Timeline
May 25, 2022:
- 11:58 PM Changeset in webkit [294872] by
-
- 1 edit in trunk/Tools/Scripts/update-angle
Generate better ChangeLogs in update-angle script
https://bugs.webkit.org/show_bug.cgi?id=238649
Patch by Kenneth Russell <kbr@chromium.org> on 2022-05-25
Auto-generate the preferred commit message format during ANGLE rolls
into a commit-message.txt file.
Reviewed by Kimmo Kinnunen.
- Tools/Scripts/update-angle:
Canonical link: https://commits.webkit.org/251002@main
- 11:08 PM Changeset in webkit [294871] by
-
- 1 edit in trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
[Soup] USE(SOUP2) build fix after 250730@main
https://bugs.webkit.org/show_bug.cgi?id=240943
Patch by Žan Doberšek <zdobersek@igalia.com> on 2022-05-25
Unreviewed build fix for USE(SOUP2), switching to string literals in a couple of
places where URL::protocolIs() is expecting them.
- Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::authenticateCallback):
(WebKit::NetworkDataTaskSoup::didStartRequest):
Canonical link: https://commits.webkit.org/251001@main
- 10:36 PM Changeset in webkit [294870] by
-
- 5 edits in trunk/Source
Unreviewed, non unified build fixes after 250949@main
- 10:21 PM Changeset in webkit [294869] by
-
- 4 edits in trunk/Tools/Scripts/libraries/reporelaypy
[commits.webkit.org] Support compare redirect
https://bugs.webkit.org/show_bug.cgi?id=240908
<rdar://problem/93904385>
Reviewed by Dewei Zhu.
- Tools/Scripts/libraries/reporelaypy/reporelaypy/init.py: Bump version.
- Tools/Scripts/libraries/reporelaypy/setup.py: Ditto.
- Tools/Scripts/libraries/reporelaypy/reporelaypy/checkoutroute.py:
(Redirector):
(Redirector.bitbucket_compare): Added.
(Redirector.trac_compare): Added.
(Redirector.github_compare): Added.
(Redirector.init): Define a compare function.
(CheckoutRoute):
(CheckoutRoute.find_newer): Add function to sort a commit pair.
(CheckoutRoute.init): Add 'compare' endpoints.
- Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkoutroute_unittest.py:
(CheckoutRouteUnittest.test_compare):
(CheckoutRouteUnittest.test_compare_trac):
Canonical link: https://commits.webkit.org/250999@main
- 9:09 PM Changeset in webkit [294868] by
-
- 2 edits in trunk/LayoutTests
Address flaky test case scroll-into-view-and-show-validation-message.html when run using WK1
https://bugs.webkit.org/show_bug.cgi?id=240875
Reviewed by Wenson Hsieh.
Address failing test case fast/forms/scroll-into-view-and-show-validation-message.html
when run using WK1. This test only fails when running WK1 and only when run
in parallel.
- LayoutTests/fast/forms/textarea-scrolled-endline-caret.html:
- LayoutTests/platform/mac-wk1/TestExpectations:
Canonical link: https://commits.webkit.org/250998@main
- 8:49 PM Changeset in webkit [294867] by
-
- 1 copy in tags/WebKit-7614.1.14.1.12
Tag WebKit-7614.1.14.1.12.
- 8:46 PM Changeset in webkit [294866] by
-
- 21 edits in trunk/Source/bmalloc/libpas
[libpas] Refactor PGM to align with libpas allocation norms and split pas_get_random
https://bugs.webkit.org/show_bug.cgi?id=240331
Reviewed by Yusuke Suzuki.
This patch touches a few major areas.
PGM did not properly align with how we returned allocation results with the rest of the code base.
We now use pas_allocation_result instead. This resulted in touching a lot of the PGM testing code.
Added numerous helper utilities to make it easier to check whether we should call into PGM.
Added config option for each heap whether PGM will be enabled or not.
Cleaned up documentation.
I split the pas_get_random into two functions (pas_get_fast_random and pas_get_secure_random).
- Source/bmalloc/libpas/Documentation.md:
- Source/bmalloc/libpas/ReadMe.md:
- Source/bmalloc/libpas/src/libpas/bmalloc_heap_config.h:
- Source/bmalloc/libpas/src/libpas/hotbit_heap_config.h:
- Source/bmalloc/libpas/src/libpas/iso_heap_config.h:
- Source/bmalloc/libpas/src/libpas/iso_test_heap_config.h:
- Source/bmalloc/libpas/src/libpas/minalign32_heap_config.h:
- Source/bmalloc/libpas/src/libpas/pagesize64k_heap_config.h:
- Source/bmalloc/libpas/src/libpas/pas_baseline_allocator_table.c:
(pas_baseline_allocator_table_get_random_index):
- Source/bmalloc/libpas/src/libpas/pas_dynamic_primitive_heap_map.c:
(pas_dynamic_primitive_heap_map_find_slow):
- Source/bmalloc/libpas/src/libpas/pas_heap_config.h:
- Source/bmalloc/libpas/src/libpas/pas_heap_config_utils.h:
- Source/bmalloc/libpas/src/libpas/pas_large_heap.c:
(pas_large_heap_try_allocate_pgm):
- Source/bmalloc/libpas/src/libpas/pas_large_heap.h:
- Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:
(pas_probabilistic_guard_malloc_allocate):
(pas_probabilistic_guard_malloc_deallocate):
(pas_probabilistic_guard_malloc_check_exists):
(pas_probabilistic_guard_malloc_get_free_virtual_memory):
(pas_probabilistic_guard_malloc_get_free_wasted_memory):
(pas_probabilistic_guard_malloc_debug_info):
(pas_probabilistic_guard_malloc_trigger): Deleted.
(pas_probabilistic_guard_malloc_can_use): Deleted.
(pas_probabilistic_guard_malloc_should_use): Deleted.
- Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h:
- Source/bmalloc/libpas/src/libpas/pas_random.h:
(pas_get_fast_random):
(pas_get_secure_random):
(pas_get_random): Deleted.
- Source/bmalloc/libpas/src/libpas/pas_segregated_shared_page_directory.c:
(find_first_eligible_consider_view):
- Source/bmalloc/libpas/src/libpas/thingy_heap_config.h:
- Source/bmalloc/libpas/src/test/IsoHeapPartialAndBaselineTests.cpp:
- Source/bmalloc/libpas/src/test/PGMTests.cpp:
(std::testPGMSingleAlloc):
(std::testPGMMultipleAlloc):
(std::testPGMErrors):
Canonical link: https://commits.webkit.org/250997@main
- 8:39 PM Changeset in webkit [294865] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.12
- 8:15 PM Changeset in webkit [294864] by
-
- 5 edits2 adds in trunk
Capturing a canvas that is not in the DOM can lead to erratic frame rates or no frame emission at all
https://bugs.webkit.org/show_bug.cgi?id=240380
Patch by Dan Glastonbury <djg@apple.com> on 2022-05-25
Reviewed by Simon Fraser.
- Source/WebCore/dom/Document.cpp:
(WebCore::Document::canvasChanged):
Schedule a rendering update whenever a canvas with out a rect needing display
preparation is added. This ensures that the prepareForDisplay is called on all
pending canvases, since this is handled in doAfterUpdateRendering.
- Source/WebCore/dom/Document.h:
Update size of RenderingUpdateState to accomodate PrepareCanvasesForDisplay.
- Source/WebCore/page/Page.cpp:
- Source/WebCore/page/Page.h:
Introduce new RenderingUpdateStep, PrepareCanvasesForDisplay, which signals that
prepareCanvasesForDisplayInNeeded() needs to be called from
doAfterRenderingUpdate(). Update size of RenderingUpdateState to accomodate
PrepareCanvasesForDisplay.
- LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-canvas-expected.txt: Added.
- LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-canvas.html:
Test that frame rate of captured video from out-of-DOM canvas is with in 25% of
the generating frame rate.
Canonical link: https://commits.webkit.org/250996@main
- 7:56 PM Changeset in webkit [294863] by
-
- 8 edits in trunk
AX: Update the isolated tree in response to dynamic aria-grabbed and aria-posinset changes
https://bugs.webkit.org/show_bug.cgi?id=240844
Reviewed by Chris Fleizach.
Added test cases to accessibility/aria-setsize-posinset.html and
accessibility/mac/aria-drag-drop.html.
- Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
- Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):
- Source/WebCore/accessibility/AXObjectCache.h:
- Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperty):
- LayoutTests/accessibility/aria-setsize-posinset-expected.txt:
- LayoutTests/accessibility/aria-setsize-posinset.html:
- LayoutTests/accessibility/mac/aria-drag-drop-expected.txt:
- LayoutTests/accessibility/mac/aria-drag-drop.html:
Canonical link: https://commits.webkit.org/250995@main
- 7:16 PM Changeset in webkit [294862] by
-
- 13 edits in trunk
Web Inspector: CSS autocomplete: suggestion hint should be the most commonly used property and not the alphabetically first one
https://bugs.webkit.org/show_bug.cgi?id=156271
<rdar://problem/25588888>
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:
(WI.CSSProperty):
(WI.CSSProperty.sortByPropertyNameUsageCount): Added.
(WI.CSSProperty._initializePropertyNameCounts): Added.
(WI.CSSProperty.prototype.update):
(WI.CSSProperty.prototype.remove):
(WI.CSSProperty.prototype.set name):
(WI.CSSProperty.prototype._updateName): Added.
Every time aWI.CSSPropertyis created/updated, increment/decrement the count of that property's
name in the global map of property name counts. When showing CSS completions for property names,
initially focus the property with the highest count (but only if the count is over 100).
- Source/WebInspectorUI/UserInterface/Base/ObjectStore.js:
(WI.ObjectStore._open):
(WI.ObjectStore.async getAllKeys): Added.
Increment theversionto add a newWI.ObjectStorefor CSS property name counts.
- Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldInitialCompletionIndex): Added.
- Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:
(WI.SpreadsheetTextField.prototype._updateCompletions):
Adddelegatemethods to adjust the initialselectedIndexwhenever completions are updated.
- Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:
(WI.CompletionSuggestionsView.prototype.set selectedIndex):
(WI.CompletionSuggestionsView.prototype.selectNext):
(WI.CompletionSuggestionsView.prototype.selectPrevious):
Make sure thedelegateis informed whenever theselectedIndexchanges, not just when selecting
the next/previous item.
- Source/WebInspectorUI/UserInterface/Base/Setting.js:
- Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
- Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
Add an experimental setting to control this behavior.
- Source/WebInspectorUI/UserInterface/Base/Utilities.js:
(Array.prototype.minIndex): Added.
Add a utility method for finding the index of the smallest item in an array.
- LayoutTests/inspector/css/css-property.html:
- LayoutTests/inspector/css/css-property-expected.txt:
- LayoutTests/inspector/unit-tests/array-utilities.html:
- LayoutTests/inspector/unit-tests/array-utilities-expected.txt:
Canonical link: https://commits.webkit.org/250994@main
- 6:56 PM Changeset in webkit [294861] by
-
- 1 edit in trunk/Source/WTF/wtf/CheckedArithmetic.h
Build fix: Don't use builtin_mul_overflow on PLATFORM(IOS_FAMILY_SIMULATOR).
https://bugs.webkit.org/show_bug.cgi?id=240937
Reviewed by Saam Barati and Alex Christensen.
The mulodi4 symbol used by clang for builtin_mul_overflow is not available.
- Source/WTF/wtf/CheckedArithmetic.h:
Canonical link: https://commits.webkit.org/250993@main
- 6:52 PM Changeset in webkit [294860] by
-
- 1 edit in trunk/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp
REGRESSION(r294381): [ Debug ] TestWebKitAPI.WebKit.CookieObserverCrash is a constant crash
https://bugs.webkit.org/show_bug.cgi?id=240595
Reviewed by Alex Christensen.
The crash is an assertion failure. The assertion ensures that WebCookieManagerProxy has no cookies observer when it gets
destroyed. The assertion was valid when it was added, since WKHTTPCookieStore does not outlive WebKit::WebsiteDataStore
(r219550), and observers will be removed when WKHTTPCookieStore is deallocated. Since r279074, WKHTTPCookieStore can
outlive WebKit::WebsiteDataStore -- it holds a weak reference to WebKit::WebsiteDataStore instead of a strong reference,
so the assertion does not hold.
- Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::~WebCookieManagerProxy):
Canonical link: https://commits.webkit.org/250992@main
- 6:48 PM Changeset in webkit [294859] by
-
- 1 edit in trunk/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNetWin.cpp
Unreviewed Windows build fix after r294852
https://bugs.webkit.org/show_bug.cgi?id=240936
- Source/WebCore/platform/network/cf/NetworkStorageSessionCFNetWin.cpp:
(WebCore::copyCookiesForURLWithFirstPartyURL):
Canonical link: https://commits.webkit.org/250991@main
- 6:36 PM Changeset in webkit [294858] by
-
- 1 edit in trunk/Source/WebKitLegacy/mac/Plugins/WebPluginDatabase.mm
Stop searching for WebKitLegacy plug-ins on iOS
https://bugs.webkit.org/show_bug.cgi?id=240923
<rdar://92748471>
Reviewed by Chris Dumez.
NPAPI plug-in support has been completely removed, but support for plugInViewWithArguments:
is being kept on macOS until one more internal user of it finishes migration to WKWebView
even though developer.apple.com says it is "unsupported in OS X v10.7 and later"
On iOS, though, there is a concern about the API we are using to get the path to
/System/Library/Internet Plug-Ins and since it is unused, let's just remove it for now.
Soon we will remove all the plug-in support code.
- Source/WebKitLegacy/mac/Plugins/WebPluginDatabase.mm:
(+[WebPluginDatabase _defaultPlugInPaths]):
Canonical link: https://commits.webkit.org/250990@main
- 6:21 PM Changeset in webkit [294857] by
-
- 1 copy in tags/WebKit-7614.1.14.1.11
Tag WebKit-7614.1.14.1.11.
- 6:20 PM Changeset in webkit [294856] by
-
- 1 copy in tags/WebKit-7614.1.14.0.11
Tag WebKit-7614.1.14.0.11.
- 6:16 PM Changeset in webkit [294855] by
-
- 26 edits in trunk/Source
USE_SYSTEM_CONTENT_PATH and USE_STAGING_INSTALL_PATH should be able to coexist
https://bugs.webkit.org/show_bug.cgi?id=240723
rdar://92000421
Reviewed by Michael Saboff.
Make it possible to build with both USE_SYSTEM_CONTENT_PATH and USE_STAGING_INSTALL_PATH
enabled. With USE_STAGING_INSTALL_PATH, all the frameworks and dylibs will be relocated
to a common "StagedFrameworks" directory, but USE_SYSTEM_CONTENT_PATH directs the build
to locate this directory at a different location, i.e. in a system content path. The
presence of USE_STAGING_INSTALL_PATH also disables all targets' current behavior of
creating symlinks into the system content path -- in this configuration, the frameworks
only need to be referenceable from their location in the StagedFrameworks directory.
Throughout this patch, there are multiple common changes to the same build settings:
INSTALL_PATH_PREFIX:
This variable adds the system content path as a prefix to products' install paths.
Leave it empty when USE_STAGING_INSTALL_PATH is set, as the effective prefix will
be baked into WK_OVERRIDE_FRAMEWORKS_DIR via WK_INSTALL_PATH_PREFIX instead.
OUTPUT_ALTERNATE_ROOT_PATH:
Define this as empty under USE_STAGING_INSTALL_PATH, since we don't need to create
the symlinks pointing into the system content path.
WK_INSTALL_PATH_PREFIX:
This variable is used to define a prefix for the override install path when using
staged frameworks. Use a different prefix under USE_SYSTEM_CONTENT_PATH. Also
remove a now-unneeded comparison against WK_MACOS_1015. WebKit doesn't support
building for versions of macOS prior to 10.15, so this *always* would evaluate to
'MACOS_SINCE_1015'.
No new tests; no behavior should be changed. (Except for output of this particular
build configuration.)
- Source/JavaScriptCore/Configurations/Base.xcconfig:
Update INSTALL_PATH_PREFIX and WK_INSTALL_PATH_PREFIX.
- Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
Update OUTPUT_ALTERNATE_ROOT_PATH.
- Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:
Update INSTALL_PATH_PREFIX.
- Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
Update WK_INSTALL_PATH_PREFIX.
- Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:
Moved the common definition of INSTALL_PATH_PREFIX here, updated WK_INSTALL_PATH_PREFIX.
- Source/ThirdParty/libwebrtc/Configurations/boringssl.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig:
Removed definition of INSTALL_PATH_PREFIX, which has been moved to Base.xcconfig. (x9)
- Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:
Avoid creating any symlinks when USE_STAGING_INSTALL_PATH is set.
- Source/WebCore/Configurations/WebCore.xcconfig:
Update INSTALL_PATH_PREFIX and WK_INSTALL_PATH_PREFIX.
- Source/WebCore/PAL/Configurations/PAL.xcconfig:
Update WK_INSTALL_PATH_PREFIX.
- Source/WebGPU/Configurations/WebGPU.xcconfig:
Update INSTALL_PATH_PREFIX, OUTPUT_ALTERNATE_ROOT_PATH, and WK_INSTALL_PATH_PREFIX.
- Source/WebInspectorUI/Configurations/Base.xcconfig:
Update WK_INSTALL_PATH_PREFIX.
- Source/WebInspectorUI/Configurations/WebInspectorUIFramework.xcconfig:
Modify the definition of INSTALL_PATH so that the "override-ness" of
WK_USE_OVERRIDE_FRAMEWORKS_DIR takes precedence over USE_SYSTEM_CONTENT_PATH. With
these two set, WebInspectorUI.framework should end up in the override path (e.g. the
StagedFrameworks directory), rather than the standard system content path location.
Also update OUTPUT_ALTERNATE_ROOT_PATH.
- Source/WebKit/Configurations/Base.xcconfig:
Update INSTALL_PATH_PREFIX.
- Source/WebKit/Configurations/BaseTarget.xcconfig:
Update WK_INSTALL_PATH_PREFIX.
- Source/WebKit/Configurations/WebKit.xcconfig:
Update OUTPUT_ALTERNATE_ROOT_PATH.
- Source/WebKit/Configurations/adattributiond.xcconfig:
Somewhat unrelated tweak -- remove WK_OVERRIDE_FRAMEWORKS_DIR from this file since
it is redundant with the definition of this setting in BaseTarget.xcconfig.
- Source/WebKitLegacy/mac/Configurations/Base.xcconfig:
Update INSTALL_PATH_PREFIX.
- Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:
Update WK_INSTALL_PATH_PREFIX.
Canonical link: https://commits.webkit.org/250989@main
- 5:47 PM Changeset in webkit [294854] by
-
- 5 edits5 adds in trunk
Sequential WebVTT cues with the same contents can be dropped
https://bugs.webkit.org/show_bug.cgi?id=240893
Reviewed by Eric Carlson.
When sequential WebVTT cues are parsed with the same contents, instead of dropping the new cue, extend its endTime of the existing cue to include the endTime of the newly parsed one.
- LayoutTests/http/tests/media/hls/hls-webvtt-flashing-expected.txt: Added.
- LayoutTests/http/tests/media/hls/hls-webvtt-flashing.html: Added.
- LayoutTests/http/tests/media/resources/hls/subtitles/flashSequence0.webvtt: Added.
- LayoutTests/http/tests/media/resources/hls/subtitles/prog_flashing.m3u8: Added.
- LayoutTests/http/tests/media/resources/hls/test-webvtt-flashing.m3u8: Added.
- LayoutTests/platform/glib/TestExpectations:
- Source/WebCore/html/track/InbandGenericTextTrack.cpp:
(WebCore::InbandGenericTextTrack::newCuesParsed):
- Source/WebCore/html/track/InbandWebVTTTextTrack.cpp:
(WebCore::InbandWebVTTTextTrack::newCuesParsed):
- Source/WebCore/html/track/TextTrack.cpp:
(WebCore::TextTrack::matchCue):
(WebCore::TextTrack::hasCue): Deleted.
- Source/WebCore/html/track/TextTrack.h:
(WebCore::TextTrack::hasCue):
Canonical link: https://commits.webkit.org/250988@main
- 5:23 PM Changeset in webkit [294853] by
-
- 1 edit in trunk/metadata/contributors.json
Add my GitHub account to contributors.json
Reviewed by Jonathan Bedard.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250987@main
- 5:13 PM Changeset in webkit [294852] by
-
- 159 edits in trunk
Make the StringView(const char*) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=240754
Reviewed by Darin Adler.
Make the StringView(const char*) constructor explicit, to encourage people to use
ASCIILiteral / ""_s. StringView::fromLatin1() is available when the caller
really has a non-string literal. In a future patch, I will make this constructor
private.
- Source/WTF/wtf/Assertions.cpp:
- Source/WTF/wtf/text/StringBuilder.h:
(WTF::StringBuilder::append):
- Source/WTF/wtf/text/StringView.h:
- Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransceiverBackend.cpp:
(WebCore::toRtpCodecCapability):
- Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp:
(WebCore::ComputedStylePropertyMapReadOnly::entries const):
- Source/WebCore/dom/DatasetDOMStringMap.cpp:
(WebCore::isValidAttributeName):
(WebCore::propertyNameMatchesAttributeName):
- Source/WebCore/dom/ViewportArguments.cpp:
(WebCore::viewportErrorMessage):
- Source/WebCore/editing/cocoa/HTMLConverter.mm:
(HTMLConverterCaches::elementHasOwnBackgroundColor):
- Source/WebCore/history/BackForwardCache.cpp:
(WebCore::canCacheFrame):
- Source/WebCore/html/URLDecomposition.cpp:
(WebCore::URLDecomposition::setPort):
- Source/WebCore/html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::checkAndCreateRegion):
(WebCore::WebVTTParser::checkAndStoreStyleSheet):
- Source/WebCore/loader/PrivateClickMeasurement.cpp:
(WebCore::PrivateClickMeasurement::parseAttributionRequest):
(WebCore::PrivateClickMeasurement::appStoreURLAdamID):
- Source/WebCore/loader/mac/LoaderNSURLExtras.mm:
(suggestedFilenameWithMIMEType):
- Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::getUnmangledInfoLog):
- Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:
(WebCore::CDMPrivateMediaSourceAVFObjC::parseKeySystem):
- Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::migrateDataToPCMDatabaseIfNecessary):
(WebKit::ResourceLoadStatisticsDatabaseStore::aggregatedThirdPartyData const):
- Source/WebKit/NetworkProcess/NetworkSchemeRegistry.cpp:
(WebKit::NetworkSchemeRegistry::shouldTreatURLSchemeAsCORSEnabled):
- Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::LocalStorageDatabaseTracker):
- Source/WebKit/NetworkProcess/cache/NetworkCacheBlobStorage.cpp:
(WebKit::NetworkCache::BlobStorage::blobPathForHash const):
- Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:
- Source/WebKit/Platform/unix/EnvironmentUtilities.cpp:
(WebKit::EnvironmentUtilities::removeValuesEndingWith):
- Source/WebKit/Shared/Cocoa/XPCEndpoint.mm:
(WebKit::XPCEndpoint::XPCEndpoint):
- Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::getProcessIdentifier):
- Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:
(API::constructedPathPrefix):
- Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h:
- Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration additionalReadAccessAllowedURLs]):
(-[_WKProcessPoolConfiguration setAdditionalReadAccessAllowedURLs:]):
- Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::createSandboxExtensionsIfNeeded):
(WebKit::WebPageProxy::isQuarantinedAndNotUserApproved):
- Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::messageSourceIsValidWebContentProcess):
- Source/WebKit/UIProcess/DeviceIdHashSaltStorage.cpp:
(WebKit::DeviceIdHashSaltStorage::deleteHashSaltFromDisk):
- Source/WebKit/UIProcess/ViewGestureController.cpp:
(WebKit::ViewGestureController::SnapshotRemovalTracker::resume):
(WebKit::ViewGestureController::SnapshotRemovalTracker::start):
(WebKit::ViewGestureController::SnapshotRemovalTracker::fireRemovalCallbackImmediately):
(WebKit::ViewGestureController::SnapshotRemovalTracker::watchdogTimerFired):
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder):
- Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::resolvePathsForSandboxExtensions):
- Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplication):
- Source/WebKit/UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::shouldAllowNonValidInjectedCode const):
- Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetDatabaseQuota):
- Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::tryLoadingUsingPDFJSHandler):
- Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::streamDidReceiveResponse):
- Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::dumpHistoryItem):
- Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldUsePDFPlugin const):
(WebKit::WebPage::platformCanHandleRequest):
- Source/WebKit/webpushd/AppBundleRequest.mm:
(WebPushD::AppBundleRequest::start):
- Source/WebKit/webpushd/PushClientConnection.mm:
(WebPushD::ClientConnection::connectionClosed):
- Source/WebKit/webpushd/WebPushDaemon.mm:
(WebPushD::Daemon::broadcastAllConnectionIdentities):
(WebPushD::Daemon::injectPushMessageForTesting):
(WebPushD::Daemon::injectEncryptedPushMessageForTesting):
- Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm:
(regExpForLabels):
(matchLabelsAgainstString):
- Tools/DumpRenderTree/mac/DumpRenderTree.mm:
(changeWindowScaleIfNeeded):
- Tools/TestWebKitAPI/Tests/WTF/FileSystem.cpp:
(TestWebKitAPI::TEST_F):
- Tools/TestWebKitAPI/Tests/WTF/SortedArrayMap.cpp:
(TEST):
- Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
(TestWebKitAPI::doStaticStringImplTests):
- Tools/TestWebKitAPI/Tests/WTF/StringToIntegerConversion.cpp:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WTF/StringView.cpp:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WTF/URL.cpp:
(TestWebKitAPI::TEST_F):
- Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp:
(TestWebKitAPI::invalidParts):
(TestWebKitAPI::shouldFail):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::testUserPassword):
- Tools/TestWebKitAPI/Tests/WTF/UUID.cpp:
(TEST):
- Tools/TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::TEST_F):
- Tools/TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
(TestWebKitAPI::TEST_F):
- Tools/TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
(TestWebKitAPI::buildDFAFromPatterns):
- Tools/TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
(TestWebKitAPI::TEST_F):
- Tools/TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
(TestWebKitAPI::readContentsOfFile):
- Tools/TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
(TestWebKitAPI::testStrip):
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
(TEST):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
(TEST):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/FTP.mm:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm:
(TEST):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
(TEST):
(runMultipleIndicesTestWithDatabase):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
(TEST):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm:
(TEST):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
- Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
(TEST):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
(TestWebKitAPI::parseUserAgent):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaSession.mm:
(TestWebKitAPI::TEST_F):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/PrivateClickMeasurement.mm:
(addAttributedPCMv2):
(addUnattributedPCMv2):
(addAttributedPCMv3):
(addUnattributedPCMv3):
(addUnattributedPCMv4):
(addAttributedPCMv4):
(addAttributedPCMv5):
(createAndPopulateObservedDomainTable):
(createAndPopulatePCMObservedDomainTable):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
(-[ServiceWorkerSchemeHandler webView:startURLSchemeTask:]):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
- Tools/TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
(TEST):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WebSocket.mm:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(ParsedRange::ParsedRange):
- Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFinishProgress):
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
(WTR::InjectedBundlePage::didRunInsecureContentForFrame):
(WTR::InjectedBundlePage::didDetectXSSForFrame):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::supportsFullScreen):
(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):
(WTR::InjectedBundlePage::beganEnterFullScreen):
(WTR::InjectedBundlePage::beganExitFullScreen):
(WTR::InjectedBundlePage::closeFullScreen):
- Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::configureContentExtensionForTest):
- Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::urlContains const):
(WTR::TestInvocation::shouldLogHistoryClientCallbacks const):
- Tools/WebKitTestRunner/TestInvocation.h:
- Tools/WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::configureContentExtensionForTest):
Canonical link: https://commits.webkit.org/250986@main
- 4:50 PM Changeset in webkit [294851] by
-
- 1 edit in branches/safari-613-branch/Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
Cherry-pick 1a810ee6f98a. rdar://problem/87980543
Unreviewed build fix. rdar://87980543
Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:247:36:|error: no matching constructor for initialization of 'WebCore::FEImage::SourceImage &&' (aka 'variant<Ref<WebCore::Image>, Ref<WebCore::ImageBuffer>, ObjectIdentifier<WebCore::RenderingResourceIdentifierType>> &&')
Canonical link: https://commits.webkit.org/245886.575@safari-7613.3.1.1-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-7613.3.1.1-branch@294732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [294850] by
-
- 7 edits in branches/safari-613-branch/Source
Cherry-pick a173819be243. rdar://problem/87980543
Cherry-pick r294280. rdar://problem/87980543
This reverts r294684.
Canonical link: https://commits.webkit.org/245886.574@safari-7613.3.1.1-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-7613.3.1.1-branch@294731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [294849] by
-
- 1 edit in branches/safari-613-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
Cherry-pick 589c2b5478bb. rdar://problem/92780272
Apply patch. rdar://problem/92780272
Canonical link: https://commits.webkit.org/245886.563@safari-7613.3.1.1-branch
git-svn-id: https://svn.webkit.org/repository/webkit/branches/safari-7613.3.1.1-branch@294055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [294848] by
-
- 6 edits2 adds in branches/safari-613-branch
Cherry-pick f5e42d63fc9. rdar://problem/93601919
Expose the correct role, subrole and role description properties for the <dialog> element.
https://bugs.webkit.org/show_bug.cgi?id=236359
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/dialog-properties.html
Elements with role="dialog" are exposed to accessibility clients with
role AXGroup, subrole AXApplicationDialog and role description
"web dialog". This patch implements this behavior for the <dialog>
element.
- accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const):
LayoutTests:
Tests that these AX properties have the expected values both when the
dialog is shown modal or modeless.
- accessibility/dialog-properties-expected.txt: Added.
- accessibility/dialog-properties.html: Added.
Canonical link: https://commits.webkit.org/247198@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [294847] by
-
- 1 edit in branches/safari-613-branch/Source/JavaScriptCore/b3/B3ReduceStrength.cpp
Cherry-pick 6983e76741a1. rdar://problem/93536782
Refine B3ReduceStrength's range for sign extension operations.
https://bugs.webkit.org/show_bug.cgi?id=240720
<rdar://problem/93536782>
Reviewed by Yusuke Suzuki and Keith Miller.
- Source/JavaScriptCore/b3/B3ReduceStrength.cpp:
Canonical link: https://commits.webkit.org/250808@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:50 PM Changeset in webkit [294846] by
-
- 4 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r293094. rdar://problem/91683009
Some AutoscrollController cleanup
https://bugs.webkit.org/show_bug.cgi?id=239512
Reviewed by Alan Bujtas.
Have AutoscrollController store a WeakPtr to the render object. Address an apparent
null de-ref in AutoscrollController::stopAutoscrollTimer() where the Frame can null.
Refactor updateDragAndDrop() with a lambda so that all the code paths that exit early
clearly call stopAutoscrollTimer() which nulls out the renderer.
- page/AutoscrollController.cpp: (WebCore::AutoscrollController::autoscrollRenderer const): (WebCore::AutoscrollController::startAutoscrollForSelection): (WebCore::AutoscrollController::stopAutoscrollTimer): (WebCore::AutoscrollController::updateAutoscrollRenderer): (WebCore::AutoscrollController::updateDragAndDrop): (WebCore::AutoscrollController::startPanScrolling):
- page/AutoscrollController.h:
- page/EventHandler.cpp: (WebCore::EventHandler::startPanScrolling):
Canonical link: https://commits.webkit.org/249805@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [294845] by
-
- 4 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r292596. rdar://problem/88862115
Take top layers into account in addLayers/removeLayers
https://bugs.webkit.org/show_bug.cgi?id=238946
Patch by Rob Buis <rbuis@igalia.com> on 2022-04-08
Reviewed by Simon Fraser.
Take top layers into account in addLayers/removeLayers, they
should use the RenderView layer as parent (emulating layerParent).
- rendering/RenderElement.cpp: (WebCore::addLayers): (WebCore::RenderElement::addLayers): (WebCore::RenderElement::removeLayers): (WebCore::RenderElement::willBeRemovedFromTree):
- rendering/RenderElement.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects const):
Canonical link: https://commits.webkit.org/249429@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [294844] by
-
- 8 edits in branches/safari-613-branch
Cherry-pick r294234. rdar://problem/93602100
Web Inspector: Regression(r266885) Crash sometimes when rehydrating imported audit results
https://bugs.webkit.org/show_bug.cgi?id=240366
Reviewed by Devin Rousso.
Source/JavaScriptCore:
- inspector/protocol/DOM.json:
Source/WebCore:
Added test cases to inspector/model/dom-node.html
After r266885, there is no path to handle the possibility that there may not be a resulting node for calls to
DOM.querySelector. To correct this, mark the return value as optional (Web Inspector frontend already treats
it as optional) and return early if there was no Element matching the selector.
- inspector/agents/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::querySelector):
- inspector/agents/InspectorDOMAgent.h:
LayoutTests:
- inspector/model/dom-node.html:
- inspector/model/dom-node-expected.txt:
Canonical link: https://commits.webkit.org/250592@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [294843] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r293922. rdar://problem/93602176
null ptr deref in WebCore::Frame::setPrinting
https://bugs.webkit.org/show_bug.cgi?id=240173
Reviewed by Wenson Hsieh.
Check m_doc in Frame::setPrinting before access, as it is a RefPtr that can become null.
- page/Frame.cpp: (WebCore::Frame::setPrinting):
Canonical link: https://commits.webkit.org/250369@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [294842] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r293857. rdar://problem/93602013
Remove unnecessary calls to CachedResource::updateBuffer and CachedResource::updateData
https://bugs.webkit.org/show_bug.cgi?id=240126
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-05
Reviewed by Chris Dumez.
It adds a function call that does nothing but a redundant assert.
- loader/cache/CachedImage.cpp: (WebCore::CachedImage::updateBufferInternal): (WebCore::CachedImage::updateBuffer): (WebCore::CachedImage::updateData):
Canonical link: https://commits.webkit.org/250322@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [294841] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r293827. rdar://problem/92624773
replaceTrack with different constraints stops sending packets
https://bugs.webkit.org/show_bug.cgi?id=239978
<rdar://problem/92624773>
Reviewed by Eric Carlson.
We should always reconfigure the microphone processor even if we are not using it,
as VPIO expects that input and output formats should match.
Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
so that we can write a regression test.
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
Canonical link: https://commits.webkit.org/250300@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [294840] by
-
- 4 edits2 adds in branches/safari-613-branch
Cherry-pick r293819. rdar://problem/93602086
Crash in WindowProxy::setDOMWindow
https://bugs.webkit.org/show_bug.cgi?id=232763
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-04
Reviewed by Chris Dumez.
Source/WebCore:
Add a few null checks here and there.
Test: fast/dom/set-dom-window-without-page.html
- bindings/js/WindowProxy.cpp: (WebCore::WindowProxy::setDOMWindow):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::findFrameForNavigation):
LayoutTests:
- fast/dom/set-dom-window-without-page-expected.txt: Added.
- fast/dom/set-dom-window-without-page.html: Added.
Canonical link: https://commits.webkit.org/250292@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [294839] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r293728. rdar://problem/92362769
Fix buggy assert in CoreAudioSharedUnit::configureSpeakerProc
https://bugs.webkit.org/show_bug.cgi?id=240001
Reviewed by Eric Carlson.
Manually tested.
- platform/mediastream/mac/CoreAudioCaptureSource.cpp: Initialize the sampleRate field before using it.
Canonical link: https://commits.webkit.org/250216@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [294838] by
-
- 3 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r293664. rdar://problem/92362769
VPIO requires the same sample rate for microphone and speaker formats
https://bugs.webkit.org/show_bug.cgi?id=239956
Reviewed by Eric Carlson.
VPIO requires the speaker sample rate and microphone sample rate to be the same.
This is not guaranteed to be true : getUserMedia/applyConstraints may set the microphone sample rate to different values.
If audio rendering already started at capture start time, we use the audio rendering sample rate.
This is not strictly compliant, given required constraints but they are not widely used.
Applications that want to make sure to use a specific sample rate would need to pause audio rendering when starting to capture.
We reset exposed settings when starting to capture to expose the actual sample rate to JavaScript through MediaStreamTrack.getSettings().
Manually tested.
- platform/mediastream/mac/BaseAudioSharedUnit.h:
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
Canonical link: https://commits.webkit.org/250168@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [294837] by
-
- 3 edits in branches/safari-613-branch/Source/ThirdParty/libwebrtc
Cherry-pick r293643. rdar://problem/92445366
[Mac] VTVideoDecoderClass object pointers can become unaligned on x86
https://bugs.webkit.org/show_bug.cgi?id=239916
<rdar://92445366>
Reviewed by Eric Carlson.
Both the base class and the derived class must be 4-byte aligned on x86, or there
is a chance that a pointer member of that struct will cross a page boundary, and
dereferencing that pointer will fail.
- Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
- Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
Canonical link: https://commits.webkit.org/250147@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:49 PM Changeset in webkit [294836] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r293147. rdar://problem/93601944
Skip release assert during container query resolution
https://bugs.webkit.org/show_bug.cgi?id=239537
Patch by Rob Buis <rbuis@igalia.com> on 2022-04-21
Reviewed by Antti Koivisto.
Skip release assert during container query resolution
since resolveStyle will be a no-op as the container
query resolution was started in resolveStyle, so calling
resolveStyle the second time will bail right away.
- dom/Document.cpp: (WebCore::Document::updateStyleIfNeeded):
Canonical link: https://commits.webkit.org/249843@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:42 PM Changeset in webkit [294835] by
-
- 1 edit in trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
Avoid extracting the main video in element fullscreen when fullscreen mode isn't active
https://bugs.webkit.org/show_bug.cgi?id=240910
rdar://93906888
Reviewed by Eric Carlson.
Add a check that we're actually still in element fullscreen before extracting the main video. Since
WebFullScreenManagerand itsm_elementboth persist after exiting fullscreen mode, there's
currently nothing preventing us from re-triggering video extraction when a video is paused once
again outside of fullscreen mode.
Covered by a new API test (more details in the bug).
- Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::handleEvent):
(WebKit::WebFullScreenManager::mainVideoElementExtractionTimerFired):
Deal with another corner case, wherein the main video element we previously detected may no longer
be in the fullscreen element's subtree by the time that the extraction timer fires. To avoid this,
always update the main video element again when the extraction timer is fired (as long as we're
still in fullscreen mode), before proceeding with extraction.
Canonical link: https://commits.webkit.org/250985@main
- 4:27 PM Changeset in webkit [294834] by
-
- 534 edits4 copies6 moves22 adds2 deletes in trunk/Source/ThirdParty/ANGLE
Update ANGLE to 2022-05-24 (8291f2d3e72eca3a25826b689a013c292ef4ba94)
https://bugs.webkit.org/show_bug.cgi?id=240894
Patch by Kenneth Russell <kbr@chromium.org> on 2022-05-25
Reviewed by Kimmo Kinnunen.
Contains upstream commits:
8291f2d3e Fix ValidCompressedSubImageSize for 3D uploads
84a0b462d Vulkan: Bug fix in GL_QCOM_shading_rate
1afb80587 Add Vulkan backend support for texture labels
7a243dbe2 Capture/Replay: Allow repeated Gen-on-Bind for resources
7df1f5816 GN: Add angle_build_tests.
11e9c8351 Vulkan: Dump graphics pipeline cache graph
2f0b6429b Revert "util/X11Window: Set PMinSize and PMaxSize hints."
cd48eedd9 Roll Chromium from 99a468a0505d to d624307d6d25 (438 revisions)
35e54dbb6 Vulkan: Fix EXT_texture_buffer support condition
f6c149339 dEQP: Support Wayland
6e2588639 Vulkan: Use packed enum for present modes
9e0a7be6c Traces: Update restricted_trace_perf.py
2ae8bdb3a Roll vulkan-deps from 880c9e0050c6 to 82a65519c521 (5 revisions)
80be1bb38 Roll SwiftShader from 73679602bc0b to b5cb037f0292 (2 revisions)
2db4297ad Roll Chromium from f0d8ec07c77f to 99a468a0505d (698 revisions)
e4a517c92 Vulkan: Rearrange GraphicsPipelineDesc to reduce footprint
f52c629b9 Capture/Replay: Make sure replay tests build libEGL
0b808c746 Silence all std::iterator deperecation warnings
bb3afdf42 Drop support for 64xMSAA+
688553c03 Vulkan: Dynamic state for primitive restart enable
c76fb2d82 Enable EXT_texture_norm16 on ES2/D3D11
3b78e0d56 Vulkan: Dynamic state for depth bias enable
7c83a3635 Vulkan: Dynamic state for rasterizer discard enable
2faabfe5e Vulkan: Optimize pipeline desc w.r.t dynamic state
ee1894e5f Account for GL_ANGLE_yuv_internal_format when setting yuv state
3da24b5cd Move trace loader code to a common location.
52c42e5a8 Temporarily disable deprecation warnings for VK-GL-CTS
88f582f6a D3D: fix whole-array assignment to SSBOs.
f8e8b7cc3 Roll vulkan-deps from c37d1e2ab98c to 880c9e0050c6 (19 revisions)
8af51b7ef Roll SwiftShader from 2933d3126969 to 73679602bc0b (4 revisions)
c3687f079 Roll Chromium from 170d12460fd5 to f0d8ec07c77f (430 revisions)
58fd31577 Vulkan: Dynamic state for vertex stride
e71a3e5fa Insert Metal polyfill for Matrix /= Scalar when needed
78ea85213 Suppress Flaky Tests
af869f4ac Update capture replay expectation file
118a6484c Metal: Upstream buffer cache fix from WebKit
f674e501f Tests: Add Bridge Constructor Portal trace
728dea2be Suppress Vulkan Validation Error
40269f91c Fix trigger.py to run mb.py with python3
c7182af2b Vulkan: Reserve varying for xfb if pre-rotation is enabled
86074fc77 Roll Chromium from dbb1f3a2b2f7 to 170d12460fd5 (586 revisions)
54a6b76f6 Roll third_party/rapidjson/src/ 7484e06c5..781a4e667 (156 commits)
2fd7444bc Fetch gn binary for the correct architecture on linux.
06fa297b6 Roll SwiftShader from cb4fc6d02fe4 to 2933d3126969 (1 revision)
6ae0c3214 Vulkan: clamp dynamic line width to supported values
d3eb61d4a D3D11: fix SSBO load in a return statement.
28dfa45d6 Spawn via vpython when old module detected.
b7474d0ae D3D11: Add GL_EXT_texture_buffer support
87ea0c7df Vulkan: SPIR-V Gen: Apply Flat to gl_Layer in FS
8701f53a4 Vulkan: Fix clear value for incomplete MS textures
dbeba9004 Reland "CGL, MTL: pbuffer for IOSurface fails for some formats"
b4ec8eac5 D3D11: implement image load/store for non-compute shaders.
2fdd7bfd1 Vulkan: Support binding 2D slice of a 3D texture to an image unit
14ca09bcf Metal: Remove the long type from program preludes
ff011779c Vulkan: Let texture buffer handle BufferVk's storage change
3d430f5f3 Vulkan: Add test for texture buffer and buffer data interaction
2abf9adf6 Vulkan: Bug fix in YUV descriptor pool allocation
78b8f5467 Roll SwiftShader from 89eb09307fbc to cb4fc6d02fe4 (1 revision)
428cd884e Tests: Add Stardew Valley trace
5e34541a1 Roll SwiftShader from 4011ab35f3d8 to 89eb09307fbc (3 revisions)
4dc9c79e0 Roll Chromium from 73ffbbeac851 to dbb1f3a2b2f7 (503 revisions)
c649979b7 Create EGLImage from VkImage correctly with non sized format
cd4cce3f8 Add more tips about recovering the qpa file.
957a44f41 Clarify that angle_debug_package is necessary to load the apk
93c0c90db Suppress the failing egl test to unblock roller
a277f1bce Vulkan: Fix Wayland surface size queries
6136ba273 D3D: minor cleanup of gl::RangeUI usage.
4ece3b08f Vulkan: Multiple DRM formats
d75bf9ad0 Capture/Replay: Also limit the number of per shader SSBOs
552b01d15 Roll vulkan-deps from 131de3fd9ec7 to c37d1e2ab98c (2 revisions)
7d7ed2538 Roll Chromium from 11b60f867851 to 73ffbbeac851 (445 revisions)
807c94ea8 Capture/Replay: Adjust tests do adhere to capture limits
891a46820 Vulkan: Dynamic state for stencil test/op
66dcca5e5 Vulkan: Dynamic state for depth test/write/op
bedb3075b Do not call RendererVK::handleDeviceLost() for device lost
15ecf068e Vulkan: Dynamic state for depth bounds
20820bb4b Make BitSetArray constexpr
36f5e6ce5 Vulkan: Fix DRM to GL format conversion
1cbcc1da1 Roll vulkan-deps from c6a60f3cc711 to 131de3fd9ec7 (22 revisions)
459c367ed D3D: Initialize storage after generating mipmap images.
ed909ee8a Roll SwiftShader from f1c2c0b07281 to 4011ab35f3d8 (1 revision)
7f14dd79b Roll Chromium from 3aa3e39b0aca to 11b60f867851 (666 revisions)
48b1f07b0 Vulkan: Dynamic state for front face
4e5da2d28 Vulkan: Dynamic state for cull mode
62fe36d3b Vulkan: Emulate YUV built-ins
4b95ac7df Vulkan: Don't invalidate pipeline on dynamic state change
81c84292f Do not do cleanup for Vulkan device lost
808192a74 Code Cleanup
87058cb8a Re-skip flaky test un-skipped by crrev.com/c/3641181
1b434e96b Skip flaky test on Mac NVIDIA.
4a7dd9429 Metal: Fix dangling pointer warning in IntermRebuild.cpp
e56f227d6 Vulkan: Add case: TextureSampleByDrawDispatchDraw
ece8fb5df Roll vulkan-deps from b768d03422ea to c6a60f3cc711 (1 revision)
03ccd9cc9 Revert "Vulkan: Flush texture updates more often"
21ad9b3c8 Vulkan: Add generic descriptors for DS cache.
d8d396dbc Vulkan: Add shared descriptor set caches.
0f2fc7664 TracePerfTest: Add ability to screenshot after reset.
7dc316c8f Roll Chromium from 65b23f3c9e05 to 3aa3e39b0aca (497 revisions)
8bb7c35c2 Vulkan: Flush texture updates more often
addfab1f7 Update docs for SwANGLE triage process.
8e844d0ff Tests: Add Black Desert Mobile trace.
389ae6b9a Add extension for read-only DS feedback loops.
40583b0f9 Tests: Skip pubg_mobile_skydive on Nvidia
4df8ca04f Remove angle_util from restricted traces.
580f90c7d Test Runner: Accept Chromium bot mode flag.
73cb1e6e2 Vulkan: Tag dynamic dirty bits with DYNAMIC
4ffab3bf5 Vulkan: Dynamic state for stencil reference
3d55cf0c0 Vulkan: Optimize the vkImage layout when used as GL_image
7e9e597ea Roll SwiftShader from e0a1188d7652 to f1c2c0b07281 (2 revisions)
8ec7b8b87 Roll Chromium from 693c7419bd5c to 65b23f3c9e05 (580 revisions)
1d8227dab Vulkan: Dynamic state for stencil write mask
c3def6fab Vulkan: Dynamic state for stencil compare mask
e9dc0f86d Cleanup from glBlitFramebuffer() 3D texture fix.
dcaa18b9c Vulkan: Dynamic state for blend color
536d6f57e Vulkan: Dynamic state for depth bias
42789b630 Use GLTexture in TextureTest for RAII goodness.
780f1a41b Vulkan: Dynamic state for line width
9b15e1c23 D3D11: clean up ES31 test expectations.
f6610106f Add a draw call perf test for changing a single uniform.
e73121b19 Vulkan: Fix VulkanPipelineCachePerfTest
dd9b4afe5 D3D: minor cleanup for image load/store.
1fa4442ba Vulkan: Set dynamic state after binding pipeline
089f2871b PerfTests: Add support for eglCreateImage and eglDestroyImage
5b623dd4b D3D9: Enable OES_fbo_render_mipmap
25ebc3b86 Roll vulkan-deps from 27ef4a0d9701 to b768d03422ea (7 revisions)
eea6366c7 Roll SwiftShader from e4a6f2d74d3c to e0a1188d7652 (1 revision)
029a4c948 util: Add calls for createImage* and destroyImage* to GLWindow
486ae89e4 Roll Chromium from 46c13be19f0f to 693c7419bd5c (567 revisions)
a8ebdf2b5 Basis Universal Texture Experiment
6ddbfa397 Metal: Log the shader source when a shader fails to translate
52904367d D3D: Mark images clean after syncing from storage
f1640db8c Fix crash when calling certain gl APIs before initialization.
66b9214fb Capture/Replay: rename ANGLE_CAPTURE to ANGLE_CAPTURE_GL
2fb58a95b Re-land: "Vulkan: GBM platform"
4ecb1e3e6 Vulkan: Support wide lines
18089dff2 Vulkan: Clean up flag passing in ImageView init.
8e1215716 D3D11: fix 3D texture blits.
464f30f4e Vulkan: Refactor UtilsVk dynamic state handling
86d9d66dc Vulkan: Determined sized-ness of format in initImageViews.
9872c1d63 Switch deqp merge to python3
5fa8f9045 Roll vulkan-deps from 626b2fd72bde to 27ef4a0d9701 (2 revisions)
c8c2664af Roll SwiftShader from 1dd93361b1d9 to e4a6f2d74d3c (2 revisions)
6bf0e620a Roll Chromium from 7f78f00fdc5c to 46c13be19f0f (273 revisions)
2b8172b9b Vulkan: Add missing initialization for mTotalMemorySize
31321cb73 Vulkan: Remove suppressions and workarounds for old AMD/Windows
0db4c39b5 Revert "Vulkan: GBM platform"
26a2e1471 Roll Chromium from bc117969dbb5 to 7f78f00fdc5c (162 revisions)
d4442f538 Reset the program executable if async linking fails.
825d5b2c5 Vulkan: GBM platform
0b0744f3e Vulkan: Fix VVL error for black desert mobile
b51bbe246 Add CopyTextureTest.ClearAfterCopySubTexture
b54b11460 Vulkan: Use ImageView layer count functions in TextureVk.
c8c4109cd HLSL: Disambiguate functions that have int/uint parameters.
e1de0950d Vulkan: Always init image views using image format.
8b4e74127 Roll SwiftShader from 74e34ab97aeb to 1dd93361b1d9 (3 revisions)
78d88796b Roll Chromium from 333c8248b125 to bc117969dbb5 (506 revisions)
e316203a6 Vulkan: add forceContinuousRefreshOnSharedPresent feature
225d8f83a Tests: Add Mortal Kombat App Trace
fa4523cf2 Roll vulkan-deps from 4ca7acf89869 to 626b2fd72bde (22 revisions)
cadb933fd Roll Chromium from 3bc34dd4d819 to 333c8248b125 (124 revisions)
1d073482a Tests: Add Basemark GPU trace
38a53d654 Revert "Remove limit_max_texture_size_to_4096 workaround"
bec809fe9 [Fuchsia] Download the gn sdk instead of core
5f2ad1537 Tests: Add Puzzles and Survival trace
b33d15556 Roll VK-GL-CTS from 106df4122297 to acf70aaf3fdb (12 revisions)
950db602b Roll SwiftShader from 643179694ec7 to 74e34ab97aeb (7 revisions)
dbbfac650 Tests: Add Monument Valley trace
b365a6069 Tests: Add Dead Cells trace
72cc8cbca Migrate Fuchsia sdk checkout from using script to CIPD
e0d00563f Vulkan: Simplify external format Chroma code.
51d6a1d96 Roll Chromium from 617cd3226543 to 3bc34dd4d819 (40 revisions)
a78eca2ca util/X11Window: Set PMinSize and PMaxSize hints.
332c9ad04 Roll Chromium from 7a60295b6324 to 617cd3226543 (278 revisions)
1d5d09e41 Vulkan: Prefer MAILBOX over IMMEDIATE present mode
d075dfe25 Vulkan: Reduce kMaxBufferToImageCopySize to 64M
333da2cf1 Vulkan: Limit the total bytes of suballocation garbages in flight
98488a196 FramebufferTest: Add FramebufferChangeTest test.
b79178a3e Scripts: Strip prebuilt debug APK from AOSP roll
8dcba9ae6 Roll Chromium from 1c301e690de1 to 7a60295b6324 (184 revisions)
51dc3c3e6 Vulkan: Force prune when there are lots of suballocations destroyed
bcc03bd62 Remove limit_max_texture_size_to_4096 workaround
2fae9482c Vulkan: Use heuristic to decide how many empty buffers to keep
0afa5b9f9 Tests: Add Alto's Odyssey trace.
2ce60b52a Fixes for C++20 support.
3f216ee74 Vulkan: Set timeout for MultiContextDrawWithSwap*
bd44b29d2 Roll Chromium from 6db3a94387ed to 1c301e690de1 (550 revisions)
d73468673 Decommission win7-x86-amd and win7-x64-nvidia
9865ed8b8 Check in build files needed.
9053a641b Vulkan: Wayland dmabuf extensions
77cd0b5a3 Re-land: "Vulkan: Cache ImageView serials on texture changes."
b72cff8c0 Fix build flags not in declare_args when angle_has_build is true
14c483f1c Presubmit: Verify comment before new tests
dc1ab34c9 Roll SwiftShader from cdf43bd816d7 to 643179694ec7 (4 revisions)
34fb4f790 Roll Chromium from 55c89a3a09ac to 6db3a94387ed (508 revisions)
edd331ebe Traces: Add a device arg to restricted_trace_perf
a7238b525 Consolidate handle list before pushing to mReleasedList
064fc64aa infra: Remove some slow *SAN tests.
9ab470749 D3D11: fix BufferToTexture copy when UNPACK_ROW_LENGTH is set.
9ad43bdd2 Re-land: "Vulkan: Support Wayland"
5c9f676d3 Basis Universal Texture Experiment
84e42c3b0 Fix validation cache when deleting a Transform Feedback.
b5f0fd1bd Skip flaky tests on Win ASAN
c0942c2d4 Roll vulkan-deps from 1cde45b8d7aa to 4ca7acf89869 (6 revisions)
c92d69d7d Roll SwiftShader from adef92e7b4c6 to cdf43bd816d7 (8 revisions)
4bbc55f4c Revert "Re-land: "Vulkan: Support Wayland""
58526dea2 Roll Chromium from 929311ac6298 to 55c89a3a09ac (470 revisions)
5113ae8ef Vulkan: Explicitly enable per-sample shading ifsampleused
9200ba537 Reland "Make SPIRV optional for Metal backend"
802504add Vulkan: Add log for buffer pool stats
4d26c66d0 Vulkan: Call cleanupGarbage only if mLastCompletedQueueSerial changed
527557b9c Fix ValidateFramebufferTextureLayer for cubemap arrays
e6662832a Re-land fixing of commit ID for Android builds.
3e05b93af Vulkan: MSAA swapchain resolve based on renderArea
c6e6e284e Update Android deqp and end2end sharding
237479a27 Fix presubmit following https://crrev.com/c/3611486
bc929e6e5 D3D11: recompile all shaders using 10.0.20348.0 toolchain.
b953bc13e Tests: Add GFXBench Tessellation trace
f7615d0ad OpenGL: Add allow_astc_formats workaround
4dc4c0f05 Remove whitespace from features json files
df163d714 Test both MSL translators in APPLEClipDistanceTest
06fa7e39a Expand Intel GPU detection
e0dd196a0 Re-land: "Vulkan: Support Wayland"
ea9a2dbea Capture/Replay: handle glGetVertexAttrib parameter value
41adabc48 Use app data dir instead of /sdcard for writing qpa file
5b4f180cd Fix formatting
f1c5e2b11 Roll vulkan-deps from 7b51f5f85aad to 1cde45b8d7aa (4 revisions)
fd57d8f0c Roll Chromium from 3a1ff9044aec to 929311ac6298 (541 revisions)
e55990e35 Capture/Replay: Handle arrays with uniform block indices
1aa4c120d gl_tests: Fix formatting
c7a9f0c6c Vulkan: Remove syncval suppressions no longer triggering
e39dfe0fe Roll VK-GL-CTS from a22069b4e3b7 to 106df4122297 (1 revision)
3eb2bcf77 Vulkan: Fix syncval errors with DONT_CARE for unused attachments
3eb891960 Roll Chromium from 1e97e6cd1c3c to 3a1ff9044aec (639 revisions)
31f841386 Add option for Metal output to angle_shader_translator
394fb0d34 Vulkan: Don't take lock for getLastCompletedQueueSerial
5e4c141c2 Tests: Add GFXBench Driver Overhead 2 trace
7184fe38c Tests: Add Jetpack Joyride trace.
8b26c14c0 Roll SwiftShader from b92f7acb7e81 to adef92e7b4c6 (4 revisions)
2d3ad8ec6 Roll vulkan-deps from 1963b94c99e8 to 7b51f5f85aad (4 revisions)
1c4c9fe95 Capture/Replay: Fix formatting
2c58e7a5b Reduce console spam from Metal shader translation
437053a16 Revert "Make SPIRV optional for Metal backend"
f9729598a Revert "Fix commit ID gathering on Android builds."
c1d0e139d Roll vulkan-deps from 4f93dbdc6060 to 1963b94c99e8 (2 revisions)
d5ceba0b4 Roll SwiftShader from f88fc3b53c52 to b92f7acb7e81 (3 revisions)
3e4069290 Roll Chromium from c7e51a124fab to 1e97e6cd1c3c (915 revisions)
2a6e123b1 Vulkan: Move pruneOrphanedBufferBlocks to last
266111a55 Vulkan: Fix SemaphoreCount best practice warning
1ef90012b Vulkan: Remove API access for mTotalBufferToImageCopySizen
454efd1d5 Add forceDepthAttachmentInitOnClear frontend workaround
29287e1fc Make SPIRV optional for Metal backend
3b65b8037 Vulkan: Work around Qualcomm imprecision with dithering
6c2486918 Enable SINGLE_BUFFER with eglCreateWindowSurface
1835e5d89 Fix commit ID gathering on Android builds.
c9794d6c0 Run a smoke test in each shard and crash on timeouts.
80d50b992 Add build arg to automatically attach renderdoc
7d31a47fc Vulkan: Optimize away eglSwapBuffers for single buffer surfaces
5c756bc1a Perf Tests: Compute GPU time periodically
c402f002b Android perf tests shards 20->6 (only --smoke-test-mode)
6930184ef Log runTests so that it shows up in logcat dumps.
c45aff4f2 Roll SwiftShader from 5f5faa3a2aad to f88fc3b53c52 (4 revisions)
cc834907f Roll vulkan-deps from f685346e2e51 to 4f93dbdc6060 (2 revisions)
95c1ff52b EGL: Fix EGL_KHR_mutable_render_buffer
0c59b5d90 Log debuggerd $PID output when instrumentation gets stuck.
fe2c82ad3 check integer overflow in Texture copyImage
cdcf17153 Add missing result_skip and result_fail.
1a144edfe Metal:ReadPixels AMD Copy Texture to Buffer optimization
6b9c5c8d1 Vulkan: Improve GetStorageMemoryType logic
cbdefd933 Roll chromium_revision 192db13f85..c7e51a124f (995097:996181)
d0c8363e0 Dump logcat if instrumentation doesn't finish in 10 minutes.
ebfb9b9f0 Configure logging in perf and gold tests to include time.
7555a1590 DEPS: Remove deprecated chromium dep
fc8282875 Tests for Nvidia/Vulkan bugs with tessellation control
Canonical link: https://commits.webkit.org/250984@main
- 4:24 PM Changeset in webkit [294833] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
[Gardening]: [ iOS Debug ] resize-observer/resize-observer-with-zoom.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=240929
<rdar://93934172>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250983@main
- 3:57 PM Changeset in webkit [294832] by
-
- 19 edits in trunk/Source/WebCore/platform/graphics
[GPU Process] [Filters] Don't use Uint8ClampedArray in software filter appliers
https://bugs.webkit.org/show_bug.cgi?id=240777
rdar://93916935
Reviewed by Simon Fraser.
The plan is to allocate the FilterImage buffers differently for GPUProcess. The
first step is to hide the underlying memory of PixelBuffer from the software
filter appliers. Helpers functions will provide access to Uint8ClampedArray. In
future patches different memory allocation will be used by new sub-classes of
PixelBuffer.
- Source/WebCore/platform/graphics/PixelBuffer.cpp:
(WebCore::PixelBuffer::bytes const):
(WebCore::PixelBuffer::byteLength const):
(WebCore::PixelBuffer::setRange):
(WebCore::PixelBuffer::zeroRange):
(WebCore::PixelBuffer::item const):
(WebCore::PixelBuffer::set):
(WebCore::PixelBuffer::createScratchPixelBuffer const):
- Source/WebCore/platform/graphics/PixelBuffer.h:
(WebCore::PixelBuffer::zeroFill):
- Source/WebCore/platform/graphics/filters/FEComposite.h:
- Source/WebCore/platform/graphics/filters/FilterImage.cpp:
(WebCore::FilterImage::correctPremultipliedPixelBuffer):
- Source/WebCore/platform/graphics/filters/software/FEColorMatrixSoftwareApplier.cpp:
(WebCore::FEColorMatrixSoftwareApplier::applyPlatformAccelerated const):
(WebCore::FEColorMatrixSoftwareApplier::applyPlatformUnaccelerated const):
- Source/WebCore/platform/graphics/filters/software/FEComponentTransferSoftwareApplier.cpp:
(WebCore::FEComponentTransferSoftwareApplier::applyPlatform const):
- Source/WebCore/platform/graphics/filters/software/FECompositeSoftwareApplier.cpp:
(WebCore::FECompositeSoftwareApplier::applyArithmetic const):
- Source/WebCore/platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.cpp:
(WebCore::FEConvolveMatrixSoftwareApplier::setDestinationPixels):
(WebCore::FEConvolveMatrixSoftwareApplier::setInteriorPixels):
(WebCore::FEConvolveMatrixSoftwareApplier::setOuterPixels):
(WebCore::FEConvolveMatrixSoftwareApplier::apply const):
- Source/WebCore/platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.h:
- Source/WebCore/platform/graphics/filters/software/FEDisplacementMapSoftwareApplier.cpp:
(WebCore::FEDisplacementMapSoftwareApplier::apply const):
- Source/WebCore/platform/graphics/filters/software/FEDropShadowSoftwareApplier.cpp:
(WebCore::FEDropShadowSoftwareApplier::apply const):
- Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp:
(WebCore::FEGaussianBlurSoftwareApplier::boxBlurAlphaOnly):
(WebCore::FEGaussianBlurSoftwareApplier::boxBlur):
(WebCore::FEGaussianBlurSoftwareApplier::boxBlurAccelerated):
(WebCore::FEGaussianBlurSoftwareApplier::boxBlurUnaccelerated):
(WebCore::FEGaussianBlurSoftwareApplier::boxBlurGeneric):
(WebCore::FEGaussianBlurSoftwareApplier::boxBlurWorker):
(WebCore::FEGaussianBlurSoftwareApplier::applyPlatform):
(WebCore::FEGaussianBlurSoftwareApplier::apply const):
- Source/WebCore/platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.h:
- Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp:
(WebCore::FELightingSoftwareApplier::apply const):
- Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.h:
- Source/WebCore/platform/graphics/filters/software/FEMorphologySoftwareApplier.cpp:
(WebCore::FEMorphologySoftwareApplier::columnExtremum):
(WebCore::FEMorphologySoftwareApplier::applyPlatformGeneric):
(WebCore::FEMorphologySoftwareApplier::apply const):
- Source/WebCore/platform/graphics/filters/software/FEMorphologySoftwareApplier.h:
- Source/WebCore/platform/graphics/filters/software/FETurbulenceSoftwareApplier.cpp:
(WebCore::FETurbulenceSoftwareApplier::applyPlatformGeneric):
(WebCore::FETurbulenceSoftwareApplier::applyPlatformWorker):
(WebCore::FETurbulenceSoftwareApplier::applyPlatform):
(WebCore::FETurbulenceSoftwareApplier::apply const):
- Source/WebCore/platform/graphics/filters/software/FETurbulenceSoftwareApplier.h:
Canonical link: https://commits.webkit.org/250982@main
- 3:45 PM Changeset in webkit [294831] by
-
- 5 edits in trunk/Source/WebKit/UIProcess
Prevent NSAttributedString crashes when AppSSO URLs are provided
https://bugs.webkit.org/show_bug.cgi?id=240739
<rdar://93656000>
Reviewed by Chris Dumez.
When NSAttributedString is used in a sandboxed app, it is prevented from checking in with the
AppSSO plugin manager, causing a Sandbox Violation and crash. We don't want NSAttributedString
to ever hand-off to AppSSO, so we should configure it's internal WKWebView to do the right thing.
Reviewed by Chris Dumez.
- Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm:
(+[_WKAttributedStringWebViewCache configuration]): Turn off AppSSO for string uses.
- Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::trySOAuthorization): Use new lazy loading approach.
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::trySOAuthorization): Ditto.
- Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::soAuthorizationCoordinator): Lazily initialize, and RELEASE_ASSERT
if we somehow reach this code without enabling AppSSO.
- Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::soAuthorizationCoordinator): Deleted.
Canonical link: https://commits.webkit.org/250981@main
- 3:36 PM Changeset in webkit [294830] by
-
- 5 edits in trunk
Directories showing up as terminal icons in mail compose
https://bugs.webkit.org/show_bug.cgi?id=240882
rdar://45111300
Reviewed by Wenson Hsieh.
- Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::iconForAttachment):
We should not try to fetch an icon if all three provided strings are
null. This was causing issues by attempting to fetch an icon after
already rendering a valid icon using the filewrapper.
- Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::requestThumbnailWithOperation):
(WebKit::WebPageProxy::requestThumbnailWithPath):
Remove some extra spaces and unnecessary WebCore:: prefix.
(WebKit::WebPageProxy::updateIconForDirectory):
New function to update the icon for directories to use the filewrapper
icon instead of the iconForFileType API. This method flips the icon so
it is right-side-up and converts it to a bitmap to pass to the web
process.
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestAttachmentIcon):
- Source/WebKit/UIProcess/WebPageProxy.h:
- Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(testDirectoryAttachmentFileURL):
(-[TestWKWebView waitForAttachmentElementSizeToBecome:]):
(TestWebKitAPI::_icon):
(TestWebKitAPI::TEST):
Add a test to make sure we hit the new NSFileWrapper icon path to fetch
the correct icon for the bundle.
Canonical link: https://commits.webkit.org/250979@main
- 3:36 PM Changeset in webkit [294829] by
-
- 2 edits in trunk/LayoutTests/platform
[Gardening]: [ iOS Debug Big Sur Debug wk2 ] ASSERTION FAILED: WebCore::IDBTransaction::dispatchEvent(WebCore::Event&)
https://bugs.webkit.org/show_bug.cgi?id=240927
<rdar://93929670>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250979@main
- 3:29 PM Changeset in webkit [294828] by
-
- 3 edits in trunk
[LFC][IFC] Support each-line keyword in text-indent
https://bugs.webkit.org/show_bug.cgi?id=240731
Patch by Kiet Ho <Kiet Ho> on 2022-05-25
Reviewed by Alan Bujtas.
Normally, text-indent only affects the first line. When 'each-line' is specified,
subsequent lines where the previous line ends with a hard break are also indented.
This is supported in the legacy layout engine but not in LFC. Adds support for
'each-line' to bring LFC to parity with the legacy engine.
Test: imported/w3c/web-platform-tests/css/css-text/text-indent/text-indent-each-line-hanging.html
- LayoutTests/TestExpectations: Remove ImageOnlyFailure expectation.
- Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
(WebCore::Layout::LineBuilder::initialConstraintsForLine const): Add logic to
indent line when 'each-line' is specified, and the previous line ends with a
hard break.
- Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:
- Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h: Modify
initialConstraintsForLine to accept information about the previous line,
not just whether there's one or not.
Canonical link: https://commits.webkit.org/250978@main
- 3:14 PM Changeset in webkit [294827] by
-
- 1 copy in tags/WebKit-7614.1.14.10.7
Tag WebKit-7614.1.14.10.7.
- 3:12 PM Changeset in webkit [294826] by
-
- 9 edits in branches/safari-7614.1.14.10-branch/Source
Versioning.
WebKit-7614.1.14.10.7
- 2:47 PM Changeset in webkit [294825] by
-
- 1 edit in trunk/Tools/Scripts/run-jsc-stress-tests
[run-jsc-stress-tests] Catch user error
https://bugs.webkit.org/show_bug.cgi?id=240905
Reviewed by Adrian Perez de Castro and Jonathan Bedard.
When the user has made a typo in the argument to --filter (selecting no
tests to execute), bring that to the user's attention instead of exiting
without an error.
- Tools/Scripts/run-jsc-stress-tests:
Canonical link: https://commits.webkit.org/250977@main
- 2:38 PM Changeset in webkit [294824] by
-
- 1 edit in trunk/Source/WebKit/Scripts/process-entitlements.sh
[iOS] WebContent captive portal XPC service needs entitlement to set sandbox state variables
https://bugs.webkit.org/show_bug.cgi?id=240921
Reviewed by Geoffrey Garen.
This patch also adds a function for the shared WebContent entitlements on iOS.
- Source/WebKit/Scripts/process-entitlements.sh:
Canonical link: https://commits.webkit.org/250976@main
- 2:36 PM Changeset in webkit [294823] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations
Re-enable http/tests/inspector/network/har/har-page.html for mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=229458
Unreviewed test expectations update.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250975@main
- 2:26 PM Changeset in webkit [294822] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.11
- 2:16 PM Changeset in webkit [294821] by
-
- 1 edit in trunk/LayoutTests/platform/win/TestExpectations
[ Win EWS ] Six webanimations/offset-compositing tests are a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240617
Unreviewed test gardening.
- LayoutTests/platform/win/TestExpectations: Mark tests as flaky.
Canonical link: https://commits.webkit.org/250974@main
- 1:29 PM Changeset in webkit [294820] by
-
- 11 edits1 copy1 delete in trunk/Source/WebKit
Remove old WebStorage implementation
https://bugs.webkit.org/show_bug.cgi?id=240833
Reviewed by Geoffrey Garen.
No behavior change; the new implementation inside Source/WebKit/NetworkProcess/storage/ is in use.
- Source/WebKit/CMakeLists.txt:
- Source/WebKit/NetworkProcess/NetworkProcess.h:
- Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.cpp: Removed.
- Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.h: Removed.
- Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp: Removed.
- Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.h: Removed.
- Source/WebKit/NetworkProcess/WebStorage/LocalStorageNamespace.cpp: Removed.
- Source/WebKit/NetworkProcess/WebStorage/LocalStorageNamespace.h: Removed.
- Source/WebKit/NetworkProcess/WebStorage/SessionStorageNamespace.cpp: Removed.
- Source/WebKit/NetworkProcess/WebStorage/SessionStorageNamespace.h: Removed.
- Source/WebKit/NetworkProcess/WebStorage/StorageArea.cpp: Removed.
- Source/WebKit/NetworkProcess/WebStorage/StorageArea.h: Removed.
- Source/WebKit/NetworkProcess/WebStorage/StorageManager.cpp: Removed.
- Source/WebKit/NetworkProcess/WebStorage/StorageManager.h: Removed.
- Source/WebKit/NetworkProcess/WebStorage/TransientLocalStorageNamespace.cpp: Removed.
- Source/WebKit/NetworkProcess/WebStorage/TransientLocalStorageNamespace.h: Removed.
- Source/WebKit/NetworkProcess/WebStorage/ios/LocalStorageDatabaseTrackerIOS.mm: Removed.
- Source/WebKit/Platform/Logging.h:
- Source/WebKit/PlatformPlayStation.cmake:
- Source/WebKit/PlatformWin.cmake:
- Source/WebKit/Shared/StorageAreaIdentifier.h: Renamed from Source/WebKit/NetworkProcess/WebStorage/StorageAreaIdentifier.h.
- Source/WebKit/Sources.txt:
- Source/WebKit/SourcesCocoa.txt:
- Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
- Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
- Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/250973@main
- 12:53 PM Changeset in webkit [294819] by
-
- 7 edits in trunk
Add support for Link nonces
https://bugs.webkit.org/show_bug.cgi?id=240817
This reads the nonce from link elements and Link headers.
This was implemented by Chromium in 2017 to be consistent with the HTMLPreloader:
https://chromium-review.googlesource.com/c/chromium/src/+/676769/
Reviewed by Kate Cheney.
- LayoutTests/imported/w3c/web-platform-tests/preload/link-header-preload-nonce-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/preload/link-header-preload-nonce.html:
These test changes were already upstream: https://github.com/web-platform-tests/wpt/commit/306dc506adba97ca84ada67bdab6227dba65bbcb
- Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
- Source/WebCore/loader/LinkHeader.cpp:
(WebCore::paramterNameFromString):
(WebCore::LinkHeader::setValue):
- Source/WebCore/loader/LinkHeader.h:
(WebCore::LinkHeader::nonce const):
- Source/WebCore/loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLinksFromHeader):
(WebCore::LinkLoader::preloadIfNeeded):
(WebCore::LinkLoader::prefetchIfNeeded):
- Source/WebCore/loader/LinkLoader.h:
Canonical link: https://commits.webkit.org/250972@main
- 12:39 PM Changeset in webkit [294818] by
-
- 2 edits in trunk/Source/WebInspectorUI/UserInterface/Views
Web Inspector: Timelines Tab: Screenshots: images should be centered
https://bugs.webkit.org/show_bug.cgi?id=240854
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.js:
(WI.ScreenshotsTimelineView.prototype.layout):
- Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.css:
(.timeline-view.screenshots):
(.timeline-view.screenshots > .spacer): Added.
(.timeline-view.screenshots > img):
Canonical link: https://commits.webkit.org/250971@main
- 12:21 PM Changeset in webkit [294817] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
[Gardening]: [ iOS Debug ] Two fast/loader/ tests are a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240918
<rdar://93918602>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250970@main
- 12:05 PM Changeset in webkit [294816] by
-
- 8 edits in trunk/Source/WebCore/platform/graphics
REGRESSION(r294215): : r294317 was reverted, it fixed an edge-case for 294217
https://bugs.webkit.org/show_bug.cgi?id=240645
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-25
Unreviewed.
Revert r294215, its dependency r294317 was reverted.
Reverted changeset:
"WebCore::IOSurface has WebCore::GraphicsContext as its
property, it should be the other way around"
https://bugs.webkit.org/show_bug.cgi?id=240417
https://commits.webkit.org/r294215
- Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContextCG::drawNativeImage):
- Source/WebCore/platform/graphics/cg/GraphicsContextCG.h:
- Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp:
(WebCore::IOSurfacePool::willAddSurface):
- Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::~ImageBufferIOSurfaceBackend):
(WebCore::ImageBufferIOSurfaceBackend::context const):
(WebCore::ImageBufferIOSurfaceBackend::releaseGraphicsContext):
- Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
- Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:
(WebCore::GraphicsContextCG::GraphicsContextCG): Deleted.
- Source/WebCore/platform/graphics/cocoa/IOSurface.h:
- Source/WebCore/platform/graphics/cocoa/IOSurface.mm:
(WebCore::IOSurface::create):
(WebCore::IOSurface::ensureGraphicsContext):
(WebCore::IOSurface::releaseGraphicsContext):
(WebCore::IOSurface::releasePlatformGraphicsContext): Deleted.
Canonical link: https://commits.webkit.org/250969@main
- 12:03 PM Changeset in webkit [294815] by
-
- 2 edits in trunk/Source/WebKit/UIProcess/ios
[iOS] Refactor some logic around tap gesture handling when VKCImageAnalysisInteraction is active
https://bugs.webkit.org/show_bug.cgi?id=240891
rdar://93808100
Reviewed by Aditya Keerthi.
Currently, when handling a single tap in WKContentView, we check whether or not the tap occurred
over the Live Text button in theVKCImageAnalysisInteraction; if so, we manually toggle Live Text
interaction highlight state. This special treatment exists (instead of simply relying on the
UIButton's tap gesture) becauseWKContentViewalready has its own synthetic click gesture which
conflicts with the UIButton's tap gesture; without this logic, taps on the analysis button would be
completely ignored.
While this works for the Live Text button, it doesn't work for other actionable buttons in the image
analysis interaction. To address this, we install aUIButtonConfigurationUpdateHandleron the
image analysis interaction just to collect the set ofUIButtons that are owned by the interaction.
When tapping on the content view, if we hit one of these VisionKitCore-owned buttons, then invoke
the button action on its behalf.
- Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _singleTapIdentified:]):
Also, pull this VisionKit interception logic out into a new helper method below, named
-_handleTapOverImageAnalysisInteractionButton:. This returns whether or not the tap was handled by
VisionKit (in which case we avoid treating this as a synthetic click on the page).
(-[WKContentView _handleTapOverImageAnalysisInteractionButton:]):
(-[WKContentView installImageAnalysisInteraction:]):
(-[WKContentView uninstallImageAnalysisInteraction]):
Canonical link: https://commits.webkit.org/250968@main
- 11:55 AM Changeset in webkit [294814] by
-
- 1 edit in trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in
[iOS] Remove obsolete graphics message filters
https://bugs.webkit.org/show_bug.cgi?id=240736
<rdar://93527356>
Reviewed by Geoffrey Garen.
Remove obsolete graphics filters in the WebContent process' sandbox on iOS, since this filtering is
now done in other parts of the system.
- Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
Canonical link: https://commits.webkit.org/250967@main
- 11:47 AM Changeset in webkit [294813] by
-
- 9 edits in branches/safari-7614.1.14.0-branch/Source
Versioning.
WebKit-7614.1.14.0.11
- 11:33 AM Changeset in webkit [294812] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm
REGRESSION (r294434): [ iOS ] TestWebKitAPI.WebAuthenticationPanel.ExportImportDuplicateCredential is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240686
<rdar://93603762>
Reviewed by Brent Fulgham.
The sync flag may differ at runtime due to internal reasons. This patch modifies the test to support either value
of the flag.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/250966@main
- 11:13 AM Changeset in webkit [294811] by
-
- 1 edit in trunk/Source/JavaScriptCore/API/tests/testapi.cpp
[JSC] TestAPI::promiseUnhandledRejection() predominantly fails on MacOS 12.3 in --debug
https://bugs.webkit.org/show_bug.cgi?id=240243
<rdar://92975620>
Reviewed by Mark Lam.
The failures are caused by an unhandled rejection, that was originated in
TestAPI::promiseDrainDoesNotEatExceptions() and ended up in the callback of
TestAPI::promiseUnhandledRejection(), with an unexpected promise and reason.
That is, the callback of TestAPI::promiseUnhandledRejection() is called twice,
with only the first invocation being successful.
The failures weren't observed before MacOS 12.3 because TestAPI::promiseDrainDoesNotEatExceptions()
is a DYLD_MACOSX_VERSION-conditional test.
To fix the tests, this change ensures that TestAPI::promiseUnhandledRejection() performs assertions
only on the first run, aligning it with TestAPI::promiseUnhandledRejectionFromUnhandledRejectionCallback().
- Source/JavaScriptCore/API/tests/testapi.cpp:
(TestAPI::promiseUnhandledRejection):
Canonical link: https://commits.webkit.org/250965@main
- 11:11 AM Changeset in webkit [294810] by
-
- 1 edit in trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp
Speculative build fix: Revert use of .alt_entry directive in LLInt asm code.
https://bugs.webkit.org/show_bug.cgi?id=240916
Unreviewed.
We suspect that this is causing linker issues on some builds.
- Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:
Canonical link: https://commits.webkit.org/250964@main
- 11:01 AM Changeset in webkit [294809] by
-
- 2 edits in trunk/Source/WebKit
Add logging related to Mach bootstrap enablement
https://bugs.webkit.org/show_bug.cgi?id=240909
Reviewed by Chris Dumez.
We are seeing telemetry that indicates that enabling Mach bootstrap is failing in some cases.
Add logging to help diagnose this.
- Source/WebKit/Platform/Logging.h:
- Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtension::createHandleForMachLookup):
- Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtension::createHandleForMachLookup):
Canonical link: https://commits.webkit.org/250963@main
- 10:57 AM Changeset in webkit [294808] by
-
- 1 edit in trunk/metadata/contributors.json
Add my GitHub account to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240915
Unreviewed.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250962@main
- 10:54 AM Changeset in webkit [294807] by
-
- 1 copy in tags/WebKit-7613.3.1.1.5
Tag WebKit-7613.3.1.1.5.
- 10:45 AM Changeset in webkit [294806] by
-
- 9 edits in branches/safari-7613.3.1.1-branch/Source
Versioning.
WebKit-7613.3.1.1.5
- 10:43 AM Changeset in webkit [294805] by
-
- 1 edit in trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py
git-webkit pr crashes when run from detached HEAD
https://bugs.webkit.org/show_bug.cgi?id=240468
Reviewed by Jonathan Bedard.
repository.branch is None when on a detached HEAD. This causes us to throw an Error when performing a regex on the branch name.
This patch treats a detached HEAD the same as being on main.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py: (PullRequest.pull_request_branch_point):
Canonical link: https://commits.webkit.org/250961@main
- 10:29 AM Changeset in webkit [294804] by
-
- 2 edits in trunk/Source/WebCore/layout/formattingContexts/flex
Expand flex-grow support
https://bugs.webkit.org/show_bug.cgi?id=240898
Reviewed by Antti Koivisto.
This patch add support for flex-grow. This property defines how flex items take over the available space.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
Canonical link: https://commits.webkit.org/250960@main
- 10:22 AM Changeset in webkit [294803] by
-
- 4 edits in trunk/Source/WebCore/platform/graphics
[Linux] GBMBufferSwapchain should only conditionally create linear-formatted buffer objects
https://bugs.webkit.org/show_bug.cgi?id=240637
Reviewed by Adrian Perez de Castro.
Spawning new gbm_bo objects should not default to requesting linear-storage
buffers. Instead, these should only be created when necessary, e.g. when
copying software-decoded video data into these buffers.
By default, no GBM flags are used. When required, the linear-storage requirement
is enscribed in the new flags field of the GBMBufferSwapchain::BufferDescription
object and acted upon in the GBMBufferSwapchain::getBuffer() call, using the
GBM_BO_USE_LINEAR flag in the gbm_bo_create() call.
The DMABuf-specific sink in MediaPlayerPrivateGStreamer is the only place at the
moment where linear-storage buffers are used since software-decoded material
originates here and is stored in linear memory.
- Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp:
(WebCore::GBMBufferSwapchain::getBuffer):
- Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.h:
- Source/WebCore/platform/graphics/gbm/GraphicsContextGLGBM.cpp:
(WebCore::GraphicsContextGLANGLE::makeContextCurrent):
- Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):
Canonical link: https://commits.webkit.org/250959@main
- 9:53 AM Changeset in webkit [294802] by
-
- 22 edits in trunk/Source/WebKit
Add remainingRunningTime info to logging of PrepareToSuspend message
https://bugs.webkit.org/show_bug.cgi?id=240879
Reviewed by Chris Dumez.
Replace background timing info with remaining run time info, so we have a better idea of when the message is sent and
when it is processed. We will know if the message is handled after process resumes (since process can be suspended
before it handles the message).
- Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::prepareToSuspend):
- Source/WebKit/GPUProcess/GPUProcess.h:
- Source/WebKit/GPUProcess/GPUProcess.messages.in:
- Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::processWillSuspendImminentlyForTestingSync):
(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::applicationDidEnterBackground):
(WebKit::NetworkProcess::applicationWillEnterForeground):
(WebKit::NetworkProcess::processDidResume):
- Source/WebKit/NetworkProcess/NetworkProcess.h:
- Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
- Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _processWillSuspendForTesting:]):
(-[WKWebView _processWillSuspendImminentlyForTesting]):
- Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::sendPrepareToSuspend):
- Source/WebKit/UIProcess/GPU/GPUProcessProxy.h:
- Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::sendPrepareToSuspend):
- Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
- Source/WebKit/UIProcess/ProcessAssertion.cpp:
(WebKit::ProcessAssertion::remainingRunTimeInSeconds):
- Source/WebKit/UIProcess/ProcessAssertion.h:
- Source/WebKit/UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::sendPrepareToSuspendIPC):
- Source/WebKit/UIProcess/ProcessThrottlerClient.h:
- Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::sendPrepareToSuspend):
- Source/WebKit/UIProcess/WebProcessProxy.h:
- Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::sendNetworkProcessPrepareToSuspendForTesting):
- Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::ProcessAssertion::remainingRunTimeInSeconds):
- Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::prepareToSuspend):
- Source/WebKit/WebProcess/WebProcess.h:
- Source/WebKit/WebProcess/WebProcess.messages.in:
Canonical link: https://commits.webkit.org/250958@main
- 9:47 AM Changeset in webkit [294801] by
-
- 1 edit in trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
Syscall should only be allowed for newer macOS versions
https://bugs.webkit.org/show_bug.cgi?id=240714
Reviewed by Chris Dumez.
- Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:
Canonical link: https://commits.webkit.org/250957@main
- 8:44 AM Changeset in webkit [294800] by
-
- 4 edits in trunk/Source/WebInspectorUI/UserInterface/Views
Web Inspector: Computed Panel: Move ungrouped CSS variables to dedicated DetailsSidebar
https://bugs.webkit.org/show_bug.cgi?id=240805
Reviewed by Patrick Angle.
A follow-up from https://github.com/WebKit/WebKit/pull/782#pullrequestreview-978824063
As an aside, it is unfortunate in hindsight that the variables section
element can either directly contain variables for ungrouped mode, or contain
sections. I wonder if there is a better way to handle this where we never
have to even add the variables section to the map and instead have a single
"section" within it (without a header) that behaves just like the grouped
sections, but for ungrouped mode.
The top-level Variables details section contains either:
- the list of ungrouped variables
- nested detail sections for each group of variables grouped by type
When toggling between grouping modes, we remove the host details sections for
variable groups, but we need to take care not to remove the top-level Variables
details section. This isn't ideal. All variable lists, ungrouped or grouped,
need their own independent host details section that can be safely removed
without impacting others.
A details section has a header with text and a button to toggle collapsing the
section contents. Ungrouped variables don't need this. The top-level Variables
details section serves this role (the reason why the code was written with it
doing double duty).
We can change the implementation of
WI.DetailsSectionto hide the header
if a title is not provided. This enables us to nest details sections without
showing extraneous headers. This relievesWI.ComputedStyleDetailsPanel.layout()
of the duty to avoid removing the top-level Variables details section.
- Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.css:
(.sidebar > .panel.details.css-style > .content > .computed > .details-section.computed-style-variables .scope-bar.computed-style-variables-grouping-mode:hover):
(.sidebar > .panel.details.css-style > .content > .computed > .details-section.computed-style-variables .computed-style-section):
Adding symmetric padding to the top of the section to space out the contents
from the header's bottom border.
- Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js:
(WI.ComputedStyleDetailsPanel.prototype.layout):
(WI.ComputedStyleDetailsPanel.prototype._renderVariablesStyleSectionGroup):
- Source/WebInspectorUI/UserInterface/Views/DetailsSection.css:
(.details-section > .header:not(:empty)):
(.details-section .details-section > .header:not(:empty)):
(.details-section .details-section:not(.collapsed) > .header:not(:empty)):
(.details-section > .header:not(:empty)::before):
(.details-section > .header): Deleted.
(.details-section .details-section > .header): Deleted.
(.details-section .details-section:not(.collapsed) > .header): Deleted.
(.details-section > .header::before): Deleted.
- Source/WebInspectorUI/UserInterface/Views/DetailsSection.js:
(WI.DetailsSection):
(WI.DetailsSection.prototype.get title):
(WI.DetailsSection.prototype.set title):
Canonical link: https://commits.webkit.org/250956@main
- 8:18 AM Changeset in webkit [294799] by
-
- 14 edits in trunk
Don't index shorthands in computed styles
https://bugs.webkit.org/show_bug.cgi?id=240356
Reviewed by Tim Nguyen.
Most shorthands were already not indexed, but legacy shorthands with a
single longhand were indexed. This didn't make much sense, since they
are like aliases with a different syntax, and aliases are not indexed.
Tests: fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html
imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html
imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer.html
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
svg/css/getComputedStyle-basic.xhtml
Canonical link: https://commits.webkit.org/250955@main
- 8:03 AM Changeset in webkit [294798] by
-
- 3 edits in trunk/Tools/Scripts/libraries/webkitbugspy
[git-webkit] Check expiration in token
https://bugs.webkit.org/show_bug.cgi?id=240883
<rdar://problem/93859778>
Reviewed by Chris Dumez.
- Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py: Ditto.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
(Tracker.credentials.validater): Check token expiration explicitly.
Canonical link: https://commits.webkit.org/250954@main
- 7:49 AM Changeset in webkit [294797] by
-
- 5 edits in trunk/Tools/Scripts/libraries/webkitscmpy
[git-webkit] clean all dead pr branches
https://bugs.webkit.org/show_bug.cgi?id=240589
<rdar://93521924>
Reviewed by Aakash Jain.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/init.py:
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py:
(DeletePRBranches): Iterate through all local branches and remove those
associated with a closed PR.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/clean_unittest.py:
(TestClean.test_delete_pr_branches):
Canonical link: https://commits.webkit.org/250953@main
- 7:00 AM WebKitGTK/2.36.x edited by
- (diff)
- 6:45 AM Changeset in webkit [294796] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/gstreamer
Merge r294537 - REGRESSION(r288092): Deadlock when the playback is stopping just right after startup
https://bugs.webkit.org/show_bug.cgi?id=240661
Patch by Yacine Bandou <yacine.bandou@softathome.com> on 2022-05-20
Reviewed by Philippe Normand.
r288092 causes a deadlock with the "28. ChangeType.H264.VP9" test in "https://ytlr-cert.appspot.com/2020/main.html".
The background thread locks the GStPad and sends a notify::caps signal which is caught by
VideoTrackPrivateGStreamer that calls callOnMainThreadAndWait.
At the same time the main thread destroys MediaPlayerPrivateGStreamer and sets the pipeline to NULL
that calls "gst_pad_set_active" which wants to lock the GStPad.
This commit uses AbortableTaskQueue and calls enqueueTask instead of callOnMainThreadAndWait
in order to be able to abort the waiting job and avoid using the "AndWait" variant, consequently
we avoid the deadlock.
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):
(WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromTags):
(WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromCaps):
(WebCore::AudioTrackPrivateGStreamer::disconnect):
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):
(WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromTags):
(WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromCaps):
(WebCore::VideoTrackPrivateGStreamer::disconnect):
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
Canonical link: https://commits.webkit.org/250792@main
- 6:45 AM Changeset in webkit [294795] by
-
- 2 edits4 adds in releases/WebKitGTK/webkit-2.36
Merge r294791 - [MSE][GStreamer] Support Google Dynamic Ad Insertion (DAI)
https://bugs.webkit.org/show_bug.cgi?id=216039
<rdar://problem/68638316>
Patch by Philippe Normand <philn@igalia.com> on 2022-05-25
Reviewed by Alicia Boya Garcia.
The "simple DAI" demo was not working as expected because the new source pad of the demuxer in the append
pipeline was sinking buffers to a "black hole". That was happening because the second time the
no-more-pads signal was emitted, the previous source pad was still linked to a track, and there was
no code to unlink/relink demuxer pads. This is now handled...
The specific "simple DAI" demo generates 2 AAC streams, with different tkhd track-id fields, we had
no layout test reproducing this use-case, so this patch provides one.
Test: media-source/media-source-audio-track-id-switch.html
- LayoutTests/media/media-source/content/test-48kHz-new-track-id.m4a: Added.
- LayoutTests/media/media-source/content/test-48khz-new-track-id-manifest.json: Added.
- LayoutTests/media/media-source/media-source-audio-track-id-switch-expected.txt: Added.
- LayoutTests/media/media-source/media-source-audio-track-id-switch.html: Added.
- Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::handleErrorSyncMessage):
(WebCore::AppendPipeline::didReceiveInitializationSegment):
(WebCore::createOptionalParserForFormat):
(WebCore::AppendPipeline::recycleTrackForPad):
(WebCore::AppendPipeline::linkPadWithTrack):
(WebCore::AppendPipeline::tryMatchPadToExistingTrack): Deleted.
- Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:
(WebCore::AppendPipeline::Track::isLinked const):
Canonical link: https://commits.webkit.org/250950@main
- 6:32 AM Changeset in webkit [294794] by
-
- 24 edits in trunk/Source/JavaScriptCore
[JSC][ARMv7] Support callee save FPRs
Patch by Geza Lore <Geza Lore> on 2022-05-25
https://bugs.webkit.org/show_bug.cgi?id=240376
Reviewed by Yusuke Suzuki.
ARMv7 FPRs d8-d15 (also referenced as s16-s32 and q4-q7) are callee save
in the host ABI, but currently JSC is unaware of this. This does not
currently cause problems as they are not used, but will be used by the
Wasm JITs.
In preparation for the 32-bit ports of the Wasm JITs, this patch:
- Teaches JSC about callee save FPRs on ARMv7. d8-d15 are host ABI callee save, but only d8-d14 are VM callee save, i.e.: we treat d15 as a volatile register in JIT code. This is so we can use d15 as a macro assembler scratch register.
- Changes offlineasm and MacroAssemblerARMv7 to use d15 as the FP scratch register. We do this so we can use the full range of d0-d7 as temporary, and in particular as Wasm argument/return registers.
- To achieve the above, we need to modify RegisterAtOffsetList as GPRs and FPRs have different sizes on JSVALUE32_64 platforms
- Adds the ARMv7 specific registers to RegisterSet::macroScratchRegisters()
- assembler/ARMv7Registers.h:
- assembler/MacroAssemblerARMv7.h:
- b3/air/AirCode.cpp:
(JSC::B3::Air::Code::calleeSaveRegisterAtOffsetList const):
(JSC::B3::Air::Code::dump const):
- b3/testb3_7.cpp:
(testInfiniteLoopDoesntCauseBadHoisting):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::llintBaselineCalleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::calleeSaveSpaceAsVirtualRegisters):
(JSC::roundCalleeSaveSpaceAsVirtualRegisters): Deleted.
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::calleeSaveGPRDisplacedInJSStack):
(JSC::ValueRecovery::calleeSaveRegDisplacedInJSStack): Deleted.
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::calleeSaveSlot):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::copyCalleeSavesToEntryFrameCalleeSavesBuffer const):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::restoreCalleeSavesFromEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::restoreCalleeSavesFromVMEntryFrameCalleeSavesBufferImpl):
(JSC::AssemblyHelpers::copyCalleeSavesToEntryFrameCalleeSavesBufferImpl):
(JSC::AssemblyHelpers::emitSave):
(JSC::AssemblyHelpers::emitRestore):
(JSC::AssemblyHelpers::emitSaveCalleeSavesFor):
(JSC::AssemblyHelpers::emitRestoreCalleeSavesFor):
(JSC::AssemblyHelpers::copyLLIntBaselineCalleeSavesFromFrameOrRegisterToEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::emitSaveOrCopyLLIntBaselineCalleeSavesFor):
- jit/CallFrameShuffleData.cpp:
(JSC::CallFrameShuffleData::setupCalleeSaveRegisters):
- jit/CallFrameShuffler.h:
(JSC::CallFrameShuffler::snapshot const):
- jit/CallFrameShuffler32_64.cpp:
(JSC::CallFrameShuffler::emitDisplace):
- jit/FPRInfo.h:
- jit/GPRInfo.h:
- jit/RegisterAtOffsetList.cpp:
(JSC::RegisterAtOffsetList::RegisterAtOffsetList):
- jit/RegisterAtOffsetList.h:
(JSC::RegisterAtOffsetList::registerCount const):
(JSC::RegisterAtOffsetList::sizeOfAreaInBytes const):
(JSC::RegisterAtOffsetList::adjustOffsets):
(JSC::RegisterAtOffsetList::size const): Deleted.
(JSC::RegisterAtOffsetList::at): Deleted.
- jit/RegisterSet.cpp:
(JSC::RegisterSet::macroScratchRegisters):
(JSC::RegisterSet::vmCalleeSaveRegisters):
- llint/LowLevelInterpreter.asm:
- offlineasm/arm.rb:
- wasm/js/JSToWasm.cpp:
(JSC::Wasm::createJSToWasmWrapper):
- wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJS):
- wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):
Canonical link: https://commits.webkit.org/250952@main
- 4:05 AM WebKitGTK/2.36.x edited by
- (diff)
- 3:42 AM WebKitGTK/2.36.x edited by
- (diff)
- 3:41 AM Changeset in webkit [294793] by
-
- 3 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/gstreamer/mse
Merge r294634 - REGRESSION(r290375) [GStreamer] Deadlock in WebProcess termination if AppendPipeline is started https://bugs.webkit.org/show_bug.cgi?id=240716
Patch by Olivier Blin <Olivier Blin> on 2022-05-23
Reviewed by Alicia Boya Garcia.
Since r290375, GStreamer ports are calling gst_deinit() at WebProcess
termination.
This is causing a deadlock if a MSE SourceBuffer has been instantiated.
That is because the GstTask from the appsrc element in the
AppendPipeline is still running.
To avoid the deadlock, stop the appsrc element in the AppendPipeline
when the SourceBuffer is removed from the MediaSource, since it will
not be useful anymore after being removed from its associated MediaSource.
The W3C spec of MediaSource.removeSourceBuffer mentions as a last step
that it should destroy all resources for sourceBuffer.
The MediaSource will be stopped at WebProcess termination, since
active DOM objects are stopped when detaching the frame.
This ensures that MediaSource is detached from its media element, and
that it removes its source buffers.
Drive-by fix: remove resetPipeline declaration, deleted in r238892
- Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::stopParser):
- Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:
- Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
(WebCore::SourceBufferPrivateGStreamer::removedFromMediaSource):
Canonical link: https://commits.webkit.org/250860@main
- 2:54 AM Changeset in webkit [294792] by
-
- 1 edit6 deletes in trunk/Tools/buildstream/elements
[Flatpak SDK] Remove Subversion
https://bugs.webkit.org/show_bug.cgi?id=240903
Patch by Philippe Normand <philn@igalia.com> on 2022-05-25
Reviewed by Adrian Perez de Castro.
- Tools/buildstream/elements/sdk-build-depends/swig.bst: Removed.
- Tools/buildstream/elements/sdk-build-depends/utf8proc.bst: Removed.
- Tools/buildstream/elements/sdk-platform.bst:
- Tools/buildstream/elements/sdk/libsecret.bst: Removed.
- Tools/buildstream/elements/sdk/libserf.bst: Removed.
- Tools/buildstream/elements/sdk/perl-term-readkey.bst: Removed.
- Tools/buildstream/elements/sdk/subversion.bst: Removed.
Canonical link: https://commits.webkit.org/250951@main
- 1:00 AM Changeset in webkit [294791] by
-
- 2 edits4 adds in trunk
[MSE][GStreamer] Support Google Dynamic Ad Insertion (DAI)
https://bugs.webkit.org/show_bug.cgi?id=216039
<rdar://problem/68638316>
Patch by Philippe Normand <philn@igalia.com> on 2022-05-25
Reviewed by Alicia Boya Garcia.
The "simple DAI" demo was not working as expected because the new source pad of the demuxer in the append
pipeline was sinking buffers to a "black hole". That was happening because the second time the
no-more-pads signal was emitted, the previous source pad was still linked to a track, and there was
no code to unlink/relink demuxer pads. This is now handled...
The specific "simple DAI" demo generates 2 AAC streams, with different tkhd track-id fields, we had
no layout test reproducing this use-case, so this patch provides one.
Test: media-source/media-source-audio-track-id-switch.html
- LayoutTests/media/media-source/content/test-48kHz-new-track-id.m4a: Added.
- LayoutTests/media/media-source/content/test-48khz-new-track-id-manifest.json: Added.
- LayoutTests/media/media-source/media-source-audio-track-id-switch-expected.txt: Added.
- LayoutTests/media/media-source/media-source-audio-track-id-switch.html: Added.
- Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::handleErrorSyncMessage):
(WebCore::AppendPipeline::didReceiveInitializationSegment):
(WebCore::createOptionalParserForFormat):
(WebCore::AppendPipeline::recycleTrackForPad):
(WebCore::AppendPipeline::linkPadWithTrack):
(WebCore::AppendPipeline::tryMatchPadToExistingTrack): Deleted.
- Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:
(WebCore::AppendPipeline::Track::isLinked const):
Canonical link: https://commits.webkit.org/250950@main
May 24, 2022:
- 11:20 PM Changeset in webkit [294790] by
-
- 44 edits2 adds2 deletes in trunk/Source/WebKit
Rename SharedBufferCopy to SharedBufferReference
https://bugs.webkit.org/show_bug.cgi?id=240796
rdar://problem/93754681
Patch by Jean-Yves Avenard <jyavenard@gmail.com> on 2022-05-24
Reviewed by Jer Noble.
- SharedBufferCopy doesn't perform a copy, but passes SharedMemory and return a SharedBuffer that wraps such SharedMemory.
Rename it to SharedBufferReference to more accurately reflect what it actually does.
- Remove SharedBufferCopy::safeBuffer() and rename SharedBufferCopy::buffer with SharedBufferCopy::unsafeBuffer. This gives better clarity that accessing SharedBufferCopy should be treated with care.
- Add SharedBufferCopy::isNull() method
- When passing a SharedBufferReferal across multiple processes, we remove the need for a new allocation and copy of the content; instead we move the underlying SharedMemory.
No change of observable behaviour.
- Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.h:
- Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp:
(WebKit::RemoteImageDecoderAVFProxy::createDecoder):
(WebKit::RemoteImageDecoderAVFProxy::setData):
- Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.h:
- Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in:
- Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::bufferingTimerFired):
(WebKit::NetworkResourceLoader::sendBuffer):
(WebKit::NetworkResourceLoader::dataReceivedThroughContentFilter):
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.cpp:
(WebKit::ServiceWorkerDownloadTask::didReceiveData):
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h:
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.messages.in:
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::didReceiveData):
(WebKit::ServiceWorkerFetchTask::loadBodyFromPreloader):
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in:
- Source/WebKit/Platform/IPC/SharedBufferCopy.cpp: Removed.
- Source/WebKit/Platform/IPC/SharedBufferCopy.h: Removed.
- Source/WebKit/Platform/IPC/SharedBufferReference.cpp: Added.
(IPC::SharedBufferReference::encode const):
(IPC::SharedBufferReference::decode):
(IPC::SharedBufferReference::unsafeBuffer const):
(IPC::SharedBufferReference::data const):
- Source/WebKit/Platform/IPC/SharedBufferReference.h: Added.
(IPC::SharedBufferReference::SharedBufferReference):
(IPC::SharedBufferReference::size const):
(IPC::SharedBufferReference::isEmpty const):
(IPC::SharedBufferReference::isNull const):
- Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp:
(WebKit::CGDisplayListImageBufferBackend::createBackendHandle const):
- Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
- Source/WebKit/Sources.txt:
- Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView createPDFWithConfiguration:completionHandler:]):
- Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::platformRegisterAttachment):
- Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::sendAudioComponentRegistrations):
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::CompletionHandler<void):
(WebKit::WebPageProxy::drawToPDF):
(WebKit::WebPageProxy::getLoadDecisionForIcon):
(WebKit::WebPageProxy::updateAttachmentAttributes):
(WebKit::WebPageProxy::registerAttachmentIdentifierFromData):
(WebKit::WebPageProxy::platformRegisterAttachment):
- Source/WebKit/UIProcess/WebPageProxy.h:
- Source/WebKit/UIProcess/WebPageProxy.messages.in:
- Source/WebKit/UIProcess/WebPasteboardProxy.h:
- Source/WebKit/UIProcess/WebPasteboardProxy.messages.in:
- Source/WebKit/UIProcess/WebURLSchemeTask.cpp:
(WebKit::WebURLSchemeTask::didReceiveData):
- Source/WebKit/UIProcess/gtk/WebPasteboardProxyGtk.cpp:
(WebKit::WebPasteboardProxy::readBuffer):
- Source/WebKit/UIProcess/ios/WKContentView.mm:
(-[WKContentView _wk_pageCountForPrintFormatter:]):
- Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::drawToPDFiOS):
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Source/WebKit/WebProcess/GPU/graphics/ImageBufferBackendHandle.h:
- Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVF.cpp:
(WebKit::RemoteImageDecoderAVF::setData):
- Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp:
(WebKit::RemoteImageDecoderAVFManager::createImageDecoder):
- Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveData):
- Source/WebKit/WebProcess/Network/WebResourceLoader.h:
- Source/WebKit/WebProcess/Network/WebResourceLoader.messages.in:
- Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveData):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveBlobChunk):
- Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
- Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::registerAttachmentIdentifier):
- Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::readBufferFromClipboard):
- Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getContentsAsMHTMLData):
(WebKit::WebPage::getSelectionAsWebArchiveData):
(WebKit::WebPage::getMainResourceDataOfFrame):
(WebKit::WebPage::getResourceDataFromFrame):
(WebKit::WebPage::getWebArchiveOfFrame):
(WebKit::WebPage::getAccessibilityTreeData):
(WebKit::WebPage::drawToPDF):
(WebKit::WebPage::drawPagesToPDF):
(WebKit::WebPage::didGetLoadDecisionForIcon):
(WebKit::WebPage::urlSchemeTaskDidReceiveData):
(WebKit::WebPage::updateAttachmentAttributes):
- Source/WebKit/WebProcess/WebPage/WebPage.h:
- Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
- Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::drawToPDFiOS):
- Source/WebKit/WebProcess/WebProcess.h:
- Source/WebKit/WebProcess/WebProcess.messages.in:
- Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::consumeAudioComponentRegistrations):
Canonical link: https://commits.webkit.org/250949@main
- 10:57 PM Changeset in webkit [294789] by
-
- 2 edits in trunk/Source/WebCore/svg
Simplify SVGPropertyOwnerRegistry slightly
https://bugs.webkit.org/show_bug.cgi?id=240839
Reviewed by Yusuke Suzuki.
SVGPropertyOwnerRegistry::findAccessor() had to loop through the hash table entries
because it wanted the behavior of QualifiedName::matches(), which is different from
QualifiedName::operator==. However, we can achieve this by using hash traits, and
the appropriate traits already exist in the form of SVGAttributeHashTranslator.
- Source/WebCore/svg/SVGElementInlines.h:
(WebCore::SVGAttributeHashTranslator::hash): Deleted.
(WebCore::SVGAttributeHashTranslator::equal): Deleted.
- Source/WebCore/svg/properties/SVGPropertyOwnerRegistry.h:
(WebCore::SVGAttributeHashTranslator::hash):
(WebCore::SVGAttributeHashTranslator::equal):
(WebCore::SVGPropertyOwnerRegistry::attributeNameToAccessorMap):
(WebCore::SVGPropertyOwnerRegistry::findAccessor):
Canonical link: https://commits.webkit.org/250948@main
- 9:43 PM Changeset in webkit [294788] by
-
- 4 edits in trunk/Source
Use dladdr to get labels instead of stashing them in the JITOperationAnnotation.
https://bugs.webkit.org/show_bug.cgi?id=240895
Reviewed by Saam Barati.
We no longer need to stash these label strings in the JITOperationAnnotations.
This change also fixes an ASAN crasher. As such, we can re-enable
ENABLE(JIT_OPERATION_DISASSEMBLY) even when ASAN_ENABLED.
- Source/JavaScriptCore/assembler/JITOperationList.cpp:
(JSC::JITOperationList::addDisassemblyLabels):
- Source/JavaScriptCore/assembler/JITOperationValidation.h:
- Source/WTF/wtf/PlatformCallingConventions.h:
- Source/WTF/wtf/PlatformEnable.h:
Canonical link: https://commits.webkit.org/250947@main
- 9:03 PM Changeset in webkit [294787] by
-
- 4 edits in trunk/Source/JavaScriptCore/offlineasm
Use
jsc_llintas a LLInt local label prefix instead of_offlineasm.
https://bugs.webkit.org/show_bug.cgi?id=240885
Reviewed by Geoffrey Garen.
Code generated by the offlineasm is tightly coupled with JSC anyway. Might as well
make the local labels more informative about where the code came from in crash traces.
So, instead of this:
JavaScriptCore`vmEntryToJavaScript:
0x1028b5d90 <+0 >: pacibsp
0x1028b5d94 <+4 >: stp x29, x30, [sp, #-0x10]!
0x1028b5d98 <+8 >: mov x29, sp
0x1028b5d9c <+12 >: sub sp, x29, #0xb0
0x1028b5da0 <+16 >: mov x13, #0xc800
0x1028b5da4 <+20 >: add x17, x1, x13
0x1028b5da8 <+24 >: ldr w4, [x17]
0x1028b5dac <+28 >: cbnz w4, 0x1028b5f34 ; _offlineasm_doVMEntrycheckVMEntryPermission
0x1028b5db0 <+32 >: str x1, [sp]
0x1028b5db4 <+36 >: mov x17, #0x9e78
...
0x1028b5de8 <+88 >: sub x3, sp, x4
0x1028b5dec <+92 >: cmp sp, x3
0x1028b5df0 <+96 >: b.ls 0x1028b5ef4 ; _offlineasm_doVMEntrythrowStackOverflow
0x1028b5df4 <+100 >: mov x17, #0xca00
0x1028b5df8 <+104 >: add x13, x1, x17
0x1028b5dfc <+108 >: ldr x17, [x13]
0x1028b5e00 <+112 >: cmp x3, x17
0x1028b5e04 <+116 >: b.lo 0x1028b5ef4 ; _offlineasm_doVMEntrythrowStackOverflow
JavaScriptCore`_offlineasm_doVMEntrystackHeightOK:
0x1028b5e08 <+0 >: mov sp, x3
0x1028b5e0c <+4 >: mov x3, #0x4
JavaScriptCore`_offlineasm_doVMEntrycopyHeaderLoop:
0x1028b5e10 <+0 >: sub w3, w3, #0x1
0x1028b5e14 <+4 >: add x17, x2, x3, lsl #3
0x1028b5e18 <+8 >: ldr x5, [x17]
We now get this:
JavaScriptCore`vmEntryToJavaScript:
0x1028cdd90 <+0>: pacibsp
0x1028cdd94 <+4>: stp x29, x30, [sp, #-0x10]!
0x1028cdd98 <+8>: mov x29, sp
0x1028cdd9c <+12>: sub sp, x29, #0xb0
0x1028cdda0 <+16>: mov x13, #0xc800
0x1028cdda4 <+20>: add x17, x1, x13
0x1028cdda8 <+24>: ldr w4, [x17]
0x1028cddac <+28>: cbnz w4, 0x1028cdf34 ; jsc_llint_doVMEntrycheckVMEntryPermission
0x1028cddb0 <+32>: str x1, [sp]
0x1028cddb4 <+36>: mov x17, #0x9e78
...
0x1028cdde8 <+88>: sub x3, sp, x4
0x1028cddec <+92>: cmp sp, x3
0x1028cddf0 <+96>: b.ls 0x1028cdef4 ; jsc_llint_doVMEntrythrowStackOverflow
0x1028cddf4 <+100>: mov x17, #0xca00
0x1028cddf8 <+104>: add x13, x1, x17
0x1028cddfc <+108>: ldr x17, [x13]
0x1028cde00 <+112>: cmp x3, x17
0x1028cde04 <+116>: b.lo 0x1028cdef4 ; jsc_llint_doVMEntrythrowStackOverflow
JavaScriptCore`jsc_llint_doVMEntrystackHeightOK:
0x1028cde08 <+0>: mov sp, x3
0x1028cde0c <+4>: mov x3, #0x4
JavaScriptCore`jsc_llint_doVMEntrycopyHeaderLoop:
0x1028cde10 <+0>: sub w3, w3, #0x1
0x1028cde14 <+4>: add x17, x2, x3, lsl #3
0x1028cde18 <+8>: ldr x5, [x17]
- Source/JavaScriptCore/offlineasm/arm.rb:
- Source/JavaScriptCore/offlineasm/arm64.rb:
- Source/JavaScriptCore/offlineasm/backends.rb:
- Source/JavaScriptCore/offlineasm/config.rb:
Canonical link: https://commits.webkit.org/250946@main
- 8:30 PM Changeset in webkit [294786] by
-
- 1 edit in trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp
[Clang only] Make every LLInt asm global label an alt entry.
https://bugs.webkit.org/show_bug.cgi?id=240890
Reviewed by Yusuke Suzuki.
This is needed to keep Clang from moving these labels around. For correctness, the AfterGate
labels rely on themselves not being move from where they are declared in source asm code. We
should enforce this with the .alt_entry directive.
- Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:
Canonical link: https://commits.webkit.org/250945@main
- 7:53 PM Changeset in webkit [294785] by
-
- 1 edit in trunk/Source/WebCore/platform/text/TextFlags.h
[GCC] Debian stable build bot broken after 250926@main
https://bugs.webkit.org/show_bug.cgi?id=240897
Reviewed by Cameron McCormack.
GCC8.3 (Debian 10) doesn't support direct brace enclosed initialization of
bitfield enums.
- Source/WebCore/platform/text/TextFlags.h: Move initialization of bitfield enums to constructor.
Canonical link: https://commits.webkit.org/250944@main
- 7:12 PM Changeset in webkit [294784] by
-
- 8 edits in trunk/Source/WebKit
Reduce refcount of SharedMemory when sending them over IPC.
https://bugs.webkit.org/show_bug.cgi?id=240855
rdar://problem/93806688
Reviewed by Jer Noble.
In the future, we want to be able to donate memory with exclusive access to another process, this require the VM to have a refcount of 1.
No change in obeservable behaviour. Covered by existing tests.
- Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::encodeSharedBuffer):
- Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::WebPasteboardProxy::getPasteboardBufferForType):
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):
- Source/WebKit/WebProcess/GPU/media/RemoteMediaResourceProxy.cpp:
(WebKit::RemoteMediaResourceProxy::dataReceived):
- Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:
(WebKit::SourceBufferPrivateRemote::append):
- Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::writeItemsToPasteboard):
- Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage):
- Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::performActionOnElement):
(WebKit::WebPage::didFinishLoadForQuickLookDocumentInMainFrame):
- Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::getDataSelectionForPasteboard):
Canonical link: https://commits.webkit.org/250943@main
- 6:43 PM Changeset in webkit [294783] by
-
- 1 copy in tags/WebKit-7614.1.14.100.3
Tag WebKit-7614.1.14.100.3.
- 6:37 PM Changeset in webkit [294782] by
-
- 1 copy in tags/WebKit-7614.1.14.0.10
Tag WebKit-7614.1.14.0.10.
- 6:37 PM Changeset in webkit [294781] by
-
- 1 copy in tags/WebKit-7614.1.14.1.10
Tag WebKit-7614.1.14.1.10.
- 5:22 PM Changeset in webkit [294780] by
-
- 19 edits in trunk
Web Inspector: Timelines Tab: Screenshots: include images from
console.screenshot
https://bugs.webkit.org/show_bug.cgi?id=240853
Reviewed by Patrick Angle.
This is nice for developers as it gives them a way to visualize all of their
console.screenshot,
which can be used to see visual snapshots of particular nodes/areas since it's configurable (instead
of the general "snapshot the viewport after compositing").
- Source/JavaScriptCore/inspector/protocol/Console.json:
- Source/JavaScriptCore/inspector/ConsoleMessage.h:
- Source/JavaScriptCore/inspector/ConsoleMessage.cpp:
(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::addToFrontend):
- Source/WebInspectorUI/UserInterface/Protocol/ConsoleObserver.js:
(WI.ConsoleObserver.prototype.messageAdded):
- Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js:
(WI.ConsoleManager.prototype.messageWasAdded):
- Source/WebInspectorUI/UserInterface/Models/ConsoleMessage.js:
(WI.ConsoleMessage):
(WI.ConsoleMessage.prototype.get timestamp): Added.
Add atimestampto console messages so that the frontend can know when the message was created.
- Source/WebCore/page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::screenshot):
Capture atimestampbefore snapshotting so it doesn't skew where it's shown in the Timelines Tab.
- Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:
(WI.TimelineManager):
(WI.TimelineManager.prototype._processRecord):
(WI.TimelineManager.prototype._handleMessageAdded): Added.
Listen forWI.ConsoleManager.Event.MessageAddedto addconsole.screenshotto the Timelines Tab.
- Source/WebCore/inspector/TimelineRecordFactory.h:
- Source/WebCore/inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createScreenshotData):
- Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::captureScreenshot):
- Source/WebInspectorUI/UserInterface/Models/ScreenshotsTimelineRecord.js:
(WI.ScreenshotsTimelineRecord):
(WI.ScreenshotsTimelineRecord.async fromJSON):
(WI.ScreenshotsTimelineRecord.prototype.toJSON):
(WI.ScreenshotsTimelineRecord.prototype.get width): Deleted.
(WI.ScreenshotsTimelineRecord.prototype.get height): Deleted.
- Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineOverviewGraph.js:
(WI.ScreenshotsTimelineOverviewGraph.prototype.layout):
Dropwidth/heightfrom screenshot records as thedataURLwill contain it (after loading).
- LayoutTests/inspector/console/console-api-expected.txt:
- LayoutTests/inspector/console/console-screenshot.html:
- LayoutTests/inspector/console/console-table-expected.txt:
- LayoutTests/inspector/timeline/timeline-event-screenshots.html:
- LayoutTests/inspector/timeline/timeline-event-screenshots-expected.txt:
- LayoutTests/inspector/worker/console-basic-expected.txt:
Canonical link: https://commits.webkit.org/250942@main
- 5:06 PM Changeset in webkit [294779] by
-
- 1 edit in trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
Remove floating objects during tree normalization after style changes
https://bugs.webkit.org/show_bug.cgi?id=240797
Reviewed by Darin Adler.
Float boxes define their own block formatting context and thus can't have other intruding
floats. That's why this scenario is not allowed in the code, except in the case when
a regular box with floatting descendants becomes float. In that case the tree might
be temporarily in a semi-correct state until we don't remove the intruding floats.
The current code deals with that by calling rebuildFloatingObjectSetFromIntrudingFloats()
in the subsequent layout. However it's possible that before that a style change kicks in and
mutates the render tree. In that case we could be manipulating stale objects. To prevent
that we can simply directly call removeFloatingObjects() when normalizing the tree after
a style change.
- Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::normalizeTreeAfterStyleChange): Call removeFloatingObjects().
Canonical link: https://commits.webkit.org/250941@main
- 5:04 PM Changeset in webkit [294778] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk2 ] compositing/video/video-border-radius.html is a flakey image failure
https://bugs.webkit.org/show_bug.cgi?id=223383
<rdar://75529480>
Patch by Jean-Yves Avenard <jyavenard@gmail.com> on 2022-05-24
Reviewed by Eric Carlson.
The test waited on the event "canplaythrough" before performing
the screen comparison, assuming that the two videos would have
rendered their first video frame.
canplaythrough is fired, per spec, when the media engine has
buffered sufficient data to ensure a smooth playback to the end.
It provides no guarantee that playback/decoding has actually started.
So instead we wait for a frame to be actually painted with my new
favourite method of the day: requestVideoFrameCallback
- LayoutTests/compositing/video/video-border-radius.html:
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250940@main
- 4:54 PM Changeset in webkit [294777] by
-
- 1 copy in tags/WebKit-7613.3.1.0.4
Tag WebKit-7613.3.1.0.4.
- 4:50 PM Changeset in webkit [294776] by
-
- 1 copy in tags/WebKit-7613.3.1.1.4
Tag WebKit-7613.3.1.1.4.
- 4:07 PM Changeset in webkit [294775] by
-
- 6 edits2 adds in trunk
Web Inspector: Timelines Tab: Screenshots: images flash while recording is still active
https://bugs.webkit.org/show_bug.cgi?id=240852
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineOverviewGraph.js:
(WI.ScreenshotsTimelineOverviewGraph):
(WI.ScreenshotsTimelineOverviewGraph.prototype.reset):
(WI.ScreenshotsTimelineOverviewGraph.prototype.layout):
- Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.js:
(WI.ScreenshotsTimelineView):
(WI.ScreenshotsTimelineView.prototype.reset):
(WI.ScreenshotsTimelineView.prototype.layout):
(WI.ScreenshotsTimelineView.prototype.selectRecord):
(WI.ScreenshotsTimelineView.prototype.clear): Deleted.
Keep aWeakMapof<img>for eachWI.ScreenshotsTimelineRecordso that we don't recreate it
over and over inlayout. Also, don't show the<img>until after it"load".
- Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.css:
(.timeline-view.screenshots):
(.timeline-view.screenshots > img.selected):
Remove scroll snapping as it prevents the selected image from being scrolled offscreen, which is
unnecessarily hostile. The changing border color is enough to identify it as the selected image.
- Source/WebInspectorUI/UserInterface/Base/Utilities.js:
(Map.prototype.getOrInitialize):
(WeakMap.prototype.getOrInitialize): Added.
Adjust utility function to allow forvalueto be a function that's only executed if thekeydoes
not exist in theMap/WeakMap.
- LayoutTests/inspector/unit-tests/map-utilities.html:
- LayoutTests/inspector/unit-tests/map-utilities-expected.txt:
- LayoutTests/inspector/unit-tests/weakmap-utilities.html: Added.
- LayoutTests/inspector/unit-tests/weakmap-utilities-expected.txt: Added.
Canonical link: https://commits.webkit.org/250939@main
- 3:43 PM Changeset in webkit [294774] by
-
- 1 copy in tags/WebKit-7614.1.14.10.6
Tag WebKit-7614.1.14.10.6.
- 3:42 PM Changeset in webkit [294773] by
-
- 1 edit in trunk/Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineOverviewGraph.js
Web Inspector: Timelines Tab: Screenshots: clicking on another screenshot doesn't select it if there's already a selected screenshot
https://bugs.webkit.org/show_bug.cgi?id=240884
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineOverviewGraph.js:
(WI.ScreenshotsTimelineOverviewGraph.prototype.layout):
Canonical link: https://commits.webkit.org/250938@main
- 3:34 PM Changeset in webkit [294772] by
-
- 1 edit in trunk/Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.css
Web Inspector: Timelines Tab: Screenshots: images should have something to make them "pop" when not selected
https://bugs.webkit.org/show_bug.cgi?id=240850
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.css:
(.timeline-view.screenshots > img):
(.timeline-view.screenshots > img.selected):
Canonical link: https://commits.webkit.org/250937@main
- 3:31 PM Changeset in webkit [294771] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm
[iOS] TestWebKitAPI.IndexedDB.IndexedDBSuspendImminently is consistently timing out on release
https://bugs.webkit.org/show_bug.cgi?id=240886
Unreviewed test gardening.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm:
(TEST): Skip the test.
Canonical link: https://commits.webkit.org/250936@main
- 3:24 PM Changeset in webkit [294770] by
-
- 1 edit in trunk/Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.css
Web Inspector: Timelines Tab: Screenshots: not enough space between images
https://bugs.webkit.org/show_bug.cgi?id=240849
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.css:
(.timeline-view.screenshots > img):
(.timeline-view.screenshots > img + img): Added.
Canonical link: https://commits.webkit.org/250935@main
- 3:18 PM Changeset in webkit [294769] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm
[ iOS & MacOS Release ]TestWebKitAPI.WebpagePreferences.WebsitePoliciesAutoplayQuirksAsyncPolicyDelegate is a flaky timeout
Unreviewed test gardening.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(TEST): Skip the test.
Canonical link: https://commits.webkit.org/250934@main
- 2:55 PM Changeset in webkit [294768] by
-
- 1 edit in trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.cpp
Use the Clang .alt_entry directive to allow use of global labels in LLInt asm.
https://bugs.webkit.org/show_bug.cgi?id=240881
Reviewed by Geoffrey Garen.
With this, debugging LLInt code will be easier. LLInt code will no longer all be at an
offset from vmEntryToJavaScript. They will instead be broken up into different sections
under human readable labels.
Secondly, crash traces of LLInt crashes will now be able to give us the nearest label
for a crash site, as opposed to everything being an offset from vmEntryToJavaScript.
For example, instead of this:
JavaScriptCore`vmEntryToJavaScript:
0x1026525b8 <+0>: pacibsp
0x1026525bc <+4>: stp x29, x30, [sp, #-0x10]!
0x1026525c0 <+8>: mov x29, sp
0x1026525c4 <+12>: sub sp, x29, #0xb0
0x1026525c8 <+16>: mov x13, #0xc800
0x1026525cc <+20>: add x17, x1, x13
0x1026525d0 <+24>: ldr w4, [x17]
0x1026525d4 <+28>: cbnz w4, 0x10265275c ; vmEntryToJavaScriptGateAfter + 120
0x1026525d8 <+32>: str x1, [sp]
0x1026525dc <+36>: mov x17, #0x9e78
0x1026525e0 <+40>: add x13, x1, x17
0x1026525e4 <+44>: ldr x4, [x13]
0x1026525e8 <+48>: str x4, [sp, #0x8]
0x1026525ec <+52>: mov x13, #0x9e70
0x1026525f0 <+56>: add x17, x1, x13
0x1026525f4 <+60>: ldr x4, [x17]
0x1026525f8 <+64>: str x4, [sp, #0x10]
0x1026525fc <+68>: ldr x4, [x2, #0x8]
0x102652600 <+72>: str x4, [sp, #0x18]
0x102652604 <+76>: ldr w4, [x2, #0x20]
0x102652608 <+80>: add x4, x4, #0x5
0x10265260c <+84>: lsl x4, x4, #3
0x102652610 <+88>: sub x3, sp, x4
0x102652614 <+92>: cmp sp, x3
0x102652618 <+96>: b.ls 0x10265271c ; vmEntryToJavaScriptGateAfter + 56
0x10265261c <+100>: mov x17, #0xca00
0x102652620 <+104>: add x13, x1, x17
0x102652624 <+108>: ldr x17, [x13]
0x102652628 <+112>: cmp x3, x17
0x10265262c <+116>: b.lo 0x10265271c ; vmEntryToJavaScriptGateAfter + 56
0x102652630 <+120>: mov sp, x3
0x102652634 <+124>: mov x3, #0x4
0x102652638 <+128>: sub w3, w3, #0x1
0x10265263c <+132>: add x17, x2, x3, lsl #3
0x102652640 <+136>: ldr x5, [x17]
We now get this:
JavaScriptCore`vmEntryToJavaScript:
0x1028b5d90 <+0>: pacibsp
0x1028b5d94 <+4>: stp x29, x30, [sp, #-0x10]!
0x1028b5d98 <+8>: mov x29, sp
0x1028b5d9c <+12>: sub sp, x29, #0xb0
0x1028b5da0 <+16>: mov x13, #0xc800
0x1028b5da4 <+20>: add x17, x1, x13
0x1028b5da8 <+24>: ldr w4, [x17]
0x1028b5dac <+28>: cbnz w4, 0x1028b5f34 ; _offlineasm_doVMEntrycheckVMEntryPermission
0x1028b5db0 <+32>: str x1, [sp]
0x1028b5db4 <+36>: mov x17, #0x9e78
0x1028b5db8 <+40>: add x13, x1, x17
0x1028b5dbc <+44>: ldr x4, [x13]
0x1028b5dc0 <+48>: str x4, [sp, #0x8]
0x1028b5dc4 <+52>: mov x13, #0x9e70
0x1028b5dc8 <+56>: add x17, x1, x13
0x1028b5dcc <+60>: ldr x4, [x17]
0x1028b5dd0 <+64>: str x4, [sp, #0x10]
0x1028b5dd4 <+68>: ldr x4, [x2, #0x8]
0x1028b5dd8 <+72>: str x4, [sp, #0x18]
0x1028b5ddc <+76>: ldr w4, [x2, #0x20]
0x1028b5de0 <+80>: add x4, x4, #0x5
0x1028b5de4 <+84>: lsl x4, x4, #3
0x1028b5de8 <+88>: sub x3, sp, x4
0x1028b5dec <+92>: cmp sp, x3
0x1028b5df0 <+96>: b.ls 0x1028b5ef4 ; _offlineasm_doVMEntrythrowStackOverflow
0x1028b5df4 <+100>: mov x17, #0xca00
0x1028b5df8 <+104>: add x13, x1, x17
0x1028b5dfc <+108>: ldr x17, [x13]
0x1028b5e00 <+112>: cmp x3, x17
0x1028b5e04 <+116>: b.lo 0x1028b5ef4 ; _offlineasm_doVMEntrythrowStackOverflow
JavaScriptCore`_offlineasm_doVMEntrystackHeightOK:
0x1028b5e08 <+0>: mov sp, x3
0x1028b5e0c <+4>: mov x3, #0x4
JavaScriptCore`_offlineasm_doVMEntrycopyHeaderLoop:
0x1028b5e10 <+0>: sub w3, w3, #0x1
0x1028b5e14 <+4>: add x17, x2, x3, lsl #3
0x1028b5e18 <+8>: ldr x5, [x17]
This feature is only available when COMPILER(CLANG) is true.
- Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:
Canonical link: https://commits.webkit.org/250933@main
- 2:49 PM Changeset in webkit [294767] by
-
- 2 edits in trunk/Source
WK_ALTERNATE_FRAMEWORKS_DIR should not affect WK_OVERRIDE_FRAMEWORKS_DIR
https://bugs.webkit.org/show_bug.cgi?id=240831
Reviewed by Tim Horton.
Resolve an inconsistency among projects regarding whether
WK_OVERRIDE_FRAMEWORKS_DIR is set for Mac Catalyst. Catalyst builds work
by setting WK_ALTERNATE_FRAMEWORKS_DIR. With this change, we update
projects so that an alternates directory never affects
WK_OVERRIDE_FRAMEWORKS_DIR.
This brings JavaScriptCore and WebGPU in
line with build settings logic in ANGLE, libwebrtc, PAL, WebCore,
WebInspectorUI, WebKitLegacy, and WebKit. Some of these projects were
changed to have these semantics years ago in <https://commits.webkit.org/r230958>.
Separating WK_ALTERNATE_FRAMEWORKS_DIR from WK_OVERRIDE_FRAMEWORKS_DIR
is valuable for distinguishing between system-installed Mac Catalyst
WebKit and self-contained WebKit builds such as STP.
- Source/JavaScriptCore/Configurations/Base.xcconfig:
- Source/WebGPU/Configurations/Base.xcconfig:
Canonical link: https://commits.webkit.org/250932@main
- 2:37 PM Changeset in webkit [294766] by
-
- 1 edit in trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
[iOS] No message displayed when Parental content filter blocked load
https://bugs.webkit.org/show_bug.cgi?id=240724
Reviewed by Geoffrey Garen.
The request to unblock a load after it has being blocked by the Parental content filter on iOS needs to be
performed in the UI process, since it may show UI. This path does not set the blocked error description on
the content filter like we do in the other path, which is addressed in this patch. This is a regression
from moving the content filtering to the Network process.
- Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::contentFilterDidBlock):
Canonical link: https://commits.webkit.org/250931@main
- 2:36 PM Changeset in webkit [294765] by
-
- 9 edits in branches/safari-7614.1.14.10-branch/Source
Versioning.
WebKit-7614.1.14.10.6
- 2:05 PM Changeset in webkit [294764] by
-
- 6 edits3 adds in trunk
Re-enable HEIC tests
https://bugs.webkit.org/show_bug.cgi?id=240843
<rdar://90658250>
Reviewed by Per Arne Vollan.
Re-enable HEIC tests as although we are not supporting them in web content, we
want to re-enable them as the process they are testing is still being used in
Mail and other apps.
- LayoutTests/fast/images/heic-as-background-image-expected.html: Added.
- LayoutTests/fast/images/heic-as-background-image.html: Added.
- LayoutTests/fast/images/resources/green-400x400.heic: Added.
- LayoutTests/platform/ios/TestExpectations:
- LayoutTests/platform/mac/TestExpectations:
- Source/WebCore/platform/RuntimeApplicationChecks.h:
- Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::CocoaApplication::isWebkitTestRunner):
- Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
Canonical link: https://commits.webkit.org/250930@main
- 1:54 PM Changeset in webkit [294763] by
-
- 4 edits in trunk
Web Inspector: Assertion Failed: Expect an array of string values CSSCompletions.js:39
https://bugs.webkit.org/show_bug.cgi?id=240715
Reviewed by Devin Rousso.
When instantiating
WI.CSSCompletionsinWI.CSSKeywordCompletions.forFunction()
for "var" functions, thevaluesarray is initally empty.
An array of strings was expected.
The actual values are added immediately after instantiation via
WI.CSSCompletions.addValues(). They come from the custom completion provider
referenced by theadditionalFunctionValueCompletionsProvideroption.
There's no reason to have this two step approach. We can provide the result of
additionalFunctionValueCompletionsProvider("var")atWI.CSSCompletions
instantiation.
- Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:
Updated the assertion in the constructor to accept an empty array of values.
One may be returned when requesting CSS variable name completions on a
page without any variables defined.
(WI.CSSCompletions.prototype.addValues): Deleted.
The method can be removed because there are no other callers of
WI.CSSCompletions.addValues().
- Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:
We can concatenate the array of pre-defined values in
WI.CSSKeywordCompletions.forFunction()with the result of
additionalFunctionValueCompletionsProvider()and use the result when
instantiatingWI.CSSCompletions.
- Source/WebInspectorUI/UserInterface/Models/CSSPropertyNameCompletions.js:
(WI.CSSPropertyNameCompletions.prototype.addValues): Deleted.
It was never expected to call
WI.CSSPropertyNameCompletions.addValues()else
it would screw up the fixed list of supported property names instantiated only
once when Web Inspector connects to the backend. The subclass had an assertion
on.addValues()to remind us of this pitfall. This can go away too now.
Canonical link: https://commits.webkit.org/250929@main
- 1:53 PM Changeset in webkit [294762] by
-
- 1 edit in branches/safari-7613.3.1.1-branch/Source/JavaScriptCore/b3/B3ReduceStrength.cpp
Cherry-pick r294563. rdar://problem/93536782
Refine B3ReduceStrength's range for sign extension operations.
https://bugs.webkit.org/show_bug.cgi?id=240720
<rdar://problem/93536782>
Reviewed by Yusuke Suzuki and Keith Miller.
- Source/JavaScriptCore/b3/B3ReduceStrength.cpp:
Canonical link: https://commits.webkit.org/250808@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:47 PM Changeset in webkit [294761] by
-
- 1 edit in trunk/Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.css
Web Inspector: Timelines Tab: Screenshots: white images blend in with the background
https://bugs.webkit.org/show_bug.cgi?id=240848
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.css:
(.timeline-view.screenshots):
(@media (prefers-color-scheme: dark) .timeline-view.screenshots): Added.
Canonical link: https://commits.webkit.org/250928@main
- 1:37 PM Changeset in webkit [294760] by
-
- 1 edit in branches/safari-7613.3.1.0-branch/Source/JavaScriptCore/b3/B3ReduceStrength.cpp
Cherry-pick r294563. rdar://problem/93536782
Refine B3ReduceStrength's range for sign extension operations.
https://bugs.webkit.org/show_bug.cgi?id=240720
<rdar://problem/93536782>
Reviewed by Yusuke Suzuki and Keith Miller.
- Source/JavaScriptCore/b3/B3ReduceStrength.cpp:
Canonical link: https://commits.webkit.org/250808@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:14 PM Changeset in webkit [294759] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Timelines Tab: Screenshots: show placeholder text when there's no images
https://bugs.webkit.org/show_bug.cgi?id=240851
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineView.js:
(WI.ScreenshotsTimelineView.prototype.layout):
- Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
Canonical link: https://commits.webkit.org/250927@main
- 12:43 PM Changeset in webkit [294758] by
-
- 7 edits in trunk/Source/WebCore
Simplify ExpansionBehavior to avoid using getters/setters
https://bugs.webkit.org/show_bug.cgi?id=240823
Patch by Kiet Ho <Kiet Ho> on 2022-05-24
Reviewed by Cameron McCormack.
- Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::applyRunExpansion):
- Source/WebCore/platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::expansionOpportunityCountInternal):
- Source/WebCore/platform/graphics/TextRun.cpp:
- Source/WebCore/platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::calculateAdditionalWidth const):
- Source/WebCore/platform/text/TextFlags.h:
(WebCore::ExpansionBehavior::ExpansionBehavior):
(WebCore::ExpansionBehavior::defaultBehavior):
(WebCore::ExpansionBehavior::allowRightOnly):
(WebCore::ExpansionBehavior::allowLeftOnly):
(WebCore::ExpansionBehavior::forceLeftOnly):
(WebCore::ExpansionBehavior::forbidAll):
(WebCore::ExpansionBehavior::left const): Deleted.
(WebCore::ExpansionBehavior::setLeft): Deleted.
(WebCore::ExpansionBehavior::right const): Deleted.
(WebCore::ExpansionBehavior::setRight): Deleted.
- Source/WebCore/rendering/LegacyInlineTextBox.cpp:
(WebCore::LegacyInlineTextBox::expansionBehavior const):
- Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::expansionBehaviorForInlineTextBox):
(WebCore::applyExpansionBehavior):
Canonical link: https://commits.webkit.org/250926@main
- 12:36 PM Changeset in webkit [294757] by
-
- 2 edits in trunk/Source/WebKit/NetworkProcess/cocoa
Private relay should fail closed for third party loads if the main resource was loaded over private relay
https://bugs.webkit.org/show_bug.cgi?id=240483
Reviewed by Chris Dumez.
This re-lands the change from r293861 along with r293481 except it uses ResourceRequest.firstPartyForCookies
instead of NetworkLoadParameters.topOrigin, which ought to be equivalent but the latter seems less reliable
and has been the cause of performance regressions associated with a few previous attempts at this fix.
- Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
- Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(WebKit::NetworkSessionCocoa::createWebSocketTask):
Canonical link: https://commits.webkit.org/250925@main
- 12:18 PM Changeset in webkit [294756] by
-
- 5 edits3 moves5 adds1 delete in trunk/LayoutTests
Import text-indent tests from WPT
https://bugs.webkit.org/show_bug.cgi?id=240835
Patch by Kiet Ho <Kiet Ho> on 2022-05-24
Reviewed by Tim Nguyen.
Imported directory css/css-text/text-indent from WPT commit
2afc2f61703755c91daaf1a7ddf9ddf868c76699. This includes tests migrated from WebKit
to WPT in PR https://github.com/web-platform-tests/wpt/pull/34153.
- LayoutTests/TestExpectations:
- LayoutTests/fast/css3-text/css3-text-indent/text-indent-each-line-hanging.html: Removed.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-indent/anonymous-flex-item-001-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-indent/anonymous-flex-item-001.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-indent/anonymous-grid-item-001-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-indent/anonymous-grid-item-001.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-indent/text-indent-each-line-hanging-expected.html: Renamed from LayoutTests/fast/css3-text/css3-text-indent/text-indent-each-line-hanging-expected.html.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-indent/text-indent-each-line-hanging.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-indent/text-indent-percentage-002.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-indent/text-indent-percentage-003.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-indent/text-indent-percentage-004.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-indent/text-indent-with-absolute-pos-child-expected.html: Renamed from LayoutTests/fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child-expected.html.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-indent/text-indent-with-absolute-pos-child.html: Renamed from LayoutTests/fast/css3-text/css3-text-indent/text-indent-with-absolute-pos-child.html.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-indent/w3c-import.log:
Canonical link: https://commits.webkit.org/250924@main
- 12:12 PM Changeset in webkit [294755] by
-
- 4 edits in trunk/Source/WebCore
Start using min/max content size for flexing
https://bugs.webkit.org/show_bug.cgi?id=240872
Reviewed by Antti Koivisto.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::updateFormattingRootGeometryAndInvalidate):
(WebCore::LayoutIntegration::FlexLayout::updateFlexItemDimensions):
- Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.h:
- Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutUsingFlexFormattingContext):
Canonical link: https://commits.webkit.org/250923@main
- 11:48 AM Changeset in webkit [294754] by
-
- 2 edits2 adds4 deletes in trunk
REGRESSION (r292532): pge.com: Unable to focus on any of the inputs
https://bugs.webkit.org/show_bug.cgi?id=240832
<rdar://92538460>
Reviewed by Simon Fraser.
This is a revert of r292532. Blank float avoiders (used width = 0px) do fit even when the available space is zero. We have to find a different way to address the float fitting issue in contain-inline-size-bfc-floats-001.html (though I am not convinced that the expected result is correct anymore).
- LayoutTests/TestExpectations:
- LayoutTests/fast/block/float/zero-size-float-avoider-incorrect-position-expected.html: Added.
- LayoutTests/fast/block/float/zero-size-float-avoider-incorrect-position.html: Added.
- Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::getClearDelta):
Canonical link: https://commits.webkit.org/250922@main
- 10:28 AM Changeset in webkit [294753] by
-
- 3 edits2 adds in trunk
isContentEditable returns false for
display:nonecontenteditable elements, but true for children
https://bugs.webkit.org/show_bug.cgi?id=240834
Reviewed by Ryosuke Niwa.
- Source/WebCore/dom/Node.cpp:
(WebCore::computeEditabilityFromComputedStyle):
Remove adisplay: nonecheck. This check is wrong for two reasons:
1) It only consults the style of the immediate element, not whether or not
that element is in a
display: nonesubtree. This regressed in r160966.
This causes a confusing situation wheredisplay: noneaffects the editability
of only the element it is directly applied to.
2) isContentEditable is not specified to be affected by
display: none.
- LayoutTests/editing/editability/isContentEditable-in-display-none-expected.txt: Added.
- LayoutTests/editing/editability/isContentEditable-in-display-none.html: Added.
Add a test that dumps the editability of a variety of different configurations of
contenteditable elements and their children.
Before this change, this test would have said that #nonVisible (the display: none
contenteditable element) was read-only, but its child <p> was editable. Now we
agree with Gecko and Blink who both say that both are editable.
- LayoutTests/fast/events/event-input-contentEditable-expected.txt:
- LayoutTests/fast/events/event-input-contentEditable.html:
Adjust this test to expect an input event to be dispatched for programmatic
editing in display: none elements. Also add a sub-test that checks the same,
but in a child element.
Before this change, we would not dispatch an input event to the display: none
contenteditable itself, but *would* dispatch an input event for input into a child element.
Now we agree with Gecko, who dispatch events in both cases.
Canonical link: https://commits.webkit.org/250921@main
- 9:57 AM Changeset in webkit [294752] by
-
- 2 edits2 adds in trunk
REGRESSION (r289032): rotate animation doesn't interpolate between 0 and 1turn without forced 50% https://bugs.webkit.org/show_bug.cgi?id=239906
Reviewed by Simon Fraser.
When using CoreAnimation non-matrix animations to animate rotations,
CoreAnimation will use the shortest direction between two rotation
angles. This means that a rotation from 0 to 360 will not rotate at all.
This is different from how CSS works, where it expects the animation to
do a full turn. In order to avoid problems with this difference, when an
animation includes larger angles (> 180 degrees), fall back to software
animation.
No new tests. It is difficult to make a test for this because
when pausing animations the software path is used.
- LayoutTests/animations/3d/full-rotation-animation-expected.html: Added.
- LayoutTests/animations/3d/full-rotation-animation.html: Added.
- Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::transformationAnimationValueAt):
(WebCore::hasBigRotationAngle):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
- Source/WebCore/platform/graphics/transforms/TransformOperations.h:
(WebCore::SharedPrimitivesPrefix::primitives const):
(WebCore::SharedPrimitivesPrefix::primitives): Deleted.
Canonical link: https://commits.webkit.org/250920@main
- 9:39 AM Changeset in webkit [294751] by
-
- 1 edit in trunk/Tools/CISupport/build-webkit-org/master.cfg
[build.webkit.org] Allow configuring multiple user credentials
https://bugs.webkit.org/show_bug.cgi?id=240826
Reviewed by Aakash Jain.
Allow configuring multiple user credentials for build.webkit.org as we
did for ews-build.webkit.org in 246332@main. This also loads credentials
from passwords.json instead of environment variables.
- Tools/CISupport/build-webkit-org/master.cfg:
Canonical link: https://commits.webkit.org/250919@main
- 9:15 AM Changeset in webkit [294750] by
-
- 1 edit in trunk/Source/WTF/wtf/FastBitVector.cpp
Avoid unnecessary calls to fastZeroedMalloc() in FastBitVector
https://bugs.webkit.org/show_bug.cgi?id=240812
Reviewed by Yusuke Suzuki.
We were calling fastZeroedMalloc() which would allocate the memory and memset it to 0,
only to then overwrite all (or most) of that memory with memcpy().
- Source/WTF/wtf/FastBitVector.cpp:
(WTF::FastBitVectorWordOwner::setEqualsSlow):
(WTF::FastBitVectorWordOwner::resizeSlow):
Canonical link: https://commits.webkit.org/250918@main
- 9:14 AM Changeset in webkit [294749] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations
[Gardening]: [ Monterey wk2 debug ] WebGL conformance tests are a flaky time out
https://bugs.webkit.org/show_bug.cgi?id=239386
<rdar://91807783>
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250917@main
- 8:38 AM Changeset in webkit [294748] by
-
- 1 add in trunk/Tools/Scripts/hooks/pre-commit
[GitHub] git-webkit pr doesn't sort Xcode project files before uploading
https://bugs.webkit.org/show_bug.cgi?id=239975
<rdar://92976140>
Reviewed by Chris Dumez.
- Tools/Scripts/hooks/pre-commit: Sort Xcode project files on commit.
Canonical link: https://commits.webkit.org/250916@main
- 8:24 AM Changeset in webkit [294747] by
-
- 1 edit in trunk/Source/WebCore/page/ImageAnalysisQueue.cpp
ImageAnalysisTests.AnalyzeDynamicallyLoadedImages is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=240847
rdar://93268890
Reviewed by Tim Horton.
This API test was created to verify that ImageAnalysisQueue detects and enqueues images that are
inserted into the document via script, after-_startImageAnalysis:has been invoked. Currently, it
occasionally times out, when the logic inImageAnalysisQueue::enqueueIfNeededto reject tiny
(< 20 by 20) images from the analysis queue falsely prevents us from enqueueing the newly inserted
image element.
Note that
enqueueIfNeededis called after the image has finished loading (i.e., dispatched its
"load" event for the new image). However, in this state, the image element's renderer hasn't
necessarily been laid out yet since its image source has changed, which means that the actual size
of the renderer might still be empty (0 by 0) when invokingenqueueIfNeeded. Since we currently
consultRenderBox::size()on theRenderImagein this method, we end up bailing too early.
Instead of checking the size of the renderer, we should be checking the size of the image instead
since the image itself is what's used to generate the bitmap image, over which we'll eventually run
image analysis. Unlike the renderer, this cached image's size doesn't depend on layout, and is
guaranteed to be up to date when the image has finished loading. This also allows us to simplify the
logic here -- since nullWebCore::Images are empty, checking that both the width and height of the
image are at least 20 is sufficient to avoid queueing null images for analysis.
- Source/WebCore/page/ImageAnalysisQueue.cpp:
(WebCore::ImageAnalysisQueue::enqueueIfNeeded):
Canonical link: https://commits.webkit.org/250915@main
- 8:01 AM Changeset in webkit [294746] by
-
- 4 edits in trunk/Source/WebCore
Remove unused RenderTheme video-related methods
https://bugs.webkit.org/show_bug.cgi?id=240862
Reviewed by Antoine Quint.
- Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::hasVerticalAppearance):
- Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::formatMediaControlsTime const): Deleted.
(WebCore::RenderTheme::formatMediaControlsCurrentTime const): Deleted.
(WebCore::RenderTheme::formatMediaControlsRemainingTime const): Deleted.
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton const): Deleted.
- Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::supportsClosedCaptioning const): Deleted.
(WebCore::RenderTheme::hasOwnDisabledStateHandlingFor const): Deleted.
(WebCore::RenderTheme::usesMediaControlStatusDisplay): Deleted.
(WebCore::RenderTheme::usesMediaControlVolumeSlider const): Deleted.
(WebCore::RenderTheme::usesVerticalVolumeSlider const): Deleted.
(WebCore::RenderTheme::mediaControlsFadeInDuration): Deleted.
(WebCore::RenderTheme::mediaControlsFadeOutDuration): Deleted.
- Source/WebCore/rendering/RenderThemeMac.h:
(WebCore::RenderThemeMac::supportsClosedCaptioning const final): Deleted.
Canonical link: https://commits.webkit.org/250914@main
- 7:31 AM Changeset in webkit [294745] by
-
- 54 edits2 copies in trunk
[LBSE] Add support for <circle> & <ellipse>
https://bugs.webkit.org/show_bug.cgi?id=240793
Patch by Nikolas Zimmermann <nzimmermann@igalia.com> on 2022-05-24
Reviewed by Rob Buis.
Rename RenderSVGEllipse -> LegacyRenderSVGEllipse and adapt callees.
Re-introduce RenderSVGEllipse for LBSE, and activate renderer creation
for <circle> & <ellipse>, if LBSE is enabled at run-time.
This allows 14 more SVG 1.1 testcases to pass.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/TestExpectations:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
- Source/WebCore/Sources.txt:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Source/WebCore/rendering/svg/LegacyRenderSVGEllipse.cpp: Copied from Source/WebCore/rendering/svg/RenderSVGEllipse.cpp.
(WebCore::LegacyRenderSVGEllipse::LegacyRenderSVGEllipse):
(WebCore::LegacyRenderSVGEllipse::updateShapeFromElement):
(WebCore::LegacyRenderSVGEllipse::calculateRadiiAndCenter):
(WebCore::LegacyRenderSVGEllipse::fillShape const):
(WebCore::LegacyRenderSVGEllipse::strokeShape const):
(WebCore::LegacyRenderSVGEllipse::shapeDependentStrokeContains):
(WebCore::LegacyRenderSVGEllipse::shapeDependentFillContains const):
(WebCore::LegacyRenderSVGEllipse::isRenderingDisabled const):
- Source/WebCore/rendering/svg/LegacyRenderSVGEllipse.h: Copied from Source/WebCore/rendering/svg/RenderSVGEllipse.h.
- Source/WebCore/rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::RenderSVGEllipse):
(WebCore::RenderSVGEllipse::updateShapeFromElement):
(WebCore::RenderSVGEllipse::fillShape const):
(WebCore::RenderSVGEllipse::strokeShape const):
(WebCore::RenderSVGEllipse::shapeDependentStrokeContains):
(WebCore::RenderSVGEllipse::shapeDependentFillContains const):
- Source/WebCore/rendering/svg/RenderSVGEllipse.h:
- Source/WebCore/svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::createElementRenderer):
- Source/WebCore/svg/SVGElement.cpp:
(WebCore::createSVGLayerAwareElementSet):
- Source/WebCore/svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::createElementRenderer):
Canonical link: https://commits.webkit.org/250913@main
- 7:22 AM Changeset in webkit [294744] by
-
- 3 edits2 adds in trunk
Obey intrinsic min-height in nested column flex container
https://bugs.webkit.org/show_bug.cgi?id=240068
Reviewed by Sergio Villar Senin.
Fixes a regression from bug 230755. An intrinsic min-height should make
a column flex container grow enough for its contents, even if it's also
a flex item with a small definite flex-basis like 0px.
Test: imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-height-flex-items-031.html
Canonical link: https://commits.webkit.org/250912@main
- 6:34 AM Changeset in webkit [294743] by
-
- 1 edit in trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp
[sqlite] Remove superfluous assertion
https://bugs.webkit.org/show_bug.cgi?id=240869
Reviewed by NOBODY (OOPS!).
Span::size() always returns a non-negative value, so checking
that the blob's size is greater than zero is unnecessary.
- Source/WebCore/platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::bindBlob):
- 6:08 AM Changeset in webkit [294742] by
-
- 3 edits in trunk/LayoutTests
canvas-createPattern-video-modify.html is an intermittent failure
https://bugs.webkit.org/show_bug.cgi?id=240780
rdar://93731906
Reviewed by Youenn Fablet.
The tests relied on the event "loadeddata" to be fired to check if the first video frame got painted.
However, at present there's no guarantee that a frame would have been painted at the time this event is fired.
This issue is separately tracked in bug 240779
So instead we use the new requestVideoCallbackFrame API which is designed specifically for this case.
We also simplify the existing page, using more modern JS features.
- LayoutTests/fast/canvas/canvas-createPattern-video-loading.html:
- LayoutTests/fast/canvas/canvas-createPattern-video-modify.html:
- LayoutTests/media/utilities.js:
(once):
(fetchWithXHR):
(waitForVideoFrame):
(waitForVideoFrameUntil):
Canonical link: https://commits.webkit.org/250910@main
- 5:31 AM EnvironmentVariables edited by
- (diff)
- 5:29 AM EnvironmentVariables edited by
- Add WEBKIT_GST_ENABLE_LEGACY_VAAPI (diff)
- 1:17 AM Changeset in webkit [294741] by
-
- 41 edits4 deletes in trunk/LayoutTests/platform
[WPE] Unreviewed test gardening, update baselines
May 23, 2022:
- 11:17 PM Changeset in webkit [294740] by
-
- 8 edits2 adds in branches/safari-7614.1.14.0-branch
Cherry-pick r294186. rdar://problem/93805727
Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence
https://bugs.webkit.org/show_bug.cgi?id=240365
Reviewed by Chris Fleizach.
Source/WebCore:
We can get infinite recursion when accessibilityIsIgnored is called as
part of computing AccessibilityObject::ignoredFromModalPresence. One
example of such a cycle:
AXObjectCache::currentModalNode() ->
AccessibilityRenderObject::computeAccessibilityIsIgnored() ->
AccessibilityRenderObject::parentObjectUnignored() ->
AccessibilityObject::accessibilityIsIgnored() ->
AccessibilityObject::ignoredFromModalPresence() ->
AXObjectCache::currentModalNode() ->
...repeat...
This patch fixes this by tracking when we start computing the current
modal node in the AXObjectCache. Then, in AccessibilityObject::accessibilityIsIgnored(),
we don't call AccessibilityObject::ignoredFromModalPresence() if this new state is true,
since in this context we only need to know if the object is inherently
ignored (i.e. ignored disregarding modal presence).
Test: accessibility/aria-modal-with-text-crash.html
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::currentModalNode):
- accessibility/AXObjectCache.h: Add m_isRetrievingCurrentModalNode. (WebCore::AXObjectCache::isRetrievingCurrentModalNode): Added.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessibilityIsIgnored const): Don't call ignoredFromModalPresence if we're in the midst of computing the current modal.
LayoutTests:
- accessibility/aria-modal-with-text-crash-expected.txt: Added.
- accessibility/aria-modal-with-text-crash.html: Added.
- platform/glib/TestExpectations: Skip new test.
- platform/ios/TestExpectations: Enable new test.
- platform/win/TestExpectations: Skip new test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:14 PM Changeset in webkit [294739] by
-
- 8 edits2 adds in branches/safari-7614.1.14.1-branch
Cherry-pick r294186. rdar://problem/93805727
Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence
https://bugs.webkit.org/show_bug.cgi?id=240365
Reviewed by Chris Fleizach.
Source/WebCore:
We can get infinite recursion when accessibilityIsIgnored is called as
part of computing AccessibilityObject::ignoredFromModalPresence. One
example of such a cycle:
AXObjectCache::currentModalNode() ->
AccessibilityRenderObject::computeAccessibilityIsIgnored() ->
AccessibilityRenderObject::parentObjectUnignored() ->
AccessibilityObject::accessibilityIsIgnored() ->
AccessibilityObject::ignoredFromModalPresence() ->
AXObjectCache::currentModalNode() ->
...repeat...
This patch fixes this by tracking when we start computing the current
modal node in the AXObjectCache. Then, in AccessibilityObject::accessibilityIsIgnored(),
we don't call AccessibilityObject::ignoredFromModalPresence() if this new state is true,
since in this context we only need to know if the object is inherently
ignored (i.e. ignored disregarding modal presence).
Test: accessibility/aria-modal-with-text-crash.html
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::currentModalNode):
- accessibility/AXObjectCache.h: Add m_isRetrievingCurrentModalNode. (WebCore::AXObjectCache::isRetrievingCurrentModalNode): Added.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessibilityIsIgnored const): Don't call ignoredFromModalPresence if we're in the midst of computing the current modal.
LayoutTests:
- accessibility/aria-modal-with-text-crash-expected.txt: Added.
- accessibility/aria-modal-with-text-crash.html: Added.
- platform/glib/TestExpectations: Skip new test.
- platform/ios/TestExpectations: Enable new test.
- platform/win/TestExpectations: Skip new test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:13 PM Changeset in webkit [294738] by
-
- 9 edits in branches/safari-7614.1.14.0-branch/Source
Versioning.
WebKit-7614.1.14.0.10
- 11:10 PM Changeset in webkit [294737] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.10
- 11:00 PM Changeset in webkit [294736] by
-
- 3 edits2 adds in trunk
REGRESSION (r294291): Another nullptr crash with ::first-letter
https://bugs.webkit.org/show_bug.cgi?id=240795
<rdar://93645746>
Reviewed by Alan Bujtas.
- LayoutTests/fast/css/first-letter-remove-crash-expected.txt: Added.
- LayoutTests/fast/css/first-letter-remove-crash.html: Added.
- LayoutTests/fast/css/first-letter-removed-added-expected.txt:
- Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::RenderTreeBuilder::FirstLetter::updateStyle):
We should always find :first-letter style when we get here.
- Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):
Rebuild the renderer subtree if ::first-letter pseudo-class stops applying.
Canonical link: https://commits.webkit.org/250908@main
- 10:38 PM Changeset in webkit [294735] by
-
- 1 edit in branches/safari-7613.3.1.0-branch/Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
Unreviewed build fix. rdar://problem/87980543
Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:247:36:|error: no matching constructor for initialization of 'WebCore::FEImage::SourceImage &&' (aka 'variant<Ref<WebCore::Image>, Ref<WebCore::ImageBuffer>, ObjectIdentifier<WebCore::RenderingResourceIdentifierType>> &&')
- 10:38 PM Changeset in webkit [294734] by
-
- 7 edits in branches/safari-7613.3.1.0-branch/Source
Cherry-pick r294280. rdar://problem/87980543
This reverts r294694.
- 10:36 PM Changeset in webkit [294733] by
-
- 9 edits in branches/safari-7613.3.1.0-branch/Source
Versioning.
WebKit-7613.3.1.0.4
- 10:28 PM Changeset in webkit [294732] by
-
- 1 edit in branches/safari-7613.3.1.1-branch/Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
Unreviewed build fix. rdar://87980543
Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:247:36:|error: no matching constructor for initialization of 'WebCore::FEImage::SourceImage &&' (aka 'variant<Ref<WebCore::Image>, Ref<WebCore::ImageBuffer>, ObjectIdentifier<WebCore::RenderingResourceIdentifierType>> &&')
- 10:26 PM Changeset in webkit [294731] by
-
- 7 edits in branches/safari-7613.3.1.1-branch/Source
Cherry-pick r294280. rdar://problem/87980543
This reverts r294684.
- 10:24 PM Changeset in webkit [294730] by
-
- 9 edits in branches/safari-7613.3.1.1-branch/Source
Versioning.
WebKit-7613.3.1.1.4
- 10:13 PM Changeset in webkit [294729] by
-
- 2 edits in trunk
REGRESSION (250413@main): [ iOS ] system-preview/badge.html is a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=240352
rdar://93191053
Patch by Antoine Quint <Antoine Quint> on 2022-05-23
Reviewed by Simon Fraser.
In the case of an ARKit image, we should only be returning when we don't
have a native image to record, otherwise the system image itself needs
to be recorded as well.
- LayoutTests/platform/ios-wk2/TestExpectations:
- Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawSystemImage):
Canonical link: https://commits.webkit.org/250907@main
- 10:09 PM Changeset in webkit [294728] by
-
- 5 edits in trunk/Source/WebCore
Remove RenderSliderThumb
https://bugs.webkit.org/show_bug.cgi?id=240794
Reviewed by Antti Koivisto.
Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
- Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::resolveCustomStyle):
(WebCore::SliderContainerElement::resolveCustomStyle):
(WebCore::RenderSliderThumb::RenderSliderThumb): Deleted.
(WebCore::RenderSliderThumb::updateAppearance): Deleted.
(WebCore::RenderSliderThumb::isSliderThumb const): Deleted.
(WebCore::SliderThumbElement::createElementRenderer): Deleted.
- Source/WebCore/html/shadow/SliderThumbElement.h:
- Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::isSlider const):
(WebCore::RenderObject::isSliderThumb const): Deleted.
- Source/WebCore/rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout): Deleted.
- Source/WebCore/rendering/RenderSlider.h:
Canonical link: https://commits.webkit.org/250906@main
- 9:09 PM Changeset in webkit [294727] by
-
- 1 edit2 deletes in trunk/LayoutTests/platform/glib
[GLIB] Unreviewed test gardening, update expectations after r293691
- 9:00 PM Changeset in webkit [294726] by
-
- 3 edits in trunk
Fix webpushd crash when removing notification permissions
https://bugs.webkit.org/show_bug.cgi?id=240737
Reviewed by Chris Dumez and Geoffrey Garen.
When removing notification permissions for an origin, webpushd crashes because of a RELEASE_ASSERT
that fires in AppBundleRequest::start when INSTALL_COORDINATION_BUNDLES isn't enabled and mock
bundles aren't enabled.
Fix this by removing the calls into AppBundleRequest when INSTALL_COORDINATION_BUNDLES isn't enabled.
Those requests are only meant to run when that feature is enabled.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm: Only run the permission management test when INSTALL_COORDINATION_BUNDLES is enabled (e.g. on iOS); that is the only time it makes sense to test that codepath.
- Source/WebKit/webpushd/WebPushDaemon.h:
- Source/WebKit/webpushd/WebPushDaemon.mm:
(WebPushD::Daemon::deletePushRegistration):
(WebPushD::Daemon::deletePushAndNotificationRegistration):
Canonical link: https://commits.webkit.org/250904@main
- 8:53 PM Changeset in webkit [294725] by
-
- 1 copy in tags/WebKit-7614.1.14.11.3
Tag WebKit-7614.1.14.11.3.
- 8:50 PM Changeset in webkit [294724] by
-
- 9 edits in branches/safari-7614.1.14.11-branch/Source
Versioning.
WebKit-7614.1.14.11.3
- 8:11 PM Changeset in webkit [294723] by
-
- 1 copy in tags/WebKit-7614.1.14.10.5
Tag WebKit-7614.1.14.10.5.
- 8:10 PM Changeset in webkit [294722] by
-
- 9 edits in branches/safari-7614.1.14.10-branch/Source
Versioning.
WebKit-7614.1.14.10.5
- 8:06 PM Changeset in webkit [294721] by
-
- 2 edits10 moves in trunk/LayoutTests/platform
[WPE] Unreviewed test gardening, fix missing baselines reported by test bot
- 8:02 PM Changeset in webkit [294720] by
-
- 1 copy in tags/WebKit-7613.3.1.0.3
Tag WebKit-7613.3.1.0.3.
- 8:00 PM Changeset in webkit [294719] by
-
- 1 delete in tags/WebKit-7613.3.1.0.3
Delete tag.
- 7:45 PM Changeset in webkit [294718] by
-
- 1 copy in tags/WebKit-7614.1.14.10.4
Tag WebKit-7614.1.14.10.4.
- 7:43 PM Changeset in webkit [294717] by
-
- 1 copy in tags/WebKit-7613.3.1.1.3
Tag WebKit-7613.3.1.1.3.
- 7:40 PM Changeset in webkit [294716] by
-
- 1 edit in trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
Web Inspector: Network Table: activity is not marked as a previous session when the Network Tab is not selected
https://bugs.webkit.org/show_bug.cgi?id=240846
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._mainResourceDidChange):
(WI.NetworkTableContentView.prototype._entryForResource):
Also markWI.Resourcethat haven't yet been inserted into theWI.Tablewhen navigating the main
resource. Use this when generating an entry for thatWI.Resourcefor the first time, instead of
always assuming that theWI.Resourceis part of the current session.
Canonical link: https://commits.webkit.org/250902@main
- 7:39 PM Changeset in webkit [294715] by
-
- 9 edits in branches/safari-7614.1.14.10-branch/Source
Versioning.
WebKit-7614.1.14.10.4
- 7:06 PM Changeset in webkit [294714] by
-
- 1 edit2 adds in trunk
Breaking out of a quoted reply block by inserting a new paragraph should reset writing direction
https://bugs.webkit.org/show_bug.cgi?id=240778
rdar://14839536
Reviewed by Devin Rousso.
The process of breaking out of a
blockquotevia the "InsertNewlineInQuotedContent" editor command currently works by
splitting theblockquoteinto two sibling elements underneath the same parent container, and then inserting abr
element in between these siblingblockquoteelements. The selection is then moved to the end of the newly created
br, which inherits the writing direction (dir) of the element containing theblockquote. In the case of Mail, if
the system language is right-to-left but the quoted content is left-to-right, this can lead to some unintuitive behavior
when breaking out of quoted LTR content, since the newly created line break will inherit the right-to-left direction of
its ancestor.
To fix this, in the case where we're breaking out of a
blockquoteand the start of the selection is left-to-right but
the element that contains theblockquoteis right-to-left, we can wrap thebrin another block-level container
element withdir=autoto avoid inheriting the writing direction from theblockquote's ancestor. This means that the
writing direction of the newly inserted paragraph will automatically be determined by what the user types.
Test: editing/execCommand/reset-direction-after-breaking-blockquote.html
- LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote-expected.txt: Added.
- LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote.html: Added.
- Source/WebCore/editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
Canonical link: https://commits.webkit.org/250901@main
- 6:44 PM Changeset in webkit [294713] by
-
- 1 edit in branches/safari-7613.3.1.0-branch/Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
Revert build fix. rdar://problem/87980543
This reverts r294685.
- 6:42 PM Changeset in webkit [294712] by
-
- 1 copy in tags/WebKit-7613.3.1.0.3
Tag WebKit-7613.3.1.0.3.
- 6:04 PM Changeset in webkit [294711] by
-
- 1 copy in tags/WebKit-7613.3.1.3.1
Tag WebKit-7613.3.1.3.1.
- 6:03 PM Changeset in webkit [294710] by
-
- 8 edits2 adds in branches/safari-7613.3.1.3-branch
Cherry-pick r294186. rdar://problem/93213436
Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence
https://bugs.webkit.org/show_bug.cgi?id=240365
Reviewed by Chris Fleizach.
Source/WebCore:
We can get infinite recursion when accessibilityIsIgnored is called as
part of computing AccessibilityObject::ignoredFromModalPresence. One
example of such a cycle:
AXObjectCache::currentModalNode() ->
AccessibilityRenderObject::computeAccessibilityIsIgnored() ->
AccessibilityRenderObject::parentObjectUnignored() ->
AccessibilityObject::accessibilityIsIgnored() ->
AccessibilityObject::ignoredFromModalPresence() ->
AXObjectCache::currentModalNode() ->
...repeat...
This patch fixes this by tracking when we start computing the current
modal node in the AXObjectCache. Then, in AccessibilityObject::accessibilityIsIgnored(),
we don't call AccessibilityObject::ignoredFromModalPresence() if this new state is true,
since in this context we only need to know if the object is inherently
ignored (i.e. ignored disregarding modal presence).
Test: accessibility/aria-modal-with-text-crash.html
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::currentModalNode):
- accessibility/AXObjectCache.h: Add m_isRetrievingCurrentModalNode. (WebCore::AXObjectCache::isRetrievingCurrentModalNode): Added.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessibilityIsIgnored const): Don't call ignoredFromModalPresence if we're in the midst of computing the current modal.
LayoutTests:
- accessibility/aria-modal-with-text-crash-expected.txt: Added.
- accessibility/aria-modal-with-text-crash.html: Added.
- platform/glib/TestExpectations: Skip new test.
- platform/ios/TestExpectations: Enable new test.
- platform/win/TestExpectations: Skip new test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 6:03 PM Changeset in webkit [294709] by
-
- 9 edits in branches/safari-7613.3.1.3-branch/Source
Versioning.
WebKit-7613.3.1.3.1
- 5:55 PM Changeset in webkit [294708] by
-
- 1 copy in tags/WebKit-7614.1.14.1.9
Tag WebKit-7614.1.14.1.9.
- 5:54 PM Changeset in webkit [294707] by
-
- 1 copy in tags/WebKit-7613.3.1.2.1
Tag WebKit-7613.3.1.2.1.
- 5:53 PM Changeset in webkit [294706] by
-
- 8 edits2 adds in branches/safari-7613.3.1.2-branch
Cherry-pick r294186. rdar://problem/93213436
Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence
https://bugs.webkit.org/show_bug.cgi?id=240365
Reviewed by Chris Fleizach.
Source/WebCore:
We can get infinite recursion when accessibilityIsIgnored is called as
part of computing AccessibilityObject::ignoredFromModalPresence. One
example of such a cycle:
AXObjectCache::currentModalNode() ->
AccessibilityRenderObject::computeAccessibilityIsIgnored() ->
AccessibilityRenderObject::parentObjectUnignored() ->
AccessibilityObject::accessibilityIsIgnored() ->
AccessibilityObject::ignoredFromModalPresence() ->
AXObjectCache::currentModalNode() ->
...repeat...
This patch fixes this by tracking when we start computing the current
modal node in the AXObjectCache. Then, in AccessibilityObject::accessibilityIsIgnored(),
we don't call AccessibilityObject::ignoredFromModalPresence() if this new state is true,
since in this context we only need to know if the object is inherently
ignored (i.e. ignored disregarding modal presence).
Test: accessibility/aria-modal-with-text-crash.html
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::currentModalNode):
- accessibility/AXObjectCache.h: Add m_isRetrievingCurrentModalNode. (WebCore::AXObjectCache::isRetrievingCurrentModalNode): Added.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessibilityIsIgnored const): Don't call ignoredFromModalPresence if we're in the midst of computing the current modal.
LayoutTests:
- accessibility/aria-modal-with-text-crash-expected.txt: Added.
- accessibility/aria-modal-with-text-crash.html: Added.
- platform/glib/TestExpectations: Skip new test.
- platform/ios/TestExpectations: Enable new test.
- platform/win/TestExpectations: Skip new test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:47 PM Changeset in webkit [294705] by
-
- 9 edits in branches/safari-7613.3.1.2-branch/Source
Versioning.
WebKit-7613.3.1.2.1
- 5:41 PM Changeset in webkit [294704] by
-
- 1 copy in tags/WebKit-7614.1.14.0.9
Tag WebKit-7614.1.14.0.9.
- 5:33 PM Changeset in webkit [294703] by
-
- 1 edit in trunk/metadata/contributors.json
Add Said Abou-Hallawa's GitHub to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240840
Unreviewed.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250900@main
- 5:27 PM Changeset in webkit [294702] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk1/TestExpectations
[Gardening]: REGRESSION (r294610): [ macOS wk1 ] Two fast/forms/ tests are a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240841
<rdar://93794351>
Unreviewed test gardening.
- LayoutTests/platform/mac-wk1/TestExpectations:
Canonical link: https://commits.webkit.org/250899@main
- 5:12 PM Changeset in webkit [294701] by
-
- 1 copy in branches/safari-7613.3.1.3-branch
New branch.
- 5:11 PM Changeset in webkit [294700] by
-
- 1 copy in branches/safari-7613.3.1.2-branch
New branch.
- 5:00 PM Changeset in webkit [294699] by
-
- 19 edits in trunk/Source/WebCore
RenderObject::containerForRepaint should be able to tell if a full repaint has already been scheduled.
https://bugs.webkit.org/show_bug.cgi?id=240721
Reviewed by Simon Fraser.
This patch is in preparation for reducing redundant repaints when an ancestor layer (between the renderer and the repaint container) has already been scheduled for one.
- Source/WebCore/editing/SelectionGeometryGatherer.cpp:
(WebCore::SelectionGeometryGatherer::addQuad):
(WebCore::SelectionGeometryGatherer::addGapRects):
- Source/WebCore/editing/SelectionGeometryGatherer.h:
- Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::isEnclosedInCompositingLayer const):
- Source/WebCore/rendering/LayoutRepainter.cpp:
(WebCore::LayoutRepainter::LayoutRepainter):
(WebCore::LayoutRepainter::repaintAfterLayout):
- Source/WebCore/rendering/LayoutRepainter.h:
- Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::layoutRunsAndFloats):
- Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::issueRepaintForOutlineAuto):
- Source/WebCore/rendering/RenderFragmentedFlow.cpp:
(WebCore::RenderFragmentedFlow::mapLocalToContainer const):
- Source/WebCore/rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
- Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::recursiveUpdateLayerPositions):
(WebCore::RenderLayer::computeRepaintRectsIncludingDescendants):
(WebCore::RenderLayer::recursiveUpdateLayerPositionsAfterScroll):
(WebCore::RenderLayer::setHasVisibleContent):
(WebCore::RenderLayer::calculateClipRects const):
- Source/WebCore/rendering/RenderLayer.h:
- Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::repaintOnCompositingChange):
- Source/WebCore/rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
- Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::scrollTo):
- Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint const):
(WebCore::RenderObject::repaint const):
(WebCore::RenderObject::repaintRectangle const):
(WebCore::RenderObject::repaintSlowRepaintObject const):
- Source/WebCore/rendering/RenderObject.h:
- Source/WebCore/rendering/RenderSelectionInfo.cpp:
(WebCore::RenderSelectionInfoBase::RenderSelectionInfoBase):
- Source/WebCore/rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfoBase::repaintContainer const):
- Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::repaintRootContents):
Canonical link: https://commits.webkit.org/250898@main
- 4:58 PM Changeset in webkit [294698] by
-
- 1 copy in tags/WebKit-7614.1.14.2.4
Tag WebKit-7614.1.14.2.4.
- 4:57 PM Changeset in webkit [294697] by
-
- 8 edits2 adds in branches/safari-7614.1.14.2-branch
Cherry-pick r294186. rdar://problem/93213436
Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence
https://bugs.webkit.org/show_bug.cgi?id=240365
Reviewed by Chris Fleizach.
Source/WebCore:
We can get infinite recursion when accessibilityIsIgnored is called as
part of computing AccessibilityObject::ignoredFromModalPresence. One
example of such a cycle:
AXObjectCache::currentModalNode() ->
AccessibilityRenderObject::computeAccessibilityIsIgnored() ->
AccessibilityRenderObject::parentObjectUnignored() ->
AccessibilityObject::accessibilityIsIgnored() ->
AccessibilityObject::ignoredFromModalPresence() ->
AXObjectCache::currentModalNode() ->
...repeat...
This patch fixes this by tracking when we start computing the current
modal node in the AXObjectCache. Then, in AccessibilityObject::accessibilityIsIgnored(),
we don't call AccessibilityObject::ignoredFromModalPresence() if this new state is true,
since in this context we only need to know if the object is inherently
ignored (i.e. ignored disregarding modal presence).
Test: accessibility/aria-modal-with-text-crash.html
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::currentModalNode):
- accessibility/AXObjectCache.h: Add m_isRetrievingCurrentModalNode. (WebCore::AXObjectCache::isRetrievingCurrentModalNode): Added.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessibilityIsIgnored const): Don't call ignoredFromModalPresence if we're in the midst of computing the current modal.
LayoutTests:
- accessibility/aria-modal-with-text-crash-expected.txt: Added.
- accessibility/aria-modal-with-text-crash.html: Added.
- platform/glib/TestExpectations: Skip new test.
- platform/ios/TestExpectations: Enable new test.
- platform/win/TestExpectations: Skip new test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:55 PM Changeset in webkit [294696] by
-
- 9 edits in branches/safari-7614.1.14.2-branch/Source
Versioning.
WebKit-7614.1.14.2.4
- 4:42 PM Changeset in webkit [294695] by
-
- 4 edits2 adds in trunk
Web Inspector: Layout panel doesn't always match visible nodes/order of nodes in document
https://bugs.webkit.org/show_bug.cgi?id=240775
rdar://93727833
Reviewed by Devin Rousso.
There were a couple issues preventing the layout panel from showing nodes that could actually have an overlay shown in
a predictable order.
First, DOMManager.prototype.nodesWithLayoutContextType provided an array of nodes sorted by nodeId, not their order in
the document. This meant that nodes created later and inserted into the page did not get placed in their logical order
relative to other containers, but at the end of the list. This is fixed with a new iterator that iterated through the
document and its tree in a way the preserves the order of elements as they would appear in a Tree view.
Second, LayoutDetailsSidebarPanel was not instrumenting the insertion/deletion of nodes, which meant that a node with a
layout context could be removed from the DOM tree, but still exist. These nodes weren't actually useful in the list
because you can't turn on the overlay for them. A similar issue existed for inserting a known node back into the DOM
tree.
Also fix an assertion reached from NodeOverlayListSection when toggling all overlays off.
- Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.prototype.attachedNodes):
(WI.DOMManager.prototype.nodesWithLayoutContextType):
- Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js:
(WI.LayoutDetailsSidebarPanel.prototype.attached):
(WI.LayoutDetailsSidebarPanel.prototype.detached):
(WI.LayoutDetailsSidebarPanel.prototype._handleNodeInserted):
(WI.LayoutDetailsSidebarPanel.prototype._handleNodeRemoved):
(WI.LayoutDetailsSidebarPanel.prototype._handleLayoutContextTypeChanged):
(WI.LayoutDetailsSidebarPanel.prototype._removeNodeFromNodeSets):
(WI.LayoutDetailsSidebarPanel.prototype._invalidateNodeSets):
(WI.LayoutDetailsSidebarPanel.prototype._refreshNodeSets):
- Instead of iterating all the nodes twice every time something changes, iterate all the nodes once, an only do so when
doing layout to prevent multiple iterations for an eventual single layout.
- Source/WebInspectorUI/UserInterface/Views/NodeOverlayListSection.js:
(WI.NodeOverlayListSection.prototype._handleToggleAllCheckboxChanged):
- Fix for an assertion reachable while manually testing this patch. Toggling the overlay off when it is already off is
not allowed, and turning an overlay on that is already on is needlessly chatty over the protocol (unless changing the
settings/color, which is left untouched).
- LayoutTests/inspector/dom/attachedNodes-expected.txt: Added.
- LayoutTests/inspector/dom/attachedNodes.html: Added.
- LayoutTests/inspector/css/setLayoutContextTypeChangedMode.html:
- Update to use WI.domManager.attachedNodes() iterator.
Canonical link: https://commits.webkit.org/250897@main
- 4:28 PM Changeset in webkit [294694] by
-
- 7 edits in branches/safari-7613.3.1.0-branch/Source
Revert r294280. rdar://problem/87980543
This reverts r294672.
- 4:27 PM Changeset in webkit [294693] by
-
- 1 edit in branches/safari-7613.3.1.1-branch/Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
Revert fix. rdar://problem/87980543
This reverts r294689.
- 4:25 PM Changeset in webkit [294692] by
-
- 1 edit in trunk/Source/WebCore/loader/cache/CachedRawResource.cpp
Capture WeakPtr to CachedResourceClient in lambdas in CachedRawResource::didAddClient()
https://bugs.webkit.org/show_bug.cgi?id=240828
<rdar://93781799>
Reviewed by Alex Christensen.
Capture WeakPtr to CachedResourceClient in lambdas in CachedRawResource::didAddClient()
instead of a raw pointer, for hardening.
- Source/WebCore/loader/cache/CachedRawResource.cpp:
(WebCore::iterateRedirects):
(WebCore::CachedRawResource::didAddClient):
Canonical link: https://commits.webkit.org/250896@main
- 3:53 PM Changeset in webkit [294691] by
-
- 1 edit in trunk/Source/WebCore/editing/IndentOutdentCommand.cpp
Null check split node parent in outdentParagraph
https://bugs.webkit.org/show_bug.cgi?id=240806
Patch by Rob Buis <rbuis@igalia.com> on 2022-05-23
Reviewed by Wenson Hsieh.
The split node parent needs an extra null check to access its parent
before safely calling hasEditableStyle.
- Source/WebCore/editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::outdentParagraph):
Canonical link: https://commits.webkit.org/250895@main
- 3:37 PM Changeset in webkit [294690] by
-
- 1 edit in trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
[iPadOS] Align scroll position to origin on resize in Multitasking mode
https://bugs.webkit.org/show_bug.cgi?id=240815
rdar://92888214
Reviewed by Devin Rousso.
Make a minor adjustment to avoid re-centering the target unobscured content rect on the hit-tested
node in the center of the viewport, when multitasking mode is enabled; instead, we can simply
preserve the existing unobscured content rect offset.
- Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
We can also avoid this hit-test when
usesMultitaskingModeViewportBehaviors()is enabled, since we
only need to anchor to the origin of the current unobscured rect.
(WebKit::WebPage::dynamicViewportSizeUpdate):
Canonical link: https://commits.webkit.org/250894@main
- 3:19 PM Changeset in webkit [294689] by
-
- 1 edit in branches/safari-7613.3.1.1-branch/Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
Unreviewed build fix. rdar://problem/87980543
WebKit/Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:247:36:|error: no matching constructor for initialization of 'Ref<WebCore::Image>'
- 3:15 PM Changeset in webkit [294688] by
-
- 2 edits in branches/safari-7614.1.14.100-branch/Source
Cherry-pick r294467. rdar://problem/93507791
REGRESSION (r294160): Occasional infinite loops under updateLayersForInteractionRegions
https://bugs.webkit.org/show_bug.cgi?id=240610
<rdar://problem/93507791>
Reviewed by Wenson Hsieh.
- Source/WebCore/page/InteractionRegion.cpp: (WebCore::regionForElement): Avoid emitting empty rects for interaction regions, and avoid emitting the region at all if this results in an empty set of rects.
- Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm: (WebKit::updateLayersForInteractionRegions): Never re-use a layer with empty bounds; we should never get here, but I'd rather re-create the layer if we do than corrupt the hash table.
Canonical link: https://commits.webkit.org/250729@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:14 PM Changeset in webkit [294687] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations
[Gardening]: [ Monterey wk2 ] webgl/2.0.0/conformance/attribs/gl-vertexattribpointer-offsets.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=240830
<rdar://93786598>
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250893@main
- 3:13 PM Changeset in webkit [294686] by
-
- 9 edits in branches/safari-7614.1.14.100-branch/Source
Versioning.
WebKit-7614.1.14.100.3
- 3:11 PM Changeset in webkit [294685] by
-
- 1 edit in branches/safari-7613.3.1.0-branch/Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp
Unreviewed build fix. rdar://problem/87980543
WebKit/Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:247:36:|error: no matching constructor for initialization of 'Ref<WebCore::Image>'
- 2:40 PM Changeset in webkit [294684] by
-
- 7 edits in branches/safari-7613.3.1.1-branch/Source
Revert r294280. rdar://problem/87980543
This reverts commit r294675.
- 2:36 PM Changeset in webkit [294683] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations
[Gardening]: [ Monterey wk2 ] WebGL conformance tests are a flaky time out
https://bugs.webkit.org/show_bug.cgi?id=239386
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250892@main
- 2:29 PM Changeset in webkit [294682] by
-
- 1 edit in trunk/metadata/contributors.json
Add mattwoohdrow's GitHub to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240824
Reviewed by Jonathan Bedard.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250891@main
- 2:21 PM Changeset in webkit [294681] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations
[Gardening]: [ Monterey Release wk2 ] webgl/max-active-contexts-webglcontextlost-prevent-default.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=240821
<rdar://93782808>
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250890@main
- 2:03 PM Changeset in webkit [294680] by
-
- 17 edits20 deletes in trunk
[css-ui] Remove support for *-level-indicator appearance values
https://bugs.webkit.org/show_bug.cgi?id=240446
Reviewed by Antti Koivisto.
These only were implemented on macOS to display stars, or other alternative types of progress on <meter> elements.
These were already removed in Chromium: https://codereview.chromium.org/1747763002
- continuous-capacity-level-indicator
- discrete-capacity-level-indicator
- relevancy-level-indicator
- rating-level-indicator
Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
- LayoutTests/accessibility/accessibility-crash-setattribute.html:
- LayoutTests/editing/execCommand/crash-breaking-blockquote-with-list.html:
- LayoutTests/editing/selection/modify-by-lineboundary-toward-pseudo-element.html:
- LayoutTests/fast/block/float/float-list-changed-before-layout-crash.html:
- LayoutTests/fast/css/content/content-quotes-crash-with-details.html:
- LayoutTests/fast/dom/HTMLMeterElement/meter-appearances-capacity.html: Removed.
- LayoutTests/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy.html: Removed.
- LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- LayoutTests/platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Removed.
- LayoutTests/platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
- LayoutTests/platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
- LayoutTests/platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Removed.
- LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- LayoutTests/platform/ios/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
- LayoutTests/platform/ios/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Removed.
- LayoutTests/platform/mac/TestExpectations:
- LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Removed.
- LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
- LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
- LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Removed.
- LayoutTests/platform/win/TestExpectations:
- LayoutTests/platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Removed.
- LayoutTests/platform/win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
- LayoutTests/platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png: Removed.
- LayoutTests/platform/win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Removed.
- LayoutTests/platform/wincairo/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
- LayoutTests/platform/wincairo/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Removed.
- LayoutTests/platform/wpe/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
- LayoutTests/platform/wpe/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt: Removed.
- Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- Source/WebCore/css/CSSProperties.json:
- Source/WebCore/css/CSSValueKeywords.in:
- Source/WebCore/platform/ThemeTypes.cpp:
(WebCore::operator<<):
- Source/WebCore/platform/ThemeTypes.h:
- Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::isControlStyled const):
- Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::supportsMeter const):
(WebCore::RenderThemeMac::levelIndicatorFor const):
(WebCore::RenderThemeMac::levelIndicatorStyleFor const): Deleted.
- Source/WebCore/rendering/RenderThemeMac.h:
Canonical link: https://commits.webkit.org/250888@main
- 2:03 PM Changeset in webkit [294679] by
-
- 1 edit in trunk/Source/WebCore/platform/gtk/po/uk.po
[GTK] Update Ukrainian translation
https://bugs.webkit.org/show_bug.cgi?id=240119
Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-23
Unreviewed.
- Source/WebCore/platform/gtk/po/uk.po:
Canonical link: https://commits.webkit.org/250888@main
- 1:47 PM Changeset in webkit [294678] by
-
- 3 edits in trunk/LayoutTests/platform
[Gardening]: [Mac wk1 Debug] webaudio/audioworket-out-of-memory.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=227845
<rdar://80398130>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
- LayoutTests/platform/mac-wk1/TestExpectations:
- LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/250887@main
- 1:17 PM Changeset in webkit [294677] by
-
- 10 edits in trunk
[css-ui] Unexpose remaining media-* appearance values
https://bugs.webkit.org/show_bug.cgi?id=240484
<rdar://93376288>
Reviewed by Aditya Keerthi.
These are made UA sheet-only (since they're used in the mediaControls*.css sheets):
- media-fullscreen-volume-slider
- media-slider
- media-volume-slider
These are made internal (only used from C++ code):
- media-fullscreen-volume-slider-thumb
- media-sliderthumb
- media-volume-sliderthumb
Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
- LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- Source/WebCore/css/CSSProperties.json:
- Source/WebCore/css/CSSValueKeywords.in:
- Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
- Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::resolveCustomStyle):
(WebCore::SliderContainerElement::resolveCustomStyle):
- Source/WebCore/platform/ThemeTypes.h:
- Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
- Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js:
Canonical link: https://commits.webkit.org/250886@main
- 12:56 PM Changeset in webkit [294676] by
-
- 8 edits2 adds in branches/safari-7613.3.1.1-branch
Cherry-pick r294186. rdar://problem/93213436
Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence
https://bugs.webkit.org/show_bug.cgi?id=240365
Reviewed by Chris Fleizach.
Source/WebCore:
We can get infinite recursion when accessibilityIsIgnored is called as
part of computing AccessibilityObject::ignoredFromModalPresence. One
example of such a cycle:
AXObjectCache::currentModalNode() ->
AccessibilityRenderObject::computeAccessibilityIsIgnored() ->
AccessibilityRenderObject::parentObjectUnignored() ->
AccessibilityObject::accessibilityIsIgnored() ->
AccessibilityObject::ignoredFromModalPresence() ->
AXObjectCache::currentModalNode() ->
...repeat...
This patch fixes this by tracking when we start computing the current
modal node in the AXObjectCache. Then, in AccessibilityObject::accessibilityIsIgnored(),
we don't call AccessibilityObject::ignoredFromModalPresence() if this new state is true,
since in this context we only need to know if the object is inherently
ignored (i.e. ignored disregarding modal presence).
Test: accessibility/aria-modal-with-text-crash.html
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::currentModalNode):
- accessibility/AXObjectCache.h: Add m_isRetrievingCurrentModalNode. (WebCore::AXObjectCache::isRetrievingCurrentModalNode): Added.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessibilityIsIgnored const): Don't call ignoredFromModalPresence if we're in the midst of computing the current modal.
LayoutTests:
- accessibility/aria-modal-with-text-crash-expected.txt: Added.
- accessibility/aria-modal-with-text-crash.html: Added.
- platform/glib/TestExpectations: Skip new test.
- platform/ios/TestExpectations: Enable new test.
- platform/win/TestExpectations: Skip new test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:55 PM Changeset in webkit [294675] by
-
- 7 edits in branches/safari-7613.3.1.1-branch/Source
Cherry-pick r294280. rdar://problem/87980543
REGRESSION(r249162): CanvasRenderingContext2DBase::drawImage() crashes if the image is animated and the first frame cannot be decoded
https://bugs.webkit.org/show_bug.cgi?id=239113
rdar://87980543
Reviewed by Simon Fraser.
Source/WebCore:
CanvasRenderingContext2DBase::drawImage() needs to ensure the first frame
of the animated image can be decoded correctly before creating the temporary
static image. If the first frame can't be decoded, this function should return
immediately. This matches the behavior of this function before r249162.
The animated image decodes its frames asynchronously in a work queue. But
the first frame has to be decoded synchronously in the main run loop. So
to avoid running the image decoder in two different threads we are going
to keep the first and the current frame cached when we receive a memory
pressure warning. This should not increase the memory allocation of the
animated image because the numbers of cached frames increases quickly and
we keep all of them till a memory warning is received. But the memory
pressure warning will be received a little bit more often. This depends
on the memory size of the first frame.
To make the code more robust, make ImageSource take a Ref<NativeImage>
instead of taking a RefPtr<NativeImage>.
- html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::drawImage):
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::destroyDecodedData):
- platform/graphics/BitmapImage.h:
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::destroyDecodedData): (WebCore::ImageSource::setNativeImage):
- platform/graphics/ImageSource.h: (WebCore::ImageSource::create): (WebCore::ImageSource::isDecoderAvailable const): (WebCore::ImageSource::destroyAllDecodedData): Deleted. (WebCore::ImageSource::destroyAllDecodedDataExcludeFrame): Deleted. (WebCore::ImageSource::destroyDecodedDataBeforeFrame): Deleted.
Source/WebKit:
- GPUProcess/graphics/RemoteDisplayListRecorder.cpp: (WebKit::RemoteDisplayListRecorder::drawSystemImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:55 PM Changeset in webkit [294674] by
-
- 2 edits in branches/safari-7613.3.1.1-branch/Source/bmalloc
Cherry-pick r293952. rdar://problem/92913312
Force PAS_ASSERT to generate different crash sites for each assertion.
https://bugs.webkit.org/show_bug.cgi?id=240209
Reviewed by Yusuke Suzuki.
Clang currently optimizes all crash sites into one in each function. Hence, if we
get a crash address at the 1 crash site, we don't know which failed assertion got
us there. This patch uses an asm statement to force Clang to emit a different
crash site for each assertion.
Benchmarks show that performance is neutral on both Jetstream2 and Speedometer2.
Size-wise, there is some increase. The following is the "size" output on
JavaScriptCore on M1:
TEXT. DATA OBJC others dec hex
old 19628032 180224 0 18792448 38600704 24d0000
new 19644416 180224 0 19251200 39075840 2544000
diff 16384 0 0 458752 475136
The increase in the "others" categories are mostly in the String Table, Symbol
Table, and Function Start Addresses. These take up disk space but should not
impact RAM usage unless they are accessed by a a debugger.
- libpas/src/libpas/pas_utils.h: (pas_assertion_failed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:55 PM Changeset in webkit [294673] by
-
- 6 edits2 adds in branches/safari-7613.3.1.1-branch
Cherry-pick r289713. rdar://problem/93601919
Expose the correct role, subrole and role description properties for the <dialog> element.
https://bugs.webkit.org/show_bug.cgi?id=236359
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/dialog-properties.html
Elements with role="dialog" are exposed to accessibility clients with
role AXGroup, subrole AXApplicationDialog and role description
"web dialog". This patch implements this behavior for the <dialog>
element.
- accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const):
LayoutTests:
Tests that these AX properties have the expected values both when the
dialog is shown modal or modeless.
- accessibility/dialog-properties-expected.txt: Added.
- accessibility/dialog-properties.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:52 PM Changeset in webkit [294672] by
-
- 8 edits2 adds in branches/safari-7613.3.1.0-branch
Cherry-pick r294186. rdar://problem/93213436
Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence
https://bugs.webkit.org/show_bug.cgi?id=240365
Reviewed by Chris Fleizach.
Source/WebCore:
We can get infinite recursion when accessibilityIsIgnored is called as
part of computing AccessibilityObject::ignoredFromModalPresence. One
example of such a cycle:
AXObjectCache::currentModalNode() ->
AccessibilityRenderObject::computeAccessibilityIsIgnored() ->
AccessibilityRenderObject::parentObjectUnignored() ->
AccessibilityObject::accessibilityIsIgnored() ->
AccessibilityObject::ignoredFromModalPresence() ->
AXObjectCache::currentModalNode() ->
...repeat...
This patch fixes this by tracking when we start computing the current
modal node in the AXObjectCache. Then, in AccessibilityObject::accessibilityIsIgnored(),
we don't call AccessibilityObject::ignoredFromModalPresence() if this new state is true,
since in this context we only need to know if the object is inherently
ignored (i.e. ignored disregarding modal presence).
Test: accessibility/aria-modal-with-text-crash.html
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::currentModalNode):
- accessibility/AXObjectCache.h: Add m_isRetrievingCurrentModalNode. (WebCore::AXObjectCache::isRetrievingCurrentModalNode): Added.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessibilityIsIgnored const): Don't call ignoredFromModalPresence if we're in the midst of computing the current modal.
LayoutTests:
- accessibility/aria-modal-with-text-crash-expected.txt: Added.
- accessibility/aria-modal-with-text-crash.html: Added.
- platform/glib/TestExpectations: Skip new test.
- platform/ios/TestExpectations: Enable new test.
- platform/win/TestExpectations: Skip new test.
Canonical link: https://commits.webkit.org/250552@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:51 PM Changeset in webkit [294671] by
-
- 1 edit in trunk/metadata/contributors.json
Add Mike Wyrzykowski to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240816
Unreviewed.
He is a contributor.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250885@main
- 12:46 PM Changeset in webkit [294670] by
-
- 4 edits in trunk/Source/WebKit/UIProcess
REGRESSION (r294469): [ iOS ] TestWebKitAPI.NSAttributedStringWebKitAdditions.DirectoriesNotCreated is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240690
Reviewed by Chris Dumez.
r294469 failed to check if WebsiteDataStore is persistent before getting and creating directories in WebProcessPool. To
fix this and to avoid future issues, we make WebsiteDataStore return null for directory getters if it's not persistent.
- Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::GPUProcessProxy):
- Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::webProcessDataStoreParameters):
- Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::cookieStorageDirectory const):
(WebKit::WebsiteDataStore::containerCachesDirectory const):
(WebKit::WebsiteDataStore::parentBundleDirectory const):
(WebKit::WebsiteDataStore::networkingCachesDirectory const):
(WebKit::WebsiteDataStore::containerTemporaryDirectory const):
(WebKit::WebsiteDataStore::defaultContainerTemporaryDirectory):
(WebKit::WebsiteDataStore::cookieStorageDirectory): Deleted.
(WebKit::WebsiteDataStore::containerCachesDirectory): Deleted.
(WebKit::WebsiteDataStore::parentBundleDirectory): Deleted.
(WebKit::WebsiteDataStore::networkingCachesDirectory): Deleted.
(WebKit::WebsiteDataStore::containerTemporaryDirectory): Deleted.
- Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
Canonical link: https://commits.webkit.org/250884@main
- 12:44 PM Changeset in webkit [294669] by
-
- 7 edits in branches/safari-7613.3.1.0-branch/Source
Cherry-pick r294280. rdar://problem/87980543
REGRESSION(r249162): CanvasRenderingContext2DBase::drawImage() crashes if the image is animated and the first frame cannot be decoded
https://bugs.webkit.org/show_bug.cgi?id=239113
rdar://87980543
Reviewed by Simon Fraser.
Source/WebCore:
CanvasRenderingContext2DBase::drawImage() needs to ensure the first frame
of the animated image can be decoded correctly before creating the temporary
static image. If the first frame can't be decoded, this function should return
immediately. This matches the behavior of this function before r249162.
The animated image decodes its frames asynchronously in a work queue. But
the first frame has to be decoded synchronously in the main run loop. So
to avoid running the image decoder in two different threads we are going
to keep the first and the current frame cached when we receive a memory
pressure warning. This should not increase the memory allocation of the
animated image because the numbers of cached frames increases quickly and
we keep all of them till a memory warning is received. But the memory
pressure warning will be received a little bit more often. This depends
on the memory size of the first frame.
To make the code more robust, make ImageSource take a Ref<NativeImage>
instead of taking a RefPtr<NativeImage>.
- html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::drawImage):
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::destroyDecodedData):
- platform/graphics/BitmapImage.h:
- platform/graphics/ImageSource.cpp: (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::destroyDecodedData): (WebCore::ImageSource::setNativeImage):
- platform/graphics/ImageSource.h: (WebCore::ImageSource::create): (WebCore::ImageSource::isDecoderAvailable const): (WebCore::ImageSource::destroyAllDecodedData): Deleted. (WebCore::ImageSource::destroyAllDecodedDataExcludeFrame): Deleted. (WebCore::ImageSource::destroyDecodedDataBeforeFrame): Deleted.
Source/WebKit:
- GPUProcess/graphics/RemoteDisplayListRecorder.cpp: (WebKit::RemoteDisplayListRecorder::drawSystemImage):
Canonical link: https://commits.webkit.org/250624@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:44 PM Changeset in webkit [294668] by
-
- 2 edits in branches/safari-7613.3.1.0-branch/Source/bmalloc
Cherry-pick r293952. rdar://problem/92913312
Force PAS_ASSERT to generate different crash sites for each assertion.
https://bugs.webkit.org/show_bug.cgi?id=240209
Reviewed by Yusuke Suzuki.
Clang currently optimizes all crash sites into one in each function. Hence, if we
get a crash address at the 1 crash site, we don't know which failed assertion got
us there. This patch uses an asm statement to force Clang to emit a different
crash site for each assertion.
Benchmarks show that performance is neutral on both Jetstream2 and Speedometer2.
Size-wise, there is some increase. The following is the "size" output on
JavaScriptCore on M1:
TEXT. DATA OBJC others dec hex
old 19628032 180224 0 18792448 38600704 24d0000
new 19644416 180224 0 19251200 39075840 2544000
diff 16384 0 0 458752 475136
The increase in the "others" categories are mostly in the String Table, Symbol
Table, and Function Start Addresses. These take up disk space but should not
impact RAM usage unless they are accessed by a a debugger.
- libpas/src/libpas/pas_utils.h: (pas_assertion_failed):
Canonical link: https://commits.webkit.org/250398@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:44 PM Changeset in webkit [294667] by
-
- 6 edits2 adds in branches/safari-7613.3.1.0-branch
Cherry-pick r289713. rdar://problem/93601919
Expose the correct role, subrole and role description properties for the <dialog> element.
https://bugs.webkit.org/show_bug.cgi?id=236359
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/dialog-properties.html
Elements with role="dialog" are exposed to accessibility clients with
role AXGroup, subrole AXApplicationDialog and role description
"web dialog". This patch implements this behavior for the <dialog>
element.
- accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const):
LayoutTests:
Tests that these AX properties have the expected values both when the
dialog is shown modal or modeless.
- accessibility/dialog-properties-expected.txt: Added.
- accessibility/dialog-properties.html: Added.
Canonical link: https://commits.webkit.org/247198@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:41 PM Changeset in webkit [294666] by
-
- 1 edit in trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
[macOS] 3 TestWebKitAPI.GetDisplayMediaTest API tests time out
https://bugs.webkit.org/show_bug.cgi?id=240813
rdar://92831194
Reviewed by Youenn Fablet.
- Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest): Don't
prompt for getDisplayMedia if the UI delegate implements the old SPI.
Canonical link: https://commits.webkit.org/250883@main
- 12:33 PM Changeset in webkit [294665] by
-
- 9 edits in branches/safari-7613.3.1.1-branch/Source
Versioning.
WebKit-7613.3.1.1.3
- 12:21 PM Changeset in webkit [294664] by
-
- 2 edits in trunk/Source/WebCore/html
MediaController should be an ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=240749
<rdar://93525670>
Reviewed by Youenn Fablet.
- html/MediaController.cpp:
(WebCore::MediaController::MediaController):
- html/MediaController.h:
Canonical link: https://commits.webkit.org/250882@main
- 12:11 PM Changeset in webkit [294663] by
-
- 9 edits in branches/safari-7613.3.1.0-branch/Source
Versioning.
WebKit-7613.3.1.0.3
- 11:54 AM Changeset in webkit [294662] by
-
- 1 copy in tags/WebKit-7614.1.14.10.3
Tag WebKit-7614.1.14.10.3.
- 11:53 AM Changeset in webkit [294661] by
-
- 6 edits in trunk/Tools/Scripts/libraries
git webkit setup opens a GitHub web page without warning
https://bugs.webkit.org/show_bug.cgi?id=240490
<rdar://93522009>
Reviewed by Alexey Proskuryakov.
- Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py: Ditto.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
(Tracker.credentials.prompt): Prompt user before generating token.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:
(Terminal.open_url): Allow caller to specify a prompt before opening URL.
Canonical link: https://commits.webkit.org/250881@main
- 11:50 AM Changeset in webkit [294660] by
-
- 2 edits in trunk/Source
Use kCGImageSourceCreateUnpremultipliedPNG on iOS family to correctly read PNG files without premultiplication.
https://bugs.webkit.org/show_bug.cgi?id=240137
<rdar://93198134>
Patch by John Cunningham <johncunningham@apple.com> on 2022-05-23
Reviewed by Simon Fraser.
- Source/WTF/wtf/PlatformHave.h:
- Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:
(WebCore::createImageSourceOptions):
Canonical link: https://commits.webkit.org/250880@main
- 11:36 AM Changeset in webkit [294659] by
-
- 9 edits in branches/safari-7614.1.14.10-branch/Source
Versioning.
WebKit-7614.1.14.10.3
- 11:16 AM Changeset in webkit [294658] by
-
- 2 edits1 move in trunk/Tools/TestWebKitAPI
REGRESSION(r293671): [ iOS ] 2 TestWebKitAPI.MediaLoading.RangeRequestSynthesis (API-Tests) are constant failures
https://bugs.webkit.org/show_bug.cgi?id=240033
rdar://92689429
Refactor the new code, add the transport stream to the copy resources step.
Reviewed by Jer Noble.
- Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add .ts file, copy to resources.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
(TestWebKitAPI::TEST): Update test.
- Tools/TestWebKitAPI/Tests/WebKit/cocoa/start-offset.ts -> Tools/TestWebKitAPI/Tests/WebKitCocoa/start-offset.ts
Canonical link: https://commits.webkit.org/250879@main
- 11:05 AM Changeset in webkit [294657] by
-
- 4 edits in branches/safari-7614.1.14.0-branch
Cherry-pick r294589. rdar://problem/92006847
[MacCatalyst] REGRESSION(r290091): sometimes can hang if
WKWebViewis unparented before the next visible content rect update
https://bugs.webkit.org/show_bug.cgi?id=240691
<rdar://problem/92006847>
Reviewed by Wenson Hsieh.
Test: WKWebViewResize.RemovesAssertionsAfterMovingToWindow
- Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _processWillSwapOrDidExit]): (-[WKWebView didMoveToWindow]): (-[WKWebView _acquireResizeAssertionForReason:]): Drive-by: WebProcess crashes should also clear the resize assertions. Drive-by: Add a 1s timeout in case the next visible content rect update takes too long.
- Source/WebKit/UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
- Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm: (-[WKWebView _hasResizeAssertion]): Added.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewResize.mm: (TEST.WKWebViewResize.RemovesAssertionsAfterMovingToWindow): Added.
Canonical link: https://commits.webkit.org/250822@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:02 AM Changeset in webkit [294656] by
-
- 9 edits in branches/safari-7614.1.14.0-branch/Source
Versioning.
WebKit-7614.1.14.0.9
- 10:58 AM Changeset in webkit [294655] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.9
- 10:57 AM Changeset in webkit [294654] by
-
- 3 edits in trunk/LayoutTests
[Cocoa] fast/text/international/generic-font-family-language-traditional.html is failing due to language minimization
https://bugs.webkit.org/show_bug.cgi?id=240751
<rdar://problem/93394618>
Reviewed by Chris Dumez.
We're saying the language list ["en", "zh-tw"] gets minimized to en, which then removes the signal about whether we should render simplified or traditional Chinese.
On one hand, this is kind of good, because the whole point of minimization is to make different browser configurations in the same bucket as identical. On the other hand, it means a user with these language preferences won't get the rendering they expect.
I could change the test to just use the language list zh-tw and I think it would still test the thing it's trying to test, so that's what this patch does.
- LayoutTests/fast/text/international/generic-font-family-language-traditional.html:
- LayoutTests/platform/ios/TestExpectations:
- LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/250878@main
- 10:54 AM Changeset in webkit [294653] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations
[Gardening]: REGRESSION (r294536): [ macOS Release wk2 ] Twelve webgl/2.0.0/conformance2/textures/image_bitmap_from_image_bitmap/tex are a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240735
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250877@main
- 10:32 AM Changeset in webkit [294652] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations
[Gardening]: REGRESSION (r293885?): [ macOS wk2 ] webrtc/canvas-to-peer-connection.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240814
<rdar://93768909>
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250876@main
- 10:11 AM Changeset in webkit [294651] by
-
- 2 edits in trunk/Source/WebKit/UIProcess/API/Cocoa
Web Driver: Expose new
isPendingTerminationproperty on_WKAutomationSession
https://bugs.webkit.org/show_bug.cgi?id=240669
rdar://93367943
Reviewed by Devin Rousso.
- Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSession.h:
- Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSession.mm:
(-[_WKAutomationSession isPendingTermination]):
Canonical link: https://commits.webkit.org/250875@main
- 10:09 AM Changeset in webkit [294650] by
-
- 1 edit in trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm
Bump the priority of iOS ProcessAssertion Queue
https://bugs.webkit.org/show_bug.cgi?id=240784
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-23
Reviewed by Chris Dumez.
It is important to acquire assertions in a timely manner as otherwise the UIProcess
might think a process is unresponsive.
Bump the priority to WorkQueue::QOS::UserInitiated.
- Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:
(assertionsWorkQueue):
Canonical link: https://commits.webkit.org/250874@main
- 9:55 AM Changeset in webkit [294649] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
[Gardening]: [ iOS ] fast/events/ios/rotation/layout-viewport-during-safari-type-rotation.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=231266
<rdar://83910715>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250873@main
- 9:36 AM Changeset in webkit [294648] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations
[Gardening]: REGRESSION (r294536): [ macOS Release wk2 ] Twelve webgl/2.0.0/conformance2/textures/image_bitmap_from_image_bitmap/tex are a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240735
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250872@main
- 9:32 AM Changeset in webkit [294647] by
-
- 8 edits in trunk
[css-ui] Restrict default-button CSS appearance value to useSystemAppearance
https://bugs.webkit.org/show_bug.cgi?id=240391
Reviewed by Aditya Keerthi.
This appearance value renders a button in its highlighted state to designate a button that is activated by default on macOS.
The most important reason to keep it around is for internal macOS apps, so we restrict it to webviews with useSystemAppearance.
- LayoutTests/editing/deleting/insert-in-orphaned-selection-crash.html:
- LayoutTests/editing/deleting/insert-in-orphaned-selection-crash-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- Source/WebCore/css/CSSProperties.json:
- Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
- Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
- Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js:
Canonical link: https://commits.webkit.org/250871@main
- 9:09 AM Changeset in webkit [294646] by
-
- 1 edit in trunk/Tools/CISupport/ews-app/ews/views/statusbubble.py
Disable mac-debug-wk1 ews status bubble
https://bugs.webkit.org/show_bug.cgi?id=240803
Reviewed by Ryan Haddad.
- Tools/CISupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):
Canonical link: https://commits.webkit.org/250870@main
- 9:04 AM Changeset in webkit [294645] by
-
- 1 edit in trunk/Source/WebCore/Modules/webdatabase/Database.cpp
Regression(r294611): ASSERTION FAILED: m_isConstructed under WebCore::fullyQualifiedInfoTableName()
https://bugs.webkit.org/show_bug.cgi?id=240800
Unreviewed, use LazyNeverDestroyed::construct() instead of assignment to LazyNeverDestroyed::get()
to address the debug assertion on the bots.
- Source/WebCore/Modules/webdatabase/Database.cpp:
(WebCore::fullyQualifiedInfoTableName):
Canonical link: https://commits.webkit.org/250869@main
- 8:58 AM Changeset in webkit [294644] by
-
- 1 edit in trunk/metadata/contributors.json
Update philn's emails in contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240799
Patch by Philippe Normand <philn@igalia.com> on 2022-05-23
Unreviewed.
- metadata/contributors.json: Update philn's emails and expertise.
Canonical link: https://commits.webkit.org/250868@main
- 8:44 AM Changeset in webkit [294643] by
-
- 1 edit in trunk/Source/WebCore/platform/gtk/po/sv.po
[GTK] Update Swedish translation
https://bugs.webkit.org/show_bug.cgi?id=240791
Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-23
Unreviewed.
- Source/WebCore/platform/gtk/po/sv.po:
Canonical link: https://commits.webkit.org/250867@main
- 8:35 AM Changeset in webkit [294642] by
-
- 4 edits in trunk
Unskip JSTests/stress/shadow-realm-import-value.js on ARMv7 and MIPS
https://bugs.webkit.org/show_bug.cgi?id=240662
Reviewed by Yusuke Suzuki.
Fix tag and payload being swapped in the resultRegs object.
Also updated some places that can use JSRInfo::returnValueJSR instead
of manually writing the GPR order.
Patch by Geza Lore and Mikhail R. Gadelha.
- jit/ThunkGenerators.cpp: (JSC::boundFunctionCallGenerator): (JSC::remoteFunctionCallGenerator):
Canonical link: https://commits.webkit.org/250866@main
- 8:13 AM WebKitEmacsTips edited by
- (diff)
- 8:02 AM Changeset in webkit [294641] by
-
- 24 edits5 deletes in trunk
[css-ui] Remove support for appearance: media-controls-{dark/light}-bar-background
https://bugs.webkit.org/show_bug.cgi?id=240756
Reviewed by Antoine Quint.
Reverts r180965 (adapted with new code), this was originally added for old media controls, but was never used.
Marked relevant WPT as passing.
- LayoutTests/compositing/media-controls-bar-appearance-big-expected.txt: Removed.
- LayoutTests/compositing/media-controls-bar-appearance-big.html: Removed.
- LayoutTests/compositing/media-controls-bar-appearance-expected.txt: Removed.
- LayoutTests/compositing/media-controls-bar-appearance.html: Removed.
- LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- LayoutTests/platform/ios/compositing/media-controls-bar-appearance-expected.txt: Removed.
- Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- Source/WebCore/css/CSSProperties.json:
- Source/WebCore/css/CSSValueKeywords.in:
- Source/WebCore/platform/ThemeTypes.cpp:
(WebCore::operator<<):
- Source/WebCore/platform/ThemeTypes.h:
- Source/WebCore/platform/graphics/GraphicsLayer.cpp:
(WebCore::operator<<):
- Source/WebCore/platform/graphics/GraphicsLayer.h:
- Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::changeLayerTypeTo):
(WebCore::layerTypeForCustomBackdropAppearance): Deleted.
(WebCore::isCustomBackdropLayerType): Deleted.
- Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:
- Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::operator<<):
- Source/WebCore/platform/graphics/ca/PlatformCALayer.h:
- Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::updateCustomAppearance):
- Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp:
(printLayer):
- Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::updateConfigurationAfterStyleChange):
(WebCore::RenderLayerBacking::updateCustomAppearance): Deleted.
- Source/WebCore/rendering/RenderLayerBacking.h:
- Source/WebKit/Platform/spi/ios/UIKitSPI.h:
- Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::drawInContext):
- Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
(WebKit::updateCustomAppearance):
(WebKit::RemoteLayerTreePropertyApplier::applyHierarchyUpdates):
(WebKit::RemoteLayerTreePropertyApplier::updateMask):
- Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::makeNode):
- Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::makeNode):
- Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:
- Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
(-[WKBackdropView hitTest:withEvent:]): Deleted.
(-[WKBackdropView description]): Deleted.
Canonical link: https://commits.webkit.org/250865@main
- 7:58 AM Changeset in webkit [294640] by
-
- 2 edits in trunk/Source/WebCore/rendering
Remove RenderTheme::adjustSearchFieldDecorationStyle()
https://bugs.webkit.org/show_bug.cgi?id=240798
Reviewed by Antti Koivisto.
Let appearance: auto; handle this instead, to centralize this in one place.
- Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::autoAppearanceForElement const):
(WebCore::RenderTheme::adjustSearchFieldDecorationStyle const): Deleted.
- Source/WebCore/rendering/RenderTheme.h:
Canonical link: https://commits.webkit.org/250864@main
- 7:34 AM Changeset in webkit [294639] by
-
- 1 edit in trunk/metadata/contributors.json
Add github account for Kimmo Kinnunen
https://bugs.webkit.org/show_bug.cgi?id=240789
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-23
Unreviewed.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250863@main
- 6:49 AM Changeset in webkit [294638] by
-
- 3 edits in trunk/Source/WebCore/layout
Add support for block direction grow
https://bugs.webkit.org/show_bug.cgi?id=240776
Reviewed by Antti Koivisto.
This is a basic block direction grow support (e.g. default block direction (top->bottom) with flex direction of column) when
flex box's height is fixed.
- Source/WebCore/layout/formattingContexts/FormattingConstraints.h:
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::updateRenderers const):
Canonical link: https://commits.webkit.org/250862@main
- 6:41 AM WebKitGTK/2.36.x edited by
- (diff)
- 6:38 AM Changeset in webkit [294637] by
-
- 2 edits in trunk
RealtimeOutgoingVideoSourceCocoa pixelBufferPool should use video range
https://bugs.webkit.org/show_bug.cgi?id=240463
rdar://problem/93354226
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-23
Reviewed by Eric Carlson.
We switched to using a pixel conformer that was using preferredPixelFormat to using libyuv routine.
Update the pixel buffer pool to use kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange to be compliant with libyuv routines.
- LayoutTests/platform/ios/TestExpectations:
- Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:
(WebCore::RealtimeOutgoingVideoSourceCocoa::pixelBufferPool):
Canonical link: https://commits.webkit.org/250861@main
- 6:24 AM Changeset in webkit [294636] by
-
- 1 edit in releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
Merge r294540 - [GStreamer] Block legacy VAAPI plugin
https://bugs.webkit.org/show_bug.cgi?id=240664
Patch by Philippe Normand <philn@igalia.com> on 2022-05-20
Reviewed by Xabier Rodriguez-Calvar.
The VAAPI plugin is not much maintained anymore and prone to rendering issues. In the
mid-term we will leverage the new stateless VA decoders. Disable the legacy plugin,
unless the WEBKIT_GST_ENABLE_LEGACY_VAAPI environment variable is set to 1.
- Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::registerWebKitGStreamerElements):
Canonical link: https://commits.webkit.org/250795@main
- 6:23 AM Changeset in webkit [294635] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r293319 - [GStreamer] Disable new demuxers based on adaptivedemux2
https://bugs.webkit.org/show_bug.cgi?id=239701
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-25
Reviewed by Xabier Rodriguez-Calvar.
The new demuxers based on adaptivedemux2 cannot be used in WebKit yet because this new base
class does not abstract away network access. They can't work in a sandboxed media process,
so demote their rank in order to prevent decodebin3 from auto-plugging them.
- platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::registerWebKitGStreamerElements):
Canonical link: https://commits.webkit.org/249942@main
- 6:14 AM Changeset in webkit [294634] by
-
- 3 edits in trunk/Source/WebCore/platform/graphics/gstreamer/mse
REGRESSION(r290375) [GStreamer] Deadlock in WebProcess termination if AppendPipeline is started
https://bugs.webkit.org/show_bug.cgi?id=240716
Patch by Olivier Blin <Olivier Blin> on 2022-05-23
Reviewed by Alicia Boya Garcia.
Since r290375, GStreamer ports are calling gst_deinit() at WebProcess
termination.
This is causing a deadlock if a MSE SourceBuffer has been instantiated.
That is because the GstTask from the appsrc element in the
AppendPipeline is still running.
To avoid the deadlock, stop the appsrc element in the AppendPipeline
when the SourceBuffer is removed from the MediaSource, since it will
not be useful anymore after being removed from its associated MediaSource.
The W3C spec of MediaSource.removeSourceBuffer mentions as a last step
that it should destroy all resources for sourceBuffer.
The MediaSource will be stopped at WebProcess termination, since
active DOM objects are stopped when detaching the frame.
This ensures that MediaSource is detached from its media element, and
that it removes its source buffers.
Drive-by fix: remove resetPipeline declaration, deleted in r238892
- Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::stopParser):
- Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h:
- Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
(WebCore::SourceBufferPrivateGStreamer::removedFromMediaSource):
Canonical link: https://commits.webkit.org/250860@main
- 4:33 AM Changeset in webkit [294633] by
-
- 1 edit in trunk/Source/WebCore/css/html.css
Remove unnecessary appearance: auto; declarations in html.css.
https://bugs.webkit.org/show_bug.cgi?id=240764
inputandselectalready have anappearance: autorule.
Reviewed by Tim Nguyen.
- Source/WebCore/css/html.css:
(#endif):
(input[type="search"]::-webkit-search-cancel-button):
(input[type="search"]::-webkit-search-decoration):
(#if defined(ENABLE_DATE_AND_TIME_INPUT_TYPES) && ENABLE_DATE_AND_TIME_INPUT_TYPES):
(input:is([type="button"], [type="submit"], [type="reset"])):
(input[type="file"]::file-selector-button):
(input[type="checkbox"]):
(#if !(defined(WTF_PLATFORM_IOS_FAMILY) && WTF_PLATFORM_IOS_FAMILY)):
(select:is([size=""], [size="0"], [size="1"])):
Canonical link: https://commits.webkit.org/250859@main
- 4:21 AM Changeset in webkit [294632] by
-
- 2 edits in trunk
[JSC] Do not use bytecode cache on $.agent worker threads
Patch by Geza Lore <Geza Lore> on 2022-05-23
https://bugs.webkit.org/show_bug.cgi?id=240642
Reviewed by Yusuke Suzuki.
Workers started via $.agent.start are not shut down in a synchronous
manner, and it is possible the main thread terminates the process while
a worker is writing its bytecode cache, which results in intermittent
test failures. As $.agent.start is only a rarely used testing facility,
we simply do not cache bytecode on these threads.
Also un-skip test on ARMv7 that used to fail because of this.
- Source/JavaScriptCore/jsc.cpp:
(Worker::isMain const):
(Worker::Worker):
(runJSC):
- JSTests/stress/lars-sab-workers.js:
Canonical link: https://commits.webkit.org/250858@main
- 3:37 AM Changeset in webkit [294631] by
-
- 1 edit in trunk/JSTests/stress/class-subclassing-function.js
Re-enable JSTests/stress/class-subclassing-function.js in ARM+NoLLInt
https://bugs.webkit.org/show_bug.cgi?id=240648
Patch by Joseph Griego <jgriego@igalia.com> on 2022-05-23
Reviewed by Yusuke Suzuki.
This was originally skipped in
https://bugs.webkit.org/show_bug.cgi?id=194285 because it runs out of
executable memory without LLInt; this seems to no longer be the case, at
least as far as my testing revealed, and EWS can hopefully confirm this
Re-enable the test in ARM+NoLLInt configurations.
- JSTests/stress/class-subclassing-function.js:
Canonical link: https://commits.webkit.org/250857@main
- 3:34 AM Changeset in webkit [294630] by
-
- 4 edits in trunk/Source
Add a runtime setting for switching on/off AudioSampleDataSource buffer adaptation
https://bugs.webkit.org/show_bug.cgi?id=240634
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-23
Reviewed by Eric Carlson.
- Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:
- Source/WebCore/page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webRTCAudioLatencyAdaptationEnabled const):
(WebCore::RuntimeEnabledFeatures::setWebRTCAudioLatencyAdaptationEnabled):
- Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm:
(WebCore::AudioSampleDataConverter::updateBufferedAmount):
Canonical link: https://commits.webkit.org/250856@main
- 2:06 AM Changeset in webkit [294629] by
-
- 14 edits3 deletes in trunk
[css-ui] Remove media-play-button and media-volume-slider-mute appearance values
https://bugs.webkit.org/show_bug.cgi?id=240760
Reviewed by Antti Koivisto.
These are unimplemented/no-op on all platforms.
- LayoutTests/fast/css-generated-content/empty-first-letter-with-columns-crash.html:
- LayoutTests/fast/multicol/readjust-first-child-on-attach.html:
Stop using these appearance values in crashtests.
- LayoutTests/imported/blink/fast/css-generated-content/empty-first-letter-with-columns-crash.html: Removed.
Remove duplicate test.
- LayoutTests/imported/blink/media/video-webkit-appearance-expected.html: Removed.
- LayoutTests/imported/blink/media/video-webkit-appearance.html: Removed.
Remove no longer relevant crashtest.
- LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
Marked subtests as passing.
- Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- Source/WebCore/css/CSSProperties.json:
- Source/WebCore/css/CSSValueKeywords.in:
- Source/WebCore/css/mediaControls.css:
Clean up stylesheet and stop using unsupported appearance values.
(:is(audio, video)::-webkit-media-controls-panel):
(video:-webkit-full-page-media):
(:is(audio, video)::-webkit-media-controls-mute-button,):
(:is(audio, video)::-webkit-media-controls-overlay-play-button):
(:is(audio, video)::-webkit-media-controls-timeline-container):
(:is(audio, video)::-webkit-media-controls-current-time-display,):
(:is(audio, video)::-webkit-media-controls-timeline):
(:is(audio, video)::-webkit-media-controls-volume-slider):
(:is(audio, video)::-webkit-media-controls-seek-back-button,):
(:is(audio, video)::-webkit-media-controls-rewind-button,):
(:is(audio, video)::-webkit-media-controls-closed-captions-container,):
(:is(audio, video)::-webkit-media-controls-volume-slider-mute-button):
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel): Deleted.
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button): Deleted.
(audio::-webkit-media-controls-overlay-play-button, video::-webkit-media-controls-overlay-play-button): Deleted.
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button): Deleted.
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container): Deleted.
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): Deleted.
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display): Deleted.
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline): Deleted.
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider): Deleted.
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button): Deleted.
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button): Deleted.
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button): Deleted.
(audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button): Deleted.
(audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button): Deleted.
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button): Deleted.
(audio::-webkit-media-controls-closed-captions-container, video::-webkit-media-controls-closed-captions-container): Deleted.
(audio::-webkit-media-controls-closed-captions-track-list, video::-webkit-media-controls-closed-captions-track-list): Deleted.
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button): Deleted.
(audio::-webkit-media-controls-fullscreen-volume-slider, video::-webkit-media-controls-fullscreen-volume-slider): Deleted.
(audio::-webkit-media-controls-fullscreen-volume-min-button, video::-webkit-media-controls-fullscreen-volume-min-button): Deleted.
(audio::-webkit-media-controls-fullscreen-volume-max-button, video::-webkit-media-controls-fullscreen-volume-max-button): Deleted.
- Source/WebCore/platform/ThemeTypes.cpp:
(WebCore::operator<<):
- Source/WebCore/platform/ThemeTypes.h:
- Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::adjustMediaControlStyle const): Deleted.
- Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaPlayButton): Deleted.
(WebCore::RenderTheme::paintMediaMuteButton): Deleted.
- Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
- Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js:
Canonical link: https://commits.webkit.org/250855@main
- 1:59 AM Changeset in webkit [294628] by
-
- 4 edits2 adds in trunk
IPC stream work queues lack autoreleasepools
https://bugs.webkit.org/show_bug.cgi?id=240647
<rdar://problem/93575653>
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-23
Reviewed by Simon Fraser.
Add the autorelease pool to each iteration of IPC stream message
processing.
This prevents leaks where the callgraph ends up using Objective-C
APIs that instantiate autoreleased objects. From WebKit code,
examples are things like dictionary literals from IOSurface.mm and
strings. Similarly other platform APIs use other similar, typically
small temporary autoreleased objects. Compared to GPUP held graphics
objects, even long running GPUP processes did not accumulate that much
leaked memory. The footprint would hike up 1-6 mb per hour on repeated
animation in the simplest case.
- Source/WebKit/Platform/IPC/StreamConnectionWorkQueue.cpp:
(IPC::StreamConnectionWorkQueue::processStreams):
- Source/WebKit/Shared/IPCStreamTester.cpp:
(WebKit::releaseUseCountHolder):
(WebKit::IPCStreamTester::checkAutoreleasePool):
- Source/WebKit/Shared/IPCStreamTester.h:
- Source/WebKit/Shared/IPCStreamTester.messages.in:
- LayoutTests/ipc/stream-check-autoreleasepool-expected.txt: Added.
- LayoutTests/ipc/stream-check-autoreleasepool.html: Added.
Canonical link: https://commits.webkit.org/250854@main
May 22, 2022:
- 11:45 PM Changeset in webkit [294627] by
-
- 1 edit in trunk/JSTests/wasm/wasm.json
WebAssembly: sync wasm.json files
https://bugs.webkit.org/show_bug.cgi?id=240741
Patch by Asumu Takikawa <asumu@igalia.com> on 2022-05-22
Reviewed by Yusuke Suzuki.
- JSTests/wasm/wasm.json:
Canonical link: https://commits.webkit.org/250853@main
- 11:31 PM Changeset in webkit [294626] by
-
- 2 edits in trunk/Source/WebKit/Shared
Ignore SIGPIPE in subprocesses
https://bugs.webkit.org/show_bug.cgi?id=240444
Reviewed by Adrian Perez de Castro.
One common case where ignoring SIGPIPE is desired is to avoid issues
when logging to journald and it crashes. As stated in
https://www.freedesktop.org/software/systemd/man/systemd-journald.service
"In order to react gracefully in this (journald stopped) case it is
recommended that programs logging to standard output/error ignore such
errors."
- Shared/AuxiliaryProcess.cpp: Avoid default platformInitialize on
Unix.
- Shared/unix/AuxiliaryProcessMain.cpp:
(WebKit::AuxiliaryProcess::platformInitialize): Added, ignore SIGPIPE.
Canonical link: https://commits.webkit.org/250852@main
- 9:43 PM Changeset in webkit [294625] by
-
- 1 edit in trunk/LayoutTests/platform/glib/TestExpectations
Unreviewed, gardening glib timeouts
https://bugs.webkit.org/show_bug.cgi?id=240783
Canonical link: https://commits.webkit.org/250851@main
- 6:23 PM Changeset in webkit [294624] by
-
- 2 edits in trunk/LayoutTests/platform
[WinCairo] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=240439
- LayoutTests/platform/wincairo-wk1/TestExpectations:
- LayoutTests/platform/wincairo/TestExpectations:
Canonical link: https://commits.webkit.org/250850@main
- 1:50 PM Changeset in webkit [294623] by
-
- 6 edits1 add in trunk/Source/WebCore
Flex layout may use flex box's height to stretch flex items
https://bugs.webkit.org/show_bug.cgi?id=240774
Reviewed by Antti Koivisto.
This is in preparation for being able to stretch the flex items vertically (e.g. when the flex box has fixed height)
- Source/WebCore/Headers.cmake:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Source/WebCore/layout/formattingContexts/FormattingConstraints.h:
(WebCore::Layout::ConstraintsForInFlowContent::isConstraintsForFlexContent const):
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingConstraints.h: Added.
(WebCore::Layout::ConstraintsForFlexContent::availableVerticalSpace const):
(WebCore::Layout::ConstraintsForFlexContent::ConstraintsForFlexContent):
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContent):
(WebCore::Layout::FlexFormattingContext::sizeAndPlaceFlexItems):
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
- Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::layout):
Canonical link: https://commits.webkit.org/250849@main
- 12:43 PM Changeset in webkit [294622] by
-
- 1 edit1 add in trunk/LayoutTests/platform/ios
AX: Update expectation for accessibility/aria-modal-with-text-crash.html on iOS
https://bugs.webkit.org/show_bug.cgi?id=240729
Reviewed by Chris Fleizach.
This test just needed a rebaseline.
- LayoutTests/platform/ios/TestExpectations:
- LayoutTests/platform/ios/accessibility/aria-modal-with-text-crash-expected.txt: Added.
Canonical link: https://commits.webkit.org/250848@main
- 11:00 AM Changeset in webkit [294621] by
-
- 10 edits in trunk
Unreviewed, reverting r249538 & r249598.
https://bugs.webkit.org/show_bug.cgi?id=240769
Introduced inconsistencies between backend and frontend DOM tree state.
Reverted changesets:
"Web Inspector: preserve DOM.NodeId if a node is removed and re-added"
https://bugs.webkit.org/show_bug.cgi?id=189687
https://commits.webkit.org/249538
"Web Inspector: Clean up
WI.DOMNodeto no longer require the sharedWI.DOMManagerbe passed during construction"
https://bugs.webkit.org/show_bug.cgi?id=239129
https://commits.webkit.org/249598
Canonical link: https://commits.webkit.org/250847@main
- 7:36 AM Changeset in webkit [294620] by
-
- 1 edit2 adds in trunk
REGRESSION(r293956): Bad color inheritance due to disallowsFastPathInheritance bit missing from RenderStyle::copyNonInheritedFrom
https://bugs.webkit.org/show_bug.cgi?id=240770
Reviewed by Alan Bujtas.
Test: fast/css/color-inheritance-dynamic.html
- Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
Add it.
- LayoutTests/fast/css/color-inheritance-dynamic-expected.html: Added.
- LayoutTests/fast/css/color-inheritance-dynamic.html: Added.
Canonical link: https://commits.webkit.org/250846@main
- 3:00 AM Changeset in webkit [294619] by
-
- 8 edits1 add in trunk
Clear StructureCache if it has Structure with relevant JSGlobalObjects
https://bugs.webkit.org/show_bug.cgi?id=240768
rdar://93232129
Reviewed by Saam Barati.
We need to clear Structures in StructureCache when having-a-bad-time: it is possible that Structure could have this have-a-bad-time
relevant JSGlobalObjects in its prototype chain. We are clearing it for InternalFunction's allocation cache. We should do the
same thing for JSGlobalObject's StructureCache.
This patch adds new watchpoint, structureCacheClearedWatchpoint. And use it in DFG. This watchpoint fires when the cache is cleared,
and it can happen even though JSGlobalObject is not getting have-a-bad-time.
- JSTests/stress/global-object-have-a-bad-time-dependency.js: Added.
(shouldBe):
(cons):
- Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::fireWatchpointAndMakeAllArrayStructuresSlowPut):
(JSC::JSGlobalObject::clearStructureCache):
- Source/JavaScriptCore/runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::structureCacheClearedWatchpoint):
(JSC::JSGlobalObject::isStructureCacheCleared const):
- Source/JavaScriptCore/runtime/StructureCache.h:
(JSC::StructureCache::forEach):
- Source/JavaScriptCore/runtime/WeakGCMap.h:
Canonical link: https://commits.webkit.org/250845@main
May 21, 2022:
- 7:34 PM Changeset in webkit [294618] by
-
- 1 edit2 adds in trunk
Invisible border should not trigger Repaint diff when currentColor changes
https://bugs.webkit.org/show_bug.cgi?id=240763
Reviewed by Simon Fraser.
Let's check if the border is visible to decide if the currentColor should trigger Repaint diff.
Test: fast/repaint/currentColorChange-with-non-visible-border.html
- Source/WebCore/rendering/style/BorderData.cpp:
(WebCore::BorderData::isEquivalentForPainting const):
- LayoutTests/fast/repaint/currentColorChange-with-non-visible-border-expected.txt: Added.
- LayoutTests/fast/repaint/currentColorChange-with-non-visible-border.html: Added.
Canonical link: https://commits.webkit.org/250844@main
- 4:40 PM Changeset in webkit [294617] by
-
- 2 edits in trunk/Source
REGRESSION (r290124): Unable to insert decimal point when typing in a number text field in QQ app
https://bugs.webkit.org/show_bug.cgi?id=240761
rdar://91882650
Reviewed by Chris Dumez and Tim Horton.
After the changes in r290124, we no longer treat strings that end with a full stop (e.g. "1.") as valid floating point
numbers, per section 2.5.4.3 of the HTML spec (Real numbers), which states that a decimal number that contains a full
stop character (".") must be succeeded by one or more digit characters. The HTML spec later references this when
describing how to sanitize the value of number inputs -- namely, we return the value of the input if it's a valid
floating point number, and otherwise return the empty string.
However, the QQ app still relies on the fact that strings of the form are "<n>." are valid floating point numbers; this
is because the app installs akeyupevent handler that asks for the input's value, removes all non-digit and non-
full-stop characters, and then sets the text field's value to this new string. Because strings ending with a period are
no longer valid floating point numbers, it's now very difficult to type decimals of the form"N.N"into some text
fields in the QQ app, since the input is cleared out each time the user types "." at the end of the field.
This new behavior (more or less) matches Chrome and Firefox; to maintain consistent behavior with other browsers without
breaking binary compatibility, we guard this new behavior with a linked-on-or-after check.
- Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
- Source/WebCore/html/parser/HTMLParserIdioms.cpp:
(WebCore::parseToDoubleForNumberType):
Canonical link: https://commits.webkit.org/250843@main
- 4:38 PM Changeset in webkit [294616] by
-
- 3 edits in trunk/Source
InteractionRegion UI-side layers should be grouped by originating element
https://bugs.webkit.org/show_bug.cgi?id=240766
Reviewed by Wenson Hsieh.
- Source/WebCore/page/InteractionRegion.cpp:
(WebCore::regionForElement):
- Source/WebCore/page/InteractionRegion.h:
(WebCore::operator==):
(WebCore::InteractionRegion::encode const):
(WebCore::InteractionRegion::decode):
Store and transmit an ElementIdentifier for each InteractionRegion.
- Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm:
(WebKit::updateLayersForInteractionRegions):
Apply it to the layer.
Canonical link: https://commits.webkit.org/250842@main
- 4:16 PM Changeset in webkit [294615] by
-
- 18 edits in trunk
Perspective should not be affected by transform-origin
https://bugs.webkit.org/show_bug.cgi?id=211787
<rdar://problem/63143806>
Patch by Nikolas Zimmermann <nzimmermann@igalia.com> on 2022-05-21
Reviewed by Simon Fraser.
Fix a number of issues related to perspective handling:
- 'perspective-origin' always used the border-box as reference box, when resolving length percentages, ignoring the choice of 'transform-box'. Fix that.
- Proper 'transform-box' awareness throghout RenderLayerBacking (few places with issue, e.g. perspectiveOrigin() affecting repaint & coverage rects)
- The chosen perspective transformation was not invariant under 'transform-origin' / 'transform-box' changes of the element A, that defines the perspective. However the perspective set on element A should only affect the rendering of its descendants: the choice of the 'transform-origin' / 'transform-box' of element A should have no effect on the perspective established for the children.
- Assure that 'transform-box' changes trigger GraphicLayer geometry updates: this fully fixes 'transform-box' support for composited elements, and brings its state on-par with non-composited elements (both support all kind of transform-box / transform-origin combinations on regular layers, clipped layers, scrolled layers).
This fixes the (not yet upstreamed) test web-platform-tests/css/css-transforms/animation/transform-box-will-change-transform-layer.html.
Prepared a new WPT test (see above) for upstreaming.
- Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::computeTransformedExtentViaTransformList const):
- Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::perspectiveTransform const):
(WebCore::RenderLayer::perspectiveOrigin const):
- Source/WebCore/rendering/RenderLayer.h:
- Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateTransform):
(WebCore::RenderLayerBacking::updateChildrenTransformAndAnchorPoint):
(WebCore::RenderLayerBacking::computeTransformOriginForPainting const): Deleted.
- Source/WebCore/rendering/RenderLayerBacking.h:
- Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::recompositeChangeRequiresGeometryUpdate):
- Source/WebCore/rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::applySVGTransform const):
- Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::computePerspectiveOrigin const):
(WebCore::RenderStyle::applyPerspective const):
(WebCore::RenderStyle::computeTransformOrigin const):
(WebCore::RenderStyle::applyTransformOrigin const):
(WebCore::RenderStyle::unapplyTransformOrigin const):
(WebCore::RenderStyle::applyTransform const):
(WebCore::RenderStyle::applyMotionPathTransform const):
- Source/WebCore/rendering/style/RenderStyle.h:
- Source/WebCore/svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::animatedLocalTransform const):
- LayoutTests/compositing/tiling/coverage-adjustment-secondary-quad-mapping-expected.txt:
- LayoutTests/compositing/tiling/perspective-on-scroller-tile-coverage-expected.txt:
- LayoutTests/platform/glib/TestExpectations:
- LayoutTests/platform/ios-wk2/compositing/tiling/coverage-adjustment-secondary-quad-mapping-expected.txt:
- LayoutTests/platform/ios/TestExpectations:
- LayoutTests/platform/mac-wk1/compositing/tiling/perspective-on-scroller-tile-coverage-expected.txt:
- LayoutTests/platform/mac/TestExpectations:
- LayoutTests/platform/win/TestExpectations:
Canonical link: https://commits.webkit.org/250841@main
- 12:26 PM Changeset in webkit [294614] by
-
- 6 edits11 adds in trunk
InteractionRegion for wrapped text has multiple rects instead of one
https://bugs.webkit.org/show_bug.cgi?id=240748
Reviewed by Wenson Hsieh.
- Source/WebCore/page/InteractionRegion.h:
(WebCore::operator==):
(WebCore::InteractionRegion::encode const):
(WebCore::InteractionRegion::decode):
- Source/WebCore/rendering/EventRegion.cpp:
(WebCore::EventRegion::translate):
(WebCore::EventRegion::dump const):
- Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm:
(WebKit::updateLayersForInteractionRegions):
- Source/WebCore/page/DebugPageOverlays.cpp:
(WebCore::pathsForRegion):
(WebCore::InteractionRegionOverlay::activeRegion):
(WebCore::InteractionRegionOverlay::drawRect):
- Source/WebCore/page/InteractionRegion.cpp:
(WebCore::regionForElement):
Maintain InteractionRegion geometry as a Region instead of a vector of rects,
so that we can smush overlapping rectangles together on a per-InteractionRegion basis.
(WebCore::operator<<):
Add dumping code for InteractionRegion (and adopt it in EventRegion).
- LayoutTests/TestExpectations:
- LayoutTests/interaction-region/click-handler-expected.txt: Added.
- LayoutTests/interaction-region/click-handler.html: Added.
- LayoutTests/interaction-region/inline-link-dark-background-expected.txt: Added.
- LayoutTests/interaction-region/inline-link-dark-background.html: Added.
- LayoutTests/interaction-region/inline-link-expected.txt: Added.
- LayoutTests/interaction-region/inline-link.html: Added.
- LayoutTests/interaction-region/split-inline-link-expected.txt: Added.
- LayoutTests/interaction-region/split-inline-link.html: Added.
- LayoutTests/interaction-region/wrapped-inline-link-expected.txt: Added.
- LayoutTests/interaction-region/wrapped-inline-link.html: Added.
Add some basic interaction region tests, currently disabled by default
because they can only be run if you turn on the build-time flag.
"wrapped-inline-link.html" covers the case we are fixing by adopting Region;
the others are more generic tests that we should have had before.
Canonical link: https://commits.webkit.org/250840@main
- 8:15 AM Changeset in webkit [294613] by
-
- 4 edits in trunk
Support invalidation for :in-range/:out-of-range
https://bugs.webkit.org/show_bug.cgi?id=238902
<rdar://91718746>
Reviewed by Alan Bujtas.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has-expected.txt:
- Source/WebCore/html/InputType.cpp:
(WebCore::InputType::setValue):
No need to invalidate style unconditionally on value change anymore.
Use Style::PseudoClassChangeInvalidation for :in-range invalidation.
- Source/WebCore/html/SearchInputType.cpp:
(WebCore::SearchInputType::setValue):
Search cancel button style depends on emptiness of the value so invalidate that specifically.
- Source/WebCore/html/SearchInputType.h:
Canonical link: https://commits.webkit.org/250839@main
- 5:38 AM Changeset in webkit [294612] by
-
- 6 edits2 adds in trunk
Text selection does not show continuous selection when dragging across pages with widows
https://bugs.webkit.org/show_bug.cgi?id=240753
<rdar://90960113>
Reviewed by Antti Koivisto.
Use the correct variable to mark the line.
Test: fast/multicol/incorrect-is-first-line-after-page-break-with-widow.html
- Source/WebCore/layout/integration/inline/InlineIteratorLineBox.cpp:
(WebCore::InlineIterator::LineBoxIterator::operator bool const):
- Source/WebCore/layout/integration/inline/InlineIteratorLineBox.h:
(WebCore::InlineIterator::LineBoxIterator::operator bool const): Deleted.
- Source/WebCore/layout/integration/inline/LayoutIntegrationPagination.cpp:
(WebCore::LayoutIntegration::adjustLinePositionsForPagination):
- Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::lineIndexAfterPageBreak):
- Source/WebCore/testing/Internals.h:
- Source/WebCore/testing/Internals.idl:
- LayoutTests/fast/multicol/incorrect-is-first-line-after-page-break-with-widow-expected.txt: Added.
- LayoutTests/fast/multicol/incorrect-is-first-line-after-page-break-with-widow.html: Added.
Canonical link: https://commits.webkit.org/250838@main
May 20, 2022:
- 11:19 PM Changeset in webkit [294611] by
-
- 139 edits in trunk/Source
Start preparing the code base for marking the StringView(const char*) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=240687
Reviewed by Darin Adler.
Start preparing the code base for marking the StringView(const char*) constructor explicit.
This encourages people to ensure ASCIILiteral / ""_s whenever possible.
- Source/JavaScriptCore/API/JSAPIGlobalObject.mm:
(JSC::computeValidImportSpecifier):
- Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::isWebKitInjectedScript):
- Source/JavaScriptCore/jit/ExecutableAllocator.cpp:
(JSC::dumpJITMemory):
- Source/JavaScriptCore/jsc.cpp:
(GlobalObject::moduleLoaderImportModule):
(GlobalObject::moduleLoaderResolve):
- Source/JavaScriptCore/runtime/FileBasedFuzzerAgent.cpp:
(JSC::FileBasedFuzzerAgent::getPredictionInternal):
- Source/JavaScriptCore/runtime/IntlLocale.cpp:
(JSC::IntlLocale::initializeLocale):
- Source/JavaScriptCore/runtime/IntlObject.cpp:
(JSC::isValidTimeZoneNameFromICUTimeZone):
- Source/JavaScriptCore/runtime/TypeProfiler.cpp:
(JSC::TypeProfiler::logTypesForTypeLocation):
- Source/JavaScriptCore/testRegExp.cpp:
(parseRegExpLine):
- Source/JavaScriptCore/yarr/YarrUnicodeProperties.cpp:
(JSC::Yarr::HashTable::entry const):
- Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):
- Source/WebKit/UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::hasOnlySecureContent):
- Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _defaultAnimationController]):
- Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _defaultAnimationController]):
- Source/WTF/wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
- Source/WTF/wtf/SortedArrayMap.h:
(WTF::operator<):
- Source/WTF/wtf/URL.cpp:
(WTF::URL::hasSpecialScheme const):
(WTF::URL::setPath):
(WTF::protocolIsInternal):
(WTF::protocolIs):
(WTF::URL::isLocalFile const):
(WTF::protocolIsJavaScript):
(WTF::URL::protocolIsAbout const):
(WTF::portAllowed):
(WTF::mimeTypeFromDataURL):
(WTF::URL::isAboutBlank const):
(WTF::URL::isAboutSrcDoc const):
- Source/WTF/wtf/URL.h:
(WTF::URL::protocolIsBlob const):
(WTF::URL::protocolIsData const):
- Source/WTF/wtf/URLHelpers.cpp:
(WTF::URLHelpers::applyHostNameFunctionToURLString):
- Source/WTF/wtf/URLParser.cpp:
(WTF::URLParser::copyBaseWindowsDriveLetter):
(WTF::URLParser::URLParser):
(WTF::URLParser::parse):
- Source/WTF/wtf/text/ASCIILiteral.h:
- Source/WTF/wtf/text/StringView.h:
(WTF::operator==):
(WTF::operator!=):
(WTF::equal):
- Source/WebCore/Modules/applepay/PaymentSession.cpp:
(WebCore::isSecure):
- Source/WebCore/Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::resolveRelativeVirtualPath):
(WebCore::DOMFileSystem::getParent):
- Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp:
(WebCore::FetchBodyConsumer::packageFormData):
- Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::removeAllDatabasesForFullOriginPath):
- Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::databasesSizeForDirectory):
- Source/WebCore/Modules/mediasource/MediaSource.cpp:
(WebCore::addVP9FullRangeVideoFlagToContentType):
- Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::shouldIgnoreIceCandidate):
- Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::iceServersFromConfiguration):
- Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::isValidURLBasedPaymentMethodIdentifier):
- Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::YouTubePluginReplacement::youTubeURLFromAbsoluteURL):
- Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinatorInternal::needsAppIdQuirks):
- Source/WebCore/Modules/webdatabase/Database.cpp:
(WebCore::fullyQualifiedInfoTableName):
- Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::usage):
- Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::validateURL):
- Source/WebCore/Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
(WebCore::WebSocket::didUpgradeURL):
- Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:
(WebCore::hostName):
(WebCore::WebSocketHandshake::WebSocketHandshake):
(WebCore::WebSocketHandshake::httpURLForAuthenticationAndCookies const):
(WebCore::headerHasValidHTTPVersion):
- Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
- Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isSearchField const):
- Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaLandmarkRoleDescription const):
- Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::rolePlatformDescription const):
- Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::setPseudoElement):
- Source/WebCore/bindings/js/ScriptModuleLoader.cpp:
(WebCore::resolveModuleSpecifier):
- Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForLoad):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForPingLoad):
(WebCore::ContentExtensions::applyResultsToRequest):
- Source/WebCore/css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::isSupportedFormat const):
- Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::formatInfiniteOrNanValue const):
(WebCore::CSSPrimitiveValue::formatNumberValue const):
(WebCore::CSSPrimitiveValue::formatIntegerValue const):
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const):
- Source/WebCore/css/CSSPrimitiveValue.h:
- Source/WebCore/css/CSSSelector.cpp:
(WebCore::CSSSelector::parsePseudoElementType):
- Source/WebCore/css/ContainerQueryParser.cpp:
(WebCore::ContainerQueryParser::consumePlainSizeFeature):
- Source/WebCore/css/DOMCSSNamespace.cpp:
(WebCore::valueWithoutImportant):
- Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeDashedIdent):
- Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::consumeLangArgumentList):
- Source/WebCore/css/typedom/CSSOMVariableReferenceValue.cpp:
(WebCore::CSSOMVariableReferenceValue::create):
(WebCore::CSSOMVariableReferenceValue::setVariable):
- Source/WebCore/dom/ConstantPropertyMap.cpp:
(WebCore::variableDataForPositivePixelLength):
(WebCore::variableDataForPositiveDuration):
- Source/WebCore/dom/DataTransfer.cpp:
(WebCore::normalizeType):
- Source/WebCore/dom/Document.cpp:
(WebCore::Document::isCookieAverse const):
- Source/WebCore/dom/Element.cpp:
(WebCore::Element::isEventHandlerAttribute const):
- Source/WebCore/dom/TextDecoder.cpp:
(WebCore::TextDecoder::encoding const):
- Source/WebCore/editing/cocoa/HTMLConverter.mm:
(HTMLConverterCaches::isBlockElement):
(HTMLConverter::computedAttributesForElement):
(HTMLConverter::_processText):
- Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::stripMicrosoftPrefix):
- Source/WebCore/editing/markup.cpp:
(WebCore::shouldPreserveMSOLists):
- Source/WebCore/fileapi/BlobURL.cpp:
- Source/WebCore/html/FeaturePolicy.cpp:
(WebCore::FeaturePolicy::parse):
- Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
- Source/WebCore/html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formWouldHaveSecureSubmission):
- Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
- Source/WebCore/html/HTMLMediaElement.cpp:
- Source/WebCore/html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::hasValidClassId):
- Source/WebCore/html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::isImageType):
- Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
- Source/WebCore/html/URLDecomposition.cpp:
(WebCore::URLDecomposition::setUsername):
(WebCore::URLDecomposition::setPassword):
(WebCore::URLDecomposition::setHost):
(WebCore::URLDecomposition::setHostname):
- Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::State::fontString const):
- Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::getActiveUniform):
(WebCore::WebGLRenderingContextBase::getUniformLocation):
- Source/WebCore/html/parser/CSSPreloadScanner.cpp:
(WebCore::hasValidImportConditions):
- Source/WebCore/html/parser/HTMLMetaCharsetParser.cpp:
(WebCore::extractCharset):
- Source/WebCore/html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
- Source/WebCore/html/track/WebVTTParser.cpp:
- Source/WebCore/inspector/DOMPatchSupport.cpp:
- Source/WebCore/inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::revealFileExternally):
- Source/WebCore/inspector/InspectorStyleSheet.cpp:
(WebCore::StyleSheetHandler::observeComment):
(WebCore::lowercasePropertyName):
(WebCore::selectorsFromSource):
- Source/WebCore/loader/CookieJar.cpp:
(WebCore::CookieJar::shouldIncludeSecureCookies):
- Source/WebCore/loader/CustomHeaderFields.cpp:
(WebCore::CustomHeaderFields::thirdPartyDomainsMatch const):
- Source/WebCore/loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::open):
- Source/WebCore/loader/PolicyChecker.cpp:
(WebCore::FrameLoader::PolicyChecker::checkNavigationPolicy):
- Source/WebCore/loader/PrivateClickMeasurement.cpp:
(WebCore::PrivateClickMeasurement::parseAttributionRequest):
- Source/WebCore/loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::isPDFJSResourceLoad const):
- Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp:
(WebCore::parseApplicationCacheManifest):
- Source/WebCore/loader/archive/ArchiveResourceCollection.cpp:
(WebCore::ArchiveResourceCollection::archiveResourceForURL):
- Source/WebCore/loader/cache/CachedResource.cpp:
(WebCore::CachedResource::makeRevalidationDecision const):
- Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
- Source/WebCore/page/EventHandler.cpp:
(WebCore::hasDropZoneType):
- Source/WebCore/page/Frame.cpp:
(WebCore::createRegExpForLabels):
(WebCore::matchLabelsAgainstString):
- Source/WebCore/page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
(WebCore::Page::allowsLoadFromURL const):
- Source/WebCore/page/Quirks.cpp:
(WebCore::isYahooMail):
(WebCore::Quirks::shouldDisableContentChangeObserverTouchEventAdjustment const):
(WebCore::Quirks::shouldHideSearchFieldResultsButton const):
(WebCore::Quirks::isAmazon const):
(WebCore::Quirks::isGoogleMaps const):
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
(WebCore::Quirks::shouldDispatchedSimulatedMouseEventsAssumeDefaultPrevented const):
(WebCore::Quirks::simulatedMouseEventTypeForTarget const):
(WebCore::Quirks::shouldPreventPointerMediaQueryFromEvaluatingToCoarse const):
(WebCore::Quirks::shouldAvoidResizingWhenInputViewBoundsChange const):
(WebCore::Quirks::shouldDisablePointerEventsQuirk const):
(WebCore::Quirks::needsInputModeNoneImplicitly const):
(WebCore::Quirks::needsFullscreenDisplayNoneQuirk const):
(WebCore::Quirks::shouldSilenceWindowResizeEvents const):
(WebCore::Quirks::shouldSilenceMediaQueryListChangeEvents const):
(WebCore::Quirks::shouldUseLegacySelectPopoverDismissalBehaviorInDataActivation const):
(WebCore::Quirks::shouldOpenAsAboutBlank const):
(WebCore::Quirks::shouldBypassBackForwardCache const):
(WebCore::Quirks::shouldBypassAsyncScriptDeferring const):
(WebCore::Quirks::shouldMakeEventListenerPassive):
(WebCore::Quirks::shouldDisableElementFullscreenQuirk const):
(WebCore::Quirks::needsCanPlayAfterSeekedQuirk const):
(WebCore::Quirks::shouldLayOutAtMinimumWindowWidthWhenIgnoringScalingConstraints const):
(WebCore::Quirks::shouldIgnoreContentObservationForSyntheticClick const):
(WebCore::isKinjaLoginAvatarElement):
(WebCore::Quirks::isMicrosoftTeamsRedirectURL):
(WebCore::Quirks::needsBlackFullscreenBackgroundQuirk const):
(WebCore::Quirks::needsToForceUserSelectAndUserDragWhenInstallingImageOverlay const):
- Source/WebCore/page/SecurityOrigin.cpp:
(WebCore::schemeRequiresHost):
(WebCore::SecurityOrigin::shouldIgnoreHost):
(WebCore::shouldTreatAsUniqueOrigin):
(WebCore::isLoopbackIPAddress):
(WebCore::SecurityOrigin::isLocalHostOrLoopbackIPAddress):
- Source/WebCore/page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::shouldHideReferrer):
(WebCore::SecurityPolicy::generateOriginHeader):
- Source/WebCore/page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse):
- Source/WebCore/page/cocoa/ResourceUsageThreadCocoa.mm:
(WebCore::ResourceUsageThread::platformCollectCPUData):
- Source/WebCore/page/csp/ContentSecurityPolicy.cpp:
(WebCore::shouldReportProtocolOnly):
(WebCore::ContentSecurityPolicy::upgradeInsecureRequestIfNeeded const):
(WebCore::ContentSecurityPolicy::setUpgradeInsecureRequests):
- Source/WebCore/page/csp/ContentSecurityPolicySource.cpp:
(WebCore::ContentSecurityPolicySource::portMatches const):
- Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp:
(WebCore::ContentSecurityPolicySourceList::isProtocolAllowedByStar const):
- Source/WebCore/platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::isSupportedJSONMIMEType):
(WebCore::MIMETypeRegistry::isXMLMIMEType):
- Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::MacApplication::isSafari):
- Source/WebCore/platform/graphics/Image.cpp:
(WebCore::Image::isPDFResource):
(WebCore::Image::isPostScriptResource):
- Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
(WebCore::CDMFactoryFairPlayStreaming::supportsKeySystem):
- Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::isUnsupportedMIMEType):
- Source/WebCore/platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:
(WebCore::AVAssetMIMETypeCache::isUnsupportedContainerType):
- Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::fontWithFamilySpecialCase):
- Source/WebCore/platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:
(WebCore::videoCodecTypeFromRFC4281Type):
(WebCore::computeMediaCapabilitiesInfo):
- Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::isContentTypeSupported):
- Source/WebCore/platform/mac/UserAgentMac.mm:
(WebCore::standardUserAgentWithApplicationName):
- Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:
(WebCore::isValidCaptureDevice):
- Source/WebCore/platform/network/CacheValidation.cpp:
(WebCore::parseCacheControlDirectives):
(WebCore::cookieRequestHeaderFieldValue):
- Source/WebCore/platform/network/DataURLDecoder.cpp:
(WebCore::DataURLDecoder::DecodeTask::process):
- Source/WebCore/platform/network/HTTPParsers.cpp:
(WebCore::extractCharsetFromMediaType):
- Source/WebCore/platform/network/ParsedContentRange.cpp:
(WebCore::parseContentRange):
- Source/WebCore/platform/network/ParsedRequestRange.cpp:
(WebCore::ParsedRequestRange::parse):
- Source/WebCore/platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::shouldContentSniffURL):
- Source/WebCore/platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::redirectedRequest const):
- Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::isHTTP09 const):
- Source/WebCore/platform/network/cf/SocketStreamHandleImpl.h:
(WebCore::SocketStreamHandleImpl::shouldUseSSL const):
- Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:
(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
- Source/WebCore/platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::willSendRequest):
- Source/WebCore/plugins/PluginData.cpp:
(WebCore::shouldBePubliclyVisible):
- Source/WebCore/rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absolutePDFURL const):
- Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::listMarkerSuffix):
- Source/WebCore/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::scrollToFragment):
- Source/WebCore/svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseOffsetValue):
(WebCore::SVGSMILElement::parseCondition):
- Source/WebCore/workers/Worker.cpp:
(WebCore::Worker::didReceiveResponse):
- Source/WebCore/workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::addRegistration):
- Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::shouldAllowExternalLoad):
Canonical link: https://commits.webkit.org/250837@main
- 11:09 PM Changeset in webkit [294610] by
-
- 36 edits1 copy4 adds in trunk
Release assert in Document::updateLayout() via HTMLTextAreaElement::childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=224471
Reviewed by Ryosuke Niwa.
This patch is based on a set of patches made by Sergio Villar Senin
and Gabriel Nava Marino.
Executing some editing commands in a text area might force the recomputation of things
like caret or the visible selection position and extent. Under some circumstances (like
when the text area has no content and children) we might end up trying to update layout
when it is not safe as a side effect of updating the caret.
In order to fix that, we can switch to a model in which we update the selection asynchronously
in the case of having a non-user triggered change. That way we don't do it inside
a restricted layout scope.
The App Highlight restoration code had to be tuned as well (when restoring and scrolling to reveal
a Quick Note on iOS MacOS). It uses TemporarySelectionChange to select and scroll to reveal the highlight
range; the code assumed that this scrolling happens synchronously, since it reverts the selection to
the original range at the end ofAppHighlightStorage::attemptToRestoreHighlightAndScrollwhen the
TemporarySelectionChange falls out of scope. That is however no longer the case. Actually no scrolling
happened after this patch because we end up only scheduling the appearance update timer before setting
the selection back to the original state withSelectionRevealMode::DoNotReveal. Since this only happens
when the user interacts in the Notes app, it seems sensible to consider it as a user triggered event.
Layout Tests
Moved some tests out of the text-based-repaint.js model because selection is now updated
and revealed asynchronously in the case of non-user triggered changes. The problem is that
by the time the repaint rects are queried the update has not happened yet. That's why
the tests were modified so that we wait until the repaint happens.
Same situation for other tests that do not involve repaint rects but trigger accesibility
tree updates. We must ensure that we let the notification be thrown before checking whether or
not has been emited. As it's done asynchronously we must let the main thread run before checking.
Last but not least, some of the tests are using setTimeout() instead of requestAnimationFrame()
because the results with the latter were not as reliable under stress/debug conditions.
- Source/WebCore/Modules/highlight/AppHighlightStorage.cpp:
(WebCore::AppHighlightStorage::attemptToRestoreHighlightAndScroll):
- Source/WebCore/editing/Editor.cpp:
(WebCore::TemporarySelectionChange::setSelection):
- Source/WebCore/editing/Editor.h:
- Source/WebCore/editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::updateSelectionAppearanceNow):
(WebCore::FrameSelection::absoluteCaretBounds):
(WebCore::FrameSelection::setCaretVisibility):
(WebCore::FrameSelection::selectionBounds):
(WebCore::FrameSelection::revealSelection):
(WebCore::updateSelectionByUpdatingLayoutOrStyle): Deleted.
(WebCore::FrameSelection::selectionBounds const): Deleted.
- Source/WebCore/editing/FrameSelection.h:
- Source/WebCore/page/EventHandler.cpp:
(WebCore::setSelectionIfNeeded):
- Source/WebCore/page/Page.cpp:
(WebCore::Page::doAfterUpdateRendering):
- LayoutTests/accessibility/mac/selection-boundary-userinfo.html:
- LayoutTests/accessibility/mac/selection-change-userinfo.html:
- LayoutTests/accessibility/mac/selection-value-changes-for-aria-textbox.html:
- LayoutTests/editing/selection-with-absolute-positioned-empty-content.html:
- LayoutTests/fast/forms/textarea-scrolled-endline-caret.html:
- LayoutTests/fast/repaint/selection-gap-absolute-child-expected.txt:
- LayoutTests/fast/repaint/selection-gap-absolute-child.html:
- LayoutTests/fast/repaint/selection-gap-fixed-child.html:
- LayoutTests/fast/repaint/selection-gap-flipped-absolute-child-expected.txt:
- LayoutTests/fast/repaint/selection-gap-flipped-absolute-child.html:
- LayoutTests/fast/repaint/selection-gap-transformed-absolute-child-expected.txt:
- LayoutTests/fast/repaint/selection-gap-transformed-absolute-child.html:
- LayoutTests/fast/repaint/selection-gap-transformed-fixed-child-expected.txt:
- LayoutTests/fast/repaint/selection-gap-transformed-fixed-child.html:
- LayoutTests/fast/repaint/selection-paint-invalidation-expected.txt:
- LayoutTests/fast/repaint/selection-ruby-rl-expected.txt:
- LayoutTests/fast/repaint/selection-ruby-rl.html:
- LayoutTests/fast/repaint/text-selection-overflow-hidden-expected.txt:
- LayoutTests/fast/repaint/text-selection-overflow-hidden.html:
- LayoutTests/fast/text/incorrect-deselection-across-multiple-elements.html:
- LayoutTests/platform/gtk/TestExpectations:
- LayoutTests/platform/gtk/fast/repaint/selection-ruby-rl-expected.txt: Copied from LayoutTests/fast/repaint/selection-ruby-rl-expected.txt.
- LayoutTests/platform/gtk/fast/repaint/text-selection-overflow-hidden-expected.txt:
- LayoutTests/platform/mac-wk1/TestExpectations:
- LayoutTests/platform/mac-wk1/accessibility/mac/focus-setting-selection-syncronizing-not-clearing-expected.txt: Added.
- LayoutTests/platform/mac-wk1/fast/repaint/4776765-expected.txt: Added.
- LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-margin-005-expected.txt:
- LayoutTests/platform/mac/TestExpectations:
- LayoutTests/platform/win/fast/repaint/4776765-expected.txt: Added.
- LayoutTests/platform/win/fast/repaint/selection-ruby-rl-expected.txt:
- LayoutTests/platform/win/fast/repaint/text-selection-overflow-hidden-expected.txt:
Canonical link: https://commits.webkit.org/250836@main
- 10:39 PM Changeset in webkit [294609] by
-
- 2 edits in trunk
[css-values-4] logical
*vi(inline) and*vb(block) viewport units should be based on the current element'swriting-mode
https://bugs.webkit.org/show_bug.cgi?id=234373
<rdar://problem/86832561>
Reviewed by Tim Nguyen.
Previously, we only looked at the root element's
writing-mode. Looking at the current element's
writing-modeallows for non-root elements to have awriting-modeindependent of the root element,
as well as having styles based on that. This was changed in <https://github.com/w3c/csswg-drafts/issues/6873>.
Tests: CSSViewportUnits.AllSame
CSSViewportUnits.MinimumViewportInsetWithWritingMode
CSSViewportUnits.MaximumViewportInsetWithWritingMode
CSSViewportUnits.EmptyUnobscuredSizeOverrides
CSSViewportUnits.SameUnobscuredSizeOverrides
CSSViewportUnits.DifferentUnobscuredSizeOverrides
CSSViewportUnits.SVGDocument
- Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::lengthOfViewportPhysicalAxisForLogicalAxis):
(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:
(changeCSSPropertyOfElements): Added.
(TEST.CSSViewportUnits.AllSame):
(TEST.CSSViewportUnits.MinimumViewportInsetWithWritingMode):
(TEST.CSSViewportUnits.MaximumViewportInsetWithWritingMode):
(TEST.CSSViewportUnits.EmptyUnobscuredSizeOverrides):
(TEST.CSSViewportUnits.SameUnobscuredSizeOverrides):
(TEST.CSSViewportUnits.DifferentUnobscuredSizeOverrides):
(TEST.CSSViewportUnits.SVGDocument):
Canonical link: https://commits.webkit.org/250835@main
- 9:21 PM Changeset in webkit [294608] by
-
- 1 edit in trunk/metadata/contributors.json
Trying out my git setup: Update my personal info in contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240745
Reviewed by Beth Dakin.
- metadata/contributors.json: Added some news skills I've acquired.
Canonical link: https://commits.webkit.org/250834@main
- 7:33 PM Changeset in webkit [294607] by
-
- 24 edits in trunk
Convert ExpansionBehavior to a struct of left/right expansion behaviors
https://bugs.webkit.org/show_bug.cgi?id=240554
Patch by Kiet Ho <Kiet Ho> on 2022-05-20
Reviewed by Myles C. Maxfield.
- Tools/TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
(TestWebKitAPI::TEST_F):
- Source/WebKit/WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
No new tests, no functional changes made.
- Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::measureText):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::drawText):
(WebCore::CanvasRenderingContext2DBase::measureTextInternal):
- Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::applyRunExpansion):
- Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h:
- Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::fallbackFontsForText):
- Source/WebCore/platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
- Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::expansionOpportunityCountInternal):
- Source/WebCore/platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
- Source/WebCore/platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::calculateAdditionalWidth const):
- Source/WebCore/platform/text/TextFlags.h:
(WebCore::ExpansionBehavior::ExpansionBehavior):
(WebCore::ExpansionBehavior::allowLeftOnly):
(WebCore::ExpansionBehavior::forceLeftOnly):
(WebCore::ExpansionBehavior::allowRightOnly):
- Source/WebCore/platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::paint):
- Source/WebCore/rendering/LegacyEllipsisBox.cpp:
(WebCore::LegacyEllipsisBox::paint):
(WebCore::LegacyEllipsisBox::selectionRect const):
(WebCore::LegacyEllipsisBox::paintSelection):
- Source/WebCore/rendering/LegacyInlineTextBox.cpp:
(WebCore::LegacyInlineTextBox::expansionBehavior const):
- Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::expansionBehaviorForInlineTextBox):
(WebCore::applyExpansionBehavior):
- Source/WebCore/rendering/RenderBlock.h:
- Source/WebCore/rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths const):
- Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
- Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
- Source/WebCore/rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::getAverageCharWidth):
- Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun const):
- Source/WebCore/rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::constructTextRun):
Canonical link: https://commits.webkit.org/250833@main
- 7:25 PM Changeset in webkit [294606] by
-
- 1 edit2 adds in trunk
Fix invalid assertion in parseKeywordValue
https://bugs.webkit.org/show_bug.cgi?id=240593
Reviewed by Antti Koivisto.
Test: fast/css/parse-non-descriptor.html
- Source/WebCore/css/parser/CSSParserFastPaths.cpp:
This function returns null, which is fine.
Canonical link: https://commits.webkit.org/250831@main
- 7:24 PM Changeset in webkit [294605] by
-
- 3 edits in trunk/Source/WebCore
Reduce branching a little under JSNodeOwner::isReachableFromOpaqueRoots()
https://bugs.webkit.org/show_bug.cgi?id=240742
Reviewed by Geoffrey Garen.
Given that JSNodeOwner::isReachableFromOpaqueRoots() already checks if the Node is
connected or not, make sure to avoid the same check under Node::opaqueRoot().
- Source/WebCore/bindings/js/JSNodeCustom.cpp:
(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
- Source/WebCore/dom/Node.cpp:
(WebCore::Node::traverseToOpaqueRoot const):
(WebCore::Node::opaqueRootSlow const): Deleted.
- Source/WebCore/dom/Node.h:
(WebCore::Node::opaqueRoot const):
Canonical link: https://commits.webkit.org/250831@main
- 6:23 PM Changeset in webkit [294604] by
-
- 1 copy1 delete in trunk/LayoutTests/platform
[Gardening]: [ iOS ] fast/events/ios/rotation/layout-viewport-during-safari-type-rotation.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=231266
Unreviewed test gardening.
- LayoutTests/platform/ios/fast/events/ios/rotation/layout-viewport-during-safari-type-rotation-expected.txt: Renamed from LayoutTests/platform/ios-wk2/fast/events/ios/rotation/layout-viewport-during-safari-type-rotation-expected.txt.
Canonical link: https://commits.webkit.org/250830@main
- 6:06 PM Changeset in webkit [294603] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations
[ Gardening ]: [ BigSur+ Debug wk2 EWS ] imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/quirks.window.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=237165
Unreviewed test gardening. Removal of no longer needed expectation.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250829@main
- 5:48 PM Changeset in webkit [294602] by
-
- 1 copy in tags/WebKit-7614.1.14.10.2
Tag WebKit-7614.1.14.10.2.
- 5:41 PM Changeset in webkit [294601] by
-
- 1 copy in tags/WebKit-7614.1.14.1.8
Tag WebKit-7614.1.14.1.8.
- 5:35 PM Changeset in webkit [294600] by
-
- 1 edit in trunk/metadata/contributors.json
Trying git workflow: updating personal info in contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240747
Reviewed by Wenson Hsieh.
Adding more recent areas of expertise.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250828@main
- 5:23 PM Changeset in webkit [294599] by
-
- 4 edits89 adds in trunk
[WebGPU] Integrate Metal-cpp
https://bugs.webkit.org/show_bug.cgi?id=240746
<rdar://problem/89344870>
Reviewed by Dean Jackson.
Metal-cpp is a low-overhead C++ interface for Metal.
https://developer.apple.com/metal/cpp/
Metal-cpp isn't a library per-se, but is instead just a collection of files which users
are supposed to just copy into their project. This does just that, and hooks up all the
necessary flags and paths and everything.
This uses the "single header alternative" described on that webpage, and creates the
single file as a build step.
Metal-cpp files should not be style-checked.
- Source/WebGPU/Configurations/WebGPU.xcconfig:
- Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:
- Source/WebGPU/WebGPU/Metal.cpp: Added.
- Source/WebGPU/WebGPU/config.h:
- Source/WebGPU/WebGPU/metal-cpp/Foundation/Foundation.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSArray.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSAutoreleasePool.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSBundle.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSData.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSDate.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSDefines.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSDictionary.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSEnumerator.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSError.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSLock.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSNotification.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSNumber.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSObjCRuntime.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSObject.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSPrivate.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSProcessInfo.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSRange.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSString.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSTypes.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Foundation/NSURL.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/LICENSE.txt: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLAccelerationStructure.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLAccelerationStructureCommandEncoder.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLAccelerationStructureTypes.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLArgument.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLArgumentEncoder.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLBinaryArchive.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLBlitCommandEncoder.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLBlitPass.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLBuffer.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLCaptureManager.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLCaptureScope.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLCommandBuffer.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLCommandEncoder.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLCommandQueue.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLComputeCommandEncoder.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLComputePass.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLComputePipeline.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLCounters.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLDefines.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLDepthStencil.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLDevice.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLDrawable.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLDynamicLibrary.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLEvent.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLFence.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLFunctionConstantValues.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLFunctionDescriptor.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLFunctionHandle.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLFunctionLog.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLFunctionStitching.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLHeaderBridge.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLHeap.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLIndirectCommandBuffer.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLIndirectCommandEncoder.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLIntersectionFunctionTable.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLLibrary.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLLinkedFunctions.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLParallelRenderCommandEncoder.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLPipeline.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLPixelFormat.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLPrivate.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLRasterizationRate.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLRenderCommandEncoder.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLRenderPass.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLRenderPipeline.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLResource.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLResourceStateCommandEncoder.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLResourceStatePass.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLSampler.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLStageInputOutputDescriptor.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLTexture.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLTypes.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLVertexDescriptor.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/MTLVisibleFunctionTable.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/Metal/Metal.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/QuartzCore/CADefines.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/QuartzCore/CAMetalDrawable.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/QuartzCore/CAPrivate.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/QuartzCore/QuartzCore.hpp: Added.
- Source/WebGPU/WebGPU/metal-cpp/README.md: Added.
- Source/WebGPU/WebGPU/metal-cpp/SingleHeader/MakeSingleHeader.py: Added.
(HeaderPrefix):
(HeaderPrefix.init):
(HeaderPrefix.str):
(HeaderPrefix.get_commit_hash):
(HeaderPrefix.get_commit_string):
(HeaderPrefix.get_date_string):
(meta_data_string):
(SingleHeader):
(SingleHeader.init):
(SingleHeader.str):
(SingleHeader.append):
(SingleHeader.process):
(SingleHeader.read_header):
(SingleHeader.strip_pragma_once):
(SingleHeader.strip_comments):
(SingleHeader.strip_empty_lines):
(SingleHeader.substitute_include_directive):
(SingleHeader.process_include_directives):
(SingleHeader.process_foundation_directives):
(SingleHeader.process_header):
(create_argument_parser):
(parse_arguments):
(make_header):
(make_dir):
(write_header):
- Tools/Scripts/webkitpy/style/checker.py:
Canonical link: https://commits.webkit.org/250827@main
- 5:23 PM Changeset in webkit [294598] by
-
- 47 edits in branches/safari-7614.1.14.10-branch/Source
Cherry-pick r294496. rdar://problem/93068926
[Xcode] Prevent STP and other self-contained builds from overwriting content in the macOS SDK
https://bugs.webkit.org/show_bug.cgi?id=240408
Reviewed by Alexey Proskuryakov.
When building with WK_OVERRIDE_FRAMEWORKS_DIR, we assume that WebKit is
being built as part of a self-contained application, e.g. Safari
Technology Preview. This means that most content is installed to the
override directory, instead of the normal /System/Library/Frameworks
directory.
However, static library content (e.g. headers and archives
for bmalloc, webrtc, WTF) is _not_ installed to the override directory,
as it is not needed at runtime. It was being installed to the default
/usr/local prefix, where it would merge with and overwrite whatever
WebKit content was already present.
To prevent overwrites and other sorts of conflict with the
system-provided WebKit, introduce WK_LIBRARY_HEADERS_FOLDER_PATH and
WK_LIBRARY_INSTALL_PATH, which expand to /usr/local/include/safari-sdk
and /usr/local/lib/safari-sdk respectively when building in this mode.
Static library headers and archives are built to these locations, where
they're still in the expected SDK location, but won't clobber system
WebKit.
- Source/bmalloc/Configurations/Base.xcconfig:
- Source/bmalloc/Configurations/bmalloc.xcconfig:
- Source/bmalloc/Configurations/mbmalloc.xcconfig:
- Source/JavaScriptCore/Configurations/Base.xcconfig:
- Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
- Source/JavaScriptCore/DerivedSources.make:
- Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
- Source/JavaScriptCore/Scripts/generate-unified-sources.sh:
- Source/JavaScriptCore/offlineasm/config.rb:
- Source/JavaScriptCore/offlineasm/parser.rb:
- Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/AngleMetalLib.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/boringssl.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/yasm.xcconfig:
- Source/WebCore/PAL/Configurations/Base.xcconfig:
- Source/WebCore/PAL/Configurations/PAL.xcconfig:
- Source/WebGPU/Configurations/Base.xcconfig:
- Source/WebGPU/Configurations/WGSL.xcconfig:
- Source/WebGPU/Configurations/WGSLUnitTests.xcconfig:
- Source/WebGPU/Configurations/WebGPU.xcconfig:
- Source/WebKit/Configurations/Base.xcconfig:
- Source/WebKit/Configurations/BaseTarget.xcconfig:
- Source/WebKit/Configurations/SandboxProfiles.xcconfig:
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Source/WebKitLegacy/scripts/generate-unified-sources.sh:
- Source/WebKitLegacy/mac/Configurations/Base.xcconfig:
- Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:
- Source/WTF/Configurations/Base.xcconfig:
- Source/WTF/Configurations/WTF.xcconfig:
- Source/WTF/Configurations/icu.xcconfig:
- Source/WebCore/Configurations/Base.xcconfig:
- Source/WebCore/Configurations/WebCore.xcconfig:
- Source/WebCore/Configurations/WebCoreTestSupport.xcconfig:
- Source/WebCore/DerivedSources.make:
- Source/WebCore/Scripts/generate-unified-sources.sh:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/250755@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:19 PM Changeset in webkit [294597] by
-
- 9 edits in branches/safari-7614.1.14.10-branch/Source
Versioning.
WebKit-7614.1.14.10.2
- 5:11 PM Changeset in webkit [294596] by
-
- 1 copy in tags/WebKit-7614.1.14.0.8
Tag WebKit-7614.1.14.0.8.
- 5:10 PM Changeset in webkit [294595] by
-
- 1 edit in trunk/JSTests/stress/regexp-bol-optimize-out-of-stack.js
Reduce array length for memory limited scenarios in regexp-bol-optimize-out-of-stack.js
https://bugs.webkit.org/show_bug.cgi?id=240717
Patch by Xan López <Xan Lopez> on 2022-05-20
Reviewed by Yusuke Suzuki.
- stress/regexp-bol-optimize-out-of-stack.js: use a smaller array size when memory is limited.
(test):
Canonical link: https://commits.webkit.org/250826@main
- 5:06 PM Changeset in webkit [294594] by
-
- 1 copy in tags/WebKit-7614.1.14.3.3
Tag WebKit-7614.1.14.3.3.
- 5:04 PM Changeset in webkit [294593] by
-
- 1 copy in tags/WebKit-7614.1.14.2.3
Tag WebKit-7614.1.14.2.3.
- 5:02 PM Changeset in webkit [294592] by
-
- 5 edits in trunk/Source/WebKit
Unreviewed, reverting r294371.
https://bugs.webkit.org/show_bug.cgi?id=240740
Introduced page load regression
Reverted changeset:
"Private relay should fail closed for third party loads if the main resource was loaded over private relay"
https://bugs.webkit.org/show_bug.cgi?id=240483
https://commits.webkit.org/r294371
Canonical link: https://commits.webkit.org/250825@main
- 4:42 PM Changeset in webkit [294591] by
-
- 5 edits in trunk/Source/WebKit
Remove unused WebPage::InteractionRegions IPC
https://bugs.webkit.org/show_bug.cgi?id=240725
Reviewed by Wenson Hsieh.
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::interactionRegions): Deleted.
- Source/WebKit/UIProcess/WebPageProxy.h:
- Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::interactionRegions): Deleted.
- Source/WebKit/WebProcess/WebPage/WebPage.h:
- Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
Canonical link: https://commits.webkit.org/250824@main
- 4:40 PM Changeset in webkit [294590] by
-
- 5 edits in trunk
Web Inspector: only override request headers if they are provided
https://bugs.webkit.org/show_bug.cgi?id=240734
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:
(WI.NetworkManager.prototype.async requestIntercepted):
(WI.NetworkManager.prototype.async responseIntercepted):
- LayoutTests/http/tests/inspector/network/intercept-request-properties.html:
- LayoutTests/http/tests/inspector/network/intercept-request-properties-expected.txt:
- LayoutTests/http/tests/inspector/network/local-resource-override-basic.html:
- LayoutTests/http/tests/inspector/network/local-resource-override-basic-expected.txt:
Canonical link: https://commits.webkit.org/250823@main
- 4:09 PM Changeset in webkit [294589] by
-
- 4 edits in trunk
[MacCatalyst] REGRESSION(r290091): sometimes can hang if
WKWebViewis unparented before the next visible content rect update
https://bugs.webkit.org/show_bug.cgi?id=240691
<rdar://problem/92006847>
Reviewed by Wenson Hsieh.
Test: WKWebViewResize.RemovesAssertionsAfterMovingToWindow
- Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _processWillSwapOrDidExit]):
(-[WKWebView didMoveToWindow]):
(-[WKWebView _acquireResizeAssertionForReason:]):
Drive-by: WebProcess crashes should also clear the resize assertions.
Drive-by: Add a 1s timeout in case the next visible content rect update takes too long.
- Source/WebKit/UIProcess/API/ios/WKWebViewPrivateForTestingIOS.h:
- Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm:
(-[WKWebView _hasResizeAssertion]): Added.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewResize.mm:
(TEST.WKWebViewResize.RemovesAssertionsAfterMovingToWindow): Added.
Canonical link: https://commits.webkit.org/250822@main
- 3:53 PM Changeset in webkit [294588] by
-
- 1 edit in trunk/Source/WebInspectorUI/UserInterface/Views/LocalResourceOverridePopover.js
Web Inspector: Sources Tab: adding a new header to a request local override doesn't show it
https://bugs.webkit.org/show_bug.cgi?id=240733
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Views/LocalResourceOverridePopover.js:
(WI.LocalResourceOverridePopover.prototype.show):
Canonical link: https://commits.webkit.org/250821@main
- 3:37 PM Changeset in webkit [294587] by
-
- 24 edits1 copy2 moves1 add2 deletes in trunk/LayoutTests
Clean up some fast/text layout tests
https://bugs.webkit.org/show_bug.cgi?id=240738
Reviewed by Myles C. Maxfield.
Move Ahem-COLR.ttf from fast/text/canvas-color-fonts/resources to fast/text/resources
so a future non-canvas test can use it.
Create a fast/text/glyph-display-lists directory to host more future glyph
display list tests.
Remove platform/ios/fast/text/softHyphen-expected.txt because the test is a ref test.
- LayoutTests/TestExpectations:
- LayoutTests/fast/text/canvas-color-fonts/COLR-expected.html:
- LayoutTests/fast/text/canvas-color-fonts/COLR.html:
- LayoutTests/fast/text/canvas-color-fonts/ctm-COLR-expected.html:
- LayoutTests/fast/text/canvas-color-fonts/ctm-COLR.html:
- LayoutTests/fast/text/canvas-color-fonts/fill-color-COLR-expected.html:
- LayoutTests/fast/text/canvas-color-fonts/fill-color-COLR.html:
- LayoutTests/fast/text/canvas-color-fonts/fill-color-shadow-COLR.html:
- LayoutTests/fast/text/canvas-color-fonts/fill-color-shadow-ctm-COLR.html:
- LayoutTests/fast/text/canvas-color-fonts/fill-gradient-COLR-2.html:
- LayoutTests/fast/text/canvas-color-fonts/fill-gradient-COLR.html:
- LayoutTests/fast/text/canvas-color-fonts/linedash-COLR-expected-mismatch.html:
- LayoutTests/fast/text/canvas-color-fonts/linedash-COLR.html:
- LayoutTests/fast/text/canvas-color-fonts/linedash-outlines-expected-mismatch.html:
- LayoutTests/fast/text/canvas-color-fonts/linedash-outlines.html:
- LayoutTests/fast/text/canvas-color-fonts/stroke-color-COLR-expected.html:
- LayoutTests/fast/text/canvas-color-fonts/stroke-color-COLR.html:
- LayoutTests/fast/text/canvas-color-fonts/stroke-color-shadow-COLR.html:
- LayoutTests/fast/text/canvas-color-fonts/stroke-color-shadow-ctm-COLR.html:
- LayoutTests/fast/text/canvas-color-fonts/stroke-gradient-COLR-2.html:
- LayoutTests/fast/text/canvas-color-fonts/stroke-gradient-COLR-3.html:
- LayoutTests/fast/text/canvas-color-fonts/stroke-gradient-COLR-4.html:
- LayoutTests/fast/text/canvas-color-fonts/stroke-gradient-COLR-5.html:
- LayoutTests/fast/text/canvas-color-fonts/stroke-gradient-COLR.html:
- LayoutTests/fast/text/glyph-display-lists/glyph-display-list-color-expected.txt: Renamed from LayoutTests/fast/text/glyph-display-list-color-expected.txt.
- LayoutTests/fast/text/glyph-display-lists/glyph-display-list-color.html: Renamed from LayoutTests/fast/text/glyph-display-list-color.html.
- LayoutTests/fast/text/resources/Ahem-COLR.ttf: Renamed from LayoutTests/fast/text/canvas-color-fonts/resources/Ahem-COLR.ttf.
- LayoutTests/platform/ios/fast/text/softHyphen-expected.txt: Removed.
Canonical link: https://commits.webkit.org/250820@main
- 3:10 PM WebKitGTK/2.36.x edited by
- (diff)
- 3:00 PM Changeset in webkit [294586] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r294243 - REGRESSION(r294104): [GStreamer][VideoCapture] Webcam raw streams may hang up the video capture pipeline
https://bugs.webkit.org/show_bug.cgi?id=240456
Patch by Loïc Le Page <llepage@igalia.com> on 2022-05-16
Reviewed by Philippe Normand.
When capturing a raw stream from a webcam, the pipeline may hang up because the decodebin3 cannot fix the upstream caps.
The webcam capsfilter should not only specify the captured mime-type (video/x-raw) but also the capture image dimensions.
Manually tested.
- platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
- 2:59 PM Changeset in webkit [294585] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r294229 - REGRESSION(r294104): [GStreamer] getUserMedia broken
https://bugs.webkit.org/show_bug.cgi?id=240420
Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-16
Reviewed by Xabier Rodriguez-Calvar.
The converter handling logic was modified in order to fix getUserMedia negotiated with raw
video and also getDisplayMedia which is always raw video and thus doesn't require decoding.
This patch also introduces a small optimization, reconfiguration is now done once only,
after setting size and framerate. Before this patch it was done twice, so the pipeline was a
taking more time to produce the first frame.
- platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
(WebCore::GStreamerVideoCaptureSource::~GStreamerVideoCaptureSource):
(WebCore::GStreamerVideoCaptureSource::settingsDidChange): Trigger capturer reconfiguration after setting both size and framerate.
(WebCore::GStreamerVideoCaptureSource::startProducingData): Ditto.
- platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::createConverter): Do not decode display capture streams, these are always raw anyway.
(WebCore::GStreamerVideoCapturer::setSize): Delay reconfiguration.
(WebCore::GStreamerVideoCapturer::setFrameRate): Ditto.
(WebCore::GStreamerVideoCapturer::reconfigure): Keep track of compatible video format. This
is needed to workaround an issue in pipewiresrc caps negotiation.
(WebCore::GStreamerVideoCapturer::adjustVideoSrcMIMEType): Renamed to reconfigure().
- platform/mediastream/gstreamer/GStreamerVideoCapturer.h:
Canonical link: https://commits.webkit.org/250587@main
- 2:57 PM Changeset in webkit [294584] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r294104 - [GStreamer][VideoCapture] Add support for capturing encoded video streams from a webcam
https://bugs.webkit.org/show_bug.cgi?id=240229
Patch by Loïc Le Page <llepage@igalia.com> on 2022-05-12
Reviewed by Philippe Normand.
Takes into account encoded video streams produced by a webcam for
video capture.
Manually tested (requires a webcam with encoded video streams).
- platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
(WebCore::GStreamerVideoCaptureSource::generatePresets):
- platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::createConverter):
(WebCore::GStreamerVideoCapturer::setSize):
(WebCore::GStreamerVideoCapturer::setFrameRate):
(WebCore::GStreamerVideoCapturer::adjustVideoSrcMIMEType):
- platform/mediastream/gstreamer/GStreamerVideoCapturer.h:
- 2:55 PM Changeset in webkit [294583] by
-
- 7 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r293580 - [GStreamer] Pipewire display capture broken
https://bugs.webkit.org/show_bug.cgi?id=239435
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-28
Reviewed by Xabier Rodriguez-Calvar.
The pipewiresrc GStreamer element now needs both the
fdandpathproperties set in order
to open the right Pipewire stream, so we need to get the node ID from the portal Start
response and pass it to the GStreamer element.
- platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.h:
- platform/mediastream/gstreamer/GStreamerDisplayCaptureDeviceManager.cpp:
(WebCore::GStreamerDisplayCaptureDeviceManager::createDisplayCaptureSource):
(WebCore::GStreamerDisplayCaptureDeviceManager::waitResponseSignal):
- platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
(WebCore::GStreamerVideoCaptureSource::createPipewireSource):
(WebCore::GStreamerVideoCaptureSource::GStreamerVideoCaptureSource):
(WebCore::m_deviceType):
(WebCore::GStreamerVideoCaptureSource::~GStreamerVideoCaptureSource):
- platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h:
- platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::createSource):
(WebCore::GStreamerVideoCapturer::setSize):
(WebCore::GStreamerVideoCapturer::setFrameRate):
- platform/mediastream/gstreamer/GStreamerVideoCapturer.h:
Canonical link: https://commits.webkit.org/250094@main
- 2:53 PM WebKitGTK/2.36.x edited by
- (diff)
- 2:42 PM Changeset in webkit [294582] by
-
- 2 edits in trunk/Tools/CISupport/ews-build
[Merge-Queue] Validate reviewers in commit message
https://bugs.webkit.org/show_bug.cgi?id=240718
<rdar://problem/93665771>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/steps.py:
(ValidateCommitMessage):
(ValidateCommitMessage.init):
(ValidateCommitMessage.extract_reviewers): Extract reviewers from commit message.
(ValidateCommitMessage.is_reviewer): Check if a contributor is a reviewer.
(ValidateCommitMessage.run): Check if extracted reviewers are reviewers.
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/250818@main
- 2:41 PM Changeset in webkit [294581] by
-
- 1 edit in trunk/Source/cmake/OptionsWPE.cmake
Unreviewed. [WPE] Bump version numbers
- Source/cmake/OptionsWPE.cmake: Update version numbers for the next release series.
Canonical link: https://commits.webkit.org/250818@main
- 2:33 PM Changeset in webkit [294580] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations
[Gardening]: REGRESSION (r294536): [ macOS Release wk2 ] Twelve webgl/2.0.0/conformance2/textures/image_bitmap_from_image_bitmap/tex are a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240735
<rdar://93678287>
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250817@main
- 2:21 PM Changeset in webkit [294579] by
-
- 3 edits in trunk/Source
[web-animations] provide a dedicated flag for KeyframeEffect.iterationComposite
https://bugs.webkit.org/show_bug.cgi?id=240727
Patch by Antoine Quint <Antoine Quint> on 2022-05-20
Reviewed by Dean Jackson.
Add a dedicated flag for the
KeyframeEffect.iterationCompositeproperty as
that property did not make it to Web Animations 1.0 and should not be enabled
together withKeyframeEffect.composite.
- Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
- Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::create):
- Source/WebCore/animation/KeyframeEffect.idl:
Canonical link: https://commits.webkit.org/250816@main
- 2:13 PM Changeset in webkit [294578] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove redundant text-indent tests already covered by WPT
https://bugs.webkit.org/show_bug.cgi?id=240730
Patch by Kiet Ho <Kiet Ho> on 2022-05-20
Reviewed by Simon Fraser.
getComputedStyle-text-indent.html is covered by the following WPT tests:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-indent-computed.html
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-indent-invalid.html
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-indent-valid.html
getComputedStyle-text-indent-inherited.html is covered by the WPT test
LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance.html
They are also obsolete, since they still use the prefixed keywords '-webkit-each-line' and
'-webkit-hanging', while WebKit has supported the non-prefixed keywords since
https://bugs.webkit.org/show_bug.cgi?id=223851. They were also marked as skipped since a long
time ago. Therefore there's no reason not to remove them.
- LayoutTests/TestExpectations:
- LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt: Removed.
- LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited-expected.txt: Removed.
- LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html: Removed.
- LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html: Removed.
Canonical link: https://commits.webkit.org/250815@main
- 2:12 PM Changeset in webkit [294577] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/JavaScriptCore
Merge r292269 - AI should do int32 optimization in ValueRep
https://bugs.webkit.org/show_bug.cgi?id=238699
Reviewed by Saam Barati.
When constant folding an int52 into a ValueRep AI doesn't
do our normal int32 boxing optimization. I'm not sure if
it matters since I couldn't find a test but it probably
doesn't hurt.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- 2:12 PM Changeset in webkit [294576] by
-
- 301 edits8 adds4 deletes in releases/WebKitGTK/webkit-2.36/Source/ThirdParty/ANGLE
Merge r291757 - Roll ANGLE to 2022-03-22 (e7f29440f02514126f30350dcd7132b68f7954d7)
https://bugs.webkit.org/show_bug.cgi?id=238171
Large autogenerated ChangeLog elided.
Tested locally with Minibrowser on M1, with test cases from the
following recent bugs:
https://bugs.webkit.org/show_bug.cgi?id=237006
https://bugs.webkit.org/show_bug.cgi?id=237906
https://bugs.webkit.org/show_bug.cgi?id=238022
and confirmed all render correctly.
Patch by Kenneth Russell <kbr@chromium.org> on 2022-03-23
Reviewed by Kimmo Kinnunen.
- 2:10 PM Changeset in webkit [294575] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/ThirdParty/ANGLE
Merge r290987 - ANGLE display cache does not work with explicit device ids
https://bugs.webkit.org/show_bug.cgi?id=237522
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-03-08
Reviewed by Kenneth Russell.
Add EGL_PLATFORM_ANGLE_DEVICE_ID_HIGH_ANGLE, EGL_PLATFORM_ANGLE_DEVICE_ID_LOW_ANGLE
to the display cache key, so that a request for a display with an explicit device does
not get resolved with a display without explicit device or with a display with another
explicit device.
WebKit tests will be added once this will be used.
ANGLE tests will be added once upstreamed.
- src/libANGLE/Display.cpp:
(egl::Display::GetDisplayFromNativeDisplay):
(egl::Display::~Display):
- 2:09 PM Changeset in webkit [294574] by
-
- 487 edits1 copy3 moves17 adds18 deletes in releases/WebKitGTK/webkit-2.36/Source/ThirdParty/ANGLE
Merge r290479 - Roll ANGLE to Feb 18 2022 (78c64dd74ee5)
https://bugs.webkit.org/show_bug.cgi?id=235746
Reviewed by Dean Jackson.
The changelog has been rewritten to avoid
confusion. The following commits are integrated in this
roll:
78c64dd74 Roll SwiftShader from 13f7365e81be to b4a56a893496 (11 revisions)
00c4dc93a Python3: Update generate_test_spec_json.py
d98f4812c FrameCapture: Capture empty buffer generation.
7a4fd4212 Roll Chromium from d984ec3b132a to 6594a8d1e6cf (1749 revisions)
b1bdce5f2 Roll VK-GL-CTS from 834c2e16ae1c to d321c7ec84de (7 revisions)
f996d4d87 Vulkan: Fix DynamicBuffer cache reuse.
8dc9e83e3 Translator: Fix RunAtTheEndOfShader w.r.t discard
00169174c gl.xml: Remove GL_BLEND_EQUATION_EXT from GetPName.
8ade4c2f7 Vulkan: Add overlay and stats for descriptor set caches.
671fcf732 Vulkan: Add a feature to retain SPIR-V debug info
1315bc816 Vulkan: Refactor DynamicBuffer::allocate.
8d966f7dd Vulkan: Simplify SubAllocation data types.
57b8b9332 Roll vulkan-deps from 9fb91023eb58 to 4d9fe6bf1f0c (8 revisions)
ae9c94f1b Add instructions to build RenderDoc for Android on Windows
38723c28c Vulkan: Allocate space for default attrib only if it is enabled
ad462491f Refine suppression for GLSLTest.SwizzledChainedAssignIncrement.
8cb586671 Vulkan: Add uniform descriptor set caching test.
bfbe86613 Fix UpdateChromeANGLE on mac for debug angle
a0d558f09 Vulkan: Fix D/S invalidation for MSAA EGL configs
3b8910625 Roll Chromium DEPS manually.
fb6303a15 Update docs for checkout with 'fetch' tool.
afacf7f99 Roll vulkan-deps from 956ca5369840 to 9fb91023eb58 (10 revisions)
2893effa4 validationESEXT: Implement ValidateGetCompressedTexImageANGLE.
b1075951d vk_helpers: Adjust CopyImageToBuffer extent to block size.
d77f64b35 Roll SwiftShader from 5f1c00bda1c1 to 13f7365e81be (5 revisions)
bdedf146d TextureVk: Implement getCompressedTexImage.
5f3f13f69 Vulkan: Invalidate D/S for multisampled EGL configs too
eeddb0504 Metal: Incorrect parenthization for assignment expressions
ed39d49a2 Metal: Fix Hang in WebGL CTS Occlusionquery_strict test
760253ce2 Vulkan: replace uniforms FastIntegerMap with FastUnorderedMap
931863370 Vulkan: Check Serial is valid in SyncHelperNativeFence
904a47975 Python3 upgrades
c590a1aa9 Roll VK-GL-CTS from 2d1377ec02b5 to 834c2e16ae1c (1 revision)
3adace153 Don't expose detailed driver version info to webGL
255fec892 Remove reference to policy_testserver.py
e2f8ff32c Tests: Add State of Survival trace
a5badc3ef [infra] Update active lucicfg experiments.
cf4b50c5b Vulkan: Retain images before changeLayoutAndQueue
3b8b1f709 Roll SwiftShader from cbd31d271e4c to 5f1c00bda1c1 (12 revisions)
f3b6af597 Roll vulkan-deps from 3a6f074dbd38 to 956ca5369840 (55 revisions)
ad4fae642 Roll Chromium from c9825531290b to d984ec3b132a (580 revisions)
e50455877 Debug Overlay Demo
527ceb73c Vulkan: Switch XFB counter buffer to suballocation
a0bc9dab4 Vulkan: Switch stencilBlitResolveNoShaderExport to suballocation
d36df8d73 Unicode support for system_utils on Windows
54d428dd5 Tests: Add MARVEL Strike Force trace
1e29ba626 Vulkan: Enable overlay by default with debug layers
19f405318 Vulkan: Enable subgroup feature in GenerateMipmap.comp
2efbfd058 Roll VK-GL-CTS from 071bfca11aa9 to 2d1377ec02b5 (11 revisions)
c6f5a5bbe Roll Chromium from c0b2804cbd93 to c9825531290b (658 revisions)
06edae72b Vulkan: Allow duplicated block name in different shader interface
6cced91b3 FrameCapture: Remove destroyed contexts from share group
f7f269560 Vulkan: Fix two bugs exposed by moving mEmptyBuffer to suballocation
9b7a77b08 Double batch timeout for sanitizer tests.
4b45576d4 Keep ANGLE_base_vertex_base_instance available for ES 2.0
d285d6a72 Vulkan: Use VK_EXT_depth_clip_control
3f0a28ba6 Add entry points for EGL_KHR_partial_update
3b4548bb6 Traces: Add restricted_trace_perf.py script for Android
a3c785fc1 GL: Remove avoid_dxt1_srgb_texture_format feature
fd378ce5a Rebind program on glUseProgramStages
3a72994ea Vulkan: Add an end2end test
0a320d16f GetImageTest: Enable on Vulkan SwiftShader.
568724918 Roll Chromium from bf99b2cc0f6b to c0b2804cbd93 (526 revisions)
d5df23318 Vulkan: Disable EGLContextSharingTestNoSyncTextureUploads on Pixel6
038adcae4 Vulkan: Render the overlay in the graphics pipeline
b39add311 Roll VK-GL-CTS from b594e2aabae9 to 071bfca11aa9 (1 revision)
419bca3f5 Vulkan: Use Vulkan API directly for BufferPool's buffer allocation
6fd2588df Update GL_MAX_CLIP_DISTANCES_EXT validation
734365a71 Vulkan: improve command buffer reset performance
118ce6aae Support to open d3d12 shared handles
a0e3a5fb9 Roll SwiftShader from 0915ab4bddf7 to cbd31d271e4c (3 revisions)
f63d5f1c1 Revert "Don't build dEQP tests on MSVC temporarily"
4b6a5a84b Roll Chromium from 60719c9cd084 to bf99b2cc0f6b (543 revisions)
670a6e476 Ignore invalid texture type error
91f92540c Metal: Fix multisample resolves.
823522375 Vulkan: Fix incorrect DescriptorSet's bufferInfo in XFB emulation path
37f59b850 Roll VK-GL-CTS from 97ceb2222747 to b594e2aabae9 (64 revisions)
02ce52d26 Test: Add Lords Mobile trace
33d17b7fc Fix perf test runner script.
4349904b0 Add keying on backend to ANGLE Display caching.
9cfd87244 Allow surface creation in DisplayVkNull
a91d56033 Roll SwiftShader from e576ca6011cd to 0915ab4bddf7 (6 revisions)
4716e0fe8 Roll Chromium from 817a527fde8c to 60719c9cd084 (571 revisions)
71d06198c Vulkan: Fix vkCmdClearAttachments vs multiview
1b9774f57 Vulkan: Force submit updates to immutable textures
a39618436 Vulkan: Bind aligned default uniform buffer size.
6207fe88d Vulkan: Minor cleanup to DynamicDescriptorPool.
5b43a30e3 Overlay: Rearrange the font image
70c510eb2 Vulkan: Use common storage for descriptor set descs.
50fb842d5 Expand SwiftShader Win/ASAN suppression.
520458769 Vulkan: StreamVertexDataWithDivisor write beyond buffer boundary
d635feb11 [fuchsia] Tests using additional_manifest_fragments are CFv1.
8622810c4 Roll SwiftShader from ad6d7f84f2a1 to e576ca6011cd (19 revisions)
d066f9a34 Roll Chromium from 26dacbf4b527 to 817a527fde8c (500 revisions)
2df2a9ec2 Add instructions to enable Debug Overlay On Android
236a3d0f0 Tests: Add Dead Trigger 2 trace
1acfe6597 Test: Add Last Shelter: Survival trace
8b81742dd Vulkan: Move shader resources descriptor set update.
02ad19e36 Vulkan: Fix vkCmdResolveImage offsets
d9fcebb8a Vulkan: Make framebuffer fetch syncval errors more specific
939da2945 Tests: Add Magic Rush: Heroes trace
9208dcc65 Revert "Vulkan: Enable framebuffer fetch on SwiftShader"
44deda4c2 Tests: Add Dragon Mania Legends trace
959d4be5f Vulkan: Remove buffer get method from descriptors desc.
b2006a222 Roll SwiftShader from 2b76a13c38ae to ad6d7f84f2a1 (1 revision)
06150ab2f Roll Chromium from 55ed02951fa2 to 26dacbf4b527 (583 revisions)
f65e7c3ca Vulkan: Take base level into account in image views
6d30de10d Metal: Fix ANGLEUniformBlock alignment
ac20272f6 Vulkan: Fix present region rectangles
2eeb87488 Vulkan: Enable framebuffer fetch on SwiftShader
2ab8f48fe Allow glCopyTexImage2D from BGRX and RGBX to GL_LUMINANCE
c48e35b94 Add more info in BlitFramebuffer error message
2b00f4f5a Fix bug in protected content validation
706f8a311 Support gl internal format for creating EGLImage from VkImage
da87b1dbc Fix GLES Display creation on ChromeOS when Vulkan is enabled
7820ca23e Vulkan: Binding available buffer range to descriptor.
8710d7fe2 Roll SwiftShader from 6014f10de554 to 2b76a13c38ae (3 revisions)
0aca45c1f Roll Chromium from 8894f7c632dd to 55ed02951fa2 (509 revisions)
1608a9567 Vulkan: Revert client vertex data streaming to use DynamicBuffer
9e3232998 FrameCapture: Regen framebuffers on Reset
e897bf9ae Remove gl_PerVertex-related suppression
3dbba51df Reland "Vulkan: Enable ANGLE_texture_multisample"
83a3f654a Revert "Suppress GLSLTest.FramebufferFetch... on Pixel6 / Vk / Glslang"
4ac0f1436 Vulkan: Fix gl_LastFragData transformation
f1159253d Expand suppression of Mimap tests to any Win/Swiftshader config.
e56f0e293 Vulkan: Check program fetch status when switching framebuffers
600ffa6ec Suppress GLSLTest.FramebufferFetch... on Pixel6 / Vk / Glslang
4a65040b6 Add new Vulkan uniform update test.
464396c7b Roll vulkan-deps from fe093f4789c2 to 3a6f074dbd38 (8 revisions)
4c9f4519b Roll SwiftShader from 4998c7b3a2b8 to 6014f10de554 (6 revisions)
6e7a7a03e Roll Chromium from a210f891a450 to 8894f7c632dd (1053 revisions)
b756b2c27 Suppress flaky Mipmap/Multithreading tests on Win/SwS/ASAN
812d5fffa Metal: End the current render pass at glInvalidateFramebuffer.
7d7cca47f Vulkan: Update default FBO when fetch in use
25120c560 Mac: Try to diagnose crashes inside Core Animation.
139f4bd46 Revert "Vulkan: Enable ANGLE_texture_multisample"
494887100 Metal: Remove emulatedInstanceID
57933493d Roll vulkan-deps from 9ee740d2e9ef to fe093f4789c2 (5 revisions)
72529c197 Vulkan: Fix a few framebuffer fetch bugs
fe56532f5 Vulkan: Enable ANGLE_texture_multisample
bc3be5a83 Vulkan: Add a dedicated suballocation garbage list
be2da2343 Vulkan: Initialize exectuable with invalid uniform serial.
33427a4b3 Vulkan: Fix vkCmdResolveImage extents
293c0b516 Vulkan: Cache commonly used 6 ushorts stream index array data
38fada351 Vulkan: Add support for OES_primitive_bounding_box
91b383e82 Translator: Emit warning when identifier has double underscores
945a09d10 Vulkan: Fix off-by-one in DynamicBuffer.
d6fb76a68 [fuchsia] Don't try to use calling executable path to load .so's
868c0739f Vulkan: Fix image base/max level respecification case.
0a6c4310e Vulkan: Fix incorrect gl_SamplePosition on ES3.2
693b48a07 Roll SwiftShader from 4db20a80409b to 4998c7b3a2b8 (1 revision)
d1b1ef9af Roll vulkan-deps from 69f4b9c09e48 to 9ee740d2e9ef (3 revisions)
3c727e44e Allow GL_RGBX8_ANGLE for texture copy destination
069269540 Roll Chromium from 97a33ab1a078 to a210f891a450 (477 revisions)
f810e9989 Use a temporary timeout multipler for trace tests.
508a8a027 Remove old spellings for SYNC-HAZARD-WRITE_AFTER_READ skips
2d3ce72d1 Refactor shared library load to avoid allocations.
665ddccd8 Vulkan: Emulate dithering
29d087df4 Fix ANGLE_rgbx_internal_format's extension file name
471f18521 D3D11: Fix underflow with computing small strides.
84470eb3d Roll SwiftShader from 518c5780ac4f to 4db20a80409b (3 revisions)
b934fad92 Roll Chromium from 4d71de73b37d to 97a33ab1a078 (625 revisions)
a4a4fec8b Roll vulkan-deps from f703f3cc0975 to 69f4b9c09e48 (10 revisions)
69263b388 Roll vulkan-deps from 746e518a0b0e to f703f3cc0975 (1 revision)
55ef2b4f7 Update one more SYNC-HAZARD-WRITE_AFTER_READ skip
168e0ae50 Vulkan: Refactor descriptor pool code.
a994ea994 Update SYNC-HAZARD-WRITE_AFTER_READ skip
e03f17535 EGL: mutable_render_buffer deferredFlush fix
e27bb3972 Roll vulkan-deps from a19b5047ffca to 746e518a0b0e (5 revisions)
8a1f8af4d Turn on the Vulkan backend on ChromeOS
9bf5716c8 Tests: Add War Planet Online trace.
287057b3b FrameCapture: Don't track coherent buffers before capture starts.
42c8b29d0 Tests: Add Dead By Daylight trace.
46b420f66 Roll SwiftShader from bca23447ad46 to 518c5780ac4f (7 revisions)
078f7ea06 Roll Chromium from 8ff0cb4f71d8 to 4d71de73b37d (550 revisions)
c4a9d4169 Metal: Refactor to build without SPIR-V
701d51b10 Vulkan: Add SmallBufferPool for small allocations
66e01ae5a Expand error message on BindTexture validation failure
706e44b06 Tests: Add PUBG Mobile launch trace
df19e35a0 Vulkan: Use queue for mGarbageQueue
4e644b330 Vulkan: Remove ProgramExecutableVk back-pointers.
b3ed47809 Change Windows display initialization from ANSI to wide version
602b957b8 Enable robustnessEXT for SwiftShader.
8b966cfc5 Roll vulkan-deps from ae6a4b829252 to a19b5047ffca (9 revisions)
322d118fc Roll SwiftShader from 711968667748 to bca23447ad46 (4 revisions)
47d63b4e3 Roll Chromium from 7b890e4b915b to 8ff0cb4f71d8 (485 revisions)
2ad5f350c Vulkan: Fix texture array level redefinition
45237a047 Metal: Fix undefined behavior of depth write
aadc64343 Vulkan: Fix to correctly redefine gl_PerVertex in GS
25e8f02b0 [infra] Use python3 for run_presubmit recipe.
a79708899 Vulkan: Use queue instead of vector for mSharedGarbageList
39f66a9c1 Vulkan: Support different SCBs for outside and inside RP
cb96c236a Revert "Vulkan: Enable framebuffer fetch on SwiftShader."
7c1346bdc Vulkan: Consolidate uniforms code in ProgramExecutableVk.
b2d55742b Program: Add generic uniform update methods.
374e0c439 ProgramPipeline: Remove mHas members.
0dc0dc2a4 Re-land: "Vulkan: Remove "fillProgramStateMap"."
510723193 Vulkan: Enable framebuffer fetch on SwiftShader.
1316d1534 Roll vulkan-deps from 4ec99dddf407 to ae6a4b829252 (11 revisions)
f44159cdb Roll SwiftShader from 366db5aedd90 to 711968667748 (8 revisions)
83ca1fbc5 Roll Chromium from 94c8695167c4 to 7b890e4b915b (100 revisions)
54f8a8f71 Roll Chromium from 35ed79e6a83b to 94c8695167c4 (935 revisions)
aaac31b48 Unskip dEQP.GLES3/functional_shaders_operator_unary_operator_minus_*
c5498b957 FrameCapture: Reset immutable buffers correctly.
8474c8e1c FrameCapture: Add Renderbuffers to mStartingResources.
5f0badf45 Vulkan: Prevent out of bounds read in divisor emulation path.
526c93ddf FrameCapture: Detect GL_MAP_COHERENT_BIT_EXT correctly.
f5dc2a951 Roll vulkan-deps from 238eaa6f9d25 to 4ec99dddf407 (7 revisions)
8fc4d3b1e Roll SwiftShader from e823eef17385 to 366db5aedd90 (2 revisions)
d7585c22a Capture/Replay: don't capture MS depth renderbuffer pixels
d6dd0cb52 EGL: EGL_KHR_lock_surface3 backend
6a14e328b Revert "Vulkan: Remove "fillProgramStateMap"."
bd87cc1ca Skip flaky CopyTextureTest.CopyOutsideMipmap
c7f31b8ae Expand TransformFeedbackTest.SpanMultipleRenderPasses suppression
296783294 Vulkan: Fix advertised precision ranges
38deffe40 Vulkan: Remove "fillProgramStateMap".
540b2e46a Fix MultithreadingTestES3.MultithreadFenceDraw skip on SwiftShader
73c823108 Update the Capture and Replay docs
85e2991f2 Fix couple LSAN detected leaks in unit and end2end tests
adb802383 On invalidate, only sync the relevant framebuffer binding
a20cd8b73 Fix initialization for ETC2 punchthrough alpha formats
cac4e54a6 Mark GL_RGBX8_ANGLE format as filterable.
64c49da36 Roll Chromium from b7f974a39665 to 35ed79e6a83b (570 revisions)
096c268bd Add a few overrides for Samsung
339a6d181 Roll vulkan-deps from c9b583de6eb8 to 238eaa6f9d25 (8 revisions)
0f00fbae2 Translator: Make vec/matrix size getters unsigned
ca3b28b4b Metal: Fix compressed texture initialization and add DXT1 test
4a5a559d6 Update Metal/iOS status from "planned" to "in progress".
a0fbcb375 Vulkan: Remove flush from SyncHelperNativeFence::serverWait
038d28772 Roll VK-GL-CTS from bfede065f419 to 97ceb2222747 (3 revisions)
29e254689 Account for EGL 1.5 version when dealing with robustness
78d482e56 Add standalone ANGLE Pixel 6 experimental bots
a5e22715e Vulkan: Fixed TC shader and gl_PerVertex block interaction
a64d52fd2 Add ANGLE_FORMAT_PRINTF() for catching format errors
31bb03fe2 Add more tests for program pipelines.
e6ed6977c Roll SwiftShader from 2e74d5dc03df to e823eef17385 (4 revisions)
a4b312c01 Roll vulkan-deps from 70b3eb7a5ab4 to c9b583de6eb8 (1 revision)
515f60bd6 FrameCapture: Keep MEC Setup resources in Reset.
034b50587 Roll Chromium from d5bf6f7f9376 to b7f974a39665 (478 revisions)
1ab6c9f69 Hide ES 3.0+ extensions from ES 2.0 clients
2caa9d4fe Vulkan: Add missing glGetProgramPipelineiv parameters handling
d23549689 Vulkan: Rename BufferHelper::initFor* to allocateFor*
a83f7e91c Vulkan: inline some of the BufferSuballocation APIs
1b5efe51a Vulkan: Rename SubAllocation to Suballocation
659725aaa Metal: Cleanup texture caps init
3064920a9 Capture/Replay: Serialize ActiveTexturesCache.
161643215 Roll vulkan-deps from d1b842fca80d to 70b3eb7a5ab4 (4 revisions)
7ff95f28d Roll Chromium from b24759852b71 to d5bf6f7f9376 (533 revisions)
1bd1a3db1 Metal: Canvas resizing causes webpage to run out of memory
15439f8e4 Vulkan: Remove BufferMemoryAllocator
dcac02ac1 Revert "Enable robustnessEXT for SwiftShader."
ef3fffd6f Fix running tests with empty test set.
e5c9b3859 Add object label in glBindTexture() error message
b53607981 Vulkan: Support fetching from default FBO
ff5368cd2 Mark a context as shared if using global textures/semaphores
fc6b747df EGL: Fallback to native device if no display available
55d127703 Metal: Cleanup autogenerated format table
cb7ff65c1 Roll SwiftShader from f6bdbed95b37 to 2e74d5dc03df (7 revisions)
eda5aa0be Roll vulkan-deps from 4cda77455291 to d1b842fca80d (6 revisions)
17f912bd6 Roll Chromium from 8cf5fa683fa3 to b24759852b71 (537 revisions)
00a2a2f3e Merge metal format table updates from Webkit
af8dd1c38 Update documentation link
f071aaaf3 Use first test name instead of shard index for TestArtifacts
7dda50fc0 Add frontend for ANDROID_extension_pack_es31a
28f223acb Vulkan: Add missing ESSL 3.2 builtin functions
400175d8e Copy shader buffers into pipeline executables.
892511fc3 Isolate LinkValidateProgramInterfaceBlocks.
fdadc420a Fix non-bot mode sharding on Android and disable elsewhere.
fa3241b70 Vulkan: Move shader_framebuffer_fetch to FeaturesVk
9012c1288 Add Microsoft vendor Id parsing to SystemInfo
453cd955a Add EGL_ANGLE_platform_angle_display_id to D3D11 backend.
a1858b024 Tests: Add Respawnables trace.
b803b60df Enable robustnessEXT for SwiftShader.
31942507f Fix export_targets Windows presubmit with Vulkan Loader.
8eafe4912 Roll SwiftShader from d7117384b0ee to f6bdbed95b37 (1 revision)
c31e14d9c Roll vulkan-deps from d891854a594a to 4cda77455291 (30 revisions)
4572a1764 Add support for GL_MESA_framebuffer_flip_y 3/*
a76550078 Roll Chromium from 86a4c63b080e to 8cf5fa683fa3 (329 revisions)
9b231f090 Vulkan: Fix incorrect bit test when mipmapping
158ecba6a Vulkan: Remove cached Impl pointers from ContextVk.
5adee9161 Wrap some global vulkan methods which depend on env variables
652e3db46 use vpython3 in run_gtest_angle_test.py
770c81b91 Roll SwiftShader from cd848cd695a4 to d7117384b0ee (2 revisions)
9cfb4dd91 Roll Chromium from c00f3886d7aa to 86a4c63b080e (890 revisions)
0aae0d7ad Update PrintSystemInfo with missing fields.
6601b8d2e Vulkan: Fix storage buffer limits on geom/tess without Vulkan support
c4c73e827 Fix RobustBufferAccessBehaviourTest.
30254d349 Ignore VUID-RuntimeSpirv-NonWritable-06341 warning
158d47831 Vulkan: Suppress VVL message about allocation exceeding heap size
28f05f41e Capture/Replay: Add annotation for crashing test
6e2ab29d1 Avoid data race in overflow check.
4f3a50e55 Roll Chromium from 3fcf884156d8 to c00f3886d7aa (595 revisions)
6312da1ab Vulkan: Disable GL_KHR_parallel_shader_compile
9f3c306ec Fix collection of systemDeviceId on Mac/M1
9b1a6d8a4 Vulkan: Invalidate depth/stencil unconditionally
bd64b3eaa Move pipeline uniforms into the executable.
985db6409 Fix test harness config parsing in Compressed Tex tests.
f4b0a95f4 Metal: Implement EXT_shader_texture_lod
814a78af5 Roll Chromium from 3668290e6162 to 3fcf884156d8 (108 revisions)
d4412d0a0 Roll Chromium from 3d4921afbcfd to 3668290e6162 (378 revisions)
2f4f5f8aa Add EGL_ANGLE_platform_angle_device_id for the Metal backend.
0ab15998c Translator: Don't promote precision for assignment operation lvalues
cd157aae5 Revert "Use STL container for vulkan memory allocator"
89467fa56 Roll Chromium from 597c376626be to 3d4921afbcfd (999 revisions)
d4c8209b3 Fix validation of copyImageSubData related to texture completeness
4a819ee26 Update code generation script to work with specified generators
96fd9b72d Fix validation of glCompressedTexImage3D
926b43e75 Reland: Frontend: separate lock in swap prep
2d1051778 Enable a few features for Samsung
345cdcb0f Rename features for consistency.
b0e15ee48 Decide GL_KHR_parallel_shader_compile in backends
a026d0536 Add support for subgroupSize of 16 in Debug Overlay Module
f180ecc96 Supress TransformFeedbackPausedDrawThenResume on Mac AMD
5ec02c8f4 Roll SwiftShader from b57a3aaee927 to cd848cd695a4 (1 revision)
7f8e7c38e Roll vulkan-deps from 328da0f26e8e to d891854a594a (9 revisions)
0b02a592f Metal: Generated Metal shaders do not compile offline
6a2558333 Metal: Fix transform feedback issue
37cde9e99 Update GLES31 expectations file
e38dab0aa Add missing implementation for glGetnUniformuiv()
74e03b9af Expose the registryID of GPUs on Mac via SystemInfo
9d11a341c Vulkan: Fix Vulkan SCB vs multiple subpasses
b90bcb9c8 Roll vulkan-deps from 57e7495dc76d to 328da0f26e8e (4 revisions)
9f1dc3e99 Roll Chromium from b91f3880e3ec to 597c376626be (567 revisions)
acd8fc76b Vulkan: Distinguish RP and outside-RP command buffer types
eea784687 Tests: Add Angry Birds 2 launch trace
095d7c0a0 Translator: Clean up spec const / driver uniform types
5c9bd7bac Update Mac goldctl
4111f9ef1 Add standalone ANGLE Mac AMD experimental bot
9d042d686 Cleanup after iOS build fixes
99b021a15 infra: Add TSAN and UBSAN tests to CQ.
b0feea4e4 Suppress failing test on Vulkan/Intel/Linux.
60a8b5930 Vulkan: Remove std::unique_ptr usage from BufferVk::mBuffer
217dc204e Broaden TSAN EGL multithread suppression.
ae1a56b67 Vulkan: Turn on GL_EXT_shader_framebuffer_fetch for ARM
9d668d6c4 Revert "Frontend: separate lock in swap prep"
b2dac79d9 Fix typo in EGLPrintInfo end2end Test
462cdb08e Capture/Replay: Reset FBOs, RBOs, VAOs
4472b3b0d Fix TSAN suppressions.
40c5cb255 Frontend: separate lock in swap prep
c2a296149 Test Expectations: Use file order as override priority.
ece463808 tests/EGLProtectedContentTest: Add QueryContext test.
1e2856fdc Update freetype-py wheel
a203e1263 Roll SwiftShader from 0b901607cad4 to b57a3aaee927 (1 revision)
8ab13284a Roll vulkan-deps from 09edcd7c680b to 57e7495dc76d (27 revisions)
6f80fa0c3 Roll Chromium from 8712e27d7e28 to b91f3880e3ec (349 revisions)
2ebdd23b6 Cleanup TextureCubeTestES3.CubeMapPixelUnpackBuffer
caf6433ad Vulkan: Rename releaseStagingBuffer to releaseStagedUpdate
93159c020 Vulkan: Remove DynamicShadowBuffer implementation
cf3812921 Revert "Re-skip MSRTT tests on Linux/AMD/Vulkan"
3263eb01f Vulkan: Switch GPU translated vertex buffer to NonHostVisible
8589c456a Vulkan: Remove mStagingBuffer from ImageHelper and ContextVk
6da1ac814 Vulkan: Switch ReadPixels from DynamicBuffer to shared pool
ad27d5d6f Reland "Vulkan: Consolidate all vertex conversion buffers to shared pool"
535a90347 Suppress headers includes privacy checks for iOS executables
a61a7f597 Vulkan: Use correct aspectMask
4e85bdd99 Revert "Vulkan: Consolidate all vertex conversion buffers to shared pool"
cca412cd8 Vulkan: Consolidate all vertex conversion buffers to shared pool
02f6226b7 Avoid using GetCWD() on MacOS when possible
a0d0a1d65 Roll SwiftShader from c73969d73ff9 to 0b901607cad4 (6 revisions)
e98b62727 Roll Chromium from b1dc46c0f1be to 8712e27d7e28 (483 revisions)
fd0142714 Vulkan: Match chromaFilter to min/mag for YUV AHBs
ccabfd140 out\Debug -> out/Debug, like in other places
abf17f018 Metal: Support depth filtering queries for D32, D24S8
f13f440e6 Reland: Metal: Fix Webkit warnings in ANGLE build
39e1a2b2e Suppress Vulkan/SwiftShader/AsyncQueue ASAN flakes.
7126c3a3c Capture/Replay: Limit caps for QC/SwS
0e49a3dd4 Vulkan: Add std::move support for BufferHelper
43b0e92b5 Vulkan: Consolidate mHostVisibleBufferPool and mMapInvalidate
42cb6147f Revert workarounds for exception handler code-gen with CFG enabled
e4c7efeaf Capture/Replay: Fix GN build on iOS.
cabc3b982 Move atomic counter uniform range counter to executable.
e9e9a2c6a Do not pass mInstance to vkGetInstanceProcAddr
beda24596 Add support for GL_MESA_framebuffer_flip_y 2/*
c984dad5f FrameCapture: Don't remove protection from shared pages.
d76515b89 Roll SwiftShader from 433b1bf9bff2 to c73969d73ff9 (4 revisions)
1b2cb4222 Roll Chromium from 1a9dad30c65b to b1dc46c0f1be (497 revisions)
cfc4db346 Metal: Provoking vertex support for Metal DrawArrays
a00b6ca46 Roll Chromium from 04d22dcbc0f6 to 1a9dad30c65b (190 revisions)
5bd459618 Roll Chromium from 70ce2f66c417 to 04d22dcbc0f6 (183 revisions)
aad7ddb28 Skip VulkanPerformanceCounterTest.InvalidateDrawDisable
0a6b78974 Add macOS support to update_chrome_angle.py
4b3e3ed5f Re-skip MSRTT tests on Linux/AMD/Vulkan
39810def0 Roll Chromium from c764378a1f24 to 70ce2f66c417 (145 revisions)
9aca4285f Traces: Fix path in retrace script.
0331738b4 Fix extension download script, and update data.
58aeec65c Capture/Replay: GN cleanups.
85de4f81e Capture/Replay: Fix TODO in test utils.
b6399ac94 Traces: Finish writing restricted trace doc updates.
fed9ba44f Roll vulkan-deps from c32df39c11ce to 09edcd7c680b (1 revision)
65cc408c3 Roll Chromium from e45e6e1a55ae to c764378a1f24 (157 revisions)
a400e76d0 Vulkan: Don't expose MSRTT without VK_KHR_depth_stencil_resolve
9f74ec615 Skip angle_end2end_tests failing on Linux AMD RX 5500 XT
b7d2f4478 Roll Chromium from d09758fa672c to e45e6e1a55ae (153 revisions)
6f1c39b52 Vulkan: Restore color attachment mask-related blend states
95f6e6865 Roll SwiftShader from 87c78ac5eb86 to 433b1bf9bff2 (2 revisions)
a026169c9 Roll Chromium from 0635acc4de22 to d09758fa672c (93 revisions)
0a28c6c61 Capture/Replay: Capture some MultiDrawIndirect parameters
5f53268ce Capture/Replay: Gather Program sources directly from call
a92036893 Roll Chromium from 52c4c43d687f to 0635acc4de22 (149 revisions)
fce481863 Roll SwiftShader from f354daff5a2b to 87c78ac5eb86 (2 revisions)
6c9b79ead Roll Chromium from 16dc16f9ec67 to 52c4c43d687f (244 revisions)
4d893a935 Re-land: "Trace Tests: Remove auto-generated code."
542f7d808 Vulkan: Copy buffer data to correct cube map face
582651bee Roll vulkan-deps from fbeca8f4ea6a to c32df39c11ce (3 revisions)
5e0d97877 Roll Chromium from 274ab850e849 to 16dc16f9ec67 (303 revisions)
2ebd583ed Android: Remove setenv from common path
14af7a8da Log subprocess output in run_perf_tests.py
2f3e6cc07 Vulkan: Remove mShadowBuffer from BufferVk class.
7dfa69e69 Unskip MRTSigned and MRTUnsigned BlendIntegerTest
993f38896 Roll Chromium from 9ca41364d3dc to 274ab850e849 (341 revisions)
0e9353f60 Skip RenderbufferDrawStencilThenUnresolveStencil on Linux Vulkan AMD
bc9d2d7de Vulkan: Consolidate BufferHelper's code paths into one
4114fe23c Vulkan: Simplify transform feedback emulation logic
32d9e186d Roll vulkan-deps from 5568048d205e to fbeca8f4ea6a (4 revisions)
ab288fea5 Upgrade restricted traces. (Re-land)
c1f478fe0 Frame Capture: Allow for no FBO when running MEC.
eba2e620f Capture/Replay: Fix uniform program indexing.
73e764dc6 Suppress capture/replay tests.
1da7e3afb Revert "Metal: Fix Webkit warnings in ANGLE build"
bdaa046fe Roll Chromium from 81decb7250e1 to 9ca41364d3dc (272 revisions)
a7e0d520f Temporarily skip failing tests on Chromium
171bc07e2 Don't silently drop out-of-range bits in BitSetT
eca427b28 Vulkan: Add mutex to protect mVirtualBlock
c1598640b Vulkan: Improve mid-RP clear warning message
4a03668d7 Address comment in CL 3347143
cf8ac00a5 Vulkan: Fix MSRTT w.r.t stencil-only unresolve
c07df6fe8 Disable vulkan device select layer for msan build
- 1:49 PM Changeset in webkit [294573] by
-
- 12 edits in trunk
[Modern Media Controls] macCatalyst should not use touch events
https://bugs.webkit.org/show_bug.cgi?id=240704
<rdar://problem/84570717>
Reviewed by Eric Carlson.
- Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js:
(LayoutTraits.prototype.supportsTouches): Added.
- Source/WebCore/Modules/modern-media-controls/controls/macos-layout-traits.js:
(MacOSLayoutTraits.prototype.supportsTouches): Added.
AllowLayoutTraitsto indicate whether touches are supported.
- Source/WebCore/Modules/modern-media-controls/controls/auto-hide-controller.js:
(AutoHideController):
- Source/WebCore/Modules/modern-media-controls/controls/button.js:
(Button):
- Source/WebCore/Modules/modern-media-controls/controls/range-button.js:
(RangeButton):
- Source/WebCore/Modules/modern-media-controls/controls/slider.js:
(Slider.prototype._interactionEndTarget):
- Source/WebCore/Modules/modern-media-controls/media/media-document-controller.js:
(MediaDocumentController):
UseLayoutTraits.prototype.supportsTouchesinstead ofGestureRecognizer.SupportsTouchesso that
macOS (including macCatalyst) can always act as though touches are not supported (which is fine
since mouse events are fully functional on macOS).
- LayoutTests/media/modern-media-controls/button/button-icon-name.html:
- LayoutTests/media/modern-media-controls/button/button.html:
- LayoutTests/media/modern-media-controls/buttons-container/buttons-container-buttons-property.html:
- LayoutTests/media/modern-media-controls/buttons-container/buttons-container-constructor.html:
- LayoutTests/media/modern-media-controls/buttons-container/buttons-container-layout.html:
Add
layoutDelegate/layoutTraitswhere needed.
Canonical link: https://commits.webkit.org/250814@main
- 1:43 PM Changeset in webkit [294572] by
-
- 5 edits in trunk/Source/WebCore/platform/graphics/displaylists
Change display list item logging to respect logging options
https://bugs.webkit.org/show_bug.cgi?id=240527
Reviewed by Myles Maxfield.
Split off from the patch in bug 240422.
We need to log display list items through a function that can take the flags
argument to avoid logging unstable resource identifiers in layout tests, so
implement dumpItem() for each item type, and respect the IncludesResourceIdentifiers
flag.
- platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::asText const):
(WebCore::DisplayList::DisplayList::dump const):
- platform/graphics/displaylists/DisplayList.h:
- platform/graphics/displaylists/DisplayListItemType.h:
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::dumpItem):
(WebCore::DisplayList::dumpItemHandle):
- platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::operator<<):
Canonical link: https://commits.webkit.org/250813@main
- 1:21 PM Changeset in webkit [294571] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
PROGRESSION (r294272): Correction to guard in Platform file caused multiple tests failures
https://bugs.webkit.org/show_bug.cgi?id=240579
<rdar://93504716>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250812@main
- 1:14 PM Changeset in webkit [294570] by
-
- 1 copy in tags/WebKit-7614.1.14.10.1
Tag WebKit-7614.1.14.10.1.
- 1:12 PM Changeset in webkit [294569] by
-
- 3 edits in branches/safari-7614.1.14.10-branch/Source/ThirdParty/ANGLE/Configurations
Cherry-pick r294525. rdar://problem/93580049
[ANGLE] Production builds don't need to include Metal debug info
https://bugs.webkit.org/show_bug.cgi?id=240696
<rdar://problem/93580049>
Reviewed by Tim Horton.
Metal debug info can be generated in engineering builds, but production builds don't need it.
- Source/ThirdParty/ANGLE/Configurations/AngleMetalLib.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig:
Canonical link: https://commits.webkit.org/250780@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:08 PM Changeset in webkit [294568] by
-
- 2 edits in trunk/Tools/Scripts
test262-runner should have basic Windows compatibility
https://bugs.webkit.org/show_bug.cgi?id=240698
Reviewed by Mark Lam.
test262-runner currently has a slew of incompabilities on Windows;
this patch rectifies enough of them to achieve basic usability.
In particular:
- When
useof a module triggers a fork() call, a crash occurs on Windows. Avoid by calling Runner::main() from outside. - This is a WebKit-specific file; use webkitdirs.pm without hesitation and determine jsc binary path using jscPath().
- Don't use
DYLD_FRAMEWORK_PATH=prefix on Windows. - Remove erroneous quotes from system call.
- Use File::Copy::copy instead of cp.
- abs_path() of a not-yet-created file is invalid on Windows. But it's also completely unnecessary, as $resultsDir is absolute.
- Manually flush progress meter on Windows (since \r without \n will never be flushed automatically).
Remaining limitation:
- If --child-processes value is too high, the runner will hang. Workaround is to provide a lower number.
- Tools/Scripts/test262-runner:
- Tools/Scripts/test262/Runner.pm:
(processCLI):
(main):
(getBuildPath):
(runTest):
(summarizeResults):
(printHTMLResults):
Canonical link: https://commits.webkit.org/250811@main
- 1:06 PM Changeset in webkit [294567] by
-
- 15 edits in branches/safari-7614.1.14.0-branch/Source
Cherry-pick r294536. rdar://problem/91660159
Drawing the PDF snapshot should take place in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=240368
rdar://91660159
Reviewed by Simon Fraser.
The ImageBufferBackends should act like a drawing surface only. It has
a GraphicsContext. It can get and set pixels. And it can get a NativeImage
out of the pixels. But it should never draw itself to a GraphicsContext.
The ImageBuffer can act like an image. It can draw itself as an image or
as a pattern into a GraphicsContext.
So draw(), drawPattern() and drawConsuming() will be removed from the
ImageBufferBackend super classes and the implementation will be unified
for all platforms and moved to ConcreteImageBuffer.
By doing that, a canvas can be drawn to the PDF context in WebProcess
even if the GPUProcess for DOM rendering is enabled.
Canonical link: https://commits.webkit.org/250791@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:06 PM Changeset in webkit [294566] by
-
- 1 edit4 adds in branches/safari-7614.1.14.0-branch
Cherry-pick r294530. rdar://problem/92984518
REGRESSION (r293126): Gmail formatting menu/panel in compose view becomes blank/empty while scrolling
https://bugs.webkit.org/show_bug.cgi?id=240625
<rdar://92984518>
Reviewed by Alan Bujtas.
Gmail uses the css
clipproperty with negative offsets, which is surprising, and revealed a bug in
the compositing code for clipping.
When a stacking-context layer has overflow:hidden or clip:, we assume that the clip encloses all the
descendants, so make a GraphicsLayer with masksToBounds as a parent of the child layers. When the
layer has border-radius with uneven corners, we implement that with a shape layer which acts as a
mask on that clipping GraphicsLayer.
The content in question had CSS clip with negative offsets and border-radius, so the shape layer
mask would clip out any content outside the border shape.
So if the clip rect extends beyond the border, we need to follow a different code path, which pushes
the clipping layers onto descendants; this code path is used for non-stacking context clipping, and
for mix-blend-mode which needs to avoid the creation of the intermediate clipping layer.
So generalize the
isolatesCompositedBlending()code path to also be used in the scenario of CSS
clip which extends outside the border box.
Tests: compositing/clipping/css-clip-and-border-radius.html
compositing/clipping/css-clip-non-stacking.html
- Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::canUseDescendantClippingLayer): (WebCore::RenderLayerCompositor::clippedByAncestor const): (WebCore::RenderLayerCompositor::computeAncestorClippingStack const): (WebCore::RenderLayerCompositor::clipsCompositingDescendants):
- LayoutTests/compositing/clipping/css-clip-and-border-radius-expected.html: Added.
- LayoutTests/compositing/clipping/css-clip-and-border-radius.html: Added.
- LayoutTests/compositing/clipping/css-clip-non-stacking-expected.html: Added.
- LayoutTests/compositing/clipping/css-clip-non-stacking.html: Added.
Canonical link: https://commits.webkit.org/250785@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:34 PM Changeset in webkit [294565] by
-
- 3 edits in trunk
AX: Update the isolated tree when aria-selected changes
https://bugs.webkit.org/show_bug.cgi?id=240703
Reviewed by Chris Fleizach.
Fixes accessibility/selected-state-changed-notifications.html in
isolated tree mode.
- Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::updateIsolatedTree):
- Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperty):
- LayoutTests/accessibility/selected-state-changed-notifications.html:
Canonical link: https://commits.webkit.org/250810@main
- 12:01 PM Changeset in webkit [294564] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
[ iOS ] accessibility/aria-modal-with-text-crash.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240722
<rdar://93669155>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250809@main
- 11:33 AM Changeset in webkit [294563] by
-
- 1 edit in trunk/Source/JavaScriptCore/b3/B3ReduceStrength.cpp
Refine B3ReduceStrength's range for sign extension operations.
https://bugs.webkit.org/show_bug.cgi?id=240720
<rdar://problem/93536782>
Reviewed by Yusuke Suzuki and Keith Miller.
- Source/JavaScriptCore/b3/B3ReduceStrength.cpp:
Canonical link: https://commits.webkit.org/250808@main
- 11:18 AM Changeset in webkit [294562] by
-
- 5 edits in trunk/Source/WebKit/NetworkProcess
Clear SessionStorage of a page when the page is destroyed
https://bugs.webkit.org/show_bug.cgi?id=240683
Reviewed by Chris Dumez.
We should not keep SessionStorage items in memory when they will not be accessed any more.
- Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::removeWebPageNetworkParameters):
- Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::clearStorageForWebPage):
- Source/WebKit/NetworkProcess/storage/NetworkStorageManager.h:
- Source/WebKit/NetworkProcess/storage/SessionStorageManager.cpp:
(WebKit::SessionStorageManager::removeNamespace):
- Source/WebKit/NetworkProcess/storage/SessionStorageManager.h:
Canonical link: https://commits.webkit.org/250807@main
- 11:15 AM Changeset in webkit [294561] by
-
- 9 edits in branches/safari-7614.1.14.10-branch/Source
Versioning.
WebKit-7614.1.14.10.1
- 10:46 AM Changeset in webkit [294560] by
-
- 1 copy in branches/safari-7614.1.14.10-branch
New branch.
- 10:33 AM Changeset in webkit [294559] by
-
- 2 edits in trunk/LayoutTests/accessibility/mac
Make accessibility/mac/aria-modal-auto-focus.html async so it can pass in isolated tree mode
https://bugs.webkit.org/show_bug.cgi?id=240676
Reviewed by Chris Fleizach.
- LayoutTests/accessibility/mac/aria-modal-auto-focus-expected.txt:
- LayoutTests/accessibility/mac/aria-modal-auto-focus.html:
Canonical link: https://commits.webkit.org/250806@main
- 10:26 AM Changeset in webkit [294558] by
-
- 3 edits in branches/safari-7614.1.14.0-branch/Source/ThirdParty/ANGLE/Configurations
Cherry-pick r294525. rdar://problem/93580049
[ANGLE] Production builds don't need to include Metal debug info
https://bugs.webkit.org/show_bug.cgi?id=240696
<rdar://problem/93580049>
Reviewed by Tim Horton.
Metal debug info can be generated in engineering builds, but production builds don't need it.
- Source/ThirdParty/ANGLE/Configurations/AngleMetalLib.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig:
Canonical link: https://commits.webkit.org/250780@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:22 AM Changeset in webkit [294557] by
-
- 9 edits in branches/safari-7614.1.14.0-branch/Source
Versioning.
WebKit-7614.1.14.0.8
- 10:20 AM Changeset in webkit [294556] by
-
- 3 edits in branches/safari-7614.1.14.3-branch/Source/ThirdParty/ANGLE/Configurations
Cherry-pick r294525. rdar://problem/93580049
[ANGLE] Production builds don't need to include Metal debug info
https://bugs.webkit.org/show_bug.cgi?id=240696
<rdar://problem/93580049>
Reviewed by Tim Horton.
Metal debug info can be generated in engineering builds, but production builds don't need it.
- Source/ThirdParty/ANGLE/Configurations/AngleMetalLib.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig:
Canonical link: https://commits.webkit.org/250780@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:15 AM Changeset in webkit [294555] by
-
- 9 edits in branches/safari-7614.1.14.3-branch/Source
Versioning.
WebKit-7614.1.14.3.3
- 10:15 AM Changeset in webkit [294554] by
-
- 3 edits in branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations
Cherry-pick r294525. rdar://problem/93580049
[ANGLE] Production builds don't need to include Metal debug info
https://bugs.webkit.org/show_bug.cgi?id=240696
<rdar://problem/93580049>
Reviewed by Tim Horton.
Metal debug info can be generated in engineering builds, but production builds don't need it.
- Source/ThirdParty/ANGLE/Configurations/AngleMetalLib.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig:
Canonical link: https://commits.webkit.org/250780@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:14 AM Changeset in webkit [294553] by
-
- 3 edits in branches/safari-7614.1.14.2-branch/Source/ThirdParty/ANGLE/Configurations
Cherry-pick r294525. rdar://problem/93580049
[ANGLE] Production builds don't need to include Metal debug info
https://bugs.webkit.org/show_bug.cgi?id=240696
<rdar://problem/93580049>
Reviewed by Tim Horton.
Metal debug info can be generated in engineering builds, but production builds don't need it.
- Source/ThirdParty/ANGLE/Configurations/AngleMetalLib.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig:
Canonical link: https://commits.webkit.org/250780@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:13 AM Changeset in webkit [294552] by
-
- 1 edit in trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
WebAccessibilityObjectWrapperMac::detachIsolatedObject should not unregister the wrapper for AccessibilityDetachmentType::ElementChanged detachments
https://bugs.webkit.org/show_bug.cgi?id=240628
Reviewed by Chris Fleizach.
Prior to this change, WebAccessibilityObjectWrapperMac::detachIsolatedObject unconditionally
called NSAccessibilityUnregisterUniqueIdForUIElement. This is the wrong
behavior for AccessibilityDetachmentType::ElementChanged detachments, as
this unregistering causes an element destroyed notification to be issued.
This type of detachment happens when we swap the underlying isolated
object for a wrapper as the result of a call to AXIsolatedTree::updateNode.
This unregistering caused VoiceOver focus flickering when modifying
sliders or textboxes, greatly hampering user experience.
No test included because there isn't a great way to test this.
- Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper detachIsolatedObject:]):
Canonical link: https://commits.webkit.org/250805@main
- 10:09 AM Changeset in webkit [294551] by
-
- 1 move in trunk/LayoutTests/platform/ios-wk2/fast/events/ios/rotation/layout-viewport-during-safari-type-rotation-expected.txt
[ REBASELINE ][ iOS ] fast/events/ios/rotation/layout-viewport-during-safari-type-rotation.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=231266
Unreviewed test gardening. Correct rebase for iOS.
- LayoutTests/platform/ios-wk2/fast/events/ios/rotation/layout-viewport-during-safari-type-rotation-expected.txt: Renamed from LayoutTests/platform/ios-wk2/fast/events/ios/rotation/layout-viewport-during-rotation-expected.txt.
Canonical link: https://commits.webkit.org/250804@main
- 10:07 AM Changeset in webkit [294550] by
-
- 36 edits4 deletes in trunk
Revert "Release assert in Document::updateLayout() via HTMLTextAreaElement::childrenChanged"
This reverts commit 0a91c415adf4e01ff05b2e98934802790e57f276.
Unreviewed revert
Canonical link: https://commits.webkit.org/250803@main
- 10:07 AM Changeset in webkit [294549] by
-
- 9 edits in branches/safari-7614.1.14.2-branch/Source
Versioning.
WebKit-7614.1.14.2.3
- 10:06 AM Changeset in webkit [294548] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.8
- 10:00 AM Changeset in webkit [294547] by
-
- 3 edits in trunk/Tools/WebKitTestRunner
After commit 039ebd9, some tests run with ITM disabled despite --accessibility-isolated-tree flag being passed
https://bugs.webkit.org/show_bug.cgi?id=240627
Reviewed by Chris Fleizach.
https://github.com/WebKit/WebKit/commit/039ebd9 changed TestController::resetStateToConsistentValues to only send the "Reset" message to the testing InjectedBundle after a test completed, rather than before and after each test. This is a good and logical change, but exposed a bug in how we set InjectedBundle::m_accessibilityIsolatedTree, since we relied on this "Reset" behavior to setup this member variable.
With this patch, we instead set InjectedBundle::m_accessibilityIsolatedTree in response to the "BeginTest" message, which fixes the issue.
- Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
- Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
- Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::createTestSettingsDictionary):
Canonical link: https://commits.webkit.org/250802@main
- 9:35 AM Changeset in webkit [294546] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
[Gardening]REGRESSION (r294317): [ iOS ] Thirteen layout tests are flaky or consistent timeouts
https://bugs.webkit.org/show_bug.cgi?id=240616
<rdar://93541706>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250801@main
- 8:55 AM Changeset in webkit [294545] by
-
- 3 edits in trunk/Tools/CISupport/ews-build
[EWS] Remove ChangeLog steps
https://bugs.webkit.org/show_bug.cgi?id=240542
<rdar://problem/93456184>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/factories.py:
- Tools/CISupport/ews-build/steps.py:
(ValidateCommitterAndReviewer.start):
(SetBuildSummary.start):
(ValidateChangeLogAndReviewer): Deleted.
(FindModifiedChangeLogs): Deleted.
(CreateLocalGITCommit): Deleted.
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/250800@main
- 8:28 AM Changeset in webkit [294544] by
-
- 177 deletes in trunk
Eliminate changelogs
https://bugs.webkit.org/show_bug.cgi?id=239125
<rdar://91959187>
Reviewed by Michael Catanzaro and Aakash J.
Let the past die. Kill it, if you have to.
- ChangeLog-2012-05-22: Removed.
- ChangeLog-2018-01-01: Removed.
- JSTests/ChangeLog-2018-09-11: Removed.
- JSTests/ChangeLog-2021-03-18: Removed.
- LayoutTests/ChangeLog-2007-10-14: Removed.
- LayoutTests/ChangeLog-2008-08-10: Removed.
- LayoutTests/ChangeLog-2009-06-16: Removed.
- LayoutTests/ChangeLog-2010-01-29: Removed.
- LayoutTests/ChangeLog-2010-05-24: Removed.
- LayoutTests/ChangeLog-2010-12-06: Removed.
- LayoutTests/ChangeLog-2011-02-16: Removed.
- LayoutTests/ChangeLog-2011-06-04: Removed.
- LayoutTests/ChangeLog-2012-04-23: Removed.
- LayoutTests/ChangeLog-2012-05-22: Removed.
- LayoutTests/ChangeLog-2012-10-02: Removed.
- LayoutTests/ChangeLog-2013-04-24: Removed.
- LayoutTests/ChangeLog-2013-10-13: Removed.
- LayoutTests/ChangeLog-2014-02-20: Removed.
- LayoutTests/ChangeLog-2014-10-07: Removed.
- LayoutTests/ChangeLog-2015-11-21: Removed.
- LayoutTests/ChangeLog-2016-09-26: Removed.
- LayoutTests/ChangeLog-2017-03-23: Removed.
- LayoutTests/ChangeLog-2018-01-01: Removed.
- LayoutTests/ChangeLog-2018-09-11: Removed.
- LayoutTests/ChangeLog-2019-06-05: Removed.
- LayoutTests/ChangeLog-2020-04-10: Removed.
- LayoutTests/ChangeLog-2021-03-18: Removed.
- LayoutTests/ChangeLog-2022-02-22: Removed.
- LayoutTests/imported/w3c/ChangeLog-2016-09-26: Removed.
- LayoutTests/imported/w3c/ChangeLog-2018-01-01: Removed.
- LayoutTests/imported/w3c/ChangeLog-2018-09-11: Removed.
- LayoutTests/imported/w3c/ChangeLog-2020-04-10: Removed.
- LayoutTests/imported/w3c/ChangeLog-2021-03-18: Removed.
- LayoutTests/imported/w3c/ChangeLog-2022-02-22: Removed.
- PerformanceTests/ChangeLog-2018-01-01: Removed.
- Source/JavaScriptCore/ChangeLog-2002-12-03: Removed.
- Source/JavaScriptCore/ChangeLog-2003-10-25: Removed.
- Source/JavaScriptCore/ChangeLog-2007-10-14: Removed.
- Source/JavaScriptCore/ChangeLog-2008-08-10: Removed.
- Source/JavaScriptCore/ChangeLog-2009-06-16: Removed.
- Source/JavaScriptCore/ChangeLog-2010-05-24: Removed.
- Source/JavaScriptCore/ChangeLog-2011-02-16: Removed.
- Source/JavaScriptCore/ChangeLog-2012-05-22: Removed.
- Source/JavaScriptCore/ChangeLog-2012-10-02: Removed.
- Source/JavaScriptCore/ChangeLog-2013-04-24: Removed.
- Source/JavaScriptCore/ChangeLog-2013-10-13: Removed.
- Source/JavaScriptCore/ChangeLog-2014-02-20: Removed.
- Source/JavaScriptCore/ChangeLog-2014-10-07: Removed.
- Source/JavaScriptCore/ChangeLog-2015-11-21: Removed.
- Source/JavaScriptCore/ChangeLog-2016-09-26: Removed.
- Source/JavaScriptCore/ChangeLog-2017-03-23: Removed.
- Source/JavaScriptCore/ChangeLog-2018-01-01: Removed.
- Source/JavaScriptCore/ChangeLog-2018-09-11: Removed.
- Source/JavaScriptCore/ChangeLog-2019-06-05: Removed.
- Source/JavaScriptCore/ChangeLog-2020-04-10: Removed.
- Source/JavaScriptCore/ChangeLog-2021-03-18: Removed.
- Source/JavaScriptCore/ChangeLog-2022-02-22: Removed.
- Source/ThirdParty/ANGLE/ChangeLog-2022-02-22: Removed.
- Source/WTF/ChangeLog-2013-10-13: Removed.
- Source/WTF/ChangeLog-2016-09-26: Removed.
- Source/WTF/ChangeLog-2018-09-11: Removed.
- Source/WTF/ChangeLog-2021-03-18: Removed.
- Source/WebCore/ChangeLog-2002-12-03: Removed.
- Source/WebCore/ChangeLog-2003-10-25: Removed.
- Source/WebCore/ChangeLog-2005-08-23: Removed.
- Source/WebCore/ChangeLog-2005-12-19: Removed.
- Source/WebCore/ChangeLog-2006-05-10: Removed.
- Source/WebCore/ChangeLog-2006-12-31: Removed.
- Source/WebCore/ChangeLog-2007-10-14: Removed.
- Source/WebCore/ChangeLog-2008-08-10: Removed.
- Source/WebCore/ChangeLog-2009-06-16: Removed.
- Source/WebCore/ChangeLog-2010-01-29: Removed.
- Source/WebCore/ChangeLog-2010-05-24: Removed.
- Source/WebCore/ChangeLog-2010-12-06: Removed.
- Source/WebCore/ChangeLog-2011-02-16: Removed.
- Source/WebCore/ChangeLog-2011-06-04: Removed.
- Source/WebCore/ChangeLog-2011-10-19: Removed.
- Source/WebCore/ChangeLog-2012-05-22: Removed.
- Source/WebCore/ChangeLog-2012-10-02: Removed.
- Source/WebCore/ChangeLog-2013-04-24: Removed.
- Source/WebCore/ChangeLog-2013-10-13: Removed.
- Source/WebCore/ChangeLog-2014-02-20: Removed.
- Source/WebCore/ChangeLog-2014-10-07: Removed.
- Source/WebCore/ChangeLog-2015-11-21: Removed.
- Source/WebCore/ChangeLog-2016-09-26: Removed.
- Source/WebCore/ChangeLog-2017-03-23: Removed.
- Source/WebCore/ChangeLog-2018-01-01: Removed.
- Source/WebCore/ChangeLog-2018-09-11: Removed.
- Source/WebCore/ChangeLog-2019-06-05: Removed.
- Source/WebCore/ChangeLog-2020-04-10: Removed.
- Source/WebCore/ChangeLog-2021-03-18: Removed.
- Source/WebCore/ChangeLog-2022-02-22: Removed.
- Source/WebInspectorUI/ChangeLog-2013-06-11: Removed.
- Source/WebInspectorUI/ChangeLog-2014-11-19: Removed.
- Source/WebInspectorUI/ChangeLog-2015-11-21: Removed.
- Source/WebInspectorUI/ChangeLog-2016-09-26: Removed.
- Source/WebInspectorUI/ChangeLog-2018-01-01: Removed.
- Source/WebInspectorUI/ChangeLog-2019-06-05: Removed.
- Source/WebInspectorUI/ChangeLog-2021-03-18: Removed.
- Source/WebKit/ChangeLog-2011-02-16: Removed.
- Source/WebKit/ChangeLog-2011-06-04: Removed.
- Source/WebKit/ChangeLog-2012-05-22: Removed.
- Source/WebKit/ChangeLog-2012-10-02: Removed.
- Source/WebKit/ChangeLog-2013-04-24: Removed.
- Source/WebKit/ChangeLog-2013-10-13: Removed.
- Source/WebKit/ChangeLog-2014-02-20: Removed.
- Source/WebKit/ChangeLog-2014-10-07: Removed.
- Source/WebKit/ChangeLog-2015-11-21: Removed.
- Source/WebKit/ChangeLog-2016-09-26: Removed.
- Source/WebKit/ChangeLog-2017-03-23: Removed.
- Source/WebKit/ChangeLog-2018-01-01: Removed.
- Source/WebKit/ChangeLog-2018-09-11: Removed.
- Source/WebKit/ChangeLog-2019-06-05: Removed.
- Source/WebKit/ChangeLog-2020-04-10: Removed.
- Source/WebKit/ChangeLog-2021-03-18: Removed.
- Source/WebKit/ChangeLog-2022-02-22: Removed.
- Source/WebKitLegacy/mac/ChangeLog-2002-12-03: Removed.
- Source/WebKitLegacy/mac/ChangeLog-2006-02-09: Removed.
- Source/WebKitLegacy/mac/ChangeLog-2007-10-14: Removed.
- Source/WebKitLegacy/mac/ChangeLog-2010-01-29: Removed.
- Source/WebKitLegacy/mac/ChangeLog-2012-10-02: Removed.
- Source/WebKitLegacy/mac/ChangeLog-2015-11-21: Removed.
- Source/WebKitLegacy/mac/ChangeLog-2019-06-05: Removed.
- Source/WebKitLegacy/win/ChangeLog-2009-06-16: Removed.
- Source/WebKitLegacy/win/ChangeLog-2015-11-21: Removed.
- Source/bmalloc/ChangeLog-2022-02-22: Removed.
- Tools/ChangeLog-2009-06-16: Removed.
- Tools/ChangeLog-2010-05-24: Removed.
- Tools/ChangeLog-2011-02-16: Removed.
- Tools/ChangeLog-2012-05-22: Removed.
- Tools/ChangeLog-2012-10-02: Removed.
- Tools/ChangeLog-2013-04-24: Removed.
- Tools/ChangeLog-2014-02-20: Removed.
- Tools/ChangeLog-2015-11-21: Removed.
- Tools/ChangeLog-2017-03-23: Removed.
- Tools/ChangeLog-2018-01-01: Removed.
- Tools/ChangeLog-2018-09-11: Removed.
- Tools/ChangeLog-2019-06-05: Removed.
- Tools/ChangeLog-2020-04-10: Removed.
- Tools/ChangeLog-2021-03-18: Removed.
- Tools/ChangeLog-2022-02-22: Removed.
- Websites/perf.webkit.org/ChangeLog-2018-01-01: Removed.
Canonical link: https://commits.webkit.org/250799@main
- 8:00 AM Changeset in webkit [294543] by
-
- 1 edit in trunk/Source/WebKit/UIProcess/API/glib/WebKitDeviceInfoPermissionRequest.cpp
[GLib] Fix typo in WebKitUserMediaPermissionRequest description
https://bugs.webkit.org/show_bug.cgi?id=240708
Patch by Olivier Blin <Olivier Blin> on 2022-05-20
Reviewed by Adrian Perez de Castro.
Mention enumerateDevices instead of enumeraceDevices.
Introduced in r237031.
- Source/WebKit/UIProcess/API/glib/WebKitDeviceInfoPermissionRequest.cpp:
Canonical link: https://commits.webkit.org/250798@main
- 5:58 AM Changeset in webkit [294542] by
-
- 2 edits in trunk/Tools/Scripts/webkitpy/style/checkers
check-webkit-style: more strict upper case enum exceptions
https://bugs.webkit.org/show_bug.cgi?id=240681
Reviewed by Darin Adler.
Added a new list of common abbreviations which are allowed to be
used as all uppercase enum values.
- Tools/Scripts/webkitpy/style/checkers/cpp.py:
(_EnumState.process_clean_line):
(_EnumState.process_clean_line.is_case_error): Extracted common
logic for inline and multiline enum declarations.
(_EnumState):
- Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(NoNonVirtualDestructorsTest):
Canonical link: https://commits.webkit.org/250797@main
- 5:02 AM Changeset in webkit [294541] by
-
- 1 edit in trunk/Source/WebKit/PlatformWPE.cmake
REGRESSION(r294504) [WPE] Fix build after PDF.js changes
https://bugs.webkit.org/show_bug.cgi?id=240711
Patch by Olivier Blin <Olivier Blin> on 2022-05-20
Reviewed by Adrian Perez de Castro.
- Source/WebKit/PlatformWPE.cmake: do not use GTK-specific variables.
Canonical link: https://commits.webkit.org/250796@main
- 2:25 AM Changeset in webkit [294540] by
-
- 1 edit in trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
[GStreamer] Block legacy VAAPI plugin
https://bugs.webkit.org/show_bug.cgi?id=240664
Patch by Philippe Normand <philn@igalia.com> on 2022-05-20
Reviewed by Xabier Rodriguez-Calvar.
The VAAPI plugin is not much maintained anymore and prone to rendering issues. In the
mid-term we will leverage the new stateless VA decoders. Disable the legacy plugin,
unless the WEBKIT_GST_ENABLE_LEGACY_VAAPI environment variable is set to 1.
- Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::registerWebKitGStreamerElements):
Canonical link: https://commits.webkit.org/250795@main
- 2:16 AM Changeset in webkit [294539] by
-
- 1 edit in trunk/Source/WTF/wtf/win/ThreadingWin.cpp
[Win] Destroy Thread::ClientData only when thread TLS is initialized
https://bugs.webkit.org/show_bug.cgi?id=240707
Reviewed by Mark Lam.
Move destruction under if (thread) check.
- Source/WTF/wtf/win/ThreadingWin.cpp:
(WTF::Thread::ThreadHolder::~ThreadHolder):
Canonical link: https://commits.webkit.org/250793@main
- 2:16 AM Changeset in webkit [294538] by
-
- 1 edit in trunk/Source/WebCore/rendering/svg/RenderSVGBlock.cpp
Non-unified build fixes, late-ish May 2022 edition
https://bugs.webkit.org/show_bug.cgi?id=240710
Unreviewed build fix
- Source/WebCore/rendering/svg/RenderSVGBlock.cpp: Add missing RenderView.h inclusion.
Canonical link: https://commits.webkit.org/250793@main
- 1:47 AM Changeset in webkit [294537] by
-
- 4 edits in trunk/Source/WebCore/platform/graphics/gstreamer
REGRESSION(r288092): Deadlock when the playback is stopping just right after startup
https://bugs.webkit.org/show_bug.cgi?id=240661
Patch by Yacine Bandou <yacine.bandou@softathome.com> on 2022-05-20
Reviewed by Philippe Normand.
r288092 causes a deadlock with the "28. ChangeType.H264.VP9" test in "https://ytlr-cert.appspot.com/2020/main.html".
The background thread locks the GStPad and sends a notify::caps signal which is caught by
VideoTrackPrivateGStreamer that calls callOnMainThreadAndWait.
At the same time the main thread destroys MediaPlayerPrivateGStreamer and sets the pipeline to NULL
that calls "gst_pad_set_active" which wants to lock the GStPad.
This commit uses AbortableTaskQueue and calls enqueueTask instead of callOnMainThreadAndWait
in order to be able to abort the waiting job and avoid using the "AndWait" variant, consequently
we avoid the deadlock.
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):
(WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromTags):
(WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromCaps):
(WebCore::AudioTrackPrivateGStreamer::disconnect):
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):
(WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromTags):
(WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromCaps):
(WebCore::VideoTrackPrivateGStreamer::disconnect):
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
Canonical link: https://commits.webkit.org/250792@main
- 12:17 AM Changeset in webkit [294536] by
-
- 15 edits in trunk/Source
Drawing the PDF snapshot should take place in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=240368
rdar://91660159
Reviewed by Simon Fraser.
The ImageBufferBackends should act like a drawing surface only. It has
a GraphicsContext. It can get and set pixels. And it can get a NativeImage
out of the pixels. But it should never draw itself to a GraphicsContext.
The ImageBuffer can act like an image. It can draw itself as an image or
as a pattern into a GraphicsContext.
So draw(), drawPattern() and drawConsuming() will be removed from the
ImageBufferBackend super classes and the implementation will be unified
for all platforms and moved to ConcreteImageBuffer.
By doing that, a canvas can be drawn to the PDF context in WebProcess
even if the GPUProcess for DOM rendering is enabled.
Canonical link: https://commits.webkit.org/250791@main
- 12:14 AM Changeset in webkit [294535] by
-
- 2 edits in trunk/Tools/Scripts/libraries
[git-webkit] Question 'Are you sure want to setup a fork?' always returns 'Yes'
Reviewed by Jonathan Bedard.
When the response of the user is an empty string, function 'Terminal.choose'
always returns the first option.
The reason for that is a 'startswith' comparison of an option with an empty
string. This comparison is always true, thus the first option is selected
instead of the default option.
Canonical link: https://commits.webkit.org/250790@main
May 19, 2022:
- 11:51 PM Changeset in webkit [294534] by
-
- 5 edits in trunk/Source/WebCore/css
CSSMotionPathEnabled setting does not prevent parsing of CSS Motion Path properties
https://bugs.webkit.org/show_bug.cgi?id=240594
<rdar://93522039>
Patch by Antoine Quint <Antoine Quint> on 2022-05-19
Reviewed by Antti Koivisto.
- Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- Source/WebCore/css/CSSProperties.json:
- Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::operator==):
(WebCore::add):
(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):
- Source/WebCore/css/parser/CSSParserContext.h:
- Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseShorthand):
Canonical link: https://commits.webkit.org/250789@main
- 11:39 PM Changeset in webkit [294533] by
-
- 1 edit in trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp
Add
revert-layertoisUniversalKeyword
https://bugs.webkit.org/show_bug.cgi?id=234674
Reviewed by Antti Koivisto.
- Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::isUniversalKeyword):
Canonical link: https://commits.webkit.org/250788@main
- 11:19 PM Changeset in webkit [294532] by
-
- 2 edits in trunk/Tools/Scripts
Tests with an '-e' parameters in requireOptions fail with bytecode cache enabled
https://bugs.webkit.org/show_bug.cgi?id=218703
Patch by Xan López <Xan Lopez> on 2022-05-19
Reviewed by Yusuke Suzuki.
Do not try to further tokenize the command parameters to the test run
in the bytecode cache helper script. This will just mess up things
like the '-e "foo bar"' extra options, and it's not needed.
- Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: do not tokenize the arguments to the script.
- Scripts/run-jsc-stress-tests: also run the bytecode cache tests on MIPS.
Canonical link: https://commits.webkit.org/250787@main
- 10:49 PM Changeset in webkit [294531] by
-
- 3 edits in trunk/Source
ASSERT(status == U_ZERO_ERROR) under SearchBuffer::search() when typing in the url bar in the iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=240699
<rdar://92182174>
Reviewed by Tim Horton.
Replace
status == U_ZERO_ERRORtests withU_SUCCESS(status).
- Source/WebCore/PAL/pal/text/TextCodecICU.cpp:
(PAL::ErrorCallbackSetter::ErrorCallbackSetter):
(PAL::ErrorCallbackSetter::~ErrorCallbackSetter):
- Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm:
(WebKit::SpoofChecker::checker):
- Source/WebCore/editing/TextIterator.cpp:
(WebCore::createSearcher):
(WebCore::SearchBuffer::SearchBuffer):
(WebCore::SearchBuffer::~SearchBuffer):
(WebCore::SearchBuffer::search):
Canonical link: https://commits.webkit.org/250786@main
- 10:27 PM Changeset in webkit [294530] by
-
- 1 edit4 adds in trunk
REGRESSION (r293126): Gmail formatting menu/panel in compose view becomes blank/empty while scrolling
https://bugs.webkit.org/show_bug.cgi?id=240625
<rdar://92984518>
Reviewed by Alan Bujtas.
Gmail uses the css
clipproperty with negative offsets, which is surprising, and revealed a bug in
the compositing code for clipping.
When a stacking-context layer has overflow:hidden or clip:, we assume that the clip encloses all the
descendants, so make a GraphicsLayer with masksToBounds as a parent of the child layers. When the
layer has border-radius with uneven corners, we implement that with a shape layer which acts as a
mask on that clipping GraphicsLayer.
The content in question had CSS clip with negative offsets and border-radius, so the shape layer
mask would clip out any content outside the border shape.
So if the clip rect extends beyond the border, we need to follow a different code path, which pushes
the clipping layers onto descendants; this code path is used for non-stacking context clipping, and
for mix-blend-mode which needs to avoid the creation of the intermediate clipping layer.
So generalize the
isolatesCompositedBlending()code path to also be used in the scenario of CSS
clip which extends outside the border box.
Tests: compositing/clipping/css-clip-and-border-radius.html
compositing/clipping/css-clip-non-stacking.html
- Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::canUseDescendantClippingLayer):
(WebCore::RenderLayerCompositor::clippedByAncestor const):
(WebCore::RenderLayerCompositor::computeAncestorClippingStack const):
(WebCore::RenderLayerCompositor::clipsCompositingDescendants):
- LayoutTests/compositing/clipping/css-clip-and-border-radius-expected.html: Added.
- LayoutTests/compositing/clipping/css-clip-and-border-radius.html: Added.
- LayoutTests/compositing/clipping/css-clip-non-stacking-expected.html: Added.
- LayoutTests/compositing/clipping/css-clip-non-stacking.html: Added.
Canonical link: https://commits.webkit.org/250785@main
- 9:52 PM Changeset in webkit [294529] by
-
- 1 edit3 adds in trunk/LayoutTests/platform/ios-wk2
[ Gardening ]REBASELINE [ iOS ] fast/events/ios/rotation/layout-viewport-during-safari-type-rotation.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=231266
Unreviewed test gardening. Rebaseline for iOS.
- LayoutTests/platform/ios-wk2/TestExpectations:
- LayoutTests/platform/ios-wk2/fast/events/ios/rotation/layout-viewport-during-rotation-expected.txt: Added.
Canonical link: https://commits.webkit.org/250784@main
- 9:03 PM Changeset in webkit [294528] by
-
- 1 edit in trunk/Source/WebCore/rendering/PathOperation.h
Unreviewed, non-unified build fixes after 250776@main
- 8:46 PM Changeset in webkit [294527] by
-
- 3 edits in trunk/Source/WebKit
Remove unused memory capacity output value in calculateURLCacheSizes
https://bugs.webkit.org/show_bug.cgi?id=240577
Patch by Olivier Blin <Olivier Blin> on 2022-05-19
Reviewed by Darin Adler.
Source/WebKit:
calculateURLCacheSizes() had a urlCacheMemoryCapacity output value
since its creation in r203857, which was passed to platformSetURLCacheSize().
But the implementation has been removed for the soup platform in
r205556 when switching to the WebKit network cache, and for the Cocoa
platform in r232201 when dropping NSURLCache support.
urlCacheMemoryCapacity is now unused.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::computeCapacity):
- Shared/CacheModel.cpp:
(WebKit::calculateURLCacheSizes):
- Shared/CacheModel.h:
Canonical link: https://commits.webkit.org/250782@main
- 8:38 PM Changeset in webkit [294526] by
-
- 48 edits3 deletes in trunk/Source
Remove a first bit of unused plug-in code
https://bugs.webkit.org/show_bug.cgi?id=240309
Reviewed by Chris Dumez.
- Source/WebKit/Sources.txt: Removed Plugin.cpp.
Removed unneeded @no-unify for PluginView.cpp and WebPluginInfoProvider.cpp.
- Source/WebKit/UIProcess/WebProcessProxy.cpp: Removed unneeded include
of PDFPlugin.h.
- Source/WebKit/WebKit.xcodeproj/project.pbxproj: Removed Plugin.cpp,
Plugin.h, and PluginController.h, and turned off non-unified building
for PluginView.cpp and WebPluginInfoProvider.cpp.
- Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameHandlesPageScaleGesture): Deprecate, and always return false.
- Source/WebKit/WebProcess/InjectedBundle/API/c/mac/WKBundlePageMac.mm:
(WKBundlePageGetPDFDocumentInFrame): Moved code inside #if ENABLE(PDFKIT_PLUGIN)
and also removed some unneeded local variables and includes.
- Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h: Updated includes,
removing uneeeded ones, and adding others that previously were inherited
from Plugin.h. Similarly, added and removed forward declarations.
Changed the class to inherit from ThreadSafeRefCounted directly, eliminating
the Plugin base class. Removed the unneeded WebFrame argument from the create
function. Moved functions here from Plugin. Made handlesPageScalFactor,
convertFromPDFViewToRootView frameForHUD, and ensureDataBufferLength private.
Made isFullFramePlugin public. Added deviceScaleFactor. Made the virtual
function overrides just normal functions. Also tweaked arguments and return
values on some of them so they are the minimum needed to do the job.
Replaced the old weak pointer to the plug-in controller with a weak ponter
to the plug-in view; the two are the same object. Removed the isPDFPlugin
function and the type traits for downcast, since this is no longer derived
from a Plugin base class.
- Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm: Tweaked includes.
Removed the "requestID" since now loading the main resource of the plug-in
is done without using general purpose "stream-loading" machinery.
(WebKit::PDFPlugin::create): Take fewer arguments.
(WebKit::PDFPlugin::PDFPlugin): Use WebFrame::fromCoreFrame to find the
frame so we don't have to pass it in. No need for null checks, though, because
PluginView does all those. Refactor and tweak a bit.
(WebKit::PDFPlugin::getResourceBytesAtPosition): Get URL from m_view.
(WebKit::PDFPlugin::updateScrollbars): Use m_view.
(WebKit::PDFPlugin::pluginView): Deleted.
(WebKit::PDFPlugin::pluginView const): Deleted.
(WebKit::PDFPlugin::createScrollbar): Use m_view.
(WebKit::PDFPlugin::convertFromScrollbarToContainingView const): Ditto.
(WebKit::PDFPlugin::convertFromContainingViewToScrollbar const): Ditto.
(WebKit::PDFPlugin::handleScroll): Deleted.
(WebKit::PDFPlugin::scrollCornerRect const): Use m_view.
(WebKit::PDFPlugin::scrollableAreaBoundingBox const): Ditto.
(WebKit::PDFPlugin::addArchiveResource): Ditto. Also get URL from m_vie
since we no longer have m_sourceURL.
(WebKit::PDFPlugin::streamDidFinishLoading): Merged with
documentDataDidFinishLoading and manualStreamDidFinishLoading, and removed
the streamID argument since we only use one stream, to load PDF document data.
(WebKit::PDFPlugin::installPDFDocument): Use m_view.
(WebKit::PDFPlugin::streamDidReceiveResponse): Merged with setSuggestedFilename
and manualStreamDidReceiveResponse, and removed the streamID argument.
(WebKit::PDFPlugin::streamDidReceiveData): Merged with manualStreamDidReceiveData,
and removed the streamID argument.
(WebKit::PDFPlugin::streamDidFail): Merged with manualStreamDidFail, and removed
the streamID argument.
(WebKit::PDFPlugin::deviceScaleFactor const): Added. Gets the device scale factor
from the WebCore Page, which is something we have to do twice. The old code used
to go through the controller to do this.
(WebKit::PDFPlugin::updatePageAndDeviceScaleFactors): Use m_view. This change
looks confusing because what the controller called contentsScaleFactor was the
device scale factor from the WebCore::Page. Better to call that deviceScaleFactor.
(WebKit::PDFPlugin::initialize): Deleted. Moved all this code into
PluginView::initializePlugin.
(WebKit::PDFPlugin::setView): Added. Used to initialize.
(WebKit::PDFPlugin::destroy): Merged with destroyPlugin and with Plugin::destroy.
(WebKit::PDFPlugin::snapshot): Use deviceScaleFactor. See note above.
(WebKit::PDFPlugin::pluginLayer): Use CALayer for the return type.
(WebKit::PDFPlugin::geometryDidChange): Use m_view.
(WebKit::PDFPlugin::frameDidFinishLoading): Deleted.
(WebKit::PDFPlugin::frameDidFail): Deleted.
(WebKit::PDFPlugin::didEvaluateJavaScript): Deleted.
(WebKit::PDFPlugin::handleEditingCommand): Removed unused argument, use StringView.
(WebKit::PDFPlugin::isEditingCommandEnabled): Use StringView.
(WebKit::PDFPlugin::isFullFramePlugin const): Use m_view.
(WebKit::PDFPlugin::notifyContentScaleFactorChanged): Ditto.
(WebKit::PDFPlugin::pluginHandlesContentOffsetForAccessibilityHitTest const): Deleted.
(WebKit::PDFPlugin::openWithNativeApplication): Use isNull.
(WebKit::PDFPlugin::nextMatchForString): Use bool.
- Source/WebKit/WebProcess/Plugins/Plugin.cpp: Removed.
- Source/WebKit/WebProcess/Plugins/Plugin.h: Removed.
- Source/WebKit/WebProcess/Plugins/PluginController.h: Removed.
- Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::URLRequest): Deleted.
(WebKit::PluginView::Stream::create): Remove streamID.
(WebKit::PluginView::Stream::streamID const): Deleted.
(WebKit::PluginView::Stream::Stream): Remove streamID.
(WebKit::PluginView::Stream::start): Use PluginView::frame.
(WebKit::PluginView::Stream::continueLoad): Removed unneeded assertion.
(WebKit::buildHTTPHeaders): Deleted.
(WebKit::lastModifiedDateMS): Deleted.
(WebKit::PluginView::Stream::willSendRequest): Removed call to
streamWillSendRequest.
(WebKit::PluginView::Stream::didReceiveResponse): Removed most of the
arguments to streamDidReceiveResponse.
(WebKit::PluginView::Stream::didReceiveData): Removed the streamID
argument to streamDidReceiveData.
(WebKit::PluginView::Stream::didFail): Removed the arguments to
streamDidFail, and the call to removeStream, since we can do that here.
(WebKit::PluginView::Stream::didFinishLoading): Removed the
streamID argument to stringDidFinishLoading, and the call to removeStream,
since we can do that here.
(WebKit::webPage): Deleted.
(WebKit::PluginView::create): Moved the code to map from element to WebPage
in here, changed the arguments to take all the parameters instead of
a Parameters struct, and moved the call to shouldUsePDFPlugin here
from WebPage::createPlugin.
(WebKit::PluginView::PluginView): Take individual parameters instead of
a Parameters struct. Also update for name changes.
(WebKit::PluginView::~PluginView): Removed most of the code, leaving
only call to cancel the stream and destroy the plug-in.
(WebKit::PluginView::destroyPluginAndReset): Deleted.
(WebKit::PluginView::setLayerHostingMode): Deleted.
(WebKit::PluginView::manualLoadDidReceiveResponse): Removed null check
of m_plugin, and most of the arguments to manualStreamDidReceiveResponse,
calling streamDidReceiveResponse instead.
(WebKit::PluginView::manualLoadDidReceiveData): Removed null check
of m_plugin, and call streamDidReceiveData instead of a separate
manualStreamDidReceiveData.
(WebKit::PluginView::manualLoadDidFinishLoading): Removed null check
of m_plugin, and call streamDidFinishLoading instead of a separate
manualStreamDidFinishLoading.
(WebKit::PluginView::manualLoadDidFail): Removed null check
of m_plugin, handling of specific stream errors, and call streamDidFail
without a specific error instead of a separate manualStreamDidFail.
(WebKit::PluginView::setPageScaleFactor): Removed unused IntPoint argument.
(WebKit::PluginView::handlesPageScaleFactor const): Deleted.
(WebKit::PluginView::requiresUnifiedScaleFactor const): Deleted.
(WebKit::PluginView::activityStateDidChange): Deleted.
(WebKit::PluginView::setDeviceScaleFactor): Removed null check of m_plugin.
(WebKit::PluginView::accessibilityAssociatedPluginParentForElement const):
(WebKit::PluginView::windowAndViewFramesChanged): Deleted.
(WebKit::PluginView::accessibilityAssociatedPluginParentForElement const):
Removed null check of m_plugin.
(WebKit::PluginView::accessibilityObject const): Ditto.
(WebKit::PluginView::initializePlugin): Merged with didInitializePlugin
removed null check of m_plugin, code to call addMediaCanStartListener,
code to call addAudioProducer, call Plugin::setView instead of calling
Plugin::initialize, call loadMainResource if needed, which was previously
done by Plugin::initialize. Removed the calls to windowAndViewFramesChanged
Plugin::setFocus. windowVisibilityChanged, windowFocusChanged, and
wantsWheelEvents. Fixed a bug in handling of non-full-frame plug-ins
in the main frame by only sending
MainFramePluginHandlesPageScaleGestureDidChange when it is full frame.
(WebKit::PluginView::platformLayer const): Removed null check of m_plugin.
(WebKit::PluginView::storageBlockingStateChanged): Deleted.
(WebKit::PluginView::scroll): Ditto.
(WebKit::PluginView::horizontalScrollbar): Ditto.
(WebKit::PluginView::verticalScrollbar): Ditto.
(WebKit::PluginView::wantsWheelEvents): Return true.
(WebKit::PluginView::paint): Removed null check of m_plugin and the
call to Plugin::paint.
(WebKit::PluginView::countFindMatches): Removed null check of m_plugin.
(WebKit::PluginView::findString): Ditto.
(WebKit::PluginView::getSelectionString const): Ditto.
(WebKit::PluginView::createWebEvent const): Deleted. Calling this
eventually resulted in calling Plugin::convertToRootView and would then
hit ASSSERT_NOT_REACHED.
(WebKit::PluginView::handleEvent): Removed the call to createWebEvent.
Updated since m_pluginElement is a Ref instead of RefPtr. Removed the
call to wantsWheelEvents, which is now always true.
(WebKit::PluginView::handleEditingCommand): Removed null check of
m_plugin and stop passing the argument to Plugin::handleEditingCommand.
(WebKit::PluginView::isEditingCommandEnabled): Removed null check of
m_plugin.
(WebKit::PluginView::shouldAllowScripting): Deleted.
(WebKit::PluginView::shouldAllowNavigationFromDrags const): Return true.
(WebKit::PluginView::willDetachRenderer): Removed null check of m_plugin.
(WebKit::PluginView::liveResourceData const): Ditto.
(WebKit::PluginView::performDictionaryLookupAtLocation): Ditto.
(WebKit::PluginView::existingSelectionContainsPoint const): Ditto.
(WebKit::PluginView::viewGeometryDidChange): Ditto.
(WebKit::PluginView::viewVisibilityDidChange): Removed code to calculate
the clip rect and don't pass a clip rect to Plugin::geometryDidChange.
(WebKit::PluginView::clipRectInWindowCoordinates const): Update since
m_pluginElement is a Ref.
(WebKit::PluginView::focusPluginElement): Ditto.
(WebKit::PluginView::pendingResourceRequestTimerFired): Renamed from
pendingURLRequestsTimerFired. Simplified code since we can only have
one pending resource request and we don't want to support JavaScript URLs.
(WebKit::PluginView::performURLRequest): Deleted.
(WebKit::PluginView::performFrameLoadURLRequest): Deleted.
(WebKit::PluginView::performJavaScriptURLRequest): Deleted.
(WebKit::PluginView::addStream): Deleted.
(WebKit::PluginView::removeStream): Deleted.
(WebKit::PluginView::cancelAllStreams): Deleted.
(WebKit::PluginView::redeliverManualStream): Removed error argument
for manualLoadDidFail function.
(WebKit::PluginView::invalidateRect): Removed null check of m_plugin.
(WebKit::PluginView::setFocus): Deleted.
(WebKit::PluginView::mediaCanStart): Deleted.
(WebKit::PluginView::pageMutedStateDidChange): Deleted.
(WebKit::PluginView::loadMainResource): Renamed from loadURL.
Removed all the arguments, since it always loads the same URL in the
same way. Removed most of the code since most arguments are defaults.
(WebKit::PluginView::contentsScaleFactor): Deleted.
(WebKit::PluginView::didFinishLoad): Deleted.
(WebKit::PluginView::didFailLoad): Deleted.
(WebKit::PluginView::shouldCreateTransientPaintingSnapshot const):
Removed null check of m_plugin.
(WebKit::PluginView::isBeingDestroyed const): Moved out of
PluginView.h so it does not have to include PDFPlugin.h.
(WebKit::PluginView::pdfDocumentForPrinting const): Ditto.
(WebKit::PluginView::pdfDocumentSizeForPrinting const): Added.
(WebKit::PluginView::accessibilityHitTest const): Moved out of
PluginView.h so it does not have to include PDFPlugin.h.
(WebKit::PluginView::rectForSelectionInRootView const): Added.
(WebKit::PluginView::contentScaleFactor const): Added.
- Source/WebKit/WebProcess/Plugins/PluginView.h: Wrapped the
entire file in #if ENABLE(PDFKIT_PLUGIN) since this is no longer
a general purpose plug-in view. Removed many includes and an
obsolete comment about moving this whole class to WebCore.
Changed PluginView to no longer derive from PluginController,
MediaCanStartListener, LoadListener, or MediaProducer.
Removed most arguments to PluginView::create and the constructor,
added in the logic about whether to create a PDF view or not, so
it can now return nullptr. Moved isBeingDestroyed out of the header.
Removed the argument to manualLoadDidFail. Removed activityStateDidChange,
setLayerHostingMode, windowAndViewFramesChanged, initialParameters,
handlesPageScaleFactor, requiresUnifiedScaleFactor, shouldAllowScripting,
performURLRequest, performFrameLoadURLRequest, performJavaScriptURLRequest,
addStream, removeStream, cancelAllStreams, mediaCanStart, mediaState,
pageMutedStateDidChange, contentsScaleFactor, didInitializePlugin,
destroyPluginAndReset, didFinishLoad, didFailLoad, createWebEvent,
m_parameters, m_isWaitingUntilMediaCanStart, m_mainResourceURL,
m_mainResourceContentType, m_shouldUseManualLoader, m_pendingFrameLoads,
m_streams, m_manualStreamError, and m_pluginIsPlayingAudio.
Added pdfDocumentSizeForPrinting, mainResourceURL, lookupTextAtLocation,
rectForSelectionInRootView, contentScaleFactor, and m_stream.
Removed unused origin argument to setPageScaleFactor. Renamed
pendingURLRequestsTimerFired to pendingResourceRequestTimerFired,
m_pendingURLRequests to m_pendingResourceRequest,
m_pendingURLRequestsTimer to m_pendingResourceRequestTimer, and
loadURL to loadMainResource. Changed m_pluginElement and m_plugin
from RefPtr to Ref since neither can be null.
- Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp:
Removed most includes.
(WebKit::WebPluginInfoProvider::WebPluginInfoProvider): Deleted.
(WebKit::WebPluginInfoProvider::~WebPluginInfoProvider): Deleted.
(WebKit::pluginInfoVector): Added. Factors out common code.
(WebKit::WebPluginInfoProvider::pluginInfo): Removed everything
except the call to pluginInfoVector.
(WebKit::WebPluginInfoProvider::webVisiblePluginInfo): Ditto.
- Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.h:
Removed unnneded include and tweaked coding style a bit.
- Source/WebKit/WebProcess/Storage/WebSWClientConnection.cpp:
Added a missing FrameDestructionObserverInlines.h include.
- Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::print): Call pdfDocumentSizeForPrinting
on the view, not the plug-in. Fixed the #if that was incorrectly
doing PLATFORM(COCOA) when it means ENABLE(PDFKIT_PLUGIN).
- Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::hasPlugInView const): Added.
(WebKit::WebFrameLoaderClient::setMainDocumentError): Moved
plug-in-specific code inside ENABLE(PDFKIT_PLUGIN).
(WebKit::WebFrameLoaderClient::committedLoad): Call hasPlugInView
and moved plug-in-specific code inside ENABLE(PDFKIT_PLUGIN).
(WebKit::WebFrameLoaderClient::finishedLoading): Ditto.
(WebKit::WebFrameLoaderClient::createPlugin): Ditto. Also pass in
the arguments individually instead of a Parameters struct.
(WebKit::WebFrameLoaderClient::redirectDataToPlugin): Ditto.
(WebKit::WebFrameLoaderClient::allowScript): Always return false
for frames with plug-in views.
- Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Added hasPlugInView. Moved m_pluginView and m_hasSentResponseToPluginView
inside ENABLE(PDFKIT_PLUGIN).
- Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation): Put the plug-in
code inside ENABLE(PDFKIT_PLUGIN) and use mainFramePlugIn.
(WebKit::WebPage::getPDFFirstPageSize): Ditto. Also call the
pdfDocumentSizeForPrinting function on the plug-in view rather than
the plug-in. Also removed unneeded null check of WebCore frame before
calling pluginViewForFrame.
- Source/WebKit/WebProcess/WebPage/FindController.cpp: Added include
needed now that other headers don't pull in as many.
(WebKit::FindController::mainFramePlugIn): Added.
(WebKit::FindController::countStringMatches): Put code inside
(WebKit::FindController::updateFindUIAfterPageScroll): Ditto.
(WebKit::FindController::findString): Ditto.
(WebKit::FindController::hideFindUI): Ditto.
- Source/WebKit/WebProcess/WebPage/FindController.h: Added mainFramePlugIn.
- Source/WebKit/WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):
Update since handlesPageScaleGesture is now a WebPage function rather than a
WebFrame function.
(WebKit::ViewGestureGeometryCollector::collectGeometryForMagnificationGesture): Ditto.
- Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::handlesPageScaleGesture const): Deleted.
(WebKit::WebFrame::requiresUnifiedScaleFactor const): Deleted.
- Source/WebKit/WebProcess/WebPage/WebFrame.h: Updated for the above.
- Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::~WebPage): Put plug-in code inside #if ENABLE(PDFKIT_PLUGIN).
(WebKit::WebPage::editorState const): Ditto.
(WebKit::WebPage::createPlugin): Deleted.
(WebKit::WebPage::pluginViewForFrame): Use dynamicDowncast.
(WebKit::WebPage::mainFramePlugIn): Added.
(WebKit::WebPage::executeEditingCommand): Put plug-in code inside
#if ENABLE(PDFKIT_PLUGIN).
(WebKit::WebPage::isEditingCommandEnabled): Ditto.
(WebKit::WebPage::textZoomFactor const): Updated since all plug-ins
use "unified scale factor" and all main-frame plug-ins "handle page scale factor".
(WebKit::WebPage::setTextZoomFactor): Ditto.
(WebKit::WebPage::pageZoomFactor const): Ditto.
(WebKit::WebPage::setPageZoomFactor): Ditto.
(WebKit::WebPage::setPageAndTextZoomFactors): Ditto.
(WebKit::WebPage::scalePage): Removed original argument to setPageScaleFactor
and put plug-in code inside #if ENABLE(PDFKIT_PLUGIN).
(WebKit::WebPage::totalScaleFactor const): Updated since all main-frame
plug-ins "handle page scale factor" and put code in #if ENABLE.
(WebKit::WebPage::validateCommand): Put code in #if ENABLE.
(WebKit::WebPage::setTopContentInset): Ditto.
(WebKit::WebPage::getMainResourceDataOfFrame): Ditto.
(WebKit::WebPage::mainFrameView const): Ditto.
(WebKit::WebPage::setActivityState): Removed call to PluginView::activityStateDidChange.
(WebKit::WebPage::setLayerHostingMode): Removed call to PluginView::setLayerHostingMode.
(WebKit::WebPage::addPluginView): Removed code to set m_hasSeenPlugin.
(WebKit::WebPage::windowAndViewFramesChanged): Removed call to
PluginView::windowAndViewFramesChanged.
(WebKit::WebPage::handlesPageScaleGesture const): Added. Returns true if
we have a main-frame plug-in.
- Source/WebKit/WebProcess/WebPage/WebPage.h: Removed include of Plugin.h,
createPlugin, and m_hasSeenPlugin. Changed argument to the
dictionaryPopupInfoForSelectionInPDFPlugin from PDFPlugin to PluginView.
Put all members that involve PluginView inside #if statements.
Added handlesPageScaleGesture and mainFramePlugIn functions.
(WebKit::WebPage::accessibilityObjectForMainFramePlugin): Just return nil
since we don't have any plug-ins in iOS at this time.
- Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
(-[WKAccessibilityWebPageObject accessibilityHitTest:]): Removed call to
pluginHandlesContentOffsetForAccessibilityHitTest, and use mainFramePlugIn.
- Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::accessibilityObjectForMainFramePlugin): Use mainFramePlugIn.
(WebKit::WebPage::dictionaryPopupInfoForSelectionInPDFPlugin): Update since
the plug-in view function is named contentScaleFactor, not just scaleFactor
as the PDF plug-in functino was named.
(WebKit::WebPage::performImmediateActionHitTestAtLocation): Call
lookupTextAtLocation on the plug-in view, not the plug-in.
- Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper associatedPluginParent]): Use dynamicDowncast,
and remove some other casts that are not needed any more.
- Source/WebCore/bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginScriptObject): Use dynamicDowncast and removed the plug-in
element argument to DOMTimer::scriptDidInteractWithPlugin.
- Source/WebCore/bindings/js/ScriptController.cpp: Removed include of
PluginViewBase.h.
(WebCore::ScriptController::createScriptInstanceForWidget): Always return
nullptr; this function is only used on platforms that do not support scripting
with widgets at all.
- Source/WebCore/html/HTMLObjectElement.cpp: Removed include of PluginViewBase.h.
- Source/WebCore/html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::pluginWidget const): Return PluginViewBase* instead
of Widget*.
(WebCore::HTMLPlugInElement::isKeyboardFocusable const): Return false.
(WebCore::HTMLPlugInElement::isUserObservable const): Deleted.
(WebCore::HTMLPlugInElement::isBelowSizeThreshold const): Deleted.
- Source/WebCore/html/HTMLPlugInElement.h: Updated for the above.
- Source/WebCore/html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::willDetachRenderers): Removed unneeded
type castss now that pluginWidget returns a PluginViewBase.
- Source/WebCore/html/PluginDocument.cpp:
(WebCore::PluginDocument::pluginWidget): Return PluginViewBase* instead
of Widget*.
- Source/WebCore/html/PluginDocument.h: Updated for the above.
- Source/WebCore/inspector/PageDebugger.cpp:
(WebCore::PageDebugger::setJavaScriptPaused): Removed calls to plug-in views.
- Source/WebCore/loader/FrameLoaderClient.h: Removed forward
declaration of PluginViewBase.
- Source/WebCore/page/DOMTimer.cpp:
(WebCore::DOMTimer::scriptDidInteractWithPlugin): Removed the plug-in
element argument, because all were always returning true for isUserObservable.
- Source/WebCore/page/DOMTimer.h: Updated for the above.
- Source/WebCore/page/DragController.cpp:
(WebCore::DragController::operationForLoad): Removed unneeded dynamicDowncast.
- Source/WebCore/page/Page.cpp:
(WebCore::Page::pluginViews): Deleted.
(WebCore::Page::storageBlockingStateChanged): Removed calls to plug-in views.
- Source/WebCore/page/Page.h: Updated for the above.
- Source/WebCore/platform/ScrollableArea.h:
(WebCore::ScrollableArea::isPDFPlugin const): Deleted.
- Source/WebCore/platform/Widget.h:
(WebCore::Widget::isPluginView const): Deleted.
- Source/WebCore/plugins/PluginViewBase.h: Removed storageBlockingStateChanged,
supportsKeyboardFocus, audioHardwareActivity, setJavaScriptPaused,
and bindingInstance. Made isPluginViewBase private and final.
- Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::pluginIsBelowSizeThreshold): Deleted.
- Source/WebCore/testing/Internals.cpp: Updated for the above.
- Source/WebCore/testing/Internals.idl: Ditto. No test was using this.
Canonical link: https://commits.webkit.org/250781@main
- 7:55 PM Changeset in webkit [294525] by
-
- 3 edits in trunk/Source/ThirdParty/ANGLE/Configurations
[ANGLE] Production builds don't need to include Metal debug info
https://bugs.webkit.org/show_bug.cgi?id=240696
<rdar://problem/93580049>
Reviewed by Tim Horton.
Metal debug info can be generated in engineering builds, but production builds don't need it.
- Source/ThirdParty/ANGLE/Configurations/AngleMetalLib.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig:
Canonical link: https://commits.webkit.org/250780@main
- 7:32 PM Changeset in webkit [294524] by
-
- 1 edit in trunk/Tools/Scripts/hooks/prepare-commit-msg
prepare-commit-msg should be no-op with --no-edit
https://bugs.webkit.org/show_bug.cgi?id=240689
Reviewed by Jonathan Bedard.
- Tools/Scripts/hooks/prepare-commit-msg:
Canonical link: https://commits.webkit.org/250779@main
- 7:14 PM Changeset in webkit [294523] by
-
- 36 edits1 copy4 adds in trunk
Release assert in Document::updateLayout() via HTMLTextAreaElement::childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=224471
Reviewed by Ryosuke Niwa.
This patch is based on a set of patches made by Sergio Villar Senin
and Gabriel Nava Marino.
Executing some editing commands in a text area might force the recomputation of things
like caret or the visible selection position and extent. Under some circumstances (like
when the text area has no content and children) we might end up trying to update layout
when it is not safe as a side effect of updating the caret.
In order to fix that, we can switch to a model in which we update the selection asynchronously
in the case of having a non-user triggered change. That way we don't do it inside
a restricted layout scope.
The App Highlight restoration code had to be tuned as well (when restoring and scrolling to reveal
a Quick Note on iOS MacOS). It uses TemporarySelectionChange to select and scroll to reveal the highlight
range; the code assumed that this scrolling happens synchronously, since it reverts the selection to
the original range at the end ofAppHighlightStorage::attemptToRestoreHighlightAndScrollwhen the
TemporarySelectionChange falls out of scope. That is however no longer the case. Actually no scrolling
happened after this patch because we end up only scheduling the appearance update timer before setting
the selection back to the original state withSelectionRevealMode::DoNotReveal. Since this only happens
when the user interacts in the Notes app, it seems sensible to consider it as a user triggered event.
Layout Tests
Moved some tests out of the text-based-repaint.js model because selection is now updated
and revealed asynchronously in the case of non-user triggered changes. The problem is that
by the time the repaint rects are queried the update has not happened yet. That's why
the tests were modified so that we wait until the repaint happens.
Same situation for other tests that do not involve repaint rects but trigger accesibility
tree updates. We must ensure that we let the notification be thrown before checking whether or
not has been emited. As it's done asynchronously we must let the main thread run before checking.
Last but not least, some of the tests are using setTimeout() instead of requestAnimationFrame()
because the results with the latter were not as reliable under stress/debug conditions.
- Source/WebCore/Modules/highlight/AppHighlightStorage.cpp:
(WebCore::AppHighlightStorage::attemptToRestoreHighlightAndScroll):
- Source/WebCore/editing/Editor.cpp:
(WebCore::TemporarySelectionChange::setSelection):
- Source/WebCore/editing/Editor.h:
- Source/WebCore/editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::updateSelectionAppearanceNow):
(WebCore::FrameSelection::absoluteCaretBounds):
(WebCore::FrameSelection::setCaretVisibility):
(WebCore::FrameSelection::selectionBounds):
(WebCore::FrameSelection::revealSelection):
(WebCore::updateSelectionByUpdatingLayoutOrStyle): Deleted.
(WebCore::FrameSelection::selectionBounds const): Deleted.
- Source/WebCore/editing/FrameSelection.h:
- Source/WebCore/page/EventHandler.cpp:
(WebCore::setSelectionIfNeeded):
- Source/WebCore/page/Page.cpp:
(WebCore::Page::doAfterUpdateRendering):
- LayoutTests/accessibility/mac/selection-boundary-userinfo.html:
- LayoutTests/accessibility/mac/selection-change-userinfo.html:
- LayoutTests/accessibility/mac/selection-value-changes-for-aria-textbox.html:
- LayoutTests/editing/selection-with-absolute-positioned-empty-content.html:
- LayoutTests/fast/forms/textarea-scrolled-endline-caret.html:
- LayoutTests/fast/repaint/selection-gap-absolute-child-expected.txt:
- LayoutTests/fast/repaint/selection-gap-absolute-child.html:
- LayoutTests/fast/repaint/selection-gap-fixed-child.html:
- LayoutTests/fast/repaint/selection-gap-flipped-absolute-child-expected.txt:
- LayoutTests/fast/repaint/selection-gap-flipped-absolute-child.html:
- LayoutTests/fast/repaint/selection-gap-transformed-absolute-child-expected.txt:
- LayoutTests/fast/repaint/selection-gap-transformed-absolute-child.html:
- LayoutTests/fast/repaint/selection-gap-transformed-fixed-child-expected.txt:
- LayoutTests/fast/repaint/selection-gap-transformed-fixed-child.html:
- LayoutTests/fast/repaint/selection-paint-invalidation-expected.txt:
- LayoutTests/fast/repaint/selection-ruby-rl-expected.txt:
- LayoutTests/fast/repaint/selection-ruby-rl.html:
- LayoutTests/fast/repaint/text-selection-overflow-hidden-expected.txt:
- LayoutTests/fast/repaint/text-selection-overflow-hidden.html:
- LayoutTests/fast/text/incorrect-deselection-across-multiple-elements.html:
- LayoutTests/platform/gtk/TestExpectations:
- LayoutTests/platform/gtk/fast/repaint/selection-ruby-rl-expected.txt: Copied from LayoutTests/fast/repaint/selection-ruby-rl-expected.txt.
- LayoutTests/platform/gtk/fast/repaint/text-selection-overflow-hidden-expected.txt:
- LayoutTests/platform/mac-wk1/TestExpectations:
- LayoutTests/platform/mac-wk1/accessibility/mac/focus-setting-selection-syncronizing-not-clearing-expected.txt: Added.
- LayoutTests/platform/mac-wk1/fast/repaint/4776765-expected.txt: Added.
- LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-margin-005-expected.txt:
- LayoutTests/platform/mac/TestExpectations:
- LayoutTests/platform/win/fast/repaint/4776765-expected.txt: Added.
- LayoutTests/platform/win/fast/repaint/selection-ruby-rl-expected.txt:
- LayoutTests/platform/win/fast/repaint/text-selection-overflow-hidden-expected.txt:
Canonical link: https://commits.webkit.org/250778@main
- 7:05 PM Changeset in webkit [294522] by
-
- 1 copy in tags/WebKit-7614.1.14.0.7
Tag WebKit-7614.1.14.0.7.
- 6:26 PM Changeset in webkit [294521] by
-
- 5 edits in trunk/Tools/Scripts/webkitpy
[webkit-patch] Fix revert workflow
https://bugs.webkit.org/show_bug.cgi?id=240684
<rdar://93602151>
Reviewed by Dewei Zhu.
- Tools/Scripts/webkitpy/common/checkout/checkout.py:
(_changelog_data_for_revision): Use git commit message instead of ChangeLog.
(changelog_entries_for_revision): Deleted.
- Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py:
(CheckoutTest.test_changelog_entries_for_revision): Deleted.
(CheckoutTest.test_commit_info_for_revision): Deleted.
(CheckoutTest.test_bug_id_for_revision): Deleted.
(CheckoutTest.test_suggested_reviewers): Deleted.
- Tools/Scripts/webkitpy/common/config/committers.py:
(Contributor.email): Match webkitscmpy's API.
- Tools/Scripts/webkitpy/tool/commands/download.py:
(AbstractRevertPrepCommand._prepare_state): Use email instead of bugzilla_email.
- Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
(PrepareChangeLogForRevert.run): Replace with a
git commit -a -m.
Canonical link: https://commits.webkit.org/250777@main
- 6:22 PM Changeset in webkit [294520] by
-
- 6 edits in trunk
Implement contain flag for ray() in offset path
https://bugs.webkit.org/show_bug.cgi?id=240259
<rdar://93374029>
Reviewed by Simon Fraser.
Implement contain flag for ray(). Contains purpose is to have the entire box
being animated be contained within the path. "Contained within the path" is
defined as having the box remain within a circle with the radius of the path
length and positioned at the offset anchor. This solution is adapted from the
repository of the spec writer: https://github.com/ewilligers/petrogale-purpureicollis.
The way this solution works is that you construct a coordinate system with the origin
being the offset anchor. You then calculate the position of each vertex of the box.
Then, rotate the vertices based on the angles difference from the x-axis. Next, using
the circle equation, we want to find an offset such that (x + offset)2 + y2 = r2.
This results in a lower and upper bound for offset: -x - sqrt(r2 - y2) <= offset <=
-x + sqrt(r2 + y2). Finally we choose the minimal value of these upper and lower
bounds to get the final clamped offset.
This patch currently doesn't take into account if it is not possible to fit the box
within the path, as this will be completed in a seperate patch. Currently, test 4 is
failing due to rounding error, and test 5 is failing due to the unimplemented part.
- Source/WebCore/platform/graphics/GeometryUtilities.cpp:
(WebCore::toRelatedAcuteAngle):
(WebCore::distanceOfPointToSidesOfRect):
(WebCore::verticesForBox):
- Source/WebCore/platform/graphics/GeometryUtilities.h:
- Source/WebCore/rendering/PathOperation.cpp:
(WebCore::RayPathOperation::lengthForContainPath const):
(WebCore::RayPathOperation::pathForReferenceRect const):
- Source/WebCore/rendering/PathOperation.h:
- Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::getPathFromPathOperation):
(WebCore::RenderStyle::applyMotionPathTransform const):
- LayoutTests/TestExpectations:
Canonical link: https://commits.webkit.org/250776@main
- 6:17 PM Changeset in webkit [294519] by
-
- 47 edits in trunk/Source
Revert "[Xcode] Prevent STP and other self-contained builds from overwriting content in the macOS SDK"
This reverts commit ae2e942111f9f4f1a80c749a3f51ab0ae83b013a.
Seeing some new failures on internal post-commit builders.
Canonical link: https://commits.webkit.org/250775@main
- 6:15 PM Changeset in webkit [294518] by
-
- 1 edit in trunk/Source/WebCore/css/typedom/numeric/CSSNumericType.cpp
Unreviewed, non-unified build fixes after 250765@main
- 5:59 PM Changeset in webkit [294517] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp
Fix boolean operation in WTF/BitMap test.
https://bugs.webkit.org/show_bug.cgi?id=240668
Reviewed by Adrian Perez de Castro.
Clang 14 starts complaining about using logical operators to boolean:
`
webkit/Tools/TestWebKitAPI/Tests/WTF/Bitmap.cpp:1172:32: warning: use of bitwise '|' with boolean operands [-Wbitwise-instead-of-logical]
EXPECT_EQ(temp.get(i), bitmap1.get(i) | bitmap2.get(i));
`
Canonical link: https://commits.webkit.org/250773@main
- 5:04 PM Changeset in webkit [294516] by
-
- 1 copy in tags/WebKit-7614.1.14.1.7
Tag WebKit-7614.1.14.1.7.
- 5:04 PM Changeset in webkit [294515] by
-
- 3 edits in trunk
Mail: dragged in attachments are shown as rich icons in compose but are received as generic icons
https://bugs.webkit.org/show_bug.cgi?id=240679
<rdar://93513798>
Reviewed by Wenson Hsieh.
Render the thumbnail for iWork files when the file wrapper is set for
attachments that are not added via the pasteboard.
Confirmed this also fixes the issue for Notes.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(testiWorkAttachmentFileURL):
(testiWorkAttachmentData):
(-[AttachmentUIDelegate _webView:didInsertAttachment:withSource:]):
(TestWebKitAPI::TEST):
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateAttachmentAttributes):
- Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::shouldDrawIcon):
(WebCore::paintAttachmentIcon):
There's a small delay while we wait for the file wrapper for the
attachment to be set so we can retrieve the thumbnail. In order to avoid a
flicker from the generic icon to the thumbnail, we should avoid painting
iWork file icons until the thumbnail is retrieved.
Canonical link: https://commits.webkit.org/250772@main
- 5:00 PM Changeset in webkit [294514] by
-
- 2 edits in trunk/Source/WebCore/editing
Avoid injected bundle delegate calls when text fields are focused and blurred without user interaction
https://bugs.webkit.org/show_bug.cgi?id=240614
Reviewed by Chris Dumez.
Add a mechanism to throttle calls to injected bundle form client via
textFieldDidBeginEditing, in
the case where the focused element is in a subframe that has never handled an editing command or
user interaction. This yields a small win on Speedometer 2, on M1 MacBookPro:
`
| subtest | ms | ms | b / a | pValue |
| Angular2-TypeScript-TodoMVC |30.651667 |28.456667 |0.928389 | 0.000000 (significant) |
| AngularJS-TodoMVC |109.733333 |111.623333 |1.017224 | 0.000000 (significant) |
| BackboneJS-TodoMVC |31.371667 |33.988333 |1.083409 | 0.000000 (significant) |
| Elm-TodoMVC |96.818333 |96.893333 |1.000775 | 0.760078 |
| EmberJS-Debug-TodoMVC |292.241667 |292.628333 |1.001323 | 0.530967 |
| EmberJS-TodoMVC |99.671667 |98.963333 |0.992893 | 0.040683 |
| Flight-TodoMVC |43.815000 |50.915000 |1.162045 | 0.000000 (significant) |
| Inferno-TodoMVC |46.633333 |44.911667 |0.963081 | 0.000000 (significant) |
| Preact-TodoMVC |11.636667 |11.673333 |1.003151 | 0.862258 |
| React-Redux-TodoMVC |121.411667 |120.096667 |0.989169 | 0.000000 (significant) |
| React-TodoMVC |69.908333 |69.885000 |0.999666 | 0.944581 |
| Vanilla-ES2015-Babel-Webpack-TodoMVC |47.750000 |46.223333 |0.968028 | 0.000000 (significant) |
| Vanilla-ES2015-TodoMVC |48.721667 |48.323333 |0.991824 | 0.001202 (significant) |
| VanillaJS-TodoMVC |40.218333 |38.231667 |0.950603 | 0.000000 (significant) |
| VueJS-TodoMVC |18.420000 |16.793333 |0.911690 | 0.000000 (significant) |
| jQuery-TodoMVC |188.831667 |186.908333 |0.989815 | 0.000005 (significant) |
a mean = 343.48012
b mean = 344.99902
pValue = 0.0027314347
(Bigger means are better.)
1.004 times better
Results ARE significant
`
See below for more details.
- Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::Editor):
(WebCore::Editor::stopTextFieldDidBeginEditingTimer):
Stop the
textFieldDidBeginEditingtimer if needed, and return true if and only if it was active.
(WebCore::Editor::textFieldDidBeginEditingTimerFired):
Dispatch the deferred EditorClient call using the currently focused element.
(WebCore::Editor::textFieldDidBeginEditing):
If we're inside of a subframe that has never handled user interaction or editing, then don't eagerly
notify the injected bundle about the newly focused text field; instead, schedule a newly added timer
(m_textFieldDidBeginEditingTimer) to perform this call after a short delay.
(WebCore::Editor::textFieldDidEndEditing):
If editing ends (i.e. the text field is blurred) while the
textFieldDidBeginEditingtimer is still
scheduled, then simply elide this call totextFieldDidBeginEditingandtextFieldDidEndEditing
altogether. This prevents us from repeatedly calling into the injected bundle if a page frequently
programmatically focuses and blurs text fields.
(WebCore::Editor::textDidChangeInTextField):
(WebCore::Editor::doTextFieldCommandFromEvent):
(WebCore::Editor::textWillBeDeletedInTextField):
(WebCore::Editor::textDidChangeInTextArea):
If any of these other injected bundle form client hooks are invoked while there is a scheduled
textFieldDidBeginEditingtimer, then stop the timer and immediately inform the injected bundle
client about the focused text field.
(WebCore::Editor::isInSubframeWithoutUserInteraction const):
(WebCore::Editor::respondToChangedSelection):
Use the new helper function above.
- Source/WebCore/editing/Editor.h:
Canonical link: https://commits.webkit.org/250771@main
- 4:46 PM Changeset in webkit [294513] by
-
- 1 edit in trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py
Handle cases where origin/HEAD doesn't exist in git-webkit
https://bugs.webkit.org/show_bug.cgi?id=240693
Reviewed by Jonathan Bedard.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.default_branch):
This makes several changes to default_branch:
- We attempt origin/HEAD, origin/main, and origin/master before trying to guess based on all branches.
- When guessing based on all branches, prefer main over master.
Additionally, this changes the searching to use
--symbolic-full-ref,
as we only ever want refs to be returned, and this takes away the
guesswork parsing.
Canonical link: https://commits.webkit.org/250770@main
- 4:42 PM Changeset in webkit [294512] by
-
- 4 edits in trunk
Web Inspector: Getting style data via WebCore::InspectorCSSAgent::getMatchedStylesForNode for a detached node crashes
https://bugs.webkit.org/show_bug.cgi?id=240608
rdar://93473674
Reviewed by Devin Rousso.
Added test case to inspector/css/node-styles-refreshed.html
Previously it was possible under at least two different circumstances that
WebCore::InspectorCSSAgent::getMatchedStylesForNodecould be called with the NodeId of a detached node, which means
thatcomputedStylefor that Node will benullptr, and calls toStyle::Scope::forNodewill fail.
The first failure state is timing based. If the Inspector frontend makes a request for updated styles for a node, the
node may already have been detached by some other means (webpage JS, for example). In this case by the time
getMatchedStylesForNodeis invoked thecomputedStyleis no longer available.
The second failure state is easier to get into. In a DOM tree with elements A, B, and C, each a child of the
previous such that A is the parent of B and B is the parent of C, imagine C is the selected DOM node. Now if
we right click and delete A from the DOM tree, we will have removed all three elements from the tree (both the
frontend representation as well as the actual tree in the backend). Previously C remained the selected node in the
tree, which means that we continue to show the Styles sidebar panel, where the user could then attempt to edit the style
of the node. These style changes trigger the need to refresh the frontend's style information, at which point we will
callgetMatchedStylesForNodewith a detached node id.
The fix to the underlying problem is to check in the backend that a node is actually attached before determining its
style information. Additionally, we should always update the selection of a TreeOutline when the current selection is
part of the subtree being removed from the tree. This prevents the user being able to easily get into the state in the
first place as well as prevents folks from getting confused about what the open sidebars are showing information for,
since visually no node _appears_ selected.
- Source/WebCore/inspector/agents/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
- Guard the functions that will eventually use
computedStyleorStyle::Scope::forNode, both of which only work for
"connected" (in Web Inspector parlance "attached") nodes. Note there are a few other uses in our code where
computedStyleis used without this check, but we do explicitly check the result of computed styles in those cases,
which also works sincecomputedStylereturns early if the node is not connected.
(WebCore::InspectorCSSAgent::buildObjectForRule):
- Add an assertion that we never call buildObjectForRule with a disconnected Element.
- Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype.removeChildAtIndex):
- Fix selection updating to account for the fact the selected node may be part of the descendants tree of the removed
item, in which case we would still want to update the selection to something else.
- LayoutTests/inspector/css/node-styles-refreshed-expected.txt:
- LayoutTests/inspector/css/node-styles-refreshed.html:
- Add test case to try getting styles of a detached node, and update other test cases with a new helper function instead
of relying on a "global"
nodeStyles.
Canonical link: https://commits.webkit.org/250769@main
- 4:00 PM Changeset in webkit [294511] by
-
- 1 edit in trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
Add sys call MSC_iokit_user_client_trap to the WebContent process' sandbox
https://bugs.webkit.org/show_bug.cgi?id=240685
<rdar://93600722>
Reviewed by Chris Dumez.
- Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:
Canonical link: https://commits.webkit.org/250768@main
- 3:47 PM Changeset in webkit [294510] by
-
- 5 edits in trunk/Tools/Scripts/libraries/webkitscmpy
[git-webkit] Use --date=unix in log commands
https://bugs.webkit.org/show_bug.cgi?id=240537
<rdar://93464544>
Reviewed by Stephanie Lewis.
Override any local configuration for git log's date format,
use a simpler date format.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.Cache.populate): Use --date=unix.
(Git.commit): Ditto.
(Git._args_from_content): Parse --date=unix.
(Git.commits): Use --date=unix.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(TestGit.test_log):
Canonical link: https://commits.webkit.org/250767@main
- 3:43 PM Changeset in webkit [294509] by
-
- 1 edit in trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp
[Curl] Suppress warning of unused enum value in switch statement.
https://bugs.webkit.org/show_bug.cgi?id=240672
Reviewed by Fujii Hironori.
Just after the request object creation, the state is WaitingForStart. It is better
the code explicitly takes care of this fact. Also moving the assignment to the state
inside the switch statement denotes the state is changing to the response of previous
state.
No new tests. Covered by existing tests.
- platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::start):
Canonical link: https://commits.webkit.org/250766@main
- 3:37 PM Changeset in webkit [294508] by
-
- 9 edits1 add in trunk
Implement unit checks of CSSNumericValue.{min,max}
https://bugs.webkit.org/show_bug.cgi?id=240559
Reviewed by Chris Dumez.
This is part of an off-by-default experimental feature.
This is in the spec but not implemented in Chrome yet.
Covered by an addition to WPT tests at https://github.com/web-platform-tests/wpt/pull/34103
- Source/WebCore/Sources.txt:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Source/WebCore/css/typedom/CSSNumericValue.cpp:
- Source/WebCore/css/typedom/CSSNumericValue.h:
- Source/WebCore/css/typedom/numeric/CSSMathProduct.cpp:
- Source/WebCore/css/typedom/numeric/CSSMathSum.cpp:
- Source/WebCore/css/typedom/numeric/CSSNumericType.cpp:
- Source/WebCore/css/typedom/numeric/CSSNumericType.h:
Canonical link: https://commits.webkit.org/250765@main
- 3:08 PM Changeset in webkit [294507] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations
[ macOS Debug wk2 iOS ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=240670
<rdar://93589033>
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250764@main
- 2:49 PM Changeset in webkit [294506] by
-
- 1 edit in trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js
Web Inspector: Computed Panel: Assertion Failed: Cannot remove view which isn't a subview. ComputedStyleSection
https://bugs.webkit.org/show_bug.cgi?id=240644
Reviewed by Patrick Angle.
The root cause for this failed assertion is an accumulation of orphaned
WI.ComputedStyleSectionview instances in
WI.ComputedStyleDetailsPanel._detailsSectionByStyleSectionMap.
When
WI.ComputedStyleDetailsPanel.layout()is called to reflect the latest selected node's variables, the previousWI.ComputedStyleSectionview instance for ungrouped
variables is accidentally kept around. When attempting to remove this view on the nextlayout()run, this orphaned instance has no
host node that belongs to the parent view so the assertion fails. The issue gets progressively worse on eachlayout()run by accumulating more orphans.
- Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js: (WI.ComputedStyleDetailsPanel.prototype.layout):
Canonical link: https://commits.webkit.org/250763@main
- 2:44 PM Changeset in webkit [294505] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
media/modern-media-controls tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=231187
<rdar://problem/83846919>
Unreviewed.
The tests in
media/modern-media-controls/overflow-supportandmedia/modern-media-controls/tracks-support
require"touch*"(really"pointer*") events on iOS, so skip for OpenSource and unskip internally.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250762@main
- 1:57 PM Changeset in webkit [294504] by
-
- 9 edits1 move1 add in trunk
[WPE][GTK] Improve dependency tracking of PDF.js files (and other GResources)
https://bugs.webkit.org/show_bug.cgi?id=240535
Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-19
Reviewed by Adrian Perez de Castro.
This commit does two things. First, for each use of
glib-compile-resources, it adds the --dependency-file argument in order
to make the build command depend on the files included in the GResource
manifest, to ensure the resource is automatically recompiled whenever
any of its source files change. Second, for PDF.js only, it replaces the
GLOB_RECURSE command with a list of source files. The
generate-pdfjs-gresource-manifest.py script is adapted to create CMake
file lists in addition to GResource manifests, and renamed from
-gresource-manifest.py to -resource-manifest.py. The web inspector
GResource would benefit from similar work, but that will be a problem
for another day.
- Tools/TestWebKitAPI/glib/CMakeLists.txt:
- Tools/glib/generate-pdfjs-resource-manifest.py: Renamed from Tools/glib/generate-pdfjs-gresource-manifest.py.
(get_filenames):
(get_filenames.resource_name):
(is_compressible):
(write_cmake_file):
(write_gresource_manifest):
- Source/ThirdParty/pdfjs/PdfJSFiles.cmake: Added.
- Source/ThirdParty/pdfjs/README.webkit:
- Source/WebKit/InspectorGResources.cmake:
- Source/WebKit/PdfJSGResources.cmake:
- Source/WebKit/PlatformGTK.cmake:
- Source/WebKit/PlatformWPE.cmake:
- CMakeLists.txt:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsWPE.cmake:
Canonical link: https://commits.webkit.org/250761@main
- 12:57 PM Changeset in webkit [294503] by
-
- 1 edit in trunk/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
Changing text color and removing line-clamp on hover causes text to disappear permanently
https://bugs.webkit.org/show_bug.cgi?id=240410
Reviewed by Darin Adler.
Address post-landing review comment.
- Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::styleWillChange):
Canonical link: https://commits.webkit.org/250760@main
- 12:54 PM Changeset in webkit [294502] by
-
- 9 edits in branches/safari-7614.1.14.0-branch/Source
Versioning.
WebKit-7614.1.14.0.7
- 12:53 PM Changeset in webkit [294501] by
-
- 1 edit in trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py
git webkit setup pauses between questions to install modules
https://bugs.webkit.org/show_bug.cgi?id=240487
<rdar://93522052>
Reviewed by Alexey Proskuryakov.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.main): Pre-install jinja.
Canonical link: https://commits.webkit.org/250759@main
- 12:53 PM Changeset in webkit [294500] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.7
- 12:22 PM Changeset in webkit [294499] by
-
- 1 edit in trunk/Source/WebCore/accessibility/AXLogger.cpp
AX: Logging outerHTML in streamAXCoreObject is not truncated
https://bugs.webkit.org/show_bug.cgi?id=240523
<rdar://93429407>
Reviewed by Chris Fleizach.
outerHTML can be a very, very big string, and we don't truncate it at all.
This can cause debug builds to perform even worse than they already do, and
is almost always too much noise in the logs.
In this change, we truncate outerHTML to 150 characters.
- Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::streamAXCoreObject):
Canonical link: https://commits.webkit.org/250758@main
- 12:18 PM Changeset in webkit [294498] by
-
- 6 edits in trunk/Source/WebCore/html/track
TextTrackCue should get its document for its ActiveDOMObject base class
https://bugs.webkit.org/show_bug.cgi?id=240660
<rdar://93512736>
Reviewed by Eric Carlson.
TextTrackCue should get its document for its ActiveDOMObject base class instead
of requiring an extra data member to store it.
- Source/WebCore/html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::scriptExecutionContext const):
(WebCore::TextTrackCue::document const):
(WebCore::TextTrackCue::getCueAsHTML):
(WebCore::TextTrackCue::rebuildDisplayTree):
- Source/WebCore/html/track/TextTrackCue.h:
(WebCore::TextTrackCue::ownerDocument): Deleted.
- Source/WebCore/html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::createDisplayTree):
(WebCore::TextTrackCueGeneric::setFontSize):
- Source/WebCore/html/track/TextTrackCueGeneric.h:
- Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCue::VTTCue):
(WebCore::VTTCue::initialize):
(WebCore::VTTCue::createDisplayTree):
(WebCore::VTTCue::displayTreeInternal):
(WebCore::VTTCue::createWebVTTNodeTree):
(WebCore::VTTCue::getCueAsHTML):
(WebCore::VTTCue::createCueRenderingTree):
(WebCore::VTTCue::getDisplayTree):
(WebCore::VTTCue::removeDisplayTree):
- Source/WebCore/html/track/VTTCue.h:
Canonical link: https://commits.webkit.org/250757@main
- 11:42 AM Changeset in webkit [294497] by
-
- 1 edit in trunk/Source/WebCore/animation/KeyframeEffect.cpp
Need to keep the document alive in KeyframeEffect::processKeyframes()
https://bugs.webkit.org/show_bug.cgi?id=240677
<rdar://93513759>
Reviewed by Saam Barati.
Since the Document is used throughout KeyframeEffect::processKeyframes and it's provided
as a simple reference, we must ensure we keep it alive with a Ref since JS code in a custom
iterator for the keyframes object could cause it to be torn down.
- Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::processKeyframes):
Canonical link: https://commits.webkit.org/250756@main
- 11:32 AM Changeset in webkit [294496] by
-
- 47 edits in trunk/Source
[Xcode] Prevent STP and other self-contained builds from overwriting content in the macOS SDK
https://bugs.webkit.org/show_bug.cgi?id=240408
Reviewed by Alexey Proskuryakov.
When building with WK_OVERRIDE_FRAMEWORKS_DIR, we assume that WebKit is
being built as part of a self-contained application, e.g. Safari
Technology Preview. This means that most content is installed to the
override directory, instead of the normal /System/Library/Frameworks
directory.
However, static library content (e.g. headers and archives
for bmalloc, webrtc, WTF) is _not_ installed to the override directory,
as it is not needed at runtime. It was being installed to the default
/usr/local prefix, where it would merge with and overwrite whatever
WebKit content was already present.
To prevent overwrites and other sorts of conflict with the
system-provided WebKit, introduce WK_LIBRARY_HEADERS_FOLDER_PATH and
WK_LIBRARY_INSTALL_PATH, which expand to /usr/local/include/safari-sdk
and /usr/local/lib/safari-sdk respectively when building in this mode.
Static library headers and archives are built to these locations, where
they're still in the expected SDK location, but won't clobber system
WebKit.
- Source/bmalloc/Configurations/Base.xcconfig:
- Source/bmalloc/Configurations/bmalloc.xcconfig:
- Source/bmalloc/Configurations/mbmalloc.xcconfig:
- Source/JavaScriptCore/Configurations/Base.xcconfig:
- Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
- Source/JavaScriptCore/DerivedSources.make:
- Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
- Source/JavaScriptCore/Scripts/generate-unified-sources.sh:
- Source/JavaScriptCore/offlineasm/config.rb:
- Source/JavaScriptCore/offlineasm/parser.rb:
- Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/AngleMetalLib.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/boringssl.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/yasm.xcconfig:
- Source/WebCore/PAL/Configurations/Base.xcconfig:
- Source/WebCore/PAL/Configurations/PAL.xcconfig:
- Source/WebGPU/Configurations/Base.xcconfig:
- Source/WebGPU/Configurations/WGSL.xcconfig:
- Source/WebGPU/Configurations/WGSLUnitTests.xcconfig:
- Source/WebGPU/Configurations/WebGPU.xcconfig:
- Source/WebKit/Configurations/Base.xcconfig:
- Source/WebKit/Configurations/BaseTarget.xcconfig:
- Source/WebKit/Configurations/SandboxProfiles.xcconfig:
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Source/WebKitLegacy/scripts/generate-unified-sources.sh:
- Source/WebKitLegacy/mac/Configurations/Base.xcconfig:
- Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:
- Source/WTF/Configurations/Base.xcconfig:
- Source/WTF/Configurations/WTF.xcconfig:
- Source/WTF/Configurations/icu.xcconfig:
- Source/WebCore/Configurations/Base.xcconfig:
- Source/WebCore/Configurations/WebCore.xcconfig:
- Source/WebCore/Configurations/WebCoreTestSupport.xcconfig:
- Source/WebCore/DerivedSources.make:
- Source/WebCore/Scripts/generate-unified-sources.sh:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/250755@main
- 11:18 AM Changeset in webkit [294495] by
-
- 5 edits4 deletes in trunk/Source/WebKit
Delete WKHoverPlatter
https://bugs.webkit.org/show_bug.cgi?id=240623
Reviewed by Wenson Hsieh.
- Source/WebKit/SourcesCocoa.txt:
- Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _allowsDoubleTapGestures]):
- Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _createAndConfigureHighlightLongPressGestureRecognizer]):
(-[WKContentView setUpInteraction]):
(-[WKContentView cleanUpInteraction]):
(-[WKContentView _locationForGesture:]):
(-[WKContentView _startPointForGesture:]):
(-[WKContentView _longPressRecognized:]):
(-[WKContentView _singleTapIdentified:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _doubleTapRecognized:]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _shouldUseContextMenus]):
(-[WKContentView setUpDragAndDropInteractions]):
(-[WKContentView mouseGestureRecognizerChanged:]):
(-[WKContentView positionInformationForHoverPlatter:withRequest:completionHandler:]): Deleted.
(-[WKContentView interactionRegionsForHoverPlatter:inRect:completionHandler:]): Deleted.
- Source/WebKit/UIProcess/ios/WKHoverPlatter.h: Removed.
- Source/WebKit/UIProcess/ios/WKHoverPlatter.mm: Removed.
- Source/WebKit/UIProcess/ios/WKHoverPlatterParameters.h: Removed.
- Source/WebKit/UIProcess/ios/WKHoverPlatterParameters.mm: Removed.
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/250754@main
- 11:05 AM Changeset in webkit [294494] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
[ iOS macOS Debug wk2 ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=240670
<rdar://93589033>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250753@main
- 10:50 AM Changeset in webkit [294493] by
-
- 2 edits in trunk/Source/JavaScriptCore/runtime
Build fix for Release ASAN builds.
https://bugs.webkit.org/show_bug.cgi?id=240667
Reviewed by Yusuke Suzuki.
JSC::ptrTagName() should also be defined for CPU(ARM64E) when ENABLE(DISASSEMBLER)
is true because it is used to support disassembly now.
- Source/JavaScriptCore/runtime/JSCPtrTag.cpp:
- Source/JavaScriptCore/runtime/JSCPtrTag.h:
Canonical link: https://commits.webkit.org/250752@main
- 10:40 AM Changeset in webkit [294492] by
-
- 3 edits in trunk/Tools/TestWebKitAPI
Begin using coroutines in testing code
https://bugs.webkit.org/show_bug.cgi?id=235730
Reviewed by Darin Adler.
co_await is nicer than nested lambdas.
This begins WebKit's use of C++ coroutines in a small, incomplete, and low-risk way by using it with test code.
Canonical link: https://commits.webkit.org/250751@main
- 10:13 AM Changeset in webkit [294491] by
-
- 4 edits in trunk/Tools/Scripts/libraries
git-webkit setup: Fix various pitfalls with credentials input
https://bugs.webkit.org/show_bug.cgi?id=240574
Reviewed by Jonathan Bedard.
Yesterday I tried to run
git webkit setup.
To put it mildly, it wasn't a smooth ride. I ended up having to debug the
tooling for hours just to be able to get it running.
This patch fixes several issues I found during the process, so that the next
unlucky person doesn't have to go through this again.
- Whenever a request failed, the response from the server was not shown in
anyway, instead printing an unhelpful generic message. This patch adds code to
write to the screen the responses obtained from the GitHub API, so that the
next person having problems with it doesn't need to add debugging code to know
what is wrong.
- When copying and pasting tokens from the browser it's very easy to
accidentally grab some leading or trailing whitespace. This is especially easy
to miss for the blind terminal key prompt. This patch adds code to trim these
fields. This is generally good UX practice since leading and trailing spaces
are virtually always accidental. [1]
- The validation code for GitHub username and token was not run under `git
webkit setup`. Looking at the code it's clear the intention was for that
validation to be done to check (1) a plain GitHub username is used instead of
an email address associated to that account and (2) that a test log-in
succeeds. But because the credentials function is called in many places, the
first instance that actually gets called happens to not set validate=True in
the arguments.
Validating passwords that have just been input for the first time should not
be an optional feature that is disabled by default. Otherwise any mistake in
the credentials input can cause cryptic errors and the user is left on their
own to figure out what is going on, and eventually, how to manually interact
with the keychain to remove or edit the bogus username and/or token. This patch
makes changes so that validation is made whenever the user is prompt for
username and token, no matter in what codepath this becomes necessary.
[1] https://tonyshowoff.com/articles/should-you-trim-passwords/
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
(Tracker.credentials):
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
- Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py:
(credentials):
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.github):
Canonical link: https://commits.webkit.org/250750@main
- 10:10 AM Changeset in webkit [294490] by
-
- 1 edit in trunk/metadata/contributors.json
Add Razvan Caliman's GitHub username to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240663
Reviewed by Jonathan Bedard.
Adding my GitHub username to contributors.json
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250749@main
- 10:07 AM Changeset in webkit [294489] by
-
- 5 edits in trunk/Tools/Scripts/libraries/webkitscmpy
git webkit setup ignores configured editor (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=240529
<rdar://93521972>
Reviewed by Alexey Proskuryakov.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
(Git): Allow whitespace in config keys.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.git): Pull editor from environment variables, if available.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:
Canonical link: https://commits.webkit.org/250748@main
- 9:43 AM Changeset in webkit [294488] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
[ iOS Debug ] fast/text/isolate-ignore.html is a consistent crash
https://bugs.webkit.org/show_bug.cgi?id=240659
<rdar://93582407>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250747@main
- 9:28 AM Changeset in webkit [294487] by
-
- 2 edits4 adds in trunk
importedScript service worker loads should not have ServiceWorker headers
https://bugs.webkit.org/show_bug.cgi?id=240571
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-19
Reviewed by Chris Dumez.
In case of update, we were reloading imported scripts with ServiceWorker header.
Prevent this as this is not as per spec.
Test: http/wpt/service-workers/update-with-importScripts.html
- Source/WebCore/workers/service/ServiceWorkerJob.cpp:
(WebCore::scriptResourceRequest):
(WebCore::ServiceWorkerJob::ImportedScriptsLoader::load):
(WebCore::ServiceWorkerJob::fetchScriptWithContext):
- Source/WebCore/workers/service/server/SWServer.cpp:
(WebCore::SWServer::createScriptRequest):
(WebCore::SWServer::startScriptFetch):
- LayoutTests/http/wpt/service-workers/resources/update-with-importScripts-script.py: Added.
(main):
- LayoutTests/http/wpt/service-workers/resources/update-with-importScripts-worker.js: Added.
- LayoutTests/http/wpt/service-workers/update-with-importScripts-expected.txt: Added.
- LayoutTests/http/wpt/service-workers/update-with-importScripts.html: Added.
- LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/250746@main
- 9:06 AM Changeset in webkit [294486] by
-
- 1 edit in trunk/Source/WTF/wtf/PlatformEnable.h
Debug assertion on launch when using an ASAN build on macOS Apple Silicon.
https://bugs.webkit.org/show_bug.cgi?id=240655
Reviewed by Chris Dumez.
Temporarily disabling ENABLE(JIT_OPERATION_DISASSEMBLY) on ASAN builds as a workaround.
- Source/WTF/wtf/PlatformEnable.h:
Canonical link: https://commits.webkit.org/250745@main
- 8:46 AM Changeset in webkit [294485] by
-
- 3 edits2 adds in trunk
REGRESSION (r294291): Nullptr crash with :first-letter
https://bugs.webkit.org/show_bug.cgi?id=240631
<rdar://93495868>
Reviewed by Alan Bujtas.
Test: fast/css/first-letter-multicol-crash.html
- Source/WebCore/rendering/RenderObject.h:
- Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp:
With multicol there can be multiple levels of anonymous ancestors. Search for the
nearest non-anonymous ancestor to find the first-letter style.
(WebCore::styleForFirstLetter):
- LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table-expected.html:
Update expected results. The new results match Chrome behavior.
- LayoutTests/fast/css/first-letter-multicol-crash-expected.txt: Added.
- LayoutTests/fast/css/first-letter-multicol-crash.html: Added.
Canonical link: https://commits.webkit.org/250744@main
- 8:40 AM Changeset in webkit [294484] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
REGRESSION (r294452): [ iOS ] ImageBufferIOSurfaceBackend - nine tests are a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=240654
<rdar://93578166>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250743@main
- 8:36 AM Changeset in webkit [294483] by
-
- 1 edit in trunk/metadata/contributors.json
Link Alicia Boya Garcia's GitHub to contributors.json
Reviewed by Jonathan Bedard.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250742@main
- 8:28 AM Changeset in webkit [294482] by
-
- 1 edit in trunk/Source/WebCore/workers/service/context/SWContextManager.cpp
REGRESSION (250635@main): TestWebKitAPI.PushAPI.pushEventsAndInspectedServiceWorker is failing
https://bugs.webkit.org/show_bug.cgi?id=240612
rdar://problem/93537478
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-19
Reviewed by Chris Dumez.
The test was failing as the injection of internals in a ServiceWorkerGlobalScope might happen after firing a push event.
To prevent this, we now do the injection by posting a task to the service worker right after starting the service worker thread
instead of after the script has been executed.
- Source/WebCore/workers/service/context/SWContextManager.cpp:
Canonical link: https://commits.webkit.org/250741@main
- 8:13 AM Changeset in webkit [294481] by
-
- 2 edits in trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes
Update WPT dom/nodes/aria-element-reflection.tentative.html test
https://bugs.webkit.org/show_bug.cgi?id=240641
Reviewed by Chris Dumez.
Update test and expectations.
The new failure is due to https://webkit.org/b/240563.
- LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/dom/nodes/aria-element-reflection.tentative.html:
Canonical link: https://commits.webkit.org/250740@main
- 7:55 AM Changeset in webkit [294480] by
-
- 3 edits in trunk/Tools/Scripts/libraries/webkitcorepy
git webkit setup ignores configured editor (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=240529
<rdar://93521972>
Reviewed by Alexey Proskuryakov.
- Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
- Tools/Scripts/libraries/webkitcorepy/webkitcorepy/editor.py:
(Editor):
(Editor.bbedit): Added.
(Editor.programs): Add bbedit, VSCode should have higher precedence than default installed
editors.
Canonical link: https://commits.webkit.org/250739@main
- 7:28 AM Changeset in webkit [294479] by
-
- 1 edit in trunk/LayoutTests/TestExpectations
accessibility/visible-character-range-scrolling.html is timing out on debug
https://bugs.webkit.org/show_bug.cgi?id=240643
Unreviewed test gardening.
- LayoutTests/TestExpectations:
Canonical link: https://commits.webkit.org/250738@main
- 6:08 AM Changeset in webkit [294478] by
-
- 6 edits2 adds in trunk
[web-animations] dynamically toggle acceleration of offset animations depending on ability of animations in the effect stack to be accelerated
https://bugs.webkit.org/show_bug.cgi?id=236712
<rdar://89030146>
Reviewed by Dean Jackson.
We implement CSS Motion Path by using it as another input for the matrix computed
in RenderStyle::applyCSSTransform(). This means that if we were to run an accelerated
animation for a transform-related property, we'd clobber a motion path set either
on the underlying style or via another animation on this element.
For transforms and motion paths to co-exist, we opt out of acceleration for all
effects in a stack associated with an element that has a motion set using the
underlying style or containing an effect animating one of the CSS Motion Path
properties.
This is done simply by adding those checks to KeyframeEffect::preventsAcceleration().
But we also need to determine when the underlying style may have changed to either
newly contain a motion path or no longer contain one. To do this, we message from
ElementAnimationRareData::setLastStyleChangeEventStyle() down to all effects on the
associated stack and check in KeyframeEffect::lastStyleChangeEventStyleDidChange()
whether the motion path state changed.
Test: webanimations/accelerated-animations-and-motion-path.html
- Source/WebCore/animation/ElementAnimationRareData.cpp:
(WebCore::ElementAnimationRareData::setLastStyleChangeEventStyle):
- Source/WebCore/animation/ElementAnimationRareData.h:
(WebCore::ElementAnimationRareData::setLastStyleChangeEventStyle): Deleted.
- Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::preventsAcceleration const):
(WebCore::KeyframeEffect::lastStyleChangeEventStyleDidChange):
- Source/WebCore/animation/KeyframeEffect.h:
- Source/WebCore/animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::lastStyleChangeEventStyleDidChange):
- Source/WebCore/animation/KeyframeEffectStack.h:
- LayoutTests/webanimations/accelerated-animations-and-motion-path-expected.txt: Added.
- LayoutTests/webanimations/accelerated-animations-and-motion-path.html: Added.
Canonical link: https://commits.webkit.org/250737@main
- 6:03 AM Changeset in webkit [294477] by
-
- 1 edit in trunk/Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm
Add some logging in AudioSampleDataConverter::updateBufferedAmount
https://bugs.webkit.org/show_bug.cgi?id=240632
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-19
Reviewed by Eric Carlson.
This can help debugging audio related issues like echo cancellation.
No change of behavior.
- Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm:
(WebCore::AudioSampleDataConverter::updateBufferedAmount):
Canonical link: https://commits.webkit.org/250736@main
- 4:42 AM Changeset in webkit [294476] by
-
- 2 edits in trunk
Fix input type email visible value update.
This is an import of Chromium CL at
https://chromium-review.googlesource.com/c/chromium/src/+/3299014
For email type, when the visible value is different from the sanitized value, we need to update it.
https://bugs.webkit.org/show_bug.cgi?id=235522
Reviewed by Chris Dumez.
- LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/email-set-value-expected.txt:
- Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::setValue):
Canonical link: https://commits.webkit.org/250735@main
- 4:37 AM Changeset in webkit [294475] by
-
- 2 edits in trunk
Make sure :active is removed on keyup for radios.
When the radio input is checked, we need to make sure that the active flag is
set to false on keyup in order to to prevent the radio from being stuck in the
active state.
This is an import of Chromium CL at
https://chromium-review.googlesource.com/c/chromium/src/+/2466297
https://bugs.webkit.org/show_bug.cgi?id=235530
Reviewed by Chris Dumez.
- LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/radio-double-activate-pseudo-expected.txt:
- Source/WebCore/html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeyupEvent):
Canonical link: https://commits.webkit.org/250734@main
- 3:54 AM Changeset in webkit [294474] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/JavaScriptCore
Merge r291602 - Fix bug in Relationship::mergeImpl
https://bugs.webkit.org/show_bug.cgi?id=238183
<rdar://89822922>
Reviewed by Yusuke Suzuki.
- dfg/DFGIntegerRangeOptimizationPhase.cpp:
- 3:37 AM Changeset in webkit [294473] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/JavaScriptCore
Merge r291601 - AirFixObviousSpills needs to consider a PreIndex and PostIndex as clobbering the Reg used for indexing
https://bugs.webkit.org/show_bug.cgi?id=238178
<rdar://87345895>
Reviewed by Mark Lam.
Inside AirFixObviousSpills, we run a basic alias analysis for StackSlots and
registers. For example, when we overwrite a register, we clear anything
it's aliased with. However, the way we were doing this was by looking at
each Arg that was Defd. However, this iteration was missing that
PostIndex/PreIndex mutate the register that feeds into the address Arg.
This patch fixes the issue by walking the instruction in such a way that
we visit all the Defs we care about, both Regs and StackSlots.
- b3/air/AirFixObviousSpills.cpp:
- 2:44 AM Changeset in webkit [294472] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r290999 - UniqueIDBDatabase::didFireVersionChangeEvent should capture identifier of UniqueIDBDatabaseConnection
https://bugs.webkit.org/show_bug.cgi?id=236950
rdar://problem/89218299
Reviewed by Chris Dumez.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::didFireVersionChangeEvent):
- 2:16 AM Changeset in webkit [294471] by
-
- 1 edit in trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp
Remove dead code in handling of GridTrackEntryAutoRepeat in canInterpolate
https://bugs.webkit.org/show_bug.cgi?id=240620
Patch by Kiet Ho <Kiet Ho> on 2022-05-19
Reviewed by Tim Nguyen.
No new tests, no changes in behavior.
- Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::canInterpolate):
Canonical link: https://commits.webkit.org/250733@main
- 12:39 AM Changeset in webkit [294470] by
-
- 36 edits in trunk/Source
Unreviewed, non-unified build fixes after 250693@main
May 18, 2022:
- 11:24 PM Changeset in webkit [294469] by
-
- 7 edits in trunk/Source/WebKit/UIProcess
Move directories from WebProcessPool to WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=240609
Reviewed by Chris Dumez.
Moving directories out of WebProcessPool because WebsiteDataStore usually decides where to store things. It is confusing
in current implementation that WebsiteDataStore gets the paths from WebProcessPool, and then WebProcessPool query paths
from WebsiteDataStore.
- Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::cacheDirectoryInContainerOrHomeDirectory): Deleted.
(WebKit::WebProcessPool::cookieStorageDirectory): Deleted.
(WebKit::WebProcessPool::parentBundleDirectory): Deleted.
(WebKit::WebProcessPool::networkingCachesDirectory): Deleted.
(WebKit::WebProcessPool::webContentCachesDirectory): Deleted.
(WebKit::WebProcessPool::containerTemporaryDirectory): Deleted.
- Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::gpuProcessCachesDirectory):
(WebKit::GPUProcessProxy::GPUProcessProxy):
- Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::webProcessDataStoreParameters):
- Source/WebKit/UIProcess/WebProcessPool.h:
- Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::cacheDirectoryInContainerOrHomeDirectory):
(WebKit::WebsiteDataStore::cookieStorageDirectory):
(WebKit::WebsiteDataStore::containerCachesDirectory):
(WebKit::WebsiteDataStore::parentBundleDirectory):
(WebKit::WebsiteDataStore::networkingCachesDirectory):
(WebKit::WebsiteDataStore::containerTemporaryDirectory):
- Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
(WebKit::WebsiteDataStore::parameters):
- Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::cookieStorageDirectory const): Deleted.
(WebKit::WebsiteDataStore::containerCachesDirectory const): Deleted.
(WebKit::WebsiteDataStore::containerTemporaryDirectory const): Deleted.
Canonical link: https://commits.webkit.org/250731@main
- 10:53 PM Changeset in webkit [294468] by
-
- 40 edits in trunk
Add find()/reverseFind()/contains() overloads takes an ASCIILiteral to our String types https://bugs.webkit.org/show_bug.cgi?id=240247
https://bugs.webkit.org/show_bug.cgi?id=240247
Reviewed by Darin Adler.
Add find()/reverseFind()/contains() overloads takes an ASCIILiteral to our String types.
These versions are more efficient when the call sites have an ASCIILiteral as they have
less branching.
- Source/JavaScriptCore/runtime/ExceptionHelpers.cpp:
(JSC::notAFunctionSourceAppender):
(JSC::invalidParameterInSourceAppender):
(JSC::invalidParameterInstanceofSourceAppender):
(JSC::invalidPrototypeSourceAppender):
- Source/JavaScriptCore/runtime/IntlObject.cpp:
(JSC::canonicalizeUnicodeExtensionsAfterICULocaleCanonicalization):
(JSC::lookupMatcher):
- Source/JavaScriptCore/tools/FunctionOverrides.cpp:
(JSC::initializeOverrideInfo):
- Source/WebCore/PAL/pal/text/DecodeEscapeSequences.h:
(PAL::Unicode16BitEscapeSequence::findInString):
- Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::needsNewCreateTableSchema):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationshipList):
- Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponse):
- Source/WebKit/NetworkProcess/cache/PrefetchCache.cpp:
(WebKit::PrefetchCache::take):
- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _updateTextInputTraits:]):
- Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::focusedElementInformation):
- Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::checkDocumentsCaptureStateConsistency):
- Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView updateTextTouchBar]):
- Source/WTF/wtf/text/AtomString.h:
- Source/WTF/wtf/text/StringImpl.cpp:
(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):
- Source/WTF/wtf/text/StringImpl.h:
(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):
- Source/WTF/wtf/text/StringView.cpp:
(WTF::StringView::find const):
(WTF::StringView::reverseFind const):
- Source/WTF/wtf/text/StringView.h:
- Source/WTF/wtf/text/WTFString.h:
- Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp:
(WebCore::FetchBodyConsumer::packageFormData):
- Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::validateSDP const):
(WebCore::PeerConnectionBackend::newICECandidate):
- Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::YouTubePluginReplacement::youTubeURLFromAbsoluteURL):
- Source/WebCore/dom/DataTransfer.cpp:
(WebCore::DataTransfer::types const):
- Source/WebCore/dom/Document.cpp:
(WebCore::Document::createCDATASection):
(WebCore::Document::createProcessingInstruction):
- Source/WebCore/editing/cocoa/HTMLConverter.mm:
(HTMLConverter::computedAttributesForElement):
- Source/WebCore/editing/libwpe/EditorLibWPE.cpp:
(WebCore::createFragmentFromPasteboardData):
- Source/WebCore/editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::shouldPreserveMSOListStyleForElement):
(WebCore::StyledMarkupAccumulator::appendNodeToPreserveMSOList):
(WebCore::shouldPreserveMSOLists):
- Source/WebCore/html/track/VTTRegion.cpp:
(WebCore::VTTRegion::parseSettingValue):
- Source/WebCore/html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::collectWebVTTBlock):
(WebCore::WebVTTParser::checkAndRecoverCue):
(WebCore::WebVTTParser::checkAndCreateRegion):
(WebCore::WebVTTParser::checkAndStoreRegion):
(WebCore::WebVTTParser::checkStyleSheet):
(WebCore::WebVTTParser::checkAndStoreStyleSheet):
(WebCore::WebVTTParser::collectCueId):
(WebCore::WebVTTParser::collectCueText):
(WebCore::WebVTTParser::ignoreBadCue):
- Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::ElementFactories::hasElementForMediaType const):
- Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
- Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:
(WebCore::ExtensionsGLOpenGLCommon::ExtensionsGLOpenGLCommon):
- Source/WebCore/platform/graphics/texmap/TextureMapperContextAttributes.cpp:
(WebCore::TextureMapperContextAttributes::get):
- Source/WebCore/platform/ios/UserAgentIOS.mm:
(WebCore::deviceNameForUserAgent):
- Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:
(WebCore::isValidCaptureDevice):
- Source/WebCore/rendering/style/GridPositionsResolver.cpp:
(WebCore::NamedLineCollectionBase::NamedLineCollectionBase):
- Source/WebCore/style/StyleScope.cpp:
(WebCore::Style::Scope::collectActiveStyleSheets):
- Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::isVP9VTBDeccoderUsed):
- Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:
(WebCore::MockLibWebRTCPeerConnection::SetRemoteDescription):
Canonical link: https://commits.webkit.org/250730@main
- 9:09 PM Changeset in webkit [294467] by
-
- 2 edits in trunk/Source
REGRESSION (r294160): Occasional infinite loops under updateLayersForInteractionRegions
https://bugs.webkit.org/show_bug.cgi?id=240610
<rdar://problem/93507791>
Reviewed by Wenson Hsieh.
- Source/WebCore/page/InteractionRegion.cpp:
(WebCore::regionForElement):
Avoid emitting empty rects for interaction regions, and avoid emitting the region
at all if this results in an empty set of rects.
- Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm:
(WebKit::updateLayersForInteractionRegions):
Never re-use a layer with empty bounds; we should never get here, but I'd rather
re-create the layer if we do than corrupt the hash table.
Canonical link: https://commits.webkit.org/250729@main
- 9:08 PM Changeset in webkit [294466] by
-
- 1 edit in trunk/Source/WebKit/WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp
Unreviewed, fix WPE build 250693@main
- WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp: Add missing inlines.h include.
Canonical link: https://commits.webkit.org/250728@main
- 9:03 PM Changeset in webkit [294465] by
-
- 1 edit in trunk/Source/WTF/wtf/text/WTFString.h
Drop operator==() overload for comparing a String and a LChar*
https://bugs.webkit.org/show_bug.cgi?id=240611
Reviewed by Darin Adler.
Drop operator==() overload for comparing a String and a LChar*, as it is unused.
- Source/WTF/wtf/text/WTFString.h:
(WTF::operator==):
(WTF::operator!=):
Canonical link: https://commits.webkit.org/250727@main
- 8:50 PM Changeset in webkit [294464] by
-
- 19 edits in trunk/Source
Use references instead of pointers when passing elements through several editor client hooks
https://bugs.webkit.org/show_bug.cgi?id=240603
Reviewed by Chris Dumez.
Change
Element*toElement&in several WebEditorClient (and injected bundle form client) codepaths
that currently expect non-null pointers, anyways. No change in behavior.
- Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):
- Source/WebKit/WebProcess/InjectedBundle/APIInjectedBundleFormClient.h:
(API::InjectedBundle::FormClient::didFocusTextField):
(API::InjectedBundle::FormClient::textFieldDidBeginEditing):
(API::InjectedBundle::FormClient::textFieldDidEndEditing):
(API::InjectedBundle::FormClient::textDidChangeInTextField):
(API::InjectedBundle::FormClient::textDidChangeInTextArea):
(API::InjectedBundle::FormClient::shouldPerformActionInTextField):
- Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::didFocusTextField):
(WebKit::InjectedBundlePageFormClient::textFieldDidBeginEditing):
(WebKit::InjectedBundlePageFormClient::textFieldDidEndEditing):
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextField):
(WebKit::InjectedBundlePageFormClient::textDidChangeInTextArea):
(WebKit::InjectedBundlePageFormClient::shouldPerformActionInTextField):
- Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
- Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedElementChanged):
- Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::textDidChangeInTextArea):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):
- Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h:
- Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h:
- Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm:
(dynamicDowncastToKit):
Also add a helper method here to make it easier to safely downcast an Element to a
given WebCore type, and then return an Objective-CDOMElementwrapper for the
element, if it matches the type.
(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
(WebEditorClient::textDidChangeInTextArea):
- Source/WebKitLegacy/win/WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
(WebEditorClient::textDidChangeInTextArea):
- Source/WebKitLegacy/win/WebCoreSupport/WebEditorClient.h:
- Source/WebCore/editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::doApply):
- Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::textFieldDidBeginEditing):
(WebCore::Editor::textFieldDidEndEditing):
(WebCore::Editor::textDidChangeInTextField):
(WebCore::Editor::doTextFieldCommandFromEvent):
(WebCore::Editor::textWillBeDeletedInTextField):
(WebCore::Editor::textDidChangeInTextArea):
- Source/WebCore/editing/Editor.h:
- Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::endEditing):
- Source/WebCore/html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::subtreeHasChanged):
- Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleKeydownEvent):
(WebCore::TextFieldInputType::handleFocusEvent):
(WebCore::TextFieldInputType::didSetValueByUserEdit):
- Source/WebCore/loader/EmptyClients.cpp:
- Source/WebCore/page/EditorClient.h:
Canonical link: https://commits.webkit.org/250726@main
- 8:05 PM Changeset in webkit [294463] by
-
- 2 edits in trunk/Source/WebCore/layout
Add support for simple 'flex-grow'
https://bugs.webkit.org/show_bug.cgi?id=240561
Reviewed by Antti Koivisto.
This is a basic "flex grow" implementation ignoring min/max values.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::updateRenderers const):
Canonical link: https://commits.webkit.org/250725@main
- 7:29 PM Changeset in webkit [294462] by
-
- 1 edit in trunk/Source/JavaScriptCore/CMakeLists.txt
PrivateHeaders/JavaScriptCore/InspectorProtocolObjects.h isn't regenerated in incremental builds
https://bugs.webkit.org/show_bug.cgi?id=240540
Reviewed by Don Olmstead.
In CMake Visual Studio generator builds, InspectorProtocolObjects.h
was not copied to the private headers directory as expected in
incremental builds.
${JavaScriptCore_DERIVED_SOURCES_DIR}/inspector/InspectorProtocolObjects.h
was added to both JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS and
JavaScriptCore_HEADERS. This caused the incremental build problem.
Don't add such headers to JavaScriptCore_HEADERS.
- Source/JavaScriptCore/CMakeLists.txt:
Canonical link: https://commits.webkit.org/250724@main
- 7:28 PM Changeset in webkit [294461] by
-
- 1 edit in trunk/Source/JavaScriptCore/CMakeLists.txt
JavaScriptCore/DerivedSources/Bytecodes.h is generated twice both in Bytecodes.vcxproj in LLIntSettingsExtractor.vcxproj
https://bugs.webkit.org/show_bug.cgi?id=240556
Reviewed by Don Olmstead.
In CMake Visual Studio generator builds, Bytecodes.h was generated
twice both in Bytecodes.vcxproj in LLIntSettingsExtractor.vcxproj.
The fundamental problem of this bug was fixed in CMake v3.12.
<https://gitlab.kitware.com/cmake/cmake/-/commit/5a6c6292898fe238f3a5105133b8904209fbedaf>
LLIntSettingsExtractor target needs to have a direct or indirect
dependency to Bytecodes target for CMake Visual Studio generator to
eliminate duplicated custom commands.
- Source/JavaScriptCore/CMakeLists.txt:
Canonical link: https://commits.webkit.org/250723@main
- 7:12 PM Changeset in webkit [294460] by
-
- 65 edits1 copy1 add2 deletes in trunk/Source/WebKit
Regression(r294190) GPUProcess is unable to launch on certain builds
https://bugs.webkit.org/show_bug.cgi?id=240615
<rdar://93533749>
Unreviewed, revert r294190 to adddress the issue.
- Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::remoteMediaResourceManager):
- Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.h:
- Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.cpp:
(WebKit::RemoteImageDecoderAVFProxy::createDecoder):
(WebKit::RemoteImageDecoderAVFProxy::setData):
- Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.h:
- Source/WebKit/GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in:
- Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.cpp:
(WebKit::RemoteMediaResourceManager::RemoteMediaResourceManager):
(WebKit::RemoteMediaResourceManager::dataReceived):
- Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.h:
- Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.messages.in:
- Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.cpp:
(WebKit::RemoteSourceBufferProxy::append):
- Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h:
- Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in:
- Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::bufferingTimerFired):
(WebKit::NetworkResourceLoader::sendBuffer):
(WebKit::NetworkResourceLoader::dataReceivedThroughContentFilter):
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.cpp:
(WebKit::ServiceWorkerDownloadTask::didReceiveData):
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h:
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.messages.in:
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::didReceiveData):
(WebKit::ServiceWorkerFetchTask::loadBodyFromPreloader):
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in:
- Source/WebKit/Platform/IPC/SharedBufferReference.cpp: Removed.
- Source/WebKit/Platform/IPC/SharedBufferReference.h: Removed.
- Source/WebKit/Platform/SharedMemory.cpp:
(WebKit::SharedMemory::Handle::takeOwnershipOfMemory const):
(WebKit::SharedMemory::Handle::transferOwnershipOfMemory const): Deleted.
- Source/WebKit/Platform/SharedMemory.h:
- Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp:
(WebKit::SharedMemory::Handle::takeOwnershipOfMemory const):
(WebKit::machProtection):
(WebKit::SharedMemory::map):
(WebKit::changeOwnershipOfMemory): Deleted.
(WebKit::SharedMemory::Handle::transferOwnershipOfMemory const): Deleted.
- Source/WebKit/Platform/unix/SharedMemoryUnix.cpp:
(WebKit::accessModeMMap):
(WebKit::SharedMemory::map):
- Source/WebKit/Scripts/process-entitlements.sh:
- Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp:
(WebKit::CGDisplayListImageBufferBackend::createBackendHandle const):
- Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
- Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::encodeSharedBuffer):
(IPC::decodeSharedBuffer):
- Source/WebKit/Sources.txt:
- Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView createPDFWithConfiguration:completionHandler:]):
- Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::platformRegisterAttachment):
- Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::WebPasteboardProxy::getPasteboardBufferForType):
(WebKit::WebPasteboardProxy::setPasteboardBufferForType):
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):
- Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::sendAudioComponentRegistrations):
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::CompletionHandler<void):
(WebKit::WebPageProxy::drawPagesToPDF):
(WebKit::WebPageProxy::drawToPDF):
(WebKit::WebPageProxy::getLoadDecisionForIcon):
(WebKit::WebPageProxy::updateAttachmentAttributes):
(WebKit::WebPageProxy::registerAttachmentIdentifierFromData):
(WebKit::WebPageProxy::platformRegisterAttachment):
- Source/WebKit/UIProcess/WebPageProxy.h:
- Source/WebKit/UIProcess/WebPageProxy.messages.in:
- Source/WebKit/UIProcess/WebPasteboardProxy.cpp:
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):
- Source/WebKit/UIProcess/WebPasteboardProxy.h:
- Source/WebKit/UIProcess/WebPasteboardProxy.messages.in:
- Source/WebKit/UIProcess/WebURLSchemeTask.cpp:
(WebKit::WebURLSchemeTask::didReceiveData):
- Source/WebKit/UIProcess/gtk/WebPasteboardProxyGtk.cpp:
(WebKit::WebPasteboardProxy::readBuffer):
- Source/WebKit/UIProcess/ios/WKContentView.mm:
(-[WKContentView _wk_pageCountForPrintFormatter:]):
- Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::drawToPDFiOS):
- Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::dataSelectionForPasteboard):
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Source/WebKit/WebProcess/GPU/graphics/ImageBufferBackendHandle.h:
- Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVF.cpp:
(WebKit::RemoteImageDecoderAVF::setData):
- Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp:
(WebKit::RemoteImageDecoderAVFManager::createImageDecoder):
- Source/WebKit/WebProcess/GPU/media/RemoteMediaResourceProxy.cpp:
(WebKit::RemoteMediaResourceProxy::dataReceived):
- Source/WebKit/WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:
(WebKit::SourceBufferPrivateRemote::append):
- Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveData):
- Source/WebKit/WebProcess/Network/WebResourceLoader.h:
- Source/WebKit/WebProcess/Network/WebResourceLoader.messages.in:
- Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::writeItemsToPasteboard):
- Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveData):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveBlobChunk):
- Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
- Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::registerAttachmentIdentifier):
- Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::readBufferFromClipboard):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):
- Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage):
- Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getContentsAsMHTMLData):
(WebKit::WebPage::getSelectionAsWebArchiveData):
(WebKit::WebPage::getMainResourceDataOfFrame):
(WebKit::WebPage::getResourceDataFromFrame):
(WebKit::WebPage::getWebArchiveOfFrame):
(WebKit::WebPage::getAccessibilityTreeData):
(WebKit::WebPage::drawToPDF):
(WebKit::WebPage::drawPagesToPDF):
(WebKit::WebPage::didGetLoadDecisionForIcon):
(WebKit::WebPage::urlSchemeTaskDidReceiveData):
(WebKit::WebPage::updateAttachmentAttributes):
- Source/WebKit/WebProcess/WebPage/WebPage.h:
- Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
- Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getDataSelectionForPasteboard):
(WebKit::WebPage::performActionOnElement):
(WebKit::WebPage::drawToPDFiOS):
(WebKit::WebPage::didFinishLoadForQuickLookDocumentInMainFrame):
- Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::getDataSelectionForPasteboard):
- Source/WebKit/WebProcess/WebProcess.h:
- Source/WebKit/WebProcess/WebProcess.messages.in:
- Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::consumeAudioComponentRegistrations):
Canonical link: https://commits.webkit.org/250722@main
- 7:08 PM Changeset in webkit [294459] by
-
- 1 copy in tags/WebKit-7614.1.14.0.6
Tag WebKit-7614.1.14.0.6.
- 7:06 PM Changeset in webkit [294458] by
-
- 1 copy in tags/WebKit-7614.1.14.1.6
Tag WebKit-7614.1.14.1.6.
- 7:04 PM Changeset in webkit [294457] by
-
- 66 edits1 copy1 add2 deletes in branches/safari-7614.1.14.1-branch/Source/WebKit
Revert r294190. rdar://problem/93533749
- 6:59 PM Changeset in webkit [294456] by
-
- 66 edits1 copy1 add2 deletes in branches/safari-7614.1.14.0-branch/Source/WebKit
Revert r294190. rdar://problem/93533749
- 6:47 PM Changeset in webkit [294455] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
REGRESSION (r294317): [ iOS ] Thirteen layout tests are flaky or consistent timeouts
https://bugs.webkit.org/show_bug.cgi?id=240616
<rdar://93541706>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250721@main
- 6:40 PM Changeset in webkit [294454] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.6
- 6:40 PM Changeset in webkit [294453] by
-
- 9 edits in branches/safari-7614.1.14.0-branch/Source
Versioning.
WebKit-7614.1.14.0.6
- 5:41 PM Changeset in webkit [294452] by
-
- 12 edits in trunk/Source
Unreviewed, reverting r294317.
Broke multiple layout-tests, and 2 api-tests.
Reverted changeset:
"ImageBufferIOSurfaceBackend context setup and teardown
functions are redundant and error-prone"
https://bugs.webkit.org/show_bug.cgi?id=240452
https://commits.webkit.org/r294317
- 5:01 PM Changeset in webkit [294451] by
-
- 3 edits1 add in trunk
Copy-pasted attachments in mail show up as generic file icons
https://bugs.webkit.org/show_bug.cgi?id=240586
rdar://91067102
Reviewed by Wenson Hsieh.
Generate QuickLook previews for attachments that are copy-pasted as
webarchives, such as pages, keynote and numbers docs.
- Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(testiWorkAttachmentFileURL):
(testiWorkAttachmentData):
(TestWebKitAPI::TEST):
(TestWebKitAPI::_generateBestRepresentationForRequest):
Swizzle QLThumbnailGenerator code to make sure we hit image generation.
This is not an ideal test but ensures we at least hit the right code
path since we are unable to directly compare icons.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/test.pages: Added.
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::registerAttachmentsFromSerializedData):
Canonical link: https://commits.webkit.org/250719@main
- 3:57 PM Changeset in webkit [294450] by
-
- 1 copy in tags/WebKit-7614.1.14.3.2
Tag WebKit-7614.1.14.3.2.
- 3:51 PM Changeset in webkit [294449] by
-
- 9 edits in branches/safari-7614.1.14.3-branch/Source
Versioning.
WebKit-7614.1.14.3.2
- 3:48 PM Changeset in webkit [294448] by
-
- 1 copy in tags/WebKit-7614.1.14.2.2
Tag WebKit-7614.1.14.2.2.
- 3:42 PM Changeset in webkit [294447] by
-
- 9 edits in branches/safari-7614.1.14.2-branch/Source
Versioning.
WebKit-7614.1.14.2.2
- 3:34 PM Changeset in webkit [294446] by
-
- 1 copy in tags/WebKit-7614.1.14.1.5
Tag WebKit-7614.1.14.1.5.
- 3:32 PM Changeset in webkit [294445] by
-
- 1 copy in tags/WebKit-7614.1.14.0.5
Tag WebKit-7614.1.14.0.5.
- 3:29 PM Changeset in webkit [294444] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.5
- 3:29 PM Changeset in webkit [294443] by
-
- 9 edits in branches/safari-7614.1.14.0-branch/Source
Versioning.
WebKit-7614.1.14.0.5
- 3:22 PM Changeset in webkit [294442] by
-
- 4 edits in trunk/Tools/Scripts/libraries/webkitscmpy
[git-webkit] Remove space in radar URLs
https://bugs.webkit.org/show_bug.cgi?id=240592
<rdar://problem/93519659>
Reviewed by Chris Dumez.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py:
(PullRequest):
(PullRequest.escape_html):
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
Canonical link: https://commits.webkit.org/250718@main
- 3:16 PM Changeset in webkit [294441] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
PROGRESSION(r294272): Correction to guard in Platform file caused multiple tests failures
https://bugs.webkit.org/show_bug.cgi?id=240579
<rdar://93504716>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250717@main
- 3:12 PM Changeset in webkit [294440] by
-
- 1 copy in tags/WebKit-7614.1.11.9.1
Tag WebKit-7614.1.11.9.1.
- 3:00 PM Changeset in webkit [294439] by
-
- 47 edits in branches/safari-7614.1.11.9-branch/Source
Apply patch. rdar://problem/93068926
- 2:58 PM Changeset in webkit [294438] by
-
- 38 edits9 deletes in trunk
[WebAuthn] Clean up WebAuthenticationModern and WebAuthnProcess
https://bugs.webkit.org/show_bug.cgi?id=240318
<rdar://93130490>
The WebAuthenticationModern flag and WebAuthnProcess are no longer used
and can be removed. This patch removes all references to both the flag
and the process.
Reviewed by Brent Fulgham.
Covered by existing tests and manual testing on macOS / iOS.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
(TestWebKitAPI::WebCore::webAuthenticationModernExperimentalFeature): Deleted.
- Source/WebKit/Configurations/WebAuthnService.xcconfig: Removed.
- Source/WebKit/Configurations/WebKit.xcconfig:
- Source/WebKit/DerivedSources.make:
- Source/WebKit/Platform/ExtraPrivateSymbolsForTAPI.h:
- Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebAuthn.sb.in: Removed.
- Source/WebKit/Scripts/process-entitlements.sh:
- Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:
(WebKit::isInWebKitChildProcess):
- Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
- Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
- Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::processStorageClass):
(WebKit::sandboxDirectory):
- Source/WebKit/Sources.txt:
- Source/WebKit/SourcesCocoa.txt:
- Source/WebKit/UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWebAuthenticationModernEnabled): Deleted.
(WKPreferencesGetWebAuthenticationModernEnabled): Deleted.
- Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:
- Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:
(+[WKProcessPool _webAuthnProcessIdentifier]): Deleted.
- Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::getLaunchOptions):
- Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::notifyPreferencesChanged):
- Source/WebKit/UIProcess/Launcher/ProcessLauncher.h:
- Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::serviceName):
(WebKit::shouldLeakBoost):
- Source/WebKit/UIProcess/WebAuthentication/Authenticator.h:
(WebKit::Authenticator::requestData const):
(WebKit::Authenticator::setWebAuthenticationModernEnabled): Deleted.
(WebKit::Authenticator::webAuthenticationModernEnabled const): Deleted.
(): Deleted.
- Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::authenticatorAdded):
(WebKit::AuthenticatorManager::enableModernWebAuthentication): Deleted.
- Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h:
- Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.h:
- Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::makeCredential):
(WebKit::LocalAuthenticator::continueGetAssertionAfterResponseSelected):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterDecidePolicy): Deleted.
- Source/WebKit/UIProcess/WebAuthentication/WebAuthnProcessProxy.cpp: Removed.
- Source/WebKit/UIProcess/WebAuthentication/WebAuthnProcessProxy.h: Removed.
- Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::getWebAuthnProcessConnection): Deleted.
- Source/WebKit/UIProcess/WebProcessPool.h:
- Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getWebAuthnProcessConnection): Deleted.
- Source/WebKit/UIProcess/WebProcessProxy.h:
- Source/WebKit/UIProcess/WebProcessProxy.messages.in:
- Source/WebKit/WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-OSX.plist: Removed.
- Source/WebKit/WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnService/Info-iOS.plist: Removed.
- Source/WebKit/WebAuthnProcess/EntryPoint/Cocoa/XPCService/WebAuthnServiceEntryPoint.mm: Removed.
- Source/WebKit/WebAuthnProcess/WebAuthnConnectionToWebProcess.cpp: Removed.
- Source/WebKit/WebAuthnProcess/WebAuthnConnectionToWebProcess.h: Removed.
- Source/WebKit/WebAuthnProcess/WebAuthnConnectionToWebProcess.messages.in: Removed.
- Source/WebKit/WebAuthnProcess/WebAuthnProcess.cpp: Removed.
- Source/WebKit/WebAuthnProcess/WebAuthnProcess.h: Removed.
- Source/WebKit/WebAuthnProcess/WebAuthnProcess.messages.in: Removed.
- Source/WebKit/WebAuthnProcess/WebAuthnProcessCreationParameters.cpp: Removed.
- Source/WebKit/WebAuthnProcess/WebAuthnProcessCreationParameters.h: Removed.
- Source/WebKit/WebAuthnProcess/ios/WebAuthnProcessIOS.mm: Removed.
- Source/WebKit/WebAuthnProcess/mac/WebAuthnProcessMac.mm: Removed.
- Source/WebKit/WebAuthnProcess/mac/com.apple.WebKit.WebAuthnProcess.sb.in: Removed.
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:
(WebKit::WebAuthenticatorCoordinator::makeCredential):
(WebKit::WebAuthenticatorCoordinator::getAssertion):
(WebKit::WebAuthenticatorCoordinator::isUserVerifyingPlatformAuthenticatorAvailable):
- Source/WebKit/WebProcess/WebAuthentication/WebAuthnProcessConnection.cpp: Removed.
- Source/WebKit/WebProcess/WebAuthentication/WebAuthnProcessConnection.h: Removed.
- Source/WebKit/WebProcess/WebAuthentication/WebAuthnProcessConnection.messages.in: Removed.
- Source/WebKit/WebProcess/WebAuthentication/WebAuthnProcessConnectionInfo.h: Removed.
- Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setMockWebAuthenticationConfiguration):
- Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::getWebAuthnProcessConnection): Deleted.
(WebKit::WebProcess::ensureWebAuthnProcessConnection): Deleted.
(WebKit::WebProcess::webAuthnProcessConnectionClosed): Deleted.
- Source/WebKit/WebProcess/WebProcess.h:
(WebKit::WebProcess::existingWebAuthnProcessConnection): Deleted.
- Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
- Source/WebCore/page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebAuthenticationModernEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAuthenticationModernEnabled const): Deleted.
- Source/WebCore/platform/RuntimeApplicationChecks.cpp:
(WebCore::processTypeDescription):
- Source/WebCore/platform/RuntimeApplicationChecks.h:
Canonical link: https://commits.webkit.org/250715@main
- 2:57 PM Changeset in webkit [294437] by
-
- 1 edit in trunk/Source/WebCore/editing/libwpe/EditorLibWPE.cpp
[LibWPE] Fix build failure when enabling LAYOUT_FORMATTING_CONTEXT
https://bugs.webkit.org/show_bug.cgi?id=240602
Unreviewed, fix libwpe build with the flag after r294399
- editing/libwpe/EditorLibWPE.cpp:
Canonical link: https://commits.webkit.org/250715@main
- 2:57 PM Changeset in webkit [294436] by
-
- 1 copy in tags/WebKit-7614.1.14.1.4
Tag WebKit-7614.1.14.1.4.
- 2:47 PM Changeset in webkit [294435] by
-
- 1 copy in tags/WebKit-7614.1.14.0.4
Tag WebKit-7614.1.14.0.4.
- 2:28 PM Changeset in webkit [294434] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm
REGRESSION (442fcb1ea6f?): TestWebKitAPI.WebAuthenticationPanel.ExportImportDuplicateCredential is failing
https://bugs.webkit.org/show_bug.cgi?id=240534
rdar://93267243
Reviewed by Brent Fulgham.
The default for a flag relevant to syncing has changed in test infrastructure. This change fixes this test
by using the sync=1 flag as set by default when importing credentials.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/250713@main
- 2:27 PM Changeset in webkit [294433] by
-
- 1 edit in trunk/Source/JavaScriptCore/assembler/SecureARM64EHashPinsInlines.h
Unreviewed, build fix after r294429
https://bugs.webkit.org/show_bug.cgi?id=240587
- Source/JavaScriptCore/assembler/SecureARM64EHashPinsInlines.h:
(JSC::SecureARM64EHashPins::forEachPage):
Canonical link: https://commits.webkit.org/250713@main
- 2:19 PM Changeset in webkit [294432] by
-
- 9 edits in branches/safari-7614.1.11.9-branch/Source
Versioning.
WebKit-7614.1.11.9.1
- 2:05 PM Changeset in webkit [294431] by
-
- 5 edits in trunk/Source/WebCore
Drop unnecessary EventTarget::isFiringEventListeners()
https://bugs.webkit.org/show_bug.cgi?id=240578
Reviewed by Geoffrey Garen.
Drop unnecessary EventTarget::isFiringEventListeners() flag. This flag was checked by
our GC logic to avoid collecting wrappers while they are firing events. However, those
checks are in hot code paths and it should be up to the code dispatching the event
to keep the wrapper alive, either via ActiveDOMObject or GCReachableRef.
- Source/WebCore/bindings/js/JSAbortSignalCustom.cpp:
(WebCore::JSAbortSignalOwner::isReachableFromOpaqueRoots):
- Source/WebCore/bindings/js/JSNodeCustom.cpp:
(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
- Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- Source/WebCore/dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
- Source/WebCore/dom/EventTarget.h:
(WebCore::EventTarget::isFiringEventListeners const): Deleted.
Canonical link: https://commits.webkit.org/250712@main
- 2:04 PM Changeset in webkit [294430] by
-
- 1 copy in branches/safari-7614.1.11.9-branch
New branch.
- 1:43 PM Changeset in webkit [294429] by
-
- 1 edit in trunk/Source/JavaScriptCore/assembler/SecureARM64EHashPinsInlines.h
Small clean ups in SecureARM64EHashPins.
https://bugs.webkit.org/show_bug.cgi?id=240587
Reviewed by Yusuke Suzuki.
- In SecureARM64EHashPins::keyForCurrentThread(), there's no need to add 1 to the value retrieve from TPIDRRO_EL0. TPIDRRO_EL0 is a pointer to valid memory and can never be 0. Also, we already code in multiple other places where we expect to load from it without a null check.
- SecureARM64EHashPins::forEachPage() should use a do-while loop instead of a for loop. This is because we are guaranteed to at least have 1 page at start up if the JIT is enabled. If the JIT is not enabled, this code will never be called.
- Source/JavaScriptCore/assembler/SecureARM64EHashPinsInlines.h:
(JSC::SecureARM64EHashPins::keyForCurrentThread):
(JSC::SecureARM64EHashPins::forEachPage):
Canonical link: https://commits.webkit.org/250711@main
- 1:39 PM Changeset in webkit [294428] by
-
- 5 edits in trunk/Source/WebKit/UIProcess
Audit token for font sandbox extension is sometimes wrong
https://bugs.webkit.org/show_bug.cgi?id=240547
Reviewed by Chris Dumez.
Audit token for font sandbox extension is sometimes wrong. We must get the audit token from the correct WebProcessProxy.
(WebKit::WebPageProxy::switchFromStaticFontRegistryToUserFontRegistry):
(WebKit::WebPageProxy::fontdMachExtensionHandle): Deleted.
- Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::fontdMachExtensionHandle):
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- Source/WebKit/UIProcess/WebPageProxy.h:
- Source/WebKit/UIProcess/WebProcessProxy.h:
Canonical link: https://commits.webkit.org/250710@main
- 1:01 PM Changeset in webkit [294427] by
-
- 6 edits in trunk
Feature Request: Regular Expression Groups in Request Override Redirects
https://bugs.webkit.org/show_bug.cgi?id=240477
<rdar://problem/73779368>
Reviewed by Patrick Angle.
This allows developers to create generic "catch all" request local overrides that can redirect
multiple URLs with a single local override (e.g.https://example.org/(.*)->localhost/$1).
- Source/WebInspectorUI/UserInterface/Models/LocalResourceOverride.js:
(WI.LocalResourceOverride):
(WI.LocalResourceOverride.prototype.generateRequestRedirectURL): Added.
(WI.LocalResourceOverride.prototype.matches):
(WI.LocalResourceOverride.prototype.get _urlRegex): Added.
Instead of directly using the URL of theWI.LocalResourceas the redirect URL, derive it based on
the regex created to check if theWI.LocalResourceOverridematches the original request.
- Source/WebInspectorUI/UserInterface/Models/Resource.js:
(WI.Resource.prototype.async createLocalResourceOverride):
- Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:
(WI.NetworkManager.prototype.async requestIntercepted):
(WI.NetworkManager.prototype.async responseIntercepted):
- Source/WebInspectorUI/UserInterface/Views/LocalResourceOverridePopover.js:
(WI.LocalResourceOverridePopover.prototype.get serializedData):
Drive-by: MoveWI.urlWithoutFragmenttoWI.LocalResourceOverrideso that every callsite doesn't
have to decide/remember to use it.
- LayoutTests/http/tests/inspector/network/intercept-request-properties.html:
- LayoutTests/http/tests/inspector/network/intercept-request-properties-expected.txt:
Canonical link: https://commits.webkit.org/250709@main
- 12:48 PM Changeset in webkit [294426] by
-
- 2 edits in trunk/Source/WebCore/rendering
Unreviewed, fix build after 250680@main (again)
Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-18
https://bugs.webkit.org/show_bug.cgi?id=240416
- Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
- Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter<TextBoxPath>::debugTextShadow const):
Canonical link: https://commits.webkit.org/250708@main
- 12:39 PM Changeset in webkit [294425] by
-
- 3 edits in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa
REGRESSION (r294272): TestWebKitAPI Failures after compile guard change
https://bugs.webkit.org/show_bug.cgi?id=240530
Reviewed by Youenn Fablet.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
Canonical link: https://commits.webkit.org/250707@main
- 12:34 PM Changeset in webkit [294424] by
-
- 2 edits in branches/safari-7614.1.14.0-branch/Source/bmalloc
Cherry-pick r293952. rdar://problem/92916514
Force PAS_ASSERT to generate different crash sites for each assertion.
https://bugs.webkit.org/show_bug.cgi?id=240209
Reviewed by Yusuke Suzuki.
Clang currently optimizes all crash sites into one in each function. Hence, if we
get a crash address at the 1 crash site, we don't know which failed assertion got
us there. This patch uses an asm statement to force Clang to emit a different
crash site for each assertion.
Benchmarks show that performance is neutral on both Jetstream2 and Speedometer2.
Size-wise, there is some increase. The following is the "size" output on
JavaScriptCore on M1:
TEXT. DATA OBJC others dec hex
old 19628032 180224 0 18792448 38600704 24d0000
new 19644416 180224 0 19251200 39075840 2544000
diff 16384 0 0 458752 475136
The increase in the "others" categories are mostly in the String Table, Symbol
Table, and Function Start Addresses. These take up disk space but should not
impact RAM usage unless they are accessed by a a debugger.
- libpas/src/libpas/pas_utils.h: (pas_assertion_failed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:21 PM Changeset in webkit [294423] by
-
- 7 edits in trunk
Invalidation fails if the mutated elements subtree has been marked invalid
https://bugs.webkit.org/show_bug.cgi?id=240581
Reviewed by Alan Bujtas.
:has() can affect elements outside the subtree so we can't use this optimization if it is present.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-in-adjacent-position-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-in-ancestor-position-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-in-parent-position-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-in-sibling-position-expected.txt:
- Source/WebCore/dom/Element.cpp:
(WebCore::Element::needsStyleInvalidation const):
Don't skip invalidation for a locally invalid subtree if :has() is present.
Add a new check for document element subtree being invalid (this covers some of the same cases and works with :has()).
- Source/WebCore/style/StyleScope.cpp:
(WebCore::Style::Scope::forNode):
Add const version.
- Source/WebCore/style/StyleScope.h:
Canonical link: https://commits.webkit.org/250706@main
- 12:19 PM Changeset in webkit [294422] by
-
- 9 edits in branches/safari-7614.1.14.0-branch/Source
Versioning.
WebKit-7614.1.14.0.4
- 12:19 PM Changeset in webkit [294421] by
-
- 1 copy in tags/WebKit-7614.1.14.3.1
Tag WebKit-7614.1.14.3.1.
- 12:15 PM Changeset in webkit [294420] by
-
- 2 edits in branches/safari-7614.1.14.3-branch/Source/bmalloc
Cherry-pick r293952. rdar://problem/92916514
Force PAS_ASSERT to generate different crash sites for each assertion.
https://bugs.webkit.org/show_bug.cgi?id=240209
Reviewed by Yusuke Suzuki.
Clang currently optimizes all crash sites into one in each function. Hence, if we
get a crash address at the 1 crash site, we don't know which failed assertion got
us there. This patch uses an asm statement to force Clang to emit a different
crash site for each assertion.
Benchmarks show that performance is neutral on both Jetstream2 and Speedometer2.
Size-wise, there is some increase. The following is the "size" output on
JavaScriptCore on M1:
TEXT. DATA OBJC others dec hex
old 19628032 180224 0 18792448 38600704 24d0000
new 19644416 180224 0 19251200 39075840 2544000
diff 16384 0 0 458752 475136
The increase in the "others" categories are mostly in the String Table, Symbol
Table, and Function Start Addresses. These take up disk space but should not
impact RAM usage unless they are accessed by a a debugger.
- libpas/src/libpas/pas_utils.h: (pas_assertion_failed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:13 PM Changeset in webkit [294419] by
-
- 9 edits in branches/safari-7614.1.14.3-branch/Source
Versioning.
WebKit-7614.1.14.3.1
- 12:12 PM Changeset in webkit [294418] by
-
- 1 copy in tags/WebKit-7614.1.14.2.1
Tag WebKit-7614.1.14.2.1.
- 12:11 PM Changeset in webkit [294417] by
-
- 2 edits in branches/safari-7614.1.14.2-branch/Source/bmalloc
Cherry-pick r293952. rdar://problem/92916514
Force PAS_ASSERT to generate different crash sites for each assertion.
https://bugs.webkit.org/show_bug.cgi?id=240209
Reviewed by Yusuke Suzuki.
Clang currently optimizes all crash sites into one in each function. Hence, if we
get a crash address at the 1 crash site, we don't know which failed assertion got
us there. This patch uses an asm statement to force Clang to emit a different
crash site for each assertion.
Benchmarks show that performance is neutral on both Jetstream2 and Speedometer2.
Size-wise, there is some increase. The following is the "size" output on
JavaScriptCore on M1:
TEXT. DATA OBJC others dec hex
old 19628032 180224 0 18792448 38600704 24d0000
new 19644416 180224 0 19251200 39075840 2544000
diff 16384 0 0 458752 475136
The increase in the "others" categories are mostly in the String Table, Symbol
Table, and Function Start Addresses. These take up disk space but should not
impact RAM usage unless they are accessed by a a debugger.
- libpas/src/libpas/pas_utils.h: (pas_assertion_failed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:07 PM Changeset in webkit [294416] by
-
- 9 edits in branches/safari-7614.1.14.2-branch/Source
Versioning.
WebKit-7614.1.14.2.1
- 11:57 AM Changeset in webkit [294415] by
-
- 2 edits in branches/safari-7614.1.14.1-branch/Source/bmalloc
Cherry-pick r293952. rdar://problem/92916514
Force PAS_ASSERT to generate different crash sites for each assertion.
https://bugs.webkit.org/show_bug.cgi?id=240209
Reviewed by Yusuke Suzuki.
Clang currently optimizes all crash sites into one in each function. Hence, if we
get a crash address at the 1 crash site, we don't know which failed assertion got
us there. This patch uses an asm statement to force Clang to emit a different
crash site for each assertion.
Benchmarks show that performance is neutral on both Jetstream2 and Speedometer2.
Size-wise, there is some increase. The following is the "size" output on
JavaScriptCore on M1:
TEXT. DATA OBJC others dec hex
old 19628032 180224 0 18792448 38600704 24d0000
new 19644416 180224 0 19251200 39075840 2544000
diff 16384 0 0 458752 475136
The increase in the "others" categories are mostly in the String Table, Symbol
Table, and Function Start Addresses. These take up disk space but should not
impact RAM usage unless they are accessed by a a debugger.
- libpas/src/libpas/pas_utils.h: (pas_assertion_failed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:51 AM Changeset in webkit [294414] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.4
- 11:40 AM Changeset in webkit [294413] by
-
- 2 edits15 adds in trunk
REGRESSION (STP): WebSocket.bufferedAmount does not get updated in some cases
https://bugs.webkit.org/show_bug.cgi?id=240311
Reviewed by Youenn Fablet.
This reverts the functional part of r290995 for OSes what don't have an NSURLSession WebSocket implementation we can use.
The rest of r290995 was just moving UTF-8 encoding to a different location in the pipeline, which has no observable behavior change.
It is unfortunate, but our old implementation of WebSockets that uses CFWriteStreamWrite thinks it has written immediately,
so if I make SocketStreamHandleImpl::platformSend call m_client.didUpdateBufferedAmount even when bytesWritten >= length,
I don't have the bufferent amount updated synchronously like Chrome, Firefox, and the NSURLSession-based implementation have.
If I leave it as it is now, the buffered amount never goes back down to zero sometimes after writing to the stream.
It was broken before, it is differently broken now, and this restores the status quo on Big Sur. This is why we can't have nice things.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
Canonical link: https://commits.webkit.org/250705@main
- 11:37 AM Changeset in webkit [294412] by
-
- 2 edits in trunk/Source/WebCore/layout/formattingContexts/flex
Move visual/logical code to dedicated functions
https://bugs.webkit.org/show_bug.cgi?id=240560
Reviewed by Antti Koivisto.
This is in preparation for adding more pre/post core layout logic.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
(): Deleted.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
Canonical link: https://commits.webkit.org/250704@main
- 11:33 AM Changeset in webkit [294411] by
-
- 3 edits in trunk
WTF::CrashOnOverflow::crash() with /((a{100000000})*b{2100000000})+/.test();
https://bugs.webkit.org/show_bug.cgi?id=240552
Reviewed by Yusuke Suzuki and Alex Christensen.
Replaced a crashing checked add in the YARR JIT code generator with a reporting add so we can
catch the overflow. When we do overflow, we terminate the JIT genration with an error.
We'll fallback to the YARR interpreter, which already exits with an error on a similar overflow.
- JSTests/stress/regexp-large-quantifier.js:
(testRegExp):
- Source/JavaScriptCore/yarr/YarrJIT.cpp:
(JSC::Yarr::dumpCompileFailure):
- Source/JavaScriptCore/yarr/YarrJIT.h:
Canonical link: https://commits.webkit.org/250703@main
- 11:17 AM Changeset in webkit [294410] by
-
- 1 copy in tags/WebKit-7614.1.14.100.2
Tag WebKit-7614.1.14.100.2.
- 11:13 AM Changeset in webkit [294409] by
-
- 9 edits in branches/safari-7614.1.14.100-branch/Source
Versioning.
WebKit-7614.1.14.100.2
- 11:12 AM Changeset in webkit [294408] by
-
- 1 edit in trunk/metadata/contributors.json
Add nmoucht to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240588
Reviewed by Tim Nguyen.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250702@main
- 11:07 AM Changeset in webkit [294407] by
-
- 1 edit in trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py
[git-webkit] Support non-members updating PRs
https://bugs.webkit.org/show_bug.cgi?id=240550
<rdar://93460889>
Reviewed by Brent Fulgham.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
(GitHub.PRGenerator.update):
Canonical link: https://commits.webkit.org/250701@main
- 10:59 AM Changeset in webkit [294406] by
-
- 2 edits in trunk/LayoutTests/platform
[ Gardening ] REGRESSION(r294272): [ iOS ] Four http/tests/workers/service/shownotification tests are a consistent failures
https://bugs.webkit.org/show_bug.cgi?id=240579
Unreviewed test gardening.
- LayoutTests/platform/ios-wk2/TestExpectations:
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250700@main
- 10:51 AM Changeset in webkit [294405] by
-
- 8 edits2 adds in trunk/Source/WebKit
Monitor process state and send prepareToSuspend based on that
https://bugs.webkit.org/show_bug.cgi?id=240359
Reviewed by Chris Dumez.
Currently UI process sends PrepareToSuspend when a process has no activity that needs an assertion, or when
assertion will be invalidated due to timeout (when assertionWillInvalidate is called). On receiving PrepareToSuspend,
process will perform necessary actions, such as suspending storage threads for network process. According to crashes in
rdar://problem/92228190, the message is not received by process before suspension, or process gets suspended while
processing the message. To fix the crash, we need to ensure the message gets processed before process suspension.
This patch introduces ProcessStateMonitor that tracks when UI process will be suspended, and notifies WebProcessPools
when remaining running time is less than 15s. On receiving the notification, ProcessThrottlers of web processes will
invalidate activities and send out PrepareToSuspend messages to web processes. These processes are not allowed to take
new background assertion until ProcessStateMonitor finds process becomes running without timeout, or ProcessStateMonitor
is destroyed. ProcessStateMonitor is created when UI process enters background, and destroyed when UI process enters
foreground, to avoid getting receiving too many unnecessary updates from runningboardd.
- Source/WebKit/Platform/spi/ios/RunningBoardServicesSPI.h:
(+[RBSProcessPredicate predicateMatchingHandle:]):
- Source/WebKit/SourcesCocoa.txt:
- Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::setProcessesShouldSuspend):
- Source/WebKit/UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::addActivity):
(WebKit::ProcessThrottler::setAllowsActivities):
- Source/WebKit/UIProcess/ProcessThrottler.h:
(WebKit::ProcessThrottler::Activity::Activity):
(WebKit::ProcessThrottler::Activity::name const):
(WebKit::ProcessThrottler::Activity::isQuietActivity const):
- Source/WebKit/UIProcess/WebProcessPool.h:
- Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:
(-[WKProcessAssertionBackgroundTaskManager init]):
(-[WKProcessAssertionBackgroundTaskManager _releaseBackgroundTask]):
- Source/WebKit/UIProcess/ios/ProcessStateMonitor.h: Added.
- Source/WebKit/UIProcess/ios/ProcessStateMonitor.mm: Added.
(WebKit::ProcessStateMonitor::ProcessStateMonitor):
(WebKit::ProcessStateMonitor::~ProcessStateMonitor):
(WebKit::ProcessStateMonitor::processDidBecomeRunning):
(WebKit::ProcessStateMonitor::processWillBeSuspended):
(WebKit::ProcessStateMonitor::processWillBeSuspendedImmediately):
(WebKit::ProcessStateMonitor::suspendTimerFired):
(WebKit::ProcessStateMonitor::checkRemainingRunTime):
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/250699@main
- 10:28 AM Changeset in webkit [294404] by
-
- 1 edit in trunk/metadata/contributors.json
Add github account to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240583
Reviewed by Antti Koivisto.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250698@main
- 10:26 AM Changeset in webkit [294403] by
-
- 2 edits in trunk/Tools/CISupport/ews-build
[Commit-Queue] Forbid ChangeLog modification (Follow-up)
https://bugs.webkit.org/show_bug.cgi?id=240461
<rdar://93351783>
Reviewed by Alexey Proskuryakov.
- Tools/CISupport/ews-build/steps.py:
(CleanGitRepo.run): Abort any in progress
git amcommands.
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/250697@main
- 10:01 AM Changeset in webkit [294402] by
-
- 1 edit in trunk/Source/WebKit/Shared/AuxiliaryProcess.h
Fix comment about termination in AuxiliaryProcess
https://bugs.webkit.org/show_bug.cgi?id=240580
Patch by Olivier Blin <Olivier Blin> on 2022-05-18
Reviewed by Chris Dumez.
enableTermination is the one needed to re-enable process termination.
Typo present from initial introduction in r83767.
- Shared/AuxiliaryProcess.h:
Canonical link: https://commits.webkit.org/250696@main
- 9:58 AM Changeset in webkit [294401] by
-
- 1 edit in trunk/metadata/contributors.json
Update contributors.json with GitHub account
https://bugs.webkit.org/show_bug.cgi?id=240584
Reviewed by Tim Nguyen.
Add my GitHub account to the contributors.json file.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250695@main
- 9:55 AM Changeset in webkit [294400] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
[Gardening]: REGRESSION(r294272): [ iOS ] Four http/tests/workers/service/shownotification tests are a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240579
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250694@main
- 9:00 AM Changeset in webkit [294399] by
-
- 57 edits1 copy in trunk/Source
Inline FrameDestructionObserver::frame()
https://bugs.webkit.org/show_bug.cgi?id=240506
Reviewed by Ryosuke Niwa.
Inline FrameDestructionObserver::frame() and it is a trivial getter and it shows on Speedometer
profiles.
- Source/WebKit/Shared/WebsitePoliciesData.cpp:
- Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:
- Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
- Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:
- Source/WebKitLegacy/mac/DOM/DOMInternal.mm:
- Source/WebKitLegacy/mac/WebView/WebDocumentLoaderMac.mm:
- Source/WebCore/Modules/applepay/PaymentSession.cpp:
- Source/WebCore/Modules/beacon/NavigatorBeacon.cpp:
- Source/WebCore/Modules/indexeddb/IDBFactory.cpp:
- Source/WebCore/Modules/mediastream/MediaDevices.cpp:
- Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:
- Source/WebCore/Modules/model-element/HTMLModelElement.cpp:
- Source/WebCore/Modules/notifications/Notification.cpp:
- Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:
- Source/WebCore/Modules/permissions/PermissionStatus.cpp:
- Source/WebCore/Modules/speech/SpeechRecognition.cpp:
- Source/WebCore/Modules/speech/SpeechSynthesis.cpp:
- Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:
- Source/WebCore/Modules/websockets/WebSocket.cpp:
- Source/WebCore/Modules/websockets/WebSocketChannel.cpp:
- Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Source/WebCore/css/FontFaceSet.cpp:
- Source/WebCore/dom/DataTransfer.cpp:
- Source/WebCore/dom/DataTransferMac.mm:
- Source/WebCore/dom/Document.h:
(WebCore::Document::hasBrowsingContext const): Deleted.
- Source/WebCore/dom/DocumentInlines.h:
(WebCore::Document::hasBrowsingContext const):
- Source/WebCore/dom/FullscreenManager.h:
- Source/WebCore/dom/ViewportArguments.cpp:
- Source/WebCore/html/HTMLMediaElement.cpp:
- Source/WebCore/html/parser/HTMLConstructionSite.cpp:
- Source/WebCore/inspector/InspectorAuditResourcesObject.cpp:
- Source/WebCore/inspector/agents/page/PageNetworkAgent.cpp:
- Source/WebCore/loader/ApplicationManifestLoader.cpp:
- Source/WebCore/loader/ResourceLoader.cpp:
- Source/WebCore/page/FrameDestructionObserver.cpp:
(WebCore::FrameDestructionObserver::frame const): Deleted.
- Source/WebCore/page/FrameDestructionObserver.h:
- Source/WebCore/page/FrameDestructionObserverInlines.h: Copied from Source/WebCore/page/FrameDestructionObserver.h.
(WebCore::FrameDestructionObserver::frame const):
- Source/WebCore/page/UserMessageHandlersNamespace.cpp:
- Source/WebCore/rendering/RenderObject.h:
- Source/WebCore/style/StyleBuilderConverter.h:
- Source/WebCore/testing/js/WebCoreTestSupport.cpp:
- Source/WebCore/workers/service/ServiceWorkerClientData.cpp:
- Source/WebCore/xml/XMLTreeViewer.cpp:
- Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:
Canonical link: https://commits.webkit.org/250693@main
- 8:49 AM Changeset in webkit [294398] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
REGRESSION (r294272): [ iOS ] Four http/tests/workers/service/shownotification tests are a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240579
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250692@main
- 8:45 AM Changeset in webkit [294397] by
-
- 15 edits in trunk/Source
Add WebKit API to turn off the URL scheme check when linkifying through Data Detectors
https://bugs.webkit.org/show_bug.cgi?id=239900
<rdar://92026172>
Reviewed by Geoffrey Garen.
This will enable us to block the Mach service com.apple.lsd.open in the WebContent process for all clients.
The URL scheme check is disabled by default for all clients that are not Web browsers. This choice was made
because we know that com.apple.lsd.open can be blocked for Web browsers without disabling the check, since
we already have blocked it there for quite some time without observing any issues. We also have a couple of
examples of other apps, which are not Mail clients, that would need this to be the default behavior.
- Source/WebCore/PAL/pal/cocoa/DataDetectorsCoreSoftLink.h:
- Source/WebCore/PAL/pal/cocoa/DataDetectorsCoreSoftLink.mm:
- Source/WebCore/PAL/pal/spi/cocoa/DataDetectorsCoreSPI.h:
- Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
- Source/WebKit/Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Source/WebKit/Shared/WebProcessCreationParameters.h:
- Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _disableURLSchemeCheckInDataDetectors]):
- Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
- Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::disableURLSchemeCheckInDataDetectors const):
- Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::nonBrowserServices): Deleted.
- Source/WebKit/UIProcess/WebPageProxy.h:
- Source/WebKit/WebProcess/WebProcess.h:
- Source/WebKit/WebProcess/WebProcess.messages.in:
- Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::disableURLSchemeCheckInDataDetectors const):
- Source/WTF/wtf/PlatformHave.h:
Canonical link: https://commits.webkit.org/250691@main
- 7:55 AM Changeset in webkit [294396] by
-
- 1 edit in trunk/LayoutTests/platform/ios/fast/css/continuationCrash-expected.txt
[Gardening]: Rebaseline-[ iOS ] fast/css/continuationCrash.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240069
Unreviewed test gardening.
- LayoutTests/platform/ios/fast/css/continuationCrash-expected.txt:
Canonical link: https://commits.webkit.org/250690@main
- 6:48 AM Changeset in webkit [294395] by
-
- 3 edits in trunk/Source/JavaScriptCore/wasm
[WASM-GC] Rtt types are represented as 64-bit values
Patch by Geza Lore <Geza Lore> on 2022-05-18
https://bugs.webkit.org/show_bug.cgi?id=239493
Reviewed by Yusuke Suzuki.
Rtt types are 64-bit reference-like values, so represent them as
B3::Int64.
- wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::gRtt):
(JSC::Wasm::AirIRGenerator::tmpForType):
(JSC::Wasm::AirIRGenerator::addRttCanon):
- wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::addRttCanon):
- wasm/wasm.json:
# Please populate the above commit message. Lines starting
# with '#' will be ignored
# On branch eng/WASM-GC-Introduce-rtt-types
# Changes to be committed:
# (use "git restore --staged <file>..." to unstage)
# modified: Source/JavaScriptCore/ChangeLog
#
# Untracked files:
# (use "git add <file>..." to include in what will be committed)
# .clion.source.upload.marker
# clion-remote-release/
#
Canonical link: https://commits.webkit.org/250689@main
- 6:10 AM Changeset in webkit [294394] by
-
- 1 edit in trunk/Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp
CoreAudioSharedInternalUnit::set should pass the value pointer directly
https://bugs.webkit.org/show_bug.cgi?id=240565
rdar://93364609
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-18
Reviewed by Eric Carlson.
Manually tested by verifying that https://webrtc.github.io/samples/src/content/getusermedia/audio/ can play the microphone stream
- Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp:
(WebCore::CoreAudioSharedInternalUnit::set):
Pass the pointer to the audio unit and not the pointer's address.
Canonical link: https://commits.webkit.org/250688@main
- 6:06 AM WebKitGTK/2.36.x edited by
- (diff)
- 6:05 AM Changeset in webkit [294393] by
-
- 3 edits in releases/WebKitGTK/webkit-2.36/Source/ThirdParty/ANGLE
Merge r292765 - [GTK][WPE] Build ANGLE with the EGL_NO_PLATFORM_SPECIFIC_TYPES define
https://bugs.webkit.org/show_bug.cgi?id=239039
Reviewed by Adrian Perez de Castro.
Specify the EGL_NO_PLATFORM_SPECIFIC_TYPES define when building ANGLE
subproject for the GTK and WPE ports. This should avoid searching for
platform-specific headers that might not be available at all during
build, e.g. the X11 headers which are used by default on UNIX platforms.
- PlatformGTK.cmake:
- PlatformWPE.cmake:
- 5:59 AM Changeset in webkit [294392] by
-
- 1 edit12 adds in trunk
[web-animations] ensure that animations using offset properties correctly run on a composited layer
https://bugs.webkit.org/show_bug.cgi?id=236709
<rdar://problem/89029756>
Reviewed by Dean Jackson.
Add all the CSS properties related to the CSS Motion Path feature to
RenderLayerCompositor::requiresCompositingForAnimation() in order to
ensure that an element's renderer is composited when one of those
properties is animated.
Tests: webanimations/offset-anchor-animation-yields-compositing.html
webanimations/offset-distance-animation-yields-compositing.html
webanimations/offset-path-animation-yields-compositing.html
webanimations/offset-position-animation-yields-compositing.html
webanimations/offset-rotate-animation-yields-compositing.html
webanimations/offset-shorthand-animation-yields-compositing.html
- Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):
- LayoutTests/webanimations/offset-anchor-animation-yields-compositing-expected.txt: Added.
- LayoutTests/webanimations/offset-anchor-animation-yields-compositing.html: Added.
- LayoutTests/webanimations/offset-distance-animation-yields-compositing-expected.txt: Added.
- LayoutTests/webanimations/offset-distance-animation-yields-compositing.html: Added.
- LayoutTests/webanimations/offset-path-animation-yields-compositing-expected.txt: Added.
- LayoutTests/webanimations/offset-path-animation-yields-compositing.html: Added.
- LayoutTests/webanimations/offset-position-animation-yields-compositing-expected.txt: Added.
- LayoutTests/webanimations/offset-position-animation-yields-compositing.html: Added.
- LayoutTests/webanimations/offset-rotate-animation-yields-compositing-expected.txt: Added.
- LayoutTests/webanimations/offset-rotate-animation-yields-compositing.html: Added.
- LayoutTests/webanimations/offset-shorthand-animation-yields-compositing-expected.txt: Added.
- LayoutTests/webanimations/offset-shorthand-animation-yields-compositing.html: Added.
Canonical link: https://commits.webkit.org/250687@main
- 5:54 AM Changeset in webkit [294391] by
-
- 8 edits in trunk
[web-animations] dynamically toggle acceleration of composition animations depending on ability of animations in the effect stack to be accelerated
https://bugs.webkit.org/show_bug.cgi?id=236708
<rdar://89029577>
Reviewed by Dean Jackson.
We currently don't have support for composite operations at the GraphicsLayerCA level. There are many situations
under which an effect depends on another effect lower in the effect stack, and if that effect fails to run accelerated,
such as due to a non-replace composite operation, we should not run any other effect for that property using
acceleration.
While we could add logic to correctly determine the cases where we actually can run effects using acceleration,
it is a relatively involved task and a simpler, less error-prone approach is to correctly run a whole effect
stack containing some non-replace composite operations without any acceleration.
We already did something similar for cases where we'd fail to run an effect targeting a transform property because
GraphicsLayerCA::addAnimation() would return false. Such situations include using a steps() timing function, a
playback rate other than 1 or providing fewer than 2 animation values.
We now use a single mechanism to deal not only with the case of animations that fail to run using GraphicsLayerCA,
but also with animations that we know GraphicsLayerCA cannot handle, such as non-replace composite operations.
To do this, we change the RunningAccelerated enum to have both "Prevented" and "Failed" values instead of the
single No value to determine the reason why an effect does not accelerated. The "Prevented" value indicates that
the effect stack or the effect itself prevented the effect from running accelerated, while the "Failed" value
indicates that while we attempted to run the animation accelerated through GraphicsLayerCA, we failed to.
We now account for the "Failed" value in preventsAcceleration() to determine that an effect should prevent other
effects from running accelerated. This method is used by KeyframeEffectStack to check that all of its effects
are able to run accelerated and to toggle acceleration based on this value.
As an effect's composite operation or keyframes is set, or when pending accelerated actions are applied, we now
instantiate a CanBeAcceleratedMutationScope which will automatically detect if the preventsAcceleration() value
changes before and after such mutations, and informs the effect stack if that is the case to make sure the effect
stack knows whether it is newly able to run or not run using acceleration.
Finally, to be able to correctly interact with GraphicsLayerCA, we must make sure to reuse the same key when creating
keyframes passed to its animation APIs, so we add a m_keyframesName member.
- Source/WebCore/animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::applyPendingAcceleratedAnimations):
- Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::KeyframeEffect):
(WebCore::KeyframeEffect::copyPropertiesFromSource):
(WebCore::KeyframeEffect::updateBlendingKeyframes):
(WebCore::KeyframeEffect::setBlendingKeyframes):
(WebCore::KeyframeEffect::computeCSSTransitionBlendingKeyframes):
(WebCore::KeyframeEffect::preventsAcceleration const):
(WebCore::KeyframeEffect::updateAcceleratedActions):
(WebCore::KeyframeEffect::addPendingAcceleratedAction):
(WebCore::KeyframeEffect::animationDidChangeTimingProperties):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
(WebCore::KeyframeEffect::setComposite):
(WebCore::KeyframeEffect::effectStackNoLongerPreventsAcceleration):
(WebCore::KeyframeEffect::effectStackNoLongerAllowsAcceleration):
(WebCore::KeyframeEffect::abilityToBeAcceleratedDidChange):
(WebCore::KeyframeEffect::CanBeAcceleratedMutationScope::CanBeAcceleratedMutationScope):
(WebCore::KeyframeEffect::CanBeAcceleratedMutationScope::~CanBeAcceleratedMutationScope):
(WebCore::KeyframeEffect::stopAcceleratingTransformRelatedProperties): Deleted.
- Source/WebCore/animation/KeyframeEffect.h:
- Source/WebCore/animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::addEffect):
(WebCore::KeyframeEffectStack::removeEffect):
(WebCore::KeyframeEffectStack::effectAbilityToBeAcceleratedDidChange):
(WebCore::KeyframeEffectStack::allowsAcceleration const):
(WebCore::KeyframeEffectStack::startAcceleratedAnimationsIfPossible):
(WebCore::KeyframeEffectStack::stopAcceleratedAnimations):
(WebCore::KeyframeEffectStack::stopAcceleratingTransformRelatedProperties): Deleted.
(WebCore::KeyframeEffectStack::containsEffectThatPreventsAccelerationOfEffect): Deleted.
- Source/WebCore/animation/KeyframeEffectStack.h:
- Source/WebCore/animation/WebAnimationTypes.h:
- LayoutTests/webanimations/accelerated-animations-and-composite-expected.txt:
- LayoutTests/webanimations/accelerated-animations-and-composite.html:
Canonical link: https://commits.webkit.org/250686@main
- 5:47 AM WebKitGTK/2.36.x edited by
- (diff)
- 4:24 AM Changeset in webkit [294390] by
-
- 563 adds in trunk/LayoutTests/platform
[LBSE] Run layout tests with LBSE activated
https://bugs.webkit.org/show_bug.cgi?id=239764
Patch by Nikolas Zimmermann <nzimmermann@igalia.com> on 2022-05-18
Reviewed by Rob Buis.
This patch adds two new baselines, that are helpful for LBSE development.
The intention of the patch is to be able to
a) Run pixel tests with legacy SVG engine that pass 100% (... on my machine; no intention to
get pixel tests running' globablly, but it's very helpful for that kind of SVG development).
--> Generate svg/W3C-SVG-1.1 pixel test baseline using my M1 machine running latest macOS Monterey
and only add the *expected.png* files as new 'mac-monterey-wk2-pixel' baseline
$ run-webkit-tests --new-baseline --pixel-tests svg/W3C-SVG-1.1
$ mv LayoutTests/platform/mac-monterey-wk2 LayoutTests/platform/mac-monterey-wk2-pixel
b) Run pixel tests wtih LBSE
LBSE does not need a new pixel test baseline, instead we should match what the legacy engine
produces, only the text dumps are different, due to inherit differences between legacy/LBSE,
such as an additional RenderLayer structure that's now included in the text dumps.
--> Generate svg/W3C-SVG-1.1 text baseline using my M1 machine running latest macOS Monterey
and *LBSE activated* and make them available as new 'mac-monterey-wk2-lbse-text' baseline.
$ run-webkit-tests --new-baseline --internal-feature=LayerBasedSVGEngineEnabled=true svg/W3C-SVG-1.1
$ mv LayoutTests/platform/mac-monterey-wk2 LayoutTests/platform/mac-monterey-wk2-lbse-text
Armed with the new baselines we can now perform testing in three combinations:
- Run pixel tests using legacy SVG engine
$ run-webkit-tests --additional-platform-directory=$PWD/LayoutTests/platform/mac-monterey-wk2-pixel \
--pixel-tests --tolerance=0 svg/W3C-SVG-1.1
By construction, this should succeed.
- Run pixel tests using LBSE
$ run-webkit-tests --additional-platform-directory=$PWD/LayoutTests/platform/mac-monterey-wk2-pixel \
--additional-platform-directory=$PWD/LayoutTests/platform/mac-monterey-wk2-lbse-text \
--additional-expectations=$PWD/LayoutTests/platform/mac-monterey-wk2-lbse-text/TestExpectations \
--pixel-tests --tolerance=0 --internal-feature=LayerBasedSVGEngineEnabled=true svg/W3C-SVG-1.1
The 'TestExpectations' file shall reflect the curent state of LBSE, thus this is always expected to succeed.
- Run A/B testing legacy SVG engine. vs LBSE
$ run-webkit-tests --self-compare-with-header=LayerBasedSVGEngineEnabled=true svg/W3C-SVG-1.1
The new very helpful A/B testing, reveals that LBSE matches 66/278 tests pixel perfect of the SVG 1.1 test suite.
It ignores all existing test expectations and allows us to cross-check the TestExpectations file is correct:
$ cat LayoutTests/platform/mac-monterey-wk2-lbse-text/TestExpectations | grep -v "\[ Pass \]" | grep -v '#' | wc -l
212
$ cat LayoutTests/platform/mac-monterey-wk2-lbse-text/TestExpectations | grep "\[ Pass \]" | wc -l
66
That perfectly matches the expectations.
Evertything is ready to run tests on dedicated bots and integrate LBSE in upstream CI.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/TestExpectations: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-lbse-text/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-04-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-05-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-07-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-09-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-10-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-12-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-14-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-15-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-16-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-17-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-18-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-19-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-20-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-25-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-27-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/animate-elem-85-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/color-prof-01-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/color-prop-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/color-prop-02-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/color-prop-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-offset-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/interact-dom-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/interact-events-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/interact-order-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/interact-order-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/interact-order-03-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/linking-a-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/linking-a-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/linking-a-04-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/linking-a-05-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/linking-a-07-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/masking-path-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/masking-path-03-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/masking-path-05-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-fill-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-fill-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-fill-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-fill-04-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-fill-05-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-render-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-04-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-05-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-07-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-08-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-09-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-10-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-13-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-14-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/paths-data-15-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/render-elems-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/render-elems-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/render-elems-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/script-handle-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/script-handle-03-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/shapes-line-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-cond-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-cond-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-defs-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-dom-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-dom-04-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-dom-05-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-frag-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-frag-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-frag-04-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-group-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-group-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-image-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-image-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-image-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-image-04-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-image-05-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-image-06-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-image-07-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-image-09-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-use-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-use-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/struct-use-05-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/styling-css-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/styling-css-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/styling-css-03-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/styling-css-04-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/styling-css-05-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/styling-css-06-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/styling-pres-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-align-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-align-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-align-03-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-align-04-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-align-05-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-align-06-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-deco-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-fonts-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-fonts-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-path-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-text-03-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-text-06-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-text-07-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-text-08-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-tref-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-tselect-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-ws-01-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/text-ws-02-t-expected.png: Added.
- LayoutTests/platform/mac-monterey-wk2-pixel/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png: Added.
Canonical link: https://commits.webkit.org/250684@main
- 4:23 AM Changeset in webkit [294389] by
-
- 2 edits in trunk/Source
ENABLE_LAYER_BASED_SVG_ENGINE needs to match for iOS and macOS
https://bugs.webkit.org/show_bug.cgi?id=239877
<rdar://problem/92829309>
Patch by Nikolas Zimmermann <nzimmermann@igalia.com> on 2022-05-18
Reviewed by Simon Fraser.
Switch on ENABLE_LAYER_BASED_SVG_ENGINE for all Cocoa based platforms.
This only works after fixing one build issue:
hasTransform() now needs hasSVGTransform(), when in turn uses rareData(), which
is not exported by WebCore at present breaking tvOS/watchOS/iOS builds, fix that.
Covered by existing tests, no change in behaviour.
- Source/WTF/wtf/PlatformEnableCocoa.h:
- Source/WebCore/rendering/RenderObject.h:
- 3:43 AM Changeset in webkit [294388] by
-
- 1 copy in releases/WPE WebKit/webkit-2.36.2
WPE WebKit 2.36.2
- 3:43 AM Changeset in webkit [294387] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.36.2 release
.:
- Source/cmake/OptionsWPE.cmake: Bump version numbers.
Source/WebKit:
- wpe/NEWS: Add release notes for 2.36.2.
- 2:01 AM Changeset in webkit [294386] by
-
- 1 edit in trunk/LayoutTests/platform/mac-wk1/TestExpectations
[ macOS wk1 ] http/wpt/fetch/navigation-post-to-get-origin.html hits a flaky assertion in invokeReadableStreamDefaultControllerFunction
https://bugs.webkit.org/show_bug.cgi?id=230693
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-18
Unreviewed.
- LayoutTests/platform/mac-wk1/TestExpectations:
Canonical link: https://commits.webkit.org/250683@main
- 1:47 AM Changeset in webkit [294385] by
-
- 10 edits in trunk/Source/WebCore
Activate text rendering, by re-using RenderSVGText
https://bugs.webkit.org/show_bug.cgi?id=239743
Patch by Nikolas Zimmermann <nzimmermann@igalia.com> on 2022-05-18
Reviewed by Rob Buis.
Adapt RenderSVGText to be usable at the same time from legacy SVG engine (as
it is right now) and from LBSE. This requires minimal effort, since RenderSVGText
already inherited from RenderLayerModelObject, so there's no need for the creation
of LegacyRenderSVGText / RenderSVGText as separated legacy/LBSE implementations.
Most SVG 1.1 <text> testcases already pass out of the box with this change.
The next patch after text support will add a new 'macos-wk2-lbse-xxx' specific
platform baseline, so that we can run tests LBSE againt iself (finally we can
include the progressions in the form of TestExpectation file changes, once a certain
patch implements a new feature in LBSE. This makes sense now as enough is upstreamed
that a considerable amount of the SVG 1.1 testsuite already passes pixel perfect.
Covered by existing tests, no change in behaviour. (However testability for LBSE is ready soon!).
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::computeVisibleRectInSVGContainer const):
- rendering/RenderObject.cpp:
(WebCore::objectIsRelayoutBoundary):
- rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::updateFromStyle):
(WebCore::RenderSVGBlock::absoluteRects const):
(WebCore::RenderSVGBlock::absoluteQuads const):
(WebCore::RenderSVGBlock::styleDidChange):
(WebCore::RenderSVGBlock::computeOverflow):
(WebCore::RenderSVGBlock::clippedOverflowRect const):
(WebCore::RenderSVGBlock::computeVisibleRectInContainer const):
(WebCore::RenderSVGBlock::computeFloatVisibleRectInContainer const):
(WebCore::RenderSVGBlock::pushMappingToContainer const):
(WebCore::RenderSVGBlock::offsetFromContainer const):
(WebCore::RenderSVGBlock::nodeAtPoint): Deleted.
- rendering/svg/RenderSVGBlock.h:
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::RenderSVGText):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::nodeAtFloatPoint):
(WebCore::RenderSVGText::nodeAtPoint):
(WebCore::RenderSVGText::paint):
(WebCore::RenderSVGText::repaintRectInLocalCoordinates const):
(WebCore::RenderSVGText::updatePositionAndOverflow):
(WebCore::RenderSVGText::absoluteQuads const): Deleted.
- rendering/svg/RenderSVGText.h:
- rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::renderSVGText const):
(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::layoutRootBox):
(WebCore::SVGRootInlineBox::renderSVGText): Deleted.
- rendering/svg/SVGRootInlineBox.h:
- svg/SVGElement.cpp:
(WebCore::createSVGLayerAwareElementSet):
Canonical link: https://commits.webkit.org/250682@main
- 12:18 AM Changeset in webkit [294384] by
-
- 1 edit in trunk/Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp
Unreviewed, non-unified build fixes after r294166
May 17, 2022:
- 11:26 PM Changeset in webkit [294383] by
-
- 13 edits in trunk/Source/WebCore
Template TextBoxPainter on line layout path
https://bugs.webkit.org/show_bug.cgi?id=240416
Reviewed by Alan Bujtas.
Painting currently goes via a line layout path agnostic iterator.
This is inefficient since we always know what sort of layout we are painting.
- Source/WebCore/layout/integration/inline/InlineIteratorBox.cpp:
(WebCore::InlineIterator::Box::visualRect const):
- Source/WebCore/layout/integration/inline/InlineIteratorBox.h:
(WebCore::InlineIterator::Box::containingBlock const):
(WebCore::InlineIterator::Box::visualRect const): Deleted.
- Source/WebCore/layout/integration/inline/InlineIteratorBoxLegacyPath.h:
(WebCore::InlineIterator::BoxLegacyPath::containingBlock const):
(WebCore::InlineIterator::BoxLegacyPath::direction const):
(WebCore::InlineIterator::BoxLegacyPath::isFirstLine const):
- Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h:
(WebCore::InlineIterator::BoxModernPath::containingBlock const):
(WebCore::InlineIterator::BoxModernPath::direction const):
(WebCore::InlineIterator::BoxModernPath::isFirstLine const):
(WebCore::InlineIterator::BoxModernPath::renderText const):
- Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::paint):
- Source/WebCore/rendering/GlyphDisplayListCache.h:
(WebCore::GlyphDisplayListCache::singleton):
- Source/WebCore/rendering/InlineBoxPainter.cpp:
(WebCore::InlineBoxPainter::paintMask):
(WebCore::InlineBoxPainter::paintDecorations):
- Source/WebCore/rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::addTextBoxVisualOverflow):
- Source/WebCore/rendering/LegacyInlineTextBox.cpp:
(WebCore::LegacyInlineTextBox::paint):
- Source/WebCore/rendering/LegacyInlineTextBox.h:
- Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
- Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::LegacyTextBoxPainter::LegacyTextBoxPainter):
(WebCore::ModernTextBoxPainter::ModernTextBoxPainter):
(WebCore::TextBoxPainter<TextBoxPath>::TextBoxPainter):
(WebCore::TextBoxPainter<TextBoxPath>::~TextBoxPainter):
(WebCore::TextBoxPainter<TextBoxPath>::makeIterator const):
(WebCore::TextBoxPainter<TextBoxPath>::paint):
(WebCore::TextBoxPainter<TextBoxPath>::createMarkedTextFromSelectionInBox):
(WebCore::TextBoxPainter<TextBoxPath>::paintBackground):
(WebCore::TextBoxPainter<TextBoxPath>::paintForegroundAndDecorations):
(WebCore::TextBoxPainter<TextBoxPath>::paintCompositionBackground):
(WebCore::TextBoxPainter<TextBoxPath>::paintForeground):
(WebCore::TextBoxPainter<TextBoxPath>::createDecorationPainter):
(WebCore::TextBoxPainter<TextBoxPath>::paintBackgroundDecorations):
(WebCore::TextBoxPainter<TextBoxPath>::paintForegroundDecorations):
(WebCore::TextBoxPainter<TextBoxPath>::paintCompositionUnderlines):
(WebCore::TextBoxPainter<TextBoxPath>::textPosition):
(WebCore::TextBoxPainter<TextBoxPath>::paintCompositionUnderline):
(WebCore::TextBoxPainter<TextBoxPath>::paintPlatformDocumentMarkers):
(WebCore::LegacyTextBoxPainter::calculateUnionOfAllDocumentMarkerBounds):
(WebCore::TextBoxPainter<TextBoxPath>::paintPlatformDocumentMarker):
(WebCore::TextBoxPainter<TextBoxPath>::computePaintRect):
(WebCore::calculateDocumentMarkerBounds):
(WebCore::TextBoxPainter<TextBoxPath>::computeHaveSelection const):
(WebCore::TextBoxPainter<TextBoxPath>::fontCascade const):
(WebCore::TextBoxPainter<TextBoxPath>::textOriginFromPaintRect const):
(WebCore::TextBoxPainter<TextBoxPath>::debugTextShadow const):
(WebCore::TextBoxPainter::TextBoxPainter): Deleted.
(WebCore::TextBoxPainter::~TextBoxPainter): Deleted.
(WebCore::TextBoxPainter::paint): Deleted.
(WebCore::TextBoxPainter::createMarkedTextFromSelectionInBox): Deleted.
(WebCore::TextBoxPainter::paintBackground): Deleted.
(WebCore::TextBoxPainter::paintForegroundAndDecorations): Deleted.
(WebCore::TextBoxPainter::paintCompositionBackground): Deleted.
(WebCore::TextBoxPainter::paintForeground): Deleted.
(WebCore::TextBoxPainter::createDecorationPainter): Deleted.
(WebCore::TextBoxPainter::paintBackgroundDecorations): Deleted.
(WebCore::TextBoxPainter::paintForegroundDecorations): Deleted.
(WebCore::TextBoxPainter::paintCompositionUnderlines): Deleted.
(WebCore::textPosition): Deleted.
(WebCore::TextBoxPainter::paintCompositionUnderline): Deleted.
(WebCore::TextBoxPainter::paintPlatformDocumentMarkers): Deleted.
(WebCore::TextBoxPainter::calculateUnionOfAllDocumentMarkerBounds): Deleted.
(WebCore::TextBoxPainter::paintPlatformDocumentMarker): Deleted.
(WebCore::TextBoxPainter::computePaintRect): Deleted.
(WebCore::TextBoxPainter::calculateDocumentMarkerBounds): Deleted.
(WebCore::TextBoxPainter::computeHaveSelection const): Deleted.
(WebCore::TextBoxPainter::fontCascade const): Deleted.
(WebCore::TextBoxPainter::textOriginFromPaintRect const): Deleted.
(WebCore::TextBoxPainter::debugTextShadow const): Deleted.
- Source/WebCore/rendering/TextBoxPainter.h:
(WebCore::TextBoxPainter::textBox const):
- 9:47 PM Changeset in webkit [294382] by
-
- 1 edit in trunk/metadata/contributors.json
Add jgriego to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240525
Patch by Joseph Griego <jgriego@igalia.com> on 2022-05-17
Reviewed by Tim Nguyen.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250679@main
- 8:23 PM Changeset in webkit [294381] by
-
- 12 edits in trunk/Source/WebKit/UIProcess
WebProcessProxy should not hold WebsiteDataStore alive when there is no page
https://bugs.webkit.org/show_bug.cgi?id=238892
<rdar://problem/91715517>
Reviewed by Youenn Fablet.
WebProcessProxy can outlive WebPageProxy, and because WebProcessProxy holds strong reference to WebsiteDataStore,
WebsiteDataStore will be kept alive even when it's not used by any page and will not be used by any page.
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::createGPUProcessConnection):
- UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::~ProvisionalPageProxy):
- UIProcess/ProvisionalPageProxy.h:
- UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::findReusableSuspendedPageProcess):
- UIProcess/WebBackForwardCache.cpp:
(WebKit::WebBackForwardCache::removeEntriesForSession):
- UIProcess/WebLockRegistryProxy.cpp:
(WebKit::WebLockRegistryProxy::requestLock):
(WebKit::WebLockRegistryProxy::releaseLock):
(WebKit::WebLockRegistryProxy::abortLockRequest):
(WebKit::WebLockRegistryProxy::snapshot):
(WebKit::WebLockRegistryProxy::clientIsGoingAway):
(WebKit::WebLockRegistryProxy::processDidExit):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::swapToProvisionalPage):
(WebKit::WebPageProxy::commitProvisionalPage):
- UIProcess/WebProcessCache.cpp:
(WebKit::WebProcessCache::canCacheProcess const):
(WebKit::WebProcessCache::takeProcess):
(WebKit::WebProcessCache::clearAllProcessesForSession):
(WebKit::WebProcessCache::CachedProcess::CachedProcess):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::establishRemoteWorkerContextConnectionToNetworkProcess):
(WebKit::WebProcessPool::processForRegistrableDomain):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::processForNavigationInternal):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::m_webLockRegistry):
(WebKit::WebProcessProxy::websiteDataStore const):
(WebKit::WebProcessProxy::setWebsiteDataStore):
(WebKit::WebProcessProxy::isDummyProcessProxy const):
(WebKit::WebProcessProxy::updateRegistrationWithDataStore):
(WebKit::WebProcessProxy::addExistingWebPage):
(WebKit::WebProcessProxy::getNetworkProcessConnection):
(WebKit::WebProcessProxy::didStartProvisionalLoadForMainFrame):
(WebKit::WebProcessProxy::sessionID const):
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::websiteDataStore const): Deleted.
- UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
- 7:19 PM Changeset in webkit [294380] by
-
- 1 edit in trunk/metadata/contributors.json
Add myself (Asumu Takikawa) to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240546
Patch by Asumu Takikawa <asumu@igalia.com> on 2022-05-17
Reviewed by Yusuke Suzuki.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250677@main
- 6:45 PM Changeset in webkit [294379] by
-
- 1 edit in trunk/Tools/glib/generate-pdfjs-gresource-manifest.py
[WPE][GTK] generate-pdfjs-gresource-manifest.py should be more careful about unknown files
https://bugs.webkit.org/show_bug.cgi?id=240536
Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-17
Reviewed by Adrian Perez de Castro.
Instead of silently ignoring unexpected files, let's create a list of
all files that we do not want to include in the resource manifest.
Anything unexpected will result in a build failure so that there are no
mistakes.
Also, change the lists at the top of the script into sets. Adrian
noticed that they do not need to be ordered.
- Tools/glib/generate-pdfjs-gresource-manifest.py:
(get_filenames):
(get_filenames.should_ignore_resource): Deleted.
Canonical link: https://commits.webkit.org/250668@main
- 6:43 PM Changeset in webkit [294378] by
-
- 5 edits in trunk/Tools/Scripts/libraries/webkitscmpy
Reverting https://trac.webkit.org/r294367, as some of our automation hosts don't
have the --date=unix option.
Reviewed by NOBODY (OOPS!).
- Scripts/libraries/webkitscmpy/setup.py:
- Scripts/libraries/webkitscmpy/webkitscmpy/init.py:
- Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.Cache.populate):
(Git.commit):
(Git._args_from_content):
(Git.commits):
- Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
- Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(TestGit.test_log):
- 6:42 PM Changeset in webkit [294377] by
-
- 1 edit in trunk/Source/WebCore/page/win/ResourceUsageThreadWin.cpp
[WinCairo] Add memory usage of LibcMalloc category
https://bugs.webkit.org/show_bug.cgi?id=239660
Reviewed by Ross Kirsling.
WinCairo's memory timeline just displays JavaScript memory usage. Adding
this info shows also Page
memory usage.
- page/win/ResourceUsageThreadWin.cpp:
(WebCore::ResourceUsageThread::platformCollectMemoryData):
Canonical link: https://commits.webkit.org/250668@main
- 6:37 PM Changeset in webkit [294376] by
-
- 3 edits in trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy
[git-webkit] Make git-webkit revert a two step workflow
https://bugs.webkit.org/show_bug.cgi?id=240192
rdar://92875608
Reviewed by Jonathan Bedard.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.create_pull_request):
(PullRequest.add_comment_to_reverted_commit_bug_tracker):
(PullRequest.is_revert_commit):
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/revert.py:
(Revert):
(Revert.parser):
(Revert.revert_commit):
(Revert.main):
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py:
(TestRevert.test_github):
(test_update):
Canonical link: https://commits.webkit.org/250668@main
- 6:20 PM Changeset in webkit [294375] by
-
- 1 copy in tags/WebKit-7614.1.14.100.1
Tag WebKit-7614.1.14.100.1.
- 6:17 PM Changeset in webkit [294374] by
-
- 9 edits3 adds in trunk
Web Inspector: support EventSource resource type in Network Panel
https://bugs.webkit.org/show_bug.cgi?id=240326
Reviewed by Devin Rousso.
- http/tests/inspector/network/eventsource-type-expected.txt: Added.
- http/tests/inspector/network/eventsource-type.html: Added.
- http/tests/inspector/network/resources/event-source.py: Added.
Web Inspector: support EventSource resource type in Network Panel
https://bugs.webkit.org/show_bug.cgi?id=240326
- inspector/protocol/Page.json: added EventSource resource type.
Web Inspector: support EventSource resource type in Network Panel
https://bugs.webkit.org/show_bug.cgi?id=240326
Network requests initiated by EventSource now have their own requester
type which allows to distinguish them from other requests.
Test: http/tests/inspector/network/eventsource-type.html
- inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::resourceTypeJSON):
(WebCore::InspectorPageAgent::inspectorResourceType):
- inspector/agents/InspectorPageAgent.h:
- page/EventSource.cpp:
(WebCore::EventSource::connect):
- platform/network/ResourceRequestBase.h:
Web Inspector: support EventSource resource type in Network Panel
https://bugs.webkit.org/show_bug.cgi?id=240326
EventSource initiated requests are now displayed with their own type
in the network panel.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Controllers/NetworkManager.js:
(WI.NetworkManager.prototype.canBeOverridden):
- UserInterface/Models/Resource.js:
(WI.Resource.displayNameForType):
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.displayNameForResource):
Canonical link: https://commits.webkit.org/250668@main
- 6:09 PM Changeset in webkit [294373] by
-
- 3 edits in trunk/Source/WebCore/Modules/WebGPU
[WebGPU] Work around https://bugs.webkit.org/show_bug.cgi?id=240219
https://bugs.webkit.org/show_bug.cgi?id=240441
https://bugs.webkit.org/show_bug.cgi?id=240219 is about a bug where we can't
say "optional thingy = 0" in an IDL file. This patch works around that in WebGPU
by replacing it with "optional thingy" and then "thingy.value_or(0)" in the C++
code. This is temporary, until https://bugs.webkit.org/show_bug.cgi?id=240219 is
fixed.
No new tests because there is no behavior change.
- Modules/WebGPU/GPUBuffer.cpp:
(WebCore::GPUBuffer::mapAsync):
(WebCore::GPUBuffer::getMappedRange):
- Modules/WebGPU/GPUBuffer.h:
- Modules/WebGPU/GPUBuffer.idl:
Canonical link: https://commits.webkit.org/250668@main
- 5:59 PM Changeset in webkit [294372] by
-
- 1 copy in tags/WebKit-7614.1.14.11.2
Tag WebKit-7614.1.14.11.2.
- 5:55 PM Changeset in webkit [294371] by
-
- 5 edits in trunk/Source/WebKit
Private relay should fail closed for third party loads if the main resource was loaded over private relay
https://bugs.webkit.org/show_bug.cgi?id=240483
<rdar://92697007>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-17
Reviewed by Chris Dumez.
This re-lands the change from r293861 along with r293481 which should fix problems related to rdar://92336270
along with r293591 which should fix performance regressions related to rdar://92458995 but was insufficient.
During a basic browsing test, I found two more places where we were making a NetworkDataTask without setting the
parameters' top origin, one in the SpeculativeLoad constructor and another in WebLoaderStrategy::preconnectTo.
- Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp:
(WebKit::NetworkCORSPreflightChecker::startPreflight):
- Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):
- Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
- Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(WebKit::NetworkSessionCocoa::createWebSocketTask):
- Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::preconnectTo):
- 5:50 PM Changeset in webkit [294370] by
-
- 9 edits in branches/safari-7614.1.14.11-branch/Source
Versioning.
WebKit-7614.1.14.11.2
- 5:37 PM Changeset in webkit [294369] by
-
- 1 edit in trunk/Source/WebCore/platform/graphics/FontCascade.cpp
Stop using ASCIILiteral::fromLiteralUnsafe() in FontCascade.cpp https://bugs.webkit.org/show_bug.cgi?id=240548
Reviewed by Myles C. Maxfield.
Stop using ASCIILiteral::fromLiteralUnsafe() in FontCascade.cpp and use ASCIILiteral
directly.
- Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::useBackslashAsYenSignForFamily):
Canonical link: https://commits.webkit.org/250668@main
- 5:27 PM Changeset in webkit [294368] by
-
- 9 edits in branches/safari-7614.1.12-branch/Source
Versioning.
WebKit-7614.1.12.5
- 5:20 PM Changeset in webkit [294367] by
-
- 5 edits in trunk/Tools/Scripts/libraries/webkitscmpy
[git-webkit] Use --date=unix in log commands
https://bugs.webkit.org/show_bug.cgi?id=240537
Reviewed by Stephanie Lewis.
Override any local configuration for git log's date format,
use a simpler date format.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git.Cache.populate): Use --date=unix.
(Git.commit): Ditto.
(Git._args_from_content): Parse --date=unix.
(Git.commits): Use --date=unix.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py:
(TestGit.test_log):
Canonical link: https://commits.webkit.org/250668@main
- 5:05 PM Changeset in webkit [294366] by
-
- 1 copy in tags/WebKit-7614.1.14.0.3
Tag WebKit-7614.1.14.0.3.
- 4:58 PM Changeset in webkit [294365] by
-
- 1 copy in tags/WebKit-7614.1.14.1.3
Tag WebKit-7614.1.14.1.3.
- 4:54 PM Changeset in webkit [294364] by
-
- 1 edit in trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c
[libpas] Suppress warnings for %llu format specifier for uint64_t.
https://bugs.webkit.org/show_bug.cgi?id=240541
Reviewed by Yusuke Suzuki.
Use PRIu64 instead.
- libpas/src/libpas/pas_utils.c:
(pas_assertion_failed_no_inline_with_extra_detail):
Canonical link: https://commits.webkit.org/250667@main
- 4:50 PM Changeset in webkit [294363] by
-
- 1 edit in trunk/LayoutTests/platform/ios/TestExpectations
[Gardening]: REGRESSION (r294215): [ iOS ] Nine focus ring tests are a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=240495
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250666@main
- 4:45 PM Changeset in webkit [294362] by
-
- 1 edit in trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
[macOS][WP] Add required methods to graphics filters
https://bugs.webkit.org/show_bug.cgi?id=240398
<rdar://92460835>
Reviewed by Geoffrey Garen.
Add required methods to graphics filters. These have been observed being used in telemetry.
- Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:
Canonical link: https://commits.webkit.org/250665@main
- 4:23 PM Changeset in webkit [294361] by
-
- 3 edits in trunk/Source/JavaScriptCore/inspector/remote
[Cocoa] Web Driver:
RemoteAutomationTargets marked for termination and targets that have never been paired may briefly be indistinguishable in application target listing
https://bugs.webkit.org/show_bug.cgi?id=240524
<rdar://93430106>
Reviewed by BJ Burg and Devin Rousso.
A
RemoteAutomationTargethas multiple possible entries it may provide in an application listing to webinspectord,
which are then interpreted by webinspectord to determine the current state of that target. The key pieces for this bug
are that aWIRConnectionIdentifierKeywhich when present is taken to mean that the target is no longer pristine and
WIRAutomationTargetIsPairedKeywhich when true indicates that the target is paired. When a connection identifier is
present and we are no longer paired, the connection is considered terminated.
There exists a race condition where webinspectord preemptively set the targets state to "Terminated" upon sending a
close request in order to make sure that the target is no longer used. Upon receiving the close message for the target
the connection identifier is removed from the map of known connection identifiers before scheduling the actual target to
be torn down asyncronously. In most cases this works fine, but sometimes an application listing is created and sent
between removing the identifier from the map of known connections and actually tearing down the target, and that is
where this issue occurs. We will in that case send a listing for the automation target with no connection identifier
(since we removed it from the map already), which is then interpreted as a listing for a pristine automation target. At
that point, it is possible that automation sessions that are being rapidly created and destroyed will attempt to pair
with the seemingly pristine existing session, even though that session is about to be torn down.
- Source/JavaScriptCore/inspector/remote/RemoteAutomationTarget.h:
- Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:
(Inspector::RemoteConnectionToTarget::close):
- Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm:
(Inspector::RemoteInspector::listingForAutomationTarget const):
Canonical link: https://commits.webkit.org/250664@main
- 4:19 PM Changeset in webkit [294360] by
-
- 1 copy in releases/WebKitGTK/webkit-2.36.2
WebKitGTK 2.36.2
- 4:17 PM Changeset in webkit [294359] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.2 release
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
- gtk/NEWS: Add release notes for 2.36.2.
- 4:17 PM Changeset in webkit [294358] by
-
- 1 edit in trunk/Tools/Scripts/check-for-invalid-symbols-in-version-script
[Python3] Fix Tools/Scripts/check-for-invalid-symbols-in-version-script
https://bugs.webkit.org/show_bug.cgi?id=240543
Reviewed by Michael Catanzaro.
- Tools/Scripts/check-for-invalid-symbols-in-version-script: Change shebang to use "python3", and pass an "encoding" argument to the Popen constructor to read strings instead of bytes from the subprocess pipe.
Canonical link: https://commits.webkit.org/250663@main
- 4:17 PM Changeset in webkit [294357] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Tools
Fix Tools/Scripts/check-for-invalid-symbols-in-version-script
https://bugs.webkit.org/show_bug.cgi?id=240543
Unreviewed build fix.
- Tools/Scripts/check-for-invalid-symbols-in-version-script: Change
shebang to use "python3", and pass an "encoding" argument to the Popen
constructor to read strings instead of bytes from the subprocess pipe.
- 4:17 PM Changeset in webkit [294356] by
-
- 7 edits in releases/WebKitGTK/webkit-2.36/Tools
Merge r290799 - [Python3] Switch a few more glib scripts to Python3
https://bugs.webkit.org/show_bug.cgi?id=237442
Reviewed by Adrian Perez de Castro.
- Scripts/check-for-global-bss-symbols-in-webkitgtk-libs: Update
shebang.
(bss_symbols): Decode Popen bytes output.
- gtk/jhbuildrc: Update shebang.
- gtk/ycm_extra_conf.py: Ditto.
- jhbuild/jhbuild-wrapper: Ditto.
(jhbuild_at_expected_revision): Decode Popen bytes output.
- jhbuild/jhbuildrc_common.py: Remove uneeded shebang.
- wpe/jhbuildrc: Update shebang.
- 3:41 PM Changeset in webkit [294355] by
-
- 1 edit in trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h
Don't synchronously flush when destroying RemoteImageBufferProxy
Reviewed by Said Abou-Hallawa.
No correctness tests added, since this should just be a performance improvement.
- WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
(WebKit::RemoteImageBufferProxy::~RemoteImageBufferProxy):
- 3:31 PM Changeset in webkit [294354] by
-
- 1 delete in trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints
[Gardening]: REGRESSION (r294317): [ iOS ] Eight imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation are a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240538
Unreviewed test gardening.
- LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt: Removed.
- LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Removed.
- LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt: Removed.
- LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt: Removed.
- LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt: Removed.
- LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: Removed.
- LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Removed.
- LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Removed.
Canonical link: https://commits.webkit.org/250661@main
- 3:11 PM Changeset in webkit [294353] by
-
- 2 edits in trunk/Tools/Scripts/webkitpy/style/checkers
check-webkit-style: allow all upper case value in ResourceRequestBase::Requester
https://bugs.webkit.org/show_bug.cgi?id=240532
Reviewed by Devin Rousso.
- Tools/Scripts/webkitpy/style/checkers/cpp.py:add style checker exception for
ResourceRequestBase::Requester enum as it contains XHR value which is all
upper case.
- Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(NoNonVirtualDestructorsTest):
Canonical link: https://commits.webkit.org/250660@main
- 3:08 PM Changeset in webkit [294352] by
-
- 1 copy in tags/WebKit-7614.1.12.4
Tag WebKit-7614.1.12.4.
- 3:00 PM Changeset in webkit [294351] by
-
- 2 edits in trunk/Tools/Scripts/webkitpy/style/checkers
check-webkit-style: validate enums declared with explicit type
https://bugs.webkit.org/show_bug.cgi?id=240478
Reviewed by Devin Rousso.
check-webkit-style now validates case of the enums delcared with explicit
type specifier.
- Tools/Scripts/webkitpy/style/checkers/cpp.py:
(_EnumState.process_clean_line):
- Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(NoNonVirtualDestructorsTest):
Canonical link: https://commits.webkit.org/250659@main
- 2:34 PM Changeset in webkit [294350] by
-
- 2 edits in branches/safari-7614.1.14.1-branch/Source/WebCore/accessibility/isolatedtree
Cherry-pick r294328. rdar://problem/92822756
AX: Lazily retrieve AXPropertyName::SupportsPressAction, AXPropertyName::ColumnHeaders, and AXPropertyName::RowHeaders
https://bugs.webkit.org/show_bug.cgi?id=240473
Reviewed by Chris Fleizach.
These properties can be expensive to compute up-front, so retrieve them
lazily.
No test because there is no user-facing behavior change.
- accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::initializeProperties): (WebCore::AXIsolatedObject::getOrRetrievePropertyValue): (WebCore::AXIsolatedObject::columnHeaders): (WebCore::AXIsolatedObject::rowHeaders): (WebCore::AXIsolatedObject::supportsPressAction const):
- accessibility/isolatedtree/AXIsolatedObject.h:
Canonical link: https://commits.webkit.org/250648@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:34 PM Changeset in webkit [294349] by
-
- 7 edits in branches/safari-7614.1.14.1-branch
Cherry-pick r294285. rdar://problem/93385094
Demote -[WKWebView retrieveAccessibilityTreeData:] to SPI
https://bugs.webkit.org/show_bug.cgi?id=240494
rdar://93385094
Reviewed by Tim Horton.
This method was only intended for use in MiniBrowser, and should ship as public API on WKWebView. Move the
declaration and implementation of this over to WKWebViewPrivateForTestingMac.h and WKWebViewTestingMac.mm
(respectively), and additionally prefix this testing-only SPI with an underscore.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView retrieveAccessibilityTreeData:]): Deleted.
- UIProcess/API/mac/WKWebViewPrivateForTestingMac.h:
- UIProcess/API/mac/WKWebViewTestingMac.mm: (-[WKWebView _retrieveAccessibilityTreeData:]): Demote -[WKWebView retrieveAccessibilityTreeData:] to SPI https://bugs.webkit.org/show_bug.cgi?id=240494 rdar://93385094
Reviewed by Tim Horton.
See WebKit/ChangeLog for more details.
- MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController logAccessibilityTrees:]):
Canonical link: https://commits.webkit.org/250629@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:34 PM Changeset in webkit [294348] by
-
- 66 edits2 adds2 deletes in branches/safari-7614.1.14.1-branch/Source/WebKit
Cherry-pick r294190. rdar://problem/91006582
SharedBuffer should be copied and then attributed back to WebContent
https://bugs.webkit.org/show_bug.cgi?id=240223
rdar://91006582
Patch by Jean-Yves Avenard <jean-yves.avenard@apple.com> on 2022-05-14
Reviewed by Jer Noble.
Ideally, when mapping an IPCHandle we would prefer to use Copy On Write.
However, there's no support for COW with explicitly-owned memory such as
those created with VM_FLAGS_PURGABLE flag.
As such, when calling mach_vm_map with copy=true argument is set the
entire page will be copied.
It is therefore more performant to manually create a new buffer and copy
the actual content.
The memory can then be blamed on a particular process.
Rework FragmentedSharedBuffer/SharedBuffer IPC's serializer to perform
a copy, partially reverting changes made in bug 233401.
We replace the unnecessary use of SharedMemory::IPCHandle and directly
send SharedBuffer in clipboard and PDF related methods.
Rename SharedBufferCopy to SharedBufferReference to more accurately
describe what it does.
Make new use of the SharedBufferReference class, replacing the use of IPCHandle
in RemoteSourceBufferProxy and RemoteMediaResourceManager.
Rename SharedBufferReference::buffer() into
SharedBufferReference::unsafeBuffer() to give better clarity that accessing
SharedBuffer and SharedMemory should be treated with care.
SharedBuffer sent from trusted processes such as network process should
prefer the use of SharedBufferReference over directly using IPCHandle or
SharedBuffer, it makes optimisation easier and avoid duplicating code.
No observable change, covered by existing tests.
- GPUProcess/GPUConnectionToWebProcess.cpp: (WebKit::GPUConnectionToWebProcess::remoteMediaResourceManager):
- GPUProcess/media/RemoteCDMInstanceProxy.h:
- GPUProcess/media/RemoteImageDecoderAVFProxy.cpp: (WebKit::RemoteImageDecoderAVFProxy::createDecoder): (WebKit::RemoteImageDecoderAVFProxy::setData):
- GPUProcess/media/RemoteImageDecoderAVFProxy.h:
- GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in:
- GPUProcess/media/RemoteMediaResourceManager.cpp: (WebKit::RemoteMediaResourceManager::RemoteMediaResourceManager): (WebKit::RemoteMediaResourceManager::dataReceived):
- GPUProcess/media/RemoteMediaResourceManager.h:
- GPUProcess/media/RemoteMediaResourceManager.messages.in:
- GPUProcess/media/RemoteSourceBufferProxy.cpp: (WebKit::RemoteSourceBufferProxy::append):
- GPUProcess/media/RemoteSourceBufferProxy.h:
- GPUProcess/media/RemoteSourceBufferProxy.messages.in:
- NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::bufferingTimerFired): (WebKit::NetworkResourceLoader::sendBuffer): (WebKit::NetworkResourceLoader::dataReceivedThroughContentFilter):
- NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.cpp: (WebKit::ServiceWorkerDownloadTask::didReceiveData):
- NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h:
- NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.messages.in:
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp: (WebKit::ServiceWorkerFetchTask::didReceiveData): (WebKit::ServiceWorkerFetchTask::loadBodyFromPreloader):
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in:
- Platform/IPC/SharedBufferCopy.cpp: Removed.
- Platform/IPC/SharedBufferCopy.h: Removed.
- Platform/IPC/SharedBufferReference.cpp: Added. (IPC::SharedBufferReference::encode const): (IPC::SharedBufferReference::decode): (IPC::SharedBufferReference::unsafeBuffer const): (IPC::SharedBufferReference::data const): (IPC::SharedBufferReference::bufferWithOwner const):
- Platform/IPC/SharedBufferReference.h: Added. (IPC::SharedBufferReference::SharedBufferReference): (IPC::SharedBufferReference::size const): (IPC::SharedBufferReference::isEmpty const): (IPC::SharedBufferReference::isNull const):
- Platform/SharedMemory.cpp: (WebKit::transferOwnershipOfMemory const):
- Platform/SharedMemory.h:
- Platform/cocoa/SharedMemoryCocoa.cpp: (WebKit::changeOwnershipOfMemory): (WebKit::SharedMemory::Handle::takeOwnershipOfMemory const): (WebKit::SharedMemory::Handle::transferOwnershipOfMemory const): (WebKit::machProtection): (WebKit::SharedMemory::map):
- Scripts/process-entitlements.sh:
- Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp: (WebKit::CGDisplayListImageBufferBackend::createBackendHandle const):
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: (WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
- Shared/WebCoreArgumentCoders.cpp: (IPC::encodeSharedBuffer): (IPC::decodeSharedBuffer):
- Sources.txt:
- UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView createPDFWithConfiguration:completionHandler:]):
- UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::platformRegisterAttachment):
- UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: (WebKit::WebPasteboardProxy::getPasteboardBufferForType): (WebKit::WebPasteboardProxy::setPasteboardBufferForType): (WebKit::WebPasteboardProxy::readBufferFromPasteboard):
- UIProcess/Cocoa/WebProcessProxyCocoa.mm: (WebKit::WebProcessProxy::sendAudioComponentRegistrations):
- UIProcess/WebPageProxy.cpp: (WebKit::CompletionHandler<void): (WebKit::WebPageProxy::drawPagesToPDF): (WebKit::WebPageProxy::drawToPDF): (WebKit::WebPageProxy::getLoadDecisionForIcon): (WebKit::WebPageProxy::updateAttachmentAttributes): (WebKit::WebPageProxy::registerAttachmentIdentifierFromData): (WebKit::WebPageProxy::platformRegisterAttachment):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPasteboardProxy.cpp: (WebKit::WebPasteboardProxy::readBufferFromPasteboard):
- UIProcess/WebPasteboardProxy.h:
- UIProcess/WebPasteboardProxy.messages.in:
- UIProcess/WebURLSchemeTask.cpp: (WebKit::WebURLSchemeTask::didReceiveData):
- UIProcess/gtk/WebPasteboardProxyGtk.cpp: (WebKit::WebPasteboardProxy::readBuffer):
- UIProcess/ios/WKContentView.mm: (-[WKContentView _wk_pageCountForPrintFormatter:]):
- UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::drawToPDFiOS):
- UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::dataSelectionForPasteboard):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/graphics/ImageBufferBackendHandle.h:
- WebProcess/GPU/media/RemoteImageDecoderAVF.cpp: (WebKit::RemoteImageDecoderAVF::setData):
- WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp: (WebKit::RemoteImageDecoderAVFManager::createImageDecoder):
- WebProcess/GPU/media/RemoteMediaResourceProxy.cpp: (WebKit::RemoteMediaResourceProxy::dataReceived):
- WebProcess/GPU/media/SourceBufferPrivateRemote.cpp: (WebKit::SourceBufferPrivateRemote::append):
- WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::didReceiveData):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::writeItemsToPasteboard):
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: (WebKit::WebServiceWorkerFetchTaskClient::didReceiveData): (WebKit::WebServiceWorkerFetchTaskClient::didReceiveBlobChunk):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::registerAttachmentIdentifier):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::bufferForType): (WebKit::WebPlatformStrategies::setBufferForType): (WebKit::WebPlatformStrategies::readBufferFromClipboard): (WebKit::WebPlatformStrategies::readBufferFromPasteboard):
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: (WebKit::WebDragClient::declareAndWriteDragImage):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::getContentsAsMHTMLData): (WebKit::WebPage::getSelectionAsWebArchiveData): (WebKit::WebPage::getMainResourceDataOfFrame): (WebKit::WebPage::getResourceDataFromFrame): (WebKit::WebPage::getWebArchiveOfFrame): (WebKit::WebPage::getAccessibilityTreeData): (WebKit::WebPage::drawToPDF): (WebKit::WebPage::drawPagesToPDF): (WebKit::WebPage::didGetLoadDecisionForIcon): (WebKit::WebPage::urlSchemeTaskDidReceiveData): (WebKit::WebPage::updateAttachmentAttributes):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::getDataSelectionForPasteboard): (WebKit::WebPage::performActionOnElement): (WebKit::WebPage::drawToPDFiOS): (WebKit::WebPage::didFinishLoadForQuickLookDocumentInMainFrame):
- WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getDataSelectionForPasteboard):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::consumeAudioComponentRegistrations):
# Please populate the above commit message. Lines starting
# with '#' will be ignored
# 13 Tim Horton <timothy_horton@apple.com>
#
# ApplePayLogoSystemImage needlessly loads PassKit in WebKit child processes on iOS
# https://bugs.webkit.org/show_bug.cgi?id=240404
# <rdar://93070349>
#
# Reviewed by Chris Dumez.
#
# * UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
# (WebKit::ProcessLauncher::launchProcess): Adopt the WTF implementation of systemDirectoryPath.
# (WebKit::systemDirectoryPath): Moved to WTF.
#
# 13 Wenson Hsieh <Wenson Hsieh>
#
# ImageAnalysisQueue should reanalyze image elements whose image sources have changed
# https://bugs.webkit.org/show_bug.cgi?id=240371
# rdar://93175651
#
# Reviewed by Tim Horton.
#
# To aid with debugging similar issues in the future, plumb the image URL through to
#requestImageAnalysisWithIdentifier, which (if an engineering default is specified) will additionally reveal
# the URL in system logs.
#
# * Platform/cocoa/ImageAnalysisUtilities.h:
# * UIProcess/Cocoa/WebViewImpl.mm:
# (WebKit::WebViewImpl::requestTextRecognition):
# * UIProcess/ios/WKContentViewInteraction.mm:
# (-[WKContentView requestTextRecognition:imageData:identifier:completionHandler:]):
#
# 13 Aditya Keerthi <Aditya Keerthi>
#
# [iOS] Multiple visible find highlights when searching for text after beginning a "find from selection"
# https://bugs.webkit.org/show_bug.cgi?id=240393
# rdar://91441895
#
# Reviewed by Wenson Hsieh.
#
# Some WebKit clients use SPI on WKWebView to support "find from selection"
# functionality (the Cmd+E shortcut). However, to support general
# find functionality, they use new find API that uses a different codepath
# to draw highlights. Mixing use of the API and SPI can currently result
# in two highlights showing up.
#
# To fix, ensure SPI highlights are removed once the API is being used.
# The long term solution is for clients to adopt API for the
# "find from selection" functionality, but in the short term the SPI
# should remain supported.
#
# * WebProcess/WebPage/WebPage.cpp:
# (WebKit::WebPage::clearAllDecoratedFoundText):
#
# 13 Kimmo Kinnunen <kkinnunen@apple.com>
#
# IPC cannot encode, decode Ref<>, causing duplicate code
# https://bugs.webkit.org/show_bug.cgi?id=240160
#
# Reviewed by Antti Koivisto.
#
# Consider reference counted type T:
# Encoding is of signatureencode(const T&)
# Decoding is of signaturestd::optional<Ref<T>> decode()
# This is usable for bothRefPtrandRefuse-cases.
#
# AddRef<T>encoder that is polymorphic toT.
# This way clients do not need to write encoders for
#Ref<T>,RefPtr<T>. They just need one encoder, forT.
#
# When clients do not need to writeRefPtr<T>, they make less
# bugs. These will be corrected in future patches.
#
# HavingRef<T>encoders allows clients to useVector<Ref<T>>encoding
# viaVector<U>encoder, and they would not need to duplicate that
# logic, making less bugs. These will be corrected in future patches.
#
# Remove mostIPC::ArgumentCoder<Ref<..>>in favor ofIPC::ArgumentCoder<..>.
# In the cases where removal was done, remove also redundant
#IPC::ArgumentCoder<RefPtr<..>>.
#
# * Platform/IPC/ArgumentCoders.h:
# (IPC::ArgumentCoder<RefPtr<T>>::decode):
# (IPC::ArgumentCoder<Ref<T>>::encode):
# (IPC::ArgumentCoder<Ref<T>>::decode):
# * Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
# (IPC::ArgumentCoder<WebCore::Font>::encodePlatformData):
# (IPC::ArgumentCoder<WebCore::Font>::decodePlatformData):
# * Shared/WebCoreArgumentCoders.cpp:
# (IPC::ArgumentCoder<WebCore::Font>::encode):
# (IPC::ArgumentCoder<Font>::decode):
# (IPC::ArgumentCoder<SystemImage>::encode):
# (IPC::ArgumentCoder<SystemImage>::decode):
# * Shared/WebCoreArgumentCoders.h:
# * Shared/playstation/WebCoreArgumentCodersPlayStation.cpp:
# (IPC::ArgumentCoder<Font>::encodePlatformData):
# (IPC::ArgumentCoder<Font>::decodePlatformData):
# * Shared/soup/WebCoreArgumentCodersSoup.cpp:
# (IPC::ArgumentCoder<Font>::encodePlatformData):
# (IPC::ArgumentCoder<Font>::decodePlatformData):
# * Shared/win/WebCoreArgumentCodersWin.cpp:
# (IPC::ArgumentCoder<Font>::encodePlatformData):
# (IPC::ArgumentCoder<Font>::decodePlatformData):
#
# 13 Tim Horton <timothy_horton@apple.com>
#
# Add UI-side layers for optionally indicating interaction regions
# https://bugs.webkit.org/show_bug.cgi?id=240372
# <rdar://problem/87170289>
#
# Reviewed by Dean Jackson.
#
# * Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
# (WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
# (WebKit::RemoteLayerTreePropertyApplier::applyHierarchyUpdates):
# Allow RemoteLayerTreeInteractionRegionLayers to add and maintain layers for interaction regions.
#
# * SourcesCocoa.txt:
# * UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.h: Added.
# * UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm: Added.
# (configureLayerForInteractionRegion):
# (WebKit::interactionRegionForLayer):
# (WebKit::isInteractionRegionLayer):
# (WebKit::setInteractionRegion):
# Box WebCore::InteractionRegion in a Objective-C object and store it on the layer.
# Use this as a key to indicate that a given layer is an interaction region.
#
# (WebKit::appendInteractionRegionLayersForLayer):
# Make sure that interaction region layers are always at the end of the layer's sublayers array.
#
# (WebKit::updateLayersForInteractionRegions):
# Add new layers for interaction regions.
# Maintain the same layer for regions that cover the same area.
# Add a green wash if the defaultWKInteractionRegionDebugFillis set.
#
# * WebKit.xcodeproj/project.pbxproj:
#
# 13 Simon Fraser <Simon Fraser>
#
# Simplify the usage of DrawGlyphsRecorder
# https://bugs.webkit.org/show_bug.cgi?id=240363
#
# Reviewed by Myles Maxfield.
#
# Move the DeconstructDrawGlyphs switch from inside DrawGlyphsRecorder to
# DisplayList::Recorder, so that DrawGlyphsRecorder is only ever used when deconstructing
# glyphs.
#
# Also, ensure that the only time that glyph deconstruction is enabled is when
# recording display lists via RemoteDisplayListRecorderProxy. There's no reason for
# paintAttachmentText() to need glyph deconstruction.
#
# This is a small perf improvement on the MotionMark Design subtest.
#
# * WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
# (WebKit::RemoteDisplayListRecorderProxy::RemoteDisplayListRecorderProxy):
# (WebKit::m_renderingBackend):
# * WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
#
# it takes from the XPC message is sent until the XPC reply is received. Add reporting when this happens
# On branch bz/240223
# Your branch is ahead of 'origin/main' by 1 commit.
# (use "git push" to publish your local commits)
#
# Changes to be committed:
# (use "git restore --staged <file>..." to unstage)
# modified: Source/WebKit/ChangeLog
#
# Untracked files:
# (use "git add <file>..." to include in what will be committed)
# 0001-SharedBuffer-should-be-copied-and-then-attributed-ba.patch
#
Canonical link: https://commits.webkit.org/250556@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:31 PM Changeset in webkit [294347] by
-
- 2 edits in branches/safari-7614.1.14.1-branch/Source/WebKit
Cherry-pick r294175. rdar://problem/91441895
[iOS] Multiple visible find highlights when searching for text after beginning a "find from selection"
https://bugs.webkit.org/show_bug.cgi?id=240393
rdar://91441895
Reviewed by Wenson Hsieh.
Some WebKit clients use SPI on WKWebView to support "find from selection"
functionality (the Cmd+E shortcut). However, to support general
find functionality, they use new find API that uses a different codepath
to draw highlights. Mixing use of the API and SPI can currently result
in two highlights showing up.
To fix, ensure SPI highlights are removed once the API is being used.
The long term solution is for clients to adopt API for the
"find from selection" functionality, but in the short term the SPI
should remain supported.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::clearAllDecoratedFoundText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:24 PM Changeset in webkit [294346] by
-
- 91 edits in trunk/Source
Use ASCIILiteral for JSC::HashTableValue::m_key
https://bugs.webkit.org/show_bug.cgi?id=240492
Reviewed by Geoffrey Garen.
Use ASCIILiteral for JSC::HashTableValue::m_key since the key is always a string literal. This
allows JSC::reifyStaticProperties() to call a more optimal Identifier::fromString(VM&, ASCIILiteral)
overload.
- Source/JavaScriptCore/create_hash_table:
- Source/JavaScriptCore/runtime/Lookup.h:
(JSC::HashTable::ConstIterator::key const):
(JSC::HashTable::ConstIterator::skipInvalidKeys):
(JSC::reifyStaticProperties):
- Source/JavaScriptCore/tools/JSDollarVM.cpp:
- Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashTableValueArray):
- Source/WebCore/bindings/scripts/test/JS/JSDOMWindow.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSExposedStar.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSPaintWorkletGlobalScope.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSServiceWorkerGlobalScope.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSShadowRealmGlobalScope.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSSharedWorkerGlobalScope.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestCallTracer.cpp:
(WebCore::JSTestCallTracerDOMConstructor::prototypeForStructure):
- Source/WebCore/bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestConditionalIncludes.cpp:
(WebCore::JSTestConditionalIncludesDOMConstructor::prototypeForStructure):
- Source/WebCore/bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp:
(WebCore::JSTestConditionallyReadWriteDOMConstructor::prototypeForStructure):
- Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSON.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONIndirectInheritance.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInherit.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestDelegateToSharedSyntheticAttribute.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestDomainSecurity.cpp:
(WebCore::JSTestDomainSecurityDOMConstructor::prototypeForStructure):
- Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
(WebCore::JSTestEnabledBySettingDOMConstructor::prototypeForStructure):
- Source/WebCore/bindings/scripts/test/JS/JSTestEnabledForContext.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestGenerateAddOpaqueRoot.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestGlobalObject.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceDOMConstructor::construct):
- Source/WebCore/bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestIterable.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestLegacyFactoryFunction.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestLegacyNoInterfaceObject.cpp:
(WebCore::JSTestLegacyNoInterfaceObjectPrototype::finishCreation):
- Source/WebCore/bindings/scripts/test/JS/JSTestLegacyOverrideBuiltIns.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestMapLike.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestMapLikeWithOverriddenOperations.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyOverrideBuiltIns.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp:
(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesDOMConstructor::prototypeForStructure):
- Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp:
(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltInsDOMConstructor::prototypeForStructure):
- Source/WebCore/bindings/scripts/test/JS/JSTestNamespaceConst.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNamespaceObject.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjDOMConstructor::construct):
- Source/WebCore/bindings/scripts/test/JS/JSTestOperationConditional.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestPluginInterface.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestReadOnlyMapLike.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestReadOnlySetLike.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestReportExtraMemoryCost.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestSetLike.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestSetLikeWithOverriddenOperations.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestStringifier.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestTaggedWrapper.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsDOMConstructor::construct):
- Source/WebCore/bindings/scripts/test/JS/JSWorkerGlobalScope.cpp:
- Source/WebCore/bindings/scripts/test/JS/JSWorkletGlobalScope.cpp:
Canonical link: https://commits.webkit.org/250658@main
- 2:23 PM Changeset in webkit [294345] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.3
- 2:18 PM Changeset in webkit [294344] by
-
- 9 edits in branches/safari-7614.1.14.0-branch/Source
Versioning.
WebKit-7614.1.14.0.3
- 2:12 PM Changeset in webkit [294343] by
-
- 1 copy in tags/WebKit-7614.1.14.1.2
Tag WebKit-7614.1.14.1.2.
- 2:11 PM Changeset in webkit [294342] by
-
- 1 edit in trunk/metadata/contributors.json
Add my github username to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240539
Reviewed by Jonathan Bedard.
- metadata/contributors.json: add my github username.
Canonical link: https://commits.webkit.org/250657@main
- 1:42 PM Changeset in webkit [294341] by
-
- 1 copy in tags/WebKit-7614.1.14.11.1
Tag WebKit-7614.1.14.11.1.
- 1:37 PM Changeset in webkit [294340] by
-
- 9 edits in branches/safari-7614.1.14.11-branch/Source
Versioning.
WebKit-7614.1.14.11.1
- 1:22 PM Changeset in webkit [294339] by
-
- 1 edit in trunk/LayoutTests/platform/ios-wk2/TestExpectations
[ Gardening ] REGRESSION (250413@main): [ iOS ] system-preview/badge.html is a consistent image failure (240352)
https://bugs.webkit.org/show_bug.cgi?id=240352
Unreviewed test gardening.
- LayoutTests/platform/ios-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250656@main
- 1:15 PM Changeset in webkit [294338] by
-
- 1 copy in branches/safari-7614.1.14.11-branch
New branch.
- 1:12 PM Changeset in webkit [294337] by
-
- 1 copy in tags/WebKit-7614.1.14.0.2
Tag WebKit-7614.1.14.0.2.
- 1:10 PM Changeset in webkit [294336] by
-
- 2 edits in trunk/Tools/CISupport/ews-build
Forbid ChangeLog modification (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=240461
<rdar://93351783>
Reviewed by Aakash Jain.
Run Canonicalize on committed patches.
- Tools/CISupport/ews-build/steps.py:
(Canonicalize.doStepIf): Deleted.
(Canonicalize.hideStepIf): Deleted.
- Tools/CISupport/ews-build/steps_unittest.py:
- 12:58 PM Changeset in webkit [294335] by
-
- 9 edits in branches/safari-7614.1.13-branch/Source
Versioning.
WebKit-7614.1.13.5
- 12:46 PM Changeset in webkit [294334] by
-
- 1 edit in trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm
MockAudioSharedInternalUnit::render should return kAudio_ParamError if input buffer is too small
https://bugs.webkit.org/show_bug.cgi?id=240518
rdar://93409662
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-17
Reviewed by Eric Carlson.
The input buffer given to render should be large enough to copy enough frameCount samples.
If that is not the case, mimick what the real audio unit is doing and return kAudio_ParamError.
We also more closely mimick the real audio unit by sending chunks of at most AudioSession::sharedSession().bufferSize().
Covered by existing tests.
- Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:
(WebCore::MockAudioSharedInternalUnit::generateSampleBuffers):
(WebCore::MockAudioSharedInternalUnit::render):
Canonical link: https://commits.webkit.org/250654@main
- 12:39 PM Changeset in webkit [294333] by
-
- 1 edit in trunk/ReadMe.md
Clearly recommend checking out from GitHub using https
https://bugs.webkit.org/show_bug.cgi?id=240528
Reviewed by Jonathan Bedard.
- ReadMe.md:
Canonical link: https://commits.webkit.org/250653@main
- 12:09 PM Changeset in webkit [294332] by
-
- 3 edits in trunk
[WebAuthn] Add SPI to update platform credential's displayName
https://bugs.webkit.org/show_bug.cgi?id=240471
<rdar://93362894>
Reviewed by Brent Fulgham.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
Updated API test.
- Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
- Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithGroupAndID:credential:username:]):
(+[_WKWebAuthenticationPanel setDisplayNameForLocalCredentialWithGroupAndID:credential:displayName:]):
This change introduces setDisplayNameForLocalCredentialWithGroupAndID, which will supercede
the existing setUsernameForLocalCredentialWithGroupAndID once all callers are updated.
Canonical link: https://commits.webkit.org/250652@main
- 12:02 PM Changeset in webkit [294331] by
-
- 2 edits in trunk
[WebAuthn] Set displayName in AuthenticatorAssertionResponse for platform authenticator
https://bugs.webkit.org/show_bug.cgi?id=240459
<rdar://93350479>
Reviewed by Brent Fulgham.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
(TestWebKitAPI::TEST):
Updated API test to account for displayName.
- Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticatorInternal::getExistingCredentials):
Canonical link: https://commits.webkit.org/250651@main
- 10:53 AM Changeset in webkit [294330] by
-
- 66 edits2 adds2 deletes in trunk/Source
Update to PDF.js v2.14.305
https://bugs.webkit.org/show_bug.cgi?id=240482
Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-17
Reviewed by Tim Nguyen.
Besides updating the upstream sources, this commit also adds a
README.webkit to explain the update procedure, and adds
CONFIGURE_DEPENDS to the GLOB_RECURSE command in PdfJSGResources.cmake
to force make/ninja to watch for changes to the files and rerun cmake if
needed, to keep incremental builds happy. Downside: this is probably
slow, and the CMake documentation explicitly warns against doing so. We
may want to generate a .cmake file that manually lists all files instead.
- Source/ThirdParty/pdfjs/README.webkit: Added.
- Source/ThirdParty/pdfjs/build/pdf.js:
(webpackUniversalModuleDefinition):
(return.):
(return):
- Source/ThirdParty/pdfjs/build/pdf.sandbox.js:
(webpackUniversalModuleDefinition):
(return.):
- Source/ThirdParty/pdfjs/build/pdf.worker.js:
(webpackUniversalModuleDefinition):
(return.):
- Source/ThirdParty/pdfjs/web/debugger.css: Added.
(#PDFBug):
(#PDFBug .controls):
(#PDFBug .panels):
(#PDFBug .panels > div):
(#PDFBug button.active):
(.debuggerShowText,):
(#PDFBug .stats):
(#PDFBug .stats .title):
(#PDFBug table):
(#PDFBug table.showText):
(#PDFBug table.showText,):
(#PDFBug table.showText td.advance):
(#viewer.textLayer-visible .textLayer):
(#viewer.textLayer-visible .canvasWrapper):
(#viewer.textLayer-visible .canvasWrapper canvas):
(#viewer.textLayer-visible .textLayer span):
(#viewer.textLayer-hover .textLayer span:hover):
(#viewer.textLayer-shadow .textLayer span):
- Source/ThirdParty/pdfjs/web/debugger.js:
(const.FontInspector.FontInspectorClosure.textLayerClick):
(const.FontInspector.FontInspectorClosure.return.properties):
(const.FontInspector):
(const.StepperManager):
(const.Stepper.StepperClosure.Stepper.prototype.updateOperatorList):
(const.Stepper.StepperClosure.Stepper.prototype.getNextBreakPoint):
(const.Stepper.StepperClosure.Stepper.prototype.goTo):
(const.Stepper.StepperClosure.Stepper):
(const.Stepper):
(const.Stats.Stats.getStatIndex):
(const.Stats):
(const.PDFBug):
(FontInspector.FontInspectorClosure.removeSelection): Deleted.
(FontInspector.FontInspectorClosure.resetSelection): Deleted.
(FontInspector.FontInspectorClosure.selectFont): Deleted.
(FontInspector.FontInspectorClosure.textLayerClick): Deleted.
(FontInspector.FontInspectorClosure.return.init): Deleted.
(FontInspector.FontInspectorClosure.return.cleanup): Deleted.
(FontInspector.FontInspectorClosure.return.get active): Deleted.
(FontInspector.FontInspectorClosure.return.set active): Deleted.
(FontInspector.FontInspectorClosure.return.properties): Deleted.
(FontInspector.FontInspectorClosure.return.fontAdded): Deleted.
(FontInspector): Deleted.
(StepperManager.StepperManagerClosure.return.init): Deleted.
(StepperManager.StepperManagerClosure.return.cleanup): Deleted.
(StepperManager.StepperManagerClosure.return.create): Deleted.
(StepperManager.StepperManagerClosure.return.selectStepper): Deleted.
(StepperManager.StepperManagerClosure.return.saveBreakPoints): Deleted.
(StepperManager): Deleted.
(Stats.Stats): Deleted.
(Stats.Stats.getStatIndex): Deleted.
(Stats): Deleted.
(window.PDFBug): Deleted.
- Source/ThirdParty/pdfjs/web/images/grab.cur: Removed.
- Source/ThirdParty/pdfjs/web/images/grabbing.cur: Removed.
- Source/ThirdParty/pdfjs/web/locale/be/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/ca/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/cs/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/cy/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/da/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/de/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/dsb/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/el/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/en-CA/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/en-GB/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/en-US/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/eo/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/es-AR/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/es-CL/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/es-ES/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/es-MX/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/et/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/eu/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/fr/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/fy-NL/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/ga-IE/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/gn/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/hr/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/hsb/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/hu/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/hye/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/ia/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/id/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/is/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/it/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/ja/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/ka/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/kab/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/kk/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/ko/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/nb-NO/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/nl/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/nn-NO/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/oc/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/pa-IN/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/pl/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/pt-BR/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/pt-PT/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/rm/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/ru/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/sat/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/sc/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/sk/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/sl/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/sv-SE/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/szl/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/tg/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/th/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/tr/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/uk/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/vi/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/zh-CN/viewer.properties:
- Source/ThirdParty/pdfjs/web/locale/zh-TW/viewer.properties:
- Source/ThirdParty/pdfjs/web/viewer.css:
(.textLayer):
(:root):
(.pdfViewer .dummyPage):
([dir="rtl"]:root):
(@media (prefers-color-scheme: dark) :root):
(@media screen and (forced-colors: active) :root):
(html,):
(body):
(.hidden,):
([dir="ltr"] #sidebarContainer):
([dir="rtl"] #sidebarContainer):
(#sidebarContainer):
([dir="ltr"] #outerContainer.sidebarOpen #sidebarContainer):
([dir="rtl"] #outerContainer.sidebarOpen #sidebarContainer):
(#outerContainer.sidebarOpen #sidebarContainer):
([dir="ltr"] #sidebarContent):
([dir="rtl"] #sidebarContent):
(#sidebarContent):
(#viewerContainer):
([dir="ltr"] #outerContainer.sidebarOpen #viewerContainer:not(.pdfPresentationMode)):
([dir="rtl"] #outerContainer.sidebarOpen #viewerContainer:not(.pdfPresentationMode)):
(#outerContainer.sidebarOpen #viewerContainer:not(.pdfPresentationMode)):
(#toolbarSidebar):
([dir="ltr"] #sidebarResizer):
([dir="rtl"] #sidebarResizer):
(#sidebarResizer):
([dir="ltr"] #loadingBar):
([dir="rtl"] #loadingBar):
(#loadingBar):
([dir="ltr"] #outerContainer.sidebarOpen #loadingBar):
([dir="rtl"] #outerContainer.sidebarOpen #loadingBar):
(#outerContainer.sidebarOpen #loadingBar):
(#loadingBar .progress):
(#loadingBar .progress.indeterminate):
(#outerContainer.sidebarResizing #sidebarContainer,):
(.findbar,):
([dir="ltr"] .findbar):
([dir="rtl"] .findbar):
(.findbar):
(.findbar > div):
([dir="ltr"] .findbar > div#findbarInputContainer):
([dir="rtl"] .findbar > div#findbarInputContainer):
(.findbar > div#findbarInputContainer):
(.findbar.wrapContainers > div,):
(.findbar.wrapContainers > div#findbarMessageContainer):
(.findbar label:hover,):
(#findInput[data-status="pending"]):
([dir="ltr"] .secondaryToolbar):
([dir="rtl"] .secondaryToolbar):
(.secondaryToolbar):
(#secondaryToolbarButtonContainer):
(.doorHanger:after,):
([dir="ltr"] .doorHanger:after):
([dir="rtl"] .doorHanger:after):
(.doorHanger:after):
([dir="ltr"] .doorHangerRight:after):
([dir="rtl"] .doorHangerRight:after):
(.doorHangerRight:after):
([dir="ltr"] .doorHanger:before):
([dir="rtl"] .doorHanger:before):
(.doorHanger:before):
([dir="ltr"] .doorHangerRight:before):
([dir="rtl"] .doorHangerRight:before):
(.doorHangerRight:before):
(#findResultsCount:empty,):
([dir="ltr"] #toolbarViewerLeft,[dir="ltr"]):
([dir="rtl"] #toolbarViewerLeft,[dir="rtl"]):
(#toolbarViewerLeft,):
([dir="ltr"] #toolbarViewerRight,[dir="ltr"]):
([dir="rtl"] #toolbarViewerRight,[dir="rtl"]):
(#toolbarViewerRight,):
([dir="ltr"] #toolbarViewerLeft > *,[dir="ltr"]):
([dir="rtl"] #toolbarViewerLeft > *,[dir="rtl"]):
(#toolbarViewerLeft > *,):
([dir="ltr"] #toolbarViewerLeft):
([dir="rtl"] #toolbarViewerLeft):
(#toolbarViewerLeft):
([dir="ltr"] #toolbarViewerRight):
([dir="rtl"] #toolbarViewerRight):
(#toolbarViewerRight):
([dir="ltr"] #toolbarSidebarRight):
([dir="rtl"] #toolbarSidebarRight):
(#toolbarSidebarRight):
(.splitToolbarButton):
([dir="ltr"] .splitToolbarButton > .toolbarButton):
([dir="rtl"] .splitToolbarButton > .toolbarButton):
(.splitToolbarButton > .toolbarButton):
(.toolbarButton,):
(.dialogButton:hover,):
(.dialogButton:hover > span,):
(.toolbarButton[disabled],):
(.splitToolbarButton > .toolbarButton:hover,):
([dir="ltr"] #toolbarSidebar .splitToolbarButton > .toolbarButton):
([dir="rtl"] #toolbarSidebar .splitToolbarButton > .toolbarButton):
(#toolbarSidebar .splitToolbarButton > .toolbarButton):
([dir="ltr"] .splitToolbarButtonSeparator):
([dir="rtl"] .splitToolbarButtonSeparator):
(.splitToolbarButtonSeparator):
(.toolbarButton:hover,):
(.secondaryToolbarButton:hover,):
(.toolbarButton.toggled::before,):
(.dropdownToolbarButton):
([dir="ltr"] .dropdownToolbarButton::after):
([dir="rtl"] .dropdownToolbarButton::after):
(.dropdownToolbarButton::after):
([dir="ltr"] .dropdownToolbarButton > select):
([dir="rtl"] .dropdownToolbarButton > select):
(.dropdownToolbarButton > select):
(.dropdownToolbarButton > select:hover,):
(.toolbarButton::before,):
(.dropdownToolbarButton:hover::after,):
(.toolbarButton:hover::before,):
([dir="ltr"] .secondaryToolbarButton::before):
([dir="rtl"] .secondaryToolbarButton::before):
(.secondaryToolbarButton::before):
(#sidebarToggle::before):
(#secondaryToolbarToggle::before):
(#findPrevious::before):
(#findNext::before):
(#previous::before):
(#next::before):
(#zoomOut::before):
(#zoomIn::before):
(#presentationMode::before,):
(#print::before,):
(#openFile::before,):
(#download::before,):
(a.secondaryToolbarButton):
(a.toolbarButton[href="#"],):
(#viewBookmark::before,):
(#viewThumbnail::before):
(#viewOutline::before):
(#viewAttachments::before):
(#viewLayers::before):
(#currentOutlineItem::before):
(#viewFind::before):
([dir="ltr"] .pdfSidebarNotification::after):
([dir="rtl"] .pdfSidebarNotification::after):
(.pdfSidebarNotification::after):
([dir="ltr"] .secondaryToolbarButton):
([dir="rtl"] .secondaryToolbarButton):
(.secondaryToolbarButton):
([dir="ltr"] .secondaryToolbarButton > span):
([dir="rtl"] .secondaryToolbarButton > span):
(.secondaryToolbarButton > span):
(#firstPage::before):
(#lastPage::before):
(#pageRotateCcw::before):
(#pageRotateCw::before):
(#cursorSelectTool::before):
(#cursorHandTool::before):
(#scrollPage::before):
(#scrollVertical::before):
(#scrollHorizontal::before):
(#scrollWrapped::before):
(#spreadNone::before):
(#spreadOdd::before):
(#spreadEven::before):
(#documentProperties::before):
(.verticalToolbarSeparator):
(.horizontalToolbarSeparator):
(.toolbarField):
([dir="ltr"] .toolbarField[type="checkbox"]):
([dir="rtl"] .toolbarField[type="checkbox"]):
(.toolbarField[type="checkbox"]):
(#pageNumber):
(#pageNumber.visiblePageIsLoading):
(#pageNumber::-webkit-inner-spin-button):
([dir="ltr"] #numPages.toolbarLabel):
([dir="rtl"] #numPages.toolbarLabel):
(#numPages.toolbarLabel):
(#thumbnailView,):
(#thumbnailView):
([dir="ltr"] .thumbnail):
([dir="rtl"] .thumbnail):
(.thumbnail):
(#thumbnailView > a:last-of-type > .thumbnail):
([dir="ltr"] .treeWithDeepNesting > .treeItem,[dir="ltr"]):
([dir="rtl"] .treeWithDeepNesting > .treeItem,[dir="rtl"]):
(.treeWithDeepNesting > .treeItem,):
([dir="ltr"] .treeItem > a):
([dir="rtl"] .treeItem > a):
(.treeItem > a):
([dir="ltr"] #layersView .treeItem > a > label):
([dir="rtl"] #layersView .treeItem > a > label):
(#layersView .treeItem > a > label):
([dir="ltr"] .treeItemToggler):
([dir="rtl"] .treeItemToggler):
(.treeItemToggler):
([dir="ltr"] .treeItemToggler::before):
([dir="rtl"] .treeItemToggler::before):
(.treeItemToggler::before):
(.treeItemToggler.treeItemsHidden::before):
(.treeItemToggler.treeItemsHidden ~ .treeItems):
(#errorWrapper):
(#errorMessageLeft):
(#errorSpacer):
(.dialogButton):
(dialog):
(dialog::-webkit-backdrop):
(dialog::backdrop):
(dialog > .row):
(dialog > .row > *):
(dialog .toolbarField):
(dialog .separator):
(dialog .buttonRow):
(dialog :link):
(#passwordDialog):
(#passwordDialog .toolbarField):
(#documentPropertiesDialog):
([dir="ltr"] #documentPropertiesDialog .row > *):
([dir="rtl"] #documentPropertiesDialog .row > *):
(#documentPropertiesDialog .row > *):
(#documentPropertiesDialog .row > span):
(#documentPropertiesDialog .row > p):
(#documentPropertiesDialog .buttonRow):
(.grab-to-pan-grab):
(.grab-to-pan-grab:active,):
(@media print body):
(@media all and (max-width: 840px) [dir="ltr"] #outerContainer.sidebarOpen #viewerContainer):
(@media all and (max-width: 840px) [dir="rtl"] #outerContainer.sidebarOpen #viewerContainer):
(@media all and (max-width: 840px) #outerContainer.sidebarOpen #viewerContainer):
(@media all and (max-width: 640px) [dir="ltr"] .findbar):
(@media all and (max-width: 640px) [dir="rtl"] .findbar):
(@media all and (max-width: 640px) .findbar):
(html): Deleted.
(.hidden): Deleted.
([hidden]): Deleted.
(html[dir="ltr"] #sidebarContainer): Deleted.
(html[dir="rtl"] #sidebarContainer): Deleted.
(#outerContainer.sidebarResizing #sidebarContainer): Deleted.
(html[dir="ltr"] #outerContainer.sidebarOpen #sidebarContainer): Deleted.
(html[dir="rtl"] #outerContainer.sidebarOpen #sidebarContainer): Deleted.
(html[dir="ltr"] #sidebarContent): Deleted.
(html[dir="rtl"] #sidebarContent): Deleted.
(#outerContainer.sidebarResizing #viewerContainer): Deleted.
(html[dir="ltr"]): Deleted.
(html[dir="rtl"]): Deleted.
(html[dir="ltr"] #toolbarSidebar): Deleted.
(html[dir="rtl"] #toolbarSidebar): Deleted.
(html[dir="ltr"] #toolbarSidebar .toolbarButton): Deleted.
(html[dir="rtl"] #toolbarSidebar .toolbarButton): Deleted.
(html[dir="ltr"] #toolbarSidebarRight .toolbarButton): Deleted.
(html[dir="rtl"] #toolbarSidebarRight .toolbarButton): Deleted.
(html[dir="ltr"] #sidebarResizer): Deleted.
(html[dir="rtl"] #sidebarResizer): Deleted.
(html[dir="ltr"] #loadingBar): Deleted.
(html[dir="rtl"] #loadingBar): Deleted.
(html[dir="ltr"] #outerContainer.sidebarOpen #loadingBar): Deleted.
(html[dir="rtl"] #outerContainer.sidebarOpen #loadingBar): Deleted.
(#outerContainer.sidebarResizing #loadingBar): Deleted.
(.findbar.wrapContainers > div): Deleted.
(html[dir="ltr"] .findbar): Deleted.
(html[dir="rtl"] .findbar): Deleted.
(.findbar .splitToolbarButton): Deleted.
(html[dir="ltr"] .findbar .splitToolbarButton): Deleted.
(html[dir="rtl"] .findbar .splitToolbarButton): Deleted.
(.findbar .splitToolbarButton > .toolbarButton): Deleted.
(.findbar .splitToolbarButton > .toolbarButton::before): Deleted.
(.findbar .splitToolbarButton > .findNext): Deleted.
(html[dir="ltr"] .findbar .splitToolbarButton > .findNext): Deleted.
(html[dir="rtl"] .findbar .splitToolbarButton > .findNext): Deleted.
(html[dir="ltr"] #findInput): Deleted.
(html[dir="rtl"] #findInput): Deleted.
(html[dir="rtl"] #findInput[data-status="pending"]): Deleted.
(html[dir="ltr"] .secondaryToolbar): Deleted.
(html[dir="rtl"] .secondaryToolbar): Deleted.
(html[dir="ltr"] .doorHanger:after,): Deleted.
(html[dir="ltr"] .doorHanger:before,): Deleted.
(html[dir="rtl"] .doorHanger:after,): Deleted.
(html[dir="rtl"] .doorHanger:before,): Deleted.
(#findMsg:empty): Deleted.
(html[dir="ltr"] #toolbarViewerLeft,): Deleted.
(html[dir="ltr"] #toolbarViewerRight,): Deleted.
(html[dir="ltr"] #toolbarViewerLeft > *,): Deleted.
(html[dir="rtl"] #toolbarViewerLeft > *,): Deleted.
(html[dir="ltr"] .splitToolbarButton > .toolbarButton): Deleted.
(html[dir="rtl"] .splitToolbarButton > .toolbarButton): Deleted.
(.overlayButton:hover,): Deleted.
(.overlayButton:hover > span,): Deleted.
(.splitToolbarButton.toggled .toolbarButton): Deleted.
(html[dir="ltr"] .splitToolbarButton > .toolbarButton:first-child,): Deleted.
(html[dir="ltr"] .splitToolbarButton > .toolbarButton:last-child,): Deleted.
(.findbar .splitToolbarButtonSeparator): Deleted.
(html[dir="ltr"] .splitToolbarButtonSeparator): Deleted.
(html[dir="rtl"] .splitToolbarButtonSeparator): Deleted.
(html[dir="ltr"] #toolbarViewerLeft > .toolbarButton:first-child,): Deleted.
(html[dir="ltr"] #toolbarViewerRight > .toolbarButton:last-child,): Deleted.
(.secondaryToolbarButton.toggled::before): Deleted.
(.toolbarButton.toggled::before): Deleted.
(html[dir="ltr"] .dropdownToolbarButton::after): Deleted.
(html[dir="rtl"] .dropdownToolbarButton::after): Deleted.
(html[dir="ltr"] .dropdownToolbarButton > select): Deleted.
(html[dir="rtl"] .dropdownToolbarButton > select): Deleted.
(#customScaleOption): Deleted.
(#pageWidthOption): Deleted.
(html[dir="ltr"] .secondaryToolbarButton::before): Deleted.
(html[dir="rtl"] .secondaryToolbarButton::before): Deleted.
(.toolbarButton#sidebarToggle::before): Deleted.
(html[dir="rtl"] .toolbarButton#sidebarToggle::before): Deleted.
(.toolbarButton#secondaryToolbarToggle::before): Deleted.
(html[dir="rtl"] .toolbarButton#secondaryToolbarToggle::before): Deleted.
(.toolbarButton.findPrevious::before): Deleted.
(.toolbarButton.findNext::before): Deleted.
(.toolbarButton.pageUp::before): Deleted.
(.toolbarButton.pageDown::before): Deleted.
(.toolbarButton.zoomOut::before): Deleted.
(.toolbarButton.zoomIn::before): Deleted.
(.toolbarButton.presentationMode::before,): Deleted.
(.toolbarButton.print::before,): Deleted.
(.toolbarButton.openFile::before,): Deleted.
(.toolbarButton.download::before,): Deleted.
(.secondaryToolbarButton.bookmark): Deleted.
(.bookmark[href="#"]): Deleted.
(.toolbarButton.bookmark::before,): Deleted.
(#viewThumbnail.toolbarButton::before): Deleted.
(#viewOutline.toolbarButton::before): Deleted.
(html[dir="rtl"] #viewOutline.toolbarButton::before): Deleted.
(#viewAttachments.toolbarButton::before): Deleted.
(#viewLayers.toolbarButton::before): Deleted.
(#currentOutlineItem.toolbarButton::before): Deleted.
(html[dir="rtl"] #currentOutlineItem.toolbarButton::before): Deleted.
(#viewFind.toolbarButton::before): Deleted.
(.toolbarButton.pdfSidebarNotification::after): Deleted.
(html[dir="ltr"] .toolbarButton.pdfSidebarNotification::after): Deleted.
(html[dir="rtl"] .toolbarButton.pdfSidebarNotification::after): Deleted.
(html[dir="ltr"] .secondaryToolbarButton): Deleted.
(html[dir="rtl"] .secondaryToolbarButton): Deleted.
(html[dir="ltr"] .secondaryToolbarButton > span): Deleted.
(html[dir="rtl"] .secondaryToolbarButton > span): Deleted.
(.secondaryToolbarButton.firstPage::before): Deleted.
(.secondaryToolbarButton.lastPage::before): Deleted.
(.secondaryToolbarButton.rotateCcw::before): Deleted.
(.secondaryToolbarButton.rotateCw::before): Deleted.
(.secondaryToolbarButton.selectTool::before): Deleted.
(.secondaryToolbarButton.handTool::before): Deleted.
(.secondaryToolbarButton.scrollPage::before): Deleted.
(.secondaryToolbarButton.scrollVertical::before): Deleted.
(.secondaryToolbarButton.scrollHorizontal::before): Deleted.
(.secondaryToolbarButton.scrollWrapped::before): Deleted.
(.secondaryToolbarButton.spreadNone::before): Deleted.
(.secondaryToolbarButton.spreadOdd::before): Deleted.
(.secondaryToolbarButton.spreadEven::before): Deleted.
(.secondaryToolbarButton.documentProperties::before): Deleted.
(html[dir="ltr"] .verticalToolbarSeparator): Deleted.
(html[dir="rtl"] .verticalToolbarSeparator): Deleted.
(html[dir="ltr"] .toolbarField[type="checkbox"]): Deleted.
(html[dir="rtl"] .toolbarField[type="checkbox"]): Deleted.
(.toolbarField.pageNumber): Deleted.
(.toolbarField.pageNumber.visiblePageIsLoading): Deleted.
(.toolbarField.pageNumber::-webkit-inner-spin-button,): Deleted.
(html[dir="ltr"] #numPages.toolbarLabel): Deleted.
(html[dir="rtl"] #numPages.toolbarLabel): Deleted.
(html[dir="ltr"] .thumbnail): Deleted.
(html[dir="rtl"] .thumbnail): Deleted.
(#outlineView,): Deleted.
(html[dir="ltr"] .treeWithDeepNesting > .treeItem,): Deleted.
(html[dir="rtl"] .treeWithDeepNesting > .treeItem,): Deleted.
(html[dir="ltr"] .treeItem > a): Deleted.
(html[dir="rtl"] .treeItem > a): Deleted.
(html[dir="ltr"] #layersView .treeItem > a > label): Deleted.
(html[dir="rtl"] #layersView .treesItem > a > label): Deleted.
(html[dir="rtl"] .treeItemToggler.treeItemsHidden::before): Deleted.
(html[dir="ltr"] .treeItemToggler): Deleted.
(html[dir="rtl"] .treeItemToggler): Deleted.
(html[dir="ltr"] .treeItemToggler::before): Deleted.
(html[dir="rtl"] .treeItemToggler::before): Deleted.
(.overlayButton): Deleted.
(#overlayContainer): Deleted.
(#overlayContainer > *): Deleted.
(#overlayContainer > .container): Deleted.
(#overlayContainer > .container > .dialog): Deleted.
(.dialog > .row): Deleted.
(.dialog > .row > *): Deleted.
(.dialog .toolbarField): Deleted.
(.dialog .separator): Deleted.
(.dialog .buttonRow): Deleted.
(.dialog :link): Deleted.
(#passwordOverlay > .dialog): Deleted.
(#passwordOverlay .toolbarField): Deleted.
(#documentPropertiesOverlay > .dialog): Deleted.
(#documentPropertiesOverlay .row > *): Deleted.
(html[dir="ltr"] #documentPropertiesOverlay .row > *): Deleted.
(html[dir="rtl"] #documentPropertiesOverlay .row > *): Deleted.
(#documentPropertiesOverlay .row > span): Deleted.
(#documentPropertiesOverlay .row > p): Deleted.
(#documentPropertiesOverlay .buttonRow): Deleted.
(.clearBoth): Deleted.
(.fileInput): Deleted.
(#PDFBug): Deleted.
(#PDFBug .controls): Deleted.
(#PDFBug .panels): Deleted.
(#PDFBug .panels > div): Deleted.
(#PDFBug button.active): Deleted.
(.debuggerShowText): Deleted.
(.debuggerHideText:hover): Deleted.
(#PDFBug .stats): Deleted.
(#PDFBug .stats .title): Deleted.
(#PDFBug table): Deleted.
(#PDFBug table.showText): Deleted.
(#PDFBug table.showText,): Deleted.
(#PDFBug table.showText td.advance): Deleted.
(#viewer.textLayer-visible .textLayer): Deleted.
(#viewer.textLayer-visible .canvasWrapper): Deleted.
(#viewer.textLayer-visible .canvasWrapper canvas): Deleted.
(#viewer.textLayer-visible .textLayer span): Deleted.
(#viewer.textLayer-hover .textLayer span:hover): Deleted.
(#viewer.textLayer-shadow .textLayer span): Deleted.
(@media print #sidebarContainer,): Deleted.
(@media print #viewerContainer): Deleted.
(@media print #mainContainer,): Deleted.
(@media print .page): Deleted.
(@media print .page[data-loaded]): Deleted.
(@media print .fileInput): Deleted.
(@media all and (max-width: 840px) html[dir="ltr"] #outerContainer.sidebarOpen #viewerContainer): Deleted.
(@media all and (max-width: 840px) html[dir="rtl"] #outerContainer.sidebarOpen #viewerContainer): Deleted.
(@media all and (max-width: 840px) #outerContainer .hiddenLargeView,): Deleted.
(@media all and (max-width: 840px) #outerContainer .visibleLargeView,): Deleted.
(@media all and (max-width: 640px) html[dir="ltr"] .findbar): Deleted.
(@media all and (max-width: 640px) html[dir="rtl"] .findbar): Deleted.
- Source/ThirdParty/pdfjs/web/viewer.html:
- Source/ThirdParty/pdfjs/web/viewer.js:
(webpack_require.const.PDFViewerApplication.async initialize):
(webpack_require.const.PDFViewerApplication.async _parseHashParameters):
(webpack_require.const.PDFViewerApplication.async _initializeViewerComponents):
(webpack_require.const.PDFViewerApplication.get supportsFullscreen):
(webpack_require.const.PDFViewerApplication.async close):
(webpack_require.):
(webpack_require):
(exports.checkOnBlobSupport): Deleted.
(webpack_require.DefaultExternalServices.async fallback): Deleted.
- Source/WebKit/PdfJSGResources.cmake:
Canonical link: https://commits.webkit.org/250650@main
- 10:49 AM Changeset in webkit [294329] by
-
- 1 edit in trunk/Source/WebCore/rendering/RenderElement.h
Remove some RenderElement API
https://bugs.webkit.org/show_bug.cgi?id=240520
Patch by Rob Buis <rbuis@igalia.com> on 2022-05-17
Reviewed by Alan Bujtas.
Remove some unused RenderElement API, instead attachRendererInternal/detachRendererInternal are used.
- Source/WebCore/rendering/RenderElement.h:
(WebCore::RenderElement::setFirstChild): Deleted.
(WebCore::RenderElement::setLastChild): Deleted.
- 10:47 AM Changeset in webkit [294328] by
-
- 2 edits in trunk/Source/WebCore/accessibility/isolatedtree
AX: Lazily retrieve AXPropertyName::SupportsPressAction, AXPropertyName::ColumnHeaders, and AXPropertyName::RowHeaders
https://bugs.webkit.org/show_bug.cgi?id=240473
Reviewed by Chris Fleizach.
These properties can be expensive to compute up-front, so retrieve them
lazily.
No test because there is no user-facing behavior change.
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::getOrRetrievePropertyValue):
(WebCore::AXIsolatedObject::columnHeaders):
(WebCore::AXIsolatedObject::rowHeaders):
(WebCore::AXIsolatedObject::supportsPressAction const):
- accessibility/isolatedtree/AXIsolatedObject.h:
Canonical link: https://commits.webkit.org/250648@main
- 10:35 AM Changeset in webkit [294327] by
-
- 4 edits in trunk/Tools/CISupport/ews-build
Forbid ChangeLog modification
https://bugs.webkit.org/show_bug.cgi?id=240461
<rdar://93351783>
Rubber-stamped by Aakash Jain.
- Tools/CISupport/ews-build/factories.py:
(CommitQueueFactory.init): Only accept patches with commit messages,
respect those commit messages.
(MergeQueueFactoryBase.init): Use commit author in commit.
- Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps.test_all_expected_steps):
- CISupport/ews-build/steps.py:
(CommitPatch): Add step which commits a patch, including it's commit message.
(PushCommitToWebKitRepo.evaluateCommand): Use GitHub checkout on Commit-Queue.
(ValidateSquashed.start): Support committed patches.
(AddReviewerToCommitMessage.start): Ditto.
(DetermineAuthor): Extract author from local commit.
(AddAuthorToCommitMessage): Use 'author' property as set by 'DetermineAuthor'.
(ValidateCommitMessage._files): Support patches.
(ValidateCommitMessage.run): Support committed patches.
(ValidateCommitMessage.getResultSummary): Support patches.
(Canonicalize.run): Support committed patches.
(ValidateSquashed.doStepIf): Deleted.
(ValidateSquashed.hideStepIf): Deleted.
(AddAuthorToCommitMessage.author): Deleted.
(ValidateCommitMessage.doStepIf): Deleted.
(ValidateCommitMessage.hideStepIf): Deleted.
- Tools/CISupport/ews-build/steps_unittest.py:
- 10:31 AM Changeset in webkit [294326] by
-
- 1 edit in trunk/Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp
Unreviewed, fix typo in comment
Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-17
- Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::launchProcess):
Canonical link: https://commits.webkit.org/250646@main
- 9:38 AM Changeset in webkit [294325] by
-
- 23 edits in trunk
Refactor ImageAnalysisQueue to take source and target identifier strings
https://bugs.webkit.org/show_bug.cgi?id=240485
rdar://93280471
Reviewed by Tim Horton.
Plumb a
sourceidentifier string alongside the existing target identifier string when kicking off the image
analysis queue. See WebKit changes for more details.
- html/shadow/imageOverlay.css:
(div.image-overlay-block):
Drive-by fix: tweak some styles in the image overlay, related to block-style image overlays installed by the
image analysis queue.
- page/ImageAnalysisQueue.cpp:
(WebCore::ImageAnalysisQueue::enqueueAllImages):
(WebCore::ImageAnalysisQueue::resumeProcessing):
(WebCore::ImageAnalysisQueue::clear):
- page/ImageAnalysisQueue.h:
- platform/TextRecognitionOptions.h:
Change
-[WKWebView _startImageAnalysis:]to-[WKWebView _startImageAnalysis:target:], and have it take
separate source and target identifier strings. We pass these strings through to the page and store them on
ImageAnalysisQueue, where they eventually bubble back up to the UI process when trigger batch image analysis,
via the newsourceandtargetarguments onrequestTextRecognition().
No change in behavior; covered by adjusting existing API tests to use the adjusted SPI.
- Platform/cocoa/ImageAnalysisUtilities.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _startImageAnalysis:target:]):
(-[WKWebView _startImageAnalysis:]): Deleted.
Rename this SPI entirely; this is safe to rename because the only existing client of this method (apart from API
tests) will simultaneously adopt the new SPI method with bothsourceandtargetarguments.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::requestTextRecognition):
- UIProcess/PageClient.h:
(WebKit::PageClient::requestTextRecognition):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestTextRecognition):
(WebKit::WebPageProxy::startImageAnalysis):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::requestTextRecognition):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView requestTextRecognition:imageData:source:target:completionHandler:]):
(-[WKContentView requestTextRecognition:imageData:identifier:completionHandler:]): Deleted.
- UIProcess/mac/PageClientImplMac.h:
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::requestTextRecognition):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::requestTextRecognition):
(WebKit::WebPage::startImageAnalysis):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
See WebKit changes for more information.
- TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/250645@main
- 8:40 AM Changeset in webkit [294324] by
-
- 1 edit in trunk/Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp
[GTK] Fix build after 250633@main
https://bugs.webkit.org/show_bug.cgi?id=240521
Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-17
Unreviewed, fix GTK build.
- rendering/updating/RenderTreeBuilderFirstLetter.cpp:
Canonical link: https://commits.webkit.org/250644@main
- 7:10 AM Changeset in webkit [294323] by
-
- 5 edits in trunk/Tools
[Merge-Queue] Forbid ChangeLog modification
https://bugs.webkit.org/show_bug.cgi?id=239413
<rdar://problem/91839553>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/factories.py:
(MergeQueueFactoryBase.init): Remove AddReviewerToChangeLog and ValidateChangeLogAndReviewer.
- CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
- Tools/CISupport/ews-build/steps.py:
(PushCommitToWebKitRepo.evaluateCommand): Remove AddReviewerToChangeLog.
(ValidateCommitMessage._files): List all modified files.
(ValidateCommitMessage.evaluateCommand): Fail step if no ChangeLog modified.
(AddReviewerToChangeLog): Deleted.
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/250643@main
- 6:22 AM Changeset in webkit [294322] by
-
- 15 edits in trunk/Source/WebKit
[WPE] Use new libwpe API to synchronise display refreshes fully to the screen refresh rate
https://bugs.webkit.org/show_bug.cgi?id=240453
Reviewed by Adrian Perez de Castro.
Use new libwpe API to track the target refresh rate and use it in
ThreadedDisplayRefreshMonitor for DisplayUpdate objects.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::targetRefreshRateDidChange):
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
(WebKit::ThreadedDisplayRefreshMonitor::ThreadedDisplayRefreshMonitor):
(WebKit::ThreadedDisplayRefreshMonitor::setTargetRefreshRate):
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.h:
- UIProcess/API/wpe/WPEView.cpp:
(WKWPE::m_backend):
- UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:
(WebKit::DrawingAreaProxyCoordinatedGraphics::targetRefreshRateDidChange):
- UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h:
- UIProcess/DrawingAreaProxy.h:
- WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::targetRefreshRateDidChange):
- WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h:
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::targetRefreshRateDidChange):
- WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::targetRefreshRateDidChange):
- WebProcess/WebPage/DrawingArea.messages.in:
- 6:22 AM Changeset in webkit [294321] by
-
- 2 edits in trunk
[GTK] Build MiniBrowser by default
https://bugs.webkit.org/show_bug.cgi?id=240515
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-05-17
Reviewed by Philippe Normand.
- Source/cmake/OptionsGTK.cmake:
Canonical link: https://commits.webkit.org/250641@main
- 6:13 AM Changeset in webkit [294320] by
-
- 1 edit in trunk/Tools/CISupport/ews-build/config.json
[ews] Move few bots from mac wk1 queues to wk2 queue
https://bugs.webkit.org/show_bug.cgi?id=240513
Reviewed by Jonathan Bedard.
- Tools/CISupport/ews-build/config.json:
Canonical link: https://commits.webkit.org/250640@main
- 5:12 AM Changeset in webkit [294319] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Always have non nullptr for WebAssembly.Memory buffer
https://bugs.webkit.org/show_bug.cgi?id=240510
Reviewed by Mark Lam.
This patch adds CagedUniquePtr to allocate a pointer for that.
- Source/JavaScriptCore/runtime/ArrayBuffer.cpp:
(JSC::ArrayBuffer::makeShared):
- Source/JavaScriptCore/wasm/js/JSWebAssemblyMemory.cpp:
(JSC::JSWebAssemblyMemory::buffer):
Canonical link: https://commits.webkit.org/250639@main
- 4:05 AM Changeset in webkit [294318] by
-
- 1 edit2 adds in trunk/LayoutTests
[iOS] Rebaseline 2 tests in imported/w3c/web-platform-tests/html/semantics/forms/
https://bugs.webkit.org/show_bug.cgi?id=240512
Unreviewed test gardening.
- LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt: Added.
- LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt: Added.
Canonical link: https://commits.webkit.org/250638@main
- 2:47 AM Changeset in webkit [294317] by
-
- 12 edits in trunk/Source
ImageBufferIOSurfaceBackend context setup and teardown functions are redundant and error-prone
https://bugs.webkit.org/show_bug.cgi?id=240452
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-17
Reviewed by Simon Fraser.
Source/WebCore:
Remove ImageBuffer::releaseGraphicsContext().
It only made sense to be used before ImageBuffer::setVolatile().
The call setVolatile only made sense after releaseGraphicsContext().
Instead, make releasing the graphics context part of the
setVolatile() contract.
ImageBufferBackend::applyBaseTransformToContext() invoked a virtual
function context(). This was called from the middle of the inheritance chain,
from a constructor.
If a class later in the inheritance chain would override context(), the
call would not be invoked correctly. Currently no class suffered from this, but
in future some might.
ImageBufferIOSurfaceBackend call to applyBaseTransformToContext() would also
recurse through context() back to applyBaseTransformToContext() in non-intuitive
way through overridden ::context() which would re-enter applyBaseTransformToContext().
Based on current knowledge doubly invoking the logic did not cause any harm.
- platform/graphics/ConcreteImageBuffer.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageBufferBackend.cpp:
(WebCore::ImageBufferBackend::applyBaseTransform):
(WebCore::ImageBufferBackend::applyBaseTransformToContext const): Deleted.
- platform/graphics/ImageBufferBackend.h:
(WebCore::ImageBufferBackend::isInUse const):
(WebCore::ImageBufferBackend::releaseGraphicsContext): Deleted.
- platform/graphics/cg/ImageBufferCGBitmapBackend.cpp:
(WebCore::ImageBufferCGBitmapBackend::ImageBufferCGBitmapBackend):
- platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::ImageBufferIOSurfaceBackend):
(WebCore::ImageBufferIOSurfaceBackend::context const):
(WebCore::ImageBufferIOSurfaceBackend::setVolatile):
(WebCore::ImageBufferIOSurfaceBackend::setNonVolatile):
(WebCore::ImageBufferIOSurfaceBackend::initializeContext):
(WebCore::ImageBufferIOSurfaceBackend::releaseGraphicsContext): Deleted.
- platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
Source/WebKit:
Adjust after removing ImageBuffer::releaseGraphicsContext().
- GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::markSurfacesVolatile):
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::setBufferVolatile):
- WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
- 2:08 AM Changeset in webkit [294316] by
-
- 11 edits5 deletes in trunk/LayoutTests
tidy up some test expectations files after resync html/semantics/forms tests
https://bugs.webkit.org/show_bug.cgi?id=240451
Reviewed by Tim Nguyen.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt:
LayoutTests:
This is to tidy up some test expectation files are WPT upstream resync at bug 240301.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Removed.
- 1:38 AM Changeset in webkit [294315] by
-
- 3 edits in trunk
Allow Service Workers to run for a little longer in case of functional events
https://bugs.webkit.org/show_bug.cgi?id=240454
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-17
Reviewed by Chris Dumez.
Functional events should usually trigger opening a new web page on the same origin as the service worker.
There are good chances that the service worker will control the new web page, it is thus potentially useful to
keep the service worker around for a bit, to not pay the cost of stopping and restarting it.
To do so, we introduce a timer in SWServerWorker that handles the termination in case of functional events/debugger.
Covered by updated API test.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:
- Source/WebCore/workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::startTermination):
(WebCore::SWServerWorker::shouldBeTerminated const):
(WebCore::SWServerWorker::terminateIfPossible):
(WebCore::SWServerWorker::terminationIfPossibleTimerFired):
- Source/WebCore/workers/service/server/SWServerWorker.h:
Canonical link: https://commits.webkit.org/250635@main
May 16, 2022:
- 11:18 PM Changeset in webkit [294314] by
-
- 2 edits in branches/safari-7614.1.14.0-branch/Source/WTF
Cherry-pick r294272. rdar://problem/93118830
Correct erroneous guard in Platform file
https://bugs.webkit.org/show_bug.cgi?id=240469
<rdar://problem/93358873>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:18 PM Changeset in webkit [294313] by
-
- 3 edits in branches/safari-7614.1.14.0-branch/Source/WTF
Cherry-pick r294265. rdar://problem/93118830
Remove abandoned WebKitAdditionsFeature1 flag (240462)
https://bugs.webkit.org/show_bug.cgi?id=240462
<rdar://93353298>
Reviewed by Alex Christensen.
Remove the abandoned WebKitAdditionsFeature1 preference, since
it ended up not being needed and now just complicates the build
and generated preferences.
- Scripts/Preferences/WebPreferencesExperimental.yaml:
- wtf/ExperimentalFeatureNames.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:17 PM Changeset in webkit [294312] by
-
- 18 edits in branches/safari-7614.1.14.0-branch
Cherry-pick r294264. rdar://problem/93118830
Remove abandoned UseScreenCaptureKit preference
https://bugs.webkit.org/show_bug.cgi?id=240460
<rdar://problem/93351960>
Reviewed by Youenn Fablet.
We no longer need this switch to activate ScreenCaptureKit, and this code is no
longer used. We should remove it to simplify the build and reduce complexity.
Source/WebCore:
- platform/mediastream/RealtimeMediaSourceCenter.h: (WebCore::RealtimeMediaSourceCenter::useScreenCaptureKit const): Deleted. (WebCore::RealtimeMediaSourceCenter::setUseScreenCaptureKit): Deleted.
Source/WebKit:
- GPUProcess/GPUProcess.cpp: (WebKit::GPUProcess::setUseScreenCaptureKit): Deleted.
- GPUProcess/GPUProcess.h:
- GPUProcess/GPUProcess.messages.in:
- Shared/WebPreferencesDefaultValues.cpp: (WebKit::defaultScreenCaptureKitEnabled): Deleted.
- Shared/WebPreferencesDefaultValues.h:
- UIProcess/API/Cocoa/WKPreferences.mm: (-[WKPreferences _useScreenCaptureKit]): Deleted. (-[WKPreferences _setUseScreenCaptureKit:]): Deleted.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- UIProcess/GPU/GPUProcessProxy.cpp: (WebKit::GPUProcessProxy::updatePreferences):
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp: (WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs const):
Source/WTF:
- Scripts/Preferences/WebPreferencesExperimental.yaml:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm: (TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:17 PM Changeset in webkit [294311] by
-
- 10 edits in branches/safari-7614.1.14.0-branch
Cherry-pick r294208. rdar://problem/93118830
AX: Remove CSSDisplayContentsAXSupportEnabled flag
https://bugs.webkit.org/show_bug.cgi?id=240409
Reviewed by Chris Fleizach.
Source/WebCore:
We added initial support without using this flag and will continue to
fix bugs as we find them, making this flag unnecessary.
- page/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setCSSDisplayContentsAXSupportEnabled): Deleted. (WebCore::RuntimeEnabledFeatures::cssDisplayContentsAXSupportEnabled const): Deleted.
Source/WebKitLegacy/mac:
We added initial support without using this flag and will continue to
fix bugs as we find them, making this flag unnecessary.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (-[WebPreferences cssDisplayContentsAXSupportEnabled]): Deleted. (-[WebPreferences setCSSDisplayContentsAXSupportEnabled:]): Deleted.
- WebView/WebPreferencesPrivate.h:
Source/WTF:
- Scripts/Preferences/WebPreferencesInternal.yaml:
Tools:
- DumpRenderTree/TestOptions.cpp: (WTR::TestOptions::defaults):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:17 PM Changeset in webkit [294310] by
-
- 2 edits in branches/safari-7614.1.14.1-branch/Source/WTF
Cherry-pick r294272. rdar://problem/93118830
Correct erroneous guard in Platform file
https://bugs.webkit.org/show_bug.cgi?id=240469
<rdar://problem/93358873>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:17 PM Changeset in webkit [294309] by
-
- 3 edits in branches/safari-7614.1.14.1-branch/Source/WTF
Cherry-pick r294265. rdar://problem/93118830
Remove abandoned WebKitAdditionsFeature1 flag (240462)
https://bugs.webkit.org/show_bug.cgi?id=240462
<rdar://93353298>
Reviewed by Alex Christensen.
Remove the abandoned WebKitAdditionsFeature1 preference, since
it ended up not being needed and now just complicates the build
and generated preferences.
- Scripts/Preferences/WebPreferencesExperimental.yaml:
- wtf/ExperimentalFeatureNames.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:17 PM Changeset in webkit [294308] by
-
- 18 edits in branches/safari-7614.1.14.1-branch
Cherry-pick r294264. rdar://problem/93118830
Remove abandoned UseScreenCaptureKit preference
https://bugs.webkit.org/show_bug.cgi?id=240460
<rdar://problem/93351960>
Reviewed by Youenn Fablet.
We no longer need this switch to activate ScreenCaptureKit, and this code is no
longer used. We should remove it to simplify the build and reduce complexity.
Source/WebCore:
- platform/mediastream/RealtimeMediaSourceCenter.h: (WebCore::RealtimeMediaSourceCenter::useScreenCaptureKit const): Deleted. (WebCore::RealtimeMediaSourceCenter::setUseScreenCaptureKit): Deleted.
Source/WebKit:
- GPUProcess/GPUProcess.cpp: (WebKit::GPUProcess::setUseScreenCaptureKit): Deleted.
- GPUProcess/GPUProcess.h:
- GPUProcess/GPUProcess.messages.in:
- Shared/WebPreferencesDefaultValues.cpp: (WebKit::defaultScreenCaptureKitEnabled): Deleted.
- Shared/WebPreferencesDefaultValues.h:
- UIProcess/API/Cocoa/WKPreferences.mm: (-[WKPreferences _useScreenCaptureKit]): Deleted. (-[WKPreferences _setUseScreenCaptureKit:]): Deleted.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- UIProcess/GPU/GPUProcessProxy.cpp: (WebKit::GPUProcessProxy::updatePreferences):
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp: (WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs const):
Source/WTF:
- Scripts/Preferences/WebPreferencesExperimental.yaml:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm: (TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:17 PM Changeset in webkit [294307] by
-
- 10 edits in branches/safari-7614.1.14.1-branch
Cherry-pick r294208. rdar://problem/93118830
AX: Remove CSSDisplayContentsAXSupportEnabled flag
https://bugs.webkit.org/show_bug.cgi?id=240409
Reviewed by Chris Fleizach.
Source/WebCore:
We added initial support without using this flag and will continue to
fix bugs as we find them, making this flag unnecessary.
- page/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setCSSDisplayContentsAXSupportEnabled): Deleted. (WebCore::RuntimeEnabledFeatures::cssDisplayContentsAXSupportEnabled const): Deleted.
Source/WebKitLegacy/mac:
We added initial support without using this flag and will continue to
fix bugs as we find them, making this flag unnecessary.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm: (-[WebPreferences cssDisplayContentsAXSupportEnabled]): Deleted. (-[WebPreferences setCSSDisplayContentsAXSupportEnabled:]): Deleted.
- WebView/WebPreferencesPrivate.h:
Source/WTF:
- Scripts/Preferences/WebPreferencesInternal.yaml:
Tools:
- DumpRenderTree/TestOptions.cpp: (WTR::TestOptions::defaults):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:17 PM Changeset in webkit [294306] by
-
- 6 edits in trunk
ISO8601::parseCalendarTime must throw in cases of time/date ambiguity
https://bugs.webkit.org/show_bug.cgi?id=240498
Reviewed by Yusuke Suzuki.
The CalendarTime production (https://tc39.es/proposal-temporal/#prod-CalendarTime) goes to a lot of trouble
to ensure that ambiguous parses are not allowed; this patch ensures that our implementation does so too.
In short:
- CalendarTime is basically TimeDesignator[opt] TimeSpec TimeZone[opt] Calendar[opt].
- When we don't have a TimeDesignator or a Calendar, we're in danger of ambiguity: YYYY-MM, YYYYMM, MM-DD, MMDD look the same as HHMM-UU, HHMMSS, HH-UU, HHMM (where UU is a UTC offset).
- The solution is to attempt to reparse the string as one of these date formats and throw if we succeed.
- stress/temporal-plaintime.js: Adjust expectations.
- test262/expectations.yaml: Mark 10 test cases as passing.
- runtime/ISO8601.cpp:
(JSC::ISO8601::isAmbiguousCalendarTime):
(JSC::ISO8601::parseCalendarTime):
(JSC::ISO8601::daysInMonth):
- runtime/ISO8601.h:
Canonical link: https://commits.webkit.org/250634@main
- 11:11 PM Changeset in webkit [294305] by
-
- 4 edits3 adds in branches/safari-613-branch
Cherry-pick r294012. rdar://problem/92425915
Fix inertness of pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=239831
Reviewed by Antti Koivisto.
When we adjust style for a pseudo-element,
m_elementanddocument().activeModalDialog()are both null. So we accidentally reset inertness to false in those cases.
Fix this by making checking for m_element's existence too.
LayoutTests/imported/w3c:
- web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.
- web-platform-tests/inert/inert-pseudo-element-hittest.html: Added.
Source/WebCore:
Test: imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest.html
- style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjust const):
LayoutTests:
- platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.
Canonical link: https://commits.webkit.org/250446@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:11 PM Changeset in webkit [294304] by
-
- 16 edits2 adds in branches/safari-613-branch
Cherry-pick r293987. rdar://problem/92775435
Implement CSS :modal pseudo class
https://bugs.webkit.org/show_bug.cgi?id=240109
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
Add and extend tests for :modal pseudo-class.
- web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has-expected.txt: Added.
- web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has.html: Added.
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-show-modal.html:
Source/WebCore:
Test: imported/w3c/web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has.html
Renames :-internal-modal-dialog to :modal and adds :has() invalidation support.
- css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText const):
- css/CSSSelector.h:
- css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkOne const):
- css/SelectorCheckerTestFunctions.h: (WebCore::matchesModalPseudoClass): (WebCore::matchesModalDialogPseudoClass): Deleted.
- css/SelectorPseudoClassAndCompatibilityElementMap.in:
- css/dialog.css: (dialog:modal): (dialog:-internal-modal-dialog): Deleted.
- css/parser/CSSSelectorParser.cpp: (WebCore::CSSSelectorParser::consumePseudo):
- cssjit/SelectorCompiler.cpp: (WebCore::SelectorCompiler::JSC_DEFINE_JIT_OPERATION): (WebCore::SelectorCompiler::addPseudoClassType):
- html/HTMLDialogElement.cpp: (WebCore::HTMLDialogElement::showModal): (WebCore::HTMLDialogElement::close): (WebCore::HTMLDialogElement::removedFromAncestor): (WebCore::HTMLDialogElement::setIsModal):
- html/HTMLDialogElement.h:
LayoutTests:
Removes :-internal-modal-dialog from internal pseudo classes.
- fast/css/pseudo-class-internal-expected.txt:
- fast/css/pseudo-class-internal.html:
Canonical link: https://commits.webkit.org/250424@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:11 PM Changeset in webkit [294303] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r293981. rdar://problem/92084291
ASSERT in WebCore::RenderTreeUpdater::updateRenderTree
https://bugs.webkit.org/show_bug.cgi?id=240237
Reviewed by Antti Koivisto.
There are instances where calling findRenderingRoots() in RenderTreeUpdater::commit will
returns two rendering roots, with one of them being an ancestor of the other.
Calling updateRenderTree on the ancestor rendering root could end up removing
the renderer of the descendant rendering root.
This patch merges findRenderingRoots() to RenderTreeUpdater::commit() which, and now we will
ignore the nested root if there is no longer a renderer when it is being processed.
- rendering/updating/RenderTreeUpdater.cpp:
Canonical link: https://commits.webkit.org/250419@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:10 PM Changeset in webkit [294302] by
-
- 2 edits in branches/safari-613-branch/Source/bmalloc
Cherry-pick r293952. rdar://problem/92913312
Force PAS_ASSERT to generate different crash sites for each assertion.
https://bugs.webkit.org/show_bug.cgi?id=240209
Reviewed by Yusuke Suzuki.
Clang currently optimizes all crash sites into one in each function. Hence, if we
get a crash address at the 1 crash site, we don't know which failed assertion got
us there. This patch uses an asm statement to force Clang to emit a different
crash site for each assertion.
Benchmarks show that performance is neutral on both Jetstream2 and Speedometer2.
Size-wise, there is some increase. The following is the "size" output on
JavaScriptCore on M1:
TEXT. DATA OBJC others dec hex
old 19628032 180224 0 18792448 38600704 24d0000
new 19644416 180224 0 19251200 39075840 2544000
diff 16384 0 0 458752 475136
The increase in the "others" categories are mostly in the String Table, Symbol
Table, and Function Start Addresses. These take up disk space but should not
impact RAM usage unless they are accessed by a a debugger.
- libpas/src/libpas/pas_utils.h: (pas_assertion_failed):
Canonical link: https://commits.webkit.org/250398@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:10 PM Changeset in webkit [294301] by
-
- 4 edits in branches/safari-613-branch/Source
Cherry-pick r293894. rdar://problem/74201964
[iOS] Infinite recursion at -[WKFullScreenWindowController _exitFullscreenImmediately]
https://bugs.webkit.org/show_bug.cgi?id=239744
<rdar://74201964>
Reviewed by Eric Carlson.
Source/WebCore:
Even after fullscreen is correctly torn down during an immediate exit, fullscreen can never again
be entered for the lifetime of the page. This is due to the ivar m_pendingExitFullscreen being set
to true with no opportunity for that state to be cleared. This occurs because the callbacks for
exiting fullscreen are performed before the lambda form FullscreenManager::exitFullscreen() is
called.
Set m_pendingExitFullscreen inside exitFullscreen(), rather than the lambda, and clear it explicitly
in the cases where fullscreen exiting is not actually necessary.
The mock behavior of Fullscreen inside DumpRenderTree and WebKitTestRunner are not able to exercise
this same path. Track improvements to this mock in bug #239747.
- dom/FullscreenManager.cpp: (WebCore::FullscreenManager::requestFullscreenForElement): (WebCore::FullscreenManager::exitFullscreen): (WebCore::FullscreenManager::setAnimatingFullscreen): (WebCore::FullscreenManager::setFullscreenControlsHidden):
Source/WebKit:
When exiting fullscreen immediately, we trigger the correct state transition by calling
-[self exitFullScreen]. However, when no fullscreen manager exists (as may happen during
navigation), -exitFullscreen may itself call -_exitFullscreenImmediately, which causes an
infinite recursion and stack overflow.
Unroll the implementation by performing all the same pieces as would have been done by
-exitFullScreen, but inline. Refactor out common behavior into -_reinsertWebViewUnderPlaceholder,
and call that both from -_exitFullscreenImmediately and _completedExitFullScreen.
Unfortunately, no API tests are possible here because TestWebKitAPI is not an actual iOS UI
application.
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController exitFullScreen]): (-[WKFullScreenWindowController _reinsertWebViewUnderPlaceholder]): (-[WKFullScreenWindowController _completedExitFullScreen]): (-[WKFullScreenWindowController _exitFullscreenImmediately]):
Canonical link: https://commits.webkit.org/250352@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:10 PM Changeset in webkit [294300] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore/platform/graphics/avfoundation/objc
Cherry-pick r293877. rdar://problem/92676179
[Cocoa] QueuedVideoOutput constructor missing nil check
https://bugs.webkit.org/show_bug.cgi?id=240149
Reviewed by Eric Carlson.
Covered by existing tests.
- Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.h:
- Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.mm: (WebCore::QueuedVideoOutput::create): (WebCore::QueuedVideoOutput::QueuedVideoOutput): (WebCore::QueuedVideoOutput::valid):
Canonical link: https://commits.webkit.org/250335@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:10 PM Changeset in webkit [294299] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r293647. rdar://problem/92257660
Only stretch the percent height <body> when it is the document element's child
https://bugs.webkit.org/show_bug.cgi?id=239932
<rdar://92257660>
Reviewed by Antti Koivisto.
This IE quirk should only be applied to when the body is actually the document element's child (stretching case).
- rendering/RenderBox.cpp: (WebCore::RenderBox::computeLogicalHeight const):
- rendering/RenderBox.h: (WebCore::RenderBox::parentBox const):
Canonical link: https://commits.webkit.org/250151@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:10 PM Changeset in webkit [294298] by
-
- 2 edits in branches/safari-613-branch/Source/WebKit
Cherry-pick r293433. rdar://problem/91981865
[WebAuthn] Do not pass ASCCredentialRequestTypePlatform... if LocalService unavailable
https://bugs.webkit.org/show_bug.cgi?id=239746
rdar://91981865
Reviewed by Brent Fulgham.
Passing platform in requestTypes breaks the UI in registerations with the syncing platform
authenticator off and local service is unavailable. This patch stops passing it in this case.
- UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::configureRegistrationRequestContext): (WebKit::WebAuthenticatorCoordinatorProxy::performRequest):
Canonical link: https://commits.webkit.org/249993@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:10 PM Changeset in webkit [294297] by
-
- 9 edits in branches/safari-613-branch
Cherry-pick r293264. rdar://problem/92130849
Web Inspector: Regression(r287684) Resources from the memory cache show empty content in Network, Sources, and Search tabs
https://bugs.webkit.org/show_bug.cgi?id=239667
Reviewed by Devin Rousso.
Source/WebCore:
Updated tests:
- http/tests/inspector/network/resource-response-source-disk-cache.html
- http/tests/inspector/network/resource-response-source-memory-cache.html
r287684 introduced a subtle bug when calling InspectorInstrumentation::didReceiveData. We rely
on there being a difference between real, but empty, data buffer and not having a data buffer,
but after r287684 an empty SharedBuffer would be passed in the later case. Instead, we should
continue to pass nullptr if there is no buffer so that InspectorNetworkAgent::didReceiveData
can distiguish between the two.
The bug is the result of having a non-nullptr
datainInspectorNetworkAgent::didReceiveData,
which causes us to callmaybeAddResourceData, which means by the time
InspectorNetworkAgent::getResponseBodyis called, the ResourceData for the request will have
an empty, not non-existant,content(), which means we will return the empty content instead,
since we believe the response had actual content.
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didReceiveDataImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didReceiveData):
- loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
LayoutTests:
Add test steps to ensure that the resource has content, and that the base64Encoded value matches our
expectations. While only the memory cache was affected by this regression, add the test steps to both
the memory and disk caches to defend this functionality.
- http/tests/inspector/network/resource-response-source-memory-cache-expected.txt:
- http/tests/inspector/network/resource-response-source-memory-cache.html:
- http/tests/inspector/network/resource-response-source-disk-cache-expected.txt:
- http/tests/inspector/network/resource-response-source-disk-cache.html:
Canonical link: https://commits.webkit.org/249905@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:10 PM Changeset in webkit [294296] by
-
- 7 edits in branches/safari-613-branch/Source
Cherry-pick r293220. rdar://problem/91924480
Apply purifyNaN in more places.
https://bugs.webkit.org/show_bug.cgi?id=239619
<rdar://problem/91924480>
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
- wasm/js/JSWebAssemblyHelpers.h: (JSC::toJSValue):
Source/WebCore:
- bindings/js/IDBBindingUtilities.cpp: (WebCore::toJS):
- bindings/js/JSDOMConvertWebGL.cpp: (WebCore::convertToJSValue):
- bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readTerminal):
- bridge/objc/objc_utility.mm: (JSC::Bindings::convertObjcValueToValue):
Canonical link: https://commits.webkit.org/249889@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:10 PM Changeset in webkit [294295] by
-
- 7 edits2 adds in branches/safari-613-branch
Cherry-pick r293170. rdar://problem/91117803
AVSampleBufferRenderSynchronizer timeline sometimes goes backwards when playback begins
https://bugs.webkit.org/show_bug.cgi?id=239471
rdar://91117803
Reviewed by Jer Noble.
Source/WebCore:
Test: media/media-source/media-source-current-time.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Log current time and requested playback rate. (WebCore::HTMLMediaElement::setPausedInternal): Log.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC): If time has gone backward, clamp to the most recent seek time. (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playInternal): INFO_LOG -> ALWAYS_LOG (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pauseInternal): Ditto. (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentMediaTime const): Use clampTimeToLastSeekTime. (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::clampTimeToLastSeekTime const): New, clamp time value to the most recent seek time. (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setCurrentTimeDidChangeCallback): Use clampTimeToLastSeekTime. (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance): INFO_LOG -> ALWAYS_LOG (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal): INFO_LOG -> ALWAYS_LOG (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer): INFO_LOG -> ALWAYS_LOG (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setHasAvailableVideoFrame): INFO_LOG -> ALWAYS_LOG (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationChanged): INFO_LOG -> ALWAYS_LOG
Source/WebKit:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: (WebKit::MediaPlayerPrivateRemote::currentTimeChanged): Log when time jumps backwards.
LayoutTests:
- media/media-source/media-source-current-time-expected.txt: Added.
- media/media-source/media-source-current-time.html: Added.
Canonical link: https://commits.webkit.org/249852@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:10 PM Changeset in webkit [294294] by
-
- 6 edits2 moves2 adds in branches/safari-613-branch
Cherry-pick r293126. rdar://problem/90483049
REGRESSION (r281913): Map toolbar flickers when dragging the map on https://gis.ee/
https://bugs.webkit.org/show_bug.cgi?id=238589
<rdar://90483049>
Reviewed by Alan Bujtas.
Source/WebCore:
If a layer has negative z-order descendants, and one of those descendants becomes
composited, then that layer also has to composite, because its foreground needs to render in
front of those descendants. But this is tricky, because the compositing toggle is
out-of-order; we only know that the layer has to get composited after processing
descendants.
In particular, this created a problem with the overlap map, which tracks sets of rectangles
in "compositing scopes" via LayerOverlapMap. The delayed compositing toggle of the layer
with negative z-order descendants meant that any layers processed up to that point had their
bounds added in the wrong overlap scope. This resulted in subsequent bad overlap testing,
and a failure to make later layers composited.
The previous fix in this area (r281913) was incorrect. Revert it, and do a better fix, which
is to speculatively push an overlap map entry for the layer with negative z-order
descendants, if necessary. If this layer ends up not getting composited, we unwind the
speculative push, which will merge that scope with its parent scope.
In addition give OverlapMapContainer (an "overlap scope") a RenderLayer& which we can use
for logging, and to assert on correct behavior; it is not otherwise used in release builds.
Tests: compositing/layer-creation/overlap-with-negative-z-layers.html
compositing/layer-creation/subtree-div-overlaps-multiple-negative-z-divs.html
- rendering/LayerOverlapMap.cpp: (WebCore::OverlapMapContainer::OverlapMapContainer): (WebCore::OverlapMapContainer::scopeLayer const): (WebCore::OverlapMapContainer::dump const): (WebCore::LayerOverlapMap::LayerOverlapMap): (WebCore::LayerOverlapMap::add): (WebCore::LayerOverlapMap::pushCompositingContainer): (WebCore::LayerOverlapMap::popCompositingContainer):
- rendering/LayerOverlapMap.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::traverseUnchangedSubtree): (WebCore::RenderLayerCompositor::updateOverlapMap const):
LayoutTests:
Move subtree-div-overlaps-multiple-negative-z-divs.html into the layer-creation directory.
Add a new test.
- compositing/layer-creation/overlap-with-negative-z-layers-expected.html: Added.
- compositing/layer-creation/overlap-with-negative-z-layers.html: Added.
- compositing/layer-creation/subtree-div-overlaps-multiple-negative-z-divs-expected.html: Renamed from LayoutTests/compositing/subtree-div-overlaps-multiple-negative-z-divs-expected.html.
- compositing/layer-creation/subtree-div-overlaps-multiple-negative-z-divs.html: Renamed from LayoutTests/compositing/subtree-div-overlaps-multiple-negative-z-divs.html.
- fast/harness/render-tree-as-text-options-expected.txt: Test progressed; update results.
Canonical link: https://commits.webkit.org/249828@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:10 PM Changeset in webkit [294293] by
-
- 2 edits in branches/safari-613-branch/Source/WebKit
Cherry-pick r292738. rdar://problem/91295875
Use WebKit::blockedError instead of ResourceLoader::blockedError in WebLoaderStrategy::scheduleLoadFromNetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=239089
<rdar://91295875>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-04-11
Reviewed by Chris Dumez.
The latter dereferences the frame loader which can be null.
- WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
Canonical link: https://commits.webkit.org/249522@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:10 PM Changeset in webkit [294292] by
-
- 3 edits2 adds in branches/safari-613-branch
Cherry-pick r292350. rdar://problem/90589355
intersectsWithAncestor should take fragmented boxes into account.
https://bugs.webkit.org/show_bug.cgi?id=238648
Reviewed by Dean Jackson.
Source/WebCore:
Test: compositing/backing/backing-store-columns-inside-position-fixed.html
- rendering/RenderLayerBacking.cpp: (WebCore::intersectsWithAncestor):
Use boundingBox() for intersectsWithAncestor, so that we can explicitly request the box that contains
all fragment boxes.
LayoutTests:
- compositing/backing/backing-store-columns-inside-position-fixed-expected.txt: Added.
- compositing/backing/backing-store-columns-inside-position-fixed.html: Added.
Adds new test that scrolls content split into columns until the first column is offscreen, to confirm
that we still have a backing store.
Canonical link: https://commits.webkit.org/249215@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:59 PM Changeset in webkit [294291] by
-
- 14 edits1 copy1 add11 deletes in trunk
Resolve ::first-letter eagerly
https://bugs.webkit.org/show_bug.cgi?id=239844
Reviewed by Alan Bujtas.
Source/WebCore:
::first-letter pseudo-element should be resolved eagerly during style resolution, similar to ::first-line.
This will clean up the architecture. It also makes ::first-letter animatable.
- rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::styleDidChange): Deleted.
- rendering/RenderTextFragment.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::removeCachedPseudoStyle): Deleted.
We always create a new style. There is no need to removed pseudo element styles.
- rendering/style/RenderStyle.h:
- rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::styleForFirstLetter):
Pull first-letter style from the parent style instead of resolving it in the middle of render tree building.
(WebCore::RenderTreeBuilder::FirstLetter::updateAfterDescendants):
(WebCore::RenderTreeBuilder::FirstLetter::updateStyle):
Delete the renderer if we no longer have a style.
(WebCore::RenderTreeBuilder::FirstLetter::createRenderers):
- rendering/updating/RenderTreeBuilderFirstLetter.h:
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):
Resove first-letter.
(WebCore::Style::TreeResolver::resolvePseudoElement):
(WebCore::Style::TreeResolver::resolveInheritedPseudoElement):
Factor into a function.
(WebCore::Style::isChildInBlockFormattingContext):
(WebCore::Style::TreeResolver::resolveAncestorFirstLinePseudoElement):
(WebCore::Style::TreeResolver::resolveAncestorFirstLetterPseudoElement):
Resolving first-letter is similar to first-line except it is always a leaf and so won't be inherited from.
(WebCore::Style::TreeResolver::makeResolutionContextForPseudoElement):
(WebCore::Style::TreeResolver::makeResolutionContextForInheritedFirstLine):
- style/StyleTreeResolver.h:
LayoutTests:
- fast/css-generated-content/first-letter-in-nested-before-expected.html: Added.
- fast/css-generated-content/first-letter-in-nested-before-expected.png: Removed.
- fast/css-generated-content/first-letter-in-nested-before-expected.txt: Removed.
- fast/css-generated-content/first-letter-in-nested-before-table-expected.html: Copied from LayoutTests/fast/css-generated-content/first-letter-in-nested-before-table.html.
- fast/css-generated-content/first-letter-in-nested-before-table-expected.png: Removed.
- fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.
- fast/css-generated-content/first-letter-in-nested-before-table.html:
- fast/css-generated-content/first-letter-in-nested-before.html:
Make reftest and update the behavior. ::first-letter won't affect ::before/after with display:table,
matching Firefox behavior (and spec logic).
- platform/glib/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.
- platform/gtk/fast/css-generated-content/first-letter-in-nested-before-expected.png: Removed.
- platform/gtk/fast/css-generated-content/first-letter-in-nested-before-table-expected.png: Removed.
- platform/ios/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.
- platform/mac/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.
- platform/win/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.
- platform/wincairo/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt: Removed.
- 10:52 PM Changeset in webkit [294290] by
-
- 4 edits in trunk/Source
[GTK][WPE] Current-context enforcement in ANGLE is expensive
https://bugs.webkit.org/show_bug.cgi?id=240392
Reviewed by Adrian Perez de Castro.
Source/WebCore:
ANGLE's current-context operations are relatively heavy and introduce
detectable overhead when executed for each of many WebGL operation. More
specifically, loads of the current-thread data from thread-local
storage are done under both EGL_GetCurrentContext() and
EGL_MakeCurrent() through the general TLS access model, relying on the
tls_get_addr function.
Instead, a static thread-local pointer variable is introduced, with the
initial-exec method, containing the address of the current
GraphicsContextGLANGLE object for a given thread. Instead of dipping
into ANGLE to retrieve the current context, the GraphicsContextGLANGLE
object's address is compared to the value of the thread-local variable
and an early return is done if they match.
This model is applied through the TLS_MODEL_INITIAL_EXEC macro that's
defined appropriately if the compiler is detected to support the
required tls_model attribute. This should be the case when targetting
platforms that use ELF, i.e. Unix-like systems but primarily Linux.
The initial-exec TLS model relies on early understanding from the
dynamic linker about what TLS data is required, which enables more
efficient allocation of and access into the required underlying memory.
Caching the current-context data into a static thread-specific variable
with the initial-exec TLS model is the same approach that's taken in the
Mesa library. More on this and other TLS models can be gathered from the
'ELF Handling For Thread-Local Storage' paper by Ulrich Drepper.
- platform/graphics/gbm/GraphicsContextGLGBM.cpp:
(WebCore::GraphicsContextGLANGLE::makeContextCurrent):
Source/WTF:
- wtf/Compiler.h: Define the TLS_MODEL_INITIAL_EXEC macro as the
tls_model attribute with the initial-exec value, to be used on variables
whose TLS model should be adjusted.
- 10:23 PM Changeset in webkit [294289] by
-
- 17 edits2 adds in branches/safari-7614.1.14.100-branch/Source
Cherry-pick r294160. rdar://problem/87170289
Add UI-side layers for optionally indicating interaction regions
https://bugs.webkit.org/show_bug.cgi?id=240372
<rdar://problem/87170289>
Reviewed by Dean Jackson.
Source/WebCore:
- page/DebugPageOverlays.cpp: (WebCore::pathsForRegion): Move inline rect inflation into InteractionRegion so that all clients get it.
- page/Page.cpp: (WebCore::Page::shouldBuildInteractionRegions const):
- page/Page.h:
- page/Frame.cpp: (WebCore::Frame::invalidateContentEventRegionsIfNeeded):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const): (WebCore::RenderLayerBacking::updateEventRegion): If the ENABLE() and setting are both enabled, update event regions due to possible interaction region changes. We could make this more conservative later, but chances are high that most layers include interaction regions.
For now, compute interaction regions only for the root layer.
In a future patch, we will adopt the normal fake paint mechanism
and maintain them on the layer that owns them.
- page/InteractionRegion.cpp: (WebCore::regionForElement): Move inline rect inflation into InteractionRegion so that all clients get it. Limit interaction rects to half of the viewport. Ignore regions that are larger.
- page/InteractionRegion.h: (WebCore::operator==): Added. (WebCore::InteractionRegion::encode const): (WebCore::InteractionRegion::decode): Remove the isInline bit, since we only used it for rect inflation.
- rendering/EventRegion.cpp: (WebCore::EventRegion::operator== const): (WebCore::EventRegion::translate): (WebCore::EventRegion::uniteInteractionRegions): (WebCore::EventRegion::computeInteractionRegions):
- rendering/EventRegion.h: (WebCore::EventRegion::interactionRegions const): (WebCore::EventRegion::encode const): (WebCore::EventRegion::decode): Store interaction regions on EventRegion.
Source/WebKit:
- Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm: (WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer): (WebKit::RemoteLayerTreePropertyApplier::applyHierarchyUpdates): Allow RemoteLayerTreeInteractionRegionLayers to add and maintain layers for interaction regions.
- SourcesCocoa.txt:
- UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.h: Added.
- UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm: Added. (configureLayerForInteractionRegion): (WebKit::interactionRegionForLayer): (WebKit::isInteractionRegionLayer): (WebKit::setInteractionRegion): Box WebCore::InteractionRegion in a Objective-C object and store it on the layer. Use this as a key to indicate that a given layer is an interaction region.
(WebKit::appendInteractionRegionLayersForLayer):
Make sure that interaction region layers are always at the end of the layer's sublayers array.
(WebKit::updateLayersForInteractionRegions):
Add new layers for interaction regions.
Maintain the same layer for regions that cover the same area.
Add a green wash if the defaultWKInteractionRegionDebugFillis set.
- WebKit.xcodeproj/project.pbxproj:
Source/WTF:
- Scripts/Preferences/WebPreferencesInternal.yaml: Add a preference to toggle interaction region layers.
Canonical link: https://commits.webkit.org/250529@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:22 PM Changeset in webkit [294288] by
-
- 42 edits in branches/safari-7614.1.14.100-branch/Source/WebCore
Cherry-pick r293993. rdar://problem/92993954
Const-ify Node::willRespondTo*Events()
https://bugs.webkit.org/show_bug.cgi?id=240246
Reviewed by Wenson Hsieh.
Constify these four methods, because there's no
reason for them not to be, and because it makes
them usable in a const context in a future patch.
- dom/EventNames.h: (WebCore::EventNames::isTouchRelatedEventType const):
- dom/EventTarget.cpp: (WebCore::EventTarget::eventTypes const):
- dom/EventTarget.h:
- dom/Node.cpp: (WebCore::Node::willRespondToMouseMoveEvents const): (WebCore::Node::willRespondToTouchEvents const): (WebCore::Node::willRespondToMouseClickEvents const): (WebCore::Node::willRespondToMouseWheelEvents const):
- dom/Node.h:
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::willRespondToMouseClickEvents const):
- html/HTMLAnchorElement.h:
- html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::willRespondToMouseClickEvents const):
- html/HTMLButtonElement.h:
- html/HTMLElement.cpp: (WebCore::HTMLElement::willRespondToMouseMoveEvents const): (WebCore::HTMLElement::willRespondToMouseWheelEvents const): (WebCore::HTMLElement::willRespondToMouseClickEvents const):
- html/HTMLElement.h:
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::willRespondToMouseClickEvents const):
- html/HTMLImageElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::willRespondToMouseClickEvents const):
- html/HTMLInputElement.h:
- html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::willRespondToMouseClickEvents const):
- html/HTMLLabelElement.h:
- html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::willRespondToMouseClickEvents const):
- html/HTMLPlugInElement.h:
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::willRespondToMouseClickEvents const):
- html/HTMLSelectElement.h:
- html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::willRespondToMouseClickEvents const):
- html/HTMLSummaryElement.h:
- html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::willRespondToMouseClickEvents const):
- html/HTMLTextAreaElement.h:
- html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::shouldSpinButtonRespondToMouseEvents const): (WebCore::TextFieldInputType::shouldSpinButtonRespondToWheelEvents const):
- html/TextFieldInputType.h:
- html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::willRespondToMouseMoveEvents const): (WebCore::SliderThumbElement::willRespondToMouseClickEvents const):
- html/shadow/SliderThumbElement.h:
- html/shadow/SpinButtonElement.cpp: (WebCore::SpinButtonElement::willRespondToMouseMoveEvents const): (WebCore::SpinButtonElement::willRespondToMouseClickEvents const): (WebCore::SpinButtonElement::shouldRespondToMouseEvents const):
- html/shadow/SpinButtonElement.h:
- html/shadow/TextControlInnerElements.cpp: (WebCore::SearchFieldResultsButtonElement::willRespondToMouseClickEvents const): (WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents const):
- html/shadow/TextControlInnerElements.h:
- mathml/MathMLElement.cpp: (WebCore::MathMLElement::willRespondToMouseClickEvents const):
- mathml/MathMLElement.h:
- mathml/MathMLSelectElement.cpp: (WebCore::MathMLSelectElement::willRespondToMouseClickEvents const):
- mathml/MathMLSelectElement.h:
- svg/SVGAElement.cpp: (WebCore::SVGAElement::willRespondToMouseClickEvents const):
- svg/SVGAElement.h:
Canonical link: https://commits.webkit.org/250430@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:21 PM Changeset in webkit [294287] by
-
- 28 edits in trunk/Source
Add ARM64 disassembler support for symbolic dumping of some well known constants.
https://bugs.webkit.org/show_bug.cgi?id=240443
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
- Added a Options::needDisassemblySupport() option. This option is true if any of the JSC disassembly options are enabled. This allows us to trivially check if we need to enable additional infrastructure (like those added in this patch) to support disassembly.
- Refactor the Disassembler's thunkLabelMap into a more generic labelMap. It can now map a pointer to a CString or a const char* label.
- Enable JITOperationList infrastructure when ENABLE(JIT_OPERATION_DISASSEMBLY) is true. This adds a name to the JITOperationAnnotation record. Since this is guarded by ENABLE(JIT_OPERATION_DISASSEMBLY), we can trivially turn this part off later if adding this name adds too much size burden (or if any unexpected issues arise). Turning this off will only disable disassembly of JIT operation names. Disassembly of other constants (see below) will still be supported.
If Options::needDisassemblySupport() is true, the JITOperationList will
register all JIT operations (and the LLInt ones as well) with the Disassembler
labelMap.
- Removed the < > brackets around branch target labels except for internal pc index labels (e.g. <716>) and <unknown> (when we don't know what the branch target is). The < > notation takes up space and doesn't add any info. The branch targets now look like this:
<32> 0x1180102c0: b.ne 0x1180101c0 -> thunk: native Tail With Saved Tags Call trampoline
<92> 0x11801c87c: b 0x118008980 -> thunk: LLInt function for call jump to prologue thunk
<3508> 0x1198e16b4: b 0x1198bc1a0 -> JIT PC
Internal pc index labels will still use the < > brackets:
<3476> 0x1198e1694: b.eq 0x1198e16a0 -> <3488>
- Added ARM64 disassembler support to compute the value of a constant being loaded into a register using "MoveWide" instructions e.g. movz and movk.
When the disassembler sees a movz or movn or mov (of the MoveWide variety),
the disassembler initializes a m_builtConstant value. With each subsequent
movk instruction with the same destination register, the disassembler splices
in the corresponding 16-bit immediate.
After disassembling a MoveWide instruction, it will check if the next
instruction is also a MoveWide instruction targeting the same destination
register. If so, the constant is still being build: hence, it does nothing and
continues.
If the next instruction is (a) a MoveWide instruction targeting a different
register, (b) not a MoveWide instruction, or (c) we've reached the end of the
LinkBuffer (i.e. there's no next instruction), then the constant building for
the current target register is complete.
- Added ARM64 disassembler support for looking up constants (built in (5) above) and printing symbolic info / names of those constants.
With ENABLE(JIT_OPERATION_DISASSEMBLY), we now have JIT operation names e.g.
<176> 0x118010270: movk x3, #0x9f6e, lsl #48 -> 0x102dc8950 operationVMHandleException
<164> 0x1180180a4: movk x8, #0xe5c, lsl #48 -> 0x102db9420 operationVirtualCall
Apart from looking up the constant in the Disassembler labelMap, it also looks
up some commonly used constants e.g.
- VM pointers:
<156> 0x11801105c: movk x0, #0x1, lsl #32 -> 0x139435000 vm
- Some VM internal pointers (more can be added later as needed):
<24> 0x118014d18: movk x17, #0x1, lsl #32 -> 0x13943ee78 vm +40568: vm.topCallFrame
<76> 0x118014d4c: movk x17, #0x1, lsl #32 -> 0x139441a10 vm +51728: vm.m_exception
<196> 0x118011244: movk x17, #0x1, lsl #32 -> 0x1394417d0 vm +51152: vm.targetMachinePCForThrow
<208> 0x1198e09d0: movk x17, #0x1, lsl #32 -> 0x104432cc0 vm +52416: vm.m_doesGC
- VM related pointers (only 1 for now; not VM fields, but hangs off of VM):
<12> 0x11801938c: movk x1, #0x1, lsl #32 -> 0x1052cd3c8 vm scratchBuffer.m_buffer
- Well known PtrTags:
<204> 0x11801124c: movz x16, #0x6f9b -> 0x6f9b ExceptionHandlerPtrTag ?
<212> 0x1180150d4: movz x16, #0x593 -> 0x593 JSEntryPtrTag ?
<168> 0x1180183a8: movz lr, #0xb389 -> 0xb389 OperationPtrTag ?
- the ? is because we cannot be certain that the 16-bit constant is a PtrTag. It may just be a coincidence that the value is the same. However, the user can trivially look at the surrounding disassembled code, and be able to tell if the value is used as a PtrTag.
For constants that are not found in the known sets:
- Small 16-bit constant (prints decimal value for convenience):
<200> 0x1198e09c8: movz x17, #0x2cc0 -> 11456
- Unknown pointers that aren't in the JIT and LLINT regions will simply print the pointer / constant:
<88> 0x1198e0958: movz x17, #0x2088
<92> 0x1198e095c: movk x17, #0x30d, lsl #16
<96> 0x1198e0960: movk x17, #0x1, lsl #32 -> 0x1030d2088
<unknown> is only used in relative branches.
- Enhanced the Integrity::isSanePointer() check to reject pointer values that are less than 4G on CPU(ADDRESS64) targets for OS(DARWIN). No sane pointer should be in the lowest 4G address region.
This also helps the disassembler more quickly filter out constant values that
aren't pointers.
This change affects DFG's speculationFromCell(), which is the only place that
may affect user facing performance. However, I think the impact should be
insignificant (since the added check is cheap).
- assembler/JITOperationList.cpp:
(JSC::JITOperationList::populatePointersInJavaScriptCore):
(JSC::llintOperations):
(JSC::JITOperationList::populatePointersInJavaScriptCoreForLLInt):
(JSC::JITOperationList::addDisassemblyLabels):
(JSC::JITOperationList::populateDisassemblyLabelsInJavaScriptCore):
(JSC::JITOperationList::populateDisassemblyLabelsInJavaScriptCoreForLLInt):
(JSC::JITOperationList::populateDisassemblyLabelsInEmbedder):
- assembler/JITOperationList.h:
(JSC::JITOperationList::populatePointersInJavaScriptCore):
(JSC::JITOperationList::populatePointersInJavaScriptCoreForLLInt):
- assembler/JITOperationValidation.h:
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::finalizeCodeWithDisassemblyImpl):
- b3/testb3_1.cpp:
(main):
- disassembler/ARM64/A64DOpcode.cpp:
(JSC::ARM64Disassembler::A64DOpcode::appendPCRelativeOffset):
(JSC::ARM64Disassembler::MoveWideFormatTrait::rejectedResult):
(JSC::ARM64Disassembler::MoveWideFormatTrait::acceptedResult):
(JSC::ARM64Disassembler::MoveWideIsValidTrait::rejectedResult):
(JSC::ARM64Disassembler::MoveWideIsValidTrait::acceptedResult):
(JSC::ARM64Disassembler::A64DOpcodeMoveWide::handlePotentialDataPointer):
(JSC::ARM64Disassembler::A64DOpcodeMoveWide::handlePotentialPtrTag):
(JSC::ARM64Disassembler::A64DOpcodeMoveWide::parse):
(JSC::ARM64Disassembler::A64DOpcodeMoveWide::format):
(JSC::ARM64Disassembler::A64DOpcodeMoveWide::isValid):
- disassembler/ARM64/A64DOpcode.h:
(JSC::ARM64Disassembler::A64DOpcodeMoveWide::baseFormat):
(JSC::ARM64Disassembler::A64DOpcodeMoveWide::formatBuffer):
- disassembler/Disassembler.cpp:
(JSC::Disassembler::ensureLabelMap):
(JSC::registerLabel):
(JSC::labelFor):
(JSC::ensureThunkLabelMap): Deleted.
(JSC::registerThunkLabel): Deleted.
(JSC::labelForThunk): Deleted.
- disassembler/Disassembler.h:
- jsc.cpp:
(jscmain):
- runtime/Gate.h:
- runtime/JSCPtrTag.cpp:
(JSC::ptrTagName):
- runtime/JSCPtrTag.h:
- runtime/Options.cpp:
(JSC::Options::recomputeDependentOptions):
- runtime/OptionsList.h:
- runtime/VM.cpp:
(JSC::VM::isScratchBuffer):
- runtime/VM.h:
- tools/Integrity.h:
(JSC::Integrity::isSanePointer):
Source/WebCore:
- bindings/js/WebCoreJITOperations.cpp:
(WebCore::populateJITOperations):
(WebCore::populateDisassemblyLabels):
- bindings/js/WebCoreJITOperations.h:
(WebCore::populateDisassemblyLabels):
(WebCore::populateJITOperations):
- testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::populateJITOperations):
(WebCoreTestSupport::populateDisassemblyLabels):
- testing/js/WebCoreTestSupport.h:
(WebCoreTestSupport::populateDisassemblyLabels):
(WebCoreTestSupport::populateJITOperations):
Source/WTF:
- Added a ENABLE(JIT_OPERATION_DISASSEMBLY) flag. Currently, this feature relies on an USE(APPLE_INTERNAL_SDK) for enumerating JIT operations similar to ENABLE(JIT_OPERATION_VALIDATION). It is also restricted to ENABLE(DISASSEMBLER) && CPU(ARM64E).
- wtf/PlatformCallingConventions.h:
- wtf/PlatformEnable.h:
- 8:36 PM Changeset in webkit [294286] by
-
- 2 edits in trunk/Source/WebKit/UIProcess/API/C
Expose Page identifier via WKPageRef SPI
https://bugs.webkit.org/show_bug.cgi?id=240400
<rdar://93269635>
Reviewed by Tim Horton.
- Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageGetIdentifier):
- Source/WebKit/UIProcess/API/C/WKPage.h:
Canonical link: https://commits.webkit.org/250630@main
- 8:29 PM Changeset in webkit [294285] by
-
- 7 edits in trunk
Demote -[WKWebView retrieveAccessibilityTreeData:] to SPI
https://bugs.webkit.org/show_bug.cgi?id=240494
rdar://93385094
Reviewed by Tim Horton.
This method was only intended for use in MiniBrowser, and should ship as public API on WKWebView. Move the
declaration and implementation of this over to WKWebViewPrivateForTestingMac.h and WKWebViewTestingMac.mm
(respectively), and additionally prefix this testing-only SPI with an underscore.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView retrieveAccessibilityTreeData:]): Deleted.
- UIProcess/API/mac/WKWebViewPrivateForTestingMac.h:
- UIProcess/API/mac/WKWebViewTestingMac.mm:
(-[WKWebView _retrieveAccessibilityTreeData:]):
Demote -[WKWebView retrieveAccessibilityTreeData:] to SPI
https://bugs.webkit.org/show_bug.cgi?id=240494
rdar://93385094
Reviewed by Tim Horton.
See WebKit/ChangeLog for more details.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController logAccessibilityTrees:]):
Canonical link: https://commits.webkit.org/250629@main
- 6:34 PM Changeset in webkit [294284] by
-
- 3 edits in trunk/Source/JavaScriptCore
Move around some NaN handling code
https://bugs.webkit.org/show_bug.cgi?id=240493
<rdar://92111504>
Reviewed by Yusuke Suzuki.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueRep):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::purifyNaN):
(JSC::FTL::DFG::LowerDFGToB3::compileValueRep):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
Canonical link: https://commits.webkit.org/250628@main
- 6:32 PM Changeset in webkit [294283] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r294215): [ iOS ] Nine fast tests are a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=240495
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250627@main
- 6:00 PM Changeset in webkit [294282] by
-
- 1 edit in trunk/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in
[macOS] Fix mach syscall sandbox violation in the Network process
https://bugs.webkit.org/show_bug.cgi?id=240466
<rdar://93249176>
Reviewed by Chris Dumez.
Fix mach syscall sandbox violation in the Network process on macOS.
- Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
Canonical link: https://commits.webkit.org/250626@main
- 4:58 PM Changeset in webkit [294281] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::InsertTextCommand::positionInsideTextNode
https://bugs.webkit.org/show_bug.cgi?id=240480
Reviewed by Ryosuke Niwa.
Calling pushAnchorElementDown in CompositeEditCommand::positionAvoidingSpecialElementBoundary can
end up removing the startPosition's container node which leaves an invalid endingSelection.
InsertTextCommand::doApply requires a real endingSelection, so we should check if this occurred and bail out.
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::doApply):
- 4:44 PM Changeset in webkit [294280] by
-
- 8 edits in trunk/Source
REGRESSION(r249162): CanvasRenderingContext2DBase::drawImage() crashes if the image is animated and the first frame cannot be decoded
https://bugs.webkit.org/show_bug.cgi?id=239113
rdar://87980543
Reviewed by Simon Fraser.
Source/WebCore:
CanvasRenderingContext2DBase::drawImage() needs to ensure the first frame
of the animated image can be decoded correctly before creating the temporary
static image. If the first frame can't be decoded, this function should return
immediately. This matches the behavior of this function before r249162.
The animated image decodes its frames asynchronously in a work queue. But
the first frame has to be decoded synchronously in the main run loop. So
to avoid running the image decoder in two different threads we are going
to keep the first and the current frame cached when we receive a memory
pressure warning. This should not increase the memory allocation of the
animated image because the numbers of cached frames increases quickly and
we keep all of them till a memory warning is received. But the memory
pressure warning will be received a little bit more often. This depends
on the memory size of the first frame.
To make the code more robust, make ImageSource take a Ref<NativeImage>
instead of taking a RefPtr<NativeImage>.
- html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::drawImage):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::destroyDecodedData):
- platform/graphics/BitmapImage.h:
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::ImageSource):
(WebCore::ImageSource::destroyDecodedData):
(WebCore::ImageSource::setNativeImage):
- platform/graphics/ImageSource.h:
(WebCore::ImageSource::create):
(WebCore::ImageSource::isDecoderAvailable const):
(WebCore::ImageSource::destroyAllDecodedData): Deleted.
(WebCore::ImageSource::destroyAllDecodedDataExcludeFrame): Deleted.
(WebCore::ImageSource::destroyDecodedDataBeforeFrame): Deleted.
Source/WebKit:
- GPUProcess/graphics/RemoteDisplayListRecorder.cpp:
(WebKit::RemoteDisplayListRecorder::drawSystemImage):
- 4:40 PM Changeset in webkit [294279] by
-
- 12 edits in trunk/Source/WebCore
rdar://93377867 (WebKit r294204: weird text rendering artifacts while pages are loading)
- layout/integration/inline/InlineIteratorBox.cpp:
(WebCore::InlineIterator::Box::visualRect const): Deleted.
- layout/integration/inline/InlineIteratorBox.h:
(WebCore::InlineIterator::Box::visualRect const):
(WebCore::InlineIterator::Box::containingBlock const): Deleted.
- layout/integration/inline/InlineIteratorBoxLegacyPath.h:
(WebCore::InlineIterator::BoxLegacyPath::containingBlock const): Deleted.
(WebCore::InlineIterator::BoxLegacyPath::direction const): Deleted.
(WebCore::InlineIterator::BoxLegacyPath::isFirstLine const): Deleted.
- layout/integration/inline/InlineIteratorBoxModernPath.h:
(WebCore::InlineIterator::BoxModernPath::direction const):
(WebCore::InlineIterator::BoxModernPath::containingBlock const): Deleted.
(WebCore::InlineIterator::BoxModernPath::isFirstLine const): Deleted.
- layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::paint):
- rendering/InlineBoxPainter.cpp:
(WebCore::InlineBoxPainter::paintMask):
(WebCore::InlineBoxPainter::paintDecorations):
- rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::addTextBoxVisualOverflow):
- rendering/LegacyInlineTextBox.cpp:
(WebCore::LegacyInlineTextBox::paint):
- rendering/LegacyInlineTextBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
- rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::TextBoxPainter):
(WebCore::TextBoxPainter::~TextBoxPainter):
(WebCore::TextBoxPainter::paint):
(WebCore::TextBoxPainter::createMarkedTextFromSelectionInBox):
(WebCore::TextBoxPainter::paintBackground):
(WebCore::TextBoxPainter::paintForegroundAndDecorations):
(WebCore::TextBoxPainter::paintCompositionBackground):
(WebCore::TextBoxPainter::paintForeground):
(WebCore::TextBoxPainter::createDecorationPainter):
(WebCore::TextBoxPainter::paintBackgroundDecorations):
(WebCore::TextBoxPainter::paintForegroundDecorations):
(WebCore::TextBoxPainter::paintCompositionUnderlines):
(WebCore::textPosition):
(WebCore::TextBoxPainter::paintCompositionUnderline):
(WebCore::TextBoxPainter::paintPlatformDocumentMarkers):
(WebCore::TextBoxPainter::calculateUnionOfAllDocumentMarkerBounds):
(WebCore::TextBoxPainter::paintPlatformDocumentMarker):
(WebCore::TextBoxPainter::computePaintRect):
(WebCore::TextBoxPainter::calculateDocumentMarkerBounds):
(WebCore::TextBoxPainter::computeHaveSelection const):
(WebCore::TextBoxPainter::fontCascade const):
(WebCore::TextBoxPainter::textOriginFromPaintRect const):
(WebCore::TextBoxPainter::debugTextShadow const):
(WebCore::LegacyTextBoxPainter::LegacyTextBoxPainter): Deleted.
(): Deleted.
(WebCore::ModernTextBoxPainter::ModernTextBoxPainter): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::TextBoxPainter): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::~TextBoxPainter): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::makeIterator const): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::paint): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::createMarkedTextFromSelectionInBox): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::paintBackground): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::paintForegroundAndDecorations): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::paintCompositionBackground): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::paintForeground): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::createDecorationPainter): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::paintBackgroundDecorations): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::paintForegroundDecorations): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::paintCompositionUnderlines): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::textPosition): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::paintCompositionUnderline): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::paintPlatformDocumentMarkers): Deleted.
(WebCore::LegacyTextBoxPainter::calculateUnionOfAllDocumentMarkerBounds): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::paintPlatformDocumentMarker): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::computePaintRect): Deleted.
(WebCore::calculateDocumentMarkerBounds): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::computeHaveSelection const): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::fontCascade const): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::textOriginFromPaintRect const): Deleted.
(WebCore::TextBoxPainter<TextBoxPath>::debugTextShadow const): Deleted.
- rendering/TextBoxPainter.h:
(WebCore::TextBoxPainter::textBox const):
- 4:40 PM Changeset in webkit [294278] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=240489
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250622@main
- 4:13 PM Changeset in webkit [294277] by
-
- 8 edits2 adds in branches/safari-613-branch
Apply patch. rdar://problem/88672183
- 4:13 PM Changeset in webkit [294276] by
-
- 6 edits in branches/safari-613-branch/Source/WebCore
Apply patch. rdar://problem/88408231
- 4:03 PM Changeset in webkit [294275] by
-
- 6 edits2 adds in trunk
Take intrinsicBorderForFieldset() into account in intrinsically sized fieldset
https://bugs.webkit.org/show_bug.cgi?id=240388
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Add test.
- web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size.html: Added.
Source/WebCore:
With 'box-sizing: content-box', computeIntrinsicLogicalContentHeightUsing
was not taking intrinsicBorderForFieldset() into account. So a fieldset
with 'height: min-content' would ignore the extra space required by the
legend, and the contents would overflow.
This patch adds a RenderBox::adjustIntrinsicLogicalHeightForBoxSizing
method with the logic, and overrides it in RenderBlock to take
intrinsicBorderForFieldset() into account.
Test: imported/w3c/web-platform-tests/html/semantics/forms/the-fieldset-element/fieldset-intrinsic-size.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustIntrinsicLogicalHeightForBoxSizing const):
Take intrinsicBorderForFieldset() into account.
- rendering/RenderBlock.h:
Override adjustIntrinsicLogicalHeightForBoxSizing.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::adjustIntrinsicLogicalHeightForBoxSizing const):
(WebCore::RenderBox::computeIntrinsicLogicalContentHeightUsing const):
Move logic into a new method so that RenderBlock can override it.
- rendering/RenderBox.h:
Declare adjustIntrinsicLogicalHeightForBoxSizing as virtual.
No need for computeIntrinsicLogicalContentHeightUsing to be virtual.
- 3:59 PM Changeset in webkit [294274] by
-
- 2 edits in trunk/Source/WebKit
Fix the build after 250556@main
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
Maintain the status quo here, for now, by adopting unsafeBuffer().
- 3:56 PM Changeset in webkit [294273] by
-
- 2 edits in trunk/Source/WebCore
[CMake][VS] PrivateHeaders/WebCore/WebCoreJSBuiltinInternals.h is not updated in incremental build
https://bugs.webkit.org/show_bug.cgi?id=240297
Reviewed by Don Olmstead.
In CMake Visual Studio generator builds,
WebCoreJSBuiltinInternals.h was not copied to the private headers
directory as expected in incremental builds.
${WebCore_DERIVED_SOURCES_DIR}/WebCoreJSBuiltinInternals.h was
added to both WebCore_SOURCES and WebCore_PRIVATE_FRAMEWORK_HEADERS.
This caused the incremental build problem. Don't add the headers
to WebCore_SOURCES.
There was another minor problem. ${WebCore_BUILTINS_SOURCES} was
passed to the MAIN_DEPENDENCY argument of add_custom_command.
However, MAIN_DEPENDENCY argument should take a single file. It
should be passed to DEPENDS argument.
- CMakeLists.txt:
- 3:43 PM Changeset in webkit [294272] by
-
- 2 edits in trunk/Source/WTF
Correct erroneous guard in Platform file
https://bugs.webkit.org/show_bug.cgi?id=240469
<rdar://problem/93358873>
- 3:35 PM Changeset in webkit [294271] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
-Wdangling-pointer warning when building ANGLE with GCC 12
https://bugs.webkit.org/show_bug.cgi?id=239339
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-05-16
Reviewed by Yusuke Suzuki and Kenneth Russell.
- Source/ThirdParty/ANGLE/CMakeLists.txt:
Canonical link: https://commits.webkit.org/250617@main
- 3:26 PM Changeset in webkit [294270] by
-
- 9 edits in branches/safari-613-branch/Source
Versioning.
WebKit-7613.3.2
- 3:26 PM Changeset in webkit [294269] by
-
- 9 edits in branches/safari-613-branch/Source
Revert "Versioning."
This reverts r294068.
- 3:25 PM Changeset in webkit [294268] by
-
- 2 edits in trunk/Source/WebKit
[SOUP2] Compute number of header bytes whe using soup 2
https://bugs.webkit.org/show_bug.cgi?id=240200
Reviewed by Michael Catanzaro.
SOUP 2 lacks methods that allow to get computed head sizes (only present in v3),
calculate the sizes manually when libsoup 2 is used.
No new tests, covered by LayoutTests/http/tests/inspector/network/resource-sizes-network.html
when compiled with SOUP 2.
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::addHeaderSizes):
(WebKit::NetworkDataTaskSoup::didGetHeaders):
- 3:25 PM Changeset in webkit [294267] by
-
- 4 edits in trunk
[css-ui] Unexpose attachment and borderless-attachment appearance values
https://bugs.webkit.org/show_bug.cgi?id=240447
Reviewed by Tim Horton.
Hide them behind the attachmentElementEnabled setting.
Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
LayoutTests:
- imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
Source/WebCore:
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
Canonical link: https://commits.webkit.org/250615@main
- 3:18 PM Changeset in webkit [294266] by
-
- 5 edits in trunk/Source
[css-ui] Update documentation for appearance CSS property
https://bugs.webkit.org/show_bug.cgi?id=240481
Reviewed by Devin Rousso.
Account for r294226, r294187 and r294170.
Source/WebCore:
- css/CSSProperties.json:
Source/WebInspectorUI:
- UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
- UserInterface/External/CSSDocumentation/CSSDocumentation.js:
Canonical link: https://commits.webkit.org/250614@main
- 2:53 PM Changeset in webkit [294265] by
-
- 3 edits in trunk/Source/WTF
Remove abandoned WebKitAdditionsFeature1 flag (240462)
https://bugs.webkit.org/show_bug.cgi?id=240462
<rdar://93353298>
Reviewed by Alex Christensen.
Remove the abandoned WebKitAdditionsFeature1 preference, since
it ended up not being needed and now just complicates the build
and generated preferences.
- Scripts/Preferences/WebPreferencesExperimental.yaml:
- wtf/ExperimentalFeatureNames.h:
- 2:44 PM Changeset in webkit [294264] by
-
- 18 edits in trunk
Remove abandoned UseScreenCaptureKit preference
https://bugs.webkit.org/show_bug.cgi?id=240460
<rdar://problem/93351960>
Reviewed by Youenn Fablet.
We no longer need this switch to activate ScreenCaptureKit, and this code is no
longer used. We should remove it to simplify the build and reduce complexity.
Source/WebCore:
- platform/mediastream/RealtimeMediaSourceCenter.h:
(WebCore::RealtimeMediaSourceCenter::useScreenCaptureKit const): Deleted.
(WebCore::RealtimeMediaSourceCenter::setUseScreenCaptureKit): Deleted.
Source/WebKit:
- GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::setUseScreenCaptureKit): Deleted.
- GPUProcess/GPUProcess.h:
- GPUProcess/GPUProcess.messages.in:
- Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultScreenCaptureKitEnabled): Deleted.
- Shared/WebPreferencesDefaultValues.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _useScreenCaptureKit]): Deleted.
(-[WKPreferences _setUseScreenCaptureKit:]): Deleted.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::updatePreferences):
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs const):
Source/WTF:
- Scripts/Preferences/WebPreferencesExperimental.yaml:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMediaWindowAndScreen.mm:
(TestWebKitAPI::TEST):
- 2:43 PM Changeset in webkit [294263] by
-
- 2 edits in trunk/Tools/buildstream
[Flatpak SDK] Update libwpe to version 1.13.2
https://bugs.webkit.org/show_bug.cgi?id=240470
Reviewed by Philippe Normand.
- elements/sdk/libwpe.bst: Update to version 1.13.2, switch download URL to the
canonical release site while at it.
Canonical link: https://commits.webkit.org/250611@main
- 2:41 PM Changeset in webkit [294262] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, fix build after 250565@main
https://bugs.webkit.org/show_bug.cgi?id=240416
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-05-16
- Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
- Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter<TextBoxPath>::debugTextShadow const):
Canonical link: https://commits.webkit.org/250610@main
- 2:37 PM Changeset in webkit [294261] by
-
- 9 edits in trunk
Unreviewed, reverting r294238.
Breaks internal builds
Reverted changeset:
"Use _adoptEffectiveConfiguration instead of a separate
NSURLSession without credentials"
https://bugs.webkit.org/show_bug.cgi?id=240362
https://commits.webkit.org/r294238
- 2:21 PM Changeset in webkit [294260] by
-
- 31 edits in branches/safari-7614.1.14.1-branch
Cherry-pick r294225. rdar://problem/92978482
Make sure calling showNotification will extend the service worker lifetime
https://bugs.webkit.org/show_bug.cgi?id=240273
<rdar://92978482>
Reviewed by Chris Dumez.
Source/WebCore:
Update NotificationClient API so that show is taking a completion handler.
Make use of this completion handler to resolve the promise when the show notification steps are done, as per spec.
Register push event to ServiceWorkerGlobalScope when the event handlers are called.
When ServiceWorkerRegistration::show is called during one of the push event handlers,
extend the push event lifetime by adding the show notification promise to the push event.
Covered by API test.
- Modules/notifications/Notification.cpp:
- Modules/notifications/Notification.h:
- Modules/notifications/NotificationClient.h:
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h:
- workers/service/ServiceWorkerGlobalScope.cpp:
- workers/service/ServiceWorkerGlobalScope.h:
- workers/service/ServiceWorkerRegistration.cpp:
- workers/service/ServiceWorkerRegistration.h:
- workers/service/context/ServiceWorkerThread.cpp:
Source/WebKit:
On WebProcess side, implement the new NoficationClient::show API that takes a callback.
Delay calling this callback until UIProcess tells us so through async IPC.
On UIProcess side, take a callback and call it when the show notification steps are done.
- NetworkProcess/Notifications/NetworkNotificationManager.cpp:
- NetworkProcess/Notifications/NetworkNotificationManager.h:
- Shared/Notifications/NotificationManagerMessageHandler.h:
- Shared/Notifications/NotificationManagerMessageHandler.messages.in:
- UIProcess/Notifications/ServiceWorkerNotificationHandler.cpp:
- UIProcess/Notifications/ServiceWorkerNotificationHandler.h:
- UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp:
- UIProcess/Notifications/WebNotificationManagerMessageHandler.h:
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
- WebProcess/Notifications/WebNotificationManager.cpp:
- WebProcess/Notifications/WebNotificationManager.h:
- WebProcess/WebCoreSupport/WebNotificationClient.cpp:
- WebProcess/WebCoreSupport/WebNotificationClient.h:
Source/WebKitLegacy/mac:
- WebCoreSupport/WebNotificationClient.h:
- WebCoreSupport/WebNotificationClient.mm:
Tools:
- TestWebKitAPI/TestNotificationProvider.cpp:
- TestWebKitAPI/TestNotificationProvider.h:
- TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:21 PM Changeset in webkit [294259] by
-
- 1 edit in trunk/Source/WebCore/css/CSSProperties.json
Fix URL to offset-rotate property in CSSProperties.json
https://bugs.webkit.org/show_bug.cgi?id=240474
Reviewed by Myles C. Maxfield.
No new tests, not a functional change.
- Source/WebCore/css/CSSProperties.json:
Canonical link: https://commits.webkit.org/250608@main
- 2:21 PM Changeset in webkit [294258] by
-
- 8 edits in branches/safari-7614.1.14.1-branch
Cherry-pick r294218. rdar://problem/90400867
Right click > "Open Link" should trigger a navigation action with WKNavigationTypeLinkActivated
https://bugs.webkit.org/show_bug.cgi?id=240427
rdar://90400867
Reviewed by Tim Horton.
Add a new linked-on-or-after check to guard this new behavior for apps built against newer SDK versions.
- wtf/cocoa/RuntimeApplicationChecksCocoa.h: Right click > "Open Link" should trigger a navigation action with WKNavigationTypeLinkActivated https://bugs.webkit.org/show_bug.cgi?id=240427 rdar://90400867
Reviewed by Tim Horton.
Make a couple of minor adjustments to
ContextMenuControllerto ensure that right clicking a link and choosing
"Open Link" or "Open Link in New Window" surfaces a navigation action withWKNavigationTypeLinkActivated,
rather thanWKNavigationTypeOther.
Test: ContextMenuTests.NavigationTypeWhenOpeningLink
- page/ContextMenuContext.cpp: (WebCore::ContextMenuContext::ContextMenuContext):
- page/ContextMenuContext.h: (WebCore::ContextMenuContext::event const):
Save a reference to the
Eventof type "contextmenu" that's triggering context menu presentation in the
ContextMenuContext.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::maybeCreateContextMenu): (WebCore::openNewWindow):
Plumb the
"contextmenu"event through toFrameLoader::loadFrameRequestwhen opening links via context menu.
(WebCore::ContextMenuController::contextMenuItemSelected):
Right click > "Open Link" should trigger a navigation action with WKNavigationTypeLinkActivated
https://bugs.webkit.org/show_bug.cgi?id=240427
rdar://90400867
Reviewed by Tim Horton.
Add an API test to verify that right clicking a link and selecting "Open Link" triggers a navigation action with
the typeWKNavigationTypeLinkActivated.
- TestWebKitAPI/Tests/mac/ContextMenuTests.mm: (TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/250576@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:19 PM Changeset in webkit [294257] by
-
- 5 edits in releases/WebKitGTK/webkit-2.36/Source
Merge r294177 - Non-unified build broken in debug mode
https://bugs.webkit.org/show_bug.cgi?id=240378
Unreviewed non-unified build fixes.
- heap/StructureAlignedMemoryAllocator.cpp: Include <sys/mman.h> if needed.
Non-unified build broken in debug mode
https://bugs.webkit.org/show_bug.cgi?id=240378
Unreviewed non-unified build fixes.
- contentextensions/ContentExtensionCompiler.cpp: Add missing wtf/CrossThreadCopier.h header.
- workers/service/ServiceWorkerClients.cpp: Add missing Logging.h header.
Canonical link: https://commits.webkit.org/250544@main
- 2:19 PM Changeset in webkit [294256] by
-
- 5 edits in releases/WebKitGTK/webkit-2.36/Source
Merge r294154 - Unreviewed, non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=240369
Source/JavaScriptCore:
- runtime/DateConversion.cpp:
Source/WebCore:
- Modules/highlight/HighlightRegister.h:
- rendering/TextPainter.h:
- 2:15 PM Changeset in webkit [294255] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.2
- 2:01 PM Changeset in webkit [294254] by
-
- 1 edit in trunk/metadata/contributors.json
Add myself to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240475
Reviewed by Myles C. Maxfield.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250607@main
- 1:45 PM Changeset in webkit [294253] by
-
- 66 edits2 adds2 deletes in branches/safari-7614.1.14.0-branch/Source/WebKit
Cherry-pick r294190. rdar://problem/91006582
SharedBuffer should be copied and then attributed back to WebContent
https://bugs.webkit.org/show_bug.cgi?id=240223
rdar://91006582
Patch by Jean-Yves Avenard <jean-yves.avenard@apple.com> on 2022-05-14
Reviewed by Jer Noble.
Ideally, when mapping an IPCHandle we would prefer to use Copy On Write.
However, there's no support for COW with explicitly-owned memory such as
those created with VM_FLAGS_PURGABLE flag.
As such, when calling mach_vm_map with copy=true argument is set the
entire page will be copied.
It is therefore more performant to manually create a new buffer and copy
the actual content.
The memory can then be blamed on a particular process.
Rework FragmentedSharedBuffer/SharedBuffer IPC's serializer to perform
a copy, partially reverting changes made in bug 233401.
We replace the unnecessary use of SharedMemory::IPCHandle and directly
send SharedBuffer in clipboard and PDF related methods.
Rename SharedBufferCopy to SharedBufferReference to more accurately
describe what it does.
Make new use of the SharedBufferReference class, replacing the use of IPCHandle
in RemoteSourceBufferProxy and RemoteMediaResourceManager.
Rename SharedBufferReference::buffer() into
SharedBufferReference::unsafeBuffer() to give better clarity that accessing
SharedBuffer and SharedMemory should be treated with care.
SharedBuffer sent from trusted processes such as network process should
prefer the use of SharedBufferReference over directly using IPCHandle or
SharedBuffer, it makes optimisation easier and avoid duplicating code.
No observable change, covered by existing tests.
- GPUProcess/GPUConnectionToWebProcess.cpp: (WebKit::GPUConnectionToWebProcess::remoteMediaResourceManager):
- GPUProcess/media/RemoteCDMInstanceProxy.h:
- GPUProcess/media/RemoteImageDecoderAVFProxy.cpp: (WebKit::RemoteImageDecoderAVFProxy::createDecoder): (WebKit::RemoteImageDecoderAVFProxy::setData):
- GPUProcess/media/RemoteImageDecoderAVFProxy.h:
- GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in:
- GPUProcess/media/RemoteMediaResourceManager.cpp: (WebKit::RemoteMediaResourceManager::RemoteMediaResourceManager): (WebKit::RemoteMediaResourceManager::dataReceived):
- GPUProcess/media/RemoteMediaResourceManager.h:
- GPUProcess/media/RemoteMediaResourceManager.messages.in:
- GPUProcess/media/RemoteSourceBufferProxy.cpp: (WebKit::RemoteSourceBufferProxy::append):
- GPUProcess/media/RemoteSourceBufferProxy.h:
- GPUProcess/media/RemoteSourceBufferProxy.messages.in:
- NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::bufferingTimerFired): (WebKit::NetworkResourceLoader::sendBuffer): (WebKit::NetworkResourceLoader::dataReceivedThroughContentFilter):
- NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.cpp: (WebKit::ServiceWorkerDownloadTask::didReceiveData):
- NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h:
- NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.messages.in:
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp: (WebKit::ServiceWorkerFetchTask::didReceiveData): (WebKit::ServiceWorkerFetchTask::loadBodyFromPreloader):
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in:
- Platform/IPC/SharedBufferCopy.cpp: Removed.
- Platform/IPC/SharedBufferCopy.h: Removed.
- Platform/IPC/SharedBufferReference.cpp: Added. (IPC::SharedBufferReference::encode const): (IPC::SharedBufferReference::decode): (IPC::SharedBufferReference::unsafeBuffer const): (IPC::SharedBufferReference::data const): (IPC::SharedBufferReference::bufferWithOwner const):
- Platform/IPC/SharedBufferReference.h: Added. (IPC::SharedBufferReference::SharedBufferReference): (IPC::SharedBufferReference::size const): (IPC::SharedBufferReference::isEmpty const): (IPC::SharedBufferReference::isNull const):
- Platform/SharedMemory.cpp: (WebKit::transferOwnershipOfMemory const):
- Platform/SharedMemory.h:
- Platform/cocoa/SharedMemoryCocoa.cpp: (WebKit::changeOwnershipOfMemory): (WebKit::SharedMemory::Handle::takeOwnershipOfMemory const): (WebKit::SharedMemory::Handle::transferOwnershipOfMemory const): (WebKit::machProtection): (WebKit::SharedMemory::map):
- Scripts/process-entitlements.sh:
- Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp: (WebKit::CGDisplayListImageBufferBackend::createBackendHandle const):
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: (WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
- Shared/WebCoreArgumentCoders.cpp: (IPC::encodeSharedBuffer): (IPC::decodeSharedBuffer):
- Sources.txt:
- UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView createPDFWithConfiguration:completionHandler:]):
- UIProcess/Cocoa/WebPageProxyCocoa.mm: (WebKit::WebPageProxy::platformRegisterAttachment):
- UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: (WebKit::WebPasteboardProxy::getPasteboardBufferForType): (WebKit::WebPasteboardProxy::setPasteboardBufferForType): (WebKit::WebPasteboardProxy::readBufferFromPasteboard):
- UIProcess/Cocoa/WebProcessProxyCocoa.mm: (WebKit::WebProcessProxy::sendAudioComponentRegistrations):
- UIProcess/WebPageProxy.cpp: (WebKit::CompletionHandler<void): (WebKit::WebPageProxy::drawPagesToPDF): (WebKit::WebPageProxy::drawToPDF): (WebKit::WebPageProxy::getLoadDecisionForIcon): (WebKit::WebPageProxy::updateAttachmentAttributes): (WebKit::WebPageProxy::registerAttachmentIdentifierFromData): (WebKit::WebPageProxy::platformRegisterAttachment):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPasteboardProxy.cpp: (WebKit::WebPasteboardProxy::readBufferFromPasteboard):
- UIProcess/WebPasteboardProxy.h:
- UIProcess/WebPasteboardProxy.messages.in:
- UIProcess/WebURLSchemeTask.cpp: (WebKit::WebURLSchemeTask::didReceiveData):
- UIProcess/gtk/WebPasteboardProxyGtk.cpp: (WebKit::WebPasteboardProxy::readBuffer):
- UIProcess/ios/WKContentView.mm: (-[WKContentView _wk_pageCountForPrintFormatter:]):
- UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::drawToPDFiOS):
- UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::dataSelectionForPasteboard):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/graphics/ImageBufferBackendHandle.h:
- WebProcess/GPU/media/RemoteImageDecoderAVF.cpp: (WebKit::RemoteImageDecoderAVF::setData):
- WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp: (WebKit::RemoteImageDecoderAVFManager::createImageDecoder):
- WebProcess/GPU/media/RemoteMediaResourceProxy.cpp: (WebKit::RemoteMediaResourceProxy::dataReceived):
- WebProcess/GPU/media/SourceBufferPrivateRemote.cpp: (WebKit::SourceBufferPrivateRemote::append):
- WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::didReceiveData):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::writeItemsToPasteboard):
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: (WebKit::WebServiceWorkerFetchTaskClient::didReceiveData): (WebKit::WebServiceWorkerFetchTaskClient::didReceiveBlobChunk):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::registerAttachmentIdentifier):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::bufferForType): (WebKit::WebPlatformStrategies::setBufferForType): (WebKit::WebPlatformStrategies::readBufferFromClipboard): (WebKit::WebPlatformStrategies::readBufferFromPasteboard):
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: (WebKit::WebDragClient::declareAndWriteDragImage):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::getContentsAsMHTMLData): (WebKit::WebPage::getSelectionAsWebArchiveData): (WebKit::WebPage::getMainResourceDataOfFrame): (WebKit::WebPage::getResourceDataFromFrame): (WebKit::WebPage::getWebArchiveOfFrame): (WebKit::WebPage::getAccessibilityTreeData): (WebKit::WebPage::drawToPDF): (WebKit::WebPage::drawPagesToPDF): (WebKit::WebPage::didGetLoadDecisionForIcon): (WebKit::WebPage::urlSchemeTaskDidReceiveData): (WebKit::WebPage::updateAttachmentAttributes):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::getDataSelectionForPasteboard): (WebKit::WebPage::performActionOnElement): (WebKit::WebPage::drawToPDFiOS): (WebKit::WebPage::didFinishLoadForQuickLookDocumentInMainFrame):
- WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getDataSelectionForPasteboard):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::consumeAudioComponentRegistrations):
# Please populate the above commit message. Lines starting
# with '#' will be ignored
# 13 Tim Horton <timothy_horton@apple.com>
#
# ApplePayLogoSystemImage needlessly loads PassKit in WebKit child processes on iOS
# https://bugs.webkit.org/show_bug.cgi?id=240404
# <rdar://93070349>
#
# Reviewed by Chris Dumez.
#
# * UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
# (WebKit::ProcessLauncher::launchProcess): Adopt the WTF implementation of systemDirectoryPath.
# (WebKit::systemDirectoryPath): Moved to WTF.
#
# 13 Wenson Hsieh <Wenson Hsieh>
#
# ImageAnalysisQueue should reanalyze image elements whose image sources have changed
# https://bugs.webkit.org/show_bug.cgi?id=240371
# rdar://93175651
#
# Reviewed by Tim Horton.
#
# To aid with debugging similar issues in the future, plumb the image URL through to
#requestImageAnalysisWithIdentifier, which (if an engineering default is specified) will additionally reveal
# the URL in system logs.
#
# * Platform/cocoa/ImageAnalysisUtilities.h:
# * UIProcess/Cocoa/WebViewImpl.mm:
# (WebKit::WebViewImpl::requestTextRecognition):
# * UIProcess/ios/WKContentViewInteraction.mm:
# (-[WKContentView requestTextRecognition:imageData:identifier:completionHandler:]):
#
# 13 Aditya Keerthi <Aditya Keerthi>
#
# [iOS] Multiple visible find highlights when searching for text after beginning a "find from selection"
# https://bugs.webkit.org/show_bug.cgi?id=240393
# rdar://91441895
#
# Reviewed by Wenson Hsieh.
#
# Some WebKit clients use SPI on WKWebView to support "find from selection"
# functionality (the Cmd+E shortcut). However, to support general
# find functionality, they use new find API that uses a different codepath
# to draw highlights. Mixing use of the API and SPI can currently result
# in two highlights showing up.
#
# To fix, ensure SPI highlights are removed once the API is being used.
# The long term solution is for clients to adopt API for the
# "find from selection" functionality, but in the short term the SPI
# should remain supported.
#
# * WebProcess/WebPage/WebPage.cpp:
# (WebKit::WebPage::clearAllDecoratedFoundText):
#
# 13 Kimmo Kinnunen <kkinnunen@apple.com>
#
# IPC cannot encode, decode Ref<>, causing duplicate code
# https://bugs.webkit.org/show_bug.cgi?id=240160
#
# Reviewed by Antti Koivisto.
#
# Consider reference counted type T:
# Encoding is of signatureencode(const T&)
# Decoding is of signaturestd::optional<Ref<T>> decode()
# This is usable for bothRefPtrandRefuse-cases.
#
# AddRef<T>encoder that is polymorphic toT.
# This way clients do not need to write encoders for
#Ref<T>,RefPtr<T>. They just need one encoder, forT.
#
# When clients do not need to writeRefPtr<T>, they make less
# bugs. These will be corrected in future patches.
#
# HavingRef<T>encoders allows clients to useVector<Ref<T>>encoding
# viaVector<U>encoder, and they would not need to duplicate that
# logic, making less bugs. These will be corrected in future patches.
#
# Remove mostIPC::ArgumentCoder<Ref<..>>in favor ofIPC::ArgumentCoder<..>.
# In the cases where removal was done, remove also redundant
#IPC::ArgumentCoder<RefPtr<..>>.
#
# * Platform/IPC/ArgumentCoders.h:
# (IPC::ArgumentCoder<RefPtr<T>>::decode):
# (IPC::ArgumentCoder<Ref<T>>::encode):
# (IPC::ArgumentCoder<Ref<T>>::decode):
# * Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
# (IPC::ArgumentCoder<WebCore::Font>::encodePlatformData):
# (IPC::ArgumentCoder<WebCore::Font>::decodePlatformData):
# * Shared/WebCoreArgumentCoders.cpp:
# (IPC::ArgumentCoder<WebCore::Font>::encode):
# (IPC::ArgumentCoder<Font>::decode):
# (IPC::ArgumentCoder<SystemImage>::encode):
# (IPC::ArgumentCoder<SystemImage>::decode):
# * Shared/WebCoreArgumentCoders.h:
# * Shared/playstation/WebCoreArgumentCodersPlayStation.cpp:
# (IPC::ArgumentCoder<Font>::encodePlatformData):
# (IPC::ArgumentCoder<Font>::decodePlatformData):
# * Shared/soup/WebCoreArgumentCodersSoup.cpp:
# (IPC::ArgumentCoder<Font>::encodePlatformData):
# (IPC::ArgumentCoder<Font>::decodePlatformData):
# * Shared/win/WebCoreArgumentCodersWin.cpp:
# (IPC::ArgumentCoder<Font>::encodePlatformData):
# (IPC::ArgumentCoder<Font>::decodePlatformData):
#
# 13 Tim Horton <timothy_horton@apple.com>
#
# Add UI-side layers for optionally indicating interaction regions
# https://bugs.webkit.org/show_bug.cgi?id=240372
# <rdar://problem/87170289>
#
# Reviewed by Dean Jackson.
#
# * Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
# (WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
# (WebKit::RemoteLayerTreePropertyApplier::applyHierarchyUpdates):
# Allow RemoteLayerTreeInteractionRegionLayers to add and maintain layers for interaction regions.
#
# * SourcesCocoa.txt:
# * UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.h: Added.
# * UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm: Added.
# (configureLayerForInteractionRegion):
# (WebKit::interactionRegionForLayer):
# (WebKit::isInteractionRegionLayer):
# (WebKit::setInteractionRegion):
# Box WebCore::InteractionRegion in a Objective-C object and store it on the layer.
# Use this as a key to indicate that a given layer is an interaction region.
#
# (WebKit::appendInteractionRegionLayersForLayer):
# Make sure that interaction region layers are always at the end of the layer's sublayers array.
#
# (WebKit::updateLayersForInteractionRegions):
# Add new layers for interaction regions.
# Maintain the same layer for regions that cover the same area.
# Add a green wash if the defaultWKInteractionRegionDebugFillis set.
#
# * WebKit.xcodeproj/project.pbxproj:
#
# 13 Simon Fraser <Simon Fraser>
#
# Simplify the usage of DrawGlyphsRecorder
# https://bugs.webkit.org/show_bug.cgi?id=240363
#
# Reviewed by Myles Maxfield.
#
# Move the DeconstructDrawGlyphs switch from inside DrawGlyphsRecorder to
# DisplayList::Recorder, so that DrawGlyphsRecorder is only ever used when deconstructing
# glyphs.
#
# Also, ensure that the only time that glyph deconstruction is enabled is when
# recording display lists via RemoteDisplayListRecorderProxy. There's no reason for
# paintAttachmentText() to need glyph deconstruction.
#
# This is a small perf improvement on the MotionMark Design subtest.
#
# * WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
# (WebKit::RemoteDisplayListRecorderProxy::RemoteDisplayListRecorderProxy):
# (WebKit::m_renderingBackend):
# * WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
#
# it takes from the XPC message is sent until the XPC reply is received. Add reporting when this happens
# On branch bz/240223
# Your branch is ahead of 'origin/main' by 1 commit.
# (use "git push" to publish your local commits)
#
# Changes to be committed:
# (use "git restore --staged <file>..." to unstage)
# modified: Source/WebKit/ChangeLog
#
# Untracked files:
# (use "git add <file>..." to include in what will be committed)
# 0001-SharedBuffer-should-be-copied-and-then-attributed-ba.patch
#
Canonical link: https://commits.webkit.org/250556@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:43 PM Changeset in webkit [294252] by
-
- 2 edits in branches/safari-7614.1.14.0-branch/Source/WebKit
Cherry-pick r294175. rdar://problem/91441895
[iOS] Multiple visible find highlights when searching for text after beginning a "find from selection"
https://bugs.webkit.org/show_bug.cgi?id=240393
rdar://91441895
Reviewed by Wenson Hsieh.
Some WebKit clients use SPI on WKWebView to support "find from selection"
functionality (the Cmd+E shortcut). However, to support general
find functionality, they use new find API that uses a different codepath
to draw highlights. Mixing use of the API and SPI can currently result
in two highlights showing up.
To fix, ensure SPI highlights are removed once the API is being used.
The long term solution is for clients to adopt API for the
"find from selection" functionality, but in the short term the SPI
should remain supported.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::clearAllDecoratedFoundText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:38 PM Changeset in webkit [294251] by
-
- 9 edits in branches/safari-7614.1.14.0-branch/Source
Versioning.
WebKit-7614.1.14.0.2
- 1:32 PM Changeset in webkit [294250] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
[PrettyPatch] Support commit messages (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=240386
<rdar://problem/93248835>
Unreviewed follow-up fix.
- Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb: Handle diffs without a header.
Canonical link: https://commits.webkit.org/250606@main
- 12:00 PM Changeset in webkit [294249] by
-
- 3 edits1 move in trunk
[css-ui] alias appearance <compat-auto> keywords to 'auto' for textfield
https://bugs.webkit.org/show_bug.cgi?id=238551
Reviewed by Tim Nguyen.
Source/WebCore:
This is to add support of aliasing appearance to 'auto' for textfield.
It has improved the following wpt tests
imported/w3c/web-platform-tests/css/css-ui/appearance-textfield-001.html
and
imported/w3c/web-platform-tests/css/css-ui/webkit-appearance-textfield-001.html.
The test failures though, are not fully fixed. The issue left is that the search cancel button
for input type="search" still present while it is expected to disappear (Bug 238751).
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustAppearanceForElement const):
LayoutTests:
Rename test name as the test result now matches the expected.
- fast/forms/color/color-input-uses-color-well-appearance-expected.html: Renamed from LayoutTests/fast/forms/color/color-input-uses-color-well-appearance-expected-mismatch.html.
- 11:54 AM Changeset in webkit [294248] by
-
- 2 edits1 add in trunk/Tools/buildstream
[Flatpak SDK] Update to pipewire master
https://bugs.webkit.org/show_bug.cgi?id=240428
Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-16
Reviewed by Adrian Perez de Castro.
The GStreamer pipewiresrc element from 0.3.36 has bugs that were fixed in the master branch.
- elements/freedesktop-sdk.bst:
- patches/fdo-0001-pipewire-base-Track-master-branch.patch: Added.
Canonical link: https://commits.webkit.org/250604@main
- 11:35 AM Changeset in webkit [294247] by
-
- 9 edits in branches/safari-7614.1.14.100-branch/Source
Versioning.
WebKit-7614.1.14.100.1
- 11:11 AM Changeset in webkit [294246] by
-
- 1 copy in branches/safari-7614.1.14.100-branch
New branch.
- 10:58 AM Changeset in webkit [294245] by
-
- 2 edits in trunk/Tools
[GTK][WPE] Make ANGLE backend EGL context initialization work
https://bugs.webkit.org/show_bug.cgi?id=240313
The platform is not selected correctly by default and the config
can not be chosen in some cases in the current conditions. Maybe
at some point we want something more general in the code for the
platform detection but for testing we have solved it adding the
environment variable (EGL_PLATORM) to make sure the platform
inside mesa is correctly selected when running the tests. If we
don't do it the small environment in the testing driver process
causes to chose the X11 because it is the building default
option. We used wayland because the headless driver we use is a
wayland backed implemented using shared memory.
Patch by Alejandro G. Castro <alex@igalia.com> on 2022-05-16
Reviewed by Žan Doberšek.
No new tests, it fixes the tests for the ANGLE implementation.
- Scripts/webkitpy/port/headlessdriver.py:
(HeadlessDriver._setup_environ_for_test):
- 10:57 AM Changeset in webkit [294244] by
-
- 2 edits in trunk/LayoutTests
[Gardening]: REGRESSION (r264117): [ Mac iOS ] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https.html
https://bugs.webkit.org/show_bug.cgi?id=214155
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250602@main
- 10:53 AM Changeset in webkit [294243] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r294104): [GStreamer][VideoCapture] Webcam raw streams may hang up the video capture pipeline
https://bugs.webkit.org/show_bug.cgi?id=240456
Patch by Loïc Le Page <llepage@igalia.com> on 2022-05-16
Reviewed by Philippe Normand.
When capturing a raw stream from a webcam, the pipeline may hang up because the decodebin3 cannot fix the upstream caps.
The webcam capsfilter should not only specify the captured mime-type (video/x-raw) but also the capture image dimensions.
Manually tested.
- platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
- 10:48 AM Changeset in webkit [294242] by
-
- 2 edits in trunk/Tools
(REGRESSION(r287957)[ Mac ] TestWebKitAPI.WebAuthenticationPanel.LAGetAssertionNoMockNoUserGesture is a constant timeout)
https://bugs.webkit.org/show_bug.cgi?id=240403
rdar://93271671
Reviewed by Brent Fulgham.
Whenever HAVE(UNIFIED_ASC_AUTH_UI), unmocked calls are passed to ASA, which does not
support calls from TWAPI.
- TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
- 10:43 AM Changeset in webkit [294241] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (250501@main): [ Mac ] 2 TestWebKitAPI.WebAuthenticationPanel.GetAssertionLA tests failing
https://bugs.webkit.org/show_bug.cgi?id=240406
rdar://93267082
Reviewed by Brent Fulgham.
Using the the truthiness of BOOL from attributes doesn't work here, instead compare it to @YES.
- UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticatorInternal::getExistingCredentials):
- 10:35 AM Changeset in webkit [294240] by
-
- 2 edits in trunk/Source/WebCore
[LFC][FFC] Add support for logical ordering
https://bugs.webkit.org/show_bug.cgi?id=240442
Reviewed by Antti Koivisto.
Let's reorder the logicalFlexItemList when the 'order' property has a non-initial value.
- layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- 10:30 AM Changeset in webkit [294239] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] imported/w3c/web-platform-tests/webrtc/RTCRtpSender-replaceTrack.https.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240463
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250597@main
- 9:49 AM Changeset in webkit [294238] by
-
- 8 edits in trunk
Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
https://bugs.webkit.org/show_bug.cgi?id=240362
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-16
Reviewed by Chris Dumez.
Source/WebCore/PAL:
- pal/spi/cf/CFNetworkSPI.h:
Source/WebKit:
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
- NetworkProcess/cocoa/NetworkSessionCocoa.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::initializeNSURLSessionsInSet):
(WebKit::SessionSet::initializeEphemeralStatelessSessionIfNeeded):
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
(WebKit::NetworkSessionCocoa::appBoundSession):
(WebKit::SessionSet::isolatedSession):
(WebKit::NetworkSessionCocoa::invalidateAndCancelSessionSet):
- 9:33 AM Changeset in webkit [294237] by
-
- 2 edits in trunk/Source/WebCore
[LFC][FFC] Add "flex-direction: column-reverse" basic visual/logical conversion
https://bugs.webkit.org/show_bug.cgi?id=240434
Reviewed by Antti Koivisto.
With "flex-direction: column-reverse" the main axis progression is from visual bottom to top (with default writing mode and all that).
- layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- 9:18 AM Changeset in webkit [294236] by
-
- 2 edits in trunk/LayoutTests
[Gardening]:[ iOS ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-videoDetectorTest.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240348
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250594@main
- 9:12 AM Changeset in webkit [294235] by
-
- 1 edit in trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm
Canvas generated transparent pixels are not well handled by LocalSampleBufferDisplayLayer
https://bugs.webkit.org/show_bug.cgi?id=230621
rdar://problem/83668394
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-16
Reviewed by Eric Carlson.
Remove black color for root and display layer.
When display layer is hidden but root layer is visible, set root layer background color to black to keep existing behavior.
This allows to render transparent video frames without a black background.
Covered by https://jsfiddle.net/nfu7oL60/ (make sure to switch between tabs after clicking start).
Also covered by https://webrtc.github.io/samples/src/content/peerconnection/pc1/ and muting/unmuting the camera.
- Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
(WebCore::LocalSampleBufferDisplayLayer::initialize):
(WebCore::LocalSampleBufferDisplayLayer::updateDisplayMode):
Canonical link: https://commits.webkit.org/250593@main
- 8:52 AM Changeset in webkit [294234] by
-
- 8 edits in trunk
Web Inspector: Regression(r266885) Crash sometimes when rehydrating imported audit results
https://bugs.webkit.org/show_bug.cgi?id=240366
Reviewed by Devin Rousso.
Source/JavaScriptCore:
- inspector/protocol/DOM.json:
Source/WebCore:
Added test cases to inspector/model/dom-node.html
After r266885, there is no path to handle the possibility that there may not be a resulting node for calls to
DOM.querySelector. To correct this, mark the return value as optional (Web Inspector frontend already treats
it as optional) and return early if there was no Element matching the selector.
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::querySelector):
- inspector/agents/InspectorDOMAgent.h:
LayoutTests:
- inspector/model/dom-node.html:
- inspector/model/dom-node-expected.txt:
- 8:08 AM Changeset in webkit [294233] by
-
- 2 edits in trunk/Source/WebCore
[LFC][FFC] Add "flex-direction: row-reverse" basic visual/logical conversion
https://bugs.webkit.org/show_bug.cgi?id=240432
Reviewed by Antti Koivisto.
With "flex-direction: row-reverse" the main axis progression is from visual right to left (with default writing mode and all that).
- layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- 6:55 AM Changeset in webkit [294232] by
-
- 2 edits in trunk/Source/WebKit
[GTK] Warning in WebKitDOMDocumentGtk.cpp with GCC 12
https://bugs.webkit.org/show_bug.cgi?id=239353
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-05-16
Reviewed by Yusuke Suzuki.
- Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:
(webkit_dom_document_create_node_iterator):
(webkit_dom_document_create_tree_walker):
Canonical link: https://commits.webkit.org/250590@main
- 6:16 AM Changeset in webkit [294231] by
-
- 2 edits in trunk/Source/WebCore
[LFC][FFC] Add "flex-direction: column" basic visual/logical conversion
https://bugs.webkit.org/show_bug.cgi?id=240430
Reviewed by Antti Koivisto.
With "flex-direction: column" the main axis progression is based on the margin box height.
- layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- 5:54 AM Changeset in webkit [294230] by
-
- 1 edit in trunk/Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm
Rename MockAudioSharedInternalUnit::m_isProducingState to MockAudioSharedInternalUnit::m_internalState
https://bugs.webkit.org/show_bug.cgi?id=240450
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-16
Reviewed by Eric Carlson.
Follow-up to https://bugs.webkit.org/show_bug.cgi?id=240421 review.
No change of behavior.
- Source/WebCore/platform/mediastream/mac/MockAudioSharedUnit.mm:
(WebCore::MockAudioSharedInternalUnit::MockAudioSharedInternalUnit):
(WebCore::MockAudioSharedInternalUnit::~MockAudioSharedInternalUnit):
(WebCore::MockAudioSharedInternalUnit::start):
(WebCore::MockAudioSharedInternalUnit::stop):
(WebCore::MockAudioSharedInternalUnit::uninitialize):
(WebCore::MockAudioSharedInternalUnit::generateSampleBuffers):
Canonical link: https://commits.webkit.org/250588@main
- 5:48 AM Changeset in webkit [294229] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION(r294104): [GStreamer] getUserMedia broken
https://bugs.webkit.org/show_bug.cgi?id=240420
Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-16
Reviewed by Xabier Rodriguez-Calvar.
The converter handling logic was modified in order to fix getUserMedia negotiated with raw
video and also getDisplayMedia which is always raw video and thus doesn't require decoding.
This patch also introduces a small optimization, reconfiguration is now done once only,
after setting size and framerate. Before this patch it was done twice, so the pipeline was a
taking more time to produce the first frame.
- platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
(WebCore::GStreamerVideoCaptureSource::~GStreamerVideoCaptureSource):
(WebCore::GStreamerVideoCaptureSource::settingsDidChange): Trigger capturer reconfiguration after setting both size and framerate.
(WebCore::GStreamerVideoCaptureSource::startProducingData): Ditto.
- platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::createConverter): Do not decode display capture streams, these are always raw anyway.
(WebCore::GStreamerVideoCapturer::setSize): Delay reconfiguration.
(WebCore::GStreamerVideoCapturer::setFrameRate): Ditto.
(WebCore::GStreamerVideoCapturer::reconfigure): Keep track of compatible video format. This
is needed to workaround an issue in pipewiresrc caps negotiation.
(WebCore::GStreamerVideoCapturer::adjustVideoSrcMIMEType): Renamed to reconfigure().
- platform/mediastream/gstreamer/GStreamerVideoCapturer.h:
Canonical link: https://commits.webkit.org/250587@main
- 5:23 AM Changeset in webkit [294228] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Add basic video meta handling in sinks
https://bugs.webkit.org/show_bug.cgi?id=240429
Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-16
Reviewed by Xabier Rodriguez-Calvar.
By handling allocation queries and advertising video meta handling to upstream elements, our
video sinks are now more efficient, especially on Raspberry Pi 4 with the v4l2 stateless
H.264 decoder.
- platform/graphics/gstreamer/GStreamerVideoSinkCommon.cpp:
(webKitVideoSinkSetMediaPlayerPrivate):
Canonical link: https://commits.webkit.org/250586@main
- 4:43 AM Changeset in webkit [294227] by
-
- 1 edit8 deletes in trunk/LayoutTests
Remove some custom-element tests
https://bugs.webkit.org/show_bug.cgi?id=240449
Patch by Rob Buis <rbuis@igalia.com> on 2022-05-16
Reviewed by Tim Nguyen.
Remove some custom-element tests since they are now available in WPT.
- fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback-expected.txt: Removed.
- fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback.html: Removed.
- fast/custom-elements/perform-microtask-checkpoint-before-construction-expected.txt: Removed.
- fast/custom-elements/perform-microtask-checkpoint-before-construction.html: Removed.
- fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct-expected.txt: Removed.
- fast/custom-elements/throw-on-dynamic-markup-insertion-counter-construct.html: Removed.
- fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions-expected.txt: Removed.
- fast/custom-elements/throw-on-dynamic-markup-insertion-counter-reactions.html: Removed.
- 3:27 AM Changeset in webkit [294226] by
-
- 8 edits11 deletes in trunk
[css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal
https://bugs.webkit.org/show_bug.cgi?id=240448
Reviewed by Antti Koivisto.
Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
iOS baseline for appearance-cssom-001-expected.txt is identical to the main one, so remove it.
LayoutTests:
- fast/forms/range/thumbslider-crash-expected.txt: Removed.
- fast/forms/range/thumbslider-crash.html: Removed.
- fast/forms/range/thumbslider-no-parent-slider.html: Removed.
- platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed.
- platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Removed.
- platform/ios/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
- platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.png: Removed.
- platform/mac/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
- platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
- platform/wincairo/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
- imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
Source/WebCore:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- platform/ThemeTypes.h:
Canonical link: https://commits.webkit.org/250584@main
- 1:18 AM Changeset in webkit [294225] by
-
- 31 edits in trunk
Make sure calling showNotification will extend the service worker lifetime
https://bugs.webkit.org/show_bug.cgi?id=240273
<rdar://92978482>
Reviewed by Chris Dumez.
Source/WebCore:
Update NotificationClient API so that show is taking a completion handler.
Make use of this completion handler to resolve the promise when the show notification steps are done, as per spec.
Register push event to ServiceWorkerGlobalScope when the event handlers are called.
When ServiceWorkerRegistration::show is called during one of the push event handlers,
extend the push event lifetime by adding the show notification promise to the push event.
Covered by API test.
- Modules/notifications/Notification.cpp:
- Modules/notifications/Notification.h:
- Modules/notifications/NotificationClient.h:
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h:
- workers/service/ServiceWorkerGlobalScope.cpp:
- workers/service/ServiceWorkerGlobalScope.h:
- workers/service/ServiceWorkerRegistration.cpp:
- workers/service/ServiceWorkerRegistration.h:
- workers/service/context/ServiceWorkerThread.cpp:
Source/WebKit:
On WebProcess side, implement the new NoficationClient::show API that takes a callback.
Delay calling this callback until UIProcess tells us so through async IPC.
On UIProcess side, take a callback and call it when the show notification steps are done.
- NetworkProcess/Notifications/NetworkNotificationManager.cpp:
- NetworkProcess/Notifications/NetworkNotificationManager.h:
- Shared/Notifications/NotificationManagerMessageHandler.h:
- Shared/Notifications/NotificationManagerMessageHandler.messages.in:
- UIProcess/Notifications/ServiceWorkerNotificationHandler.cpp:
- UIProcess/Notifications/ServiceWorkerNotificationHandler.h:
- UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp:
- UIProcess/Notifications/WebNotificationManagerMessageHandler.h:
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
- WebProcess/Notifications/WebNotificationManager.cpp:
- WebProcess/Notifications/WebNotificationManager.h:
- WebProcess/WebCoreSupport/WebNotificationClient.cpp:
- WebProcess/WebCoreSupport/WebNotificationClient.h:
Source/WebKitLegacy/mac:
- WebCoreSupport/WebNotificationClient.h:
- WebCoreSupport/WebNotificationClient.mm:
Tools:
- TestWebKitAPI/TestNotificationProvider.cpp:
- TestWebKitAPI/TestNotificationProvider.h:
- TestWebKitAPI/Tests/WebKitCocoa/PushAPI.mm:
- 1:14 AM Changeset in webkit [294224] by
-
- 17 edits in trunk
Do not allow unitless values for CSS unprefixed perspective property
https://bugs.webkit.org/show_bug.cgi?id=104805
<rdar://problem/77016090>
Reviewed by Tim Nguyen.
LayoutTests/imported/w3c:
- web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt:
Source/WebCore:
No new tests. This is tested by an existing WPT test:
web-platform-tests/quirks/unitless-length/excluded-properties-001.html
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- css/CSSProperties.json:
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumePerspective):
(WebCore::CSSPropertyParser::consumePrefixedPerspective):
(WebCore::CSSPropertyParser::parseShorthand):
- css/parser/CSSPropertyParser.h:
- rendering/style/WillChangeData.cpp:
(WebCore::WillChangeData::propertyCreatesStackingContext):
LayoutTests:
- platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- 12:26 AM Changeset in webkit [294223] by
-
- 2 edits in trunk/Source/WebCore
MockAudioSharedInternalUnit should exit early when being stopped in generateSampleBuffers
https://bugs.webkit.org/show_bug.cgi?id=240421
<rdar://93279260>
Reviewed by Eric Carlson.
We used to always call generateSampleBuffers from main thread.
We are now calling it from background thread with dispatchAfter to mimick a realtime clock.
This broke the dispatchSync call we were calling when stopping the mock unit as the dispatchAfter task would be called
after the dispatchSync and |this| could potentially no longer be valid.
To prevent this, we introduce MockAudioSharedInternalUnitState which allows to safely know whether the unit is stopped or not
at any point in time. If the unit is stopped, dispatchAfter will not call generateSampleBuffers.
Covered by existing tests.
- platform/mediastream/mac/MockAudioSharedUnit.mm:
(WebCore::MockAudioSharedInternalUnitState::create):
(WebCore::MockAudioSharedInternalUnitState::isProducingData const):
(WebCore::MockAudioSharedInternalUnitState::setIsProducingData):
(WebCore::MockAudioSharedInternalUnit::MockAudioSharedInternalUnit):
(WebCore::MockAudioSharedInternalUnit::~MockAudioSharedInternalUnit):
(WebCore::MockAudioSharedInternalUnit::start):
(WebCore::MockAudioSharedInternalUnit::stop):
(WebCore::MockAudioSharedInternalUnit::uninitialize):
(WebCore::MockAudioSharedInternalUnit::generateSampleBuffers):
- 12:14 AM Changeset in webkit [294222] by
-
- 2 edits in trunk/Source/WebKit
Add logging when taking a process assertion synchronously
https://bugs.webkit.org/show_bug.cgi?id=240334
Reviewed by Chris Dumez.
No observable change of behavior.
- UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::ProcessAssertion::acquireSync):
May 15, 2022:
- 11:37 PM Changeset in webkit [294221] by
-
- 4 edits in trunk/Source/WebCore
Audio playback rate sped up for few seconds when using createMediaElementSource
https://bugs.webkit.org/show_bug.cgi?id=239696
<rdar://problem/92569332>
Reviewed by Eric Carlson.
We added a way for AudioSampleDataSource to reduce latency due to its audio buffer by reading the audio buffer faster
until the audio buffer size decreases to a reasonnable value.
The reasonnable buffer size was computed in terms of multiple of 10ms as RTC sources are pushing 10 or 20 millisecond chunks.
Other sources may push much bigger chunks (100 milliseconds for instance), in which case it does not make real sense to try to reduce the delay below it.
To prevent this, we will decrease the buffer size if it is above 100 milliseconds (as previously) AND the buffer size is 4 times the size of the pushed audio chunk.
4 times the size of the pushed audio chunk is 40 ms for RTC sources which is a reasonnable buffer size.
Manually tested with https://webaudioapi.com/samples/audio-tag/.
- platform/audio/cocoa/AudioSampleDataConverter.h:
- platform/audio/cocoa/AudioSampleDataConverter.mm:
(WebCore::AudioSampleDataConverter::updateBufferedAmount):
- platform/audio/cocoa/AudioSampleDataSource.mm:
(WebCore::AudioSampleDataSource::pushSamplesInternal):
- 7:32 PM Changeset in webkit [294220] by
-
- 2 edits in trunk/Source/bmalloc
Unreviewed, revert r294214 partially
https://bugs.webkit.org/show_bug.cgi?id=240292
These part is not cold code. We must not use PAS_ASSERT_WITH_DETAIL.
- libpas/src/libpas/pas_local_allocator_config_kind.h:
(pas_local_allocator_config_kind_create_normal):
(pas_local_allocator_config_kind_create_primordial_partial):
(pas_local_allocator_config_kind_create_bitfit):
(pas_local_allocator_config_kind_get_segregated_page_config_kind):
(pas_local_allocator_config_kind_get_bitfit_page_config_kind):
(pas_local_allocator_config_kind_get_string):
- 6:44 PM Changeset in webkit [294219] by
-
- 3 edits in trunk/LayoutTests
[WinCairo] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=240439
- platform/wincairo-wk1/TestExpectations:
- platform/wincairo/TestExpectations:
Canonical link: https://commits.webkit.org/250577@main
- 4:21 PM Changeset in webkit [294218] by
-
- 8 edits in trunk
Right click > "Open Link" should trigger a navigation action with WKNavigationTypeLinkActivated
https://bugs.webkit.org/show_bug.cgi?id=240427
rdar://90400867
Reviewed by Tim Horton.
Add a new linked-on-or-after check to guard this new behavior for apps built against newer SDK versions.
- wtf/cocoa/RuntimeApplicationChecksCocoa.h:
Right click > "Open Link" should trigger a navigation action with WKNavigationTypeLinkActivated
https://bugs.webkit.org/show_bug.cgi?id=240427
rdar://90400867
Reviewed by Tim Horton.
Make a couple of minor adjustments to
ContextMenuControllerto ensure that right clicking a link and choosing
"Open Link" or "Open Link in New Window" surfaces a navigation action withWKNavigationTypeLinkActivated,
rather thanWKNavigationTypeOther.
Test: ContextMenuTests.NavigationTypeWhenOpeningLink
- page/ContextMenuContext.cpp:
(WebCore::ContextMenuContext::ContextMenuContext):
- page/ContextMenuContext.h:
(WebCore::ContextMenuContext::event const):
Save a reference to the
Eventof type "contextmenu" that's triggering context menu presentation in the
ContextMenuContext.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::maybeCreateContextMenu):
(WebCore::openNewWindow):
Plumb the
"contextmenu"event through toFrameLoader::loadFrameRequestwhen opening links via context menu.
(WebCore::ContextMenuController::contextMenuItemSelected):
Right click > "Open Link" should trigger a navigation action with WKNavigationTypeLinkActivated
https://bugs.webkit.org/show_bug.cgi?id=240427
rdar://90400867
Reviewed by Tim Horton.
Add an API test to verify that right clicking a link and selecting "Open Link" triggers a navigation action with
the typeWKNavigationTypeLinkActivated.
- TestWebKitAPI/Tests/mac/ContextMenuTests.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/250576@main
- 9:53 AM Changeset in webkit [294217] by
-
- 3 edits1 add in trunk/Source/WebCore
[LFC][FFC] Introduce logical direction based flex layout
https://bugs.webkit.org/show_bug.cgi?id=240424
Reviewed by Antti Koivisto.
This is in preparation for ensuring that core flex layout only needs to deal with
one direction for flex content progression (row vs. column vs. reversed etc).
- WebCore.xcodeproj/project.pbxproj:
- layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForFlexLayout):
- 8:49 AM Changeset in webkit [294216] by
-
- 2 edits in trunk/JSTests
Skip flaky test on ARM
https://bugs.webkit.org/show_bug.cgi?id=240426
Unreviewed gardening.
- stress/verify-can-gc-node-index.js:
- 6:30 AM Changeset in webkit [294215] by
-
- 9 edits in trunk/Source/WebCore
WebCore::IOSurface has WebCore::GraphicsContext as its property, it should be the other way around
https://bugs.webkit.org/show_bug.cgi?id=240417
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-15
Reviewed by Simon Fraser.
Do not store WebCore::GraphicsContext in WebCore::IOSurface.
E.g. graphics context is not the property of the bitmap that
is being drawn to. The backing bitmap is a property of the context.
Instead, store the GraphicsContextCG at the place where the user is,
e.g. in ImageBufferIOSurfaceBackend. This allows the context client
to create the context with the options the client needs.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContextCG::GraphicsContextCG):
(WebCore::GraphicsContextCG::drawNativeImage):
- platform/graphics/cg/GraphicsContextCG.h:
- platform/graphics/cg/IOSurfacePool.cpp:
(WebCore::IOSurfacePool::willAddSurface):
- platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::~ImageBufferIOSurfaceBackend):
(WebCore::ImageBufferIOSurfaceBackend::context const):
(WebCore::ImageBufferIOSurfaceBackend::releaseGraphicsContext):
- platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
- platform/graphics/cocoa/IOSurface.h:
- platform/graphics/cocoa/IOSurface.mm:
(WebCore::IOSurface::create):
(WebCore::IOSurface::releasePlatformGraphicsContext):
(WebCore::IOSurface::ensureGraphicsContext): Deleted.
(WebCore::IOSurface::releaseGraphicsContext): Deleted.
May 14, 2022:
- 7:08 PM Changeset in webkit [294214] by
-
- 6 edits in trunk/Source/bmalloc
[LIBPAS] Add extra assert information to malloc enumeration API
https://bugs.webkit.org/show_bug.cgi?id=240292
Reviewed by Yusuke Suzuki.
In the heap enumerator (which is a slow path), we have asserts that
have the opportunity to include extra information to aid debugging.
We add PAS_ASSERT_WITH_DETAIL, which stuffs extra data into registers before crashing
so that we can see it in crash logs. We also add a debugging option to allow logging
to syslog, for cases when we do not have access to stdout.
- libpas/src/libpas/pas_enumerate_segregated_heaps.c:
(consider_allocator):
- libpas/src/libpas/pas_local_allocator_config_kind.h:
(pas_local_allocator_config_kind_create_normal):
(pas_local_allocator_config_kind_create_primordial_partial):
(pas_local_allocator_config_kind_create_bitfit):
(pas_local_allocator_config_kind_get_segregated_page_config_kind):
(pas_local_allocator_config_kind_get_bitfit_page_config_kind):
(pas_local_allocator_config_kind_get_string):
- libpas/src/libpas/pas_log.c:
(pas_vlog):
- libpas/src/libpas/pas_utils.c:
(pas_crash_with_info_impl):
(pas_panic):
(pas_assertion_failed_no_inline):
(pas_assertion_failed_no_inline_with_extra_detail):
- libpas/src/libpas/pas_utils.h:
- 5:47 PM Changeset in webkit [294213] by
-
- 9 edits in trunk/Source
Put ThreadGlobalData in Thread
https://bugs.webkit.org/show_bug.cgi?id=240116
Reviewed by Darin Adler and Mark Lam.
This patch puts ThreadGlobalData into Thread's m_clientData field.
Thread is stored in fast TLS, so accessing to this field is quite fast
compared to the current ThreadSpecific one.
At the same time, this change can remove a hack in ThreadGlobalData.
Previously worker thread needs to tear down ThreadGlobalData explicitly
because Thread::current() can be destroyed earlier than ThreadGlobalData.
In that case, EventNames etc., which accesses to AtomString's destruction
can have problem because of lack of Thread::current() access. But since
we now move it to Thread, we can control how it is destroyed with Thread::current()
precisely, and we can explicitly destroy it before Thread::current() is fully
cleared. So we do not need to call it explicitly anymore.
Currently, we are calling it just to make ThreadGlobalData destroyed for debugging.
- Source/WebCore/PAL/pal/ThreadGlobalData.cpp:
(PAL::ThreadGlobalData::ThreadGlobalData):
(PAL::ThreadGlobalData::destroy): Deleted.
- Source/WebCore/PAL/pal/ThreadGlobalData.h:
(PAL::ThreadGlobalData::ThreadGlobalData::cachedConverterICU): Deleted.
- Source/WTF/wtf/Threading.h:
(WTF::Thread::Thread):
- Source/WTF/wtf/posix/ThreadingPOSIX.cpp:
(WTF::Thread::destructTLS):
- Source/WTF/wtf/win/ThreadingWin.cpp:
(WTF::Thread::ThreadHolder::~ThreadHolder):
- Source/WebCore/platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::destroy):
(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):
Canonical link: https://commits.webkit.org/250571@main
- 5:45 PM Changeset in webkit [294212] by
-
- 7 edits in trunk/Tools
[webkit-patch] Include commit messages in patches (Follow-up #2)
https://bugs.webkit.org/show_bug.cgi?id=240256
<rdar://problem/92982358>
Unreviewed follow-up fix.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.create_patch): Allow caller to exclude commit message, run
git diffagainst HEAD by
default to include both staged and unstaged changes.
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.create_patch): Match function signature for git.
- Scripts/webkitpy/common/checkout/scm/scm_mock.py:
(MockSCM.create_patch): Match function signature for git.
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.create_patch): Match function signature for git.
- Scripts/webkitpy/w3c/test_exporter.py:
(WebPlatformTestExporter._wpt_patch): Exclude commit message since we won't be able
to classify it's file.
- Scripts/webkitpy/w3c/test_exporter_unittest.py:
(TestExporterTest.MockGit.create_patch): Match function signature for git.
- 3:39 PM Changeset in webkit [294211] by
-
- 3 edits2 adds in trunk
Changing text color and removing line-clamp on hover causes text to disappear permanently
https://bugs.webkit.org/show_bug.cgi?id=240410
Reviewed by Simon Fraser.
Source/WebCore:
Invalidate the flex items' line layout path when line-clamp property value changes.
While the line clamp property is set on the flex box, it is "forced on" the flex items' inline content.
(i.e. the property is not inherited, it is propagated to the flex children)
It means dynamic value change only runs on the flex box renderer.
Test: fast/block/dynamic-line-clamp-empty-content.html
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::styleWillChange):
LayoutTests:
- fast/block/dynamic-line-clamp-empty-content-expected.html: Added.
- fast/block/dynamic-line-clamp-empty-content.html: Added.
- 2:35 PM Changeset in webkit [294210] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed win build fix.
- layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::flexBoxLogicalBorder):
(WebCore::LayoutIntegration::flexBoxLogicalPadding):
(WebCore::LayoutIntegration::FlexLayout::updateFormattingRootGeometryAndInvalidate):
(WebCore::LayoutIntegration::logicalBorder): Deleted.
(WebCore::LayoutIntegration::logicalPadding): Deleted.
- 1:08 PM Changeset in webkit [294209] by
-
- 14 edits in trunk/Source
Rename EventTrackingRegions::Event to EventTrackingRegions::EventType
https://bugs.webkit.org/show_bug.cgi?id=240295
Reviewed by Darin Adler.
This patch is follow-up after r293967 by Darin's comment. EventTrackingRegions::Event is not event actually,
it is just an EventType. This patch renames it with EventType. We also rename variables "event" to "eventType".
- Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<EventTrackingRegions>::decode):
- Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::eventTrackingTypeForPoint const):
- Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateTouchEventTracking):
- Source/WebCore/page/DebugPageOverlays.cpp:
(WebCore::NonFastScrollableRegionOverlay::drawRect):
- Source/WebCore/page/Page.cpp:
(WebCore::Page::touchEventRectsForEventForTesting):
- Source/WebCore/page/Page.h:
- Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame const):
- Source/WebCore/page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::computeWheelProcessingSteps):
(WebCore::ScrollingTree::eventTrackingTypeForPoint):
- Source/WebCore/page/scrolling/ScrollingTree.h:
- Source/WebCore/platform/EventTrackingRegions.cpp:
(WebCore::EventTrackingRegions::eventName):
(WebCore::EventTrackingRegions::eventNameAtomString): We add this function to have a way to get AtomString event name. It simplifies Internal code.
(WebCore::EventTrackingRegions::trackingTypeForPoint):
(WebCore::EventTrackingRegions::uniteSynchronousRegion):
- Source/WebCore/platform/EventTrackingRegions.h:
- Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::touchEventRectsForEvent):
Canonical link: https://commits.webkit.org/250567@main
- 12:15 PM Changeset in webkit [294208] by
-
- 10 edits in trunk
AX: Remove CSSDisplayContentsAXSupportEnabled flag
https://bugs.webkit.org/show_bug.cgi?id=240409
Reviewed by Chris Fleizach.
Source/WebCore:
We added initial support without using this flag and will continue to
fix bugs as we find them, making this flag unnecessary.
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setCSSDisplayContentsAXSupportEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssDisplayContentsAXSupportEnabled const): Deleted.
Source/WebKitLegacy/mac:
We added initial support without using this flag and will continue to
fix bugs as we find them, making this flag unnecessary.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences cssDisplayContentsAXSupportEnabled]): Deleted.
(-[WebPreferences setCSSDisplayContentsAXSupportEnabled:]): Deleted.
- WebView/WebPreferencesPrivate.h:
Source/WTF:
- Scripts/Preferences/WebPreferencesInternal.yaml:
Tools:
- DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):
- 11:04 AM Changeset in webkit [294207] by
-
- 1 copy in tags/WebKit-7614.1.14.1.1
Tag WebKit-7614.1.14.1.1.
- 11:02 AM Changeset in webkit [294206] by
-
- 1 copy in tags/WebKit-7614.1.14.0.1
Tag WebKit-7614.1.14.0.1.
- 10:58 AM Changeset in webkit [294205] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.1
- 10:51 AM Changeset in webkit [294204] by
-
- 13 edits in trunk/Source/WebCore
Template TextBoxPainter on line layout path
https://bugs.webkit.org/show_bug.cgi?id=240416
Reviewed by Alan Bujtas.
Painting currently goes via a line layout path agnostic iterator.
This is inefficient since we always know what sort of layout we are painting.
- layout/integration/inline/InlineIteratorBox.cpp:
(WebCore::InlineIterator::Box::visualRect const):
- layout/integration/inline/InlineIteratorBox.h:
(WebCore::InlineIterator::Box::containingBlock const):
(WebCore::InlineIterator::Box::visualRect const): Deleted.
- layout/integration/inline/InlineIteratorBoxLegacyPath.h:
(WebCore::InlineIterator::BoxLegacyPath::containingBlock const):
(WebCore::InlineIterator::BoxLegacyPath::direction const):
(WebCore::InlineIterator::BoxLegacyPath::isFirstLine const):
- layout/integration/inline/InlineIteratorBoxModernPath.h:
(WebCore::InlineIterator::BoxModernPath::containingBlock const):
(WebCore::InlineIterator::BoxModernPath::direction const):
(WebCore::InlineIterator::BoxModernPath::isFirstLine const):
(WebCore::InlineIterator::BoxModernPath::renderText const):
- layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::paint):
- rendering/InlineBoxPainter.cpp:
(WebCore::InlineBoxPainter::paintMask):
(WebCore::InlineBoxPainter::paintDecorations):
- rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::addTextBoxVisualOverflow):
- rendering/LegacyInlineTextBox.cpp:
(WebCore::LegacyInlineTextBox::paint):
- rendering/LegacyInlineTextBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
- rendering/TextBoxPainter.cpp:
(WebCore::LegacyTextBoxPainter::LegacyTextBoxPainter):
(WebCore::ModernTextBoxPainter::ModernTextBoxPainter):
(WebCore::TextBoxPainter<TextBoxPath>::TextBoxPainter):
(WebCore::TextBoxPainter<TextBoxPath>::~TextBoxPainter):
(WebCore::TextBoxPainter<TextBoxPath>::makeIterator const):
(WebCore::TextBoxPainter<TextBoxPath>::paint):
(WebCore::TextBoxPainter<TextBoxPath>::createMarkedTextFromSelectionInBox):
(WebCore::TextBoxPainter<TextBoxPath>::paintBackground):
(WebCore::TextBoxPainter<TextBoxPath>::paintForegroundAndDecorations):
(WebCore::TextBoxPainter<TextBoxPath>::paintCompositionBackground):
(WebCore::TextBoxPainter<TextBoxPath>::paintForeground):
(WebCore::TextBoxPainter<TextBoxPath>::createDecorationPainter):
(WebCore::TextBoxPainter<TextBoxPath>::paintBackgroundDecorations):
(WebCore::TextBoxPainter<TextBoxPath>::paintForegroundDecorations):
(WebCore::TextBoxPainter<TextBoxPath>::paintCompositionUnderlines):
(WebCore::TextBoxPainter<TextBoxPath>::textPosition):
(WebCore::TextBoxPainter<TextBoxPath>::paintCompositionUnderline):
(WebCore::TextBoxPainter<TextBoxPath>::paintPlatformDocumentMarkers):
(WebCore::LegacyTextBoxPainter::calculateUnionOfAllDocumentMarkerBounds):
(WebCore::TextBoxPainter<TextBoxPath>::paintPlatformDocumentMarker):
(WebCore::TextBoxPainter<TextBoxPath>::computePaintRect):
(WebCore::calculateDocumentMarkerBounds):
(WebCore::TextBoxPainter<TextBoxPath>::computeHaveSelection const):
(WebCore::TextBoxPainter<TextBoxPath>::fontCascade const):
(WebCore::TextBoxPainter<TextBoxPath>::textOriginFromPaintRect const):
(WebCore::TextBoxPainter<TextBoxPath>::debugTextShadow const):
(WebCore::TextBoxPainter::TextBoxPainter): Deleted.
(WebCore::TextBoxPainter::~TextBoxPainter): Deleted.
(WebCore::TextBoxPainter::paint): Deleted.
(WebCore::TextBoxPainter::createMarkedTextFromSelectionInBox): Deleted.
(WebCore::TextBoxPainter::paintBackground): Deleted.
(WebCore::TextBoxPainter::paintForegroundAndDecorations): Deleted.
(WebCore::TextBoxPainter::paintCompositionBackground): Deleted.
(WebCore::TextBoxPainter::paintForeground): Deleted.
(WebCore::TextBoxPainter::createDecorationPainter): Deleted.
(WebCore::TextBoxPainter::paintBackgroundDecorations): Deleted.
(WebCore::TextBoxPainter::paintForegroundDecorations): Deleted.
(WebCore::TextBoxPainter::paintCompositionUnderlines): Deleted.
(WebCore::textPosition): Deleted.
(WebCore::TextBoxPainter::paintCompositionUnderline): Deleted.
(WebCore::TextBoxPainter::paintPlatformDocumentMarkers): Deleted.
(WebCore::TextBoxPainter::calculateUnionOfAllDocumentMarkerBounds): Deleted.
(WebCore::TextBoxPainter::paintPlatformDocumentMarker): Deleted.
(WebCore::TextBoxPainter::computePaintRect): Deleted.
(WebCore::TextBoxPainter::calculateDocumentMarkerBounds): Deleted.
(WebCore::TextBoxPainter::computeHaveSelection const): Deleted.
(WebCore::TextBoxPainter::fontCascade const): Deleted.
(WebCore::TextBoxPainter::textOriginFromPaintRect const): Deleted.
(WebCore::TextBoxPainter::debugTextShadow const): Deleted.
- rendering/TextBoxPainter.h:
(WebCore::TextBoxPainter::textBox const):
- 10:40 AM Changeset in webkit [294203] by
-
- 9 edits in branches/safari-7614.1.14.0-branch/Source
Versioning.
WebKit-7614.1.14.0.1
- 10:25 AM Changeset in webkit [294202] by
-
- 1 copy in branches/safari-7614.1.14.3-branch
New branch.
- 10:25 AM Changeset in webkit [294201] by
-
- 1 copy in branches/safari-7614.1.14.2-branch
New branch.
- 10:25 AM Changeset in webkit [294200] by
-
- 1 copy in branches/safari-7614.1.14.1-branch
New branch.
- 10:25 AM Changeset in webkit [294199] by
-
- 1 copy in branches/safari-7614.1.14.0-branch
New branch.
- 9:56 AM Changeset in webkit [294198] by
-
- 2 edits in trunk/Source/WebCore
[FFC][Integration] Add "fixed sized/all default value" flex layout
https://bugs.webkit.org/show_bug.cgi?id=240414
Reviewed by Antti Koivisto.
This patch adds support for the simplest possible flex layout (fixed size, no-wrap, no-reversed etc).
- layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- 9:26 AM Changeset in webkit [294197] by
-
- 6 edits in trunk/Source
WebCore::IOSurface refers to unused context size
https://bugs.webkit.org/show_bug.cgi?id=240385
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-14
Reviewed by Simon Fraser.
Source/WebCore:
Remove unused IOSurface::m_contextSize.
Context related code makes IOSurface error-prone wrt
reusing the IOSurface in the pool.
- platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::create):
- platform/graphics/cocoa/IOSurface.h:
- platform/graphics/cocoa/IOSurface.mm:
(WebCore::IOSurface::create):
(WebCore::IOSurface::IOSurface):
(WebCore::IOSurface::ensurePlatformContext):
Source/WebKit:
Adjust after removing the IOSurface context size parameter.
All call sites passed the surface size.
- WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp:
(WebKit::ImageBufferShareableMappedIOSurfaceBackend::create):
- 8:59 AM Changeset in webkit [294196] by
-
- 12 edits in trunk/Source/WebCore
Use an OptionSet<> for DisplayList::AsTextFlags
https://bugs.webkit.org/show_bug.cgi?id=240415
Reviewed by Alan Bujtas.
Simple adoption of OptionSet<DisplayList::AsTextFlag> in place of DisplayList::AsTextFlags.
- html/HTMLCanvasElement.h:
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::displayListAsText const):
(WebCore::GraphicsLayer::replayDisplayListAsText const):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::displayListAsText const):
(WebCore::GraphicsLayerCA::replayDisplayListAsText const):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::shouldDumpForFlags):
(WebCore::DisplayList::DisplayList::asText const):
- platform/graphics/displaylists/DisplayList.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::displayListAsText const):
(WebCore::RenderLayerBacking::replayDisplayListAsText const):
- rendering/RenderLayerBacking.h:
- rendering/TextPainter.cpp:
(WebCore::TextPainter::cachedGlyphDisplayListsForTextNodeAsText):
- rendering/TextPainter.h:
- testing/Internals.cpp:
(WebCore::Internals::displayListForElement):
(WebCore::Internals::replayDisplayListForElement):
(WebCore::Internals::cachedGlyphDisplayListsForTextNode):
- 8:24 AM Changeset in webkit [294195] by
-
- 13 edits4 adds in trunk
[Repaint] Border ignores currentColor change when hovering
https://bugs.webkit.org/show_bug.cgi?id=240401
Reviewed by Antti Koivisto.
Source/WebCore:
This patch triggers repaint when currentColor is applied on border.
It most likely got broken at r150259 (9 years ago!) when StyleDifferenceRepaintIfText was introduced.
StyleDifferenceRepaintIfText is a "conditional repaint" diff value which only triggers repaint if the renderer has some text content.
Later, r156619 addressed some of the "content with border/outline is not painting" fallout by extending
StyleDifferenceRepaintIfText to RepaintIfTextOrBorderOrOutline.
RepaintIfTextOrBorderOrOutline turns "conditional repaints" to real repaints if, in addition to text, the content has outline/border.
However the fix was neither complete nor proper (it patched the repaint logic by changing hasImmediateNonWhitespaceTextChildOrBorderOrOutline
instead of computing the correct diff value -unconditional Repaint).
Fast-forward to 2020, r267528 ensured that content with outline is no longer a "conditional repaint".
It also made some of the code introduced in r156619 redundant (see hasImmediateNonWhitespaceTextChildOrBorderOrOutline).
This patch expands on r267528 by introducing isEquivalentForPainting for the border data. It ensures that we
compute (unconditional) Repaint diff value, if the border uses currentColor.
Tests: fast/repaint/repaint-current-color-border-on-hover.html
fast/repaint/repaint-pseudo-border-on-hover.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::hasImmediateNonWhitespaceTextChildOrBorderOrOutline const):
- rendering/style/BorderData.h:
(WebCore::BorderData::isEquivalentForPainting const):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresRepaint const):
LayoutTests:
- fast/repaint/repaint-current-color-border-on-hover-expected.txt: Added.
- fast/repaint/repaint-current-color-border-on-hover.html: Added.
- fast/repaint/repaint-pseudo-border-on-hover-expected.txt: Added.
- fast/repaint/repaint-pseudo-border-on-hover.html: Added.
- 7:40 AM Changeset in webkit [294194] by
-
- 2 edits in trunk/Tools
[webkit-patch] Include commit messages in patches (Follow-up)
https://bugs.webkit.org/show_bug.cgi?id=240256
<rdar://problem/92982358>
Unreviewed follow-up fix.
- Tools/Scripts/webkitpy/common/checkout/scm/git.py:
(Git.create_patch): Prefer commit specified by user.
Canonical link: https://commits.webkit.org/250560@main
- 6:59 AM Changeset in webkit [294193] by
-
- 4 edits in trunk/Source/WebCore
[FFC][Integration] Add updateFormattingRootGeometryAndInvalidate/updateRenderers
https://bugs.webkit.org/show_bug.cgi?id=240413
Reviewed by Antti Koivisto.
Make sure that the layout box/renderer geometries are all up-to-date.
- layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::logicalBorder):
(WebCore::LayoutIntegration::logicalPadding):
(WebCore::LayoutIntegration::FlexLayout::updateFormattingRootGeometryAndInvalidate):
(WebCore::LayoutIntegration::FlexLayout::layout):
(WebCore::LayoutIntegration::FlexLayout::updateRenderers const):
- layout/integration/flex/LayoutIntegrationFlexLayout.h:
(WebCore::LayoutIntegration::FlexLayout::flexBoxRenderer const):
(WebCore::LayoutIntegration::FlexLayout::flexBoxRenderer):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutUsingFlexFormattingContext):
- 6:30 AM Changeset in webkit [294192] by
-
- 2 edits in trunk/Source/WebCore
[FFC][Integration] Do not reset the effective display value for flex root
https://bugs.webkit.org/show_bug.cgi?id=240412
Reviewed by Antti Koivisto.
Non-inline formatting roots (e.g. flex) should not need display type adjustment.
- layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::rootBoxStyle):
(WebCore::LayoutIntegration::rootBoxFirstLineStyle):
(WebCore::LayoutIntegration::BoxTree::BoxTree):
(WebCore::LayoutIntegration::BoxTree::updateStyle):
- 6:19 AM Changeset in webkit [294191] by
-
- 11 edits in trunk/Source/WebCore
[LFC] LayoutState should track the integration formatting context type
https://bugs.webkit.org/show_bug.cgi?id=240411
Reviewed by Antti Koivisto.
Let's not use RuntimeEnabledFeatures to check wheter the integration codepath is enabled as
the new FCs (e.g. flex) don't even have such flags.
- layout/LayoutContext.cpp:
- layout/LayoutState.cpp:
(WebCore::Layout::LayoutState::LayoutState):
(WebCore::Layout::LayoutState::formattingStateForFormattingContext const):
(WebCore::Layout::LayoutState::formattingStateForInlineFormattingContext const):
(WebCore::Layout::LayoutState::formattingStateForFlexFormattingContext const):
(WebCore::Layout::LayoutState::ensureInlineFormattingState):
(WebCore::Layout::LayoutState::ensureFlexFormattingState):
(WebCore::Layout::LayoutState::setViewportSize):
(WebCore::Layout::LayoutState::viewportSize const):
(WebCore::Layout::LayoutState::setIsIntegratedRootBoxFirstChild):
(WebCore::Layout::LayoutState::shouldIgnoreTrailingLetterSpacing const):
(WebCore::Layout::LayoutState::shouldNotSynthesizeInlineBlockBaseline const):
- layout/LayoutState.h:
(WebCore::Layout::LayoutState::isInlineFormattingContextIntegration const):
(WebCore::Layout::LayoutState::isFlexFormattingContextIntegration const):
- layout/floats/FloatingState.cpp:
- layout/formattingContexts/inline/InlineFormattingContext.cpp:
- layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::close):
- layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::appendTextDisplayBox):
- layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::FlexLayout):
- layout/integration/inline/LayoutIntegrationInlineContent.cpp:
- layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::LineLayout):
(WebCore::LayoutIntegration::LineLayout::releaseCaches):
- 5:41 AM Changeset in webkit [294190] by
-
- 66 edits2 adds2 deletes in trunk/Source/WebKit
SharedBuffer should be copied and then attributed back to WebContent
https://bugs.webkit.org/show_bug.cgi?id=240223
rdar://91006582
Patch by Jean-Yves Avenard <jean-yves.avenard@apple.com> on 2022-05-14
Reviewed by Jer Noble.
Ideally, when mapping an IPCHandle we would prefer to use Copy On Write.
However, there's no support for COW with explicitly-owned memory such as
those created with VM_FLAGS_PURGABLE flag.
As such, when calling mach_vm_map with copy=true argument is set the
entire page will be copied.
It is therefore more performant to manually create a new buffer and copy
the actual content.
The memory can then be blamed on a particular process.
Rework FragmentedSharedBuffer/SharedBuffer IPC's serializer to perform
a copy, partially reverting changes made in bug 233401.
We replace the unnecessary use of SharedMemory::IPCHandle and directly
send SharedBuffer in clipboard and PDF related methods.
Rename SharedBufferCopy to SharedBufferReference to more accurately
describe what it does.
Make new use of the SharedBufferReference class, replacing the use of IPCHandle
in RemoteSourceBufferProxy and RemoteMediaResourceManager.
Rename SharedBufferReference::buffer() into
SharedBufferReference::unsafeBuffer() to give better clarity that accessing
SharedBuffer and SharedMemory should be treated with care.
SharedBuffer sent from trusted processes such as network process should
prefer the use of SharedBufferReference over directly using IPCHandle or
SharedBuffer, it makes optimisation easier and avoid duplicating code.
No observable change, covered by existing tests.
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::remoteMediaResourceManager):
- GPUProcess/media/RemoteCDMInstanceProxy.h:
- GPUProcess/media/RemoteImageDecoderAVFProxy.cpp:
(WebKit::RemoteImageDecoderAVFProxy::createDecoder):
(WebKit::RemoteImageDecoderAVFProxy::setData):
- GPUProcess/media/RemoteImageDecoderAVFProxy.h:
- GPUProcess/media/RemoteImageDecoderAVFProxy.messages.in:
- GPUProcess/media/RemoteMediaResourceManager.cpp:
(WebKit::RemoteMediaResourceManager::RemoteMediaResourceManager):
(WebKit::RemoteMediaResourceManager::dataReceived):
- GPUProcess/media/RemoteMediaResourceManager.h:
- GPUProcess/media/RemoteMediaResourceManager.messages.in:
- GPUProcess/media/RemoteSourceBufferProxy.cpp:
(WebKit::RemoteSourceBufferProxy::append):
- GPUProcess/media/RemoteSourceBufferProxy.h:
- GPUProcess/media/RemoteSourceBufferProxy.messages.in:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::bufferingTimerFired):
(WebKit::NetworkResourceLoader::sendBuffer):
(WebKit::NetworkResourceLoader::dataReceivedThroughContentFilter):
- NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.cpp:
(WebKit::ServiceWorkerDownloadTask::didReceiveData):
- NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h:
- NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.messages.in:
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::didReceiveData):
(WebKit::ServiceWorkerFetchTask::loadBodyFromPreloader):
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.h:
- NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.messages.in:
- Platform/IPC/SharedBufferCopy.cpp: Removed.
- Platform/IPC/SharedBufferCopy.h: Removed.
- Platform/IPC/SharedBufferReference.cpp: Added.
(IPC::SharedBufferReference::encode const):
(IPC::SharedBufferReference::decode):
(IPC::SharedBufferReference::unsafeBuffer const):
(IPC::SharedBufferReference::data const):
(IPC::SharedBufferReference::bufferWithOwner const):
- Platform/IPC/SharedBufferReference.h: Added.
(IPC::SharedBufferReference::SharedBufferReference):
(IPC::SharedBufferReference::size const):
(IPC::SharedBufferReference::isEmpty const):
(IPC::SharedBufferReference::isNull const):
- Platform/SharedMemory.cpp:
(WebKit::transferOwnershipOfMemory const):
- Platform/SharedMemory.h:
- Platform/cocoa/SharedMemoryCocoa.cpp:
(WebKit::changeOwnershipOfMemory):
(WebKit::SharedMemory::Handle::takeOwnershipOfMemory const):
(WebKit::SharedMemory::Handle::transferOwnershipOfMemory const):
(WebKit::machProtection):
(WebKit::SharedMemory::map):
- Scripts/process-entitlements.sh:
- Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp:
(WebKit::CGDisplayListImageBufferBackend::createBackendHandle const):
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
- Shared/WebCoreArgumentCoders.cpp:
(IPC::encodeSharedBuffer):
(IPC::decodeSharedBuffer):
- Sources.txt:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView createPDFWithConfiguration:completionHandler:]):
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::platformRegisterAttachment):
- UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::WebPasteboardProxy::getPasteboardBufferForType):
(WebKit::WebPasteboardProxy::setPasteboardBufferForType):
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):
- UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::sendAudioComponentRegistrations):
- UIProcess/WebPageProxy.cpp:
(WebKit::CompletionHandler<void):
(WebKit::WebPageProxy::drawPagesToPDF):
(WebKit::WebPageProxy::drawToPDF):
(WebKit::WebPageProxy::getLoadDecisionForIcon):
(WebKit::WebPageProxy::updateAttachmentAttributes):
(WebKit::WebPageProxy::registerAttachmentIdentifierFromData):
(WebKit::WebPageProxy::platformRegisterAttachment):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPasteboardProxy.cpp:
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):
- UIProcess/WebPasteboardProxy.h:
- UIProcess/WebPasteboardProxy.messages.in:
- UIProcess/WebURLSchemeTask.cpp:
(WebKit::WebURLSchemeTask::didReceiveData):
- UIProcess/gtk/WebPasteboardProxyGtk.cpp:
(WebKit::WebPasteboardProxy::readBuffer):
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _wk_pageCountForPrintFormatter:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::drawToPDFiOS):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::dataSelectionForPasteboard):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/graphics/ImageBufferBackendHandle.h:
- WebProcess/GPU/media/RemoteImageDecoderAVF.cpp:
(WebKit::RemoteImageDecoderAVF::setData):
- WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp:
(WebKit::RemoteImageDecoderAVFManager::createImageDecoder):
- WebProcess/GPU/media/RemoteMediaResourceProxy.cpp:
(WebKit::RemoteMediaResourceProxy::dataReceived):
- WebProcess/GPU/media/SourceBufferPrivateRemote.cpp:
(WebKit::SourceBufferPrivateRemote::append):
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveData):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::writeItemsToPasteboard):
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveData):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveBlobChunk):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::registerAttachmentIdentifier):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::readBufferFromClipboard):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getContentsAsMHTMLData):
(WebKit::WebPage::getSelectionAsWebArchiveData):
(WebKit::WebPage::getMainResourceDataOfFrame):
(WebKit::WebPage::getResourceDataFromFrame):
(WebKit::WebPage::getWebArchiveOfFrame):
(WebKit::WebPage::getAccessibilityTreeData):
(WebKit::WebPage::drawToPDF):
(WebKit::WebPage::drawPagesToPDF):
(WebKit::WebPage::didGetLoadDecisionForIcon):
(WebKit::WebPage::urlSchemeTaskDidReceiveData):
(WebKit::WebPage::updateAttachmentAttributes):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getDataSelectionForPasteboard):
(WebKit::WebPage::performActionOnElement):
(WebKit::WebPage::drawToPDFiOS):
(WebKit::WebPage::didFinishLoadForQuickLookDocumentInMainFrame):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::getDataSelectionForPasteboard):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::consumeAudioComponentRegistrations):
# Please populate the above commit message. Lines starting
# with '#' will be ignored
# 13 Tim Horton <timothy_horton@apple.com>
#
# ApplePayLogoSystemImage needlessly loads PassKit in WebKit child processes on iOS
# https://bugs.webkit.org/show_bug.cgi?id=240404
# <rdar://93070349>
#
# Reviewed by Chris Dumez.
#
# * UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
# (WebKit::ProcessLauncher::launchProcess): Adopt the WTF implementation of systemDirectoryPath.
# (WebKit::systemDirectoryPath): Moved to WTF.
#
# 13 Wenson Hsieh <Wenson Hsieh>
#
# ImageAnalysisQueue should reanalyze image elements whose image sources have changed
# https://bugs.webkit.org/show_bug.cgi?id=240371
# rdar://93175651
#
# Reviewed by Tim Horton.
#
# To aid with debugging similar issues in the future, plumb the image URL through to
#requestImageAnalysisWithIdentifier, which (if an engineering default is specified) will additionally reveal
# the URL in system logs.
#
# * Platform/cocoa/ImageAnalysisUtilities.h:
# * UIProcess/Cocoa/WebViewImpl.mm:
# (WebKit::WebViewImpl::requestTextRecognition):
# * UIProcess/ios/WKContentViewInteraction.mm:
# (-[WKContentView requestTextRecognition:imageData:identifier:completionHandler:]):
#
# 13 Aditya Keerthi <Aditya Keerthi>
#
# [iOS] Multiple visible find highlights when searching for text after beginning a "find from selection"
# https://bugs.webkit.org/show_bug.cgi?id=240393
# rdar://91441895
#
# Reviewed by Wenson Hsieh.
#
# Some WebKit clients use SPI on WKWebView to support "find from selection"
# functionality (the Cmd+E shortcut). However, to support general
# find functionality, they use new find API that uses a different codepath
# to draw highlights. Mixing use of the API and SPI can currently result
# in two highlights showing up.
#
# To fix, ensure SPI highlights are removed once the API is being used.
# The long term solution is for clients to adopt API for the
# "find from selection" functionality, but in the short term the SPI
# should remain supported.
#
# * WebProcess/WebPage/WebPage.cpp:
# (WebKit::WebPage::clearAllDecoratedFoundText):
#
# 13 Kimmo Kinnunen <kkinnunen@apple.com>
#
# IPC cannot encode, decode Ref<>, causing duplicate code
# https://bugs.webkit.org/show_bug.cgi?id=240160
#
# Reviewed by Antti Koivisto.
#
# Consider reference counted type T:
# Encoding is of signatureencode(const T&)
# Decoding is of signaturestd::optional<Ref<T>> decode()
# This is usable for bothRefPtrandRefuse-cases.
#
# AddRef<T>encoder that is polymorphic toT.
# This way clients do not need to write encoders for
#Ref<T>,RefPtr<T>. They just need one encoder, forT.
#
# When clients do not need to writeRefPtr<T>, they make less
# bugs. These will be corrected in future patches.
#
# HavingRef<T>encoders allows clients to useVector<Ref<T>>encoding
# viaVector<U>encoder, and they would not need to duplicate that
# logic, making less bugs. These will be corrected in future patches.
#
# Remove mostIPC::ArgumentCoder<Ref<..>>in favor ofIPC::ArgumentCoder<..>.
# In the cases where removal was done, remove also redundant
#IPC::ArgumentCoder<RefPtr<..>>.
#
# * Platform/IPC/ArgumentCoders.h:
# (IPC::ArgumentCoder<RefPtr<T>>::decode):
# (IPC::ArgumentCoder<Ref<T>>::encode):
# (IPC::ArgumentCoder<Ref<T>>::decode):
# * Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
# (IPC::ArgumentCoder<WebCore::Font>::encodePlatformData):
# (IPC::ArgumentCoder<WebCore::Font>::decodePlatformData):
# * Shared/WebCoreArgumentCoders.cpp:
# (IPC::ArgumentCoder<WebCore::Font>::encode):
# (IPC::ArgumentCoder<Font>::decode):
# (IPC::ArgumentCoder<SystemImage>::encode):
# (IPC::ArgumentCoder<SystemImage>::decode):
# * Shared/WebCoreArgumentCoders.h:
# * Shared/playstation/WebCoreArgumentCodersPlayStation.cpp:
# (IPC::ArgumentCoder<Font>::encodePlatformData):
# (IPC::ArgumentCoder<Font>::decodePlatformData):
# * Shared/soup/WebCoreArgumentCodersSoup.cpp:
# (IPC::ArgumentCoder<Font>::encodePlatformData):
# (IPC::ArgumentCoder<Font>::decodePlatformData):
# * Shared/win/WebCoreArgumentCodersWin.cpp:
# (IPC::ArgumentCoder<Font>::encodePlatformData):
# (IPC::ArgumentCoder<Font>::decodePlatformData):
#
# 13 Tim Horton <timothy_horton@apple.com>
#
# Add UI-side layers for optionally indicating interaction regions
# https://bugs.webkit.org/show_bug.cgi?id=240372
# <rdar://problem/87170289>
#
# Reviewed by Dean Jackson.
#
# * Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
# (WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
# (WebKit::RemoteLayerTreePropertyApplier::applyHierarchyUpdates):
# Allow RemoteLayerTreeInteractionRegionLayers to add and maintain layers for interaction regions.
#
# * SourcesCocoa.txt:
# * UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.h: Added.
# * UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm: Added.
# (configureLayerForInteractionRegion):
# (WebKit::interactionRegionForLayer):
# (WebKit::isInteractionRegionLayer):
# (WebKit::setInteractionRegion):
# Box WebCore::InteractionRegion in a Objective-C object and store it on the layer.
# Use this as a key to indicate that a given layer is an interaction region.
#
# (WebKit::appendInteractionRegionLayersForLayer):
# Make sure that interaction region layers are always at the end of the layer's sublayers array.
#
# (WebKit::updateLayersForInteractionRegions):
# Add new layers for interaction regions.
# Maintain the same layer for regions that cover the same area.
# Add a green wash if the defaultWKInteractionRegionDebugFillis set.
#
# * WebKit.xcodeproj/project.pbxproj:
#
# 13 Simon Fraser <Simon Fraser>
#
# Simplify the usage of DrawGlyphsRecorder
# https://bugs.webkit.org/show_bug.cgi?id=240363
#
# Reviewed by Myles Maxfield.
#
# Move the DeconstructDrawGlyphs switch from inside DrawGlyphsRecorder to
# DisplayList::Recorder, so that DrawGlyphsRecorder is only ever used when deconstructing
# glyphs.
#
# Also, ensure that the only time that glyph deconstruction is enabled is when
# recording display lists via RemoteDisplayListRecorderProxy. There's no reason for
# paintAttachmentText() to need glyph deconstruction.
#
# This is a small perf improvement on the MotionMark Design subtest.
#
# * WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
# (WebKit::RemoteDisplayListRecorderProxy::RemoteDisplayListRecorderProxy):
# (WebKit::m_renderingBackend):
# * WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
#
# it takes from the XPC message is sent until the XPC reply is received. Add reporting when this happens
# On branch bz/240223
# Your branch is ahead of 'origin/main' by 1 commit.
# (use "git push" to publish your local commits)
#
# Changes to be committed:
# (use "git restore --staged <file>..." to unstage)
# modified: Source/WebKit/ChangeLog
#
# Untracked files:
# (use "git add <file>..." to include in what will be committed)
# 0001-SharedBuffer-should-be-copied-and-then-attributed-ba.patch
#
Canonical link: https://commits.webkit.org/250556@main
- 12:21 AM Changeset in webkit [294189] by
-
- 1 edit in trunk/Source/WTF/wtf/text/WTFString.h
Drop unused appendNumber(Vector<CharacterType>& vector, unsigned char) function
https://bugs.webkit.org/show_bug.cgi?id=240387
Reviewed by Darin Adler.
- Source/WTF/wtf/text/WTFString.h:
(WTF::appendNumber): Deleted.
Canonical link: https://commits.webkit.org/250555@main
May 13, 2022:
- 11:14 PM Changeset in webkit [294188] by
-
- 7 edits in trunk/Source
ApplePayLogoSystemImage needlessly loads PassKit in WebKit child processes on iOS
https://bugs.webkit.org/show_bug.cgi?id=240404
<rdar://93070349>
Reviewed by Chris Dumez.
Source/WebCore:
- Modules/applepay/ApplePayLogoSystemImage.mm:
(WebCore::passKitBundle):
Adopt systemDirectoryPath instead of unnecessarily loading PassKit just
to find its bundle path (the previous implementation made use of the fact
thatdlopeninternally adjusts the search path to look in the simulator
root, but also resulted in wasted time loading and initializing PassKit
and its dependencies).
Source/WebKit:
- UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::ProcessLauncher::launchProcess): Adopt the WTF implementation of systemDirectoryPath.
(WebKit::systemDirectoryPath): Moved to WTF.
Source/WTF:
- wtf/FileSystem.h:
- wtf/cocoa/FileSystemCocoa.mm:
(WTF::FileSystemImpl::systemDirectoryPath):
Move the implementation of systemDirectoryPath() from WebKit2.
systemDirectoryPath() provides the correct path to /System
in the simulator, for consumption by APIs (like NSURL) that do not
adjust to the simulator-rooted path themselves.
- 10:29 PM Changeset in webkit [294187] by
-
- 11 edits2 deletes in trunk
[css-ui] Unexpose appearance property values already handled by appearance: auto
https://bugs.webkit.org/show_bug.cgi?id=240384
Reviewed by Aditya Keerthi.
These are only used internally, and are handled by appearance: auto in the UA sheets:
- caps-lock-indicator
- color-well
- list-button
- searchfield-decoration
- searchfield-results-decoration
- searchfield-results-button
- searchfield-cancel-button
LayoutTests/imported/w3c:
- web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
Source/WebCore:
Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
- platform/ThemeTypes.cpp:
(WebCore::operator<<):
- platform/ThemeTypes.h:
LayoutTests:
- platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- fast/css/appearance-caps-lock-indicator-expected.txt: Removed.
- fast/css/appearance-caps-lock-indicator.html: Removed.
- 9:37 PM Changeset in webkit [294186] by
-
- 8 edits2 adds in trunk
Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence
https://bugs.webkit.org/show_bug.cgi?id=240365
Reviewed by Chris Fleizach.
Source/WebCore:
We can get infinite recursion when accessibilityIsIgnored is called as
part of computing AccessibilityObject::ignoredFromModalPresence. One
example of such a cycle:
AXObjectCache::currentModalNode() ->
AccessibilityRenderObject::computeAccessibilityIsIgnored() ->
AccessibilityRenderObject::parentObjectUnignored() ->
AccessibilityObject::accessibilityIsIgnored() ->
AccessibilityObject::ignoredFromModalPresence() ->
AXObjectCache::currentModalNode() ->
...repeat...
This patch fixes this by tracking when we start computing the current
modal node in the AXObjectCache. Then, in AccessibilityObject::accessibilityIsIgnored(),
we don't call AccessibilityObject::ignoredFromModalPresence() if this new state is true,
since in this context we only need to know if the object is inherently
ignored (i.e. ignored disregarding modal presence).
Test: accessibility/aria-modal-with-text-crash.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::currentModalNode):
- accessibility/AXObjectCache.h:
Add m_isRetrievingCurrentModalNode.
(WebCore::AXObjectCache::isRetrievingCurrentModalNode): Added.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::accessibilityIsIgnored const):
Don't call ignoredFromModalPresence if we're in the midst of computing the current modal.
LayoutTests:
- accessibility/aria-modal-with-text-crash-expected.txt: Added.
- accessibility/aria-modal-with-text-crash.html: Added.
- platform/glib/TestExpectations: Skip new test.
- platform/ios/TestExpectations: Enable new test.
- platform/win/TestExpectations: Skip new test.
- 8:20 PM Changeset in webkit [294185] by
-
- 9 edits in branches/safari-7614.1.12-branch/Source
Versioning.
WebKit-7614.1.12.4
- 6:42 PM Changeset in webkit [294184] by
-
- 2 edits in trunk/Tools
[webkit-patch] Apply patches commit messages
https://bugs.webkit.org/show_bug.cgi?id=240402
<rdar://93272455>
Reviewed by Dewei Zhu.
- Tools/Scripts/webkitpy/common/checkout/checkout.py:
(Checkout):
(filter_patch_content): Insert reviewer to git patch as we're applying it.
(apply_patch): If a patch has a commit subject, it contains commit messages
and we should apply those commit messages.
Canonical link: https://commits.webkit.org/250551@main
- 4:37 PM Changeset in webkit [294183] by
-
- 7 edits in trunk/Tools
[webkit-patch] Include commit messages in patches
https://bugs.webkit.org/show_bug.cgi?id=240256
<rdar://92982358>
Rubber-stamped by Aakash Jain.
- Scripts/webkitpy/common/checkout/checkout.py:
(Checkout.commit_message_for_this_commit): If no changelogs are modified, prefer
the commit message.
- Scripts/webkitpy/common/checkout/diff_parser.py:
(DiffParser._parse_into_diff_files): Ignore commit message headers.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.create_patch): Prefer
git format-patchwhen local commits are available.
(Git.rev_parse): Determine hash for ref.
(Git.format_patch): Deleted.
(Git.request_pull): Deleted.
- Scripts/webkitpy/tool/steps/abstractstep.py:
(AbstractStep): Keep record of local commit.
- Scripts/webkitpy/tool/steps/editchangelog.py:
(EditChangeLog.run): Do not edit changelog if no changelog is present.
- Scripts/webkitpy/tool/steps/preparechangelog.py:
(PrepareChangeLog.run): Do not prepare changelog if local commit is present.
Canonical link: https://commits.webkit.org/250550@main
- 4:12 PM Changeset in webkit [294182] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r281791): [iOS] WKWebView cannot load local .log file
https://bugs.webkit.org/show_bug.cgi?id=239591
<rdar://problem/92442408>
Unreviewed correction based on a comment from Darin.
- platform/network/ios/WebCoreURLResponseIOS.mm:
(WebCore::adjustMIMETypeIfNecessary):
- 3:56 PM Changeset in webkit [294181] by
-
- 2 edits in trunk/Source/WTF
Enforce foreground WebContent memory limit on macOS
https://bugs.webkit.org/show_bug.cgi?id=240397
Reviewed by Chris Dumez.
We removed the foreground memory limit for WebContent on macOS in r272046. But based on some
bug reports that we've seen, it seems like we need to restore some limit to prevent bad user
outcomes when a misbehaving process has runaway memory usage.
This patch adds a foreground memory limit of 8GB or 16GB depending on RAM size. This matches
the limits set by other browsers for their content process.
- wtf/MemoryPressureHandler.cpp:
(WTF::thresholdForMemoryKillOfActiveProcess):
(WTF::MemoryPressureHandler::thresholdForMemoryKill):
Canonical link: https://commits.webkit.org/250548@main
- 3:28 PM Changeset in webkit [294180] by
-
- 28 edits in trunk/Source/JavaScriptCore
Enhance the ARM64Disassembler to print pc indices and better branch target labels.
https://bugs.webkit.org/show_bug.cgi?id=240370
Reviewed by Saam Barati.
Disassemblies used to look like this:
0x10e480ff8: ldurb w17, [x0, #7]
0x10e480ffc: cmp w17, #0
0x10e481000: b.hi 0x10e48103c
0x10e481004: stur x0, [fp, #-72]
...
0x10e481040: movk x3, #0xfffe, lsl #48
0x10e481044: b 0x10e4814f4
0x10e481048: nop
With this patch, it will now look like this:
<748> 0x10e120aec: ldurb w17, [x0, #7]
<752> 0x10e120af0: cmp w17, #0
<756> 0x10e120af4: b.hi 0x10e120b30 -> <816>
<760> 0x10e120af8: stur x0, [fp, #-80]
...
<820> 0x10e120b34: movk x3, #0xfffe, lsl #48
<824> 0x10e120b38: b 0x10e120fc8 -> <1992>
<828> 0x10e120b3c: nop
- Each instruction pc is now prefixed with a pc index i.e. the offset of the pc address from the start of the compilation unit e.g. <756>.
- Relative branches now show the branch target as a pc index (effectively, an internal label in this compilation unit) in addition to the pc address e.g. the "-> <816>" in:
<756> 0x10e120af4: b.hi 0x10e120b30 -> <816>
Also fixed a formatting bug where the space between relative branch instructions
and their target pc was short 2 spaces.
- If the relative branch target is a known thunk, the disassembler will now print the thunk label e.g.
<828> 0x10e12033c: bl 0x10e0f0a00 -> <thunk: get_from_scope thunk>
<1476> 0x10e120dc4: cbnz x16, 0x10e104100 -> <thunk: handleExceptionWithCallFrameRollback>
<2368> 0x10e121140: b 0x10e10c000 -> <thunk: DFG OSR exit generation thunk>
Introduced a FINALIZE_THUNK macro that will be used instead of FINALIZE_CODE in
thunk generators. By doing so, thunk labels will automatically be registered
with the disassembler, and will be used for the above look up.
Thunk label registration is only done if disassembly is enabled.
- If the branch target is neither an internal label nor a thunk, then the disassembler will print some useful info about it to the best of its knowledge e.g.
<168> 0x10e1002e8: b 0x10e120b60 -> <JIT PC>
<168> 0x10e1002e8: b 0x10e120b60 -> <LLInt PC>
<168> 0x10e1002e8: b 0x10e120b60 -> <unknown>
- The disassemble() function now takes 2 additional arguments: codeStart, and codeEnd. These are needed so that the disassembler can compute the pc index for each instruction, as well as determine if a branch target is internal to this compilation unit, or pointing out of it.
This feature is currently only supported for the ARM64 disassembler.
Printing of JIT operation labels (via movz + movk + indirect branch) is not yet
supported.
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::finalizeCodeWithDisassemblyImpl):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::setIsThunk):
- b3/air/AirDisassembler.cpp:
(JSC::B3::Air::Disassembler::dump):
- dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::dumpDisassembly):
- dfg/DFGThunks.cpp:
(JSC::DFG::osrExitGenerationThunkGenerator):
(JSC::DFG::osrEntryThunkGenerator):
- disassembler/ARM64/A64DOpcode.cpp:
(JSC::ARM64Disassembler::A64DOpcode::appendPCRelativeOffset):
(JSC::ARM64Disassembler::A64DOpcodeConditionalBranchImmediate::format):
- disassembler/ARM64/A64DOpcode.h:
(JSC::ARM64Disassembler::A64DOpcode::A64DOpcode):
(JSC::ARM64Disassembler::A64DOpcode::appendPCRelativeOffset): Deleted.
- disassembler/ARM64Disassembler.cpp:
(JSC::tryToDisassemble):
- disassembler/CapstoneDisassembler.cpp:
(JSC::tryToDisassemble):
- disassembler/Disassembler.cpp:
(JSC::disassemble):
(JSC::disassembleAsynchronously):
(JSC::ensureThunkLabelMap):
(JSC::registerThunkLabel):
(JSC::labelForThunk):
- disassembler/Disassembler.h:
(JSC::tryToDisassemble):
- disassembler/RISCV64Disassembler.cpp:
(JSC::tryToDisassemble):
- disassembler/X86Disassembler.cpp:
(JSC::tryToDisassemble):
- ftl/FTLThunks.cpp:
(JSC::FTL::genericGenerationThunkGenerator):
(JSC::FTL::slowPathCallThunkGenerator):
- jit/JIT.cpp:
(JSC::JIT::consistencyCheckGenerator):
- jit/JITCall.cpp:
(JSC::JIT::returnFromBaselineGenerator):
- jit/JITDisassembler.cpp:
(JSC::JITDisassembler::dump):
(JSC::JITDisassembler::dumpDisassembly):
- jit/JITDisassembler.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::valueIsFalseyGenerator):
(JSC::JIT::valueIsTruthyGenerator):
(JSC::JIT::op_throw_handlerGenerator):
(JSC::JIT::op_enter_handlerGenerator):
(JSC::JIT::op_check_traps_handlerGenerator):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::slow_op_get_by_val_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_get_private_name_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_put_by_val_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_put_private_name_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_del_by_id_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_del_by_val_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_get_by_id_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_get_by_id_with_this_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_put_by_id_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::generateOpResolveScopeThunk):
(JSC::JIT::slow_op_resolve_scopeGenerator):
(JSC::JIT::generateOpGetFromScopeThunk):
(JSC::JIT::slow_op_get_from_scopeGenerator):
(JSC::JIT::slow_op_put_to_scopeGenerator):
- jit/SlowPathCall.cpp:
(JSC::JITSlowPathCall::generateThunk):
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
- jit/ThunkGenerator.h:
- jit/ThunkGenerators.cpp:
(JSC::handleExceptionGenerator):
(JSC::handleExceptionWithCallFrameRollbackGenerator):
(JSC::popThunkStackPreservesAndHandleExceptionGenerator):
(JSC::checkExceptionGenerator):
(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::linkCallThunkGenerator):
(JSC::linkPolymorphicCallThunkGenerator):
(JSC::virtualThunkFor):
(JSC::nativeForGenerator):
(JSC::arityFixupGenerator):
(JSC::unreachableGenerator):
(JSC::stringGetByValGenerator):
(JSC::boundFunctionCallGenerator):
(JSC::remoteFunctionCallGenerator):
- llint/LLIntThunks.cpp:
(JSC::LLInt::generateThunkWithJumpTo):
(JSC::LLInt::generateThunkWithJumpToPrologue):
(JSC::LLInt::generateThunkWithJumpToLLIntReturnPoint):
(JSC::LLInt::createJSGateThunk):
(JSC::LLInt::createWasmGateThunk):
(JSC::LLInt::createTailCallGate):
(JSC::LLInt::tagGateThunk):
(JSC::LLInt::untagGateThunk):
- yarr/YarrDisassembler.cpp:
(JSC::Yarr::YarrDisassembler::dump):
(JSC::Yarr::YarrDisassembler::dumpDisassembly):
- yarr/YarrDisassembler.h:
- 3:20 PM Changeset in webkit [294179] by
-
- 9 edits in trunk
ImageAnalysisQueue should reanalyze image elements whose image sources have changed
https://bugs.webkit.org/show_bug.cgi?id=240371
rdar://93175651
Reviewed by Tim Horton.
Currently, ImageAnalysisQueue maintains the set of all image elements that have been queued for analysis, and
avoids re-queueing such image elements. However, on some websites, this leads to stale analysis results being
shown in certain image elements that have changed image sources (and subsequently finished loaded the new image).
To address this, we introduce a mechanism to remember the latest image URL for image elements that have been
analyzed using the analysis queue; we only avoid reanalyzing these same image elements if the source URL is the
same as the source URL when we last analyzed it.
This allows us (for instance) to handle the scenario where a single image element periodically cycles between
differentsrcattribute values.
Test: ImageAnalysisTests.AnalyzeImageAfterChangingSource
- page/ImageAnalysisQueue.cpp:
(WebCore::ImageAnalysisQueue::enqueueIfNeeded):
Also avoid trying to prematurely analyze images whose cached images only contain the null image. This caused
empty results to sometimes be incorrectly cached for some image elements, if analysis is triggered too early.
(WebCore::ImageAnalysisQueue::resumeProcessing):
- page/ImageAnalysisQueue.h:
To aid with debugging similar issues in the future, plumb the image URL through to
requestImageAnalysisWithIdentifier, which (if an engineering default is specified) will additionally reveal
the URL in system logs.
- Platform/cocoa/ImageAnalysisUtilities.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::requestTextRecognition):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView requestTextRecognition:imageData:identifier:completionHandler:]):
Add an API test to exercise the scenario by verifying that the same image element is reanalyzed after setting
thesrcto a different image URL.
- TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/250546@main
- 3:11 PM Changeset in webkit [294178] by
-
- 2 edits1 add in trunk/Tools/buildstream
[Flatpak SDK] Add Breakpad to SDK
https://bugs.webkit.org/show_bug.cgi?id=240367
Reviewed by Philippe Normand.
To be used to generate minidumps of crashes.
Based on original bst file by Adrian Perez de Castro.
- elements/sdk-platform.bst:
- elements/sdk/breakpad.bst: Added.
- 3:02 PM Changeset in webkit [294177] by
-
- 5 edits in trunk/Source
Non-unified build broken in debug mode
https://bugs.webkit.org/show_bug.cgi?id=240378
Unreviewed non-unified build fixes.
- heap/StructureAlignedMemoryAllocator.cpp: Include <sys/mman.h> if needed.
Non-unified build broken in debug mode
https://bugs.webkit.org/show_bug.cgi?id=240378
Unreviewed non-unified build fixes.
- contentextensions/ContentExtensionCompiler.cpp: Add missing wtf/CrossThreadCopier.h header.
- workers/service/ServiceWorkerClients.cpp: Add missing Logging.h header.
Canonical link: https://commits.webkit.org/250544@main
- 2:55 PM Changeset in webkit [294176] by
-
- 6 edits in trunk
TemporalPlainTime::toTemporalTimeRecord shouldn't require all properties to be provided
https://bugs.webkit.org/show_bug.cgi?id=240394
Reviewed by Yusuke Suzuki and Darin Adler.
Following the spec correction of https://github.com/tc39/proposal-temporal/pull/1862, this patch
fixes our Temporal.PlainTime implementation to require that *one* property be provided, not *all* of them.
- stress/temporal-plaintime.js:
- test262/expectations.yaml: Mark 32 test cases as passing.
- runtime/TemporalDuration.cpp:
(JSC::TemporalDuration::fromDurationLike):
- runtime/TemporalPlainTime.cpp:
(JSC::toTemporalTimeRecord):
Canonical link: https://commits.webkit.org/250543@main
- 2:43 PM Changeset in webkit [294175] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Multiple visible find highlights when searching for text after beginning a "find from selection"
https://bugs.webkit.org/show_bug.cgi?id=240393
rdar://91441895
Reviewed by Wenson Hsieh.
Some WebKit clients use SPI on WKWebView to support "find from selection"
functionality (the Cmd+E shortcut). However, to support general
find functionality, they use new find API that uses a different codepath
to draw highlights. Mixing use of the API and SPI can currently result
in two highlights showing up.
To fix, ensure SPI highlights are removed once the API is being used.
The long term solution is for clients to adopt API for the
"find from selection" functionality, but in the short term the SPI
should remain supported.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::clearAllDecoratedFoundText):
- 2:40 PM Changeset in webkit [294174] by
-
- 2 edits in trunk/Tools
Disable MediaLoading.CaptivePortalHLS API test
https://bugs.webkit.org/show_bug.cgi?id=239859
It is always timing out.
Disable it to speed up EWS.
- TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
(TestWebKitAPI::TEST):
- 2:39 PM Changeset in webkit [294173] by
-
- 1 copy in tags/WebKit-7614.1.14
Tag WebKit-7614.1.14.
- 2:36 PM Changeset in webkit [294172] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm
Regression(r293803) ProcessSwap.MediaTypeAfterSwap and ProcessSwap.PageZoomLevelAfterSwap are failing
https://bugs.webkit.org/show_bug.cgi?id=240399
Reviewed by Alex Christensen.
Since r293803, WebKit's default WebContent process crash handler only reloads WebViews that are
visible. However, those 2 API tests were relying on the old behavior. To address the issue, use
a custom process termination handler which reloads the view.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[PSONNavigationDelegate webViewWebContentProcessDidTerminate:]):
Canonical link: https://commits.webkit.org/250540@main
- 2:12 PM Changeset in webkit [294171] by
-
- 2 edits in trunk/Tools
Use None for architecture when dump-class-layout does not have
-aoption
https://bugs.webkit.org/show_bug.cgi?id=240395
Reviewed by Saam Barati and Simon Fraser.
We can pass None to architecture, then SBDebugger::CreateTargetWithFileAndArch
will call CreateTarget with nullptr architecture string. Then, TargetList constructs
ArchSpec based on currently selected platform automatically and it covers most of cases.
I tried it, and it worked with watchOS, macOS, iOS so far.
So, we should just pass None to CreateTargetWithFileAndArch by default.
- Tools/lldb/lldb_dump_class_layout.py:
(LLDBDebuggerInstance.init):
(LLDBDebuggerInstance.del):
(LLDBDebuggerInstance._get_first_file_architecture): Deleted.
Canonical link: https://commits.webkit.org/250539@main
- 12:38 PM Changeset in webkit [294170] by
-
- 14 edits1 delete in trunk
[css-ui] Remove caret/progress-bar-value/listitem values from appearance property
https://bugs.webkit.org/show_bug.cgi?id=240390
Reviewed by Aditya Keerthi.
LayoutTests/imported/w3c:
They're basically unimplemented.
- web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
Source/WebCore:
Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- platform/ThemeTypes.cpp:
(WebCore::operator<<):
- platform/ThemeTypes.h:
LayoutTests:
They're basically unimplemented.
Remove WPE expectations which were very out-of-date.
- fast/css/appearance-with-pseudo-elements-expected.html:
- fast/css/appearance-with-pseudo-elements-in-quirks-mode-expected.html:
- fast/css/appearance-with-pseudo-elements-in-quirks-mode.html:
- fast/css/appearance-with-pseudo-elements.html:
- platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt: Removed.
- 12:16 PM Changeset in webkit [294169] by
-
- 8 edits in trunk/Source/WebKit
IPC cannot encode, decode Ref<>, causing duplicate code
https://bugs.webkit.org/show_bug.cgi?id=240160
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-13
Reviewed by Antti Koivisto.
Consider reference counted type T:
Encoding is of signatureencode(const T&)
Decoding is of signaturestd::optional<Ref<T>> decode()
This is usable for bothRefPtrandRefuse-cases.
Add
Ref<T>encoder that is polymorphic toT.
This way clients do not need to write encoders for
Ref<T>,RefPtr<T>. They just need one encoder, forT.
When clients do not need to write
RefPtr<T>, they make less
bugs. These will be corrected in future patches.
Having
Ref<T>encoders allows clients to useVector<Ref<T>>encoding
viaVector<U>encoder, and they would not need to duplicate that
logic, making less bugs. These will be corrected in future patches.
Remove most
IPC::ArgumentCoder<Ref<..>>in favor ofIPC::ArgumentCoder<..>.
In the cases where removal was done, remove also redundant
IPC::ArgumentCoder<RefPtr<..>>.
- Platform/IPC/ArgumentCoders.h:
(IPC::ArgumentCoder<RefPtr<T>>::decode):
(IPC::ArgumentCoder<Ref<T>>::encode):
(IPC::ArgumentCoder<Ref<T>>::decode):
- Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<WebCore::Font>::encodePlatformData):
(IPC::ArgumentCoder<WebCore::Font>::decodePlatformData):
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<WebCore::Font>::encode):
(IPC::ArgumentCoder<Font>::decode):
(IPC::ArgumentCoder<SystemImage>::encode):
(IPC::ArgumentCoder<SystemImage>::decode):
- Shared/WebCoreArgumentCoders.h:
- Shared/playstation/WebCoreArgumentCodersPlayStation.cpp:
(IPC::ArgumentCoder<Font>::encodePlatformData):
(IPC::ArgumentCoder<Font>::decodePlatformData):
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<Font>::encodePlatformData):
(IPC::ArgumentCoder<Font>::decodePlatformData):
- Shared/win/WebCoreArgumentCodersWin.cpp:
(IPC::ArgumentCoder<Font>::encodePlatformData):
(IPC::ArgumentCoder<Font>::decodePlatformData):
- 11:25 AM Changeset in webkit [294168] by
-
- 2 edits in branches/safari-7614.1.13-branch/Source/WebCore
Cherry-pick r294135. rdar://problem/93201070
[WebAuthn] Remove document focus requirement for conditional mediation requests
https://bugs.webkit.org/show_bug.cgi?id=240361
rdar://problem/93201070
Reviewed by Brent Fulgham.
This is necessary so conditional mediation requests work when you open a page in
a new tab. Conditional mediation requests do not support security keys and the
request will be aborted if conditional mediation is not available.
- Modules/credentialmanagement/CredentialsContainer.cpp: (WebCore::CredentialsContainer::get):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:22 AM Changeset in webkit [294167] by
-
- 9 edits in trunk/Source/WebCore
Move handling of active descendant changed notifications out of AccessibilityRenderObject.
https://bugs.webkit.org/show_bug.cgi?id=240357
<rdar://problem/93196901>
Reviewed by Chris Fleizach.
No change in functionality.
AXObjectCache::handleActiveDescendantChanged now handles this
notifications as appropriate. This makes the code cleaner and more
straightforward. More importantly this change is necessary for the
refactoring of relationships implementation.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleActiveDescendantChanged):
(WebCore::AXObjectCache::handleAttributeChange):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::handleActiveDescendantChanged):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityObjectInterface.h:
(WebCore::Accessibility::findRelatedObjectInAncestry):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::activeDescendant const):
(WebCore::AccessibilityRenderObject::shouldNotifyActiveDescendant const): Deleted.
(WebCore::AccessibilityRenderObject::targetElementForActiveDescendant const): Deleted.
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged): Deleted.
- accessibility/AccessibilityRenderObject.h:
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::handleActiveDescendantChanged): Deleted.
- accessibility/isolatedtree/AXIsolatedObject.h:
- 11:06 AM Changeset in webkit [294166] by
-
- 26 edits8 adds in trunk
Web Inspector: [Meta] Implement Timelines Film Strip
https://bugs.webkit.org/show_bug.cgi?id=239350
Patch by Anjali Kumar <anjalik_22@apple.com> on 2022-05-13
Reviewed by Devin Rousso and Patrick Angle.
Source/JavaScriptCore:
- inspector/protocol/Timeline.json:
Source/WebCore:
Test: inspector/timeline/timeline-event-screenshots.html
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createScreenshotData):
- inspector/TimelineRecordFactory.h:
- inspector/agents/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didComposite):
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::didPaint):
(WebCore::InspectorTimelineAgent::toggleInstruments):
(WebCore::InspectorTimelineAgent::captureScreenshot):
(WebCore::toProtocol):
(WebCore::InspectorTimelineAgent::createRecordEntry):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
- inspector/agents/InspectorTimelineAgent.h:
Source/WebInspectorUI:
Add the ability to see screenshots taken of the viewport within the Timelines tab. The purpose of the
screenshots is to provide more context to the other data presented within the Timelines tab, so that
developers can improve the efficiency of their page loading times. They can see what is painting on their
pages in addition to when the paints are occuring.
The screenshots presented are taken immediately after each composite. They are designed to be layered
on top of one another as opposed to being presented in a non-overlapping fashion in order to provide developers
with the exact screenshot that occured during a particular point in time on the timeline. This allows developers
to zoom in and pinpoint the exact moment the page looked like that particularly rendered screenshot.
When a screenshot is clicked on, the details section opens up to an enlarged view of that particular image.
Developers can utilize this to view each screenshot in greater detail.
This feature is named "Screenshots" (one word), as in the UI we currently have existing strings for "Capture
Screenshot" and "Could not capture screenshot".
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Base/Setting.js:
- UserInterface/Controllers/TimelineManager.js:
(WI.TimelineManager.defaultTimelineTypes):
(WI.TimelineManager.prototype._processRecord):
(WI.TimelineManager.prototype._updateAutoCaptureInstruments):
- UserInterface/Images/IdentifierIcons.svg:
- UserInterface/Main.html:
- UserInterface/Models/Instrument.js:
(WI.Instrument.createForTimelineType):
- UserInterface/Models/ScreenshotsInstrument.js: Added.
(WI.ScreenshotsInstrument):
(WI.ScreenshotsInstrument.supported):
(WI.ScreenshotsInstrument.prototype.get timelineRecordType):
- UserInterface/Models/ScreenshotsTimelineRecord.js: Added.
(WI.ScreenshotsTimelineRecord):
(WI.ScreenshotsTimelineRecord.async fromJSON):
(WI.ScreenshotsTimelineRecord.prototype.toJSON):
(WI.ScreenshotsTimelineRecord.prototype.get imageData):
(WI.ScreenshotsTimelineRecord.prototype.get width):
(WI.ScreenshotsTimelineRecord.prototype.get height):
- UserInterface/Models/TimelineRecord.js:
(WI.TimelineRecord.async fromJSON):
- UserInterface/Models/TimelineRecording.js:
(WI.TimelineRecording.prototype.addRecord):
- UserInterface/Test.html:
- UserInterface/Views/ContentView.js:
(WI.ContentView.createFromRepresentedObject):
- UserInterface/Views/ScreenshotsTimelineOverviewGraph.css: Added.
(body .sidebar > .panel.navigation.timeline > .timelines-content li.item.screenshots,):
(.timeline-overview-graph.screenshots > img):
(.timeline-overview-graph.screenshots > img.selected):
- UserInterface/Views/ScreenshotsTimelineOverviewGraph.js: Added.
(WI.ScreenshotsTimelineOverviewGraph):
(WI.ScreenshotsTimelineOverviewGraph.prototype.get height):
(WI.ScreenshotsTimelineOverviewGraph.prototype.layout):
(WI.ScreenshotsTimelineOverviewGraph.prototype.updateSelectedRecord):
(WI.ScreenshotsTimelineOverviewGraph.prototype._visibleRecords):
- UserInterface/Views/ScreenshotsTimelineView.css: Added.
(.timeline-view.screenshots):
(.timeline-view.screenshots > img):
(.timeline-view.screenshots > img.selected):
- UserInterface/Views/ScreenshotsTimelineView.js: Added.
(WI.ScreenshotsTimelineView):
(WI.ScreenshotsTimelineView.prototype.reset):
(WI.ScreenshotsTimelineView.prototype.clear):
(WI.ScreenshotsTimelineView.prototype.get showsFilterBar):
(WI.ScreenshotsTimelineView.prototype.layout):
(WI.ScreenshotsTimelineView.prototype.selectRecord):
(WI.ScreenshotsTimelineView.prototype._selectTimelineRecord):
(WI.ScreenshotsTimelineView.prototype._visibleRecords):
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
- UserInterface/Views/TimelineIcons.css:
(.screenshots-icon .icon):
(@media (prefers-color-scheme: dark) .screenshots-icon .icon):
- UserInterface/Views/TimelineOverviewGraph.js:
(WI.TimelineOverviewGraph.createForTimeline):
- UserInterface/Views/TimelineTabContentView.js:
(WI.TimelineTabContentView.displayNameForTimelineType):
(WI.TimelineTabContentView.iconClassNameForTimelineType):
(WI.TimelineTabContentView.genericClassNameForTimelineType):
(WI.TimelineTabContentView.iconClassNameForRecord):
(WI.TimelineTabContentView.displayNameForRecord):
LayoutTests:
- inspector/timeline/resources/timeline-event-utilities.js:
(TestPage.registerInitializer.InspectorTest.TimelineEvent.captureTimelineWithScript):
(TestPage.registerInitializer):
- inspector/timeline/timeline-event-screenshots-expected.txt: Added.
- inspector/timeline/timeline-event-screenshots.html: Added.
- inspector/timeline/timeline-recording-expected.txt:
- 11:04 AM Changeset in webkit [294165] by
-
- 2 edits in trunk
Add self to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240389
Patch by Geza Lore <Geza Lore> on 2022-05-13
Reviewed by Jonathan Bedard.
- metadata/contributors.json:
- 10:58 AM Changeset in webkit [294164] by
-
- 2 edits in trunk/Source/WebCore
-Wstringop-overflow warning in DocumentWriter.cpp
https://bugs.webkit.org/show_bug.cgi?id=239340
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-05-13
Reviewed by Chris Dumez.
- Source/WebCore/loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::end):
Canonical link: https://commits.webkit.org/250533@main
- 10:25 AM Changeset in webkit [294163] by
-
- 4 edits in trunk
input.showPicker() should throw when input is readonly/disabled
https://bugs.webkit.org/show_bug.cgi?id=240302
Reviewed by Tim Nguyen.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly.html: Added.
Source/WebCore:
When input is readonly or disabled, input.showPicker() should throw InvalidStateError.
Test: imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::showPicker):
- 10:21 AM Changeset in webkit [294162] by
-
- 2 edits in trunk/Source/WebCore
-Wreturn-type warning in PathOperation.cpp
https://bugs.webkit.org/show_bug.cgi?id=240383
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-05-13
Reviewed by Chris Dumez.
- Source/WebCore/rendering/PathOperation.cpp:
(WebCore::RayPathOperation::lengthForPath const):
Canonical link: https://commits.webkit.org/250531@main
- 10:05 AM Changeset in webkit [294161] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
[PrettyPatch] Support commit messages
https://bugs.webkit.org/show_bug.cgi?id=240386
<rdar://problem/93248835>
Rubber-stamped by Aakash Jain.
- Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:
(PrettyPatch.message_header): Match a commit message header.
(PrettyPatch.message_footer): Match a commit message footer.
(PrettyPatch.MESSAGE_HEADER_FORMATS): List of commit message headers.
(PrettyPatch.BUG_URL_RE): Regex to match bug urls in subject.
(PrettyPatch.MESSAGE_FOOTER_FORMATS): List of commit messagae footers.
(PrettyPatch.parse): Treat commit messages a new file named 'COMMIT_MESSAGE'.
Canonical link: https://commits.webkit.org/250530@main
- 9:31 AM Changeset in webkit [294160] by
-
- 17 edits2 adds in trunk/Source
Add UI-side layers for optionally indicating interaction regions
https://bugs.webkit.org/show_bug.cgi?id=240372
<rdar://problem/87170289>
Reviewed by Dean Jackson.
Source/WebCore:
- page/DebugPageOverlays.cpp:
(WebCore::pathsForRegion):
Move inline rect inflation into InteractionRegion so that all clients get it.
- page/Page.cpp:
(WebCore::Page::shouldBuildInteractionRegions const):
- page/Page.h:
- page/Frame.cpp:
(WebCore::Frame::invalidateContentEventRegionsIfNeeded):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::maintainsEventRegion const):
(WebCore::RenderLayerBacking::updateEventRegion):
If the ENABLE() and setting are both enabled, update event regions
due to possible interaction region changes. We could make this more
conservative later, but chances are high that most layers include
interaction regions.
For now, compute interaction regions only for the root layer.
In a future patch, we will adopt the normal fake paint mechanism
and maintain them on the layer that owns them.
- page/InteractionRegion.cpp:
(WebCore::regionForElement):
Move inline rect inflation into InteractionRegion so that all clients get it.
Limit interaction rects to half of the viewport. Ignore regions that are larger.
- page/InteractionRegion.h:
(WebCore::operator==): Added.
(WebCore::InteractionRegion::encode const):
(WebCore::InteractionRegion::decode):
Remove the isInline bit, since we only used it for rect inflation.
- rendering/EventRegion.cpp:
(WebCore::EventRegion::operator== const):
(WebCore::EventRegion::translate):
(WebCore::EventRegion::uniteInteractionRegions):
(WebCore::EventRegion::computeInteractionRegions):
- rendering/EventRegion.h:
(WebCore::EventRegion::interactionRegions const):
(WebCore::EventRegion::encode const):
(WebCore::EventRegion::decode):
Store interaction regions on EventRegion.
Source/WebKit:
- Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
(WebKit::RemoteLayerTreePropertyApplier::applyHierarchyUpdates):
Allow RemoteLayerTreeInteractionRegionLayers to add and maintain layers for interaction regions.
- SourcesCocoa.txt:
- UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.h: Added.
- UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm: Added.
(configureLayerForInteractionRegion):
(WebKit::interactionRegionForLayer):
(WebKit::isInteractionRegionLayer):
(WebKit::setInteractionRegion):
Box WebCore::InteractionRegion in a Objective-C object and store it on the layer.
Use this as a key to indicate that a given layer is an interaction region.
(WebKit::appendInteractionRegionLayersForLayer):
Make sure that interaction region layers are always at the end of the layer's sublayers array.
(WebKit::updateLayersForInteractionRegions):
Add new layers for interaction regions.
Maintain the same layer for regions that cover the same area.
Add a green wash if the defaultWKInteractionRegionDebugFillis set.
- WebKit.xcodeproj/project.pbxproj:
Source/WTF:
- Scripts/Preferences/WebPreferencesInternal.yaml:
Add a preference to toggle interaction region layers.
- 9:05 AM Changeset in webkit [294159] by
-
- 9 edits in branches/safari-7614.1.13-branch/Source
Versioning.
WebKit-7614.1.14
- 9:02 AM Changeset in webkit [294158] by
-
- 6 edits in trunk
Unreviewed, reverting r294113.
https://bugs.webkit.org/show_bug.cgi?id=240381
This bug needs to be addressed using a different approach
Reverted changeset:
"Mail compose: right clicking an image attachment selects it"
https://bugs.webkit.org/show_bug.cgi?id=240315
https://commits.webkit.org/r294113
- 7:54 AM Changeset in webkit [294157] by
-
- 2 edits in trunk/Source/WTF
False positive warning when building RefCounter test with GCC 12
https://bugs.webkit.org/show_bug.cgi?id=239338
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-05-13
Reviewed by Chris Dumez.
- Source/WTF/wtf/RefCounter.h:
(WTF::RefCounter<T>::Count::deref):
Canonical link: https://commits.webkit.org/250527@main
- 7:38 AM Changeset in webkit [294156] by
-
- 3 edits1 copy11 deletes in trunk/LayoutTests
Clean up some html/semantics/forms/ test expectations
https://bugs.webkit.org/show_bug.cgi?id=240344
Unreviewed test gardening.
Combine multiple files to reduce the number of platform specific expectations.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt.
- web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
LayoutTests:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt: Removed.
- platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: Removed.
- platform/mac/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt: Removed.
- platform/win/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: Removed.
- 4:41 AM Changeset in webkit [294155] by
-
- 2 edits in trunk/Source/WebCore
[GTK][WPE] Remove leftover for WINDOWS support in GraphicsContextGLGBM
https://bugs.webkit.org/show_bug.cgi?id=240314
GBM is a Linux technology we would need another sharing buffers
technology to add support in Windows. This is leftover from the
code copied originally.
Patch by Alejandro G. Castro <alex@igalia.com> on 2022-05-13
Reviewed by Žan Doberšek.
No new tests, we are just removing some compilation option.
- platform/graphics/gbm/GraphicsContextGLGBM.cpp:
(WebCore::GraphicsContextGLGBM::platformInitializeContext):
- 4:30 AM Changeset in webkit [294154] by
-
- 5 edits in trunk/Source
Unreviewed, non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=240369
Source/JavaScriptCore:
- runtime/DateConversion.cpp:
Source/WebCore:
- Modules/highlight/HighlightRegister.h:
- rendering/TextPainter.h:
- 2:25 AM Changeset in webkit [294153] by
-
- 60 edits1 copy1 move23 adds10 deletes in trunk/LayoutTests
Resync web-platform-tests/html/semantics/forms tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=240301
Reviewed by Tim Nguyen.
LayoutTests/imported/w3c:
Upstream commit: https://github.com/web-platform-tests/wpt/commit/23e7602b7784c758397308183f414bb99e0c622b
- resources/import-expectations.json:
- resources/resource-files.json:
- web-platform-tests/html/semantics/forms/beforeinput.tentative-expected.txt: Added.
- web-platform-tests/html/semantics/forms/beforeinput.tentative.html: Added.
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing.html:
- web-platform-tests/html/semantics/forms/constraints/support/validator.js:
(validator.run_test):
(validator.test_support_type): Deleted.
- web-platform-tests/html/semantics/forms/form-submission-0/enctypes-helper.js:
- web-platform-tests/html/semantics/forms/form-submission-0/getactionurl-expected.txt:
- web-platform-tests/html/semantics/forms/form-submission-0/getactionurl.html:
- web-platform-tests/html/semantics/forms/form-submission-0/multipart-formdata.window.js:
- web-platform-tests/html/semantics/forms/form-submission-0/resources/getactionurl-iframe.html: Added.
- web-platform-tests/html/semantics/forms/form-submission-0/resources/w3c-import.log:
- web-platform-tests/html/semantics/forms/form-submission-0/text-plain.window.js:
- web-platform-tests/html/semantics/forms/form-submission-0/urlencoded2.window.js:
- web-platform-tests/html/semantics/forms/textfieldselection/select-event-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/textfieldselection/select-event.html: Removed.
- web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-textarea-expected.txt:
- web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-textarea.html:
- web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application.html:
- web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setRangeText-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setRangeText.html: Removed.
- web-platform-tests/html/semantics/forms/textfieldselection/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-input-element/cloning-steps-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/cloning-steps.html:
- web-platform-tests/html/semantics/forms/the-input-element/datetime-local-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/datetime-local-trailing-zeros-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-input-element/datetime-local-trailing-zeros.html: Added.
- web-platform-tests/html/semantics/forms/the-input-element/datetime-local.html:
- web-platform-tests/html/semantics/forms/the-input-element/input-untrusted-key-event-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-input-element/input-untrusted-key-event.html: Added.
- web-platform-tests/html/semantics/forms/the-input-element/input-whitespace-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-input-element/input-whitespace.html: Added.
- web-platform-tests/html/semantics/forms/the-input-element/invalid-datalist-options-crash.html: Added.
- web-platform-tests/html/semantics/forms/the-input-element/large-step-crash.html: Added.
- web-platform-tests/html/semantics/forms/the-input-element/show-picker-cross-origin-iframe.html:
- web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-input-element/show-picker-disabled-readonly.html: Added.
- web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-input-element/show-picker-user-gesture.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/show-picker.html.
- web-platform-tests/html/semantics/forms/the-input-element/type-change-state.html:
- web-platform-tests/html/semantics/forms/the-input-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-label-element/proxy-modifier-click-to-associated-element.tentative.html:
- web-platform-tests/html/semantics/forms/the-label-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-ask-for-reset.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-form-state-restore.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-form-submission.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-keyboard.tentative-expected.txt:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-keyboard.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-labels.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-many-options.tentative-expected.txt:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-many-options.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-nested.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-option-arbitrary-content-displayed-ref.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-option-arbitrary-content-displayed.tentative-expected.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-option-arbitrary-content-displayed.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-option-arbitrary-content-not-displayed.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-option-focusable.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-parts-structure.tentative-expected.txt:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-parts-structure.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-popup-position-with-zoom.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-popup-position.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-popup.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-required-attribute.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-shadow-root-replacement.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/selectmenu-value-selectedOption.tentative.html:
- web-platform-tests/html/semantics/forms/the-selectmenu-element/support/cat.png: Removed.
- web-platform-tests/html/semantics/forms/the-selectmenu-element/support/w3c-import.log:
- web-platform-tests/html/semantics/forms/w3c-import.log:
LayoutTests:
- TestExpectations:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime-local-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime-local-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime-local-expected.txt: Removed.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime-local-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime-local-expected.txt.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime-local-trailing-zeros-expected.txt: Added.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/notifications/idlharness.https.any-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/datetime-local-expected.txt: Removed.
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
- tests-options.json:
- 2:14 AM Changeset in webkit [294152] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Properly handle DMABuf-containing GstBuffers with missing DMABuf GstCaps feature
https://bugs.webkit.org/show_bug.cgi?id=240374
Reviewed by Chris Lord.
To detect DMABuf-backed GstBuffers, for now we relied on the appropriate
feature being present on the related GstCaps object. This doesn't cover
every decoder which for one reason or another isn't specifying their
caps like this.
For those cases, we have to do a weaker but sufficient check on the
base GstMemory object contained in the GstBuffer, namely test that it
comes from a DMABuf-capable allocator, through using the
gst_is_dmabuf_memory() function. When true, we can proceed on handling
the buffer and its contained DMABuf object.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):
- 2:07 AM Changeset in webkit [294151] by
-
- 4 edits1 add in trunk/Source/WebCore
[Linux][GBM] Provide utility function for construction of eglCreateImage attributes data
https://bugs.webkit.org/show_bug.cgi?id=240373
Reviewed by Chris Lord.
Provide DMABufEGLUtilities::constructEGLCreateImageAttributes() helper
function that unifies the construction of the EGLImage creation
attributes. For a given DMABufObject and plane index, a Vector of EGLint
attributes for a single-plane EGLImage object is returned, optionally
including the modifier value if requested (when the EGL implementation,
through the necessary extensions, supports modifiers).
The new function replaces duplicated code in GraphicsContextGLGBM and
TextureMapperPlatformLayerProxyDMABuf.
- platform/TextureMapper.cmake:
- platform/graphics/gbm/DMABufEGLUtilities.h: Added.
(WebCore::DMABufEGLUtilities::constructEGLCreateImageAttributes):
- platform/graphics/gbm/GraphicsContextGLGBM.cpp:
(WebCore::GraphicsContextGLANGLE::makeContextCurrent):
- platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp:
(WebCore::TextureMapperPlatformLayerProxyDMABuf::DMABufLayer::createEGLImageData):
- 1:36 AM Changeset in webkit [294150] by
-
- 2 edits in trunk/Tools
[Flatpak SDK] Sandbox access to pipewire socket
https://bugs.webkit.org/show_bug.cgi?id=240338
Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-13
Reviewed by Adrian Perez de Castro.
Starting from version 0.5 of Bubblewrap bind mounts behavior slightly changed. Without this
patch the pipewire socket wouldn't be available from the default XDG runtime directory.
- flatpak/webkit-bwrap:
Canonical link: https://commits.webkit.org/250520@main
- 1:31 AM Changeset in webkit [294149] by
-
- 1 edit5 adds in trunk/LayoutTests
[GTK] Unreviewed test gardening, follow-up to r294148
Add removed baselines in corresponding directory.
- platform/glib/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/xhr/getresponseheader.any-expected.txt: Added.
- platform/glib/imported/w3c/web-platform-tests/xhr/getresponseheader.any.worker-expected.txt: Added.
- 1:22 AM Changeset in webkit [294148] by
-
- 1 edit3 deletes in trunk/LayoutTests
[GTK] Unreviewed test gardening, follow-up to r294142
Remove wrongly generated baselines. Parent directoy has the same name
as baseline and that ends up in an Exception error while running the
layout-tests.
- platform/glib/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt/location_hash-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/xhr/getresponseheader.any-expected.txt/getresponseheader.any-expected.txt: Removed.
- platform/glib/imported/w3c/web-platform-tests/xhr/getresponseheader.any.worker-expected.txt/getresponseheader.any.worker-expected.txt: Removed.
- 1:13 AM Changeset in webkit [294147] by
-
- 14 edits in trunk/Source/WebCore
Remove WorkerLoaderProxy::postTaskForModeToWorkerOrWorkletGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=240299
Reviewed by Alex Christensen.
WorkerLoaderProxy::postTaskForModeToWorkerOrWorkletGlobalScope is no longer needed given we have
ScriptExecutionContext infrastructure that can be used instead.
Covered by existing tests.
- Modules/webaudio/AudioWorkletMessagingProxy.cpp:
(WebCore::AudioWorkletMessagingProxy::postTaskForModeToWorkerOrWorkletGlobalScope): Deleted.
- Modules/webaudio/AudioWorkletMessagingProxy.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::WorkerThreadableWebSocketChannel::Peer::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessage):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpdateBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpgradeURL):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::postTaskTo):
(WebCore::ScriptExecutionContext::postTaskForModeToWorkerOrWorklet):
- dom/ScriptExecutionContext.h:
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
(WebCore::m_contextIdentifier):
(WebCore::WorkerThreadableLoader::MainThreadBridge::notifyIsDone):
(WebCore::WorkerThreadableLoader::MainThreadBridge::redirectReceived):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishTiming):
- loader/WorkerThreadableLoader.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerOrWorkletGlobalScope): Deleted.
- workers/WorkerMessagingProxy.h:
- workers/service/context/ServiceWorkerThreadProxy.h:
- workers/shared/context/SharedWorkerThreadProxy.h:
- 12:54 AM Changeset in webkit [294146] by
-
- 3 edits in trunk/LayoutTests
[GLIB][WPE] Unreviewed test gardening, move test image failures to GLIB
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- 12:29 AM Changeset in webkit [294145] by
-
- 14 edits in trunk/Source
Simplify the usage of DrawGlyphsRecorder
https://bugs.webkit.org/show_bug.cgi?id=240363
Reviewed by Myles Maxfield.
Move the DeconstructDrawGlyphs switch from inside DrawGlyphsRecorder to
DisplayList::Recorder, so that DrawGlyphsRecorder is only ever used when deconstructing
glyphs.
Also, ensure that the only time that glyph deconstruction is enabled is when
recording display lists via RemoteDisplayListRecorderProxy. There's no reason for
paintAttachmentText() to need glyph deconstruction.
Source/WebCore:
This is a small perf improvement on the MotionMark Design subtest.
- platform/graphics/DrawGlyphsRecorder.h:
(WebCore::DrawGlyphsRecorder::deconstructDrawGlyphs const): Deleted.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::displayListForTextRun const):
- platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:
(WebCore::DrawGlyphsRecorder::DrawGlyphsRecorder):
(WebCore::DrawGlyphsRecorder::drawGlyphs):
(WebCore::DrawGlyphsRecorder::drawNativeText):
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::Recorder):
(WebCore::DisplayList::Recorder::drawGlyphs):
(WebCore::DisplayList::Recorder::drawGlyphsAndCacheFont):
- platform/graphics/displaylists/DisplayListRecorder.h:
- platform/graphics/displaylists/DisplayListRecorderImpl.cpp:
(WebCore::DisplayList::RecorderImpl::RecorderImpl):
- platform/graphics/displaylists/DisplayListRecorderImpl.h:
- platform/graphics/harfbuzz/DrawGlyphsRecorderHarfBuzz.cpp:
(WebCore::DrawGlyphsRecorder::DrawGlyphsRecorder):
- platform/graphics/win/DrawGlyphsRecorderWin.cpp:
(WebCore::DrawGlyphsRecorder::DrawGlyphsRecorder):
- rendering/RenderThemeIOS.mm:
(WebCore::paintAttachmentText):
Source/WebKit:
This is a small perf improvement on the MotionMark Design subtest.
- WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
(WebKit::RemoteDisplayListRecorderProxy::RemoteDisplayListRecorderProxy):
(WebKit::m_renderingBackend):
- WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
- 12:26 AM Changeset in webkit [294144] by
-
- 2 edits in trunk/Source/WebCore
Remove unneeded check in HTMLSlotElement::assignedNodes()
https://bugs.webkit.org/show_bug.cgi?id=240340
Reviewed by Ryosuke Niwa.
- html/HTMLSlotElement.cpp:
(WebCore::HTMLSlotElement::assignedNodes const):
Canonical link: https://commits.webkit.org/250514@main
- 12:19 AM Changeset in webkit [294143] by
-
- 31 edits3 moves1 add3 deletes in trunk/LayoutTests
[WPE] Unreviewed test gardening, update baselines
- platform/glib/TestExpectations:
- platform/glib/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt.
- platform/glib/fast/text/international/bidi-layout-across-linebreak-expected.txt: Renamed from LayoutTests/platform/gtk/fast/text/international/bidi-layout-across-linebreak-expected.txt.
- platform/glib/fast/text/international/hindi-spacing-expected.txt: Renamed from LayoutTests/platform/gtk/fast/text/international/hindi-spacing-expected.txt.
- platform/gtk/TestExpectations:
- platform/wpe/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/wpe/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
- platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt: Removed.
- platform/wpe/css3/flexbox/button-expected.txt:
- platform/wpe/fast/block/float/float-avoidance-expected.txt:
- platform/wpe/fast/block/lineboxcontain/glyphs-expected.txt:
- platform/wpe/fast/block/positioning/inline-block-relposition-expected.txt:
- platform/wpe/fast/css-generated-content/initial-letter-basic-expected.txt:
- platform/wpe/fast/css-generated-content/initial-letter-border-padding-expected.txt:
- platform/wpe/fast/css-generated-content/initial-letter-raised-expected.txt:
- platform/wpe/fast/css-generated-content/initial-letter-sunken-expected.txt:
- platform/wpe/fast/css/continuationCrash-expected.txt:
- platform/wpe/fast/css/margin-top-bottom-dynamic-expected.txt:
- platform/wpe/fast/css/rtl-ordering-expected.txt:
- platform/wpe/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
- platform/wpe/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
- platform/wpe/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
- platform/wpe/fast/html/details-replace-summary-child-expected.txt:
- platform/wpe/fast/html/details-replace-text-expected.txt:
- platform/wpe/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/wpe/fast/overflow/scrollRevealButton-expected.txt:
- platform/wpe/fast/replaced/replaced-breaking-expected.txt:
- platform/wpe/fast/replaced/width100percent-button-expected.txt:
- platform/wpe/fast/table/003-expected.txt:
- platform/wpe/fast/table/append-cells2-expected.txt:
- platform/wpe/fast/table/remove-td-display-none-expected.txt:
- platform/wpe/fast/text/emoji-expected.txt:
- platform/wpe/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
- platform/wpe/fast/text/international/bidi-override-expected.txt:
- platform/wpe/fast/text/international/hindi-spacing-expected.txt: Removed.
- platform/wpe/fast/text/orientation-sideways-expected.txt:
May 12, 2022:
- 11:24 PM Changeset in webkit [294142] by
-
- 2 edits1 copy2 moves5 adds1 delete in trunk/LayoutTests
[GTK] Unreviewed test gardening, fix missing test results.
- platform/glib/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt/location_hash-expected.txt: Renamed from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt.
- platform/glib/imported/w3c/web-platform-tests/xhr/getresponseheader.any-expected.txt/getresponseheader.any-expected.txt: Renamed from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/xhr/getresponseheader.any-expected.txt.
- platform/glib/imported/w3c/web-platform-tests/xhr/getresponseheader.any.worker-expected.txt/getresponseheader.any.worker-expected.txt: Renamed from LayoutTests/platform/wpe/imported/w3c/web-platform-tests/xhr/getresponseheader.any.worker-expected.txt.
- platform/gtk/TestExpectations:
- 10:04 PM Changeset in webkit [294141] by
-
- 12 edits in trunk
ARIA reflection for FrozenArray<Element> attributes
https://bugs.webkit.org/show_bug.cgi?id=239853
<rdar://problem/92797836>
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Update expectations with the new PASS lines.
- web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt:
Source/WebCore:
Implement ARIA reflection for attributes that refer to a list of Elements:
aria-controls, aria-describedby, aria-details, aria-flowto,
aria-labelledby and aria-owns.
For the properties names this patch uses "Elements" suffix:
ariaControlsElements, ariaDescribedByElements, ariaDescribedByElements,
ariaFlowToElements, ariaLabelledByElements, ariaOwnsElements
this matches Chromium implementation and AOM explainer, but not AOM spec:
https://github.com/w3c/aria/issues/1732
- accessibility/AriaAttributes.idl: Add the new properties under
AriaReflectionForElementReferencesEnabled runtime flag.
- bindings/scripts/CodeGenerator.pm:
(GetterExpression): Add function for FrozenArray<Element> properties.
(SetterExpression): Ditto.
- bindings/scripts/test/JS/JSTestObj.cpp: Add tests.
(WebCore::JSTestObjDOMConstructor::construct):
(WebCore::jsTestObj_reflectedElementsArrayAttrGetter):
(WebCore::JSC_DEFINE_CUSTOM_GETTER):
(WebCore::setJSTestObj_reflectedElementsArrayAttrSetter):
(WebCore::JSC_DEFINE_CUSTOM_SETTER):
- bindings/scripts/test/TestObj.idl: Add example attribute.
- dom/Element.cpp:
(WebCore::isElementsArrayReflectionAttribute): New utility method to
identify the attributes that refer to a list of Elements.
(WebCore::Element::attributeChanged): Include check for elements
array.
(WebCore::Element::getElementsArrayAttribute const): Implement getter.
(WebCore::Element::setElementsArrayAttribute): Implement setter.
- dom/Element.h: Remove FIXME in ExplicitlySetAttrElementsMap as now
it stores more than one element. Add headers for getter and setter.
LayoutTests:
Update test so it identifies the FrozenArray<Element> attributes.
- accessibility/ARIA-reflection-expected.txt:
- accessibility/ARIA-reflection.html:
- 8:38 PM Changeset in webkit [294140] by
-
- 4 edits4 deletes in trunk/LayoutTests
[GTK] Unreviewed test gardening, update tests expected to fail but passed
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- platform/gtk/imported/w3c/web-platform-tests/mathml/presentation-markup/tables/table-002-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/not-participating-to-parent-layout-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002-expected.txt: Removed.
- platform/wpe/TestExpectations:
- 7:12 PM Changeset in webkit [294139] by
-
- 3 edits in trunk/Source/WTF
-Wattributes warnings from AtomString.cpp and WTFString.cpp
https://bugs.webkit.org/show_bug.cgi?id=240358
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-05-12
Reviewed by Yusuke Suzuki.
- Source/WTF/wtf/text/AtomString.cpp:
- Source/WTF/wtf/text/WTFString.cpp:
Canonical link: https://commits.webkit.org/250509@main
- 6:49 PM Changeset in webkit [294138] by
-
- 14 edits in trunk/Source/WebCore
Quirk Flightaware.com to use the older number serialization path.
https://bugs.webkit.org/show_bug.cgi?id=240320
Reviewed by Simon Fraser.
Ensures that serialization of matrix() CSS properties uses the older serialization (which
matches ECMA script serialization) since this site expects these to be comparable as strings.
No new tests, since this is a site-specific quirk.
- css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::customCSSText const):
- css/CSSFunctionValue.h:
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::formatNumberValue const):
(WebCore::CSSPrimitiveValue::customCSSText const):
- css/CSSPrimitiveValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::cssText const):
- css/CSSValue.h:
(WebCore::CSSValue::CSSValue):
- css/CSSValueList.cpp:
(WebCore::CSSValueList::customCSSText const):
- css/CSSValueList.h:
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):
- css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue const):
- css/StyleProperties.h:
- page/Quirks.cpp:
(WebCore::Quirks::needsFlightAwareSerializationQuirk const):
- page/Quirks.h:
- 6:41 PM Changeset in webkit [294137] by
-
- 2 edits in trunk/Source/WebKit
-Wunused-result in WebCoreSupport/WebContextMenuClient.cpp
https://bugs.webkit.org/show_bug.cgi?id=240364
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-05-12
Reviewed by Chris Dumez.
- Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):
Canonical link: https://commits.webkit.org/250507@main
- 6:09 PM Changeset in webkit [294136] by
-
- 13 edits in branches/safari-7614.1.13-branch/Source
Cherry-pick r293994. rdar://problem/87157773
[iOS] Adjust some viewport behaviors when multitasking mode is enabled
https://bugs.webkit.org/show_bug.cgi?id=240151
rdar://87157773
Reviewed by Tim Horton.
Add a new ViewportConfiguration flag to prefer horizontal scrolling over shrinking to fit when the view layout
size falls under the current "default desktop webpage" of 980pt. See WebKit changes for more details.
- page/ViewportConfiguration.cpp: (WebCore::ViewportConfiguration::initialScaleFromSize const): (WebCore::ViewportConfiguration::webpageParameters): (WebCore::ViewportConfiguration::imageDocumentParameters):
Pull the magic value representing the "assumed width of most desktop webpages" (980) out into a named constant,
defaultDesktopViewportWidth, so that we can consult it when computing the initial scale.
(WebCore::ViewportConfiguration::description const):
- page/ViewportConfiguration.h: (WebCore::ViewportConfiguration::setPrefersHorizontalScrollingBelowDesktopViewportWidths): [iOS] Adjust some viewport behaviors when multitasking mode is enabled https://bugs.webkit.org/show_bug.cgi?id=240151 rdar://87157773
Reviewed by Tim Horton.
Make some adjustments to viewport behaviors when multitasking mode is enabled. See the comments below for more
details. There are no changes in behavior when multitasking mode is disabled; tests for the new behaviors in
multitasking mode will be added in a subsequent patch.
- Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
Add plumbing to inform the web process when "multitasking mode" state changes; we use this bit in WebPage to
determine whether or not we should use multitasking mode viewport behaviors (see below).
- UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _registerForNotifications]): (-[WKWebView didMoveToWindow]): (-[WKWebView _multitaskingModeDidChange:]):
Send IPC to WebPage in these two places, to keep "multitasking mode" state in sync with the native view.
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
Make a minor adjustment here to ignore
oldWebViewWidthInContentViewCoordinateswhen computing a target scale
to zoom to when performing animated resize, in multitasking mode. This is required to prevent us from zooming
in excessively when the width of the view increases, since we'd otherwise attempt to keep the same content in
the page visible by zooming in (for instance, if an image covers most of the visual viewport at a lower view
width, thismin()logic would cause us to zoom in, such that the image would still cover most of the viewport
at a larger width). This behavior is undesirable in multitasking mode.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): (WebKit::WebPageProxy::setIsInMultitaskingMode):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::didCommitLoad): (WebKit::WebPage::setIsInMultitaskingMode):
Add plumbing to set the
m_isInMultitaskingModeflag on WebPage, and update the viewport configuration flag to
prefer horizontal scrolling below 980pt.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::scaleAfterViewportWidthChange):
Refactor a bit of code here (without changing any behaviors), to make it a bit clearer:
- Rename
userHasChangedPageScaleFactortoscaleToFitContentto better describe how this flag affects the
adjusted target scale during dynamic resize.
- Make the log messages specific to both branches, and also log the adjusted viewport scale instead of the
(currently unused) given
scalein the non-scaleToFitContentcodepath.
(WebKit::WebPage::dynamicViewportSizeUpdate):
Make another "multitasking mode viewport behavior" adjustment here by maintaining the initial scale (only if the
viewport was already at initial scale) when performing dynamic viewport size updates. By default, we currently
adjust the scale such that the same content is still visible at the new viewport size; however, when allowing
horizontal scrolling, this causes us to zoom in excessively when making the window width larger. Instead, when
multitasking mode is enabled, we should try to preserve initial scale when changing window size, such that only
the horizontal scroll amount changes.
(WebKit::WebPage::usesMultitaskingModeViewportBehaviors const):
Add a helper method to encapsulate whether or not multitasking mode viewport behaviors should be used; this
should be true only when both desktop-class viewport behaviors are active, *and* multitasking mode is also
active.
Canonical link: https://commits.webkit.org/250431@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 6:02 PM Changeset in webkit [294135] by
-
- 2 edits in trunk/Source/WebCore
[WebAuthn] Remove document focus requirement for conditional mediation requests
https://bugs.webkit.org/show_bug.cgi?id=240361
rdar://problem/93201070
Reviewed by Brent Fulgham.
This is necessary so conditional mediation requests work when you open a page in
a new tab. Conditional mediation requests do not support security keys and the
request will be aborted if conditional mediation is not available.
- Modules/credentialmanagement/CredentialsContainer.cpp:
(WebCore::CredentialsContainer::get):
- 5:55 PM Changeset in webkit [294134] by
-
- 4 edits in branches/safari-7614.1.13-branch/Source
Cherry-pick r294122. rdar://problem/93191958
[WebAuthn] Include backup state in authenticatorData
https://bugs.webkit.org/show_bug.cgi?id=240353
rdar://problem/93191958
Reviewed by Brent Fulgham.
Source/WebCore:
Add flags for credential backup state: https://github.com/w3c/webauthn/pull/1695
- Modules/webauthn/WebAuthenticationConstants.h:
Source/WebKit:
This patch adds support for backup state flags, which will be added to
the Web Authentication spec soon via https://github.com/w3c/webauthn/pull/1695
These flags are set whenever a credential is "backup eligible" and "backed up"
hinting to RPs that the credential is "durable" and may persist through device
restores. This is useful for RPs that may choose to offer to remove the user
password if a credental is in this state.
- UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticatorInternal::authDataFlags): (WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification): (WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:55 PM Changeset in webkit [294133] by
-
- 6 edits in branches/safari-7614.1.13-branch
Cherry-pick r294088. rdar://problem/93134975
ImageAnalysisQueue should extract and analyze images inside of subframes
https://bugs.webkit.org/show_bug.cgi?id=240328
rdar://93134975
Reviewed by Tim Horton.
Teach
ImageAnalysisQueueto recursively find all images on the page (including images in of subframe content)
and queue them for analysis. To do this, we refactorenqueueAllImagesto call into a new recursive helper
method,enqueueAllImagesRecursive, to look for more candidate image elements that exist inside frame owner
elements (e.g.iframe).
Test: ImageAnalysisTests.AnalyzeImagesInSubframes
- page/ImageAnalysisQueue.cpp: (WebCore::ImageAnalysisQueue::enqueueAllImages): (WebCore::ImageAnalysisQueue::enqueueAllImagesRecursive):
- page/ImageAnalysisQueue.h: ImageAnalysisQueue should extract and analyze images inside of subframes https://bugs.webkit.org/show_bug.cgi?id=240328 rdar://93134975
Reviewed by Tim Horton.
Add an API test to verify that we extract and analyze images inside of subframes, in addition to images in the
main frame.
- TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm: (TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/multiple-images.html:
Canonical link: https://commits.webkit.org/250478@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:55 PM Changeset in webkit [294132] by
-
- 14 edits in branches/safari-7614.1.13-branch
Cherry-pick r294084. rdar://problem/93036066
Re-send connection configuration if webpushd dies
https://bugs.webkit.org/show_bug.cgi?id=240286
Reviewed by Geoffrey Garen.
If webpushd dies, all future communication with it from NetworkProcess fails because we
don't re-send the connection configuration to the daemon after the connection is
interrupted. This manifests itself as an "invalid sender" AbortError from various
PushManager methods because webpushd doesn't know the bundle identifier of the UIProcess it
is working on behalf of.
To fix this, I moved the responsibility for sending the configuration from
NetworkNotificationManager to WebPushD::Connection, and WebPushD::Connection re-sends the
configuration every time a new XPC connection is created.
Covered by a new API test.
Source/WebKit:
- NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::NetworkSession):
- NetworkProcess/NetworkSession.h: (WebKit::NetworkSession::webPushDaemonUsesMockBundlesForTesting const): Deleted.
- NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm: (WebKit::WebPushD::Connection::newConnectionWasInitialized const):
- NetworkProcess/Notifications/NetworkNotificationManager.cpp: (WebKit::NetworkNotificationManager::NetworkNotificationManager): (WebKit::NetworkNotificationManager::sendMessage const): (WebKit::NetworkNotificationManager::sendMessageWithReply const): (WebKit::NetworkNotificationManager::maybeSendConnectionConfiguration const): Deleted.
- NetworkProcess/Notifications/NetworkNotificationManager.h:
- NetworkProcess/Notifications/WebPushDaemonConnection.cpp: (WebKit::WebPushD::Connection::Connection):
- NetworkProcess/Notifications/WebPushDaemonConnection.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm: (TestWebKitAPI::testWebPushDaemonPList): (TestWebKitAPI::setUpTestWebPushD): (TestWebKitAPI::restartTestWebPushD): (TestWebKitAPI::WebPushDTest::WebPushDTest):
- TestWebKitAPI/cocoa/DaemonTestUtilities.h:
- TestWebKitAPI/cocoa/DaemonTestUtilities.mm: (TestWebKitAPI::restartService):
Canonical link: https://commits.webkit.org/250475@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:55 PM Changeset in webkit [294131] by
-
- 4 edits in branches/safari-7614.1.13-branch/Source
Cherry-pick r293968. rdar://problem/92892014
[macOS] REGRESSION (r293825): Find highlight snapshots are incorrectly scaled
https://bugs.webkit.org/show_bug.cgi?id=240203
rdar://92892014
Reviewed by Tim Horton.
Source/WebCore:
takeSnapshots() depends on the snapshot ImageBuffer::resolutionScale() to
set the size of the TextIndicatorData image. r293825 scaled the size of
the ImageBuffer before creation and moved the scaling to the GraphicsContext.
So we have correct scaled pixels but the resolutionScale is 1. So we get
enlarged incorrect image.
The fix is to revert r293825 and fix the iOS snapshot without having to
change snapshotFrameRectWithClip().
- page/FrameSnapshotting.cpp: (WebCore::snapshotFrameRectWithClip):
Source/WebKit:
In getShareableBitmapForImageBufferWithQualifiedIdentifier(), we used to
pass the backendSize as the srcRect and the backendSize as the destRect
to GraphicsContext::drawImageBuffer(). The backendSize is the logicalSize
scaled by the resolutionScale. But in ImageBufferCGBackend::draw() we
scale the srcRect by the resolutionScale one more time. This double-
scaled srcRect draws a srcRect whose size = backendSize * resolutionScale
to a destRect whose size = backendSize. And this results in shrinking the
desired snapshot image by 1 / resolutionScale.
- GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::getShareableBitmapForImageBufferWithQualifiedIdentifier):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:55 PM Changeset in webkit [294130] by
-
- 2 edits in branches/safari-7614.1.13-branch/Source/WebKit
Cherry-pick r293954. rdar://problem/92885915
Do WebKitAdditions header replacement only when a specific environment variable is set
https://bugs.webkit.org/show_bug.cgi?id=240210
<rdar://92885915>
Reviewed by Tim Horton.
- Source/WebKit/Configurations/WebKit.xcconfig:
- Source/WebKit/mac/replace-webkit-additions-includes.py: (check_should_do_replacement): (main): (is_supported_os): Deleted.
Canonical link: https://commits.webkit.org/250400@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:55 PM Changeset in webkit [294129] by
-
- 13 edits2 adds in branches/safari-7614.1.13-branch
Cherry-pick r293951. rdar://problem/92635604
Don't propagate GraphicsContextState change bits into TextPainter's glyph display list recorder
https://bugs.webkit.org/show_bug.cgi?id=239952
<rdar://problem/92635604>
Source/WebCore:
Reviewed by Said Abou-Hallawa and Antti Koivisto.
In FontCascade::displayListForTextRun, we create a
DisplayList::Recorder, then call drawGlyphBuffer. We initialize the
DisplayList::Recorder with the GraphicsContextState of the
GraphicsContext we're drawing to. Just before this, we will have set the
current fill color on that GraphicsContext.
When GPUP DOM rendering is disabled, GraphicsContextCG responds to
setFillColor etc. by updating GraphicsContextState, including setting
the Change flag, then immediately updating the CGContext, and clearing
the Change flag.
But when GPUP DOM rendering is enabled, the GraphicsContext is a
DisplayList::Recorder for the layer we're painting in to. Because
DisplayList::Recorder applies its state changes lazily, it can be in the
situation where its GraphicsContextState has had the fill brush changed,
and the Change flag is still set. So DisplayList::Recorder starts off
with a GraphicsContextState with unapplied changes in it. We end up in
DisplayList::Recorder::drawGlyphsAndCacheFont, which calls
appendStateChangeItemIfNecessary, which sees that the Change bit is set,
and generates a SetInlineFillColor display list item, which is
recorded and then replayed the next time the same text is painted.
This recorded fill color then may be wrong for the next TextPainter
that wants to reuse the cached glyph display list.
Display list recorders should never be initialized with a
GraphicsContextState that has change flags set on it. We can assert
this, then make FontCascade explicitly clear those flags on the state
object it passes in to the DisplayList::Recorder.
Test: fast/text/glyph-display-list-color.html
- platform/graphics/FontCascade.cpp: (WebCore::FontCascade::displayListForTextRun const):
- platform/graphics/GraphicsContextState.cpp: (WebCore::GraphicsContextState::cloneForRecording const):
- platform/graphics/GraphicsContextState.h:
- platform/graphics/displaylists/DisplayListRecorder.cpp: (WebCore::DisplayList::Recorder::Recorder):
Add setForceUseGlyphDisplayListForTesting and
cachedGlyphDisplayListsForTextNode functions on Internal for the
test to use:
- rendering/GlyphDisplayListCache.h: (WebCore::GlyphDisplayListCache::getIfExists):
- rendering/TextPainter.cpp: (WebCore::TextPainter::shouldUseGlyphDisplayList): (WebCore::TextPainter::setForceUseGlyphDisplayListForTesting): (WebCore::TextPainter::cachedGlyphDisplayListsForTextNodeAsText):
- rendering/TextPainter.h: (WebCore::TextPainter::glyphDisplayListIfExists):
- testing/Internals.cpp: (WebCore::Internals::setForceUseGlyphDisplayListForTesting): (WebCore::Internals::cachedGlyphDisplayListsForTextNode):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Reviewed by Antti Koivisto.
- fast/text/glyph-display-list-color-expected.txt: Added.
- fast/text/glyph-display-list-color.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:31 PM Changeset in webkit [294128] by
-
- 4 edits in trunk/Source/WebCore
TextBoxPainter::paintForeground: painting text with no marking/decoration should be simple
https://bugs.webkit.org/show_bug.cgi?id=240319
Reviewed by Simon Fraser.
Let's have a fast codepath for regular, simple text painting.
- rendering/StyledMarkedText.cpp:
(WebCore::StyledMarkedText::computeStyleForUnmarkedMarkedText):
(WebCore::computeStyleForUnmarkedMarkedText): Deleted.
- rendering/StyledMarkedText.h:
(WebCore::StyledMarkedText::StyledMarkedText):
(WebCore::StyledMarkedText::style):
- rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::paintBackground):
(WebCore::TextBoxPainter::paintForegroundAndDecorations):
- 5:05 PM Changeset in webkit [294127] by
-
- 3 edits in branches/safari-7614.1.13-branch/Source/WebKit
Cherry-pick r294126. rdar://problem/93208265
Revert r293861
https://bugs.webkit.org/show_bug.cgi?id=239977
<rdar://93208265>
Apparently it is still needed on trunk
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::createWebSocketTask):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:43 PM Changeset in webkit [294126] by
-
- 3 edits in trunk/Source/WebKit
Revert r293861
https://bugs.webkit.org/show_bug.cgi?id=239977
<rdar://93208265>
Apparently it is still needed on trunk
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::createWebSocketTask):
- 3:32 PM Changeset in webkit [294125] by
-
- 2 edits in trunk
Unreviewed, revert r284894 as it caused issues with printing and reader mode
https://bugs.webkit.org/show_bug.cgi?id=240355
<rdar://92538667>
Revert r284894 as it caused issues with printing and reader mode.
Canonical link: https://commits.webkit.org/250503@main
- 2:57 PM Changeset in webkit [294124] by
-
- 2 edits in trunk/Source/WebCore
StorageMap::removeItem may fail to remove item from map
https://bugs.webkit.org/show_bug.cgi?id=239982
rdar://80891555
- storage/StorageMap.cpp:
(WebCore::StorageMap::removeItem):
Address post-landing review comment from Darin.
- 2:56 PM Changeset in webkit [294123] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r293971 - [Nicosia] Canvas animations don't work with threaded rendering
https://bugs.webkit.org/show_bug.cgi?id=227760
<rdar://problem/80588913>
Reviewed by Adrian Perez de Castro.
Implement Nicosia::CairoOperationRecorder::draImageBuffer(), which is required in order to paint
canvas contents into a GraphicsContext.
- platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
(Nicosia::CairoOperationRecorder::drawImageBuffer):
- 2:54 PM WebKitGTK/2.36.x edited by
- (diff)
- 2:51 PM Changeset in webkit [294122] by
-
- 4 edits in trunk/Source
[WebAuthn] Include backup state in authenticatorData
https://bugs.webkit.org/show_bug.cgi?id=240353
rdar://problem/93191958
Reviewed by Brent Fulgham.
Source/WebCore:
Add flags for credential backup state: https://github.com/w3c/webauthn/pull/1695
- Modules/webauthn/WebAuthenticationConstants.h:
Source/WebKit:
This patch adds support for backup state flags, which will be added to
the Web Authentication spec soon via https://github.com/w3c/webauthn/pull/1695
These flags are set whenever a credential is "backup eligible" and "backed up"
hinting to RPs that the credential is "durable" and may persist through device
restores. This is useful for RPs that may choose to offer to remove the user
password if a credental is in this state.
- UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticatorInternal::authDataFlags):
(WebKit::LocalAuthenticator::continueMakeCredentialAfterUserVerification):
(WebKit::LocalAuthenticator::continueGetAssertionAfterUserVerification):
- 2:30 PM Changeset in webkit [294121] by
-
- 2 edits in trunk
Add GitHub account to contributors.json and update expertise field
https://bugs.webkit.org/show_bug.cgi?id=240360
Unreviewed.
- metadata/contributors.json:
- 2:14 PM Changeset in webkit [294120] by
-
- 1 copy in tags/WebKit-7614.1.12.3
Tag WebKit-7614.1.12.3.
- 2:06 PM Changeset in webkit [294119] by
-
- 9 edits in branches/safari-7614.1.13-branch/Source
Versioning.
WebKit-7614.1.13.5
- 1:58 PM Changeset in webkit [294118] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r281791): [iOS] WKWebView cannot load local .log file
https://bugs.webkit.org/show_bug.cgi?id=239591
<rdar://problem/92442408>
Reviewed by Geoffrey Garen.
The refactoring in Bug 229414 did not retain the old behavior on iOS where local
files (which do not get a MIME type assigned by CFNetwork) passed through the
same 'preferredMIMETypeForFileExtensionFromUTType' logic we use on macOS.
- platform/network/ios/WebCoreURLResponseIOS.mm:
(WebCore::adjustMIMETypeIfNecessary):
- 1:15 PM Changeset in webkit [294117] by
-
- 4 edits in trunk
Make if-domain and unless-domain regexes only look at URL hosts
https://bugs.webkit.org/show_bug.cgi?id=240199
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-12
Reviewed by John Wilander.
Source/WebCore:
In bug 234126 I moved how if-domain and unless-domain are done by translating them into a regex.
I overlooked that a domain can be in the path. If we get to '/' then we are at the end of the host.
Covered by an API test.
- contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::getDomainList):
Tools:
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::TEST_F):
- 1:08 PM Changeset in webkit [294116] by
-
- 1 edit in trunk/Tools/CISupport/build-webkit-org/steps.py
[build.webkit.org] Upload minified archives while building custom revision
https://bugs.webkit.org/show_bug.cgi?id=240354
Reviewed by Ryan Haddad.
- Tools/CISupport/build-webkit-org/steps.py:
(CompileWebKit.evaluateCommand):
(TransferToS3.init):
(TransferToS3.finished):
Canonical link: https://commits.webkit.org/250497@main
- 1:03 PM Changeset in webkit [294115] by
-
- 2 edits in trunk/Tools/CISupport/build-webkit-org
[build.webkit.org] Upload steps should be properly named
https://bugs.webkit.org/show_bug.cgi?id=240351
Reviewed by Ryan Haddad.
- Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
- Tools/CISupport/build-webkit-org/steps.py:
(ArchiveMinifiedBuiltProduct):
(UploadBuiltProduct):
(UploadMinifiedBuiltProduct):
Canonical link: https://commits.webkit.org/250496@main
- 11:51 AM Changeset in webkit [294114] by
-
- 2 edits in trunk/Source/WebKit
Don't install WebKit feature flags plist on macOS
https://bugs.webkit.org/show_bug.cgi?id=240350
<rdar://problem/93183882>
Reviewed by Wenson Hsieh.
- WebKit.xcodeproj/project.pbxproj:
We don't need it on macOS (and won't need it at all soon), and
the script is currently installing to the wrong place for some kinds
of macOS builds. So, just skip it.
- 11:22 AM Changeset in webkit [294113] by
-
- 6 edits in trunk
Mail compose: right clicking an image attachment selects it
https://bugs.webkit.org/show_bug.cgi?id=240315
rdar://45454933
Reviewed by Wenson Hsieh.
- wtf/cocoa/RuntimeApplicationChecksCocoa.h:
Mail compose: right clicking an image attachment selects it
https://bugs.webkit.org/show_bug.cgi?id=240315
rdar://45454933
Reviewed by Wenson Hsieh.
If the page is editable, don't select if the element is an image.
- page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):
Mail compose: right clicking an image attachment selects it
https://bugs.webkit.org/show_bug.cgi?id=240315
rdar://45454933
Reviewed by Wenson Hsieh.
API test coverage.
- TestWebKitAPI/Tests/mac/ContextMenuTests.mm:
(TestWebKitAPI::rightClick):
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/250494@main
- 11:14 AM Changeset in webkit [294112] by
-
- 1 copy in tags/WebKit-7614.1.13.4
Tag WebKit-7614.1.13.4.
- 11:05 AM Changeset in webkit [294111] by
-
- 2 edits in branches/safari-7614.1.13-branch/Source/WebKit
Apply patch. rdar://problem/92617943
- 10:55 AM Changeset in webkit [294110] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-videoDetectorTest.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240348
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250493@main
- 10:43 AM Changeset in webkit [294109] by
-
- 4 edits in trunk/Source/WebKit
[GTK][WPE] Do not return pointer to disposed timezone string
https://bugs.webkit.org/show_bug.cgi?id=240327
Reviewed by Michael Catanzaro.
Store time zone name in CString to avoid returning pointer to a temp string which was
disposed before returning from webkit_web_context_get_time_zone_override.
No new tests. Covered by existing unit tests.
- UIProcess/API/glib/WebKitWebContext.cpp:
(webkitWebContextSetProperty):
(webkitWebContextConstructed):
(webkit_web_context_get_time_zone_override):
(webkit_web_context_set_time_zone_override): Deleted this function as the time zone can
only be overridden during context construction.
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/wpe/WebKitWebContext.h:
- 10:43 AM Changeset in webkit [294108] by
-
- 6 edits in trunk/Source/WebCore
[macOS] Remove support for deprecated ScreenCaptureKit API
https://bugs.webkit.org/show_bug.cgi?id=239511
<rdar://problem/91973817>
Reviewed by Youenn Fablet.
Source/WebCore:
Tested manually.
- platform/mediastream/mac/ScreenCaptureKitCaptureSource.h:
- platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(-[WebCoreScreenCaptureKitHelper stream:didOutputSampleBuffer:ofType:]):
(WebCore::ScreenCaptureKitCaptureSource::ScreenCaptureKitCaptureSource):
(WebCore::ScreenCaptureKitCaptureSource::stop):
(WebCore::ScreenCaptureKitCaptureSource::streamConfiguration):
(WebCore::ScreenCaptureKitCaptureSource::startContentStream):
(WebCore::ScreenCaptureKitCaptureSource::updateStreamConfiguration):
(WebCore::ScreenCaptureKitCaptureSource::streamDidOutputSampleBuffer):
- platform/mediastream/mac/ScreenCaptureKitSharingSessionManager.mm:
(-[WebDisplayMediaPromptHelper sessionDidEnd:]):
(WebCore::ScreenCaptureKitSharingSessionManager::sessionDidEnd):
(WebCore::ScreenCaptureKitSharingSessionManager::takeSharingSessionForFilter):
Source/WebCore/PAL:
- pal/spi/mac/ScreenCaptureKitSPI.h:
- 10:39 AM Changeset in webkit [294107] by
-
- 2 edits in trunk/JSTests
Unskip no longer failing test
https://bugs.webkit.org/show_bug.cgi?id=240346
Unreviewed gardening.
Test no longer fails on ARM. No good explanation for why it was only
failing in bytecode-cache mode. Also not sure which subsequent commit
fixed it.
- stress/exception-in-to-property-key-should-be-handled-early.js:
- 10:37 AM Changeset in webkit [294106] by
-
- 3 edits in branches/safari-7614.1.13-branch/Source/WebKit
Cherry-pick r294072. rdar://problem/93058432
Need to add DYLD_LIBRARY_PATH for XPC services
https://bugs.webkit.org/show_bug.cgi?id=240289
Reviewed by Alexey Proskuryakov.
Set DYLD_LIBRARY_PATH / DYLD_VERSIONED_LIBRARY_PATH for XPC services depending on the value of USE_STAGING_INSTALL_PATH.
Also added DYLD_LIBRARY_PATH to the XPC environment for webpushd.
- Configurations/BaseTarget.xcconfig:
- webpushd/webpushtool/WebPushToolMain.mm: (registerDaemonWithLaunchD):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:31 AM Changeset in webkit [294105] by
-
- 9 edits in branches/safari-7614.1.13-branch/Source
Versioning.
WebKit-7614.1.13.4
- 9:24 AM Changeset in webkit [294104] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer][VideoCapture] Add support for capturing encoded video streams from a webcam
https://bugs.webkit.org/show_bug.cgi?id=240229
Patch by Loïc Le Page <llepage@igalia.com> on 2022-05-12
Reviewed by Philippe Normand.
Takes into account encoded video streams produced by a webcam for
video capture.
Manually tested (requires a webcam with encoded video streams).
- platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
(WebCore::GStreamerVideoCaptureSource::generatePresets):
- platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::createConverter):
(WebCore::GStreamerVideoCapturer::setSize):
(WebCore::GStreamerVideoCapturer::setFrameRate):
(WebCore::GStreamerVideoCapturer::adjustVideoSrcMIMEType):
- platform/mediastream/gstreamer/GStreamerVideoCapturer.h:
- 7:27 AM Changeset in webkit [294103] by
-
- 5 edits in trunk/Source/WebKit
REGRESSION(r291038) [GTK][WPE] Fix build without remote inspector
https://bugs.webkit.org/show_bug.cgi?id=240305
Patch by Olivier Blin <Olivier Blin> on 2022-05-12
Reviewed by Michael Catanzaro.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
- 6:56 AM Changeset in webkit [294102] by
-
- 9 edits1 copy3 adds in trunk
Add a better mock for audio units used by CoreAudioSharedUnit
https://bugs.webkit.org/show_bug.cgi?id=240231
Reviewed by Eric Carlson.
Source/WebCore:
Move CoreAudioSharedUnit to its own file, CoreAudioSharedUnit.h/CoreAudioSharedUnit.cpp.
Introduce an internal unit to abstract out CoreAudioSharedUnit from actual CoreAudio units.
Implement a CoreAudio based internal unit in CoreAudioSharedUnit.cpp.
Implement a Mock based internal unit in MockAudioSharedUnit.h/MockAudioSharedUnit.mm.
Add inputput/ouput sample rate validation (debug assert and release error returned).
Add a test that uses this validation.
Test: fast/mediastream/audio-unit-reconfigure.html
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/mediastream/mac/BaseAudioSharedUnit.cpp:
- platform/mediastream/mac/BaseAudioSharedUnit.h:
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
- platform/mediastream/mac/CoreAudioSharedUnit.cpp: Added.
- platform/mediastream/mac/CoreAudioSharedUnit.h: Added.
- platform/mediastream/mac/MockAudioSharedUnit.h:
- platform/mediastream/mac/MockAudioSharedUnit.mm:
LayoutTests:
- fast/mediastream/audio-unit-reconfigure-expected.txt: Added.
- fast/mediastream/audio-unit-reconfigure.html: Added.
- 6:49 AM Changeset in webkit [294101] by
-
- 4 edits in trunk
[cssom] Serialize computed '-webkit-text-combine: none'
https://bugs.webkit.org/show_bug.cgi?id=239989
Reviewed by Tim Nguyen.
LayoutTests/imported/w3c:
Update some test expectations.
- web-platform-tests/css/cssom/serialize-all-longhands-expected.txt:
Source/WebCore:
The computed value of '-webkit-text-combine' was only serialized for
'-webkit-text-combine: horizontal' or 'text-combine-upright: all'.
But the initial value 'none' just produced an empty string.
Test: imported/w3c/web-platform-tests/css/cssom/serialize-all-longhands.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- 6:30 AM Changeset in webkit [294100] by
-
- 7 edits in trunk/Source/WebCore
[GTK][WPE] Respect and use the DMABuf modifier values
https://bugs.webkit.org/show_bug.cgi?id=240276
Reviewed by Chris Lord.
When wrapping DMABuf objects in EGLImages, the modifier values should be
respected and used to properly and completely describe the DMABuf.
This should be applied in two places. First one is GraphicsContextGLGBM
where the DMABuf is used to back the ANGLE-handled EGLImage. Second one
is TextureMapperPlatformLayerProxyDMABuf, during construction of the
DMABufLayer object used to present the DMABuf inside the composition
engine.
In both cases this primarily relies on the presence of the
EGL_EXT_image_dma_buf_import_modifiers extension. For the first case
detection of this extension is done through ANGLE and its state stored
on the GraphicsContextGLGBM object during context initialization. For
the second case this state is stored on the PlatformDisplay object
after it's retrieved during the EGLDisplay initialization.
If detected, the DMABuf modifier value is included in the attributes
array used for the EGLImage creation call. The actual modifier value is
retrieved from the gbm_bo object, leaving it to libgbm to assess the
best possible formatting of the DMAbuf resource.
- platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::initializeEGLDisplay):
- platform/graphics/PlatformDisplay.h:
(WebCore::PlatformDisplay::eglExtensions const):
- platform/graphics/gbm/GBMBufferSwapchain.cpp:
(WebCore::GBMBufferSwapchain::Buffer::createDMABufObject const):
- platform/graphics/gbm/GraphicsContextGLGBM.cpp:
(WebCore::GraphicsContextGLANGLE::makeContextCurrent):
(WebCore::GraphicsContextGLGBM::platformInitializeContext):
- platform/graphics/gbm/GraphicsContextGLGBM.h:
(WebCore::GraphicsContextGLGBM::eglExtensions):
- platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp:
(WebCore::TextureMapperPlatformLayerProxyDMABuf::DMABufLayer::createEGLImageData):
- 6:12 AM Changeset in webkit [294099] by
-
- 5 edits in trunk/Source/WebCore
TextBoxPainter::paintBackground should bail out early when nothing to paint
https://bugs.webkit.org/show_bug.cgi?id=240317
Reviewed by Simon Fraser.
Collecting markers and highlights is a somewhat expensive operation while most
of the time the text has neither markers nor highlights. Let's just bail out early when applicable.
- dom/Document.h:
(WebCore::Document::hasHighlightRegister const):
- rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::paintBackground):
- 5:40 AM Changeset in webkit [294098] by
-
- 5 edits in trunk
[:has() pseudo-class] Support invalidation for :target pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=240329
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Extend current test to cover more cases, and mark it as passing.
- web-platform-tests/css/selectors/invalidation/target-pseudo-in-has-expected.txt:
- web-platform-tests/css/selectors/invalidation/target-pseudo-in-has.html:
Source/WebCore:
Test: imported/w3c/web-platform-tests/css/selectors/invalidation/target-pseudo-in-has.html
- dom/Document.cpp:
(WebCore::Document::setCSSTarget):
- 1:44 AM Changeset in webkit [294097] by
-
- 11 edits12 adds in trunk/LayoutTests/imported/w3c
Re-import css/selectors WPT from revision 4653e9128742e2c2609e76f04f4084cdc10ffead
https://bugs.webkit.org/show_bug.cgi?id=240332
Reviewed by Antti Koivisto.
Upstream commit: https://github.com/web-platform-tests/wpt/commit/4653e9128742e2c2609e76f04f4084cdc10ffead
- web-platform-tests/css/selectors/first-child-expected.txt: Added.
- web-platform-tests/css/selectors/first-child.html: Added.
- web-platform-tests/css/selectors/first-of-type-expected.txt: Added.
- web-platform-tests/css/selectors/first-of-type.html: Added.
- web-platform-tests/css/selectors/invalidation/has-in-adjacent-position-expected.txt:
- web-platform-tests/css/selectors/invalidation/has-in-adjacent-position.html:
- web-platform-tests/css/selectors/invalidation/has-in-ancestor-position-expected.txt:
- web-platform-tests/css/selectors/invalidation/has-in-ancestor-position.html:
- web-platform-tests/css/selectors/invalidation/has-in-parent-position-expected.txt:
- web-platform-tests/css/selectors/invalidation/has-in-parent-position.html:
- web-platform-tests/css/selectors/invalidation/has-in-sibling-position-expected.txt:
- web-platform-tests/css/selectors/invalidation/has-in-sibling-position.html:
- web-platform-tests/css/selectors/invalidation/target-pseudo-in-has-expected.txt: Added.
- web-platform-tests/css/selectors/invalidation/target-pseudo-in-has.html: Added.
- web-platform-tests/css/selectors/invalidation/w3c-import.log:
- web-platform-tests/css/selectors/last-child-expected.txt: Added.
- web-platform-tests/css/selectors/last-child.html: Added.
- web-platform-tests/css/selectors/last-of-type-expected.txt: Added.
- web-platform-tests/css/selectors/last-of-type.html: Added.
- web-platform-tests/css/selectors/only-child-expected.txt: Added.
- web-platform-tests/css/selectors/only-child.html: Added.
- web-platform-tests/css/selectors/w3c-import.log:
May 11, 2022:
- 11:39 PM Changeset in webkit [294096] by
-
- 2 edits in trunk/LayoutTests
[GPU Process] webrtc/vp8-then-h264-gpu-process-crash.html flaky fails after turning DOM in GPUP on by default
https://bugs.webkit.org/show_bug.cgi?id=236926
Patch by John Cunningham <johncunningham@apple.com> on 2022-05-11
Reviewed by Youenn Fablet.
- platform/wpe/TestExpectations:
- 10:41 PM Changeset in webkit [294095] by
-
- 2 edits in trunk/Source/WebCore
[WPE] Unreviewed, build fix after r293816
https://bugs.webkit.org/show_bug.cgi?id=240330
Build was broken when ENABLE_ORIENTATION_EVENTS=ON
- dom/DeviceOrientationEvent.idl:
- 10:14 PM Changeset in webkit [294094] by
-
- 2 edits in trunk/Source/WebCore
Some RenderStyle::diff() optimizations
https://bugs.webkit.org/show_bug.cgi?id=240323
Reviewed by Alan Bujtas.
Some LengthBox operator== stuff was showing up on profiles, which we can avoid by
first testing m_surroundData pointer equality.
scrollPadding and scrollSnapType live in rareNonInheritedData, so we can move their
comparisons into rareNonInheritedDataChangeRequiresLayout().
changeRequiresRepaint() can check for m_backgroundData and m_surroundData pointer
equality before doing more expensive tests.
These changes reduce the time in RenderStyle::diff() in the MotionMark Design
subtest by ~40%.
- rendering/style/RenderStyle.cpp:
(WebCore::rareNonInheritedDataChangeRequiresLayout):
(WebCore::RenderStyle::changeRequiresLayout const):
(WebCore::RenderStyle::changeRequiresLayerRepaint const):
(WebCore::RenderStyle::changeRequiresRepaint const):
- 9:49 PM Changeset in webkit [294093] by
-
- 1 copy in tags/WebKit-7614.1.13.3
Tag WebKit-7614.1.13.3.
- 9:46 PM Changeset in webkit [294092] by
-
- 2 edits in branches/safari-7614.1.13-branch/Source/WebKit
Cherry-pick r293945. rdar://problem/92859012
Fix another internal build
https://bugs.webkit.org/show_bug.cgi?id=240201
<rdar://92859012>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-06
Reviewed by Alexey Proskuryakov.
Bug 240184 introduced a classic "but I have spaces in my path" bug.
- Configurations/adattributiond.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:46 PM Changeset in webkit [294091] by
-
- 2 edits in branches/safari-7614.1.13-branch/Source/WebKit
Cherry-pick r293936. rdar://problem/92859012
Fix adattributiond build in internal build on older macOS
https://bugs.webkit.org/show_bug.cgi?id=240184
<rdar://92859012>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-06
Reviewed by Alexey Proskuryakov.
We need to search for WK_OVERRIDE_FRAMEWORKS_DIR to find the right frameworks
- Configurations/adattributiond.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:33 PM Changeset in webkit [294090] by
-
- 4 edits1 add in branches/safari-7614.1.13-branch/Source/WebGPU
Cherry-pick r293937. rdar://problem/92524485
[WebGPU] Fix build on downlevel OSes in Apple's build system
https://bugs.webkit.org/show_bug.cgi?id=240159
<rdar://problem/92524485>
Reviewed by Alexey Proskuryakov.
Some variables from WebKitTargetConditionals.xcconfig and
PlatformSupport.xcconfig are used, so we have to make sure
we include them. Also refactor the INSTALL_PATH variable a
bit.
- Configurations/Base.xcconfig:
- Configurations/WebGPU.xcconfig:
- Configurations/WebKitTargetConditionals.xcconfig: Added.
- WebGPU.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:27 PM Changeset in webkit [294089] by
-
- 9 edits in branches/safari-7614.1.13-branch/Source
Versioning.
WebKit-7614.1.13.3
- 9:05 PM Changeset in webkit [294088] by
-
- 6 edits in trunk
ImageAnalysisQueue should extract and analyze images inside of subframes
https://bugs.webkit.org/show_bug.cgi?id=240328
rdar://93134975
Reviewed by Tim Horton.
Teach
ImageAnalysisQueueto recursively find all images on the page (including images in of subframe content)
and queue them for analysis. To do this, we refactorenqueueAllImagesto call into a new recursive helper
method,enqueueAllImagesRecursive, to look for more candidate image elements that exist inside frame owner
elements (e.g.iframe).
Test: ImageAnalysisTests.AnalyzeImagesInSubframes
- page/ImageAnalysisQueue.cpp:
(WebCore::ImageAnalysisQueue::enqueueAllImages):
(WebCore::ImageAnalysisQueue::enqueueAllImagesRecursive):
- page/ImageAnalysisQueue.h:
ImageAnalysisQueue should extract and analyze images inside of subframes
https://bugs.webkit.org/show_bug.cgi?id=240328
rdar://93134975
Reviewed by Tim Horton.
Add an API test to verify that we extract and analyze images inside of subframes, in addition to images in the
main frame.
- TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/multiple-images.html:
Canonical link: https://commits.webkit.org/250478@main
- 7:06 PM Changeset in webkit [294087] by
-
- 5 edits in trunk/Source/JavaScriptCore
Better handle clobbered registers in O0 register allocation
https://bugs.webkit.org/show_bug.cgi?id=240205
<rdar://87220688>
Reviewed by Yusuke Suzuki.
This patch makes Air's O0 register allocator better handle clobbered
registers. We now model both early and late clobber directly, and use
this to perform a basic interference analysis when allocating a register
to a Tmp. An early clobber interferes with any Use in an instruction, and
any early Defs. A late clobber interferes with any Defs in an instruction,
and any late Uses. What this enables is an early Use can be allocated
to a register that is only late clobbered. And a result can be allocated
to a register that is only early clobbered.
Prior to this, the algorithm had a bug where a Use may be allocated to
a register that is early clobbered.
- b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:
(JSC::B3::Air::GenerateAndAllocateRegisters::buildLiveRanges):
(JSC::B3::Air::GenerateAndAllocateRegisters::alloc):
(JSC::B3::Air::GenerateAndAllocateRegisters::freeDeadTmpsIfNeeded):
(JSC::B3::Air::GenerateAndAllocateRegisters::assignTmp):
(JSC::B3::Air::GenerateAndAllocateRegisters::prepareForGeneration):
(JSC::B3::Air::GenerateAndAllocateRegisters::generate):
- b3/air/AirAllocateRegistersAndStackAndGenerateCode.h:
- b3/air/testair.cpp:
- jit/RegisterSet.h:
Canonical link: https://commits.webkit.org/250477@main
- 6:44 PM Changeset in webkit [294086] by
-
- 2 edits in trunk/Source/WebKit
[WinCairo] Fix a compile error due to InspectorResourceURLSchemeHandler
https://bugs.webkit.org/show_bug.cgi?id=239490
Reviewed by Yusuke Suzuki.
- UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp:
Canonical link: https://commits.webkit.org/250476@main
- 6:36 PM Changeset in webkit [294085] by
-
- 9 edits in branches/safari-7614.1.12-branch/Source
Versioning.
WebKit-7614.1.12.3
- 5:56 PM Changeset in webkit [294084] by
-
- 14 edits in trunk
Re-send connection configuration if webpushd dies
https://bugs.webkit.org/show_bug.cgi?id=240286
Reviewed by Geoffrey Garen.
If webpushd dies, all future communication with it from NetworkProcess fails because we
don't re-send the connection configuration to the daemon after the connection is
interrupted. This manifests itself as an "invalid sender" AbortError from various
PushManager methods because webpushd doesn't know the bundle identifier of the UIProcess it
is working on behalf of.
To fix this, I moved the responsibility for sending the configuration from
NetworkNotificationManager to WebPushD::Connection, and WebPushD::Connection re-sends the
configuration every time a new XPC connection is created.
Covered by a new API test.
Source/WebKit:
- NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::NetworkSession):
- NetworkProcess/NetworkSession.h:
(WebKit::NetworkSession::webPushDaemonUsesMockBundlesForTesting const): Deleted.
- NetworkProcess/Notifications/Cocoa/WebPushDaemonConnectionCocoa.mm:
(WebKit::WebPushD::Connection::newConnectionWasInitialized const):
- NetworkProcess/Notifications/NetworkNotificationManager.cpp:
(WebKit::NetworkNotificationManager::NetworkNotificationManager):
(WebKit::NetworkNotificationManager::sendMessage const):
(WebKit::NetworkNotificationManager::sendMessageWithReply const):
(WebKit::NetworkNotificationManager::maybeSendConnectionConfiguration const): Deleted.
- NetworkProcess/Notifications/NetworkNotificationManager.h:
- NetworkProcess/Notifications/WebPushDaemonConnection.cpp:
(WebKit::WebPushD::Connection::Connection):
- NetworkProcess/Notifications/WebPushDaemonConnection.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:
(TestWebKitAPI::testWebPushDaemonPList):
(TestWebKitAPI::setUpTestWebPushD):
(TestWebKitAPI::restartTestWebPushD):
(TestWebKitAPI::WebPushDTest::WebPushDTest):
- TestWebKitAPI/cocoa/DaemonTestUtilities.h:
- TestWebKitAPI/cocoa/DaemonTestUtilities.mm:
(TestWebKitAPI::restartService):
Canonical link: https://commits.webkit.org/250475@main
- 5:54 PM Changeset in webkit [294083] by
-
- 1 copy in tags/WebKit-7613.3.1.1.2
Tag WebKit-7613.3.1.1.2.
- 5:31 PM Changeset in webkit [294082] by
-
- 44 edits in trunk
Web Inspector: Parse InjectedScriptSource as a built-in to get guaranteed non-user-overriden JSC built-ins
https://bugs.webkit.org/show_bug.cgi?id=152294
Reviewed by Devin Rousso.
Source/JavaScriptCore:
Covered by existing tests, and new test cases in
LayoutTests/inspector/injected-script/observable.html
- CMakeLists.txt:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Build InjectedScriptSource.js as a builtin, not as a plain header file containing its source code.
- Scripts/wkbuiltins/builtins_model.py:
(BuiltinFunction.fromString):
(BuiltinsCollection._parse_functions):
- InspectorInjectedScript contains unbalanced curly brackets inside quotes. The generation of builtins is now
hardened against this. Previously all curly brackets were counted, which meant that the source code would be cut
off earlier than the actual end of the function.
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createExecutable):
- CommandLineAPIModuleSource.js uses destructuring to get the
RemoteObjectandCommandLineAPIclasses at
instantiation. We need to treat this destructure as a single parameter, otherwise debug assertions will catch
the discrepancy between parameter counts.
- builtins/BuiltinNames.h:
- bytecode/LinkTimeConstant.h:
- Add symbols that we need to have a private version of, and for some of those symbols make them link-time constants.
- builtins/IteratorHelpers.js:
(globalPrivate.builtinSetIterable):
(globalPrivate.builtinMapIterable):
- Add reusable helpers for getting builtin iterators for Maps and Sets. This is done with private symbols that
represent the same function that the iterator would have returned. We create a new wrapper object to allow usage
to follow the same pattern at dealing with an unwrapped iterable object.
- inspector/InjectedScriptManager.cpp:
(Inspector::InjectedScriptManager::createInjectedScript):
(Inspector::InjectedScriptManager::injectedScriptFor):
(Inspector::InjectedScriptManager::injectedScriptSource): Deleted.
- inspector/InjectedScriptManager.h:
- Use the new link-time constant for the Injected Script creation function.
- inspector/InjectedScriptModule.cpp:
(Inspector::InjectedScriptModule::ensureInjected):
- inspector/InjectedScriptModule.h:
- Injected modules are now provided as a JSFunction, not raw source code.
- inspector/InjectedScriptSource.js:
- Use private symbols throughout to ensure we get non-observable, non-overridden versions of functions and values.
- In many cases, this is a 1:1 mapping where the new symbol is just prefixed with an
@. - For pushing values to arrays, use
@arrayPush, the builtin way of pushing a value into an array. - For the
Symbolconstructor, just use the existing@createPrivateSymbolinstead of exposing a private
version of the
Symbolconstructor..
Symbol.toStringTagis converted to@@toStringTag, the private version of that symbol.Math.maxinRemoteObject.prototype._generatePreviewnow uses a helper function that performs a comparison
instead of exposing both Math and Math.max as private builtins.
- Create objects as prototype-less using the new builtin helper @createPrototypelessObject, which can also take
arguments that are key value pairs for near-parity with normal Object creation via
{}.
- Create arrays as prototype-less using the new builtin helper @createPrototypelessArray, which can also take
arguments which are entries to put into the array.
- For spreading arguments (for the console commandline functions) we should create a new prototypeless array to
spread instead of spreading the raw arguments to avoid interacting with a potentially modified iterator.
- parser/Parser.h:
(JSC::parse):
- Add the line number to builtin compilation logging to help identify where sometimes ambiguous errors occurred.
- runtime/ArrayConstructor.cpp:
- runtime/ArrayPrototype.cpp:
- runtime/MapPrototype.cpp:
- runtime/ObjectConstructor.cpp:
- runtime/SetPrototype.cpp:
- runtime/StringPrototype.cpp:
- Expose necessary functions/constructors via their private name for use in InjectedScriptSource.js and
CommandLineAPIModuleSource.js
- runtime/JSGlobalObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSGlobalObject::init):
- runtime/JSGlobalObject.h:
- Add a link-time constant for the String constructor.
- Add helpers for JSON parsing/serialization.
Source/WebCore:
- CMakeLists.txt:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- Build CommandLineAPIModuleSource.js as a builtin, not as a plain header file containing its source code.
- inspector/CommandLineAPIModule.cpp:
(WebCore::CommandLineAPIModule::injectModuleFunction const):
(WebCore::CommandLineAPIModule::source const): Deleted.
- inspector/CommandLineAPIModule.h:
- Provide a JSFunction for module injection instead of raw source code.
- inspector/CommandLineAPIModuleSource.js:
- Similar to JavaScriptCore/inspector/InjectedScriptSource.js, use private names for properties and functions
throughout to get non-user-overridden builtins.
- In
normalizeEventTypesuse a Set instead of an array, since we are processing user-provided types that may
be repeated. This means that we need to iterate over all the types to insert them in the set, but since
@arrayPushdoesn't support pushing multiple values at the same time this is no more work than using an Array.
LayoutTests:
- inspector/injected-script/observable-expected.txt:
- inspector/injected-script/observable.html:
- Add several more test cases for overriding functions and entire objects.
- inspector/debugger/pause-for-internal-scripts-expected.txt:
- inspector/debugger/pause-for-internal-scripts.html:
- Changed to test a custom internal script snippet since the inspector injected script is now a builtin.
- inspector/debugger/scriptParsed-expected.txt:
- inspector/debugger/scriptParsed.html:
- The inspector injected script (and modules) will no longer appear as scripts in Web Inspector.
- inspector/model/remote-object/error-expected.txt:
- inspector/timeline/line-column.html:
- inspector/timeline/line-column-expected.txt:
- platform/gtk/inspector/timeline/line-column-expected.txt:
- Inspector injected script line numbers are different between release and debug builds, so filter those out.
- 5:02 PM Changeset in webkit [294081] by
-
- 1 copy in tags/WebKit-7613.3.1.0.2
Tag WebKit-7613.3.1.0.2.
- 4:58 PM Changeset in webkit [294080] by
-
- 1 copy in tags/WebKit-7614.1.13.2
Tag WebKit-7614.1.13.2.
- 4:52 PM Changeset in webkit [294079] by
-
- 11 edits2 adds in trunk
fast/text/international/system-language/navigator-language/navigator-language-fr.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240104
<rdar://problem/92765233>
Reviewed by Per Arne Vollan and Myles Maxfield.
The test was flaky and navigator.language would sometimes return "fr" and sometimes "fr-FR".
The reason for this is that Cocoa ports used 2 separate mechanisms to override the system
language:
- The override languages were used to set the AppleLanguages NSUserDefaults, causing APIs such as CFLocaleCopyPreferredLanguages() to return the overriden languages.
- During process initialization we would also call WTF::overrideUserPreferredLanguages() which would add the override languages to an override Vector in WTF.
The test was setting the override language to "fr". When method 2 would succeed,
navigator.language would return "fr", from preferredLanguagesOverride().
However, Internals::resetToConsistentState() would reset WTF::preferredLanguagesOverride()
shortly after the test starts running. As a result, the override Vector in WTF would often
end up being empty and we would end up calling CFLocaleCopyPreferredLanguages().
However, CFLocaleCopyPreferredLanguages() return "fr-FR", which is equivalent but not
exactly the same.
To address the issue, I made the following changes:
- Use a single method for overriding languages for Cocoa ports. We are now using the AppleLanguages user default exclusively and not the WTF::preferredLanguagesOverride() Vector.
- We now call Internals::resetToConsistentState() only after running the test in WebKitTestRunner, not at the beginning of the test. This is consistent to what we were already doing in DumpRenderTree. Because Internals::resetToConsistentState() resets the languages, we don't want it to run at the beginning of the test. This is because some tests specify their languages in their header and WKTR ends up setting those languages via TestOptions, before actually running the test. We don't want those to get cleared.
- Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Only ask the injected bundle to reset after running the test and not before. This is
consistent with what DumpRenderTree was already doing. The injected bundle would call
Internals::resetToConsistentState() when receiving this reset message.
- Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::setAppleLanguagesPreference):
Move the logic to set the AppleLanguages user default from the WebKit2 layer to WTF,
inside LanguageCocoa.mm and use it inside WTF::overrideUserPreferredLanguages().
- Source/WTF/wtf/Language.cpp:
(WTF::overrideUserPreferredLanguages):
- Source/WTF/wtf/cocoa/LanguageCocoa.mm:
(WTF::overrideUserPreferredLanguages):
Stop using the WTF::preferredLanguagesOverride() Vector on Cocoa and set the AppleLanguages
user default instead. WebKit2 was using both AppleLanguages and this Vector, which would give
inconsistent results, especially when resetting the Vector but not the user default. Using
the user default is also more realistic then the fake override Vector as we end up calling
into the usual CF APIs to retrieve the languages.
- Source/WebCore/platform/graphics/FontDescription.cpp:
(WebCore::computeSpecializedChineseLocale):
- Source/WebCore/platform/graphics/FontGenericFamilies.cpp:
(WebCore::computeUserPrefersSimplified):
Add some FIXME comments. These functions do locale matching but use minimized locales which
may cause the matching to fail. This is causing fast/text/international/generic-font-family-language-traditional.html
to fail. We didn't notice before because our test infrastructure storing language overrides in
a vector in WTF, which doesn't get minimized, unlike locales we get from the system.
- Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::userPreferredLanguages const):
Stop minimizing the locales returned by internals.userPreferredLanguages(). It used to not matter because
locales set by the test would be set in the WTF::overrideUserPreferredLanguages() Vector and locales from
that vector would get returned un-minimized, even when requesting minimized locales. However, now that we
are no longer using this vector and using the regular code path instead, locales would get minimized and
this would cause a test to fail. The test was checking that the values returned by
internals.userPreferredLanguages() are exactly the same as the ones set via internals.setUserPreferredLanguages().
- LayoutTests/fast/harness/user-preferred-language.html:
Tweak test to use call internals.setUserPreferredLanguages() with proper locales instead of using
non-locales. This used to not matter because we were storing them in the WTF::overrideUserPreferredLanguages()
Vector and internals.userPreferredLanguages() would return then as-is from the vector.
However, now that we actually set the AppleLanguages user default and actually call the CF APIs to retrieve
the locales, having properly formatted locales is required.
- LayoutTests/platform/gtk/fast/text/international/system-language/navigator-language/navigator-language-en-expected.txt: Added.
We used to clear the language override shortly after starting the test so the test was actually getting the system language
instead of "en" which is the override that the test sets.
- LayoutTests/platform/ios/TestExpectations:
- LayoutTests/platform/mac/TestExpectations:
Mark fast/text/international/generic-font-family-language-traditional.html as failing since language minimization
is causing it to fail. This is not a regression from this patch. This is an issue in shipping code that is now
exposed because our test infrastructure for locale overriding is now closer to real life.
Canonical link: https://commits.webkit.org/250473@main
- 3:32 PM Changeset in webkit [294078] by
-
- 1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 145
Added a tag for Safari Technology Preview release 145.
- 2:57 PM Changeset in webkit [294077] by
-
- 9 edits in trunk
[WinCairo] Support file downloads
https://bugs.webkit.org/show_bug.cgi?id=240293
Reviewed by Fujii Hironori.
.:
- Source/cmake/OptionsWin.cmake: enable DOWNLOAD_ATTRIBUTE by default in WinCairo.
Source/WebCore:
Properly convert suggested file name to utf8.
Coverred by LayoutTests/http/tests/download/literal-utf-8.html.
- platform/network/curl/ResourceResponseCurl.cpp:
(WebCore::ResourceResponse::platformSuggestedFilename const):
Source/WebKit:
Hooked up Curl calls to Download callbacks. Added basic support for
file downloads in Curl.
- NetworkProcess/curl/NetworkDataTaskCurl.cpp:
(WebKit::NetworkDataTaskCurl::cancel):
(WebKit::NetworkDataTaskCurl::curlDidReceiveData):
(WebKit::NetworkDataTaskCurl::curlDidComplete):
(WebKit::NetworkDataTaskCurl::deleteDownloadFile):
(WebKit::NetworkDataTaskCurl::curlDidFailWithError):
(WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse):
- NetworkProcess/curl/NetworkDataTaskCurl.h:
LayoutTests:
- platform/wincairo/TestExpectations: enable downloads tests.
- 2:57 PM Changeset in webkit [294076] by
-
- 9 edits in branches/safari-7613.3.1.1-branch/Source
Versioning.
WebKit-7613.3.1.1.2
- 2:56 PM Changeset in webkit [294075] by
-
- 9 edits in branches/safari-7613.3.1.0-branch/Source
Versioning.
WebKit-7613.3.1.0.2
- 2:47 PM Changeset in webkit [294074] by
-
- 2 edits in trunk
Remove Subversion references from ReadMe
https://bugs.webkit.org/show_bug.cgi?id=240316
<rdar://problem/93127701>
Reviewed by Geoffrey Garen.
- ReadMe.md:
Canonical link: https://commits.webkit.org/250471@main
- 2:43 PM Changeset in webkit [294073] by
-
- 1 copy in tags/WebKit-7613.3.1.1.1
Tag WebKit-7613.3.1.1.1.
- 2:41 PM Changeset in webkit [294072] by
-
- 3 edits in trunk/Source/WebKit
Need to add DYLD_LIBRARY_PATH for XPC services
https://bugs.webkit.org/show_bug.cgi?id=240289
Reviewed by Alexey Proskuryakov.
Set DYLD_LIBRARY_PATH / DYLD_VERSIONED_LIBRARY_PATH for XPC services depending on the value of USE_STAGING_INSTALL_PATH.
Also added DYLD_LIBRARY_PATH to the XPC environment for webpushd.
- Configurations/BaseTarget.xcconfig:
- webpushd/webpushtool/WebPushToolMain.mm:
(registerDaemonWithLaunchD):
- 2:37 PM Changeset in webkit [294071] by
-
- 1 copy in tags/WebKit-7613.3.1.0.1
Tag WebKit-7613.3.1.0.1.
- 1:40 PM Changeset in webkit [294070] by
-
- 12 edits1 add in branches/safari-613-branch/Source
Cherry-pick r293804. rdar://92717726
Crash under WebCore: WebCore::CachedResourceClientWalker<WebCore::CachedImageClient>::next()
https://bugs.webkit.org/show_bug.cgi?id=240072
<rdar://92717726>
Reviewed by Geoff Garen.
Have CachedResource and CachedResourceClientWalker hold the clients via WeakPtrs instead of
raw pointers and null check them before usage. This is a lot safer.
- Source/WTF/WTF.xcodeproj/project.pbxproj:
- Source/WTF/wtf/WeakHashCountedSet.h: Added.
(WTF::WeakHashCountedSet::begin):
(WTF::WeakHashCountedSet::end):
(WTF::WeakHashCountedSet::begin const):
(WTF::WeakHashCountedSet::end const):
(WTF::WeakHashCountedSet::find):
(WTF::WeakHashCountedSet::find const):
(WTF::WeakHashCountedSet::contains const):
(WTF::WeakHashCountedSet::computeSize const):
(WTF::WeakHashCountedSet::clear):
(WTF::Counter>::add):
(WTF::Counter>::remove):
- Source/WebCore/html/HTMLLinkElement.h:
- Source/WebCore/loader/DocumentThreadableLoader.h:
- Source/WebCore/loader/ImageLoader.h:
- Source/WebCore/loader/LinkLoader.h:
- Source/WebCore/loader/cache/CachedImage.cpp:
(WebCore::CachedImage::addClientWaitingForAsyncDecoding):
- Source/WebCore/loader/cache/CachedResource.cpp:
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::switchClientsToRevalidatedResource):
- Source/WebCore/loader/cache/CachedResource.h:
(WebCore::CachedResource::hasClients const):
(WebCore::CachedResource::hasClient):
(WebCore::CachedResource::numberOfClients const):
- Source/WebCore/loader/cache/CachedResourceClient.h:
- Source/WebCore/loader/cache/CachedResourceClientWalker.h:
(WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
(WebCore::CachedResourceClientWalker::next):
- Source/WebCore/rendering/RenderObject.h:
Canonical link: https://commits.webkit.org/245886.562@safari-7613.3.1.0-branch
- 1:40 PM Changeset in webkit [294069] by
-
- 3 edits3 adds in branches/safari-613-branch
Cherry-pick r293736. rdar://80891555
StorageMap::removeItem may fail to remove item from map
https://bugs.webkit.org/show_bug.cgi?id=239982
rdar://80891555
Reviewed by Chris Dumez.
Source/WebCore:
We may have updated m_impl, but we don't update iterator for removal. In this case, item is not removed from
map, but currentSize is updated. The mismatch between currentSize and actual size of the map may lead to
underflow and overflow in currentSize when item is added or removed later.
Test: storage/domstorage/sessionstorage/window-open-remove-item.html
- storage/StorageMap.cpp:
(WebCore::StorageMap::removeItem):
LayoutTests:
- storage/domstorage/sessionstorage/resources/window-open-remove-item.html: Added.
- storage/domstorage/sessionstorage/window-open-remove-item-expected.txt: Added.
- storage/domstorage/sessionstorage/window-open-remove-item.html: Added.
Canonical link: https://commits.webkit.org/245886.561@safari-7613.3.1.0-branch
- 1:40 PM Changeset in webkit [294068] by
-
- 9 edits in branches/safari-613-branch/Source
Versioning.
WebKit-7613.3.1.0.1
Canonical link: https://commits.webkit.org/245886.560@safari-7613.3.1.0-branch
- 1:35 PM Changeset in webkit [294067] by
-
- 50 edits in trunk
REGRESSION (r291788): MotionMark Suits subtest is 9% regressed
https://bugs.webkit.org/show_bug.cgi?id=240112
rdar://92409900
Reviewed by Alan Bujtas.
Source/WebCore:
Add mechanism to safely update SVG renderer from element without triggering an unnecessary style resolution.
- dom/Document.cpp:
(WebCore::Document::removedLastRef):
(WebCore::Document::resolveStyle):
(WebCore::Document::updateTextRenderer):
(WebCore::Document::updateSVGRenderer):
Use the same mechanism as text updates to schedule SVG rendering updates.
(WebCore::Document::ensurePendingRenderTreeUpdate):
(WebCore::Document::needsStyleRecalc const):
(WebCore::Document::destroyRenderTree):
Ensure any remaining style update get deleted along with the render tree.
- dom/Document.h:
- dom/ElementData.h:
(WebCore::ElementData::svgResourcesInAncestorChainAreDirty const): Deleted.
(WebCore::ElementData::setSVGResourcesInAncestorChainAreDirty const): Deleted.
Not needed anymore, Style::Update remembers what needs updating.
- rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateElementRenderer):
Schedule an update. Currently this really just schedules a layout which pulls in the changes from the element.
- style/StyleUpdate.cpp:
(WebCore::Style::Update::addElement):
(WebCore::Style::Update::addSVGRendererUpdate):
Add a bit to ElementUpdate to indicate that SVG update is needed.
- style/StyleUpdate.h:
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::applyResultsToTarget):
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged):
- svg/SVGElement.cpp:
(WebCore::SVGElement::updateSVGRendererForElementChange):
(WebCore::SVGElement::setSVGResourcesInAncestorChainAreDirty): Deleted.
(WebCore::SVGElement::invalidateSVGResourcesInAncestorChainIfNeeded): Deleted.
Replace setSVGResourcesInAncestorChainAreDirty with the new mechanism. Don't invalidate style.
- svg/SVGElement.h:
- svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::svgAttributeChanged):
- svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::svgAttributeChanged):
- svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::svgAttributeChanged):
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::setOrder):
(WebCore::SVGFEConvolveMatrixElement::setKernelUnitLength):
(WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged):
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):
- svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):
- svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::setStdDeviation):
(WebCore::SVGFEDropShadowElement::svgAttributeChanged):
- svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::setStdDeviation):
(WebCore::SVGFEGaussianBlurElement::svgAttributeChanged):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::buildPendingResource):
(WebCore::SVGFEImageElement::svgAttributeChanged):
- svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::setRadius):
(WebCore::SVGFEMorphologyElement::svgAttributeChanged):
- svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::svgAttributeChanged):
- svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::svgAttributeChanged):
- svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::svgAttributeChanged):
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::svgAttributeChanged):
(WebCore::SVGFilterElement::childrenChanged):
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::invalidateFilterPrimitiveParent):
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
- svg/SVGGeometryElement.cpp:
(WebCore::SVGGeometryElement::svgAttributeChanged):
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::svgAttributeChanged):
(WebCore::SVGGradientElement::childrenChanged):
- svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::svgAttributeChanged):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::svgAttributeChanged):
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::svgAttributeChanged):
- svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::svgAttributeChanged):
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::svgAttributeChanged):
(WebCore::SVGMarkerElement::childrenChanged):
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::svgAttributeChanged):
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::svgAttributeChanged):
(WebCore::SVGPatternElement::childrenChanged):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::svgAttributeChanged):
- svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::svgAttributeChanged):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::updateCurrentTranslate):
(WebCore::SVGSVGElement::svgAttributeChanged):
- svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::svgAttributeChanged):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::svgAttributeChanged):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::svgAttributeChanged):
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::svgAttributeChanged):
- svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::svgAttributeChanged):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged):
- svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::svgAttributeChanged):
LayoutTests:
- svg/animations/animation-leak-list-property-instances.html:
Do a rendering update before checking for leaks.
- 1:25 PM Changeset in webkit [294066] by
-
- 7 edits in branches/safari-613-branch
Revert r292888. rdar://problem/80059355
This reverts commit 8c9dcc208cc2be524c3b836f02e4fadc7df788f9/r293995.
- 1:20 PM Changeset in webkit [294065] by
-
- 9 edits in branches/safari-7614.1.13-branch/Source
Versioning.
WebKit-7614.1.13.2
- 11:47 AM Changeset in webkit [294064] by
-
- 1 edit in trunk/metadata/contributors.json
Add my GitHub account name to contributors.json.
Reviewed by Jonathan Bedard.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250468@main
- 11:35 AM Changeset in webkit [294063] by
-
- 4 edits in trunk
[Webpage Translation] Avoid removing elements with no children during text manipulation
https://bugs.webkit.org/show_bug.cgi?id=240287
rdar://91882797
Reviewed by Tim Horton.
After invoking webpage translation on a particular website, the entire page becomes blank and unusable when
scrolling. This happens because of an uncaught JavaScript exception that's thrown when this page's script
attempts to remove an element from its parent usingp.removeChild(c), where the nodepis not a parent of
the given nodec; this, in turn, happens becauseTextManipulationControllerhas already unparentedcfrom
pwhile performing text replacement during translation.
In this particular case, the former child node
cis an emptydivelement with no text or children. As such,
it's unnecessary to flag this element for removal in the first place, since doing so isn't necessary to fill in
translated text.
We can avoid this issue by simply skipping over such nodes (i.e. containers that contain no text, no child
elements, and also are not replaced elements) to avoid this and similar compatibility issues that arise when
the DOM is mutated underneath the page, during translation.
Test: TextManipulation.CompleteTextManipulationSkipsEmptyContainers
- editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::replace):
[Webpage Translation] Avoid removing elements with no children during text manipulation
https://bugs.webkit.org/show_bug.cgi?id=240287
rdar://91882797
Reviewed by Tim Horton.
Add a new API test to exercise the change.
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/250467@main
- 11:18 AM Changeset in webkit [294062] by
-
- 2 edits in trunk
Unreviewed, add github info to contributors.json.
- metadata/contributors.json:
- 10:58 AM Changeset in webkit [294061] by
-
- 2 edits in trunk/LayoutTests
Rebaseline WK1 notifications test expectations after r293921
https://bugs.webkit.org/show_bug.cgi?id=240153
Unreviewed test gardening.
- platform/mac-wk1/imported/w3c/web-platform-tests/notifications/idlharness.https.any-expected.txt:
- 10:51 AM Changeset in webkit [294060] by
-
- 3 edits in trunk/Source/WebKit
[WP] Remove obsolete message filters
https://bugs.webkit.org/show_bug.cgi?id=240242
Reviewed by Chris Dumez.
Remove obsolete message filters in the WebContent process' sandbox. This filtering is now done in other parts of the system.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
- 10:46 AM Changeset in webkit [294059] by
-
- 2 edits in trunk/Source/WebCore
Add a webshare quirk for youtube
https://bugs.webkit.org/show_bug.cgi?id=240303
<rdar://93042649>
Reviewed by Tim Horton.
Manually tested.
- page/Quirks.cpp:
(WebCore::isYouTubeDocument):
(WebCore::Quirks::shouldDisableWebSharePolicy const):
- 10:44 AM Changeset in webkit [294058] by
-
- 19 edits in trunk/Source
MediaPlayerPrivateRemote::nativeImageForCurrentTime should not use IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=240226
<rdar://problem/92969905>
Reviewed by Eric Carlson.
Source/WebCore:
Add a way for MediaPlayer to pass the VideoFrame related to the given frame metadata.
Covered by existing tests, in particular:
- LayoutTests/media/video-canvas-createPattern.html
- LayoutTests/media/video-canvas-drawing.html
- LayoutTests/media/video-canvas-drawing-output.html
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/MediaPlayer.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
- platform/mediastream/libwebrtc/VideoFrameLibWebRTC.h:
Source/WebKit:
On GPUProcess side, when receiving notification of a new frame, create a remote frame
in RemoteMediaPlayerProxy::mediaPlayerOnNewVideoFrameMetadata
and send it to MediaPlayerPrivateRemote::pushVideoFrameMetadata on WebProcess side.
When being asked to create a NativeImage, MediaPlayerPrivateRemote can use that remote image
to get a NativeImage using its videoFrameObjectHeapProxy.
If the remote video frame is not available, get it through videoFrameForCurrentTime and convert it in the same way.
This creates in that case a double IPC. We should probably remove these two IPCs and use VideoFrame as much as we can in follow-up patches.
- GPUProcess/media/RemoteMediaPlayerProxy.h:
- GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
- GPUProcess/media/RemoteVideoFrameObjectHeap.h:
- GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in:
- GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:
- WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
- WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
- WebProcess/GPU/webrtc/SharedVideoFrame.h:
- 10:20 AM Changeset in webkit [294057] by
-
- 9 edits in trunk/Source
Introduce a canvas-drawImage specific method to get a NativeImage from a video element
https://bugs.webkit.org/show_bug.cgi?id=240275
Reviewed by Eric Carlson.
Source/WebCore:
Introduce shouldGetNativeImageForCanvasDrawing in HTMLVideoElement/MediaPlayer/MediaPlayerPrivate.
If returning true, we call videoFrameForCurrentTime when drawing a video to canvas.
Otherwise, we directly use video.paintCurrentFrameInContext code path.
This allows skipping a code path where videoFrameForCurrentTime is less efficient than video.paintCurrentFrameInContext.
Covered by existing canvas tests.
- html/HTMLVideoElement.cpp:
- html/HTMLVideoElement.h:
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
Source/WebKit:
Implement shouldGetNativeImageForCanvasDrawing in MediaPlayerPrivateRemote to return false.
This allows to not do sync IPC in the code path where everything can be done in GPUProcess.
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
- WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
- 10:13 AM Changeset in webkit [294056] by
-
- 1 copy in tags/WebKit-7614.1.11.9
Tag WebKit-7614.1.11.9.
- 10:09 AM Changeset in webkit [294055] by
-
- 1 edit in branches/safari-7613.3.1.1-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
Apply patch. rdar://problem/92780272
- 8:54 AM Changeset in webkit [294054] by
-
- 2 edits in trunk/LayoutTests
[Gardening][ macOS Debug wk2 ] fast/css/variables/test-suite/168.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=239822
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250460@main
- 8:16 AM Changeset in webkit [294053] by
-
- 2 edits in trunk/LayoutTests
[Gardening][ macOS Debug wk2 ] fast/css/variables/test-suite/168.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=239822
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250459@main
- 7:56 AM Changeset in webkit [294052] by
-
- 3 edits in trunk/LayoutTests
[Gardening][ iOS ][ macOS Debug wk1 ] webaudio/AudioBuffer/huge-buffer.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=240081
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
- LayoutTests/platform/mac-wk1/TestExpectations:
Canonical link: https://commits.webkit.org/250458@main
- 7:27 AM Changeset in webkit [294051] by
-
- 4 edits in trunk/Tools/CISupport/build-webkit-org
[build.webkit.org] Allow users to specify custom revision to checkout
https://bugs.webkit.org/show_bug.cgi?id=240307
Reviewed by Ryan Haddad.
- Tools/CISupport/build-webkit-org/factories.py:
(Factory.init):
- Tools/CISupport/build-webkit-org/loadConfig.py:
(loadBuilderConfig):
- Tools/CISupport/build-webkit-org/steps.py:
(CheckOutSpecificRevision):
(CheckOutSpecificRevision.init):
(CheckOutSpecificRevision.doStepIf):
(CheckOutSpecificRevision.hideStepIf):
(CheckOutSpecificRevision.start):
(ShowIdentifier.start):
(ShowIdentifier.evaluateCommand):
Canonical link: https://commits.webkit.org/250457@main
May 10, 2022:
- 9:27 PM Changeset in webkit [294050] by
-
- 4 edits in trunk
[Temporal] Years 0-999 should be canonically represented with 4 digits, not 6
https://bugs.webkit.org/show_bug.cgi?id=240294
Reviewed by Yusuke Suzuki.
This patch implements the spec change of https://github.com/tc39/proposal-temporal/issues/2082:
The range for 4-digit years in ISO8601 date strings should be 0-9999, not 1000-9999.
- test262/expectations.yaml:
Mark four test cases as passing.
- runtime/TemporalInstant.cpp:
Canonical link: https://commits.webkit.org/250456@main
- 6:07 PM Changeset in webkit [294049] by
-
- 3 edits3 adds in branches/safari-7613.3.1.1-branch
Cherry-pick r293736. rdar://problem/80891555
StorageMap::removeItem may fail to remove item from map
https://bugs.webkit.org/show_bug.cgi?id=239982
rdar://80891555
Reviewed by Chris Dumez.
Source/WebCore:
We may have updated m_impl, but we don't update iterator for removal. In this case, item is not removed from
map, but currentSize is updated. The mismatch between currentSize and actual size of the map may lead to
underflow and overflow in currentSize when item is added or removed later.
Test: storage/domstorage/sessionstorage/window-open-remove-item.html
- storage/StorageMap.cpp: (WebCore::StorageMap::removeItem):
LayoutTests:
- storage/domstorage/sessionstorage/resources/window-open-remove-item.html: Added.
- storage/domstorage/sessionstorage/window-open-remove-item-expected.txt: Added.
- storage/domstorage/sessionstorage/window-open-remove-item.html: Added.
Canonical link: https://commits.webkit.org/250224@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 6:07 PM Changeset in webkit [294048] by
-
- 3 edits in branches/safari-7613.3.1.1-branch/Source/ThirdParty/libwebrtc
Cherry-pick r293643. rdar://problem/92445366
[Mac] VTVideoDecoderClass object pointers can become unaligned on x86
https://bugs.webkit.org/show_bug.cgi?id=239916
<rdar://92445366>
Reviewed by Eric Carlson.
Both the base class and the derived class must be 4-byte aligned on x86, or there
is a chance that a pointer member of that struct will cross a page boundary, and
dereferencing that pointer will fail.
- Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
- Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
Canonical link: https://commits.webkit.org/250147@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 6:00 PM Changeset in webkit [294047] by
-
- 3 edits2 adds in trunk
Upstream TypedArray.prototype.fill speedup from bun
https://bugs.webkit.org/show_bug.cgi?id=239891
Reviewed by Saam Barati.
This patch imports bun's improvement in TypedArray#fill[1], bun is MIT licensed.
We use memset and its variant to fill TypedArray if possible.
Microbenchmarks show 5x improvement.
ToT Patched
typed-array-fill 1092.0348+-6.2496 221.3430+-9.1261 definitely 4.9337x faster
[1]: https://github.com/Jarred-Sumner/WebKit/commit/b06577c1f1de19d2ef3d4a87d14ea41909ddf5fc
- JSTests/microbenchmarks/typed-array-fill.js: Added.
- JSTests/stress/typed-array-fill-complicated.js: Added.
(shouldBe):
(throw.new.Error):
- Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::speciesConstruct):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncIncludes):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewPrivateFuncSubarrayCreate):
Canonical link: https://commits.webkit.org/250455@main
- 5:53 PM Changeset in webkit [294046] by
-
- 1 copy in tags/WebKit-7614.1.13.1
Tag WebKit-7614.1.13.1.
- 5:42 PM Changeset in webkit [294045] by
-
- 9 edits in branches/safari-7614.1.13-branch/Source
Versioning.
WebKit-7614.1.13.1
- 5:35 PM Changeset in webkit [294044] by
-
- 9 edits in branches/safari-614.1.11-branch/Source
Versioning.
WebKit-7614.1.11.9
- 5:26 PM Changeset in webkit [294043] by
-
- 9 edits in branches/safari-7613.3.1.1-branch/Source
Versioning.
WebKit-7613.3.1.1.1
- 5:09 PM Changeset in webkit [294042] by
-
- 12 edits1 add in branches/safari-7613.3.1.0-branch/Source
Cherry-pick r293804. rdar://92717726
Crash under WebCore: WebCore::CachedResourceClientWalker<WebCore::CachedImageClient>::next()
https://bugs.webkit.org/show_bug.cgi?id=240072
<rdar://92717726>
Reviewed by Geoff Garen.
Have CachedResource and CachedResourceClientWalker hold the clients via WeakPtrs instead of
raw pointers and null check them before usage. This is a lot safer.
- Source/WTF/WTF.xcodeproj/project.pbxproj:
- Source/WTF/wtf/WeakHashCountedSet.h: Added.
(WTF::WeakHashCountedSet::begin):
(WTF::WeakHashCountedSet::end):
(WTF::WeakHashCountedSet::begin const):
(WTF::WeakHashCountedSet::end const):
(WTF::WeakHashCountedSet::find):
(WTF::WeakHashCountedSet::find const):
(WTF::WeakHashCountedSet::contains const):
(WTF::WeakHashCountedSet::computeSize const):
(WTF::WeakHashCountedSet::clear):
(WTF::Counter>::add):
(WTF::Counter>::remove):
- Source/WebCore/html/HTMLLinkElement.h:
- Source/WebCore/loader/DocumentThreadableLoader.h:
- Source/WebCore/loader/ImageLoader.h:
- Source/WebCore/loader/LinkLoader.h:
- Source/WebCore/loader/cache/CachedImage.cpp:
(WebCore::CachedImage::addClientWaitingForAsyncDecoding):
- Source/WebCore/loader/cache/CachedResource.cpp:
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::switchClientsToRevalidatedResource):
- Source/WebCore/loader/cache/CachedResource.h:
(WebCore::CachedResource::hasClients const):
(WebCore::CachedResource::hasClient):
(WebCore::CachedResource::numberOfClients const):
- Source/WebCore/loader/cache/CachedResourceClient.h:
- Source/WebCore/loader/cache/CachedResourceClientWalker.h:
(WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
(WebCore::CachedResourceClientWalker::next):
- Source/WebCore/rendering/RenderObject.h:
Canonical link: https://commits.webkit.org/250278@main
- 5:09 PM Changeset in webkit [294041] by
-
- 3 edits3 adds in branches/safari-7613.3.1.0-branch
Cherry-pick r293736. rdar://80891555
StorageMap::removeItem may fail to remove item from map
https://bugs.webkit.org/show_bug.cgi?id=239982
rdar://80891555
Reviewed by Chris Dumez.
Source/WebCore:
We may have updated m_impl, but we don't update iterator for removal. In this case, item is not removed from
map, but currentSize is updated. The mismatch between currentSize and actual size of the map may lead to
underflow and overflow in currentSize when item is added or removed later.
Test: storage/domstorage/sessionstorage/window-open-remove-item.html
- storage/StorageMap.cpp:
(WebCore::StorageMap::removeItem):
LayoutTests:
- storage/domstorage/sessionstorage/resources/window-open-remove-item.html: Added.
- storage/domstorage/sessionstorage/window-open-remove-item-expected.txt: Added.
- storage/domstorage/sessionstorage/window-open-remove-item.html: Added.
Canonical link: https://commits.webkit.org/250224@main
- 4:56 PM Changeset in webkit [294040] by
-
- 1 copy in tags/WebKit-7614.1.13
Tag WebKit-7614.1.13.
- 4:45 PM Changeset in webkit [294039] by
-
- 9 edits in branches/safari-7613.3.1.0-branch/Source
Versioning.
WebKit-7613.3.1.0.1
- 4:31 PM Changeset in webkit [294038] by
-
- 4 edits in trunk/Tools
[git-webkit] Fail quickly for invalid bugzilla credentials
https://bugs.webkit.org/show_bug.cgi?id=240182
<rdar://problem/92879251>
Reviewed by Stephanie Lewis.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.main): Check credentials before creating an issue, exit
program if issue creation fails.
Canonical link: https://commits.webkit.org/250454@main
- 4:26 PM Changeset in webkit [294037] by
-
- 1 delete in branches/safari-613.3.1.0-branch
Delete branch.
- 4:26 PM Changeset in webkit [294036] by
-
- 1 delete in branches/safari-613.3.1.1-branch
Delete branch.
- 4:26 PM Changeset in webkit [294035] by
-
- 1 copy in branches/safari-7613.3.1.1-branch
New branch.
- 4:25 PM Changeset in webkit [294034] by
-
- 1 copy in branches/safari-7613.3.1.0-branch
New branch.
- 4:13 PM Changeset in webkit [294033] by
-
- 1 copy in branches/safari-613.3.1.1-branch
New branch.
- 4:13 PM Changeset in webkit [294032] by
-
- 1 copy in branches/safari-613.3.1.0-branch
New branch.
- 4:10 PM Changeset in webkit [294031] by
-
- 1 delete in branches/safari-613.3.1.1-branch
Delete branch.
- 4:10 PM Changeset in webkit [294030] by
-
- 1 delete in branches/safari-613.3.1.0-branch
Delete branch.
- 3:53 PM Changeset in webkit [294029] by
-
- 2 edits in trunk/LayoutTests
Rebase inspector/timeline/line-column.html for Mac
https://bugs.webkit.org/show_bug.cgi?id=240291
Unreviewed test gardening.
- LayoutTests/inspector/timeline/line-column-expected.txt:
Canonical link: https://commits.webkit.org/250453@main
- 3:30 PM Changeset in webkit [294028] by
-
- 1 copy in branches/safari-613.3.1.1-branch
New branch.
- 3:30 PM Changeset in webkit [294027] by
-
- 1 copy in branches/safari-613.3.1.0-branch
New branch.
- 3:30 PM Changeset in webkit [294026] by
-
- 1 delete in branches/safari-613.3.1.1-branch
Delete branch.
- 3:29 PM Changeset in webkit [294025] by
-
- 1 delete in branches/safari-613.3.1.0-branch
Delete branch.
- 3:28 PM Changeset in webkit [294024] by
-
- 1 copy in branches/safari-613.3.1.1-branch
New branch.
- 3:28 PM Changeset in webkit [294023] by
-
- 1 copy in branches/safari-613.3.1.0-branch
New branch.
- 3:28 PM Changeset in webkit [294022] by
-
- 1 delete in branches/safari-613.3.0-branch
Delete branch.
- 3:28 PM Changeset in webkit [294021] by
-
- 1 delete in branches/safari-613.3.1-branch
Delete branch.
- 3:26 PM Changeset in webkit [294020] by
-
- 1 copy in branches/safari-613.3.1-branch
New branch.
- 3:26 PM Changeset in webkit [294019] by
-
- 1 copy in branches/safari-613.3.0-branch
New branch.
- 3:19 PM Changeset in webkit [294018] by
-
- 56 edits1 add25 deletes in trunk
Unreviewed, revert r288307 as it caused correctness issues
https://bugs.webkit.org/show_bug.cgi?id=240280
<rdar://92641509>
Revert r288307 again since it introduced some bad regressions, identified
on the radar.
Canonical link: https://commits.webkit.org/250452@main
- 2:55 PM Changeset in webkit [294017] by
-
- 24 edits in trunk/Source/JavaScriptCore
Add optional Integrity checks at JSC API boundaries.
https://bugs.webkit.org/show_bug.cgi?id=240264
Reviewed by Yusuke Suzuki.
- Defined ENABLE_EXTRA_INTEGRITY_CHECKS in Integrity.h. JSC developers can enable this for their local build if they want to enable more prolific Integrity audits. This is disabled by default.
This feature is currently only supported for USE(JSVALUE64) targets.
The following changes only take effect if ENABLE(EXTRA_INTEGRITY_CHECKS) is enabled.
Otherwise, these are no-ops.
- Added Integrity audits to all toJS and toRef conversion functions in APICast.h. This will help us detect if bad values are passed across the API boundary.
- Added some Integrity audits in JSValue.mm where the APICast ones were insufficient.
The following changes are in effect even when ENABLE(EXTRA_INTEGRITY_CHECKS) is
disabled. Some of these were made to support ENABLE(EXTRA_INTEGRITY_CHECKS), and
some are just clean up in related code that I had to touch along the way.
- Moved isSanePointer() to Integrity.h so that it can be used in more places.
- Changed VM registration with the VMInspector so that it's registered earlier and removed later. Integrity audits may need to audit VM pointers while the VM is being constructed and destructed.
- Added VM::m_isInService to track when the VM is fully constructed or about to be destructed since the VM is now registered with the VMInspector differently (see (4) above). Applied this check in places that need it.
- Fixed VMInspector::isValidExecutableMemory() to check the ExecutableAllocator directly without iterating VMs (which is completely unnecessary).
- Fixed VMInspector::isValidExecutableMemory() and VMInspector::codeBlockForMachinePC() to use AdoptLock. This fixes a race condition where the lock can be contended after ensureIsSafeToLock() succeeds.
- Added VMInspector::isValidVM() to check if a VM pointer is registered or not. VMInspector caches the most recently added or found VM so that isValidVM() can just check the cache for its fast path.
- Moved the implementation of VMInspector::verifyCell() to Integrity::analyzeCell()
and add more checks to it. VMInspector::verifyCell() now calls Integrity::verifyCell()
which uses Integrity::analyzeCell() to do the real cell analysis.
- Also strengten Integrity::auditStructureID() so that it will check if a
Structure's memory has been released. This change is enabled on Debug builds
by default as well as when ENABLE(EXTRA_INTEGRITY_CHECKS). It is disabled
on Release builds.
- API/APICast.h:
(toJS):
(toJSForGC):
(uncheckedToJS):
(toRef):
(toGlobalRef):
- API/JSContext.mm:
- API/JSContextRef.cpp:
- API/JSScript.mm:
- API/JSValue.mm:
(ObjcContainerConvertor::convert):
(objectToValueWithoutCopy):
(objectToValue):
- API/JSVirtualMachine.mm:
- API/JSWeakPrivate.cpp:
- API/glib/JSCContext.cpp:
- API/glib/JSCWrapperMap.cpp:
- API/tests/JSObjectGetProxyTargetTest.cpp:
- bytecode/SpeculatedType.cpp:
(JSC::speculationFromCell):
(JSC::isSanePointer): Deleted.
- heap/HeapFinalizerCallback.cpp:
- heap/WeakSet.h:
- runtime/Structure.h:
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::~VM):
- runtime/VM.h:
(JSC::VM::isInService const):
- tools/HeapVerifier.cpp:
(JSC::HeapVerifier::checkIfRecorded):
- tools/Integrity.cpp:
(JSC::Integrity::Random::reloadAndCheckShouldAuditSlow):
(JSC::Integrity::auditCellMinimallySlow):
(JSC::Integrity::doAudit):
(JSC::Integrity::Analyzer::analyzeVM):
(JSC::Integrity::Analyzer::analyzeCell):
(JSC::Integrity::doAuditSlow):
(JSC::Integrity::verifyCell):
(): Deleted.
(JSC::Integrity::auditCellFully): Deleted.
- tools/Integrity.h:
(JSC::isSanePointer):
(JSC::Integrity::auditCell):
(JSC::Integrity::audit):
- tools/IntegrityInlines.h:
(JSC::Integrity::auditCell):
(JSC::Integrity::auditCellFully):
(JSC::Integrity::auditStructureID):
(JSC::Integrity::doAudit):
- tools/VMInspector.cpp:
(JSC::VMInspector::add):
(JSC::VMInspector::remove):
(JSC::VMInspector::isValidVMSlow):
(JSC::VMInspector::dumpVMs):
(JSC::VMInspector::isValidExecutableMemory):
(JSC::VMInspector::codeBlockForMachinePC):
(JSC::ensureIsSafeToLock): Deleted.
- tools/VMInspector.h:
(JSC::VMInspector::isValidVM):
(): Deleted.
(JSC::VMInspector::unusedVerifier): Deleted.
- tools/VMInspectorInlines.h:
(JSC::VMInspector::verifyCell):
(JSC::VMInspector::verifyCellSize): Deleted.
- 2:15 PM Changeset in webkit [294016] by
-
- 4 edits in trunk/Source/WebCore
Remove the unneeded StylePropertiesBase after Bug 240244
https://bugs.webkit.org/show_bug.cgi?id=240282
Reviewed by Antti Koivisto.
Now that we have removed the abandoned CSSDeferredParser, we no longer need the
StylePropertiesBase class. This patch removes this layer to simplify the code.
- css/StyleProperties.h:
(WebCore::StyleProperties::type const):
(WebCore::StyleProperties::cssParserMode const):
(WebCore::StyleProperties::StyleProperties):
(WebCore::StyleProperties::deref const):
(isType):
(WebCore::StylePropertiesBase::type const): Deleted.
(WebCore::StylePropertiesBase::cssParserMode const): Deleted.
(WebCore::StylePropertiesBase::StylePropertiesBase): Deleted.
(WebCore::StylePropertiesBase::deref const): Deleted.
- css/StyleRule.cpp:
(WebCore::StyleRule::StyleRule):
(WebCore::StyleRule::create):
(WebCore::StyleRule::properties const): Deleted.
- css/StyleRule.h:
- 1:52 PM Changeset in webkit [294015] by
-
- 2 edits in trunk/Source/WebCore
[GPU Process] [Filters] FilterImages can be leaked
https://bugs.webkit.org/show_bug.cgi?id=240274
Reviewed by Simon Fraser.
When a FilterEffect is dynamically updated we clear its result FilterImage.
We also need to clear all the result FilterImages of all the FilterEffects
recursively which takes this changing FilterEffect as an input.
Clearing the result FilterImage of the changing FilterEffect happens by
removing the entry from FilterResults::m_results.
Clearing the FilterImages of the dependent FilterEffects happens by using
FilterResults::m_resultReferences.
What is missing is removing the FilterImage entry itself from
FilterResults::m_resultReferences.
- platform/graphics/filters/FilterResults.h:
(WebCore::FilterResults::clearEffectResult):
- 1:22 PM Changeset in webkit [294014] by
-
- 2 edits in trunk/Tools
Patch is merged via merge-queue, but bugzilla is not closed
https://bugs.webkit.org/show_bug.cgi?id=240155
<rdar://problem/93045114>
Reviewed by Aakash Jain.
- CISupport/ews-build/steps.py:
(UpdatePullRequest): Allow subsequent steps to run if we fail to update a PR.
Canonical link: https://commits.webkit.org/250448@main
- 12:58 PM Changeset in webkit [294013] by
-
- 4 edits in trunk/Websites/webkit.org
[webkit.org] Replace svn.webkit.org with GitHub
https://bugs.webkit.org/show_bug.cgi?id=240093
<rdar://problem/92760014>
Reviewed by Ryan Haddad, Aakash Jain and Dewei Zhu.
- wp-content/themes/webkit/css-status.php: Replace svn.webkit.org with raw.githubusercontent.com.
- wp-content/themes/webkit/status.php: Ditto.
- wp-content/themes/webkit/team.php: Ditto.
Canonical link: https://commits.webkit.org/250447@main
- 11:42 AM Changeset in webkit [294012] by
-
- 4 edits3 adds in trunk
Fix inertness of pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=239831
Reviewed by Antti Koivisto.
When we adjust style for a pseudo-element,
m_elementanddocument().activeModalDialog()are both null. So we accidentally reset inertness to false in those cases.
Fix this by making checking for m_element's existence too.
LayoutTests/imported/w3c:
- web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.
- web-platform-tests/inert/inert-pseudo-element-hittest.html: Added.
Source/WebCore:
Test: imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest.html
- style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
LayoutTests:
- platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-pseudo-element-hittest-expected.txt: Added.
- 11:04 AM Changeset in webkit [294011] by
-
- 7 edits1 add in trunk/Tools
[GitHub]
git commitgenerates a nicely formatted commit log but is missing bug information
https://bugs.webkit.org/show_bug.cgi?id=240254
<rdar://93033766 >
Reviewed by Chris Dumez.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/init.py: Add "commit" program.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.main): Invoke Commit.bug_urls.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:
(FilteredCommand.parser): Typo fix in log message.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/commit.py: Added.
(Commit.parser):
(Commit.bug_urls): Extract a list of bug URLs from an issue.
(Commit.main): Extract commit message information from issue.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/commit_unittest.py:
Canonical link: https://commits.webkit.org/250445@main
- 10:28 AM Changeset in webkit [294010] by
-
- 2 edits in trunk/Source/WebCore
Optimize Replayer::applyItem() slightly
https://bugs.webkit.org/show_bug.cgi?id=240258
Reviewed by Wenson Hsieh.
Convert a series of
ifstatements into a switch.
De-templatize applyFontItem<> since DrawGlyphs is the only instantiation, and the
name was confusing.
- platform/graphics/displaylists/DisplayListReplayer.cpp:
(WebCore::DisplayList::applyDrawGlyphs):
(WebCore::DisplayList::Replayer::applyItem):
(WebCore::DisplayList::applyFontItem): Deleted.
- 10:00 AM Changeset in webkit [294009] by
-
- 1 copy in tags/WebKit-7614.1.12.2
Tag WebKit-7614.1.12.2.
- 9:53 AM Changeset in webkit [294008] by
-
- 9 edits in branches/safari-7614.1.12-branch/Source
Versioning.
WebKit-7614.1.12.2
- 9:48 AM Changeset in webkit [294007] by
-
- 29 edits3 deletes in trunk
Remove abandoned CSSDeferredParser implementation and feature flag
https://bugs.webkit.org/show_bug.cgi?id=240244
Reviewed by Antti Koivisto.
This patch rolls out the abandoned CSSDeferredParser implementation added in Bug 165743.
Source/WebCore:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::keyframes const):
(WebCore::StyleRuleKeyframes::wrapperAppendKeyframe):
(WebCore::StyleRuleKeyframes::wrapperRemoveKeyframe):
(WebCore::StyleRuleKeyframes::findKeyframeIndex const):
(WebCore::StyleRuleKeyframes::parseDeferredRulesIfNeeded const): Deleted.
- css/CSSKeyframesRule.h:
- css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::MutableStyleProperties):
(WebCore::StyleProperties::PropertyReference::cssText const):
(WebCore::DeferredStyleProperties::create): Deleted.
(WebCore::DeferredStyleProperties::DeferredStyleProperties): Deleted.
(WebCore::DeferredStyleProperties::parseDeferredProperties): Deleted.
- css/StyleProperties.h:
(WebCore::StylePropertiesBase::deref const):
(isType):
- css/StyleRule.cpp:
(WebCore::StyleRule::properties const):
(WebCore::StyleRuleGroup::childRules const):
(WebCore::StyleRuleGroup::wrapperInsertRule):
(WebCore::StyleRuleGroup::wrapperRemoveRule):
(WebCore::DeferredStyleGroupRuleList::DeferredStyleGroupRuleList): Deleted.
(WebCore::DeferredStyleGroupRuleList::parseDeferredRules): Deleted.
(WebCore::DeferredStyleGroupRuleList::parseDeferredKeyframes): Deleted.
(WebCore::StyleRuleGroup::parseDeferredRulesIfNeeded const): Deleted.
- css/StyleRule.h:
(WebCore::StyleRule::propertiesWithoutDeferredParsing const): Deleted.
(WebCore::StyleRuleGroup::childRulesWithoutDeferredParsing const): Deleted.
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseString):
(WebCore::traverseRulesInVector):
(WebCore::StyleSheetContents::traverseSubresources const):
- css/parser/CSSDeferredParser.cpp: Removed.
- css/parser/CSSDeferredParser.h: Removed.
- css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseSheet):
- css/parser/CSSParser.h:
- css/parser/CSSParserContext.cpp:
(WebCore::operator==):
(WebCore::add):
- css/parser/CSSParserContext.h:
- css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::CSSParserImpl):
(WebCore::CSSParserImpl::parseStyleSheet):
(WebCore::CSSParserImpl::consumeMediaRule):
(WebCore::CSSParserImpl::consumeSupportsRule):
(WebCore::CSSParserImpl::consumeKeyframesRule):
(WebCore::CSSParserImpl::consumeLayerRule):
(WebCore::CSSParserImpl::consumeContainerRule):
(WebCore::CSSParserImpl::consumeStyleRule):
(WebCore::CSSParserImpl::createDeferredStyleProperties): Deleted.
(WebCore::CSSParserImpl::parseDeferredDeclaration): Deleted.
(WebCore::CSSParserImpl::parseDeferredRuleList): Deleted.
(WebCore::CSSParserImpl::parseDeferredKeyframeList): Deleted.
(WebCore::CSSParserImpl::adoptTokenizerEscapedStrings): Deleted.
- css/parser/CSSParserImpl.h:
(WebCore::CSSParserImpl::tokenizer const):
(WebCore::CSSParserImpl::deferredParser const): Deleted.
- style/ElementRuleCollector.cpp:
(WebCore::Style::ElementRuleCollector::collectMatchingRulesForList):
- style/StyleInvalidator.cpp:
(WebCore::Style::shouldDirtyAllStyle):
- testing/Internals.cpp:
(WebCore::deferredStyleRulesCountForList): Deleted.
(WebCore::Internals::deferredStyleRulesCount): Deleted.
(WebCore::deferredGroupRulesCountForList): Deleted.
(WebCore::Internals::deferredGroupRulesCount): Deleted.
(WebCore::deferredKeyframesRulesCountForList): Deleted.
(WebCore::Internals::deferredKeyframesRulesCount): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetDeferredCSSParserEnabled): Deleted.
(WKPreferencesGetDeferredCSSParserEnabled): Deleted.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
Source/WTF:
- Scripts/Preferences/WebPreferences.yaml:
LayoutTests:
- fast/css/deferred-parsing/dynamic-external-style-expected.txt: Removed.
- fast/css/deferred-parsing/dynamic-external-style.html: Removed.
- fast/css/deferred-parsing/dynamic-style-in-document-expected.txt: Removed.
- fast/css/deferred-parsing/dynamic-style-in-document.html: Removed.
- fast/css/deferred-parsing/hover-test-expected.txt: Removed.
- fast/css/deferred-parsing/hover-test.html: Removed.
- fast/css/deferred-parsing/keyframes-rule-expected.txt: Removed.
- fast/css/deferred-parsing/keyframes-rule.html: Removed.
- fast/css/deferred-parsing/media-print-expected.txt: Removed.
- fast/css/deferred-parsing/media-print.html: Removed.
- fast/css/deferred-parsing/nth-of-type-expected.txt: Removed.
- fast/css/deferred-parsing/nth-of-type.html: Removed.
- fast/css/deferred-parsing/resources/basic-sheet.css: Removed.
- fast/css/deferred-parsing/simple-external-style-expected.txt: Removed.
- fast/css/deferred-parsing/simple-external-style.html: Removed.
- fast/css/deferred-parsing/simple-style-in-document-expected.txt: Removed.
- fast/css/deferred-parsing/simple-style-in-document.html: Removed.
- fast/css/deferred-parsing/supports-rule-expected.txt: Removed.
- fast/css/deferred-parsing/supports-rule.html: Removed.
- platform/ios-wk2/TestExpectations:
- platform/ios/TestExpectations:
- 3:13 AM Changeset in webkit [294006] by
-
- 3 edits in trunk/Source/WebCore
Create a stopped CacheStorageConnection for workers in case of detached documents
https://bugs.webkit.org/show_bug.cgi?id=240224
<rdar://problem/92853663>
Reviewed by Chris Dumez.
A worker might not always have a main thread connection as its document may be detached.
In that case, we now create a StoppedCacheStorageConnection that will always return Error::Stopped to any callback.
Covered by existing tests.
- Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::StoppedCacheStorageConnection::create):
(WebCore::createMainThreadConnection):
(WebCore::WorkerCacheStorageConnection::WorkerCacheStorageConnection):
(WebCore::WorkerCacheStorageConnection::~WorkerCacheStorageConnection):
(WebCore::WorkerCacheStorageConnection::create): Deleted.
- Modules/cache/WorkerCacheStorageConnection.h:
- 1:52 AM Changeset in webkit [294005] by
-
- 6 edits in trunk/Source/WebKit
RemoteVideoFrameObjectHeapProxyProcessor binary semaphore usage might trigger deadlocks in case of GPUProcess crash
https://bugs.webkit.org/show_bug.cgi?id=240161
<rdar://problem/92849827>
Reviewed by Eric Carlson.
In case of GPUProcess crash when waiting for a converted buffer, we would never call the semaphore signal method.
This would hang the main thread since this code path is main thread only.
To prevent this, we use synchronous IPC to send the buffer conversion order.
Once it is done, we use the binary semaphore to synchronize the main thread with the work queue on which we are receiving the converted buffer.
It is ok to use a binary semaphore at that point since we know the web process has or is processing the converted buffer IPC messages.
We also make sure to recreate the SharedVideoFrameWriter in case it was disabled due the GPUProcess connection being closed.
Covered by existing tests, in particular LayoutTests/webrtc/captureCanvas-webrtc.html.
- GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
(WebKit::RemoteVideoFrameObjectHeap::convertBuffer):
- GPUProcess/media/RemoteVideoFrameObjectHeap.h:
- GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in:
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
(WebKit::RemoteVideoFrameObjectHeapProxyProcessor::getNativeImage):
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.h:
- WebProcess/GPU/webrtc/SharedVideoFrame.h:
(WebKit::SharedVideoFrameWriter::isDisabled const):
- 12:45 AM Changeset in webkit [294004] by
-
- 2 edits in trunk/Source/WebCore
com.apple.WebKit.GPU leaks CMBlockBuffer
https://bugs.webkit.org/show_bug.cgi?id=240267
rdar://92655222
Patch by Jean-Yves Avenard <jean-yves.avenard@apple.com> on 2022-05-09
Reviewed by Jer Noble.
- platform/graphics/cocoa/CMUtilities.mm:
(WebCore::toCMSampleBuffer): adopt newly created CMBlockBuffer rather than increase the refcount.
# Please populate the above commit message. Lines starting
# with '#' will be ignored
# com.apple.WebKit.GPU leaks CMBlockBuffer
# https://bugs.webkit.org/show_bug.cgi?id=240267
# rdar://92655222
#
# Reviewed by Jer Noble.
#
# * platform/graphics/cocoa/CMUtilities.mm:
# (WebCore::toCMSampleBuffer): adopt newly created CMBlockBuffer rather than increase the refcount.
# On branch bz/240267
# Your branch is ahead of 'origin/main' by 1 commit.
# (use "git push" to publish your local commits)
#
# Changes to be committed:
# (use "git restore --staged <file>..." to unstage)
# modified: Source/WebCore/ChangeLog
#
# Please populate the above commit message. Lines starting
# with '#' will be ignored
# On branch bz/240267
# Your branch is ahead of 'origin/main' by 1 commit.
# (use "git push" to publish your local commits)
#
# nothing to commit, working tree clean
Canonical link: https://commits.webkit.org/250440@main
May 9, 2022:
- 11:53 PM Changeset in webkit [294003] by
-
- 2 edits in trunk/Source/WebCore
Check if node is connected after calling mergeWithNeighboringLists
https://bugs.webkit.org/show_bug.cgi?id=240234
Patch by Rob Buis <rbuis@igalia.com> on 2022-05-09
Reviewed by Wenson Hsieh.
Check if node is connected after calling mergeWithNeighboringLists since
DOM mutations can change the DOM tree.
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApplyForSingleParagraph):
- 11:52 PM Changeset in webkit [294002] by
-
- 19 edits2 adds in trunk
[cssom] Don't index perspective/transform-origin-* in computed styles
https://bugs.webkit.org/show_bug.cgi?id=239670
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update some test expectations.
Add serialize-all-longhands.html, it still fails due to
https://webkit.org/b/239965 and https://webkit.org/b/239989.
- web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
- web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- web-platform-tests/css/cssom/serialize-all-longhands-expected.txt: Added.
- web-platform-tests/css/cssom/serialize-all-longhands.html: Added.
Source/WebCore:
'perspective-origin' and 'transform-origin' are shorthands in WebKit.
The longhands are 'perspective-origin-x/y' and 'transform-origin-x/y/z'.
But these aren't standard properties, so they serialize to empty string
in computed styles. However, they were still indexed.
This patch stops indexing these longhands, so they won't appear when
iterating a computed style. Also, the shorthands will now be indexed.
Test: fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html
imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html
imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer.html
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
imported/w3c/web-platform-tests/css/cssom/serialize-all-longhands.html
svg/css/getComputedStyle-basic.xhtml
- css/CSSProperties.json:
Add "computable" flag.
- css/makeprop.pl:
(skippedFromComputedStyle):
(addProperty):
Let "computable" flag override default logic for indexing or not in
computed styles.
Tools:
Add checker for new "computable" flag.
- Scripts/webkitpy/style/checkers/jsonchecker.py:
(JSONCSSPropertiesChecker.check_codegen_properties):
LayoutTests:
Update test expectations.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 11:48 PM Changeset in webkit [294001] by
-
- 13 edits in trunk
Support ray() shape in offset-path
https://bugs.webkit.org/show_bug.cgi?id=233344
Reviewed by Simon Fraser.
Source/WebCore:
Add support for rendering ray path. Involves getting containing block and offset
of the element from the containing block. Using the size of the containing block
and offset, calculate the length of the ray and create a Line path using the length
and angle. Calculating closest/farthest-side and closest/farthest-corner are simple
but calculating side requires some explanation. First, we get the two possible sides of
the containing block the ray could be intersecting with, based on the angle. To calculate
which side is being intersected, if tan(theta) * top/bottom is outside of the containing
block, this means that the ray is intersecting with the other side. Finally, we calculate
the acute angle based on which side we intersected with. Using the length and angle, we
calculate the length of the hypotenuse, which corresponds with the length of the start point
of the ray to its intersection with a side of the containing block. Test 7 is still failing
due to getting incorrect width of containing block (doesn't happen when animating the path
for some reason). Will implement contain in another patch.
- WebCore.xcodeproj/project.pbxproj:
- rendering/PathOperation.cpp:
(WebCore::toPositiveAngle):
(WebCore::RayPathOperation::getLengthForPath const):
(WebCore::RayPathOperation::pathForReferenceRect const):
- rendering/PathOperation.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setReferenceBoxForPathOperations):
(WebCore::RenderLayer::updateTransform):
- rendering/RenderLayer.h:
- rendering/style/RenderStyle.cpp:
(WebCore::getPathFromPathOperation):
LayoutTests:
- 10:20 PM Changeset in webkit [294000] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, address Darin's feedback on r250361.
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::toIntegerWithoutRounding const):
Normalize away -0 by unconditionally adding positive 0 (instead of making a separate zero check).
- 10:08 PM Changeset in webkit [293999] by
-
- 2 edits in trunk
Introduction.md: Explain active DOM objects
https://bugs.webkit.org/show_bug.cgi?id=240212
Reviewed by Chris Dumez.
Added an elementary description of active DOM objects to Introduction.md.
- Introduction.md:
- 9:41 PM Changeset in webkit [293998] by
-
- 2 edits in trunk/Source/WebCore
Do not use the cached renderer's parent in handleFragmentedFlowStateChange lambda
https://bugs.webkit.org/show_bug.cgi?id=240266
Reviewed by Simon Fraser.
- rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::normalizeTreeAfterStyleChange):
- 8:49 PM Changeset in webkit [293997] by
-
- 9 edits in trunk
Temporal round and total methods should accept string param
https://bugs.webkit.org/show_bug.cgi?id=240249
Reviewed by Yusuke Suzuki.
This patch implements https://github.com/tc39/proposal-temporal/pull/1875,
which allows certain required string options to be passed directly instead of as part of an options object.
Namely:
{Duration, Instant, PlainTime}::roundnow acceptsmallestUnitas a string paramDuration::totalnow acceptsunitas a string param
- stress/temporal-duration.js:
- stress/temporal-instant.js:
- stress/temporal-plaintime.js:
Add test cases.
- test262/expectations.yaml:
Mark 24 test cases passing.
(This number should be 26, but two still fail as the harness expects PlainDateTime and ZonedDateTime to exist.)
- runtime/TemporalDuration.cpp:
(JSC::TemporalDuration::round const):
(JSC::TemporalDuration::total const):
- runtime/TemporalInstant.cpp:
- runtime/TemporalPlainTime.cpp:
(JSC::TemporalPlainTime::round const):
Canonical link: https://commits.webkit.org/250433@main
- 7:52 PM Changeset in webkit [293996] by
-
- 6 edits in trunk
Temporal and Date must reject expanded year -000000
https://bugs.webkit.org/show_bug.cgi?id=240263
Reviewed by Yusuke Suzuki.
As of the following two PRs, -000000 is officially disallowed as a representation of the year zero in ISO date strings.
https://github.com/tc39/ecma262/pull/2550
https://github.com/tc39/proposal-temporal/pull/1992
This patch implements the change for Temporal and Date alike.
- test262/expectations.yaml:
Mark 24 test cases as passing.
- runtime/ISO8601.cpp:
(JSC::ISO8601::parseDate):
- wtf/DateMath.cpp:
(WTF::parseES5DatePortion):
Canonical link: https://commits.webkit.org/250432@main
- 5:16 PM Changeset in webkit [293995] by
-
- 7 edits in branches/safari-613-branch
Cherry-pick r292888. rdar://problem/80059355
[iOS] [WK2] Managed pasteboard should function for all managed domains
https://bugs.webkit.org/show_bug.cgi?id=239319
rdar://80059355
Reviewed by Kate Cheney.
Source/WebCore/PAL:
Add an SPI method on
MCProfileConnection.
- pal/spi/ios/ManagedConfigurationSPI.h:
Source/WebKit:
Unless a WebKit client has specified a data owner for the web view that is not _UIDataOwnerUndefined, fall back
to _UIDataOwnerEnterprise when the current domain of the WKWebView is managed (that is, `-[MCProfileConnection
isURLManaged:]` returns YES for the web view's current URL). This allows managed pasteboard to work for all
WebKit clients, if the current URL is managed.
Test: UIPasteboardTests.PerformAsDataOwnerWithManagedURL
- Platform/spi/ios/UIKitSPI.h:
Drive-by fix: move the staged declarations of
-_dataOwnerForCopyand-_dataOwnerForPasteout of the IPI
section, and into the non-internal SDK section.
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _dataOwnerForPasteboard:]):
Tools:
Add a new API test to verify that we fall back to consulting
-[MCProfileConnection isURLManaged:]when
determining the data owner for copy and paste, unless a data owner is already explicitly set on a view in the
responder chain (specifically, the WKWebView).
- TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: (+[TestUIPasteboard _performAsDataOwner:block:]): (-[TestMCProfileConnection isURLManaged:]): (TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/249658@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:06 PM Changeset in webkit [293994] by
-
- 13 edits in trunk/Source
[iOS] Adjust some viewport behaviors when multitasking mode is enabled
https://bugs.webkit.org/show_bug.cgi?id=240151
rdar://87157773
Reviewed by Tim Horton.
Add a new ViewportConfiguration flag to prefer horizontal scrolling over shrinking to fit when the view layout
size falls under the current "default desktop webpage" of 980pt. See WebKit changes for more details.
- page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::initialScaleFromSize const):
(WebCore::ViewportConfiguration::webpageParameters):
(WebCore::ViewportConfiguration::imageDocumentParameters):
Pull the magic value representing the "assumed width of most desktop webpages" (980) out into a named constant,
defaultDesktopViewportWidth, so that we can consult it when computing the initial scale.
(WebCore::ViewportConfiguration::description const):
- page/ViewportConfiguration.h:
(WebCore::ViewportConfiguration::setPrefersHorizontalScrollingBelowDesktopViewportWidths):
[iOS] Adjust some viewport behaviors when multitasking mode is enabled
https://bugs.webkit.org/show_bug.cgi?id=240151
rdar://87157773
Reviewed by Tim Horton.
Make some adjustments to viewport behaviors when multitasking mode is enabled. See the comments below for more
details. There are no changes in behavior when multitasking mode is disabled; tests for the new behaviors in
multitasking mode will be added in a subsequent patch.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
Add plumbing to inform the web process when "multitasking mode" state changes; we use this bit in WebPage to
determine whether or not we should use multitasking mode viewport behaviors (see below).
- UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _registerForNotifications]):
(-[WKWebView didMoveToWindow]):
(-[WKWebView _multitaskingModeDidChange:]):
Send IPC to WebPage in these two places, to keep "multitasking mode" state in sync with the native view.
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
Make a minor adjustment here to ignore
oldWebViewWidthInContentViewCoordinateswhen computing a target scale
to zoom to when performing animated resize, in multitasking mode. This is required to prevent us from zooming
in excessively when the width of the view increases, since we'd otherwise attempt to keep the same content in
the page visible by zooming in (for instance, if an image covers most of the visual viewport at a lower view
width, thismin()logic would cause us to zoom in, such that the image would still cover most of the viewport
at a larger width). This behavior is undesirable in multitasking mode.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setIsInMultitaskingMode):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
(WebKit::WebPage::setIsInMultitaskingMode):
Add plumbing to set the
m_isInMultitaskingModeflag on WebPage, and update the viewport configuration flag to
prefer horizontal scrolling below 980pt.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::scaleAfterViewportWidthChange):
Refactor a bit of code here (without changing any behaviors), to make it a bit clearer:
- Rename
userHasChangedPageScaleFactortoscaleToFitContentto better describe how this flag affects the
adjusted target scale during dynamic resize.
- Make the log messages specific to both branches, and also log the adjusted viewport scale instead of the
(currently unused) given
scalein the non-scaleToFitContentcodepath.
(WebKit::WebPage::dynamicViewportSizeUpdate):
Make another "multitasking mode viewport behavior" adjustment here by maintaining the initial scale (only if the
viewport was already at initial scale) when performing dynamic viewport size updates. By default, we currently
adjust the scale such that the same content is still visible at the new viewport size; however, when allowing
horizontal scrolling, this causes us to zoom in excessively when making the window width larger. Instead, when
multitasking mode is enabled, we should try to preserve initial scale when changing window size, such that only
the horizontal scroll amount changes.
(WebKit::WebPage::usesMultitaskingModeViewportBehaviors const):
Add a helper method to encapsulate whether or not multitasking mode viewport behaviors should be used; this
should be true only when both desktop-class viewport behaviors are active, *and* multitasking mode is also
active.
Canonical link: https://commits.webkit.org/250431@main
- 4:50 PM Changeset in webkit [293993] by
-
- 42 edits in trunk/Source/WebCore
Const-ify Node::willRespondTo*Events()
https://bugs.webkit.org/show_bug.cgi?id=240246
Reviewed by Wenson Hsieh.
Constify these four methods, because there's no
reason for them not to be, and because it makes
them usable in a const context in a future patch.
- dom/EventNames.h:
(WebCore::EventNames::isTouchRelatedEventType const):
- dom/EventTarget.cpp:
(WebCore::EventTarget::eventTypes const):
- dom/EventTarget.h:
- dom/Node.cpp:
(WebCore::Node::willRespondToMouseMoveEvents const):
(WebCore::Node::willRespondToTouchEvents const):
(WebCore::Node::willRespondToMouseClickEvents const):
(WebCore::Node::willRespondToMouseWheelEvents const):
- dom/Node.h:
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::willRespondToMouseClickEvents const):
- html/HTMLAnchorElement.h:
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::willRespondToMouseClickEvents const):
- html/HTMLButtonElement.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::willRespondToMouseMoveEvents const):
(WebCore::HTMLElement::willRespondToMouseWheelEvents const):
(WebCore::HTMLElement::willRespondToMouseClickEvents const):
- html/HTMLElement.h:
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::willRespondToMouseClickEvents const):
- html/HTMLImageElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::willRespondToMouseClickEvents const):
- html/HTMLInputElement.h:
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::willRespondToMouseClickEvents const):
- html/HTMLLabelElement.h:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::willRespondToMouseClickEvents const):
- html/HTMLPlugInElement.h:
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::willRespondToMouseClickEvents const):
- html/HTMLSelectElement.h:
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::willRespondToMouseClickEvents const):
- html/HTMLSummaryElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::willRespondToMouseClickEvents const):
- html/HTMLTextAreaElement.h:
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::shouldSpinButtonRespondToMouseEvents const):
(WebCore::TextFieldInputType::shouldSpinButtonRespondToWheelEvents const):
- html/TextFieldInputType.h:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents const):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents const):
- html/shadow/SliderThumbElement.h:
- html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents const):
(WebCore::SpinButtonElement::willRespondToMouseClickEvents const):
(WebCore::SpinButtonElement::shouldRespondToMouseEvents const):
- html/shadow/SpinButtonElement.h:
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::willRespondToMouseClickEvents const):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents const):
- html/shadow/TextControlInnerElements.h:
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::willRespondToMouseClickEvents const):
- mathml/MathMLElement.h:
- mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::willRespondToMouseClickEvents const):
- mathml/MathMLSelectElement.h:
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::willRespondToMouseClickEvents const):
- svg/SVGAElement.h:
- 4:03 PM Changeset in webkit [293992] by
-
- 4 edits in trunk/Websites/bugs.webkit.org
[bugs.webkit.org] Use GitHub as baseline when diffing
https://bugs.webkit.org/show_bug.cgi?id=240073
<rdar://problem/92741303>
Reviewed by Ryan Haddad and Dewei Zhu.
- Websites/bugs.webkit.org/code-review.js: Use GitHub instead of
Subversion for tip-of-tree baseline, blame and log links.
- Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb: Ditto.
Use GitHub instead of Subversion for tip-of-tree baseline.
Canonical link: https://commits.webkit.org/250429@main
- 4:02 PM Changeset in webkit [293991] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
Unreviewed build fix; disable -Wimplicit-fallthrough in libwebrtc
- Configurations/Base.xcconfig:
- 2:17 PM Changeset in webkit [293990] by
-
- 4 edits in trunk/Source
[macOS] HTTP traffic is not filtered in the parental controls filter
https://bugs.webkit.org/show_bug.cgi?id=240180
<rdar://problem/92875540>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Traditionally, we have not filtered HTTP in the parental controls filter on macOS, since other parts of the system
has taken care of this. This has changed in the most recent macOS version, and WebKit should also filter HTTP in
addition to HTTPS.
- platform/cocoa/ParentalControlsContentFilter.mm:
(WebCore::canHandleResponse):
Source/WTF:
Add HAVE macro which tells us which OS versions are filtering HTTP traffic on behalf of WebKit.
- wtf/PlatformHave.h:
- 1:56 PM Changeset in webkit [293989] by
-
- 5 edits in trunk/Source/WebCore
Cache the viewport size inside SVGLengthContext
https://bugs.webkit.org/show_bug.cgi?id=240157
Reviewed by Alan Bujtas.
Each call to SVGLengthContext::determineViewport() did an ancestor element walk
looking for a viewport element, and some call sites hit this two or more times
(e.g. for width, then height). So cache m_viewportSize in the class, modernizing
the code to use optionals.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::referenceBoxRect const):
- rendering/svg/LegacyRenderSVGRoot.cpp:
(WebCore::LegacyRenderSVGRoot::computeFloatVisibleRectInContainer const):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::clipPathReferenceBox):
- svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::valueForLength):
(WebCore::SVGLengthContext::convertValueToUserUnits const):
(WebCore::SVGLengthContext::convertValueFromUserUnitsToPercentage const):
(WebCore::SVGLengthContext::convertValueFromPercentageToUserUnits const):
(WebCore::SVGLengthContext::viewportSize const):
(WebCore::SVGLengthContext::computeViewportSize const):
(WebCore::SVGLengthContext::determineViewport const): Deleted.
- svg/SVGLengthContext.h:
- 1:43 PM Changeset in webkit [293988] by
-
- 2 edits in trunk/Source/WebKit
Allow log streaming from webpushd
https://bugs.webkit.org/show_bug.cgi?id=240238
Reviewed by Per Arne Vollan.
log streamoutputs nothing from webpushd because we blocked the diagnosticd service in its
sandbox. We should allow that and also block awdd since it's unlikely that webpushd needs
access to the wireless diagnostics daemon.
- webpushd/mac/com.apple.WebKit.webpushd.sb.in:
Canonical link: https://commits.webkit.org/250425@main
- 1:37 PM Changeset in webkit [293987] by
-
- 16 edits2 adds in trunk
Implement CSS :modal pseudo class
https://bugs.webkit.org/show_bug.cgi?id=240109
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
Add and extend tests for :modal pseudo-class.
- web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has-expected.txt: Added.
- web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has.html: Added.
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-show-modal.html:
Source/WebCore:
Test: imported/w3c/web-platform-tests/css/selectors/invalidation/modal-pseudo-class-in-has.html
Renames :-internal-modal-dialog to :modal and adds :has() invalidation support.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText const):
- css/CSSSelector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):
- css/SelectorCheckerTestFunctions.h:
(WebCore::matchesModalPseudoClass):
(WebCore::matchesModalDialogPseudoClass): Deleted.
- css/SelectorPseudoClassAndCompatibilityElementMap.in:
- css/dialog.css:
(dialog:modal):
(dialog:-internal-modal-dialog): Deleted.
- css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::consumePseudo):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::JSC_DEFINE_JIT_OPERATION):
(WebCore::SelectorCompiler::addPseudoClassType):
- html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::showModal):
(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::removedFromAncestor):
(WebCore::HTMLDialogElement::setIsModal):
- html/HTMLDialogElement.h:
LayoutTests:
Removes :-internal-modal-dialog from internal pseudo classes.
- fast/css/pseudo-class-internal-expected.txt:
- fast/css/pseudo-class-internal.html:
- 1:04 PM Changeset in webkit [293986] by
-
- 4 edits in trunk/Tools
[git-webkit] Verify forks after creation
https://bugs.webkit.org/show_bug.cgi?id=240085
<rdar://problem/92978491>
Reviewed by Stephanie Lewis.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.github): Check parent of fork, wait until fork is created before continuing.
Canonical link: https://commits.webkit.org/250423@main
- 12:40 PM Changeset in webkit [293985] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, build fix for Internal iOS build
https://bugs.webkit.org/show_bug.cgi?id=240206
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateTouchEventTracking):
- 12:10 PM Changeset in webkit [293984] by
-
- 3 edits1 add in trunk/Source/WebKit
WebKit has a broken module in Mac Catalyst
https://bugs.webkit.org/show_bug.cgi?id=240175
rdar://92703419
Patch by Ian Anderson <iana@apple.com> on 2022-05-09
Reviewed by Tim Horton.
Add a module map for Mac Catalyst that excludes WebKit/WebKitLegacy.h,
matching the exclusion from WebKit/WebKit.h.
- Configurations/WebKit.xcconfig:
- Modules/MacCatalyst.modulemap: Added.
- WebKit.xcodeproj/project.pbxproj:
- 11:48 AM Changeset in webkit [293983] by
-
- 1 copy in branches/safari-7614.1.13-branch
New branch.
- 11:27 AM Changeset in webkit [293982] by
-
- 2 edits in trunk/LayoutTests
[GLIB] Update some test expectations for known failures
https://bugs.webkit.org/show_bug.cgi?id=240240
Unreviewed test garderning.
Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-05-09
- platform/glib/TestExpectations:
- 10:44 AM Changeset in webkit [293981] by
-
- 2 edits in trunk/Source/WebCore
ASSERT in WebCore::RenderTreeUpdater::updateRenderTree
https://bugs.webkit.org/show_bug.cgi?id=240237
Reviewed by Antti Koivisto.
There are instances where calling findRenderingRoots() in RenderTreeUpdater::commit will
returns two rendering roots, with one of them being an ancestor of the other.
Calling updateRenderTree on the ancestor rendering root could end up removing
the renderer of the descendant rendering root.
This patch merges findRenderingRoots() to RenderTreeUpdater::commit() which, and now we will
ignore the nested root if there is no longer a renderer when it is being processed.
- rendering/updating/RenderTreeUpdater.cpp:
- 10:32 AM Changeset in webkit [293980] by
-
- 5 edits2 adds in trunk
[iOS] Double tapping on YouTube video causes playback to pause instead of seek
https://bugs.webkit.org/show_bug.cgi?id=240222
rdar://92637636
Reviewed by Aditya Keerthi and Kate Cheney.
Add a new layout test. See WebKit/ChangeLog for more details.
- fast/events/touch/ios/touch-events-when-double-tapping-after-selecting-text-expected.txt: Added.
- fast/events/touch/ios/touch-events-when-double-tapping-after-selecting-text.html: Added.
[iOS] Double tapping on YouTube video causes playback to pause instead of seek
https://bugs.webkit.org/show_bug.cgi?id=240222
rdar://92637636
Reviewed by Aditya Keerthi and Kate Cheney.
Add a new compile-time flag to guard the presence of
-[UITextInteractionAssistant contextMenuInteraction]. See
WebKit/ChangeLog for more details.
- wtf/PlatformHave.h:
[iOS] Double tapping on YouTube video causes playback to pause instead of seek
https://bugs.webkit.org/show_bug.cgi?id=240222
rdar://92637636
Reviewed by Aditya Keerthi and Kate Cheney.
On some recent versions of iOS,
UITextInteractionAssistantinstalls its own context menu interaction by
default. This makes UIKit introduce a_UIRelationshipGestureRecognizerto the gesture recognizer graph when
using WKWebView when the text interaction assistant has been activated in order to implement the asynchronous
context menu configuration API.
Currently, we add a direct failure requirement from the immediately resettable deferring gesture to this new
UIKit relationship gesture. This is problematic, since the context menu interaction will automatically add
failure requirements to other long press gestures on the web view, such as the image analysis gestures that
trigger Live Text analysis when long pressing on images with text. As a result, the set of immediately
resettable gestures is now connected to the set of delayed resettable gestures after the first tap when
performing a double tap gesture. Since theUIWebTouchEventsGestureRecognizeris a part of this immediate reset
subgraph, this means that the touch event gesture recognizer doesn't get reset until about 320 ms after a tap
when the text interaction assistant has been activated, due to this new context menu interaction.
On YouTube.com, this manifests in a double-tap on the main video player being broken since a double tap gesture
only dispatchestouchstartandtouchendon the first tap, and YouTube's script only seeks forwards or
backwards if it observes twotouchstartevents that are close to each other within 350 ms.
To fix this, we simply teach the deferring gesture subgraph partitioning logic in
-deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:to funnel the relationship gesture (i.e.
-gestureRecognizerForFailureRelationships) of the text interaction assistant's context menu interaction into
the delayed reset subgraph instead of the immediate reset subgraph.
Test: fast/events/touch/ios/touch-events-when-double-tapping-after-selecting-text.html
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView deferringGestureRecognizer:shouldDeferOtherGestureRecognizer:]):
- UIProcess/ios/WKDeferringGestureRecognizer.mm:
(-[WKDeferringGestureRecognizer shouldDeferGestureRecognizer:]):
Canonical link: https://commits.webkit.org/250418@main
- 9:52 AM Changeset in webkit [293979] by
-
- 3 edits in trunk/Source/WebKit
Create reports for long process launch times
https://bugs.webkit.org/show_bug.cgi?id=240127
Unreviewed, fix typo.
- UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::connect):
(WebKit::AuxiliaryProcessProxy::didFinishLaunching):
- UIProcess/AuxiliaryProcessProxy.h:
- 9:41 AM Changeset in webkit [293978] by
-
- 2 edits in trunk/Source/WebCore
AXLogger::streamAXCoreObject is missing a null check for AccessibilityObject dynamicDowncast
https://bugs.webkit.org/show_bug.cgi?id=240228
Reviewed by Andres Gonzalez.
When checking if an object has display:contents, we do:
if (auto* axObject = dynamicDowncast<AccessibilityObject>(&object); axObject->hasDisplayContents())
Which does not have a nullcheck for when the dynamicDowncast fails (i.e. because
the object is not an AccessibilityObject).
- accessibility/AXLogger.cpp:
(WebCore::streamAXCoreObject):
- 9:22 AM Changeset in webkit [293977] by
-
- 25 edits2 adds in trunk
Image controls menu button is not appearing for multi-page PDFs
https://bugs.webkit.org/show_bug.cgi?id=240120
rdar://86425721
Reviewed by Megan Gardner.
Source/WebCore:
Test: fast/attachment/attachment-image-controls-basic.html
Refactor image controls button code so it can also be used for PDF
attachments.
- dom/mac/ImageControlsMac.cpp:
(WebCore::ImageControlsMac::handleEvent):
(WebCore::ImageControlsMac::isImageMenuEnabled):
(WebCore::ImageControlsMac::updateImageControls):
(WebCore::ImageControlsMac::tryCreateImageControls):
(WebCore::ImageControlsMac::destroyImageControls):
(WebCore::ImageControlsMac::hasImageControls):
- dom/mac/ImageControlsMac.h:
Handle the PDF case when a click on the image controls button happens.
Move all image controls code to ImageControlsMac where it can be
shared by image and attachment elements.
- html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::parseAttribute):
(WebCore::HTMLAttachmentElement::childShouldCreateRenderer const):
- html/HTMLAttachmentElement.h:
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::didAttachRenderers):
(WebCore::HTMLImageElement::setAttachmentElement):
(WebCore::HTMLImageElement::updateImageControls): Deleted.
(WebCore::HTMLImageElement::tryCreateImageControls): Deleted.
(WebCore::HTMLImageElement::destroyImageControls): Deleted.
(WebCore::HTMLImageElement::hasImageControls const): Deleted.
- html/HTMLImageElement.h:
(WebCore::HTMLImageElement::isImageMenuEnabled const):
(WebCore::HTMLImageElement::setImageMenuEnabled):
(WebCore::HTMLImageElement::imageMenuEnabled const): Deleted.
- html/shadow/mac/imageControlsMac.css:
The image controls button was originally offset by 20px from the top
and the right. This causes the image controls button to appear in the
middle of a PDF attachment and be difficult to see. This change makes
it flush against the top right corner for both images and PDFs.
(button#image-controls-button):
- page/ChromeClient.h:
(WebCore::ChromeClient::handlePDFServiceClick):
- rendering/RenderAttachment.cpp:
(WebCore::RenderAttachment::RenderAttachment):
(WebCore::RenderAttachment::layout):
(WebCore::RenderAttachment::layoutShadowContent):
- rendering/RenderAttachment.h:
Add canHaveGeneratedChildren() and canHaveChildren() so that
we render the image controls button in the shadow tree.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
- testing/Internals.cpp:
(WebCore::Internals::hasImageControls const):
Source/WebKit:
Refactor image controls button code so it can also be used for PDF
attachments.
- Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::controlledDataIsEditable const):
We need to make sure PDF attachments are marked as editable so the
context menu gets properly populated.
- Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::ContextMenuContextData):
- UIProcess/API/Cocoa/APIAttachmentCocoa.mm:
(API::Attachment::enclosingImageNSData const):
Remove the image check so we return the PDF NSData in the attachment
case.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::handlePDFServiceClick):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::handlePDFServiceClick):
Plumbing for handling a click on the image controls button for PDFs.
LayoutTests:
- TestExpectations:
- fast/attachment/attachment-image-controls-basic.html: Added.
- platform/mac-wk2/TestExpectations:
- platform/mac/fast/attachment/attachment-image-controls-basic-expected.txt: Added.
- 8:48 AM Changeset in webkit [293976] by
-
- 4 edits in trunk
Make input placeholder line-height declaration !important
https://bugs.webkit.org/show_bug.cgi?id=240225
Reviewed by Tim Nguyen.
Source/WebCore:
This is the same the changes made in chromium at
https://chromium-review.googlesource.com/c/chromium/src/+/3594234
and Firefox change at
https://phabricator.services.mozilla.com/D116907
- css/html.css:
(input::placeholder):
LayoutTests:
Unskip the test that passes.
- 8:17 AM Changeset in webkit [293975] by
-
- 3 edits2 adds in trunk
REGRESSION (r291817): NativeImage passed to RemoteResourceCacheProxy::recordNativeImageUse may be null
https://bugs.webkit.org/show_bug.cgi?id=239649
rdar://92018859
Reviewed by Dean Jackson.
Test: system-preview/svg-image.html
In the case of an <img> pointing to an SVG resource, the nativeImage() is null. We need to handle this case
properly (filed bug 239673), but for now we can at least not crash.
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawSystemImage):
Canonical link: https://commits.webkit.org/250413@main
- 7:57 AM Changeset in webkit [293974] by
-
- 2 edits in trunk/JSTests
Unreviewed test gardening.
- test262/expectations.yaml:
- 7:46 AM Changeset in webkit [293973] by
-
- 2 edits in trunk/Tools
Test262 runner should show progress
https://bugs.webkit.org/show_bug.cgi?id=240181
Reviewed by Yusuke Suzuki.
The progress will appear as something like [42/245669].
- Scripts/test262/Runner.pm:
(processCLI):
(main):
Canonical link: https://commits.webkit.org/250411@main
- 7:18 AM WebKitGTK/2.36.x edited by
- (diff)
- 7:05 AM Changeset in webkit [293972] by
-
- 3 edits in trunk/Source/WebCore
CoreAudioCaptureSource::settingsDidChange should not reconfigure the audio unit if CoreAudioCaptureSource is not started
https://bugs.webkit.org/show_bug.cgi?id=240059
Reviewed by Eric Carlson.
We should only ask to reconfigure when source settings change if the source is actually started.
Otherwise, we can wait for the source to start to actually set the unit values and reconfigure if needed.
To make sure to correctly expose settings, we reset them in CoreAudioCaptureSource::settingsDidChange and in
CoreAudioCaptureSource::initializeToStartProducingData.
We also only use the audio unit sample rate if it is rendering audio, otherwise we can change the sample rate at will.
Manually tested.
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
- 3:54 AM Changeset in webkit [293971] by
-
- 2 edits in trunk/Source/WebCore
[Nicosia] Canvas animations don't work with threaded rendering
https://bugs.webkit.org/show_bug.cgi?id=227760
<rdar://problem/80588913>
Reviewed by Adrian Perez de Castro.
Implement Nicosia::CairoOperationRecorder::draImageBuffer(), which is required in order to paint
canvas contents into a GraphicsContext.
- platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
(Nicosia::CairoOperationRecorder::drawImageBuffer):
- 3:47 AM Changeset in webkit [293970] by
-
- 4 edits in trunk
[WinCairo][WK1] accessibility/aria-combobox-control-owns-elements.html is crashing after 250325@main
https://bugs.webkit.org/show_bug.cgi?id=240218
<rdar://problem/92929718>
Reviewed by Joanmarie Diggs.
Source/WebCore:
Fix a wrong ASSERT for AriaReflectionForElementReferencesEnabled.
If AriaReflectionForElementReferencesEnabled is disabled, and you set
one of the attributes that have reflection under that flag,
we'll hit an ASSERT in Element::attributeChanged().
The fact that we set such attribute doesn't mean that the flag
has to be enabled.
Removed the ASSERT and added an if to check if the flag is enabled,
otherwise we don't need to do anything with the map.
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
LayoutTests:
- platform/wincairo-wk1/TestExpectations: Mark test as timeout as it
was before r293958.
- 1:41 AM Changeset in webkit [293969] by
-
- 8 edits in trunk/Source
Unreviewed, non-unified build fixes after r293562
Source/WebCore:
- workers/shared/context/SharedWorkerThread.cpp:
- workers/shared/context/SharedWorkerThreadProxy.cpp:
Source/WebKit:
- NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h:
- WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp:
(WebKit::WebSharedWorkerContextManagerConnection::launchSharedWorker):
Source/WTF:
- wtf/text/StringCommon.h:
May 8, 2022:
- 11:28 PM Changeset in webkit [293968] by
-
- 4 edits in trunk/Source
[macOS] REGRESSION (r293825): Find highlight snapshots are incorrectly scaled
https://bugs.webkit.org/show_bug.cgi?id=240203
rdar://92892014
Reviewed by Tim Horton.
Source/WebCore:
takeSnapshots() depends on the snapshot ImageBuffer::resolutionScale() to
set the size of the TextIndicatorData image. r293825 scaled the size of
the ImageBuffer before creation and moved the scaling to the GraphicsContext.
So we have correct scaled pixels but the resolutionScale is 1. So we get
enlarged incorrect image.
The fix is to revert r293825 and fix the iOS snapshot without having to
change snapshotFrameRectWithClip().
- page/FrameSnapshotting.cpp:
(WebCore::snapshotFrameRectWithClip):
Source/WebKit:
In getShareableBitmapForImageBufferWithQualifiedIdentifier(), we used to
pass the backendSize as the srcRect and the backendSize as the destRect
to GraphicsContext::drawImageBuffer(). The backendSize is the logicalSize
scaled by the resolutionScale. But in ImageBufferCGBackend::draw() we
scale the srcRect by the resolutionScale one more time. This double-
scaled srcRect draws a srcRect whose size = backendSize * resolutionScale
to a destRect whose size = backendSize. And this results in shrinking the
desired snapshot image by 1 / resolutionScale.
- GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::getShareableBitmapForImageBufferWithQualifiedIdentifier):
- 11:14 PM Changeset in webkit [293967] by
-
- 18 edits in trunk/Source
Introduce EventTrackingRegions::Event enum
https://bugs.webkit.org/show_bug.cgi?id=240206
Reviewed by Mark Lam.
We noticed that EventNames 260~ AtomStrings are allocated in scrolling thread only because we are using
eventNames() for EventTrackingRegions. But since use of it is limited, we can just use enum instead.
- We can make EventTrackingRegions more efficient by using enum instead of String.
- We can save memory by avoiding EventNames string allocations & AtomStringTable registration.
- We can make this parameter more strictly typed compared to accepting any kind of Strings
- Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::dump):
- Source/WebKit/Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<EventTrackingRegions>::decode):
- Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::eventTrackingTypeForPoint const):
- Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.h:
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateTouchEventTracking):
- Source/WebCore/page/DebugPageOverlays.cpp:
(WebCore::NonFastScrollableRegionOverlay::drawRect):
- Source/WebCore/page/Page.cpp:
(WebCore::Page::touchEventRectsForEventForTesting):
- Source/WebCore/page/Page.h:
- Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame const):
- Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.cpp:
(WebCore::ScrollingStateFrameScrollingNode::dumpProperties const):
- Source/WebCore/page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::computeWheelProcessingSteps):
(WebCore::ScrollingTree::eventTrackingTypeForPoint):
- Source/WebCore/page/scrolling/ScrollingTree.h:
- Source/WebCore/platform/EventTrackingRegions.cpp:
(WebCore::EventTrackingRegions::eventName):
(WebCore::EventTrackingRegions::trackingTypeForPoint):
(WebCore::EventTrackingRegions::uniteSynchronousRegion):
- Source/WebCore/platform/EventTrackingRegions.h:
- Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::touchEventRectsForEvent):
- Source/WebCore/testing/Internals.h:
Canonical link: https://commits.webkit.org/250405@main
- 9:05 PM Changeset in webkit [293966] by
-
- 2 edits in branches/safari-7614.1.12-branch/Source/WebKit
Cherry-pick r293945. rdar://problem/92859012
Fix another internal build
https://bugs.webkit.org/show_bug.cgi?id=240201
<rdar://92859012>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-06
Reviewed by Alexey Proskuryakov.
Bug 240184 introduced a classic "but I have spaces in my path" bug.
- Configurations/adattributiond.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:05 PM Changeset in webkit [293965] by
-
- 4 edits1 add in branches/safari-7614.1.12-branch/Source/WebGPU
Cherry-pick r293937. rdar://problem/92524485
[WebGPU] Fix build on downlevel OSes in Apple's build system
https://bugs.webkit.org/show_bug.cgi?id=240159
<rdar://problem/92524485>
Reviewed by Alexey Proskuryakov.
Some variables from WebKitTargetConditionals.xcconfig and
PlatformSupport.xcconfig are used, so we have to make sure
we include them. Also refactor the INSTALL_PATH variable a
bit.
- Configurations/Base.xcconfig:
- Configurations/WebGPU.xcconfig:
- Configurations/WebKitTargetConditionals.xcconfig: Added.
- WebGPU.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:04 PM Changeset in webkit [293964] by
-
- 2 edits in branches/safari-7614.1.12-branch/Source/WebKit
Cherry-pick r293936. rdar://problem/92859012
Fix adattributiond build in internal build on older macOS
https://bugs.webkit.org/show_bug.cgi?id=240184
<rdar://92859012>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-06
Reviewed by Alexey Proskuryakov.
We need to search for WK_OVERRIDE_FRAMEWORKS_DIR to find the right frameworks
- Configurations/adattributiond.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:55 PM Changeset in webkit [293963] by
-
- 1 copy in tags/WebKit-7614.1.11.8
Tag WebKit-7614.1.11.8.
- 8:54 PM Changeset in webkit [293962] by
-
- 2 edits in branches/safari-614.1.11-branch/Source/WebKit
Cherry-pick r293945. rdar://problem/92859012
Fix another internal build
https://bugs.webkit.org/show_bug.cgi?id=240201
<rdar://92859012>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-06
Reviewed by Alexey Proskuryakov.
Bug 240184 introduced a classic "but I have spaces in my path" bug.
- Configurations/adattributiond.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:54 PM Changeset in webkit [293961] by
-
- 4 edits1 add in branches/safari-614.1.11-branch/Source/WebGPU
Cherry-pick r293937. rdar://problem/92524485
[WebGPU] Fix build on downlevel OSes in Apple's build system
https://bugs.webkit.org/show_bug.cgi?id=240159
<rdar://problem/92524485>
Reviewed by Alexey Proskuryakov.
Some variables from WebKitTargetConditionals.xcconfig and
PlatformSupport.xcconfig are used, so we have to make sure
we include them. Also refactor the INSTALL_PATH variable a
bit.
- Configurations/Base.xcconfig:
- Configurations/WebGPU.xcconfig:
- Configurations/WebKitTargetConditionals.xcconfig: Added.
- WebGPU.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:54 PM Changeset in webkit [293960] by
-
- 2 edits in branches/safari-614.1.11-branch/Source/WebKit
Cherry-pick r293936. rdar://problem/92859012
Fix adattributiond build in internal build on older macOS
https://bugs.webkit.org/show_bug.cgi?id=240184
<rdar://92859012>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-06
Reviewed by Alexey Proskuryakov.
We need to search for WK_OVERRIDE_FRAMEWORKS_DIR to find the right frameworks
- Configurations/adattributiond.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:45 PM Changeset in webkit [293959] by
-
- 9 edits in branches/safari-614.1.11-branch/Source
Versioning.
WebKit-7614.1.11.8
- 5:19 PM Changeset in webkit [293958] by
-
- 2 edits in trunk/LayoutTests
[WinCairo][WK1] accessibility/aria-combobox-control-owns-elements.html is crashing after 250325@main
https://bugs.webkit.org/show_bug.cgi?id=240218
<rdar://problem/92929718>
Unreviewed test gardening.
- platform/wincairo-wk1/TestExpectations: Skip it.
Canonical link: https://commits.webkit.org/250404@main
- 10:08 AM Changeset in webkit [293957] by
-
- 2 edits in trunk
Introduction.md: Fix typos found by mcatanzaro
https://bugs.webkit.org/show_bug.cgi?id=240211
Reviewed by Tim Nguyen.
Fixed typos.
- Introduction.md:
- 12:12 AM Changeset in webkit [293956] by
-
- 15 edits in trunk
Avoid resolving style for elements that only inherit changes from parent
https://bugs.webkit.org/show_bug.cgi?id=240132
<rdar://problem/92867346>
Reviewed by Sam Weinig.
Source/WebCore:
When an inherited property changes we need to update all descendant styles too. Currently this
is done by simply running the full style resolution for them including selector matching and
style building steps.
In the common case nothing changes in descendants expect the inherited properties. This patch implements
a fast-path mechanism that allows us to simply copy the relevant properties from the parent, skipping
all the other work. This is possible if we can prove that the value of these properties is not changed
by any rules targeting the child and that there are no other properties affected by this value change.
The mechanism is only implemented for the 'color' property for now. It can be expanded for other properties later.
It would be especially useful for custom properties.
- css/CSSProperties.json:
- css/makeprop.pl:
Add "fast-path-inherited" codegen property that disables the fast-path if the property is explicitly mutated.
(generateInitialValueSetter):
(generateValueSetter):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::fastPathInheritFrom):
Inherit fast path properties.
(WebCore::RenderStyle::fastPathInheritedEqual const):
(WebCore::RenderStyle::nonFastPathInheritedEqual const):
Test for fast-path property changes.
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::disallowsFastPathInheritance const):
(WebCore::RenderStyle::setDisallowsFastPathInheritance):
Track if can use the mechanism.
(WebCore::RenderStyle::NonInheritedFlags::operator== const):
- rendering/style/StyleInheritedData.cpp:
(WebCore::StyleInheritedData::operator== const):
(WebCore::StyleInheritedData::fastPathInheritedEqual const):
(WebCore::StyleInheritedData::nonFastPathInheritedEqual const):
(WebCore::StyleInheritedData::fastPathInheritFrom):
- rendering/style/StyleInheritedData.h:
- style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueFill):
(WebCore::Style::BuilderCustom::applyValueStroke):
- style/StyleBuilderState.cpp:
(WebCore::Style::BuilderState::colorFromPrimitiveValueWithResolvedCurrentColor const):
Color value 'currentcolor' is mostly resolved during use time but in the few places we still resolve it during style building
we need to disable the fast-path, since it makes other properties depend on 'color' property.
- style/StyleChange.cpp:
(WebCore::Style::determineChange):
New style change type for fast-path inheritance.
- style/StyleChange.h:
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::styleForStyleable):
Resolve by just copying properties from the parent.
(WebCore::Style::TreeResolver::computeDescendantsToResolve):
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::determineResolutionType):
Use fast-path if the only reason we are resolving this element is that some supported inherited property changed.
(WebCore::Style::TreeResolver::resolveComposedTree):
(WebCore::Style::TreeResolver::shouldResolveElement): Deleted.
- style/StyleTreeResolver.h:
Tools:
- Scripts/webkitpy/style/checkers/jsonchecker.py:
(JSONCSSPropertiesChecker.check_codegen_properties):
May 7, 2022:
- 10:50 PM Changeset in webkit [293955] by
-
- 7 edits in trunk/Source/WebCore
Add helper functions to queue task on Node with GCReachableRef
https://bugs.webkit.org/show_bug.cgi?id=240204
Reviewed by Chris Dumez.
Added Node::queueTaskKeepingThisNodeAlive, which queues a task to the event loop while keeping "this" Node
and its JS wrapper alive, and Node::queueTaskToDispatchEvent, which queues a task to the event loop to
dispatch an event on "this" Node while keeping it and its JS wrapper alive, and deployed them in elements.
- Modules/model-element/HTMLModelElement.cpp:
(WebCore::HTMLModelElement::setSourceURL): Need to disambiguate which queueTaskToDispatchEvent to use
between Node and ActiveDOMObject.
(WebCore::HTMLModelElement::notifyFinished): Ditto.
- dom/Node.cpp:
(WebCore::Node::queueTaskKeepingThisNodeAlive): Added.
(WebCore::Node::queueTaskToDispatchEvent): Added.
- dom/Node.h:
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::parseAttribute): Use newly added functions.
- html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::close): Ditto.
(WebCore::HTMLDialogElement::queueCancelTask): Ditto.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::scheduleSelectEvent): Ditto.
- 9:19 PM Changeset in webkit [293954] by
-
- 2 edits in trunk/Source/WebKit
Do WebKitAdditions header replacement only when a specific environment variable is set
https://bugs.webkit.org/show_bug.cgi?id=240210
<rdar://92885915>
Reviewed by Tim Horton.
- Source/WebKit/Configurations/WebKit.xcconfig:
- Source/WebKit/mac/replace-webkit-additions-includes.py:
(check_should_do_replacement):
(main):
(is_supported_os): Deleted.
Canonical link: https://commits.webkit.org/250400@main
- 8:47 PM Changeset in webkit [293953] by
-
- 2 edits in trunk/Source/WebCore
Use an OptionSet iterator to skip directly to GraphicsContextState::Change bits to handle
https://bugs.webkit.org/show_bug.cgi?id=239954
<rdar://problem/92593424>
Patch by Cameron McCormack <Cameron McCormack> on 2022-05-07
Reviewed by Simon Fraser.
It would be rare for display list SetState items to have many Change
bits set on them. Instead of checking for all 15 bits in mergeChanges,
we can use OptionSet's iterator to skip directly to each changed bit.
Using ctz to turn the Change bit into a bit position helps the
compiler generate compact code to jump to each case in the switch
statement.
On an iPad I tested with, this is a ~2% win on the MotionMark Design
subtest, 5.5% on Leaves, and 1.4% overall.
- platform/graphics/GraphicsContextState.cpp:
(WebCore::toIndex):
(WebCore::GraphicsContextState::mergeChanges):
- 7:41 PM Changeset in webkit [293952] by
-
- 2 edits in trunk/Source/bmalloc
Force PAS_ASSERT to generate different crash sites for each assertion.
https://bugs.webkit.org/show_bug.cgi?id=240209
Reviewed by Yusuke Suzuki.
Clang currently optimizes all crash sites into one in each function. Hence, if we
get a crash address at the 1 crash site, we don't know which failed assertion got
us there. This patch uses an asm statement to force Clang to emit a different
crash site for each assertion.
Benchmarks show that performance is neutral on both Jetstream2 and Speedometer2.
Size-wise, there is some increase. The following is the "size" output on
JavaScriptCore on M1:
TEXT. DATA OBJC others dec hex
old 19628032 180224 0 18792448 38600704 24d0000
new 19644416 180224 0 19251200 39075840 2544000
diff 16384 0 0 458752 475136
The increase in the "others" categories are mostly in the String Table, Symbol
Table, and Function Start Addresses. These take up disk space but should not
impact RAM usage unless they are accessed by a a debugger.
- libpas/src/libpas/pas_utils.h:
(pas_assertion_failed):
- 4:34 PM Changeset in webkit [293951] by
-
- 13 edits2 adds in trunk
Don't propagate GraphicsContextState change bits into TextPainter's glyph display list recorder
https://bugs.webkit.org/show_bug.cgi?id=239952
<rdar://problem/92635604>
Source/WebCore:
Reviewed by Said Abou-Hallawa and Antti Koivisto.
In FontCascade::displayListForTextRun, we create a
DisplayList::Recorder, then call drawGlyphBuffer. We initialize the
DisplayList::Recorder with the GraphicsContextState of the
GraphicsContext we're drawing to. Just before this, we will have set the
current fill color on that GraphicsContext.
When GPUP DOM rendering is disabled, GraphicsContextCG responds to
setFillColor etc. by updating GraphicsContextState, including setting
the Change flag, then immediately updating the CGContext, and clearing
the Change flag.
But when GPUP DOM rendering is enabled, the GraphicsContext is a
DisplayList::Recorder for the layer we're painting in to. Because
DisplayList::Recorder applies its state changes lazily, it can be in the
situation where its GraphicsContextState has had the fill brush changed,
and the Change flag is still set. So DisplayList::Recorder starts off
with a GraphicsContextState with unapplied changes in it. We end up in
DisplayList::Recorder::drawGlyphsAndCacheFont, which calls
appendStateChangeItemIfNecessary, which sees that the Change bit is set,
and generates a SetInlineFillColor display list item, which is
recorded and then replayed the next time the same text is painted.
This recorded fill color then may be wrong for the next TextPainter
that wants to reuse the cached glyph display list.
Display list recorders should never be initialized with a
GraphicsContextState that has change flags set on it. We can assert
this, then make FontCascade explicitly clear those flags on the state
object it passes in to the DisplayList::Recorder.
Test: fast/text/glyph-display-list-color.html
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::displayListForTextRun const):
- platform/graphics/GraphicsContextState.cpp:
(WebCore::GraphicsContextState::cloneForRecording const):
- platform/graphics/GraphicsContextState.h:
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::Recorder):
Add setForceUseGlyphDisplayListForTesting and
cachedGlyphDisplayListsForTextNode functions on Internal for the
test to use:
- rendering/GlyphDisplayListCache.h:
(WebCore::GlyphDisplayListCache::getIfExists):
- rendering/TextPainter.cpp:
(WebCore::TextPainter::shouldUseGlyphDisplayList):
(WebCore::TextPainter::setForceUseGlyphDisplayListForTesting):
(WebCore::TextPainter::cachedGlyphDisplayListsForTextNodeAsText):
- rendering/TextPainter.h:
(WebCore::TextPainter::glyphDisplayListIfExists):
- testing/Internals.cpp:
(WebCore::Internals::setForceUseGlyphDisplayListForTesting):
(WebCore::Internals::cachedGlyphDisplayListsForTextNode):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Reviewed by Antti Koivisto.
- fast/text/glyph-display-list-color-expected.txt: Added.
- fast/text/glyph-display-list-color.html: Added.
- 11:15 AM Changeset in webkit [293950] by
-
- 2 edits in trunk
Explain now node reference counting works in Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=240202
Unreviewed. Fix an obvious typo.
- Introduction.md:
- 10:58 AM Changeset in webkit [293949] by
-
- 2 edits in trunk
Explain now node reference counting works in Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=240202
Reviewed by Chris Dumez.
Added explanation on how Node reference counting works.
- Introduction.md:
- 10:34 AM Changeset in webkit [293948] by
-
- 8 edits in trunk/Source
Modernize / Optimize HTMLInputElement a bit
https://bugs.webkit.org/show_bug.cgi?id=240194
Reviewed by Darin Adler.
- Source/WebCore/html/ColorInputType.h:
- Source/WebCore/html/FileInputType.cpp:
(WebCore::FileInputType::firstElementPathForInputValue const):
(WebCore::FileInputType::files): Deleted.
(WebCore::FileInputType::canSetValue): Deleted.
(WebCore::FileInputType::getTypeSpecificValue): Deleted.
- Source/WebCore/html/FileInputType.h:
- Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore::HTMLInputElement::endEditing):
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::accessKeyAction):
(WebCore::HTMLInputElement::initializeInputType):
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::finishParsingChildren):
(WebCore::HTMLInputElement::appendFormData):
(WebCore::HTMLInputElement::reset):
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::setIndeterminate):
(WebCore::HTMLInputElement::value const):
(WebCore::HTMLInputElement::valueWithDefault const):
(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::defaultEventHandler):
(WebCore::HTMLInputElement::acceptMIMETypes const):
(WebCore::HTMLInputElement::acceptFileExtensions const):
(WebCore::HTMLInputElement::setShowAutoFillButton):
(WebCore::HTMLInputElement::files):
(WebCore::HTMLInputElement::setFiles):
(WebCore::HTMLInputElement::onSearch):
(WebCore::HTMLInputElement::prepareForDocumentSuspension):
(WebCore::HTMLInputElement::valueAsColor const):
(WebCore::HTMLInputElement::selectColor):
(WebCore::HTMLInputElement::suggestedColors const):
(WebCore::HTMLInputElement::dataList const):
(WebCore::HTMLInputElement::updateValueIfNeeded):
(WebCore::HTMLInputElement::isInRequiredRadioButtonGroup):
(WebCore::HTMLInputElement::radioButtonGroup const):
(WebCore::HTMLInputElement::checkedRadioButtonForGroup const):
(WebCore::HTMLInputElement::size const): Deleted.
(WebCore::HTMLInputElement::setValueForUser): Deleted.
(WebCore::HTMLInputElement::acceptMIMETypes): Deleted.
(WebCore::HTMLInputElement::acceptFileExtensions): Deleted.
(WebCore::HTMLInputElement::canReceiveDroppedFiles const): Deleted.
- Source/WebCore/html/HTMLInputElement.h:
(WebCore::HTMLInputElement::size const):
(WebCore::HTMLInputElement::setValueForUser):
(WebCore::HTMLInputElement::hasDirtyValue const):
(WebCore::HTMLInputElement::hasAutoFillStrongPasswordButton const):
(WebCore::HTMLInputElement::canReceiveDroppedFiles const):
- Source/WebCore/html/InputType.cpp:
(WebCore::InputType::files): Deleted.
(WebCore::InputType::setFiles): Deleted.
(WebCore::InputType::getTypeSpecificValue): Deleted.
(WebCore::InputType::canSetValue): Deleted.
(WebCore::InputType::valueAsColor const): Deleted.
(WebCore::InputType::selectColor): Deleted.
(WebCore::InputType::suggestedColors const): Deleted.
- Source/WebCore/html/InputType.h:
(WebCore::InputType::supportsValidation const):
(WebCore::InputType::InputType):
(WebCore::InputType::canHaveTypeSpecificValue const): Deleted.
Canonical link: https://commits.webkit.org/250394@main
May 6, 2022:
- 10:27 PM Changeset in webkit [293947] by
-
- 11 edits in trunk
Fix flakey test by using the old API on old systems.
https://bugs.webkit.org/show_bug.cgi?id=240195
Reviewed by Tim Horton.
Source/WebKit:
Turn fast/images/text-recognition/ios/show-data-detector-context-menu.html back on.
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]):
(-[WKActionSheetAssistant contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]): Deleted.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]):
(-[WKContentView contextMenuInteraction:configuration:dismissalPreviewForItemWithIdentifier:contextMenuInteraction:previewForDismissingMenuWithConfiguration:]):
(-[WKContentView contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]): Deleted.
(-[WKContentView contextMenuInteraction:configuration:dismissalPreviewForItemWithIdentifier:]): Deleted.
- UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:
(-[WKDataListSuggestionsDropdown contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]):
(-[WKDataListSuggestionsDropdown contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]): Deleted.
- UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimePicker contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]):
(-[WKDateTimePicker contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]): Deleted.
- UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]):
(-[WKFileUploadPanel contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]): Deleted.
- UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKSelectPicker contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:contextMenuInteraction:previewForHighlightingMenuWithConfiguration:]):
(-[WKSelectPicker contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]): Deleted.
Source/WTF:
- wtf/PlatformHave.h:
LayoutTests:
- platform/ios/TestExpectations:
- 9:16 PM Changeset in webkit [293946] by
-
- 2 edits in trunk/Source/WebCore
Block-style image overlay containers should have lighter shadows
https://bugs.webkit.org/show_bug.cgi?id=240198
rdar://92890194
Reviewed by Tim Horton.
Make some minor adjustments to the style of block-style image overlays. The short and long box-shadows
underneath these boxes should be much lighter, and the font-weight should be normal (400) instead of bold.
- html/shadow/imageOverlay.css:
(div.image-overlay-block):
Canonical link: https://commits.webkit.org/250392@main
- 9:02 PM Changeset in webkit [293945] by
-
- 2 edits in trunk/Source/WebKit
Fix another internal build
https://bugs.webkit.org/show_bug.cgi?id=240201
<rdar://92859012>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-06
Reviewed by Alexey Proskuryakov.
Bug 240184 introduced a classic "but I have spaces in my path" bug.
- Configurations/adattributiond.xcconfig:
- 7:17 PM Changeset in webkit [293944] by
-
- 2 edits in trunk/Source/WebCore
[WebXR] Update color format used for the multisample render buffer
https://bugs.webkit.org/show_bug.cgi?id=240179
Patch by Ada Chan <adachan@apple.com> on 2022-05-06
Reviewed by Dean Jackson.
- Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
- 7:07 PM Changeset in webkit [293943] by
-
- 6 edits in trunk/Source/WebCore
Optimize shouldApplyContainment methods
https://bugs.webkit.org/show_bug.cgi?id=240164
Reviewed by Alan Bujtas.
Based on a patch by Rob Buis.
Optimize shouldApplyContainment methods by allowing OptionSet as a parameter.
Also restrict the principal box checks to a single location.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeIntrinsicLogicalWidths const):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths const):
- rendering/RenderElement.h:
(WebCore::RenderElement::canContainFixedPositionObjects const):
(WebCore::RenderElement::canContainAbsolutelyPositionedObjects const):
(WebCore::RenderElement::shouldApplyLayoutOrPaintContainment const):
(WebCore::RenderElement::shouldApplySizeOrStyleContainment const):
(WebCore::RenderElement::shouldApplyLayoutContainment const):
(WebCore::RenderElement::shouldApplyPaintContainment const):
(WebCore::RenderElement::shouldApplySizeContainment const):
(WebCore::RenderElement::shouldApplyInlineSizeContainment const):
(WebCore::RenderElement::shouldApplyStyleContainment const):
(WebCore::RenderElement::shouldApplyAnyContainment const):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths const):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeEmptyTracksForAutoRepeat const):
- 6:52 PM Changeset in webkit [293942] by
-
- 5 edits in trunk
Temporal.Duration#toString should never ignore fractionalSecondDigits
https://bugs.webkit.org/show_bug.cgi?id=240193
Reviewed by Yusuke Suzuki.
This patch implements the spec correction of https://github.com/tc39/proposal-temporal/pull/1956:
new Temporal.Duration.from(1).toString({ fractionalSecondDigits: 2 })should be P1Y0.00S, not just P1Y.
- stress/temporal-duration.js: Add a test case.
- test262/expectations.yaml: Mark two test cases as passing.
- runtime/TemporalDuration.cpp:
(JSC::TemporalDuration::toString):
Canonical link: https://commits.webkit.org/250388@main
- 6:41 PM Changeset in webkit [293941] by
-
- 21 edits6 adds in trunk/Source
Unreviewed, reverting r293824.
https://bugs.webkit.org/show_bug.cgi?id=240197
Speedometer2/Angular2-TypeScript-TodoMVC 8% regression
Reverted changeset:
"SWOriginStore is no longer needed"
https://bugs.webkit.org/show_bug.cgi?id=240003
https://commits.webkit.org/r293824
- 6:38 PM Changeset in webkit [293940] by
-
- 3 edits2 adds in trunk
CSP: Fix script-src-elem policies in workers
https://bugs.webkit.org/show_bug.cgi?id=239840
Reviewed by Kate Cheney.
Source/WebCore:
Test: http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-and-script-src-elem.html
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForScript const):
LayoutTests:
CSP: Fix script-src-elem policies in workers
- http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-and-script-src-elem-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-and-script-src-elem.html: Added.
- 6:32 PM Changeset in webkit [293939] by
-
- 2 edits in trunk/Source/WebCore
Use dynamicDowncast in getPathFromPathOperation()
https://bugs.webkit.org/show_bug.cgi?id=240190
Reviewed by Chris Dumez.
Small cleanup.
- style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertPathOperation):
- 6:15 PM Changeset in webkit [293938] by
-
- 12 edits in trunk
Don't show "Markup Image" item for images that have already been marked up
https://bugs.webkit.org/show_bug.cgi?id=240133
rdar://92064534
Reviewed by Aditya Keerthi.
Source/WebKit:
Add some logic to avoid showing the "Markup Image" menu item on both macOS (in the context menu) and iOS (in the
callout bar or editing context menu) for image elements that were created and inserted in the process of
invoking "Markup Image". See below for more details.
Tests: ImageAnalysisTests.AllowImageAnalysisMarkupOnce
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::shouldAllowImageMarkup):
Add an async reply IPC message that the UI process uses to determine whether or not we should enable image
markup for an element corresponding to the givenElementContext.
- UIProcess/WebPageProxy.h:
Also move the declaration of
replaceImageWithMarkupResultsinto theENABLE(IMAGE_ANALYSIS_ENHANCEMENTS)
section.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView doAfterComputingImageAnalysisResultsForMarkup:]):
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::appendMarkupItemToControlledImageMenuIfNeeded):
Consult
shouldAllowImageMarkup()before triggering image analysis when determining whether or not we should
include the "Markup Image" item.
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::replaceImageWithMarkupResults):
Keep track of image elements that were created to replace existing images when performing image markup. To
achieve this, we scan the selection range before the caret after replacing the image to find the newly inserted
image and add it tom_elementsToExcludeFromMarkup.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
Clear out the
m_imageElementsToExcludeFromMarkupvector.
(WebKit::WebPage::shouldAllowImageMarkup const):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
Add an API test to verify that the option to Markup Image goes away after invoking Markup Image on an image
element.
- TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
(TestWebKitAPI::runMarkupTest):
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/250384@main
- 5:48 PM Changeset in webkit [293937] by
-
- 4 edits1 add in trunk/Source/WebGPU
[WebGPU] Fix build on downlevel OSes in Apple's build system
https://bugs.webkit.org/show_bug.cgi?id=240159
<rdar://problem/92524485>
Reviewed by Alexey Proskuryakov.
Some variables from WebKitTargetConditionals.xcconfig and
PlatformSupport.xcconfig are used, so we have to make sure
we include them. Also refactor the INSTALL_PATH variable a
bit.
- Configurations/Base.xcconfig:
- Configurations/WebGPU.xcconfig:
- Configurations/WebKitTargetConditionals.xcconfig: Added.
- WebGPU.xcodeproj/project.pbxproj:
- 5:41 PM Changeset in webkit [293936] by
-
- 2 edits in trunk/Source/WebKit
Fix adattributiond build in internal build on older macOS
https://bugs.webkit.org/show_bug.cgi?id=240184
<rdar://92859012>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-06
Reviewed by Alexey Proskuryakov.
We need to search for WK_OVERRIDE_FRAMEWORKS_DIR to find the right frameworks
- Configurations/adattributiond.xcconfig:
- 5:15 PM Changeset in webkit [293935] by
-
- 4 edits in trunk
ISO8601::Duration should guard against -0
https://bugs.webkit.org/show_bug.cgi?id=240185
Reviewed by Yusuke Suzuki.
Currently, when we parse a negative ISO duration string or negate a positive Duration object,
we end up storing -0 for the zero fields. This patch ensures that we always store +0 instead.
- test262/expectations.yaml:
Mark 32 test cases as passing.
- runtime/ISO8601.h:
Add guards for zero cases.
Canonical link: https://commits.webkit.org/250381@main
- 5:10 PM Changeset in webkit [293934] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py
Enable field trial configs when testing Chrome Betas
https://bugs.webkit.org/show_bug.cgi?id=240187
Reviewed by Saam Barati.
- Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
(OSXChromeDriverBase):
(OSXChromeDriverBase.launch_args_with_url):
(OSXChromeDriverBase.launch_url):
(OSXChromeCanaryDriver.launch_args_with_url):
(OSXChromeBetaDriver.launch_args_with_url):
(OSXChromeDevDriver._set_chrome_binary_location):
(OSXChromeDevDriver):
(OSXChromeDevDriver.launch_args_with_url):
Canonical link: https://commits.webkit.org/250380@main
- 5:08 PM Changeset in webkit [293933] by
-
- 3 edits2 adds in trunk
Use correct document as root for lazy image observer
https://bugs.webkit.org/show_bug.cgi?id=240083
Patch by Rob Buis <rbuis@igalia.com> on 2022-05-06
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
Add a test for scrolling a lazy loaded image into view in an iframe.
- web-platform-tests/html/semantics/embedded-content/the-img-element/scrolling-below-viewport-image-lazy-loading-in-iframe-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/scrolling-below-viewport-image-lazy-loading-in-iframe.html: Added.
Source/WebCore:
Use correct document as root for lazy image observer, meaning
elements in the main frame will use the main frame document and
elements in iframes will use the iframe document as root.
Test: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/scrolling-below-viewport-image-lazy-loading-in-iframe.html
- html/LazyLoadImageObserver.cpp:
(WebCore::LazyLoadImageObserver::intersectionObserver):
- 5:04 PM Changeset in webkit [293932] by
-
- 1 copy in tags/WebKit-7614.1.12.1
Tag WebKit-7614.1.12.1.
- 5:01 PM Changeset in webkit [293931] by
-
- 2 edits in trunk/Source/WebCore
[macOS] Content filter blocking shield is not displayed
https://bugs.webkit.org/show_bug.cgi?id=240178
<rdar://91586177>
Reviewed by Geoffrey Garen.
This is a regression from moving content filtering from the WebContent process to the Network process in r291630.
After r291630, the function to determine if a blocked request can be unblocked, is called in the Network process,
but it is not handling the case where the function to unblock the request is not set. This is causing the load
for blocked URLs to never finish, since the decision handler provided to the unblock request function is never
called. This patch addresses this by calling the decisionhandler with the blocked flag set in this case.
- platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:
(WebCore::ContentFilterUnblockHandler::requestUnblockAsync const):
- 4:17 PM Changeset in webkit [293930] by
-
- 4 edits in trunk/Tools
[git-webkit] Forward environment to
git commit
https://bugs.webkit.org/show_bug.cgi?id=240191
<rdar://problem/92885927>
Reviewed by Stephanie Lewis.
- Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.create_commit): Pass caller's environment.
Canonical link: https://commits.webkit.org/250377@main
- 4:10 PM Changeset in webkit [293929] by
-
- 2 edits in trunk/Source/WebCore
[macOS] HTTP traffic is not filtered in the parental controls filter
https://bugs.webkit.org/show_bug.cgi?id=240180
<rdar://problem/92875540>
Reviewed by Geoffrey Garen.
Traditionally, we have not filtered HTTP in the parental controls filter on macOS, since other parts of the system
has taken care of this. This appears to have changed now, and WebKit should also filter HTTP in addition to HTTPS.
- platform/cocoa/ParentalControlsContentFilter.mm:
(WebCore::canHandleResponse):
- 3:33 PM Changeset in webkit [293928] by
-
- 5 edits in trunk/Source
Remove unused ApplePayRemoteUIEnabled preference
https://bugs.webkit.org/show_bug.cgi?id=240177
Reviewed by Devin Rousso.
Remove the internal WKPreference for ApplePayRemoteUIEnabled now that
we always use the high-security remote ApplePay UI.
Source/WebKit:
- WebProcess/ApplePay/WebPaymentCoordinator.cpp:
(WebKit::WebPaymentCoordinator::networkProcessConnectionClosed):
(WebKit::WebPaymentCoordinator::messageSenderConnection const):
(WebKit::WebPaymentCoordinator::remoteUIEnabled const): Deleted.
- WebProcess/ApplePay/WebPaymentCoordinator.h:
Source/WTF:
- Scripts/Preferences/WebPreferencesInternal.yaml:
- 3:20 PM Changeset in webkit [293927] by
-
- 2 edits in trunk/LayoutTests
[Gardening] REGRESSION (r293117): [ iOS ] fast/innerHTML/001.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=240170
Unreviewed test gardening.
Canonical link: https://commits.webkit.org/250374@main
- 3:06 PM Changeset in webkit [293926] by
-
- 3 edits2 adds in trunk
[selectors] Double script focus after mouse click shouldn't match :focus-visible
https://bugs.webkit.org/show_bug.cgi?id=239472
<rdar://problem/92301472>
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/selectors/focus-visible-script-focus-020-expected.txt: Added.
- web-platform-tests/css/selectors/focus-visible-script-focus-020.html: Added.
Source/WebCore:
When you do the second script focus, we were setting
m_latestFocusTrigger to FocusTrigger::Bindings, that makes us lose the
information about the previous element that was focused via mouse
click and start matching :focus-visible on that case.
Test: imported/w3c/web-platform-tests/css/selectors/focus-visible-script-focus-020.html
- dom/Document.cpp:
(WebCore::Document::setFocusedElement): We avoid setting
m_latestFocusTrigger if we come from script focus. That way we know if
the previous focused element was focused via mouse click after several
script focus.
- 2:54 PM Changeset in webkit [293925] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Add more information about MarkedBlock assertion
https://bugs.webkit.org/show_bug.cgi?id=240176
Reviewed by Mark Lam and Saam Barati.
Collect more information about assertion via CRASH_WITH_INFO.
- Source/JavaScriptCore/heap/MarkedBlockInlines.h:
(JSC::MarkedBlock::Handle::specializedSweep):
Canonical link: https://commits.webkit.org/250372@main
- 2:51 PM Changeset in webkit [293924] by
-
- 2 edits in trunk/LayoutTests
[Gardening][ iOS ] fast/innerHTML/001.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=240170
Reviewed by Jonathan Bedard.
Canonical link: https://commits.webkit.org/250371@main
- 2:10 PM Changeset in webkit [293923] by
-
- 7 edits in trunk/Source
Remove abandoned WKPreference for SelectionPaintingWithoutSelectionGaps
https://bugs.webkit.org/show_bug.cgi?id=240129
Reviewed by Alan Bujtas.
Remove the abandoned WKPreference 'SelectionPaintingWithoutSelectionGaps', which was added to support
the EFL port. As the EFL port is no longer buildable, and this code is never used outside of EFL, we
should remove this dead code.
Source/WebCore:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::shouldPaintSelectionGaps const):
Source/WebKit:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSelectionPaintingWithoutSelectionGapsEnabled): Deleted.
(WKPreferencesGetSelectionPaintingWithoutSelectionGapsEnabled): Deleted.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
Source/WTF:
- Scripts/Preferences/WebPreferences.yaml:
- 2:03 PM Changeset in webkit [293922] by
-
- 2 edits in trunk/Source/WebCore
null ptr deref in WebCore::Frame::setPrinting
https://bugs.webkit.org/show_bug.cgi?id=240173
Reviewed by Wenson Hsieh.
Check m_doc in Frame::setPrinting before access, as it is a RefPtr that can become null.
- page/Frame.cpp:
(WebCore::Frame::setPrinting):
- 1:26 PM Changeset in webkit [293921] by
-
- 26 edits2 adds in trunk
Add support for Notification objects with custom data
https://bugs.webkit.org/show_bug.cgi?id=240153
Reviewed by Chris Dumez.
This adds support for the data attribute in Notification. This holds an arbitrary structured
cloneable object passed through the constructor. The accessor is marked SameObject, which we
implement via CachedAttribute. The wire form of the data is serialized and deserialized in
NotificationData so that persistent notifications properly support this property.
- Modules/notifications/Notification.cpp:
(WebCore::createSerializedNotificationData):
(WebCore::Notification::create):
(WebCore::Notification::createForServiceWorker):
(WebCore::Notification::Notification):
(WebCore::Notification::dataForBindings):
- Modules/notifications/Notification.h:
- Modules/notifications/Notification.idl:
- Modules/notifications/NotificationData.cpp:
(WebCore::NotificationData::isolatedCopy const):
(WebCore::NotificationData::isolatedCopy):
- Modules/notifications/NotificationData.h:
(WebCore::NotificationData::encode const):
(WebCore::NotificationData::decode):
- Modules/notifications/NotificationDataCocoa.mm:
(WebCore::NotificationData::fromDictionary):
(WebCore::NotificationData::dictionaryRepresentation const):
- Modules/notifications/NotificationOptions.idl:
- workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::showNotification):
LayoutTests/imported/w3c:
- web-platform-tests/notifications/idlharness.https.any-expected.txt:
- web-platform-tests/notifications/idlharness.https.any.serviceworker-expected.txt:
- web-platform-tests/wasm/serialization/module/serialization-via-notifications-api.any-expected.txt:
LayoutTests:
- http/tests/notifications/notification-expected.txt:
- http/tests/notifications/notification.html:
- http/tests/workers/service/getnotifications-expected.txt:
- http/tests/workers/service/getnotifications-stop-expected.txt:
- http/tests/workers/service/getnotifications-stop.html:
- http/tests/workers/service/getnotifications.html:
- http/tests/workers/service/openwindow-from-notification-click.html:
- http/tests/workers/service/resources/shownotification-openwindow-worker.js:
(async tryShow):
(async getNotes):
- http/tests/workers/service/resources/shownotification-worker.js:
(async event):
(async tryShow):
(async tryShowInvalidData.try.data):
(async tryShowInvalidData):
(async getNotes):
- http/tests/workers/service/shownotification-allowed-document-expected.txt:
- http/tests/workers/service/shownotification-allowed-document.html:
- http/tests/workers/service/shownotification-allowed.html:
- http/tests/workers/service/shownotification-invalid-data-expected.txt: Added.
- http/tests/workers/service/shownotification-invalid-data.html:
Canonical link: https://commits.webkit.org/250368@main
- 12:55 PM Changeset in webkit [293920] by
-
- 3 edits in trunk/Source/WebKit
Improve Mac webpushd sandbox
https://bugs.webkit.org/show_bug.cgi?id=240110
Reviewed by Per Arne Vollan.
This tightens the webpushd sandbox to only allow essential operations.
The first ~280 lines or so are similar to the other WebKit sandboxes, although I removed
many of the lines in this prelude as most of the services listed in the other profiles
have no use in webpushd.
The last ~50 lines of the profile (starting with the comment about SQLite) allows the
operations necessary for functioning of the daemon:
- Communicating with the push service daemon
- Waking up processes in response to a push
- Persisting subscriptions to the PushDatabase
I've also switched webpushd to read CF preferences directly like the other daemons, since our
sandbox profiles expect this.
- webpushd/WebPushDaemonMain.mm:
- webpushd/mac/com.apple.WebKit.webpushd.sb.in:
Canonical link: https://commits.webkit.org/250367@main
- 12:41 PM Changeset in webkit [293919] by
-
- 19 edits in trunk/Source
Remove internal WKPreference for non-iTunesAVOutput now that all platform support it
https://bugs.webkit.org/show_bug.cgi?id=240141
Reviewed by Eric Carlson.
WebKit on macOS has used a different AV Output target than IOS_FAMILY targets because those platforms lacked
the AVOutput option. Now that all platforms share this target, we can consolidate on the correct endpoint and
remove this preference code.
Source/WebCore:
- Modules/airplay/WebMediaSessionManager.cpp:
(WebCore::WebMediaSessionManager::showPlaybackTargetPicker):
- Modules/airplay/WebMediaSessionManagerClient.h:
(WebCore::WebMediaSessionManagerClient::alwaysOnLoggingAllowed const):
(WebCore::WebMediaSessionManagerClient::useiTunesAVOutputContext const): Deleted.
- platform/graphics/MediaPlaybackTargetPicker.h:
- platform/graphics/avfoundation/objc/AVPlaybackTargetPicker.h:
- platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.h:
- platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm:
(WebCore::AVRoutePickerViewTargetPicker::outputContextInternal):
(WebCore::AVRoutePickerViewTargetPicker::showPlaybackTargetPicker):
- platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
- platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
(WebCore::MediaPlaybackTargetPickerMac::showPlaybackTargetPicker):
Source/WebKit:
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::useiTunesAVOutputContext const): Deleted.
Source/WTF:
- Scripts/Preferences/WebPreferencesInternal.yaml:
- 12:26 PM Changeset in webkit [293918] by
-
- 6 edits in trunk/Source/WebCore
[IDL] Drop redundant [AtomString] on attributes marked as [Reflect] already
https://bugs.webkit.org/show_bug.cgi?id=240152
Reviewed by Darin Adler.
Drop redundant [AtomString] on attributes marked as [Reflect] already. All
attributes of string types and marked as [Reflect] now use AtomString
automatically, without having to specify it in the IDL.
- Source/WebCore/accessibility/AccessibilityRole.idl:
- Source/WebCore/accessibility/AriaAttributes.idl:
- Source/WebCore/dom/Element.idl:
- Source/WebCore/html/HTMLAnchorElement.idl:
- Source/WebCore/html/HTMLHtmlElement.idl:
Canonical link: https://commits.webkit.org/250365@main
- 12:13 PM Changeset in webkit [293917] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r290718 - Fix deprecations for ERB.new in GenerateSettings.rb
https://bugs.webkit.org/show_bug.cgi?id=237237
Reviewed by Don Olmstead.
Ruby 3.1.0 reported the following warning:
GenerateSettings.rb:283: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
GenerateSettings.rb:283: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.
r290104 and r290331 fixed the same problem for
GeneratePreferences.rb, but forgot GenerateSettings.rb.
- Scripts/GenerateSettings.rb: Use the keyword argument for ERB.new for Ruby 2.6+.
- 12:07 PM Changeset in webkit [293916] by
-
- 2 edits in trunk/Source/WebCore
ASSERT in WebCore::StyleProperties::getGridTemplateValue
https://bugs.webkit.org/show_bug.cgi?id=240172
Reviewed by Dean Jackson.
Update StyleProperties::getGridTemplateValue with a more thorough check
as it is currently only checking the grid:none/grid:initial special keyword.
- css/StyleProperties.cpp:
(WebCore::StyleProperties::getGridTemplateValue const):
- 12:06 PM Changeset in webkit [293915] by
-
- 3 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
[Nicosia] Images in webkit.org/blog/ don't show up with threaded rendering
https://bugs.webkit.org/show_bug.cgi?id=238259
Patch by Miguel Gomez <magomez@igalia.com> on 2022-05-06
Reviewed by Carlos Garcia Campos.
Implement Nicosia::CairoOperationRecorder::drawFilteredImageBuffer(), which is required
to render images that have CSS filters applied.
- platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
(Nicosia::CairoOperationRecorder::drawFilteredImageBuffer):
- platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
- 12:06 PM WebKitGTK/2.36.x edited by
- (diff)
- 12:06 PM Changeset in webkit [293914] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r293826 - REGRESSION(249114@main) [GTK] Crashes on shutdown if the display is not set
https://bugs.webkit.org/show_bug.cgi?id=239767
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2022-05-05
Reviewed by Michael Catanzaro.
Handle the case of PlatformDisplay created with a nullptr GdkDisplay.
- platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::PlatformDisplay):
- platform/graphics/wayland/PlatformDisplayWayland.cpp:
(WebCore::PlatformDisplayWayland::PlatformDisplayWayland):
(WebCore::PlatformDisplayWayland::~PlatformDisplayWayland):
- platform/graphics/x11/PlatformDisplayX11.cpp:
(WebCore::PlatformDisplayX11::PlatformDisplayX11):
(WebCore::PlatformDisplayX11::~PlatformDisplayX11):
- 12:00 PM Changeset in webkit [293913] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WTF
Merge r290331 - Ruby ERB.new compatibility fix
https://bugs.webkit.org/show_bug.cgi?id=237035
Reviewed by Fujii Hironori.
ERB.new has changed its calling convention in newer ruby versions.
This was exposed by https://commits.webkit.org/247450@main, which
tried to silence the warning emitted by newer ruby versions.
Unfortunately, this resulted in failures with older ruby versions
(e.g.
https://build.webkit.org/#/builders/46/builds/11387/steps/8/logs/stdio).
Use the compatibility hack suggested by RuboCop to get this working
across ruby versions (without any warnings).
- Scripts/GeneratePreferences.rb:
- 11:59 AM Changeset in webkit [293912] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebKit
Merge r292265 - GTK doesn't compile with ENABLE_ACCESSIBILITY=0
https://bugs.webkit.org/show_bug.cgi?id=238669
Reviewed by Michael Catanzaro.
Fix GTK compilation with ENABLE_ACCESSIBILITY=0
No new tests.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDispose):
(webkit_web_view_base_class_init):
- 11:53 AM Changeset in webkit [293911] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source/WebCore
Merge r293441 - [GTK] Initialize m_eglDisplay in PlatformDisplay::PlatformDisplay(GdkDisplay*)
https://bugs.webkit.org/show_bug.cgi?id=239760
Patch by Xi Ruoyao <xry111@mengyan1223.wang> on 2022-04-26
Reviewed by Michael Catanzaro.
No new tests because there is no behavior change.
- platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::PlatformDisplay):
initialize m_eglDisplay to EGL_NO_DISPLAY.
- 11:37 AM Changeset in webkit [293910] by
-
- 3 edits in trunk/Tools
Update PGO profile collection scripts to include MotionMark
https://bugs.webkit.org/show_bug.cgi?id=240171
Reviewed by Mark Lam.
- Scripts/build-and-collect-pgo-profiles:
- Scripts/pgo-profile:
- 11:09 AM WebKitGTK/2.36.x edited by
- (diff)
- 10:59 AM Changeset in webkit [293909] by
-
- 2 edits in branches/safari-7614.1.12-branch/Source/WebKit
Cherry-pick r293818. rdar://problem/92751323
REGRESSION (r293716): macCatalyst WebKit build fails; overlapping content at /System/Library/FeatureFlags/Domain/WebKit.plist
https://bugs.webkit.org/show_bug.cgi?id=240099
<rdar://92751323>
Reviewed by Chris Dumez.
- WebKit.xcodeproj/project.pbxproj: Avoid copying the feature flags plist for macCatalyst, since it installs into the same place as macOS.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:59 AM Changeset in webkit [293908] by
-
- 2 edits2 adds in branches/safari-7614.1.12-branch/Source/WebKit
Cherry-pick r293716. rdar://problem/92644672
REGRESSION (r292351): Processes no longer get the right jetsam priority on iOS
https://bugs.webkit.org/show_bug.cgi?id=239992
<rdar://problem/92644672>
Reviewed by Chris Dumez.
- FeatureFlags/WebKit.plist: Added.
- WebKit.xcodeproj/project.pbxproj:
Temporarily reinstate
RB_full_manage_WK_jetsam, since it is being read by a different project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:59 AM Changeset in webkit [293907] by
-
- 2 edits in trunk/Source/WebKit
[WebAuthn] Get rid of ASCAgentProxy instance after success/error/cancel
https://bugs.webkit.org/show_bug.cgi?id=240143
rdar://problem/92825715
Reviewed by Brent Fulgham.
For internal reasons, the ASCAgentProxy instance cannot be reused, so we
should clear it after a request or cancellation.
- UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
- 10:56 AM Changeset in webkit [293906] by
-
- 1 copy in releases/WPE WebKit/webkit-2.34.7/webkit-2.34
WPE WebKit 2.34.7
- 10:55 AM Changeset in webkit [293905] by
-
- 4 edits in releases/WebKitGTK/webkit-2.34
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.34.7 release
.:
- Source/cmake/OptionsWPE.cmake: Bump version numbers.
Source/WebKit:
- wpe/NEWS: Add release notes for 2.34.7
- 10:39 AM Changeset in webkit [293904] by
-
- 5 edits in trunk/Source/JavaScriptCore
Temporal.Duration should handle -0 properly
https://bugs.webkit.org/show_bug.cgi?id=240145
Reviewed by Yusuke Suzuki.
r250284 broke a new test262 test which verifies that -0 is normalized to 0 in cases like
new Temporal.Duration(-0)andTemporal.Duration.from({years: -0 }).
This patch properly aligns these paths with the spec.
- runtime/JSCJSValue.h:
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::toIntegerWithoutRounding const): Added.
(JSC::JSValue::toIntegerOrInfinity const):
- runtime/TemporalDuration.cpp:
(JSC::TemporalDuration::fromDurationLike):
- runtime/TemporalDurationConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
Canonical link: https://commits.webkit.org/250361@main
- 10:32 AM Changeset in webkit [293903] by
-
- 18 edits in trunk
Remove the viewportFitEnabled WKPreference now that it is always on
https://bugs.webkit.org/show_bug.cgi?id=240147
Reviewed by Tim Horton.
Remove the WKPreference 'ViewportFitEnabled' now that it is always enabled on all platforms, and
we do not wish to turn it off in testing or in other debugging circumstances.
Source/WebCore:
- dom/ViewportArguments.cpp:
(WebCore::setViewportFeature):
- dom/ViewportArguments.h:
Source/WebKit:
- UIProcess/API/ios/WKWebViewIOS.mm:
(viewportArgumentsFromDictionary):
(-[WKWebView _overrideViewportWithArguments:]):
Source/WebKitLegacy/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences viewportFitEnabled]): Deleted.
(-[WebPreferences setViewportFitEnabled:]): Deleted.
- WebView/WebPreferencesPrivate.h:
Source/WTF:
- Scripts/Preferences/WebPreferences.yaml:
LayoutTests:
- fast/css/variables/env/ios/safe-area-inset-env-set-expected.html:
- fast/css/variables/env/ios/safe-area-inset-env-set.html:
- fast/events/ios/rotation/safe-area-insets-during-safari-type-rotation.html:
- fast/viewport/ios/viewport-fit-auto.html:
- fast/viewport/ios/viewport-fit-contain.html:
- fast/viewport/ios/viewport-fit-cover.html:
- 10:25 AM Changeset in webkit [293902] by
-
- 9 edits in branches/safari-7614.1.12-branch/Source
Versioning.
WebKit-7614.1.12.1
- 10:23 AM Changeset in webkit [293901] by
-
- 2 edits in trunk
Unreviewed, add github info to contributors.json.
- metadata/contributors.json:
- 10:10 AM Changeset in webkit [293900] by
-
- 30 edits in trunk/Source/WebCore
Make the various shouldApplyContainment() functions member functions on RenderElement
https://bugs.webkit.org/show_bug.cgi?id=240156
Reviewed by Alan Bujtas.
These were free functions, but make more sense as member functions on RenderElement
since most callers passed*this. Just one call site needs to downcast<> to
RenderElement.
No behavior change.
- rendering/GridTrackSizingAlgorithm.cpp:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeIntrinsicLogicalWidths const):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths const):
(WebCore::RenderBlock::firstLineBaseline const):
(WebCore::RenderBlock::inlineBlockBaseline const):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths const):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
(WebCore::RenderBlockFlow::adjustSizeContainmentChildForPagination):
(WebCore::RenderBlockFlow::firstLineBaseline const):
(WebCore::RenderBlockFlow::inlineBlockBaseline const):
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::updateLogicalHeight):
(WebCore::RenderBox::isUnsplittableForPagination const):
(WebCore::RenderBox::layoutOverflowRectForPropagation const):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::updateFromStyle):
- rendering/RenderButton.cpp:
(WebCore::RenderButton::baselinePosition const):
- rendering/RenderCounter.cpp:
(WebCore::makeCounterNode):
(WebCore::RenderCounter::rendererSubtreeAttached):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::computeIntrinsicLogicalWidths const):
- rendering/RenderElement.h:
(WebCore::RenderElement::canContainFixedPositionObjects const):
(WebCore::RenderElement::canContainAbsolutelyPositionedObjects const):
(WebCore::RenderElement::shouldApplyLayoutContainment const):
(WebCore::RenderElement::shouldApplySizeContainment const):
(WebCore::RenderElement::shouldApplyInlineSizeContainment const):
(WebCore::RenderElement::shouldApplyStyleContainment const):
(WebCore::RenderElement::shouldApplyPaintContainment const):
(WebCore::RenderElement::shouldApplyAnyContainment const):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths const):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths const):
(WebCore::RenderFlexibleBox::firstLineBaseline const):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeEmptyTracksForAutoRepeat const):
(WebCore::RenderGrid::firstLineBaseline const):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::computeIntrinsicRatioInformation const):
- rendering/RenderInline.h:
- rendering/RenderLayer.cpp:
(WebCore::canCreateStackingContext):
(WebCore::RenderLayer::shouldBeCSSStackingContext const):
(WebCore::RenderLayer::setAncestorChainHasSelfPaintingLayerDescendant):
(WebCore::RenderLayer::setAncestorChainHasVisibleDescendant):
(WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::computeIntrinsicLogicalWidths const):
(WebCore::RenderListBox::baselinePosition const):
- rendering/RenderMenuList.cpp:
(RenderMenuList::computeIntrinsicLogicalWidths const):
- rendering/RenderObject.cpp:
(WebCore::objectIsRelayoutBoundary):
(WebCore::shouldApplyLayoutContainment): Deleted.
(WebCore::shouldApplySizeContainment): Deleted.
(WebCore::shouldApplyInlineSizeContainment): Deleted.
(WebCore::shouldApplyStyleContainment): Deleted.
(WebCore::shouldApplyPaintContainment): Deleted.
(WebCore::shouldApplyAnyContainment): Deleted.
- rendering/RenderObject.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox const):
(WebCore::RenderReplaced::computeIntrinsicRatioInformation const):
- rendering/RenderReplaced.h:
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::computeIntrinsicLogicalWidths const):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::firstLineBaseline const):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeIntrinsicLogicalWidths const):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::calculateIntrinsicSize):
- rendering/RenderView.cpp:
(WebCore::RenderView::rendererForRootBackground const):
- rendering/svg/LegacyRenderSVGRoot.cpp:
(WebCore::LegacyRenderSVGRoot::computeIntrinsicRatioInformation const):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation const):
- style/ContainerQueryEvaluator.cpp:
(WebCore::Style::ContainerQueryEvaluator::evaluateSizeFeature const):
- 9:49 AM Changeset in webkit [293899] by
-
- 7 edits4 adds in trunk
[Cocoa] Seeking into a xHE-AAC track backed by a SourceBuffer can stall playback
https://bugs.webkit.org/show_bug.cgi?id=239750
<rdar://91922569>
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-mp4-xhe-aac.html
xHE-AAC audio has the concept of an "independant sample", which behaves similarly to an
i-frame in a video codec. This sample is a prerequisite for decoding all samples that
come after it.
When such a track is parsed, those samples are marked as "sync", meaning they, as well as all
subsequent samples before the playhead, will be enqueued as "non-displaying". However, the
AVSampleBufferAudioRenderer does not use the DoNotDisplay sample attachment to control this
behavior. Instead, it relies on the TrimDurationAtStart (which has the effect of setting the
duration of the sample to zero, rendering it inaudible). Without this attachment, the renderer
will get "stuck" waiting for playback to clear out it's queue of samples.
Adopt this TrimDurationAtStart attachment if a given CMSampleBuffer is of the Audio type.
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
(WebCore::MediaSampleAVFObjC::createNonDisplayingCopy const):
Source/WebCore/PAL:
Fix a spelling error in the CoreMediaSoftLink macros.
- pal/cf/CoreMediaSoftLink.cpp:
- pal/cf/CoreMediaSoftLink.h:
LayoutTests:
- media/media-source/content/test-xhe-aac-manifest.json: Added.
- media/media-source/content/test-xhe-aac.m4a: Added.
- media/media-source/media-mp4-xhe-aac-expected.txt: Added.
- media/media-source/media-mp4-xhe-aac.html: Added.
- 9:43 AM Changeset in webkit [293898] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] fast/innerHTML/001.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=240170
Unreviewed test gardening.
Canonical link: https://commits.webkit.org/250356@main
- 9:40 AM Changeset in webkit [293897] by
-
- 3 edits2 adds in trunk
CSP: Fix incorrect blocked-uri for inline scripts and strict-dynamic policies
https://bugs.webkit.org/show_bug.cgi?id=240136
Reviewed by Kate Cheney.
Source/WebCore:
Test: http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-inline-report.py
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowNonParserInsertedScripts const):
LayoutTests:
- http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-inline-report-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-inline-report.py: Added.
- 9:29 AM Changeset in webkit [293896] by
-
- 4 edits3 adds in trunk
Video playback fails when using postMessage() during a User Gesture
https://bugs.webkit.org/show_bug.cgi?id=239781
<rdar://91281385>
Reviewed by Eric Carlson.
Source/WebCore:
Test: workers/worker-user-gesture.html
Certain frameworks handle user gestures by sending messages through postMessage() to
to a non-shared worker, where the message is processed and a response is sent back
to the page. In the case of APIs which require a user gesture, this gesture is lost
during the response event, even if it was present in the originating postMessage().
Other web APIs, such as Fetch, have been modified to forward this user gesture through
to the resulting event handlers. This change will expand that forwarding behavior to
include postMessage() to a non-shared Worker context.
When a message is sent to a WorkerContext, the current UserGestureToken is saved inside
a thread-safe RefCounted utility class WorkerUserGestureForwarder. This forwarder is
saved into an ivar of WorkerMessagingProxy, where it can be read during the handling
of a WorkerContext-originated postMessage(). The ivar is cleared immediately after sending
the initial postMessage(). The effect is that all calls to workerScope.postMessage()
made during the handling of a worker.postMessage() event will inherit the user gesture
of that initial call.
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerUserGestureForwarder::create):
(WebCore::WorkerUserGestureForwarder::~WorkerUserGestureForwarder):
(WebCore::WorkerUserGestureForwarder::userGestureToForward const):
(WebCore::WorkerUserGestureForwarder::WorkerUserGestureForwarder):
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
- workers/WorkerMessagingProxy.h:
LayoutTests:
- workers/worker-user-gesture-expected.txt: Added.
- workers/worker-user-gesture.html: Added.
- workers/worker-user-gesture.js: Added.
- 9:26 AM Changeset in webkit [293895] by
-
- 2 edits in trunk/Source/WebCore
Add lambda for fragmented flow state change handling
https://bugs.webkit.org/show_bug.cgi?id=240165
Patch by Rob Buis <rbuis@igalia.com> on 2022-05-06
Reviewed by Alan Bujtas.
Add lambda for fragmented flow state change handling
and call it in the case where the parent is affected.
- rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::normalizeTreeAfterStyleChange):
- 9:09 AM Changeset in webkit [293894] by
-
- 4 edits in trunk/Source
[iOS] Infinite recursion at -[WKFullScreenWindowController _exitFullscreenImmediately]
https://bugs.webkit.org/show_bug.cgi?id=239744
<rdar://74201964>
Reviewed by Eric Carlson.
Source/WebCore:
Even after fullscreen is correctly torn down during an immediate exit, fullscreen can never again
be entered for the lifetime of the page. This is due to the ivar m_pendingExitFullscreen being set
to true with no opportunity for that state to be cleared. This occurs because the callbacks for
exiting fullscreen are performed before the lambda form FullscreenManager::exitFullscreen() is
called.
Set m_pendingExitFullscreen inside exitFullscreen(), rather than the lambda, and clear it explicitly
in the cases where fullscreen exiting is not actually necessary.
The mock behavior of Fullscreen inside DumpRenderTree and WebKitTestRunner are not able to exercise
this same path. Track improvements to this mock in bug #239747.
- dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::requestFullscreenForElement):
(WebCore::FullscreenManager::exitFullscreen):
(WebCore::FullscreenManager::setAnimatingFullscreen):
(WebCore::FullscreenManager::setFullscreenControlsHidden):
Source/WebKit:
When exiting fullscreen immediately, we trigger the correct state transition by calling
-[self exitFullScreen]. However, when no fullscreen manager exists (as may happen during
navigation), -exitFullscreen may itself call -_exitFullscreenImmediately, which causes an
infinite recursion and stack overflow.
Unroll the implementation by performing all the same pieces as would have been done by
-exitFullScreen, but inline. Refactor out common behavior into -_reinsertWebViewUnderPlaceholder,
and call that both from -_exitFullscreenImmediately and _completedExitFullScreen.
Unfortunately, no API tests are possible here because TestWebKitAPI is not an actual iOS UI
application.
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController _reinsertWebViewUnderPlaceholder]):
(-[WKFullScreenWindowController _completedExitFullScreen]):
(-[WKFullScreenWindowController _exitFullscreenImmediately]):
- 8:58 AM Changeset in webkit [293893] by
-
- 3 edits in trunk/Source/WebKit
Create reports for long process launch times
https://bugs.webkit.org/show_bug.cgi?id=240127
Reviewed by Yusuke Suzuki.
We have reports that it can take a long time to launch WebKit processes in some cases. This is the time
it takes from the XPC message is sent until the XPC reply is received. Add reporting when this happens
in order to help diagnose the issue.
- UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::connect):
(WebKit::AuxiliaryProcessProxy::didFinishLaunching):
- UIProcess/AuxiliaryProcessProxy.h:
- 8:23 AM Changeset in webkit [293892] by
-
- 4 edits in trunk/Source/WebKit
[WP] Wait for Launch Services database after Network process connection has been established
https://bugs.webkit.org/show_bug.cgi?id=240125
<rdar://92107043>
Reviewed by Geoffrey Garen.
Since the Launch Services database is provided to the WebContent process by the Network process, it makes sense
to wait for the database when we're certain that the Network process is running. This should fix main thread hangs
in the cases where we before started waiting for the database before the Network process had launched. To support
this move, we also need to delay the initialization of accessibility in NSApplication, since that depends on having
the database available. This is now being done in WebPage::platformInitializeAccessibility, which is a natural
place for this initialization to take place.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformInitializeAccessibility):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureNetworkProcessConnection):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 8:21 AM Changeset in webkit [293891] by
-
- 3 edits in trunk/Tools
[ews-build.webkit.org] Do not block EWS queues for merging-blocked label
https://bugs.webkit.org/show_bug.cgi?id=240169
<rdar://problem/92860451>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/steps.py:
(ValidateChange.validate_github): merging-blocked label should only block merge-queue.
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/250349@main
- 8:13 AM Changeset in webkit [293890] by
-
- 2 edits in trunk/Source/WebKit
GPU Process crash under IPC::Connection::open() ASSERTION FAILED: m_sendPort
https://bugs.webkit.org/show_bug.cgi?id=240146
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-06
Reviewed by Chris Dumez.
If WP creates connection to GPUP but then exits, the
sent mach send right for communication comes out as MACH_PORT_DEAD_NAME in GPUP.
This will prevent proper initialization of IPC::Connection. This will
later assert in IPC::Connection::open().
Fix by checking identifierIsValid(). This will succeed only if the
listening port was alive at the time the send port was received.
Speculative fix.
Regression from r293829.
- GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::createGPUConnectionToWebProcess):
- 8:02 AM Changeset in webkit [293889] by
-
- 2 edits in trunk/Tools
[Flatpak SDK] Include port / build type in shell prompt
https://bugs.webkit.org/show_bug.cgi?id=240166
Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-06
Reviewed by Adrian Perez de Castro.
This might help avoiding confusions like running debug tools in a release shell, or wpe
things in a gtk shell.
- flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):
Canonical link: https://commits.webkit.org/250347@main
- 7:50 AM Changeset in webkit [293888] by
-
- 2 edits in trunk/LayoutTests
[ iOS Release ] fast/css-custom-paint/animate-repaint.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240167
Unreviewed test gardening.
Canonical link: https://commits.webkit.org/250346@main
- 7:45 AM Changeset in webkit [293887] by
-
- 2 edits2 adds in trunk/Tools/buildstream
Update mold to version 1.2.1 https://bugs.webkit.org/show_bug.cgi?id=240162
Reviewed by Philippe Normand.
Update Mold to version 1.2.1, which now properly supports --gdb-index and Clang's
ThinLTO (on top of regular LTO support). The copy of libtbb bundled with the Mold
sources does no longer build with the rest of tooling from the SDK, so this patch
adds Buildstream elements for it and its hwloc dependency; both these two packages
are built with the minimal set of options needed to build Mold.
- elements/sdk/hwloc.bst: Added.
- elements/sdk/mold.bst: Updated to version 1.2.1
- elements/sdk/tbb.bst: Added.
Canonical link: https://commits.webkit.org/250345@main
- 5:55 AM WebKitFlatpakSDK/DebugWithRR edited by
- (diff)
- 2:52 AM Changeset in webkit [293886] by
-
- 19 edits1 copy in trunk/Source
Allow MediaPlayerPrivateMediaStreamAVFObjC to avoid pixel conformers if IOSurfaces are not allowed
https://bugs.webkit.org/show_bug.cgi?id=240113
rdar://92629845
Reviewed by Eric Carlson.
Source/WebCore:
Add a callback in MediaPlayerPrivateMediaStreamAVFObjC to allow use a custom way to create a NativeImage from a VideoFrame.
Small refactoring in PixelBufferConformerCV to share more code with WebKit.
Make sure that SharedVideoFrameReader/Writer support kCVPixelFormatType_420YpCbCr10BiPlanarFullRange.
Covered by existing tests.
- WebCore.xcodeproj/project.pbxproj:
- platform/cocoa/SharedVideoFrameInfo.mm:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
- platform/graphics/cv/CVUtilities.h:
- platform/graphics/cv/PixelBufferConformerCV.cpp:
- platform/graphics/cv/PixelBufferConformerCV.h:
Source/WebKit:
Implement VideoFrame conversion to BGRA by sending IPC to GPUProcess, use pixel conformer in GPUProcess and send back the results to WebProcess.
This goes through RemoteVideoFrameObjectHeapProxy/RemoteVideoFrameObjectHeapProxyProcessor which exchanges with RemoteVideoFrameObjectHeap.
Make use of this conversion code path for MediaPlayerPrivateMediaStreamAVFObjC by setting MediaPlayerPrivateMediaStreamAVFObjC nativeImageCreator callback.
- GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:
- GPUProcess/media/RemoteVideoFrameObjectHeap.h:
- GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in:
- GPUProcess/media/RemoteVideoFrameObjectHeap.mm: Added.
- SourcesCocoa.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxy.h:
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.cpp:
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.h:
- WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxyProcessor.messages.in:
- 2:30 AM WebKitGTK/2.36.x edited by
- (diff)
- 1:44 AM Changeset in webkit [293885] by
-
- 10 edits in trunk/Source
Remove usage of PixelBufferConformer in RealtimeOutgoingVideoSourceCocoa
https://bugs.webkit.org/show_bug.cgi?id=240118
Reviewed by Eric Carlson.
Source/ThirdParty/libwebrtc:
Add a routine to convert RGB CVPixelBuffer to YUV webrtc VideoFrameBuffer.
- Configurations/libwebrtc.iOS.exp:
- Configurations/libwebrtc.iOSsim.exp:
- Configurations/libwebrtc.mac.exp:
- Source/webrtc/sdk/WebKit/WebKitUtilities.h:
- Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
(webrtc::convertBGRAToYUV):
Source/WebCore:
Remove RealtimeOutgoingVideoSourceCocoa::convertToYUV, instead use libyuv based converter routine.
Covered by existing canvas -> peer connection tests.
- platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:
- platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.h:
- platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:
- 1:18 AM Changeset in webkit [293884] by
-
- 2 edits in trunk/Source/WebCore
Make readArrayBufferViewImpl defensive
https://bugs.webkit.org/show_bug.cgi?id=240154
rdar://92113248
Reviewed by Mark Lam.
Check deserialized value's type before starting using it as JSArrayBuffer*.
- Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readArrayBufferViewImpl):
Canonical link: https://commits.webkit.org/250342@main
- 12:43 AM Changeset in webkit [293883] by
-
- 3 edits in trunk/Source/WebCore
[Nicosia] Images in webkit.org/blog/ don't show up with threaded rendering
https://bugs.webkit.org/show_bug.cgi?id=238259
Reviewed by Carlos Garcia Campos.
Implement Nicosia::CairoOperationRecorder::drawFilteredImageBuffer(), which is required
to render images that have CSS filters applied.
- platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
(Nicosia::CairoOperationRecorder::drawFilteredImageBuffer):
- platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
- 12:26 AM Changeset in webkit [293882] by
-
- 7 edits in trunk/Source/JavaScriptCore
builtins-generator-tests are failing after 250242@main
https://bugs.webkit.org/show_bug.cgi?id=239792
<rdar://problem/92532725>
Unreviewed resetting the results.
Tools/Scripts/run-builtins-generator-tests --reset-results
- Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
May 5, 2022:
- 9:44 PM Changeset in webkit [293881] by
-
- 62 edits in trunk/Source
[EME] CDM and friends should be using SharedBuffer rather FragmentedSharedBuffer
https://bugs.webkit.org/show_bug.cgi?id=240111
rdar://92780561
Patch by Jean-Yves Avenard <jean-yves.avenard@apple.com> on 2022-05-05
Reviewed by Eric Carlson.
Source/WebCore:
By using SharedBuffer directly we can simplify the code.
The change while extensive is rather trivial as the SharedBuffer used
were already contiguous.
No change in observable behaviour
- Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::sanitizeInitData):
(WebCore::CDM::supportsInitData):
(WebCore::CDM::sanitizeResponse):
- Modules/encryptedmedia/CDM.h:
- Modules/encryptedmedia/CDMClient.h:
- Modules/encryptedmedia/InitDataRegistry.cpp:
(WebCore::extractKeyIDsKeyids):
(WebCore::sanitizeKeyids):
(WebCore::InitDataRegistry::extractPsshBoxesFromCenc):
(WebCore::InitDataRegistry::extractKeyIDsCenc):
(WebCore::InitDataRegistry::sanitizeCenc):
(WebCore::sanitizeWebM):
(WebCore::extractKeyIDsWebM):
(WebCore::InitDataRegistry::sanitizeInitData):
(WebCore::InitDataRegistry::extractKeyIDs):
- Modules/encryptedmedia/InitDataRegistry.h:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::generateRequest):
(WebCore::MediaKeySession::update):
(WebCore::MediaKeySession::remove):
(WebCore::MediaKeySession::enqueueMessage):
(WebCore::MediaKeySession::sendMessage):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/encryptedmedia/MediaKeyStatusMap.cpp:
(WebCore::keyIdsMatch):
- Modules/encryptedmedia/MediaKeyStatusMap.h:
- Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::unrequestedInitializationDataReceived):
- Modules/encryptedmedia/MediaKeys.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::cdmClientUnrequestedInitializationDataReceived):
- html/HTMLMediaElement.h:
- platform/encryptedmedia/CDMInstance.h:
- platform/encryptedmedia/CDMInstanceSession.h:
- platform/encryptedmedia/CDMPrivate.h:
- platform/encryptedmedia/CDMProxy.h:
(WebCore::KeyHandle::idAsSharedBuffer const):
- platform/encryptedmedia/CDMUtilities.cpp:
(WebCore::CDMUtilities::parseJSONObject):
- platform/encryptedmedia/CDMUtilities.h:
- platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::extractKeyidsLocationFromCencInitData):
(WebCore::isCencInitData):
(WebCore::extractKeyidsFromCencInitData):
(WebCore::extractKeyIdFromWebMInitData):
(WebCore::CDMPrivateClearKey::supportsInitData const):
(WebCore::CDMPrivateClearKey::sanitizeResponse const):
(WebCore::CDMInstanceClearKey::setServerCertificate):
(WebCore::CDMInstanceSessionClearKey::requestLicense):
(WebCore::CDMInstanceSessionClearKey::updateLicense):
(WebCore::CDMInstanceSessionClearKey::removeSessionData):
- platform/encryptedmedia/clearkey/CDMClearKey.h:
- platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
(WebCore::extractSinfData):
(WebCore::extractSchemeAndKeyIdFromSinf):
(WebCore::CDMPrivateFairPlayStreaming::extractKeyIDsSinf):
(WebCore::CDMPrivateFairPlayStreaming::sanitizeSinf):
(WebCore::CDMPrivateFairPlayStreaming::sanitizeSkd):
(WebCore::CDMPrivateFairPlayStreaming::extractKeyIDsSkd):
(WebCore::CDMPrivateFairPlayStreaming::supportsInitData const):
(WebCore::CDMPrivateFairPlayStreaming::sanitizeResponse const):
- platform/graphics/avfoundation/CDMFairPlayStreaming.h:
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::initializationDataForRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::takeUnexpectedKeyRequestForInitializationData):
(WebCore::parseJSONValue):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setServerCertificate):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::sessionForKeyIDs const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestLicense):
(WebCore::isEqual):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::closeSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequests):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::attemptToDecryptWithInstance):
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::copyKeyIDs):
- platform/graphics/gstreamer/eme/CDMThunder.cpp:
(WebCore::CDMPrivateThunder::supportsInitData const):
(WebCore::CDMPrivateThunder::sanitizeResponse const):
(WebCore::CDMInstanceThunder::setServerCertificate):
(WebCore::ParsedResponseMessage::ParsedResponseMessage):
(WebCore::ParsedResponseMessage::payload const):
(WebCore::ParsedResponseMessage::payload):
(WebCore::CDMInstanceSessionThunder::challengeGeneratedCallback):
(WebCore::CDMInstanceSessionThunder::errorCallback):
(WebCore::CDMInstanceSessionThunder::requestLicense):
(WebCore::CDMInstanceSessionThunder::updateLicense):
(WebCore::CDMInstanceSessionThunder::loadSession):
(WebCore::CDMInstanceSessionThunder::removeSessionData):
- platform/graphics/gstreamer/eme/CDMThunder.h:
- testing/MockCDMFactory.cpp:
(WebCore::MockCDMFactory::hasSessionWithID):
(WebCore::MockCDMFactory::removeSessionWithID):
(WebCore::MockCDMFactory::addKeysToSessionWithID):
(WebCore::MockCDMFactory::removeKeysFromSessionWithID):
(WebCore::MockCDMFactory::keysForSessionWithID const):
(WebCore::MockCDM::supportsInitData const):
(WebCore::MockCDM::sanitizeResponse const):
(WebCore::MockCDMInstance::setServerCertificate):
(WebCore::MockCDMInstanceSession::requestLicense):
(WebCore::MockCDMInstanceSession::updateLicense):
(WebCore::MockCDMInstanceSession::removeSessionData):
- testing/MockCDMFactory.h:
Source/WebKit:
Remove the use of IPC::SharedBufferCopy objects to send data over IPC;
it adds no value here as SharedBuffer are fully serialisable.
- GPUProcess/media/RemoteCDMInstanceProxy.cpp:
(WebKit::RemoteCDMInstanceProxy::unrequestedInitializationDataReceived):
(WebKit::RemoteCDMInstanceProxy::setServerCertificate):
- GPUProcess/media/RemoteCDMInstanceProxy.h:
- GPUProcess/media/RemoteCDMInstanceProxy.messages.in:
- GPUProcess/media/RemoteCDMInstanceSessionProxy.cpp:
(WebKit::RemoteCDMInstanceSessionProxy::requestLicense):
(WebKit::RemoteCDMInstanceSessionProxy::updateLicense):
(WebKit::RemoteCDMInstanceSessionProxy::removeSessionData):
(WebKit::RemoteCDMInstanceSessionProxy::sendMessage):
- GPUProcess/media/RemoteCDMInstanceSessionProxy.h:
- GPUProcess/media/RemoteCDMInstanceSessionProxy.messages.in:
- GPUProcess/media/RemoteCDMProxy.cpp:
(WebKit::RemoteCDMProxy::supportsInitData):
(WebKit::RemoteCDMProxy::sanitizeResponse):
- GPUProcess/media/RemoteCDMProxy.h:
- GPUProcess/media/RemoteLegacyCDMProxy.h:
- GPUProcess/media/RemoteLegacyCDMSessionProxy.cpp:
(WebKit::convertToUint8Array):
(WebKit::convertToOptionalSharedBuffer):
(WebKit::RemoteLegacyCDMSessionProxy::generateKeyRequest):
(WebKit::RemoteLegacyCDMSessionProxy::update):
- GPUProcess/media/RemoteLegacyCDMSessionProxy.h:
- GPUProcess/media/RemoteLegacyCDMSessionProxy.messages.in:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<WebCore::CDMInstanceSession::Message>::encode):
(IPC::ArgumentCoder<WebCore::CDMInstanceSession::Message>::decode):
- WebProcess/GPU/media/RemoteCDM.cpp:
(WebKit::RemoteCDM::supportsInitData const):
(WebKit::RemoteCDM::sanitizeResponse const):
- WebProcess/GPU/media/RemoteCDM.h:
- WebProcess/GPU/media/RemoteCDMInstance.cpp:
(WebKit::RemoteCDMInstance::unrequestedInitializationDataReceived):
(WebKit::RemoteCDMInstance::setServerCertificate):
- WebProcess/GPU/media/RemoteCDMInstance.h:
- WebProcess/GPU/media/RemoteCDMInstance.messages.in:
- WebProcess/GPU/media/RemoteCDMInstanceSession.cpp:
(WebKit::RemoteCDMInstanceSession::requestLicense):
(WebKit::RemoteCDMInstanceSession::updateLicense):
(WebKit::RemoteCDMInstanceSession::removeSessionData):
(WebKit::RemoteCDMInstanceSession::sendMessage):
- WebProcess/GPU/media/RemoteCDMInstanceSession.h:
- WebProcess/GPU/media/RemoteCDMInstanceSession.messages.in:
- WebProcess/GPU/media/RemoteLegacyCDMSession.cpp:
(WebKit::convertToArrayBuffer):
(WebKit::convertToUint8Array):
(WebKit::convertToSharedBuffer):
(WebKit::RemoteLegacyCDMSession::generateKeyRequest):
(WebKit::RemoteLegacyCDMSession::update):
(WebKit::RemoteLegacyCDMSession::cachedKeyForKeyID const):
(WebKit::RemoteLegacyCDMSession::sendMessage):
- WebProcess/GPU/media/RemoteLegacyCDMSession.h:
- WebProcess/GPU/media/RemoteLegacyCDMSession.messages.in:
Canonical link: https://commits.webkit.org/250339@main
- 9:10 PM Changeset in webkit [293880] by
-
- 3 edits in trunk/Source/WebCore
Reduce the number of calls to canContainFixedPositionObjects()
https://bugs.webkit.org/show_bug.cgi?id=240150
Reviewed by Alan Bujtas.
canContainFixedPositionObjects() isn't super cheap, so only call it when we need to remove
the IsFixed bit.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer const):
(WebCore::RenderBox::mapAbsoluteToLocalPoint const):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::mapLocalToContainer const):
- 7:34 PM Changeset in webkit [293879] by
-
- 28 edits in trunk/Source
Identifier::string() should return an AtomString
https://bugs.webkit.org/show_bug.cgi?id=240122
Reviewed by Yusuke Suzuki.
Identifier::string() should return an AtomString instead of a String, since
it holds an AtomString internally.
Also add some overloads to jsString() to resolve ambiguity for some callers.
- Source/JavaScriptCore/API/JSContext.mm:
(-[JSContext dependencyIdentifiersForModuleJSScript:]):
- Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:
(JSC::processClauseList):
- Source/JavaScriptCore/dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
- Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::functionDetails):
- Source/JavaScriptCore/jsc.cpp:
(JSC_DEFINE_HOST_FUNCTION):
- Source/JavaScriptCore/runtime/Error.cpp:
(JSC::addErrorInfo):
- Source/JavaScriptCore/runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::finishCreation):
- Source/JavaScriptCore/runtime/ErrorPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
- Source/JavaScriptCore/runtime/FunctionExecutable.cpp:
(JSC::FunctionExecutable::toStringSlow):
- Source/JavaScriptCore/runtime/Identifier.h:
(JSC::Identifier::string const):
(JSC::Identifier::atomString const): Deleted.
- Source/JavaScriptCore/runtime/IdentifierInlines.h:
(JSC::identifierToJSValue):
(JSC::identifierToSafePublicJSValue):
- Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::format const):
(JSC::IntlDateTimeFormat::formatRange):
- Source/JavaScriptCore/runtime/IntlDisplayNames.cpp:
(JSC::IntlDisplayNames::of const):
- Source/JavaScriptCore/runtime/IntlListFormat.cpp:
(JSC::IntlListFormat::format const):
- Source/JavaScriptCore/runtime/IntlRelativeTimeFormat.cpp:
(JSC::IntlRelativeTimeFormat::format const):
- Source/JavaScriptCore/runtime/JSFunction.cpp:
(JSC::JSFunction::reifyName):
- Source/JavaScriptCore/runtime/JSModuleLoader.cpp:
(JSC::JSModuleLoader::requestImportModule):
- Source/JavaScriptCore/runtime/JSString.h:
(JSC::jsString):
- Source/JavaScriptCore/runtime/JSStringInlines.h:
(JSC::repeatCharacter):
- Source/JavaScriptCore/runtime/StringPrototype.cpp:
(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::toLocaleCase):
(JSC::normalize):
- Source/JavaScriptCore/runtime/SymbolPrototype.cpp:
(JSC::JSC_DEFINE_CUSTOM_GETTER):
- Source/WTF/wtf/PrintStream.cpp:
(WTF::printInternal):
- Source/WTF/wtf/PrintStream.h:
- Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::processKeyframeLikeObject):
- Source/WebCore/inspector/WebInjectedScriptHost.cpp:
(WebCore::WebInjectedScriptHost::getInternalProperties):
Canonical link: https://commits.webkit.org/250337@main
- 7:23 PM Changeset in webkit [293878] by
-
- 5 edits2 adds in trunk
Removing x-webkit-wirelessvideoplaybackdisabled attribute from video does not enable AirPlay.
https://bugs.webkit.org/show_bug.cgi?id=239031
Reviewed by Jer Noble.
- Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::setWirelessVideoPlaybackDisabled):
- Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::setWirelessVideoPlaybackDisabled):
Test: media/airplay-wirelessvideoplaybackdisabled.html
- Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged):
- Source/WebCore/html/HTMLMediaElement.h:
- Source/WebCore/html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::parseAttribute):
- LayoutTests/media/airplay-wirelessvideoplaybackdisabled-expected.txt: Added.
- LayoutTests/media/airplay-wirelessvideoplaybackdisabled.html: Added.
Canonical link: https://commits.webkit.org/250336@main
- 6:28 PM Changeset in webkit [293877] by
-
- 2 edits in trunk/Source/WebCore/platform/graphics/avfoundation/objc
[Cocoa] QueuedVideoOutput constructor missing nil check
https://bugs.webkit.org/show_bug.cgi?id=240149
Reviewed by Eric Carlson.
Covered by existing tests.
- Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.h:
- Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.mm:
(WebCore::QueuedVideoOutput::create):
(WebCore::QueuedVideoOutput::QueuedVideoOutput):
(WebCore::QueuedVideoOutput::valid):
Canonical link: https://commits.webkit.org/250335@main
- 5:59 PM Changeset in webkit [293876] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] fast/images/exif-orientation-background-image-repeat.html is a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=240148
Unreviewed test gardening.
Canonical link: https://commits.webkit.org/250334@main
- 5:49 PM Changeset in webkit [293875] by
-
- 7 edits in trunk/Tools
[git-webkit] Automatically file bug
https://bugs.webkit.org/show_bug.cgi?id=240139
<rdar://problem/92818331>
Reviewed by Dewei Zhu.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.main): If a project has defined bug trackers and the user provides a bug title instead of a bug
url or branch name (determined by spaces in the provided string), walk the user through bug creation.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py:
(TestBranch): Add mock issues, rebase prompts.
(TestBranch.test_create_bug): Added.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py:
(TestRevert.test_github): Add mock issues, rebase prompts.
(TestRevert.test_modified): Ditto.
Canonical link: https://commits.webkit.org/250333@main
- 5:24 PM Changeset in webkit [293874] by
-
- 1 copy in tags/WebKit-7613.3.1
Tag WebKit-7613.3.1.
- 5:12 PM Changeset in webkit [293873] by
-
- 2 edits in trunk
Add GitHub user name
https://bugs.webkit.org/show_bug.cgi?id=240144
Unreviewed, add github user name to contributors.json.
- metadata/contributors.json:
- 5:03 PM Changeset in webkit [293872] by
-
- 1 copy in tags/WebKit-7614.1.11.7
Tag WebKit-7614.1.11.7.
- 5:01 PM Changeset in webkit [293871] by
-
- 9 edits in branches/safari-614.1.11-branch/Source
Versioning.
WebKit-7614.1.11.7
- 4:50 PM Changeset in webkit [293870] by
-
- 3 edits in trunk/Source/WebCore
Add check if referenced element is SVG for clip-path
https://bugs.webkit.org/show_bug.cgi?id=240096
Reviewed by Simon Fraser.
Add check when creating new ReferencePathOperation that it is referencing
an svg element.
- style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertPathOperation):
- 4:43 PM Changeset in webkit [293869] by
-
- 2 edits in trunk/JSTests
Rebaseline icu tests to public sdk's icu
https://bugs.webkit.org/show_bug.cgi?id=240142
Reviewed by Yusuke Suzuki.
- test262/expectations.yaml:
- 4:28 PM Changeset in webkit [293868] by
-
- 9 edits in branches/safari-613-branch/Source
Versioning.
WebKit-7613.3.1
- 4:15 PM Changeset in webkit [293867] by
-
- 5 edits in trunk/Source/WebCore
Avoid using WebCore::Colors created with out-of-line components in DrawGlyphsRecorder
https://bugs.webkit.org/show_bug.cgi?id=235604
rdar://88345680
Reviewed by Simon Fraser.
Source/WebCore:
In DrawGlyphsRecorder::recordDrawGlyphs we interrogate the CGContext's
state to find out the current fill and stroke color. This needed to
record color font glyphs correctly. When we're not using a color font,
the CGColors for the fill and stroke will be the same as we set them
in prepareInternalContext.
Those CGColors we create in prepareInternalContext from the
WebCore::Colors (created by calling cachedCGColor) don't record the
exact form the original colors had. CGColors only expose float
components, so Color::createAndPreserveColorSpace conservatively
creates a Color with out-of-line components to store those float
values, even if the original Color the CGColor was created from had
uint8_t components.
Color::operator== treats colors of different forms as being different,
which means we generate additional, unnecessary SetState display list
items changing say the fill color from Color(255, 255, 255) (inline) to
Color(1.0, 1.0, 1.0) (out of line).
We can avoid this by checking whether the context state's fill and
stroke CGColors are the same object as the ones we set in
prepareInternalContext, and if so, set the current fill/stroke brush
based on m_originalState.fillBrush/strokeBrush. In the common case of
a non-color glyph, this brush change will be detected as the same as
the current value, and the SetState item generation will be avoided.
This improves the MotionMark design subtest by 2.4%, and the overall
score by 0.7%, when GPUP DOM rendering is enabled.
- platform/graphics/DrawGlyphsRecorder.h:
- platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:
(WebCore::DrawGlyphsRecorder::recordInitialColors):
(WebCore::DrawGlyphsRecorder::prepareInternalContext):
(WebCore::DrawGlyphsRecorder::updateFillColor):
(WebCore::DrawGlyphsRecorder::updateStrokeColor):
Source/WebCore/PAL:
- pal/spi/cg/CoreGraphicsSPI.h: Add CGContextGetStrokeColorAsColor.
- 4:11 PM Changeset in webkit [293866] by
-
- 18 edits in branches/safari-613-branch
Revert r293850. rdar://problem/88904160
This reverts a patch application at r293850.
- 4:11 PM Changeset in webkit [293865] by
-
- 5 edits in branches/safari-613-branch/Source/WebKit
Revert r293851. rdar://problem/88904160
This reverts a patch application at r293851.
- 4:10 PM Changeset in webkit [293864] by
-
- 4 edits in branches/safari-613-branch/Source/WebKit
Revert r293852. rdar://problem/88904160
This reverts a patch application at r293852.
- 3:42 PM Changeset in webkit [293863] by
-
- 8 edits in trunk/Source
Remove abandoned WKPreference for AlwaysUseAcceleratedOverflowScroll
https://bugs.webkit.org/show_bug.cgi?id=240130
Reviewed by Simon Fraser.
The preference 'AlwaysUseAcceleratedOverflowScroll' and related code are no longer used. We should remove this dead code.
Source/WebCore:
- rendering/RenderLayerScrollableArea.cpp:
(WebCore::RenderLayerScrollableArea::canUseCompositedScrolling const):
Source/WebKitLegacy/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences _setAlwaysUseAcceleratedOverflowScroll:]): Deleted.
(-[WebPreferences _alwaysUseAcceleratedOverflowScroll]): Deleted.
- WebView/WebPreferencesPrivate.h:
Source/WTF:
- Scripts/Preferences/WebPreferences.yaml:
- 3:27 PM Changeset in webkit [293862] by
-
- 2 edits in trunk
Add github info for myself to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240140
Unreviewed metadata addition.
- metadata/contributors.json:
- 3:14 PM Changeset in webkit [293861] by
-
- 3 edits in trunk/Source/WebKit
Unreviewed, reverting r293697.
Mergred to branch, not needed on trunk
Reverted changeset:
"Revert all use of
_setPrivacyProxyFailClosedForUnreachableNonMainHosts"
https://bugs.webkit.org/show_bug.cgi?id=239977
https://commits.webkit.org/r293697
- 2:40 PM Changeset in webkit [293860] by
-
- 19 edits in trunk
ARIA reflection for Element attributes
https://bugs.webkit.org/show_bug.cgi?id=239852
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Small fix on the test and update test results with the new PASS.
Add new test case to cover elements moved to a different document.
- web-platform-tests/dom/nodes/aria-element-reflection.tentative-expected.txt:
- web-platform-tests/dom/nodes/aria-element-reflection.tentative.html:
Source/WebCore:
Implement ARIA reflection for attributes that refer to a single Element:
aria-activedescendant & aria-errormessage.
For the properties names this patch uses "Element" suffix:
ariaActiveDescendantElement & ariaErrorMessageElement;
this matches Chromium implementation and AOM explainer, but not AOM spec:
https://github.com/w3c/aria/issues/1732
This implementation is done following the proposed spec text defined at:
https://github.com/whatwg/html/pull/3917
- accessibility/AriaAttributes.idl: Add ariaActiveDescendantElement &
ariaErrorMessageElement.
- bindings/scripts/CodeGenerator.pm:
(GetterExpression): Add function for Element attributes.
(SetterExpression): Ditto.
- bindings/scripts/test/JS/JSTestObj.cpp: Add tests for element
attribute reflection.
(WebCore::JSTestObjDOMConstructor::construct):
(WebCore::jsTestObj_reflectedElementAttrGetter):
(WebCore::JSC_DEFINE_CUSTOM_GETTER):
(WebCore::setJSTestObj_reflectedElementAttrSetter):
(WebCore::JSC_DEFINE_CUSTOM_SETTER):
- bindings/scripts/test/TestObj.idl: Add reflectedElementAttr
attribute.
- dom/Element.cpp:
(WebCore::isElementReflectionAttribute): Utility function to identify
Element reflection attributes.
(WebCore::Element::attributeChanged): If an element reflection
attribute has changed we need to synchronize the map entry by removing
it as it'll be properly updated in setElementAttribute() when needed.
(WebCore::Element::explicitlySetAttrElementsMap): Kind of getter
for the ExplicitlySetAttrElementsMap but that creates the map if it
doesn't exist yet.
(WebCore::Element::explicitlySetAttrElementsMapIfExists const):
Getter for the map.
(WebCore::Element::getElementAttribute const): Implement getter for
element attribute.
(WebCore::Element::setElementAttribute): Implement setter for
element attribute.
- dom/Element.h: Add new method headers and defines the
ExplicitlySetAttrElementsMap, which so far only stores one Element in
the Vector, but uses a Vector in preparation for supporting
FrozenArray<Element> reflection in the future.
- dom/ElementRareData.cpp: Update size of SameSizeAsElementRareData to
include the new pointer.
- dom/ElementRareData.h: Add m_explicitlySetAttrElementsMap attribute.
(WebCore::ElementRareData::explicitlySetAttrElementsMap): Getter.
(WebCore::ElementRareData::useTypes const):Include
ExplicitlySetAttrElementsMap.
- dom/Node.cpp:
(WebCore::stringForRareDataUseType): Add ExplicitlySetAttrElementsMap.
- dom/NodeRareData.h: Ditto.
Source/WTF:
Add new runtime flag AriaReflectionForElementReferencesEnabled.
- Scripts/Preferences/WebPreferencesExperimental.yaml:
LayoutTests:
Update test to include the new reflected attributes.
- accessibility/ARIA-reflection-expected.txt:
- accessibility/ARIA-reflection.html:
- 2:10 PM Changeset in webkit [293859] by
-
- 2 edits in trunk/LayoutTests
[ iOS ][ Monterey Release wk2 ] imported/w3c/web-platform-tests/content-security-policy/inheritance/blob-url-in-main-window-self-navigate-inherits.sub.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=239568
Unreviewed test gardening.
Canonical link: https://commits.webkit.org/250324@main
- 12:44 PM Changeset in webkit [293858] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, partial revert of r293813 because of proposal's issue.
https://bugs.webkit.org/show_bug.cgi?id=240102
- runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::initializeNumberFormat):
- 11:58 AM Changeset in webkit [293857] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary calls to CachedResource::updateBuffer and CachedResource::updateData
https://bugs.webkit.org/show_bug.cgi?id=240126
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-05
Reviewed by Chris Dumez.
It adds a function call that does nothing but a redundant assert.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::updateBufferInternal):
(WebCore::CachedImage::updateBuffer):
(WebCore::CachedImage::updateData):
- 11:54 AM Changeset in webkit [293856] by
-
- 1 copy in tags/WebKit-7613.2.7.1.9
Tag WebKit-7613.2.7.1.9.
- 11:50 AM Changeset in webkit [293855] by
-
- 9 edits in branches/safari-613.2.7.1-branch/Source
Versioning.
WebKit-7613.2.7.1.9
- 11:42 AM Changeset in webkit [293854] by
-
- 1 edit5 deletes in trunk/LayoutTests
Remove and cleanup platform expectations folders
https://bugs.webkit.org/show_bug.cgi?id=240131
Unreviewed test gardening.
- platform/mac-catalina-wk1/TestExpectations: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/anchor-element-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/attrib-string-colors-with-color-filter-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/attribute-string-for-copy-with-color-filter-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-1-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-2-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-3-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-4-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-5-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-for-typing-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/attributed-string-for-typing-with-color-filter-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/basic-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/comment-cdata-section-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/font-size-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/font-style-variant-effect-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/font-weight-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/letter-spacing-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/text-decorations-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/mac/attributed-string/vertical-align-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/selection/select-across-readonly-input-4-expected.txt: Removed.
- platform/mac-catalina-wk1/editing/selection/select-across-readonly-input-5-expected.txt: Removed.
- platform/mac-catalina-wk1/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Removed.
- platform/mac-catalina-wk1/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001-expected.txt: Removed.
- platform/mac-catalina-wk2/fast/events/contextmenu-lookup-action-for-image-expected.txt: Removed.
- platform/mac-catalina-wk2/http/tests/websocket/tests/hybi/send-object-tostring-check-expected.txt: Removed.
- platform/mac-catalina-wk2/http/tests/workers/service/serviceworker-websocket.https-expected.txt: Removed.
- platform/mac-catalina-wk2/imported/w3c/web-platform-tests/media-source/mediasource-invalid-codec-expected.txt: Removed.
- platform/mac-catalina-wk2/imported/w3c/web-platform-tests/service-workers/service-worker/websocket-in-service-worker.https-expected.txt: Removed.
- platform/mac-catalina-wk2/imported/w3c/web-platform-tests/service-workers/service-worker/websocket.https-expected.txt: Removed.
- platform/mac-catalina-wk2/imported/w3c/web-platform-tests/websockets/basic-auth.any-expected.txt: Removed.
- platform/mac-catalina-wk2/imported/w3c/web-platform-tests/websockets/basic-auth.any.worker-expected.txt: Removed.
- platform/mac-catalina-wk2/imported/w3c/web-platform-tests/websockets/remove-own-iframe-during-onerror.window-expected.txt: Removed.
- platform/mac-catalina/TestExpectations: Removed.
- platform/mac-catalina/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
- platform/mac-catalina/editing/pasteboard/pasting-tabs-expected.txt: Removed.
- platform/mac-catalina/editing/selection/3690703-2-expected.txt: Removed.
- platform/mac-catalina/editing/selection/3690703-expected.txt: Removed.
- platform/mac-catalina/editing/selection/3690719-expected.txt: Removed.
- platform/mac-catalina/editing/selection/select-from-textfield-outwards-expected.txt: Removed.
- platform/mac-catalina/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt: Removed.
- platform/mac-catalina/editing/selection/vertical-rl-rtl-extend-line-backward-br-mixed-expected.txt: Removed.
- platform/mac-catalina/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt: Removed.
- platform/mac-catalina/editing/selection/vertical-rl-rtl-extend-line-backward-p-mixed-expected.txt: Removed.
- platform/mac-catalina/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt: Removed.
- platform/mac-catalina/editing/selection/vertical-rl-rtl-extend-line-forward-br-mixed-expected.txt: Removed.
- platform/mac-catalina/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt: Removed.
- platform/mac-catalina/editing/selection/vertical-rl-rtl-extend-line-forward-p-mixed-expected.txt: Removed.
- platform/mac-catalina/fast/block/basic/001-expected.txt: Removed.
- platform/mac-catalina/fast/block/float/float-avoidance-expected.txt: Removed.
- platform/mac-catalina/fast/css/apple-system-control-colors-expected.txt: Removed.
- platform/mac-catalina/fast/css/continuationCrash-expected.txt: Removed.
- platform/mac-catalina/fast/css/rtl-ordering-expected.txt: Removed.
- platform/mac-catalina/fast/css/text-overflow-input-expected.txt: Removed.
- platform/mac-catalina/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Removed.
- platform/mac-catalina/fast/forms/auto-fill-button/hide-auto-fill-strong-password-viewable-treatment-when-form-is-reset-expected.txt: Removed.
- platform/mac-catalina/fast/forms/basic-inputs-expected.txt: Removed.
- platform/mac-catalina/fast/forms/basic-textareas-quirks-expected.txt: Removed.
- platform/mac-catalina/fast/forms/box-shadow-override-expected.txt: Removed.
- platform/mac-catalina/fast/forms/button-positioned-expected.txt: Removed.
- platform/mac-catalina/fast/forms/button-sizes-expected.txt: Removed.
- platform/mac-catalina/fast/forms/date/date-input-rendering-basic-expected.txt: Removed.
- platform/mac-catalina/fast/forms/form-element-geometry-expected.txt: Removed.
- platform/mac-catalina/fast/forms/hidpi-textfield-background-bleeding-expected.html: Removed.
- platform/mac-catalina/fast/forms/input-appearance-height-expected.txt: Removed.
- platform/mac-catalina/fast/forms/input-appearance-preventDefault-expected.txt: Removed.
- platform/mac-catalina/fast/forms/input-appearance-spinbutton-expected.txt: Removed.
- platform/mac-catalina/fast/forms/input-appearance-spinbutton-up-expected.txt: Removed.
- platform/mac-catalina/fast/forms/input-button-sizes-expected.txt: Removed.
- platform/mac-catalina/fast/forms/input-disabled-color-expected.txt: Removed.
- platform/mac-catalina/fast/forms/input-placeholder-visibility-1-expected.txt: Removed.
- platform/mac-catalina/fast/forms/input-placeholder-visibility-3-expected.txt: Removed.
- platform/mac-catalina/fast/forms/input-readonly-dimmed-expected.txt: Removed.
- platform/mac-catalina/fast/forms/input-table-expected.txt: Removed.
- platform/mac-catalina/fast/forms/input-text-word-wrap-expected.txt: Removed.
- platform/mac-catalina/fast/forms/input-value-expected.txt: Removed.
- platform/mac-catalina/fast/forms/listbox-bidi-align-expected.txt: Removed.
- platform/mac-catalina/fast/forms/listbox-width-change-expected.txt: Removed.
- platform/mac-catalina/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Removed.
- platform/mac-catalina/fast/forms/option-text-clip-expected.txt: Removed.
- platform/mac-catalina/fast/forms/plaintext-mode-2-expected.txt: Removed.
- platform/mac-catalina/fast/forms/range/input-appearance-range-expected.txt: Removed.
- platform/mac-catalina/fast/forms/range/slider-padding-expected.txt: Removed.
- platform/mac-catalina/fast/forms/range/slider-thumb-shared-style-expected.txt: Removed.
- platform/mac-catalina/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Removed.
- platform/mac-catalina/fast/forms/search-rtl-expected.txt: Removed.
- platform/mac-catalina/fast/forms/search/search-size-with-decorations-expected.txt: Removed.
- platform/mac-catalina/fast/forms/search/search-zoom-computed-style-height-expected.txt: Removed.
- platform/mac-catalina/fast/forms/select-change-listbox-to-popup-expected.txt: Removed.
- platform/mac-catalina/fast/forms/select-change-popup-to-listbox-expected.txt: Removed.
- platform/mac-catalina/fast/forms/select-selected-expected.txt: Removed.
- platform/mac-catalina/fast/forms/select-visual-hebrew-expected.txt: Removed.
- platform/mac-catalina/fast/forms/select/optgroup-rendering-expected.txt: Removed.
- platform/mac-catalina/fast/forms/textAreaLineHeight-expected.txt: Removed.
- platform/mac-catalina/fast/forms/textarea-placeholder-visibility-1-expected.txt: Removed.
- platform/mac-catalina/fast/forms/textarea-placeholder-visibility-2-expected.txt: Removed.
- platform/mac-catalina/fast/forms/textfield-outline-expected.txt: Removed.
- platform/mac-catalina/fast/forms/time/time-input-rendering-basic-expected.txt: Removed.
- platform/mac-catalina/fast/forms/visual-hebrew-text-field-expected.txt: Removed.
- platform/mac-catalina/fast/parser/document-write-option-expected.txt: Removed.
- platform/mac-catalina/fast/parser/entity-comment-in-textarea-expected.txt: Removed.
- platform/mac-catalina/fast/parser/open-comment-in-textarea-expected.txt: Removed.
- platform/mac-catalina/fast/repaint/block-inputrange-repaint-expected.txt: Removed.
- platform/mac-catalina/fast/repaint/slider-thumb-drag-release-expected.txt: Removed.
- platform/mac-catalina/fast/sandbox/mac/sandbox-mach-lookup-expected.txt: Removed.
- platform/mac-catalina/fast/text/backslash-to-yen-sign-euc-expected.txt: Removed.
- platform/mac-catalina/fast/text/basic/014-expected.txt: Removed.
- platform/mac-catalina/fast/text/capitalize-boundaries-expected.txt: Removed.
- platform/mac-catalina/fast/text/drawBidiText-expected.txt: Removed.
- platform/mac-catalina/fast/text/hyphenate-avoid-orphaned-word-expected.txt: Removed.
- platform/mac-catalina/fast/text/hyphenate-character-expected.txt: Removed.
- platform/mac-catalina/fast/text/hyphenate-first-word-expected.txt: Removed.
- platform/mac-catalina/fast/text/hyphenate-limit-before-after-expected.txt: Removed.
- platform/mac-catalina/fast/text/hyphenate-limit-lines-expected.txt: Removed.
- platform/mac-catalina/fast/text/hyphenate-locale-expected.txt: Removed.
- platform/mac-catalina/fast/text/hyphens-expected.txt: Removed.
- platform/mac-catalina/fast/text/indic-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/bidi-fallback-font-weight-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/bidi-linebreak-001-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/bidi-linebreak-002-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/bidi-linebreak-003-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/danda-space-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-en-US-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-en-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-es-ES-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-es-MX-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-es-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-fr-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-hi-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-pt-BR-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/system-language/navigator-language/navigator-language-ru-expected.txt: Removed.
- platform/mac-catalina/fast/text/international/system-language/system-font-punctuation-expected.txt: Removed.
- platform/mac-catalina/fast/text/justify-ideograph-leading-expansion-expected.txt: Removed.
- platform/mac-catalina/fast/text/midword-break-after-breakable-char-expected.txt: Removed.
- platform/mac-catalina/fast/text/vertical-rl-rtl-linebreak-expected.txt: Removed.
- platform/mac-catalina/fast/text/vertical-rl-rtl-linebreak-mixed-expected.txt: Removed.
- platform/mac-catalina/http/tests/navigation/javascriptlink-frames-expected.txt: Removed.
- platform/mac-catalina/http/tests/xmlhttprequest/methods-async-expected.txt: Removed.
- platform/mac-catalina/http/tests/xmlhttprequest/methods-expected.txt: Removed.
- platform/mac-catalina/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Removed.
- platform/mac-catalina/http/tests/xmlhttprequest/workers/methods-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.any-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.any.worker-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/fetch/redirect-navigate/preserve-fragment-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/mime-types/canPlayType-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/resize-during-playback-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/mathml/relations/html5-tree/dynamic-childlist-001-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/media-source/mediasource-invalid-codec-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/websockets/interfaces/WebSocket/bufferedAmount/bufferedAmount-getting-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/xhr/send-entity-body-empty-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/xhr/send-entity-body-get-head-async-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/xhr/send-entity-body-get-head-expected.txt: Removed.
- platform/mac-catalina/imported/w3c/web-platform-tests/xhr/send-entity-body-none-expected.txt: Removed.
- platform/mac-catalina/inspector/css/get-system-fonts-expected.txt: Removed.
- platform/mac-catalina/media/media-can-play-webm-expected.txt: Removed.
- platform/mac-catalina/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Removed.
- platform/mac-catalina/platform/mac/fast/text/bidi-fallback-font-weight-expected.txt: Removed.
- platform/mac-catalina/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Removed.
- platform/mac-catalina/platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt: Removed.
- platform/mac-catalina/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed.
- platform/mac-catalina/svg/custom/svg-fonts-without-missing-glyph-expected.txt: Removed.
- platform/mac-catalina/svg/text/bidi-tspans-expected.txt: Removed.
- platform/mac-catalina/tables/mozilla/bugs/bug18359-expected.txt: Removed.
- platform/mac-catalina/tables/mozilla/bugs/bug2479-3-expected.txt: Removed.
- platform/mac-catalina/tables/mozilla/bugs/bug26178-expected.txt: Removed.
- platform/mac-catalina/tables/mozilla/bugs/bug30692-expected.txt: Removed.
- platform/mac-catalina/tables/mozilla/bugs/bug33855-expected.txt: Removed.
- platform/mac-catalina/tables/mozilla/bugs/bug60749-expected.txt: Removed.
- platform/mac-catalina/tables/mozilla/bugs/bug7342-expected.txt: Removed.
- platform/mac-catalina/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Removed.
- platform/mac-catalina/tables/mozilla/other/wa_table_tr_align-expected.txt: Removed.
- platform/mac-catalina/transforms/2d/zoom-menulist-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/anchor-element-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/attrib-string-colors-with-color-filter-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/attribute-string-for-copy-with-color-filter-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-1-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-2-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-3-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-4-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-5-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-1-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/attributed-string-for-typing-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/attributed-string-for-typing-with-color-filter-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/basic-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/comment-cdata-section-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/font-size-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/font-style-variant-effect-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/font-weight-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/letter-spacing-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/text-decorations-expected.txt: Removed.
- platform/mac-mojave-wk1/editing/mac/attributed-string/vertical-align-expected.txt: Removed.
- platform/mac-mojave-wk1/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.any-expected.txt: Removed.
- platform/mac-mojave-wk1/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.any.worker-expected.txt: Removed.
- platform/mac-mojave/css1/basic/inheritance-expected.txt: Removed.
- platform/mac-mojave/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Removed.
- platform/mac-mojave/css2.1/t0805-c5522-brdr-02-e-expected.txt: Removed.
- platform/mac-mojave/css2.1/t1202-counter-09-b-expected.txt: Removed.
- platform/mac-mojave/css2.1/t1202-counters-09-b-expected.txt: Removed.
- platform/mac-mojave/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
- platform/mac-mojave/editing/mac/selection/context-menu-select-editability-expected.txt: Removed.
- platform/mac-mojave/editing/selection/3690703-2-expected.txt: Removed.
- platform/mac-mojave/editing/selection/3690703-expected.txt: Removed.
- platform/mac-mojave/editing/selection/3690719-expected.txt: Removed.
- platform/mac-mojave/fast/block/basic/001-expected.txt: Removed.
- platform/mac-mojave/fast/block/float/float-avoidance-expected.txt: Removed.
- platform/mac-mojave/fast/css-generated-content/014-expected.png: Removed.
- platform/mac-mojave/fast/css-generated-content/014-expected.txt: Removed.
- platform/mac-mojave/fast/css/apple-system-control-colors-expected.txt: Removed.
- platform/mac-mojave/fast/css/continuationCrash-expected.txt: Removed.
- platform/mac-mojave/fast/css/css3-nth-child-expected.txt: Removed.
- platform/mac-mojave/fast/css/line-height-font-order-expected.png: Removed.
- platform/mac-mojave/fast/css/line-height-font-order-expected.txt: Removed.
- platform/mac-mojave/fast/css/rtl-ordering-expected.txt: Removed.
- platform/mac-mojave/fast/css/text-overflow-input-expected.txt: Removed.
- platform/mac-mojave/fast/dom/34176-expected.txt: Removed.
- platform/mac-mojave/fast/dom/clone-node-dynamic-style-expected.txt: Removed.
- platform/mac-mojave/fast/forms/basic-inputs-expected.txt: Removed.
- platform/mac-mojave/fast/forms/button-positioned-expected.txt: Removed.
- platform/mac-mojave/fast/forms/button-sizes-expected.txt: Removed.
- platform/mac-mojave/fast/forms/date/date-input-rendering-basic-expected.txt: Removed.
- platform/mac-mojave/fast/forms/input-appearance-spinbutton-expected.txt: Removed.
- platform/mac-mojave/fast/forms/input-button-sizes-expected.txt: Removed.
- platform/mac-mojave/fast/forms/input-disabled-color-expected.txt: Removed.
- platform/mac-mojave/fast/forms/input-readonly-dimmed-expected.txt: Removed.
- platform/mac-mojave/fast/forms/input-text-word-wrap-expected.txt: Removed.
- platform/mac-mojave/fast/forms/listbox-bidi-align-expected.txt: Removed.
- platform/mac-mojave/fast/forms/listbox-width-change-expected.txt: Removed.
- platform/mac-mojave/fast/forms/option-text-clip-expected.txt: Removed.
- platform/mac-mojave/fast/forms/plaintext-mode-2-expected.txt: Removed.
- platform/mac-mojave/fast/forms/search-rtl-expected.txt: Removed.
- platform/mac-mojave/fast/forms/search/search-size-with-decorations-expected.txt: Removed.
- platform/mac-mojave/fast/forms/select-change-listbox-to-popup-expected.txt: Removed.
- platform/mac-mojave/fast/forms/select-change-popup-to-listbox-expected.txt: Removed.
- platform/mac-mojave/fast/forms/select-selected-expected.txt: Removed.
- platform/mac-mojave/fast/forms/select/optgroup-rendering-expected.txt: Removed.
- platform/mac-mojave/fast/forms/textfield-outline-expected.txt: Removed.
- platform/mac-mojave/fast/forms/time/time-input-rendering-basic-expected.txt: Removed.
- platform/mac-mojave/fast/images/image-controls-basic-expected.png: Removed.
- platform/mac-mojave/fast/indic-expected.txt: Removed.
- platform/mac-mojave/fast/invalid/003-expected.txt: Removed.
- platform/mac-mojave/fast/invalid/004-expected.txt: Removed.
- platform/mac-mojave/fast/invalid/nestedh3s-expected.txt: Removed.
- platform/mac-mojave/fast/overflow/007-expected.png: Removed.
- platform/mac-mojave/fast/overflow/007-expected.txt: Removed.
- platform/mac-mojave/fast/parser/document-write-option-expected.txt: Removed.
- platform/mac-mojave/fast/sandbox/mac/sandbox-mach-lookup-expected.txt: Removed.
- platform/mac-mojave/fast/selectors/018-expected.txt: Removed.
- platform/mac-mojave/fast/table/frame-and-rules-expected.txt: Removed.
- platform/mac-mojave/fast/text/atsui-multiple-renderers-expected.txt: Removed.
- platform/mac-mojave/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Removed.
- platform/mac-mojave/fast/text/font-weights-expected.txt: Removed.
- platform/mac-mojave/fast/text/font-weights-zh-expected.txt: Removed.
- platform/mac-mojave/fast/text/hyphenate-avoid-orphaned-word-expected.txt: Removed.
- platform/mac-mojave/fast/text/hyphenate-character-expected.png: Removed.
- platform/mac-mojave/fast/text/hyphenate-character-expected.txt: Removed.
- platform/mac-mojave/fast/text/hyphens-expected.png: Removed.
- platform/mac-mojave/fast/text/hyphens-expected.txt: Removed.
- platform/mac-mojave/fast/text/indic-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/bidi-fallback-font-weight-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/bidi-mirror-he-ar-expected.png: Removed.
- platform/mac-mojave/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/danda-space-expected.png: Removed.
- platform/mac-mojave/fast/text/international/danda-space-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-en-US-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-en-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-419-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-ES-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-MX-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-fr-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-hi-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-ja-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-pt-BR-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-ru-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-zh-HK-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK-expected.txt: Removed.
- platform/mac-mojave/fast/text/international/system-language/system-font-punctuation-expected.txt: Removed.
- platform/mac-mojave/http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt: Removed.
- platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Removed.
- platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-navigation-from-cross-origin-page-expected.txt: Removed.
- platform/mac-mojave/http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page-expected.txt: Removed.
- platform/mac-mojave/http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt: Removed.
- platform/mac-mojave/http/tests/cookies/same-site/popup-cross-site-expected.txt: Removed.
- platform/mac-mojave/http/tests/cookies/same-site/popup-cross-site-post-expected.txt: Removed.
- platform/mac-mojave/http/tests/cookies/same-site/popup-same-site-via-cross-site-redirect-expected.txt: Removed.
- platform/mac-mojave/http/tests/inspector/network/resource-sizes-network-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/cors/access-control-expose-headers-parsing.window-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/cors/credentials-flag-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/cors/origin-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/css/css-fonts/generic-family-keywords-001-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/css/css-pseudo/text-selection-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/fetch/api/basic/header-value-combining.any.worker-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.any-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.any.worker-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/fetch/content-type/script.window-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/fetch/nosniff/parsing-nosniff.window-actual.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/fetch/nosniff/parsing-nosniff.window-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/mathml/relations/css-styling/ignored-properties-001-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-002-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/xhr/getallresponseheaders-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/xhr/getresponseheader.any-expected.txt: Removed.
- platform/mac-mojave/imported/w3c/web-platform-tests/xhr/getresponseheader.any.worker-expected.txt: Removed.
- platform/mac-mojave/platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt: Removed.
- platform/mac-mojave/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Removed.
- platform/mac-mojave/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Removed.
- platform/mac-mojave/svg/batik/text/textStyles-expected.txt: Removed.
- platform/mac-mojave/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
- platform/mac-mojave/tables/mozilla/bugs/bug10296-1-expected.png: Removed.
- platform/mac-mojave/tables/mozilla/bugs/bug10296-1-expected.txt: Removed.
- platform/mac-mojave/tables/mozilla/bugs/bug139524-2-expected.png: Removed.
- platform/mac-mojave/tables/mozilla/bugs/bug139524-2-expected.txt: Removed.
- platform/mac-mojave/tables/mozilla/bugs/bug2479-3-expected.txt: Removed.
- platform/mac-mojave/tables/mozilla/bugs/bug30692-expected.txt: Removed.
- platform/mac-mojave/tables/mozilla/bugs/bug33855-expected.txt: Removed.
- platform/mac-mojave/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Removed.
- platform/mac-mojave/tables/mozilla/other/wa_table_tr_align-expected.txt: Removed.
- platform/mac-mojave/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Removed.
- platform/mac-mojave/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Removed.
Canonical link: https://commits.webkit.org/250321@main
- 11:37 AM Changeset in webkit [293853] by
-
- 2 edits in trunk/Source/WebKit
Allow hw.cpu64bit_capable sysctl-read in network process sandbox on iOS
https://bugs.webkit.org/show_bug.cgi?id=240124
<rdar://92797350>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-05
Reviewed by Per Arne Vollan.
It's used on watchOS.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in:
- 11:36 AM Changeset in webkit [293852] by
-
- 4 edits in branches/safari-613-branch/Source/WebKit
Apply patch. rdar://problem/88904160
- 11:35 AM Changeset in webkit [293851] by
-
- 5 edits in branches/safari-613-branch/Source/WebKit
Apply patch. rdar://problem/88904160
- 11:35 AM Changeset in webkit [293850] by
-
- 18 edits in branches/safari-613-branch
Apply patch. rdar://problem/88904160
- 11:31 AM Changeset in webkit [293849] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
[bugs.webkit.org] Replace svn.webkit.org in committers autocomplete
https://bugs.webkit.org/show_bug.cgi?id=240090
<rdar://problem/92758558>
Reviewed by Aakash Jain.
- Websites/bugs.webkit.org/committers-autocomplete.js: Replace
svn.webkit.org with raw.githubusercontent.com.
Canonical link: https://commits.webkit.org/250319@main
- 11:28 AM Changeset in webkit [293848] by
-
- 6 edits in branches/safari-613-branch/Source/WebKit
Revert r293791. rdar://problem/88904160
This reverts the application of a patch landed at r293791.
- 11:26 AM Changeset in webkit [293847] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] Clean up StructureID related data
https://bugs.webkit.org/show_bug.cgi?id=240114
Reviewed by Mark Lam.
This patch moves structureHeapAddressSize to StructureID. And define it only when we use it.
We also use decontaminate() in ADDRESS32 tryDecode. Strictly speaking, it is not necessary
for now since 32bit environment does not have concurrent GC & concurrent JIT compiler, but
it can have that.
- Source/JavaScriptCore/runtime/JSCConfig.h:
- Source/JavaScriptCore/runtime/StructureID.h:
(JSC::StructureID::tryDecode const):
Canonical link: https://commits.webkit.org/250318@main
- 11:00 AM Changeset in webkit [293846] by
-
- 10 edits1 add in trunk/Source
[GPU Process] NativeImage should share the ShareableBitmap data when it's sent to GPU Process
https://bugs.webkit.org/show_bug.cgi?id=239874
rdar://92031359
Reviewed by Simon Fraser.
Source/WebCore:
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/BackingStoreCopy.h: Added.
- platform/graphics/ImageBufferBackend.h:
(): Deleted.
Source/WebKit:
Instead of allocating a new memory buffer in GPUProcess and copying the
ShareableBitmap data to it, we can create a PlatformImage that directly
references this data. This will make all the NativeImages data be attributed
to WebProcess.
- GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::cacheNativeImageWithQualifiedIdentifier):
- Shared/ShareableBitmap.h:
(WebKit::ShareableBitmap::createPlatformImage):
- Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::makeCGImage):
(WebKit::ShareableBitmap::createPlatformImage):
(WebKit::ShareableBitmap::createCGImage const):
(WebKit::ShareableBitmap::releaseDataProviderData): Deleted.
- WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:
(WebKit::ImageBufferShareableBitmapBackend::copyNativeImage const):
- WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
- 10:27 AM Changeset in webkit [293845] by
-
- 2 edits in trunk/LayoutTests
[ Catalina EWS ] webgl/2.0.0/* tests are flaky crashing ASSERTION FAILED: !needsLayout()
https://bugs.webkit.org/show_bug.cgi?id=229580
Unreviewed test gardening. Skip WebGL tests on mac-wk1.
- platform/mac-wk1/TestExpectations:
Canonical link: https://commits.webkit.org/250316@main
- 10:13 AM Changeset in webkit [293844] by
-
- 1 copy in tags/WebKit-7614.1.12
Tag WebKit-7614.1.12.
- 9:52 AM Changeset in webkit [293843] by
-
- 2 edits in branches/safari-7614.1.12-branch/Source/WebCore
Cherry-pick r293825. rdar://problem/92635752
[GPU Process] [iOS] REGRESSION(r293570): Snapshot rendering is not scaled with the device scale factor
https://bugs.webkit.org/show_bug.cgi?id=240100
rdar://92635752
Reviewed by Simon Fraser.
The scaling factor is not set in the GraphicsContext of the
ImageBufferShareableBitmapBackend.
To fix this bug is to make snapshotFrameRectWithClip() handle the scaling
outside the ImageBuffer creation. This is similar to what we do in
GraphicsContext::createAlignedImageBuffer() where we scale the size and
create the ImageBuffer with scaleFactor = 1.
- page/FrameSnapshotting.cpp: (WebCore::snapshotFrameRectWithClip):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:40 AM Changeset in webkit [293842] by
-
- 5 edits1 add in trunk
SuspendableWorkQueue::suspend should invoke callback immediately when queue is suspended
https://bugs.webkit.org/show_bug.cgi?id=240070
Reviewed by Chris Dumez.
Source/WTF:
With current implementation, if suspend() is called when queue is suspended, the completionHandler is not
invoked unitl the queue is resumed and suspended again. This might cause confusion for callers. To fix it,
now SuspendableWorkQueue will invoke callback immediately when queue is already suspended.
API test: WTF_SuspendableWorkQueue.SuspendTwice
- wtf/SuspendableWorkQueue.cpp:
(WTF::SuspendableWorkQueue::suspend):
(WTF::SuspendableWorkQueue::resume):
(WTF::SuspendableWorkQueue::dispatchSync):
(WTF::SuspendableWorkQueue::suspendIfNeeded):
- wtf/SuspendableWorkQueue.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/SuspendableWorkQueue.cpp: Added.
(TestWebKitAPI::TEST):
- 9:34 AM Changeset in webkit [293841] by
-
- 7 edits1 add in trunk
BroadcastChannel instance in data URL dedicated worker can communicate with creator context
https://bugs.webkit.org/show_bug.cgi?id=240016
Reviewed by Youenn Fablet.
For workers, we used to dispatch to the loader document and then get the origin from that loader document.
This normally works because the worker usually inherits the origin from its loader document. However, when
the worker is loaded from a data URL, its origin is opaque:
To address the issue, we now get the security origin directly from the BroadcastChannel's
ScriptExecutionContext, before dispatching to the main thread.
This led to one issue though because I now have to call isolatedCopy() on the SecurityOrigin to pass it to
the main thread. In particular, 2 BroadcastChannels from the same opaque origin should be able to talk to
each other. This used to work because the SecurityOrigin objects would have the same pointers and
SecurityOrigin::isSameOriginAs() would check for pointer equality. However, now that I call isolatedCopy(),
we get new & different pointers so this wouldn't work anymore. To address this, I replaced the m_isUnique
boolean data member on SecurityOrigin with a global uniqueOriginIdentifier and we check this identifier
to see if 2 opaque/unique SecurityOrigin objects are for the same opaque/unique origin. This means the
check will still work if the SecurityOrigin objects are isolated-copied or even IPC'd.
- LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html:
Resync to get test coverage from upstream WPT.
- Source/WebCore/dom/BroadcastChannel.cpp:
(WebCore::BroadcastChannel::MainThreadBridge::registerChannel):
- Source/WebCore/page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::isSameOriginAs const):
(WebCore::SecurityOrigin::equal const):
- Source/WebCore/page/SecurityOrigin.h:
(WebCore::SecurityOrigin::isUnique const):
(WebCore::SecurityOrigin::encode const):
(WebCore::SecurityOrigin::decode):
Canonical link: https://commits.webkit.org/250314@main
- 9:29 AM Changeset in webkit [293840] by
-
- 3 edits in trunk/LayoutTests
[ iOS ][ macOS ] imported/w3c/web-platform-tests/webrtc/protocol/rtp-clockrate.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240123
Unreviewed test gardening.
Canonical link: https://commits.webkit.org/250313@main
- 9:13 AM Changeset in webkit [293839] by
-
- 12 edits in trunk/Source
[WK2][Cocoa] Remove use of CVPixelBufferConformer from WebContent process in MediaPlayerPrivateRemote::nativeImageForCurrentTime()
https://bugs.webkit.org/show_bug.cgi?id=240108
<rdar://problem/92773611>
Reviewed by Simon Fraser.
Source/WebCore:
No longer pass a CVPixelBufferRef up through onNewVideoFrameMetadata().
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::onNewVideoFrameMetadata):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerOnNewVideoFrameMetadata):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::checkNewVideoFrameMetadata):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::checkNewVideoFrameMetadata):
Source/WebKit:
CVPixelBufferConformer makes use of hardware acceleration to perform colorspace conversions,
and these calls fail when IOKit access is blocked from the WebContent sandbox. The use of
CVPixelBufferConformer (via PixelBufferConformerCV) in nativeImageForCurrentTime() is a
convenince when a web page is using rVFC() to avoid a call into the GPU process when that
callback results in a video->canvas paint. However, this convenience is not strictly necessary,
and by reverting this optimization, the conformance of the resulting pixel buffer is
performed upon request in the GPU process instead.
- GPUProcess/media/RemoteMediaPlayerProxy.h:
- GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:
(WebKit::RemoteMediaPlayerProxy::mediaPlayerOnNewVideoFrameMetadata):
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::stopVideoFrameMetadataGathering):
- WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:
- WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:
(WebKit::MediaPlayerPrivateRemote::pushVideoFrameMetadata):
(WebKit::MediaPlayerPrivateRemote::nativeImageForCurrentTime):
- 9:02 AM Changeset in webkit [293838] by
-
- 7 edits2 deletes in trunk/Tools/buildstream
[Flatpak SDK] Bump to GStreamer 1.20.2
https://bugs.webkit.org/show_bug.cgi?id=240121
Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-05
Reviewed by Adrian Perez de Castro.
- elements/sdk/gst-libav.bst:
- elements/sdk/gst-plugins-bad.bst:
- elements/sdk/gst-plugins-base.bst:
- elements/sdk/gst-plugins-good.bst:
- elements/sdk/gst-plugins-ugly.bst:
- elements/sdk/gstreamer.bst:
- patches/gstreamer-0001-typefind-Skip-parsing-of-data-URIs.patch: Removed.
- patches/gstreamer-0002-uri-Build-doubly-linked-list-by-prepending-items.patch: Removed.
Canonical link: https://commits.webkit.org/250311@main
- 8:55 AM Changeset in webkit [293837] by
-
- 3 edits in trunk/Source/WebKit
Optimize IPC Decoding for primitive types
https://bugs.webkit.org/show_bug.cgi?id=240106
Reviewed by Cameron McCormack.
Calls to memmove() showed up on profiles under Decoder::decodeFixedLengthData() for
primitive types. Allow the compiler to optimize these away by inlining Decoder::decodeFixedLengthData()
and related functions.
- Platform/IPC/Decoder.cpp:
(IPC::roundUpToAlignment): Deleted.
(IPC::alignedBufferIsLargeEnoughToContain): Deleted.
(IPC::Decoder::alignBufferPosition): Deleted.
(IPC::Decoder::bufferIsLargeEnoughToContain const): Deleted.
(IPC::Decoder::decodeFixedLengthData): Deleted.
- Platform/IPC/Decoder.h:
(IPC::roundUpToAlignment):
(IPC::alignedBufferIsLargeEnoughToContain):
(IPC::Decoder::alignBufferPosition):
(IPC::Decoder::bufferIsLargeEnoughToContain const):
(IPC::Decoder::decodeFixedLengthData):
- 8:48 AM Changeset in webkit [293836] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/watchlist
Add myself (Youssef Soliman) to watchlist for Media
https://bugs.webkit.org/show_bug.cgi?id=240101
Reviewed by Eric Carlson.
- Tools/Scripts/webkitpy/common/config/watchlist:
Canonical link: https://commits.webkit.org/250309@main
- 8:36 AM Changeset in webkit [293835] by
-
- 5 edits1 add in trunk
Right click using trackpad crashes Safari
https://bugs.webkit.org/show_bug.cgi?id=240030
rdar://91786269
Reviewed by Tim Horton.
Source/WebCore:
Trackpad on iOS should mimic mac selection behavior and block context
menu clicks that are not made on a text node.
- page/EventHandler.cpp:
(WebCore::EventHandler::selectClosestContextualWordOrLinkFromHitTestResult):
(WebCore::EventHandler::sendContextMenuEvent):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/emptyTable.html: Added.
- TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm:
(TEST):
- 8:18 AM Changeset in webkit [293834] by
-
- 2 edits in trunk/LayoutTests
[Gardening]REGRESSION (r293506): [ iOS ][ macOS ] imported/w3c/web-platform-tests/service-workers/service-worker/registration-updateviacache.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240074
Unreviewed test gardening.
Canonical link: https://commits.webkit.org/250307@main
- 8:15 AM Changeset in webkit [293833] by
-
- 4 edits in trunk/Source
Add SharedVideoFrameReader/SharedVideoFrameWriter logging for error cases
https://bugs.webkit.org/show_bug.cgi?id=236066
<rdar://problem/88424960>
Reviewed by Eric Carlson.
Source/WebCore:
No change of behavior.
- platform/cocoa/SharedVideoFrameInfo.mm:
(WebCore::SharedVideoFrameInfo::writePixelBuffer):
Source/WebKit:
- WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
(WebKit::SharedVideoFrameWriter::prepareWriting):
(WebKit::SharedVideoFrameReader::readBufferFromSharedMemory):
(WebKit::SharedVideoFrameReader::readBuffer):
- 8:04 AM Changeset in webkit [293832] by
-
- 3 edits in trunk/Tools
[webkitbugspy] Include mocks in package
https://bugs.webkit.org/show_bug.cgi?id=240098
<rdar://problem/92763124>
Reviewed by Aakash Jain.
- Scripts/libraries/webkitbugspy/setup.py:
- Scripts/libraries/webkitbugspy/webkitbugspy/init.py:
Canonical link: https://commits.webkit.org/250305@main
- 8:01 AM Changeset in webkit [293831] by
-
- 5 edits in trunk/Tools
[git-webkit] Fetch alternate remotes when adding remote
https://bugs.webkit.org/show_bug.cgi?id=240066
<rdar://problem/92733391>
Reviewed by Ryan Haddad.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto,
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: Mock
git fetch
for non-fork remotes.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup._add_remote): Optionally fetch remote after adding it.
(Setup.git):
Canonical link: https://commits.webkit.org/250304@main
- 7:45 AM Changeset in webkit [293830] by
-
- 7 edits1 copy1 add in trunk
<input type=color> should have box-sizing: border-box in UA stylesheet
https://bugs.webkit.org/show_bug.cgi?id=197878
Reviewed by Tim Nguyen.
LayoutTests/imported/w3c:
- web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:
Source/WebCore:
As discussed at [1], We should have box-sizing: border-box for <input type=color>, the same
as buttons. WebKit currently has content-box. This patch is to change it to box-box.
Since <input type=color> is disabled with WebKitLegacy [2], this fix doesn't apply to it. Hence,
for mac-wk1 platform, the test expectation for html/rendering/non-replaced-elements/form-controls/resets.html
stays as it is.
[1] https://github.com/whatwg/html/issues/4281
[2] https://webkit-search.igalia.com/webkit/source/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml#425-437
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::colorInputStyleSheet const):
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::colorInputStyleSheet const):
LayoutTests:
- platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt.
- 6:42 AM Changeset in webkit [293829] by
-
- 22 edits1 delete in trunk/Source/WebKit
Connecting to GPU process may hang if UI process sends sync message simultaneously
https://bugs.webkit.org/show_bug.cgi?id=239905
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-05
Reviewed by Chris Dumez.
Previously, establishing GPU process connection would be a sync message:
- WP -> UI sync GetGPUProcessConnection
- UI -> GPUP async CreateGPUConnectionToWebProcess
- GPUP -> UI async reply CreateGPUConnectionToWebProcess
- UI -> WP sync reply GetGPUProcessConnection
If UI would send a message to WP after step 3 and wait for reply, this
would never come as WP would be waiting for the sync reply for GetGPUProcessConnection.
This would happen for example with requestAutocorrectionContextWithCompletionHandler,
which would send HandleAutocorrectionContextRequest and wait for
Messages::WebPageProxy::HandleAutocorrectionContext messages.
Mitigate this by creating the GPU connection in WP and sending
that to GPUP through UI in an async message. This way WP does not block on the GPUP
connection initialization. Send the GPUP connection initialization result, audit token and
vp9 HW decoder presence, as the first user message through the new connection.
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::create):
(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
- GPUProcess/GPUConnectionToWebProcess.h:
- GPUProcess/GPUProcess.cpp:
(WebKit::asConnectionIdentifier):
(WebKit::GPUProcess::createGPUConnectionToWebProcess):
- GPUProcess/GPUProcess.h:
- GPUProcess/GPUProcess.messages.in:
- Shared/GPUProcessConnectionInitializationParameters.h:
(WebKit::GPUProcessConnectionInitializationParameters::decode):
- Shared/GPUProcessConnectionParameters.h:
(WebKit::GPUProcessConnectionParameters::encode const):
(WebKit::GPUProcessConnectionParameters::decode):
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::createGPUProcessConnection):
- UIProcess/GPU/GPUProcessProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createGPUProcessConnection):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createGPUProcessConnection):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::getGPUProcessConnectionParameters):
(WebKit::GPUProcessConnection::create):
(WebKit::GPUProcessConnection::GPUProcessConnection):
(WebKit::GPUProcessConnection::auditToken):
(WebKit::GPUProcessConnection::invalidate):
(WebKit::GPUProcessConnection::didInitialize):
(WebKit::GPUProcessConnection::waitForDidInitialize):
(WebKit::GPUProcessConnection::hasVP9HardwareDecoder):
- WebProcess/GPU/GPUProcessConnection.h:
- WebProcess/GPU/GPUProcessConnection.messages.in:
- WebProcess/GPU/GPUProcessConnectionInfo.h:
(WebKit::GPUProcessConnectionInfo::encode const):
(WebKit::GPUProcessConnectionInfo::decode):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureGPUProcessConnection):
- WebProcess/WebProcess.h:
- WebProcess/cocoa/WebProcessCocoa.mm:
- 5:12 AM Changeset in webkit [293828] by
-
- 2 edits in trunk/Source/JavaScriptCore
[GCC] REGRESSION(r293605): error: cannot convert ‘<brace-enclosed initializer list>’ to ‘unsigned char:3’ in initialization
https://bugs.webkit.org/show_bug.cgi?id=239897
Reviewed by Yusuke Suzuki.
- bytecode/MethodOfGettingAValueProfile.h: Move initialization of 'm_kind' to class constructor.
- 2:48 AM Changeset in webkit [293827] by
-
- 2 edits in trunk/Source/WebCore
replaceTrack with different constraints stops sending packets
https://bugs.webkit.org/show_bug.cgi?id=239978
<rdar://problem/92624773>
Reviewed by Eric Carlson.
We should always reconfigure the microphone processor even if we are not using it,
as VPIO expects that input and output formats should match.
Manually tested with https://bugs.webkit.org/show_bug.cgi?id=239978 and https://jsfiddle.net/72qsLw9a/.
A follow-up should allow to put more common code between CoreAudioSharedUnit and MockAudioSharedUnit
so that we can write a regression test.
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
- 1:50 AM WebKitGTK/2.36.x edited by
- (diff)
- 1:33 AM Changeset in webkit [293826] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION(249114@main) [GTK] Crashes on shutdown if the display is not set
https://bugs.webkit.org/show_bug.cgi?id=239767
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2022-05-05
Reviewed by Michael Catanzaro.
Handle the case of PlatformDisplay created with a nullptr GdkDisplay.
- platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::PlatformDisplay):
- platform/graphics/wayland/PlatformDisplayWayland.cpp:
(WebCore::PlatformDisplayWayland::PlatformDisplayWayland):
(WebCore::PlatformDisplayWayland::~PlatformDisplayWayland):
- platform/graphics/x11/PlatformDisplayX11.cpp:
(WebCore::PlatformDisplayX11::PlatformDisplayX11):
(WebCore::PlatformDisplayX11::~PlatformDisplayX11):
- 1:19 AM Changeset in webkit [293825] by
-
- 2 edits in trunk/Source/WebCore
[GPU Process] [iOS] REGRESSION(r293570): Snapshot rendering is not scaled with the device scale factor
https://bugs.webkit.org/show_bug.cgi?id=240100
rdar://92635752
Reviewed by Simon Fraser.
The scaling factor is not set in the GraphicsContext of the
ImageBufferShareableBitmapBackend.
To fix this bug is to make snapshotFrameRectWithClip() handle the scaling
outside the ImageBuffer creation. This is similar to what we do in
GraphicsContext::createAlignedImageBuffer() where we scale the size and
create the ImageBuffer with scaleFactor = 1.
- page/FrameSnapshotting.cpp:
(WebCore::snapshotFrameRectWithClip):
- 12:38 AM Changeset in webkit [293824] by
-
- 21 edits6 deletes in trunk/Source
SWOriginStore is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=240003
Reviewed by Chris Dumez.
Source/WebCore:
Covered by existing tests.
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- loader/DocumentLoader.cpp:
- workers/service/SWClientConnection.h:
- workers/service/WorkerSWClientConnection.cpp:
- workers/service/WorkerSWClientConnection.h:
- workers/service/server/SWOriginStore.cpp: Removed.
- workers/service/server/SWOriginStore.h: Removed.
- workers/service/server/SWServer.cpp:
- workers/service/server/SWServer.h:
Source/WebKit:
No observable change, we remove the SWOrigin optimization as its main remaining use
is to optimize the case of a page being loaded by service worker instead of app cache which is a tiny edge case.
- NetworkProcess/NetworkSession.cpp:
- NetworkProcess/NetworkSession.h:
- NetworkProcess/ServiceWorker/WebSWOriginStore.cpp: Removed.
- NetworkProcess/ServiceWorker/WebSWOriginStore.h: Removed.
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
- NetworkProcess/ServiceWorker/WebSWServerConnection.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Storage/WebSWClientConnection.cpp:
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWClientConnection.messages.in:
- WebProcess/Storage/WebSWOriginTable.cpp: Removed.
- WebProcess/Storage/WebSWOriginTable.h: Removed.
May 4, 2022:
- 11:38 PM Changeset in webkit [293823] by
-
- 11 edits in trunk/Source
SharedMemory::systemPageSize is redundant function
https://bugs.webkit.org/show_bug.cgi?id=240057
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-04
Reviewed by Antti Koivisto.
Source/WebKit:
Remove SharedMemory::systemPageSize().
Use WTF::pageSize() from PageBlock.h.
- Platform/SharedMemory.h:
- Platform/cocoa/SharedMemoryCocoa.cpp:
- Platform/unix/SharedMemoryUnix.cpp:
- Platform/win/SharedMemoryWin.cpp:
- Shared/SharedStringHashStore.cpp:
(WebKit::tableSizeForKeyCount):
- UIProcess/linux/MemoryPressureMonitor.cpp:
(WebKit::calculateMemoryAvailable):
- mac/WebKit2.order:
Source/WTF:
- wtf/PageBlock.cpp:
(WTF::systemPageSize):
Remove pointless static variable from OS(WINDOWS) variant.
- wtf/linux/CurrentProcessMemoryStatus.cpp:
(WTF::currentProcessMemoryStatus):
Remove another redundant implementation.
- 11:36 PM Changeset in webkit [293822] by
-
- 2 edits in trunk/Source/WebKit
Empty remote backing store collection prepare starts up GPU process
https://bugs.webkit.org/show_bug.cgi?id=240067
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-04
Reviewed by Simon Fraser.
Avoid starting up GPU process by using an early return if
prepareBuffersForDisplay input array is empty.
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::prepareBuffersForDisplay):
- 10:48 PM Changeset in webkit [293821] by
-
- 11 edits in trunk/Source
Optimize some convertToASCIIUppercase() call sites
https://bugs.webkit.org/show_bug.cgi?id=240095
Reviewed by Darin Adler.
Optimize some convertToASCIIUppercase() call sites. Also rename lowercase(StringView)
/ uppercase(StringView) to asASCIILowercase(StringView) / asASCIIUppercase(StringView)
for clarity, given that they only work with ASCII case.
- Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::handleForWebPageProxy):
(WebKit::WebAutomationSession::handleForWebFrameID):
- Source/WTF/wtf/text/StringConcatenate.h:
(WTF::asASCIILowercase):
(WTF::asASCIIUppercase):
(WTF::lowercase): Deleted.
(WTF::uppercase): Deleted.
- Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:
(WebCore::hostName):
- Source/WebCore/css/ContainerQueryParser.cpp:
(WebCore::consumeFeatureName):
- Source/WebCore/css/MediaQueryExpression.cpp:
(WebCore::MediaQueryExpression::serialize const):
- Source/WebCore/css/parser/CSSParserSelector.cpp:
(WebCore::CSSParserSelector::parsePseudoElementSelector):
(WebCore::CSSParserSelector::parsePseudoClassSelector):
- Source/WebCore/dom/TextDecoder.cpp:
(WebCore::TextDecoder::encoding const):
- Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::languageIdentifier):
- Source/WebCore/platform/text/hyphen/HyphenationLibHyphen.cpp:
(WebCore::extractLocaleFromDictionaryFileName):
(WebCore::canHyphenate):
(WebCore::lastHyphenLocation):
- Source/WebCore/xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::getAllResponseHeaders const):
Canonical link: https://commits.webkit.org/250294@main
- 9:56 PM Changeset in webkit [293820] by
-
- 6 edits2 adds in trunk
[Apple Pay] REGRESSION(r291588):
appearance: -apple-pay-buttondoesn't work withborder-width: 0
https://bugs.webkit.org/show_bug.cgi?id=240087
<rdar://problem/92559095>
Reviewed by Kate Cheney.
Source/WebCore:
As of r291588, all
appearancevalues now correspond to a specific element (or form control)
with the exception of-apple-pay-button, which can be applied to any element. Add logic to
specifically allow for this behavior.
Test: fast/css/appearance-apple-pay-button-border-width.html
- rendering/RenderTheme.cpp:
(WebCore::isAppearanceAllowedForAllElements): Added.
(WebCore::RenderTheme::adjustStyle):
LayoutTests:
- fast/css/appearance-apple-pay-button-border-width.html: Added.
- fast/css/appearance-apple-pay-button-border-width-expected-mismatch.html: Added.
- TestExpectations:
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- 9:45 PM Changeset in webkit [293819] by
-
- 4 edits2 adds in trunk
Crash in WindowProxy::setDOMWindow
https://bugs.webkit.org/show_bug.cgi?id=232763
Patch by Alex Christensen <achristensen@webkit.org> on 2022-05-04
Reviewed by Chris Dumez.
Source/WebCore:
Add a few null checks here and there.
Test: fast/dom/set-dom-window-without-page.html
- bindings/js/WindowProxy.cpp:
(WebCore::WindowProxy::setDOMWindow):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
LayoutTests:
- fast/dom/set-dom-window-without-page-expected.txt: Added.
- fast/dom/set-dom-window-without-page.html: Added.
- 9:23 PM Changeset in webkit [293818] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (r293716): macCatalyst WebKit build fails; overlapping content at /System/Library/FeatureFlags/Domain/WebKit.plist
https://bugs.webkit.org/show_bug.cgi?id=240099
<rdar://92751323>
Reviewed by Chris Dumez.
- WebKit.xcodeproj/project.pbxproj:
Avoid copying the feature flags plist for macCatalyst, since it installs into the same place as macOS.
- 8:42 PM Changeset in webkit [293817] by
-
- 2 edits in trunk/Source
Annotate more String member functions with WARN_UNUSED_RETURN
https://bugs.webkit.org/show_bug.cgi?id=240078
Reviewed by Darin Adler.
- Source/WTF/wtf/text/WTFString.h:
Canonical link: https://commits.webkit.org/250290@main
- 8:22 PM Changeset in webkit [293816] by
-
- 136 edits in trunk/Source
Mark the AtomString(const String&) constructor as explicit
https://bugs.webkit.org/show_bug.cgi?id=239950
Reviewed by Darin Adler.
Mark the AtomString(const String&) constructor as explicit to help identify
inefficient patterns in our code base.
- Source/WebKit/GPUProcess/media/RemoteMediaDescription.h:
(WebKit::MediaDescriptionInfo::decode):
- Source/WebKit/Platform/IPC/ArgumentCoders.cpp:
(IPC::ArgumentCoder<AtomString>::decode):
- Source/WebKit/Shared/SessionState.h:
- Source/WebKit/Shared/WebFoundTextRange.h:
- Source/WebKit/Shared/WebUserContentControllerDataTypes.cpp:
(WebKit::WebScriptMessageHandlerData::decode):
- Source/WebKit/Shared/WebUserContentControllerDataTypes.h:
- Source/WebKit/UIProcess/Downloads/DownloadProxy.messages.in:
- Source/WebKit/UIProcess/UserContent/WebScriptMessageHandler.cpp:
(WebKit::WebScriptMessageHandler::create):
(WebKit::WebScriptMessageHandler::WebScriptMessageHandler):
- Source/WebKit/UIProcess/UserContent/WebScriptMessageHandler.h:
(WebKit::WebScriptMessageHandler::name const):
- Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::resolveChildFrameWithName):
- Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameSetAccessibleName):
- Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::initialize):
(WebKit::PDFPlugin::clickedLink):
- Source/WebKit/WebProcess/Plugins/PluginController.h:
- Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::URLRequest::target const):
(WebKit::PluginView::loadURL):
- Source/WebKit/WebProcess/Plugins/PluginView.h:
- Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp:
(WebKit::WebUserMessageHandlerDescriptorProxy::create):
(WebKit::WebUserMessageHandlerDescriptorProxy::WebUserMessageHandlerDescriptorProxy):
(WebKit::WebUserContentController::addUserScriptMessageHandlerInternal):
- Source/WebKit/WebProcess/UserContent/WebUserContentController.h:
- Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createFrame):
- Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp:
(WebKit::WebFoundTextRangeController::findTextRangesForStringMatches):
(WebKit::WebFoundTextRangeController::documentForFoundTextRange const):
- Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::initWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::setAccessibleName):
- Source/WebKit/WebProcess/WebPage/WebFrame.h:
- Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):
(WebKit::WebPage::insertAttachment):
(WebKit::WebPage::updateAttachmentAttributes):
- Source/WebKit/WebProcess/cocoa/RemoteRealtimeAudioSource.cpp:
(WebKit::RemoteRealtimeAudioSource::create):
(WebKit::RemoteRealtimeAudioSource::RemoteRealtimeAudioSource):
- Source/WebKit/WebProcess/cocoa/RemoteRealtimeAudioSource.h:
- Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:
(WebKit::RemoteRealtimeMediaSource::RemoteRealtimeMediaSource):
(WebKit::RemoteRealtimeMediaSource::createRemoteMediaSource):
- Source/WebKit/WebProcess/cocoa/RemoteRealtimeMediaSource.h:
- Source/WebKit/WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:
(WebKit::RemoteRealtimeVideoSource::RemoteRealtimeVideoSource):
(WebKit::RemoteRealtimeVideoSource::clone):
- Source/WebKit/WebProcess/cocoa/RemoteRealtimeVideoSource.h:
- Source/WebKitLegacy/mac/Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage getPluginInfoFromPLists]):
- Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h:
- Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createFrame):
- Source/WebKitLegacy/mac/WebView/WebFrame.mm:
(+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
(+[WebFrame _createMainFrameWithPage:frameName:frameView:]):
(+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
(-[WebFrame setAccessibleName:]):
- Source/WebKitLegacy/mac/WebView/WebFrameInternal.h:
- Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createFrame):
- Source/WebKitLegacy/win/WebCoreSupport/WebFrameLoaderClient.h:
- Source/WTF/wtf/text/AtomString.h:
- Source/WebCore/loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::createFrame):
- Source/WebCore/loader/EmptyFrameLoaderClient.h:
- Source/WebCore/loader/FrameLoaderClient.h:
- Source/WebCore/loader/SubframeLoader.cpp:
(WebCore::FrameLoader::SubframeLoader::loadSubframe):
- Source/WebCore/loader/SubframeLoader.h:
Canonical link: https://commits.webkit.org/250289@main
- 7:47 PM Changeset in webkit [293815] by
-
- 3 edits in trunk/Source/WebKit
Fix crash in RemoteRenderingBackendProxy::prepareBuffersForDisplay()
https://bugs.webkit.org/show_bug.cgi?id=240089
<rdar://91444900>
Reviewed by Tim Horton.
We keep WebContent processes alive after a GPU Process crash, so having a RELEASE_ASSERT
when IPC with the GPU Process fails is the wrong approach. Instead, just behave as if all
the returned buffers are null, and need full display.
In testing, I saw a single instance of a crash in RemoteLayerBackingStore::drawInContext(),
probably because m_backBuffer.imageBuffer was null.
SwapBuffersDisplayRequirement::NeedsFullDisplay should mean that we don't hit this, but
null-check the back buffer just in case.
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::drawInContext):
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::prepareBuffersForDisplay):
- 7:37 PM Changeset in webkit [293814] by
-
- 7 edits in trunk
Improve logging of display list items in IPC messages
https://bugs.webkit.org/show_bug.cgi?id=240053
Reviewed by Cameron McCormack.
Source/WebCore:
In order for IPC arguments to show up in IPCMessages logging, the stream operators
for display list items have to be visible to WebKit2 code. So export them all from
WebCore, but only if !LOG_DISABLED, to avoid code bloat.
- platform/graphics/Font.cpp:
(WebCore::operator<<):
- platform/graphics/Font.h:
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::FillPath::apply const):
(WebCore::DisplayList::operator<<):
- platform/graphics/displaylists/DisplayListItems.h:
LayoutTests:
Now that display list logging is debug only, these tests will only work in debug builds.
- platform/mac/TestExpectations:
- 7:21 PM Changeset in webkit [293813] by
-
- 4 edits in trunk
[JSC] Intl.NumberFormat lacks some validation for rounding-increment
https://bugs.webkit.org/show_bug.cgi?id=240102
Reviewed by Ross Kirsling.
This patch adds some validations added in Intl.NumberFormat v3[1].
Important thing is one is TypeError and one is RangeError.
Both are tested in test262.
[1]: https://tc39.es/proposal-intl-numberformat-v3/out/numberformat/proposed.html#sec-initializenumberformat
- JSTests/test262/expectations.yaml:
- Source/JavaScriptCore/runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::initializeNumberFormat):
Canonical link: https://commits.webkit.org/250286@main
- 6:53 PM Changeset in webkit [293812] by
-
- 5 edits2 adds in trunk
Indeterminate, checked checkboxes do not render correctly on iOS, GTK, and Windows
https://bugs.webkit.org/show_bug.cgi?id=240015
rdar://92645056
Reviewed by Cameron McCormack.
Source/WebCore:
Checkboxes can have the indeterminate and checked attributes set to
true at the same time. In this scenario, an indeterminate appearance
should be rendered. Reorder logic to ensure that the indeterminate
attribute has precedence when deciding what to draw. This approach
aligns with the macOS logic in ThemeMac.
Test: fast/forms/checkbox-checked-indeterminate.html
- platform/adwaita/ThemeAdwaita.cpp:
(WebCore::ThemeAdwaita::paintCheckbox):
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintCheckbox):
- rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::determineState):
LayoutTests:
Added a reference test to to verify that indeterminate, checked
checkboxes have the same appearance as indeterminate checkboxes.
- fast/forms/checkbox-checked-indeterminate-expected.html: Added.
- fast/forms/checkbox-checked-indeterminate.html: Added.
- 6:34 PM Changeset in webkit [293811] by
-
- 4 edits in trunk
Temporal.Duration constructor should throw on non-integers
https://bugs.webkit.org/show_bug.cgi?id=240094
Reviewed by Yusuke Suzuki.
Belated implementation for https://github.com/tc39/proposal-temporal/pull/1872 --
this patch makesnew Temporal.Duration(1.1)throw just asTemporal.Duration.from({ years: 1.1 })does.
- test262/expectations.yaml:
Mark two test cases as passing.
- runtime/TemporalDurationConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
Canonical link: https://commits.webkit.org/250284@main
- 6:14 PM Changeset in webkit [293810] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] fast/text/international/system-language/navigator-language/navigator-language-fr.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240104
Unreviewed test gardening.
Canonical link: https://commits.webkit.org/250283@main
- 6:01 PM Changeset in webkit [293809] by
-
- 2 edits in trunk/Source/WebCore
[macOS] ScreenCaptureKitCaptureSource should stop content sharing session when capture ends
https://bugs.webkit.org/show_bug.cgi?id=240086
rdar://91008087
Reviewed by Jer Noble.
Tested manually.
- platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(WebCore::ScreenCaptureKitCaptureSource::~ScreenCaptureKitCaptureSource): Call
-[SCContentSharingSession end].
(WebCore::ScreenCaptureKitCaptureSource::sessionDidEnd): Ditto.
- 5:51 PM Changeset in webkit [293808] by
-
- 4 edits1 add in trunk
[JSC] Temporal.Instant since/until should not accept year / month / day / week units
https://bugs.webkit.org/show_bug.cgi?id=240097
Reviewed by Ross Kirsling.
Temporal.Instant.{since,until} should not accept year / month / day / week units as smallestUnit / largestUnit
according to the spec [1,2]. But we missed that and crashing with the attached test. This patch fixes it.
[1]: https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.until
[2]: https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.since
- JSTests/stress/temporal-instant-since-and-until-with-year-month-week-day.js: Added.
(shouldThrow):
(let.smallestUnit.of.units.shouldThrow):
(let.largestUnit.of.units.shouldThrow):
- Source/JavaScriptCore/runtime/TemporalInstant.cpp:
Canonical link: https://commits.webkit.org/250281@main
- 5:44 PM Changeset in webkit [293807] by
-
- 1 edit in trunk/Source/WTF/wtf/text/StringView.cpp
Optimize / simplify slow case in StringView::convertASCIILowercaseAtom() https://bugs.webkit.org/show_bug.cgi?id=240082
Reviewed by Darin Adler.
Optimize / simplify slow case in StringView::convertASCIILowercaseAtom() where the input string
is not already lowercase. We now callmakeAtomString(lowercase(input))which simplifies the
code a lot and is actually more efficient because makeAtomString() has an optimization that
avoids a StringImpl allocation when the string is relatively small (< 64 characters) and is
already part of the AtomStringTable already.
I validated the implementation by running it in a loop with the String "BODY" and got a
~35% speedup.
- Source/WTF/wtf/text/StringView.cpp:
(WTF::convertASCIILowercaseAtom):
Canonical link: https://commits.webkit.org/250280@main
- 5:20 PM Changeset in webkit [293806] by
-
- 1 edit in trunk/metadata/contributors.json
Add myself (Youssef Soliman) to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=240084
Reviewed by Jer Noble.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250279@main
- 5:11 PM Changeset in webkit [293805] by
-
- 1 edit in branches/safari-613-branch/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
Unreviewed build fix. rdar://problem/91446377
./layout/formattingContexts/inline/InlineLineBuilder.cpp:933:33: error: use of undeclared identifier 'isFirstLine'
- 5:02 PM Changeset in webkit [293804] by
-
- 12 edits1 add in trunk/Source
Crash under WebCore: WebCore::CachedResourceClientWalker<WebCore::CachedImageClient>::next()
https://bugs.webkit.org/show_bug.cgi?id=240072
<rdar://92717726>
Reviewed by Geoff Garen.
Have CachedResource and CachedResourceClientWalker hold the clients via WeakPtrs instead of
raw pointers and null check them before usage. This is a lot safer.
- Source/WTF/WTF.xcodeproj/project.pbxproj:
- Source/WTF/wtf/WeakHashCountedSet.h: Added.
(WTF::WeakHashCountedSet::begin):
(WTF::WeakHashCountedSet::end):
(WTF::WeakHashCountedSet::begin const):
(WTF::WeakHashCountedSet::end const):
(WTF::WeakHashCountedSet::find):
(WTF::WeakHashCountedSet::find const):
(WTF::WeakHashCountedSet::contains const):
(WTF::WeakHashCountedSet::computeSize const):
(WTF::WeakHashCountedSet::clear):
(WTF::Counter>::add):
(WTF::Counter>::remove):
- Source/WebCore/html/HTMLLinkElement.h:
- Source/WebCore/loader/DocumentThreadableLoader.h:
- Source/WebCore/loader/ImageLoader.h:
- Source/WebCore/loader/LinkLoader.h:
- Source/WebCore/loader/cache/CachedImage.cpp:
(WebCore::CachedImage::addClientWaitingForAsyncDecoding):
- Source/WebCore/loader/cache/CachedResource.cpp:
(WebCore::CachedResource::didAddClient):
(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::switchClientsToRevalidatedResource):
- Source/WebCore/loader/cache/CachedResource.h:
(WebCore::CachedResource::hasClients const):
(WebCore::CachedResource::hasClient):
(WebCore::CachedResource::numberOfClients const):
- Source/WebCore/loader/cache/CachedResourceClient.h:
- Source/WebCore/loader/cache/CachedResourceClientWalker.h:
(WebCore::CachedResourceClientWalker::CachedResourceClientWalker):
(WebCore::CachedResourceClientWalker::next):
- Source/WebCore/rendering/RenderObject.h:
Canonical link: https://commits.webkit.org/250278@main
- 4:51 PM Changeset in webkit [293803] by
-
- 3 edits in trunk
WebKit should only reload WebViews automatically on crash if the view is visible
https://bugs.webkit.org/show_bug.cgi?id=240079
<rdar://92442052>
Reviewed by Geoffrey Garen and Darin Adler.
If the client app doesn't override WKNavigationDelegate.webViewWebContentProcessDidTerminate,
WebKit would previously reload the web view automatically. However, for some apps with a lot
of non-visible WebViews, this could cause a lot of churn when coming back to the foreground,
after many of these WebContent processes were jetsammed in the background.
To address this, WebKit now delays the automatic web view reload until the view becomes
visible (still reloads right away when the view is visible when the crash occurs).
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
(TEST):
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::launchProcess):
(WebKit::WebPageProxy::activityStateDidChange):
(WebKit::WebPageProxy::viewIsBecomingVisible):
(WebKit::WebPageProxy::dispatchProcessDidTerminate):
- Source/WebKit/UIProcess/WebPageProxy.h:
Canonical link: https://commits.webkit.org/250277@main
- 4:27 PM Changeset in webkit [293802] by
-
- 2 edits in trunk/Tools
REGRESSION(r293703):[ BigSur+ iOS ] TestWTF.WTF_URLExtras.URLExtras_ParsingError (API-Test) is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=240049
<rdar://problem/92704160>
Unreviewed follow-up to r293761 because I dropped an item the std::array but failed to update its size.
- TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):
- 4:25 PM Changeset in webkit [293801] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
[Gardening]REGRESSION(r293038):[ iOS ] fast/forms/auto-fill-button/input-auto-fill-button.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240065
Unreviewed test gardening.
Canonical link: https://commits.webkit.org/250275@main
- 4:17 PM Changeset in webkit [293800] by
-
- 2 edits in trunk/LayoutTests
Unreviewed revert
This reverts commit 250254@main because test is no longer failing after rebaseline
https://bugs.webkit.org/show_bug.cgi?id=240065
Canonical link: https://commits.webkit.org/250273@main
- 4:17 PM Changeset in webkit [293799] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Use decontaminate in StructureID::decode
https://bugs.webkit.org/show_bug.cgi?id=240088
Reviewed by Saam Barati and Mark Lam.
We have a bug that ENABLE(STRUCTURE_ID_WITH_SHIFT) and CPU(ADDRESS32) version of StructureID::decode
does not have decontaminate() call. It is wrong since these ID can be decoded concurrently. This patch fixes it.
- Source/JavaScriptCore/runtime/StructureID.h:
(JSC::StructureID::decode const):
Canonical link: https://commits.webkit.org/250273@main
- 4:14 PM Changeset in webkit [293798] by
-
- 2 edits in trunk/Tools
[ Gardening ] REGRESSION(r293671): [ iOS ] 2 TestWebKitAPI.MediaLoading.RangeRequestSynthesis (API-Tests) are constant failures
https://bugs.webkit.org/show_bug.cgi?id=240033
Unreviewed test gardening. Disabling API-tests on iOS.
- TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/250272@main
- 4:10 PM Changeset in webkit [293797] by
-
- 306 edits6 copies2 moves1018 adds60 deletes in trunk/JSTests
May 2022 test262 update
https://bugs.webkit.org/show_bug.cgi?id=240076
Reviewed by Yusuke Suzuki.
- test262/harness/propertyHelper.js:
- test262/harness/regExpUtils.js:
(testPropertyEscapes):
- test262/harness/temporalHelpers.js:
(TemporalHelpers.assertPlainYearMonth):
(TemporalHelpers.calendarFromFieldsUndefinedOptions.CalendarFromFieldsUndefinedOptions):
(TemporalHelpers.calendarFromFieldsUndefinedOptions.CalendarFromFieldsUndefinedOptions.prototype.toString):
(TemporalHelpers.calendarFromFieldsUndefinedOptions.CalendarFromFieldsUndefinedOptions.prototype.dateFromFields):
(TemporalHelpers.calendarFromFieldsUndefinedOptions.CalendarFromFieldsUndefinedOptions.prototype.yearMonthFromFields):
(TemporalHelpers.calendarFromFieldsUndefinedOptions.CalendarFromFieldsUndefinedOptions.prototype.monthDayFromFields):
(TemporalHelpers.OneShiftTimeZone.prototype.getPossibleInstantsFor):
(TemporalHelpers.checkFractionalSecondDigitsOptionWrongType): Deleted.
- test262/latest-changes-summary.txt:
- test262/test/built-ins/Array/prototype/Symbol.unscopables/array-find-from-last.js: Added.
- test262/test/built-ins/Array/prototype/Symbol.unscopables/array-grouping.js: Added.
- test262/test/built-ins/Array/prototype/Symbol.unscopables/value.js:
- test262/test/built-ins/Array/prototype/concat/create-species-non-ctor.js:
- test262/test/built-ins/Array/prototype/filter/create-species-non-ctor.js:
- test262/test/built-ins/Array/prototype/map/create-species-non-ctor.js:
- test262/test/built-ins/Array/prototype/slice/create-species-non-ctor.js:
- test262/test/built-ins/Array/prototype/splice/create-species-non-ctor.js:
- test262/test/built-ins/Date/parse/year-zero.js: Added.
- test262/test/built-ins/Date/year-zero.js: Added.
- test262/test/built-ins/Error/constructor.js:
- test262/test/built-ins/Function/prototype/bind/instance-length-tointeger.js:
- test262/test/built-ins/Number/S15.7.1.1_A1.js:
- test262/test/built-ins/RegExp/prototype/toString/S15.10.6.4_A6.js:
- test262/test/built-ins/RegExp/prototype/toString/S15.10.6.4_A7.js:
- test262/test/built-ins/ShadowRealm/WrappedFunction/throws-typeerror-on-revoked-proxy.js: Added.
(const.fn.r.evaluate.globalThis.revocable.Proxy.revocable):
- test262/test/built-ins/ShadowRealm/prototype/evaluate/globalthis-ordinary-object.js: Added.
(catch):
- test262/test/built-ins/ShadowRealm/prototype/evaluate/globalthis-orginary-object.js: Removed.
- test262/test/built-ins/ShadowRealm/prototype/evaluate/throws-typeerror-wrap-throwing.js: Added.
(r.evaluate.const.revocable.Proxy.revocable):
(r.evaluate.const.fn):
- test262/test/built-ins/String/prototype/localeCompare/15.5.4.9_CE.js:
(i.pair.0.localeCompare):
(string_appeared_here.localeCompare): Deleted.
(else.i.pair.0.localeCompare): Deleted.
- test262/test/built-ins/Temporal/Calendar/from/calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/from/calendar-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/from/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.Calendar.from):
(description.of.typeErrorTests.Temporal.Calendar.from):
- test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.Duration):
(description.of.typeErrorTests.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-string-with-utc-designator.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.Duration):
(description.of.typeErrorTests.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/Calendar/prototype/dateAdd/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/dateFromFields/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateFromFields/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/Calendar/prototype/dateUntil/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateUntil/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateUntil/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateUntil/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.PlainDate):
(description.of.rangeErrorTests.instance.dateUntil.new.Temporal.PlainDate):
(description.of.typeErrorTests.new.Temporal.PlainDate):
(description.of.typeErrorTests.instance.dateUntil.new.Temporal.PlainDate):
- test262/test/built-ins/Temporal/Calendar/prototype/dateUntil/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/dateUntil/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateUntil/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.PlainDate):
(description.of.rangeErrorTests.instance.dateUntil.new.Temporal.PlainDate):
(description.of.typeErrorTests.new.Temporal.PlainDate):
(description.of.typeErrorTests.instance.dateUntil.new.Temporal.PlainDate):
- test262/test/built-ins/Temporal/Calendar/prototype/dateUntil/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateUntil/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateUntil/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dateUntil/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/day/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/day/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/day/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/day/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.day):
(description.of.typeErrorTests.instance.day):
- test262/test/built-ins/Temporal/Calendar/prototype/day/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/day/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/day/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.day):
(description.of.typeErrorTests.instance.day):
- test262/test/built-ins/Temporal/Calendar/prototype/day/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/day/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/day/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfWeek/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfWeek/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfWeek/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfWeek/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.dayOfWeek):
(description.of.typeErrorTests.instance.dayOfWeek):
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfWeek/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfWeek/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfWeek/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.dayOfWeek):
(description.of.typeErrorTests.instance.dayOfWeek):
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfWeek/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfWeek/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfWeek/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfYear/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfYear/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfYear/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfYear/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.dayOfYear):
(description.of.typeErrorTests.instance.dayOfYear):
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfYear/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfYear/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfYear/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.dayOfYear):
(description.of.typeErrorTests.instance.dayOfYear):
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfYear/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfYear/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/dayOfYear/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/daysInMonth/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInMonth/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInMonth/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInMonth/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.daysInMonth):
(description.of.typeErrorTests.instance.daysInMonth):
- test262/test/built-ins/Temporal/Calendar/prototype/daysInMonth/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/daysInMonth/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInMonth/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.daysInMonth):
(description.of.typeErrorTests.instance.daysInMonth):
- test262/test/built-ins/Temporal/Calendar/prototype/daysInMonth/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInMonth/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInMonth/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/daysInWeek/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInWeek/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInWeek/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInWeek/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.daysInWeek):
(description.of.typeErrorTests.instance.daysInWeek):
- test262/test/built-ins/Temporal/Calendar/prototype/daysInWeek/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/daysInWeek/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInWeek/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.daysInWeek):
(description.of.typeErrorTests.instance.daysInWeek):
- test262/test/built-ins/Temporal/Calendar/prototype/daysInWeek/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInWeek/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInWeek/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/daysInYear/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInYear/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInYear/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInYear/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.daysInYear):
(description.of.typeErrorTests.instance.daysInYear):
- test262/test/built-ins/Temporal/Calendar/prototype/daysInYear/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/daysInYear/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInYear/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.daysInYear):
(description.of.typeErrorTests.instance.daysInYear):
- test262/test/built-ins/Temporal/Calendar/prototype/daysInYear/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInYear/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/daysInYear/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.inLeapYear):
(description.of.typeErrorTests.instance.inLeapYear):
- test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/argument-string.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.inLeapYear):
(description.of.typeErrorTests.instance.inLeapYear):
- test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/basic.js:
- test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/branding.js:
- test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/inLeapYear/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/mergeFields/basic.js: Added.
(assert.deepEqual.cal.mergeFields):
- test262/test/built-ins/Temporal/Calendar/prototype/mergeFields/iso8601-calendar-month-monthCode.js: Added.
(assert.deepEqual.cal.mergeFields):
- test262/test/built-ins/Temporal/Calendar/prototype/mergeFields/non-string-properties.js: Added.
(assert.deepEqual.cal.mergeFields):
- test262/test/built-ins/Temporal/Calendar/prototype/month/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/month/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/month/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/month/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.month):
(description.of.typeErrorTests.instance.month):
- test262/test/built-ins/Temporal/Calendar/prototype/month/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/month/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/month/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.month):
(description.of.typeErrorTests.instance.month):
- test262/test/built-ins/Temporal/Calendar/prototype/month/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/month/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/month/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/monthCode/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthCode/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthCode/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthCode/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.monthCode):
(description.of.typeErrorTests.instance.monthCode):
- test262/test/built-ins/Temporal/Calendar/prototype/monthCode/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/monthCode/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthCode/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.monthCode):
(description.of.typeErrorTests.instance.monthCode):
- test262/test/built-ins/Temporal/Calendar/prototype/monthCode/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthCode/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthCode/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/monthDayFromFields/basic.js: Added.
(string_appeared_here.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/monthDayFromFields/fields-missing-properties.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthDayFromFields/fields-not-object.js:
- test262/test/built-ins/Temporal/Calendar/prototype/monthDayFromFields/monthcode-invalid.js: Added.
(string_appeared_here.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/monthDayFromFields/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthDayFromFields/overflow-constrain.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthDayFromFields/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/Calendar/prototype/monthDayFromFields/overflow-reject.js: Added.
(9995.forEach):
(999.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/monthDayFromFields/reference-year-1972.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthsInYear/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthsInYear/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthsInYear/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthsInYear/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.monthsInYear):
(description.of.typeErrorTests.instance.monthsInYear):
- test262/test/built-ins/Temporal/Calendar/prototype/monthsInYear/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/monthsInYear/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthsInYear/argument-string.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthsInYear/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.monthsInYear):
(description.of.typeErrorTests.instance.monthsInYear):
- test262/test/built-ins/Temporal/Calendar/prototype/monthsInYear/basic.js:
- test262/test/built-ins/Temporal/Calendar/prototype/monthsInYear/branding.js:
- test262/test/built-ins/Temporal/Calendar/prototype/monthsInYear/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthsInYear/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/monthsInYear/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/argument-plaindate.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/argument-plaindatetime.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.weekOfYear):
(description.of.typeErrorTests.instance.weekOfYear):
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/argument-string.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.weekOfYear):
(description.of.typeErrorTests.instance.weekOfYear):
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/branding.js:
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/weekOfYear/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/year/argument-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/year/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/year/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/year/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.year):
(description.of.typeErrorTests.instance.year):
- test262/test/built-ins/Temporal/Calendar/prototype/year/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/year/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/year/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.year):
(description.of.typeErrorTests.instance.year):
- test262/test/built-ins/Temporal/Calendar/prototype/year/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/year/leap-second.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/year/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/basic.js: Added.
(string_appeared_here.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/branding.js:
- test262/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/fields-missing-properties.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/fields-not-object.js:
- test262/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/monthcode-invalid.js: Added.
(string_appeared_here.forEach):
- test262/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/options-not-object.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/overflow-constrain.js: Added.
- test262/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/Calendar/prototype/yearMonthFromFields/overflow-reject.js: Added.
(9995.forEach):
- test262/test/built-ins/Temporal/Duration/basic.js: Added.
- test262/test/built-ins/Temporal/Duration/call-builtin.js: Added.
(Number.isFinite):
(Math.sign):
- test262/test/built-ins/Temporal/Duration/compare/argument-cast.js: Added.
(assert.sameValue.Temporal.Duration.compare.new.Temporal.Duration):
(Temporal.Duration.compare.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/compare/basic.js: Added.
- test262/test/built-ins/Temporal/Duration/compare/calendar-dateadd-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Duration/compare/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/Duration/compare/relativeto-hour.js: Added.
- test262/test/built-ins/Temporal/Duration/compare/relativeto-month.js: Added.
- test262/test/built-ins/Temporal/Duration/compare/relativeto-propertybag-invalid.js: Added.
- test262/test/built-ins/Temporal/Duration/compare/relativeto-year.js: Added.
- test262/test/built-ins/Temporal/Duration/compare/timezone-string-leap-second.js: Added.
(new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/compare/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Duration/compare/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.Duration):
(description.of.typeErrorTests.new.Temporal.Duration):
(new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/compare/twenty-five-hour-day.js: Added.
- test262/test/built-ins/Temporal/Duration/days-undefined.js:
- test262/test/built-ins/Temporal/Duration/from/argument-duration.js: Added.
- test262/test/built-ins/Temporal/Duration/from/argument-existing-object.js:
- test262/test/built-ins/Temporal/Duration/from/argument-object-invalid.js: Added.
- test262/test/built-ins/Temporal/Duration/from/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/Duration/from/argument-string.js: Added.
- test262/test/built-ins/Temporal/Duration/hours-undefined.js:
- test262/test/built-ins/Temporal/Duration/microseconds-undefined.js:
- test262/test/built-ins/Temporal/Duration/milliseconds-undefined.js:
- test262/test/built-ins/Temporal/Duration/minutes-undefined.js:
- test262/test/built-ins/Temporal/Duration/mixed.js: Added.
- test262/test/built-ins/Temporal/Duration/months-undefined.js:
- test262/test/built-ins/Temporal/Duration/nanoseconds-undefined.js:
- test262/test/built-ins/Temporal/Duration/prototype/abs/basic.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/abs/new-object.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/add/argument-object-invalid.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/add/argument-string.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/add/basic.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/add/options-undefined.js:
- test262/test/built-ins/Temporal/Duration/prototype/add/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/add/relativeto-leap-second.js: Added.
(const.result1.instance.add.new.Temporal.Duration):
(const.result2.instance.add.new.Temporal.Duration):
(const.result3.instance.add.new.Temporal.Duration):
(const.result4.instance.add.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/add/relativeto-month.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/add/relativeto-number.js: Added.
(const.result.instance.add.new.Temporal.Duration):
(const.relativeTo.of.numbers.instance.add.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/add/relativeto-order.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/add/relativeto-propertybag-calendar-number.js: Added.
(const.result1.instance.add.new.Temporal.Duration):
(const.result2.instance.add.new.Temporal.Duration):
(const.calendar.of.numbers.instance.add.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/add/relativeto-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.add.new.Temporal.Duration):
(description.of.typeErrorTests.instance.add.new.Temporal.Duration):
(instance.add.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/add/relativeto-required.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/add/relativeto-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.add.new.Temporal.Duration):
(description.of.typeErrorTests.instance.add.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/add/relativeto-year.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/add/timezone-string-leap-second.js: Added.
(instance.add.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/add/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Duration/prototype/add/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.add.new.Temporal.Duration):
(description.of.typeErrorTests.instance.add.new.Temporal.Duration):
(instance.add.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/blank/basic.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/negated/basic.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/round/calendar-dateadd-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/round/largestunit-smallestunit-default.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/round/largestunit-smallestunit-mismatch.js: Added.
(largestIdx.smallestIdx.d.round):
- test262/test/built-ins/Temporal/Duration/prototype/round/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/round/relativeto-leap-second.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/round/relativeto-number.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/round/relativeto-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/round/relativeto-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.round):
(description.of.typeErrorTests.instance.round):
- test262/test/built-ins/Temporal/Duration/prototype/round/relativeto-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.round):
(description.of.typeErrorTests.instance.round):
- test262/test/built-ins/Temporal/Duration/prototype/round/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/Duration/prototype/round/roundto-invalid-string.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/round/smallestunit-disallowed-units-string.js: Removed.
- test262/test/built-ins/Temporal/Duration/prototype/round/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/Duration/prototype/round/smallestunit.js: Added.
(expected.of.Object.entries):
- test262/test/built-ins/Temporal/Duration/prototype/round/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/round/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Duration/prototype/round/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.round):
(description.of.typeErrorTests.instance.round):
- test262/test/built-ins/Temporal/Duration/prototype/subtract/argument-object-invalid.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/subtract/argument-string.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/subtract/basic.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/subtract/options-undefined.js:
- test262/test/built-ins/Temporal/Duration/prototype/subtract/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/subtract/relativeto-leap-second.js: Added.
(const.result1.instance.subtract.new.Temporal.Duration):
(const.result2.instance.subtract.new.Temporal.Duration):
(const.result3.instance.subtract.new.Temporal.Duration):
(const.result4.instance.subtract.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/subtract/relativeto-month.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/subtract/relativeto-number.js: Added.
(const.result.instance.subtract.new.Temporal.Duration):
(const.relativeTo.of.numbers.instance.subtract.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/subtract/relativeto-order.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/subtract/relativeto-propertybag-calendar-number.js: Added.
(const.result1.instance.subtract.new.Temporal.Duration):
(const.result2.instance.subtract.new.Temporal.Duration):
(const.calendar.of.numbers.instance.subtract.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/subtract/relativeto-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.subtract.new.Temporal.Duration):
(description.of.typeErrorTests.instance.subtract.new.Temporal.Duration):
(instance.subtract.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/subtract/relativeto-required.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/subtract/relativeto-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.subtract.new.Temporal.Duration):
(description.of.typeErrorTests.instance.subtract.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/subtract/relativeto-year.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/subtract/timezone-string-leap-second.js: Added.
(instance.subtract.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/subtract/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Duration/prototype/subtract/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.subtract.new.Temporal.Duration):
(description.of.typeErrorTests.instance.subtract.new.Temporal.Duration):
(instance.subtract.new.Temporal.Duration):
- test262/test/built-ins/Temporal/Duration/prototype/toJSON/basic.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/toJSON/options.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/toString/balance.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/toString/fractionalseconddigits-auto.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/toString/fractionalseconddigits-invalid-string.js:
- test262/test/built-ins/Temporal/Duration/prototype/toString/fractionalseconddigits-number.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/toString/fractionalseconddigits-out-of-range.js:
- test262/test/built-ins/Temporal/Duration/prototype/toString/fractionalseconddigits-undefined.js:
(expected.of.tests.const.lambda.duration.toString):
- test262/test/built-ins/Temporal/Duration/prototype/toString/fractionalseconddigits-wrong-type.js:
- test262/test/built-ins/Temporal/Duration/prototype/toString/negative-components.js:
- test262/test/built-ins/Temporal/Duration/prototype/toString/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/toString/roundingmode-ceil.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/toString/roundingmode-floor.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/toString/roundingmode-halfExpand.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/toString/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/Duration/prototype/toString/roundingmode-trunc.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/toString/smallestunit-fractionalseconddigits.js: Added.
(expected.of.tests.const.string.duration.toString.get fractionalSecondDigits):
(duration.toString.get fractionalSecondDigits):
- test262/test/built-ins/Temporal/Duration/prototype/toString/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/Duration/prototype/toString/smallestunit-valid-units.js:
(test):
(notValid.forEach):
- test262/test/built-ins/Temporal/Duration/prototype/total/calendar-dateadd-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/total/options-wrong-type.js:
(values.forEach): Deleted.
- test262/test/built-ins/Temporal/Duration/prototype/total/relativeto-leap-second.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/total/relativeto-number.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.total):
(description.of.typeErrorTests.instance.total):
- test262/test/built-ins/Temporal/Duration/prototype/total/relativeto-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.total):
(description.of.typeErrorTests.instance.total):
- test262/test/built-ins/Temporal/Duration/prototype/total/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/total/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Duration/prototype/total/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.total):
(description.of.typeErrorTests.instance.total):
- test262/test/built-ins/Temporal/Duration/prototype/valueOf/basic.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/with/all-negative.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/with/all-positive.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/with/argument-invalid-prop.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/with/argument-mixed-sign.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/with/argument-object-wrong-shape.js: Added.
(let.d.new.Temporal.Duration):
(forEach):
- test262/test/built-ins/Temporal/Duration/prototype/with/argument-sign-prop.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/with/argument-wrong-type.js: Added.
(forEach):
- test262/test/built-ins/Temporal/Duration/prototype/with/branding.js:
- test262/test/built-ins/Temporal/Duration/prototype/with/partial-positive.js: Added.
- test262/test/built-ins/Temporal/Duration/prototype/with/sign-conflict-throws-rangeerror.js: Added.
(fields.forEach):
- test262/test/built-ins/Temporal/Duration/prototype/with/sign-replace.js: Added.
- test262/test/built-ins/Temporal/Duration/seconds-undefined.js:
- test262/test/built-ins/Temporal/Duration/weeks-undefined.js:
- test262/test/built-ins/Temporal/Duration/years-undefined.js:
- test262/test/built-ins/Temporal/Instant/compare/argument-object-tostring.js: Added.
(arg.toString):
- test262/test/built-ins/Temporal/Instant/compare/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.Instant.compare):
(description.of.typeErrorTests.Temporal.Instant.compare):
- test262/test/built-ins/Temporal/Instant/compare/instant-string-sub-minute-offset.js: Added.
- test262/test/built-ins/Temporal/Instant/compare/leap-second.js: Added.
- test262/test/built-ins/Temporal/Instant/compare/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Instant/from/argument-instant.js: Added.
- test262/test/built-ins/Temporal/Instant/from/argument-object-tostring.js: Added.
(arg.toString):
- test262/test/built-ins/Temporal/Instant/from/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.Instant.from):
(description.of.typeErrorTests.Temporal.Instant.from):
- test262/test/built-ins/Temporal/Instant/from/basic.js: Added.
- test262/test/built-ins/Temporal/Instant/from/instant-string-sub-minute-offset.js: Added.
- test262/test/built-ins/Temporal/Instant/from/leap-second.js: Added.
- test262/test/built-ins/Temporal/Instant/from/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Instant/prototype/add/basic.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/add/branding.js:
- test262/test/built-ins/Temporal/Instant/prototype/add/disallowed-duration-units.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/add/result-out-of-range.js:
(fields.forEach):
- test262/test/built-ins/Temporal/Instant/prototype/equals/argument-object-tostring.js: Added.
(arg.toString):
- test262/test/built-ins/Temporal/Instant/prototype/equals/argument-wrong-type.js:
(description.of.rangeErrorTests.instance.equals):
(description.of.typeErrorTests.instance.equals):
- test262/test/built-ins/Temporal/Instant/prototype/equals/instant-string-sub-minute-offset.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/equals/leap-second.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/equals/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Instant/prototype/round/options-wrong-type.js:
- test262/test/built-ins/Temporal/Instant/prototype/round/rounding-direction.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/round/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/Instant/prototype/round/roundto-invalid-string.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/round/smallestunit-disallowed-units.js: Removed.
- test262/test/built-ins/Temporal/Instant/prototype/round/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/Instant/prototype/since/argument-object-tostring.js: Added.
(arg.toString):
- test262/test/built-ins/Temporal/Instant/prototype/since/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.since):
(description.of.typeErrorTests.instance.since):
- test262/test/built-ins/Temporal/Instant/prototype/since/instant-string-sub-minute-offset.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/since/largestunit-invalid-string.js:
- test262/test/built-ins/Temporal/Instant/prototype/since/leap-second.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/since/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/since/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/Instant/prototype/since/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/Instant/prototype/since/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Instant/prototype/subtract/basic.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/subtract/branding.js:
- test262/test/built-ins/Temporal/Instant/prototype/subtract/disallowed-duration-units.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/subtract/result-out-of-range.js:
(fields.forEach):
- test262/test/built-ins/Temporal/Instant/prototype/toJSON/year-format.js: Added.
(epochNsInYear):
- test262/test/built-ins/Temporal/Instant/prototype/toString/fractionalseconddigits-auto.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toString/fractionalseconddigits-invalid-string.js:
- test262/test/built-ins/Temporal/Instant/prototype/toString/fractionalseconddigits-non-integer.js:
- test262/test/built-ins/Temporal/Instant/prototype/toString/fractionalseconddigits-number.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toString/fractionalseconddigits-out-of-range.js:
- test262/test/built-ins/Temporal/Instant/prototype/toString/fractionalseconddigits-undefined.js:
(expected.of.tests.const.lambda.instant.toString):
- test262/test/built-ins/Temporal/Instant/prototype/toString/fractionalseconddigits-wrong-type.js:
- test262/test/built-ins/Temporal/Instant/prototype/toString/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toString/rounding-cross-midnight.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toString/rounding-direction.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toString/roundingmode-ceil.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toString/roundingmode-floor.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toString/roundingmode-halfExpand.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toString/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/Instant/prototype/toString/roundingmode-trunc.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toString/smallestunit-fractionalseconddigits.js: Added.
(expected.of.tests.const.string.instant.toString.get fractionalSecondDigits):
(instant.toString.get fractionalSecondDigits):
- test262/test/built-ins/Temporal/Instant/prototype/toString/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/Instant/prototype/toString/smallestunit-valid-units.js:
(test):
(notValid.forEach):
- test262/test/built-ins/Temporal/Instant/prototype/toString/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toString/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Instant/prototype/toString/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.toString):
(description.of.typeErrorTests.instance.toString):
- test262/test/built-ins/Temporal/Instant/prototype/toString/year-format.js: Added.
(epochNsInYear):
- test262/test/built-ins/Temporal/Instant/prototype/toZonedDateTime/calendar-number.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toZonedDateTime/calendar-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toZonedDateTime/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.toZonedDateTime):
(description.of.typeErrorTests.instance.toZonedDateTime):
- test262/test/built-ins/Temporal/Instant/prototype/toZonedDateTime/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toZonedDateTime/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Instant/prototype/toZonedDateTime/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.toZonedDateTime):
(description.of.typeErrorTests.instance.toZonedDateTime):
- test262/test/built-ins/Temporal/Instant/prototype/toZonedDateTimeISO/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/toZonedDateTimeISO/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Instant/prototype/toZonedDateTimeISO/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.toZonedDateTimeISO):
(description.of.typeErrorTests.instance.toZonedDateTimeISO):
- test262/test/built-ins/Temporal/Instant/prototype/until/argument-object-tostring.js: Added.
(arg.toString):
- test262/test/built-ins/Temporal/Instant/prototype/until/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.until):
(description.of.typeErrorTests.instance.until):
- test262/test/built-ins/Temporal/Instant/prototype/until/instant-string-sub-minute-offset.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/until/largestunit-invalid-string.js:
- test262/test/built-ins/Temporal/Instant/prototype/until/leap-second.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/until/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/Instant/prototype/until/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/Instant/prototype/until/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/Instant/prototype/until/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Now/plainDate/calendar-number.js: Added.
- test262/test/built-ins/Temporal/Now/plainDate/calendar-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Now/plainDate/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.Now.plainDate):
(description.of.typeErrorTests.Temporal.Now.plainDate):
- test262/test/built-ins/Temporal/Now/plainDate/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Now/plainDate/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Now/plainDate/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.Now.plainDate):
(description.of.typeErrorTests.Temporal.Now.plainDate):
- test262/test/built-ins/Temporal/Now/plainDateISO/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Now/plainDateISO/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Now/plainDateISO/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.Now.plainDateISO):
(description.of.typeErrorTests.Temporal.Now.plainDateISO):
- test262/test/built-ins/Temporal/Now/plainDateTime/calendar-number.js: Added.
- test262/test/built-ins/Temporal/Now/plainDateTime/calendar-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Now/plainDateTime/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.Now.plainDateTime):
(description.of.typeErrorTests.Temporal.Now.plainDateTime):
- test262/test/built-ins/Temporal/Now/plainDateTime/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Now/plainDateTime/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Now/plainDateTime/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.Now.plainDateTime):
(description.of.typeErrorTests.Temporal.Now.plainDateTime):
- test262/test/built-ins/Temporal/Now/plainDateTimeISO/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Now/plainDateTimeISO/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Now/plainDateTimeISO/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.Now.plainDateTimeISO):
(description.of.typeErrorTests.Temporal.Now.plainDateTimeISO):
- test262/test/built-ins/Temporal/Now/plainTimeISO/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Now/plainTimeISO/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Now/plainTimeISO/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.Now.plainTimeISO):
(description.of.typeErrorTests.Temporal.Now.plainTimeISO):
- test262/test/built-ins/Temporal/Now/zonedDateTime/calendar-number.js: Added.
- test262/test/built-ins/Temporal/Now/zonedDateTime/calendar-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Now/zonedDateTime/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.Now.zonedDateTime):
(description.of.typeErrorTests.Temporal.Now.zonedDateTime):
- test262/test/built-ins/Temporal/Now/zonedDateTime/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Now/zonedDateTime/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Now/zonedDateTime/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.Now.zonedDateTime):
(description.of.typeErrorTests.Temporal.Now.zonedDateTime):
- test262/test/built-ins/Temporal/Now/zonedDateTimeISO/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/Now/zonedDateTimeISO/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/Now/zonedDateTimeISO/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.Now.zonedDateTimeISO):
(description.of.typeErrorTests.Temporal.Now.zonedDateTimeISO):
- test262/test/built-ins/Temporal/PlainDate/calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDate/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.PlainDate):
(description.of.typeErrorTests.new.Temporal.PlainDate):
- test262/test/built-ins/Temporal/PlainDate/compare/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainDate/compare/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/compare/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDate/compare/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.PlainDate):
(description.of.rangeErrorTests.Temporal.PlainDate.compare.new.Temporal.PlainDate):
(description.of.typeErrorTests.new.Temporal.PlainDate):
(description.of.typeErrorTests.Temporal.PlainDate.compare.new.Temporal.PlainDate):
- test262/test/built-ins/Temporal/PlainDate/compare/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDate/compare/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/PlainDate/compare/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.PlainDate):
(description.of.rangeErrorTests.Temporal.PlainDate.compare.new.Temporal.PlainDate):
(description.of.typeErrorTests.new.Temporal.PlainDate):
(description.of.typeErrorTests.Temporal.PlainDate.compare.new.Temporal.PlainDate):
- test262/test/built-ins/Temporal/PlainDate/compare/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainDate/compare/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/compare/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDate/from/argument-number.js:
- test262/test/built-ins/Temporal/PlainDate/from/argument-plaindate.js:
- test262/test/built-ins/Temporal/PlainDate/from/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/from/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDate/from/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.PlainDate.from):
(description.of.typeErrorTests.Temporal.PlainDate.from):
- test262/test/built-ins/Temporal/PlainDate/from/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDate/from/argument-string-invalid.js:
(const.object.get overflow): Deleted.
- test262/test/built-ins/Temporal/PlainDate/from/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.PlainDate.from):
(description.of.typeErrorTests.Temporal.PlainDate.from):
- test262/test/built-ins/Temporal/PlainDate/from/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/from/observable-get-overflow-argument-string-invalid.js: Copied from JSTests/test262/test/built-ins/Temporal/PlainDate/from/argument-string-invalid.js.
(const.object.get overflow):
- test262/test/built-ins/Temporal/PlainDate/from/observable-get-overflow-argument-string.js: Renamed from JSTests/test262/test/built-ins/Temporal/PlainDate/from/argument-string-overflow.js.
- test262/test/built-ins/Temporal/PlainDate/from/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDate/from/overflow-invalid-string.js:
(validItems.forEach): Deleted.
- test262/test/built-ins/Temporal/PlainDate/from/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDate/prototype/add/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/add/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/equals/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/equals/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/equals/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/equals/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.equals):
(description.of.typeErrorTests.instance.equals):
- test262/test/built-ins/Temporal/PlainDate/prototype/equals/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/equals/argument-wrong-type.js:
(description.of.rangeErrorTests.instance.equals):
(description.of.typeErrorTests.instance.equals):
- test262/test/built-ins/Temporal/PlainDate/prototype/equals/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/equals/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/equals/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDate/prototype/since/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/since/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/since/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/since/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.since):
(description.of.typeErrorTests.instance.since):
- test262/test/built-ins/Temporal/PlainDate/prototype/since/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDate/prototype/since/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/since/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.since):
(description.of.typeErrorTests.instance.since):
- test262/test/built-ins/Temporal/PlainDate/prototype/since/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/since/largestunit-default.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/since/largestunit-higher-units.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/since/largestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/since/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/since/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/since/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/since/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/since/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDate/prototype/subtract/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/subtract/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/toJSON/year-format.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-time-designator-required-for-disambiguation.js:
(ambiguousStrings.forEach):
- test262/test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.toPlainDateTime):
(description.of.typeErrorTests.instance.toPlainDateTime):
- test262/test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/limits.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/plaintime-propertybag-no-time-units.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/year-zero.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/toPlainMonthDay/calendar-monthdayfromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/toPlainYearMonth/calendar-yearmonthfromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/toString/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/toString/year-format.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-string-time-designator-required-for-disambiguation.js:
(ambiguousStrings.forEach):
- test262/test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.toZonedDateTime):
(description.of.typeErrorTests.instance.toZonedDateTime):
- test262/test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/plaintime-propertybag-no-time-units.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.toZonedDateTime):
(description.of.typeErrorTests.instance.toZonedDateTime):
- test262/test/built-ins/Temporal/PlainDate/prototype/toZonedDateTime/year-zero.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/until/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/until/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/until/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/until/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.until):
(description.of.typeErrorTests.instance.until):
- test262/test/built-ins/Temporal/PlainDate/prototype/until/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDate/prototype/until/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/until/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.until):
(description.of.typeErrorTests.instance.until):
- test262/test/built-ins/Temporal/PlainDate/prototype/until/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/until/largestunit-default.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/until/largestunit-higher-units.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/until/largestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/until/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/until/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/until/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/until/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/until/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDate/prototype/with/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/with/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDate/prototype/withCalendar/calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/withCalendar/calendar-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDate/prototype/withCalendar/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.withCalendar):
(description.of.typeErrorTests.instance.withCalendar):
- test262/test/built-ins/Temporal/PlainDateTime/calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.PlainDateTime):
(description.of.typeErrorTests.new.Temporal.PlainDateTime):
- test262/test/built-ins/Temporal/PlainDateTime/compare/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/compare/argument-object-insufficient-data.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/compare/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/compare/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/compare/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.PlainDateTime):
(description.of.rangeErrorTests.Temporal.PlainDateTime.compare.new.Temporal.PlainDateTime):
(description.of.typeErrorTests.new.Temporal.PlainDateTime):
(description.of.typeErrorTests.Temporal.PlainDateTime.compare.new.Temporal.PlainDateTime):
- test262/test/built-ins/Temporal/PlainDateTime/compare/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/compare/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.PlainDateTime):
(description.of.rangeErrorTests.Temporal.PlainDateTime.compare.new.Temporal.PlainDateTime):
(description.of.typeErrorTests.new.Temporal.PlainDateTime):
(description.of.typeErrorTests.Temporal.PlainDateTime.compare.new.Temporal.PlainDateTime):
- test262/test/built-ins/Temporal/PlainDateTime/compare/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/compare/calendar-ignored.js: Added.
(const.calendar1.toString):
(const.calendar2.toString):
- test262/test/built-ins/Temporal/PlainDateTime/compare/cast.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/compare/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/compare/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/constructor-full.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/datetime-math.js: Added.
(units.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-object-month.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-object.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-plaindatetime.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.PlainDateTime.from):
(description.of.typeErrorTests.Temporal.PlainDateTime.from):
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-string-comma-decimal-separator.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-string-invalid.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-string-minus-sign.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-string-offset.js: Added.
(strs.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-string-optional-data.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-string-out-of-range.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-string-subsecond.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-string-time-separators.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-string-timezone.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-string.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.PlainDateTime.from):
(description.of.typeErrorTests.Temporal.PlainDateTime.from):
- test262/test/built-ins/Temporal/PlainDateTime/from/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/limits.js: Added.
(string_appeared_here.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/from/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/overflow-default-constrain.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/overflow-invalid-string.js:
(validValues.forEach): Deleted.
- test262/test/built-ins/Temporal/PlainDateTime/from/overflow-reject.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/from/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/hour-undefined.js:
- test262/test/built-ins/Temporal/PlainDateTime/limits.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/microsecond-undefined.js:
- test262/test/built-ins/Temporal/PlainDateTime/millisecond-undefined.js:
- test262/test/built-ins/Temporal/PlainDateTime/minute-undefined.js:
- test262/test/built-ins/Temporal/PlainDateTime/nanosecond-undefined.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/add/ambiguous-date.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/add/argument-duration.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/add/argument-object-insufficient-data.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/add/argument-plain-object-mixed-signs.js: Added.
(string_appeared_here.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/add/hour-overflow.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/add/limits.js: Added.
(string_appeared_here.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/add/negative-duration.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/add/options-empty.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/add/options-invalid.js: Added.
(badOptions.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/add/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/add/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/dayOfWeek/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/dayOfYear/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/daysInMonth/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/daysInWeek/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/daysInYear/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-object-insufficient-data.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.equals):
(description.of.typeErrorTests.instance.equals):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-wrong-type.js:
(description.of.rangeErrorTests.instance.equals):
(description.of.typeErrorTests.instance.equals):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/equals/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/equals/calendar-checked.js: Added.
(const.calendar4.toString):
(const.calendar5.toString):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/equals/cast.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/equals/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/equals/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/monthsInYear/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/balance.js: Added.
(string_appeared_here.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/limits.js: Added.
(string_appeared_here.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/rounding-direction.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/roundingincrement-divides.js: Added.
(12.forEach):
(string_appeared_here.forEach):
(Object.entries.nextIncrements.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/roundingincrement-does-not-divide.js: Added.
(units.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/roundingincrement-one-day.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-ceil-basic.js: Added.
(Object.entries.incrementOneCeil.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-floor-basic.js: Added.
(Object.entries.incrementOneFloor.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-halfexpand-basic.js: Added.
(Object.entries.incrementOneNearest.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-halfexpand-is-default.js: Added.
(Object.entries.units.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-trunc-basic.js: Added.
(Object.entries.incrementOneFloor.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/roundto-invalid-string.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/smallestunit-disallowed-units.js: Removed.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/throws-argument-object-insufficient-data.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/throws-argument-object.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/throws-no-argument.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/round/throws-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/argument-object.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.since):
(description.of.typeErrorTests.instance.since):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/argument-string.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.since):
(description.of.typeErrorTests.instance.since):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/different-calendars-throws.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/largestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/no-unnecessary-units.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/options-empty.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/options-invalid.js: Added.
(badOptions.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/returns-days.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/round-relative-to-receiver.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/roundingincrement-basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/roundingincrement-cleanly-divides.js: Added.
(12.forEach):
(string_appeared_here.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/roundingincrement-does-not-divide.js: Added.
(Object.entries.badIncrements.forEach):
(Object.entries.fullIncrements.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/roundingmode-ceil-basic.js: Added.
(incrementOneCeil.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/roundingmode-floor-basic.js: Added.
(incrementOneFloor.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/roundingmode-halfexpand-basic.js: Added.
(ensureUnsignedZero):
(incrementOneNearest.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/roundingmode-halfexpand-default-changes.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/roundingmode-trunc-basic.js: Added.
(ensureUnsignedZero):
(incrementOneTrunc.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/roundingmode-trunc-is-default.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/subseconds.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/weeks-months-mutually-exclusive.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/since/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/subtract/ambiguous-date.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/subtract/argument-duration.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/subtract/argument-object-insufficient-data.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/subtract/argument-plain-object-mixed-signs.js: Added.
(string_appeared_here.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/subtract/hour-overflow.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/subtract/limits.js: Added.
(string_appeared_here.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/subtract/negative-duration.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/subtract/options-empty.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/subtract/options-invalid.js: Added.
(badOptions.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/subtract/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/subtract/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toJSON/year-format.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toPlainMonthDay/calendar-monthdayfromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toPlainTime/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toPlainYearMonth/calendar-yearmonthfromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/calendarname-always.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/calendarname-auto.js: Added.
(const.customCal.toString):
(const.fakeISO8601Cal.toString):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/calendarname-invalid-string.js:
(invalidCals.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/calendarname-never.js: Added.
(const.cal.toString):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/fractionalseconddigits-auto.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/fractionalseconddigits-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/fractionalseconddigits-non-integer.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/fractionalseconddigits-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/fractionalseconddigits-out-of-range.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/fractionalseconddigits-undefined.js:
(expected.of.tests.const.lambda.datetime.toString):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/fractionalseconddigits-wrong-type.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/rounding-cross-midnight.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/rounding-direction.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/roundingmode-ceil.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/roundingmode-floor.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/roundingmode-halfExpand.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/roundingmode-trunc.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/smallestunit-fractionalseconddigits.js: Added.
(expected.of.tests.const.string.datetime.toString.get fractionalSecondDigits):
(datetime.toString.get fractionalSecondDigits):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/smallestunit-valid-units.js:
(test):
(notValid.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toString/year-format.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/disambiguation-invalid-string.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/invalid-instant.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/multiple-instants.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/options-object.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/toZonedDateTime/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.toZonedDateTime):
(description.of.typeErrorTests.instance.toZonedDateTime):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/argument-object.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.until):
(description.of.typeErrorTests.instance.until):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/argument-string.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.until):
(description.of.typeErrorTests.instance.until):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/balance-negative-duration.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/balance.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/casts-argument.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/different-calendars-throws.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/inverse.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/largestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/no-unnecessary-units.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/options-empty.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/options-invalid.js: Added.
(badOptions.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/returns-days.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/round-relative-to-receiver.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/roundingincrement-basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/roundingincrement-cleanly-divides.js: Added.
(12.forEach):
(string_appeared_here.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/roundingincrement-does-not-divide.js: Added.
(Object.entries.nondivisibleUnits.forEach):
(Object.entries.equalDivisibleUnits.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/roundingmode-ceil-basic.js: Added.
(incrementOneCeil.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/roundingmode-floor-basic.js: Added.
(incrementOneFloor.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/roundingmode-halfexpand-basic.js: Added.
(ensureUnsignedZero):
(incrementOneNearest.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/roundingmode-halfexpand-default-changes.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/roundingmode-trunc-basic.js: Added.
(ensureUnsignedZero):
(incrementOneTrunc.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/roundingmode-trunc-is-default.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/subseconds.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/units-changed.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/weeks-months-mutually-exclusive.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/until/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/valueOf/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/weekOfYear/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/argument-not-object.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/argument-object-insufficient-data.js: Added.
(units.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/calendar-options.js: Added.
(Calendar):
(Calendar.prototype.dateFromFields):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/calendar-temporal-object-throws.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/calendar-throws.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/month-and-monthcode-must-agree.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/multiple-unrecognized-properties-ignored.js: Added.
(units.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/options-empty.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/options-invalid.js: Added.
(badOptions.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/order-of-operations.js:
(const.options.get overflow):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/string-throws.js: Added.
(baddies.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/with/timezone-throws.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/argument-string.js: Added.
(const.calendar.toString):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/basic.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/calendar-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/calendar-temporal-object.js:
(TemporalHelpers.checkToTemporalCalendarFastPath):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.withCalendar):
(description.of.typeErrorTests.instance.withCalendar):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-object-insufficient-data.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-object.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-plaindate-calendar-noniso.js: Added.
(const.cal.toString):
(const.cal.year):
(const.cal.month):
(const.cal.monthCode):
(const.cal.day):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-plaindate-calendar-same-id.js: Added.
(const.cal1.toString):
(const.cal2.toString):
(const.cal2.year):
(const.cal2.month):
(const.cal2.monthCode):
(const.cal2.day):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-plaindate-calendar-same-object.js: Added.
(const.cal.toString):
(const.cal.year):
(const.cal.month):
(const.cal.monthCode):
(const.cal.day):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-plaindate-calendar.js: Added.
(const.cal.toString):
(const.cal.year):
(const.cal.month):
(const.cal.monthCode):
(const.cal.day):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-plaindate.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.withPlainDate):
(description.of.typeErrorTests.instance.withPlainDate):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-string-iso-calendar.js: Added.
(const.cal.toString):
(const.cal.year):
(const.cal.month):
(const.cal.monthCode):
(const.cal.day):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-string.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.withPlainDate):
(description.of.typeErrorTests.instance.withPlainDate):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/non-compatible-calendars-throw.js: Added.
(const.cal.toString):
(const.anotherCal.toString):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainDate/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-object-insufficient-data.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-time-designator-required-for-disambiguation.js:
(ambiguousStrings.forEach):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-without-time-designator.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-time.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.withPlainTime):
(description.of.typeErrorTests.instance.withPlainTime):
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/no-argument-default-to-midnight.js: Added.
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/plaintime-propertybag-no-time-units.js:
- test262/test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/year-zero.js:
- test262/test/built-ins/Temporal/PlainDateTime/second-undefined.js:
- test262/test/built-ins/Temporal/PlainMonthDay/calendar-always.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.PlainMonthDay):
(description.of.typeErrorTests.new.Temporal.PlainMonthDay):
- test262/test/built-ins/Temporal/PlainMonthDay/from/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/from/argument-plainmonthday.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/from/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/from/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/from/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.PlainMonthDay.from):
(description.of.typeErrorTests.Temporal.PlainMonthDay.from):
- test262/test/built-ins/Temporal/PlainMonthDay/from/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainMonthDay/from/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.PlainMonthDay.from):
(description.of.typeErrorTests.Temporal.PlainMonthDay.from):
- test262/test/built-ins/Temporal/PlainMonthDay/from/calendar-monthdayfromfields-called-with-options-undefined.js: Added.
(Temporal.Calendar.prototype.monthDayFromFields):
- test262/test/built-ins/Temporal/PlainMonthDay/from/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/from/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/from/overflow-invalid-string.js:
(validValues.forEach): Deleted.
- test262/test/built-ins/Temporal/PlainMonthDay/from/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.equals):
(description.of.typeErrorTests.instance.equals):
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/equals/argument-wrong-type.js:
(description.of.rangeErrorTests.instance.equals):
(description.of.typeErrorTests.instance.equals):
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/equals/calendar-monthdayfromfields-called-with-options-undefined.js: Added.
(Temporal.Calendar.prototype.monthDayFromFields):
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/equals/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/equals/year-zero.js:
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/toJSON/year-format.js: Added.
(NotISO):
(NotISO.prototype.toString):
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/toString/calendarname-always.js:
(toString):
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/toString/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/toString/year-format.js: Added.
(NotISO):
(NotISO.prototype.toString):
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/with/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainMonthDay/prototype/with/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/PlainTime/compare/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainTime/compare/argument-string-time-designator-required-for-disambiguation.js:
(ambiguousStrings.forEach):
- test262/test/built-ins/Temporal/PlainTime/compare/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.PlainTime):
(description.of.rangeErrorTests.Temporal.PlainTime.compare.new.Temporal.PlainTime):
(description.of.typeErrorTests.new.Temporal.PlainTime):
(description.of.typeErrorTests.Temporal.PlainTime.compare.new.Temporal.PlainTime):
- test262/test/built-ins/Temporal/PlainTime/compare/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/compare/plaintime-propertybag-no-time-units.js:
- test262/test/built-ins/Temporal/PlainTime/compare/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainTime/from/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainTime/from/argument-object-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/from/argument-object.js: Added.
- test262/test/built-ins/Temporal/PlainTime/from/argument-plaintime.js:
- test262/test/built-ins/Temporal/PlainTime/from/argument-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/from/argument-string-time-designator-required-for-disambiguation.js:
(ambiguousStrings.forEach):
- test262/test/built-ins/Temporal/PlainTime/from/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.PlainTime.from):
(description.of.typeErrorTests.Temporal.PlainTime.from):
- test262/test/built-ins/Temporal/PlainTime/from/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/from/observable-get-overflow-argument-string-invalid.js: Renamed from JSTests/test262/test/built-ins/Temporal/PlainTime/from/argument-string-invalid.js.
- test262/test/built-ins/Temporal/PlainTime/from/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainTime/from/overflow-constrain.js: Added.
- test262/test/built-ins/Temporal/PlainTime/from/overflow-invalid-string.js:
(validValues.forEach): Deleted.
- test262/test/built-ins/Temporal/PlainTime/from/overflow-reject.js: Added.
- test262/test/built-ins/Temporal/PlainTime/from/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainTime/negative-zero.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/add/argument-duration.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/add/argument-higher-units.js: Added.
(new.Temporal.Duration):
- test262/test/built-ins/Temporal/PlainTime/prototype/add/argument-object.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/equals/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-time-designator-required-for-disambiguation.js:
(ambiguousStrings.forEach):
- test262/test/built-ins/Temporal/PlainTime/prototype/equals/argument-wrong-type.js:
(description.of.rangeErrorTests.instance.equals):
(description.of.typeErrorTests.instance.equals):
- test262/test/built-ins/Temporal/PlainTime/prototype/equals/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/equals/plaintime-propertybag-no-time-units.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/equals/year-zero.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/round/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/rounding-cross-midnight.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundingincrement-hours.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundingincrement-invalid.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundingincrement-microseconds.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundingincrement-milliseconds.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundingincrement-minutes.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundingincrement-nanoseconds.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundingincrement-seconds.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-ceil.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-floor.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-halfExpand.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-trunc.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundingmode-undefined.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/round/roundto-invalid-string.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/smallestunit-disallowed-units.js: Removed.
- test262/test/built-ins/Temporal/PlainTime/prototype/round/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/round/smallestunit-missing.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/argument-cast.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/argument-string-time-designator-required-for-disambiguation.js:
(ambiguousStrings.forEach):
- test262/test/built-ins/Temporal/PlainTime/prototype/since/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.since):
(description.of.typeErrorTests.instance.since):
- test262/test/built-ins/Temporal/PlainTime/prototype/since/basic.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/largestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/since/largestunit.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/since/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/plaintime-propertybag-no-time-units.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/since/result-sub-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/roundingincrement-hours.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/roundingincrement-invalid.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/roundingincrement-microseconds.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/roundingincrement-milliseconds.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/roundingincrement-minutes.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/roundingincrement-nanoseconds.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/roundingincrement-seconds.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/roundingmode-ceil.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/roundingmode-floor.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/roundingmode-halfExpand.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/since/roundingmode-trunc.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/since/roundingmode-undefined.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/since/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/since/year-zero.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/subtract/argument-duration.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/subtract/argument-higher-units.js: Added.
(new.Temporal.Duration):
- test262/test/built-ins/Temporal/PlainTime/prototype/subtract/argument-object.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toPlainDateTime/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toPlainDateTime/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toPlainDateTime/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toPlainDateTime/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.toPlainDateTime):
(description.of.typeErrorTests.instance.toPlainDateTime):
- test262/test/built-ins/Temporal/PlainTime/prototype/toPlainDateTime/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainTime/prototype/toPlainDateTime/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toPlainDateTime/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.toPlainDateTime):
(description.of.typeErrorTests.instance.toPlainDateTime):
- test262/test/built-ins/Temporal/PlainTime/prototype/toPlainDateTime/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toPlainDateTime/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toPlainDateTime/limits.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toPlainDateTime/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/fractionalseconddigits-auto.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/fractionalseconddigits-invalid-string.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/fractionalseconddigits-non-integer.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/fractionalseconddigits-number.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/fractionalseconddigits-out-of-range.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/fractionalseconddigits-undefined.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/fractionalseconddigits-wrong-type.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/rounding-cross-midnight.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/roundingmode-ceil.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/roundingmode-floor.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/roundingmode-halfExpand.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/roundingmode-trunc.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/smallestunit-fractionalseconddigits.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/toString/smallestunit-valid-units.js:
(test):
(notValid.forEach):
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.toZonedDateTime):
(description.of.typeErrorTests.instance.toZonedDateTime):
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/argument-string-with-utc-designator.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.toZonedDateTime):
(description.of.typeErrorTests.instance.toZonedDateTime):
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.plainDate.new.Temporal.PlainDate):
(description.of.typeErrorTests.plainDate.new.Temporal.PlainDate):
- test262/test/built-ins/Temporal/PlainTime/prototype/toZonedDateTime/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainTime/prototype/until/argument-cast.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/argument-string-time-designator-required-for-disambiguation.js:
(ambiguousStrings.forEach):
- test262/test/built-ins/Temporal/PlainTime/prototype/until/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.until):
(description.of.typeErrorTests.instance.until):
- test262/test/built-ins/Temporal/PlainTime/prototype/until/basic.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/largestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/until/largestunit.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/plaintime-propertybag-no-time-units.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/until/result-sub-second.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/roundingincrement-hours.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/roundingincrement-invalid.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/roundingincrement-microseconds.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/roundingincrement-milliseconds.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/roundingincrement-minutes.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/roundingincrement-nanoseconds.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/roundingincrement-seconds.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-ceil.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-floor.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-halfExpand.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-trunc.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-undefined.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/until/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/until/year-zero.js:
- test262/test/built-ins/Temporal/PlainTime/prototype/with/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainTime/prototype/with/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/PlainYearMonth/calendar-always.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.PlainYearMonth):
(description.of.typeErrorTests.new.Temporal.PlainYearMonth):
- test262/test/built-ins/Temporal/PlainYearMonth/compare/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.PlainYearMonth):
(description.of.rangeErrorTests.Temporal.PlainYearMonth.compare.new.Temporal.PlainYearMonth):
(description.of.typeErrorTests.new.Temporal.PlainYearMonth):
(description.of.typeErrorTests.Temporal.PlainYearMonth.compare.new.Temporal.PlainYearMonth):
- test262/test/built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainYearMonth/compare/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.PlainYearMonth):
(description.of.rangeErrorTests.Temporal.PlainYearMonth.compare.new.Temporal.PlainYearMonth):
(description.of.typeErrorTests.new.Temporal.PlainYearMonth):
(description.of.typeErrorTests.Temporal.PlainYearMonth.compare.new.Temporal.PlainYearMonth):
- test262/test/built-ins/Temporal/PlainYearMonth/compare/calendar-yearmonthfromfields-called-with-options-undefined.js: Added.
(Temporal.Calendar.prototype.yearMonthFromFields):
- test262/test/built-ins/Temporal/PlainYearMonth/compare/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/compare/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainYearMonth/from/argument-number.js:
- test262/test/built-ins/Temporal/PlainYearMonth/from/argument-plainyearmonth.js:
- test262/test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.PlainYearMonth.from):
(description.of.typeErrorTests.Temporal.PlainYearMonth.from):
- test262/test/built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainYearMonth/from/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.PlainYearMonth.from):
(description.of.typeErrorTests.Temporal.PlainYearMonth.from):
- test262/test/built-ins/Temporal/PlainYearMonth/from/calendar-yearmonthfromfields-called-with-options-undefined.js: Added.
(Temporal.Calendar.prototype.yearMonthFromFields):
- test262/test/built-ins/Temporal/PlainYearMonth/from/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/from/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/from/overflow-invalid-string.js:
(validValues.forEach): Deleted.
- test262/test/built-ins/Temporal/PlainYearMonth/from/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainYearMonth/limits.js:
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/add/calendar-datefromfields-called.js: Added.
(CustomCalendar):
(CustomCalendar.prototype.year):
(CustomCalendar.prototype.month):
(CustomCalendar.prototype.monthCode):
(CustomCalendar.prototype.day):
(CustomCalendar.prototype.daysInMonth):
(CustomCalendar.prototype._dateFromFieldsImpl):
(CustomCalendar.prototype.dateFromFields):
(CustomCalendar.prototype.yearMonthFromFields):
(CustomCalendar.prototype.monthDayFromFields):
(CustomCalendar.prototype.dateAdd):
(CustomCalendar.prototype.toString):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/add/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/add/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.equals):
(description.of.typeErrorTests.instance.equals):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/equals/argument-wrong-type.js:
(description.of.rangeErrorTests.instance.equals):
(description.of.typeErrorTests.instance.equals):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/equals/calendar-yearmonthfromfields-called-with-options-undefined.js: Added.
(Temporal.Calendar.prototype.yearMonthFromFields):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/equals/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/equals/year-zero.js:
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.since):
(description.of.typeErrorTests.instance.since):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.since):
(description.of.typeErrorTests.instance.since):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/calendar-yearmonthfromfields-called-with-options-undefined.js: Added.
(Temporal.Calendar.prototype.yearMonthFromFields):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/largestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/since/year-zero.js:
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/subtract/calendar-datefromfields-called.js: Added.
(CustomCalendar):
(CustomCalendar.prototype.year):
(CustomCalendar.prototype.month):
(CustomCalendar.prototype.monthCode):
(CustomCalendar.prototype.day):
(CustomCalendar.prototype.daysInMonth):
(CustomCalendar.prototype._dateFromFieldsImpl):
(CustomCalendar.prototype.dateFromFields):
(CustomCalendar.prototype.yearMonthFromFields):
(CustomCalendar.prototype.monthDayFromFields):
(CustomCalendar.prototype.dateAdd):
(CustomCalendar.prototype.toString):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/subtract/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/subtract/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/toJSON/year-format.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/toString/calendarname-always.js:
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/toString/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/toString/year-format.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-number.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.until):
(description.of.typeErrorTests.instance.until):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.until):
(description.of.typeErrorTests.instance.until):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/calendar-yearmonthfromfields-called-with-options-undefined.js: Added.
(Temporal.Calendar.prototype.yearMonthFromFields):
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/largestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/leap-second.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/until/year-zero.js:
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/with/options-wrong-type.js:
(values.forEach): Deleted.
- test262/test/built-ins/Temporal/PlainYearMonth/prototype/with/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/TimeZone/from/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/TimeZone/from/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/TimeZone/from/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.TimeZone.from):
(description.of.typeErrorTests.Temporal.TimeZone.from):
- test262/test/built-ins/Temporal/TimeZone/prototype/getInstantFor/argument-number.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getInstantFor/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getInstantFor/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getInstantFor/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.getInstantFor):
(description.of.typeErrorTests.instance.getInstantFor):
- test262/test/built-ins/Temporal/TimeZone/prototype/getInstantFor/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/TimeZone/prototype/getInstantFor/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.getInstantFor):
(description.of.typeErrorTests.instance.getInstantFor):
- test262/test/built-ins/Temporal/TimeZone/prototype/getInstantFor/leap-second.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getInstantFor/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getInstantFor/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/TimeZone/prototype/getNextTransition/leap-second.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getNextTransition/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/TimeZone/prototype/getOffsetNanosecondsFor/leap-second.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getOffsetNanosecondsFor/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/TimeZone/prototype/getOffsetStringFor/leap-second.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getOffsetStringFor/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/TimeZone/prototype/getPlainDateTimeFor/argument-object-tostring.js: Added.
(arg.toString):
- test262/test/built-ins/Temporal/TimeZone/prototype/getPlainDateTimeFor/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.getPlainDateTimeFor):
(description.of.typeErrorTests.instance.getPlainDateTimeFor):
- test262/test/built-ins/Temporal/TimeZone/prototype/getPlainDateTimeFor/calendar-number.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getPlainDateTimeFor/calendar-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getPlainDateTimeFor/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.getPlainDateTimeFor.new.Temporal.Instant):
(description.of.typeErrorTests.instance.getPlainDateTimeFor.new.Temporal.Instant):
- test262/test/built-ins/Temporal/TimeZone/prototype/getPlainDateTimeFor/instant-string-sub-minute-offset.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getPlainDateTimeFor/leap-second.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getPlainDateTimeFor/limits.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getPlainDateTimeFor/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/TimeZone/prototype/getPossibleInstantsFor/argument-number.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getPossibleInstantsFor/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getPossibleInstantsFor/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getPossibleInstantsFor/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.getPossibleInstantsFor):
(description.of.typeErrorTests.instance.getPossibleInstantsFor):
- test262/test/built-ins/Temporal/TimeZone/prototype/getPossibleInstantsFor/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/TimeZone/prototype/getPossibleInstantsFor/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.getPossibleInstantsFor):
(description.of.typeErrorTests.instance.getPossibleInstantsFor):
- test262/test/built-ins/Temporal/TimeZone/prototype/getPossibleInstantsFor/leap-second.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getPossibleInstantsFor/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/TimeZone/prototype/getPreviousTransition/leap-second.js: Added.
- test262/test/built-ins/Temporal/TimeZone/prototype/getPreviousTransition/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/calendar-number.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.ZonedDateTime):
(description.of.typeErrorTests.new.Temporal.ZonedDateTime):
- test262/test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.ZonedDateTime.compare):
(description.of.typeErrorTests.Temporal.ZonedDateTime.compare):
- test262/test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/compare/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.ZonedDateTime.compare):
(description.of.typeErrorTests.Temporal.ZonedDateTime.compare):
- test262/test/built-ins/Temporal/ZonedDateTime/compare/leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/compare/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/compare/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/compare/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.ZonedDateTime.compare):
(description.of.typeErrorTests.Temporal.ZonedDateTime.compare):
- test262/test/built-ins/Temporal/ZonedDateTime/compare/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.ZonedDateTime.from):
(description.of.typeErrorTests.Temporal.ZonedDateTime.from):
- test262/test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/from/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.ZonedDateTime.from):
(description.of.typeErrorTests.Temporal.ZonedDateTime.from):
- test262/test/built-ins/Temporal/ZonedDateTime/from/argument-zoneddatetime.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/from/leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/from/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/from/overflow-invalid-string.js:
(validValues.forEach): Deleted.
- test262/test/built-ins/Temporal/ZonedDateTime/from/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/from/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/from/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.Temporal.ZonedDateTime.from):
(description.of.typeErrorTests.Temporal.ZonedDateTime.from):
- test262/test/built-ins/Temporal/ZonedDateTime/from/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/add/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/add/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.equals):
(description.of.typeErrorTests.instance.equals):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.equals):
(description.of.typeErrorTests.instance.equals):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/equals/leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/equals/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/equals/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/equals/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.equals):
(description.of.typeErrorTests.instance.equals):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/equals/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/round/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/round/rounding-direction.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/round/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/round/roundto-invalid-string.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/round/smallestunit-disallowed-units.js: Removed.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/round/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.since):
(description.of.typeErrorTests.instance.since):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.since):
(description.of.typeErrorTests.instance.since):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/calendar-dateadd-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/largestunit-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.since):
(description.of.typeErrorTests.instance.since):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/since/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/subtract/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/subtract/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toJSON/year-format.js: Added.
(epochNsInYear):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toPlainMonthDay/calendar-monthdayfromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toPlainYearMonth/calendar-yearmonthfromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/fractionalseconddigits-auto.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/fractionalseconddigits-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/fractionalseconddigits-non-integer.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/fractionalseconddigits-number.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/fractionalseconddigits-out-of-range.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/fractionalseconddigits-undefined.js:
(expected.of.tests.const.lambda.datetime.toString):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/fractionalseconddigits-wrong-type.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/rounding-cross-midnight.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/rounding-direction.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/roundingmode-ceil.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/roundingmode-floor.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/roundingmode-halfExpand.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/roundingmode-trunc.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/smallestunit-fractionalseconddigits.js: Added.
(expected.of.tests.const.string.datetime.toString.get fractionalSecondDigits):
(datetime.toString.get fractionalSecondDigits):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/smallestunit-valid-units.js:
(test):
(notValid.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/toString/year-format.js: Added.
(epochNsInYear):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.until):
(description.of.typeErrorTests.instance.until):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.until):
(description.of.typeErrorTests.instance.until):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/calendar-dateadd-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/largestunit-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/roundingmode-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/smallestunit-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.until):
(description.of.typeErrorTests.instance.until):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/until/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/with/options-wrong-type.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/with/overflow-invalid-string.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/calendar-number.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/calendar-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.withCalendar):
(description.of.typeErrorTests.instance.withCalendar):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/argument-number.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/argument-propertybag-calendar-number.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.withPlainDate):
(description.of.typeErrorTests.instance.withPlainDate):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/argument-string-invalid.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.withPlainDate):
(description.of.typeErrorTests.instance.withPlainDate):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/year-zero.js:
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/argument-number.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/argument-string-time-designator-required-for-disambiguation.js:
(ambiguousStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.withPlainTime):
(description.of.typeErrorTests.instance.withPlainTime):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/plaintime-propertybag-no-time-units.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/year-zero.js:
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/timezone-string-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.withTimeZone):
(description.of.typeErrorTests.instance.withTimeZone):
- test262/test/built-ins/Temporal/ZonedDateTime/timezone-string-leap-second.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/timezone-string-multiple-offsets.js: Added.
- test262/test/built-ins/Temporal/ZonedDateTime/timezone-wrong-type.js: Added.
(description.of.rangeErrorTests.new.Temporal.ZonedDateTime):
(description.of.typeErrorTests.new.Temporal.ZonedDateTime):
- test262/test/built-ins/TypedArray/prototype/set/BigInt/array-arg-targetbuffer-detached-on-get-src-value-throws.js: Removed.
- test262/test/built-ins/TypedArray/prototype/set/array-arg-targetbuffer-detached-on-get-src-value-no-throw.js: Added.
(testWithTypedArrayConstructors.):
(testWithTypedArrayConstructors.get let):
- test262/test/built-ins/TypedArray/prototype/set/array-arg-targetbuffer-detached-on-get-src-value-throws.js: Removed.
- test262/test/built-ins/TypedArray/prototype/sort/BigInt/detached-buffer-comparefn.js: Removed.
- test262/test/built-ins/TypedArray/prototype/sort/detached-buffer-comparefn-coerce.js: Removed.
- test262/test/built-ins/TypedArray/prototype/sort/detached-buffer-comparefn.js: Removed.
- test262/test/built-ins/TypedArray/prototype/sort/sort-tonumber.js:
(testWithTypedArrayConstructors):
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/detached-when-species-retrieved-different-type.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/detached-when-species-retrieved-same-type.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/other-ctor-buffer-ctor-access-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/other-ctor-buffer-ctor-custom-species-proto-from-ctor-realm.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/other-ctor-buffer-ctor-custom-species.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/other-ctor-buffer-ctor-not-object-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/other-ctor-buffer-ctor-species-access-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/other-ctor-buffer-ctor-species-not-ctor-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/other-ctor-buffer-ctor-species-prototype-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/same-ctor-buffer-ctor-access-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/same-ctor-buffer-ctor-species-custom-proto-from-ctor-realm.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/same-ctor-buffer-ctor-species-custom.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/same-ctor-buffer-ctor-species-not-ctor.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/same-ctor-buffer-ctor-species-prototype-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/same-ctor-buffer-ctor-species-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors-bigint/typedarray-arg/same-ctor-buffer-ctor-value-not-obj-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/no-species.js: Added.
(GrossBuffer):
(GrossBuffer.get Symbol):
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/detached-when-species-retrieved-different-type.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/detached-when-species-retrieved-same-type.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/other-ctor-buffer-ctor-access-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/other-ctor-buffer-ctor-custom-species-proto-from-ctor-realm.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/other-ctor-buffer-ctor-custom-species.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/other-ctor-buffer-ctor-not-object-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/other-ctor-buffer-ctor-species-access-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/other-ctor-buffer-ctor-species-not-ctor-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/other-ctor-buffer-ctor-species-null.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/other-ctor-buffer-ctor-species-prototype-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/other-ctor-buffer-ctor-species-undefined.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/out-of-bounds-when-species-retrieved-different-type.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/out-of-bounds-when-species-retrieved-same-type.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/same-ctor-buffer-ctor-access-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/same-ctor-buffer-ctor-species-custom-proto-from-ctor-realm.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/same-ctor-buffer-ctor-species-custom.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/same-ctor-buffer-ctor-species-not-ctor.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/same-ctor-buffer-ctor-species-prototype-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/same-ctor-buffer-ctor-species-throws.js: Removed.
- test262/test/built-ins/TypedArrayConstructors/ctors/typedarray-arg/same-ctor-buffer-ctor-value-not-obj-throws.js: Removed.
- test262/test/built-ins/parseInt/15.1.2.2-2-1.js:
- test262/test/harness/temporalHelpers-one-shift-time-zone.js: Added.
(checkTimeZoneArithmetic):
- test262/test/intl402/DurationFormat/constructor-locales-invalid.js: Added.
(expectedError.of.getInvalidLocaleArguments):
- test262/test/intl402/DurationFormat/constructor-locales-valid.js: Added.
(name.of.tests.matchers.forEach):
- test262/test/intl402/DurationFormat/constructor-options-defaults.js: Added.
- test262/test/intl402/DurationFormat/constructor-options-fractionalDigits-invalid.js: Added.
- test262/test/intl402/DurationFormat/constructor-options-fractionalDigits-valid.js: Added.
- test262/test/intl402/DurationFormat/constructor-options-invalid.js: Added.
- test262/test/intl402/DurationFormat/constructor-options-localeMatcher-invalid.js: Added.
(const.localeMatcher.of.invalidOptions.new.Intl.DurationFormat):
- test262/test/intl402/DurationFormat/constructor-options-localeMatcher-valid.js: Added.
- test262/test/intl402/DurationFormat/constructor-options-numberingSystem-invalid.js: Added.
- test262/test/intl402/DurationFormat/constructor-options-numberingSystem-valid.js: Added.
- test262/test/intl402/DurationFormat/constructor-options-order.js: Added.
(const.options.get localeMatcher):
(const.options.get numberingSystem):
(const.options.get style):
- test262/test/intl402/DurationFormat/constructor-options-style-invalid.js: Added.
(const.invalidOption.of.invalidOptions.new.Intl.DurationFormat):
- test262/test/intl402/DurationFormat/constructor-options-style-valid.js: Added.
(toString):
- test262/test/intl402/DurationFormat/extensibility.js: Renamed from JSTests/test262/test/intl402/DurationFormat/instance/extensibility.js.
- test262/test/intl402/DurationFormat/length.js: Renamed from JSTests/test262/test/intl402/DurationFormat/instance/length.js.
- test262/test/intl402/DurationFormat/name.js: Renamed from JSTests/test262/test/intl402/DurationFormat/instance/name.js.
- test262/test/intl402/DurationFormat/newtarget-undefined.js: Added.
- test262/test/intl402/DurationFormat/prop-desc.js: Renamed from JSTests/test262/test/intl402/DurationFormat/instance/prop-desc.js.
- test262/test/intl402/DurationFormat/prototype.js: Renamed from JSTests/test262/test/intl402/DurationFormat/instance/prototype.js.
- test262/test/intl402/DurationFormat/supportedLocalesOf/basic.js: Added.
- test262/test/intl402/DurationFormat/supportedLocalesOf/branding.js: Added.
- test262/test/intl402/DurationFormat/supportedLocalesOf/length.js: Added.
- test262/test/intl402/DurationFormat/supportedLocalesOf/locales-empty.js: Added.
- test262/test/intl402/DurationFormat/supportedLocalesOf/locales-invalid.js: Added.
(expectedError.of.getInvalidLocaleArguments):
- test262/test/intl402/DurationFormat/supportedLocalesOf/locales-specific.js: Added.
- test262/test/intl402/DurationFormat/supportedLocalesOf/name.js: Added.
- test262/test/intl402/DurationFormat/supportedLocalesOf/prop-desc.js: Added.
- test262/test/intl402/Intl/DateTimeFormat/prototype/formatRange/fails-on-distinct-temporal-types.js: Added.
(Object.entries.instances.forEach):
- test262/test/intl402/Intl/DateTimeFormat/prototype/formatRangeToParts/fails-on-distinct-temporal-types.js: Added.
(Object.entries.instances.forEach):
- test262/test/intl402/NumberFormat/constructor-roundingIncrement-invalid.js:
- test262/test/intl402/NumberFormat/constructor-roundingIncrement.js:
(expected.of.values.get roundingIncrement):
- test262/test/intl402/NumberFormat/prototype/format/format-max-min-fraction-significant-digits.js: Added.
(nfTestMatrix.forEach):
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-10.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-100.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-1000.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-2.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-20.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-200.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-2000.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-25.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-250.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-2500.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-5.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-50.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-500.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-increment-5000.js:
- test262/test/intl402/NumberFormat/prototype/format/format-rounding-priority-more-precision.js:
- test262/test/intl402/NumberFormat/prototype/formatRange/x-greater-than-y-throws.js:
- test262/test/intl402/NumberFormat/prototype/formatRangeToParts/x-greater-than-y-throws.js:
- test262/test/intl402/Temporal/Calendar/prototype/era/argument-number.js: Added.
- test262/test/intl402/Temporal/Calendar/prototype/era/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/intl402/Temporal/Calendar/prototype/era/argument-propertybag-calendar-number.js: Added.
- test262/test/intl402/Temporal/Calendar/prototype/era/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.era):
(description.of.typeErrorTests.instance.era):
- test262/test/intl402/Temporal/Calendar/prototype/era/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/intl402/Temporal/Calendar/prototype/era/argument-string-invalid.js: Added.
- test262/test/intl402/Temporal/Calendar/prototype/era/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.era):
(description.of.typeErrorTests.instance.era):
- test262/test/intl402/Temporal/Calendar/prototype/era/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/intl402/Temporal/Calendar/prototype/era/leap-second.js: Added.
- test262/test/intl402/Temporal/Calendar/prototype/era/year-zero.js:
(invalidStrings.forEach):
- test262/test/intl402/Temporal/Calendar/prototype/eraYear/argument-number.js: Added.
- test262/test/intl402/Temporal/Calendar/prototype/eraYear/argument-propertybag-calendar-leap-second.js: Added.
- test262/test/intl402/Temporal/Calendar/prototype/eraYear/argument-propertybag-calendar-number.js: Added.
- test262/test/intl402/Temporal/Calendar/prototype/eraYear/argument-propertybag-calendar-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.eraYear):
(description.of.typeErrorTests.instance.eraYear):
- test262/test/intl402/Temporal/Calendar/prototype/eraYear/argument-propertybag-calendar-year-zero.js: Added.
(invalidStrings.forEach):
- test262/test/intl402/Temporal/Calendar/prototype/eraYear/argument-string-invalid.js: Added.
- test262/test/intl402/Temporal/Calendar/prototype/eraYear/argument-wrong-type.js: Added.
(description.of.rangeErrorTests.instance.eraYear):
(description.of.typeErrorTests.instance.eraYear):
- test262/test/intl402/Temporal/Calendar/prototype/eraYear/calendar-datefromfields-called-with-options-undefined.js: Added.
- test262/test/intl402/Temporal/Calendar/prototype/eraYear/leap-second.js: Added.
- test262/test/intl402/Temporal/Calendar/prototype/eraYear/year-zero.js:
(invalidStrings.forEach):
- test262/test/intl402/Temporal/Duration/compare/relativeto-hour.js: Added.
- test262/test/intl402/Temporal/Instant/prototype/toString/timezone-offset.js: Added.
(test):
- test262/test/intl402/Temporal/PlainDateTime/prototype/toString/calendarname-always.js: Added.
- test262/test/intl402/Temporal/PlainDateTime/prototype/toString/calendarname-auto.js: Added.
- test262/test/intl402/Temporal/PlainDateTime/prototype/toString/calendarname-never.js: Added.
- test262/test/intl402/Temporal/PlainDateTime/prototype/withPlainDate/argument-plaindate-calendar-noniso.js: Added.
(const.cal.era):
(const.cal.eraYear):
(const.cal.toString):
(const.cal.year):
(const.cal.month):
(const.cal.monthCode):
(const.cal.day):
- test262/test/intl402/Temporal/PlainDateTime/prototype/withPlainDate/argument-plaindate-calendar-same-id.js: Added.
(const.cal1.toString):
(const.cal2.era):
(const.cal2.eraYear):
(const.cal2.toString):
(const.cal2.year):
(const.cal2.month):
(const.cal2.monthCode):
(const.cal2.day):
- test262/test/intl402/Temporal/PlainDateTime/prototype/withPlainDate/argument-plaindate-calendar-same-object.js: Added.
(const.cal.era):
(const.cal.eraYear):
(const.cal.toString):
(const.cal.year):
(const.cal.month):
(const.cal.monthCode):
(const.cal.day):
- test262/test/intl402/Temporal/PlainDateTime/prototype/withPlainDate/argument-plaindate-calendar.js: Added.
(const.cal.era):
(const.cal.eraYear):
(const.cal.toString):
(const.cal.year):
(const.cal.month):
(const.cal.monthCode):
(const.cal.day):
- test262/test/intl402/Temporal/PlainDateTime/prototype/withPlainDate/argument-string-calendar.js: Added.
- test262/test/intl402/Temporal/PlainDateTime/prototype/withPlainDate/argument-string-iso-calendar.js: Added.
(const.cal.era):
(const.cal.eraYear):
(const.cal.toString):
(const.cal.year):
(const.cal.month):
(const.cal.monthCode):
(const.cal.day):
- test262/test/intl402/Temporal/TimeZone/etc-timezone.js: Added.
(14.forEach):
(9.forEach):
(12.forEach):
- test262/test/language/expressions/compound-assignment/left-hand-side-private-reference-accessor-property-and.js: Removed.
- test262/test/language/expressions/compound-assignment/left-hand-side-private-reference-accessor-property-nullish.js: Removed.
- test262/test/language/expressions/compound-assignment/left-hand-side-private-reference-accessor-property-or.js: Removed.
- test262/test/language/expressions/compound-assignment/left-hand-side-private-reference-data-property-and.js: Removed.
- test262/test/language/expressions/compound-assignment/left-hand-side-private-reference-data-property-nullish.js: Removed.
- test262/test/language/expressions/compound-assignment/left-hand-side-private-reference-data-property-or.js: Removed.
- test262/test/language/expressions/compound-assignment/left-hand-side-private-reference-method-and.js: Removed.
- test262/test/language/expressions/compound-assignment/left-hand-side-private-reference-method-nullish.js: Removed.
- test262/test/language/expressions/compound-assignment/left-hand-side-private-reference-method-or.js: Removed.
- test262/test/language/expressions/compound-assignment/left-hand-side-private-reference-readonly-accessor-property-and.js: Removed.
- test262/test/language/expressions/compound-assignment/left-hand-side-private-reference-readonly-accessor-property-nullish.js: Removed.
- test262/test/language/expressions/compound-assignment/left-hand-side-private-reference-readonly-accessor-property-or.js: Removed.
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-accessor-property-and.js: Added.
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-accessor-property-nullish.js: Added.
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-accessor-property-or.js: Added.
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-accessor-property-short-circuit-and.js: Added.
(doNotCall):
(C.prototype.get field):
(C.prototype.set field):
(C.prototype.compoundAssignment):
(C):
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-accessor-property-short-circuit-nullish.js: Added.
(doNotCall):
(C.prototype.get field):
(C.prototype.set field):
(C.prototype.compoundAssignment):
(C):
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-accessor-property-short-circuit-or.js: Added.
(doNotCall):
(C.prototype.get field):
(C.prototype.set field):
(C.prototype.compoundAssignment):
(C):
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-data-property-and.js: Added.
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-data-property-nullish.js: Added.
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-data-property-or.js: Added.
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-data-property-short-circuit-and.js: Added.
(doNotCall):
(C.prototype.compoundAssignment):
(C.prototype.fieldValue):
(C):
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-data-property-short-circuit-nullish.js: Added.
(doNotCall):
(C.prototype.compoundAssignment):
(C.prototype.fieldValue):
(C):
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-data-property-short-circuit-or.js: Added.
(doNotCall):
(C.prototype.compoundAssignment):
(C.prototype.fieldValue):
(C):
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-method-and.js: Added.
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-method-short-circuit-nullish.js: Added.
(doNotCall):
(C.prototype.compoundAssignment):
(C.prototype.getPrivateMethodFunctionObject):
(C):
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-method-short-circuit-or.js: Added.
(doNotCall):
(C.prototype.compoundAssignment):
(C.prototype.getPrivateMethodFunctionObject):
(C):
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-readonly-accessor-property-and.js: Added.
(C.prototype.get field):
(C.prototype.compoundAssignment):
(C):
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-readonly-accessor-property-nullish.js: Added.
(C.prototype.get field):
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-readonly-accessor-property-or.js: Added.
(C.prototype.get field):
(C.prototype.compoundAssignment):
(C):
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-readonly-accessor-property-short-circuit-and.js: Added.
(doNotCall):
(C.prototype.get field):
(C.prototype.compoundAssignment):
(C):
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-readonly-accessor-property-short-circuit-nullish.js: Added.
(doNotCall):
(C.prototype.get field):
(C.prototype.compoundAssignment):
(C):
- test262/test/language/expressions/logical-assignment/left-hand-side-private-reference-readonly-accessor-property-short-circuit-or.js: Added.
(doNotCall):
(C.prototype.get field):
(C.prototype.compoundAssignment):
(C):
- test262/test/language/expressions/unary-plus/S11.4.6_A3_T3.js:
(new.Number):
(isNaN):
- test262/test/language/statements/for-in/S12.6.4_A7_T2.js:
(erasator_T_1000):
(accum.indexOf.string_appeared_here.1.accum.indexOf): Deleted.
(accum.indexOf): Deleted.
- test262/test262-Revision.txt:
- 3:47 PM Changeset in webkit [293796] by
-
- 3 edits in trunk/LayoutTests
[ iOS ][ macOS Debug wk1 ] webaudio/AudioBuffer/huge-buffer.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=240081
Unreviewed test gardening.
Canonical link: https://commits.webkit.org/250270@main
- 3:03 PM Changeset in webkit [293795] by
-
- 2 edits in trunk/Source/WebKit
[iOS][GPUP] Grant read access to font directory
https://bugs.webkit.org/show_bug.cgi?id=240080
Reviewed by Brent Fulgham.
- Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in:
- 2:55 PM Changeset in webkit [293794] by
-
- 2 edits in trunk/Source/WebCore
[Mac] WebCore should search system content path for nested Frameworks
https://bugs.webkit.org/show_bug.cgi?id=240063
Reviewed by Alexey Proskuryakov.
Changed nested frameworks directory to be below where WebCore will be installed
when building with the system content path.
- Configurations/WebCore.xcconfig:
- 2:23 PM Changeset in webkit [293793] by
-
- 6 edits in branches/safari-613-branch/Source/WebKit
Apply patch. rdar://problem/88904160
- 2:23 PM Changeset in webkit [293792] by
-
- 48 edits in branches/safari-613-branch/Source/WebCore
Apply patch. rdar://problem/75450208
- 2:23 PM Changeset in webkit [293791] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r291299. rdar://problem/91446377
Line Builder and Content Breaker out of sync
https://bugs.webkit.org/show_bug.cgi?id=237903
Reviewed by Simon Fraser.
Line builder and content breaker could become out of sync in the case where
the first line style was different than following styles. This could result
in issues with wrapping later on.
- layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::handleInlineContent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:18 PM Changeset in webkit [293790] by
-
- 5 edits in trunk
REGRESSION (r293427): [ iOS ] http/tests/quicklook/same-origin-xmlhttprequest-allowed.html is a constant crash and failure (240024)
https://bugs.webkit.org/show_bug.cgi?id=240024
rdar://92678727
Reviewed by Wenson Hsieh.
Source/WebCore:
No new tests, this will fix a failing test.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoadingRemoteArchive):
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::scheduleArchiveLoad):
- loader/DocumentLoader.h:
LayoutTests:
- platform/ios/TestExpectations:
- 1:59 PM Changeset in webkit [293789] by
-
- 1 copy in tags/WebKit-7614.1.11.6
Tag WebKit-7614.1.11.6.
- 1:41 PM Changeset in webkit [293788] by
-
- 9 edits in branches/safari-614.1.11-branch/Source
Versioning.
WebKit-7614.1.11.6
- 1:36 PM Changeset in webkit [293787] by
-
- 3 edits in trunk/LayoutTests
[Gardening][iOS Mac ] imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/same-hash.html is a flaky text failure
https://bugs.webkit.org/show_bug.cgi?id=237552
Unreviewed test gardening.
Canonical link: https://commits.webkit.org/250266@main
- 1:28 PM Changeset in webkit [293786] by
-
- 3 edits in trunk/Source/WebKit
[WebAuthn] Remove user gesture requirement for mediation=conditional assertions
https://bugs.webkit.org/show_bug.cgi?id=240038
rdar://92137603
Reviewed by Brent Fulgham.
Conditional assertions are non-modal and already require a gesture to complete via
a different mechanism.
Tested manually on device.
- UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::configurationAssertionRequestContext):
- UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
(WebKit::WebAuthenticatorCoordinatorProxy::handleRequest):
- 1:22 PM Changeset in webkit [293785] by
-
- 33 edits in trunk
Remove deprecated 'JavaEnabled' feature flag and related code
https://bugs.webkit.org/show_bug.cgi?id=240044
Reviewed by Darin Adler.
We removed support for Java Plug-Ins in macOS 10.15, but never removed the preference. To reduce code complexity
and build times we should remove this unused preference, leaving non-functional stubs to avoid breaking binaries
that expect to call their accessor methods.
Source/WebCore:
- loader/ResourceLoadStatistics.cpp:
(WebCore::navigatorAPIEnumToString):
- loader/ResourceLoadStatistics.h:
- loader/SubframeLoader.cpp:
(WebCore::FrameLoader::SubframeLoader::pluginIsLoadable):
- page/Navigator.cpp:
(WebCore::Navigator::javaEnabled const): Deleted.
- page/Navigator.h:
Source/WebKit:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetJavaEnabled):
(WKPreferencesGetJavaEnabled):
(WKPreferencesSetJavaEnabledForLocalFiles):
(WKPreferencesGetJavaEnabledForLocalFiles):
- UIProcess/API/C/WKPreferencesRef.h:
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences encodeWithCoder:]):
(-[WKPreferences initWithCoder:]):
(-[WKPreferences javaEnabled]):
(-[WKPreferences setJavaEnabled:]):
(-[WKPreferences _setJavaEnabledForLocalFiles:]):
(-[WKPreferences _javaEnabledForLocalFiles]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- UIProcess/API/glib/WebKitSettings.cpp:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::createWithLegacyDefaults):
Source/WebKitLegacy/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController init]):
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.h:
- WebView/WebPreferences.mm:
(-[WebPreferences isJavaEnabled]):
(-[WebPreferences setJavaEnabled:]):
Source/WebKitLegacy/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openLocalFrontend):
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::isJavaEnabled):
(WebPreferences::setJavaEnabled):
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WTF:
- Scripts/Preferences/WebPreferences.yaml:
Tools:
- DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
- TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
(TEST):
- 1:20 PM Changeset in webkit [293784] by
-
- 12 edits in trunk/Tools
[git-webkit] Populate commit message with bug details
https://bugs.webkit.org/show_bug.cgi?id=240022
<rdar://problem/92674438>
Reviewed by Dewei Zhu.
- Tools/Scripts/hooks/prepare-commit-msg: Pull title and bugs from environment variables.
- Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitcorepy/webkitcorepy/init.py: Ditto.
- Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/popen.py:
(PopenBase.init): Support environment variables.
(PopenBase.poll): Ditto.
(Popen.init): Ditto.
- Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/subprocess.py:
(Subprocess.CommandRoute.init): Support environment variables.
(Subprocess.CommandRoute.matches): Ditto
(Subprocess.CommandRoute.call): Ditto.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py: Pull title and bugs from
environment variables.
(Branch.main): Pass bug title and URLs to caller via args.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.create_commit): Pass title and bug urls to
git commit.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
Canonical link: https://commits.webkit.org/250263@main
- 12:20 PM Changeset in webkit [293783] by
-
- 4 edits in trunk/Tools
REGRESSION(r287574-r287580): [ iOS ] 3 TestWebKitAPI.WebKitLegacy.* tests are constantly crashing (ScrollingDoesNotPauseMedia, PreemptVideoFullscreen, AudioSessionCategoryIOS)
https://bugs.webkit.org/show_bug.cgi?id=237125>
Unreviewed test gardening. Disabling API-tests for iOS.
- TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitLegacy/ios/PreemptVideoFullscreen.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/250262@main
- 12:03 PM Changeset in webkit [293782] by
-
- 4 edits in trunk/Source/WebKit
Add push service result logging
https://bugs.webkit.org/show_bug.cgi?id=240035
Reviewed by Geoffrey Garen.
This adds logging to make it easier to debug certain errors we have seen internally (e.g.
unexpectedly missing subscriptions and service workers that aren't spawning to service push
events):
- In some cases, it appears that a push event is coming in, but the service worker to handle the event never spawns. This can happen if we think an origin doesn't have permission to show a notification in UIProcess and we bail out early. Currently we don't have logging for this case.
To fix this, I removed the early bail-out in NetworkProcessProxy::processPushMessage
entirely. Instead, we always IPC the message to NetworkProcess::processPushMessage.
This will trigger existing logging around whether a service worker spawns to handle the
push event on the NetworkProcess side. The optimization to not spawn NetworkProcess in
the permission-denied case will not be used in the long run, because we plan to move the
subscription to the ignore list in this case (see the FIXME in
NetworkProcess::processPushMessage), which requires spawning NetworkProcess to message
webpushd anyway.
- For push service requests that produce a result, we additionally log whether or not the result exists (e.g. to know if a push subscription exists or not).
- Add logging for the cases where WebKit explicitly asks webpushd to bulk-remove subscriptions.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::processPushMessage):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::processPushMessage):
- webpushd/PushService.mm:
(WebPushD::PushServiceRequestImpl::fulfill):
(WebPushD::PushService::removeRecordsForBundleIdentifier):
(WebPushD::PushService::removeRecordsForBundleIdentifierAndOrigin):
Canonical link: https://commits.webkit.org/250261@main
- 11:14 AM Changeset in webkit [293781] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r293506): [ iOS ][ macOS ] imported/w3c/web-platform-tests/service-workers/service-worker/registration-updateviacache.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=240074
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
- LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/250260@main
- 10:47 AM Changeset in webkit [293780] by
-
- 3 edits in trunk/Tools
[ews.webkit.org] Hide sensitive content for alternate remotes
https://bugs.webkit.org/show_bug.cgi?id=239988
<rdar://problem/92639150>
Reviewed by Aakash Jain.
- CISupport/ews-build/steps.py:
(ConfigureBuild.add_pr_details): PRs targeting alternate hosts are sensitive.
(DetermineLandedIdentifier.start): Hide step for sensitive PRs.
(AddReviewerToChangeLog.hideStepIf): Ditto.
(ValidateCommitMessage): Implement with steps.ShellSequence
(ValidateCommitMessage.init):
(ValidateCommitMessage.run): Use grep to search for appropriate commit message string and hide
the content of the commit message itself.
(ValidateCommitMessage.start): Logic moved to ValidateCommitMessage.run.
(ValidateCommitMessage.evaluateCommand): Ditto.
- CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/250259@main
- 10:44 AM Changeset in webkit [293779] by
-
- 22 edits in trunk/Source
Use IterationStatus in more places.
https://bugs.webkit.org/show_bug.cgi?id=239864
Reviewed by Saam Barati.
Source/JavaScriptCore:
There's no need for a StackVisitor::Status and a VMInspector::FunctorStatus which
represent the same idea.
- API/JSContextRef.cpp:
(BacktraceFunctor::operator() const):
- bytecode/CodeBlock.cpp:
(JSC::RecursionCheckFunctor::operator() const):
- debugger/DebuggerCallFrame.cpp:
(JSC::LineAndColumnFunctor::operator() const):
- inspector/ScriptCallStackFactory.cpp:
(Inspector::CreateScriptCallStackFunctor::operator() const):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::callerSourceOrigin):
(JSC::CallFrame::globalObjectOfClosestCodeBlock):
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp:
(JSC::GetStackTraceFunctor::operator() const):
(JSC::Interpreter::getStackTrace):
(JSC::GetCatchHandlerFunctor::operator() const):
(JSC::UnwindFunctor::operator() const):
- interpreter/ShadowChicken.cpp:
(JSC::ShadowChicken::update):
- interpreter/StackVisitor.h:
(JSC::StackVisitor::visit):
(JSC::CallerFunctor::operator() const):
- jsc.cpp:
(FunctionJSCStackFunctor::operator() const):
(startTimeoutTimer):
- runtime/Error.cpp:
(JSC::FindFirstCallerFrameWithCodeblockFunctor::operator() const):
- runtime/FunctionPrototype.cpp:
(JSC::RetrieveArgumentsFunctor::operator() const):
(JSC::RetrieveCallerFunctionFunctor::operator() const):
- runtime/JSGlobalObject.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
- runtime/NullSetterFunction.cpp:
(JSC::GetCallerStrictnessFunctor::operator() const):
- tools/HeapVerifier.cpp:
(JSC::HeapVerifier::checkIfRecorded):
- tools/JSDollarVM.cpp:
(JSC::CallerFrameJITTypeFunctor::operator() const):
(JSC::JSC_DEFINE_HOST_FUNCTION):
- tools/VMInspector.cpp:
(JSC::VMInspector::forEachVM):
(JSC::VMInspector::isValidExecutableMemory):
(JSC::VMInspector::codeBlockForMachinePC):
(JSC::VMInspector::codeBlockForFrame):
(JSC::DumpFrameFunctor::operator() const):
(JSC::VMInspector::dumpRegisters):
- tools/VMInspector.h:
(JSC::VMInspector::WTF_REQUIRES_LOCK):
Source/WebCore:
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::callerGlobalObject):
- testing/Internals.cpp:
(WebCore::GetCallerCodeBlockFunctor::operator() const):
- 10:21 AM Changeset in webkit [293778] by
-
- 1 edit in trunk/metadata/contributors.json
Unreviewed, add my GitHub account name to contributors.json
- metadata/contributors.json:
- 10:11 AM Changeset in webkit [293777] by
-
- 2 edits in trunk/LayoutTests
[Rebaseline] REGRESSION (r293038):[ iOS ] fast/forms/auto-fill-button/input-auto-fill-button.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240065
Unreviewed test gardening.
- LayoutTests/platform/ios/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt:
Canonical link: https://commits.webkit.org/250256@main
- 9:24 AM Changeset in webkit [293776] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] fast/css/continuationCrash.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240069
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250255@main
- 8:35 AM Changeset in webkit [293775] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] fast/forms/auto-fill-button/input-auto-fill-button.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240065
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250254@main
- 8:25 AM Changeset in webkit [293774] by
-
- 3 edits in trunk/Tools
[ews-build.webkit.org] Cache contributors by default
https://bugs.webkit.org/show_bug.cgi?id=240040
<rdar://problem/92695239>
Reviewed by Aakash Jain.
On-disk contributor record can get stale quickly. Rely on the network by default.
- Tools/CISupport/ews-build/steps.py:
(GitHub.email_for_owners): Rely on the network contributors.json by default.
(Contributors.load): Force reload contributors every 4 hours. Use disk or remote if specifically
requested, otherwise default to remote. Use cache if not expired.
(ValidateCommitterAndReviewer.start): Rely on the network contributors.json by default.
(AddReviewerMixin.gitCommitEnvironment): Ditto.
(AddAuthorToCommitMessage.author): Ditto.
Canonical link: https://commits.webkit.org/250253@main
- 7:48 AM Changeset in webkit [293773] by
-
- 10 edits1 copy in trunk
[InputElement] Selection after type change needs to follow HTML specification
https://bugs.webkit.org/show_bug.cgi?id=237361
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end-extra-expected.txt:
Source/WebCore:
As per spec at https://html.spec.whatwg.org/multipage/input.html#input-type-change,
following step 7-9, if the previous type doesn't support Selection API and the new type
does, selectionStart and selectionEnd should be 0, selectionDirection should be set to "none".
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::runPostTypeUpdateTasks):
(WebCore::HTMLInputElement::initializeInputType):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::HTMLTextFormControlElement):
LayoutTests:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end-extra-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end-extra-expected.txt.
- platform/mac-wk1/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
- platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
- 7:23 AM Changeset in webkit [293772] by
-
- 2 edits in trunk/Source/WTF
Unreviewed. Remove the build warning below since r293729.
warning: redundant move in return statement [-Wredundant-move]
- wtf/DateMath.cpp:
(WTF::validateTimeZone):
- 3:43 AM Changeset in webkit [293771] by
-
- 8 edits in trunk
[GStreamer] Mediastream mock audio interruption fixes after r290985
https://bugs.webkit.org/show_bug.cgi?id=239926
Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-04
Reviewed by Chris Dumez.
Similarly to mock video sources, the GStreamer mock audio sources are now cached in a
hashset, which is used to dispatch interruption requests.
- platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:
(WebCore::GStreamerAudioCaptureSource::interrupted const): Avoid runtime critical GObject
warnings that would happen if this method is called before the pipeline has been created.
- platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.cpp: Cache mock sources in a hashset.
(WebCore::MockRealtimeAudioSourceGStreamer::~MockRealtimeAudioSourceGStreamer):
- platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.h:
- platform/mock/MockRealtimeAudioSource.cpp: Dispatch interruption requests to currently
cached GStreamer mock audio sources.
(WebCore::MockRealtimeAudioSource::setIsInterrupted):
- platform/mock/MockRealtimeVideoSource.cpp: Switch to MainThreadNeverDestroyed<T> for caching sources.
(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):
(WebCore::MockRealtimeVideoSource::~MockRealtimeVideoSource):
LayoutTests:
- platform/glib/TestExpectations: Unflag mediastream tests now passing.
Canonical link: https://commits.webkit.org/250250@main
- 3:31 AM Changeset in webkit [293770] by
-
- 12 edits in trunk
DisplayList::Recorder has redundant, unused flushContext
https://bugs.webkit.org/show_bug.cgi?id=239999
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-04
Reviewed by Simon Fraser.
Remove DisplayList::Recorder::flushContext(GraphicsContextFlushIdentifier)
It was unused.
Source/WebCore:
"Flush context" is not a display list item. It is a command for the graphics
context, issued a underlying resource is being used outside the graphics context
abstraction. As display list is working inside the abstraction, there's nothing
that could possibly use the underlying resources between flush and the next
item.
GraphicsContextFlushIdentifier cannot possibly be constructed in sensible way
at WebCore level.
- platform/graphics/displaylists/DisplayListItems.h:
- platform/graphics/displaylists/DisplayListRecorder.h:
- platform/graphics/displaylists/DisplayListRecorderImpl.h:
Source/WebKit:
It has wrong signature for proper operation for the concrete classes.
- WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
- 3:12 AM Changeset in webkit [293769] by
-
- 5 edits1 delete in trunk/Source/WebKit
LibWebRTCCodecs does no longer need a pixel conformer
https://bugs.webkit.org/show_bug.cgi?id=240004
Reviewed by Eric Carlson.
Removing no longer used code.
No change of behavior.
Unified build fix.
- SourcesCocoa.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/GPU/webrtc/LibWebRTCCodecs.h:
- WebProcess/GPU/webrtc/LibWebRTCCodecs.mm: Removed.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
- 2:30 AM Changeset in webkit [293768] by
-
- 3 edits in trunk/Source/WTF
[WTF] Initialize emptyString and nullString data at compile time
https://bugs.webkit.org/show_bug.cgi?id=240054
Reviewed by Mark Lam.
As we did for AtomString in r293757, we can initialize emptyString() and nullString()
data at compile time. This patch does that for WTF::String.
- Source/WTF/wtf/text/WTFString.cpp:
(WTF::emptyString): Deleted.
(WTF::nullString): Deleted.
- Source/WTF/wtf/text/WTFString.h:
(WTF::StaticString::StaticString):
(WTF::nullString):
(WTF::emptyString):
Canonical link: https://commits.webkit.org/250247@main
- 2:12 AM Changeset in webkit [293767] by
-
- 4 edits in trunk
Web Inspector: Update jsmin to 3.0.1
https://bugs.webkit.org/show_bug.cgi?id=239924
Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-04
Reviewed by Yusuke Suzuki.
Updated jsmin from upstream version, applying a few style changes suggested by
check-webkit-style. This new version is Python3-only and also much faster. Old:
time python /app/webkit/Source/JavaScriptCore/Scripts/jsmin.py < /app/webkit/WebKitBuild/Release/WebInspectorUI/DerivedSources/Main.js > foo.js
real 1m21.234s
user 0m59.580s
sys 0m21.253s
New:
time python /app/webkit/Source/JavaScriptCore/Scripts/jsmin.py < /app/webkit/WebKitBuild/Release/WebInspectorUI/DerivedSources/Main.js > foo.js
real 0m3.933s
user 0m3.899s
sys 0m0.018s
- Scripts/jsmin.py:
(jsmin):
(JavascriptMinify.init):
(JavascriptMinify.minify.write):
(JavascriptMinify.minify):
(JavascriptMinify):
(JavascriptMinify.regex_literal):
(JavascriptMinify.regex_literal.cannot):
(JavascriptMinify.line_comment):
(JavascriptMinify.block_comment):
(JavascriptMinify.newline):
(JavascriptMinify.minify.read): Deleted.
LayoutTests:
- platform/gtk/inspector/timeline/line-column-expected.txt:
Canonical link: https://commits.webkit.org/250246@main
- 1:33 AM Changeset in webkit [293766] by
-
- 4 edits in trunk/Source
Enable TextCheckingType::Correction on MacCatalyst.
https://bugs.webkit.org/show_bug.cgi?id=240036
Reviewed by Wenson Hsieh.
Add TextCheckingType::Correction to Catalyst to bring consistency to macOS.
Source/WebCore:
- editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markAndReplaceFor):
(WebCore::Editor::resolveTextCheckingTypeMask):
Source/WebKit:
- UIProcess/ios/TextCheckerIOS.mm:
(WebKit::TextChecker::checkTextOfParagraph):
- 1:31 AM Changeset in webkit [293765] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Crash during MediaPlayerPrivateMediaFoundation::removeListener in the async callback thread
https://bugs.webkit.org/show_bug.cgi?id=239485
Reviewed by Don Olmstead.
WinCairo debug layout tests were observing a random crash while
MediaPlayerPrivateMediaFoundation::AsyncCallback was destructing.
m_mediaPlayer was being accessed without locking m_mutex in
~AsyncCallback.
m_mediaPlayer can be replaced with using a WeakPtr.
There is one more multi-threading problem. IMFAsyncCallback should
use InterlockedIncrement and InterlockedDecrement for
ref-counting.
Implementing the Asynchronous Callback - Win32 apps | Microsoft Docs
<https://docs.microsoft.com/en-us/windows/win32/medfound/implementing-the-asynchronous-callback>
This change re-implemented AsyncCallback with a WeakPtr, Function,
QISearch and Interlocked{In,De}crement.
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::AsyncCallback):
(WebCore::beginGetEvent):
(WebCore::MediaPlayerPrivateMediaFoundation::createSession):
(WebCore::MediaPlayerPrivateMediaFoundation::startCreateMediaSource):
(WebCore::MediaPlayerPrivateMediaFoundation::onCreatedMediaSource):
(WebCore::MediaPlayerPrivateMediaFoundation::onNetworkStateChanged):
(WebCore::MediaPlayerPrivateMediaFoundation::endCreatedMediaSource): Deleted.
(WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent): Deleted.
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::~AsyncCallback): Deleted.
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::QueryInterface): Deleted.
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::AddRef): Deleted.
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::Release): Deleted.
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::GetParameters): Deleted.
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::Invoke): Deleted.
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::onMediaPlayerDeleted): Deleted.
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
- 12:14 AM Changeset in webkit [293764] by
-
- 4 edits in trunk/Source/WebKit
RemoteImageBuffer ThreadSafeImageBufferFlusher hangs if GPU process crashes
https://bugs.webkit.org/show_bug.cgi?id=240007
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-04
Reviewed by Geoffrey Garen.
RemoteResourceCacheProxy clears the RemoteImageBuffer backend when the
GPUP is lost. Mark the flush as completed in this case, so that any pending
off-thread flush waits can proceed.
Make sure RemoteResourceCacheProxy clears the backends on destruction too,
so that any pending flushes proceed in this case too.
- WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
- WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
(WebKit::RemoteResourceCacheProxy::~RemoteResourceCacheProxy):
(WebKit::RemoteResourceCacheProxy::clearImageBufferBackends):
(WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed):
- WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:
- 12:02 AM Changeset in webkit [293763] by
-
- 10 edits in trunk
Drop StringImpl::createFromLiteral()
https://bugs.webkit.org/show_bug.cgi?id=239792
Reviewed by Darin Adler.
Drop StringImpl::createFromLiteral().
Call sites that have an ASCIILiteral can now simply call StringImpl::create(ASCIILiteral).
Call sites that have raw characters can call the existing StringImpl::createWithoutCopying().
This simplifies our API a bit.
Also inline part of the createWithoutCopying() functions so that the 0-length check is
inline. This allows the compiler to optimize the check out when the length is known at
compile time (which is often the case with literals).
- Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
- Source/JavaScriptCore/API/JSScriptRef.cpp:
- Source/JavaScriptCore/Scripts/wkbuiltins/builtins_templates.py:
- Source/JavaScriptCore/builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::BuiltinExecutables):
- Source/JavaScriptCore/runtime/IntlObject.cpp:
(JSC::availableUnits):
- Source/WTF/wtf/text/StringImpl.cpp:
(WTF::StringImpl::createWithoutCopyingNonEmpty):
(WTF::StringImpl::createFromLiteral): Deleted.
(WTF::StringImpl::createWithoutCopying): Deleted.
- Source/WTF/wtf/text/StringImpl.h:
(WTF::StringImpl::create):
(WTF::StringImpl::createWithoutCopying):
(WTF::StringImpl::createFromLiteral): Deleted.
- Source/WTF/wtf/text/WTFString.h:
(WTF::String::String):
- Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
Canonical link: https://commits.webkit.org/250242@main
May 3, 2022:
- 11:25 PM Changeset in webkit [293762] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp
REGRESSION(r293285): ASSERTION FAILED: m_isConstructed /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/WebKitBuild/Debug/usr/local/include/wtf/NeverDestroyed.h(152) : ..... [T = const WTF::AtomString, AccessTraits = WTF::MainThreadAccessTraits]
https://bugs.webkit.org/show_bug.cgi?id=240051
Reviewed by Yusuke Suzuki.
Make sure the tests initialize CommonAtomStrings since the implementation being tested seems
to rely on them.
- Tools/TestWebKitAPI/Tests/WebCore/DocumentOrder.cpp:
(TestWebKitAPI::createDocument):
Canonical link: https://commits.webkit.org/250241@main
- 11:19 PM Changeset in webkit [293761] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm
REGRESSION(r293703):[ BigSur+ iOS ] TestWTF.WTF_URLExtras.URLExtras_ParsingError (API-Test) is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=240049
Reviewed by Yusuke Suzuki.
We need to pass the length of the string, which is the number of characters without the null terminator.
However, we were passing utf16.size(), which was one too many since the utf16 array contains the null
terminator at the end.
- Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/250239@main
- 11:18 PM Changeset in webkit [293760] by
-
- 15 edits in trunk/Source
Replace String::remove() by a makeStringByRemoving() free function
https://bugs.webkit.org/show_bug.cgi?id=239995
Reviewed by Yusuke Suzuki.
Replace String::remove() by a makeStringByRemoving() free function. This is a
step towards making String immutable.
- Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::lastCNAMEDomain):
- Source/WebKit/UIProcess/Inspector/win/InspectorResourceURLSchemeHandler.cpp:
(WebKit::InspectorResourceURLSchemeHandler::platformStartTask):
- Source/WTF/wtf/URL.cpp:
(WTF::URL::remove):
- Source/WTF/wtf/text/WTFString.cpp:
(WTF::makeStringByRemoving):
(WTF::String::removeInternal): Deleted.
(WTF::String::remove): Deleted.
- Source/WTF/wtf/text/WTFString.h:
- Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp:
(WebCore::RTCDTMFSender::playNextTone):
- Source/WebCore/dom/CharacterData.cpp:
(WebCore::CharacterData::deleteData):
- Source/WebCore/dom/FragmentDirectiveParser.cpp:
(WebCore::FragmentDirectiveParser::parseFragmentDirective):
- Source/WebCore/dom/Range.cpp:
(WebCore::processContentsBetweenOffsets):
- Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::deleteInsignificantText):
- Source/WebCore/inspector/InspectorOverlayLabel.cpp:
(WebCore::InspectorOverlayLabel::draw):
- Source/WebCore/inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::deleteRule):
- Source/WebCore/platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp:
(WebCore::GStreamerMediaDescription::extractCodecName):
- Source/WebCore/platform/network/curl/CookieJarDB.cpp:
(WebCore::CookieJarDB::deleteCookie):
- Source/WebCore/platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::shortTimeFormat):
Canonical link: https://commits.webkit.org/250239@main
- 11:14 PM Changeset in webkit [293759] by
-
- 3 edits in trunk/Source/JavaScriptCore
[RISCV64] Implement MacroAssemblerRISCV64 move-conditionally methods
https://bugs.webkit.org/show_bug.cgi?id=239998
Reviewed by Yusuke Suzuki.
Provide implementations for the variants of the move-conditionally
operation in MacroAssemblerRISCV64. These are true macro operations,
often requiring scratch registers and branches to implement the
behavior since the RISC-V ISA doesn't provide appropriate instructions
out-of-the-box.
Test cases in testmasm are also enabled, including some additional
guards to avoid unused-variable warnings at build-time.
- assembler/MacroAssemblerRISCV64.h:
(JSC::MacroAssemblerRISCV64::moveConditionally32):
(JSC::MacroAssemblerRISCV64::moveConditionally64):
(JSC::MacroAssemblerRISCV64::moveConditionallyFloat):
(JSC::MacroAssemblerRISCV64::moveConditionallyDouble):
(JSC::MacroAssemblerRISCV64::moveConditionallyTest32):
(JSC::MacroAssemblerRISCV64::moveConditionallyTest64):
(JSC::MacroAssemblerRISCV64::moveDoubleConditionally32):
(JSC::MacroAssemblerRISCV64::moveDoubleConditionally64):
(JSC::MacroAssemblerRISCV64::moveDoubleConditionallyFloat):
(JSC::MacroAssemblerRISCV64::moveDoubleConditionallyDouble):
(JSC::MacroAssemblerRISCV64::moveDoubleConditionallyTest32):
(JSC::MacroAssemblerRISCV64::moveDoubleConditionallyTest64):
(JSC::MacroAssemblerRISCV64::branchForMoveConditionally):
- assembler/testmasm.cpp:
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackValues):
- 8:17 PM Changeset in webkit [293758] by
-
- 5 edits in trunk/Source/WebKit
Add logging related to Launch Services database
https://bugs.webkit.org/show_bug.cgi?id=240032
Reviewed by Geoffrey Garen.
We have reports indicating that it can sometime take unexpectedly long time for the Network process to provide
the Launch Services database to the WebContent and GPU process. Add some logging to help diagnose the issue.
There are also some related selector response checks that can be removed now.
- NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm:
(WebKit::LaunchServicesDatabaseObserver::LaunchServicesDatabaseObserver):
(WebKit::LaunchServicesDatabaseObserver::startObserving):
(WebKit::LaunchServicesDatabaseObserver::~LaunchServicesDatabaseObserver):
(WebKit::databaseContext): Deleted.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::didFinishLaunching):
- UIProcess/Network/NetworkProcessProxyCocoa.mm:
(WebKit::NetworkProcessProxy::sendXPCEndpointToProcess):
- WebProcess/cocoa/LaunchServicesDatabaseManager.mm:
(WebKit::LaunchServicesDatabaseManager::handleEvent):
- 7:27 PM Changeset in webkit [293757] by
-
- 9 edits in trunk/Source
[JSC] Initialize empty and null AtomString at compile time
https://bugs.webkit.org/show_bug.cgi?id=240031
Reviewed by Mark Lam.
Because they are initialized from static data, we can just initialize them
at compile time, and we do not need to haveAtomString::init.
- Source/WebKit/WebAuthnProcess/WebAuthnProcess.cpp:
(WebKit::WebAuthnProcess::initializeWebAuthnProcess):
- Source/WTF/wtf/Threading.cpp:
(WTF::initialize):
- Source/WTF/wtf/text/AtomString.cpp:
(WTF::AtomString::init): Deleted.
- Source/WTF/wtf/text/AtomString.h:
(WTF::StaticAtomString::StaticAtomString):
(WTF::nullAtom):
(WTF::emptyAtom):
- Source/WebCore/dom/make_names.pl:
(printInit):
Canonical link: https://commits.webkit.org/250236@main
- 6:44 PM Changeset in webkit [293756] by
-
- 2 edits in trunk/LayoutTests
webgl/1.0.3/conformance/state/gl-object-get-calls.html times out after turning WebGL in GPUP on by default
https://bugs.webkit.org/show_bug.cgi?id=238691
<rdar://problem/91191670>
Unreviewed test gardening.
Patch by Dan Glastonbury <djg@apple.com> on 2022-05-03
- webgl/TestExpectations:
- 5:40 PM Changeset in webkit [293755] by
-
- 1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 143
Added a tag for Safari Technology Preview release 143.
- 5:40 PM Changeset in webkit [293754] by
-
- 1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 132
Added a tag for Safari Technology Preview release 132.
- 5:39 PM Changeset in webkit [293753] by
-
- 1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 131
Added a tag for Safari Technology Preview release 131.
- 5:39 PM Changeset in webkit [293752] by
-
- 1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 130
Added a tag for Safari Technology Preview release 130.
- 5:37 PM Changeset in webkit [293751] by
-
- 1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 129
Added a tag for Safari Technology Preview release 129.
- 5:37 PM Changeset in webkit [293750] by
-
- 1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 128
Added a tag for Safari Technology Preview release 128.
- 5:36 PM Changeset in webkit [293749] by
-
- 1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 127
Added a tag for Safari Technology Preview release 127.
- 5:36 PM Changeset in webkit [293748] by
-
- 1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 126
Added a tag for Safari Technology Preview release 126.
- 5:36 PM Changeset in webkit [293747] by
-
- 1 copy in releases/Apple/Safari Technology Preview/Safari Technology Preview 125
Added a tag for Safari Technology Preview release 125.
- 4:27 PM Changeset in webkit [293746] by
-
- 7 edits in trunk/Source/JavaScriptCore
[JSC] Extend Structure heap size from 1GB to 4GB
https://bugs.webkit.org/show_bug.cgi?id=240028
Reviewed by Saam Barati.
1GB was much smaller compared to StructureIDTable (which allowed 7GB).
This patch extends 1GB to 4GB, that's maximum limit of the current encoding scheme (we can
extend it further to 64GB if we introduce shift based on alignment, but currently not used).
We use this 4GB on platforms which has enough virtual address space.
- Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
- Source/JavaScriptCore/jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitNonNullDecodeStructureID):
- Source/JavaScriptCore/runtime/JSCConfig.h:
Canonical link: https://commits.webkit.org/250234@main
- 4:02 PM Changeset in webkit [293745] by
-
- 2 edits in trunk/LayoutTests
Some layout tests are failing on EWS but not post commit testing due to a OS difference
https://bugs.webkit.org/show_bug.cgi?id=239564
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250233@main
- 3:55 PM Changeset in webkit [293744] by
-
- 5 edits in trunk/Source/WebKit
Unreviewed, reverting r293743.
https://bugs.webkit.org/show_bug.cgi?id=240042
Introduced debug assert
Reverted changeset:
"Add logging related to Launch Services database"
https://bugs.webkit.org/show_bug.cgi?id=240032
https://commits.webkit.org/r293743
- 3:23 PM Changeset in webkit [293743] by
-
- 5 edits in trunk/Source/WebKit
Add logging related to Launch Services database
https://bugs.webkit.org/show_bug.cgi?id=240032
Reviewed by Geoffrey Garen.
We have reports indicating that it can sometime take unexpectedly long time for the Network process to provide
the Launch Services database to the WebContent and GPU process. Add some logging to help diagnose the issue.
There are also some related selector response checks that can be removed now.
- NetworkProcess/cocoa/LaunchServicesDatabaseObserver.mm:
(WebKit::LaunchServicesDatabaseObserver::LaunchServicesDatabaseObserver):
(WebKit::LaunchServicesDatabaseObserver::startObserving):
(WebKit::LaunchServicesDatabaseObserver::~LaunchServicesDatabaseObserver):
(WebKit::databaseContext): Deleted.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::didFinishLaunching):
- UIProcess/Network/NetworkProcessProxyCocoa.mm:
(WebKit::NetworkProcessProxy::sendXPCEndpointToProcess):
- WebProcess/cocoa/LaunchServicesDatabaseManager.mm:
(WebKit::LaunchServicesDatabaseManager::handleEvent):
- 3:10 PM Changeset in webkit [293742] by
-
- 3 edits in trunk/LayoutTests
[macOS] Make a couple of grammar checking tests more robust to system spell checker changes
https://bugs.webkit.org/show_bug.cgi?id=240034
rdar://92689657
Reviewed by Aditya Keerthi.
In some versions of macOS, feeding the following sentence to NSSpellChecker:
"the the adlj adaasj sdklj. there there"
...no longer yields grammar errors at "the the" and "there there", due to presence of duplicated "the" and
"there", which causes a couple of layout tests to time out.
This patch works around the system changes by swizzling out spell checking results, such that we don't need to
rely on the default NSSpellChecker always tagging "the the" and "there there" as grammar errors.
- editing/spelling/inline-spelling-markers-hidpi.html:
- editing/spelling/inline-spelling-markers.html:
Canonical link: https://commits.webkit.org/250230@main
- 2:55 PM Changeset in webkit [293741] by
-
- 3 edits in trunk/LayoutTests
Rebase fast/forms/select-list-box-with-height.html and fast/forms/control-restrict-line-height.html
https://bugs.webkit.org/show_bug.cgi?id=240039
Unreviewed test gardening.
- LayoutTests/platform/ios/fast/forms/control-restrict-line-height-expected.txt:
- LayoutTests/platform/ios/fast/forms/select-list-box-with-height-expected.txt:
Canonical link: https://commits.webkit.org/250229@main
- 2:22 PM Changeset in webkit [293740] by
-
- 2 edits1 delete in trunk/LayoutTests
Fix rebase from 250225@main
https://bugs.webkit.org/show_bug.cgi?id=239569
Unreviewed test gardening.
- LayoutTests/platform/ios/tables/mozilla/bugs/bug2479-3-expected.txt:
- LayoutTests/tables/mozilla/bugs/bug2479-3-expected.txt: Removed.
Canonical link: https://commits.webkit.org/250228@main
- 2:18 PM Changeset in webkit [293739] by
-
- 2 edits in trunk/LayoutTests
[ iOS ] css3/background/background-repeat-space-content.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=240037
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250227@main
- 2:01 PM Changeset in webkit [293738] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r293427): [ iOS ] http/tests/quicklook/same-origin-xmlhttprequest-allowed.html is a constant failure and crash
https://bugs.webkit.org/show_bug.cgi?id=240024
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
Canonical link: https://commits.webkit.org/250226@main
- 1:54 PM Changeset in webkit [293737] by
-
- 1 edit1 add in trunk/LayoutTests
Rebase tables/mozilla/bugs/bug2479-3.html
https://bugs.webkit.org/show_bug.cgi?id=239569
Unreviewed test gardening.
- LayoutTests/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
Canonical link: https://commits.webkit.org/250225@main
- 1:18 PM Changeset in webkit [293736] by
-
- 3 edits3 adds in trunk
StorageMap::removeItem may fail to remove item from map
https://bugs.webkit.org/show_bug.cgi?id=239982
rdar://80891555
Reviewed by Chris Dumez.
Source/WebCore:
We may have updated m_impl, but we don't update iterator for removal. In this case, item is not removed from
map, but currentSize is updated. The mismatch between currentSize and actual size of the map may lead to
underflow and overflow in currentSize when item is added or removed later.
Test: storage/domstorage/sessionstorage/window-open-remove-item.html
- storage/StorageMap.cpp:
(WebCore::StorageMap::removeItem):
LayoutTests:
- storage/domstorage/sessionstorage/resources/window-open-remove-item.html: Added.
- storage/domstorage/sessionstorage/window-open-remove-item-expected.txt: Added.
- storage/domstorage/sessionstorage/window-open-remove-item.html: Added.
- 12:15 PM Changeset in webkit [293735] by
-
- 7 edits in trunk
REGRESSION (r293703): 358 JSC tests failing
https://bugs.webkit.org/show_bug.cgi?id=240023
Reviewed by Yusuke Suzuki.
Make sure WTF::initialize() calls AtomString::init() given that JSC now relies on
emptyAtom().
- Tools/TestWebKitAPI/TestsController.cpp:
(TestWebKitAPI::TestsController::TestsController):
- Source/WTF/wtf/Threading.cpp:
(WTF::initialize):
- Source/WTF/wtf/text/AtomString.cpp:
(WTF::AtomString::init):
- Source/WebCore/platform/CommonAtomStrings.cpp:
(WebCore::initializeCommonAtomStrings):
Canonical link: https://commits.webkit.org/250223@main
- 11:47 AM Changeset in webkit [293734] by
-
- 2 edits in trunk/Source/WebKit
[iOS][WP] Only block IOKit access if all GPUP features are enabled
https://bugs.webkit.org/show_bug.cgi?id=240010
Reviewed by Tim Horton.
Only block IOKit access in the WebContent process' sandbox on iOS if all GPUP features are enabled.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_appHighlightsVisible):
- 11:25 AM Changeset in webkit [293733] by
-
- 5 edits in trunk/Source/WebKit
[iOS][GPUP] Remove Mach sandbox extensions for non browser clients
https://bugs.webkit.org/show_bug.cgi?id=240008
Reviewed by Geoffrey Garen.
Remove Mach sandbox extensions for clients that are not browsers in the GPU process on iOS. The same set of extensions
has recently been removed from the WebContent process. We also block these in the GPU process' sandbox, so there should
be no change in behavior.
- GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::initializeGPUProcess):
- GPUProcess/GPUProcessCreationParameters.cpp:
(WebKit::GPUProcessCreationParameters::encode const):
(WebKit::GPUProcessCreationParameters::decode):
- GPUProcess/GPUProcessCreationParameters.h:
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::GPUProcessProxy):
(WebKit::nonBrowserServices): Deleted.
- 11:23 AM Changeset in webkit [293732] by
-
- 2 edits in trunk/Source/WebKit
[iOS][WP] Remove obsolete message filter
https://bugs.webkit.org/show_bug.cgi?id=240012
Reviewed by Geoffrey Garen.
Remove obsolete message filter in the WebContent process on iOS. This filtering is now enabled by the
GPU restricted entitlement we have added for the WebContent process.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
- 11:06 AM Changeset in webkit [293731] by
-
- 5 edits in trunk/LayoutTests
[ Test Gardening ] Batch remove expectations no longer needed
https://bugs.webkit.org/show_bug.cgi?id=240021
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/250219@main
- 10:37 AM Changeset in webkit [293730] by
-
- 3 edits in trunk/Source/WebKit
[iOS] The "Copy Cropped Image" context menu action should be gated on cropped image results
https://bugs.webkit.org/show_bug.cgi?id=240013
rdar://88941787
Reviewed by Tim Horton.
Only show this item in the context menu when long pressing in the case where
requestImageAnalysisMarkup
computes a non-null result for the given image bitmap. This gating logic runs alongside existing gating logic
for both the visual search item ("Look Up") and "Show Text" actions. See below for more details.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _setUpImageAnalysis]):
(-[WKContentView _tearDownImageAnalysis]):
Introduce a
_croppedImageResultivar to cache the CGImage result after running image analysis over the image
corresponding to the element for which we're showing the context menu. This is reset in the same lifecycle as
the extant_hasVisualSearchResultsand_hasSelectableTextInImageflags which are used for the same purpose.
(-[WKContentView imageAnalysisGestureDidBegin:]):
(-[WKContentView _completeImageAnalysisRequestForContextMenu:requestIdentifier:hasTextResults:]):
This is the codepath that currently prevents us from showing the context menu until we know whether or not there
are relevant visual search results, such that we can conditionally show the "Look Up" context menu item. Adjust
this so that it calls-_invokeAllActionsToPerformAfterPendingImageAnalysis:only after we've also determined
whether or not there is a non-null cropped image result, so that we can also conditionally show the "Copy
Cropped Image" item.
To achieve this, we move the call to
-_invokeAllActionsToPerformAfterPendingImageAnalysis:into a
WTF::CallbackAggregator, and ref/deref the aggregator when invoking both of the async image analysis
operations. When the callback aggregator is destroyed (i.e., after both async image analysis operations are
complete), we proceed with showing the context menu.
(-[WKContentView imageAnalysisGestureDidTimeOut:]):
Implement similar logic as above, but for the scenario where we show the context menu after the user continues
to long press after selecting text inside of an image.
(-[WKContentView actionSheetAssistantShouldIncludeCopyCroppedImageAction:]):
Only show the item if
_croppedImageResultis non-null.
(-[WKContentView actionSheetAssistant:copyCroppedImage:sourceMIMEType:]):
Instead of running image analysis and writing the resulting image to the clipboard, simply transcode the cached
image in_croppedImageResult.
Canonical link: https://commits.webkit.org/250218@main
- 10:06 AM Changeset in webkit [293729] by
-
- 29 edits1 add in trunk
[WK2] Add API to allow embedder to set a timezone override
https://bugs.webkit.org/show_bug.cgi?id=213884
Source/JavaScriptCore:
Reviewed by Yusuke Suzuki.
- runtime/DateConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
- runtime/DateConversion.cpp:
(JSC::formatDateTime): Format the overridden timezone if it's enabled.
- runtime/DateConversion.h:
- runtime/DatePrototype.cpp:
(JSC::formateDateInstance):
- runtime/JSDateMath.cpp:
(JSC::toICUTimeZone):
(JSC::toOpaqueICUTimeZone):
(JSC::OpaqueICUTimeZoneDeleter::operator()):
(JSC::DateCache::calculateLocalTimeOffset):
(JSC::DateCache::defaultTimeZone):
(JSC::DateCache::timeZoneDisplayNameOverride):
(JSC::DateCache::timeZoneCacheSlow): Apply timezone override if it is set.
(JSC::DateCache::resetIfNecessary):
- runtime/JSDateMath.h:
Source/WebKit:
Reviewed by Yusuke Suzuki.
This patch adds:
- new Cocoa API
- new Glib API (targetting both WPE and GTK ports)
- new C API (for the win port)
that allows the embedder to set a timezone override for the underlying PageConfiguration.
Since this API is not exposed in glib ports, a new contruct-time-only property was added to
the WebKitWebContext API. It would also allow fine-grained control over multiple pages, for
instance it's not possible currently to have two pages in different timezones.
No new layout tests, this change is covered by new API tests.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/API/APIProcessPoolConfiguration.cpp:
(API::ProcessPoolConfiguration::copy):
- UIProcess/API/APIProcessPoolConfiguration.h:
- UIProcess/API/C/WKContextConfigurationRef.cpp:
(WKContextConfigurationCopyTimeZoneOverride):
(WKContextConfigurationSetTimeZoneOverride):
- UIProcess/API/C/WKContextConfigurationRef.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
- UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
(-[_WKProcessPoolConfiguration timeZoneOverride]):
(-[_WKProcessPoolConfiguration setTimeZoneOverride:]):
- UIProcess/API/glib/WebKitWebContext.cpp:
(webkitWebContextGetProperty):
(webkitWebContextSetProperty):
(webkitWebContextConstructed):
(webkit_web_context_class_init):
(webkit_web_context_set_time_zone_override):
(webkit_web_context_get_time_zone_override):
- UIProcess/API/gtk/WebKitWebContext.h:
- UIProcess/API/wpe/WebKitWebContext.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Apply timezone override if any on process start.
Source/WTF:
Reviewed by Yusuke Suzuki.
- wtf/DateMath.cpp: New APIs to control and query the timezone override.
(WTF::innerTimeZoneOverride): Static storage of the override informations.
(WTF::WTF_REQUIRES_LOCK):
(WTF::validateTimeZone): New function allowing to check if a timezone identifier is valid according to ICU's database and covert it
to UChar buffer suitable for passing to ucal.
(WTF::isTimeZoneValid):
(WTF::setTimeZoneOverride): New API to set the timezone override, this is meant to be
used on newly created WebProcesses. In addition to providing alternative name for the code
that calls into ICU library, on POSIX systems writes new timezone to "TZ" environement
variable to adjust result of strftime (called in formatDateTime).
(WTF::getTimeZoneOverride): Query the timezone override.
- wtf/DateMath.h:
Tools:
Reviewed by Yusuke Suzuki.
Add API tests for the timezone configuration API. The GTK and WPE MiniBrowsers also gained
new runtime options allowing to exercise this new API.
- MiniBrowser/gtk/main.c:
(activate):
- MiniBrowser/wpe/main.cpp:
(main):
- TestWebKitAPI/SourcesCocoa.txt:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/TimeZoneOverride.mm: Added.
(TimeZoneOverrideTest::runScriptAndExecuteCallback):
(TimeZoneOverrideTest::callAsyncFunctionBody):
(TEST_F):
- TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
(testWebContextTimeZoneOverride):
(testWebContextTimeZoneOverrideInWorker):
(beforeAll):
- TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
(main):
- TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
(runJavaScriptReadyCallback):
(WebViewTest::runJavaScriptAndWaitUntilFinished):
- TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
- flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):
- 9:09 AM Changeset in webkit [293728] by
-
- 2 edits in trunk/Source/WebCore
Fix buggy assert in CoreAudioSharedUnit::configureSpeakerProc
https://bugs.webkit.org/show_bug.cgi?id=240001
Reviewed by Eric Carlson.
Manually tested.
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
Initialize the sampleRate field before using it.
- 9:02 AM Changeset in webkit [293727] by
-
- 7 edits in trunk
Web Inspector: Importing a timeline leaves timeline overview non-scrollable/non-zoomable until windows is resized
https://bugs.webkit.org/show_bug.cgi?id=239880
Reviewed by Devin Rousso.
Source/WebInspectorUI:
Cancelling an in-progress layout (or the layout of a child of a view in middle of laying out) led to
_dirtyDescendantsCountbeing in an inconsistent state. Views had their_dirtyDescendantsCountcleared before
they are laid out, so every non-zero_dirtyDescendantsCountof a view in the process of being laid out meant
that during layoutneedsLayout()was called to dirty that view or one of its children. In this case, a
previous cancellation meant that the TimelineOverview ended up in an inconsistent state where its parent view
tree was not aware that it needed layout because it reached a zero_dirtyDescendantsCountwhile walking down
the view hierarchy, which meant that the TimelineOverview was perpetually stuck until the entire view hierarchy
needed re-laid out due to a window resize or similar event.
Our current accounting for
_dirtyDescendantsCountin View makes assumptions that are not always true during
layout. Specifically that parents of views undergoing layout will have a non-zero_dirtyDescendantsCountstill
from which to subtract in_cancelScheduledLayoutForView. This wasn't always true because as soon as we began
laying out a parent view, we cleared both the_dirtyflag as well as zeroed out_dirtyDescendantsCount. In
the case of cancelling a layout from within a layout, the cancellation wouldn't actually take effect anyways,
and sincecancelLayoutwas only ever invoked fromupdateLayout, the relevant layout flags should instead be
cleared as part of actually performing the layout.cancelLayoutat most saved us a rAF callback only to
realize we no longer have any views in need of layout, but this benefit was negligible, and in general we should
prefer not to be callingupdateLayoutfor performance reasons anyways.
This patch improves the accounting around
_dirtyDescendantsCount, making sure to decrement it as we perform
layout, instead of all at once. This reduces our reliance on assumptions about who will modify the
_dirtyDescendantsCountand at what times relative to layout.
The only time in this patch that we do not do a +1/-1 adjustment to the layout count is in the special case of
attaching/detaching a view. In that case, the parent tree from which we are detaching the view will have the
_dirtyDescendantsCountof the detached parent adjusted by the_dirtyDescendantsCountof the former child
view. This is done by_setSelfAndDescendantsNotDirty, which allows us to avoid an exponential walking of the
tree for this otherwise self-contained operation (we don't call into any overridable functions that could modify
the_dirtyflag or_dirtyDescendantsCount).
After we have cleaned up the former parent branch of the tree, we mark the newly attached view as needing
layout, which will then ensure the child view gets laid out again by marking it asdirtyand incrementing its
new parent branch of the tree's_dirtyDescendantsCount.
- UserInterface/Views/View.js:
(WI.View.prototype.insertSubviewBefore):
- Add assertion that the view is not currently a child of a different view in addition to the existing check
that a view is not already a child of the target view.
(WI.View.prototype._setDirty):
- New utility method through which (almost) all marking of dirty/not dirty should be done in order to ensure
that
_dirtyDescendantsCountis correctly adjusted.
(WI.View.prototype._didMoveToParent):
- Mark the view and all subviews as not dirty before removing it from its previous parent in order to adjust
_dirtyDescendantsCountappropriately, and then mark the view as dirty once attached to its new parent.
- Inline the logic from WI.View.prototype._didMoveToWindow in order to also handle marking children as not dirty
and having a zeroed
_dirtyDescendantsCount.
- This method contains the exception to the rule that _dirtyDescendantsCount is always incremented/decremented
by one. Here we are able to optimize away the need to walk the entire parent tree for each subview/subviews of
subviews/etc. because the operation takes place all at once with no overridable function being called where we
have to worry about mutations to_dirty/_dirtyDescendantsCount.
(WI.View.prototype._layoutSubtree):
(WI.View._visitViewTreeForLayout):
- Don't zero out the
_dirtyDescendantsCount, and instead use the new_setDirtyhelper.
(WI.View._scheduleLayoutForView):
- Don't zero out the
_dirtyDescendantsCount, and instead use the new_setDirtyhelper. - Mark the view as dirty after checking if its attached a view so that detached views have no dirty state until
they are attached, at which point the root of the previous detached subtree will be marked as dirty.
- Drive-by change to use a for-loop instead of a while-loop to avoid
Array.prototype.shift().
(WI.View.prototype.updateLayout):
(WI.View.prototype.cancelLayout): Deleted.
(WI.View._cancelScheduledLayoutForView): Deleted.
- Remove the concept of "canceling" layout, since it is only used by
updateLayout, and the call to
_layoutSubtreeinupdateLayoutwill cause the view, dirty or not, to be marked as not dirty.
LayoutTests:
- inspector/view/asynchronous-layout-expected.txt:
- inspector/view/asynchronous-layout.html:
- Added test case for calls to
updateLayout()during asynchronouslayout(). - Remove test case for removed
View.prototype.cancelLayout.
- inspector/view/basics-expected.txt:
- inspector/view/basics.html:
- Added test case to verify that
_dirtyDescendantsCountis an expected value at various points of
attaching/detaching views.
- 9:00 AM Changeset in webkit [293726] by
-
- 2 edits in trunk/Source/WebCore
AudioMediaStreamTrackRendererUnit::updateRenderSourcesIfNecessary can free memory
https://bugs.webkit.org/show_bug.cgi?id=240002
Reviewed by Eric Carlson.
Manually tested.
- platform/mediastream/cocoa/AudioMediaStreamTrackRendererUnit.cpp:
Overwriting the source vector may lead to freeing AudioSampleDataSources.
This is ok as this happens rarely, add DisableMallocRestrictionsForCurrentThreadScope for that purpose.
- 8:45 AM Changeset in webkit [293725] by
-
- 6 edits2 adds in trunk
[CSS Cascade Layers] Endless recursion with revert-layer in other tree context
https://bugs.webkit.org/show_bug.cgi?id=239967
<rdar://92449950>
Reviewed by Alan Bujtas.
Source/WebCore:
We should only revert within a tree context (scope).
Adding more comprehensive WPTs separately.
Test: fast/css/revert-layer-tree-context-stack-overflow.html
- style/PropertyCascade.cpp:
(WebCore::Style::PropertyCascade::PropertyCascade):
Pass the property tree scope to the rollback cascade.
(WebCore::Style::PropertyCascade::addMatch):
Don't include properties from lower priority tree scopes to rollback cascade.
Reverse the logic for clarity.
- style/PropertyCascade.h:
(WebCore::Style::PropertyCascade::PropertyCascade):
- style/StyleBuilder.cpp:
(WebCore::Style::Builder::ensureRollbackCascadeForRevert):
(WebCore::Style::Builder::ensureRollbackCascadeForRevertLayer):
(WebCore::Style::Builder::makeRollbackCascadeKey):
Include tree scope to the key.
- style/StyleBuilder.h:
LayoutTests:
- fast/css/revert-layer-tree-context-stack-overflow-expected.html: Added.
- fast/css/revert-layer-tree-context-stack-overflow.html: Added.
- 7:31 AM Changeset in webkit [293724] by
-
- 3 edits in trunk/Source/WebInspectorUI
WebInspectorUI is missing a symlink to system content path
https://bugs.webkit.org/show_bug.cgi?id=239971
Reviewed by Alexey Proskuryakov.
Enabled script execution for install headers phase.
Added checks to run Copy User Interface Resources script only during the install phase.
- Configurations/WebInspectorUIFramework.xcconfig:
- WebInspectorUI.xcodeproj/project.pbxproj:
- 7:16 AM Changeset in webkit [293723] by
-
- 28 edits2 adds in trunk
IPC stream connection sends should fail immediately when connection closes
https://bugs.webkit.org/show_bug.cgi?id=238253
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-05-03
Reviewed by Simon Fraser.
Source/WebKit:
Send the StreamClientConnection client wait semaphore from
StreamServerConnection. This way the client will fail the wait
when the server crashes.
Test: ipc/stream-sync-crash-no-timeout.html
- GPUProcess/graphics/RemoteGraphicsContextGL.cpp:
(WebKit::RemoteGraphicsContextGL::workQueueInitialize):
- GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::startListeningForIPC):
- GPUProcess/graphics/WebGPU/RemoteGPU.cpp:
(WebKit::RemoteGPU::workQueueInitialize):
- Platform/IPC/StreamClientConnection.cpp:
(IPC::StreamClientConnection::setSemaphores):
(IPC::StreamClientConnection::wakeUpServer):
- Platform/IPC/StreamClientConnection.h:
(IPC::StreamClientConnection::tryAcquire):
(IPC::StreamClientConnection::tryAcquireAll):
- Platform/IPC/StreamConnectionBuffer.cpp:
(IPC::StreamConnectionBuffer::StreamConnectionBuffer):
(IPC::StreamConnectionBuffer::operator=):
(IPC::StreamConnectionBuffer::encode const):
(IPC::StreamConnectionBuffer::decode):
- Platform/IPC/StreamConnectionBuffer.h:
(IPC::StreamConnectionBuffer::dataSize const):
- Platform/IPC/StreamServerConnection.cpp:
(IPC::StreamServerConnection::release):
(IPC::StreamServerConnection::releaseAll):
- Platform/IPC/StreamServerConnection.h:
- Shared/IPCStreamTester.cpp:
(WebKit::IPCStreamTester::initialize):
(WebKit::IPCStreamTester::syncCrashOnZero):
- Shared/IPCStreamTester.h:
- Shared/IPCStreamTester.messages.in:
- Shared/IPCStreamTesterProxy.h:
- Shared/IPCStreamTesterProxy.messages.in:
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
(WebKit::RemoteGraphicsContextGLProxy::wasCreated):
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
- WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.messages.in:
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::streamConnection):
(WebKit::RemoteRenderingBackendProxy::didInitialize):
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
- WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in:
- WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp:
(WebKit::RemoteGPUProxy::wasCreated):
- WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h:
- WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.messages.in:
- WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSIPCStreamClientConnection::setSemaphores):
(WebKit::IPCTestingAPI::JSIPCStreamClientConnection::staticFunctions):
(WebKit::IPCTestingAPI::JSIPCStreamClientConnection::sendIPCStreamTesterSyncCrashOnZero):
LayoutTests:
The test works on minibrowser but GPUP startup code fails in run-webkit-tests,
thus disabled.
- TestExpectations:
- ipc/stream-sync-crash-no-timeout-expected.txt: Added.
- ipc/stream-sync-crash-no-timeout.html: Added.
- ipc/stream-sync-reply-shared-memory.html: Adjust after API change.
- 6:42 AM Changeset in webkit [293722] by
-
- 2 edits in trunk/JSTests
Skip test currently failing on ARM
https://bugs.webkit.org/show_bug.cgi?id=240005
Unreviewed gardening.
- stress/exception-in-to-property-key-should-be-handled-early.js:
- 1:17 AM Changeset in webkit [293721] by
-
- 9 edits in trunk/Source
Versioning.
WebKit-7614.1.13
- 1:07 AM Changeset in webkit [293720] by
-
- 1 copy in branches/safari-7614.1.12-branch
New branch.
- 1:06 AM Changeset in webkit [293719] by
-
- 6 edits in trunk
ServiceWorkerRegistration update should fail if called from an installing service worker context
https://bugs.webkit.org/show_bug.cgi?id=239962
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/update-not-allowed.https-expected.txt:
Source/WebCore:
Implement step 4 of https://w3c.github.io/ServiceWorker/#service-worker-registration-update.
Covered by rebased test.
- workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::update):
LayoutTests:
- 12:47 AM Changeset in webkit [293718] by
-
- 3 edits in trunk/Source/WebGPU
[WebGPU] Device creation should not always fail if supported features are requested
https://bugs.webkit.org/show_bug.cgi?id=239955
Reviewed by Kimmo Kinnunen.
Somehow a block of code was remaining from before we implemented optional features.
Test: webgpu/api/validation/createTexture
- WebGPU/Adapter.mm:
(WebGPU::Adapter::requestDevice):
- WebGPU/Instance.mm:
(WebGPU::Instance::requestAdapter):
May 2, 2022:
- 11:11 PM Changeset in webkit [293717] by
-
- 5 edits in trunk
URL.createObjectURL should not be exposed in service worker contexts
https://bugs.webkit.org/show_bug.cgi?id=239972
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/interface-requirements-sw.https-expected.txt:
Source/WebCore:
Covered by rebased test.
- bindings/scripts/CodeGeneratorJS.pm:
Add support for DedicatedWorker and SharedWorker in binding generator for function scope expsure.
(GenerateRuntimeEnableConditionalStringForExposeScope):
- html/DOMURL.idl:
Update WebIDL as per spec.
- 10:26 PM Changeset in webkit [293716] by
-
- 2 edits2 adds in trunk/Source/WebKit
REGRESSION (r292351): Processes no longer get the right jetsam priority on iOS
https://bugs.webkit.org/show_bug.cgi?id=239992
<rdar://problem/92644672>
Reviewed by Chris Dumez.
- FeatureFlags/WebKit.plist: Added.
- WebKit.xcodeproj/project.pbxproj:
Temporarily reinstate
RB_full_manage_WK_jetsam, since it is being
read by a different project.
- 10:19 PM Changeset in webkit [293715] by
-
- 2 edits in trunk/LayoutTests
[ Monterey wk1 GuardMalloc ] fast/borders/hidpi-3x-input-hairline-border.html is timing out
<rdar://problem/81996454>
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
Canonical link: https://commits.webkit.org/250204@main
- 10:07 PM Changeset in webkit [293714] by
-
- 23 edits1 add in trunk
[JSC] Introduce unlinked version of invalidation
https://bugs.webkit.org/show_bug.cgi?id=239887
Reviewed by Saam Barati.
This patch makes invalidation mechanism unlinked for unlinked DFG.
- We always use CheckTraps instead of InvalidationPoint with VMTraps so that we do not need
to repatch existing code.
- We introduce load-and-branch based InvalidationPoint for unlinked DFG so that we do not need
to repatch it to jump to OSR exit when watchpoint fires. We store this condition in DFG::JITData
so that code can quickly access to that.
- We make isStillValid conditions in DFG::CommonData always true for unlinked DFG code. Instead,
we check isJettisoned() condition of CodeBlock since it will become eventually per CodeBlock
information (while this CodeBlock gets invalidated, unlinked DFG code itself can be used for
the other CodeBlock).
After this change, now, jumpReplacements for unlinked DFG becomes empty. We no longer repatch these invalidation points.
- Source/JavaScriptCore/bytecode/CodeBlock.cpp:
(JSC::CodeBlock::jettison):
(JSC::CodeBlock::hasInstalledVMTrapsBreakpoints const):
(JSC::CodeBlock::canInstallVMTrapBreakpoints const):
(JSC::CodeBlock::installVMTrapBreakpoints):
(JSC::CodeBlock::hasInstalledVMTrapBreakpoints const): Deleted.
- Source/JavaScriptCore/bytecode/CodeBlock.h:
- Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- Source/JavaScriptCore/dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::invalidate):
(JSC::DFG::CommonData::~CommonData):
(JSC::DFG::CommonData::installVMTrapBreakpoints):
(JSC::DFG::CommonData::isVMTrapBreakpoint):
- Source/JavaScriptCore/dfg/DFGCommonData.h:
(JSC::DFG::CommonData::CommonData):
(JSC::DFG::CommonData::hasInstalledVMTrapsBreakpoints const):
(JSC::DFG::CommonData::isStillValid const):
- Source/JavaScriptCore/dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- Source/JavaScriptCore/dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::JITCode):
- Source/JavaScriptCore/dfg/DFGJITCode.h:
- Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- Source/JavaScriptCore/dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
(JSC::DFG::prepareCatchOSREntry):
- Source/JavaScriptCore/dfg/DFGPlan.cpp:
(JSC::DFG::Plan::finalize):
- Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInvalidationPoint):
(JSC::DFG::SpeculativeJIT::compileCheckTraps):
(JSC::DFG::SpeculativeJIT::emitInvalidationPoint): Deleted.
- Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:
- Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- Source/JavaScriptCore/ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::JITCode):
- Source/JavaScriptCore/ftl/FTLJITCode.h:
(JSC::FTL::JITCode::isUnlinked const):
- Source/JavaScriptCore/ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
- Source/JavaScriptCore/jit/JITCode.cpp:
(JSC::JITCode::isUnlinked const):
- Source/JavaScriptCore/jit/JITCode.h:
- Source/JavaScriptCore/runtime/VMTraps.cpp:
(JSC::VMTraps::tryInstallTrapBreakpoints):
(JSC::VMTraps::handleTraps):
Canonical link: https://commits.webkit.org/250203@main
- 9:38 PM Changeset in webkit [293713] by
-
- 2 edits in trunk/LayoutTests
[ iOS macOS wk2 ]compositing/video/video-bo rder-radius-clipping.html is a flakey image failure
https://bugs.webkit.org/show_bug.cgi?id=224690
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250202@main
- 9:15 PM Changeset in webkit [293712] by
-
- 2 edits in trunk/LayoutTests
[ iOS macOS wk2 ]compositing/video/video-bo rder-radius-clipping.html is a flakey image failure
https://bugs.webkit.org/show_bug.cgi?id=224690
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250201@main
- 8:43 PM Changeset in webkit [293711] by
-
- 2 edits in trunk
Update yijia's info in constributors
https://bugs.webkit.org/show_bug.cgi?id=239994
Unreviewed.
- metadata/contributors.json:
- 8:02 PM Changeset in webkit [293710] by
-
- 15 edits in trunk/Source/JavaScriptCore
[JSC] Introduce shifting Structure encoding
https://bugs.webkit.org/show_bug.cgi?id=239957
Reviewed by Mark Lam.
For platforms which have limited amount of virtual address space (<= 36 bits), this patch introduces
shifting Structure encoding. We align Structure on a 32-bytes boundary instead of 16 bytes so that
we can ensure that lower 5 bits are zero. Then, we can use 1 bit for nuke, and shifting 4 bits to
convert 36 bit address to 32 bit StructureID. By using this mechanism, we do not need to allocate
large virtual address space for these platforms. If we an address can have more than 36 bits, then
we should just reserve a larger address region since we have enough address space. Current Structure
size is 112 bytes, which is 3.5 atoms at 32 bytes / atom. Hence, this alignment costs us 16 bytes per
Structure.
Relanding with debug build failure & crash on static atomSize assumption in IsoSubspace.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
- heap/Heap.cpp:
- heap/IsoSubspace.h:
(JSC::GCClient::IsoSubspace::allocatorFor):
- heap/IsoSubspaceInlines.h:
(JSC::GCClient::IsoSubspace::allocate):
- heap/StructureAlignedMemoryAllocator.cpp:
(JSC::StructureMemoryManager::StructureMemoryManager):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitNonNullDecodeStructureID):
- llint/LLIntOfflineAsmConfig.h:
- llint/LowLevelInterpreter64.asm:
- runtime/JSCell.h:
- runtime/JSCellInlines.h:
(JSC::JSCell::JSCell):
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- runtime/Structure.h:
- runtime/StructureID.h:
(JSC::StructureID::decode const):
(JSC::StructureID::tryDecode const):
(JSC::StructureID::encode):
- tools/IntegrityInlines.h:
(JSC::Integrity::auditStructureID):
- 7:08 PM Changeset in webkit [293709] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WTF/Ref.cpp
Add API tests for ref-counting churn in static_reference_cast<>()
https://bugs.webkit.org/show_bug.cgi?id=239987
Reviewed by Darin Adler.
Add API tests for ref-counting churn in static_reference_cast<>().
This covers the fix made in r293682.
- Tools/TestWebKitAPI/Tests/WTF/Ref.cpp:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/250198@main
- 6:55 PM Changeset in webkit [293708] by
-
- 8 edits in trunk
[JSC] Add ISO8601 based Temporal.PlainDate getters
https://bugs.webkit.org/show_bug.cgi?id=239949
Reviewed by Ross Kirsling and Dean Jackson.
This patch adds missing getters of Temporal.PlainDate. Currently, we are not querying to Calendar.
It will be wired once we bake Calendar completely.
- JSTests/stress/temporal-plaindate.js:
(print):
(shouldBe):
- Source/JavaScriptCore/runtime/ISO8601.cpp:
(JSC::ISO8601::dayOfWeek):
(JSC::ISO8601::dayOfYear):
(JSC::ISO8601::weekOfYear):
(JSC::ISO8601::daysInMonth):
(JSC::ISO8601::monthCode):
- Source/JavaScriptCore/runtime/ISO8601.h:
- Source/JavaScriptCore/runtime/TemporalPlainDate.cpp:
(JSC::TemporalPlainDate::from):
(JSC::TemporalPlainDate::monthCode const):
(JSC::TemporalPlainDate::dayOfWeek const):
(JSC::TemporalPlainDate::dayOfYear const):
(JSC::TemporalPlainDate::weekOfYear const):
- Source/JavaScriptCore/runtime/TemporalPlainDate.h:
- Source/JavaScriptCore/runtime/TemporalPlainDatePrototype.cpp:
(JSC::JSC_DEFINE_CUSTOM_GETTER):
Canonical link: https://commits.webkit.org/250197@main
- 6:32 PM Changeset in webkit [293707] by
-
- 2 edits in trunk/Source/WebKit
Crash in WebKit::ModelElementController::modelElementCreateRemotePreview
https://bugs.webkit.org/show_bug.cgi?id=239985
Reviewed by Dean Jackson.
Add a check before using m_modelElementController, as it's not guaranteed
to be initialized in the constructor, and can be invalidated in WebPageProxy::resetState.
Test: fast/html/model-element-controller-crash.html
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::modelElementGetCamera):
(WebKit::WebPageProxy::modelElementSetCamera):
(WebKit::WebPageProxy::modelElementIsPlayingAnimation):
(WebKit::WebPageProxy::modelElementSetAnimationIsPlaying):
(WebKit::WebPageProxy::modelElementIsLoopingAnimation):
(WebKit::WebPageProxy::modelElementSetIsLoopingAnimation):
(WebKit::WebPageProxy::modelElementAnimationDuration):
(WebKit::WebPageProxy::modelElementAnimationCurrentTime):
(WebKit::WebPageProxy::modelElementSetAnimationCurrentTime):
(WebKit::WebPageProxy::modelElementHasAudio):
(WebKit::WebPageProxy::modelElementIsMuted):
(WebKit::WebPageProxy::modelElementSetIsMuted):
(WebKit::WebPageProxy::takeModelElementFullscreen):
(WebKit::WebPageProxy::modelElementSetInteractionEnabled):
(WebKit::WebPageProxy::modelElementCreateRemotePreview):
(WebKit::WebPageProxy::modelElementLoadRemotePreview):
(WebKit::WebPageProxy::modelElementDestroyRemotePreview):
(WebKit::WebPageProxy::modelElementSizeDidChange):
(WebKit::WebPageProxy::handleMouseDownForModelElement):
(WebKit::WebPageProxy::handleMouseMoveForModelElement):
(WebKit::WebPageProxy::handleMouseUpForModelElement):
(WebKit::WebPageProxy::modelInlinePreviewUUIDs):
- 5:59 PM Changeset in webkit [293706] by
-
- 3 edits in trunk/Source/WebInspectorUI
WebInspector: Improve rendering of GLbitfield in WebGL canvas recordings.
https://bugs.webkit.org/show_bug.cgi?id=239589
Patch by Dan Glastonbury <djg@apple.com> on 2022-05-02
Reviewed by Devin Rousso.
- UserInterface/Models/RecordingAction.js:
(WI.RecordingAction.bitfieldNamesForParameter.test_and_clear_bit):
(WI.RecordingAction.bitfieldNamesForParameter): Split known
bitfields into an array of valid named representation for each
bit. Unknown bits are returned as hexadecimal formatted string.
- UserInterface/Views/RecordingActionTreeElement.js:
(WI.RecordingActionTreeElement._generateDOM.createParameterElement):
(WI.RecordingActionTreeElement._generateDOM): If param has a
non-null, array of strings, render the array as
context.FIELD1|context.FIELD2
Canonical link: https://commits.webkit.org/250195@main
- 5:55 PM Changeset in webkit [293705] by
-
- 1 copy in tags/WebKit-7613.2.7.0.7
Tag WebKit-7613.2.7.0.7.
- 5:53 PM Changeset in webkit [293704] by
-
- 1 copy in tags/WebKit-7613.2.7.1.8
Tag WebKit-7613.2.7.1.8.
- 5:37 PM Changeset in webkit [293703] by
-
- 22 edits in trunk
Drop some unused StringImpl / AtomStringImpl / AtomString API
https://bugs.webkit.org/show_bug.cgi?id=239912
Reviewed by Yusuke Suzuki.
Simplifies our API a bit and encourages people to write more efficient
code.
- Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WTF/StringOperators.cpp:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WTF/StringView.cpp:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):
- Source/JavaScriptCore/API/JSValue.mm:
(createStructHandlerMap):
- Source/JavaScriptCore/runtime/CachedTypes.cpp:
(JSC::CachedUniquedStringImplBase::decode const):
- Source/JavaScriptCore/runtime/Identifier.cpp:
(JSC::Identifier::addLiteral): Deleted.
- Source/JavaScriptCore/runtime/Identifier.h:
(JSC::Identifier::Identifier):
(JSC::Identifier::add):
- Source/JavaScriptCore/runtime/ObjectPrototype.cpp:
(JSC::inferBuiltinTag):
(JSC::objectPrototypeToString):
- Source/JavaScriptCore/runtime/SmallStrings.cpp:
(JSC::SmallStrings::initializeCommonStrings):
(JSC::SmallStrings::initialize):
- Source/JavaScriptCore/runtime/SmallStrings.h:
- Source/WTF/wtf/text/AtomString.h:
(WTF::AtomString::AtomString):
- Source/WTF/wtf/text/AtomStringImpl.cpp:
(WTF::CStringTranslator::hash): Deleted.
(WTF::CStringTranslator::equal): Deleted.
(WTF::CStringTranslator::translate): Deleted.
- Source/WTF/wtf/text/AtomStringImpl.h:
- Source/WTF/wtf/text/StringImpl.cpp:
- Source/WTF/wtf/text/StringImpl.h:
(WTF::StringImpl::create):
(WTF::StringImpl::createFromCString):
(WTF::lengthOfNullTerminatedString): Deleted.
- Source/WTF/wtf/text/WTFString.cpp:
(WTF::String::String):
- Source/WTF/wtf/text/WTFString.h:
- Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
Canonical link: https://commits.webkit.org/250194@main
- 5:04 PM Changeset in webkit [293702] by
-
- 3 edits in trunk/LayoutTests
[ iOS ][ macOS ] css3/calc/transitions-dependent.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=239990
Unreviewed test gardening.
- LayoutTests/platform/ios-simulator/TestExpectations:
- LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/250193@main
- 5:01 PM Changeset in webkit [293701] by
-
- 31 edits in trunk/Source
Move starAtom() / xmlAtom() / xmlnsAtom() from WTF to WebCore https://bugs.webkit.org/show_bug.cgi?id=239969
Reviewed by Darin Adler.
Move starAtom() / xmlAtom() / xmlnsAtom() from WTF to WebCore since
they are not useful outside WebCore.
- Source/WTF/wtf/text/AtomString.cpp:
(WTF::AtomString::init):
- Source/WTF/wtf/text/AtomString.h:
(WTF::emptyAtom):
(WTF::starAtom): Deleted.
(WTF::xmlAtom): Deleted.
(WTF::xmlnsAtom): Deleted.
- Source/WebCore/css/CSSPageRule.cpp:
- Source/WebCore/css/CSSSelector.cpp:
- Source/WebCore/css/CSSSelectorList.cpp:
- Source/WebCore/css/SelectorChecker.cpp:
- Source/WebCore/css/SelectorFilter.cpp:
- Source/WebCore/css/StyleSheetContents.cpp:
- Source/WebCore/css/parser/CSSSelectorParser.cpp:
- Source/WebCore/cssjit/SelectorCompiler.cpp:
- Source/WebCore/dom/Attr.cpp:
- Source/WebCore/dom/Attribute.h:
- Source/WebCore/dom/ContainerNode.cpp:
- Source/WebCore/dom/Node.cpp:
- Source/WebCore/dom/NodeRareData.h:
- Source/WebCore/dom/QualifiedName.cpp:
- Source/WebCore/dom/SelectorQuery.cpp:
- Source/WebCore/dom/TagCollection.h:
- Source/WebCore/editing/MarkupAccumulator.cpp:
- Source/WebCore/html/LabelableElement.cpp:
- Source/WebCore/html/LabelsNodeList.cpp:
- Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
- Source/WebCore/platform/CommonAtomStrings.h:
- Source/WebCore/style/PageRuleCollector.cpp:
- Source/WebCore/style/RuleData.cpp:
- Source/WebCore/style/RuleFeature.h:
- Source/WebCore/style/RuleSet.cpp:
- Source/WebCore/xml/NativeXPathNSResolver.cpp:
- Source/WebCore/xml/XPathStep.cpp:
- Source/WebCore/xml/parser/XMLDocumentParser.cpp:
- Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:
Canonical link: https://commits.webkit.org/250192@main
- 4:33 PM Changeset in webkit [293700] by
-
- 4 edits in trunk/Source/WebCore
[Quirks] REGRESSION (r286874): Menu is Cut Off After Pressing Search Icon on Hotels.com
https://bugs.webkit.org/show_bug.cgi?id=239980
<rdar://91992835>
Reviewed by Simon Fraser.
Disable resolution media query on www.hotels.com.
- css/MediaQueryEvaluator.cpp:
(WebCore::resolutionEvaluate):
- page/Quirks.cpp:
(WebCore::Quirks::shouldUseResolutionMedia const):
- page/Quirks.h:
- 4:25 PM Changeset in webkit [293699] by
-
- 3 edits in branches/safari-613-branch/Source/WebKit
Apply patch. rdar://problem/92617943
- 4:11 PM Changeset in webkit [293698] by
-
- 3 edits in branches/safari-613.2.7.1-branch/Source/WebKit
Apply patch. rdar://problem/92617943
- 4:04 PM Changeset in webkit [293697] by
-
- 3 edits in trunk/Source/WebKit
Revert all use of _setPrivacyProxyFailClosedForUnreachableNonMainHosts
https://bugs.webkit.org/show_bug.cgi?id=239977
<rdar://92617943>
Reviewed by John Wilander.
Due to what is likely confusion about internal integration processes,
the powers that be have decided that the best course of action for now
is to restore the status quo and accept any consequences that may entail.
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::createWebSocketTask):
- 4:04 PM Changeset in webkit [293696] by
-
- 1 copy in tags/WebKit-7614.1.11.5
Tag WebKit-7614.1.11.5.
- 4:01 PM Changeset in webkit [293695] by
-
- 9 edits in branches/safari-613.2.7.1-branch/Source
Versioning.
WebKit-7613.2.7.1.8
- 4:01 PM Changeset in webkit [293694] by
-
- 9 edits in branches/safari-614.1.11-branch/Source
Versioning.
WebKit-7614.1.11.5
- 3:58 PM Changeset in webkit [293693] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Fix ASan crash due to CString ownership
https://bugs.webkit.org/show_bug.cgi?id=239981
Reviewed by Darin Adler and Mark Lam.
We need to ensure that CString is kept alive.
- runtime/JSDateMath.cpp:
(JSC::DateCache::timeZoneDisplayName):
Canonical link: https://commits.webkit.org/250189@main
- 3:49 PM Changeset in webkit [293692] by
-
- 3 edits in branches/safari-613.2.7.0-branch/Source/WebKit
Apply patch. rdar://problem/92617943
- 3:48 PM Changeset in webkit [293691] by
-
- 8 edits in trunk/LayoutTests/imported/w3c
Update some wpt tests with control characters in cookies
https://bugs.webkit.org/show_bug.cgi?id=239966
<rdar://92300855>
Reviewed by Chris Dumez.
This reflects a change in https://github.com/httpwg/http-extensions/issues/1531
- web-platform-tests/cookies/name/name-ctl-expected.txt:
- web-platform-tests/cookies/name/name-ctl.html:
- web-platform-tests/cookies/resources/cookie-test.js:
- web-platform-tests/cookies/value/value-ctl-expected.txt:
- web-platform-tests/cookies/value/value-ctl.html:
- web-platform-tests/html/dom/documents/resource-metadata-management/document-cookie-expected.txt:
- web-platform-tests/html/dom/documents/resource-metadata-management/document-cookie.html:
- 3:46 PM Changeset in webkit [293690] by
-
- 9 edits in branches/safari-613.2.7.0-branch/Source
Versioning.
WebKit-7613.2.7.0.7
- 3:35 PM Changeset in webkit [293689] by
-
- 11 edits in trunk
[cssom] Don't index 'all' shorthand in computed styles
https://bugs.webkit.org/show_bug.cgi?id=239669
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update test expectations.
- web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
Source/WebCore:
Computed styles should provide getters for both longhands and shorthands,
but only the former should be indexed.
However, the 'all' shorthand was being indexed as if it was a longhand.
Tests: imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
- css/makeprop.pl:
(skippedFromComputedStyle):
LayoutTests:
Update test expectations.
- platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- 3:33 PM Changeset in webkit [293688] by
-
- 4 edits in trunk/Source
Add option to JSC shell to wait for a USR2 signal before exiting to aid in collection of vmmaps
https://bugs.webkit.org/show_bug.cgi?id=239919
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
- jsc.cpp:
(main):
Source/WTF:
- wtf/threads/Signals.h:
(WTF::toSystemSignal):
- 3:22 PM Changeset in webkit [293687] by
-
- 1 copy in tags/WebKit-7614.1.11.4
Tag WebKit-7614.1.11.4.
- 3:19 PM Changeset in webkit [293686] by
-
- 9 edits in branches/safari-614.1.11-branch/Source
Versioning.
WebKit-7614.1.11.4
- 2:56 PM Changeset in webkit [293685] by
-
- 13 edits in trunk/Source/JavaScriptCore
Unreviewed, reverting r293680.
https://bugs.webkit.org/show_bug.cgi?id=239983
crash on iOS
Reverted changeset:
"[JSC] Introduce shifting Structure encoding"
https://bugs.webkit.org/show_bug.cgi?id=239957
https://commits.webkit.org/r293680
- 2:52 PM Changeset in webkit [293684] by
-
- 4 edits3 adds in trunk
[Modern Media Controls] REGRESSION(?) tapping a video to start playing for the first time doesn't start playing
https://bugs.webkit.org/show_bug.cgi?id=239918
<rdar://problem/91329117>
Reviewed by Jer Noble.
Source/WebCore:
This happens on iOS because the
<video>has aGestureRecognizerthat will attempt to
play(), and then thePlayPauseButton(which also has aGestureRecognizer) will attempt
totogglePlayback()(viaPlaybackSupport), which willpause()because the<video>is
notpaused.
When a
<video>isplay()for the first time, it may not actually start playing for a
moment (e.g. buffering) even though it will say it'spaused.
Test: media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-shows-start-button.html
- Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype.togglePlayback):
Also checkhasPlayedto decide whether toplay()orpause(), as it's set when the first
"play"event is handled, as until then we're still not playing yet and shouldplay().
This could also be fixed in
PlaybackSupport(and/orStartSupport), but doing it in
togglePlaybackis a more general solution that fixes all present (and future) callsites.
LayoutTests:
- media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-shows-start-button.html: Added.
- media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-shows-start-button-expected.txt: Added.
- 2:18 PM Changeset in webkit [293683] by
-
- 8 edits1 add in trunk/Source/WebKit
Use a strongly typed identifier for requests to mark surfaces as volatile
https://bugs.webkit.org/show_bug.cgi?id=239974
Reviewed by Simon Fraser.
- Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::markSurfacesVolatile):
- Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
- Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in:
- Source/WebKit/Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
- Source/WebKit/Shared/MarkSurfacesAsVolatileRequestIdentifier.h: Added.
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::markSurfacesVolatile):
(WebKit::RemoteRenderingBackendProxy::didMarkLayersAsVolatile):
- Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
- Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in:
Canonical link: https://commits.webkit.org/250183@main
- 1:31 PM Changeset in webkit [293682] by
-
- 1 edit in trunk/Source/WTF/wtf/Ref.h
static_reference_cast(const Ref<X, Y>&) causes unnecessary ref-counting churn
https://bugs.webkit.org/show_bug.cgi?id=239970
Reviewed by Geoffrey Garen.
This function was calling copyRef() to get a non-const Ref<> and then calling Ref::get() to construct a
new Ref<> of the destination type. The copyRef() would increase the ref count by 1, constructing the
new destination Ref<> would increase the ref count by 1 again and then the temporary Ref going out of
scope would decrease the ref count by one.
We now call static_reference_cast(Ref<X, Y>&&) with the result of the copyRef(), which will leak
the pointer from the Ref<> and adopt it in the destination Ref, thus avoiding unnecessary churn.
Also drop the static_reference_cast(Ref<X, Y>&) overload as it is no longer more efficient than the
static_reference_cast(const Ref<X, Y>&) one.
- Source/WTF/wtf/Ref.h:
(WTF::static_reference_cast):
Canonical link: https://commits.webkit.org/250182@main
- 1:29 PM Changeset in webkit [293681] by
-
- 10 edits1 add in trunk
[macOS] The "Markup Image" services menu item should be gated on image analysis results
https://bugs.webkit.org/show_bug.cgi?id=239933
rdar://92348202
Reviewed by Kate Cheney.
Source/WebKit:
Adjust some macOS-specific logic for appending the "Markup Image" menu item in the services menu, such that we
only add this new item in the case where the relevant image analysis APIs come back with a valid cropped image
result. See below for more details.
Test: ImageAnalysisTests.MarkupImageItemInServicesMenu
- UIProcess/WebContextMenuProxy.h:
(WebKit::WebContextMenuProxy::croppedImageResult const):
Move
m_croppedImageForContextMenuintoWebContextMenuProxyMacasm_croppedImageResult, so that it can be
easily used for both the new "Copy Cropped Image" and "Markup Image" items. This also allows us to simplify some
logic for resetting this cached image result since the wholem_activeContextMenuis always destroyed upon
presenting a context menu, so there's no need to separately clear outm_croppedImageResult.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::showContextMenu):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebContextMenuProxyMac.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
(WebKit::WebContextMenuProxyMac::appendMarkupItemToControlledImageMenuIfNeeded):
Pull this logic out into a separate helper method, and change it so that:
- We run the image analysis prior to creating and adding the item.
- Only add the item if the image analysis returned a non-null CGImageRef.
- Store the CGImageRef on
m_croppedImageResult, for use if the menu item is invoked.
(WebKit::WebContextMenuProxyMac::applyMarkupToControlledImage):
(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::handleContextMenuCopyCroppedImage):
(WebKit::WebPageProxy::setCroppedImageForContextMenu): Deleted.
Tools:
Add an API test to simulate clicking on the services menu button in an attachment-backed image element while
swizzling the relevant image analysis APIs to return a valid CGImageRef; verify that the "Markup Image" menu
item eventually shows up.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
(TestWebKitAPI::createWebViewWithTextRecognitionEnhancements):
(TestWebKitAPI::iconImage):
Make this testing helper function work on both macOS and iOS.
(TestWebKitAPI::TEST):
(TestWebKitAPI::runMarkupTest):
- TestWebKitAPI/Tests/WebKitCocoa/image-controls.html: Added.
- 1:15 PM Changeset in webkit [293680] by
-
- 13 edits in trunk/Source/JavaScriptCore
[JSC] Introduce shifting Structure encoding
https://bugs.webkit.org/show_bug.cgi?id=239957
Reviewed by Mark Lam.
For platforms which have limited amount of virtual address space (<= 36 bits), this patch introduces
shifting Structure encoding. We align Structure on a 32-bytes boundary instead of 16 bytes so that
we can ensure that lower 5 bits are zero. Then, we can use 1 bit for nuke, and shifting 4 bits to
convert 36 bit address to 32 bit StructureID. By using this mechanism, we do not need to allocate
large virtual address space for these platforms. If we an address can have more than 36 bits, then
we should just reserve a larger address region since we have enough address space. Current Structure
size is 112 bytes, which is 3.5 atoms at 32 bytes / atom. Hence, this alignment costs us 16 bytes per
Structure.
- Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
- Source/JavaScriptCore/heap/Heap.cpp:
- Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:
- Source/JavaScriptCore/jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitNonNullDecodeStructureID):
- Source/JavaScriptCore/llint/LLIntOfflineAsmConfig.h:
- Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:
- Source/JavaScriptCore/runtime/JSCConfig.h:
- Source/JavaScriptCore/runtime/JSCell.h:
(JSC::JSCell::atomSize):
- Source/JavaScriptCore/runtime/Structure.h:
(JSC::Structure::atomSize):
- Source/JavaScriptCore/runtime/StructureID.h:
(JSC::StructureID::decode const):
(JSC::StructureID::tryDecode const):
(JSC::StructureID::encode):
- Source/JavaScriptCore/tools/IntegrityInlines.h:
(JSC::Integrity::auditStructureID):
Canonical link: https://commits.webkit.org/250179@main
- 1:15 PM Changeset in webkit [293679] by
-
- 12 edits in trunk
Cancel response stream if load is being cancelled by the web page
https://bugs.webkit.org/show_bug.cgi?id=239968
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/fetch-event-respond-with-readable-stream.https-expected.txt:
Source/WebCore:
Add a cancel callback and use it to get the fetch client cancelling notification
to cancel the response body stream or response body load.
Covered by rebased test.
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::cancelStream):
- Modules/fetch/FetchResponse.h:
- bindings/js/ReadableStream.cpp:
(WebCore::ReadableStream::cancel):
- bindings/js/ReadableStream.h:
- workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::processResponse):
- workers/service/context/ServiceWorkerFetch.h:
Source/WebKit:
Use the cancel callback to pipe the order to cancel the stream.
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::cancel):
(WebKit::WebServiceWorkerFetchTaskClient::setCancelledCallback):
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:
- 1:06 PM Changeset in webkit [293678] by
-
- 1 copy in tags/WebKit-7614.1.11.3
Tag WebKit-7614.1.11.3.
- 12:56 PM Changeset in webkit [293677] by
-
- 9 edits in branches/safari-614.1.11-branch/Source
Versioning.
WebKit-7614.1.11.3
- 12:46 PM Changeset in webkit [293676] by
-
- 6 edits in trunk
PWA in iOS use old assets after publish new servicerWorker/assets
https://bugs.webkit.org/show_bug.cgi?id=199110
<rdar://problem/51992077>
Reviewed by Chris Dumez.
Source/WebCore:
In case a service worker is updated, its state will be waiting until activated.
In case we suspend clients and network process, the newly installed service worker wil remain waiting.
We will wait for the service worker to get activated when network process gets unsuspended, which might not happen if the network process gets stopped by the OS.
To prevent this, we now update the service worker registration as soon as the service worker install job is finished.
The migration from waiting to activated upon network process crash is not ideal: in theory we should fire an activate event on the waiting service worker.
That said, this is still somehow allowed, as failing to activate (say if service worker process is crashing when handling the event) is allowed.
Covered by new API test.
- workers/service/server/SWServer.cpp:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
- TestWebKitAPI/cocoa/HTTPServer.h:
- TestWebKitAPI/cocoa/HTTPServer.mm:
- 12:44 PM Changeset in webkit [293675] by
-
- 2 edits in trunk/Source/WebGPU
Fix tvOS build
https://bugs.webkit.org/show_bug.cgi?id=239973
<rdar://problem/92599361>
- WebGPU/HardwareCapabilities.mm:
- 12:15 PM Changeset in webkit [293674] by
-
- 2 edits in trunk/Source/WebGPU
[WebGPU] [tvOS] Neither MTLGPUFamilyApple6 nor MTLGPUFamilyApple7 exist on tvOS
https://bugs.webkit.org/show_bug.cgi?id=239973
<rdar://problem/92599361>
Unreviewed build fix.
- WebGPU/HardwareCapabilities.mm:
(WebGPU::rawHardwareCapabilities):
- 12:12 PM Changeset in webkit [293673] by
-
- 5 edits in trunk
[selection] Set correct selection range for TEXTAREA when updating default value
https://bugs.webkit.org/show_bug.cgi?id=237525
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end-extra-expected.txt:
Source/WebCore:
Updating defaultValue should keep selectionStart/End. We need clamp them if the new value is shorter than the
selectionStart/End. This change is to be in line with [1] & [2].
[1] https://html.spec.whatwg.org/multipage/form-elements.html#the-textarea-element:dom-textarea-defaultvalue-2
[2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#textFieldSelection:concept-textarea/input-relevant-value
Part of this change is an import of Chromium CL at
https://github.com/chromium/chromium/commit/bb27a500d07f8b3c567e84857a40c3ce42fa454a
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::childrenChanged):
(WebCore::HTMLTextAreaElement::setValueCommon):
- html/HTMLTextFormControlElement.h:
- 12:01 PM Changeset in webkit [293672] by
-
- 3 edits2 adds in trunk
HTML Parser: Wrong column number in CR-LF line ending style (DOS EOL style) HTML files
https://bugs.webkit.org/show_bug.cgi?id=239947
Reviewed by Myles C. Maxfield.
Source/WebCore:
JS stack trace reported wrong column numbers in CR-LF line ending
HTML files. m_numberOfCharactersConsumedPriorToCurrentLine was the
number of characters included the preceding CR but the following
LF in those files.
In SegmentedString::advance, startNewLine() is called after
decrementing m_currentSubstring.length. In
SegmentedString::advancePastNewline, however, startNewLine() was
called before calling decrementAndCheckLength(). startNewLine()
should be called after decrementing.
Test: js/dom/line-column-numbers-cr-lf.html
- platform/text/SegmentedString.h:
(WebCore::SegmentedString::advancePastNewline):
Call startNewLine() after decrementAndCheckLength() is called.
LayoutTests:
- js/dom/line-column-numbers-cr-lf-expected.txt: Added.
- js/dom/line-column-numbers-cr-lf.html: Added.
- 11:35 AM Changeset in webkit [293671] by
-
- 4 edits1 add in trunk
[Cocoa] Allow more mime types in captive portal mode
https://bugs.webkit.org/show_bug.cgi?id=239859
rdar://91830683
Reviewed by Brent Fulgham.
Source/WTF:
- Scripts/Preferences/WebPreferences.yaml:
Tools:
- TestWebKitAPI/Tests/WebKit/cocoa/start-offset.ts: Added.
- TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
(TestWebKitAPI::runVideoTest):
(TestWebKitAPI::testTransportStreamBytes):
(TestWebKitAPI::TEST):
- 11:05 AM Changeset in webkit [293670] by
-
- 13 edits1 delete in trunk
[cssom] Enumerate all logical longhands in the computed style
https://bugs.webkit.org/show_bug.cgi?id=239910
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update test expectations.
- web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
- web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
Source/WebCore:
Bug 210695 made computed styles enumerate most logical longhands, but
only the ones thefined in the css-logical spec were included. Other
specs, like css-scroll-snap, can also define logical longhands.
This patch fixes the logic, and instead of checking the spec, it checks
the "logical-property-group" field.
Tests: imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html
imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer.html
imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree.html
- css/makeprop.pl:
(isLogical):
LayoutTests:
Update test expectations.
all-prop-initial-xml-expected.txt for ios was clearly outdated, so just
removing it.
- platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Removed.
- platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- 10:21 AM Changeset in webkit [293669] by
-
- 1 copy in tags/WebKit-7614.1.11.2
Tag WebKit-7614.1.11.2.
- 10:15 AM Changeset in webkit [293668] by
-
- 9 edits in branches/safari-614.1.11-branch/Source
Versioning.
WebKit-7614.1.11.2
- 9:57 AM Changeset in webkit [293667] by
-
- 4 edits in trunk/Tools
[git-webkit] log should support ranges
https://bugs.webkit.org/show_bug.cgi?id=239510
<rdar://problem/92031167>
Reviewed by Ryan Haddad.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:
(FilteredCommand.replace): Break logic converting a substring into a revision or hash into a function.
(FilteredCommand.main): If an argument can be split by ..., convert it's substrings into revisions/hashes.
Canonical link: https://commits.webkit.org/250171@main
- 9:52 AM Changeset in webkit [293666] by
-
- 2 edits in trunk/JSTests
new-largeish-contiguous-array-with-size.js: pick up leakFactor
https://bugs.webkit.org/show_bug.cgi?id=239963
Unreviewed gardening.
The @ directives are implemented imperatively, so requireOptions
only has any effect if it precedes the run* statement. Also,
s/var leakFactor/leakFactor/ to avoid running into this:
Exception: SyntaxError: Can't create duplicate variable: 'leakFactor'
With this fix, the leakFactor works as intended -- no failures in 200+
iterations.
- stress/new-largeish-contiguous-array-with-size.js:
- 9:29 AM Changeset in webkit [293665] by
-
- 7 edits in trunk
Register shared workers as service worker clients
https://bugs.webkit.org/show_bug.cgi?id=239846
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/claim-shared-worker-fetch.https-expected.txt:
Source/WebCore:
Make sure to register shared workers as service worker clients at launch time or when recreating the network process connection.
Covered by rebased test.
- workers/shared/context/SharedWorkerThread.cpp:
- workers/shared/context/SharedWorkerThreadProxy.cpp:
- workers/shared/context/SharedWorkerThreadProxy.h:
- 9:15 AM Changeset in webkit [293664] by
-
- 3 edits in trunk/Source/WebCore
VPIO requires the same sample rate for microphone and speaker formats
https://bugs.webkit.org/show_bug.cgi?id=239956
Reviewed by Eric Carlson.
VPIO requires the speaker sample rate and microphone sample rate to be the same.
This is not guaranteed to be true : getUserMedia/applyConstraints may set the microphone sample rate to different values.
If audio rendering already started at capture start time, we use the audio rendering sample rate.
This is not strictly compliant, given required constraints but they are not widely used.
Applications that want to make sure to use a specific sample rate would need to pause audio rendering when starting to capture.
We reset exposed settings when starting to capture to expose the actual sample rate to JavaScript through MediaStreamTrack.getSettings().
Manually tested.
- platform/mediastream/mac/BaseAudioSharedUnit.h:
- platform/mediastream/mac/CoreAudioCaptureSource.cpp:
- 8:55 AM Changeset in webkit [293663] by
-
- 8 edits in trunk
[iOS] Add support for the "Markup Image" action when right clicking an image in editable content
https://bugs.webkit.org/show_bug.cgi?id=239948
rdar://92064672
Reviewed by Tim Horton.
Source/WebKit:
Insert a "Markup Image" menu action when right clicking an editable image element on iPad via trackpad, but only
when the image has relevant image analysis markup results. See below for more details.
Test: ImageAnalysisTests.MarkupImageUsingContextMenu
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView prepareSelectionForContextMenuWithLocationInView:completionHandler:]):
In the case where a single image is selected in editable content, make this method additionally wait until we've
finished analyzing the selected image, such that the subsequent call to-buildMenuForWebViewWithBuilder:which
populates items in the right click context menu will include the "Markup Image" item if there are relevant
results.
(-[WKContentView buildMenuForWebViewWithBuilder:]):
Also move the location of this item to before the Format (B/I/U) menu items in both the callout bar and the
editing context menu.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::prepareSelectionForContextMenuWithLocationInView):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::prepareSelectionForContextMenuWithLocationInView):
In the case where an image element is clicked, just select the image element instead of trying to detect a
nearby word or link. We also immediately send a full editor state update here, such that the editor state's
selectedEditableImagewill be up to date when the completion handler in the UI process is invoked.
Tools:
Add an API test to verify that the "Markup Image" is included in the context menu when right clicking an image
element inside an editable web view.
- TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
(TestWebKitAPI::simulateEditContextMenuAppearance):
(TestWebKitAPI::TEST):
- 8:08 AM Changeset in webkit [293662] by
-
- 3 edits in trunk/LayoutTests
REGRESSION: fast/css/stylesheet-candidate-nodes-crash.xhtml is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=239960
rdar://92293472
Reviewed by Alan Bujtas.
XML parser update has changed error reporting output slightly.
Remove the error report from the test output since testing that is not the purpose of this test.
- fast/css/stylesheet-candidate-nodes-crash-expected.txt:
- fast/css/stylesheet-candidate-nodes-crash.xhtml:
- 3:56 AM Changeset in webkit [293661] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer][Debug] media-recorder tests hitting an ASSERT
https://bugs.webkit.org/show_bug.cgi?id=239942
Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-02
Reviewed by Xabier Rodriguez-Calvar.
Delay the track observing stopping until InternalSources are destroyed. Doing so during
PAUSED->READY was not safe in MediaRecording pipelines, because the transcoder changes its
state from a secondary thread.
- platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
(webkitMediaStreamSrcChangeState):
Canonical link: https://commits.webkit.org/250165@main
- 2:31 AM Changeset in webkit [293660] by
-
- 4 edits in trunk
[GLib] Make WebKitSettings XSS auditor functions no-op
https://bugs.webkit.org/show_bug.cgi?id=239651
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-05-02
Reviewed by Adrian Perez de Castro.
- Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):
- Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
Canonical link: https://commits.webkit.org/250164@main
May 1, 2022:
- 10:46 PM Changeset in webkit [293659] by
-
- 15 edits in trunk/Source
REGRESSION(r282117): RemoteRenderingBackend::willDestroyImageBuffer() can crash if the RemoteRenderingBackend has already been destroyed
https://bugs.webkit.org/show_bug.cgi?id=239107
rdar://91608298
Reviewed by Darin Adler.
Source/WebCore:
-- IOSurfacePool will be RefCounted.
-- ImageBufferIOSurfaceBackend::create() will pass the surfacePool
of the CreationContext to ImageBufferIOSurfaceBackend constructor.
-- ImageBufferIOSurfaceBackend will hold a RefPtr<IOSurfacePool>.
-- ImageBufferIOSurfaceBackend destructor will call IOSurface::moveToPool()
to return its surface to the IOSurfacePool if it was set.
- platform/graphics/ConcreteImageBuffer.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageBufferBackend.h:
(WebCore::ImageBufferBackend::releaseGraphicsContext):
(WebCore::ImageBufferBackend::releaseBufferToPool): Deleted.
- platform/graphics/cg/IOSurfacePool.cpp:
(WebCore::IOSurfacePool::create):
- platform/graphics/cg/IOSurfacePool.h:
- platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::create):
(WebCore::ImageBufferIOSurfaceBackend::ImageBufferIOSurfaceBackend):
(WebCore::ImageBufferIOSurfaceBackend::~ImageBufferIOSurfaceBackend):
(WebCore::ImageBufferIOSurfaceBackend::releaseBufferToPool): Deleted.
- platform/graphics/cg/ImageBufferIOSurfaceBackend.h:
Source/WebKit:
After r282117, the assumption that RemoteRenderingBackend will outlive
all its RemoteImageBuffers became wrong. The RemoteRenderingBackend can
get destroyed under GPUConnectionToWebProcess::didClose() before the
callOnMainThread() of the ThreadSafeRefcounted image buffers have run.
This solution is to make the ImageBufferIOSurfaceBackend be responsible
of returning its IOSurface to the IOSurfacePool. So no need to call
willDestroyImageBuffer() from the RemoteImageBuffer destructor.
- GPUProcess/graphics/RemoteGraphicsContextGL.h:
- GPUProcess/graphics/RemoteImageBuffer.h:
(WebKit::RemoteImageBuffer::RemoteImageBuffer):
(WebKit::RemoteImageBuffer::m_renderingResourcesRequest):
(WebKit::RemoteImageBuffer::~RemoteImageBuffer):
- GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::willDestroyImageBuffer): Deleted.
- GPUProcess/graphics/RemoteRenderingBackend.h:
(WebKit::RemoteRenderingBackend::ioSurfacePool const):
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::Buffer::discard):
- WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp:
(WebKit::ImageBufferShareableMappedIOSurfaceBackend::create):
- 6:48 PM Changeset in webkit [293658] by
-
- 4 edits in trunk/Source/WebCore
[Modern Media Controls] the overflow button sometimes flickers
https://bugs.webkit.org/show_bug.cgi?id=239921
<rdar://problem/91329468>
Reviewed by Eric Carlson.
There are two things that control the visibility of the
OverflowButton:
- whether any of the "default" actions (e.g. playback speed, chapters, etc.) are possible
- if any other buttons that have
contextMenuOptionsare dropped (i.e. there's not enough
room for it because the
<video>is narrow or there are already too many buttons)
(1) is recalculated for most JS media events (e.g. whenever tracks are changed, if
thereadyStatechanges, etc.).
(2) is recalculated in
layoutofMediaControls, which is (relatively) less frequent.
In the case that the only contextmenu options are provided by (2) (i.e. none of the "default"
actions are possible), the frequent recalculation of (1) will combined with the fact that
layoutuses arequestAnimationFrameto delay/batch work will cause there to be a short
period of time after the recalculation of (1) and before the recalculation of (2) where
there are no contextmenu options, resulting in theOverflowButtonbeing hidden.
- Modules/modern-media-controls/controls/overflow-button.js:
(OverflowButton):
(OverflowButton.prototype.set visible):
(OverflowButton.prototype.set visible.isEmpty): Added.
(OverflowButton.prototype.get contextMenuOptions):
(OverflowButton.prototype.addExtraContextMenuOptions): Renamed fromaddContextMenuOptions.
(OverflowButton.prototype.clearExtraContextMenuOptions): Renamed fromclearContextMenuOptions.
(OverflowButton.prototype.set defaultContextMenuOptions):
- Modules/modern-media-controls/controls/inline-media-controls.js:
(InlineMediaControls.prototype.layout):
- Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
(MacOSFullscreenMediaControls.prototype.layout):
Instead of having a single_contextMenuOptionsthat is modified by both (1) and (2), have
a separate member variable for each. This way, the recalculation of (1) doesn't also clear
the state left over from the last time (2) was calculated (which will be recalculated by (2)
shortly thereafter). Use both member variables to decide whether theOverflowButtonshould
bevisible, allowing (1) and (2) to update independent of eachother.
- 6:17 PM Changeset in webkit [293657] by
-
- 5 edits in trunk/Source/JavaScriptCore
[JSC] Revive JSC's guard against speculation collection
https://bugs.webkit.org/show_bug.cgi?id=239939
Reviewed by Mark Lam.
r288815 dropped JSC's guard against structures in speculation collection, but this is wrong.
This patch reverts it back.
- Source/JavaScriptCore/bytecode/SpeculatedType.cpp:
(JSC::speculationFromCell):
- Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:
(JSC::StructureMemoryManager::StructureMemoryManager):
(JSC::StructureMemoryManager::tryMallocStructureBlock):
(JSC::StructureMemoryManager::freeStructureBlock):
(JSC::StructureAlignedMemoryAllocator::initializeStructureAddressSpace):
- Source/JavaScriptCore/runtime/JSCConfig.h:
- Source/JavaScriptCore/runtime/StructureID.h:
(JSC::StructureID::tryDecode const):
Canonical link: https://commits.webkit.org/250161@main
- 5:17 PM Changeset in webkit [293656] by
-
- 178 edits in trunk/Source
Prepare the rest of WebCore for making the AtomString(const String&) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=239917
Reviewed by Darin Adler.
Prepare the rest of WebCore for making the AtomString(const String&) constructor explicit.
This helps find suboptimal patterns in our code base, where we may be doing unnecessary
String allocations.
- Source/WebCore/PAL/pal/FileSizeFormatter.cpp:
(PAL::fileSizeDescription):
- Source/WebCore/PAL/pal/FileSizeFormatter.h:
- Source/WebCore/PAL/pal/cocoa/FileSizeFormatterCocoa.mm:
(PAL::fileSizeDescription):
- Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.idl:
- Source/WebCore/Modules/encryptedmedia/MediaKeyMessageEvent.idl:
- Source/WebCore/Modules/encryptedmedia/MediaKeySession.idl:
- Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl:
- Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl:
- Source/WebCore/Modules/mediarecorder/MediaRecorderErrorEvent.idl:
- Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.idl:
- Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.idl:
- Source/WebCore/Modules/mediastream/RTCErrorEvent.idl:
- Source/WebCore/Modules/mediastream/RTCPeerConnectionIceErrorEvent.idl:
- Source/WebCore/Modules/mediastream/RTCPeerConnectionIceEvent.idl:
- Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl:
- Source/WebCore/Modules/mediastream/RTCTrackEvent.idl:
- Source/WebCore/Modules/mediastream/RTCTransformEvent.idl:
- Source/WebCore/Modules/notifications/NotificationEvent.idl:
- Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.idl:
- Source/WebCore/Modules/paymentrequest/PaymentMethodChangeEvent.idl:
- Source/WebCore/Modules/paymentrequest/PaymentRequestUpdateEvent.idl:
- Source/WebCore/Modules/speech/SpeechRecognitionErrorEvent.idl:
- Source/WebCore/Modules/speech/SpeechRecognitionEvent.idl:
- Source/WebCore/Modules/speech/SpeechSynthesisEvent.idl:
- Source/WebCore/Modules/webxr/XRInputSourceEvent.idl:
- Source/WebCore/Modules/webxr/XRInputSourcesChangeEvent.idl:
- Source/WebCore/Modules/webxr/XRReferenceSpaceEvent.idl:
- Source/WebCore/Modules/webxr/XRSessionEvent.idl:
- Source/WebCore/bindings/IDLTypes.h:
(WebCore::IDLString::isNullValue):
- Source/WebCore/bindings/js/JSDOMConvertStrings.h:
(WebCore::propertyNameToString):
(WebCore::Converter<IDLLegacyNullToEmptyAtomStringAdaptor<T>>::convert):
(WebCore::JSConverter<IDLLegacyNullToEmptyAtomStringAdaptor<T>>::convert):
(WebCore::JSConverter<IDLAtomStringAdaptor<T>>::convert):
(WebCore::JSConverter<IDLAtomStringAdaptor<IDLUSVString>>::convert):
- Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributeGetterBodyDefinition):
(GetAnnotatedIDLType):
- Source/WebCore/bindings/scripts/test/TestPromiseRejectionEvent.idl:
- Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyValue):
- Source/WebCore/css/CSSProperties.json:
- Source/WebCore/css/DOMCSSCustomPropertyDescriptor.h:
- Source/WebCore/css/DOMCSSCustomPropertyDescriptor.idl:
- Source/WebCore/css/MediaQueryExpression.cpp:
(WebCore::consumeFirstValue):
- Source/WebCore/css/MediaQueryListEvent.idl:
- Source/WebCore/css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::setCustomProperty):
- Source/WebCore/css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseValueWithVariableReferences):
- Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseTypedCustomPropertyValue):
- Source/WebCore/css/parser/CSSPropertyParser.h:
- Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeFamilyNameRaw):
- Source/WebCore/dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocumentType):
(WebCore::DOMImplementation::createDocument):
- Source/WebCore/dom/DOMImplementation.h:
- Source/WebCore/dom/DOMImplementation.idl:
- Source/WebCore/dom/Document+HTMLObsolete.idl:
- Source/WebCore/dom/Document.cpp:
(WebCore::Document::createElementNS):
(WebCore::Document::formElementsState const):
(WebCore::Document::setStateForNewFormElements):
(WebCore::Document::parseQualifiedName):
(WebCore::Document::createAttributeNS):
(WebCore::Document::getCachedLocale):
(WebCore::Document::setBgColor):
(WebCore::Document::setFgColor):
(WebCore::Document::setAlinkColor):
(WebCore::Document::setLinkColorForBindings):
(WebCore::Document::setVlinkColor):
- Source/WebCore/dom/Document.h:
- Source/WebCore/dom/Document.idl:
- Source/WebCore/dom/Element.cpp:
(WebCore::Element::toggleAttribute):
(WebCore::Element::didAddAttribute):
(WebCore::Element::didModifyAttribute):
(WebCore::Element::didRemoveAttribute):
- Source/WebCore/dom/KeyboardEvent.idl:
- Source/WebCore/dom/MutationObserver.h:
- Source/WebCore/dom/MutationObserver.idl:
- Source/WebCore/dom/QualifiedName.h:
(WebCore::QualifiedName::toAtomString const):
- Source/WebCore/dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestModuleScript):
- Source/WebCore/editing/ApplyStyleCommand.cpp:
(WebCore::joinWithSpace):
- Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::inputEventTypeName const):
- Source/WebCore/editing/CompositeEditCommand.h:
- Source/WebCore/editing/CreateLinkCommand.cpp:
(WebCore::CreateLinkCommand::doApply):
- Source/WebCore/editing/EditCommand.cpp:
(WebCore::inputTypeNameForEditingAction):
- Source/WebCore/editing/EditCommand.h:
- Source/WebCore/editing/EditingStyle.cpp:
(WebCore::StyleChange::extractTextStyles):
- Source/WebCore/editing/EditingStyle.h:
(WebCore::StyleChange::fontColor):
(WebCore::StyleChange::fontFace):
(WebCore::StyleChange::fontSize):
- Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::applyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::Editor::insertAttachment):
(WebCore::Editor::styleForSelectionStart):
- Source/WebCore/editing/Editor.h:
- Source/WebCore/editing/EditorCommand.cpp:
(WebCore::executeFormatBlock):
(WebCore::executeInsertHorizontalRule):
(WebCore::executeInsertImage):
- Source/WebCore/editing/MarkupAccumulator.cpp:
(WebCore::shouldAddNamespaceElement):
(WebCore::MarkupAccumulator::generateUniquePrefix):
- Source/WebCore/editing/TextManipulationController.cpp:
(WebCore::TextManipulationController::replace):
- Source/WebCore/editing/TypingCommand.cpp:
(WebCore::TypingCommand::inputEventTypeName const):
- Source/WebCore/editing/TypingCommand.h:
- Source/WebCore/editing/WebContentReader.h:
- Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::createFragmentForImageAttachment):
(WebCore::replaceRichContentWithAttachments):
(WebCore::createFragmentAndAddResources):
(WebCore::sanitizeMarkupWithArchive):
(WebCore::attachmentForFilePath):
(WebCore::attachmentForData):
(WebCore::WebContentReader::readURL):
(WebCore::WebContentReader::readDataBuffer):
- Source/WebCore/editing/markup.cpp:
(WebCore::AttributeChange::AttributeChange):
(WebCore::completeURLs):
(WebCore::replaceSubresourceURLs):
(WebCore::StyledMarkupAccumulator::appendCustomAttributes):
(WebCore::createFragmentForImageAndURL):
- Source/WebCore/history/HistoryItem.cpp:
(WebCore::HistoryItem::setDocumentState):
(WebCore::HistoryItem::documentState const):
- Source/WebCore/history/HistoryItem.h:
- Source/WebCore/html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::createTDForFilename):
- Source/WebCore/html/FileInputType.cpp:
(WebCore::FileInputType::saveFormControlState const):
- Source/WebCore/html/FormController.cpp:
(WebCore::StringVectorReader::consumeString):
(WebCore::StringVectorReader::consumeSubvector):
(WebCore::appendSerializedFormControlState):
(WebCore::FormController::formElementsState const):
(WebCore::FormController::setStateForNewFormElements):
(WebCore::FormController::parseStateVector):
(WebCore::FormController::referencedFilePaths):
- Source/WebCore/html/FormController.h:
- Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):
- Source/WebCore/html/HTMLAreaElement.idl:
- Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::setFile):
(WebCore::HTMLAttachmentElement::updateAttributes):
(WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):
- Source/WebCore/html/HTMLAttachmentElement.h:
- Source/WebCore/html/HTMLBaseElement.idl:
- Source/WebCore/html/HTMLButtonElement.idl:
- Source/WebCore/html/HTMLCollection.cpp:
(WebCore::HTMLCollection::isSupportedPropertyName):
- Source/WebCore/html/HTMLCollection.h:
- Source/WebCore/html/HTMLFormControlElementWithState.h:
- Source/WebCore/html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::namedItemOrItems const):
- Source/WebCore/html/HTMLFormControlsCollection.h:
- Source/WebCore/html/HTMLFormElement.idl:
- Source/WebCore/html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::openURL):
- Source/WebCore/html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::shouldLoadFrameLazily):
- Source/WebCore/html/HTMLIFrameElement.idl:
- Source/WebCore/html/HTMLImageElement.idl:
- Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
- Source/WebCore/html/HTMLInputElement.idl:
- Source/WebCore/html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::parseAttribute):
- Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setPreload):
- Source/WebCore/html/HTMLMediaElement.h:
- Source/WebCore/html/HTMLMediaElement.idl:
- Source/WebCore/html/HTMLOrForeignElement.idl:
- Source/WebCore/html/HTMLSelectElement.idl:
- Source/WebCore/html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::saveFormControlState const):
- Source/WebCore/html/HTMLTextAreaElement.idl:
- Source/WebCore/html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::HTMLVideoElement):
- Source/WebCore/html/HiddenInputType.cpp:
(WebCore::HiddenInputType::saveFormControlState const):
(WebCore::HiddenInputType::restoreFormControlState):
(WebCore::HiddenInputType::setValue):
- Source/WebCore/html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure):
- Source/WebCore/html/InputType.cpp:
(WebCore::InputType::saveFormControlState const):
- Source/WebCore/html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::MediaDocument::replaceMediaElementTimerFired):
- Source/WebCore/html/ModelDocument.cpp:
(WebCore::ModelDocumentParser::createDocumentStructure):
- Source/WebCore/html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
- Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createAutoFillButton):
(WebCore::TextFieldInputType::updateAutoFillButton):
- Source/WebCore/html/canvas/WebGLContextEvent.idl:
- Source/WebCore/html/parser/HTMLMetaCharsetParser.cpp:
(WebCore::HTMLMetaCharsetParser::processMeta):
(WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
- Source/WebCore/html/parser/HTMLMetaCharsetParser.h:
- Source/WebCore/html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
- Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
(WebCore::createForeignAttributesMap):
- Source/WebCore/html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::create):
- Source/WebCore/html/track/AudioTrack.cpp:
(WebCore::AudioTrack::updateKindFromPrivate):
- Source/WebCore/html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::LoadableTextTrack):
(WebCore::LoadableTextTrack::create):
- Source/WebCore/html/track/LoadableTextTrack.h:
- Source/WebCore/html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::setId):
- Source/WebCore/html/track/TextTrackCue.h:
(WebCore::TextTrackCue::id const):
- Source/WebCore/html/track/TextTrackCue.idl:
- Source/WebCore/html/track/TrackEvent.idl:
- Source/WebCore/html/track/VideoTrack.cpp:
(WebCore::VideoTrack::updateKindFromPrivate):
- Source/WebCore/html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::collectWebVTTBlock):
(WebCore::WebVTTParser::collectCueId):
(WebCore::WebVTTParser::resetCueValues):
- Source/WebCore/html/track/WebVTTParser.h:
- Source/WebCore/inspector/DOMEditor.cpp:
(WebCore::DOMEditor::setAttribute):
(WebCore::DOMEditor::removeAttribute):
- Source/WebCore/inspector/DOMEditor.h:
- Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp:
(WebCore::InspectorAuditAccessibilityObject::getComputedProperties):
- Source/WebCore/inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::drawRulers):
- Source/WebCore/inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
- Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setAttributeValue):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeAttribute):
(WebCore::InspectorDOMAgent::setNodeName):
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
- Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::interceptWithResponse):
(WebCore::InspectorNetworkAgent::interceptRequestWithResponse):
- Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadPostRequest):
- Source/WebCore/loader/HistoryController.cpp:
(WebCore::FrameLoader::HistoryController::recursiveSetProvisionalItem):
- Source/WebCore/loader/PolicyChecker.cpp:
(WebCore::FrameLoader::PolicyChecker::checkNewWindowPolicy):
- Source/WebCore/loader/PolicyChecker.h:
- Source/WebCore/page/PageSerializer.cpp:
(WebCore::isCharsetSpecifyingNode):
- Source/WebCore/platform/Pasteboard.h:
(WebCore::PasteboardWebContentReader::readDataBuffer):
- Source/WebCore/platform/graphics/InbandGenericCue.h:
(WebCore::GenericCueData::GenericCueData):
(WebCore::GenericCueData::decode):
(WebCore::InbandGenericCue::id const):
(WebCore::InbandGenericCue::setId):
- Source/WebCore/platform/graphics/avfoundation/objc/InbandChapterTrackPrivateAVFObjC.mm:
(WebCore::InbandChapterTrackPrivateAVFObjC::processChapters):
- Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp:
(WebCore::ISOWebVTTCue::ISOWebVTTCue):
(WebCore::ISOWebVTTCue::parse):
- Source/WebCore/platform/graphics/iso/ISOVTTCue.h:
- Source/WebCore/platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::read):
- Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp:
(WebCore::RealtimeVideoCaptureSource::RealtimeVideoCaptureSource):
- Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.h:
- Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):
- Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.h:
- Source/WebCore/platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:
(WebCore::MockRealtimeVideoSource::create):
(WebCore::MockRealtimeVideoSourceMac::createForMockDisplayCapturer):
(WebCore::MockRealtimeVideoSourceMac::MockRealtimeVideoSourceMac):
- Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockDisplayCapturer::MockDisplayCapturer):
- Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::create):
(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):
- Source/WebCore/platform/mock/MockRealtimeVideoSource.h:
- Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertStringOrAutoAtom):
(WebCore::Style::BuilderConverter::convertStringOrNoneAtom):
- Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueContent):
- Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::shadowPseudoId):
(WebCore::Internals::setShadowPseudoId):
(WebCore::Internals::formControlStateOfPreviousHistoryItem):
(WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::highlightPseudoElementColor):
- Source/WebCore/testing/Internals.h:
- Source/WebCore/testing/Internals.idl:
- Source/WebCore/testing/MockCDMFactory.cpp:
(WebCore::MockCDMFactory::setSupportedRobustness): Deleted.
- Source/WebCore/testing/MockCDMFactory.h:
(WebCore::MockCDMFactory::setSupportedRobustness):
- Source/WebCore/testing/MockCDMFactory.idl:
Canonical link: https://commits.webkit.org/250160@main
- 1:16 PM Changeset in webkit [293655] by
-
- 3 edits in trunk/LayoutTests
[GLIB] Update test expectations. Unreviewed test gardening.
https://bugs.webkit.org/show_bug.cgi?id=239945
Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-05-01
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- 8:08 AM Changeset in webkit [293654] by
-
- 2 edits in trunk/Source/JavaScriptCore
[RISCV64] Implement MacroAssembler::probe(), ctiMasmProbeTrampoline
https://bugs.webkit.org/show_bug.cgi?id=239938
Reviewed by Yusuke Suzuki.
Implement MacroAssembler::probe() for RISCV64, along with the
ctiMasmProbeTrampoline operation. The implementation follows the process
of implementations for other platforms, with incoming, outgoing and
return-address-restoration records used to store register values during
setup and breakdown of the probe.
Going into the probe and back out of it, the general-purpose and
floating-point registers are stored, with the exception of global and
thread registers (x3 and x4). After the probe, if the probe state on the
stack is broken, the complete state is re-established before the
registers are reloaded, with the stack pointer and return address
registers set up last.
Covered by probing-related unit tests in testmasm.
- assembler/MacroAssemblerRISCV64.cpp:
(JSC::MacroAssembler::probe):
- 8:05 AM Changeset in webkit [293653] by
-
- 2 edits in trunk/Source/JavaScriptCore
[RISCV64] Enable testmasm execution
https://bugs.webkit.org/show_bug.cgi?id=239937
Reviewed by Yusuke Suzuki.
In testmasm, enable some additional sets of tests for RISCV64 that cover
already-functioning behavior. In isSpecialGPR(), the function returns
true under CPU(RISCV64) for the appropriate registers.
In invoke(), when targeting RISCV64 and invoking JIT-produced code whose
return type is a 32-bit integer, the resulting value is manually
sign-extended to paper over the mismatch between zero-extended 32-bit
values that are used and produced in JSC JIT and the sign-extended
32-bit values that are expected in the RV64 calling convention.
- assembler/testmasm.cpp:
(JSC::isSpecialGPR):
(JSC::invoke):
(JSC::testProbePreservesGPRS):
(JSC::testLoadBaseIndex):
(JSC::testStoreBaseIndex):
- 7:18 AM Changeset in webkit [293652] by
-
- 2 edits1 delete in trunk/LayoutTests
[GStreamer] tests gardening
https://bugs.webkit.org/show_bug.cgi?id=239943
Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-01
Unreviewed, update a couple media-recorder and media-capabilities expectations.
- platform/glib/TestExpectations:
- platform/wpe/http/wpt/mediarecorder/MediaRecorder-dataavailable-expected.txt: Removed.
- platform/wpe/http/wpt/mediarecorder/MediaRecorder-mock-dataavailable-expected.txt: Removed.
Canonical link: https://commits.webkit.org/250156@main
- 1:51 AM Changeset in webkit [293651] by
-
- 2 edits in trunk/Tools
[WPE][GTK] Built product archives include old library files
https://bugs.webkit.org/show_bug.cgi?id=239928
Patch by Philippe Normand <pnormand@igalia.com> on 2022-05-01
Reviewed by Adrian Perez de Castro.
- CISupport/built-product-archive: Exclude old WPE/GTK files from built product zip archives.
Canonical link: https://commits.webkit.org/250155@main
Apr 30, 2022:
- 7:42 PM Changeset in webkit [293650] by
-
- 15 edits in trunk/Source/WebCore
Code cleanup in preparation for refactoring of computing relationships between AXObjects.
https://bugs.webkit.org/show_bug.cgi?id=239848
<rdar://problem/92455544>
Reviewed by Chris Fleizach and Tyler Wilcock.
No new functionality.
AccessibilityObject::ariaElementsFromAttribute() and
ariaElementsReferencedByAttribute() are the methods that currently
compute the relationships between objects. These methods now return a
vector of the related objects instead of taking an out parameter.
In addition, all ariaXXXElements and ariaXXXReferencingElements methods
are renamed to better reflect the relationships they retrieve. Note that
the prefix aria is removed from all method names because ARIA is one way
of establishing relationships between objects, but not necessarily the
only way. These changes make the code more concise and clearer.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement const):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::ariaElementsFromAttribute const):
(WebCore::AccessibilityObject::ariaElementsReferencedByAttribute const):
(WebCore::AccessibilityObject::isActiveDescendantOfFocusedContainer const):
(WebCore::AccessibilityObject::activeDescendantOfObjects const):
(WebCore::AccessibilityObject::controlledObjects const):
(WebCore::AccessibilityObject::controllers const):
(WebCore::AccessibilityObject::describedByObjects const):
(WebCore::AccessibilityObject::descriptionForObjects const):
(WebCore::AccessibilityObject::detailedByObjects const):
(WebCore::AccessibilityObject::detailsForObjects const):
(WebCore::AccessibilityObject::errorMessageObjects const):
(WebCore::AccessibilityObject::errorMessageForObjects const):
(WebCore::AccessibilityObject::flowToObjects const):
(WebCore::AccessibilityObject::flowFromObjects const):
(WebCore::AccessibilityObject::labelledByObjects const):
(WebCore::AccessibilityObject::labelForObjects const):
(WebCore::AccessibilityObject::ownedObjects const):
(WebCore::AccessibilityObject::owners const):
(WebCore::AccessibilityObject::ariaActiveDescendantReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaControlsElements const): Deleted.
(WebCore::AccessibilityObject::ariaControlsReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaDescribedByElements const): Deleted.
(WebCore::AccessibilityObject::ariaDescribedByReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaDetailsElements const): Deleted.
(WebCore::AccessibilityObject::ariaDetailsReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaErrorMessageElements const): Deleted.
(WebCore::AccessibilityObject::ariaErrorMessageReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaFlowToElements const): Deleted.
(WebCore::AccessibilityObject::ariaFlowToReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaLabelledByElements const): Deleted.
(WebCore::AccessibilityObject::ariaLabelledByReferencingElements const): Deleted.
(WebCore::AccessibilityObject::ariaOwnsElements const): Deleted.
(WebCore::AccessibilityObject::ariaOwnsReferencingElements const): Deleted.
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityObjectInterface.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::linkedUIElements const):
(WebCore::AccessibilityRenderObject::targetElementForActiveDescendant const):
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::columnHeaders):
(WebCore::AccessibilityTableCell::ariaOwnedByParent const):
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::addChildren):
- accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::relationMap const):
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
(WebCore::AXIsolatedObject::activeDescendantOfObjects const):
(WebCore::AXIsolatedObject::controllers const):
(WebCore::AXIsolatedObject::describedByObjects const):
(WebCore::AXIsolatedObject::descriptionForObjects const):
(WebCore::AXIsolatedObject::detailsForObjects const):
(WebCore::AXIsolatedObject::errorMessageForObjects const):
(WebCore::AXIsolatedObject::flowFromObjects const):
(WebCore::AXIsolatedObject::labelledByObjects const):
(WebCore::AXIsolatedObject::labelForObjects const):
(WebCore::AXIsolatedObject::owners const):
(WebCore::AXIsolatedObject::ariaActiveDescendantReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaControlsReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaDescribedByElements const): Deleted.
(WebCore::AXIsolatedObject::ariaDescribedByReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaDetailsReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaErrorMessageReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaFlowToReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaLabelledByElements const): Deleted.
(WebCore::AXIsolatedObject::ariaLabelledByReferencingElements const): Deleted.
(WebCore::AXIsolatedObject::ariaOwnsReferencingElements const): Deleted.
- accessibility/isolatedtree/AXIsolatedObject.h:
- accessibility/isolatedtree/AXIsolatedTree.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- 9:57 AM Changeset in webkit [293649] by
-
- 3 edits in trunk
[WPE][GTK] Enable MEDIA_SESSION by default
https://bugs.webkit.org/show_bug.cgi?id=239931
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-30
Reviewed by Michael Catanzaro.
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsWPE.cmake:
Canonical link: https://commits.webkit.org/250153@main
- 9:50 AM Changeset in webkit [293648] by
-
- 6 edits in trunk
REGRESSION(r283437) a number of media tests fail/timeout on the test bots
https://bugs.webkit.org/show_bug.cgi?id=231811
<rdar://problem/84552871>
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-30
Reviewed by Michael Catanzaro.
Disable DBus MPRIS notifications when running the tests, these leak to the host when running
on desktop and trigger timeouts on under-powered bots.
- platform/audio/glib/MediaSessionGLib.cpp:
(WebCore::MediaSessionGLib::create):
(WebCore::MediaSessionGLib::MediaSessionGLib):
(WebCore::MediaSessionGLib::emitPositionChanged):
(WebCore::MediaSessionGLib::updateNowPlaying):
(WebCore::MediaSessionGLib::playbackStatusChanged):
- platform/audio/glib/MediaSessionManagerGLib.h:
(WebCore::MediaSessionManagerGLib::setDBusNotificationsEnabled):
(WebCore::MediaSessionManagerGLib::areDBusNotificationsEnabled const):
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
LayoutTests:
- platform/glib/TestExpectations: Unflag tests now passing.
Canonical link: https://commits.webkit.org/250152@main
- 9:30 AM Changeset in webkit [293647] by
-
- 2 edits in trunk/Source/WebCore
Only stretch the percent height <body> when it is the document element's child
https://bugs.webkit.org/show_bug.cgi?id=239932
<rdar://92257660>
Reviewed by Antti Koivisto.
This IE quirk should only be applied to when the body is actually the document element's child (stretching case).
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight const):
- rendering/RenderBox.h:
(WebCore::RenderBox::parentBox const):
- 8:30 AM Changeset in webkit [293646] by
-
- 5 edits2 adds in trunk
ASSERTION FAILED: *trailingRunIndex >= overflowingRunIndex in WebCore::Layout::InlineContentBreaker::tryBreakingNextOverflowingRuns
https://bugs.webkit.org/show_bug.cgi?id=239838
<rdar://problem/92455051>
Reviewed by Antti Koivisto.
Source/WebCore:
Take partial text overflow into account when computing intrinsic width.
Test: fast/inline/overflowing-content-inside-inline-box-crash.html
- layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthForConstraint const):
- layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
- layout/formattingContexts/inline/InlineLineBuilder.h:
LayoutTests:
- fast/inline/overflowing-content-inside-inline-box-crash-expected.txt: Added.
- fast/inline/overflowing-content-inside-inline-box-crash.html: Added.
- 6:11 AM Changeset in webkit [293645] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Introduce LineBuilder::PartialContent
https://bugs.webkit.org/show_bug.cgi?id=239886
Reviewed by Antti Koivisto.
This patch is in preparation for adding partial content support for intrinsic width computation.
- Use a dedicated PartialContent structure to store partial overflowing information (output of current line breaking, input to next line).
- Decouple partial overflowing width (see above) and the "let's not measure the wrapped content again on the next line as leading content" cached value.
- layout/formattingContexts/inline/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::lineLayout):
- layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::initialize):
- layout/formattingContexts/inline/InlineLineBuilder.h:
(WebCore::Layout::LineBuilder::PartialContent::PartialContent):
- 6:01 AM Changeset in webkit [293644] by
-
- 3 edits2 adds in trunk
[LFC][IFC] Do not wrap </span> to the next line when it is preceded by overflowing text
https://bugs.webkit.org/show_bug.cgi?id=239879
<rdar://problem/92497176>
Reviewed by Antti Koivisto.
Source/WebCore:
This patch makes sure that inline content run(s) ("X") followed by inline box end run(s) (</span></span>)
don't get separated when they overflow the line (e.g. width: 0px).
Test: fast/inline/overflowing-content-inside-inline-box.html
- layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::processOverflowingContent const):
LayoutTests:
- fast/inline/overflowing-content-inside-inline-box-expected.html: Added.
- fast/inline/overflowing-content-inside-inline-box.html: Added.
- 12:26 AM Changeset in webkit [293643] by
-
- 3 edits in trunk/Source/ThirdParty/libwebrtc
[Mac] VTVideoDecoderClass object pointers can become unaligned on x86
https://bugs.webkit.org/show_bug.cgi?id=239916
<rdar://92445366>
Reviewed by Eric Carlson.
Both the base class and the derived class must be 4-byte aligned on x86, or there
is a chance that a pointer member of that struct will cross a page boundary, and
dereferencing that pointer will fail.
- Source/webrtc/sdk/WebKit/WebKitVP8Decoder.cpp:
- Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:
Apr 29, 2022:
- 11:07 PM Changeset in webkit [293642] by
-
- 3 edits2 adds in trunk
REGRESSION(r290770): element.scrollIntoViewIfNeeded() scrolls to top even when element is already in viewport
https://bugs.webkit.org/show_bug.cgi?id=238985
Patch by Rob Buis <rbuis@igalia.com> on 2022-04-29
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/css/cssom-view/scrollintoview-zero-height-item-expected.txt: Added.
- web-platform-tests/css/cssom-view/scrollintoview-zero-height-item.html: Added.
Source/WebCore:
This mostly reverts to the code as it was before r290770, but adds code to
treat non-intersections as hidden, including zero width/height rects.
Test: imported/w3c/web-platform-tests/css/cssom-view/scrollintoview-zero-height-item.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::getRectToExpose const):
- 8:37 PM Changeset in webkit [293641] by
-
- 2 edits in trunk/Source/WebCore
The isYahooMail quirk is specific to PLATFORM(IOS_FAMILY)
https://bugs.webkit.org/show_bug.cgi?id=239914
Reviewed by Simon Fraser.
The isYahooMail check is incorrectly guarded by ENABLE(PUBLIC_SUFFIX_LIST) when the only
using this function is guarded by ENABLE(IOS_TOUCH_EVENTS) and PLATFORM(IOS_FAMILY). Use
PLATFORM(IOS_FAMILY) since ENABLE(IOS_TOUCH_EVENTS) implies that anyways.
Fixes an unused function warning for other ports.
- page/Quirks.cpp:
- 6:37 PM Changeset in webkit [293640] by
-
- 2 edits in trunk/LayoutTests
[ Monterey WK2 ] media/media-source/media-source-webm-vorbis-partial.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=239308
rdar://91719356
Patch by Jean-Yves Avenard <jean-yves.avenard@apple.com> on 2022-04-29
Reviewed by Jer Noble.
The test disabled the GPU process, and sandboxing rules prevent from
calling CoreMedia in the content process.
- media/media-source/media-source-webm-vorbis-partial.html:
# Please populate the above commit message. Lines starting
# with '#' will be ignored
# Reviewed by Jer Noble.
# On branch 239308
# Your branch is ahead of 'origin/main' by 1 commit.
# (use "git push" to publish your local commits)
#
# Changes to be committed:
# (use "git restore --staged <file>..." to unstage)
# modified: LayoutTests/ChangeLog
#
Canonical link: https://commits.webkit.org/250144@main
- 5:47 PM Changeset in webkit [293639] by
-
- 12 edits in trunk
Unreviewed, reverting r293621.
Reverting patch while we fix internal EWS issues, will reland
Source/JavaScriptCore:
after.
Reverted changeset:
https://commits.webkit.org/r293621
Source/WTF:
after
Reverted changeset:
https://commits.webkit.org/r293621
Tools:
after
Reverted changeset:
- 5:18 PM Changeset in webkit [293638] by
-
- 4 edits in trunk
[Mail compose] Images with data URLs should be pasted or dropped as attachments
https://bugs.webkit.org/show_bug.cgi?id=239911
rdar://91658665
Reviewed by Tim Horton.
Source/WebCore:
Effectively revert the changes in r226340, which prevented data-URL and http-family-URL images from being
converted into attachments when pasting or dropping into Mail compose. The original intent behind this change
may have been to save Mail storage space (in the server and in the on-disk cache) by excluding remote images,
but this was changed in r291261 due to being a regression in behavior compared to legacy WebKit compose
behavior, which creates attachments when pasting or dropping both data and remote images.
Furthermore, the space-saving rationale never really made sense for image data URLs, which are encoded in base
64, since this base 64 representation is always going to be larger than the raw binary representation that we
would otherwise use for a normal attachment.
Test: WKAttachmentTests.InsertDataURLImagesAsAttachments
- editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::shouldReplaceSubresourceURLWithBlobDuringSanitization):
Remove the argument flag enum altogether, and rename this method to clarify that it is just about blob URL
replacement for sanitizing pasted/dropped fragments (rather than attachment replacement).
(WebCore::replaceRichContentWithAttachments):
(WebCore::sanitizeMarkupWithArchive):
(WebCore::WebContentReader::readHTML):
(WebCore::WebContentMarkupReader::readHTML):
(WebCore::shouldReplaceSubresourceURL): Deleted.
Tools:
Adjust expectations for an existing API test.
- TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::TEST):
- 4:23 PM Changeset in webkit [293637] by
-
- 16 edits in trunk/Source
Reduce usage of std::unique_ptr<HashSet> / std::unique_ptr<HashMap>
https://bugs.webkit.org/show_bug.cgi?id=239903
Reviewed by Yusuke Suzuki.
Reduce usage of std::unique_ptr<HashSet> / std::unique_ptr<HashMap> as HashSet / HashMap
are already essentially pointers. This avoids some unnecessary dereferencing.
- Source/JavaScriptCore/heap/Heap.cpp:
(JSC::Heap::addCoreConstraints):
- Source/JavaScriptCore/heap/Heap.h:
- Source/JavaScriptCore/heap/HeapInlines.h:
- Source/WebKit/WebProcess/WebCoreSupport/WebPasteboardOverrides.cpp:
(WebKit::WebPasteboardOverrides::addOverride):
(WebKit::WebPasteboardOverrides::removeOverride):
(WebKit::WebPasteboardOverrides::overriddenTypes):
(WebKit::WebPasteboardOverrides::getDataForOverride const):
- Source/WebKit/WebProcess/WebCoreSupport/WebPasteboardOverrides.h:
- Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::recordCreatingDatabase):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::creatingDatabase):
(WebCore::DatabaseTracker::recordDeletingDatabase):
(WebCore::DatabaseTracker::doneDeletingDatabase):
(WebCore::DatabaseTracker::isDeletingDatabase):
(WebCore::DatabaseTracker::canDeleteOrigin):
- Source/WebCore/Modules/webdatabase/DatabaseTracker.h:
- Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::wrapForDeprecatedCSSOM):
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::didMutate):
- Source/WebCore/css/PropertySetCSSStyleDeclaration.h:
- Source/WebCore/dom/MutationObserver.cpp:
(WebCore::MutationObserver::deliver):
- Source/WebCore/dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::takeTransientRegistrations):
(WebCore::MutationObserverRegistration::isReachableFromOpaqueRoots const):
- Source/WebCore/dom/MutationObserverRegistration.h:
(WebCore::MutationObserverRegistration::hasTransientRegistrations const):
- Source/WebCore/platform/graphics/GlyphMetricsMap.h:
(WebCore::GlyphMetricsMap<T>::locatePageSlowCase):
- Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::insertIntoTrackedRendererMaps):
(WebCore::removeFromTrackedRendererMaps):
(WebCore::removeBlockFromPercentageDescendantAndContainerMaps):
- Source/WebCore/style/StyleScope.cpp:
(WebCore::Style::Scope::updateActiveStyleSheets):
(WebCore::Style::Scope::activeStyleSheetsContains const):
- Source/WebCore/style/StyleScope.h:
Canonical link: https://commits.webkit.org/250141@main
- 4:15 PM Changeset in webkit [293636] by
-
- 7 edits in trunk/Source/WebKit
[GPUProcess] Stop using a synchronous IPC for marking layers as volatile
https://bugs.webkit.org/show_bug.cgi?id=239901
<rdar://91663593>
Reviewed by Geoffrey Garen.
Stop using a synchronous IPC to the GPUProcess for marking layers as volatile. Instead,
use an asynchronous IPC for the request and another asynchronous one for the response.
Ideally, we'd be using a sendWithAsyncReply(), like the FIXME comment in the code
suggested. However, this is not supported yet by our new "streaming" IPC.
- Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::markSurfacesVolatile):
- Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
- Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in:
- Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::~RemoteRenderingBackendProxy):
(WebKit::RemoteRenderingBackendProxy::markSurfacesVolatile):
(WebKit::RemoteRenderingBackendProxy::didMarkLayersAsVolatile):
- Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
- Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.messages.in:
- Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::tryMarkLayersVolatileCompletionHandler):
Canonical link: https://commits.webkit.org/250140@main
- 3:54 PM Changeset in webkit [293635] by
-
- 2 edits in trunk/Source/WebCore
increase transient activation duration to 5s
https://bugs.webkit.org/show_bug.cgi?id=239832
Reviewed by Geoffrey Garen.
This matches other user agents and gives a bit more time for asynchronous work to be done.
Spec: <https://html.spec.whatwg.org/multipage/interaction.html#transient-activation-duration>
- page/DOMWindow.cpp:
- 3:40 PM Changeset in webkit [293634] by
-
- 19 edits in branches/safari-613-branch/Source
Cherry-pick r287877. rdar://problem/92357915
Non-unified build fixes, early January 2022 edition
https://bugs.webkit.org/show_bug.cgi?id=235013
Unreviewed non-unified build fixes.
Source/JavaScriptCore:
- wasm/js/JSWebAssemblyModule.cpp: Add missing JSWebAssemblyLinkError.h header.
- wasm/js/JSWebAssemblyModule.h: Add missing forward declaration for the JSC::OptimizingCallLinkInfo type.
Source/WebCore:
No new tests needed.
- Modules/fetch/FetchBodyConsumer.cpp: Add missing FormData.h header.
- Modules/fetch/FormDataConsumer.h: Add missing ExceptionOr.h header, and forward declaration for the WebCore::ScriptExecutionContext type.
- animation/CSSAnimation.cpp: Add missing KeyframeEffect.h header.
- animation/KeyframeEffect.cpp: Add missing StyledElement.h header.
- html/HTMLFormElement.cpp: Add missing PseudoClassChangeInvalidation.h header.
- platform/network/SynchronousLoaderClient.cpp: Add missing SharedBuffer.h header.
- rendering/svg/RenderSVGBlock.cpp: Add missing SVGRenderSupport.h header.
- rendering/svg/RenderSVGForeignObject.cpp: Ditto.
- rendering/svg/RenderSVGInline.cpp: Ditto.
- rendering/svg/RenderSVGModelObject.cpp: Add missing SVGElementInlines.h header.
- rendering/svg/SVGInlineTextBox.cpp: Add missing FloatConversion.h header.
- svg/SVGViewElement.cpp: Add missing RenderElement.h header.
- workers/service/context/ServiceWorkerFetch.h: Add missing forward declaration for the WebCore::SharedBuffer type, remove unused one for WebCore::FragmentedSharedBuffer.
Source/WebKit:
- Platform/IPC/SharedBufferCopy.cpp: Add missing WebCoreArgumentCoders.h header, remove now unneeded ArgumentCoders.h header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:40 PM Changeset in webkit [293633] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, reverting r293481.
https://bugs.webkit.org/show_bug.cgi?id=239908
Introduced perf regression
Reverted changeset:
"Adjust what we consider to be private relayed"
https://bugs.webkit.org/show_bug.cgi?id=239784
https://commits.webkit.org/r293481
- 3:26 PM Changeset in webkit [293632] by
-
- 1 copy in tags/WebKit-7614.1.11.1
Tag WebKit-7614.1.11.1.
- 2:50 PM Changeset in webkit [293631] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Regression(r267038) Import a timeline does not render the timeline, only lists the events
https://bugs.webkit.org/show_bug.cgi?id=239872
Reviewed by Devin Rousso.
Two issues existed after r267038 that prevented the timeline overview from rendering correctly for imported
recordings. The first is that the timeline view itself was not visible as the result of assuming that we would
already be in middle of layout when insideWI.TimelineRecordingContentView.prototype._updateTimes, which isn't
true for the updating of times when importing a recording. In that case, syncronously attempting to lay out the
view means that the layout, including initial layout, will be performed before the view is attached, which means
we are unable to get the clientWidth of the view's element during layout, which in turn prevents us from
painting the timeline ruler.
The second issue is that when importing a timeline, we should ignore the current capturing state when setting
the current, start, and end times, otherwise not all the values will be kept.
- UserInterface/Views/TimelineRecordingContentView.js:
(WI.TimelineRecordingContentView):
(WI.TimelineRecordingContentView.prototype._updateTimes):
- 2:38 PM Changeset in webkit [293630] by
-
- 2 edits in trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy
Corrected spelling of edited in webkitscmpy.
- 1:05 PM Changeset in webkit [293629] by
-
- 16 edits in trunk/Source/JavaScriptCore
[JSC] Use FixedVector in JumpReplacements and VariableEventStream
https://bugs.webkit.org/show_bug.cgi?id=239892
Reviewed by Mark Lam.
- Introduce DFG::VariableEventStreamBuilder. And construct DFG::VariableEventStream from that
builder when finailizing code generation. We also make it FixedVector.
- Use FixedVector for JumpReplacements.
- Source/JavaScriptCore/dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::shrinkToFit):
- Source/JavaScriptCore/dfg/DFGCommonData.h:
- Source/JavaScriptCore/dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::noticeOSRBirth):
(JSC::DFG::GenerationInfo::use):
(JSC::DFG::GenerationInfo::spill):
(JSC::DFG::GenerationInfo::setSpilled):
(JSC::DFG::GenerationInfo::fillGPR):
(JSC::DFG::GenerationInfo::fillJSValue):
(JSC::DFG::GenerationInfo::fillCell):
(JSC::DFG::GenerationInfo::fillInt32):
(JSC::DFG::GenerationInfo::fillInt52):
(JSC::DFG::GenerationInfo::fillStrictInt52):
(JSC::DFG::GenerationInfo::fillBoolean):
(JSC::DFG::GenerationInfo::fillDouble):
(JSC::DFG::GenerationInfo::fillStorage):
(JSC::DFG::GenerationInfo::appendBirth):
(JSC::DFG::GenerationInfo::appendFill):
(JSC::DFG::GenerationInfo::appendSpill):
- Source/JavaScriptCore/dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::shrinkToFit):
(JSC::DFG::JITCode::reconstruct):
- Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::exceptionCheck):
- Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h:
(JSC::DFG::SlowPathGenerator::SlowPathGenerator):
- Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::emitInvalidationPoint):
(JSC::DFG::SpeculativeJIT::addSlowPathGeneratorLambda):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::compileDeleteById):
(JSC::DFG::SpeculativeJIT::compileDeleteByVal):
(JSC::DFG::SpeculativeJIT::compileInById):
(JSC::DFG::SpeculativeJIT::compileInByVal):
(JSC::DFG::SpeculativeJIT::compileHasPrivate):
(JSC::DFG::SpeculativeJIT::noticeOSRBirth):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::compilePutByVal):
- Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::finalizeEventStream):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::spill):
(JSC::DFG::SpeculativeJIT::recordSetLocal):
- Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileGetByVal):
- Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedGetByIdWithThis):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::fillSpeculateBigInt32):
(JSC::DFG::SpeculativeJIT::compileGetByVal):
(JSC::DFG::SpeculativeJIT::compile):
- Source/JavaScriptCore/dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStreamBuilder::logEvent):
(JSC::DFG::VariableEventStream::reconstruct const):
(JSC::DFG::VariableEventStream::logEvent): Deleted.
- Source/JavaScriptCore/dfg/DFGVariableEventStream.h:
(JSC::DFG::VariableEventStream::VariableEventStream):
(JSC::DFG::VariableEventStreamBuilder::appendAndLog):
(JSC::DFG::VariableEventStreamBuilder::size const):
(JSC::DFG::VariableEventStreamBuilder::finalize):
(JSC::DFG::VariableEventStream::appendAndLog): Deleted.
- Source/JavaScriptCore/ftl/FTLLink.cpp:
(JSC::FTL::link):
- Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
- Source/JavaScriptCore/ftl/FTLState.h:
Canonical link: https://commits.webkit.org/250135@main
- 12:41 PM Changeset in webkit [293628] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, reverting r293591.
https://bugs.webkit.org/show_bug.cgi?id=239907
Did not resolve perf issue
Reverted changeset:
"Set top origin of CORS preflight requests"
https://bugs.webkit.org/show_bug.cgi?id=239869
https://commits.webkit.org/r293591
- 12:41 PM Changeset in webkit [293627] by
-
- 9 edits in trunk/Source
Update toExistingAtomString() to return an AtomString
https://bugs.webkit.org/show_bug.cgi?id=239904
Reviewed by Darin Adler.
Update toExistingAtomString() to return an AtomString instead of a RefPtr<AtomStringImpl>
as it is a bit less awkward to use.
- Source/JavaScriptCore/dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
- Source/JavaScriptCore/jit/JITOperations.cpp:
(JSC::getByVal):
(JSC::JSC_DEFINE_JIT_OPERATION):
- Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:
(JSC::LLInt::getByVal):
- Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:
(JSC::JSC_DEFINE_COMMON_SLOW_PATH):
- Source/JavaScriptCore/runtime/JSString.h:
(JSC::JSString::toExistingAtomString const):
- Source/WTF/wtf/text/StringView.h:
(WTF::StringView::toExistingAtomString const):
- Source/WebCore/bindings/js/JSDOMConvertStrings.h:
(WebCore::Converter<IDLRequiresExistingAtomStringAdaptor<T>>::convert):
- Source/WebCore/dom/TreeScope.cpp:
(WebCore::TreeScope::getElementById const):
- Source/WebCore/platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::loadResourceSynchronously):
Canonical link: https://commits.webkit.org/250133@main
- 12:25 PM Changeset in webkit [293626] by
-
- 2 edits in trunk/Tools
REGRESSION (249864@main): [ iOS ] TestWebKitAPI.ScrollViewScrollabilityTests.ScrollableWithOverflowHiddenAndShrunkUI is failing
https://bugs.webkit.org/show_bug.cgi?id=239867
Reviewed by Sam Weinig.
Use values that are representative of iPhone 8, which is the model used for running
API tests.
- TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
(TestWebKitAPI::TEST):
- 11:55 AM Changeset in webkit [293625] by
-
- 20 edits2 adds in trunk
Format time zone name using ICU instead of platform calls
https://bugs.webkit.org/show_bug.cgi?id=239865
Reviewed by Yusuke Suzuki.
JSTests:
Added new tests that ensure Date's timezone is formatted using preferred
language.
- complex.yaml:
- complex/timezone-format-de.js: Added.
(shouldBe):
- complex/timezone-format-en.js: Added.
(shouldBe):
Source/JavaScriptCore:
formatDateTime now uses cached display name of the timezone.
- runtime/DateConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
- runtime/DateConversion.cpp:
(JSC::formatDateTime):
- runtime/DateConversion.h:
- runtime/DatePrototype.cpp:
(JSC::formateDateInstance):
- runtime/JSDateMath.cpp:
(JSC::toICUTimeZone): Encapsulate bitwise_cast into typesafe functions.
(JSC::toOpaqueICUTimeZone):
(JSC::OpaqueICUTimeZoneDeleter::operator()):
(JSC::DateCache::calculateLocalTimeOffset):
(JSC::DateCache::defaultTimeZone):
(JSC::DateCache::timeZoneDisplayName): Both standard and daylight names are computed
once on the first access as ICU methods internally acquire locks.
(JSC::DateCache::timeZoneCacheSlow):
(JSC::DateCache::resetIfNecessary):
- runtime/JSDateMath.h:
LayoutTests:
Rebased existing layout tests to reflect new format (which is the same as in other
browsers now).
- storage/indexeddb/modern/date-basic-expected.txt:
- storage/indexeddb/modern/date-basic-private-expected.txt:
- storage/indexeddb/modern/get-keyrange-expected.txt:
- storage/indexeddb/modern/get-keyrange-private-expected.txt:
- storage/indexeddb/modern/idbobjectstore-delete-1-expected.txt:
- storage/indexeddb/modern/idbobjectstore-delete-1-private-expected.txt:
- 11:13 AM Changeset in webkit [293624] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r291998): [GTK] test accessibility/gtk/menu-list-unfocused-notifications.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=239888
Change the delay between changes to the combobox value to 1ms to ensure that an
accessibility event is consistently generated for both changes.
Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-04-29
Reviewed by Martin Robinson.
- accessibility/gtk/menu-list-unfocused-notifications.html:
- 11:11 AM Changeset in webkit [293623] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, remove unused variable
https://bugs.webkit.org/show_bug.cgi?id=239828
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
- 11:08 AM Changeset in webkit [293622] by
-
- 5 edits in trunk/Source/WebCore
[css-cascade] Sort shorthand properties at the end of CSSPropertyID enum
https://bugs.webkit.org/show_bug.cgi?id=238888
Reviewed by Darin Adler.
Only longhands should matter during the CSS Cascade, so by sorting
shorthands at the end, and ignoring them, we can save some memory and
avoid some iterations.
No test since now there should be no observable change in behavior.
- css/StylePropertyShorthand.cpp:
(WebCore::isShorthandCSSProperty): Deleted.
- css/StylePropertyShorthand.h:
(WebCore::isShorthandCSSProperty):
Turn function into a simple constexpr comparison.
- css/makeprop.pl:
(addProperty):
(sortByDescendingPriorityAndName):
Sort shorthand properties at the end.
- style/PropertyCascade.h:
Update comment.
- 10:47 AM Changeset in webkit [293621] by
-
- 9 edits in trunk
Drop StringImpl::createFromLiteral()
https://bugs.webkit.org/show_bug.cgi?id=239792
Reviewed by Darin Adler.
Drop StringImpl::createFromLiteral().
Call sites that have an ASCIILiteral can now simply call StringImpl::create(ASCIILiteral).
Call sites that have raw characters can call the existing StringImpl::createWithoutCopying().
This simplifies our API a bit.
Also inline part of the createWithoutCopying() functions so that the 0-length check is
inline. This allows the compiler to optimize the check out when the length is known at
compile time (which is often the case with literals).
- Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WTF/StringView.cpp:
(TestWebKitAPI::TEST):
- Source/JavaScriptCore/API/JSScriptRef.cpp:
- Source/JavaScriptCore/Scripts/wkbuiltins/builtins_templates.py:
- Source/JavaScriptCore/builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::BuiltinExecutables):
- Source/JavaScriptCore/runtime/IntlObject.cpp:
(JSC::availableUnits):
- Source/WTF/wtf/text/StringImpl.cpp:
(WTF::StringImpl::createWithoutCopyingNonEmpty):
(WTF::StringImpl::createFromLiteral): Deleted.
(WTF::StringImpl::createWithoutCopying): Deleted.
- Source/WTF/wtf/text/StringImpl.h:
(WTF::StringImpl::create):
(WTF::StringImpl::createWithoutCopying):
(WTF::StringImpl::createFromLiteral): Deleted.
- Source/WTF/wtf/text/WTFString.h:
(WTF::String::String):
Canonical link: https://commits.webkit.org/250127@main
- 10:40 AM Changeset in webkit [293620] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r290548) [GTK][WPE] test LayoutTests/fast/events/node-event-anchor-lock.html fails
https://bugs.webkit.org/show_bug.cgi?id=239890
Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-04-29
Reviewed by Martin Robinson.
- fast/events/node-event-anchor-lock.html: Disable scroll animation for this test.
- 9:36 AM Changeset in webkit [293619] by
-
- 2 edits in trunk/Source/WTF
REGRESSION(r293608): [GTK][WPE] Broke clang builds
https://bugs.webkit.org/show_bug.cgi?id=239899
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-29
Reviewed by Michael Catanzaro.
- wtf/StdLibExtras.h: Restrict std::remove_cvref hacks to GCC.
Canonical link: https://commits.webkit.org/250125@main
- 9:26 AM Changeset in webkit [293618] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Video on twitch.tv shifts to top of screen when toggling playback in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=239884
<rdar://92367060>
Reviewed by Eric Carlson.
Twitch will cause the HTMLMediaElement to recreate the MediaPlayer when resuming playback
after pausing. If this happens in fullscreen, VideoLayerManagerObjC::setVideoLayer() will
be called with the new video layer, however it will be laid out pinned to the top-left
corner of the screen (rather than centered), as setVideoLayer() will call -setFrame with
an explicit 0,0 position argument.
Rather than pin the layer to the top-left, use the full value of m_videoFullscreenFrame
when setting the video layer frame, both in setVideoLayer() as well as
setVideoFullscreenLayer().
Its currently impossible to write an test for this behavior, as TestWebKitAPI is not a UI
application, and therefore cannot enter fullscreen mode.
- platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:
(WebCore::VideoLayerManagerObjC::setVideoLayer):
(WebCore::VideoLayerManagerObjC::setVideoFullscreenLayer):
- 8:59 AM Changeset in webkit [293617] by
-
- 2 edits in trunk
Unreviewed, add my GitHub account name to contributors.json
I also ran
validate-committer-lists --canonicalizeto fix up some minor style inconsistencies in this file
after some other recent additions.
- metadata/contributors.json:
- 8:45 AM Changeset in webkit [293616] by
-
- 2 edits in trunk
Unreviewed; add my github account to contributors.json.
- metadata/contributors.json:
- 8:35 AM Changeset in webkit [293615] by
-
- 6 edits in trunk/Tools
[git-webkit] Redact bug title in branch name on alternate remotes
https://bugs.webkit.org/show_bug.cgi?id=239826
<rdar://problem/92418512>
Rubber-stamped by Aakash Jain.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.main): Allow caller to redact bug title in branch name.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.pull_request_branch_point): Redact bug title in branch name
for non-origin remotes.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py:
(TestBranch.test_redacted):
Canonical link: https://commits.webkit.org/250121@main
- 8:24 AM Changeset in webkit [293614] by
-
- 2 edits in trunk/Tools
[ews-build.webkit.org] Link to PRs with undefined title
https://bugs.webkit.org/show_bug.cgi?id=239820
<rdar://problem/92416554>
Reviewed by Aakash Jain.
- CISupport/ews-build/steps.py:
(ConfigureBuild.add_pr_details):
Canonical link: https://commits.webkit.org/250120@main
- 8:11 AM Changeset in webkit [293613] by
-
- 2 edits in trunk/Source/WebCore
Add background-clip: text to CSSProperties.json
Unreviewed fix.
- css/CSSProperties.json:
- 7:31 AM Changeset in webkit [293612] by
-
- 2 edits in trunk/Source/WebKit
Fix ASAN build after "IPC testing API should have the ability to test IPC::Connection send and receive through IPC::Connection"
https://bugs.webkit.org/show_bug.cgi?id=239894
Unreviewed build fix.
Add a return for function which does ASSERT_NOT_REACHED().
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-29
- WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSIPCConnection::didReceiveSyncMessage):
- 4:20 AM WebKitGTK/Debugging edited by
- (diff)
- 3:42 AM Changeset in webkit [293611] by
-
- 2 edits in trunk/LayoutTests
[GTK][WPE] media/video-with-alpha.html is failing and skipped
https://bugs.webkit.org/show_bug.cgi?id=226484
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-29
Unreviewed, gardening.
- platform/glib/TestExpectations: The SDK ships GStreamer 1.20, mark
media/video-with-alpha.html as passing.
Canonical link: https://commits.webkit.org/250117@main
- 12:59 AM Changeset in webkit [293610] by
-
- 6 edits in trunk/Source/WebKit
[macOS] Unreviewed, non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=239889
- UIProcess/API/Cocoa/_WKDataTask.h:
- UIProcess/API/Cocoa/_WKDataTask.mm:
- UIProcess/API/Cocoa/_WKInspectorConfigurationInternal.h:
- UIProcess/Cocoa/ModalContainerControlClassifier.h:
- UIProcess/Cocoa/ModalContainerControlClassifier.mm:
- 12:57 AM Changeset in webkit [293609] by
-
- 4 edits2 adds in trunk
HTMLMediaElement can get multiple interruptions for invisible autoplay
https://bugs.webkit.org/show_bug.cgi?id=239842
<rdar://91809550>
Reviewed by Eric Carlson.
Source/WebCore:
A media element may be interrupted for invisible autoplay.
In some cases, like by calling play on the media element, the media element will no longer be in interrupted state.
This will lead to multiple invisible autoplay interruptions to be added to the same media element.
There will be only one end of interruption for invisible autoplay, which will lead to the media element to not restart as expected.
To prevent this, we store a boolean in HTMLMediaElement that tells us whether the media element has an ongoing invisible autoplay interruption.
Based on that, we make sure to always balance invisible autoplay interruption begin and end.
Test: media/video-mediastream-restricted-invisible-autoplay-not-allowed.html
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
LayoutTests:
- fast/mediastream/video-mediastream-restricted-invisible-autoplay-not-allowed-expected.txt: Added.
- fast/mediastream/video-mediastream-restricted-invisible-autoplay-not-allowed.html: Added.
- 12:50 AM Changeset in webkit [293608] by
-
- 5 edits in trunk
[GCC] std::remove_cvref is undefined in GCC8.4
https://bugs.webkit.org/show_bug.cgi?id=239881
Reviewed by Žan Doberšek.
r293505 changed the guard that added std::remove_cvref if not defined
by GCC, checking cplusplus <= 201703L.
However in Ubuntu GCC8.4 this flag's value is 201709L. Thus, the
evaluation of this flag cannot reliably determine whether the compiler
has to define std::remove_cvref or not.
Instead of relying on a predefined compiler flag, what the patch does is
to attempt to compile a small snippet of code to check whether std::remove_cvref
is supported by the compiler. If successful, the flag 'HAVE_STD_REMOVE_CVREF' is defined.
.:
- Source/cmake/OptionsCommon.cmake: Set and expose HAVE_STD_REMOVE_CVREF if needed.
- Source/cmake/WebKitCompilerFlags.cmake: Check whether GCC supports std::remove_cvref.
Source/WTF:
- wtf/StdLibExtras.h: Define std::remove_cvref if not defined by GCC.
- 12:14 AM Changeset in webkit [293607] by
-
- 4 edits in trunk
Make sure to fail importScripts as per https://w3c.github.io/ServiceWorker/#importscripts step 4
https://bugs.webkit.org/show_bug.cgi?id=239847
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/import-scripts-updated-flag.https-expected.txt:
Source/WebCore:
Once a service worker is installed, the service worker should not be able to call importScript on new URLs.
Covered by updated test.
- workers/WorkerScriptLoader.cpp:
Apr 28, 2022:
- 10:18 PM Changeset in webkit [293606] by
-
- 2 edits in trunk/Source/WebCore
afterprint event should be scheduled on event loop
https://bugs.webkit.org/show_bug.cgi?id=239883
Patch by Alex Christensen <achristensen@webkit.org> on 2022-04-28
Reviewed by Chris Dumez.
- page/Page.cpp:
(WebCore::dispatchPrintEvent):
(WebCore::Page::dispatchBeforePrintEvent):
(WebCore::Page::dispatchAfterPrintEvent):
- 9:12 PM Changeset in webkit [293605] by
-
- 19 edits in trunk/Source
[JSC] Make DFG::OSRExit data unlinked
https://bugs.webkit.org/show_bug.cgi?id=239828
Reviewed by Saam Barati.
This patch makes DFG::OSRExit unlinked. While generated OSR exit code is linked version,
we no longer put linked data to DFG::OSRExit so that unlinked DFG can use DFG::OSRExit.
Key changes are two things.
- Now, we always store compiled MacroAssemblerCodeRef in DFG::JITData regardless of whether we have linked / unlinked DFG. While linked DFG uses repatching to jump to this code, unlinked DFG looks into this vector in JITData and jump to that.
- MethodOfGettingAValueProfile was including CodeBlock*, ValueProfile* in CodeBlock* etc., so it was linked data structure which unlinked DFG cannot use. Instead, we encode how to retrieve these pointers when generating OSR exit code actually, and just storing CodeOrigin, type, and Operand to make MethodOfGettingAValueProfile unlinked data structure. While CodeOrigin can include InlineCallFrame, but our first version of unlinked DFG will not perform inlining thus we will not include it. It also makes sizeof(MethodOfGettingAValueProfile) smaller from 32 bytes to 16 bytes (50% reduction).
- Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodeRef::offsetOfCodePtr):
- Source/JavaScriptCore/bytecode/CodeBlock.cpp:
(JSC::CodeBlock::updateOSRExitCounterAndCheckIfNeedToReoptimize): Deleted.
- Source/JavaScriptCore/bytecode/CodeBlock.h:
- Source/JavaScriptCore/bytecode/MethodOfGettingAValueProfile.cpp:
(JSC::MethodOfGettingAValueProfile::emitReportValue const):
(JSC::MethodOfGettingAValueProfile::fromLazyOperand): Deleted.
(JSC::MethodOfGettingAValueProfile::reportValue): Deleted.
- Source/JavaScriptCore/bytecode/MethodOfGettingAValueProfile.h:
(JSC::MethodOfGettingAValueProfile::unaryArithProfile):
(JSC::MethodOfGettingAValueProfile::binaryArithProfile):
(JSC::MethodOfGettingAValueProfile::argumentValueProfile):
(JSC::MethodOfGettingAValueProfile::bytecodeValueProfile):
(JSC::MethodOfGettingAValueProfile::lazyOperandValueProfile):
(JSC::MethodOfGettingAValueProfile::operator bool const):
(JSC::MethodOfGettingAValueProfile::MethodOfGettingAValueProfile): Deleted.
- Source/JavaScriptCore/dfg/DFGGraph.cpp:
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
- Source/JavaScriptCore/dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::JITCode):
(JSC::DFG::JITCode::findPC):
- Source/JavaScriptCore/dfg/DFGJITCode.h:
- Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
- Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalize):
- Source/JavaScriptCore/dfg/DFGOSRExit.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
(JSC::DFG::OSRExit::compileExit):
(JSC::DFG::OSRExit::codeLocationForRepatch const): Deleted.
- Source/JavaScriptCore/dfg/DFGOSRExit.h:
(JSC::DFG::OSRExit::codeLocationForRepatch const):
(JSC::DFG::OSRExitState::OSRExitState): Deleted.
- Source/JavaScriptCore/dfg/DFGPlan.cpp:
(JSC::DFG::Plan::finalizeJITData):
- Source/JavaScriptCore/dfg/DFGPlan.h:
- Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
- Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- Source/WTF/wtf/FixedVector.h:
Canonical link: https://commits.webkit.org/250111@main
- 7:24 PM Changeset in webkit [293604] by
-
- 12 edits in trunk/Source
Remove the AVFoundationNSURLSessionEnabled preference
https://bugs.webkit.org/show_bug.cgi?id=239632
Reviewed by Eric Carlson.
All supported operating systems have supported AVFoundationNSURLSession
for several years. Since we expect AVFoundation to always use WebKit
for network loading (and indeed, expect improper behavior if we do not)
we should remove this toggle to simplify the code and reduce the chance
for users to mistakenly activate it.
Source/WebCore:
- page/DeprecatedGlobalSettings.cpp:
(WebCore::DeprecatedGlobalSettings::setAVFoundationEnabled):
(WebCore::DeprecatedGlobalSettings::setAVFoundationNSURLSessionEnabled): Deleted.
- page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::isAVFoundationEnabled):
(WebCore::DeprecatedGlobalSettings::isAVFoundationNSURLSessionEnabled): Deleted.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::didPassCORSAccessCheck const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::wouldTaintOrigin const):
Source/WebKit:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAVFoundationNSURLSessionEnabled):
(WKPreferencesGetAVFoundationNSURLSessionEnabled):
- UIProcess/API/C/WKPreferencesRef.h:
Source/WebKitLegacy/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences setAVFoundationNSURLSessionEnabled:]):
(-[WebPreferences isAVFoundationNSURLSessionEnabled]):
Source/WTF:
- Scripts/Preferences/WebPreferences.yaml:
- 6:59 PM Changeset in webkit [293603] by
-
- 3 edits2 adds in trunk
CSP: Fix mixing strict-dynamic and unsafe-inline policies
https://bugs.webkit.org/show_bug.cgi?id=239862
Reviewed by Kate Cheney.
Source/WebCore:
Test: http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-and-unsafe-inline-policies.html
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForNonParserInsertedScripts const):
LayoutTests:
If you had multiple policies, one including strict-dynamic and another with unsafe-inline, the unsafe-inline
policy was incorrectly handled.
- http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-and-unsafe-inline-policies-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-and-unsafe-inline-policies.html: Added.
- 6:46 PM Changeset in webkit [293602] by
-
- 6 edits in trunk
[css-cascade] Mark properties sharing a computed value as related
https://bugs.webkit.org/show_bug.cgi?id=239579
Reviewed by Tim Nguyen.
LayoutTests/imported/w3c:
Some failures are now passing.
- web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
Source/WebCore:
Some longhand properties share a computed value with another property,
like a legacy -webkit- prefixed one.
In that case, when both properties are specified, the last one should
win. That is typically done by marking the properties as related, using
the "related-property" field. This defers the properties and makes
them cascade properly.
However, some properties weren't marked as related despite sharing a
computed value. So this patch marks these pairs:
- mask-clip and -webkit-mask-clip
- mask-composite and -webkit-mask-composite
- mask-mode and -webkit-mask-source-type
- text-combine-upright and -webkit-text-combine
Test: imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer.html
- css/CSSProperties.json:
LayoutTests:
Some failures are now passing.
- platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
- 6:28 PM Changeset in webkit [293601] by
-
- 16 edits in trunk
Support C files in Unified Builds
https://bugs.webkit.org/show_bug.cgi?id=239873
Reviewed by Mark Lam.
This patch adds support for C (not CPP) files in Unified Builds
so that we do not need to build Zydis in non-unified way.
Also, this patch fixes a bug that we always generate empty UnifiedSource-1.xxx.
It also fixes a bug that this script cannot handle 0 max bundle count.
- Tools/TestWebKitAPI/Scripts/generate-unified-sources.sh:
- Source/JavaScriptCore/CMakeLists.txt:
- Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
- Source/JavaScriptCore/Scripts/generate-unified-sources.sh:
- Source/JavaScriptCore/Sources.txt:
- Source/JavaScriptCore/UnifiedSources-output.xcfilelist:
- Source/WebKit/Scripts/generate-unified-sources.sh:
- Source/WebKitLegacy/scripts/generate-unified-sources.sh:
- Source/WTF/Scripts/generate-unified-source-bundles.rb:
- Source/WebCore/Scripts/generate-unified-sources.sh:
Canonical link: https://commits.webkit.org/250107@main
- 5:54 PM Changeset in webkit [293600] by
-
- 1 copy in tags/WebKit-7613.2.7.1.7
Tag WebKit-7613.2.7.1.7.
- 5:52 PM Changeset in webkit [293599] by
-
- 19 edits in branches/safari-613.2.7.1-branch/Source
Cherry-pick r287877. rdar://problem/92357915
Non-unified build fixes, early January 2022 edition
https://bugs.webkit.org/show_bug.cgi?id=235013
Unreviewed non-unified build fixes.
Source/JavaScriptCore:
- wasm/js/JSWebAssemblyModule.cpp: Add missing JSWebAssemblyLinkError.h header.
- wasm/js/JSWebAssemblyModule.h: Add missing forward declaration for the JSC::OptimizingCallLinkInfo type.
Source/WebCore:
No new tests needed.
- Modules/fetch/FetchBodyConsumer.cpp: Add missing FormData.h header.
- Modules/fetch/FormDataConsumer.h: Add missing ExceptionOr.h header, and forward declaration for the WebCore::ScriptExecutionContext type.
- animation/CSSAnimation.cpp: Add missing KeyframeEffect.h header.
- animation/KeyframeEffect.cpp: Add missing StyledElement.h header.
- html/HTMLFormElement.cpp: Add missing PseudoClassChangeInvalidation.h header.
- platform/network/SynchronousLoaderClient.cpp: Add missing SharedBuffer.h header.
- rendering/svg/RenderSVGBlock.cpp: Add missing SVGRenderSupport.h header.
- rendering/svg/RenderSVGForeignObject.cpp: Ditto.
- rendering/svg/RenderSVGInline.cpp: Ditto.
- rendering/svg/RenderSVGModelObject.cpp: Add missing SVGElementInlines.h header.
- rendering/svg/SVGInlineTextBox.cpp: Add missing FloatConversion.h header.
- svg/SVGViewElement.cpp: Add missing RenderElement.h header.
- workers/service/context/ServiceWorkerFetch.h: Add missing forward declaration for the WebCore::SharedBuffer type, remove unused one for WebCore::FragmentedSharedBuffer.
Source/WebKit:
- Platform/IPC/SharedBufferCopy.cpp: Add missing WebCoreArgumentCoders.h header, remove now unneeded ArgumentCoders.h header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@287877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:51 PM Changeset in webkit [293598] by
-
- 9 edits in branches/safari-613.2.7.1-branch/Source
Versioning.
WebKit-7613.2.7.1.7
- 5:29 PM Changeset in webkit [293597] by
-
- 2 edits in trunk/Source/WTF
REGRESSION (DOM GPUP): Rich HTML emails on watchOS no longer show up
https://bugs.webkit.org/show_bug.cgi?id=239870
rdar://91311606
Reviewed by Tim Horton.
Temporarily turn GPU process for DOM off by default on watchOS.
- Scripts/Preferences/WebPreferencesExperimental.yaml:
- 4:51 PM Changeset in webkit [293596] by
-
- 3 edits in trunk/Source/WebCore/rendering/style
Use a HashSet instead of a std::unique_ptr<HashSet> for StyleRareNonInheritedData.customPaintWatchedProperties
https://bugs.webkit.org/show_bug.cgi?id=239863
Reviewed by Yusuke Suzuki.
Use a HashSet instead of a std::unique_ptr<HashSet> for StyleRareNonInheritedData.customPaintWatchedProperties.
A HashSet is already essentially a pointer, no need for the extra dereferencing.
- Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::addCustomPaintWatchProperty):
(WebCore::changedCustomPaintWatchedProperty):
- Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
- Source/WebCore/rendering/style/StyleRareNonInheritedData.h:
Canonical link: https://commits.webkit.org/250105@main
- 4:31 PM Changeset in webkit [293595] by
-
- 19 edits1 add in trunk/Source
Dynamically switch message filter
https://bugs.webkit.org/show_bug.cgi?id=238577
<rdar://69263324>
Reviewed by Geoffrey Garen.
Source/WebKit:
Use a sandbox state variable to dynamically switch the bootstrap filter in the WebContent process' sandbox.
During launch of the WebContent process, we use a more permissive bootstrap filter to allow creating Mach
connections in this time frame. After the WebContent process has launched, we switch to a blocking filter,
which will essentially block access to launchd. The bootstrap filter is being switched back to the more
permissive version when we create new Mach sandbox extensions for the WebContent process. This is done on
a case by case basis, by adding a new parameter to control this behavior when creating Mach sandbox
extensions. While launching the WebContent process there is usually no need to specify that the permissive
bootstrap filter is needed, since we are already using the permissive filter during launch time. However,
for some Mach extensions that will only result in a new XPC connection in the WebContent process after launch,
we need to specify that the permissive filter is requried. Otherwise, creating the new XPC connection after
launch will fail. For Mach sandbox extensions created after launch of the WebContent process, we always need
to use the permissive bootstrap filter to be able to create the XPC connection. Enabling the permissive
bootstrap filter requires the audit token to be available, which means we need to pass the audit token when
creating the new Mach sandbox extensions. This patch also waits until after the Web page has been created to
set the sandbox variable which indicates that the WebContent process has launched. Without this last change,
the bootstrap filter would have needed switching when creating the Web page, since creating the WebPage will
consume and revoke some mach extensions.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
- Scripts/process-entitlements.sh:
- Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtension::createHandleForMachLookup):
(WebKit::SandboxExtension::createHandlesForMachLookup):
- Shared/Sandbox/SandboxStateVariables.h: Added.
- Shared/SandboxExtension.h:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::addPlatformLoadParameters):
(WebKit::WebPageProxy::grantAccessToAssetServices):
(WebKit::WebPageProxy::switchFromStaticFontRegistryToUserFontRegistry):
(WebKit::WebPageProxy::fontdMachExtensionHandle):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
- UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
(WebKit::WebProcessProxy::messageSourceIsValidWebContentProcess):
(WebKit::WebProcessProxy::auditToken const):
- UIProcess/SpeechRecognitionRemoteRealtimeMediaSourceManager.cpp:
(WebKit::SpeechRecognitionRemoteRealtimeMediaSourceManager::addSource):
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest):
- UIProcess/UserMediaProcessManager.cpp:
(WebKit::UserMediaProcessManager::willCreateMediaStream):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processNextQueuedMouseEvent):
(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
(WebKit::WebPageProxy::creationParameters):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::create):
- WebProcess/com.apple.WebProcess.sb.in:
Source/WTF:
Add SPI to set sandbox state variable.
- wtf/spi/darwin/SandboxSPI.h:
- 3:47 PM Changeset in webkit [293594] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk1 ] imported/w3c/web-platform-tests/css/css-text/text-transform/text-transform-upperlower-003.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=239871
Unreviewed test gardening.
- LayoutTests/platform/mac-wk1/TestExpectations:
Canonical link: https://commits.webkit.org/250103@main
- 3:43 PM Changeset in webkit [293593] by
-
- 2 edits in trunk/Tools
Fix SafeBrowsing API tests on platforms with safe browsing result details
https://bugs.webkit.org/show_bug.cgi?id=239861
<rdar://91767123>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-04-28
Reviewed by Anders Carlsson.
- TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(-[TestServiceLookupResult malwareDetailsBaseURLString]):
(-[TestServiceLookupResult learnMoreURL]):
(-[TestServiceLookupResult reportAnErrorBaseURLString]):
(-[TestServiceLookupResult localizedProviderDisplayName]):
- 3:26 PM Changeset in webkit [293592] by
-
- 2 edits in trunk/LayoutTests
Remove expectations for tiled-drawing/scrolling/scroll-snap/scroll-snap-momentum-in-non-snapping-axis.html
https://bugs.webkit.org/show_bug.cgi?id=228930
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250101@main
- 3:21 PM Changeset in webkit [293591] by
-
- 2 edits in trunk/Source/WebKit
Set top origin of CORS preflight requests
https://bugs.webkit.org/show_bug.cgi?id=239869
<rdar://92458995>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-04-28
Reviewed by Geoffrey Garen.
Since r293481 we establish two TCP connections to each domain that needs a CORS preflight request.
This is because we were calling _setPrivacyProxyFailClosedForUnreachableNonMainHosts for the CORS
preflight request but not the actual request after a successful CORS preflight check. They were
different because we weren't setting parameters.topOrigin for the CORS preflight request. Now we
are and the two requests can share a TCP connection once more.
- NetworkProcess/NetworkCORSPreflightChecker.cpp:
(WebKit::NetworkCORSPreflightChecker::startPreflight):
- 2:46 PM Changeset in webkit [293590] by
-
- 2 edits in trunk/Source/WebKit
Fix build error after r293509
https://bugs.webkit.org/show_bug.cgi?id=239866
<rdar://92471416>
Unreviewed build fix.
- Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::AuxiliaryProcess::isSystemWebKit):
- 2:23 PM Changeset in webkit [293589] by
-
- 5 edits in trunk
[ macOS Debug wk2 ] Thirteen imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ are a flaky crash (ASSERTION FAILED: willBeComposited == needsToBeComposited(layer, queryData))
https://bugs.webkit.org/show_bug.cgi?id=239770
<rdar://92334616>
Reviewed by Jer Noble.
Source/WebKit:
With media in the GPU Process, the contract that changes in the answer to
HTMLMediaElement::supportsAcceleratedRendering() must be associated with a call to
contentChanged(VideoChanged) was broken: MediaPlayerPrivateRemote's
m_configuration.supportsAcceleratedRendering changed in response to IPC from the GPU process,
but nothing triggered contentChanged(VideoChanged).
Fix by calling renderingModeChanged().
- GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:
- WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::acceleratedRenderingStateChanged):
LayoutTests:
Unskip the affected tests, reverting r293451.
- platform/mac-wk2/TestExpectations:
- 1:13 PM Changeset in webkit [293588] by
-
- 6 edits in trunk/Source
Leverage the known length of an ASCIILiteral when comparing it to a String / AtomString
https://bugs.webkit.org/show_bug.cgi?id=239798
Reviewed by Yusuke Suzuki and Darin Adler.
Leverage the known length of an ASCIILiteral when comparing it to a String / AtomString.
Make sure we call ASCIILiteral::length() inline to allow the compiler to optimize out
the strlen() call, then call the more efficientequal(StringImpl*, const LChar*, unsigned)
instead ofequal(StringImpl*, const LChar*).
- Source/JavaScriptCore/jsc.cpp:
(printInternal):
- Source/JavaScriptCore/runtime/JSCJSValueInlines.h:
(JSC::toPreferredPrimitiveType):
- Source/JavaScriptCore/runtime/PropertyName.h:
(JSC::isCanonicalNumericIndexString):
- Source/WTF/wtf/text/AtomString.h:
(WTF::operator==):
- Source/WTF/wtf/text/StringImpl.h:
(WTF::equal):
- Source/WTF/wtf/text/WTFString.h:
(WTF::operator==):
(WTF::operator!=):
Canonical link: https://commits.webkit.org/250097@main
- 1:04 PM Changeset in webkit [293587] by
-
- 17 edits1 move1 delete in trunk/LayoutTests
[GLIB] Update test expectations and baselines. Unreviewed test gardening.
https://bugs.webkit.org/show_bug.cgi?id=239827
Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-04-28
LayoutTests/imported/w3c:
- web-platform-tests/cookies/samesite/about-blank-toplevel.https-expected.txt: Update baseline to expect a pass.
LayoutTests:
- platform/glib/TestExpectations:
- platform/glib/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
- platform/glib/fast/lists/li-br-expected.txt:
- platform/gtk/TestExpectations:
- platform/gtk/compositing/repaint/composite-and-scale-change-expected.txt: Renamed from LayoutTests/platform/gtk/compositing/repaint/composite-and-scale-change-actual.txt.
- platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
- platform/gtk/fast/borders/rtl-border-05-expected.txt:
- platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
- platform/gtk/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
- platform/gtk/fast/ruby/ruby-runs-spans-expected.txt:
- platform/gtk/fast/ruby/rubyDOM-insert-rt-expected.txt:
- platform/gtk/fast/ruby/rubyDOM-insert-text1-expected.txt:
- platform/gtk/inspector/css/shadow-scoped-style-expected.txt: Removed.
- platform/wpe/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
- platform/wpe/fast/borders/rtl-border-05-expected.txt:
- platform/wpe/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
- 12:59 PM Changeset in webkit [293586] by
-
- 2 edits in branches/safari-614.1.11-branch/Source/WebGPU
Cherry-pick r293558. rdar://problem/91769511
WebGPU doesn't create a symlink to the system content path in installhdrs
https://bugs.webkit.org/show_bug.cgi?id=239819
Reviewed by Alexey Proskuryakov.
Enabled script phases for installhdrs and installapi.
- Configurations/WebGPU.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:56 PM Changeset in webkit [293585] by
-
- 9 edits in branches/safari-614.1.11-branch/Source
Versioning.
WebKit-7614.1.11.1
- 12:48 PM Changeset in webkit [293584] by
-
- 1 copy in tags/WebKit-7614.1.10.8
Tag WebKit-7614.1.10.8.
- 12:47 PM Changeset in webkit [293583] by
-
- 2 edits in branches/safari-614.1.10-branch/Source/WebGPU
Cherry-pick r293558. rdar://problem/91769511
WebGPU doesn't create a symlink to the system content path in installhdrs
https://bugs.webkit.org/show_bug.cgi?id=239819
Reviewed by Alexey Proskuryakov.
Enabled script phases for installhdrs and installapi.
- Configurations/WebGPU.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:45 PM Changeset in webkit [293582] by
-
- 9 edits in branches/safari-614.1.10-branch/Source
Versioning.
WebKit-7614.1.10.8
- 12:05 PM Changeset in webkit [293581] by
-
- 4 edits in trunk/LayoutTests
Update webrtc/connection-state.html to not expected the completed ice connection state
https://bugs.webkit.org/show_bug.cgi?id=239843
Reviewed by Eric Carlson.
Wait for video to be playable to check states.
Remove completed state from the expected ice connection state as this is racy and app specific for when completed will happen (it can take a long time or not).
This is aligned with WebKit and Chrome implementations.
- TestExpectations:
- webrtc/connection-state.html:
- webrtc/connection-state-expected.txt:
- 11:45 AM Changeset in webkit [293580] by
-
- 7 edits in trunk/Source/WebCore
[GStreamer] Pipewire display capture broken
https://bugs.webkit.org/show_bug.cgi?id=239435
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-28
Reviewed by Xabier Rodriguez-Calvar.
The pipewiresrc GStreamer element now needs both the
fdandpathproperties set in order
to open the right Pipewire stream, so we need to get the node ID from the portal Start
response and pass it to the GStreamer element.
- platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.h:
- platform/mediastream/gstreamer/GStreamerDisplayCaptureDeviceManager.cpp:
(WebCore::GStreamerDisplayCaptureDeviceManager::createDisplayCaptureSource):
(WebCore::GStreamerDisplayCaptureDeviceManager::waitResponseSignal):
- platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:
(WebCore::GStreamerVideoCaptureSource::createPipewireSource):
(WebCore::GStreamerVideoCaptureSource::GStreamerVideoCaptureSource):
(WebCore::m_deviceType):
(WebCore::GStreamerVideoCaptureSource::~GStreamerVideoCaptureSource):
- platform/mediastream/gstreamer/GStreamerVideoCaptureSource.h:
- platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::createSource):
(WebCore::GStreamerVideoCapturer::setSize):
(WebCore::GStreamerVideoCapturer::setFrameRate):
- platform/mediastream/gstreamer/GStreamerVideoCapturer.h:
Canonical link: https://commits.webkit.org/250094@main
- 10:46 AM Changeset in webkit [293579] by
-
- 9 edits in trunk
[WTF] Use quadratic-probing instead of double-hashing
https://bugs.webkit.org/show_bug.cgi?id=239813
Reviewed by Geoffrey Garen.
If table size is always power-of-two, we can safely use quadratic-probing[1] even if the load exceeds 50%.
Quadratic-probing and double-hashing have different tradeoff between clustering possibility and CPU cache
friendliness. Double-hashing can avoid clustering more, but it is not CPU cache friendly. Quadratic-probing
can cause clustering more but better for CPU cache. And while linear-probing caused a lot of trouble and not
practical, quadratic-probing with 75% load factor is practical configuration which is used in production-ready
hashtables e.g. Google's sparsetable / densetable[2].
This patch replaces WTF::HashTable's probing algorithm from double-hashing to quadratic-probing to make it more
cache friendly while keeping reasonable clustering characteristics (compared to linear-probing etc.). Due to
this cache friendliness, we get large performance improvements.
- 0.52% improvement in Speedometer2 with 95% probability.
- 0.72% improvement in JetStream2 with 98% probability.
[1]: https://fgiesen.wordpress.com/2015/02/22/triangular-numbers-mod-2n/
[2]: http://goog-sparsehash.sourceforge.net/doc/implementation.html
Canonical link: https://commits.webkit.org/250093@main
- 10:40 AM Changeset in webkit [293578] by
-
- 2 edits in trunk/Source/WTF
[iOS] Enable IOKit blocking in GPUP by default
https://bugs.webkit.org/show_bug.cgi?id=239615
Reviewed by Darin Adler.
- Scripts/Preferences/WebPreferencesInternal.yaml:
- 10:23 AM Changeset in webkit [293577] by
-
- 2 edits in trunk/Tools
[run-javascriptcore-tests] Fix user-facing accounting
https://bugs.webkit.org/show_bug.cgi?id=239845
Reviewed by Adrian Perez de Castro.
Update numJSCStressFlakyButPassed for flaky tests that were declared a
pass. Otherwise we end up miscounting passes as failures in the summary
we print out to the user. E.g. in
https://build.webkit.org/#/builders/31/builds/3567/steps/8/logs/stdio
the test was flaky but passed, yet run-javascriptcore-tests outputs
1 test flaky and failed.
since it calculates $numJSCStressFlaky - $numJSCStressFlakyButPassed
and $numJSCStressFlakyButPassed is zero (since it wasn't getting
updated).
- Scripts/run-javascriptcore-tests:
(runJSCStressTests):
- 9:48 AM Changeset in webkit [293576] by
-
- 3 edits in trunk/LayoutTests
[ iOS ] tables/mozilla/bugs/bug26178.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=239567
<rdar://problem/92055518>
Unreviewed test gardening.
This test produces different (1px) render tree dump results on iOS 15 and 15E sims.
Mark as failure on iOS as there appears be no way to have different expectations for those.
- platform/ios/TestExpectations:
- platform/ios/tables/mozilla/bugs/bug26178-expected.txt:
Also update to E results.
- 9:34 AM Changeset in webkit [293575] by
-
- 5 edits in trunk/Tools
[webkitbugspy] Limit number of failed bugzilla login attempts
https://bugs.webkit.org/show_bug.cgi?id=239850
<rdar://problem/92462214>
Reviewed by Michael Catanzaro.
- Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py: Ditto.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
(Tracker.init): Caller can define the number of failed login attempts.
(Tracker.user): Detect a failed login.
(Tracker._login_arguments): Only provide login arguments if login attempts
have not been exceeded.
(Tracker.populate): Detect a failed login.
(Tracker.set): Detect a failed login, handle case where login arguments are
not provided due to exceeded login attempts.
(Tracker.add_comment): Ditto.
(Tracker.projects): Detect a failed login.
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py:
Canonical link: https://commits.webkit.org/250089@main
- 9:27 AM Changeset in webkit [293574] by
-
- 3 edits in trunk/LayoutTests
Rebaseline editing/pasteboard/smart-paste-paragraph-002.html after r293521
https://bugs.webkit.org/show_bug.cgi?id=166782
Unreviewed test gardening.
- editing/pasteboard/smart-paste-paragraph-002-expected.txt:
- platform/ios/editing/pasteboard/smart-paste-paragraph-002-expected.txt:
- 9:20 AM Changeset in webkit [293573] by
-
- 1 edit in trunk/Tools/CISupport/ews-build/steps.py
Merge-queue error message about missing user permissions from contributors.json should indicate how to fix it
https://bugs.webkit.org/show_bug.cgi?id=239851
Reviewed by Jonathan Bedard.
- Tools/CISupport/ews-build/steps.py:
(ValidateCommitterAndReviewer.fail_build):
Canonical link: https://commits.webkit.org/250087@main
- 8:18 AM WebKitGTK/2.36.x edited by
- (diff)
- 8:12 AM Changeset in webkit [293572] by
-
- 4 edits in trunk/Source/WebCore
DisplayList::Recorder should lazily create the DrawGlyphsRecorder
https://bugs.webkit.org/show_bug.cgi?id=239829
Reviewed by Myles C. Maxfield.
Creating a DrawGlyphsRecorder does a bit of work that calls into Core Graphics. We don't need
to do this work for a layer that has no text, so delay this work until the first drawGlyphs() call.
This is a few % perf gain on the Images MotionMark subtest.
- platform/graphics/DrawGlyphsRecorder.h:
- platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::Recorder):
(WebCore::DisplayList::Recorder::drawGlyphs):
- platform/graphics/displaylists/DisplayListRecorder.h:
- 3:06 AM Changeset in webkit [293571] by
-
- 2 edits in trunk/Source/JavaScriptCore
[RISCV64] Implement MacroAssemblerRISCV64 branchAtomicWeakCAS{8,16,32,64} methods
https://bugs.webkit.org/show_bug.cgi?id=239806
Reviewed by Yusuke Suzuki.
Provide MacroAssemblerRISCV64 method implementations for the different
branchAtomicWeakCAS variants. The 32-bit and 64-bit versions are
straightforward, leveraging the load-reserved and store-conditional
instructions of the corresponding sizes. For 8-bit and 16-bit versions,
a method template is provided, loading and storing 32-bit words and
performing additional operations to validate and change the desired
value.
- assembler/MacroAssemblerRISCV64.h:
(JSC::MacroAssemblerRISCV64::branchAtomicWeakCASImpl):
(JSC::MacroAssemblerRISCV64::branchAtomicWeakCAS8):
(JSC::MacroAssemblerRISCV64::branchAtomicWeakCAS16):
(JSC::MacroAssemblerRISCV64::branchAtomicWeakCAS32):
(JSC::MacroAssemblerRISCV64::branchAtomicWeakCAS64):
- 1:21 AM Changeset in webkit [293570] by
-
- 62 edits in trunk/Source
[GPU Process] Make WebImage be backed by ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=239527
rdar://91113628
Reviewed by Tim Horton.
Source/WebCore:
Before enabling GPU Process for DOM rendering there were two modes for
page snapshot: Local bitmap and ShareableBitmap. The ShareableBitmap is
shared between the WebProcess and the UIProcess. The image is drawn in
WebProcess and is consumed by the UIProcess.
After enabling GPU Process for DOM rendering, a new mode should be added:
Remote ShareableBitmap. In this mode, the graphics will be recorded in
WebProcess, the drawing will be committed in GPUProcess and the image will
be consumed by either the WebProcess or the UIProcess.
To add this new mode, the snapshot will be drawn to an ImageBuffer instead
of a ShareableBitmap. And WebImage will be backed by an ImageBuffer instead
of a ShareableBitmap.
- page/FrameSnapshotting.cpp:
(WebCore::snapshotFrameRectWithClip):
- page/FrameSnapshotting.h:
- platform/graphics/ConcreteImageBuffer.h:
(WebCore::ConcreteImageBuffer::create):
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::createCairoSurface):
- platform/graphics/ImageBufferBackend.h:
(WebCore::ImageBufferBackend::createCairoSurface):
(WebCore::ImageBufferBackend::Parameters::encode const):
(WebCore::ImageBufferBackend::Parameters::decode):
- platform/graphics/RenderingMode.h:
- platform/graphics/cairo/ImageBufferCairoSurfaceBackend.cpp:
(WebCore::ImageBufferCairoSurfaceBackend::createCairoSurface):
- platform/graphics/cairo/ImageBufferCairoSurfaceBackend.h:
Source/WebKit:
-- Allow ImageBufferBackendHandleSharing and ImageBufferShareableBitmapBackend
to compile always.
-- Make WebImage hold an ImageBuffer instead of having it hold a ShareableBitamp.
-- Pass the ChromeClient to WebImage::create() so it can call its
createImageBuffer() which creates RemoteImageBuffer for GPUProcess
drawing.
-- Remove the ShareableBitamp local mode where is backed by a local memory
buffer. This mode was added to make WebImage can be non shareable even
it was backed by ShareableBitamp. So ShareableBitmap::createShareable()
should be renamed ShareableBitmap::create().
-- Replace WebImage::bitmap()::makeCGImageCopy() with
WebImage::copyNativeImage(WebCore::CopyBackingStore)
-- Replace WebImage::bitmap()::makeCGImageCopy() with
WebImage::copyNativeImage(WebCore::DontCopyBackingStore)
-- Replace WebImage::bitmap()::createGraphicsContext() with
WebImage::context()
-- Allow encoding and decoding ImageBufferShareableBitmapBackend by allowing
ImageBufferBackend::Parameters to be encoded and decoded.
-- Make ImageBuffer be able to createCairoSurface(). The pointer to this
surface will be leaked. And to maintain a correct life cycle for the
surface data which is owned by the backend, the ImageBuffer itself
will be ref() when the surface RefPtr is created and will be deref()
when the surface raw pointer is destroyed.
- GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::getShareableBitmapForImageBufferWithQualifiedIdentifier):
(WebKit::RemoteRenderingBackend::getFilteredImageForImageBuffer):
- GPUProcess/graphics/wc/WCScene.cpp:
(WebKit::WCScene::update):
- GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:
(WebKit::RemoteMediaPlayerManagerProxy::bitmapImageForCurrentTime):
- Shared/API/c/WKImage.cpp:
(WKImageCreate):
- Shared/API/c/cairo/WKImageCairo.cpp:
(WKImageCreateCairoSurface):
(WKImageCreateFromCairoSurface):
- Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateCGImage):
(WKImageCreateFromCGImage):
- Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::setImage):
- Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp:
(WebKit::CGDisplayListImageBufferBackend::createBackendHandle const):
- Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h:
- Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createHandle const):
(WebKit::ShareableBitmap::ShareableBitmap):
(WebKit::ShareableBitmap::data const):
(WebKit::ShareableBitmap::createShareable): Deleted.
(WebKit::ShareableBitmap::~ShareableBitmap): Deleted.
- Shared/ShareableBitmap.h:
(WebKit::ShareableBitmap::bytesPerRow const):
(WebKit::ShareableBitmap::isBackedBySharedMemory const): Deleted.
- Shared/UserData.cpp:
(WebKit::UserData::encode):
(WebKit::UserData::decode):
- Shared/WebCoreArgumentCoders.cpp:
(IPC::encodeImage):
- Shared/WebCoreArgumentCoders.h:
- Shared/WebImage.cpp:
(WebKit::WebImage::create):
(WebKit::WebImage::WebImage):
(WebKit::WebImage::size const):
(WebKit::WebImage::parameters const):
(WebKit::WebImage::context const):
(WebKit::WebImage::copyNativeImage const):
(WebKit::WebImage::bitmap const):
(WebKit::WebImage::createCairoSurface):
(WebKit::WebImage::createHandle const):
(WebKit::WebImage::~WebImage): Deleted.
- Shared/WebImage.h:
(WebKit::WebImage::bitmap): Deleted.
(WebKit::WebImage::bitmap const): Deleted.
- Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::createPersistentCairoSurface):
- Shared/gtk/ArgumentCodersGtk.cpp:
(IPC::encodeImage):
- UIProcess/API/glib/WebKitWebView.cpp:
(webKitWebViewDidReceiveSnapshot):
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::convertPlatformImageToBitmap):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didGetImageForFindMatch):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WKTextFinderClient.mm:
(-[WKTextFinderClient didGetImageForMatchResult:]):
- WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::takeScreenshot):
- WebProcess/GPU/graphics/ImageBufferBackendHandle.h:
- WebProcess/GPU/graphics/ImageBufferBackendHandleSharing.h:
(WebKit::ImageBufferBackendHandleSharing::bitmap const):
- WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:
(WebKit::ImageBufferShareableBitmapBackend::create):
(WebKit::ImageBufferShareableBitmapBackend::ImageBufferShareableBitmapBackend):
(WebKit::ImageBufferShareableBitmapBackend::createBackendHandle const):
(WebKit::ImageBufferShareableBitmapBackend::createCairoSurface):
- WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
- WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:
(WebKit::createShareableBitmapFromNativeImage):
- WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.cpp:
(WebKit::ImageBufferRemoteIOSurfaceBackend::createBackendHandle const):
- WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.h:
- WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp:
(WebKit::ImageBufferShareableMappedIOSurfaceBackend::createBackendHandle const):
- WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.h:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
(-[WKWebProcessPlugInNodeHandle renderedImageWithOptions:width:]):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::imageForRect):
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::renderedImage):
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::image const):
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::snapshot):
- WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp:
(WebKit::createShareableBitmap):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createImageBuffer const):
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::convertCairoSurfaceToShareableBitmap):
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertDragImageToBitmap):
- WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
- WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::display):
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::getImageForFindMatch):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createSelectionSnapshot const):
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::takeSnapshot):
(WebKit::snapshotColorSpace):
(WebKit::WebPage::snapshotAtSize):
(WebKit::WebPage::snapshotNode):
(WebKit::WebPage::drawRectToImage):
(WebKit::snapshotOptionsToBitmapConfiguration): Deleted.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::shareableBitmapSnapshotForNode):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setTopOverhangImage):
(WebKit::WebPage::setBottomOverhangImage):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldUseRemoteRenderingFor):
- 12:59 AM Changeset in webkit [293569] by
-
- 2 edits in trunk/Source/WebCore
Use more smart pointers in Element.cpp
https://bugs.webkit.org/show_bug.cgi?id=239836
Patch by Alex Christensen <achristensen@webkit.org> on 2022-04-28
Reviewed by Chris Dumez.
- dom/Element.cpp:
(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):
- 12:38 AM Changeset in webkit [293568] by
-
- 3 edits in trunk/Tools
test-webkitperl outputs errors about uninitialized $platform variable
https://bugs.webkit.org/show_bug.cgi?id=239762
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-28
Reviewed by Alexey Proskuryakov.
Make filter-build-webkit a module that exports the tested functions.
Avoid running filter-webkit-build main code if the code is being imported
as a module.
- Scripts/filter-build-webkit:
(main):
(shouldIgnoreLine):
- Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
- 12:18 AM Changeset in webkit [293567] by
-
- 16 edits1 copy5 adds in trunk
IPC testing API should have the ability to test IPC::Connection send and receive through IPC::Connection
https://bugs.webkit.org/show_bug.cgi?id=239495
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-28
Reviewed by Darin Adler.
Source/WebKit:
Add the testing interfaces to be able to send IPC::Connection instances
to other processes.
Add the testing interfaces to be able to send messages through arbitrary
IPC::Connection instances.
Test: ipc/create-connection-and-send-async.html
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Platform/IPC/Connection.h:
(IPC::Connection::waitForMessageForTesting):
- Scripts/webkit/messages.py:
(types_that_cannot_be_forward_declared):
- Shared/IPCConnectionTester.cpp: Added.
(WebKit::asIdentifier):
(WebKit::IPCConnectionTester::create):
(WebKit::IPCConnectionTester::IPCConnectionTester):
(WebKit::IPCConnectionTester::initialize):
(WebKit::IPCConnectionTester::stopListeningForIPC):
(WebKit::IPCConnectionTester::sendAsyncMessages):
(WebKit::IPCConnectionTester::didClose):
(WebKit::IPCConnectionTester::didReceiveInvalidMessage):
(WebKit::IPCConnectionTester::asyncMessage):
(WebKit::IPCConnectionTester::syncMessage):
- Shared/IPCConnectionTester.h: Copied from Source/WebKit/Shared/IPCTester.h.
- Shared/IPCConnectionTester.messages.in: Copied from Source/WebKit/Shared/IPCTester.messages.in.
- Shared/IPCConnectionTesterIdentifier.h: Added.
- Shared/IPCTester.cpp:
(WebKit::IPCTester::createConnectionTester):
(WebKit::IPCTester::createConnectionTesterAndSendAsyncMessages):
(WebKit::IPCTester::releaseConnectionTester):
- Shared/IPCTester.h:
- Shared/IPCTester.messages.in:
- Sources.txt:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::JSIPCAttachment::create):
(WebKit::IPCTestingAPI::JSIPCAttachment::encode const):
(WebKit::IPCTestingAPI::JSIPCAttachment::JSIPCAttachment):
(WebKit::IPCTestingAPI::JSIPCConnection::create):
(WebKit::IPCTestingAPI::JSIPCConnection::JSIPCConnection):
(WebKit::IPCTestingAPI::createTypeError):
(WebKit::IPCTestingAPI::convertToUint64):
(WebKit::IPCTestingAPI::sendMessageWithJSArguments):
(WebKit::IPCTestingAPI::extractSyncIPCMessageInfo):
(WebKit::IPCTestingAPI::sendSyncMessageWithJSArguments):
(WebKit::IPCTestingAPI::waitForMessageWithJSArguments):
(WebKit::IPCTestingAPI::JSIPCSemaphore::createJSWrapper):
(WebKit::IPCTestingAPI::JSIPCSemaphore::wrapperClass):
(WebKit::IPCTestingAPI::JSIPCSemaphore::unwrap):
(WebKit::IPCTestingAPI::JSIPCSemaphore::toWrapped):
(WebKit::IPCTestingAPI::JSIPCSemaphore::initialize):
(WebKit::IPCTestingAPI::JSIPCSemaphore::finalize):
(WebKit::IPCTestingAPI::JSIPCSemaphore::staticFunctions):
(WebKit::IPCTestingAPI::JSIPCAttachment::createJSWrapper):
(WebKit::IPCTestingAPI::JSIPCAttachment::wrapperClass):
(WebKit::IPCTestingAPI::JSIPCAttachment::unwrap):
(WebKit::IPCTestingAPI::JSIPCAttachment::toWrapped):
(WebKit::IPCTestingAPI::JSIPCAttachment::initialize):
(WebKit::IPCTestingAPI::JSIPCAttachment::finalize):
(WebKit::IPCTestingAPI::JSIPCAttachment::staticFunctions):
(WebKit::IPCTestingAPI::JSIPCConnection::createJSWrapper):
(WebKit::IPCTestingAPI::JSIPCConnection::wrapperClass):
(WebKit::IPCTestingAPI::JSIPCConnection::unwrap):
(WebKit::IPCTestingAPI::JSIPCConnection::toWrapped):
(WebKit::IPCTestingAPI::JSIPCConnection::initialize):
(WebKit::IPCTestingAPI::JSIPCConnection::finalize):
(WebKit::IPCTestingAPI::JSIPCConnection::didReceiveMessage):
(WebKit::IPCTestingAPI::JSIPCConnection::didReceiveSyncMessage):
(WebKit::IPCTestingAPI::JSIPCConnection::didClose):
(WebKit::IPCTestingAPI::JSIPCConnection::didReceiveInvalidMessage):
(WebKit::IPCTestingAPI::JSIPCConnection::staticFunctions):
(WebKit::IPCTestingAPI::JSIPCConnection::open):
(WebKit::IPCTestingAPI::JSIPCConnection::invalidate):
(WebKit::IPCTestingAPI::JSIPCConnection::sendMessage):
(WebKit::IPCTestingAPI::JSIPCConnection::sendSyncMessage):
(WebKit::IPCTestingAPI::JSIPCConnection::waitForMessage):
(WebKit::IPCTestingAPI::JSIPCStreamClientConnection::prepareToSendOutOfStreamMessage):
(WebKit::IPCTestingAPI::JSIPC::staticFunctions):
(WebKit::IPCTestingAPI::encodeFrameInfoData):
(WebKit::IPCTestingAPI::encodeAttachment):
(WebKit::IPCTestingAPI::VectorEncodeHelper::encode const):
(WebKit::IPCTestingAPI::encodeArrayArgument):
(WebKit::IPCTestingAPI::encodeArgument):
(WebKit::IPCTestingAPI::JSIPC::sendMessage):
(WebKit::IPCTestingAPI::JSIPC::waitForMessage):
(WebKit::IPCTestingAPI::JSIPC::sendSyncMessage):
(WebKit::IPCTestingAPI::JSIPC::createConnectionPair):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:
(TEST):
Change two tests to pass "IPC" object as the value of FrameInfoData. This way the argument encode functions
do not need to take the JSIPC argument.
LayoutTests:
- ipc/create-connection-and-send-async.html: Added.
Apr 27, 2022:
- 10:36 PM Changeset in webkit [293566] by
-
- 3 edits in trunk/Source/WebCore
AXObjectCache::childrenChanged modifies m_deferred* member variables but doesn't start timer to process them
https://bugs.webkit.org/show_bug.cgi?id=239787
Reviewed by Chris Fleizach.
This patch fixes this a bug where AXObjectCache::childrenChanged
methods modify m_deferred* member variables, but doesn't start
the m_performCacheUpdateTimer.
This patch also renames m_deferredChildrenChangedNodeList to
m_deferredNodeAddedOrRemovedList, since this more accurately
captures what this list is for.
Finally, this refactors a few methods that modify m_deferred* member
variables to not start the cache timer unless the variable has
actually changed.
Fixes these tests in ITM:
- accessibility/mac/focus-moves-cursor.html
- accessibility/image-load-on-delay.html
- accessibility/legend-children-are-visible.html
- accessibility/text-alternative-calculation-hidden-nodes.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::deferMenuListValueChange):
(WebCore::AXObjectCache::deferModalChange):
(WebCore::AXObjectCache::deferNodeAddedOrRemoved): Added.
(WebCore::AXObjectCache::prepareForDocumentDestruction):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
- accessibility/AXObjectCache.h:
- 10:32 PM Changeset in webkit [293565] by
-
- 5 edits in trunk
Web Inspector: [Flexbox]
<button>and<select>elements are appearing in list of Flex containers
https://bugs.webkit.org/show_bug.cgi?id=239425
Reviewed by Devin Rousso.
Source/WebCore:
Added test cases to inspector/css/nodeLayoutContextTypeChanged.html.
- inspector/agents/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::layoutContextTypeForRenderer):
LayoutTests:
- inspector/css/nodeLayoutContextTypeChanged-expected.txt:
- inspector/css/nodeLayoutContextTypeChanged.html:
- 10:01 PM Changeset in webkit [293564] by
-
- 7 edits in trunk/Source/WebKit
[iOS] Add a mechanism to override desktop-class browsing state in multitasking mode
https://bugs.webkit.org/show_bug.cgi?id=239801
rdar://89786146
Reviewed by Tim Horton.
Keep the recommended desktop-class browsing state stable as the width of the web view changes, while
multitasking mode is active.
- UIProcess/API/ios/WKWebViewIOS.h:
- UIProcess/PageClient.h:
(WebKit::PageClient::isInMultitaskingMode const):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::isInMultitaskingMode const):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::isDesktopClassBrowsingRecommended const):
Turn the static helper function
desktopClassBrowsingRecommendedinto a private method instead, so that we
don't need to pass in all the information we need from the WebPageProxy when determining whether we should
default to desktop-class browsing. This also allows us to make a slight adjustment here to avoid recommending
mobile content when the window is narrower than 375 points in multitasking mode.
(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):
(WebKit::desktopClassBrowsingRecommended): Deleted.
- 9:50 PM Changeset in webkit [293563] by
-
- 161 edits in trunk/Source
Prepare more of the code base for making the AtomString(const String&) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=239711
Reviewed by Darin Adler.
Prepare more of the code base for making the AtomString(const String&) constructor explicit.
This helps us find cases where we atomize unnecessarily or not early enough, thus causing
unnecessary String allocations.
- Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponse):
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::processResponse):
- Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::dumpHistoryItem):
- Source/WTF/wtf/text/StringImpl.h:
- Source/WebCore/Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::create):
- Source/WebCore/Modules/highlight/HighlightRegister.cpp:
(WebCore::HighlightRegister::setFromMapLike):
(WebCore::HighlightRegister::remove):
- Source/WebCore/Modules/highlight/HighlightRegister.h:
(WebCore::HighlightRegister::map const):
- Source/WebCore/Modules/highlight/HighlightRegister.idl:
- Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl:
- Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.idl:
- Source/WebCore/Modules/mediastream/RTCDataChannel.idl:
- Source/WebCore/Modules/mediastream/RTCDataChannelEvent.idl:
- Source/WebCore/Modules/pictureinpicture/PictureInPictureEvent.idl:
- Source/WebCore/Modules/push-api/PushEvent.idl:
- Source/WebCore/Modules/push-api/PushSubscriptionChangeEvent.idl:
- Source/WebCore/Modules/speech/SpeechSynthesisErrorEvent.idl:
- Source/WebCore/Modules/webaudio/AudioProcessingEvent.idl:
- Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.idl:
- Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readServerHandshake):
(WebCore::WebSocketHandshake::readStatusLine):
- Source/WebCore/Modules/websockets/WebSocketHandshake.h:
- Source/WebCore/animation/AnimationPlaybackEvent.idl:
- Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::customPropertyValue):
(WebCore::ComputedStyleExtractor::customPropertyText):
- Source/WebCore/css/CSSComputedStyleDeclaration.h:
- Source/WebCore/css/CSSVariableReferenceValue.cpp:
(WebCore::resolveVariableReference):
- Source/WebCore/css/ContainerQueryParser.cpp:
(WebCore::ContainerQueryParser::consumeFilteredContainerQuery):
(WebCore::consumeFeatureName):
- Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::consumeFontPaletteValuesRule):
(WebCore::CSSParserImpl::consumeKeyframesRule):
- Source/WebCore/css/parser/CSSParserSelector.cpp:
(WebCore::CSSParserSelector::parsePseudoElementSelector):
(WebCore::CSSParserSelector::parsePseudoClassSelector):
- Source/WebCore/css/typedom/CSSStyleValue.cpp:
(WebCore::CSSStyleValue::parse):
(WebCore::CSSStyleValue::parseAll):
- Source/WebCore/css/typedom/CSSStyleValue.h:
- Source/WebCore/css/typedom/CSSStyleValue.idl:
- Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
(WebCore::CSSStyleValueFactory::extractCustomCSSValues):
(WebCore::CSSStyleValueFactory::parseStyleValue):
- Source/WebCore/css/typedom/CSSStyleValueFactory.h:
- Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp:
(WebCore::ComputedStylePropertyMapReadOnly::get const):
(WebCore::ComputedStylePropertyMapReadOnly::getAll const):
(WebCore::ComputedStylePropertyMapReadOnly::has const):
- Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.h:
- Source/WebCore/css/typedom/StylePropertyMapReadOnly.h:
- Source/WebCore/css/typedom/StylePropertyMapReadOnly.idl:
- Source/WebCore/dom/AnimationEvent.idl:
- Source/WebCore/dom/Document.cpp:
(WebCore::Document::setContentLanguage):
(WebCore::Document::processMetaHttpEquiv):
- Source/WebCore/dom/Document.h:
(WebCore::Document::contentLanguage const):
(WebCore::Document::baseTarget const):
- Source/WebCore/dom/Element.h:
(WebCore::Element::target const):
- Source/WebCore/dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::KeyboardEvent):
(WebCore::KeyboardEvent::initKeyboardEvent):
- Source/WebCore/dom/KeyboardEvent.h:
- Source/WebCore/dom/KeyboardEvent.idl:
- Source/WebCore/dom/PointerEvent.cpp:
(WebCore::PointerEvent::create):
- Source/WebCore/dom/PointerEvent.h:
- Source/WebCore/dom/PopStateEvent.idl:
- Source/WebCore/dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestModuleScript):
- Source/WebCore/dom/StyledElement.cpp:
- Source/WebCore/history/HistoryItem.cpp:
(WebCore::HistoryItem::reset):
(WebCore::HistoryItem::target const):
(WebCore::HistoryItem::setTarget):
(WebCore::HistoryItem::childItemWithTarget):
- Source/WebCore/history/HistoryItem.h:
- Source/WebCore/html/Autofill.cpp:
(WebCore::AutofillData::createFromHTMLFormControlElement):
- Source/WebCore/html/BaseButtonInputType.cpp:
(WebCore::BaseButtonInputType::setValue):
- Source/WebCore/html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::setValue):
- Source/WebCore/html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::setupDateTimeChooserParameters):
- Source/WebCore/html/CustomPaintImage.cpp:
(WebCore::extractComputedProperty):
(WebCore::CustomPaintImage::doCustomPaint):
- Source/WebCore/html/CustomPaintImage.h:
- Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::target const):
(WebCore::HTMLAnchorElement::effectiveTarget const):
- Source/WebCore/html/HTMLAnchorElement.h:
- Source/WebCore/html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::target const):
- Source/WebCore/html/HTMLAreaElement.h:
- Source/WebCore/html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::target const):
- Source/WebCore/html/HTMLBaseElement.h:
- Source/WebCore/html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::target const):
(WebCore::HTMLFormElement::effectiveTarget const):
- Source/WebCore/html/HTMLFormElement.h:
- Source/WebCore/html/HTMLHtmlElement.idl:
- Source/WebCore/html/HTMLIFrameElement.idl:
- Source/WebCore/html/HTMLImageElement.idl:
- Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::target const):
- Source/WebCore/html/HTMLLinkElement.h:
- Source/WebCore/html/track/AudioTrack.idl:
- Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:
- Source/WebCore/loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::startPreflight):
- Source/WebCore/loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest):
- Source/WebCore/loader/FormSubmission.cpp:
(WebCore::FormSubmission::FormSubmission):
- Source/WebCore/loader/FormSubmission.h:
(WebCore::FormSubmission::Attributes::target const):
(WebCore::FormSubmission::Attributes::setTarget):
(WebCore::FormSubmission::target const):
- Source/WebCore/loader/FrameLoadRequest.cpp:
(WebCore::FrameLoadRequest::FrameLoadRequest):
- Source/WebCore/loader/FrameLoadRequest.h:
(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::frameName const):
(WebCore::FrameLoadRequest::setFrameName):
- Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation):
(WebCore::extractContentLanguageFromHeader):
(WebCore::FrameLoader::didBeginDocument):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
- Source/WebCore/loader/FrameLoader.h:
- Source/WebCore/loader/HistoryController.cpp:
(WebCore::FrameLoader::HistoryController::recursiveGoToItem):
- Source/WebCore/loader/LinkLoader.cpp:
(WebCore::LinkLoader::preloadIfNeeded):
- Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::shouldStoreResourceAsFlatFile):
- Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::name const):
(WebCore::DOMWindow::setName):
- Source/WebCore/page/DOMWindow.h:
- Source/WebCore/page/DOMWindow.idl:
- Source/WebCore/page/DragController.cpp:
(WebCore::documentFragmentFromDragData):
- Source/WebCore/page/ModalContainerObserver.h:
(WebCore::ModalContainerObserver::overrideSearchTermForTesting):
- Source/WebCore/page/Navigator.cpp:
(WebCore::Navigator::initializePluginAndMimeTypeArrays):
- Source/WebCore/page/PageSerializer.cpp:
(WebCore::PageSerializer::SerializerMarkupAccumulator::appendCustomAttributes):
- Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):
- Source/WebCore/platform/graphics/FontCache.cpp:
(WebCore::FontCache::cachedFontPlatformData):
- Source/WebCore/platform/graphics/FontDescription.cpp:
(WebCore::computeSpecializedChineseLocale):
- Source/WebCore/platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load):
(WebCore::MediaPlayer::supportsType):
- Source/WebCore/platform/graphics/cocoa/FontDescriptionCocoa.cpp:
(WebCore::FontDescription::platformResolveGenericFamily):
- Source/WebCore/platform/graphics/filters/FilterOperation.cpp:
(WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
- Source/WebCore/platform/graphics/filters/FilterOperation.h:
(WebCore::ReferenceFilterOperation::create):
(WebCore::ReferenceFilterOperation::fragment const):
- Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:
(WebCore::DisplayCaptureSourceCocoa::settings):
- Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:
(WebCore::CoreAudioCaptureSource::capabilities):
(WebCore::CoreAudioCaptureSource::settings):
- Source/WebCore/platform/mock/MockRealtimeAudioSource.cpp:
(WebCore::MockRealtimeAudioSource::settings):
(WebCore::MockRealtimeAudioSource::capabilities):
- Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::capabilities):
(WebCore::MockRealtimeVideoSource::settings):
- Source/WebCore/platform/mock/mediasource/MockSourceBufferPrivate.cpp:
- Source/WebCore/platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::loadResourceSynchronously):
- Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::crossThreadData const):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::mimeType const):
(WebCore::ResourceResponseBase::setMimeType):
(WebCore::ResourceResponseBase::textEncodingName const):
(WebCore::ResourceResponseBase::setTextEncodingName):
(WebCore::ResourceResponseBase::httpVersion const):
(WebCore::ResourceResponseBase::setHTTPVersion):
- Source/WebCore/platform/network/ResourceResponseBase.h:
- Source/WebCore/plugins/DOMMimeType.cpp:
(WebCore::DOMMimeType::type const):
- Source/WebCore/plugins/DOMMimeType.h:
- Source/WebCore/plugins/DOMPlugin.cpp:
(WebCore::DOMPlugin::supportedPropertyNames const):
- Source/WebCore/plugins/DOMPluginArray.cpp:
(WebCore::DOMPluginArray::supportedPropertyNames const):
- Source/WebCore/plugins/PluginData.h:
- Source/WebCore/rendering/MarkedText.h:
- Source/WebCore/rendering/PathOperation.cpp:
(WebCore::ReferencePathOperation::create):
(WebCore::ReferencePathOperation::ReferencePathOperation):
- Source/WebCore/rendering/PathOperation.h:
- Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::addCustomPaintWatchProperty):
- Source/WebCore/rendering/style/RenderStyle.h:
- Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
- Source/WebCore/rendering/style/StyleRareNonInheritedData.h:
- Source/WebCore/style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::pushCascadeLayer):
- Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::applyCustomProperty):
- Source/WebCore/style/StyleBuilder.h:
- Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertPathOperation):
- Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyValueListStyleType):
(WebCore::Style::BuilderCustom::applyValueWebkitLocale):
(WebCore::Style::BuilderCustom::applyValueFontFamily):
(WebCore::Style::BuilderCustom::applyValueTextEmphasisStyle):
(WebCore::Style::BuilderCustom::applyValueCounter):
(WebCore::Style::BuilderCustom::applyValueAlt):
- Source/WebCore/style/StyleBuilderState.cpp:
(WebCore::Style::BuilderState::createFilterOperations):
- Source/WebCore/svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
- Source/WebCore/svg/SVGAElement.h:
- Source/WebCore/svg/SVGElement.cpp:
(WebCore::SVGElement::synchronizeAttribute):
(WebCore::SVGElement::synchronizeAllAttributes):
(WebCore::SVGElement::commitPropertyChange):
(WebCore::SVGElement::insertedIntoAncestor):
(WebCore::SVGElement::buildPendingResourcesIfNeeded):
- Source/WebCore/svg/SVGElement.h:
(WebCore::SVGElement::className const):
- Source/WebCore/svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::fragmentIdentifierFromIRIString):
(WebCore::SVGURIReference::targetElementFromIRIString):
- Source/WebCore/svg/SVGURIReference.h:
- Source/WebCore/svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::updateUserAgentShadowTree):
(WebCore::SVGUseElement::findTarget const):
- Source/WebCore/svg/SVGUseElement.h:
- Source/WebCore/svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::Condition::Condition):
(WebCore::SVGSMILElement::buildPendingResource):
(WebCore::SVGSMILElement::parseCondition):
- Source/WebCore/svg/animation/SVGSMILElement.h:
- Source/WebCore/svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::calculateFilterOutsets):
- Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::overrideModalContainerSearchTermForTesting):
- Source/WebCore/testing/Internals.h:
- Source/WebCore/testing/Internals.idl:
- Source/WebCore/worklets/PaintWorkletGlobalScope.cpp:
(WebCore::PaintWorkletGlobalScope::PaintDefinition::PaintDefinition):
(WebCore::PaintWorkletGlobalScope::registerPaint):
- Source/WebCore/worklets/PaintWorkletGlobalScope.h:
- Source/WebCore/worklets/PaintWorkletGlobalScope.idl:
- Source/WebCore/xml/CustomXPathNSResolver.cpp:
(WebCore::CustomXPathNSResolver::lookupNamespaceURI):
- Source/WebCore/xml/XPathGrammar.cpp:
- Source/WebCore/xml/XPathParser.cpp:
(WebCore::XPath::Parser::expandQualifiedName):
- Source/WebCore/xml/XPathParser.h:
Canonical link: https://commits.webkit.org/250077@main
- 9:09 PM Changeset in webkit [293562] by
-
- 4 edits in trunk/Source/WebKit/UIProcess
GPUProcess doesn't get notified of imminent process suspension
https://bugs.webkit.org/show_bug.cgi?id=239815
Reviewed by Tim Horton.
By defaults, ProcessThrottler in the UIProcess use a ProcessAndUIAssertion instance internally,
instead of a simple ProcessAssertion. This makes sure that a process assertion is taken on
behalf of the UIProcess as well, not just the child process. This also makes sure that when
the UIProcess has been in the background for too long and its assertion gets invalidated, we
release all ProcessAndUIAssertion instances as well.
The WebProcess and NetworkProcess were correctly using a ProcessAndUIAssertion. However, the
GPUProcess was passingfalsewhen constructing the ProcessThrottler, causing it to use a
simple ProcessAssertion. As a result, the GPUProcess would not get notified on imminent
suspension when the app has been running in the background for too long.
This patch aligns the behavior of the GPUProcess with the one of the NetworkProcess since
both processes are very similar.
- Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::GPUProcessProxy):
- Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::anyProcessPoolShouldTakeUIBackgroundAssertion): Deleted.
- Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::anyProcessPoolNeedsUIBackgroundAssertion):
- Source/WebKit/UIProcess/WebProcessPool.h:
Canonical link: https://commits.webkit.org/250076@main
- 9:03 PM Changeset in webkit [293561] by
-
- 35 edits in trunk
Have equalIgnoringASCIICase() take in an ASCIILiteral instead of a const char*
https://bugs.webkit.org/show_bug.cgi?id=239802
Reviewed by Darin Adler.
Have equalIgnoringASCIICase() take in an ASCIILiteral instead of a const char*,
as we are encouraging developers to use ""_s for string literals.
- Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WTF/StringView.cpp:
(TestWebKitAPI::TEST):
- Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:
(parameterValue):
(WebFrameLoaderClient::createPlugin):
- Source/WTF/wtf/text/AtomString.h:
(WTF::equalIgnoringASCIICase):
- Source/WTF/wtf/text/StringImpl.h:
(WTF::equalIgnoringASCIICase):
- Source/WTF/wtf/text/StringView.h:
(WTF::equalIgnoringASCIICase):
- Source/WTF/wtf/text/WTFString.h:
(WTF::equalIgnoringASCIICase):
- Source/WTF/wtf/unix/LanguageUnix.cpp:
(WTF::platformLanguage):
- Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:
(WebCore::PaymentCoordinator::validatedPaymentNetwork const):
- Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::siblingWithAriaRole):
(WebCore::AccessibilityNodeObject::menuElementForMenuButton const):
(WebCore::AccessibilityNodeObject::menuItemElementForMenu const):
- Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::popupValue const):
- Source/WebCore/css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific const):
- Source/WebCore/css/MediaQueryEvaluator.h:
- Source/WebCore/dom/Document.cpp:
(WebCore::messageSourceForWTFLogChannel):
- Source/WebCore/dom/SecurityContext.cpp:
(WebCore::SecurityContext::isSupportedSandboxPolicy):
- Source/WebCore/html/HiddenInputType.cpp:
(WebCore::HiddenInputType::appendFormData const):
- Source/WebCore/html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::isSupported):
- Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getExtension):
- Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
- Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
- Source/WebCore/page/FrameTree.cpp:
(WebCore::isBlankTargetFrameName):
(WebCore::isParentTargetFrameName):
(WebCore::isSelfTargetFrameName):
(WebCore::isTopTargetFrameName):
- Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::keySystemIsSupported):
- Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::similarFont):
(WebCore::FontCache::platformAlternateFamilyName):
- Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::Font::platformInit):
- Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::isThunderRanked):
- Source/WebCore/platform/network/CacheValidation.cpp:
- Source/WebCore/platform/network/HTTPParsers.cpp:
(WebCore::normalizeHTTPMethod):
(WebCore::isSafeMethod):
- Source/WebCore/platform/network/curl/CurlMultipartHandle.cpp:
(WebCore::CurlMultipartHandle::extractBoundary):
- Source/WebCore/platform/playstation/MIMETypeRegistryPlayStation.cpp:
(WebCore::MIMETypeRegistry::mimeTypeForExtension):
(WebCore::MIMETypeRegistry::preferredExtensionForMIMEType):
- Source/WebCore/style/ElementRuleCollector.h:
(WebCore::Style::ElementRuleCollector::setMedium):
- Source/WebCore/svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendArabicReplacementSubtable):
(WebCore::SVGToOTFFontConverter::appendGSUBTable):
- Source/WebCore/xml/XMLHttpRequest.cpp:
(WebCore::replaceCharsetInMediaTypeIfNeeded):
Canonical link: https://commits.webkit.org/250075@main
- 8:23 PM Changeset in webkit [293560] by
-
- 2 edits in trunk/LayoutTests
[ macOS wk1 ] Fourteen webgl/2.0.0/conformance tests are a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=239835
Unreviewed test gardening.
- LayoutTests/platform/mac-wk1/TestExpectations:
Canonical link: https://commits.webkit.org/250074@main
- 8:19 PM Changeset in webkit [293559] by
-
- 2 edits in trunk/Tools
[ iOS ] TestWebKitAPI.IndexedDB.IndexedDBSuspendImminently is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=239310
<rdar://problem/91721160>
Reviewed by Youenn Fablet.
Message may be received before runTestAndCheckResult(), so we should not unset receivedScriptMessage before
wait.
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm:
(runUntilMessageReceived):
(TEST):
(runTestAndCheckResult): Deleted.
- 8:04 PM Changeset in webkit [293558] by
-
- 2 edits in trunk/Source/WebGPU
WebGPU doesn't create a symlink to the system content path in installhdrs
https://bugs.webkit.org/show_bug.cgi?id=239819
Reviewed by Alexey Proskuryakov.
Enabled script phases for installhdrs and installapi.
- Configurations/WebGPU.xcconfig:
- 8:03 PM Changeset in webkit [293557] by
-
- 9 edits in trunk
[git-webkit] Run style checker
https://bugs.webkit.org/show_bug.cgi?id=239730
<rdar://problem/92428565>
Reviewed by Chris Dumez.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git): Add webkitscmpy.auto-check option.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py:
(PullRequest.parser): Add --check/--no-check flag.
(PullRequest.pre_pr_checks): Find and run all pre-PR checks.
(PullRequest.create_pull_request): Run PR checks.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py:
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/revert_unittest.py:
- metadata/git_config_extension: Add style-checker as pre-pr check.
Canonical link: https://commits.webkit.org/250071@main
- 7:46 PM Changeset in webkit [293556] by
-
- 1 copy in tags/WebKit-7613.2.7.2.5
Tag WebKit-7613.2.7.2.5.
- 7:45 PM Changeset in webkit [293555] by
-
- 9 edits in branches/safari-613.2.7.2-branch/Source
Versioning.
WebKit-7613.2.7.2.5
- 7:42 PM Changeset in webkit [293554] by
-
- 1 copy in tags/WebKit-7613.2.7.3.5
Tag WebKit-7613.2.7.3.5.
- 7:37 PM Changeset in webkit [293553] by
-
- 9 edits in branches/safari-613.2.7.3-branch/Source
Versioning.
WebKit-7613.2.7.3.5
- 7:25 PM Changeset in webkit [293552] by
-
- 1 copy in tags/WebKit-7613.2.7.0.6
Tag WebKit-7613.2.7.0.6.
- 7:24 PM Changeset in webkit [293551] by
-
- 9 edits in branches/safari-613.2.7.0-branch/Source
Versioning.
WebKit-7613.2.7.0.6
- 7:03 PM Changeset in webkit [293550] by
-
- 2 edits in trunk/Source/WebCore
Ensure completion handler is called in SWServer::clear
https://bugs.webkit.org/show_bug.cgi?id=239755
Reviewed by Youenn Fablet.
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::clearAll):
(WebCore::SWServer::clear):
- 5:32 PM Changeset in webkit [293549] by
-
- 2 edits in trunk/Source/bmalloc
Unreviewed libpas build fix for PlayStation.
https://bugs.webkit.org/show_bug.cgi?id=239834
- libpas/src/libpas/pas_random.h:
(pas_get_random):
Temporarily disable path on PlayStation.
Canonical link: https://commits.webkit.org/250069@main
- 5:29 PM Changeset in webkit [293548] by
-
- 82 edits in trunk
Drop AtomString(const char*, ConstructFromLiteral) constructor
https://bugs.webkit.org/show_bug.cgi?id=239721
Reviewed by Darin Adler.
Drop AtomString(const char*, ConstructFromLiteral) constructor and instead update
the call sites to use the AtomString(ASCIILiteral) one instead. It reduces
complexity to not have several constructor for the same purpose.
- Tools/TestWebKitAPI/Tests/WTF/AtomString.cpp:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WebCore/Logging.cpp:
(TestWebKitAPI::TEST_F):
- Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::resourceType):
- Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::subresourcesType):
- Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::soupHTTPVersionToString):
- Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::PDFPlugin):
- Source/WebKit/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::attach):
- Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
(WebKit::PDFPluginChoiceAnnotation::createAnnotationElement):
- Source/WTF/wtf/text/AtomString.cpp:
(WTF::AtomString::init):
- Source/WTF/wtf/text/AtomString.h:
- Source/WebCore/Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.cpp:
(WebCore::stringForPlaybackTargetAvailability):
- Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::automaticKeyword):
(WebCore::MediaControlsHost::forcedOnlyKeyword):
(WebCore::alwaysOnKeyword):
(WebCore::manualKeyword):
(WebCore::MediaControlsHost::mediaControlsContainerClassName const):
- Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::kind const):
(WebCore::MediaStreamTrack::contentHint const):
- Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:
(WebCore::blobKeyword):
(WebCore::arraybufferKeyword):
- Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::YouTubePluginReplacement::installReplacement):
- Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::liveRegionRelevant const):
- Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateDefaultValue):
- Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunction_methodWithOptionalAtomStringAndDefaultValueBody):
- Source/WebCore/css/MediaFeatureNames.cpp:
(WebCore::MediaFeatureNames::init):
- Source/WebCore/css/makeprop.pl:
- Source/WebCore/css/parser/CSSParserSelector.cpp:
(WebCore::CSSParserSelector::parsePseudoElementSelector):
- Source/WebCore/dom/ConstantPropertyMap.cpp:
(WebCore::ConstantPropertyMap::nameForProperty const):
- Source/WebCore/dom/Document.cpp:
(WebCore::Document::validateCustomElementName):
- Source/WebCore/dom/EventNames.cpp:
- Source/WebCore/dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::imageOverlayElementIdentifier):
(WebCore::ImageOverlay::imageOverlayDataDetectorClass):
(WebCore::ImageOverlay::imageOverlayLineClass):
(WebCore::ImageOverlay::imageOverlayTextClass):
(WebCore::ImageOverlay::imageOverlayBlockClass):
- Source/WebCore/dom/MutationRecord.cpp:
- Source/WebCore/dom/mac/ImageControlsMac.cpp:
(WebCore::ImageControlsMac::imageControlsElementIdentifier):
(WebCore::ImageControlsMac::imageControlsButtonIdentifier):
- Source/WebCore/dom/make_names.pl:
(printNamesCppFile):
- Source/WebCore/editing/MarkupAccumulator.cpp:
(WebCore::htmlAttributeSerialization):
- Source/WebCore/html/Autocapitalize.cpp:
(WebCore::stringForAutocapitalizeType):
- Source/WebCore/html/Autofill.cpp:
(WebCore::isContactToken):
- Source/WebCore/html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::appendEntry):
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):
- Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
(WebCore::HTMLAnchorElement::isSystemPreviewLink):
- Source/WebCore/html/HTMLElement.cpp:
(WebCore::toValidDirValue):
- Source/WebCore/html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::formControlType const):
- Source/WebCore/html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::formControlType const):
- Source/WebCore/html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::formControlType const):
- Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::formControlType const):
- Source/WebCore/html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::scope const):
- Source/WebCore/html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::formControlType const):
- Source/WebCore/html/HTMLTextFormControlElement.cpp:
(WebCore::directionString):
- Source/WebCore/html/InputMode.cpp:
(WebCore::InputModeNames::numeric):
(WebCore::InputModeNames::decimal):
- Source/WebCore/html/InputTypeNames.cpp:
(WebCore::InputTypeNames::checkbox):
(WebCore::InputTypeNames::color):
(WebCore::InputTypeNames::date):
(WebCore::InputTypeNames::datetimelocal):
(WebCore::InputTypeNames::file):
(WebCore::InputTypeNames::hidden):
(WebCore::InputTypeNames::image):
(WebCore::InputTypeNames::month):
(WebCore::InputTypeNames::number):
(WebCore::InputTypeNames::password):
(WebCore::InputTypeNames::radio):
(WebCore::InputTypeNames::range):
(WebCore::InputTypeNames::time):
(WebCore::InputTypeNames::week):
- Source/WebCore/html/MediaController.cpp:
(WebCore::playbackStateWaiting):
(WebCore::playbackStatePlaying):
(WebCore::playbackStateEnded):
- Source/WebCore/html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::MediaDocument::replaceMediaElementTimerFired):
- Source/WebCore/html/ModelDocument.cpp:
(WebCore::ModelDocumentParser::createDocumentStructure):
- Source/WebCore/html/PDFDocument.cpp:
(WebCore::PDFDocument::createDocumentStructure):
- Source/WebCore/html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
- Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createContainer):
- Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
(WebCore::createForeignAttributesMap):
- Source/WebCore/html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeHourFieldElement::create):
(WebCore::DateTimeMeridiemFieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeSymbolicMonthFieldElement::create):
(WebCore::DateTimeYearFieldElement::create):
- Source/WebCore/html/shadow/ShadowPseudoIds.cpp:
(WebCore::ShadowPseudoIds::cue):
(WebCore::ShadowPseudoIds::fileSelectorButton):
(WebCore::ShadowPseudoIds::placeholder):
(WebCore::ShadowPseudoIds::webkitContactsAutoFillButton):
(WebCore::ShadowPseudoIds::webkitCredentialsAutoFillButton):
(WebCore::ShadowPseudoIds::webkitCreditCardAutoFillButton):
(WebCore::ShadowPseudoIds::webkitStrongPasswordAutoFillButton):
(WebCore::ShadowPseudoIds::webkitCapsLockIndicator):
(WebCore::ShadowPseudoIds::webkitColorSwatch):
(WebCore::ShadowPseudoIds::webkitColorSwatchWrapper):
(WebCore::ShadowPseudoIds::webkitDatetimeEdit):
(WebCore::ShadowPseudoIds::webkitDatetimeEditText):
(WebCore::ShadowPseudoIds::webkitDatetimeEditFieldsWrapper):
(WebCore::ShadowPseudoIds::webkitDateAndTimeValue):
(WebCore::ShadowPseudoIds::webkitDetailsMarker):
(WebCore::ShadowPseudoIds::webkitGenericCueRoot):
(WebCore::ShadowPseudoIds::webkitInnerSpinButton):
(WebCore::ShadowPseudoIds::webkitListButton):
(WebCore::ShadowPseudoIds::webkitMediaSliderThumb):
(WebCore::ShadowPseudoIds::webkitMediaSliderContainer):
(WebCore::ShadowPseudoIds::webkitMediaTextTrackContainer):
(WebCore::ShadowPseudoIds::webkitMediaTextTrackDisplay):
(WebCore::ShadowPseudoIds::webkitMediaTextTrackDisplayBackdrop):
(WebCore::ShadowPseudoIds::webkitMediaTextTrackRegion):
(WebCore::ShadowPseudoIds::webkitMediaTextTrackRegionContainer):
(WebCore::ShadowPseudoIds::webkitMeterBar):
(WebCore::ShadowPseudoIds::webkitMeterInnerElement):
(WebCore::ShadowPseudoIds::webkitMeterOptimumValue):
(WebCore::ShadowPseudoIds::webkitMeterSuboptimumValue):
(WebCore::ShadowPseudoIds::webkitMeterEvenLessGoodValue):
(WebCore::ShadowPseudoIds::webkitPluginReplacement):
(WebCore::ShadowPseudoIds::webkitProgressBar):
(WebCore::ShadowPseudoIds::webkitProgressValue):
(WebCore::ShadowPseudoIds::webkitProgressInnerElement):
(WebCore::ShadowPseudoIds::webkitSearchDecoration):
(WebCore::ShadowPseudoIds::webkitSearchResultsButton):
(WebCore::ShadowPseudoIds::webkitSearchResultsDecoration):
(WebCore::ShadowPseudoIds::webkitSearchCancelButton):
(WebCore::ShadowPseudoIds::webkitSliderRunnableTrack):
(WebCore::ShadowPseudoIds::webkitSliderThumb):
(WebCore::ShadowPseudoIds::webkitSliderContainer):
(WebCore::ShadowPseudoIds::webkitTextfieldDecorationContainer):
(WebCore::ShadowPseudoIds::webkitValidationBubble):
(WebCore::ShadowPseudoIds::webkitValidationBubbleArrowClipper):
(WebCore::ShadowPseudoIds::webkitValidationBubbleArrow):
(WebCore::ShadowPseudoIds::webkitValidationBubbleMessage):
(WebCore::ShadowPseudoIds::webkitValidationBubbleIcon):
(WebCore::ShadowPseudoIds::webkitValidationBubbleTextBlock):
(WebCore::ShadowPseudoIds::webkitValidationBubbleHeading):
(WebCore::ShadowPseudoIds::webkitValidationBubbleBody):
- Source/WebCore/html/track/AudioTrack.cpp:
(WebCore::AudioTrack::descriptionKeyword):
(WebCore::AudioTrack::mainDescKeyword):
(WebCore::AudioTrack::translationKeyword):
- Source/WebCore/html/track/TextTrack.cpp:
(WebCore::descriptionsKeyword):
(WebCore::chaptersKeyword):
(WebCore::metadataKeyword):
(WebCore::forcedKeyword):
- Source/WebCore/html/track/VTTRegion.cpp:
(WebCore::upKeyword):
(WebCore::VTTRegion::textTrackCueContainerScrollingClass):
- Source/WebCore/html/track/VideoTrack.cpp:
(WebCore::VideoTrack::signKeyword):
- Source/WebCore/loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::initiatorName const):
- Source/WebCore/loader/cache/CachedResourceRequestInitiators.cpp:
(WebCore::CachedResourceRequestInitiators::CachedResourceRequestInitiators):
- Source/WebCore/page/EventHandler.cpp:
(WebCore::focusDirectionForKey):
- Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldBypassBackForwardCache const):
- Source/WebCore/platform/CommonAtomStrings.cpp:
- Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:
(WebCore::PlaybackSessionModelMediaElement::eventNameAll):
- Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::useBackslashAsYenSignForFamily):
- Source/WebCore/platform/graphics/FontDescription.cpp:
(WebCore::computeSpecializedChineseLocale):
- Source/WebCore/platform/graphics/MediaPlayer.cpp:
(WebCore::applicationOctetStream):
- Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::metadataType):
- Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::lastResortFallbackFont):
- Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
(WebCore::SystemFontDatabaseCoreText::systemFontParameters):
- Source/WebCore/platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::controlFont const):
- Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::extractHTTPStatusText):
- Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::ResourceResponse):
- Source/WebCore/rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::updateCachedSystemFontDescription const):
- Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::setFontFromControlSize const):
- Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjustForSiteSpecificQuirks const):
- Source/WebCore/svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::rotateMode const):
- Source/WebCore/svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::setCalcMode):
(WebCore::SVGAnimationElement::setAttributeType):
(WebCore::sumAtom):
- Source/WebCore/svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::media const):
- Source/WebCore/svg/animation/SVGSMILElement.cpp:
(WebCore::indefiniteAtom):
(WebCore::SVGSMILElement::restart const):
(WebCore::SVGSMILElement::fill const):
- Source/WebCore/svg/properties/SVGAnimationAdditiveValueFunctionImpl.cpp:
(WebCore::SVGAnimationColorFunction::colorFromString):
- Source/WebCore/svg/properties/SVGPropertyAnimator.h:
(WebCore::SVGPropertyAnimator::adjustForInheritance const):
Canonical link: https://commits.webkit.org/250068@main
- 4:54 PM Changeset in webkit [293547] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'this.resource.hadLoadingError')
https://bugs.webkit.org/show_bug.cgi?id=239824
Reviewed by Patrick Angle.
- UserInterface/Views/LocalResourceOverrideTreeElement.js:
(WI.LocalResourceOverrideTreeElement.prototype.updateStatus):
- 4:42 PM Changeset in webkit [293546] by
-
- 31 edits in trunk/Source/WebCore/html
Devirtualize InputType validation
https://bugs.webkit.org/show_bug.cgi?id=239809
Reviewed by Geoff Garen and Cameron McCormack.
HTMLInputElement::isValidValue() used to call 4 virtual functions on InputType
and is hot code on Speedometer. To optimize this, HTMLInputElement::isValidValue()
now calls a non-virtual HTMLInputElement::isValidValue() which switches on the
input type and then calls the 4 functions on the actual InputType subclass, so
that the compiler can optimize out the virtual calls out thanks to final
optimization.
This is a 0.5-0.75% progression on Speedometer on Intel. This might be a very
small (~0.2%) progression on Apple Silicon.
- Source/WebCore/html/BaseButtonInputType.h:
(WebCore::BaseButtonInputType::BaseButtonInputType):
- Source/WebCore/html/BaseCheckableInputType.h:
(WebCore::BaseCheckableInputType::BaseCheckableInputType):
- Source/WebCore/html/BaseClickableWithKeyInputType.h:
(WebCore::BaseClickableWithKeyInputType::BaseClickableWithKeyInputType):
- Source/WebCore/html/BaseDateAndTimeInputType.h:
- Source/WebCore/html/BaseTextInputType.h:
(WebCore::BaseTextInputType::BaseTextInputType):
- Source/WebCore/html/ButtonInputType.h:
- Source/WebCore/html/CheckboxInputType.h:
- Source/WebCore/html/ColorInputType.h:
- Source/WebCore/html/DateInputType.h:
- Source/WebCore/html/DateTimeLocalInputType.h:
- Source/WebCore/html/EmailInputType.h:
- Source/WebCore/html/FileInputType.h:
- Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isValidValue const):
- Source/WebCore/html/HiddenInputType.h:
- Source/WebCore/html/ImageInputType.h:
- Source/WebCore/html/InputType.cpp:
(WebCore::validateInputType):
(WebCore::InputType::isValidValue const):
- Source/WebCore/html/InputType.h:
(WebCore::InputType::type const):
- Source/WebCore/html/MonthInputType.h:
- Source/WebCore/html/NumberInputType.h:
- Source/WebCore/html/PasswordInputType.h:
- Source/WebCore/html/RadioInputType.h:
- Source/WebCore/html/RangeInputType.h:
- Source/WebCore/html/ResetInputType.h:
- Source/WebCore/html/SearchInputType.h:
- Source/WebCore/html/SubmitInputType.h:
- Source/WebCore/html/TelephoneInputType.h:
- Source/WebCore/html/TextFieldInputType.h:
- Source/WebCore/html/TextInputType.h:
- Source/WebCore/html/TimeInputType.h:
- Source/WebCore/html/URLInputType.h:
- Source/WebCore/html/WeekInputType.h:
Canonical link: https://commits.webkit.org/250065@main
- 4:42 PM Changeset in webkit [293545] by
-
- 4 edits in trunk/Tools
[git-webkit] Cleanup PRs on alternate remotes
https://bugs.webkit.org/show_bug.cgi?id=239814
<rdar://problem/92410887>
Reviewed by Aakash Jain.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/clean.py:
(Clean.parser): Add --remote argument.
(Clean.cleanup): Allow caller to specify remote.
(Clean.main): Pass remote to cleanup.
Canonical link: https://commits.webkit.org/250065@main
- 4:36 PM Changeset in webkit [293544] by
-
- 2 edits in trunk/Source/WTF
[PGO] Allow collecting other kinds of pgo profiles.
https://bugs.webkit.org/show_bug.cgi?id=239776
Reviewed by Saam Barati.
Update the way we collect PGO profiles to use LLVM's file handling, because
it really seems to care about that. This allowws us to try out other kinds
of profile generation, like the IR-based -fcs-profile-generate.
- Source/WTF/wtf/GenerateProfiles.h:
(WTF::registerProfileGenerationCallback):
Canonical link: https://commits.webkit.org/250064@main
- 3:58 PM Changeset in webkit [293543] by
-
- 8 edits2 adds in trunk
LayoutTests/imported/w3c:
Fix CSS cascade regarding logical properties
https://bugs.webkit.org/show_bug.cgi?id=236199
Reviewed by Darin Adler.
Expect animation-004.html to pass.
Add new test logicalprops-with-deferred-writing-mode.html
- web-platform-tests/css/css-logical/animation-004-expected.txt:
- web-platform-tests/css/css-logical/logicalprops-with-deferred-writing-mode-expected.txt: Added.
- web-platform-tests/css/css-logical/logicalprops-with-deferred-writing-mode.html: Added.
Source/WebCore:
Reland "Fix CSS cascade regarding logical properties"
https://bugs.webkit.org/show_bug.cgi?id=236199
Reviewed by Antti Koivisto.
This is a reland of https://commits.webkit.org/r291546, which was
reverted due to a performance regression. This problem should have been
addressed by bug 238260.
Original summary:
The CSS cascade was trying to resolve logical properties into physical
ones too early. This failed if we still didn't know the direction or
writing-mode, e.g. because they were set to a variable or to a CSS-wide
keyword.
This patch keeps logical properties as-is during the cascade. They are
only resolved when finally applied. Also, both logical properties and
their physical equivalents are now set to apply in parse order, since
'height: 0px; block-size: 1px' and 'block-size: 1px; height: 0px' can be
different, the order matters.
Tests: imported/w3c/web-platform-tests/css/css-logical/animation-004.html
imported/w3c/web-platform-tests/css/css-logical/logicalprops-with-deferred-writing-mode.html
- css/makeprop.pl:
(addProperty):
(sortByDescendingPriorityAndName):
Defer properties that belong to a logical property group.
- css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseValueWithVariableReferences):
Logical properties no longer need special handling for variables.
- style/PropertyCascade.cpp:
(WebCore::Style::PropertyCascade::PropertyCascade):
Remove members no longer needed.
(WebCore::Style::PropertyCascade::set):
This method is no longer used for properties in a logical property
group. Remove dead code and add assert.
(WebCore::Style::PropertyCascade::setDeferred):
Remove assert, logical properties are now handled here.
(WebCore::Style::PropertyCascade::lastDeferredPropertyResolvingRelated const):
Take into account that properties in a logical property group are now
deferred.
(WebCore::Style::PropertyCascade::resolveDirectionAndWritingMode const): Deleted.
(WebCore::Style::PropertyCascade::direction const): Deleted.
Remove broken logic.
- style/PropertyCascade.h:
Remove members, struct and methods no longer needed.
Update method signatures.
- style/StyleBuilder.cpp:
(WebCore::Style::Builder::Builder):
Remove argument no longer needed.
(WebCore::Style::Builder::applyProperty):
Resolve logical properties using the direction and writing-mode from the
style.
(WebCore::Style::directionFromStyle): Deleted.
Remove function no longer needed.
- 3:46 PM Changeset in webkit [293542] by
-
- 1 copy in tags/WebKit-7614.1.11
Tag WebKit-7614.1.11.
- 3:38 PM Changeset in webkit [293541] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Improve rendering of GLenums in WebGL canvas recordings.
https://bugs.webkit.org/show_bug.cgi?id=239586
Patch by Dan Glastonbury <djg@apple.com> on 2022-04-27
Reviewed by Devin Rousso.
- Source/WebInspectorUI/UserInterface/Models/RecordingAction.js:
(WI.RecordingAction.constantNameForParameter):
Arrays are also objects, so checking for typeof x == "object" is
not enough to distinguish arrays from dictionaries. Since the if
above the failing check was handling arrays, turn "object" check
into anelse ifhandles arrays and dictionaries correctly.
Canonical link: https://commits.webkit.org/250062@main
- 3:31 PM Changeset in webkit [293540] by
-
- 1 copy in tags/WebKit-7613.2.7.0.5
Tag WebKit-7613.2.7.0.5.
- 3:29 PM Changeset in webkit [293539] by
-
- 1 copy in tags/WebKit-7613.2.7.1.6
Tag WebKit-7613.2.7.1.6.
- 3:26 PM Changeset in webkit [293538] by
-
- 2 edits in branches/safari-613.2.7.1-branch/Source/WebKit
Cherry-pick r293481. rdar://problem/92336270
Adjust what we consider to be private relayed
https://bugs.webkit.org/show_bug.cgi?id=239784
<rdar://92336270>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-04-26
Reviewed by Geoffrey Garen.
If a request is not eligible for private relay, then do not consider it having been private relayed.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:25 PM Changeset in webkit [293537] by
-
- 2 edits in branches/safari-613.2.7.0-branch/Source/WebKit
Cherry-pick r293481. rdar://problem/92336270
Adjust what we consider to be private relayed
https://bugs.webkit.org/show_bug.cgi?id=239784
<rdar://92336270>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-04-26
Reviewed by Geoffrey Garen.
If a request is not eligible for private relay, then do not consider it having been private relayed.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm: (-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:45 PM Changeset in webkit [293536] by
-
- 1 copy in tags/WebKit-7613.2.7.3.4
Tag WebKit-7613.2.7.3.4.
- 2:44 PM Changeset in webkit [293535] by
-
- 9 edits in branches/safari-613.2.7.3-branch/Source
Versioning.
WebKit-7613.2.7.3.4
- 2:30 PM Changeset in webkit [293534] by
-
- 1 copy in tags/WebKit-7613.2.7.2.4
Tag WebKit-7613.2.7.2.4.
- 2:29 PM Changeset in webkit [293533] by
-
- 9 edits in branches/safari-613.2.7.2-branch/Source
Versioning.
WebKit-7613.2.7.2.4
- 1:41 PM Changeset in webkit [293532] by
-
- 2 edits in trunk/LayoutTests
[ macOS Debug wk2 ] fast/css/variables/test-suite/168.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=239822
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250061@main
- 1:20 PM Changeset in webkit [293531] by
-
- 11 edits in trunk/Source/WebCore
[GStreamer] Track handling fixes
https://bugs.webkit.org/show_bug.cgi?id=239702
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-27
Reviewed by Xabier Rodriguez-Calvar.
When the player is using playbin3 the audio/video/text tracks are associated to the
corresponding GstStream, itself part of a single GstStreamCollection. There is no need to
use a GRefPtr for GstStream in this case because those streams are not meant to be modified
and they remain valid as long as the parent collection is alive. So the player now keeps
track of the current stream collection and the private tracks handle GstStream pointers.
The stream collection handling was refactored, removing redundant logging, making use of
ScopeExit and removing the special case for text tracks creation.
This patch also changes the internal storage of tracks from HashMap<AtomString,RePtr<T>> to
HashMap<AtomString,Ref<T>>, bringing us a bit closer to the AVF implementation.
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):
(WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromTags):
(WebCore::AudioTrackPrivateGStreamer::updateConfigurationFromCaps):
(WebCore::AudioTrackPrivateGStreamer::kind const):
(WebCore::AudioTrackPrivateGStreamer::disconnect):
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
(WebCore::InbandTextTrackPrivateGStreamer::create):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfTrack):
(WebCore::MediaPlayerPrivateGStreamer::updateEnabledVideoTrack):
(WebCore::MediaPlayerPrivateGStreamer::updateEnabledAudioTrack):
(WebCore::MediaPlayerPrivateGStreamer::playbin3SendSelectStreamsIfAppropriate):
(WebCore::MediaPlayerPrivateGStreamer::updateTracks):
(WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::TrackPrivateBaseGStreamer):
(WebCore::TrackPrivateBaseGStreamer::disconnect):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
(WebCore::TrackPrivateBaseGStreamer::stream const):
(WebCore::TrackPrivateBaseGStreamer::stream): Deleted.
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):
(WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromTags):
(WebCore::VideoTrackPrivateGStreamer::updateConfigurationFromCaps):
(WebCore::VideoTrackPrivateGStreamer::kind const):
(WebCore::VideoTrackPrivateGStreamer::disconnect):
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
Canonical link: https://commits.webkit.org/250060@main
- 1:18 PM Changeset in webkit [293530] by
-
- 10 edits in trunk
[iOS] unable to start playing audio when device is locked
https://bugs.webkit.org/show_bug.cgi?id=239812
<rdar://90642648>
Reviewed by Jer Noble.
Source/WebCore:
Updated media/audio-session-category.html.
- platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::updateSessionState): Choose the appropriate
route sharing policy after choosing the audio session category because
setting MediaPlayback+Default makes a process ineligible for NowPlaying, and starting
playback in the background will be blocked.
- platform/audio/mac/AudioSessionMac.h:
- platform/audio/mac/AudioSessionMac.mm:
(WebCore::AudioSessionMac::setCategory): Updated for testing.
- testing/Internals.cpp:
(WebCore::Internals::routeSharingPolicy const): Added accessor for testing.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- media/audio-session-category-expected.txt:
- media/audio-session-category.html:
- 12:50 PM Changeset in webkit [293529] by
-
- 2 edits in trunk/LayoutTests
[ macOS Debug wk2 ] fast/css/identical-logical-height-decl.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=239818
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250058@main
- 12:13 PM Changeset in webkit [293528] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
Rebaseline imported/w3c/web-platform-tests/css/css-text/inheritance.html after r293521
https://bugs.webkit.org/show_bug.cgi?id=166782
Unreviewed test gardening.
- web-platform-tests/css/css-text/inheritance-expected.txt:
- 12:09 PM Changeset in webkit [293527] by
-
- 2 edits in trunk/Tools
[ews-build.webkit.org] Support alternative remotes (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=239617
<rdar://problem/92115230>
Unreviewed follow-up fix.
- Tools/CISupport/ews-build/events.py:
(GitHubEventHandlerNoEdits.extractProperties):
- 12:07 PM Changeset in webkit [293526] by
-
- 9 edits in branches/safari-613.2.7.0-branch/Source
Versioning.
WebKit-7613.2.7.0.5
- 12:06 PM Changeset in webkit [293525] by
-
- 9 edits in branches/safari-613.2.7.1-branch/Source
Versioning.
WebKit-7613.2.7.1.6
- 12:04 PM Changeset in webkit [293524] by
-
- 21 edits in trunk
Make -webkit-transform-style an alias of transform-style
https://bugs.webkit.org/show_bug.cgi?id=239808
Reviewed by Antti Koivisto.
Fixes cascade issues when applying both -webkit-transform-style and transform-style (see bug 239579), and removes
unnecessary code as well given the FIXME was never addressed.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
- web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
Source/WebCore:
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- css/CSSProperties.json:
- css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
- rendering/style/WillChangeData.cpp:
(WebCore::WillChangeData::propertyCreatesStackingContext):
LayoutTests:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 12:03 PM Changeset in webkit [293523] by
-
- 2 edits in trunk/LayoutTests
[GTK] The setting WebKitMinimumFontSize is not reset by the testing framework, leading to flaky tests
https://bugs.webkit.org/show_bug.cgi?id=237181
Unreviewed test gardening.
Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-04-27
- platform/gtk/TestExpectations: Remove skip now that the test doesn't cause problems.
- 12:01 PM Changeset in webkit [293522] by
-
- 4 edits in trunk/Source
Avoid sending a flush IPC to the GPU process when destroying a RemoteImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=239799
Reviewed by Said Abou-Hallawa.
After r280652, destroying a RemoteImageBufferProxy would always send a flush to the GPU
process, even if there had be no drawing since the previous flush.
Fix to only send a flush and wait when necessary.
Roughly 8% progression on MotionMark Images subtest on iPhone.
Source/WebCore:
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::flushDrawingContextAsync):
Source/WebKit:
- WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
(WebKit::RemoteImageBufferProxy::waitForDidFlushWithTimeout):
- 11:56 AM Changeset in webkit [293521] by
-
- 24 edits in trunk
[css-text] Make word-wrap CSS property an alias of overflow-wrap
https://bugs.webkit.org/show_bug.cgi?id=166782
Reviewed by Antti Koivisto.
This follows the spec, and fixes cascade issues when applying both properties (see bug 239579).
Relevant WPT expectations updated to pass.
- LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/overflow-wrap/word-wrap-alias-expected.txt:
- Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- Source/WebCore/css/CSSProperties.json:
- Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
- Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::applyEditingStyleToBodyElement const):
- Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::collectPresentationalHintsForAttribute):
- Source/WebCore/html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::collectPresentationalHintsForAttribute):
- LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
- LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt:
- LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- LayoutTests/svg/css/getComputedStyle-basic-expected.txt:* web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
Canonical link: https://commits.webkit.org/250052@main
- 11:37 AM Changeset in webkit [293520] by
-
- 2 edits in trunk/JSTests
Unskip flaky test on mips
https://bugs.webkit.org/show_bug.cgi?id=239342
Unreviewed gardening.
Re-enable test. It should still be flaky, so can use it to test
the code reporting the flakiness to resultsdb.
- stress/new-largeish-contiguous-array-with-size.js:
- 10:36 AM Changeset in webkit [293519] by
-
- 4 edits in trunk
[iOS] Focus changes unexpectedly when scrolling to a found text range
https://bugs.webkit.org/show_bug.cgi?id=239793
rdar://90996437
Reviewed by Wenson Hsieh.
Source/WebKit:
- WebProcess/WebPage/WebFoundTextRangeController.cpp:
(WebKit::WebFoundTextRangeController::scrollTextRangeToVisible):
Specify
DoNotSetFocusin theTemporarySelectionOptions to avoid
unnecessary focus changes when scrolling to a found text range.
Focus changes can cause the web view to regain first responder status
while searching for text, which will dismiss the find panel and end
the search session.
Tools:
Add an API test to ensure that scrolling to a found range does not
change focus.
- TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
(TEST):
- 10:30 AM Changeset in webkit [293518] by
-
- 7 edits in trunk/Source/bmalloc
[libpas] Implement secure random numbers
https://bugs.webkit.org/show_bug.cgi?id=239735
Reviewed by Yusuke Suzuki.
We currently have a cheesy random and secure random, which use the same implementation for generating
random numbers. (We are going to ignore the mock testing code here). This patch introduces a fast random and
secure random. The fast random maintains the same properties as the previous implementation, while secure random
will use the cryptographically secure arc4random_uniform to give better randomness. arc4random() can be quite an
expensive operation and based on discussing with Yusuke he found heavy performance penalties when using this in
JSC. Our secure random shall only be used in cases where true randomness is needed. We have 2 spots where we
currently use secure random; we shall just migrate those over to using fast random.
- Source/bmalloc/libpas/src/libpas/pas_baseline_allocator_table.c:
(pas_baseline_allocator_table_get_random_index):
- Source/bmalloc/libpas/src/libpas/pas_dynamic_primitive_heap_map.c:
(pas_dynamic_primitive_heap_map_find_slow):
- Source/bmalloc/libpas/src/libpas/pas_random.c:
- Source/bmalloc/libpas/src/libpas/pas_random.h:
(pas_get_random):
- Source/bmalloc/libpas/src/libpas/pas_segregated_shared_page_directory.c:
(find_first_eligible_consider_view):
- Source/bmalloc/libpas/src/test/IsoHeapPartialAndBaselineTests.cpp:
(std::testTwoBaselinesEvictions):
Canonical link: https://commits.webkit.org/250049@main
- 10:26 AM Changeset in webkit [293517] by
-
- 2 edits in trunk/LayoutTests
Cleanup expectations for 7 imported/w3c/web-platform-tests/html/semantics/interactive-elements/ tests
https://bugs.webkit.org/show_bug.cgi?id=239790
Unreviewed test gardening.
- LayoutTests/platform/ios-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250048@main
- 10:22 AM Changeset in webkit [293516] by
-
- 4 edits in trunk
[Mac] http/tests/media/user-gesture-preserved-across-xmlhttprequest.html is a flaky fail/crash/timeout
https://bugs.webkit.org/show_bug.cgi?id=229588
<rdar://problem/82408723>
Reviewed by Chris Dumez.
Source/WebCore:
I removed the user gesture in fetch by mistake so let's add it back.
Test is no longer crashing on bots and is timing out on debug bots because it is a slow test.
Mark test as slow and remove flakiness expectations.
Covered by unflaked test.
- Modules/fetch/WindowOrWorkerGlobalScopeFetch.cpp:
(WebCore::doFetch):
LayoutTests:
- platform/mac/TestExpectations:
- 10:15 AM Changeset in webkit [293515] by
-
- 4 edits in trunk/Tools
test-webkitpy TestInstallGitLFS fails
https://bugs.webkit.org/show_bug.cgi?id=239788
<rdar://problem/92363359>
Reviewed by Michael Catanzaro.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_git_lfs_unittest.py:
(TestInstallGitLFS.test_install): Specify mock system and machine.
(TestInstallGitLFS.test_configure): Ditto.
(TestInstallGitLFS.test_no_op): Ditto.
(TestInstallGitLFS.test_no_repo): Ditto.
Canonical link: https://commits.webkit.org/250046@main
- 10:12 AM Changeset in webkit [293514] by
-
- 6 edits in trunk/Tools
[commits.webkit.org] Change branch forwarding behavior
https://bugs.webkit.org/show_bug.cgi?id=239136
<rdar://problem/91314217>
Reviewed by Dewei Zhu.
- Tools/Scripts/libraries/reporelaypy/reporelaypy/init.py: Bump version.
- Tools/Scripts/libraries/reporelaypy/setup.py: Ditto.
- Tools/Scripts/libraries/reporelaypy/reporelaypy/checkout.py:
(Checkout.Encoder.default): Encode forwarding list.
(Checkout.init): Add forwarding argument.
(Checkout.push_update): Add dest_branch argument.
(Checkout.forward_update): Trigger push_update based on forwarding arguments.
(Checkout.update_all): Use forward_update instead of pushing to every branch.
- Tools/Scripts/libraries/reporelaypy/reporelaypy/hooks.py:
(HookProcessor.process_worker_hook): Extract remote from incoming data, invoke forward_update.
- Tools/Scripts/libraries/reporelaypy/reporelaypy/tests/checkout_unittest.py:
(CheckoutUnittest.test_json):
Canonical link: https://commits.webkit.org/250045@main
- 10:06 AM Changeset in webkit [293513] by
-
- 387 edits4 copies23 adds7 deletes in trunk/Source/ThirdParty/ANGLE
Update ANGLE to 2022-04-26 (7ca11287a056d4150cba96c9c9b964153ad539cb)
https://bugs.webkit.org/show_bug.cgi?id=239114
<rdar://problem/91944443>
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-27
Reviewed by Kenneth Russell.
Contains upstream commits:
git log --oneline fe28a4295af087ee82b8f629b67176b95019af6d..7ca11287a056d4150cba96c9c9b964153ad539cb --pretty="%h %s"
7ca11287a Roll SwiftShader from f13461dbb23c to 5f5faa3a2aad (1 revision)
9d6b3a7ee Vulkan: Move overlay draw after swap's implicit flush
4aae5815f Vulkan: Overlay widgets for submission statistics
02b968481 Vulkan: Add support for GL_QCOM_shading_rate
69705e5c0 Add -Wno-deprecated-non-prototype
c0ac374f7 Replaceadb exec-out catwith pull to temp location.
018118394 Refactor platform code
ea76cb0f5 Vulkan: Add entry points for GL_QCOM_shading_rate
62ca64492 Reland "Fix BlendStateExt::mMaxColorMask initialization"
d1788614c Use adb instead of catapult to run perf tests on Android.
e0183a421 Revert "Mark contexts as shared when importing EGL images."
400d9fe43 Rename feature files to *_autogen.h
0f3710d99 Generalize GetDisplayFromNativeDisplay
a8cac0058 Remove observer when element array buffer is detached
2d6e42fcc Update Program Pipeline TODOs.
853b6edf9 Roll SwiftShader from 71f3089b729c to f13461dbb23c (1 revision)
c95bd5e7e Roll vulkan-deps from 01fd48aca427 to f685346e2e51 (6 revisions)
2db718edf Vulkan: Skip empty submissions
b07a11569 Split Context ResourceUseList to RP Commandbuffers
37c53684e Split Context ResourceUseList to RP Commandbuffers
158951600 Avoid leaking gl::Framebuffers in gl::Context
f565ea4d6 Roll vulkan-deps from 158676f39f3b to 01fd48aca427 (13 revisions)
ad93a708a Further expand Vulkan end2end_test skip
e6fc5e62c Use _FindAdb (cached) directly instead of Adb wrapper.
4ac3ec13e Switch py_utils import to pathlib.
64fa5edaa Suppress VVL UNASSIGNED-BestPractices-SemaphoreCount
e1fdef909 Revert "Vulkan: Cache ImageView serials on texture changes."
3b38b3790 Vulkan: Add feature avoid HOST_VISIBLE and DEVICE_LOCAL combination
d988db39b Fall back to adb on PATH if platform-tools not present.
2dd13ebbd Track Surface color & depth/stencil init separately.
8f56edfdd Roll Chromium from 408793418c48 to 192db13f8509 (548 revisions)
0690f5d34 Revert "CGL, MTL: pbuffer for IOSurface fails for some formats"
0439d9cd2 Vulkan: Update glslang wrapper TODO.
768c7d47e Revert "Re-land: "Vulkan: Support Wayland""
47b9a97b6 Expand Vulkan end2end_test skip.
dc1b7029e Disable MSAN in the Vulkan loader
7a32cf547 Android: Add build to blueprint.
13784ebe3 Vulkan: use "undefined" for layerProvokingVertex
04c6f9375 Roll SwiftShader from ea5f37f39193 to 71f3089b729c (5 revisions)
96239a340 Roll Chromium from a434f1de2483 to 408793418c48 (456 revisions)
1d67951e0 Avoid IOError in capture_replay_tests.py
dd493b5ca EGL: allow eglQueryString(EGL_NO_DISPLAY, EGL_VERSION)
6cbedc984 Add a test for backwards mip generation with draw
d3dbaa8df Vulkan: Remove BufferVk::mHasBeenReferencedByGPU
5097d10c1 D3D: unsuppress some now-passing tests.
cb1ee485f Vulkan: Add perf test for MSAA swapchain resolve
c66de085a Vulkan: Fix surface invalidate w.r.t shared present mode
19c6a8566 Tests: Add Free Fire Max trace
7d229d047 Vulkan: Cache ImageView serials on texture changes.
7c091cb35 Use adb directly (instead of catapult) in gold tests.
4efc4ee68 Fix validate state cache after XFB buffer deleted.
3f800e5c8 Metal:Clear Backbuffer when Robust Resource Init enabled
5b84ad797 CGL, MTL: pbuffer for IOSurface fails for some formats
ff8a9f6a1 Vulkan: Renaming "ShaderBuffers" to "ShaderResources".
f6cdd02fb Re-land: "Vulkan: Support Wayland"
5610ab642 Fix ANGLEGetDisplayPlatform after method deprecation
6199e905a Switch to using build/android:build_java
b2a1f0d28 Track total vs per-frame descriptor set counters.
37cdf93d0 Vulkan: Acquire a new buffer even when size is unchanged
349612591 Roll vulkan-deps from 00e1ddd4230c to 158676f39f3b (8 revisions)
f4a550bff Roll SwiftShader from 103a69bd6c82 to ea5f37f39193 (3 revisions)
dde8b6629 Roll Chromium from e1b5a693bbfe to a434f1de2483 (504 revisions)
fcec69045 Generate feature variable names from display names
f4fc8e168 Revert "Fix BlendStateExt::mMaxColorMask initialization"
5014ce664 Vulkan: Add orphaned list for non-empty BufferBlocks.
55c21842b Vulkan: Use flat array lookups for shader variables.
6e130d2b7 D3D: fix SSBOs used in vertex shaders.
50d008a7e Fix BlendStateExt::mMaxColorMask initialization
cfc92ebf1 Vulkan: Encapsulate ShareGroup::mContexts
9907f22d0 gold tests: Add command-line arg for gold instance.
e18240d13 Mark contexts as shared when importing EGL images.
bddb944bc Vulkan: Prep variable info map to remove hashing.
242f0d81f Revert "Infra: Enable Skia Gold tests on Pixel 6"
acdec48ad Tests: Add Monster Strike trace
e77be6632 Use ProgramExecutable directly in GlslangWrapper.
c82513afb Add FastMap class.
4cd15cb39 Skip a Vulkan test due to a threading flake.
64fa1e80f Revert "vulkan: Call glFinish in VulkanHelper destructor"
9cc459c98 Add check for GL_ANDROID_extension_pack_es31a support
dbe5b7554 Roll vulkan-deps from 1a408eb154d7 to 00e1ddd4230c (8 revisions)
834ca6869 Roll Chromium from e9b55eb91cb1 to e1b5a693bbfe (303 revisions)
197100880 Vulkan: Call into vulkan directly for big size allocation.
bdb52cb8b Vulkan: Remove retains before acquireBufferHelper
866210add Metal: Fix bytesPerRow computation for compressed formats
33c8a2d0d Roll vulkan-deps from 7f875b15c6a3 to 1a408eb154d7 (4 revisions)
d903818a8 Roll Chromium from 573f2ec89cb9 to e9b55eb91cb1 (411 revisions)
3636d129e Infra: Enable Skia Gold tests on Pixel 6
d18e9e84a Roll vulkan-deps from c9be322642fb to 7f875b15c6a3 (16 revisions)
dfde9f402 Roll SwiftShader from 1d450ae99a0f to 103a69bd6c82 (3 revisions)
ff084b28d Roll Chromium from e6765ea8299f to 573f2ec89cb9 (443 revisions)
5f7db7755 Vulkan: updateUniforms when commandbuffer is valid
3587e217d Remove copyResourceUseList from ShareGroupVk
956fb16ec Remove Win NVIDIA dEQP suppressions
5e48e5b8d Roll VK-GL-CTS from 2748d45ebbb4 to a22069b4e3b7 (10 revisions)
aefb2a99e vulkan: Call glFinish in VulkanHelper destructor
4a33204ce Roll VK-GL-CTS from 20a474e64382 to 2748d45ebbb4 (1 revision)
039660a07 Translator: Drop const from opaque parameter types
0360248c6 Suppress flaky end2end failures on Mac/NVIDIA/OpenGL
03b3bc3f6 Tests: Add Special Forces Group 2 trace.
c3f159629 Fix OOB problem in validationES.{h,cpp}
fef34a6ef doc/DevSetup: Add Visual Studio Installer hint.
27b01dd4a Roll SwiftShader from 011bba68c819 to 1d450ae99a0f (4 revisions)
fcd6e2605 GN: Fix util target when X11 not enabled
b5d34da08 Add src/tests/py_utils/ for utils, angle_path_util for imports.
7e61e176e Roll Chromium from 61150a1970a3 to e6765ea8299f (515 revisions)
871878352 Metal: For readPixels copy IOSurface to non-IOSurface texture
52237c322 Suppress CopyTextureTest.CopyToMipmap on Intel Mac OpenGL
d2fd28cae Vulkan: Relax advanced blend on VK extension requirement
c5271e8e6 Vulkan: Emulate GL_KHR_blend_equation_advanced
01c0bc215 Revert "Vulkan: Support Wayland"
af51a287a Vulkan: Enum class instead of bool didRespecify
e9d695b5d Roll vulkan-deps from 345e2a278e69 to c9be322642fb (74 revisions)
f00d827e0 Roll SwiftShader from 620982155d55 to 011bba68c819 (4 revisions)
4b8e5db62 Roll Chromium from f961a0d4732b to 61150a1970a3 (431 revisions)
985d42934 Metal:Speed up BGRA8 to RGBA8 copy for readPixels
8074061d2 Remove feature override platform methods
a0b5299b6 Vulkan: Fix resolve with subpass into smaller framebuffer
6768aff71 Fix Geometry Shader Conformance Test Failure on Pixel6
445bf9bdf Use the real max vertex attrib index instead of MAX_VERTEX_ATTRIBS
d4cbd9bfe vulkan: Mark external memory textures as preinitialized
291be0b7a Suppress multisample_interpolation dEQP failures on Pixel 6 Vulkan
9442b7a83 D3D: Remove a pass-through function.
957f82974 Vulkan: Change ContextVk to Context for BufferPool APIs
510351f20 Vulkan: Support Wayland
ea86cfd2e Roll chromium_revision f89964bd5b..f961a0d473 (990903:991486)
fb093278c egl_angle_ext: add more missing extension enum values
93ccde91b Update ANGLE's docs regarding Windows 10 SDK version to use
19582d120 gl_angle_ext.xml: treat glProvokingVertexANGLE as alias
fec9c918e Roll SwiftShader from d15c42482560 to 620982155d55 (2 revisions)
aed5951e3 Reland "Vulkan: Fix texture-after-framebuffer sync issues"
797e627e6 Autogenerate list of features as enum
eeb396535 Autogenerate features
9237272f9 Metal:remove TextureMtl::mIsPow2
e08476cf5 Metal: Avoid leaking MTLDevice lists in DisplayMtl
1b2adb402 Metal: Avoid leaking MTLFunctionConstantValues in ProgramMtl
a201bbc98 egl_angle_ext.xml: add missing enums and typedefs
5c85fd4e1 Add error check on resuming XFB with deleted buffer.
a947c5f56 Skip BlitFramebufferTest.ScissoredMultisampleStencil
fb91e27cf add GL_ANGLE_robust_resource_initialization extension to xml
6803a2d01 D3D11: implement SSBOs in pixel and vertex shaders.
c458b5add Fix CheckedNumeric using the wrong type.
04782d86b Validate vertex attrib index against caps.maxVertexAttributes
767b65939 Roll VK-GL-CTS from 6f8a7182bd26 to 20a474e64382 (14 revisions)
b120ab6d4 Roll Chromium from a01c0c749d0a to f89964bd5b42 (617 revisions)
1b94c5856 Revert "Vulkan: Switch loader to new driver files env var."
727cd8ef6 Fix pointer sscanf for ChromeOS
92e99653d Fix crashes in gl::VertexArray::detachBuffer() and onDestory()
4b381f419 Vulkan: Fix descriptorSet perf counter values.
09a24f3d5 Roll SwiftShader from d09282e5c609 to d15c42482560 (2 revisions)
5a16a1f99 Roll Chromium from 64472fba3112 to a01c0c749d0a (448 revisions)
3cea7fcc0 Split Context ResourceUseList to RP Commandbuffers
ac1301069 Metal: Remove Unused IOSurface code
1f6123d55 Vulkan: Switch loader to new driver files env var.
a16491d98 Vulkan: Fix invalidation of non-existing aspects
d6ff967e3 Roll SwiftShader from d3cc7d7ac0c3 to d09282e5c609 (6 revisions)
b7e8ab48d Roll Chromium from 6f6eb80eab19 to 64472fba3112 (509 revisions)
ba04fcfd1 Support ANGLE_PREFERRED_DEVICE on CGL
23558369a Update perf tests arguments.
f36dde314 D3D: remove NV GetDimensions() workaround for image load/store.
7a9856f67 Report durations of all flaky retries in JSON test output
9d486a85e GL: Unbind textures from FBO after calls to frameBufferTexture2D
a1c9ba709 Update validation of glFramebufferTextureLayer for cube maps
152616eed Tests: Add Aztec Ruins High trace
06c201f84 Roll SwiftShader from 1b159f6cdecb to d3cc7d7ac0c3 (1 revision)
b4eaa3a29 Roll Chromium from 3c01a5c3bc2f to 6f6eb80eab19 (52 revisions)
ff9bd35d9 Roll Chromium from c32f123be7eb to 3c01a5c3bc2f (107 revisions)
bac8915c5 Roll Chromium from f39b4372b8a8 to c32f123be7eb (777 revisions)
366f60116 Roll vulkan-deps from 6d732e01d9ea to 345e2a278e69 (3 revisions)
607d398e0 Vulkan: Optimize resolve of multisample swapchains
0ffff9eda Vulkan: Perf counters test for glInvalidateSubFramebuffer
ca3b7d35f Vulkan: Roll volk
3258477a0 Skip car_chase on all Intel Windows platforms
78f5ef92a Roll SwiftShader from 7d100c556081 to 1b159f6cdecb (2 revisions)
7b0f63182 Vulkan: Wayland include directories
8b84cf15e Tests: Add GFXBench Car Chase trace
256bbb8ac Vulkan: Don't invalidate resolve attachment except with MSRTT
b3fff1aaf retrace_restricted_traces: Check for json file.
a11bf0edc Fix Max Atomic Counter Conformance Test Failure on Pixel6
a555be4aa Tests: Add Scary Teacher 3D trace
e933df513 retrace_restricted_traces: Remove unused code.
808f754c4 Capture/Replay: Use glFramebufferTexture2D for cubes
1a3411c7d Set SKIPPED status on skipped tests, rely on it in Gold tests.
34471fed1 Vulkan: Skip failing intel blend test.
4f7efb51b Remove swiftshader_spirv_tools_dir
2cb264b5a Roll SwiftShader from a190ceed7293 to 7d100c556081 (9 revisions)
83d3a98cd Remove commented out mSkipTest.
74eac5e5a Roll VK-GL-CTS from fbc38865227d to 6f8a7182bd26 (14 revisions)
e7d44541e Use GTEST_SKIP to set gTest status of skipped tests to SKIPPED.
b33767ec9 Revert "Vulkan: Fix texture-after-framebuffer sync issues"
bd7915fd0 Use provided format as intended format for EGLImage from VkImage
4655ef15d Roll SwiftShader from 649d6e46aeae to a190ceed7293 (1 revision)
4b2602259 Roll Chromium from 804d5a91d49d to f39b4372b8a8 (124 revisions)
4b232a9a8 Roll Chromium from 384f873e0970 to 804d5a91d49d (4365 revisions)
f41303cda Skip end2end tests timing out on TSAN and ASAN
535cd538f Vulkan: Fix texture-after-framebuffer sync issues
4615a0355 Skip failing tests on Pixel 6
6b94a71ce Vulkan: Lift SwS suppressions.
ba0eba20b Remove the TODOs regarding multisample buffer age
cd9e887ae Vulkan: Add multisample buffer age tests
8f9043636 Vulkan: Move memory allocation initialization code into function
b169f6f94 Vulkan: Fix no location decoration vs framebuffer fetch
5cffbe965 Android: Track peak GPU memory in restricted_trace_perf
cc19587e2 infra: Use logarithmic batching in LUCI config.
e10803f76 Compiler: Allow deferred array sizing in geometry shaders
dd86dd15b Cache outer array offset in linked uniforms.
0754b1f72 Roll SwiftShader from bc5bec05c369 to 649d6e46aeae (3 revisions)
57a081c76 Roll vulkan-deps from e37ba68c0fde to 6d732e01d9ea (4 revisions)
d3492eef5 Vulkan: Handle border color for stencil component
- 9:32 AM Changeset in webkit [293512] by
-
- 2 edits in trunk/Tools
test-webkitperl outputs git hints during the test
https://bugs.webkit.org/show_bug.cgi?id=239759
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-27
Reviewed by Alexey Proskuryakov.
Avoid git hints about initial branch name during a test that initializes a git repository.
The output disrupts the test system result reporting output.
Specify the quiet operation. --initial-branch cannot be specified
since the Perl tests run on older git.
- Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl:
- 9:30 AM Changeset in webkit [293511] by
-
- 17 edits in trunk
[css-ui] Remove some unimplemented -webkit-appearance keywords
https://bugs.webkit.org/show_bug.cgi?id=238930
Reviewed by Aditya Keerthi.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
Source/WebCore:
Remove the following unimplmented --webkit-appearance keyworkds:
button-bevel
media-controls-background
media-controls-fullscreen-background
media-current-time-display
media-enter-fullscreen-button
media-exit-fullscreen-button
media-mute-button
media-overlay-play-button
media-return-to-realtime-button
media-rewind-button
media-seek-back-button
media-seek-forward-button
media-time-remaining-display
media-toggle-closed-captions-button
media-volume-slider-container
menulist-textfield
menulist-text
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSProperties.json:
- css/CSSValueKeywords.in:
- platform/ThemeTypes.cpp:
(WebCore::operator<<):
- platform/ThemeTypes.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaPlayButton):
(WebCore::RenderTheme::paintMediaMuteButton):
(WebCore::RenderTheme::paintMediaSliderThumb):
(WebCore::RenderTheme::paintMediaVolumeSliderThumb):
(WebCore::RenderTheme::paintMediaFullscreenButton): Deleted.
(WebCore::RenderTheme::paintMediaOverlayPlayButton): Deleted.
(WebCore::RenderTheme::paintMediaSeekBackButton): Deleted.
(WebCore::RenderTheme::paintMediaSeekForwardButton): Deleted.
(WebCore::RenderTheme::paintMediaVolumeSliderContainer): Deleted.
(WebCore::RenderTheme::paintMediaRewindButton): Deleted.
(WebCore::RenderTheme::paintMediaReturnToRealtimeButton): Deleted.
(WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton): Deleted.
(WebCore::RenderTheme::paintMediaControlsBackground): Deleted.
(WebCore::RenderTheme::paintMediaCurrentTime): Deleted.
(WebCore::RenderTheme::paintMediaTimeRemaining): Deleted.
Source/WebInspectorUI:
We might need to update the changes on UserInterface/External/CodeMirror/css.js since
PR https://github.com/codemirror/CodeMirror/pull/6912 has been merged in CodeMirror.
- UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
- UserInterface/External/CSSDocumentation/CSSDocumentation.js:
LayoutTests:
- imported/blink/editing/execCommand/outdent-collapse-table-crash.html:
- platform/gtk/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
- 8:49 AM Changeset in webkit [293510] by
-
- 19 edits1 add in trunk
[WASM-GC] Introduce rtt types
https://bugs.webkit.org/show_bug.cgi?id=239493
Reviewed by Keith Miller.
JSTests:
Added basic tests for manipulation of rtt types.
- wasm/gc/rtt.js: Added.
(module):
(testRttTypes):
(testRttCanon):
- wasm/wasm.json:
Source/JavaScriptCore:
Add a basic support through runtime call for rtt.canon and rtt types.
It is a prototype implementation of rtt types needed to move forward
with wasm gc proposal (https://github.com/WebAssembly/gc/blob/main/proposals/gc/MVP.md).
For example, we don't need to use rtt values for struct.new,
but we do need them for the future js api.
So, rtt.canon returns jsNull for now, but we can replace it with
properly defined values when the spec will be ready.
- bytecode/BytecodeList.rb:
- llint/WebAssembly.asm:
- wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::tmpForType):
(JSC::Wasm::AirIRGenerator::AirIRGenerator):
(JSC::Wasm::AirIRGenerator::addRttCanon):
- wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::addRttCanon):
- wasm/WasmCallingConvention.h:
(JSC::Wasm::WasmCallingConvention::marshallLocation const):
- wasm/WasmFormat.h:
(JSC::Wasm::isValueType):
(JSC::Wasm::isValidHeapTypeKind):
- wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseExpression):
(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):
- wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::callInformationForCaller):
(JSC::Wasm::LLIntGenerator::callInformationForCallee):
(JSC::Wasm::LLIntGenerator::addArguments):
(JSC::Wasm::LLIntGenerator::addRttCanon):
- wasm/WasmOperations.cpp:
(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):
- wasm/WasmOperations.h:
- wasm/WasmParser.h:
(JSC::Wasm::Parser<SuccessType>::parseValueType):
- wasm/WasmSlowPaths.cpp:
(JSC::LLInt::WASM_SLOW_PATH_DECL):
- wasm/WasmSlowPaths.h:
- wasm/generateWasmOpsHeader.py:
- wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJS):
- wasm/wasm.json:
- 8:49 AM Changeset in webkit [293509] by
-
- 13 edits in trunk/Source/WebKit
[macOS] The function getpwnam can sometimes fail
https://bugs.webkit.org/show_bug.cgi?id=239513
<rdar://89758690>
Reviewed by Darin Adler.
The system function getpwnam is caching the results from the first invocation, and will return the cached
values after the first call. It may happen that opendirectoryd will invalidate the cached values by
posting notifications. If that happens, getpwnam will then fail, since there are no cached values and
the WebContent process' sandbox is blocking access to opendirectoryd. This patch addresses this issue
by observing these notifications in the UI process, and recreating the cached values for getpwnam, by
calling the function in the WebContent process while holding a temporary sandbox extenstion to
opendirectoryd.
- GPUProcess/GPUProcess.h:
- GPUProcess/GPUProcess.messages.in:
- GPUProcess/mac/GPUProcessMac.mm:
(WebKit::GPUProcess::openDirectoryCacheInvalidated):
- GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
- Shared/AuxiliaryProcess.h:
- Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::getHomeDirectory):
(WebKit::populateSandboxInitializationParameters):
(WebKit::AuxiliaryProcess::openDirectoryCacheInvalidated):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):
- UIProcess/WebProcessPool.h:
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::openDirectoryCacheInvalidated):
- WebProcess/com.apple.WebProcess.sb.in:
- 7:11 AM Changeset in webkit [293508] by
-
- 2 edits in trunk
[GTK] Add user agent quirk for "ClicSalud+" (Andalusian Health Service, Spain)
https://bugs.webkit.org/show_bug.cgi?id=239763
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-04-27
Reviewed by Adrian Perez de Castro.
- Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST):
- Source/WebCore/platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresMacintoshPlatform):
Canonical link: https://commits.webkit.org/250039@main
- 6:16 AM Changeset in webkit [293507] by
-
- 6 edits in trunk
[GLib] Make WebKitSettings XSS auditor functions no-op
https://bugs.webkit.org/show_bug.cgi?id=239651
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-04-27
Reviewed by Adrian Perez de Castro.
Let's deprecate these functions.
Also, do not print warnings because they are called during init by the property setters.
- Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:
(webkit_settings_get_enable_xss_auditor):
(webkit_settings_set_enable_xss_auditor):
- Source/WebKit/UIProcess/API/gtk/WebKitSettings.h:
- Source/WebKit/UIProcess/API/wpe/WebKitSettings.h:
Canonical link: https://commits.webkit.org/250038@main
- 6:12 AM Changeset in webkit [293506] by
-
- 20 edits in trunk
service worker update should refresh imported scripts in addition to the main script
https://bugs.webkit.org/show_bug.cgi?id=239657
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/credentials.https-expected.txt:
Source/WebCore:
After checking main script, if matching, we refreach each identified imported script.
If matching, we reuse the same worker, otherwise we install a new one.
We reuse the soft update loader to fetch scripts in case of soft update.
Otherwise, we load scripts through the job's client.
Covered by rebased test.
- workers/service/SWClientConnection.cpp:
- workers/service/SWClientConnection.h:
- workers/service/ServiceWorkerContainer.cpp:
- workers/service/ServiceWorkerContainer.h:
- workers/service/ServiceWorkerJob.cpp:
- workers/service/ServiceWorkerJob.h:
- workers/service/ServiceWorkerJobClient.h:
- workers/service/server/SWServer.cpp:
- workers/service/server/SWServer.h:
- workers/service/server/SWServerJobQueue.cpp:
- workers/service/server/SWServerJobQueue.h:
- workers/service/server/SWServerWorker.cpp:
- workers/service/server/SWServerWorker.h:
Source/WebKit:
- NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.h:
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
- NetworkProcess/ServiceWorker/WebSWServerConnection.h:
- WebProcess/Storage/WebSWClientConnection.messages.in:
- 4:59 AM Changeset in webkit [293505] by
-
- 2 edits in trunk/Source/WTF
[GCC] GCC9.3 defines 'remove_cvref_t' but not 'cpp_lib_remove_cvref'
https://bugs.webkit.org/show_bug.cgi?id=239805
Reviewed by Žan Doberšek.
GCC9.3 defines 'remove_cvref_t' but not 'cpp_lib_remove_cvref'. The
latter was introduced in GCC9.4:
The flag 'cpp_lib_remove_cvref' is used to check whether 'remove_cvref_t'
is defined, but it's not posible to rely on it for GCC9.3 as explained on the
paragraph above.
Instead we check whether cplusplus is <= 201703L since the GCC commit
that defined 'remove_cvref_t' does it if cplusplus > 201703L. See:
https://github.com/gcc-mirror/gcc/commit/6791489ee5214b0181aa22adc250cbbde1897a5c
- wtf/StdLibExtras.h:
- 4:14 AM Changeset in webkit [293504] by
-
- 22 edits in trunk/Source/WebCore
[LBSE] Fix origin of transformations in SVG
https://bugs.webkit.org/show_bug.cgi?id=239717
Patch by Nikolas Zimmermann <nzimmermann@igalia.com> on 2022-04-27
Reviewed by Rob Buis.
Fix the majority of SVG transform issues in LBSE. webkit.org/b/237711 laid the groundwork for SVG
transforms in LBSE, however there are still issues:
- SVG transforms specified alone on SVG elements, w/o any additional style/perspective related property such as transform-box / transform-origin / ... do not trigger layer creation, fix by adapting StyleAdjuster.
- Switching on/off transforms for a SVG element, was not tracking updates to both 'HasSVGTransform' and 'HasTransformRelatedProperty' flags correctly, fix that by introducing an 'updateHasSVGTransformFlags' helper.
- Modify SVGContainerLayout to avoid a dependency on the children transformations when computing container boundaries. In the legacy engine, we always have to mark the whole ancestor chain as 'need to recompute boundaries' and invoking a re-layout, to perform the recomputation. This change avoids the invalidation of the whole ancestor chain, when an elements transform changes in a non-accelerated way (e.g. SVGTransformList manipulation, SMIL <animateTransform> / <animate> / <set>). In CSS transformations do not affect layout, only hit-testing and painting.
-> SVG/CSS transforms applied on SVG elements is conceptually equivalent to CSS transformations on CSS boxes now.
Transformation changes no longer affect the 'internal geometry' (objectBoundingBoxWithoutTransformations()).
currentSVGLayoutLocation() / nominalSVGLayoutLocation() are computed using the 'internal geometry' and used
throughout layout.
This avoids most of the RenderLayer / RenderLayerBacking specific changes that were present in the downstream
LBSE implementation, while also solving an important design issue: no back-splash from children to parents.
Large, deep nested documents -- as seen in the wild -- will benefit the most, avoiding the frequent ancestor
walks to mark the containing block / parent hierachy for re-layout.
Covered by existing tests, no change in behaviour. (However testability for LBSE is ready soon!).
- rendering/RenderElement.cpp:
(WebCore::RenderElement::referenceBoxRect const):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::canCreateStackingContext):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::rendererLocation const):
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
(WebCore::RenderLayerModelObject::computeVisibleRectInSVGContainer const):
(WebCore::RenderLayerModelObject::updateHasSVGTransformFlags):
- rendering/RenderLayerModelObject.h:
(WebCore::RenderLayerModelObject::nominalSVGLayoutLocation const):
(WebCore::RenderLayerModelObject::currentSVGLayoutLocation const):
(WebCore::RenderLayerModelObject::setCurrentSVGLayoutLocation):
- rendering/RenderObject.h:
(WebCore::RenderObject::objectBoundingBoxWithoutTransformations const):
- rendering/svg/RenderSVGBlock.h:
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layoutChildren):
(WebCore::RenderSVGContainer::paint):
(WebCore::RenderSVGContainer::nodeAtPoint):
(WebCore::RenderSVGContainer::styleDidChange): Deleted.
- rendering/svg/RenderSVGContainer.h:
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::updateFromStyle):
(WebCore::RenderSVGModelObject::absoluteRects const):
- rendering/svg/RenderSVGModelObject.h:
(WebCore::RenderSVGModelObject::currentSVGLayoutRect const):
(WebCore::RenderSVGModelObject::setCurrentSVGLayoutRect):
(WebCore::RenderSVGModelObject::frameRectEquivalent const):
(WebCore::RenderSVGModelObject::applyTopLeftLocationOffsetEquivalent const):
(WebCore::RenderSVGModelObject::layoutRect const): Deleted.
(WebCore::RenderSVGModelObject::setLayoutRect): Deleted.
(WebCore::RenderSVGModelObject::setLayoutLocation): Deleted.
(WebCore::RenderSVGModelObject::paintingLocation const): Deleted.
(WebCore::RenderSVGModelObject::layoutLocation const): Deleted.
(WebCore::RenderSVGModelObject::layoutLocationOffset const): Deleted.
(WebCore::RenderSVGModelObject::layoutSize const): Deleted.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::updateFromStyle):
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::paint):
(WebCore::RenderSVGShape::nodeAtPoint):
- rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::updateFromStyle):
- rendering/svg/SVGBoundingBoxComputation.cpp:
(WebCore::SVGBoundingBoxComputation::handleRootOrContainer const):
- rendering/svg/SVGBoundingBoxComputation.h:
(WebCore::SVGBoundingBoxComputation::computeVisualOverflowRect):
- rendering/svg/SVGContainerLayout.cpp:
(WebCore::SVGContainerLayout::positionChildrenRelativeToContainer):
(WebCore::SVGContainerLayout::verifyLayoutLocationConsistency):
(WebCore::layoutLocationFromRenderer): Deleted.
(WebCore::setLayoutLocationForRenderer): Deleted.
- rendering/svg/SVGContainerLayout.h:
- style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjust const):
- 3:36 AM Changeset in webkit [293503] by
-
- 2 edits in trunk/Source/WebCore
<link rel=preconnect> always sends credentials to different-origin, ignoring crossorigin=anonymous
https://bugs.webkit.org/show_bug.cgi?id=239119
<rdar://problem/91643534>
Reviewed by John Wilander.
Update the check as per spec, step 5 of
https://html.spec.whatwg.org/multipage/links.html#link-type-preconnect
This is difficult to test as preconnect can only expose TLS credentials.
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::preconnectIfNeeded):
- 2:10 AM Changeset in webkit [293502] by
-
- 15 edits3 adds in trunk
Add testRunner API to clear memory cache
https://bugs.webkit.org/show_bug.cgi?id=239804
rdar://92033309
Reviewed by Chris Dumez.
Source/WebCore:
- testing/Internals.cpp:
(WebCore::Internals::clearMemoryCache):
Beef up clearMemoryCache to be on par with testRunner counterpart.
Source/WebKit:
Add necessary WebKit API to implement the testRunner API.
Make use of new testRunner API in added test.
Test: http/wpt/fetch/clear-memory-cache.html
- NetworkProcess/NetworkProcess.cpp:
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
- UIProcess/API/C/WKWebsiteDataStoreRef.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
Tools:
Implement the clear memory cache testRunner API and related plumbery.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
LayoutTests:
- http/wpt/fetch/clear-memory-cache-expected.txt: Added.
- http/wpt/fetch/clear-memory-cache.html: Added.
- http/wpt/fetch/resources/clear-memory-cache.py: Added.
- 2:01 AM WebKitGTK/2.36.x edited by
- (diff)
- 1:21 AM Changeset in webkit [293501] by
-
- 42 edits3 adds2 deletes in trunk
Shared workers should match service worker registrations
https://bugs.webkit.org/show_bug.cgi?id=239122
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/clients-get-client-types.https-expected.txt:
- web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt:
- web-platform-tests/service-workers/service-worker/worker-interception-redirect.https-expected.txt:
- web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt:
Source/WebCore:
Update SharedWorkerScriptLoader to set correctly client ID and service worker data.
Ditto for SharedWorkerThread and SharedWorkerThreadProxy.
Add support to get a SharedWorkerThreadProxy from a client ID.
Use this in SWClientConnection to add support for controller change and post messaging.
Given we create the shared worker identifier in one web process but we might spawn the actual worker in another process,
we need to unregister the identifier with the old process identifier and register the identifier with the new process identifier.
This is done at shared worker launch time.
Covered by updated tests.
Test: http/wpt/service-workers/controlled-sharedworker.https.html
- Headers.cmake:
- workers/Worker.cpp:
- workers/Worker.h:
- workers/WorkerGlobalScope.cpp:
- workers/WorkerInitializationData.h:
- workers/WorkerScriptLoader.cpp:
- workers/WorkerScriptLoader.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::gatherClientData):
- workers/service/server/SWServer.h:
- workers/service/SWClientConnection.cpp:
- workers/service/ServiceWorkerContainer.cpp:
- workers/shared/SharedWorkerObjectConnection.cpp:
- workers/shared/SharedWorkerObjectConnection.h:
- workers/shared/SharedWorkerScriptLoader.cpp:
- workers/shared/SharedWorkerScriptLoader.h:
- workers/shared/context/SharedWorkerThread.cpp:
- workers/shared/context/SharedWorkerThreadProxy.cpp:
- workers/shared/context/SharedWorkerThreadProxy.h:
Source/WebKit:
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
- NetworkProcess/ServiceWorker/WebSWServerConnection.h:
- NetworkProcess/SharedWorker/WebSharedWorker.h:
- NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:
- NetworkProcess/SharedWorker/WebSharedWorkerServer.h:
- NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp:
- NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h:
- NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp:
- WebProcess/Storage/WebSWClientConnection.cpp:
- WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp:
- WebProcess/Storage/WebSharedWorkerContextManagerConnection.h:
- WebProcess/Storage/WebSharedWorkerContextManagerConnection.messages.in:
- WebProcess/Storage/WebSharedWorkerObjectConnection.messages.in:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::establishRemoteWorkerContextConnectionToNetworkProcess):
LayoutTests:
- http/wpt/service-workers/controlled-sharedworker.https-expected.txt: Added.
- http/wpt/service-workers/controlled-sharedworker.https.html: Added.
- http/wpt/service-workers/resources/controlled-sharedworker.js: Added.
- http/wpt/service-workers/skipFetchEvent-worker.js:
- platform/glib/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt: Removed.
- platform/ios-wk2/imported/w3c/web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt: Removed.
Apr 26, 2022:
- 10:59 PM Changeset in webkit [293500] by
-
- 1 copy in tags/WebKit-7614.1.10.7
Tag WebKit-7614.1.10.7.
- 10:55 PM Changeset in webkit [293499] by
-
- 9 edits in branches/safari-614.1.10-branch/Source
Versioning.
WebKit-7614.1.10.7
- 10:40 PM Changeset in webkit [293498] by
-
- 2 edits in trunk/Tools
Remove adjustPathForRecentRenamings from VCSUtils.pm, they are not recent anymore
https://bugs.webkit.org/show_bug.cgi?id=239646
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-26
Reviewed by Darin Adler.
These were used to adjust patches 10 years ago.
The functionality renames *_test_expectations.txt in ANGLE imports, which causes surprises
and hard to track redundant sections while inspecting downstream differences to upstream.
- Scripts/VCSUtils.pm:
(parseGitDiffHeader):
- 10:30 PM Changeset in webkit [293497] by
-
- 8 edits2 adds in trunk
::first-letter does not work if used only in shadow content
https://bugs.webkit.org/show_bug.cgi?id=220650
<rdar://problem/73477161>
Reviewed by Alan Bujtas.
Source/WebCore:
Test: fast/shadow-dom/shadow-first-line-and-letter.html
We were not setting usesFirstLetter/LinesRules bits if those pseudo-elements were used
only in shadow trees.
Fix by removing the bits. They don't seem to allow any valuable optimizations.
- rendering/LegacyRootInlineBox.cpp:
(WebCore::LegacyRootInlineBox::verticalPositionForBox):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight const):
(WebCore::RenderBlock::getFirstLetter):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::mayAffectLayout const):
(WebCore::RenderInline::lineHeight const):
- rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::lineHeight const):
- rendering/RenderView.h:
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
(WebCore::Style::TreeResolver::resolve):
LayoutTests:
Test case by vb@bigdot.de.
- fast/shadow-dom/shadow-first-line-and-letter-expected.html: Added.
- fast/shadow-dom/shadow-first-line-and-letter.html: Added.
- 9:49 PM Changeset in webkit [293496] by
-
- 2 edits in trunk/Source/WebKit
Don't flush the IOSurface CGContext when just setting ownership identity
https://bugs.webkit.org/show_bug.cgi?id=239800
Reviewed by Myles C. Maxfield.
ImageBufferIOSurfaceBackend::surface() has a call to flushContext(), which we don't need
to do if we're just getting the surface to call setOwnershipIdentity(), so use m_surface
directly.
This is a ~18% perf gain on the Leaves MotionMark subtest on iPhone.
- WebProcess/GPU/graphics/cocoa/ImageBufferShareableMappedIOSurfaceBackend.cpp:
(WebKit::ImageBufferShareableMappedIOSurfaceBackend::setOwnershipIdentity):
- 7:48 PM Changeset in webkit [293495] by
-
- 5 edits in trunk/Tools
[git-webkit] Cannot create pull request branch using bug URL, fails to fetch comments from Bugzilla, fails to modify bug
https://bugs.webkit.org/show_bug.cgi?id=239741
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-04-26
Reviewed by Jonathan Bedard.
- Tools/Scripts/libraries/webkitbugspy/setup.py:
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py:
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
(Tracker.credentials.validater):
(Tracker._login_arguments):
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py:
(Bugzilla.init):
(Bugzilla.request):
Canonical link: https://commits.webkit.org/250028@main
- 7:31 PM Changeset in webkit [293494] by
-
- 3 edits in trunk/Source/ThirdParty/ANGLE
Max Limits have been reduced
https://bugs.webkit.org/show_bug.cgi?id=238914
Allow larger constant uniform buffer data. Provide a
buffer to Metal if uniform data exceeds 4kb
Tested by running deqp gles3 limits tests for uniform data
Reviewed by Dean Jackson.
- src/libANGLE/renderer/metal/ProgramMtl.mm:
(rx::ProgramMtl::commitUniforms):
- src/libANGLE/renderer/metal/mtl_common.h:
- 7:01 PM Changeset in webkit [293493] by
-
- 6 edits in trunk/Source/WebCore
[css-logical] Side border shorthands should not be logical/physical
https://bugs.webkit.org/show_bug.cgi?id=239734
Reviewed by Tim Nguyen.
No test since now there should be no observable change in behavior.
However, this refactoring will be needed for bug 236199.
- animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
Mark logical side border shorthands as animatable.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
Add code for serializing logical side border shorthands.
- css/CSSProperties.json:
Stop side border shorthands from being in a logical property group.
They will just expand into logical or physical longhands, but the
shorthands themselves will be normal.
- css/makeprop.pl:
(addProperty):
Assert that no shorthand belongs to a logical property group.
- css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseValueWithVariableReferences):
Remove dead code.
- 7:00 PM Changeset in webkit [293492] by
-
- 2 edits in trunk/Source/JavaScriptCore
[WASM] Fix warning: cast from ‘char*’ to ‘JSC::Wasm::Type*’ increases required alignment of target type [-Wcast-align]
https://bugs.webkit.org/show_bug.cgi?id=239698
Reviewed by Darin Adler.
There is a warning inside TypeDefinition on some platforms so this
patch fixes it.
- wasm/WasmTypeDefinition.h:
(JSC::Wasm::FunctionSignature::FunctionSignature):
(JSC::Wasm::FunctionSignature::storage):
(JSC::Wasm::FunctionSignature::storage const):
(JSC::Wasm::StructType::StructType):
(JSC::Wasm::StructType::storage):
(JSC::Wasm::StructType::storage const):
(JSC::Wasm::TypeDefinition::payload):
- 6:15 PM Changeset in webkit [293491] by
-
- 3 edits in trunk/Source
Avoid iterating the input string several times setInnerText() / setOuterText()
https://bugs.webkit.org/show_bug.cgi?id=239783
Reviewed by Geoff Garen.
Avoid iterating the input string several times setInnerText() / setOuterText(), to look for new lines
and carriage return characters. Instead of callingcontains('\n')and thencontains('\r'), thus iterating
over the string twice, we now callcontains([](UChar c) { return c == '\n' || c == '\r'; }), achieving
the same thing by traversing the input string only once.
- Source/WTF/wtf/text/WTFString.h:
- Source/WebCore/editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::performTrivialReplace):
- Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::setInnerText):
(WebCore::HTMLElement::setOuterText):
Canonical link: https://commits.webkit.org/250023@main
- 6:14 PM Changeset in webkit [293490] by
-
- 2 edits7 deletes in trunk/LayoutTests
Cleanup expectations for 7 imported/w3c/web-platform-tests/html/semantics/interactive-elements/ tests
https://bugs.webkit.org/show_bug.cgi?id=239790
Unreviewed test gardening.
- LayoutTests/platform/ios-wk2/TestExpectations:
- LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/backdrop-receives-element-events-expected.txt: Removed.
- LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/closed-dialog-does-not-block-mouse-events-expected.txt: Removed.
- LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-inlines-expected.txt: Removed.
- LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-ancestor-is-inert-expected.txt: Removed.
- LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-blocks-mouse-events-expected.txt: Removed.
- LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/non-modal-dialog-does-not-block-mouse-events-expected.txt: Removed.
- LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/simulated-click-inert-expected.txt: Removed.
Canonical link: https://commits.webkit.org/250023@main
- 5:47 PM Changeset in webkit [293489] by
-
- 1 copy in tags/WebKit-7614.1.10.6
Tag WebKit-7614.1.10.6.
- 5:29 PM Changeset in webkit [293488] by
-
- 14 edits in trunk/Source/WebCore
MediaSession.setPositionState() does not work.
https://bugs.webkit.org/show_bug.cgi?id=237196
Reviewed by Eric Carlson.
Use MediaSession's positionState if present when constructing NowPlaying
MediaRemote data.
We emulate what the media-session position would have been had the
time progressed according to the playback rate.
As such, we need to tell the media-session when no action handlers are
set that the media was paused or played again.
When seeking, we update the new time position and continue according to
the set playback rate.
Tested manually with the following scenarios:
- Set a page only defining the media-session's position state once
- Let the media element play by default, check the Now Playing position
- Pause/Play using Now Playing control and checks that the time doesn't jump around.
- Seek using Now Playing and check that the media seeks properly and that the Now Playing positon progress from the seek point according to the media-session's playback rate.
- Seek using default media control and check the same as above.
- Seek using default media control, then pause in Now Playing: check that the playback position doesn't jump around.
We don't have a way to properly test the MediaRemote
external framework and with existing MediaSession API tests currently
disabled following bug 221514.
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::setPlaybackState):
(WebCore::MediaSession::updateReportedPosition):
(WebCore::MediaSession::willBeginPlayback):
(WebCore::MediaSession::willPausePlayback):
(WebCore::MediaSession::positionOverridden):
- Modules/mediasession/MediaSession.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
(WebCore::HTMLMediaElement::removedFromAncestor):
(WebCore::HTMLMediaElement::mediaLoadingFailed):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::finishSeek):
(WebCore::HTMLMediaElement::clearMediaPlayer):
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::clientWillBeginPlayback):
(WebCore::MediaElementSession::clientWillPausePlayback):
(WebCore::MediaElementSession::nowPlayingInfo const):
(WebCore::MediaElementSession::metadataChanged):
(WebCore::MediaElementSession::positionStateChanged):
(WebCore::MediaElementSession::clientCharacteristicsChanged):
- html/MediaElementSession.h:
- platform/audio/NowPlayingInfo.h:
(WebCore::NowPlayingInfo::operator== const):
(WebCore::NowPlayingInfo::encode const):
(WebCore::NowPlayingInfo::decode):
- platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::clientCharacteristicsChanged):
- platform/audio/PlatformMediaSession.h:
- platform/audio/PlatformMediaSessionManager.h:
(WebCore::PlatformMediaSessionManager::clientCharacteristicsChanged):
- platform/audio/cocoa/MediaSessionManagerCocoa.h:
- platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::clientCharacteristicsChanged):
(WebCore::MediaSessionManagerCocoa::setNowPlayingInfo):
- 5:27 PM Changeset in webkit [293487] by
-
- 2 edits in trunk/LayoutTests
[ macOS ] webanimations/accelerated-animation-after-forward-filling-animation.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=239794
Unreviewed test gardening.
- LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/250021@main
- 5:23 PM Changeset in webkit [293486] by
-
- 9 edits in trunk/Source
Unreviewed, reverting "[Xcode] Compute PGO profdata paths instead of searching for them at build time"
https://bugs.webkit.org/show_bug.cgi?id=239681
Source/JavaScriptCore:
This reverts commit 433f73bc052d7c978c619e28b2574df8faf6cb72.
- Configurations/JavaScriptCore.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
Source/WebCore:
- Configurations/WebCore.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
- Configurations/BaseTarget.xcconfig:
- WebKit.xcodeproj/project.pbxproj:
- 5:19 PM Changeset in webkit [293485] by
-
- 6 edits4 adds in trunk
[css-cascade] Fix cascade rollback for deferred properties
https://bugs.webkit.org/show_bug.cgi?id=238125
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Add a test. It still has some failures due to bug 239579, bug 239669,
and bug 239670.
- web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: Added.
- web-platform-tests/css/css-cascade/all-prop-revert-layer.html: Added.
Source/WebCore:
When a deferred property was set to 'revert' or 'revert-layer', it used
to roll back to a declaration of the same exact property (or behave as
'unset' if none).
This patch lets deferred properties roll back to their related property,
e.g. '-webkit-box-shadow: revert-layer' can roll back to a 'box-shadow'
declaration in the previous layer.
This is consistent with logical and physical properties, where the
rollback happens after resolving logical properties.
Test: imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer.html
- style/PropertyCascade.cpp:
(WebCore::Style::PropertyCascade::lastDeferredPropertyResolvingRelated const):
- style/PropertyCascade.h:
- style/StyleBuilder.cpp:
(WebCore::Style::Builder::applyProperty):
LayoutTests:
Add custom expectation for mac-wk1 since scroll-behavior is disabled
there, and thus not checked by the test.
- platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt: Added.
- 4:44 PM Changeset in webkit [293484] by
-
- 208 edits in trunk
Update equalLettersIgnoringASCIICase() / startsWithLettersIgnoringASCIICase() to take in an ASCIILiteral
https://bugs.webkit.org/show_bug.cgi?id=239775
Reviewed by Geoff Garen.
Update equalLettersIgnoringASCIICase() / startsWithLettersIgnoringASCIICase() to take in an ASCIILiteral,
as we are encouraging developers to use _s suffix for string literals.
- Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
- Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::xmlRoleValueString):
- Tools/WebKitTestRunner/cocoa/CrashReporterInfo.mm:
(WTR::testPathFromURL):
- Source/JavaScriptCore/runtime/Options.cpp:
(JSC::parse):
- Source/WebCore/PAL/pal/text/TextEncodingRegistry.cpp:
(PAL::defaultTextEncodingNameForSystemLanguage):
- Source/WebDriver/WebDriverService.cpp:
(WebDriver::WebDriverService::matchCapabilities const):
- Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp:
(WebKit::NetworkDataTaskBlob::resume):
- Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::preconnectTo):
- Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponse):
- Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::isMediaMIMEType):
- Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):
- Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:
(WebKit::NetworkDataTaskCurl::willPerformHTTPRedirection):
- Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection):
- Source/WebKit/UIProcess/API/C/WKWebsitePolicies.cpp:
(WKWebsitePoliciesSetCustomHeaderFields):
- Source/WebKit/UIProcess/API/Cocoa/_WKCustomHeaderFields.mm:
(-[_WKCustomHeaderFields setFields:]):
- Source/WebKit/UIProcess/Cocoa/MediaPermissionUtilities.mm:
(WebKit::visibleDomain):
- Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::matchesExtensionOrEquivalent):
- Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::desktopClassBrowsingRecommendedForRequest):
- Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::encodeSharedMemory):
- Source/WTF/wtf/Assertions.cpp:
- Source/WTF/wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
- Source/WTF/wtf/SortedArrayMap.h:
(WTF::operator==):
- Source/WTF/wtf/text/AtomString.h:
(WTF::equalLettersIgnoringASCIICase):
- Source/WTF/wtf/text/StringCommon.h:
(WTF::equalLettersIgnoringASCIICase):
(WTF::equalLettersIgnoringASCIICaseCommon):
(WTF::startsWithLettersIgnoringASCIICaseCommon):
(WTF::equalLettersIgnoringASCIICaseCommonWithoutLength): Deleted.
(WTF::startsWithLettersIgnoringASCIICaseCommonWithoutLength): Deleted.
- Source/WTF/wtf/text/StringImpl.h:
(WTF::startsWithLettersIgnoringASCIICase):
(WTF::equalLettersIgnoringASCIICase):
- Source/WTF/wtf/text/StringView.h:
(WTF::equalLettersIgnoringASCIICase):
(WTF::startsWithLettersIgnoringASCIICase):
- Source/WTF/wtf/text/WTFString.h:
(WTF::equalLettersIgnoringASCIICase):
(WTF::startsWithLettersIgnoringASCIICase):
- Source/WebCore/Modules/applepay/PaymentCoordinator.cpp:
(WebCore::PaymentCoordinator::validatedPaymentNetwork const):
- Source/WebCore/Modules/applicationmanifest/ApplicationManifestParser.cpp:
(WebCore::ApplicationManifestParser::parseIcons):
- Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp:
(WebCore::LegacyCDMPrivateClearKey::supportsKeySystem):
(WebCore::LegacyCDMPrivateClearKey::supportsKeySystemAndMimeType):
- Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp:
(WebCore::CDMSessionClearKey::update):
- Source/WebCore/Modules/fetch/FetchBodyConsumer.cpp:
(WebCore::FetchBodyConsumer::packageFormData):
- Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp:
(WebCore::isValidVideoMIMEType):
(WebCore::isValidAudioMIMEType):
- Source/WebCore/Modules/mediarecorder/MediaRecorderProvider.cpp:
(WebCore::MediaRecorderProvider::isSupported):
- Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::YouTubePluginReplacement::supportsMIMEType):
(WebCore::YouTubePluginReplacement::supportsFileExtension):
(WebCore::isYouTubeURL):
(WebCore::processAndCreateYouTubeURL):
(WebCore::YouTubePluginReplacement::youTubeURLFromAbsoluteURL):
- Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinatorInternal::needsAppIdQuirks):
- Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::checkResponseHeaders):
- Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::isModalElement const):
(WebCore::AXObjectCache::handleMenuItemSelected):
(WebCore::isNodeAriaVisible):
- Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::isMultiSelectable const):
- Source/WebCore/accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isEnabled const):
- Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRoleFromNode const):
(WebCore::AccessibilityNodeObject::isEnabled const):
(WebCore::AccessibilityNodeObject::isIndeterminate const):
(WebCore::AccessibilityNodeObject::isPressed const):
(WebCore::AccessibilityNodeObject::isChecked const):
(WebCore::AccessibilityNodeObject::isMultiSelectable const):
(WebCore::AccessibilityNodeObject::isRequired const):
(WebCore::AccessibilityNodeObject::elementAttributeValue const):
(WebCore::shouldUseAccessibilityObjectInnerText):
(WebCore::AccessibilityNodeObject::textUnderElement const):
- Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::autoCompleteValue const):
(WebCore::AccessibilityObject::contentEditableAttributeIsEnabled):
(WebCore::AccessibilityObject::ariaIsMultiline const):
(WebCore::AccessibilityObject::liveRegionStatusIsEnabled):
(WebCore::AccessibilityObject::sortDirection const):
(WebCore::AccessibilityObject::popupValue const):
(WebCore::AccessibilityObject::supportsPressed const):
(WebCore::AccessibilityObject::supportsExpanded const):
(WebCore::AccessibilityObject::isExpanded const):
(WebCore::AccessibilityObject::checkboxOrRadioValue const):
(WebCore::AccessibilityObject::isAXHidden const):
(WebCore::AccessibilityObject::setIsIgnoredFromParentDataForChild):
- Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::hasPopup const):
(WebCore::AccessibilityRenderObject::supportsDragging const):
(WebCore::AccessibilityRenderObject::defaultObjectInclusion const):
(WebCore::AccessibilityRenderObject::isSelected const):
(WebCore::AccessibilityRenderObject::orientation const):
(WebCore::AccessibilityRenderObject::liveRegionAtomic const):
- Source/WebCore/accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::orientation const):
- Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::rolePlatformDescription const):
- Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::processKeyframes):
- Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForLoad):
- Source/WebCore/css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::isSVGFontFaceSrc const):
- Source/WebCore/css/MediaList.cpp:
(WebCore::reportMediaQueryWarningIfNeeded):
- Source/WebCore/css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::mediaTypeMatch const):
(WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific const):
(WebCore::evaluateResolution):
- Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
- Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::isUniversalKeyword):
- Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::consumeStringOrURI):
(WebCore::CSSParserImpl::consumeImportRule):
(WebCore::CSSParserImpl::consumeDeclaration):
(WebCore::CSSParserImpl::consumeKeyframeKeyList):
- Source/WebCore/css/parser/CSSParserSelector.cpp:
(WebCore::CSSParserSelector::parsePagePseudoSelector):
(WebCore::CSSParserSelector::parsePseudoElementSelector):
- Source/WebCore/css/parser/CSSParserTokenRange.cpp:
(WebCore::CSSParserTokenRange::consumeBlockCheckingForEditability):
- Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::consumeAnimationName):
- Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp:
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeUnicodeRangeString):
- Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::consumePseudo):
(WebCore::CSSSelectorParser::consumeAttributeFlags):
(WebCore::consumeANPlusB):
- Source/WebCore/css/parser/CSSSupportsParser.cpp:
(WebCore::CSSSupportsParser::consumeCondition):
- Source/WebCore/css/parser/CSSTokenizer.cpp:
(WebCore::CSSTokenizer::consumeIdentLikeToken):
- Source/WebCore/css/parser/MediaQueryParser.cpp:
(WebCore::MediaQueryParser::readMediaNot):
(WebCore::isRestrictorOrLogicalOperator):
(WebCore::MediaQueryParser::readMediaType):
(WebCore::MediaQueryParser::readAnd):
(WebCore::MediaQueryParser::handleBlocks):
- Source/WebCore/css/parser/SizesCalcParser.cpp:
(WebCore::SizesCalcParser::calcToReversePolishNotation):
- Source/WebCore/css/typedom/transform/CSSPerspective.cpp:
(WebCore::checkLength):
- Source/WebCore/dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
- Source/WebCore/dom/Document.cpp:
(WebCore::Document::determineActiveThemeColorMetaElement):
(WebCore::Document::processColorScheme):
(WebCore::Document::processFormatDetection):
(WebCore::Document::createEvent):
(WebCore::Document::setDesignMode):
(WebCore::Document::parseDNSPrefetchControlHeader):
- Source/WebCore/dom/Element.cpp:
(WebCore::isStyleAttribute):
(WebCore::Element::isSpellCheckingEnabled const):
(WebCore::Element::canContainRangeEndPoint const):
- Source/WebCore/dom/InlineStyleSheetOwner.cpp:
(WebCore::isValidCSSContentType):
- Source/WebCore/dom/ScriptElement.cpp:
(WebCore::ScriptElement::determineScriptType const):
(WebCore::ScriptElement::isScriptForEventSupported const):
- Source/WebCore/dom/SecurityContext.cpp:
(WebCore::SecurityContext::parseSandboxPolicy):
- Source/WebCore/dom/ViewportArguments.cpp:
(WebCore::findSizeValue):
(WebCore::findScaleValue):
(WebCore::findBooleanValue):
(WebCore::parseViewportFitValue):
(WebCore::setViewportFeature):
- Source/WebCore/editing/EditorCommand.cpp:
(WebCore::executeDefaultParagraphSeparator):
(WebCore::executeStyleWithCSS):
(WebCore::executeUseCSS):
- Source/WebCore/editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
- Source/WebCore/editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::requiresExtendedContext):
(WebCore::removeResultLinksFromAnchor):
(WebCore::searchForLinkRemovingExistingDDLinks):
(WebCore::DataDetection::isDataDetectorElement):
- Source/WebCore/history/HistoryItem.cpp:
(WebCore::HistoryItem::setFormInfoFromRequest):
- Source/WebCore/html/Autocapitalize.cpp:
(WebCore::autocapitalizeTypeForAttributeValue):
- Source/WebCore/html/Autofill.cpp:
(WebCore::AutofillData::createFromHTMLFormControlElement):
- Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::draggable const):
(WebCore::HTMLAnchorElement::relList):
- Source/WebCore/html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::parseAttribute):
- Source/WebCore/html/HTMLBRElement.cpp:
(WebCore::HTMLBRElement::collectPresentationalHintsForAttribute):
- Source/WebCore/html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::collectPresentationalHintsForAttribute):
- Source/WebCore/html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::parseAttribute):
- Source/WebCore/html/HTMLDivElement.cpp:
(WebCore::HTMLDivElement::collectPresentationalHintsForAttribute):
- Source/WebCore/html/HTMLElement.cpp:
(WebCore::isLTROrRTLIgnoringCase):
(WebCore::contentEditableType):
(WebCore::HTMLElement::collectPresentationalHintsForAttribute):
(WebCore::toValidDirValue):
(WebCore::HTMLElement::applyAlignmentAttributeToStyle):
(WebCore::HTMLElement::setContentEditable):
(WebCore::HTMLElement::draggable const):
(WebCore::HTMLElement::translate const):
(WebCore::HTMLElement::hasDirectionAuto const):
(WebCore::HTMLElement::directionality const):
(WebCore::HTMLElement::dirAttributeChanged):
(WebCore::parseLegacyColorValue):
(WebCore::HTMLElement::shouldAutocorrect const):
- Source/WebCore/html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::collectPresentationalHintsForAttribute):
- Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::shouldAutocorrect const):
- Source/WebCore/html/HTMLFormElement.cpp:
(WebCore::parseFormRelAttributes):
(WebCore::HTMLFormElement::shouldAutocorrect const):
(WebCore::HTMLFormElement::relList):
(WebCore::HTMLFormElement::shouldAutocomplete const):
(WebCore::HTMLFormElement::autocomplete const):
- Source/WebCore/html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::scrollingMode const):
- Source/WebCore/html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseAttribute):
- Source/WebCore/html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::collectPresentationalHintsForAttribute):
- Source/WebCore/html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseAttribute):
(WebCore::HTMLIFrameElement::loadingForBindings const):
(WebCore::isFrameLazyLoadable):
- Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::hasLazyLoadableAttributeValue):
(WebCore::parseCrossoriginState):
(WebCore::HTMLImageElement::decodingMode const):
- Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::mediaCaptureType const):
- Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::as const):
(WebCore::HTMLLinkElement::process):
- Source/WebCore/html/HTMLMarqueeElement.cpp:
(WebCore::HTMLMarqueeElement::collectPresentationalHintsForAttribute):
- Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- Source/WebCore/html/HTMLMenuElement.cpp:
(WebCore::HTMLMenuElement::parseAttribute):
- Source/WebCore/html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::attributeChanged):
(WebCore::HTMLMetaElement::removedFromAncestor):
(WebCore::HTMLMetaElement::process):
- Source/WebCore/html/HTMLObjectElement.cpp:
(WebCore::mapDataParamToSrc):
(WebCore::HTMLObjectElement::parametersForPlugin):
(WebCore::HTMLObjectElement::containsJavaApplet const):
- Source/WebCore/html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::collectPresentationalHintsForAttribute):
- Source/WebCore/html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::isURLParameter):
- Source/WebCore/html/HTMLTableElement.cpp:
(WebCore::getBordersFromFrameAttributeValue):
(WebCore::HTMLTableElement::collectPresentationalHintsForAttribute):
(WebCore::HTMLTableElement::parseAttribute):
- Source/WebCore/html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::collectPresentationalHintsForAttribute):
- Source/WebCore/html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::parseAttribute):
- Source/WebCore/html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setRangeText):
(WebCore::HTMLTextFormControlElement::directionForFormData const):
- Source/WebCore/html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::parseAttribute):
- Source/WebCore/html/InputType.cpp:
(WebCore::InputType::applyStep):
- Source/WebCore/html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::LinkRelAttribute):
(WebCore::LinkRelAttribute::isSupported):
- Source/WebCore/html/MediaElementSession.cpp:
(WebCore::MediaElementSession::wirelessVideoPlaybackDisabled const):
- Source/WebCore/html/NumberInputType.cpp:
(WebCore::NumberInputType::sizeShouldIncludeDecoration const):
- Source/WebCore/html/RangeInputType.cpp:
(WebCore::RangeInputType::createStepRange const):
(WebCore::RangeInputType::handleKeydownEvent):
- Source/WebCore/html/StepRange.cpp:
(WebCore::StepRange::parseStep):
- Source/WebCore/html/canvas/CanvasStyle.cpp:
(WebCore::isCurrentColorString):
- Source/WebCore/html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::emitRule):
- Source/WebCore/html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype):
- Source/WebCore/html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::isHTMLIntegrationPoint):
- Source/WebCore/html/parser/HTMLMetaCharsetParser.cpp:
(WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):
- Source/WebCore/html/parser/HTMLParserIdioms.cpp:
(WebCore::parseCORSSettingsAttribute):
- Source/WebCore/html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
- Source/WebCore/html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
- Source/WebCore/html/parser/ParsingUtilities.h:
(WebCore::skipExactlyIgnoringASCIICase):
- Source/WebCore/html/track/TextTrack.cpp:
(WebCore::TextTrack::setKindKeywordIgnoringASCIICase):
- Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::shouldTreatAsText):
- Source/WebCore/loader/CrossOriginAccessControl.cpp:
(WebCore::createPotentialAccessControlRequest):
- Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::loadApplicationManifest):
- Source/WebCore/loader/FetchIdioms.cpp:
(WebCore::shouldBlockResponseDueToMIMEType):
- Source/WebCore/loader/FormSubmission.cpp:
(WebCore::appendMailtoPostFormDataToURL):
(WebCore::FormSubmission::Attributes::parseEncodingType):
(WebCore::FormSubmission::Attributes::parseMethodType):
- Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldPerformFragmentNavigation):
- Source/WebCore/loader/LinkHeader.cpp:
(WebCore::paramterNameFromString):
- Source/WebCore/loader/LinkLoader.cpp:
(WebCore::LinkLoader::resourceTypeFromAsAttribute):
(WebCore::LinkLoader::preconnectIfNeeded):
- Source/WebCore/loader/ResourceCryptographicDigest.cpp:
(WebCore::parseHashAlgorithmAdvancingPosition):
- Source/WebCore/loader/ServerTiming.cpp:
(WebCore::ServerTiming::setParameter):
- Source/WebCore/loader/TextResourceDecoder.cpp:
(WebCore::TextResourceDecoder::determineContentType):
(WebCore::TextResourceDecoder::setEncoding):
- Source/WebCore/loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
- Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp:
(WebCore::parseApplicationCacheManifest):
- Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::shouldStoreResourceAsFlatFile):
- Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::mimeTypeAllowedByNosniff const):
(WebCore::CachedCSSStyleSheet::canUseSheet const):
- Source/WebCore/loader/cache/CachedResource.cpp:
(WebCore::shouldCacheSchemeIndefinitely):
- Source/WebCore/mathml/MathMLElement.cpp:
(WebCore::MathMLElement::collectPresentationalHintsForAttribute):
- Source/WebCore/mathml/MathMLFractionElement.cpp:
(WebCore::MathMLFractionElement::lineThickness):
(WebCore::MathMLFractionElement::cachedFractionAlignment):
- Source/WebCore/page/DOMSelection.cpp:
(WebCore::DOMSelection::modify):
- Source/WebCore/page/EventSource.cpp:
(WebCore::EventSource::responseIsValid const):
- Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::scrollToFragmentInternal):
- Source/WebCore/page/Page.cpp:
(WebCore::Page::useDarkAppearance const):
- Source/WebCore/page/PageConsoleClient.cpp:
(WebCore::PageConsoleClient::screenshot):
- Source/WebCore/page/Quirks.cpp:
(WebCore::isYahooMail):
(WebCore::Quirks::needsFormControlToBeMouseFocusable const):
(WebCore::Quirks::needsSeekingSupportDisabled const):
(WebCore::Quirks::needsPerDocumentAutoplayBehavior const):
(WebCore::Quirks::shouldAutoplayWebAudioForArbitraryUserGesture const):
(WebCore::Quirks::shouldTooltipPreventFromProceedingWithClick const):
(WebCore::Quirks::needsMillisecondResolutionForHighResTimeStamp const):
(WebCore::Quirks::shouldStripQuotationMarkInFontFaceSetFamily const):
(WebCore::Quirks::isTouchBarUpdateSupressedForHiddenContentEditable const):
(WebCore::Quirks::isNeverRichlyEditableForTouchBar const):
(WebCore::shouldSuppressAutocorrectionAndAutocaptializationInHiddenEditableAreasForHost):
(WebCore::Quirks::shouldDispatchSyntheticMouseEventsWhenModifyingSelection const):
(WebCore::Quirks::needsYouTubeMouseOutQuirk const):
(WebCore::Quirks::shouldAvoidUsingIOS13ForGmail const):
(WebCore::Quirks::isGoogleMaps const):
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
(WebCore::Quirks::shouldDispatchedSimulatedMouseEventsAssumeDefaultPrevented const):
(WebCore::Quirks::simulatedMouseEventTypeForTarget const):
(WebCore::Quirks::shouldMakeTouchEventNonCancelableForTarget const):
(WebCore::Quirks::shouldPreventPointerMediaQueryFromEvaluatingToCoarse const):
(WebCore::Quirks::shouldPreventDispatchOfTouchEvent const):
(WebCore::Quirks::shouldAvoidResizingWhenInputViewBoundsChange const):
(WebCore::Quirks::shouldDisablePointerEventsQuirk const):
(WebCore::Quirks::needsDeferKeyDownAndKeyPressTimersUntilNextEditingCommand const):
(WebCore::Quirks::needsInputModeNoneImplicitly const):
(WebCore::Quirks::needsGMailOverflowScrollQuirk const):
(WebCore::Quirks::needsYouTubeOverflowScrollQuirk const):
(WebCore::Quirks::needsFullscreenDisplayNoneQuirk const):
(WebCore::Quirks::shouldSilenceWindowResizeEvents const):
(WebCore::Quirks::shouldSilenceMediaQueryListChangeEvents const):
(WebCore::Quirks::shouldAvoidScrollingWhenFocusedContentIsVisible const):
(WebCore::Quirks::shouldUseLegacySelectPopoverDismissalBehaviorInDataActivation const):
(WebCore::Quirks::shouldIgnoreAriaForFastPathContentObservationCheck const):
(WebCore::Quirks::shouldOpenAsAboutBlank const):
(WebCore::Quirks::shouldBypassBackForwardCache const):
(WebCore::Quirks::shouldIgnoreContentObservationForSyntheticClick const):
(WebCore::Quirks::needsVP9FullRangeFlagQuirk const):
(WebCore::Quirks::needsHDRPixelDepthQuirk const):
(WebCore::Quirks::needsBlackFullscreenBackgroundQuirk const):
(WebCore::Quirks::shouldDisableEndFullscreenEventWhenEnteringPictureInPictureFromFullscreenQuirk const):
(WebCore::Quirks::needsToForceUserSelectAndUserDragWhenInstallingImageOverlay const):
- Source/WebCore/page/SecurityOrigin.cpp:
(WebCore::isFeedWithNestedProtocolInHTTPFamily):
(WebCore::SecurityOrigin::isLocalHostOrLoopbackIPAddress):
- Source/WebCore/page/SecurityOriginData.cpp:
(WebCore::SecurityOriginData::databaseIdentifier const):
- Source/WebCore/page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse):
(WebCore::UserContentURLPattern::matches const):
- Source/WebCore/page/WindowFeatures.cpp:
(WebCore::setWindowFeature):
(WebCore::boolFeature):
- Source/WebCore/page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportUnsupportedDirective const):
(WebCore::ContentSecurityPolicy::reportInvalidSourceExpression const):
- Source/WebCore/page/csp/ContentSecurityPolicySourceList.cpp:
(WebCore::isSourceListNone):
(WebCore::schemeIsInHttpFamily):
(WebCore::ContentSecurityPolicySourceList::isValidSourceForExtensionMode):
(WebCore::ContentSecurityPolicySourceList::parseSource):
(WebCore::ContentSecurityPolicySourceList::parseNonceSource):
- Source/WebCore/platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::isSupportedImageVideoOrSVGMIMEType):
(WebCore::MIMETypeRegistry::isSupportedWebAssemblyMIMEType):
(WebCore::MIMETypeRegistry::isSupportedStyleSheetMIMEType):
(WebCore::MIMETypeRegistry::isSupportedFontMIMEType):
(WebCore::MIMETypeRegistry::isTextMediaPlaylistMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJSONMIMEType):
(WebCore::MIMETypeRegistry::isSupportedTextTrackMIMEType):
(WebCore::MIMETypeRegistry::isTextMIMEType):
(WebCore::MIMETypeRegistry::isXMLMIMEType):
(WebCore::MIMETypeRegistry::isXMLEntityMIMEType):
(WebCore::MIMETypeRegistry::isJavaAppletMIMEType):
(WebCore::MIMETypeRegistry::isPostScriptMIMEType):
(WebCore::MIMETypeRegistry::canShowMIMEType):
- Source/WebCore/platform/PreviewConverter.cpp:
(WebCore::PreviewConverter::supportsMIMEType):
- Source/WebCore/platform/ReferrerPolicy.cpp:
(WebCore::parseReferrerPolicyToken):
- Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::parseLicenseFormat):
(WebCore::CDMFactoryClearKey::supportsKeySystem):
(WebCore::CDMPrivateClearKey::supportsInitData const):
(WebCore::CDMInstanceSessionClearKey::requestLicense):
- Source/WebCore/platform/graphics/FontCache.cpp:
(WebCore::FontCache::alternateFamilyName):
- Source/WebCore/platform/graphics/FontDescription.cpp:
(WebCore::computeSpecializedChineseLocale):
- Source/WebCore/platform/graphics/FontGenericFamilies.cpp:
(WebCore::computeUserPrefersSimplified):
- Source/WebCore/platform/graphics/MIMETypeCache.cpp:
(WebCore::MIMETypeCache::shouldOverrideExtendedType):
- Source/WebCore/platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::supportsType):
- Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:
(WebCore::CDMPrivateMediaSourceAVFObjC::supportsKeySystemAndMimeType):
- Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::keySystemIsSupported):
- Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::generateKeyRequest):
- Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
(WebCore::CDMSessionAVStreamSession::generateKeyRequest):
- Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::willUseWebMFormatReaderForType):
(WebCore::keySystemIsSupported):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):
- Source/WebCore/platform/graphics/cg/ImageBufferUtilitiesCG.cpp:
(WebCore::utiFromImageBufferMIMEType):
- Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::similarFont):
(WebCore::isDotPrefixedForbiddenFont):
(WebCore::fontWithFamilySpecialCase):
(WebCore::FontCache::platformAlternateFamilyName):
- Source/WebCore/platform/graphics/cocoa/FontDescriptionCocoa.cpp:
(WebCore::matchSystemFontUse):
- Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::isContentTypeSupported):
- Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
(WebCore::SystemFontDatabaseCoreText::monospaceFamily):
- Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::isCommonlyUsedGenericFamily):
- Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::supportsFormat):
- Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp:
(webKitDMABufVideoSinkIsEnabled):
- Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:
(WebCore::CDMPrivateThunder::supportsInitData const):
- Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat):
- Source/WebCore/platform/graphics/win/FontCacheWin.cpp:
(WebCore::adjustedGDIFontWeight):
(WebCore::FontCache::createFontPlatformData):
(WebCore::FontCache::platformAlternateFamilyName):
- Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::supportsFormat):
- Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::supportsFormat):
- Source/WebCore/platform/mediarecorder/cocoa/VideoSampleBufferCompressor.mm:
(WebCore::VideoSampleBufferCompressor::create):
- Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::createDecodingConfiguration):
(WebCore::LibWebRTCProvider::createEncodingConfiguration):
- Source/WebCore/platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::loadResourceSynchronously):
(WebCore::BlobResourceHandle::doStart):
- Source/WebCore/platform/network/CacheValidation.cpp:
(WebCore::parseCacheControlDirectives):
- Source/WebCore/platform/network/DataURLDecoder.cpp:
(WebCore::DataURLDecoder::shouldRemoveFragmentIdentifier):
(WebCore::DataURLDecoder::DecodeTask::process):
- Source/WebCore/platform/network/FormData.h:
(WebCore::FormData::parseEncodingType):
- Source/WebCore/platform/network/HTTPParsers.cpp:
(WebCore::parseContentTypeOptionsHeader):
(WebCore::parseXFrameOptionsHeader):
(WebCore::parseRange):
(WebCore::isForbiddenHeaderName):
(WebCore::isPriviledgedNoCORSRequestHeaderName):
(WebCore::isForbiddenResponseHeaderName):
(WebCore::isForbiddenMethod):
(WebCore::isCrossOriginSafeRequestHeader):
- Source/WebCore/platform/network/MIMEHeader.cpp:
(WebCore::MIMEHeader::parseContentTransferEncoding):
- Source/WebCore/platform/network/ResourceRequestBase.cpp:
(WebCore::shouldUseGet):
- Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::isAttachment const):
(WebCore::ResourceResponseBase::isAttachmentWithFilename const):
- Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegate::createResourceRequest):
- Source/WebCore/platform/network/curl/CookieUtil.cpp:
(WebCore::CookieUtil::parseCookieAttributes):
- Source/WebCore/platform/network/curl/CurlMultipartHandle.cpp:
(WebCore::CurlMultipartHandle::extractBoundary):
- Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp:
(WebCore::ResourceResponse::isAppendableHeader):
(WebCore::ResourceResponse::appendHTTPHeaderField):
- Source/WebCore/platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::willSendRequest):
- Source/WebCore/platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::useWALJournalMode):
- Source/WebCore/platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::isColumnDeclaredAsBlob):
- Source/WebCore/platform/win/PasteboardWin.cpp:
(WebCore::clipboardTypeFromMIMEType):
- Source/WebCore/plugins/PluginData.cpp:
(WebCore::isBuiltInPDFPlugIn):
- Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::iconForAttachment):
- Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertTouchCallout):
- Source/WebCore/svg/SVGAElement.cpp:
(WebCore::SVGAElement::relList):
- Source/WebCore/svg/SVGTests.cpp:
(WebCore::SVGTests::hasFeatureForLegacyBindings):
- Source/WebCore/svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::compareCodepointsLexicographically):
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter):
- Source/WebCore/testing/Internals.cpp:
(WebCore::markerTypeFrom):
(WebCore::markerTypesFrom):
(WebCore::Internals::mediaElementHasCharacteristic):
(WebCore::Internals::setCaptionDisplayMode):
(WebCore::Internals::beginMediaSessionInterruption):
(WebCore::Internals::endMediaSessionInterruption):
(WebCore::mediaTypeFromString):
(WebCore::Internals::setMediaSessionRestrictions):
(WebCore::Internals::setMediaElementRestrictions):
(WebCore::Internals::postRemoteControlCommand):
(WebCore::Internals::setAudioContextRestrictions):
(WebCore::Internals::setMockMediaPlaybackTargetPickerState):
(WebCore::Internals::setPageMuted):
(WebCore::Internals::addPrefetchLoadEventListener):
- Source/WebCore/testing/LegacyMockCDM.cpp:
(WebCore::LegacyMockCDM::supportsKeySystem):
(WebCore::LegacyMockCDM::supportsKeySystemAndMimeType):
(WebCore::LegacyMockCDM::supportsMIMEType):
- Source/WebCore/testing/MockCDMFactory.cpp:
(WebCore::MockCDMFactory::supportsKeySystem):
(WebCore::MockCDM::sanitizeSessionId const):
(WebCore::MockCDMInstance::setServerCertificate):
- Source/WebCore/workers/service/server/SWServer.cpp:
(WebCore::SWServer::canHandleScheme const):
- Source/WebCore/xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createDecoder const):
- Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::shouldAllowExternalLoad):
Canonical link: https://commits.webkit.org/250018@main
- 4:39 PM Changeset in webkit [293483] by
-
- 5 edits in trunk/Tools
Cannot run test-webkitpy, autoinstaller fails to compile lupa
https://bugs.webkit.org/show_bug.cgi?id=239786
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-04-26
Reviewed by Jonathan Bedard.
- Tools/Scripts/libraries/reporelaypy/reporelaypy/init.py:
- Tools/Scripts/libraries/reporelaypy/setup.py:
- Tools/Scripts/libraries/resultsdbpy/resultsdbpy/init.py:
- Tools/Scripts/libraries/resultsdbpy/setup.py:
Canonical link: https://commits.webkit.org/250017@main
- 4:15 PM Changeset in webkit [293482] by
-
- 4 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r292911. rdar://problem/91519558
Parent Mismatch
https://bugs.webkit.org/show_bug.cgi?id=239390
Reviewed by Simon Fraser.
The oldParent and layer->parent() may be different under certain circumstances.
To account for this, we can just use the layer->parent() and remove the use
of oldParent. This also has the benefit of simplifying the moveLayers() function.
- rendering/RenderElement.cpp: (WebCore::RenderElement::moveLayers):
- rendering/RenderElement.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::insertOnlyThisLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:58 PM Changeset in webkit [293481] by
-
- 2 edits in trunk/Source/WebKit
Adjust what we consider to be private relayed
https://bugs.webkit.org/show_bug.cgi?id=239784
<rdar://92336270>
Patch by Alex Christensen <achristensen@webkit.org> on 2022-04-26
Reviewed by Geoffrey Garen.
If a request is not eligible for private relay, then do not consider it having been private relayed.
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
- 3:57 PM Changeset in webkit [293480] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r291968. rdar://problem/91681393
AccessibilityObject::listMarkerTextForNodeAndPosition should check for presence of list item before anything else
https://bugs.webkit.org/show_bug.cgi?id=238341
Reviewed by Andres Gonzalez.
The first thing AccessibilityObject::listMarkerTextForNodeAndPosition
does is check to see that the given rangeisStartOfLine. We
should instead check if there's an actual list item to work with
before doing this, sinceisStartOfLinecan cause crashes.
Covered by test
accessibility/mac/attributed-string-with-listitem-multiple-lines.html.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:56 PM Changeset in webkit [293479] by
-
- 2 edits in trunk/Tools
[build.webkit.org] Support identifiers on dashboard (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=239473
<rdar://problem/76852365>
Unreviewed test gardening.
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/tests/index-expected.txt:
Canonical link: https://commits.webkit.org/250015@main
- 3:48 PM Changeset in webkit [293478] by
-
- 2 edits in trunk/LayoutTests
[ macOS ] webanimations/accelerated-animation-slot-invalidation.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=239791
Unreviewed test gardening.
- LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/250014@main
- 3:45 PM Changeset in webkit [293477] by
-
- 2 edits in trunk/Tools
[ews-build.webkit.org] Support alternative remotes (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=239617
<rdar://problem/92115230>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/events.py:
(GitHubEventHandlerNoEdits.extractProperties): 'project' is not set by extractProperties.
Canonical link: https://commits.webkit.org/250013@main
- 3:36 PM Changeset in webkit [293476] by
-
- 6 edits in trunk/Tools
[git-webkit] Checkout PRs from alternate remotes
https://bugs.webkit.org/show_bug.cgi?id=239745
<rdar://problem/92300209>
Reviewed by Dewei Zhu.
- Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git): The name of the repository is embedded in the argument.
(Git.checkout): Handle remote-postfixed remote names.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/checkout.py:
(Checkout.parser): Add --remote command.
(Checkout.main): Use the full repo name instead of the owner's username.
- Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
(GitHub.PRGenerator.PullRequest): Pass full repo name as metadata.
Canonical link: https://commits.webkit.org/250012@main
- 3:33 PM Changeset in webkit [293475] by
-
- 6 edits in trunk/Tools
[build.webkit.org] Support identifiers in popover
https://bugs.webkit.org/show_bug.cgi?id=239773
<rdar://problem/92339575>
Rubber-stamped by Aakash Jain.
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Commits.js:
(Commits): Keep track of all fetched commits.
(Commits.prototype._update): Save fetched commits.
(Commits.prototype.lastNIdentifiers): Return a list of the last n identifiers
on a branch.
(Commits.prototype.fetch): Load information for last N commits.
(Commits.prototype.urlFor): Return a url for a commit ref.
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Main.js: Remove
trac auto-updater.
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/QueueView.js:
(QueueView.prototype._appendPendingRevisionCount): After we determine the
number of commits behind, fetch that many commits.
(QueueView.prototype._popoverLinesForCommitRange): Support commits with identifiers.
(QueueView.prototype._presentPopoverForPendingCommits):
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/tests/resources/MockCommits.js:
- Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/tests/resources/tests.js:
Canonical link: https://commits.webkit.org/250011@main
- 3:25 PM Changeset in webkit [293474] by
-
- 2 edits in trunk/Source/WebCore/dom
ElementData::setClassNames() can take an r-value reference
https://bugs.webkit.org/show_bug.cgi?id=239789
Reviewed by Geoffrey Garen.
- Source/WebCore/dom/Element.cpp:
(WebCore::Element::classAttributeChanged):
- Source/WebCore/dom/ElementData.h:
(WebCore::ElementData::setClassNames const):
Canonical link: https://commits.webkit.org/250010@main
- 3:22 PM Changeset in webkit [293473] by
-
- 34 edits in trunk
[JSC] Add forceUnlinkedDFG option
https://bugs.webkit.org/show_bug.cgi?id=239751
Reviewed by Saam Barati.
This patch adds forceUnlinkedDFG option to start running tests with unlinked DFG (while it is not truly unlinked yet).
- Tools/Scripts/run-jsc-stress-tests:
- Source/JavaScriptCore/jit/JITOperations.cpp:
(JSC::JSC_DEFINE_JIT_OPERATION):
- Source/JavaScriptCore/runtime/OptionsList.h:
- JSTests/stress/arith-abs-on-various-types.js:
- JSTests/stress/arith-abs-to-arith-negate-range-optimizaton.js:
- JSTests/stress/arith-acos-on-various-types.js:
- JSTests/stress/arith-acosh-on-various-types.js:
- JSTests/stress/arith-asin-on-various-types.js:
- JSTests/stress/arith-asinh-on-various-types.js:
- JSTests/stress/arith-atan-on-various-types.js:
- JSTests/stress/arith-atanh-on-various-types.js:
- JSTests/stress/arith-cbrt-on-various-types.js:
- JSTests/stress/arith-ceil-on-various-types.js:
- JSTests/stress/arith-clz32-on-various-types.js:
- JSTests/stress/arith-cos-on-various-types.js:
- JSTests/stress/arith-cosh-on-various-types.js:
- JSTests/stress/arith-expm1-on-various-types.js:
- JSTests/stress/arith-floor-on-various-types.js:
- JSTests/stress/arith-fround-on-various-types.js:
- JSTests/stress/arith-log-on-various-types.js:
- JSTests/stress/arith-log10-on-various-types.js:
- JSTests/stress/arith-log2-on-various-types.js:
- JSTests/stress/arith-round-on-various-types.js:
- JSTests/stress/arith-sin-on-various-types.js:
- JSTests/stress/arith-sinh-on-various-types.js:
- JSTests/stress/arith-sqrt-on-various-types.js:
- JSTests/stress/arith-tan-on-various-types.js:
- JSTests/stress/arith-tanh-on-various-types.js:
- JSTests/stress/arith-trunc-on-various-types.js:
- JSTests/stress/fold-multi-get-by-offset-to-get-by-offset-with-watchpoint.js:
Canonical link: https://commits.webkit.org/250009@main
- 3:18 PM Changeset in webkit [293472] by
-
- 18 edits in branches/safari-613-branch
Revert "Apply patch. rdar://problem/88904160"
- 3:18 PM Changeset in webkit [293471] by
-
- 9 edits3 adds in branches/safari-613-branch
Cherry-pick r290630. rdar://problem/89442583
AX: WebKit should ignore empty modals rather than trapping focus inside them
https://bugs.webkit.org/show_bug.cgi?id=237163
Reviewed by Chris Fleizach and Andres Gonzalez.
Source/WebCore:
Given this markup:
<div role="dialog" aria-modal="true">
<div aria-hidden="true">
<button>Close modal (inside modal)</button>
</div>
</div>
There is no accessible content inside this modal, but WebKit traps user focus inside,
making the rest of the page completely inaccessible.
With this patch we ignore modals that don't have accessible content.
We do this by walking the DOM to find any non-AX-ignored objects.
Because determining whether or not an element is ignored is dependent
on modals present on the page, this patch moves the call toignoredFromModalPresence
out ofAccessibilityObject::defaultObjectInclusion, as this function is
downstream ofcomputeAccessibilityIsIgnored, and we need to call
that on objects inside modal candidates. Without this move, we would
recurse infinitely inAXObjectCache::modalElementHasAccessibleContent.
We now check whether an object is ignored due to modal presence in
AccessibilityObject::accessibilityIsIgnored(), so that function should
be used as the final say in determining whether an object is ignored.
Test: accessibility/ignore-modals-without-any-content.html
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::modalElementHasAccessibleContent): (WebCore::AXObjectCache::currentModalNode):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const): (WebCore::AccessibilityObject::accessibilityIsIgnored const):
- accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::computeAccessibilityIsIgnored const):
LayoutTests:
- accessibility/ignore-modals-without-any-content-expected.txt: Added.
- accessibility/ignore-modals-without-any-content.html: Added.
- platform/glib/TestExpectations: Skip new test.
- platform/ios/TestExpectations: Enable new test.
- platform/ios/accessibility/ignore-modals-without-any-content-expected.txt: Added.
- platform/win/TestExpectations: Skip new test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:18 PM Changeset in webkit [293470] by
-
- 1 edit in branches/safari-613-branch/Source/WebCore/ChangeLog
Cherry-pick r290860. rdar://problem/89291570
AX: Protect incoming object with Ref in AXObjectCache::textChanged
https://bugs.webkit.org/show_bug.cgi?id=237475
Reviewed by Chris Fleizach.
This is better practice as ascending the hierarchy could cause
the object to get deleted.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:18 PM Changeset in webkit [293469] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r292430. rdar://problem/92204558
[Cocoa] Video is sometimes not visible after r292049
https://bugs.webkit.org/show_bug.cgi?id=238826
Reviewed by Jer Noble.
RenderVideo::willBeDestroyed calls MediaPlayer::setPageIsVisible, which causes
MediaPlayerPrivateAVFoundationObjC::platformSetVisible to hide the AVPlayerLayer.
HTMLMediaElement::visibilityStateChanged is the only other thing that calls
MediaPlayer::setPageIsVisible, and it only calls it when the page visibility changes,
so if that doesn't happen the AVPlayerLayer is not shown when the renderer is
recreated.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::willBeDestroyed): Don't call MediaPlayer::setPageIsVisible(false), the page visibility has not changed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:18 PM Changeset in webkit [293468] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r293286. rdar://problem/92198272
Crash under AsyncScrollingCoordinator::scrollingThreadAddedPendingUpdate()
https://bugs.webkit.org/show_bug.cgi?id=239683
<rdar://92198272>
Reviewed by Alan Bujtas.
Crash data suggest that m_page can be null in
AsyncScrollingCoordinator::scheduleRenderingUpdate(), which does seem possible because
scheduleRenderingUpdate() is a dispatch from the scrolling thread, and
ScrollingCoordinator::pageDestroyed() may have run before it runs.
- page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::scheduleRenderingUpdate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:18 PM Changeset in webkit [293467] by
-
- 3 edits in branches/safari-613-branch
Cherry-pick r292274. rdar://problem/80544133
[Cocoa] Automatically relayout the page when new fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>
Reviewed by Chris Dumez.
Source/WebCore:
This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.
FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.
Test: fast/text/install-font-style-recalc.html
- page/Page.cpp: (WebCore::m_contentSecurityPolicyModeForExtension): (WebCore::Page::firstTimeInitialization):
- page/Page.h:
- platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
- platform/graphics/FontCache.h:
Tools:
Make TestRunner::dumpResourceLoadStatistics() clear any currently-recorded statistics.
This avoids the problem where spurious layouts during the time when the page has been created but
before the test has begun record irrelevant statistics.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::clearResourceLoadStatistics):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::dumpResourceLoadStatistics):
LayoutTests:
- TestExpectations:
- fast/text/install-font-style-recalc-expected.txt: Added.
- fast/text/install-font-style-recalc.html: Added.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:18 PM Changeset in webkit [293466] by
-
- 5 edits in branches/safari-613-branch/Source/WebKit
Revert "Apply patch. rdar://problem/88904160"
- 3:18 PM Changeset in webkit [293465] by
-
- 3 edits in branches/safari-613-branch
Cherry-pick r292274. rdar://problem/80544133
[Cocoa] Automatically relayout the page when new fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>
Reviewed by Chris Dumez.
Source/WebCore:
This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.
FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.
Test: fast/text/install-font-style-recalc.html
- page/Page.cpp: (WebCore::m_contentSecurityPolicyModeForExtension): (WebCore::Page::firstTimeInitialization):
- page/Page.h:
- platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
- platform/graphics/FontCache.h:
Tools:
Make TestRunner::dumpResourceLoadStatistics() clear any currently-recorded statistics.
This avoids the problem where spurious layouts during the time when the page has been created but
before the test has begun record irrelevant statistics.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::clearResourceLoadStatistics):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::dumpResourceLoadStatistics):
LayoutTests:
- TestExpectations:
- fast/text/install-font-style-recalc-expected.txt: Added.
- fast/text/install-font-style-recalc.html: Added.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:18 PM Changeset in webkit [293464] by
-
- 3 edits in branches/safari-613-branch
Cherry-pick r292072. rdar://problem/80544133
[Cocoa] Automatically relayout the page when new fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>
Reviewed by Chris Dumez.
Source/WebCore:
This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.
FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.
Test: fast/text/install-font-style-recalc.html
- page/Page.cpp: (WebCore::m_attachmentElementClient):
- platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
- platform/graphics/FontCache.h:
LayoutTests:
- fast/text/install-font-style-recalc-expected.txt: Added.
- fast/text/install-font-style-recalc.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:17 PM Changeset in webkit [293463] by
-
- 5 edits in branches/safari-613-branch/Source/WebKit
Apply patch. rdar://problem/88904160
- 3:17 PM Changeset in webkit [293462] by
-
- 18 edits in branches/safari-613-branch
Apply patch. rdar://problem/88904160
- 3:17 PM Changeset in webkit [293461] by
-
- 2 edits in branches/safari-613-branch
Cherry-pick r291724. rdar://problem/91975589
Expose the AX tree of PDFs loaded via iframes on the Mac
https://bugs.webkit.org/show_bug.cgi?id=238168
Reviewed by Chris Fleizach.
Source/WebKit:
Given this markup:
<iframe src="/path/to/paystub.pdf">
An accessibility tree is built for paystub.pdf, but we don't expose it
to AX clients, making the PDF entirely inaccessible.
This happens because we were setting the AX parent to be the webpage
for full-frame PDF plugins (which an iframe with this markup is).
This behavior is correct only for main-frame (i.e. not iframe)
full-frame plugins, so this patch adds an extra condition to that logic.
Test: accessibility/mac/iframe-pdf.html
- WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::PDFPlugin):
LayoutTests:
- accessibility/mac/iframe-pdf-expected.txt: Added.
- accessibility/mac/iframe-pdf.html: Added.
- platform/mac-wk1/TestExpectations: Skip new test as it always times out in WK1 (similar to accessibility/mac/basic-embed-pdf-accessibility.html)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:17 PM Changeset in webkit [293460] by
-
- 4 edits in branches/safari-613-branch
Cherry-pick r291589. rdar://problem/90511155
LayoutTests/imported/w3c:
BroadcastChannel instances in distinct opaque origins can communicate
https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>
Reviewed by Alex Christensen.
Import web-platform-tests test coverage.
- web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt: Added.
- web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html: Added.
- web-platform-tests/webmessaging/broadcastchannel/w3c-import.log:
Source/WebCore:
BroadcastChannel instances in distinct opaque origins can communicate
https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>
Reviewed by Alex Christensen.
The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel,
which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty
SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from
unique SecurityOrigins, they would compare as equal.
To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar
to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData
objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins
would not be equal but the same unique SecurityOrigin would be. I then used this new
PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of
ClientOrigin. This allows communication between several BroadcastChannels from the same
unique origin, while preventing communication between distinct opaque origins.
When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve
the Network Process at all since the destination can only be in the same WebProcess.
Test: imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- dom/BroadcastChannel.cpp: (WebCore::shouldPartitionOrigin): (WebCore::BroadcastChannel::MainThreadBridge::registerChannel): (WebCore::BroadcastChannel::MainThreadBridge::unregisterChannel): (WebCore::BroadcastChannel::MainThreadBridge::postMessage):
- dom/BroadcastChannelRegistry.h:
- loader/EmptyClients.cpp:
- page/PartitionedSecurityOrigin.h: Added. (WebCore::PartitionedSecurityOrigin::PartitionedSecurityOrigin): (WebCore::PartitionedSecurityOrigin::isHashTableDeletedValue const): (WebCore::PartitionedSecurityOrigin::isHashTableEmptyValue const): (WebCore::operator==): (WTF::add): (WTF::PartitionedSecurityOriginHash::hash): (WTF::PartitionedSecurityOriginHash::equal): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::emptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::constructEmptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::isEmptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::peek): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::take):
Source/WebKit:
BroadcastChannel instances in distinct opaque origins can communicate
https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>
Reviewed by Alex Christensen.
The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel,
which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty
SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from
unique SecurityOrigins, they would compare as equal.
To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar
to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData
objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins
would not be equal but the same unique SecurityOrigin would be. I then used this new
PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of
ClientOrigin. This allows communication between several BroadcastChannels from the same
unique origin, while preventing communication between distinct opaque origins.
When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve
the Network Process at all since the destination can only be in the same WebProcess.
- WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.cpp: (WebKit::toClientOrigin): (WebKit::WebBroadcastChannelRegistry::registerChannel): (WebKit::WebBroadcastChannelRegistry::unregisterChannel): (WebKit::WebBroadcastChannelRegistry::postMessage): (WebKit::WebBroadcastChannelRegistry::postMessageLocally): (WebKit::WebBroadcastChannelRegistry::postMessageToRemote): (WebKit::WebBroadcastChannelRegistry::networkProcessCrashed):
- WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.h:
Source/WebKitLegacy:
Dust off Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=238121
Reviewed by Yusuke Suzuki.
- PlatformMac.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:17 PM Changeset in webkit [293459] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r292878. rdar://problem/90248865
ScriptDisallowedScope::isEventAllowedInMainThread assert failure when activating AudioSession
https://bugs.webkit.org/show_bug.cgi?id=239343
Reviewed by Eric Carlson.
As part of HTMLMediaElement::clearMediaPlayer we call PlatformMediaSession::canProduceAudioChanged
which can result in activating the AudioSession when the page is capturing audio.
This sends a synchronous IPC message to the GPU process. As part of IPC::Connection::waitForSyncReply,
we also end up dispatching enqueued messages, including a WebPage_EndPrinting message that
fires an event listener on the main thread.
This patch will instead queue the PlatformMediaSession::canProduceAudioChanged as a task to avoid
firing the event listener on the main thread, which results in assertion failure.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::clearMediaPlayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:17 PM Changeset in webkit [293458] by
-
- 6 edits in branches/safari-613-branch
Apply patch. rdar://problem/91446317
- 3:17 PM Changeset in webkit [293457] by
-
- 6 edits in branches/safari-613-branch
Revert r291606. rdar://problem/91446317
- 3:17 PM Changeset in webkit [293456] by
-
- 1 edit in branches/safari-613-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
Revert "Unreviewed build fix. rdar://91446317"
- 2:58 PM Changeset in webkit [293455] by
-
- 6 edits in trunk/Source
Fix build error: "cp: JavaScriptCore.profdata is not a directory"
https://bugs.webkit.org/show_bug.cgi?id=239681
Unreviewed build fix.
- Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/250008@main
- 2:51 PM Changeset in webkit [293454] by
-
- 4 edits in trunk
Show the option to Markup Image in the callout bar only when appropriate
https://bugs.webkit.org/show_bug.cgi?id=239779
rdar://88941823
Reviewed by Darin Adler.
Source/WebKit:
Make a minor adjustment to only show this callout bar action in the case where
_imageAnalysisMarkupDatahas
already been computed and cached.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView imageAnalysisMarkupMenu]):
Tools:
Adjust some API tests so that they continue passing after these changes.
- TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
(TestWebKitAPI::iconImage):
(TestWebKitAPI::simulateCalloutBarAppearance):
(TestWebKitAPI::invokeImageMarkupAction):
(TestWebKitAPI::TEST):
(TestWebKitAPI::runMarkupTest):
- 2:35 PM Changeset in webkit [293453] by
-
- 9 edits3 deletes in branches/safari-613.2.7.0-branch
Revert r290630. rdar://problem/89442583
This reverts r293440.
- 2:34 PM Changeset in webkit [293452] by
-
- 2 edits in trunk
Unreviewed, add my @redhat.com email
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-04-26
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/250005@main
- 2:34 PM Changeset in webkit [293451] by
-
- 2 edits in trunk/LayoutTests
[ macOS Debug wk2 ] Thirteen imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ are a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=239770
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/250005@main
- 2:30 PM Changeset in webkit [293450] by
-
- 9 edits3 deletes in branches/safari-613.2.7.1-branch
Revert r290630. rdar://problem/89442583
This reverts commit r293439.
- 2:29 PM Changeset in webkit [293449] by
-
- 13 edits in trunk/Source
Remove AriaReflectionEnabled runtime flag
https://bugs.webkit.org/show_bug.cgi?id=239532
Reviewed by Chris Fleizach.
Source/WebCore:
ARIA reflection shipped in Safari 12.1 (July 2019)
so it looks the runtime flag is not needed anymore.
- accessibility/AccessibilityRole.idl:
- accessibility/AriaAttributes.idl:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setAriaReflectionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::ariaReflectionEnabled const): Deleted.
Source/WebKit:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAriaReflectionEnabled): Deleted.
(WKPreferencesGetAriaReflectionEnabled): Deleted.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
Source/WebKitLegacy/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences ariaReflectionEnabled]): Deleted.
(-[WebPreferences setAriaReflectionEnabled:]): Deleted.
Source/WTF:
- Scripts/Preferences/WebPreferencesInternal.yaml:
- 2:24 PM Changeset in webkit [293448] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (r293117): Context menu lift animation encompasses the entire web view
https://bugs.webkit.org/show_bug.cgi?id=239782
rdar://92342919
Reviewed by Aditya Keerthi.
After r293117, we no longer implement the context menu delegate method for vending a targeted preview when
showing the context menu for a link or image; rename to match the name of the method we implement to match the
name of the UIKit delegate method.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView contextMenuInteraction:configuration:highlightPreviewForItemWithIdentifier:]):
(-[WKContentView contextMenuInteraction:configuration:previewForHighlightingItemWithIdentifier:]): Deleted.
- 2:22 PM Changeset in webkit [293447] by
-
- 8 edits in trunk
[ iOS EWS ] css3/background/background-repeat-round-auto2.html is a image failure
https://bugs.webkit.org/show_bug.cgi?id=238965
<rdar://91454381>
Reviewed by Tim Horton.
Generic shaders can produce slightly different results to optimized shaders, and
get swapped in racily, so disable them for testing on platforms where accelerated
drawing is used.
Tools:
- Scripts/webkitpy/port/base.py:
(Port.port_adjust_environment_for_test_driver):
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver):
- Scripts/webkitpy/port/ios.py:
(IOSPort.test_expectations_file_position):
(IOSPort):
(IOSPort.port_adjust_environment_for_test_driver):
- Scripts/webkitpy/port/mac.py:
(MacPort.port_adjust_environment_for_test_driver):
LayoutTests:
- platform/ios-wk2/TestExpectations:
- platform/ios/TestExpectations:
- 1:02 PM Changeset in webkit [293446] by
-
- 4 edits in trunk/Tools
[webkit-patch] Use Commit-Queue when landing by default
https://bugs.webkit.org/show_bug.cgi?id=239777
<rdar://problem/92345543>
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/tool/commands/download.py:
(LandUnsafe): Renamed from LandUnsafe.
(Land): Renamed to LandUnsafe.
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/commands/upload.py:
(LandSafely):
(Land): Inherit from LandSafely.
Canonical link: https://commits.webkit.org/250000@main
- 1:01 PM Changeset in webkit [293445] by
-
- 8 edits in trunk/JSTests
Several internationalization tests broken with ICU 69.1
https://bugs.webkit.org/show_bug.cgi?id=239724
Patch by Michael Catanzaro <Michael Catanzaro> on 2022-04-26
Reviewed by Ross Kirsling and Yusuke Suzuki.
Update these tests to be more permissive of different results for different ICU versions.
ICU 69 on macOS is producing different results from ICU 69 on Linux for reasons unexplained,
so instead of checking the version number, let's instead just accept both ways.
- stress/array-toLocaleString.js:
(shouldBeOneOf):
- stress/date-toLocaleString.js:
(shouldBeOneOf):
- stress/intl-datetimeformat-formatrange-relevant-extensions-ja.js:
(shouldBeOneOf):
(vm.icuVersion):
(shouldBeOneOfThem): Deleted.
- stress/intl-datetimeformat-formatrangetoparts-relevant-extensions-ja.js:
(shouldBeOneOf):
- stress/intl-datetimeformat.js:
(shouldBeOneOf):
(shouldBeOneOfThem): Deleted.
- stress/intl-locale-info.js:
(shouldBeOneOf):
(shouldBe):
- stress/intl-locale.js:
(shouldBeOneOf):
Canonical link: https://commits.webkit.org/250000@main
- 12:44 PM WebKitGTK/2.36.x edited by
- (diff)
- 12:31 PM Changeset in webkit [293444] by
-
- 9 edits in trunk
Constructed FormData object should not contain an entry for the submit button that was used to submit the form
https://bugs.webkit.org/show_bug.cgi?id=239070
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Update test expectation as the sub-test is now passing.
- web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set-expected.txt:
Source/WebCore:
When the activedSubmit flag is set for a submit button, its value is appended to a FormData. In the case of form
submission called in submit event handler, we include submit button when build FormData. The submit button should
not be included though. This patch correct it by calling set the activatedSubmit flag just before or after building
FormData.
Part of the patch is an import of Chromium CL at
https://codereview.chromium.org/2340213002
- html/DOMFormData.cpp:
(WebCore::DOMFormData::create):
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::defaultEventHandler):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submit):
(WebCore::HTMLFormElement::constructEntryList):
- html/HTMLFormElement.h:
- html/SubmitInputType.cpp:
(WebCore::SubmitInputType::handleDOMActivateEvent):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- 12:25 PM Changeset in webkit [293443] by
-
- 7 edits in trunk
Save a few drawing operations when painting layer contents
https://bugs.webkit.org/show_bug.cgi?id=239756
Reviewed by Tim Horton.
Remove an extra save/restore, and a translate(0,0) when painting layers and there's just one
dirty rect.
Source/WebCore:
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::paintGraphicsLayerContents):
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayer::drawLayerContents): The caller sets the clip when there's just one
dirty rect.
LayoutTests:
- displaylists/extent-includes-shadow-expected.txt:
- displaylists/layer-dispay-list-expected.txt:
- displaylists/replay-skip-clipped-rect-expected.txt:
- 12:20 PM Changeset in webkit [293442] by
-
- 9 edits in trunk/Source
[Xcode] Compute PGO profdata paths instead of searching for them at build time
https://bugs.webkit.org/show_bug.cgi?id=239681
Reviewed by Alexey Proskuryakov.
Production builds should always use profdata from the SDK, internal
release builds should use profdata from the local WebKitAdditions, and
everyone else should use the stub profdata. Add a PROFILE_DATA_PATH
build setting which implements these rules and replace the script
phases that checked those paths dynamically.
This fixes XCBuild validation issues in the open-source build, and
should prevent production builders from using stale profdata in
BUILT_PRODUCTS_DIR. Additionally, engineers can now build with custom
profile data by overriding PROFILE_DATA_PATH.
If PROFILE_DATA_PATH does not appear to be raw LLVM profiling data, it
is decoded using compression_tool(1).
- Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
- Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
- Source/WebKit/Configurations/BaseTarget.xcconfig:
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Source/WebCore/Configurations/WebCore.xcconfig:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/249997@main
- 11:51 AM Changeset in webkit [293441] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Initialize m_eglDisplay in PlatformDisplay::PlatformDisplay(GdkDisplay*)
https://bugs.webkit.org/show_bug.cgi?id=239760
Patch by Xi Ruoyao <xry111@mengyan1223.wang> on 2022-04-26
Reviewed by Michael Catanzaro.
No new tests because there is no behavior change.
- platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::PlatformDisplay):
initialize m_eglDisplay to EGL_NO_DISPLAY.
- 11:35 AM Changeset in webkit [293440] by
-
- 9 edits3 adds in branches/safari-613.2.7.0-branch
Cherry-pick r290630. rdar://problem/89442583
AX: WebKit should ignore empty modals rather than trapping focus inside them
https://bugs.webkit.org/show_bug.cgi?id=237163
Reviewed by Chris Fleizach and Andres Gonzalez.
Source/WebCore:
Given this markup:
<div role="dialog" aria-modal="true">
<div aria-hidden="true">
<button>Close modal (inside modal)</button>
</div>
</div>
There is no accessible content inside this modal, but WebKit traps user focus inside,
making the rest of the page completely inaccessible.
With this patch we ignore modals that don't have accessible content.
We do this by walking the DOM to find any non-AX-ignored objects.
Because determining whether or not an element is ignored is dependent
on modals present on the page, this patch moves the call toignoredFromModalPresence
out ofAccessibilityObject::defaultObjectInclusion, as this function is
downstream ofcomputeAccessibilityIsIgnored, and we need to call
that on objects inside modal candidates. Without this move, we would
recurse infinitely inAXObjectCache::modalElementHasAccessibleContent.
We now check whether an object is ignored due to modal presence in
AccessibilityObject::accessibilityIsIgnored(), so that function should
be used as the final say in determining whether an object is ignored.
Test: accessibility/ignore-modals-without-any-content.html
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::modalElementHasAccessibleContent): (WebCore::AXObjectCache::currentModalNode):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const): (WebCore::AccessibilityObject::accessibilityIsIgnored const):
- accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::computeAccessibilityIsIgnored const):
LayoutTests:
- accessibility/ignore-modals-without-any-content-expected.txt: Added.
- accessibility/ignore-modals-without-any-content.html: Added.
- platform/glib/TestExpectations: Skip new test.
- platform/ios/TestExpectations: Enable new test.
- platform/ios/accessibility/ignore-modals-without-any-content-expected.txt: Added.
- platform/win/TestExpectations: Skip new test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:33 AM Changeset in webkit [293439] by
-
- 9 edits3 adds in branches/safari-613.2.7.1-branch
Cherry-pick r290630. rdar://problem/89442583
AX: WebKit should ignore empty modals rather than trapping focus inside them
https://bugs.webkit.org/show_bug.cgi?id=237163
Reviewed by Chris Fleizach and Andres Gonzalez.
Source/WebCore:
Given this markup:
<div role="dialog" aria-modal="true">
<div aria-hidden="true">
<button>Close modal (inside modal)</button>
</div>
</div>
There is no accessible content inside this modal, but WebKit traps user focus inside,
making the rest of the page completely inaccessible.
With this patch we ignore modals that don't have accessible content.
We do this by walking the DOM to find any non-AX-ignored objects.
Because determining whether or not an element is ignored is dependent
on modals present on the page, this patch moves the call toignoredFromModalPresence
out ofAccessibilityObject::defaultObjectInclusion, as this function is
downstream ofcomputeAccessibilityIsIgnored, and we need to call
that on objects inside modal candidates. Without this move, we would
recurse infinitely inAXObjectCache::modalElementHasAccessibleContent.
We now check whether an object is ignored due to modal presence in
AccessibilityObject::accessibilityIsIgnored(), so that function should
be used as the final say in determining whether an object is ignored.
Test: accessibility/ignore-modals-without-any-content.html
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::modalElementHasAccessibleContent): (WebCore::AXObjectCache::currentModalNode):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::defaultObjectInclusion const): (WebCore::AccessibilityObject::accessibilityIsIgnored const):
- accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::computeAccessibilityIsIgnored const):
LayoutTests:
- accessibility/ignore-modals-without-any-content-expected.txt: Added.
- accessibility/ignore-modals-without-any-content.html: Added.
- platform/glib/TestExpectations: Skip new test.
- platform/ios/TestExpectations: Enable new test.
- platform/ios/accessibility/ignore-modals-without-any-content-expected.txt: Added.
- platform/win/TestExpectations: Skip new test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:32 AM Changeset in webkit [293438] by
-
- 9 edits in branches/safari-613.2.7.0-branch/Source
Versioning.
WebKit-7613.2.7.0.4
- 11:31 AM Changeset in webkit [293437] by
-
- 2 edits in trunk/LayoutTests
[ macOS Debug wk2 ] Six imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ are a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=239770
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249995@main
- 11:28 AM Changeset in webkit [293436] by
-
- 11 edits2 adds in trunk
Adjust some image transcoding behaviors related to "Copy Cropped Image"
https://bugs.webkit.org/show_bug.cgi?id=239748
rdar://92287000
Reviewed by Kate Cheney.
Source/WebKit:
Refactor some logic for extracting "cropped images" and "markup images". Currently, we always try to preserve
the MIME type of the source image data, but this causes various issues, such as images losing alpha or failing
to transcode altogether. See below for more details.
Test: ImageAnalysisTests.PerformImageAnalysisMarkupWithWebPImages
- Platform/cocoa/CocoaImage.h:
- Platform/cocoa/CocoaImage.mm:
(WebKit::transcodeWithPreferredMIMEType):
Drop support for the
fallbackTypeIdentifierargument, now that nothing depends on it.
- Platform/cocoa/ImageAnalysisUtilities.h:
- Platform/cocoa/ImageAnalysisUtilities.mm:
(WebKit::imageDataForCroppedImageResult):
Add a new helper method to convert a CGImageRef to raw image data that's appropriate for the given source MIME
type. If the type belongs one of a short list of supported types, we use it directly; otherwise, fall back to
"image/png".
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView imageAnalysisMarkupMenu]):
(-[WKContentView actionSheetAssistant:copyCroppedImage:sourceMIMEType:]):
- UIProcess/mac/WebContextMenuProxyMac.mm:
Deploy
imageDataForCroppedImageResultin place of directly callingtranscodeWithPreferredMIMEType.
(WebKit::WebContextMenuProxyMac::applyMarkupToControlledImage):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::handleContextMenuCopyCroppedImage):
Tools:
Add an API test to exercise the change.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:
(TestWebKitAPI::runMarkupTest):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/webp-image.html: Added.
- 11:28 AM Changeset in webkit [293435] by
-
- 9 edits in branches/safari-613.2.7.1-branch/Source
Versioning.
WebKit-7613.2.7.1.5
- 11:21 AM Changeset in webkit [293434] by
-
- 9 edits in branches/safari-613.2.7.3-branch/Source
Versioning.
WebKit-7613.2.7.3.3.
- 11:16 AM Changeset in webkit [293433] by
-
- 2 edits in trunk/Source/WebKit
[WebAuthn] Do not pass ASCCredentialRequestTypePlatform... if LocalService unavailable
https://bugs.webkit.org/show_bug.cgi?id=239746
rdar://91981865
Reviewed by Brent Fulgham.
Passing platform in requestTypes breaks the UI in registerations with the syncing platform
authenticator off and local service is unavailable. This patch stops passing it in this case.
- UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
(WebKit::configureRegistrationRequestContext):
(WebKit::WebAuthenticatorCoordinatorProxy::performRequest):
- 11:09 AM Changeset in webkit [293432] by
-
- 2 edits in trunk/Source/WebCore
[WebAuthn] Remove misspelled constant "LocalAuthenticatiorAccessGroup"
https://bugs.webkit.org/show_bug.cgi?id=235894
rdar://88104045
Reviewed by Brent Fulgham.
This change removes a constant with a misspelled variable name after all
downstream usage is removed.
- Modules/webauthn/WebAuthenticationConstants.h:
- 11:01 AM Changeset in webkit [293431] by
-
- 2 edits in trunk
Remove usage of makeWeakPtr() on Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=239768
Reviewed by Chris Dumez.
- Introduction.md:
- 9:56 AM Changeset in webkit [293430] by
-
- 3 edits in trunk/Tools
Enable --treat-failing-as-flaky for the JSC post-commit bots
https://bugs.webkit.org/show_bug.cgi?id=239341
Reviewed by Jonathan Bedard.
Try to cover up for a little test flakiness (while still recording
it in resultsdb) to avoid too many false alerts.
- CISupport/build-webkit-org/steps.py:
(RunJavaScriptCoreTests):
(RunJavaScriptCoreTests.start):
- CISupport/build-webkit-org/steps_unittest.py:
- 9:43 AM Changeset in webkit [293429] by
-
- 2 edits in trunk/LayoutTests
[ macOS Debug wk2 ] Four imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ are a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=239770
Unreviewed test gardening.
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249989@main
- 9:31 AM Changeset in webkit [293428] by
-
- 3 edits in trunk/Source/WebKit
Fix crashes under RemoteLayerBackingStore::applyBackingStoreToLayer()
https://bugs.webkit.org/show_bug.cgi?id=239742
<rdar://91533748>
Reviewed by Wenson Hsieh.
It's possible for ensureBackendCreated() to time out, especially when debugging the GPU
process, in which case RemoteLayerBackingStore can end up with a front buffer with no
backend, which results in an unset m_bufferHandle in the UI process. So add some logging
when this happens, and check the m_bufferHandle optional before accessing its value.
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
- WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
- 9:28 AM Changeset in webkit [293427] by
-
- 11 edits in trunk
Remove WebArchiveDebugMode
https://bugs.webkit.org/show_bug.cgi?id=239738
<rdar://problem/88406961>
Reviewed by Tim Horton.
Source/WebCore:
Remove use case of WebArchiveDebugMode and deprecate it now that it
is no longer in use. Add a new temporary flag WebArchiveTestMode
that is more aptly named and will maintain existing behavior for
internal tests temporarily.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::scheduleArchiveLoad):
Source/WebKit:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWebArchiveTestingModeEnabled):
(WKPreferencesGetWebArchiveTestingModeEnabled):
(WKPreferencesSetWebArchiveDebugModeEnabled):
(WKPreferencesGetWebArchiveDebugModeEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setWebArchiveTestingModeEnabled:]):
(-[WKPreferences _webArchiveTestingModeEnabled]):
(-[WKPreferences _setWebArchiveDebugModeEnabled:]):
(-[WKPreferences _webArchiveDebugModeEnabled]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
Source/WTF:
- Scripts/Preferences/WebPreferences.yaml:
Tools:
- TestWebKitAPI/Tests/mac/LoadWebArchive.mm:
(TestWebKitAPI::TEST):
(TestWebKitAPI::constructArchive):
- 8:59 AM Changeset in webkit [293426] by
-
- 2 edits in trunk/Source/WebKit
Add object addresses to IPC logging
https://bugs.webkit.org/show_bug.cgi?id=239754
Reviewed by Cameron McCormack.
It's useful if IPC logging shows the receiver address, so you can distinguish different
receivers.
- Platform/IPC/HandleMessage.h:
(IPC::textStreamForLogging):
(IPC::logMessageImpl):
(IPC::logMessage):
(IPC::logReply):
(IPC::handleMessage):
(IPC::handleMessageWantsConnection):
(IPC::handleMessageSynchronous):
(IPC::handleMessageSynchronousWantsConnection):
(IPC::handleMessageAsync):
(IPC::handleMessageAsyncWantsConnection):
- 8:51 AM Changeset in webkit [293425] by
-
- 8 edits in trunk/Source/WebKit
REGRESSION(r288464?):[ iOS15 Release GPUP arm64 ] TestWebKitAPI.GPUProcess.ExitsUnderMemoryPressureGetUserMediaAudioCase is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=237854
<rdar://problem/90273222>
Reviewed by Eric Carlson.
stopProducingData was called on some ended tracks.
This would trigger the creation of a new connection in case GPUProcess is gone.
To prevent this, we now keep a connection reference in RemoteRealtimeMediaSourceProxy.
When the GPUProcess connection is being closed, we update the connection if the track is to be continued.
Covered by API test.
- WebProcess/cocoa/RemoteCaptureSampleManager.cpp:
- WebProcess/cocoa/RemoteCaptureSampleManager.h:
- WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:
- WebProcess/cocoa/RemoteRealtimeMediaSource.h:
- WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.cpp:
- WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:
- WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:
- 8:35 AM Changeset in webkit [293424] by
-
- 2 edits in trunk/LayoutTests
http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html is failing
https://bugs.webkit.org/show_bug.cgi?id=239630
<rdar://92128154>
Reviewed by Youenn Fablet.
We get an error when closing the websocket. The error gets queued up on the event loop and
may or may not get processed before the test ends, leading to flakiness. The test is actually
about testing bufferedAmount after closing the socket and this part is still being tested and
reliably passing. As a result, I am simply silencing the error in the test to address the
flakiness.
- LayoutTests/http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/249984@main
- 7:28 AM Changeset in webkit [293423] by
-
- 2 edits in trunk/Tools
[ews-build.webkit.org] Specify repository when sending emails
https://bugs.webkit.org/show_bug.cgi?id=239739
<rdar://problem/92291225>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/steps.py:
(GitHubMixin.should_send_email_for_pr): Pass repository URL.
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.
Canonical link: https://commits.webkit.org/249983@main
- 4:01 AM Changeset in webkit [293422] by
-
- 2 edits in trunk/Source/WebCore
[DatabaseTracker] Use PRIu64 for logging for portability
https://bugs.webkit.org/show_bug.cgi?id=239765
Reviewed by Adrian Perez de Castro.
Use PRIu64 when logging to avoid warnings.
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::setQuota):
- 3:59 AM Changeset in webkit [293421] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Mark unused variable
https://bugs.webkit.org/show_bug.cgi?id=239766
Reviewed by Adrian Perez de Castro.
- platform/mock/MockRealtimeMediaSourceCenter.cpp:
- 3:29 AM Changeset in webkit [293420] by
-
- 4 edits in trunk/Source/ThirdParty/ANGLE
Update test_expectations, run_code_generation.py, angle_unittests.gni from ANGLE upstream
https://bugs.webkit.org/show_bug.cgi?id=239645
Unreviewed, reproducible with Tools/Scripts/update-angle --regenerate-changes-diff
These are not changed in downstream but the changes are due to stale merges.
Reduces the changes.diff
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-26
- changes.diff:
- scripts/run_code_generation.py:
(main):
- src/tests/angle_unittests.gni:
- src/tests/deqp_support/deqp_egl_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_egl_TestExpectations.
- src/tests/deqp_support/deqp_gles2_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles2_TestExpectations.
- src/tests/deqp_support/deqp_gles31_rotate_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles31_rotate_TestExpectations.
- src/tests/deqp_support/deqp_gles31_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles31_TestExpectations.
- src/tests/deqp_support/deqp_gles3_rotate_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles3_rotate_TestExpectations.
- src/tests/deqp_support/deqp_gles3_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_gles3_TestExpectations.
- src/tests/deqp_support/deqp_khr_gles2_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_khr_gles2_TestExpectations.
- src/tests/deqp_support/deqp_khr_gles31_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_khr_gles31_TestExpectations.
- src/tests/deqp_support/deqp_khr_gles32_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_khr_gles32_TestExpectations.
- src/tests/deqp_support/deqp_khr_gles3_TestExpectations: Renamed from Source/ThirdParty/ANGLE/src/tests/deqp_support/deqp_khr_gles3_TestExpectations.
- 1:15 AM Changeset in webkit [293419] by
-
- 8 edits1 add in trunk/Tools/buildstream
[Flatpak SDK] Partial revert of r249480
https://bugs.webkit.org/show_bug.cgi?id=239700
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-26
Reviewed by Adrian Perez de Castro.
The switch to upstream gtk3 recipe broke something related with icons handling and
introduced a crash in media/video-controls-drag.html. For the time being, revert to our
custom recipe.
This patch also updates the pipenv environment used to build the SDK, to BuildStream 1.6.5.
- Pipfile:
- Pipfile.lock:
- elements/qt5/qtbase.bst:
- elements/sdk-platform.bst:
- elements/sdk/adwaita-icon-theme.bst:
- elements/sdk/gst-plugins-base.bst:
- elements/sdk/gst-plugins-good.bst:
- elements/sdk/gtk+-3.bst: Added.
Canonical link: https://commits.webkit.org/249979@main
- 12:34 AM Changeset in webkit [293418] by
-
- 9 edits in trunk
Service Worker loads should not expose some ResourceTiming information
https://bugs.webkit.org/show_bug.cgi?id=239608
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/resource-timing-fetch-variants.https-expected.txt:
Source/WebCore:
Filter out some resource timing info when the load is served from a service worker.
While we could do the filtering on service worker side, it is best to do it within PerformanceResourceTiming
as native clients might still want to use non filtered data in case the service worker is returning a network load
as the response.
Covered by rebased test.
- loader/ResourceTiming.cpp:
(WebCore::ResourceTiming::ResourceTiming):
- loader/ResourceTiming.h:
(WebCore::ResourceTiming::isLoadedFromServiceWorker const):
- page/PerformanceResourceTiming.cpp:
(WebCore::PerformanceResourceTiming::nextHopProtocol const):
(WebCore::PerformanceResourceTiming::redirectStart const):
(WebCore::PerformanceResourceTiming::redirectEnd const):
(WebCore::PerformanceResourceTiming::domainLookupStart const):
(WebCore::PerformanceResourceTiming::domainLookupEnd const):
(WebCore::PerformanceResourceTiming::connectStart const):
(WebCore::PerformanceResourceTiming::connectEnd const):
- page/PerformanceResourceTiming.h:
(WebCore::PerformanceResourceTiming::isLoadedFromServiceWorker const):
LayoutTests:
Apr 25, 2022:
- 11:57 PM Changeset in webkit [293417] by
-
- 6 edits in trunk
Service workers should not intercept embed/object related loads
https://bugs.webkit.org/show_bug.cgi?id=239642
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/service-workers/service-worker/embed-and-object-are-not-intercepted.https-expected.txt:
Source/WebCore:
In case document loader or image loader are triggered by embed/object elements,
set service worker mode to none.
Covered by rebased test.
- loader/DocumentLoader.cpp:
- loader/DocumentLoader.h:
- loader/ImageLoader.cpp:
- 11:43 PM Changeset in webkit [293416] by
-
- 1 copy in tags/WebKit-7613.2.7.2.3
Tag WebKit-7613.2.7.2.3.
- 11:41 PM Changeset in webkit [293415] by
-
- 9 edits in branches/safari-613.2.7.2-branch/Source
Versioning.
WebKit-7613.2.7.2.2
- 11:36 PM Changeset in webkit [293414] by
-
- 1 copy in tags/WebKit-7613.2.7.1.4
Tag WebKit-7613.2.7.1.4.
- 11:34 PM Changeset in webkit [293413] by
-
- 9 edits in branches/safari-613.2.7.1-branch/Source
Versioning.
WebKit-7613.2.7.1.4
- 11:31 PM Changeset in webkit [293412] by
-
- 1 copy in tags/WebKit-7613.2.7.0.3
Tag WebKit-7613.2.7.0.3.
- 11:28 PM Changeset in webkit [293411] by
-
- 9 edits in branches/safari-613.2.7.0-branch/Source
Versioning.
WebKit-7613.2.7.0.3
- 9:49 PM Changeset in webkit [293410] by
-
- 4 edits in trunk
[iOS] Add NSCoding support for findInteractionEnabled
https://bugs.webkit.org/show_bug.cgi?id=239733
rdar://87850648
Reviewed by Wenson Hsieh.
Source/WebKit:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithCoder:]):
(-[WKWebView encodeWithCoder:]):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
(TEST):
- 9:07 PM Changeset in webkit [293409] by
-
- 31 edits3 adds2 deletes in trunk
Web Inspector: add UI for blocking requests
https://bugs.webkit.org/show_bug.cgi?id=239674
Reviewed by Patrick Angle.
Source/WebCore:
Test: http/tests/inspector/network/intercept-request-with-error.html
- inspector/agents/InspectorNetworkAgent.h:
(WebCore::InspectorNetworkAgent::errorDomain): Added.
- inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::toResourceErrorType): Added.
(WebCore::InspectorNetworkAgent::interceptRequestWithError):
Unify the resource error message for consistency.
Mark the resource error as coming from Web Inspector so that it can identified (see below).
- inspector/agents/WebConsoleAgent.cpp:
(WebCore::WebConsoleAgent::didFailLoading):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::logErrorAndFail):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFail):
Don't add console messages for requests that were blocked by Web Inspector.
- inspector/agents/page/PageNetworkAgent.h:
- inspector/agents/page/PageNetworkAgent.cpp:
(WebCore::PageNetworkAgent::addConsoleMessage): Added.
- inspector/agents/worker/WorkerNetworkAgent.h:
- inspector/agents/worker/WorkerNetworkAgent.cpp:
(WebCore::WorkerNetworkAgent::addConsoleMessage): Added.
Add avirtualmethod so thatInspectorNetworkAgentcan log to the console (PageNetworkAgent
uses thePage,WorkerNetworkAgentuses theWorkerOrWorkletGlobalScope, etc.).
Source/WebInspectorUI:
- UserInterface/Models/LocalResourceOverride.js:
(WI.LocalResourceOverride):
(WI.LocalResourceOverride.create):
(WI.LocalResourceOverride.displayNameForNetworkStageOfType): Added.
(WI.LocalResourceOverride.displayNameForType):
(WI.LocalResourceOverride.displayNameForResourceErrorType): Added.
(WI.LocalResourceOverride.fromJSON):
(WI.LocalResourceOverride.prototype.toJSON):
(WI.LocalResourceOverride.prototype.get resourceErrorType): Added.
(WI.LocalResourceOverride.prototype.set resourceErrorType): Added.
(WI.LocalResourceOverride.prototype.get canMapToFile):
AddWI.LocalResourceOverride.ResourceErrorType(and a corresponding member variable) that
is be used when blocking matching requests.
- UserInterface/Controllers/NetworkManager.js:
(WI.NetworkManager.supportsBlockingRequests): Added.
(WI.NetworkManager.prototype.async requestIntercepted):
(WI.NetworkManager.prototype._handleResourceOverrideResourceErrorTypeChanged): Added.
Make sure to saveWI.LocalResourceOverride.InterceptType.Blockwhenever the
WI.LocalResourceOverride.ResourceErrorTypechanges.
- UserInterface/Views/ContextMenuUtilities.js:
(WI.appendContextMenuItemsForSourceCode):
- UserInterface/Views/ResourceContentView.js:
(WI.ResourceContentView):
(WI.ResourceContentView.prototype._populateCreateLocalResourceOverrideContextMenu):
(WI.ResourceContentView.prototype._handleCreateLocalResourceOverride): Deleted.
Add contextmenu items for "Block Request URL".
- UserInterface/Views/LocalResourceOverrideRequestContentView.js:
(WI.LocalResourceOverrideRequestContentView):
(WI.LocalResourceOverrideRequestContentView.prototype.initialLayout):
(WI.LocalResourceOverrideRequestContentView.prototype.initialLayout.addOption): Added.
- UserInterface/Views/LocalResourceOverrideRequestContentView.css:
(.content-view.text.local-resource-override-request > .message-text-view select): Added.
There will be no request or response content forWI.LocalResourceOverride.InterceptType.Block
so show a<select>for choosing theWI.LocalResourceOverride.ResourceErrorType.
- UserInterface/Views/LocalResourceOverridePopover.js:
(WI.LocalResourceOverridePopover.prototype.get serializedData):
(WI.LocalResourceOverridePopover.prototype.show):
- UserInterface/Views/LocalResourceOverridePopover.css:
(.popover .local-resource-override-popover-content:is(.response, .block) .editor.url): Renamed from
.popover .local-resource-override-popover-content.response .editor.url.
Only show the URL editor forWI.LocalResourceOverride.InterceptType.Block.
- UserInterface/Models/Resource.js:
(WI.Resource.classNamesForResource):
- UserInterface/Views/ResourceTreeElement.js:
(WI.ResourceTreeElement.prototype._updateResource):
(WI.ResourceTreeElement.prototype._updateIcon):
(WI.ResourceTreeElement.prototype._loadingDidFail): Added.
- UserInterface/Views/ResourceIcons.css:
(.resource-icon.override.skip-network .icon): Added.
(body:not(.window-inactive, .window-docked-inactive) :is(.table, .data-grid):focus-within .selected .resource-icon.override.skip-network .icon, body:not(.window-inactive, .window-docked-inactive) .tree-outline:focus-within .selected.resource-icon.override.skip-network .icon): Added.
(@media (prefers-color-scheme: dark) .resource-icon.override.skip-network .icon): Added.
- UserInterface/Images/SkipNetwork.svg: Added.
Add a new icon for when requests do not involve any network activity.
- UserInterface/Views/ContentView.js:
(WI.ContentView.createFromRepresentedObject):
(WI.ContentView.resolvedRepresentedObjectForRepresentedObject):
- UserInterface/Views/FontResourceContentView.js:
(WI.FontResourceContentView.prototype.dropZoneShouldAppearForDragEvent):
- UserInterface/Views/ImageResourceContentView.js:
(WI.ImageResourceContentView.prototype.dropZoneShouldAppearForDragEvent):
- UserInterface/Views/LocalResourceOverrideTreeElement.js:
(WI.LocalResourceOverrideTreeElement.prototype.willDismissPopover):
Use positive checks for the desiredWI.LocalResourceOverride.InterceptTypeinstead of
a negative check for the one value meant to be exlucded in the expectation that no new
enum values would get added (which this patch proves to be false).
- UserInterface/Views/LocalResourceOverrideLabelView.js:
(WI.LocalResourceOverrideLabelView.prototype.initialLayout):
Use the newWI.LocalResourceOverride.displayNameForNetworkStageOfTypeinstead of doing
that work here.
- Localizations/en.lproj/localizedStrings.js:
LayoutTests:
- http/tests/inspector/network/intercept-request-with-error.html: Added.
- http/tests/inspector/network/intercept-request-with-error-expected.txt: Added.
- inspector/network/interceptRequestWithError.html: Removed.
- inspector/network/interceptRequestWithError-expected.txt: Removed.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
Reworked this test to use
WI.LocalResourceOverrideinstead of the protocol.
- 8:53 PM Changeset in webkit [293408] by
-
- 2 edits in trunk/Source/WebKit
[XCBuild] Refactor WebKit resources to emit output tasks for dependency validation
https://bugs.webkit.org/show_bug.cgi?id=239556
Reviewed by Alexey Proskuryakov.
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Replace the script phase that calls generate-automation-atom.py with a build rule, and process those files as headers.
- Clean up references and project metadata for deleted files.
- Use WK_FRAMEWORK_VERSION_PREFIX in script output paths so that the realpaths are correct on macOS.
Canonical link: https://commits.webkit.org/249974@main
- 7:16 PM Changeset in webkit [293407] by
-
- 1 copy in tags/WebKit-7613.2.7.3.2
Tag WebKit-7613.2.7.3.2.
- 7:14 PM Changeset in webkit [293406] by
-
- 1 edit in branches/safari-613.2.7.3-branch/Source/JavaScriptCore/API/JSTypedArray.cpp
Apply patch. rdar://67069953
- 7:13 PM Changeset in webkit [293405] by
-
- 9 edits in branches/safari-613.2.7.3-branch/Source
Versioning.
WebKit-7613.2.7.3.2
- 7:06 PM Changeset in webkit [293404] by
-
- 1 copy in tags/WebKit-7613.2.7.0.2
Tag WebKit-7613.2.7.0.2.
- 7:03 PM Changeset in webkit [293403] by
-
- 1 edit in branches/safari-613.2.7.0-branch/Source/JavaScriptCore/API/JSTypedArray.cpp
Apply patch. rdar://67069953
- 7:03 PM Changeset in webkit [293402] by
-
- 1 edit in branches/safari-613.2.7.0-branch/Source/JavaScriptCore/API/JSTypedArray.cpp
Apply patch. rdar://67069953
- 7:03 PM Changeset in webkit [293401] by
-
- 112 edits5 deletes in branches/safari-613.2.7.0-branch/Source
Apply patch. rdar://problem/67069953
- 6:55 PM Changeset in webkit [293400] by
-
- 1 copy in tags/WebKit-7613.2.7.1.3
Tag WebKit-7613.2.7.1.3.
- 6:49 PM Changeset in webkit [293399] by
-
- 1 edit in branches/safari-613.2.7.1-branch/Source/JavaScriptCore/API/JSTypedArray.cpp
Apply patch. rdar://67069953
- 6:49 PM Changeset in webkit [293398] by
-
- 1 edit in branches/safari-613.2.7.1-branch/Source/JavaScriptCore/API/JSTypedArray.cpp
Apply patch. rdar://67069953
- 6:49 PM Changeset in webkit [293397] by
-
- 112 edits5 deletes in branches/safari-613.2.7.1-branch/Source
Apply patch. rdar://problem/67069953
- 6:44 PM Changeset in webkit [293396] by
-
- 1 copy in tags/WebKit-7613.2.7.2.1
Tag WebKit-7613.2.7.2.1.
- 6:41 PM Changeset in webkit [293395] by
-
- 1 delete in tags/WebKit-7613.2.7.2.1
Delete tag.
- 6:40 PM Changeset in webkit [293394] by
-
- 1 edit in branches/safari-613.2.7.2-branch/Source/JavaScriptCore/API/JSTypedArray.cpp
Apply patch. rdar://67069953
- 6:36 PM Changeset in webkit [293393] by
-
- 2 edits in trunk/Source/JavaScriptCore
structureIDToStructureWithScratch should only do things if ADDRESS64
https://bugs.webkit.org/show_bug.cgi?id=239749
Reviewed by Saam Barati.
- llint/LowLevelInterpreter64.asm:
- 6:31 PM Changeset in webkit [293392] by
-
- 1 edit in branches/safari-613-branch/Source/JavaScriptCore/API/JSTypedArray.cpp
Apply patch. rdar://67069953
- 6:22 PM BuildingCairoOnWindows edited by
- (diff)
- 6:20 PM BuildingCairoOnWindows edited by
- (diff)
- 6:16 PM Changeset in webkit [293391] by
-
- 2 edits in branches/safari-613-branch/Source/WebCore
Cherry-pick r290860. rdar://problem/89291570
AX: Protect incoming object with Ref in AXObjectCache::textChanged
https://bugs.webkit.org/show_bug.cgi?id=237475
Reviewed by Chris Fleizach.
This is better practice as ascending the hierarchy could cause
the object to get deleted.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 6:13 PM Changeset in webkit [293390] by
-
- 1 copy in tags/WebKit-7613.2.7.2.1
Tag WebKit-7613.2.7.2.1.
- 6:09 PM Changeset in webkit [293389] by
-
- 1 edit in branches/safari-613.2.7.2-branch/Source/JavaScriptCore/API/JSTypedArray.cpp
Apply patch. rdar://67069953
- 6:09 PM Changeset in webkit [293388] by
-
- 112 edits5 deletes in branches/safari-613.2.7.2-branch/Source
Apply patch. rdar://problem/67069953
- 6:02 PM Changeset in webkit [293387] by
-
- 1 copy in tags/WebKit-7613.2.7.3.1
Tag WebKit-7613.2.7.3.1.
- 6:00 PM Changeset in webkit [293386] by
-
- 1 edit in branches/safari-613.2.7.3-branch/Source/JavaScriptCore/API/JSTypedArray.cpp
Apply patch. rdar://67069953
- 6:00 PM Changeset in webkit [293385] by
-
- 112 edits5 deletes in branches/safari-613.2.7.3-branch/Source
Apply patch. rdar://problem/67069953
- 5:57 PM Changeset in webkit [293384] by
-
- 1 edit in branches/safari-613-branch/Source/JavaScriptCore/API/JSTypedArray.cpp
Apply patch. rdar://67069953
- 5:41 PM Changeset in webkit [293383] by
-
- 112 edits5 deletes in branches/safari-613-branch/Source
Apply patch. rdar://problem/67069953
- 5:25 PM Changeset in webkit [293382] by
-
- 3 edits in trunk/Tools
[Merge-Queue] Differentiate gardening commits in bug comments
https://bugs.webkit.org/show_bug.cgi?id=239740
<rdar://problem/92293298>
Reviewed by Ryan Haddad.
- Tools/CISupport/ews-build/steps.py:
(DetermineLandedIdentifier.comment_text_for_bug):
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249972@main
- 5:21 PM Changeset in webkit [293381] by
-
- 2 edits in trunk/Tools
GitHub EWS is confused with prior PR's merge-blocked label
https://bugs.webkit.org/show_bug.cgi?id=239411
<rdar://problem/92196846>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/steps.py:
(BlockPullRequest.start): Only apply blocked label if tested hash and current hash match.
Canonical link: https://commits.webkit.org/249971@main
- 5:16 PM Changeset in webkit [293380] by
-
- 6 edits in trunk/Source/WebKit
HARDENING: Add MESSAGE_CHECK in some Captive Portal cases
https://bugs.webkit.org/show_bug.cgi?id=239551
<rdar://91478748>
Reviewed by Darin Adler.
Add MESSAGE_CHECK protections to a set of message handlers for API prohibited when
sent from a Captive Portal process. This change also adds a flag to the GPUProcessConnectionParameters
struct so that GPU Process connections can be marked as being associated with a Captive Portal
process.
- GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::GPUConnectionToWebProcess):
(WebKit::GPUConnectionToWebProcess::createGraphicsContextGL):
(WebKit::GPUConnectionToWebProcess::releaseGraphicsContextGL):
- GPUProcess/GPUConnectionToWebProcess.h:
(WebKit::GPUConnectionToWebProcess::isCaptivePortalModeEnabled const):
- GPUProcess/media/RemoteAudioDestinationManager.cpp:
(WebKit::RemoteAudioDestinationManager::createAudioDestination):
(WebKit::RemoteAudioDestinationManager::deleteAudioDestination):
(WebKit::RemoteAudioDestinationManager::startAudioDestination):
(WebKit::RemoteAudioDestinationManager::stopAudioDestination):
- Shared/GPUProcessConnectionParameters.h:
(WebKit::GPUProcessConnectionParameters::encode const):
(WebKit::GPUProcessConnectionParameters::decode):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::getGPUProcessConnection):
- 5:12 PM Changeset in webkit [293379] by
-
- 8 edits in trunk/Source
Introduce new makeStringByReplacingAll(StringView, UChar, UChar) function
https://bugs.webkit.org/show_bug.cgi?id=239728
Reviewed by Darin Adler.
Introduce new makeStringByReplacingAll(StringView, UChar, UChar) function, to complement
the existing makeStringByReplacingAll(const String&, UChar, UChar). This allows several
call sites to avoid a temporary String constructing since they have a StringView.
- Source/WebCore/PAL/pal/text/TextCodecICU.cpp:
(PAL::TextCodecICU::encode const):
- Source/WTF/wtf/URLParser.cpp:
(WTF::URLParser::parseURLEncodedForm):
- Source/WTF/wtf/text/StringImpl.cpp:
(WTF::StringImpl::replace):
- Source/WTF/wtf/text/StringImpl.h:
(WTF::StringImpl::createByReplacingInCharacters):
- Source/WTF/wtf/text/StringView.cpp:
(WTF::makeStringByReplacingAll):
- Source/WTF/wtf/text/StringView.h:
- Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::queryKeysAndValues):
- Source/WebCore/editing/cocoa/HTMLConverter.mm:
(WebCore::editingAttributedString):
Canonical link: https://commits.webkit.org/249969@main
- 5:03 PM Changeset in webkit [293378] by
-
- 1 edit in branches/safari-613-branch/Source/WebCore/page/Page.cpp
Unreviewed build fix. rdar://80544133
./page/Page.cpp:389:9: error: incomplete type 'WebCore::FontCache' named in nested name specifier
- 5:03 PM Changeset in webkit [293377] by
-
- 3 edits in branches/safari-613-branch
Cherry-pick r292274. rdar://problem/80544133
[Cocoa] Automatically relayout the page when new fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>
Reviewed by Chris Dumez.
Source/WebCore:
This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.
FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.
Test: fast/text/install-font-style-recalc.html
- page/Page.cpp: (WebCore::m_contentSecurityPolicyModeForExtension): (WebCore::Page::firstTimeInitialization):
- page/Page.h:
- platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
- platform/graphics/FontCache.h:
Tools:
Make TestRunner::dumpResourceLoadStatistics() clear any currently-recorded statistics.
This avoids the problem where spurious layouts during the time when the page has been created but
before the test has begun record irrelevant statistics.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::clearResourceLoadStatistics):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::dumpResourceLoadStatistics):
LayoutTests:
- TestExpectations:
- fast/text/install-font-style-recalc-expected.txt: Added.
- fast/text/install-font-style-recalc.html: Added.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:02 PM Changeset in webkit [293376] by
-
- 3 edits in branches/safari-613-branch
Cherry-pick r292274. rdar://problem/80544133
[Cocoa] Automatically relayout the page when new fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>
Reviewed by Chris Dumez.
Source/WebCore:
This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.
FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.
Test: fast/text/install-font-style-recalc.html
- page/Page.cpp: (WebCore::m_contentSecurityPolicyModeForExtension): (WebCore::Page::firstTimeInitialization):
- page/Page.h:
- platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
- platform/graphics/FontCache.h:
Tools:
Make TestRunner::dumpResourceLoadStatistics() clear any currently-recorded statistics.
This avoids the problem where spurious layouts during the time when the page has been created but
before the test has begun record irrelevant statistics.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::clearResourceLoadStatistics):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::dumpResourceLoadStatistics):
LayoutTests:
- TestExpectations:
- fast/text/install-font-style-recalc-expected.txt: Added.
- fast/text/install-font-style-recalc.html: Added.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:02 PM Changeset in webkit [293375] by
-
- 4 edits2 adds in branches/safari-613-branch
Cherry-pick r291724. rdar://problem/91975589
Expose the AX tree of PDFs loaded via iframes on the Mac
https://bugs.webkit.org/show_bug.cgi?id=238168
Reviewed by Chris Fleizach.
Source/WebKit:
Given this markup:
<iframe src="/path/to/paystub.pdf">
An accessibility tree is built for paystub.pdf, but we don't expose it
to AX clients, making the PDF entirely inaccessible.
This happens because we were setting the AX parent to be the webpage
for full-frame PDF plugins (which an iframe with this markup is).
This behavior is correct only for main-frame (i.e. not iframe)
full-frame plugins, so this patch adds an extra condition to that logic.
Test: accessibility/mac/iframe-pdf.html
- WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::PDFPlugin):
LayoutTests:
- accessibility/mac/iframe-pdf-expected.txt: Added.
- accessibility/mac/iframe-pdf.html: Added.
- platform/mac-wk1/TestExpectations: Skip new test as it always times out in WK1 (similar to accessibility/mac/basic-embed-pdf-accessibility.html)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:02 PM Changeset in webkit [293374] by
-
- 2 edits in branches/safari-613-branch
Apply patch. rdar://problem/91590827
- 5:02 PM Changeset in webkit [293373] by
-
- 10 edits in branches/safari-613-branch
Apply patch. rdar://problem/91288849
- 5:02 PM Changeset in webkit [293372] by
-
- 20 edits3 adds in branches/safari-613-branch
Cherry-pick r291589. rdar://problem/90511155
LayoutTests/imported/w3c:
BroadcastChannel instances in distinct opaque origins can communicate
https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>
Reviewed by Alex Christensen.
Import web-platform-tests test coverage.
- web-platform-tests/webmessaging/broadcastchannel/opaque-origin-expected.txt: Added.
- web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html: Added.
- web-platform-tests/webmessaging/broadcastchannel/w3c-import.log:
Source/WebCore:
BroadcastChannel instances in distinct opaque origins can communicate
https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>
Reviewed by Alex Christensen.
The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel,
which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty
SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from
unique SecurityOrigins, they would compare as equal.
To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar
to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData
objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins
would not be equal but the same unique SecurityOrigin would be. I then used this new
PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of
ClientOrigin. This allows communication between several BroadcastChannels from the same
unique origin, while preventing communication between distinct opaque origins.
When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve
the Network Process at all since the destination can only be in the same WebProcess.
Test: imported/w3c/web-platform-tests/webmessaging/broadcastchannel/opaque-origin.html
- Headers.cmake:
- WebCore.xcodeproj/project.pbxproj:
- dom/BroadcastChannel.cpp: (WebCore::shouldPartitionOrigin): (WebCore::BroadcastChannel::MainThreadBridge::registerChannel): (WebCore::BroadcastChannel::MainThreadBridge::unregisterChannel): (WebCore::BroadcastChannel::MainThreadBridge::postMessage):
- dom/BroadcastChannelRegistry.h:
- loader/EmptyClients.cpp:
- page/PartitionedSecurityOrigin.h: Added. (WebCore::PartitionedSecurityOrigin::PartitionedSecurityOrigin): (WebCore::PartitionedSecurityOrigin::isHashTableDeletedValue const): (WebCore::PartitionedSecurityOrigin::isHashTableEmptyValue const): (WebCore::operator==): (WTF::add): (WTF::PartitionedSecurityOriginHash::hash): (WTF::PartitionedSecurityOriginHash::equal): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::emptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::constructEmptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::isEmptyValue): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::peek): (WTF::HashTraits<WebCore::PartitionedSecurityOrigin>::take):
Source/WebKit:
BroadcastChannel instances in distinct opaque origins can communicate
https://bugs.webkit.org/show_bug.cgi?id=238090
<rdar://problem/90511155>
Reviewed by Alex Christensen.
The issue is that we would use a ClientOrigin to distinguish origins for BroadcastChannel,
which relies on SecurityOriginData internally. A unique/opaque SecurityOrigin becomes an empty
SecurityOriginData upon conversion. As a result, when comparing ClientOrigin objects from
unique SecurityOrigins, they would compare as equal.
To address the issue, I introduced a new PartitionedSecurityOrigin type which is similar
to ClientOrigin but stores SecurityOrigin objects internally, instead of SecurityOriginData
objects. PartitionedSecurityOrigin's operator==() is such that different SecurityOrigins
would not be equal but the same unique SecurityOrigin would be. I then used this new
PartitionedSecurityOrigin type as key in our HashMap on the WebProcess side instead of
ClientOrigin. This allows communication between several BroadcastChannels from the same
unique origin, while preventing communication between distinct opaque origins.
When the PartitionedSecurityOrigin contains an opaque security origin, we don't involve
the Network Process at all since the destination can only be in the same WebProcess.
- WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.cpp: (WebKit::toClientOrigin): (WebKit::WebBroadcastChannelRegistry::registerChannel): (WebKit::WebBroadcastChannelRegistry::unregisterChannel): (WebKit::WebBroadcastChannelRegistry::postMessage): (WebKit::WebBroadcastChannelRegistry::postMessageLocally): (WebKit::WebBroadcastChannelRegistry::postMessageToRemote): (WebKit::WebBroadcastChannelRegistry::networkProcessCrashed):
- WebProcess/WebCoreSupport/WebBroadcastChannelRegistry.h:
Source/WebKitLegacy:
Dust off Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=238121
Reviewed by Yusuke Suzuki.
- PlatformMac.cmake:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:02 PM Changeset in webkit [293371] by
-
- 11 edits in branches/safari-613-branch
Cherry-pick r292274. rdar://problem/80544133
[Cocoa] Automatically relayout the page when new fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>
Reviewed by Chris Dumez.
Source/WebCore:
This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.
FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.
Test: fast/text/install-font-style-recalc.html
- page/Page.cpp: (WebCore::m_contentSecurityPolicyModeForExtension): (WebCore::Page::firstTimeInitialization):
- page/Page.h:
- platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
- platform/graphics/FontCache.h:
Tools:
Make TestRunner::dumpResourceLoadStatistics() clear any currently-recorded statistics.
This avoids the problem where spurious layouts during the time when the page has been created but
before the test has begun record irrelevant statistics.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): (WTR::InjectedBundle::clearResourceLoadStatistics):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::dumpResourceLoadStatistics):
LayoutTests:
- TestExpectations:
- fast/text/install-font-style-recalc-expected.txt: Added.
- fast/text/install-font-style-recalc.html: Added.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:02 PM Changeset in webkit [293370] by
-
- 8 edits2 adds in branches/safari-613-branch
Cherry-pick r292072. rdar://problem/80544133
[Cocoa] Automatically relayout the page when new fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>
Reviewed by Chris Dumez.
Source/WebCore:
This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.
FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.
Test: fast/text/install-font-style-recalc.html
- page/Page.cpp: (WebCore::m_attachmentElementClient):
- platform/graphics/FontCache.cpp: (WebCore::Function<void): (WebCore::FontCache::registerFontCacheInvalidationCallback): (WebCore::FontCache::invalidateAllFontCaches):
- platform/graphics/FontCache.h:
LayoutTests:
- fast/text/install-font-style-recalc-expected.txt: Added.
- fast/text/install-font-style-recalc.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:02 PM Changeset in webkit [293369] by
-
- 2 edits in branches/safari-613-branch/Source
Apply patch. rdar://problem/90968687
- 4:14 PM Changeset in webkit [293368] by
-
- 9 edits in trunk/Source
Web Inspector: request interception should not be guarded based on service workers
https://bugs.webkit.org/show_bug.cgi?id=239677
Reviewed by Patrick Angle.
Source/WebCore:
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::shouldInterceptRequest):
(WebCore::InspectorInstrumentation::interceptRequest):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::shouldInterceptRequestImpl):
- inspector/InspectorInstrumentationWebKit.h:
(WebCore::InspectorInstrumentationWebKit::shouldInterceptRequest):
(WebCore::InspectorInstrumentationWebKit::interceptRequest):
- inspector/InspectorInstrumentationWebKit.cpp:
(WebCore::InspectorInstrumentationWebKit::shouldInterceptRequestInternal):
Pass alongResourceLoaderinstead ofResourceRequestso thatInspectorNetworkAgent::shouldInterceptRequest
can look at the configuration of the load (e.g.serviceWorkerRegistrationIdentifier), not
just the request configuration.
- inspector/agents/InspectorNetworkAgent.h:
- inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::shouldInterceptRequest):
Move the#if ENABLE(SERVICE_WORKER)here.
Source/WebKit:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
Move the#if ENABLE(SERVICE_WORKER)toWebCore::InspectorNetworkAgent::shouldInterceptRequest.
- 3:56 PM Changeset in webkit [293367] by
-
- 4 edits2 adds in trunk
Web Inspector: crash when a subresource is intercepted by a skip network local override with an error status code
https://bugs.webkit.org/show_bug.cgi?id=239675
Reviewed by Patrick Angle.
Source/WebCore:
Test: http/tests/inspector/network/intercept-request-subresource-with-response-error-status-code.html
- inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::interceptRequestWithResponse):
SubresourceLoader::didReceiveResponsewill eventually causereleaseResources(viacancel),
which will clear them_resource, which is needed in order to provide the response content.
We should only provide the response content if we're still processing the load.
LayoutTests:
- http/tests/inspector/network/intercept-request-subresource-with-response-error-status-code.html: Added.
- http/tests/inspector/network/intercept-request-subresource-with-response-error-status-code-expected.txt: Added.
- platform/mac-wk1/TestExpectations:
- 3:55 PM Changeset in webkit [293366] by
-
- 3 edits in branches/safari-614.1.11-branch/Source/WebKit
Cherry-pick r293339. rdar://problem/92283605
Fix the tvOS and watchOS builds after r293231
https://bugs.webkit.org/show_bug.cgi?id=239736
rdar://92283605
Reviewed by Wenson Hsieh.
- UIProcess/API/Cocoa/WKWebView.h:
UIFindInteraction is marked unavailable on watchOS and tvOS.
- UIProcess/API/Cocoa/WKWebView.mm:
Use platform-checks rather than the existing HAVE macro, so that these
methods are still implemented in older builds. There are no version
checks in WKWebView.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:45 PM Changeset in webkit [293365] by
-
- 1 copy in branches/safari-614.1.11-branch
New branch.
- 3:44 PM Changeset in webkit [293364] by
-
- 9 edits in trunk/Source
Versioning.
WebKit-7614.1.12
- 3:24 PM Changeset in webkit [293363] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, fix the macOS Monterey build after r293340
https://bugs.webkit.org/show_bug.cgi?id=239712
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):
Put some of the "Copy Cropped Image" logic here behind ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS), instead of just
ENABLE(IMAGE_ANALYSIS).
- 3:03 PM Changeset in webkit [293362] by
-
- 2 edits in branches/safari-613.2.7.1-branch/Source/WebCore
Cherry-pick r291968. rdar://problem/91681393
AccessibilityObject::listMarkerTextForNodeAndPosition should check for presence of list item before anything else
https://bugs.webkit.org/show_bug.cgi?id=238341
Reviewed by Andres Gonzalez.
The first thing AccessibilityObject::listMarkerTextForNodeAndPosition
does is check to see that the given rangeisStartOfLine. We
should instead check if there's an actual list item to work with
before doing this, sinceisStartOfLinecan cause crashes.
Covered by test
accessibility/mac/attributed-string-with-listitem-multiple-lines.html.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:03 PM Changeset in webkit [293361] by
-
- 2 edits in branches/safari-613.2.7.0-branch/Source/WebCore
Cherry-pick r291968. rdar://problem/91681393
AccessibilityObject::listMarkerTextForNodeAndPosition should check for presence of list item before anything else
https://bugs.webkit.org/show_bug.cgi?id=238341
Reviewed by Andres Gonzalez.
The first thing AccessibilityObject::listMarkerTextForNodeAndPosition
does is check to see that the given rangeisStartOfLine. We
should instead check if there's an actual list item to work with
before doing this, sinceisStartOfLinecan cause crashes.
Covered by test
accessibility/mac/attributed-string-with-listitem-multiple-lines.html.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:35 PM Changeset in webkit [293360] by
-
- 2 edits in branches/safari-613.2.7.3-branch/Source/WebCore
Cherry-pick r290860. rdar://problem/89291570
AX: Protect incoming object with Ref in AXObjectCache::textChanged
https://bugs.webkit.org/show_bug.cgi?id=237475
Reviewed by Chris Fleizach.
This is better practice as ascending the hierarchy could cause
the object to get deleted.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:35 PM Changeset in webkit [293359] by
-
- 1 copy in tags/WebKit-7614.1.9.7
Tag WebKit-7614.1.9.7.
- 2:33 PM Changeset in webkit [293358] by
-
- 9 edits in branches/safari-613.2.7.3-branch/Source
Versioning.
WebKit-7613.2.7.3.1
- 2:28 PM Changeset in webkit [293357] by
-
- 2 edits in branches/safari-613.2.7.2-branch/Source/WebCore
Cherry-pick r290860. rdar://problem/89291570
AX: Protect incoming object with Ref in AXObjectCache::textChanged
https://bugs.webkit.org/show_bug.cgi?id=237475
Reviewed by Chris Fleizach.
This is better practice as ascending the hierarchy could cause
the object to get deleted.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:27 PM Changeset in webkit [293356] by
-
- 9 edits in branches/safari-613.2.7.2-branch/Source
Versioning.
WebKit-7613.2.7.2.1
- 2:25 PM Changeset in webkit [293355] by
-
- 9 edits in branches/safari-614.1.9-branch/Source
Versioning.
WebKit-7614.1.9.7
- 2:24 PM Changeset in webkit [293354] by
-
- 2 edits in branches/safari-613.2.7.1-branch/Source/WebCore
Cherry-pick r290860. rdar://problem/89291570
AX: Protect incoming object with Ref in AXObjectCache::textChanged
https://bugs.webkit.org/show_bug.cgi?id=237475
Reviewed by Chris Fleizach.
This is better practice as ascending the hierarchy could cause
the object to get deleted.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:18 PM Changeset in webkit [293353] by
-
- 2 edits in branches/safari-613.2.7.0-branch/Source/WebCore
Revert r293286. rdar://problem/92198272
This reverts r293343.
- 2:18 PM Changeset in webkit [293352] by
-
- 2 edits in branches/safari-613.2.7.0-branch/Source/WebCore
Cherry-pick r290860. rdar://problem/89291570
AX: Protect incoming object with Ref in AXObjectCache::textChanged
https://bugs.webkit.org/show_bug.cgi?id=237475
Reviewed by Chris Fleizach.
This is better practice as ascending the hierarchy could cause
the object to get deleted.
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::textChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:59 PM Changeset in webkit [293351] by
-
- 1 copy in tags/WebKit-7614.1.9.6
Tag WebKit-7614.1.9.6.
- 1:59 PM Changeset in webkit [293350] by
-
- 9 edits in branches/safari-613.2.7.1-branch/Source
Versioning.
WebKit-7613.2.7.1.3
- 1:57 PM Changeset in webkit [293349] by
-
- 9 edits in branches/safari-614.1.9-branch/Source
Versioning.
WebKit-7614.1.9.6
- 1:55 PM Changeset in webkit [293348] by
-
- 8 edits in trunk
[JSC] Enable change-array-by-copy
https://bugs.webkit.org/show_bug.cgi?id=239678
Reviewed by Saam Barati.
- Source/JavaScriptCore/runtime/OptionsList.h:
Canonical link: https://commits.webkit.org/249964@main
- 1:52 PM Changeset in webkit [293347] by
-
- 2 edits in branches/safari-613.2.7.1-branch/Source/WebCore
Cherry-pick r292430. rdar://problem/92204558
[Cocoa] Video is sometimes not visible after r292049
https://bugs.webkit.org/show_bug.cgi?id=238826
Reviewed by Jer Noble.
RenderVideo::willBeDestroyed calls MediaPlayer::setPageIsVisible, which causes
MediaPlayerPrivateAVFoundationObjC::platformSetVisible to hide the AVPlayerLayer.
HTMLMediaElement::visibilityStateChanged is the only other thing that calls
MediaPlayer::setPageIsVisible, and it only calls it when the page visibility changes,
so if that doesn't happen the AVPlayerLayer is not shown when the renderer is
recreated.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::willBeDestroyed): Don't call MediaPlayer::setPageIsVisible(false), the page visibility has not changed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:52 PM Changeset in webkit [293346] by
-
- 2 edits in branches/safari-613.2.7.1-branch/Source/WebCore
Cherry-pick r293286. rdar://problem/92198272
Crash under AsyncScrollingCoordinator::scrollingThreadAddedPendingUpdate()
https://bugs.webkit.org/show_bug.cgi?id=239683
<rdar://92198272>
Reviewed by Alan Bujtas.
Crash data suggest that m_page can be null in
AsyncScrollingCoordinator::scheduleRenderingUpdate(), which does seem possible because
scheduleRenderingUpdate() is a dispatch from the scrolling thread, and
ScrollingCoordinator::pageDestroyed() may have run before it runs.
- page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::scheduleRenderingUpdate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:49 PM Changeset in webkit [293345] by
-
- 6 edits2 adds in trunk
AX: Don't expose aria-roledescription value on "generic" elements (e.g. div and span) unless explicit role value is also defined
https://bugs.webkit.org/show_bug.cgi?id=174248
<rdar://problem/33178050>
Reviewed by Andres Gonzalez.
Source/WebCore:
ARIA spec states to not expose the role description on "generic" elements.
https://www.w3.org/TR/wai-aria/#aria-roledescription
Test: accessibility/ignored-aria-role-description.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsARIARoleDescription const):
(WebCore::AccessibilityObject::roleDescription const):
- accessibility/AccessibilityObject.h:
LayoutTests:
- accessibility/ignored-aria-role-description-expected.txt: Added.
- accessibility/ignored-aria-role-description.html: Added.
- 1:48 PM Changeset in webkit [293344] by
-
- 2 edits in branches/safari-613.2.7.0-branch/Source/WebCore
Cherry-pick r292430. rdar://problem/92204558
[Cocoa] Video is sometimes not visible after r292049
https://bugs.webkit.org/show_bug.cgi?id=238826
Reviewed by Jer Noble.
RenderVideo::willBeDestroyed calls MediaPlayer::setPageIsVisible, which causes
MediaPlayerPrivateAVFoundationObjC::platformSetVisible to hide the AVPlayerLayer.
HTMLMediaElement::visibilityStateChanged is the only other thing that calls
MediaPlayer::setPageIsVisible, and it only calls it when the page visibility changes,
so if that doesn't happen the AVPlayerLayer is not shown when the renderer is
recreated.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::willBeDestroyed): Don't call MediaPlayer::setPageIsVisible(false), the page visibility has not changed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:44 PM Changeset in webkit [293343] by
-
- 2 edits in branches/safari-613.2.7.0-branch/Source/WebCore
Cherry-pick r293286. rdar://problem/92198272
Crash under AsyncScrollingCoordinator::scrollingThreadAddedPendingUpdate()
https://bugs.webkit.org/show_bug.cgi?id=239683
<rdar://92198272>
Reviewed by Alan Bujtas.
Crash data suggest that m_page can be null in
AsyncScrollingCoordinator::scheduleRenderingUpdate(), which does seem possible because
scheduleRenderingUpdate() is a dispatch from the scrolling thread, and
ScrollingCoordinator::pageDestroyed() may have run before it runs.
- page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::scheduleRenderingUpdate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:36 PM Changeset in webkit [293342] by
-
- 9 edits in branches/safari-613.2.7.0-branch/Source
Versioning.
WebKit-7613.2.7.0.2
- 1:09 PM Changeset in webkit [293341] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
Fix duplicate headers warning in libwebrtc Copy Headers phase
https://bugs.webkit.org/show_bug.cgi?id=239415
Reviewed by Sam Weinig.
- libwebrtc.xcodeproj/project.pbxproj:
Remove and re-add these files (Xcode won't delete just one copy of them,
because they have the same identifiers).
- 1:00 PM Changeset in webkit [293340] by
-
- 5 edits in trunk/Source/WebKit
[macOS] Only show a context menu action to "Copy Cropped Image" when appropriate
https://bugs.webkit.org/show_bug.cgi?id=239712
rdar://92239384
Reviewed by Darin Adler.
Implement gating for the "Copy Cropped Image" context menu item. This is similar to the current gating mechanism
used for visual look up, wherein the Look Up menu item is asynchronously appended to the context menu.
In this case, we only append the "Copy Cropped Image" menu item in the case where
requestImageAnalysisMarkup
completes with a non-null result.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::contextMenuItemSelected):
- UIProcess/WebPageProxy.h:
Cache the image analysis results for "Copy Cropped Image" in a member variable,
m_croppedImageForContextMenu.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setCroppedImageForContextMenu):
(WebKit::WebPageProxy::handleContextMenuCopyCroppedImage):
- 12:58 PM Changeset in webkit [293339] by
-
- 3 edits in trunk/Source/WebKit
Fix the tvOS and watchOS builds after r293231
https://bugs.webkit.org/show_bug.cgi?id=239736
rdar://92283605
Reviewed by Wenson Hsieh.
- UIProcess/API/Cocoa/WKWebView.h:
UIFindInteraction is marked unavailable on watchOS and tvOS.
- UIProcess/API/Cocoa/WKWebView.mm:
Use platform-checks rather than the existing HAVE macro, so that these
methods are still implemented in older builds. There are no version
checks in WKWebView.h.
- 12:54 PM Changeset in webkit [293338] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: response overrides with an error status code should indicate that somewhere
https://bugs.webkit.org/show_bug.cgi?id=239676
Reviewed by Patrick Angle.
- UserInterface/Views/LocalResourceOverrideTreeElement.js:
(WI.LocalResourceOverrideTreeElement.prototype.updateStatus):
Also have theWI.LocalResourceOverrideTreeElementadd/remove the"error"CSS class
depening on the state of the relatedWI.LocalResource(which is what's done for "regular"
WI.ResourceTreeElementandWI.Resource).
- 12:09 PM Changeset in webkit [293337] by
-
- 4 edits in trunk/Source/WebCore
Unprefix html.css, fullscreen.css and pdfjs-extras
https://bugs.webkit.org/show_bug.cgi?id=239725
Reviewed by Brent Fulgham.
Use unprefixed versions of CSS values & properties.
Excluded text-align: -webkit-center which has different behavior than text-align: center.
- Modules/pdfjs-extras/adwaita/style.css:
(.dropdownToolbarButton > select):
- css/fullscreen.css:
(:-webkit-full-screen-ancestor:not(iframe)):
- css/html.css:
(input, textarea, select, button, meter, progress):
(#if defined(ENABLE_DATE_AND_TIME_INPUT_TYPES) && ENABLE_DATE_AND_TIME_INPUT_TYPES):
(input::-webkit-credentials-auto-fill-button):
(input::-webkit-contacts-auto-fill-button):
(input::-webkit-credit-card-auto-fill-button):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-arrow):
- 11:49 AM Changeset in webkit [293336] by
-
- 1 copy in tags/WebKit-7613.2.7.1.2
Tag WebKit-7613.2.7.1.2.
- 11:33 AM Changeset in webkit [293335] by
-
- 9 edits in branches/safari-613.2.7.1-branch/Source
Versioning.
WebKit-7613.2.7.1.2
- 11:29 AM Changeset in webkit [293334] by
-
- 59 edits in trunk/Source/WebInspectorUI
Web Inspector: Unprefix CSS properties in source code
https://bugs.webkit.org/show_bug.cgi?id=239517
Reviewed by Patrick Angle.
Properties:
-webkit-appearance
-webkit-mask-image
-webkit-clip-path
-webkit-text-decoration-*
-webkit-user-select
Values:
cursor: -webkit-grab/grabbing
-webkit-fill-available
JS Properties:
webkitTransform
Media queries:
-webkit-device-pixel-ratio
-webkit-min-device-pixel-ratio
-webkit-max-device-pixel-ratio
Also used shorthand properties there and there.
- UserInterface/Debug/UncaughtExceptionReporter.css:
(.sheet-container):
(.uncaught-exception-sheet li):
- UserInterface/Views/AuditTestCaseContentView.css:
(.content-view.audit-test-case > section table > tr > td > :not(.tree-outline)):
- UserInterface/Views/AuditTestContentView.css:
(.content-view.audit-test.manager-editing > header :is(.name, .description)[contenteditable]):
- UserInterface/Views/BoxShadowEditor.css:
(.box-shadow-editor > table > tr > td > input[type="text"]):
- UserInterface/Views/BreakpointActionView.css:
(.breakpoint-action-eval-editor):
- UserInterface/Views/BreakpointPopover.css:
(.popover .edit-breakpoint-popover-content > table > tr.condition > td > .editor):
- UserInterface/Views/BreakpointTreeElement.css:
(.item.breakpoint .status > .status-image.auto-continue::after):
- UserInterface/Views/CPUTimelineView.css:
(.timeline-view.cpu > .content > .overview .legend):
(.timeline-view.cpu > .content > .overview > .chart > .container.stats):
- UserInterface/Views/CPUUsageCombinedView.css:
(.cpu-usage-combined-view > .details):
- UserInterface/Views/ChangesDetailsSidebarPanel.css:
(.sidebar > .panel.changes-panel .css-rule):
- UserInterface/Views/CodeMirrorOverrides.css:
(.CodeMirror-linewidget):
- UserInterface/Views/ColorSquare.css:
(@media (-webkit-device-pixel-ratio: 1) .color-square > .srgb-edge): Deleted.
- UserInterface/Views/ComputedStyleSection.css:
(.computed-style-section):
(.computed-style-section .computed-property-item .disclosure-button):
- UserInterface/Views/ConsoleMessageView.css:
(.console-user-command.special-user-log > .console-message-body):
(.console-message-body > span):
(.console-message-body > span > :matches(.console-message-enclosed, .console-message-preview, .console-message-preview-divider)):
(.console-message .console-message-extra-parameters-container > li,):
(.console-user-command > .console-message-body):
- UserInterface/Views/CookiePopover.css:
(.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"])):
- UserInterface/Views/DOMEventsBreakdownView.css:
(.waterfall-popover-content .dom-events-breakdown):
- UserInterface/Views/DOMTreeOutline.css:
(.tree-outline.dom.non-selectable):
(.tree-outline.dom li .selection-area):
- UserInterface/Views/DatabaseContentView.css:
(:matches(.database-user-query, .database-query-result)::before):
(.database-query-text):
(.database-query-result.error):
(.database-query-result.no-results):
- UserInterface/Views/DetailsSection.css:
(.details-section > .content > .group > .row.simple > .value):
(.details-section > .content > .group > .row.text):
(@media (-webkit-min-device-pixel-ratio: 2) .details-section,): Deleted.
- UserInterface/Views/Editing.css:
(.editing):
- UserInterface/Views/EventBreakpointPopover.css:
(.popover .edit-breakpoint-popover-content .event input):
- UserInterface/Views/FilterBar.css:
(:matches(.filter-bar, .search-bar) > input[type="search"]):
(:matches(.filter-bar, .search-bar) > input[type="search"]::-webkit-search-decoration):
- UserInterface/Views/FindBanner.css:
(.find-banner > input[type="search"]):
(.find-banner > button):
- UserInterface/Views/FontResourceContentView.css:
(.content-view.resource.font .preview > .line > .content):
- UserInterface/Views/FormattedValue.css:
(.formatted-node > .tree-outline.dom li):
- UserInterface/Views/GeneralStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content ~ .options-container > .filter-bar):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle):
- UserInterface/Views/GoToLineDialog.css:
(.go-to-line-dialog > div > input):
- UserInterface/Views/GradientEditor.css:
(.gradient-editor > .gradient-angle > input::-webkit-inner-spin-button):
- UserInterface/Views/GradientSlider.js:
(WI.GradientSliderKnob.prototype._updateTransform):
(WI.GradientSliderKnob):
- UserInterface/Views/ImageResourceContentView.css:
(.content-view.resource.image img):
- UserInterface/Views/IndexedDatabaseContentView.css:
(.indexed-database.content-view):
- UserInterface/Views/InlineSwatch.css:
(@media (-webkit-max-device-pixel-ratio: 1) .inline-swatch): Deleted.
- UserInterface/Views/InputPopover.css:
(.popover .input-popover-content > .editor):
- UserInterface/Views/LocalResourceOverrideLabelView.css:
(.local-resource-override-label-view > div > .url):
- UserInterface/Views/LocalResourceOverridePopover.css:
(.popover .local-resource-override-popover-content .editor):
- UserInterface/Views/Main.css:
(body):
(input[type=range]):
(.message-text-view):
(.resource-link,):
(.go-to-arrow):
(.css-documentation-button):
(.search-settings):
(.expand-list-button):
(.bouncy-highlight):
(@media (-webkit-device-pixel-ratio: 1) .reference-page-link): Deleted.
- UserInterface/Views/NetworkResourceDetailView.css:
(.content-view.resource-details):
- UserInterface/Views/NetworkTableContentView.css:
(.network-table > .statistics > .statistic > .text):
- UserInterface/Views/ObjectTreeView.css:
(.tree-outline.object li):
- UserInterface/Views/OpenResourceDialog.css:
(.open-resource-dialog > .field > input):
- UserInterface/Views/RecordingContentView.css:
(.content-view.recording > .preview-container):
- UserInterface/Views/ResourceCookiesContentView.css:
(.resource-cookies .table > .header):
- UserInterface/Views/ResourceHeadersContentView.css:
(.resource-headers .go-to-link):
(.resource-headers .call-stack):
- UserInterface/Views/ResourceTimingBreakdownView.css:
(.waterfall-popover-content .resource-timing-breakdown):
- UserInterface/Views/ResourceTreeElement.css:
(.item.resource.resource-type-websocket .status > .ready-state):
- UserInterface/Views/ScopeChainDetailsSidebarPanel.css:
(.watch-expression-editor):
- UserInterface/Views/Slider.css:
(@media (-webkit-min-device-pixel-ratio: 2) .slider): Deleted.
- UserInterface/Views/SourceCodeTextEditor.css:
(.source-code.text-editor > .CodeMirror .line-indicator-widget.inline):
(@media (-webkit-min-device-pixel-ratio: 2) .popover .debugger-popover-content > .body): Deleted.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(.spreadsheet-style-declaration-editor):
(.spreadsheet-style-declaration-editor > .property:matches(.invalid-name, .other-vendor, .overridden):not(.disabled) > .content > *:not(.name, .value-container),):
(.spreadsheet-style-declaration-editor > .property.invalid-name:not(.disabled) > .content > *:not(.name, .value-container),):
(body:not(.meta-key-pressed) .spreadsheet-style-declaration-editor > .property.invalid-value:not(.disabled) > .content .value:not(.editing),):
(.spreadsheet-style-declaration-editor .property.has-warning .warning):
- UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:
(.spreadsheet-css-declaration):
(.spreadsheet-css-declaration.selecting,):
(.spreadsheet-css-declaration .selector > .icon):
- UserInterface/Views/SpringEditor.css:
(.spring-editor > .number-input-container > .number-input-row > input::-webkit-inner-spin-button):
- UserInterface/Views/TextEditor.css:
(.text-editor > .CodeMirror .has-breakpoint .CodeMirror-linenumber::before):
(.text-editor > .CodeMirror .breakpoint-auto-continue:not(.execution-line.primary) .CodeMirror-linenumber::after):
- UserInterface/Views/TimelineRecordFrame.css:
(.timeline-record-frame.tall):
- UserInterface/Views/TimelineRuler.css:
(.timeline-ruler:not(.disabled, .resizing-selection) > .selection-drag):
(.timeline-ruler:not(.disabled, .resizing-selection) > .selection-drag:active):
- UserInterface/Views/TreeOutline.css:
(.tree-outline .item .disclosure-button):
- UserInterface/Views/TypeTreeElement.css:
(.item.type-tree-element > .disclosure-button):
- UserInterface/Views/TypeTreeView.css:
(.tree-outline.type li):
- UserInterface/Views/URLBreakpointPopover.css:
(.popover .edit-breakpoint-popover-content .url .editor):
(@media (prefers-color-scheme: dark) .popover .edit-breakpoint-popover-content .url .editor):
- 11:25 AM Changeset in webkit [293333] by
-
- 4 edits2 adds in trunk
[CSS Typed OM] Fix AttributeStyleMap.get for list values
https://bugs.webkit.org/show_bug.cgi?id=239716
Reviewed by Alan Bujtas.
Source/WebCore:
Test: css-typedom/typed-om-perspective-value.html
- css/typedom/CSSStyleValueFactory.cpp:
(WebCore::CSSStyleValueFactory::reifyValue):
The list here hasn't been deep copied. Don't move away a member.
- css/typedom/CSSStyleValueFactory.h:
Passing Ref<>&& instead of Ref<> here is a bug-prone over-optimization.
LayoutTests:
- css-typedom/typed-om-perspective-value-expected.txt: Added.
- css-typedom/typed-om-perspective-value.html: Added.
- 11:19 AM Changeset in webkit [293332] by
-
- 7 edits in trunk/Source/WebCore
Unprefix modern-media-controls CSS properties
https://bugs.webkit.org/show_bug.cgi?id=239726
Reviewed by Eric Carlson.
- Modules/modern-media-controls/controls/button.css:
(button):
(button > picture):
- Modules/modern-media-controls/controls/button.js:
(Button.prototype.commitProperty):
- Modules/modern-media-controls/controls/media-controls.css:
(.media-controls > *):
- Modules/modern-media-controls/controls/slider.css:
(.slider > input):
(.ios .slider > input):
(.slider > input::-webkit-slider-thumb):
- Modules/modern-media-controls/controls/text-tracks.css:
(video::-webkit-media-text-track-container):
- Modules/modern-media-controls/controls/watchos-activity-indicator.css:
(button.watchos-activity-indicator > picture):
- 10:58 AM Changeset in webkit [293331] by
-
- 2 edits in trunk/Tools
[build.webkit.org] Use GitHub checkouts (Follow-up)
https://bugs.webkit.org/show_bug.cgi?id=239072
<rdar://problem/91567092>
Unreviewed follow-up fix.
- Tools/CISupport/build-webkit-org/steps.py:
(CheckOutSource.init): Use the specified commit, not the latest.
- 10:20 AM WebKitGTK/2.36.x edited by
- (diff)
- 9:41 AM Changeset in webkit [293330] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Remove unused rtc variable
https://bugs.webkit.org/show_bug.cgi?id=239727
Reviewed by Philippe Normand.
- Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::addTrack):
- 9:10 AM Changeset in webkit [293329] by
-
- 35 edits5 adds in trunk
Web Locks held in a Worker are not released on page refresh or exit
https://bugs.webkit.org/show_bug.cgi?id=239614
<rdar://problem/92173575>
Reviewed by Alex Christensen.
Before a web worker olding a lock would terminate, WebLockManager::stop() would get called
and it would attempt to release all locks held by the worker. However, because we're off
the main thread and because the lock registry was held by the Page on the main thread,
we would rely on a call toworkerLoaderProxy().postTaskToLoader()to get back to the
main thread and access the lock registry via the Document's page. However, this wasn't
reliable because the task posted to postTaskToLoader() could get dropped if the worker's
Document is also going away (which is the case when reloading or navigating away).
To address the issue, the WebLockRegistry can now be accessed directly (on the main thread),
without having to go through a Page. As a result, we can simply do a callOnMainThread()
and then access WebLockRegistry::shared(), which is always reliable. To maintain the
previous behavior for WebKitLegacy, I also partitioned the WebLockRegistry per sessionID
since we don't want views sharing the same locks if one is using the default session and
the other is using a private session. This wasn't an issue for modern WebKit since there
is a single session per WebProcess.
To achieve this, I had to made sure that WorkerOrWorkletGlobalScope::sessionID() was returning
a valid value. This worked for ServiceWorkerGlobalScope but not for other types or workers /
worklets global scopes.
Test: workers/worker-web-lock-released-on-reload.html
- Source/WebKit/UIProcess/WebLockRegistryProxy.cpp:
(WebKit::WebLockRegistryProxy::requestLock):
(WebKit::WebLockRegistryProxy::releaseLock):
(WebKit::WebLockRegistryProxy::abortLockRequest):
(WebKit::WebLockRegistryProxy::snapshot):
(WebKit::WebLockRegistryProxy::clientIsGoingAway):
- Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::installServiceWorker):
- Source/WebKit/WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp:
(WebKit::WebSharedWorkerContextManagerConnection::launchSharedWorker):
- Source/WebKit/WebProcess/WebCoreSupport/RemoteWebLockRegistry.cpp:
(WebKit::RemoteWebLockRegistry::requestLock):
(WebKit::RemoteWebLockRegistry::releaseLock):
(WebKit::RemoteWebLockRegistry::abortLockRequest):
(WebKit::RemoteWebLockRegistry::snapshot):
(WebKit::RemoteWebLockRegistry::clientIsGoingAway):
- Source/WebKit/WebProcess/WebCoreSupport/RemoteWebLockRegistry.h:
- Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_appHighlightsVisible):
- Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- Source/WebKit/WebProcess/WebProcess.h:
(WebKit::WebProcess::broadcastChannelRegistry):
(WebKit::WebProcess::webLockRegistry): Deleted.
- Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(getOrCreateWebLockRegistry): Deleted.
- Source/WebKitLegacy/win/WebView.cpp:
(WebView::initWithFrame):
(getOrCreateWebLockRegistry): Deleted.
Test: workers/worker-web-lock-released-on-reload.html
- Source/WebCore/Modules/web-locks/WebLockManager.cpp:
(WebCore::WebLockManager::MainThreadBridge::create):
(WebCore::WebLockManager::MainThreadBridge::MainThreadBridge):
(WebCore::WebLockManager::MainThreadBridge::requestLock):
(WebCore::WebLockManager::MainThreadBridge::releaseLock):
(WebCore::WebLockManager::MainThreadBridge::abortLockRequest):
(WebCore::WebLockManager::MainThreadBridge::query):
(WebCore::WebLockManager::MainThreadBridge::clientIsGoingAway):
(WebCore::WebLockManager::MainThreadBridge::ensureOnMainThread): Deleted.
- Source/WebCore/Modules/web-locks/WebLockRegistry.cpp:
(WebCore::sharedRegistry):
(WebCore::WebLockRegistry::shared):
(WebCore::WebLockRegistry::setSharedRegistry):
(WebCore::LocalWebLockRegistry::ensureRegistryForOrigin):
(WebCore::LocalWebLockRegistry::existingRegistryForOrigin const):
(WebCore::LocalWebLockRegistry::PerOriginRegistry::create):
(WebCore::LocalWebLockRegistry::PerOriginRegistry::PerOriginRegistry):
(WebCore::LocalWebLockRegistry::PerOriginRegistry::~PerOriginRegistry):
(WebCore::LocalWebLockRegistry::requestLock):
(WebCore::LocalWebLockRegistry::releaseLock):
(WebCore::LocalWebLockRegistry::abortLockRequest):
(WebCore::LocalWebLockRegistry::snapshot):
(WebCore::LocalWebLockRegistry::clientIsGoingAway):
(WebCore::LocalWebLockRegistry::clientsAreGoingAway):
- Source/WebCore/Modules/web-locks/WebLockRegistry.h:
- Source/WebCore/Modules/webaudio/AudioWorkletMessagingProxy.cpp:
(WebCore::generateWorkletParameters):
- Source/WebCore/dom/Document.h:
- Source/WebCore/loader/EmptyClients.cpp:
(WebCore::pageConfigurationWithEmptyClients):
- Source/WebCore/page/Page.cpp:
(WebCore::Page::Page):
- Source/WebCore/page/Page.h:
(WebCore::Page::webLockRegistry): Deleted.
- Source/WebCore/page/PageConfiguration.cpp:
(WebCore::PageConfiguration::PageConfiguration):
- Source/WebCore/page/PageConfiguration.h:
- Source/WebCore/workers/Worker.cpp:
(WebCore::Worker::notifyFinished):
- Source/WebCore/workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
- Source/WebCore/workers/WorkerGlobalScopeProxy.h:
- Source/WebCore/workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
- Source/WebCore/workers/WorkerMessagingProxy.h:
- Source/WebCore/workers/WorkerOrWorkletGlobalScope.cpp:
(WebCore::WorkerOrWorkletGlobalScope::WorkerOrWorkletGlobalScope):
- Source/WebCore/workers/WorkerOrWorkletGlobalScope.h:
(WebCore::WorkerOrWorkletGlobalScope::WorkerOrWorkletGlobalScope):
- Source/WebCore/workers/WorkerThread.h:
- Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::create):
(WebCore::ServiceWorkerGlobalScope::ServiceWorkerGlobalScope):
- Source/WebCore/workers/service/ServiceWorkerGlobalScope.h:
- Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::createWorkerGlobalScope):
- Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp:
(WebCore::generateWorkerParameters):
- Source/WebCore/worklets/WorkletGlobalScope.cpp:
(WebCore::WorkletGlobalScope::WorkletGlobalScope):
- Source/WebCore/worklets/WorkletParameters.h:
(WebCore::WorkletParameters::isolatedCopy const):
(WebCore::WorkletParameters::isolatedCopy):
- LayoutTests/workers/resources/worker-web-lock-released-on-reload-popup.html: Added.
- LayoutTests/workers/resources/worker-web-lock-released-on-reload-worker.js: Added.
- LayoutTests/workers/worker-web-lock-released-on-reload-expected.txt: Added.
- LayoutTests/workers/worker-web-lock-released-on-reload.html: Added.
Canonical link: https://commits.webkit.org/249952@main
- 8:37 AM Changeset in webkit [293328] by
-
- 2 edits in trunk/Source/WebKit
[GLIB] Default-handle recently-added ProcessTerminationReason values
https://bugs.webkit.org/show_bug.cgi?id=239720
Reviewed by Philippe Normand.
- UIProcess/API/glib/WebKitNavigationClient.cpp: Add a couple of
new values for ProcessTerminationReason that were added on r292912
to silent some compile-time warnings.
- 8:25 AM Changeset in webkit [293327] by
-
- 4 edits in trunk/Tools
[ews-build.webkit.org] Support alternative remotes
https://bugs.webkit.org/show_bug.cgi?id=239617
<rdar://problem/92115230>
Reviewed by Aakash Jain.
- Tools/CISupport/ews-build/events.py:
(GitHubEventHandlerNoEdits):
(GitHubEventHandlerNoEdits.extractProperties): Remove sensative fields from non-public
pull requests.
(GitHubEventHandlerNoEdits.handle_pull_request): Generalize label process sleep.
- Tools/CISupport/ews-build/steps.py:
(CheckOutPullRequest.run): Checkout with EWS credentials.
- Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249949@main
- 8:25 AM Changeset in webkit [293326] by
-
- 81 edits in trunk
Replace String::replace() functions with makeStringByReplacingAll() free functions
https://bugs.webkit.org/show_bug.cgi?id=239685
Reviewed by Darin Adler.
Replace String::replace() functions with makeStringByReplacingAll() free functions.
"All" is added to the name since every instance is replaced, not just the first one.
Making it a free function that returns a new String is a step towards making String
immutable.
In the future, we may want to add a makeStringByReplacingAll() that takes in a
StringView instead of aconst String. Some call sites would benefit from that.
- Tools/TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:
(AppleLanguagesTest::AppleLanguagesTest):
- Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::attributedStringForRange):
- Source/JavaScriptCore/inspector/agents/InspectorAuditAgent.cpp:
(Inspector::InspectorAuditAgent::run):
- Source/JavaScriptCore/jit/ExecutableAllocator.cpp:
(JSC::dumpJITMemory):
- Source/JavaScriptCore/runtime/TypeProfiler.cpp:
(JSC::TypeProfiler::logTypesForTypeLocation):
- Source/JavaScriptCore/runtime/TypeSet.cpp:
(JSC::StructureShape::propertyHash):
- Source/JavaScriptCore/yarr/RegularExpression.cpp:
(JSC::Yarr::replace):
- Source/WebCore/PAL/pal/text/TextCodecICU.cpp:
(PAL::TextCodecICU::encode const):
- Source/WebKit/NetworkProcess/DatabaseUtilities.cpp:
(WebKit::DatabaseUtilities::stripIndexQueryToMatchStoredValue):
- Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::escapeForJSON):
- Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:
(webkit_web_context_set_preferred_languages):
- Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::insertText):
- Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):
- Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:
(WebKit::WebResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
- Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm:
(matchLabelsAgainstString):
- Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(-[WebHTMLView insertText:]):
- Source/WebKitLegacy/win/DOMHTMLClasses.cpp:
(DOMHTMLInputElement::replaceCharactersInRange):
- Source/WebKitLegacy/win/WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
- Source/WebKitLegacy/win/WebLocalizableStrings.cpp:
(LocalizedString::operator LPCTSTR const):
- Source/WTF/wtf/Language.cpp:
(WTF::canonicalLanguageIdentifier):
- Source/WTF/wtf/URLHelpers.cpp:
(WTF::URLHelpers::mapHostNames):
- Source/WTF/wtf/URLParser.cpp:
(WTF::URLParser::parseURLEncodedForm):
- Source/WTF/wtf/text/StringView.h:
(WTF::makeStringByReplacingAll):
(WTF::makeStringByReplacing):
(WTF::String::replace): Deleted.
- Source/WTF/wtf/text/WTFString.h:
(WTF::makeStringByReplacingAll):
(WTF::String::replace): Deleted.
- Source/WTF/wtf/unix/LanguageUnix.cpp:
(WTF::platformLanguage):
- Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::encodeDatabaseName):
(WebCore::IDBServer::SQLiteIDBBackingStore::decodeDatabaseName):
- Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::setConfiguration):
- Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::queryKeysAndValues):
- Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineDropEffects const):
- Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:
(WebCore::AccessibilityAtspi::registerRoot):
(WebCore::AccessibilityAtspi::registerObject):
(WebCore::AccessibilityAtspi::registerHyperlink):
- Source/WebCore/contentextensions/ContentExtensionActions.cpp:
(WebCore::ContentExtensions::RedirectAction::RegexSubstitutionAction::applyToURL const):
- Source/WebCore/contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::getDomainList):
- Source/WebCore/css/parser/CSSTokenizer.cpp:
(WebCore::CSSTokenizer::preprocessString):
- Source/WebCore/display/css/DisplayTextBox.cpp:
(WebCore::Display::TextBox::debugDescription const):
- Source/WebCore/dom/Document.cpp:
(WebCore::Document::displayStringModifiedByEncoding const):
- Source/WebCore/dom/Node.cpp:
(WebCore::Node::showNode const):
- Source/WebCore/dom/Text.cpp:
(WebCore::appendTextRepresentation):
- Source/WebCore/dom/ViewportArguments.cpp:
(WebCore::viewportErrorMessage):
- Source/WebCore/editing/EditingStyle.cpp:
(WebCore::StyleChange::extractTextStyles):
- Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::selectedText const):
- Source/WebCore/editing/FrameSelection.cpp:
(WebCore::FrameSelection::debugRenderer const):
- Source/WebCore/editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):
- Source/WebCore/editing/TextIterator.cpp:
(WebCore::foldQuoteMarks):
- Source/WebCore/editing/VisibleUnits.cpp:
(WebCore::charactersAroundPosition):
- Source/WebCore/editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::stringSelectionForPasteboard):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
- Source/WebCore/editing/cocoa/HTMLConverter.mm:
(WebCore::editingAttributedString):
- Source/WebCore/editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::takeResults):
(WebCore::createFragmentFromText):
- Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::setInnerText):
- Source/WebCore/html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setValueCommon):
- Source/WebCore/html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setRangeText):
- Source/WebCore/html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::LinkRelAttribute):
- Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
- Source/WebCore/html/URLDecomposition.cpp:
(WebCore::URLDecomposition::setSearch):
- Source/WebCore/inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle):
- Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::outputLayoutBox):
- Source/WebCore/loader/FormSubmission.cpp:
(WebCore::appendMailtoPostFormDataToURL):
(WebCore::encodingFromAcceptCharset):
- Source/WebCore/page/Frame.cpp:
(WebCore::matchLabelsAgainstString):
- Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::imageTitle):
(WebCore::webCryptoMasterKeyKeychainLabel):
- Source/WebCore/platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:
(WebCore::AVStreamDataParserMIMETypeCache::canDecodeExtendedType):
- Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::configureDownloadBuffer):
- Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::handleStateChangeMessage):
- Source/WebCore/platform/gtk/SelectionData.cpp:
(WebCore::replaceNonBreakingSpaceWithSpace):
- Source/WebCore/platform/mediastream/gstreamer/GStreamerDisplayCaptureDeviceManager.cpp:
(WebCore::GStreamerDisplayCaptureDeviceManager::createDisplayCaptureSource):
- Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::sanitizeSuggestedFilename):
- Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::createSoupURI const):
- Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::sanitizeFilename):
- Source/WebCore/platform/text/DateTimeFormat.cpp:
(WebCore::DateTimeFormat::quoteAndAppendLiteral):
- Source/WebCore/platform/text/LocaleToScriptMapping.cpp:
(WebCore::localeToScriptCodeForFontSelection):
- Source/WebCore/platform/text/hyphen/HyphenationLibHyphen.cpp:
(WebCore::scanDirectoryForDictionaries):
- Source/WebCore/platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::shortMonthFormat):
- Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::replaceNBSPWithSpace):
- Source/WebCore/rendering/LegacyInlineTextBox.cpp:
(WebCore::LegacyInlineTextBox::outputLineBox const):
- Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateSecurityDiscCharacters):
- Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::outputRenderObject const):
- Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::setRenderedText):
- Source/WebCore/rendering/svg/RenderSVGInlineText.cpp:
(WebCore::applySVGWhitespaceRules):
- Source/WebCore/xml/XSLTProcessor.cpp:
(WebCore::transformTextStringToXHTMLDocumentString):
Canonical link: https://commits.webkit.org/249949@main
- 7:12 AM Changeset in webkit [293325] by
-
- 1 edit in trunk/Tools/CISupport/build-webkit-org/config.json
[build.webkit.org] Delete builddir key from config.json
https://bugs.webkit.org/show_bug.cgi?id=239718
Reviewed by Jonathan Bedard.
- Tools/CISupport/build-webkit-org/config.json:
Canonical link: https://commits.webkit.org/249948@main
- 6:58 AM Changeset in webkit [293324] by
-
- 2 edits in trunk/Source/JavaScriptCore
[GLIB] Remove leftover unused variable from r292929
https://bugs.webkit.org/show_bug.cgi?id=239715
Reviewed by Philippe Normand.
- API/glib/JSCWrapperMap.cpp:
(JSC::WrapperMap::wrappedObject const): VM& vm is unused,
remove.
- 6:31 AM Changeset in webkit [293323] by
-
- 6 edits in trunk/Tools
[build.webkit.org] Use GitHub checkouts
https://bugs.webkit.org/show_bug.cgi?id=239072
<rdar://problem/91567092>
Reviewed by Ryan Haddad.
- Tools/CISupport/build-webkit-org/config.json: Convert schedulers to GitHub based branch names.
- Tools/CISupport/build-webkit-org/loadConfig.py: Ditto.
- Tools/CISupport/build-webkit-org/master.cfg: Enable incoming hooks from GitHub.
(load_password): Added.
- Tools/CISupport/build-webkit-org/steps.py:
(CheckOutSource): Replace with GitHub based checkout.
(CleanUpGitIndexLock): Replaced SVNCleanup.
(SVNCleanup): Replace with CleanUpGitIndexLock.
(ShowIdentifier.start):got_revisionwill bet hash, not subversion revision.
- Tools/CISupport/build-webkit-org/steps_unittest.py:
(TestShowIdentifier.test_success):
(TestShowIdentifier.test_failure):
Canonical link: https://commits.webkit.org/249946@main
- 6:06 AM Changeset in webkit [293322] by
-
- 7 edits in trunk
UA stylesheet should include table { text-indent: initial } to conform with HTML standard
https://bugs.webkit.org/show_bug.cgi?id=201297
Reviewed by Tim Nguyen.
LayoutTests/imported/w3c:
- web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:
- web-platform-tests/html/rendering/non-replaced-elements/tables/table-ua-stylesheet-expected.txt:
Source/WebCore:
As per [1], text-indent for table should be initial.
[1] https://html.spec.whatwg.org/multipage/rendering.html#tables-2
- css/html.css:
(table):
LayoutTests:
- platform/glib/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/resets-expected.txt:
- 5:56 AM Changeset in webkit [293321] by
-
- 2 edits in trunk/Tools
Fix typo in Tools/CISupport/ews-build/steps.py
Unreviewed.
- CISupport/ews-build/steps.py:
(UpdateWorkingDirectory):
- 4:47 AM Changeset in webkit [293320] by
-
- 7 edits2 adds in trunk
REGRESSION (249585@main): TestWebKitAPI.IPCTestingAPI.CanReceiveIPCSemaphore is timing out
https://bugs.webkit.org/show_bug.cgi?id=239507
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-25
Reviewed by Wenson Hsieh.
Source/WebKit:
Add purpose-built test interfaces for testing sending IPC::Semaphore via the IPC.
Test: ipc/send-semaphore.html
- Shared/IPCTester.cpp:
(WebKit::IPCTester::sendSameSemaphoreBack):
(WebKit::IPCTester::sendSemaphoreBackAndSignalProtocol):
- Shared/IPCTester.h:
- Shared/IPCTester.messages.in:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:
Move CanReceiveIPCSemaphore and CanSendIPCSemaphore test logic
to LayoutTests/ipc/send-semaphore.html
The tests were using audio and canvas implementation detail
messages to test that IPC system can send IPC::Semaphore via IPC.
Canvas implementation details changed and the test started
to fail.
The new tests use IPC messages that are purpose-built to test this
feature. The new tests also actually test that the sent semaphores
work.
LayoutTests:
- ipc/send-semaphore-expected.txt: Added.
- ipc/send-semaphore.html: Added.
- 2:20 AM Changeset in webkit [293319] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Disable new demuxers based on adaptivedemux2
https://bugs.webkit.org/show_bug.cgi?id=239701
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-25
Reviewed by Xabier Rodriguez-Calvar.
The new demuxers based on adaptivedemux2 cannot be used in WebKit yet because this new base
class does not abstract away network access. They can't work in a sandboxed media process,
so demote their rank in order to prevent decodebin3 from auto-plugging them.
- platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::registerWebKitGStreamerElements):
Canonical link: https://commits.webkit.org/249942@main
- 12:57 AM Changeset in webkit [293318] by
-
- 2 edits in trunk/Tools
[git] Allow pre-commit hook to feed from staged ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=239419
Patch by Philippe Normand <pnormand@igalia.com> on 2022-04-25
Reviewed by Jonathan Bedard.
In workflows where prepare-ChangeLog is executed manually before staging and committing
changes the prepare-commit-msg hook can now read the curated ChangeLog from the git stage
and present it in the editor for validation. In case no ChangeLog was staged, the hook will
generate a message itself.
- Scripts/hooks/prepare-commit-msg:
Canonical link: https://commits.webkit.org/249941@main
- 12:04 AM Changeset in webkit [293317] by
-
- 3 edits in trunk/Source/ThirdParty/ANGLE
REGRESSION (Safari 15.4) Performance regression after uploading WebGL buffers
https://bugs.webkit.org/show_bug.cgi?id=239015
Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-04-25
Reviewed by Dean Jackson.
BufferMtl::getRestartIndices() would recalculate restart indices on each
draw because RestartRangeCache::operator bool() would return m_isDirty
instead of the intended !m_isDirty.
Use std::optional to hold the RestartRangeCache instead of
maintaining m_isDirty. This allows the type system to contribute to the
correctness of the code. Dirty restart range cache is not useful and takes
up memory.
Re-apply hunks from r281550 "ANGLE Metal index buffer left mapped when building primitive restart ranges".
These were overwritten in r286638 "Roll ANGLE to include upstreamed Metal backend".
- src/libANGLE/renderer/metal/BufferMtl.h:
(rx::BufferMtl::RestartRangeCache::RestartRangeCache):
- src/libANGLE/renderer/metal/BufferMtl.mm:
(rx::BufferMtl::markConversionBuffersDirty):
(rx::BufferMtl::clearConversionBuffers):
(rx::BufferMtl::getRestartIndices):
