Timeline
May 31, 2022:
- 10:27 PM Changeset in webkit [295081] by
-
- 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
DOM order may not be sufficient when constructing the LogicalFlexItemList
https://bugs.webkit.org/show_bug.cgi?id=241166
Reviewed by Antti Koivisto.
We need to hold on to a reference to the layout box in case logical order != DOM order.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
Canonical link: https://commits.webkit.org/251176@main
- 10:00 PM Changeset in webkit [295080] by
-
- 2 edits in trunk
Allow decidePolicyForNavigation* decisionHandlers to be called on non-main runloops
https://bugs.webkit.org/show_bug.cgi?id=241157
<rdar://94130705>
Reviewed by Brady Eidson.
Wouldn't it be nice if all apps used your APIs exactly how you want them to?
This is not the case. People call decision handlers on non-main threads.
When this happens, just hop to the main thread to avoid threading issues.
- Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse):
Canonical link: https://commits.webkit.org/251175@main
- 8:00 PM Changeset in webkit [295079] by
-
- 32 edits25 adds in trunk/LayoutTests
Import css/css-text/text-align tests from WPT
https://bugs.webkit.org/show_bug.cgi?id=241160
Patch by Kiet Ho <Kiet Ho> on 2022-05-31
Reviewed by Tim Nguyen.
Imported from WPT commit 9a7bbe40439176ace294a65474b3a9fed2f8b2d3.
- LayoutTests/TestExpectations:
- LayoutTests/imported/w3c/resources/resource-files.json:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-006-ref.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-006.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-007-ref.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-007.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-008.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-inline-end-crash.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-shy-001-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-shy-001.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-001-expected.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-001.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-002-expected.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-002.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-003-expected.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-003.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-004-expected.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-004.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-005-expected.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-005.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-006-expected.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justifyall-006.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-001.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-002.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-003.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-004.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-005.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-006.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-007.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-008.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-009.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-010-ref.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-010.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-011.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-012.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-013.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-014.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-interpolation-expected.txt: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-interpolation.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-01-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-01.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-02-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-02.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-03-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-03.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-04-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-04.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-ref.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-ltr-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-ltr-ref.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-ltr.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-rtl-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-rtl-ref.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-match-parent-root-rtl.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-webkit-match-parent-expected.txt: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-webkit-match-parent.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/w3c-import.log:
Canonical link: https://commits.webkit.org/251174@main
- 7:07 PM Changeset in webkit [295078] by
-
- 1 edit in trunk/Source/ThirdParty/ANGLE/changes.diff
Regenerate Source/ThirdParty/ANGLE/changes.diff
https://bugs.webkit.org/show_bug.cgi?id=241165
Patch by Dan Glastonbury <djg@apple.com> on 2022-05-31
Reviewed by Dean Jackson.
- Source/ThirdParty/ANGLE/changes.diff:
Output of update-angle --regenerate-changes-diff
Canonical link: https://commits.webkit.org/251173@main
- 6:53 PM Changeset in webkit [295077] by
-
- 2 edits in trunk/LayoutTests
Move conformance[2]/textures/image_bitmap_from_image_bitmap/ suppressions to top level
https://bugs.webkit.org/show_bug.cgi?id=241145
Patch by Kenneth Russell <kbr@chromium.org> on 2022-05-31
Unreviewed test gardening. Move suppressions from
webgl/TestExpectations to top-level TestExpectations.
- LayoutTests/TestExpectations:
- LayoutTests/webgl/TestExpectations:
Canonical link: https://commits.webkit.org/251172@main
- 6:33 PM Changeset in webkit [295076] by
-
- 1 edit in trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js
Web Inspector: CSS autocomplete: enable experimental feature for initial hint being the most commonly used property of the matching suggestions
https://bugs.webkit.org/show_bug.cgi?id=241146
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Base/Setting.js:
Canonical link: https://commits.webkit.org/251171@main
- 6:25 PM Changeset in webkit [295075] by
-
- 1 edit in trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js
Web Inspector: Debugger: blackbox breakpoint evaluations by default
https://bugs.webkit.org/show_bug.cgi?id=241143
Reviewed by Patrick Angle.
According to <https://webkit.org/web-inspector/script-blackboxing/>
Script blackboxing is the ability to mark a
<script>in Web Inspector so that it is ignored by
the JavaScript debugger, meaning that any JavaScript execution pauses that would happen in that
<script>are instead deferred until JavaScript execution has continued outside of that<script>.
Based on that, developers will likely expect that breakpoint evaluations fall under the category of
"things that the JavaScript debugger does" and would therefore expect that they're ignored/deferred.
- Source/WebInspectorUI/UserInterface/Base/Setting.js:
Canonical link: https://commits.webkit.org/251170@main
- 6:16 PM Changeset in webkit [295074] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Timelines Tab: Screenshots: enable by default
https://bugs.webkit.org/show_bug.cgi?id=241144
Reviewed by Patrick Angle.
- Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
- Source/WebInspectorUI/UserInterface/Base/Setting.js:
- Source/WebInspectorUI/UserInterface/Models/ScreenshotsInstrument.js:
(WI.ScreenshotsInstrument.supported):
- Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
Canonical link: https://commits.webkit.org/251169@main
- 4:42 PM Changeset in webkit [295073] by
-
- 45 edits in trunk/Source
[Xcode] Prevent STP and other self-contained builds from overwriting content in the macOS SDK
https://bugs.webkit.org/show_bug.cgi?id=240408
Reviewed by Alexey Proskuryakov.
When building with WK_OVERRIDE_FRAMEWORKS_DIR, we assume that WebKit is
being built as part of a self-contained application, e.g. Safari
Technology Preview. This means that most content is installed to the
override directory, instead of the normal /System/Library/Frameworks
directory.
However, static library content (e.g. headers and archives
for bmalloc, webrtc, WTF) is _not_ installed to the override directory,
as it is not needed at runtime. It was being installed to the default
/usr/local prefix, where it would merge with and overwrite whatever
WebKit content was already present.
To prevent overwrites and other sorts of conflict with the
system-provided WebKit, introduce WK_LIBRARY_HEADERS_FOLDER_PATH and
WK_LIBRARY_INSTALL_PATH, which expand to /usr/local/include/safari-sdk
and /usr/local/lib/safari-sdk respectively when building in this mode.
Static library headers and archives are built to these locations, where
they're still in the expected SDK location, but won't clobber system
WebKit.
- Source/bmalloc/Configurations/Base.xcconfig:
- Source/bmalloc/Configurations/bmalloc.xcconfig:
- Source/bmalloc/Configurations/mbmalloc.xcconfig:
- Source/JavaScriptCore/Configurations/Base.xcconfig:
- Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
- Source/JavaScriptCore/DerivedSources.make:
- Source/JavaScriptCore/Scripts/generate-unified-sources.sh:
- Source/JavaScriptCore/offlineasm/config.rb:
- Source/JavaScriptCore/offlineasm/parser.rb:
- Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/AngleMetalLib.xcconfig:
- Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/boringssl.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig:
- Source/ThirdParty/libwebrtc/Configurations/yasm.xcconfig:
- Source/WebCore/PAL/Configurations/Base.xcconfig:
- Source/WebCore/PAL/Configurations/PAL.xcconfig:
- Source/WebGPU/Configurations/Base.xcconfig:
- Source/WebGPU/Configurations/WGSL.xcconfig:
- Source/WebGPU/Configurations/WGSLUnitTests.xcconfig:
- Source/WebGPU/Configurations/WebGPU.xcconfig:
- Source/WebKit/Configurations/Base.xcconfig:
- Source/WebKit/Configurations/BaseTarget.xcconfig:
- Source/WebKit/Configurations/SandboxProfiles.xcconfig:
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Source/WebKitLegacy/scripts/generate-unified-sources.sh:
- Source/WebKitLegacy/mac/Configurations/Base.xcconfig:
- Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:
- Source/WTF/Configurations/Base.xcconfig:
- Source/WTF/Configurations/WTF.xcconfig:
- Source/WTF/Configurations/icu.xcconfig:
- Source/WebCore/Configurations/Base.xcconfig:
- Source/WebCore/Configurations/WebCore.xcconfig:
- Source/WebCore/Configurations/WebCoreTestSupport.xcconfig:
- Source/WebCore/DerivedSources.make:
- Source/WebCore/Scripts/generate-unified-sources.sh:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/251168@main
- 4:05 PM Changeset in webkit [295072] by
-
- 3 edits in trunk/Source
Fix whitespace paths in "Copy Profiling Data"
https://bugs.webkit.org/show_bug.cgi?id=240285
Unreviewed build fix. JAVASCRIPTCORE_PRIVATE_HEADERS_DIR may contain
spaces, so when we're invoking copy-profiling-data.sh from that
directory we need to defensively quote it.
- Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/251167@main
- 3:43 PM Changeset in webkit [295071] by
-
- 40 edits in trunk/Source
Revert "Perform media networking operations off the main thread"
This reverts commit be35d3c403e1c80fbc18a7a9c0389633448758ac.
Unreviewed revert due to causing 25 consistent crashes on bot.
Canonical link: https://commits.webkit.org/251166@main
- 3:24 PM Changeset in webkit [295070] by
-
- 1 edit in trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm
[WebAuthn][ios] weakThis not checked before clearing ASCProxy
https://bugs.webkit.org/show_bug.cgi?id=241029
rdar://93932684
Reviewed by Brent Fulgham.
This issue causes crashes after cancelling some types of requests. This change
has been tested on device to verify it fixes the crash.
- Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
Canonical link: https://commits.webkit.org/251165@main
- 3:22 PM Changeset in webkit [295069] by
-
- 1 edit in trunk/metadata/contributors.json
Add Nikita Vasilyev's GitHub username to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=241158
Patch by Nikita Vasilyev <me@elv1s.ru> on 2022-05-31
Reviewed by Jonathan Bedard.
- metadata/contributors.json:
Canonical link: https://commits.webkit.org/251164@main
- 3:08 PM Changeset in webkit [295068] by
-
- 1 edit in trunk/Source/WebKit/UIProcess/Cocoa/SOAuthorization/PopUpSOAuthorizationSession.mm
PopUpSOAuthorization::initSecretWebView modifies parent web view configuration
https://bugs.webkit.org/show_bug.cgi?id=241155
<rdar://94176551>
Reviewed by Chris Dumez.
The AppSSO flows that create a new WKWebView pass through the method
'PopUpSOAuthorizationSession::initSecretWebView'. This conducts SSO flows in
an invisible Window for cases where other UI handles the actual authentication,
but a web view is needed to handle server interactions. It deactivates AppSSO
in the hidden view so that normal server authentication can happen without AppSSO
being triggered a second time.
This method made the common mistake of assuming that performing 'copy' on the
configuration member of the paren't WKWebView yielded a deep copy that could bei
manipulated to control the invisible view independently of the parent view. While
the method correctly disabled AppSSO for the hidden view, it also deactivated it
for the parent view.
This bug could lead to cases where someone who mistakenly terminated an AppSSO flow
would be unable to start the process a second time, as the view would now be
configured to block access to AppSSO authentication.
This patch corrects that bug.
Tested by SOAuthorizationPopUp.InterceptionSucceedTwice.
- Source/WebKit/UIProcess/Cocoa/SOAuthorization/PopUpSOAuthorizationSession.mm:
(WebKit::PopUpSOAuthorizationSession::initSecretWebView):
Canonical link: https://commits.webkit.org/251163@main
- 2:47 PM Changeset in webkit [295067] by
-
- 4 edits1 add in trunk/Source/WebKit
[Xcode] Fix dependency cycles caused by Safari header imports
https://bugs.webkit.org/show_bug.cgi?id=240285
Reviewed by Tim Horton.
We were including headers produced by targets which depend on WebKit.
For Xcode engineering builds, this is not a valid dependency, because
an engineering build does not distinguish between a "header"
dependency and a regular target dependency. These errors have survived
in the codebase because:
- Xcode doesn't recognize header imports as "implicit dependencies",
so the build system hasn't traditionally known these dependencies
exist, except in some incremental builds.
- These headers are available in internal SDKs, so it's possible for
the targets to build out-of-order but build successfully (as long as
the first target to build can use a possibly-outdated version of the
code from the SDK).
When building targets in parallel, we are emitting more information to
recognize these as implicit dependencies (revealing the cycle) and the
build system is laying down framework bundle directories earlier on in
the build (preventing reliance on SDK frameworks).
- Source/WebKit/WebKit.xcodeproj/project.pbxproj: WebKit needs to build after AuthenticationServicesCore in internal builds. Add it as a product dependency.
- Source/WebKit/Configurations/WebKit.xcconfig: Because AuthenticationServicesCore.framework is not available externally, add it to EXCLUDED_SOURCE_FILE_NAMES. The build system still honors the product dependency ordering, but won't fail when it's missing.
- Source/WebKit/Platform/spi/ios/SafariServicesSPI.h: Added, contains interface declarations for needed SSReadingList API. Technically not SPI, but follows the convention of similar platform redeclaration headers.
- Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm: WebKit cannot depend on SafariServices. Replace the import of SSReadingList.h with SafariServicesSPI.h.
- Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: WebKit cannot depend on AuthenticationServices.framework. Thankfully, this import was unused. Delete it.
- Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm: WebKit cannot depend on SafariServices. Replace the import of SSReadingList.h with SafariServicesSPI.h.
Canonical link: https://commits.webkit.org/251162@main
- 2:22 PM Changeset in webkit [295066] by
-
- 3 edits1 add in trunk
ASSERTION FAILED: regExp->isValid() LLIntSlowPaths.cpp(625)
https://bugs.webkit.org/show_bug.cgi?id=241107
<rdar://93369481>
Reviewed by Mark Lam.
We can remove this ASSERT(regExp->isValid()) and others like it that are used for NewRegExp
bytecode processing because subsequent code already must handle the invalid case. These code
paths may create a new RegExp or retrieve a cached RegExp. For the case where a RegExp is
created for the first time it is valid or we wouldn't have generated the NewRegExp bytecode.
This valid RegExp can subsequently be marked with an error if it fails YARR RegExp engine JIT
code or interpreter bytecode generation. Matching with a RegExp with one of these generation
errors properly throws a Syntax error. These ASSERTs fail when the NewRegExp processing
retrieves an already cached RegExp, with a generation error. The matching code will still
throw a Syntax Error.
- JSTests/stress/regexp-late-compilation-error.js: Added.
(testRegExp1):
(testRegExp2):
(test):
- Source/JavaScriptCore/dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
- Source/JavaScriptCore/jit/JITOperations.cpp:
(JSC::JSC_DEFINE_JIT_OPERATION):
- Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
Canonical link: https://commits.webkit.org/251161@main
- 2:18 PM Changeset in webkit [295065] by
-
- 6 edits1 add in trunk/Source
Refer to correct profiling data in WebCore and WebKit
https://bugs.webkit.org/show_bug.cgi?id=239681
Reviewed by Alexey Proskuryakov.
Revert "Unreviewed, revert "[Xcode] Compute PGO profdata paths instead of searching for them at build time""
This reverts commit 2ee0d9d171e2ff7daa94d1a15727033a994e6414.
A bad copy-paste led to WebCore and WebKit's production builds using PGO
data from JavaScriptCore. Fix it, and add back a check that ensures
production builds fail instead of falling back to stub profiling data.
- Source/WebCore/Configurations/WebCore.xcconfig:
- Source/WebKit/Configurations/BaseTarget.xcconfig:
Canonical link: https://commits.webkit.org/251160@main
- 2:13 PM Changeset in webkit [295064] by
-
- 2 edits in trunk/Source/WebKit/UIProcess/API/Cocoa
Remove setUsernameForLocalCredentialWithGroupAndID SPI
https://bugs.webkit.org/show_bug.cgi?id=240829
<rdar://93366441>
Reviewed by Brent Fulgham.
This SPI is no longer used internally and can be removed.
- Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
- Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithID:username:]): Deleted.
(+[_WKWebAuthenticationPanel setUsernameForLocalCredentialWithGroupAndID:credential:username:]): Deleted.
Canonical link: https://commits.webkit.org/251159@main
- 1:53 PM Changeset in webkit [295063] by
-
- 1 edit in trunk/Source/WebCore/dom/Element.cpp
REGRESSION (251042@main):[ iOS Debug ] ASSERTION FAILED: m_ptr in Ref.h(115) : T *WTF::Ref<WTF::WeakPtrImpl<>>::operator->() const [T = WTF::WeakPtrImpl<>, Traits = WTF::RawPtrTraits<WTF::WeakPtrImpl<>>]
https://bugs.webkit.org/show_bug.cgi?id=241141
<rdar://94168551>
Unreviewed, remove null references in the WeakHashMap before calling
WeakHashMap::ensure() to address assertion hits on iOS Debug bots.
This seems to indicate a potential WeakHashMap bug where
WeakHashMap::ensure() can get confused if the WeakMapHash contains
null references but I'll investigate separately.
- Source/WebCore/dom/Element.cpp:
(WebCore::Element::identifier const):
Canonical link: https://commits.webkit.org/251158@main
- 1:19 PM Changeset in webkit [295062] by
-
- 1 edit2 adds in trunk
[macOS] Include text context menu actions when right clicking on selected Live Text in a link
https://bugs.webkit.org/show_bug.cgi?id=241069
rdar://91606522
Reviewed by Devin Rousso.
Currently, when right clicking selected text inside of an image that's inside of a link, we only
show context menu actions for the link and image. While it's still possible to copy this selected
text using the Menu Bar (Edit > Copy), this should be reflected in the context menu as well.
To fix this, we adjust a bit of macOS-specific logic in
ContextMenuControllerto include the set
of text actions as well, in this scenario.
- LayoutTests/fast/images/text-recognition/mac/context-menu-for-image-in-link-contains-copy-expected.txt: Added.
- LayoutTests/fast/images/text-recognition/mac/context-menu-for-image-in-link-contains-copy.html: Added.
Add a layout test to verify the change.
- Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
Always show selected text options for selected Live Text. Additionally, simplify a bit of nearby
code to take advantage of "if statements with initializers".
Canonical link: https://commits.webkit.org/251157@main
- 12:14 PM Changeset in webkit [295061] by
-
- 2 edits in trunk/Source/JavaScriptCore/runtime
Simplify Structure::checkOffsetConsistency()
https://bugs.webkit.org/show_bug.cgi?id=241025
Reviewed by Geoffrey Garen.
Drop redundant isCompilationThread() check in checkOffsetConsistency() before calling
checkOffsetConsistency(PropertyTable*, const DetailsFunc&) since the callee already
does this check. Hopefully, the compiler was already optimizing out the duplicate
check but it is better to be sure given that this check shows on speedometer profiles,
mostly under checkOffsetConsistency().
Also drop the return value since no caller makes use of it.
- Source/JavaScriptCore/runtime/Structure.h:
- Source/JavaScriptCore/runtime/StructureInlines.h:
(JSC::Structure::checkOffsetConsistency const):
Canonical link: https://commits.webkit.org/251156@main
- 11:09 AM Changeset in webkit [295060] by
-
- 9 edits in trunk
Web Inspector: Open Resource dialog should support matching file paths
https://bugs.webkit.org/show_bug.cgi?id=178152
<rdar://problem/34925656>
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Controllers/ResourceQueryController.js:
(WI.ResourceQueryController.prototype.executeQuery):
(WI.ResourceQueryController.prototype._findSpecialCharacterIndicesInDisplayName): Added.
(WI.ResourceQueryController.prototype._findSpecialCharacterIndicesInURL): Added.
(WI.ResourceQueryController.prototype._findSpecialCharacterIndices): Deleted.
Do a second search for the entire URL. Use the result that has the better rank.
- Source/WebInspectorUI/UserInterface/Controllers/QueryController.js:
(WI.QueryController.prototype.findSpecialCharacterIndices): Added.
- Source/WebInspectorUI/UserInterface/Controllers/CSSQueryController.js:
(WI.CSSQueryController.prototype.executeQuery):
(WI.CSSQueryController.prototype._findSpecialCharacterIndicesInPropertyName): Added.
(WI.CSSQueryController.prototype._findSpecialCharacterIndices): Deleted.
Move the shared_findSpecialCharacterIndicesto the base class to avoid repeated logic.
- Source/WebInspectorUI/UserInterface/Models/ResourceQueryResult.js:
(WI.ResourceQueryResult):
(WI.ResourceQueryResult.prototype.get searchString): Added.
Include the string for the matches so callers can reason about what was matched.
- Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js:
(WI.OpenResourceDialog.prototype._populateResourceTreeOutline):
(WI.OpenResourceDialog.prototype._populateResourceTreeOutline.createHighlightedTitleFragment):
Shift the matches if it was for the entire URL, so that highlights still appear for the display name.
- LayoutTests/inspector/unit-tests/css-query-controller.html:
- LayoutTests/inspector/unit-tests/css-query-controller-expected.txt:
- LayoutTests/inspector/unit-tests/resource-query-controller.html:
- LayoutTests/inspector/unit-tests/resource-query-controller-expected.txt:
Canonical link: https://commits.webkit.org/251155@main
- 11:00 AM Changeset in webkit [295059] by
-
- 2 edits in trunk/Source/WebCore/dom
Avoid GCReacheableRefMap lookup inside JSNodeOwner::isReachableFromOpaqueRoots()
https://bugs.webkit.org/show_bug.cgi?id=241063
Reviewed by Geoffrey Garen.
Avoid GCReacheableRefMap lookup inside JSNodeOwner::isReachableFromOpaqueRoots()
by leveraging a flag on Node. According to A/B testing this is a ~0.5%
progression on Speedometer on Apple Silicon.
- Source/WebCore/dom/GCReachableRef.h:
(WebCore::GCReachableRefMap::contains):
(WebCore::GCReachableRefMap::add):
(WebCore::GCReachableRefMap::remove):
- Source/WebCore/dom/Node.h:
(WebCore::Node::isInGCReacheableRefMap const):
(WebCore::Node::setIsInGCReacheableRefMap):
Canonical link: https://commits.webkit.org/251154@main
- 10:12 AM Changeset in webkit [295058] by
-
- 3 edits in trunk
REGRESSION (250981@main): Two SOAuthorization API tests failing
https://bugs.webkit.org/show_bug.cgi?id=240979
<rdar://93996565>
Reviewed by Chris Dumez.
In Bug 240739 I modified AppSSO to lazily initialize the SOAuthenticationCoordinator. This introduced
two problems in the API Tests:
- SOAuthorizationRedirect.InterceptionSucceed3 expected SOAuthentiationCoordinator initialization to happen as soon as the WKWebsiteDataStore was created, but this is now too soon. The assertion just needed to be made after an AppSSO operation was called that would construct the SSO object.
- SOAuthorizationPopUp.InterceptionSucceedTwice revealed a real bug. We almost never start an AppSSO flow, then turn off the feature -- except in the case of a pop-up authentication, which creates a secret hidden window without AppSSO turned on. Hitting this test case caused a crash that needed to be addressed by checking for this rare case, and making sure we didn't dereference a nullptr.
- Source/WebKit/UIProcess/Cocoa/SOAuthorization/PopUpSOAuthorizationSession.mm:
(WebKit::PopUpSOAuthorizationSession::initSecretWebView): Properly disable AppSSO through the WKPreference,
rather than reaching into the object to modify WebKit internal state.
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::trySOAuthorization): Don't attempt to dereference the SOAuthenticationCoordinator when the
AppSSO feature is turned off for a pop-up window.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
(TestWebKitAPI::TEST): Move the assertion to after AppSSO initialization is complete.
Canonical link: https://commits.webkit.org/251153@main
- 10:05 AM Changeset in webkit [295057] by
-
- 2 edits in trunk/Source/cmake
[WPE][GTK] Expose ENABLE_VIDEO build option
https://bugs.webkit.org/show_bug.cgi?id=241128
Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-31
Reviewed by Philippe Normand.
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsWPE.cmake:
Canonical link: https://commits.webkit.org/251151@main
- 10:05 AM Changeset in webkit [295056] by
-
- 17 edits in trunk
Remove some WebSQL code from WebKit
https://bugs.webkit.org/show_bug.cgi?id=240857
Reviewed by Chris Dumez.
- Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bubblewrapSpawn):
- Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):
- Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):
- Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::resolvedMediaKeysDirectory const):
(WebKit::WebsiteDataStore::resolvedDatabaseDirectory const): Deleted.
- Source/WebKit/UIProcess/WebsiteData/playstation/WebsiteDataStorePlayStation.cpp:
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):
- Source/WebKit/UIProcess/WebsiteData/win/WebsiteDataStoreWin.cpp:
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):
- Source/WebKit/UIProcess/glib/WebProcessProxyGLib.cpp:
(WebKit::WebProcessProxy::platformGetLaunchOptions):
- Source/WebKit/UIProcess/glib/WebsiteDataStoreGLib.cpp:
(WebKit::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):
- Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleClearAllDatabases): Deleted.
- Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::exceededDatabaseQuota): Deleted.
- Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h:
- Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::prepareToSuspend):
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.html:
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(runWebsiteDataStoreCustomPaths):
- Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
- Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::clearAllDatabases):
Canonical link: https://commits.webkit.org/251151@main
- 9:59 AM Changeset in webkit [295055] by
-
- 1 edit in trunk/Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineOverviewGraph.css
Web Inspector: Timelines Tab: Screenshots: the selected image should be on top in the overview
https://bugs.webkit.org/show_bug.cgi?id=240878
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Views/ScreenshotsTimelineOverviewGraph.css:
(.timeline-overview-graph.screenshots > img.selected):
Canonical link: https://commits.webkit.org/251150@main
- 9:08 AM Changeset in webkit [295054] by
-
- 5 edits in trunk/Source/WebCore/svg/properties
Handle start/stop conflicts with multiple SVG animators
https://bugs.webkit.org/show_bug.cgi?id=241121
Reviewed by Said Abou-Hallawa.
While animating an SVG property from multiple animators, and if there
are multiple instance of this property, then starting or stopping a
specific animator can override the shared m_animVal. This patch fixes
that issue by allowing instanceStartAnimation/instanceStopAnimation
to modify m_animVal only in the case where there are no other animators
for this property. The change is performed for each SVG type (Value,
Primitive, Decorated and List).
- Source/WebCore/svg/properties/SVGAnimatedDecoratedProperty.h: Do not touch m_animVal if there are other animators for this property.
- Source/WebCore/svg/properties/SVGAnimatedPrimitiveProperty.h: Ditto.
- Source/WebCore/svg/properties/SVGAnimatedProperty.h: Ditto.
- Source/WebCore/svg/properties/SVGAnimatedPropertyList.h: Ditto.
- Source/WebCore/svg/properties/SVGAnimatedValueProperty.h: Fix a typo.
Canonical link: https://commits.webkit.org/251149@main
- 8:41 AM Changeset in webkit [295053] by
-
- 1 edit in trunk/Tools/CISupport/ews-build/steps.py
EWS should email PR author in case Merge-Queue silently fails on their PR
https://bugs.webkit.org/show_bug.cgi?id=241101
Reviewed by Jonathan Bedard.
- Tools/CISupport/ews-build/steps.py:
(ValidateChange.validate_github):
(ValidateChange.send_email_for_github_failure):
Canonical link: https://commits.webkit.org/251148@main
- 8:22 AM Changeset in webkit [295052] by
-
- 9 edits in trunk/Source
[iOS] Refactor some logic around
VideoFullscreenInterfaceAVKit
https://bugs.webkit.org/show_bug.cgi?id=241113
Reviewed by Eric Carlson.
Adjust the window level of
VideoFullscreenInterfaceAVKit's window. No change in behavior.
- Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:
(VideoFullscreenInterfaceAVKit::doSetup):
- Source/WebKit/UIProcess/PageClient.h:
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didEnterFullscreen):
(WebKit::WebPageProxy::didExitFullscreen):
Also refactor
WebPageProxy::did(Enter|Exit)Fullscreen, such that we implement
didExitFullscreen(PlaybackSessionContextIdentifier)in the case where
ENABLE(VIDEO_PRESENTATION_MODE)is enabled, anddidExitFullscreen()(with no arguments) in the
case where it's disabled.
Currently both versions of
did(Enter|Exit)Fullscreen()exist ifENABLE(VIDEO_PRESENTATION_MODE)
is set, even though we only expect to call intodid(Enter|Exit)Fullscreen()from outside of
WebPageProxy.
- Source/WebKit/UIProcess/WebPageProxy.h:
- Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
- Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didEnterFullscreen):
(WebKit::PageClientImpl::didExitFullscreen):
- Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didEnterFullscreen]):
(-[WKContentView _didExitFullscreen]):
- Source/WebKit/UIProcess/mac/PageClientImplMac.h:
Canonical link: https://commits.webkit.org/251147@main
- 6:41 AM Changeset in webkit [295051] by
-
- 3 edits in trunk/Source/WebCore/layout
Add support for margin: auto
https://bugs.webkit.org/show_bug.cgi?id=241111
Reviewed by Antti Koivisto.
Auto margins take up all of the space that they can in their axis.
- compute the space 'margin: auto' can take
- distribute it among flex items with 'margin: auto'
- adjust final top/left with the computed margin
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::computedAutoMarginValueForFlexItems):
(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
Canonical link: https://commits.webkit.org/251146@main
- 6:39 AM Changeset in webkit [295050] by
-
- 3 edits in trunk/Source/WebCore
Ensure logical properties have skip-builder
https://bugs.webkit.org/show_bug.cgi?id=241105
Reviewed by Tim Nguyen.
Builder::applyProperty resolves logical properties into physical ones.
So there is no need to define BuilderCustom methods for them.
Thus, most already have skip-builder:true. This patch covers the only
two exceptions.
No test since there should be no change in behavior.
- Source/WebCore/css/CSSProperties.json:
Flag contain-intrinsic-block-size and contain-intrinsic-inline-size with
skip-builder:true.
- Source/WebCore/css/makeprop.pl:
Require logical properties to have skip-builder:true.
- Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyInitialContainIntrinsicBlockSize): Deleted.
(WebCore::Style::BuilderCustom::applyInheritContainIntrinsicBlockSize): Deleted.
(WebCore::Style::BuilderCustom::applyValueContainIntrinsicBlockSize): Deleted.
(WebCore::Style::BuilderCustom::applyInitialContainIntrinsicInlineSize): Deleted.
(WebCore::Style::BuilderCustom::applyInheritContainIntrinsicInlineSize): Deleted.
(WebCore::Style::BuilderCustom::applyValueContainIntrinsicInlineSize): Deleted.
Remove unnecessary logic.
Canonical link: https://commits.webkit.org/251145@main
- 6:24 AM Changeset in webkit [295049] by
-
- 32 edits27 adds1 delete in trunk
Unprefix -webkit-text-justify and add inter-character value
https://bugs.webkit.org/show_bug.cgi?id=229084
<rdar://82177456>
Reviewed by Antti Koivisto.
This is still disabled by default behind the cssTextJustifyEnabled setting.
We don't keep support for the -webkit- prefix, since only Firefox ships text-justify (without the prefix) and it was never enabled in WebKit for macOS/iOS.
distribute and inter-character are aliases, with distribute being the legacy one. The spec specifies it as parse-time, but we implement it compute-time (like Chrome).
https://github.com/w3c/csswg-drafts/issues/7322 is filed about potentially removing 'distribute' from the spec.
- LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-expected.txt: Removed.
- LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited-expected.txt: Removed.
- LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html: Removed.
- LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html: Removed.
Removed parsing tests redundant with WPT.
- LayoutTests/fast/css3-text/css3-text-justify/text-justify-none.html:
- LayoutTests/fast/text/text-combine-crash.html:
- LayoutTests/TestExpectations:
- LayoutTests/imported/w3c/resources/resource-files.json:
- LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-allowed-properties-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-allowed-properties-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-justify-computed-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-justify-valid-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-bidi-003.xht:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-001.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-002.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-003.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-004.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-005.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-006.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/distribute-alias.tentative-expected.txt: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/distribute-alias.tentative.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-001-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-001.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-002-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-002.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-003-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-003.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-004-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-004.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-005-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-005.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-006-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-and-trailing-spaces-006.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-distribute-001-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-distribute-001.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-character-001-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-character-001-ref.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-character-001.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-word-001-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-word-001-ref.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-inter-word-001.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-interpolation-expected.txt: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-interpolation.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-none-001-expected.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-none-001-ref.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/text-justify-none-001.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-justify/w3c-import.log:
- LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
- LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
Import new WPT from 6aa9a39, remove prefixes automatically added by the importer, and rebaseline tests.
- Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextJustify const):
- Source/WebCore/css/CSSProperties.json:
- Source/WebCore/css/StyleProperties.cpp:
- Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):
- Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
- Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::textAlignmentForLine const):
- Source/WebCore/rendering/style/RenderStyleConstants.h:
- Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:
Canonical link: https://commits.webkit.org/251144@main
- 6:02 AM Changeset in webkit [295048] by
-
- 5 edits1 add in trunk/Source/WebCore/platform
[Linux] TextureMapperPlatformLayerProxyDMABuf should support different colorspaces
https://bugs.webkit.org/show_bug.cgi?id=240633
Patch by Žan Doberšek <zdobersek@igalia.com> on 2022-05-31
Reviewed by Miguel Gomez and Philippe Normand.
Add the DMABufColorSpace enumeration, covering different colorspaces we
currently can support between decoded GStreamer data and the TextureMapper
DMABuf integration.
DMABufObject gains a DMABufColorSpace member variable, initially of an invalid
value but that can be overridden by whoever is constructing the object.
In MediaPlayerPrivateGStreamer, the desired colorspace can be retrieved from the
GstVideoInfo colorimetry information and set on the DMABufObject.
The colorspace is now respected in TextureMapperPlatformLayerProxyDMABuf,
choosing between different YUV-to-RGB matrices that are to be used when sampling
from the set of plane-assigned textures. The default is the BT.601 conversion
matrix. For RGBA-like formats, no conversion is required, so an assert is placed
to ensure that the colorspace is either unspecified or specified as SRGB.
- Source/WebCore/platform/TextureMapper.cmake:
- Source/WebCore/platform/graphics/gbm/DMABufColorSpace.h: Added.
- Source/WebCore/platform/graphics/gbm/DMABufObject.h:
(WebCore::DMABufObject::encode const):
(WebCore::DMABufObject::encode):
(WebCore::DMABufObject::decode):
- Source/WebCore/platform/graphics/gbm/GBMBufferSwapchain.cpp:
- Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::colorSpaceForColorimetry):
(WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor):
- Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp:
(WebCore::TextureMapperPlatformLayerProxyDMABuf::DMABufLayer::paintToTextureMapper):
Canonical link: https://commits.webkit.org/251143@main
- 5:33 AM Changeset in webkit [295047] by
-
- 2 edits in trunk/Source/WebKit/WebProcess/WebPage
[WPE][GTK] Build broken with ENABLE_VIDEO=OFF after r292252
https://bugs.webkit.org/show_bug.cgi?id=241123
Reviewed by Philippe Normand.
- Source/WebKit/WebProcess/WebPage/WebPage.cpp: Add missing ENABLE(VIDEO) guard.
- Source/WebKit/WebProcess/WebPage/WebPage.h: Ditto.
Canonical link: https://commits.webkit.org/251142@main
- 3:38 AM Changeset in webkit [295046] by
-
- 1 edit in trunk/Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp
[GStreamer] DMABufVideoSink fails to list NV21 as a supported format
https://bugs.webkit.org/show_bug.cgi?id=241119
Patch by Žan Doberšek <zdobersek@igalia.com> on 2022-05-31
Reviewed by Miguel Gomez and Philippe Normand.
- Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp:
NV12 is listed twice in the DMABufVideoSink's list of supported formats. This
is a typo, one of those was supposed to be NV21, a different-but-similar format
that works just fine.
Canonical link: https://commits.webkit.org/251141@main
- 1:22 AM WebKitGTK/2.36.x edited by
- Started section of merges for the 2.36.x releases (diff)
- 1:15 AM Changeset in webkit [295045] by
-
- 1 edit in trunk/Source/WebCore/bindings/js/JSDOMMapLike.cpp
[GTK][WPE] Build failure when cross-building for 64-bit ARM
https://bugs.webkit.org/show_bug.cgi?id=241109
Unreviewed build fix.
- Source/WebCore/bindings/js/JSDOMMapLike.cpp: Add missing JavaScriptCore/HashMapImplInlines.h header inclusion.
Canonical link: https://commits.webkit.org/251140@main
May 30, 2022:
- 11:43 PM Changeset in webkit [295044] by
-
- 2 edits in trunk/Source
RemoteVideoFrameProxy::pixelBuffer should properly compute canUseIOSurface
https://bugs.webkit.org/show_bug.cgi?id=241100
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-30
Reviewed by Eric Carlson.
We can use IOSurface when doing WebGL in WebProcess, instead of when doing WebGL in GPUProcess.
Update canUseIOSurface accordingly.
Add error logging when creating a CVPixelBufferRef.
- Source/WebCore/platform/graphics/cv/CVUtilities.mm:
(WebCore::createCVPixelBuffer):
- Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.cpp:
(WebKit::RemoteVideoFrameProxy::pixelBuffer const):
Canonical link: https://commits.webkit.org/251139@main
- 10:49 PM Changeset in webkit [295043] by
-
- 1 edit in trunk/Source/bmalloc/libpas/src/libpas/pas_utils.c
[libpas] Build fix macOS
https://bugs.webkit.org/show_bug.cgi?id=241116
Reviewed by Yusuke Suzuki.
Convert from int to uint64_t. Line should always be a positive number.
- Source/bmalloc/libpas/src/libpas/pas_utils.c:
(pas_assertion_failed_no_inline):
(pas_assertion_failed_no_inline_with_extra_detail):
Canonical link: https://commits.webkit.org/251138@main
- 9:50 PM Changeset in webkit [295042] by
-
- 1 edit in trunk/.clangd
Clangd should always interpret headers as C++
https://bugs.webkit.org/show_bug.cgi?id=241118
Reviewed by Saam Barati.
Attach
-xc++flag to headers in .clangd to interpret all headers as C++ by default.
- .clangd:
Canonical link: https://commits.webkit.org/251137@main
- 9:18 PM Changeset in webkit [295041] by
-
- 1 edit in trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp
REGRESSION(251043@main): "ASSERTION FAILED: channel" in WebCore::ThreadableWebSocketChannel::create
https://bugs.webkit.org/show_bug.cgi?id=241087
Reviewed by Don Olmstead.
Since 251043@main, WinCairo WK1 was crashing for WebSocket tests.
channelvariable was null inThreadableWebSocketChannel::create.
In the case, it should call WebSocketChannel::create like Mac port
does.
- Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::create):
Canonical link: https://commits.webkit.org/251136@main
- 9:13 PM Changeset in webkit [295040] by
-
- 6 edits in trunk/Source
[JSC] Make VMEntryScope cheap
https://bugs.webkit.org/show_bug.cgi?id=241091
Reviewed by Mark Lam.
This patch makes VMEntryScope cheap. In some microbenchmarks, we observe repeated execution of VMEntryScope
because of many ticks driven by microtasks. And currently VMEntryScope is designed to be non-cheap based on
the assumption that this is not frequently executed.
- We add isJSThread flag to Thread so that we can skip some of unnecessary initializations.
- Appropriately set UNLIKELY / LIKELY for the major path.
- Make DateCache::resetIfNecessary fast path inlined.
ToT
Time(doxbee-async-es2017-native): 24 ms.
Time(doxbee-promises-es2015-native): 44.9 ms.
Time(fibonacci-async-es2017-native): 197.6 ms.
Time(parallel-async-es2017-native): 109.1 ms.
Time(parallel-promises-es2015-native): 80.4 ms.
Patched
Time(doxbee-async-es2017-native): 21.4 ms.
Time(doxbee-promises-es2015-native): 36.4 ms.
Time(fibonacci-async-es2017-native): 168.1 ms.
Time(parallel-async-es2017-native): 103.7 ms.
Time(parallel-promises-es2015-native): 70.9 ms.
- Source/JavaScriptCore/runtime/JSDateMath.cpp:
(JSC::DateCache::resetIfNecessarySlow):
(JSC::DateCache::resetIfNecessary): Deleted.
- Source/JavaScriptCore/runtime/JSDateMath.h:
(JSC::DateCache::resetIfNecessary):
- Source/JavaScriptCore/runtime/VM.h:
(JSC::VM::firePrimitiveGigacageEnabledIfNecessary):
- Source/JavaScriptCore/runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):
- Source/WTF/wtf/Threading.cpp:
(WTF::Thread::registerJSThread):
- Source/WTF/wtf/Threading.h:
Canonical link: https://commits.webkit.org/251135@main
- 6:26 PM Changeset in webkit [295039] by
-
- 5 edits1 copy1 add in trunk/Source/WebCore
Move core flex layout to FlexLayout
https://bugs.webkit.org/show_bug.cgi?id=241106
Reviewed by Antti Koivisto.
- Source/WebCore/Headers.cmake:
- Source/WebCore/Sources.txt:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
(WebCore::Layout::FlexFormattingContext::computeAvailableLogicalVerticalSpace const): Deleted.
(WebCore::Layout::FlexFormattingContext::computeAvailableLogicalHorizontalSpace const): Deleted.
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForShrinkingFlexItems): Deleted.
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForStretchingFlexItems): Deleted.
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForFlexItems): Deleted.
(WebCore::Layout::FlexFormattingContext::computeLogicalHeightForFlexItems): Deleted.
(WebCore::Layout::FlexFormattingContext::alignFlexItems): Deleted.
(WebCore::Layout::FlexFormattingContext::justifyFlexItems): Deleted.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
- Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp: Added.
(WebCore::Layout::FlexLayout::FlexLayout):
(WebCore::Layout::FlexLayout::computeAvailableLogicalVerticalSpace const):
(WebCore::Layout::FlexLayout::computeAvailableLogicalHorizontalSpace const):
(WebCore::Layout::FlexLayout::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexLayout::alignFlexItems):
(WebCore::Layout::FlexLayout::justifyFlexItems):
(WebCore::Layout::FlexLayout::layout):
- Source/WebCore/layout/formattingContexts/flex/FlexLayout.h: Copied from Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h.
(WebCore::Layout::FlexLayout::formattingState const):
(WebCore::Layout::FlexLayout::flexBoxStyle const):
Canonical link: https://commits.webkit.org/251134@main
- 4:59 PM Changeset in webkit [295038] by
-
- 1 edit in trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
[Cocoa] Rename [de]normalizeWeight() to [de]normalizeGXWeight()
https://bugs.webkit.org/show_bug.cgi?id=241112
Reviewed by Alan Bujtas.
Weights are measured in 3 different scales:
- CSS weights (1 - 999)
- Core Text weights (-1.0 - 1.0)
- TrueType GX weights (0.0ish to 2.0ish, it's not really defined, only the "default" value
of 1.0 is defined).
Our current functions convert between CSS weights and TrueType GX weights, so this makes that more
clear. A subsequent patch will add conversions between CSS weights and Core Text weights.
No new tests because there is no behavior change.
- Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::normalizeGXWeight):
(WebCore::denormalizeGXWeight):
(WebCore::preparePlatformFont):
(WebCore::variationCapabilitiesForFontDescriptor):
(WebCore::normalizeWeight): Deleted.
(WebCore::denormalizeWeight): Deleted.
Canonical link: https://commits.webkit.org/251132@main
- 4:58 PM Changeset in webkit [295037] by
-
- 1 edit in trunk/Source/WTF/wtf/RAMSize.cpp
Include <sys/sysinfo.h> on FreeBSD too
https://bugs.webkit.org/show_bug.cgi?id=241099
Patch by Leonardo Taccari <leot@NetBSD.org> on 2022-05-30
Reviewed by Fujii Hironori.
sysinfo(2)/sysinfo(3) is used also in FreeBSD, include corresponding
<sys/sysinfo.h> header too.
- Source/WTF/wtf/RAMSize.cpp:
Canonical link: https://commits.webkit.org/251132@main
- 4:41 PM Changeset in webkit [295036] by
-
- 3 edits in trunk/Source/JavaScriptCore/heap
[JSC] Make Strong::set cheap
https://bugs.webkit.org/show_bug.cgi?id=241090
Reviewed by Mark Lam.
HandleSet::writeBarrier is frequently called because it is called every time we set a value in Strong<>.
This patch optimizes it,
- We should make it inline function since it has a super fast path major use can be covered. And this function is small.
- We should not always remove a node from the list first. We should insert / remove it only when necessary.
- Remove m_immediateList since it is not necessary.
- Make HandleNode as a derived class of BasicRawSentinelNode to make implementation simpler.
This change improves promise benchmarks score since promise uses microtasks which hold values via Strong<>.
ToT
Time(doxbee-async-bluebird): 42.8 ms.
Time(doxbee-async-es2017-babel): 36.4 ms.
Time(doxbee-async-es2017-native): 28.3 ms.
Time(doxbee-promises-bluebird): 514.2 ms.
Time(doxbee-promises-es2015-native): 44.8 ms.
Time(fibonacci-async-es2017-babel): 380.5 ms.
Time(fibonacci-async-es2017-native): 218.2 ms.
Time(parallel-async-bluebird): 648.8 ms.
Time(parallel-async-es2017-babel): 116.9 ms.
Time(parallel-async-es2017-native): 115.6 ms.
Time(parallel-promises-bluebird): 638 ms.
Time(parallel-promises-es2015-native): 82 ms.
Patched
Time(doxbee-async-bluebird): 38 ms.
Time(doxbee-async-es2017-babel): 27 ms.
Time(doxbee-async-es2017-native): 19.5 ms.
Time(doxbee-promises-bluebird): 508.3 ms.
Time(doxbee-promises-es2015-native): 33.3 ms.
Time(fibonacci-async-es2017-babel): 349.1 ms.
Time(fibonacci-async-es2017-native): 151 ms.
Time(parallel-async-bluebird): 639.6 ms.
Time(parallel-async-es2017-babel): 100.9 ms.
Time(parallel-async-es2017-native): 101.9 ms.
Time(parallel-promises-bluebird): 614 ms.
Time(parallel-promises-es2015-native): 70.9 ms.
- Source/JavaScriptCore/heap/HandleSet.cpp:
(JSC::HandleSet::writeBarrier): Deleted.
- Source/JavaScriptCore/heap/HandleSet.h:
(JSC::HandleSet::heapFor):
(JSC::HandleSet::allocate):
(JSC::HandleSet::deallocate):
(JSC::HandleSet::writeBarrier):
(JSC::HandleSet::toHandle): Deleted.
(JSC::HandleSet::toNode): Deleted.
(JSC::HandleNode::HandleNode): Deleted.
(JSC::HandleNode::setPrev): Deleted.
(JSC::HandleNode::prev): Deleted.
(JSC::HandleNode::setNext): Deleted.
(JSC::HandleNode::next): Deleted.
- Source/JavaScriptCore/heap/Strong.h:
(JSC::Strong::set):
Canonical link: https://commits.webkit.org/251131@main
- 3:10 PM Changeset in webkit [295035] by
-
- 9 edits12 adds in trunk
Fix invalidation with scope breaking :is/not()
https://bugs.webkit.org/show_bug.cgi?id=241098
Reviewed by Alan Bujtas.
Selector like :has(:is(foo bar)) can be affected by mutations outside the :has scope.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/child-indexed-pseudo-classes-in-has-expected.txt: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/child-indexed-pseudo-classes-in-has.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/empty-pseudo-in-has-expected.txt: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/empty-pseudo-in-has.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-in-adjacent-position.html:
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-in-ancestor-position.html:
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-in-parent-position.html:
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-in-sibling-position.html:
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/is-pseudo-containing-complex-in-has-expected.txt: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/is-pseudo-containing-complex-in-has.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/link-pseudo-in-has-expected.txt: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/link-pseudo-in-has.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/not-pseudo-containing-complex-in-has-expected.txt: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/not-pseudo-containing-complex-in-has.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/typed-child-indexed-pseudo-classes-in-has-expected.txt: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/typed-child-indexed-pseudo-classes-in-has.html: Added.
- LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/w3c-import.log:
Reimport selector invalidation tests.
- Source/WebCore/style/ChildChangeInvalidation.cpp:
(WebCore::Style::ChildChangeInvalidation::invalidateForChangedElement):
(WebCore::Style::needsDescendantTraversal):
- Source/WebCore/style/RuleFeature.cpp:
(WebCore::Style::isSiblingOrSubject):
(WebCore::Style::isHasPseudoClassMatchElement):
(WebCore::Style::computeNextMatchElement):
(WebCore::Style::computeHasPseudoClassMatchElement):
(WebCore::Style::computeSubSelectorMatchElement):
(WebCore::Style::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):
Detect the case and fall back to very wide invalidation (same a non-subject :has() for now).
- Source/WebCore/style/RuleFeature.h:
(WebCore::Style::RuleFeatureSet::usesHasPseudoClass const):
- Source/WebCore/style/StyleInvalidator.cpp:
(WebCore::Style::Invalidator::invalidateStyleWithMatchElement):
Canonical link: https://commits.webkit.org/251130@main
- 3:03 PM Changeset in webkit [295034] by
-
- 4 edits in trunk
WebKitTestRunner shouldn't link object files of JavaScriptCore and WebCore
https://bugs.webkit.org/show_bug.cgi?id=241002
Reviewed by Don Olmstead.
243269@main removed
WebKitfromWebKitTestRunner_FRAMEWORKSfor
WPE. But, it should be there not to link object files of
JavaScriptCore and WebCore to WebKitTestRunner. In WPE builds,
JavaScriptCore and WebCore API are exported from WebKit shared
library. WebKit consumers shouldn't link with object files of
JavaScriptCore and WebCore.
However, adding
WebKittoWebKitTestRunner_FRAMEWORKSintroduced a
new problem that the object file of LowLevelInterpreter.cpp was linked
into WebKitTestRunner. This problem was fixed by changing
LowLevelInterpreterLib to a STATIC library.
- Source/JavaScriptCore/CMakeLists.txt:
- Tools/WebKitTestRunner/CMakeLists.txt:
- Tools/WebKitTestRunner/PlatformGTK.cmake:
- Tools/WebKitTestRunner/PlatformWin.cmake:
Canonical link: https://commits.webkit.org/251129@main
- 2:59 PM Changeset in webkit [295033] by
-
- 1 edit in trunk/Source/bmalloc/bmalloc/AvailableMemory.cpp
Include <sys/sysinfo.h> only on FreeBSD and Linux
https://bugs.webkit.org/show_bug.cgi?id=241077
Patch by Leonardo Taccari <leot@NetBSD.org> on 2022-05-30
Reviewed by Fujii Hironori.
sysinfo(2)/sysinfo(3) is used only on FreeBSD and Linux and could be not
available in other Unix-like operating systems.
- Source/bmalloc/bmalloc/AvailableMemory.cpp:
Canonical link: https://commits.webkit.org/251128@main
- 11:07 AM Changeset in webkit [295032] by
-
- 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Add support for justify-content: space-evenly
https://bugs.webkit.org/show_bug.cgi?id=241085
Reviewed by Antti Koivisto.
Distribute items evenly. Items have equal space around them.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::justifyFlexItems):
Canonical link: https://commits.webkit.org/251127@main
- 9:48 AM Changeset in webkit [295031] by
-
- 17 edits in trunk
MediaStreamTrack.getConstraints is empty object
https://bugs.webkit.org/show_bug.cgi?id=240569
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-30
Reviewed by Eric Carlson.
Cover audio and video constraints in UserMediaRequest.
Set these constraints on the created tracks at promise resolution time.
Make a refactoring to move from using RefPtr<MediaStreamTrack> to Ref<MediaStreamTrack>.
Remove use of MediaStream::getTracks since it is not efficient.
Covered by updated tests.
- Source/WebCore/Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::getUserMedia):
(WebCore::MediaDevices::getDisplayMedia):
- Source/WebCore/Modules/mediastream/MediaDevices.h:
- Source/WebCore/Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::clone):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::getFirstAudioTrack const):
(WebCore::MediaStream::getFirstVideoTrack const):
(WebCore::MediaStream::getTracks const):
(WebCore::MediaStream::internalAddTrack):
(WebCore::MediaStream::internalTakeTrack):
(WebCore::MediaStream::mediaState const):
(WebCore::MediaStream::updateActiveState):
(WebCore::MediaStream::filteredTracks const):
- Source/WebCore/Modules/mediastream/MediaStream.h:
- Source/WebCore/Modules/mediastream/MediaStreamTrack.h:
(WebCore::MediaStreamTrack::setConstraints):
- Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::create):
(WebCore::UserMediaRequest::UserMediaRequest):
(WebCore::UserMediaRequest::allow):
- Source/WebCore/Modules/mediastream/UserMediaRequest.h:
- LayoutTests/fast/mediastream/getDisplayMedia-max-constraints3.html:
- LayoutTests/fast/mediastream/getUserMedia-webaudio.html:
- LayoutTests/fast/mediastream/mediastreamtrack-video-clone.html:
Canonical link: https://commits.webkit.org/251126@main
- 9:44 AM Changeset in webkit [295030] by
-
- 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Add support for justify-content: space-around
https://bugs.webkit.org/show_bug.cgi?id=241084
Reviewed by Antti Koivisto.
Distribute items evenly. Items have a half-size space on either end.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::justifyFlexItems):
Canonical link: https://commits.webkit.org/251125@main
- 8:20 AM Changeset in webkit [295029] by
-
- 1 edit in trunk/Source/WebCore/platform/graphics/cpu/arm/filters/FEGaussianBlurNEON.h
[GPU Process][Filters] Don't use Uint8ClampedArray in software filter appliers also for FEGaussianBlurNEON
https://bugs.webkit.org/show_bug.cgi?id=240964
Reviewed by Said Abou-Hallawa.
This complement the changes done in r250982 by adapting the specific
method used for ARMv7 NEON.
- Source/WebCore/platform/graphics/cpu/arm/filters/FEGaussianBlurNEON.h:
(WebCore::boxBlurNEON):
Canonical link: https://commits.webkit.org/251124@main
- 7:18 AM Changeset in webkit [295028] by
-
- 34 edits in trunk/Source
Unreviewed, non-unified build fixes after 251082@main
- Source/WebCore/bindings/js/JSAttrCustom.cpp:
- Source/WebCore/bindings/js/JSAudioBufferSourceNodeCustom.cpp:
- Source/WebCore/bindings/js/JSCSSRuleCustom.cpp:
- Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp:
- Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:
- Source/WebCore/bindings/js/JSDocumentCustom.cpp:
- Source/WebCore/bindings/js/JSFetchEventCustom.cpp:
- Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:
- Source/WebCore/bindings/js/JSHTMLTemplateElementCustom.cpp:
- Source/WebCore/bindings/js/JSIDBCursorCustom.cpp:
- Source/WebCore/bindings/js/JSIntersectionObserverCustom.cpp:
- Source/WebCore/bindings/js/JSIntersectionObserverEntryCustom.cpp:
- Source/WebCore/bindings/js/JSMessageChannelCustom.cpp:
- Source/WebCore/bindings/js/JSMessagePortCustom.cpp:
- Source/WebCore/bindings/js/JSNodeCustom.cpp:
- Source/WebCore/bindings/js/JSNodeIteratorCustom.cpp:
- Source/WebCore/bindings/js/JSPaintRenderingContext2DCustom.cpp:
- Source/WebCore/bindings/js/JSResizeObserverEntryCustom.cpp:
- Source/WebCore/bindings/js/JSSVGViewSpecCustom.cpp:
- Source/WebCore/bindings/js/JSStyleSheetCustom.cpp:
- Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:
- Source/WebCore/bindings/js/JSUndoItemCustom.cpp:
- Source/WebCore/bindings/js/JSWebGL2RenderingContextCustom.cpp:
- Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp:
- Source/WebCore/bindings/js/JSWebXRSessionCustom.cpp:
- Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp:
- Source/WebCore/bindings/js/JSWorkerNavigatorCustom.cpp:
- Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:
- Source/WebCore/bindings/js/JSXPathResultCustom.cpp:
- Source/WebCore/html/HTMLCanvasElement.cpp:
- Source/WebCore/page/DOMWindowProperty.h:
- Source/WebCore/page/UndoManager.h:
- Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
Canonical link: https://commits.webkit.org/251123@main
- 7:10 AM Changeset in webkit [295027] by
-
- 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Add support for justify-content: space-between
https://bugs.webkit.org/show_bug.cgi?id=241080
Reviewed by Antti Koivisto.
Distribute items evenly. The first item is flush with the start, the last is flush with the end.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::justifyFlexItems):
- Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForFlexLayout):
Canonical link: https://commits.webkit.org/251122@main
- 7:05 AM Changeset in webkit [295026] by
-
- 11 edits1 copy6 adds in trunk
REGRESSION (r293885): [ macOS wk2 ] webrtc/canvas-to-peer-connection.html is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=240814
Patch by Youenn Fablet <youennf@gmail.com> on 2022-05-30
Reviewed by Eric Carlson.
With r293885, we stopped using a pixel conformer to convert frames to YUV.
Instead, we used libyuv routines.
Libyuv is using BT.601 while our pixel conformer was using BT.709.
BT.709 is preferred in WebRTC so we now simply remove our conversion routine from RealtimeOutgoingVideoSourceCocoa.
Our hardware codecs can directly take RGB and convert it to YUV using BT.709.
To ensure we use the proper conversion routine, we add a RGB -> YUV conformer in LibWebRTCCodecsProxy.
Libvpx will use BT.601 routine so we do not have a very good story with VP8.
A follow-up should fix this. We add dedicated tests for both H264 and VP8.
We skip the new tests in glib as GTK bots do not like it.
- LayoutTests/platform/glib/TestExpectations:
- LayoutTests/platform/ios-simulator/TestExpectations:
- LayoutTests/platform/mac-wk2/TestExpectations:
- LayoutTests/webrtc/canvas-to-peer-connection.html:
- LayoutTests/webrtc/routines.js:
- Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:
(WebCore::RealtimeOutgoingVideoSourceCocoa::videoFrameAvailable):
- Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.h:
- Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:
(WebCore::RealtimeOutgoingVideoSourceCocoa::pixelBufferPool): Deleted.
- Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
- Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:
Canonical link: https://commits.webkit.org/251121@main
- 6:54 AM Changeset in webkit [295025] by
-
- 3 edits in trunk/Source/bmalloc/libpas/src/libpas
Unreviewed, build fix on Linux
https://bugs.webkit.org/show_bug.cgi?id=240331
- Source/bmalloc/libpas/src/libpas/pas_heap_config.h:
- Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:
(pas_probabilistic_guard_malloc_debug_info):
- Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.h:
Canonical link: https://commits.webkit.org/251120@main
- 6:00 AM Changeset in webkit [295024] by
-
- 2 edits in trunk/Source/WebCore/accessibility
Fix a11y build warnings
https://bugs.webkit.org/show_bug.cgi?id=241044
Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-30
Reviewed by Adrian Perez de Castro.
- Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::symmetricRelation):
- Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
Canonical link: https://commits.webkit.org/251119@main
- 3:02 AM Changeset in webkit [295023] by
-
- 1 edit in trunk/Source/WTF/wtf/CompactPtr.h
Unreviewed, build fix for iOS debug build
- Source/WTF/wtf/CompactPtr.h:
(WTF::CompactPtr::encode):
(WTF::CompactPtr::decode):
(WTF::CompactPtr::decode const): Deleted.
Canonical link: https://commits.webkit.org/251118@main
- 3:00 AM Changeset in webkit [295022] by
-
- 2 edits in trunk/Source/JavaScriptCore/runtime
[JSC] Shrink BrandedStructure
https://bugs.webkit.org/show_bug.cgi?id=241092
Reviewed by Mark Lam.
Use CompactRefPtr and WriteBarrierStructureID to shrink sizeof(BrandedStructure) from 112 to 104.
While it is not enough for 32byte alignment, anyway we can make it smaller, and if we make it 8byte
smaller further, it will become 96bytes.
- Source/JavaScriptCore/runtime/BrandedStructure.cpp:
(JSC::BrandedStructure::BrandedStructure):
- Source/JavaScriptCore/runtime/BrandedStructure.h:
Canonical link: https://commits.webkit.org/251117@main
- 1:29 AM Changeset in webkit [295021] by
-
- 45 edits1 delete in trunk
Unprefix -webkit-text-align-last and add match-parent value support
https://bugs.webkit.org/show_bug.cgi?id=229083
<rdar://82176885>
Reviewed by Antti Koivisto.
We do not keep support for the prefixed version since no other browser supports it, and WebKit never exposed it on macOS/iOS.
Also, unprefix WPTs where prefixes were added automatically by the test importer.
Note that serialization of the match-parent value isn't as specified in the spec, but the behavior matches other browsers.
Original patch by Brent Fulgham.
- LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-expected.txt: Removed.
- LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited-expected.txt: Removed.
- LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html: Removed.
- LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html: Removed.
These tests are redundant with the parsing ones on WPT.
- LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html:
- LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-text-align-expected.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-text-align-ref.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/marker-text-align.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-percent-001-expected.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-thickness-percent-001.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/inheritance-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/letter-spacing/letter-spacing-bidi-003.xht:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-last-computed-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-last-valid-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-001.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-002.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-003.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-004.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-005.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-006.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-007.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-008.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-009.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-010.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-011.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-012.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-013.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-014.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-empty-inline.html:
- LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-wins-001.html:
- LayoutTests/imported/w3c/web-platform-tests/svg/styling/required-properties-expected.txt:
- LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
- LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
- Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- Source/WebCore/css/CSSProperties.json:
- Source/WebCore/css/StyleProperties.cpp:
- Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):
- Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
- Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::textAlignLast const):
(WebCore::RenderStyle::textIndentType const):
(WebCore::RenderStyle::setTextAlignLast):
(WebCore::RenderStyle::setTextIndentType):
(WebCore::RenderStyle::initialTextAlignLast):
(WebCore::RenderStyle::initialTextIndentType):
- Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertTextAlignLast):
- Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyInitialTextAlignLast):
(WebCore::Style::BuilderCustom::applyValueTextAlignLast):
- Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation-overrides.json:
- Source/WebInspectorUI/UserInterface/External/CSSDocumentation/CSSDocumentation.js:
- Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:
Canonical link: https://commits.webkit.org/251116@main
- 12:19 AM Changeset in webkit [295020] by
-
- 1 edit in trunk/Tools/Scripts/update-angle
Avoid staging autogenerated commit-message.txt
https://bugs.webkit.org/show_bug.cgi?id=240967
Patch by Kenneth Russell <kbr@chromium.org> on 2022-05-29
Unstage the autogenerated commit-message.txt before exiting the
update-angle script to make it easier for the user to remove.
Reviewed by Kimmo Kinnunen.
- Source/ThirdParty/ANGLE/commit-message.txt: Added.
- Tools/Scripts/update-angle:
Canonical link: https://commits.webkit.org/251115@main
May 29, 2022:
- 12:56 PM Changeset in webkit [295019] by
-
- 1 edit in trunk/LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt
[Gardening] Rebaseline fast/dom/HTMLMeterElement/meter-element-markup.html after 9a73643
https://bugs.webkit.org/show_bug.cgi?id=240930
Unreviewed test gardening.
Just reflects the new unprefixed style.
- LayoutTests/fast/dom/HTMLMeterElement/meter-element-markup-expected.txt:
Canonical link: https://commits.webkit.org/251114@main
- 10:10 AM Changeset in webkit [295018] by
-
- 2 edits in trunk/Source/WebCore/layout/formattingContexts/inline
LineBuilder::initialConstraintsForLine needs to know whether there is previous line and if it ended with line break
https://bugs.webkit.org/show_bug.cgi?id=241062
Reviewed by Antti Koivisto.
No need to pass in the PreviousLine struct.
- Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
(WebCore::Layout::LineBuilder::computedIntrinsicWidth):
(WebCore::Layout::LineBuilder::initialConstraintsForLine const):
- Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:
Canonical link: https://commits.webkit.org/251112@main
- 10:09 AM Changeset in webkit [295017] by
-
- 2 edits in trunk/Source/WebCore/layout/formattingContexts/flex
Add basic support for justify-content
https://bugs.webkit.org/show_bug.cgi?id=241073
Reviewed by Antti Koivisto.
"justify-content" property defines how space is distributed between and around flex items along the main-axis.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::justiftFlexItems):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
Canonical link: https://commits.webkit.org/251112@main
- 8:34 AM Changeset in webkit [295016] by
-
- 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Add support for align-self
https://bugs.webkit.org/show_bug.cgi?id=241071
Reviewed by Antti Koivisto.
Align-items behavior can be overwritten for individual flex items by applying the align-self property to them.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::alignFlexItems):
Canonical link: https://commits.webkit.org/251111@main
- 7:03 AM Changeset in webkit [295015] by
-
- 2 edits in trunk/Source/WebCore/layout/formattingContexts/flex
Compute available space when ConstraintsForFlexContent does not provide one
https://bugs.webkit.org/show_bug.cgi?id=241070
Reviewed by Antti Koivisto.
e.g. if the flex box does not have fixed height in the cross axis direction, all flex items become as tall as the tallest flex item.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::computeAvailableLogicalVerticalSpace const):
(WebCore::Layout::FlexFormattingContext::computeAvailableLogicalHorizontalSpace const):
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexFormattingContext::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexFormattingContext::alignFlexItems):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
(WebCore::Layout::availableLogicalVerticalSpace): Deleted.
(WebCore::Layout::availableLogicalHorizontalSpace): Deleted.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
Canonical link: https://commits.webkit.org/251110@main
- 6:44 AM Changeset in webkit [295014] by
-
- 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Add support for flex-start/flex-end/start/end alignment
https://bugs.webkit.org/show_bug.cgi?id=241067
Reviewed by Antti Koivisto.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexFormattingContext::alignFlexItems):
Canonical link: https://commits.webkit.org/251109@main
- 6:22 AM Changeset in webkit [295013] by
-
- 2 edits in trunk/Source/WebCore/layout/formattingContexts/flex
Introduce FlexFormattingContext::alignFlexItems
https://bugs.webkit.org/show_bug.cgi?id=241064
Reviewed by Antti Koivisto.
This is cross axis alignment (add support for 'center' to showcase).
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexFormattingContext::alignFlexItems):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
Canonical link: https://commits.webkit.org/251108@main
- 1:24 AM Changeset in webkit [295012] by
-
- 1 edit in trunk/Source/WTF/wtf/CompactPtr.h
REGRESSION(251103@main): Broke GTK/WPE
https://bugs.webkit.org/show_bug.cgi?id=241076
Patch by Philippe Normand <philn@igalia.com> on 2022-05-29
Unreviewed. Fix GTK/WPE build.
- Source/WTF/wtf/CompactPtr.h:
(WTF::CompactPtr::swap):
Canonical link: https://commits.webkit.org/251107@main
- 1:14 AM Changeset in webkit [295011] by
-
- 10 edits1 add in trunk
[JSC] Async / Await should not wrap awaited value with one tick
https://bugs.webkit.org/show_bug.cgi?id=241072
Reviewed by Saam Barati.
This patch integrates spec change[1], which removes one level tick count when resolving promise with await.
Previously, regardless of whether the value is promise or not, we are always using resolveWithoutPromise,
but it introduces one tick before the handlers are resolved. The spec change makes it that we can call
performPromiseThen directly if the input value is promise, so we can skip one tick which looks up "then"
and register handlers.
This is beneficial for await performance and it also fixes a bug tested via test262 and attached test due
to the spec change.
We observed performance improvement in async + native promise tests.
ToT
Time(doxbee-async-es2017-native): 35.6 ms.
Time(fibonacci-async-es2017-native): 292.3 ms.
Time(parallel-async-es2017-native): 117.3 ms.
Patched
Time(doxbee-async-es2017-native): 24.2 ms.
Time(fibonacci-async-es2017-native): 198.1 ms.
Time(parallel-async-es2017-native): 109.5 ms.
[1]: https://github.com/tc39/ecma262/pull/1250
- JSTests/stress/async-await-basic.js:
- JSTests/stress/async-await-tick-count.js: Added.
(shouldBe):
(async returnDirectPrimitive):
(async returnAwaitPrimitive):
(async returnDirectPromisePrimitive):
(async returnAwaitPromisePrimitive):
(async test):
(async tests):
(globalThis.setUnhandledRejectionCallback.setUnhandledRejectionCallback):
- JSTests/test262/expectations.yaml:
- LayoutTests/inspector/canvas/recording-bitmaprenderer-frameCount-expected.txt:
- LayoutTests/inspector/canvas/recording-bitmaprenderer-full-expected.txt:
- LayoutTests/inspector/canvas/recording-bitmaprenderer-memoryLimit-expected.txt:
- LayoutTests/inspector/console/message-stack-trace-expected.txt:
- Source/JavaScriptCore/builtins/AsyncFromSyncIteratorPrototype.js:
- Source/JavaScriptCore/builtins/AsyncFunctionPrototype.js:
(globalPrivate.asyncFunctionResume):
- Source/JavaScriptCore/builtins/AsyncGeneratorPrototype.js:
(globalPrivate.awaitValue):
(globalPrivate.asyncGeneratorResumeNext):
- Source/JavaScriptCore/builtins/PromiseOperations.js:
(globalPrivate.newPromiseCapabilitySlow):
(globalPrivate.promiseResolve):
(globalPrivate.promiseResolveSlow):
(globalPrivate.promiseRejectSlow):
(globalPrivate.resolvePromiseWithFirstResolvingFunctionCallCheck):
(globalPrivate.fulfillPromiseWithFirstResolvingFunctionCallCheck):
(globalPrivate.rejectPromiseWithFirstResolvingFunctionCallCheck):
(globalPrivate.resolveWithoutPromiseForAsyncAwait):
Canonical link: https://commits.webkit.org/251106@main
- 12:57 AM Changeset in webkit [295010] by
-
- 35 edits in trunk
Replace CSS3_TEXT build flag with Experimental feature settings
https://bugs.webkit.org/show_bug.cgi?id=121875
Patch by Kiet Ho <Kiet Ho> on 2022-05-29
Reviewed by Tim Nguyen and Myles C. Maxfield.
Currently, -webkit-text-align-last and -webkit-text-justify are gated behind
the ENABLE(CSS3_TEXT) build flag. EWS bots doesn't enable it, hence the properties
aren't tested even though tests are available for them. This patch replaces the build
flag with two experimental settings, which is on during layout tests, allowing the
properties to be tested.
- LayoutTests/TestExpectations:
- LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- LayoutTests/platform/win/TestExpectations:
- LayoutTests/platform/wincairo/TestExpectations:
- LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
- Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:
- Source/WTF/wtf/PlatformEnable.h:
- Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
Temporarily mark -webkit-text-align-last and -webkit-text-justify as not animatable
to avoid the assert. CSS animations for those properties will be implemented in
webkit.org/b/240591.
- Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
- Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator TextJustify const):
- Source/WebCore/css/CSSProperties.json:
- Source/WebCore/css/StyleProperties.cpp:
- Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::operator==):
(WebCore::add):
(WebCore::CSSParserContext::isPropertyRuntimeDisabled const):
- Source/WebCore/css/parser/CSSParserContext.h:
- Source/WebCore/css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
- Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::LegacyLineLayout::textAlignmentForLine const):
- Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::rareInheritedDataChangeRequiresLayout):
- Source/WebCore/rendering/style/RenderStyle.h:
(WebCore::RenderStyle::textIndentType const):
(WebCore::RenderStyle::textJustify const):
(WebCore::RenderStyle::setTextIndentType):
(WebCore::RenderStyle::setTextJustify):
(WebCore::RenderStyle::initialTextIndentType):
(WebCore::RenderStyle::initialTextJustify):
- Source/WebCore/rendering/style/RenderStyleConstants.h:
- Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
- Source/WebCore/rendering/style/StyleRareInheritedData.h:
- Source/WebKitLegacy/win/WebPreferences.cpp:
(WebPreferences::cssTextAlignLastEnabled):
(WebPreferences::cssTextJustifyEnabled):
- Source/WebKitLegacy/win/WebPreferences.h:
- Source/WebKitLegacy/win/WebView.cpp:
(WebView::notifyPreferencesChanged):
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
- Tools/DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):
- Tools/Scripts/webkitperl/FeatureList.pm:
Canonical link: https://commits.webkit.org/251105@main
May 28, 2022:
- 10:09 PM Changeset in webkit [295009] by
-
- 2 edits in trunk/Source/WebCore/html/parser
Optimize href attribute lookup in TokenPreloadScanner::updatePredictedBaseURL()
https://bugs.webkit.org/show_bug.cgi?id=241051
Reviewed by Darin Adler.
Optimize href attribute lookup in TokenPreloadScanner::updatePredictedBaseURL() by avoiding
is8Bit() checks for every character of the parameter. Instead, make sure both the parameter
is aconst UChar*for fast comparison with attributes, which are stored as Vector<UChar>.
- Source/WebCore/html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):
- Source/WebCore/html/parser/HTMLToken.h:
(WebCore::findAttribute):
(WebCore::nameMatches): Deleted.
Canonical link: https://commits.webkit.org/251104@main
- 8:23 PM Changeset in webkit [295008] by
-
- 29 edits2 copies1 move3 adds in trunk
Shrink Structure to 96 Bytes when addresses can be encoded in 36-bits
https://bugs.webkit.org/show_bug.cgi?id=240407
Reviewed by Yusuke Suzuki.
We have 2% RAMification regression on iOS, which needs a memory performance
improvement. To work towards resolving this regression, this patch is to
reduce JS object's structure size from 112 bytes to 96 bytes for iOS systems.
- We can reduce 36-bit addresses into 4 bytes when dealing with pointers that
have 16-byte alignment.
- StructureID can be removed from StructureIDBlob since we can directly compute
the id by encoding the Structure pointer.
CompactPtr and CompactRefPtr classes are introduced for pointers, which can
achieve 8 bytes in MacOS and 4 bytes in iOS.
- PerformanceTests/JetStream2/RexBench/OfflineAssembler/LowLevelInterpreter64.asm:
- PerformanceTests/JetStream2/RexBench/OfflineAssembler/LowLevelInterpreter64.js:
- PerformanceTests/JetStream2/RexBench/OfflineAssembler/expected.js:
- PerformanceTests/RexBench/OfflineAssembler/LowLevelInterpreter64.asm:
- PerformanceTests/RexBench/OfflineAssembler/LowLevelInterpreter64.js:
- PerformanceTests/RexBench/OfflineAssembler/expected.js:
- Source/JavaScriptCore/CMakeLists.txt:
- Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
- Source/JavaScriptCore/bytecode/GetByValHistory.h:
(JSC::GetByValHistory::observe):
- Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:
- Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.cpp:
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
- Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.h:
- Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
- Source/JavaScriptCore/heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::genericAddPointer):
(JSC::ConservativeRoots::genericAddSpan):
- Source/JavaScriptCore/heap/ConservativeRoots.h:
- Source/JavaScriptCore/heap/HeapSnapshot.h:
- Source/JavaScriptCore/heap/HeapUtil.h:
(JSC::HeapUtil::findGCObjectPointersForMarking):
(JSC::HeapUtil::isPointerGCObjectJSCell):
(JSC::HeapUtil::isValueGCObject):
- Source/JavaScriptCore/heap/MarkedBlockSet.h:
(JSC::MarkedBlockSet::add):
(JSC::MarkedBlockSet::recomputeFilter):
(JSC::MarkedBlockSet::filter const):
- Source/JavaScriptCore/heap/TinyBloomFilter.h:
(JSC::TinyBloomFilter<Bits>::TinyBloomFilter):
(JSC::TinyBloomFilter<Bits>::add):
(JSC::TinyBloomFilter<Bits>::ruleOut const):
(JSC::TinyBloomFilter<Bits>::reset):
(JSC::TinyBloomFilter::TinyBloomFilter): Deleted.
(JSC::TinyBloomFilter::add): Deleted.
(JSC::TinyBloomFilter::ruleOut const): Deleted.
(JSC::TinyBloomFilter::reset): Deleted.
- Source/JavaScriptCore/jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitStoreStructureWithTypeInfo):
(JSC::AssemblyHelpers::emitEncodeStructure):
- Source/JavaScriptCore/jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitStoreStructureWithTypeInfo):
(JSC::AssemblyHelpers::loadCompactPtr):
(JSC::AssemblyHelpers::branchCompactPtr):
- Source/JavaScriptCore/jit/JITPropertyAccess.cpp:
(JSC::JIT::generateOpGetFromScopeThunk):
(JSC::JIT::emit_op_put_to_scope):
- Source/JavaScriptCore/runtime/ClassInfo.h:
(JSC::ClassInfo::offsetOfParentClass): Deleted.
(JSC::ClassInfo::isSubClassOf const): Deleted.
- Source/JavaScriptCore/runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::processUnverifiedStackTraces):
- Source/JavaScriptCore/runtime/Structure.cpp:
(JSC::Structure::Structure):
- Source/JavaScriptCore/runtime/Structure.h:
(JSC::Structure::id const):
(JSC::Structure::typeInfoBlob const):
(JSC::Structure::classInfoForCells const):
(JSC::Structure::indexingModeIncludingHistoryOffset):
(JSC::Structure::objectInitializationBlob const): Deleted.
(JSC::Structure::idBlob const): Deleted.
(JSC::Structure::structureIDOffset): Deleted.
- Source/JavaScriptCore/runtime/StructureInlines.h:
(JSC::Structure::get):
(JSC::Structure::add):
- Source/JavaScriptCore/runtime/TypeInfoBlob.h: Renamed from Source/JavaScriptCore/runtime/StructureIDBlob.h.
(JSC::TypeInfoBlob::TypeInfoBlob):
(JSC::TypeInfoBlob::operator=):
(JSC::TypeInfoBlob::indexingModeIncludingHistory const):
(JSC::TypeInfoBlob::fencedIndexingModeIncludingHistory):
(JSC::TypeInfoBlob::setIndexingModeIncludingHistory):
(JSC::TypeInfoBlob::type const):
(JSC::TypeInfoBlob::inlineTypeFlags const):
(JSC::TypeInfoBlob::typeInfo const):
(JSC::TypeInfoBlob::blob const):
(JSC::TypeInfoBlob::indexingModeIncludingHistoryOffset):
- Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):
- Source/WTF/WTF.xcodeproj/project.pbxproj:
- Source/WTF/wtf/CMakeLists.txt:
- Source/WTF/wtf/CompactPtr.h: Added.
(WTF::CompactPtr::CompactPtr):
(WTF::CompactPtr::operator* const):
(WTF::CompactPtr::operator-> const):
(WTF::CompactPtr::operator! const):
(WTF::CompactPtr::operator bool const):
(WTF::CompactPtr::operator=):
(WTF::CompactPtr::get const):
(WTF::CompactPtr::set):
(WTF::CompactPtr::exchange):
(WTF::CompactPtr::swap):
(WTF::CompactPtr::encode):
(WTF::CompactPtr::encode const):
(WTF::CompactPtr::decode const):
(WTF::GetPtrHelper<CompactPtr<T>>::getPtr):
(WTF::CompactPtrTraits::exchange):
(WTF::CompactPtrTraits::swap):
(WTF::CompactPtrTraits::unwrap):
(WTF::CompactPtrTraits::hashTableDeletedValue):
(WTF::CompactPtrTraits::isHashTableDeletedValue):
- Source/WTF/wtf/CompactRefPtr.h: Copied from Source/JavaScriptCore/heap/HeapSnapshot.h.
- Source/WTF/wtf/text/StringImpl.cpp:
- Source/WTF/wtf/text/StringImpl.h:
- Tools/TestWebKitAPI/CMakeLists.txt:
- Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- Tools/TestWebKitAPI/Tests/WTF/AlignedRefLogger.h: Copied from Source/JavaScriptCore/heap/TinyBloomFilter.h.
(TestWebKitAPI::DerivedAlignedRefLogger::DerivedAlignedRefLogger):
- Tools/TestWebKitAPI/Tests/WTF/CompactPtr.cpp: Added.
(TestWebKitAPI::TEST):
- Tools/TestWebKitAPI/Tests/WTF/CompactRefPtr.cpp: Added.
(TestWebKitAPI::TEST):
(TestWebKitAPI::f1):
(TestWebKitAPI::returnConstRefCountedRef):
(TestWebKitAPI::returnRefCountedRef):
(TestWebKitAPI::CompactRefPtrCheckingAlignedRefLogger::CompactRefPtrCheckingAlignedRefLogger):
(TestWebKitAPI::loggerName):
(TestWebKitAPI::CompactRefPtrCheckingAlignedRefLogger::ref):
(TestWebKitAPI::CompactRefPtrCheckingAlignedRefLogger::deref):
- Tools/TestWebKitAPI/Tests/WTF/JSONValue.cpp:
(TestWebKitAPI::TEST):
- Websites/browserbench.org/JetStream2.0/RexBench/OfflineAssembler/LowLevelInterpreter64.asm:
- Websites/browserbench.org/JetStream2.0/RexBench/OfflineAssembler/LowLevelInterpreter64.js:
- Websites/browserbench.org/JetStream2.0/RexBench/OfflineAssembler/expected.js:
Canonical link: https://commits.webkit.org/251103@main
- 7:03 PM Changeset in webkit [295007] by
-
- 1 edit in trunk/Source/WTF/wtf/text/StringBuilderJSON.cpp
Simplify / Optimize StringBuilder::appendQuotedJSONString()
https://bugs.webkit.org/show_bug.cgi?id=240955
Reviewed by Darin Adler.
This simplifies the code, makes it more consistent with the test of StringBuilder,
and appears to be a ~0.3% progression on Speedometer on Apple Silicon.
- Source/WTF/wtf/text/StringBuilderJSON.cpp:
(WTF::StringBuilder::appendQuotedJSONString):
Canonical link: https://commits.webkit.org/251102@main
- 5:11 PM Changeset in webkit [295006] by
-
- 1 edit in trunk/LayoutTests/editing/execCommand/outdent-paragraph-crash.html
Null check split node parent in outdentParagraph
https://bugs.webkit.org/show_bug.cgi?id=235914
Patch by Rob Buis <rbuis@igalia.com> on 2022-05-28
Reviewed by Ryosuke Niwa.
Changed test to use setTimeout as it more reliably causes the original crash.
- LayoutTests/editing/execCommand/outdent-paragraph-crash.html:
Canonical link: https://commits.webkit.org/251101@main
- 4:33 PM Changeset in webkit [295005] by
-
- 1 copy in tags/WebKit-7614.1.14.1.15
Tag WebKit-7614.1.14.1.15.
- 3:58 PM Changeset in webkit [295004] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.15
- 11:00 AM Changeset in webkit [295003] by
-
- 1 edit in branches/safari-613-branch/Source/WebCore/rendering/RenderElement.h
Unreviewed build fix. rdar://problem/91519558
./rendering/RenderElement.cpp:723:21:|error: out-of-line definition of 'moveLayers' does not match any declaration in 'WebCore::RenderElement'
- 10:44 AM Changeset in webkit [295002] by
-
- 6 edits1 delete in trunk/Source
Unreviewed, revert "[Xcode] Compute PGO profdata paths instead of searching for them at build time"
This reverts commit 6dfb5dc2b3bcd083231cee3cacc599ca7f76998b because of Speedometer2 3% regression.
Probably breaking PGO build.
Canonical link: https://commits.webkit.org/251100@main
- 9:31 AM Changeset in webkit [295001] by
-
- 2 edits in trunk/Source/WebCore/layout/formattingContexts/flex
Introduce FlexFormattingContext::computeLogicalHeightForFlexItems
https://bugs.webkit.org/show_bug.cgi?id=241056
Reviewed by Antti Koivisto.
This is just a very basic "let's stretch the flex items in the cross axis direction" change.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::availableLogicalVerticalSpace):
(WebCore::Layout::availableLogicalHorizontalSpace):
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexFormattingContext::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
Canonical link: https://commits.webkit.org/251099@main
- 9:18 AM Changeset in webkit [295000] by
-
- 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Transition flex-grow computation to flex-basis based
https://bugs.webkit.org/show_bug.cgi?id=241057
Reviewed by Antti Koivisto.
- Introduce StrechingFlexItem to cache growth related values
- Use flex-basis as the base for the flex grow computation
- Compute the final logical width values
(This is very similar to how we compute "shrink values".)
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForStretchingFlexItems):
Canonical link: https://commits.webkit.org/251098@main
- 6:26 AM Changeset in webkit [294999] by
-
- 40 edits in trunk/Source
Perform media networking operations off the main thread
https://bugs.webkit.org/show_bug.cgi?id=235353
rdar://84517825
Reviewed by Eric Carlson.
We run the media's networking operation and IPC service into a new dedicated WorkQueue.
Not all operation on a MediaResource can be made thread-agnostic, and the creation and shutdown of the MediaResource must still occur on the main thread due to the current architecture which forces more task dispatches than ideal.
However, all other operations will now run on a WorkQueue when the GPU Process is enabled. For WK1 we continue to use the main thread.
We use the IPC::Connection::WorkQueueMessageReceiver characteristics to proxy the network operations from the content process main thread to the GPU Process MediaResourceLoader's WorkQueue.
Some changes were required in data structures such as ResourceResponseBase, where we must use Strings over AtomStrings. A WorkQueue while guaranteeing that all tasks runs sequentially, will use different threads making the use of AtomStrings impossible.
RemoteMediaResourceManager now holds a strong reference to the RemoteMediaResource, to clear that reference and to make the call more explicit we rename PlatformMediaResource::stop into PlatformMediaResource::shutdown()
A call to shutdown() is equivalent to the previous call to stop() followed by setClient(nullptr).
Side-by fixes: various thread-safety fixes in WebCoreNSURLSession, access to some members weren't thread-safe.
To make the code flow easier to follow, we use the new assertIsCurrent(WorkQueue&) extensively. Most methods will now assert that it runs on the thread it's supposed to.
- Source/WebCore/Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::create):
- Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readServerHandshake):
(WebCore::WebSocketHandshake::readStatusLine):
- Source/WebCore/Modules/websockets/WebSocketHandshake.h:
- Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::interceptWithResponse):
(WebCore::InspectorNetworkAgent::interceptRequestWithResponse):
- Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setResponseMIMEType):
- Source/WebCore/loader/DocumentLoader.h:
- Source/WebCore/loader/MediaResourceLoader.cpp:
(WebCore::MediaResource::MediaResource):
(WebCore::MediaResource::~MediaResource):
(WebCore::MediaResource::shutdown):
(WebCore::MediaResource::responseReceived):
(WebCore::MediaResource::shouldCacheResponse):
(WebCore::MediaResource::redirectReceived):
(WebCore::MediaResource::dataSent):
(WebCore::MediaResource::dataReceived):
(WebCore::MediaResource::notifyFinished):
(WebCore::MediaResource::ensureShutdown):
(WebCore::MediaResource::stop): Deleted.
- Source/WebCore/loader/MediaResourceLoader.h:
- Source/WebCore/loader/cache/CachedRawResourceClient.h:
- Source/WebCore/platform/graphics/PlatformMediaResourceLoader.h:
(WebCore::PlatformMediaResourceLoader::targetQueue):
(WebCore::PlatformMediaResource::shutdown):
(WebCore::PlatformMediaResource::didPassAccessControlCheck const):
(WebCore::PlatformMediaResource::setClient):
(WebCore::PlatformMediaResource::client const):
(WebCore::PlatformMediaResource::stop): Deleted.
(WebCore::PlatformMediaResource::client): Deleted.
- Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::didCancelLoadingRequest):
(WebCore::MediaPlayerPrivateAVFoundationObjC::didStopLoadingRequest):
(WebCore::MediaPlayerPrivateAVFoundationObjC::didPassCORSAccessCheck const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::wouldTaintOrigin const):
- Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
- Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::CachedResourceMediaLoader::responseReceived):
(WebCore::PlatformResourceMediaLoader::create):
(WebCore::PlatformResourceMediaLoader::PlatformResourceMediaLoader):
(WebCore::PlatformResourceMediaLoader::stop):
(WebCore::PlatformResourceMediaLoader::responseReceived):
(WebCore::PlatformResourceMediaLoader::loadFailed):
(WebCore::PlatformResourceMediaLoader::loadFinished):
(WebCore::PlatformResourceMediaLoader::dataReceived):
(WebCore::DataURLResourceMediaLoader::DataURLResourceMediaLoader):
(WebCore::WebCoreAVFResourceLoader::create):
(WebCore::WebCoreAVFResourceLoader::WebCoreAVFResourceLoader):
(WebCore::WebCoreAVFResourceLoader::~WebCoreAVFResourceLoader):
(WebCore::WebCoreAVFResourceLoader::startLoading):
(WebCore::WebCoreAVFResourceLoader::stopLoading):
(WebCore::WebCoreAVFResourceLoader::responseReceived):
(WebCore::WebCoreAVFResourceLoader::loadFailed):
(WebCore::WebCoreAVFResourceLoader::loadFinished):
(WebCore::WebCoreAVFResourceLoader::newDataStoredInSharedBuffer):
(WebCore::WebCoreAVFResourceLoader::invalidate): Deleted.
- Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(stopLoaderIfNeeded):
(webKitWebSrcUnLock):
(webKitSrcWouldTaintOrigin):
- Source/WebCore/platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::crossThreadData const):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::mimeType const):
(WebCore::ResourceResponseBase::setMimeType):
(WebCore::ResourceResponseBase::textEncodingName const):
(WebCore::ResourceResponseBase::setTextEncodingName):
(WebCore::ResourceResponseBase::httpStatusText const):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpVersion const):
(WebCore::ResourceResponseBase::setHTTPVersion):
- Source/WebCore/platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::decode):
- Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::cfURLResponse const):
(WebCore::ResourceResponse::platformLazyInit):
- Source/WebCore/platform/network/cocoa/RangeResponseGenerator.h:
(WebCore::RangeResponseGenerator::create):
- Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm:
(WebCore::RangeResponseGenerator::Data::Data):
(WebCore::RangeResponseGenerator::Data::~Data):
(WebCore::RangeResponseGenerator::Data::shutdownResource):
(WebCore::RangeResponseGenerator::RangeResponseGenerator):
(WebCore::synthesizedResponseForRange):
(WebCore::RangeResponseGenerator::removeTask):
(WebCore::RangeResponseGenerator::giveResponseToTaskIfBytesInRangeReceived):
(WebCore::RangeResponseGenerator::expectedContentLengthFromData):
(WebCore::RangeResponseGenerator::giveResponseToTasksWithFinishedRanges):
(WebCore::RangeResponseGenerator::willHandleRequest):
(WebCore::RangeResponseGenerator::willSynthesizeRangeResponses):
(WebCore::RangeResponseGenerator::~RangeResponseGenerator): Deleted.
- Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.h:
- Source/WebCore/platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSessionTaskTransactionMetrics _initWithMetrics:onTarget:]):
(-[WebCoreNSURLSessionTaskTransactionMetrics dealloc]):
(-[WebCoreNSURLSessionTaskMetrics _initWithMetrics:onTarget:]):
(-[WebCoreNSURLSessionTaskMetrics dealloc]):
(-[WebCoreNSURLSessionTaskMetrics transactionMetrics]):
(-[WebCoreNSURLSession initWithResourceLoader:delegate:delegateQueue:]):
(-[WebCoreNSURLSession dealloc]):
(-[WebCoreNSURLSession taskCompleted:]):
(-[WebCoreNSURLSession addDelegateOperation:]):
(-[WebCoreNSURLSession task:didReceiveCORSAccessCheckResult:]):
(-[WebCoreNSURLSession task:didReceiveResponseFromOrigin:]):
(-[WebCoreNSURLSession rangeResponseGenerator]):
(-[WebCoreNSURLSession didPassCORSAccessChecks]):
(-[WebCoreNSURLSession finishTasksAndInvalidate]):
(-[WebCoreNSURLSession dataTaskWithRequest:]):
(-[WebCoreNSURLSession sendH2Ping:pongHandler:]):
(WebCore::WebCoreNSURLSessionDataTaskClient::WebCoreNSURLSessionDataTaskClient):
(WebCore::WebCoreNSURLSessionDataTaskClient::clearTask):
(WebCore::WebCoreNSURLSessionDataTaskClient::dataSent):
(WebCore::WebCoreNSURLSessionDataTaskClient::responseReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::shouldCacheResponse):
(WebCore::WebCoreNSURLSessionDataTaskClient::dataReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::redirectReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::accessControlCheckFailed):
(WebCore::WebCoreNSURLSessionDataTaskClient::loadFailed):
(WebCore::WebCoreNSURLSessionDataTaskClient::loadFinished):
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:targetQueue:]):
(-[WebCoreNSURLSessionDataTask _cancel:]):
(-[WebCoreNSURLSessionDataTask error]):
(-[WebCoreNSURLSessionDataTask session]):
(-[WebCoreNSURLSessionDataTask setSession:]):
(-[WebCoreNSURLSessionDataTask resource]):
(-[WebCoreNSURLSessionDataTask setResource:]):
(-[WebCoreNSURLSessionDataTask cancel]):
(-[WebCoreNSURLSessionDataTask suspend]):
(-[WebCoreNSURLSessionDataTask resume]):
(-[WebCoreNSURLSessionDataTask dealloc]):
(-[WebCoreNSURLSessionDataTask resource:sentBytes:totalBytesToBeSent:]):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:completionHandler:]):
(-[WebCoreNSURLSessionDataTask resource:shouldCacheResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedData:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:completionHandler:]):
(-[WebCoreNSURLSessionDataTask _resource:loadFinishedWithError:metrics:]):
(-[WebCoreNSURLSessionDataTask resource:accessControlCheckFailedWithError:]):
(-[WebCoreNSURLSessionDataTask resource:loadFailedWithError:]):
(-[WebCoreNSURLSessionDataTask resourceFinished:metrics:]):
(-[WebCoreNSURLSessionTaskTransactionMetrics _initWithMetrics:]): Deleted.
(-[WebCoreNSURLSessionTaskMetrics _initWithMetrics:]): Deleted.
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:]): Deleted.
(-[WebCoreNSURLSessionDataTask _restart]): Deleted.
(-[WebCoreNSURLSessionDataTask _cancel]): Deleted.
- Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::setResponseFromCachedHeaders):
- Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::handleDataURL):
- Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::setStatusLine):
- Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::ResourceResponse):
- Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::didClose):
(WebKit::GPUConnectionToWebProcess::remoteMediaResourceManager):
- Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::requestResource):
- Source/WebKit/GPUProcess/media/RemoteMediaResource.cpp:
(WebKit::RemoteMediaResource::RemoteMediaResource):
(WebKit::RemoteMediaResource::~RemoteMediaResource):
(WebKit::RemoteMediaResource::shutdown):
(WebKit::RemoteMediaResource::didPassAccessControlCheck const):
(WebKit::RemoteMediaResource::responseReceived):
(WebKit::RemoteMediaResource::redirectReceived):
(WebKit::RemoteMediaResource::dataSent):
(WebKit::RemoteMediaResource::dataReceived):
(WebKit::RemoteMediaResource::accessControlCheckFailed):
(WebKit::RemoteMediaResource::loadFailed):
(WebKit::RemoteMediaResource::loadFinished):
(WebKit::RemoteMediaResource::stop): Deleted.
- Source/WebKit/GPUProcess/media/RemoteMediaResource.h:
- Source/WebKit/GPUProcess/media/RemoteMediaResourceLoader.cpp:
(WebKit::RemoteMediaResourceLoader::RemoteMediaResourceLoader):
(WebKit::RemoteMediaResourceLoader::requestResource):
(WebKit::RemoteMediaResourceLoader::sendH2Ping):
- Source/WebKit/GPUProcess/media/RemoteMediaResourceLoader.h:
- Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.cpp:
(WebKit::RemoteMediaResourceManager::~RemoteMediaResourceManager):
(WebKit::RemoteMediaResourceManager::stopListeningForIPC):
(WebKit::RemoteMediaResourceManager::initializeConnection):
(WebKit::RemoteMediaResourceManager::addMediaResource):
(WebKit::RemoteMediaResourceManager::removeMediaResource):
(WebKit::RemoteMediaResourceManager::resourceForIdAndReady):
(WebKit::RemoteMediaResourceManager::responseReceived):
(WebKit::RemoteMediaResourceManager::redirectReceived):
(WebKit::RemoteMediaResourceManager::dataSent):
(WebKit::RemoteMediaResourceManager::dataReceived):
(WebKit::RemoteMediaResourceManager::accessControlCheckFailed):
(WebKit::RemoteMediaResourceManager::loadFailed):
(WebKit::RemoteMediaResourceManager::loadFinished):
- Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.h:
- Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponse):
- Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:
(WebKit::ServiceWorkerFetchTask::processResponse):
- Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::didGetFileInfo):
- Source/WebKit/Shared/API/glib/WebKitURIResponse.cpp:
(webkit_uri_response_get_mime_type):
- Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp:
(webkitURISchemeRequestReadCallback):
- Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::~MediaPlayerPrivateRemote):
(WebKit::MediaPlayerPrivateRemote::removeResource):
- Source/WebKit/WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveData):
- Source/WebKit/WebProcess/Network/WebResourceLoader.h:
Canonical link: https://commits.webkit.org/251097@main
- 6:22 AM Changeset in webkit [294998] by
-
- 1 copy in releases/WPE WebKit/webkit-2.36.3
WPE WebKit 2.36.3
- 6:21 AM Changeset in webkit [294997] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.36.3 release
.:
- Source/cmake/OptionsWPE.cmake: Bump version numbers.
Source/WebKit:
- wpe/NEWS: Add release notes for 2.36.3.
- 6:21 AM Changeset in webkit [294996] by
-
- 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Use flex-basis when shrinking flex items
https://bugs.webkit.org/show_bug.cgi?id=241046
Reviewed by Antti Koivisto.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForShrinkingFlexItems):
Canonical link: https://commits.webkit.org/251096@main
- 6:06 AM Changeset in webkit [294995] by
-
- 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Introduce the concept of frozen flex items
https://bugs.webkit.org/show_bug.cgi?id=241034
Reviewed by Antti Koivisto.
When a shrinking flex item gets too small, we exclude it from the shrinking algorithm and recompute the shrink factor. However the new shrink factor could make additional flex items too small.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForShrinkingFlexItems):
Canonical link: https://commits.webkit.org/251095@main
- 5:43 AM Changeset in webkit [294994] by
-
- 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Introduce ShrinkingFlexItem structure
https://bugs.webkit.org/show_bug.cgi?id=241033
Reviewed by Antti Koivisto.
This local structure caches some of the shrinking related values.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForShrinkingFlexItems):
Canonical link: https://commits.webkit.org/251094@main
- 3:43 AM Changeset in webkit [294993] by
-
- 5 edits in trunk/Source/WebCore/bindings/js
REGRESSION(251082@main): Broke WPE/GTK builds
https://bugs.webkit.org/show_bug.cgi?id=241060
Patch by Philippe Normand <philn@igalia.com> on 2022-05-28
Unreviewed, fix WPE/GTK builds by including new WebCoreOpaqueRoot header in custom JS bindings.
- Source/WebCore/bindings/js/JSDOMQuadCustom.cpp:
- Source/WebCore/bindings/js/JSNavigatorCustom.cpp:
- Source/WebCore/bindings/js/JSServiceWorkerGlobalScopeCustom.cpp:
- Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp:
- Source/WebCore/bindings/js/JSWorkerNavigatorCustom.cpp:
Canonical link: https://commits.webkit.org/251093@main
- 2:11 AM Changeset in webkit [294992] by
-
- 1 copy in releases/WebKitGTK/webkit-2.36.3
WebKitGTK 2.36.3
- 2:10 AM Changeset in webkit [294991] by
-
- 4 edits in releases/WebKitGTK/webkit-2.36
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.36.3 release
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
- gtk/NEWS: Add release notes for 2.36.3.
- 2:10 AM Changeset in webkit [294990] by
-
- 2 edits in releases/WebKitGTK/webkit-2.36/Source
Merge r294939 - Non unified build fixes, lateish May 2022 edition
https://bugs.webkit.org/show_bug.cgi?id=241019
Unreviewed build fixes.
- Source/JavaScriptCore/wasm/js/WasmToJS.cpp: Add missing JSCJSValueInlines.h header inclusion.
- Source/WebCore/platform/audio/MultiChannelResampler.cpp: Add missing <functional> header inclusion, needed for std::bind().
Canonical link: https://commits.webkit.org/251050@main
- 2:10 AM Changeset in webkit [294989] by
-
- 3 edits in releases/WebKitGTK/webkit-2.36/Source
Merge r294881 - Cannot link WebKitTestRunner in non-unified builds
https://bugs.webkit.org/show_bug.cgi?id=240755
Reviewed by Adrian Perez de Castro.
In GTK non-unified build, WebKit shared library didn't export all
WEBCORE_EXPORT marked WebCore symbols because WebCore was a static
library.
WebCore should be an SHARED or OBJECT library to work WEBCORE_EXPORT
macro as expected.
- Source/WebCore/PlatformGTK.cmake:
- Source/WebCore/page/gtk/DragControllerGtk.cpp:
- Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsWPE.cmake:
Canonical link: https://commits.webkit.org/251011@main
- 1:07 AM Changeset in webkit [294988] by
-
- 1 edit in trunk/Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.mm
CRASH: Exception thrown from QueuedVideoOutput::invalidate
https://bugs.webkit.org/show_bug.cgi?id=241052
<rdar://93953827>
Reviewed by Eric Carlson.
- Source/WebCore/platform/graphics/avfoundation/objc/QueuedVideoOutput.mm:
(WebCore::QueuedVideoOutput::QueuedVideoOutput):
An Objective-C exception is thrown from -removeObserver: stating the observer
was never added in the first place. Clear out ivars in the early return to avoid
doing work in invalidate() which (in addition to being unnecessary) will trigger
the exception.
Canonical link: https://commits.webkit.org/251092@main
May 27, 2022:
- 10:25 PM Changeset in webkit [294987] by
-
- 4 edits in trunk/Source/WebKit/UIProcess
Use desktop User Agent when preconnecting for loads that are predicted to use desktop content mode
https://bugs.webkit.org/show_bug.cgi?id=240938
Reviewed by Geoffrey Garen.
- Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _preconnectToServer:]):
- Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::preconnectTo):
- Source/WebKit/UIProcess/WebPageProxy.h:
- Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::useDesktopClassBrowsing const):
(WebKit::WebPageProxy::predictedUserAgentForRequest const):
(WebKit::WebPageProxy::effectiveContentModeAfterAdjustingPolicies):
- Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::predictedUserAgentForRequest const):
Canonical link: https://commits.webkit.org/251091@main
- 10:24 PM Changeset in webkit [294986] by
-
- 1 edit in trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
Trigger element fullscreen video extraction after the
seekedevent
https://bugs.webkit.org/show_bug.cgi?id=241053
Reviewed by Devin Rousso.
- Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::handleEvent):
(WebKit::WebFullScreenManager::setMainVideoElement):
Canonical link: https://commits.webkit.org/251090@main
- 9:30 PM Changeset in webkit [294985] by
-
- 1 edit in trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js
Web Inspector: CSS property name counts should be updated atomically
https://bugs.webkit.org/show_bug.cgi?id=240994
Reviewed by Patrick Angle.
Consider the following example:
`
display: foo;
display: bar;
`
Before this change, the following would happen:
- get the cached count of
display: foo - increment the cached count of
display: fooby 1 - get the stored count of
display: foo - get the cached count of
display: bar - increment the cached count of
display: barby 1 - get the stored count of
display: bar
(async)
- increment the stored count of
display: foo(from c) by 1
(async)
- increment the stored count of
display: bar(from f) by 1
The problem is that g/h get the same stored count because c/f happened before any updates occurred.
After this change, the following would happen:
- get the cached count of
display: foo - increment the cached count of
display: fooby 1 - get the cached count of
display: bar - increment the cached count of
display: barby 1
(async)
- get the stored count of
display: foo
(async)
- increment the stored count of
display: foo(from e) by 1
(async)
- get the stored count of
display: bar
(async)
- increment the stored count of
display: bar(from g) by 1
By ensuring there is never more than one active operation on
WI.objectStores.cssPropertyNameCounts
at a time, it is guaranteed that values will never be trampled over (though it takes a bit longer).
- Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:
(WI.CSSProperty._initializePropertyNameCounts):
(WI.CSSProperty.prototype._updateName.changeCount):
Canonical link: https://commits.webkit.org/251089@main
- 9:22 PM Changeset in webkit [294984] by
-
- 1 edit in trunk/Source/WebCore/html/InputType.cpp
Optimize InputType::create() by reducing calls to AtomString::convertToASCIILowercase()
https://bugs.webkit.org/show_bug.cgi?id=241043
Reviewed by Cameron McCormack.
In the common case, InputType::create() gets called with a
typestring that
is already lowercase. As a result, we would iterate over the whole string
unnecessarily under convertToASCIILowercase() to verify that it is already
lowercase, just to look up the type in a HashMap.
To avoid this, we now trying to look up the type in the HashMap directly, and
only fallback to calling convertToASCIILowercase() in the rare case where the
look up failed.
On my Apple Silicon MacBook Pro, this reduces the number of samples under
convertToASCIILowercase() from 17 to 4. Also reduces the number of samples
under InputType::create() from 21 to 12.
- Source/WebCore/html/InputType.cpp:
(WebCore::createInputTypeFactoryMap):
(WebCore::findFactory):
(WebCore::InputType::create):
Canonical link: https://commits.webkit.org/251088@main
- 9:10 PM Changeset in webkit [294983] by
-
- 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
Introduce base-size to the flex algorithm
https://bugs.webkit.org/show_bug.cgi?id=241001
Reviewed by Antti Koivisto.
This is in preparation for supporting flex-basis, where the flex-basis value is used as the base for flexing.
- Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexFormattingContext::computeLogicalWidthForFlexItems):
Canonical link: https://commits.webkit.org/251087@main
- 9:05 PM Changeset in webkit [294982] by
-
- 3 edits in trunk/Source/WebKit
Rename the WebKit2
Imagelogging category toImageAnalysis
https://bugs.webkit.org/show_bug.cgi?id=241032
Reviewed by Devin Rousso.
This existing logging category is only used for image analysis -- as such, the logging category
should be renamed to reflect that. This also avoids confusing these logs with the Images logging
category in WebCore, which is really about image decoding, rendering and painting.
No change in behavior.
- Source/WebKit/Platform/Logging.h:
- Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::requestTextRecognition):
(WebKit::WebViewImpl::computeHasVisualSearchResults):
(WebKit::WebViewImpl::installImageAnalysisOverlayView): Deleted.
(WebKit::WebViewImpl::uninstallImageAnalysisOverlayView): Deleted.
- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _cancelImageAnalysis]):
(-[WKContentView validateImageAnalysisRequestIdentifier:]):
(-[WKContentView imageAnalysisGestureDidBegin:]):
(-[WKContentView _completeImageAnalysisRequestForContextMenu:requestIdentifier:hasTextResults:]):
(-[WKContentView imageAnalysisGestureDidTimeOut:]):
(-[WKContentView installImageAnalysisInteraction:]): Deleted.
(-[WKContentView uninstallImageAnalysisInteraction]): Deleted.
Canonical link: https://commits.webkit.org/251086@main
- 8:37 PM Changeset in webkit [294981] by
-
- 7 edits in trunk/Source/WebCore
Fix sense of the display list AsTextFlags
https://bugs.webkit.org/show_bug.cgi?id=240939
Reviewed by Simon Fraser.
They do the opposite of what their names suggest.
- Source/WebCore/platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::shouldDumpForFlags):
(WebCore::DisplayList::DisplayList::dump const):
- Source/WebCore/platform/graphics/displaylists/DisplayListItemType.h:
- Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::dumpItem):
- Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::operator<<):
- Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::displayListForElement):
(WebCore::Internals::replayDisplayListForElement):
(WebCore::Internals::cachedGlyphDisplayListsForTextNode):
- Source/WebCore/testing/Internals.h:
- Source/WebCore/testing/Internals.idl:
Canonical link: https://commits.webkit.org/251085@main
- 8:16 PM Changeset in webkit [294980] by
-
- 4 edits in trunk/Source/WebCore/dom
Remove some unnecessary work from the Node destructor
https://bugs.webkit.org/show_bug.cgi?id=241035
Reviewed by Geoffrey Garen.
Remove some unnecessary work from the Node destructor as it shows on
Speedometer profiles.
In particular, stop calling clearRareData() as this is just clearing a data
member. Also move work that only applies to non-ContainerNode to the Text
and CharacterData destructors since those are the only two non-ContainerNodes.
- Source/WebCore/dom/Attr.cpp:
(WebCore::Attr::~Attr):
- Source/WebCore/dom/CharacterData.cpp:
(WebCore::CharacterData::~CharacterData):
- Source/WebCore/dom/CharacterData.h:
- Source/WebCore/dom/Node.cpp:
(WebCore::Node::~Node):
Canonical link: https://commits.webkit.org/251084@main
- 8:13 PM Changeset in webkit [294979] by
-
- 3 edits in trunk
Fix typo in ConcatenateCTM display list item serialization
https://bugs.webkit.org/show_bug.cgi?id=240935
Reviewed by Simon Fraser.
- LayoutTests/displaylists/extent-includes-transforms-expected.txt:
- LayoutTests/platform/mac-wk1/displaylists/extent-includes-transforms-expected.txt:
- Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::operator<<):
Canonical link: https://commits.webkit.org/251083@main
- 7:40 PM Changeset in webkit [294978] by
-
- 131 edits1 add1 delete in trunk/Source/WebCore
Refactor opaque root logic in WebCore in preparation for Node GC optimizations
https://bugs.webkit.org/show_bug.cgi?id=240998
Reviewed by Geoffrey Garen.
Refactor opaque root logic in WebCore in preparation for Node GC optimizations.
Introduce addWebCoreOpaqueRoot() / containsWebCoreOpaqueRoot() functions for
WebCore to deal with opaque roots, instead of interacting with the SlotVisitor
directly. This introduce a nice central point in WebCore where we will be
able to set / check flags on Node to speed up GC.
Also introduce a WebCoreOpaqueRoot type to replace
void*as type of opaque
roots in WebCore. This is useful because we will need to know whether an
opaque root in a Node or not in a future patch.
There is no expected behavior change from this patch, this is just pure
refactoring to make it a lot easier for us to optimize Node gargabe collection.
- Source/WebCore/Modules/fetch/FetchRequest.cpp:
(WebCore::root):
- Source/WebCore/Modules/fetch/FetchRequest.h:
- Source/WebCore/Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::opaqueRoot):
(WebCore::root):
- Source/WebCore/Modules/indexeddb/IDBIndex.h:
- Source/WebCore/Modules/indexeddb/IDBIndex.idl:
- Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::visitReferencedIndexes const):
(WebCore::root):
- Source/WebCore/Modules/indexeddb/IDBObjectStore.h:
- Source/WebCore/Modules/indexeddb/IDBRequest.cpp:
(WebCore::root):
- Source/WebCore/Modules/indexeddb/IDBRequest.h:
- Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::visitReferencedObjectStores const):
- Source/WebCore/Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::opaqueRoot):
- Source/WebCore/Modules/mediasource/SourceBuffer.h:
- Source/WebCore/Modules/mediasource/SourceBufferList.cpp:
(WebCore::root):
- Source/WebCore/Modules/mediasource/SourceBufferList.h:
- Source/WebCore/Modules/remoteplayback/RemotePlayback.cpp:
(WebCore::RemotePlayback::opaqueRootConcurrently const):
- Source/WebCore/Modules/remoteplayback/RemotePlayback.h:
- Source/WebCore/Modules/webaudio/AudioBuffer.cpp:
(WebCore::root):
- Source/WebCore/Modules/webaudio/AudioBuffer.h:
- Source/WebCore/Modules/webaudio/AudioWorkletGlobalScope.cpp:
(WebCore::AudioWorkletGlobalScope::visitProcessors):
- Source/WebCore/Modules/webaudio/AudioWorkletProcessor.cpp:
(WebCore::root):
- Source/WebCore/Modules/webaudio/AudioWorkletProcessor.h:
- Source/WebCore/Modules/webxr/WebXRSession.cpp:
(WebCore::root):
- Source/WebCore/Modules/webxr/WebXRSession.h:
- Source/WebCore/Sources.txt:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Source/WebCore/bindings/js/JSAbortSignalCustom.cpp:
(WebCore::JSAbortSignalOwner::isReachableFromOpaqueRoots):
- Source/WebCore/bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSAudioBufferSourceNodeCustom.cpp:
(WebCore::JSAudioBufferSourceNode::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSCSSRuleCustom.cpp:
(WebCore::JSCSSRule::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSCSSRuleCustom.h:
(WebCore::root):
- Source/WebCore/bindings/js/JSCSSRuleListCustom.cpp:
(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):
- Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::root):
(WebCore::JSCSSStyleDeclaration::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.h:
- Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::JSCanvasRenderingContext2DOwner::isReachableFromOpaqueRoots):
(WebCore::JSCanvasRenderingContext2D::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSDOMQuadCustom.cpp:
(WebCore::JSDOMQuad::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSDeprecatedCSSOMValueCustom.cpp:
(WebCore::JSDeprecatedCSSOMValueOwner::isReachableFromOpaqueRoots):
- Source/WebCore/bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSFetchEventCustom.cpp:
(WebCore::JSFetchEvent::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSHTMLTemplateElementCustom.cpp:
(WebCore::JSHTMLTemplateElement::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSIDBCursorCustom.cpp:
(WebCore::JSIDBCursor::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSIDBIndexCustom.cpp: Removed.
(WebCore::JSIDBIndex::visitAdditionalChildren): Deleted.
- Source/WebCore/bindings/js/JSIntersectionObserverCustom.cpp:
(WebCore::JSIntersectionObserver::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSIntersectionObserverEntryCustom.cpp:
(WebCore::JSIntersectionObserverEntry::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSMediaListCustom.h:
(WebCore::root):
- Source/WebCore/bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSNavigatorCustom.cpp:
(WebCore::JSNavigator::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSNodeCustom.cpp:
(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
(WebCore::JSNode::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSNodeCustom.h:
(WebCore::root):
- Source/WebCore/bindings/js/JSNodeIteratorCustom.cpp:
(WebCore::JSNodeIterator::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
- Source/WebCore/bindings/js/JSOffscreenCanvasRenderingContext2DCustom.cpp:
(WebCore::root):
(WebCore::JSOffscreenCanvasRenderingContext2DOwner::isReachableFromOpaqueRoots):
(WebCore::JSOffscreenCanvasRenderingContext2D::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSPaintRenderingContext2DCustom.cpp:
(WebCore::root):
(WebCore::JSPaintRenderingContext2DOwner::isReachableFromOpaqueRoots):
(WebCore::JSPaintRenderingContext2D::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSResizeObserverEntryCustom.cpp:
(WebCore::JSResizeObserverEntry::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSSVGViewSpecCustom.cpp:
(WebCore::JSSVGViewSpec::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSServiceWorkerGlobalScopeCustom.cpp:
(WebCore::JSServiceWorkerGlobalScope::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheet::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSStyleSheetCustom.h:
(WebCore::root):
- Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:
(WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots):
(WebCore::JSTextTrackCue::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSTreeWalkerCustom.cpp:
(WebCore::JSTreeWalker::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSUndoItemCustom.cpp:
(WebCore::JSUndoItemOwner::isReachableFromOpaqueRoots):
- Source/WebCore/bindings/js/JSWebGL2RenderingContextCustom.cpp:
(WebCore::JSWebGL2RenderingContext::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSWebXRSessionCustom.cpp:
(WebCore::JSWebXRSession::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp:
(WebCore::JSWorkerGlobalScope::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSWorkerNavigatorCustom.cpp:
(WebCore::JSWorkerNavigator::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitAdditionalChildren):
- Source/WebCore/bindings/js/JSXPathResultCustom.cpp:
(WebCore::JSXPathResult::visitAdditionalChildren):
- Source/WebCore/bindings/js/WebCoreOpaqueRoot.h: Added.
(WebCore::WebCoreOpaqueRoot::WebCoreOpaqueRoot):
(WebCore::WebCoreOpaqueRoot::isNode const):
(WebCore::WebCoreOpaqueRoot::pointer const):
(WebCore::addWebCoreOpaqueRoot):
(WebCore::containsWebCoreOpaqueRoot):
- Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- Source/WebCore/bindings/scripts/test/JS/JSTestGenerateAddOpaqueRoot.cpp:
(WebCore::JSTestGenerateAddOpaqueRoot::visitChildrenImpl):
- Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachableOwner::isReachableFromOpaqueRoots):
- Source/WebCore/crypto/CryptoKey.cpp:
(WebCore::root):
- Source/WebCore/crypto/CryptoKey.h:
- Source/WebCore/dom/AbortController.cpp:
(WebCore::AbortController::opaqueRoot):
- Source/WebCore/dom/AbortController.h:
- Source/WebCore/dom/AbortController.idl:
- Source/WebCore/dom/AbortSignal.cpp:
(WebCore::root):
- Source/WebCore/dom/AbortSignal.h:
- Source/WebCore/dom/DOMPointReadOnly.cpp:
(WebCore::root):
- Source/WebCore/dom/DOMPointReadOnly.h:
- Source/WebCore/dom/DOMRectReadOnly.cpp:
(WebCore::root):
- Source/WebCore/dom/DOMRectReadOnly.h:
- Source/WebCore/dom/DocumentInlines.h:
(WebCore::Node::opaqueRoot const):
- Source/WebCore/dom/MessagePort.cpp:
(WebCore::root):
- Source/WebCore/dom/MessagePort.h:
- Source/WebCore/dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::isReachableFromOpaqueRoots const):
- Source/WebCore/dom/MutationRecord.cpp:
- Source/WebCore/dom/Node.cpp:
(WebCore::Node::traverseToOpaqueRoot const):
- Source/WebCore/dom/Node.h:
(WebCore::Node::opaqueRoot const): Deleted.
- Source/WebCore/dom/NodeFilter.h:
(WebCore::root):
- Source/WebCore/dom/Range.cpp:
(WebCore::Range::visitNodesConcurrently const):
- Source/WebCore/dom/ScriptExecutionContext.cpp:
(WebCore::root):
- Source/WebCore/dom/ScriptExecutionContext.h:
- Source/WebCore/dom/StaticRange.cpp:
(WebCore::StaticRange::visitNodesConcurrently const):
- Source/WebCore/fileapi/Blob.cpp:
(WebCore::root):
- Source/WebCore/fileapi/Blob.h:
- Source/WebCore/html/CanvasBase.cpp:
(WebCore::root):
- Source/WebCore/html/CanvasBase.h:
- Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::root):
- Source/WebCore/html/HTMLCanvasElement.h:
- Source/WebCore/html/HTMLMediaElement.h:
- Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::addMembersToOpaqueRoots):
- Source/WebCore/html/canvas/WebGLFramebuffer.cpp:
- Source/WebCore/html/canvas/WebGLObject.cpp:
(WebCore::root):
- Source/WebCore/html/canvas/WebGLObject.h:
- Source/WebCore/html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::addMembersToOpaqueRoots):
- Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::addMembersToOpaqueRoots):
(WebCore::root):
- Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
- Source/WebCore/html/canvas/WebGLTransformFeedback.cpp:
(WebCore::WebGLTransformFeedback::addMembersToOpaqueRoots):
- Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.cpp:
(WebCore::WebGLVertexArrayObjectBase::addMembersToOpaqueRoots):
(WebCore::root):
- Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.h:
- Source/WebCore/html/track/TrackBase.cpp:
(WebCore::TrackBase::opaqueRoot):
- Source/WebCore/html/track/TrackBase.h:
(WebCore::root):
- Source/WebCore/html/track/TrackListBase.cpp:
(WebCore::TrackListBase::opaqueRoot):
- Source/WebCore/html/track/TrackListBase.h:
(WebCore::root):
- Source/WebCore/page/DOMWindow.cpp:
(WebCore::root):
- Source/WebCore/page/DOMWindow.h:
- Source/WebCore/page/IntersectionObserver.cpp:
(WebCore::IntersectionObserver::isReachableFromOpaqueRoots const):
- Source/WebCore/page/NavigatorBase.cpp:
(WebCore::root):
- Source/WebCore/page/NavigatorBase.h:
- Source/WebCore/page/ResizeObserver.cpp:
(WebCore::ResizeObserver::isReachableFromOpaqueRoots const):
- Source/WebCore/workers/WorkerLocation.cpp:
(WebCore::root):
- Source/WebCore/workers/WorkerLocation.h:
(WebCore::WorkerLocation::create):
(WebCore::WorkerLocation::url const):
(WebCore::WorkerLocation::WorkerLocation):
- Source/WebCore/workers/service/ServiceWorkerClients.cpp:
(WebCore::root):
- Source/WebCore/workers/service/ServiceWorkerClients.h:
- Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:
(WebCore::root):
- Source/WebCore/workers/service/ServiceWorkerRegistration.h:
- Source/WebCore/xml/XMLHttpRequestUpload.cpp:
(WebCore::root):
- Source/WebCore/xml/XMLHttpRequestUpload.h:
Canonical link: https://commits.webkit.org/251082@main
- 7:19 PM Changeset in webkit [294977] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm
WKHTTPCookieStore tests should use removeDataOfTypes to delete all cookies
https://bugs.webkit.org/show_bug.cgi?id=240726
Reviewed by Sihui Liu.
Call WKWebsiteDataStore.removeDataOfTypes when to clear all cookies
instead of deleting them one by one. Besides simplifying the code it
documents the API recommended for the clients.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
(clearCookies):
(TEST):
(deleteCookies): Deleted.
Canonical link: https://commits.webkit.org/251081@main
- 7:12 PM Changeset in webkit [294976] by
-
- 1 edit in trunk/Source/WebCore/html/HTMLAttachmentElement.cpp
[WK2] Attachment icons do not update after updating filewrapper
https://bugs.webkit.org/show_bug.cgi?id=241026
rdar://86293273
Reviewed by Wenson Hsieh.
In the case of certain iWork file types downloaded from iCloud that require
thumbnails, we don't remove the progress update once the filewrapper is updated
with the complete attachment, which prevents the thumbnail from appearing.
This patch removes the progress attribute once the thumbnail is updated
so we know we can now paint the icon.
No new tests. There's no clear way to test this change. For previous thumbnail bugs
we swizzled the thumbnail generator code to make sure we were generating
thumbnails; however, this bug is a case of the thumbnail being generated but not
displayed. Similarly, we can't compare the attachment size because it is the same for
the attachment with and without the correct thumbnail.
- Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::updateThumbnail):
Canonical link: https://commits.webkit.org/251080@main
- 6:46 PM Changeset in webkit [294975] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm
[ iOS ] TestWebKitAPI.SOAuthorizationSubFrame.InterceptionErrorWithReferrer is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=239311
<rdar://91723056>
Reviewed by Brent Fulgham.
There is a race condition when using waitForMessage that we hit here, causing flaky tests on
some bots. This patch avoids this by specifying the messages waited for before loading the
request.
- Tools/TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
(-[TestSOAuthorizationScriptMessageHandler initWithExpectation:]):
(-[TestSOAuthorizationScriptMessageHandler userContentController:didReceiveScriptMessage:]):
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/251079@main
- 6:23 PM Changeset in webkit [294974] by
-
- 1 edit in trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
[GLib] Properly deprecate WebKitSettings properties enable-accelerated-2d-canvas, enable-plugins, and enable-xss-auditor
https://bugs.webkit.org/show_bug.cgi?id=240993
Patch by Michael Catanzaro <mcatanzaro@redhat.com> on 2022-05-27
Reviewed by Adrian Perez de Castro.
- Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:
(webkit_settings_class_init):
Canonical link: https://commits.webkit.org/251078@main
- 6:06 PM Changeset in webkit [294973] by
-
- 41 edits in trunk/Source/WebCore
Add a fake style bit for mouse click handlers
https://bugs.webkit.org/show_bug.cgi?id=240924
Reviewed by Antti Koivisto.
Add a bit to
EventListenerRegionTypefor mouse click events, and
populate it via Node::willRespondToMouseClickEvents.
To do so while avoiding recursive style computation, make it possible
to plumb Editability through to willRespondToMouseClickEventsWithEditability.
This short-circuits Node calling into computeEditability() from the base
implementation of willRespondToMouseClickEvents, which reenters style computation
via computedStyle() when called from StyleAdjuster (whereEventListenerRegionType
is populated).
Also make a variant of computeEditability that takes a passed-in style, and
do some refactoring to share more code between platforms (without changing
behavior, even in cases where the behavior differences are suprising).
- Source/WebCore/dom/Node.cpp:
(WebCore::computeEditabilityFromComputedStyle):
Instead of computing style, computeEditabilityFromComputedStyle is now passed a RenderStyle reference.
(WebCore::Node::computeEditabilityWithStyle const):
This subsumes most of the logic from computeEditability(), but will
compute the style (only if we need it) if it is not passed in.
(WebCore::Node::computeEditability const):
computeEditability retains its "normal" API, passing through its arguments and a null style,
indicating to computeEditabilityWithStyle that it should compute the style as usual.
(WebCore::Node::computeEditabilityForMouseClickEvents const):
A variant ofcomputeEditabilityWithStylethat maintains an odd existing
platform-specific difference in theUserSelectAllTreatmentargument,
and allows callers ofwillRespondToMouseClickEventsWithEditabilityto
all be consistent.
(WebCore::Node::willRespondToMouseClickEvents const):
Maintain the existing behavior of willRespondToMouseClickEvents; compute editability as needed.
(WebCore::Node::willRespondToMouseClickEventsWithEditability const):
willRespondToMouseClickEventsWithEditabilityis now the override point, and
will not itself cause a style update.
Refactor this function a bit to share as much code as possible between platforms
(and maintain an existing comment questioning the differences that we maintain).
- Source/WebCore/dom/Node.h:
- Source/WebCore/rendering/EventRegion.cpp:
(WebCore::EventRegion::eventListenerRegionForType const):
- Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::patternForEventListenerRegionType):
Add EventListenerRegionType::MouseClick to these two switches over EventListenerRegionType,
but break and fall into the ASSERT_NOT_REACHED default state; these are only called
for wheel event listeners.
- Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
- Source/WebCore/rendering/style/RenderStyleConstants.h:
- Source/WebCore/style/StyleAdjuster.cpp:
(WebCore::Style::Adjuster::adjustEventListenerRegionTypesForRootStyle):
(WebCore::Style::Adjuster::computeEventListenerRegionTypes):
(WebCore::Style::Adjuster::adjust const):
If we're building interaction regions, propagate EventListenerRegionType::MouseClick
down the style tree like we do for wheel event listeners. This is a bit more complicated
than wheel event listeners, using the Node method instead of just looking at the
set of event listeners, because many elements accept mouse clicks *without* having
event listeners installed; they just implement behaviors in their default event handlers.
- Source/WebCore/style/StyleAdjuster.h:
- Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegions):
Adopt the new fake style bit. This is not the final intended use: we will use it from
EventRegion::unite(), like we do for wheel events, in a future patch.
- Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLAnchorElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/html/HTMLAnchorElement.h:
- Source/WebCore/html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLButtonElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/html/HTMLButtonElement.h:
- Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/html/HTMLElement.h:
- Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLImageElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/html/HTMLImageElement.h:
- Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLInputElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/html/HTMLInputElement.h:
- Source/WebCore/html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLLabelElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/html/HTMLLabelElement.h:
- Source/WebCore/html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLPlugInElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/html/HTMLPlugInElement.h:
- Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLSelectElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/html/HTMLSelectElement.h:
- Source/WebCore/html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLSummaryElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/html/HTMLSummaryElement.h:
- Source/WebCore/html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::HTMLTextAreaElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/html/HTMLTextAreaElement.h:
- Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/html/shadow/SliderThumbElement.h:
- Source/WebCore/html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::SpinButtonElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/html/shadow/SpinButtonElement.h:
- Source/WebCore/html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::SearchFieldResultsButtonElement::willRespondToMouseClickEvents const): Deleted.
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/html/shadow/TextControlInnerElements.h:
- Source/WebCore/mathml/MathMLElement.cpp:
(WebCore::MathMLElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::MathMLElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/mathml/MathMLElement.h:
- Source/WebCore/mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::MathMLSelectElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/mathml/MathMLSelectElement.h:
- Source/WebCore/svg/SVGAElement.cpp:
(WebCore::SVGAElement::willRespondToMouseClickEventsWithEditability const):
(WebCore::SVGAElement::willRespondToMouseClickEvents const): Deleted.
- Source/WebCore/svg/SVGAElement.h:
Propagate editability through overrides of willRespondToMouseClickEvents(WithEditability).
Canonical link: https://commits.webkit.org/251077@main
- 5:56 PM Changeset in webkit [294972] by
-
- 15 edits3 copies in trunk/Source/WebCore
Add EXT_texture_compression_bptc WebGL extension support
https://bugs.webkit.org/show_bug.cgi?id=235637
Patch by Alexey Knyazev <3479527+lexaknyazev@users.noreply.github.com> on 2022-05-27
Reviewed by Kenneth Russell.
Support BPTC texture formats and slightly cleanup RGTC code.
- Source/WebCore/CMakeLists.txt:
- Source/WebCore/DerivedSources-input.xcfilelist:
- Source/WebCore/DerivedSources-output.xcfilelist:
- Source/WebCore/DerivedSources.make:
- Source/WebCore/Sources.txt:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp:
(WebCore::convertToJSValue):
- Source/WebCore/html/canvas/EXTTextureCompressionBPTC.cpp: Copied from Source/WebCore/html/canvas/EXTTextureCompressionRGTC.cpp.
(WebCore::EXTTextureCompressionBPTC::EXTTextureCompressionBPTC):
(WebCore::EXTTextureCompressionBPTC::getName const):
(WebCore::EXTTextureCompressionBPTC::supported):
- Source/WebCore/html/canvas/EXTTextureCompressionBPTC.h: Copied from Source/WebCore/html/canvas/EXTTextureCompressionRGTC.h.
- Source/WebCore/html/canvas/EXTTextureCompressionBPTC.idl: Copied from Source/WebCore/html/canvas/EXTTextureCompressionRGTC.h.
- Source/WebCore/html/canvas/EXTTextureCompressionRGTC.cpp:
(WebCore::EXTTextureCompressionRGTC::EXTTextureCompressionRGTC):
(WebCore::EXTTextureCompressionRGTC::supported):
- Source/WebCore/html/canvas/EXTTextureCompressionRGTC.h:
- Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
- Source/WebCore/html/canvas/WebGLExtension.h:
- Source/WebCore/html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
- Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::validateCompressedTexFuncData):
(WebCore::WebGLRenderingContextBase::loseExtensions):
- Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
- Source/WebCore/platform/graphics/GraphicsContextGL.h:
Canonical link: https://commits.webkit.org/251076@main
- 5:32 PM Changeset in webkit [294971] by
-
- 1 edit1 delete in trunk/Source/WebKit
Remove WebKit feature flags plist
https://bugs.webkit.org/show_bug.cgi?id=241042
Reviewed by Wenson Hsieh.
- Source/WebKit/FeatureFlags/WebKit.plist: Removed.
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Now that the blocking bug is resolved, we can remove this entirely.
Canonical link: https://commits.webkit.org/251075@main
- 5:01 PM Changeset in webkit [294970] by
-
- 12 edits in trunk
Optimize setting SVG element transforms
https://bugs.webkit.org/show_bug.cgi?id=240825
Reviewed by Said Abou-Hallawa.
When parseTransformValueGeneric() creates SVGTransformValues, it default-constructed them
and then called setRotate(), setScale() etc, which would reset m_matrix to identity a second time.
Optimize by providing static helpers for creating translate, rotate and scale SVGTransformValues
which initialize the matrix with the final value. Helpers are added to AffineTransform to
create scale, translate and rotate transforms, renamingtranslationtomakeTranslationso
that the "scale" helper doesn't conflict with thescalemember function.
This reduces the time spent under the Element::setAttribute() function in the MotionMark
Suits test by about 14%.
- Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::rectForViewportConstrainedObjects):
- Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::GlyphToPathTranslator::GlyphToPathTranslator):
- Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp:
(WebCore::LegacyRenderSVGRoot::paintReplaced):
(WebCore::LegacyRenderSVGRoot::localToParentTransform const):
- Source/WebCore/rendering/svg/RenderSVGResourceMarker.cpp:
(WebCore::RenderSVGResourceMarker::localToParentTransform const):
- Source/WebCore/rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::calculateLocalTransform):
- Source/WebCore/svg/SVGTransform.h:
(WebCore::SVGTransform::create):
(WebCore::SVGTransform::SVGTransform):
- Source/WebCore/svg/SVGTransformList.cpp:
(WebCore::SVGTransformList::parseGeneric):
- Source/WebCore/svg/SVGTransformValue.h:
(WebCore::SVGTransformValue::translateTransformValue):
(WebCore::SVGTransformValue::rotateTransformValue):
(WebCore::SVGTransformValue::scaleTransformValue):
(WebCore::SVGTransformValue::setMatrix):
(WebCore::SVGTransformValue::matrixDidChange):
(WebCore::SVGTransformValue::setTranslate):
(WebCore::SVGTransformValue::setScale):
(WebCore::SVGTransformValue::setRotate):
- Source/WebCore/svg/SVGTransformable.cpp:
(WebCore::parseTransformValueGeneric):
- Source/WebCore/svg/properties/SVGValueProperty.h:
- Tools/TestWebKitAPI/Tests/WebCore/AffineTransform.cpp:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/251074@main
- 5:00 PM Changeset in webkit [294969] by
-
- 1 edit in trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in
[macOS][GPUP] Block unused system calls
https://bugs.webkit.org/show_bug.cgi?id=240966
<rdar://84826074>
Reviewed by Chris Dumez.
- Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
Canonical link: https://commits.webkit.org/251073@main
- 4:55 PM Changeset in webkit [294968] by
-
- 1 edit in trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.js
Web Inspector: Sources: editing a breakpoint action to cause the CodeMirror to wrap doesn't update the
WI.Popoversize
https://bugs.webkit.org/show_bug.cgi?id=220643
<rdar://problem/73225206>
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.js:
(WI.BreakpointActionView.prototype._updateBody):
(WI.BreakpointActionView.prototype._handleJavaScriptCodeMirrorUpdate): Added.
(WI.BreakpointActionView.prototype._codeMirrorViewportChanged): Deleted.
Replace listening for"viewportChange"(and"update") with"updates", each time comparing the
getScrollInfo().clientHeight(we don't care about theclientWidthbecause it's hardcoded in the
CSS.breakpoint-action-eval-editor > .CodeMirror) with the last value. This is necessary because
"viewportChange"is only fired when the number of lines changes, which a wrapped line doesn't do.
Canonical link: https://commits.webkit.org/251072@main
- 4:52 PM Changeset in webkit [294967] by
-
- 1 edit in trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js
Web Inspector: Timelines: switching between Events/Frames while editing instruments leaves the UI in a broken state
https://bugs.webkit.org/show_bug.cgi?id=218700
<rdar://problem/71180148>
Reviewed by Patrick Angle.
- Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:
(WI.TimelineOverview.prototype.set viewMode):
(WI.TimelineOverview.prototype._viewModeDidChange):
Forcibly stop editing instruments when switching between Events/Frames. Note that this will save the
current state of edited instruments, so no changes will be lost.
Canonical link: https://commits.webkit.org/251071@main
- 4:40 PM Changeset in webkit [294966] by
-
- 1 edit in trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py
git-webkit pr: Show server response when updating an issue fails
Reviewed by Jonathan Bedard.
Small changes are also made to the request() method to make it more
reusable: now it can handle methods other than GET, and can print custom
error messages when requests fail.
Bare usages of python-requests have been refactored to use
self.request() where possible (that is, when the path being accessed is
within the repo URL).
- Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
Canonical link: https://commits.webkit.org/251070@main
- 4:09 PM Changeset in webkit [294965] by
-
- 57 edits2 deletes in trunk
Revert "Enable WasmLLInt on ARMv7"
Unreviewed.
This reverts commit 2a12d06fc13f7c3bbcf8d204d6f760ab222d75d9.
2a12d06fc13f7c3bbcf8d204d6f760ab222d75d9 breaks WASM on 64-bit platforms.
Canonical link: https://commits.webkit.org/251068@main
- 4:08 PM Changeset in webkit [294964] by
-
- 1 edit in trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
[iOS] Performing the image markup action should reset
_imageAnalysisMarkupData
https://bugs.webkit.org/show_bug.cgi?id=241024
Reviewed by Aditya Keerthi.
- Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView imageAnalysisMarkupMenu]):
Canonical link: https://commits.webkit.org/251068@main
- 4:02 PM Changeset in webkit [294963] by
-
- 11 edits in trunk/Source/WebCore
Update internal CSS to remove '-webkit-' prefixing where possible
https://bugs.webkit.org/show_bug.cgi?id=240930
<rdar://93934318>
Patch by Sammy Gill <sgill26@apple.com> on 2022-05-27
Reviewed by Brent Fulgham and Tim Nguyen.
There are many instances in WebCore where prefixed versions of CSS
attributes are being used even though these attributes have been
standardized and have unprefixed versions. The prefixed versions no
longer need to be used and can be replaced by their unprefixed
equivalents.
- Source/WebCore/Modules/mediacontrols/mediaControlsAdwaita.css:
- Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:
- Source/WebCore/Modules/mediacontrols/mediaControlsBase.css:
- Source/WebCore/css/html.css:
- Source/WebCore/css/legacyFormControlsIOS.css:
- Source/WebCore/css/mediaControls.css:
- Source/WebCore/css/themeAdwaita.css:
- Source/WebCore/html/shadow/imageOverlay.css:
- Source/WebCore/html/shadow/mac/imageControlsMac.css:
- Source/WebCore/html/shadow/meterElementShadow.css:
- Source/WebCore/xml/XMLViewer.css:
Canonical link: https://commits.webkit.org/251067@main
- 3:59 PM Changeset in webkit [294962] by
-
- 3 edits in trunk/LayoutTests/platform
[Gardening]: [ iOS macOS ] two imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage tests are a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=241048
<rdar://94056966>
Unreviewed test gardening.
- LayoutTests/platform/ios/TestExpectations:
- LayoutTests/platform/mac-wk1/TestExpectations:
- LayoutTests/platform/mac-wk2/TestExpectations:
Canonical link: https://commits.webkit.org/251066@main
- 3:55 PM Changeset in webkit [294961] by
-
- 1 edit in trunk/LayoutTests/webgl/TestExpectations
Flakes in WebGL conformance[2]/textures/image_bitmap_from_image_bitmap/ tests
https://bugs.webkit.org/show_bug.cgi?id=241027
Patch by Kenneth Russell <kbr@chromium.org> on 2022-05-27
Unreviewed test gardening.
- LayoutTests/webgl/TestExpectations:
Mark all tests under:
webgl/2.0.0/conformance[2]/textures/image_bitmap_from_image_bitmap
as flaky (Pass Failure) while the bug is being investigated.
Canonical link: https://commits.webkit.org/251065@main
- 3:48 PM Changeset in webkit [294960] by
-
- 2 edits in trunk/Source
Revert "Non unified build fixes, lateish May 2022 edition"
Unreviewed.
This reverts commit 2db7e5eef53c0424ac30bccf7cdf9aa8428e9464.
We need to revert 2a12d06fc13f7c3bbcf8d204d6f760ab222d75d9 because it broke WASM on
64-bit platforms. 2db7e5eef53c0424ac30bccf7cdf9aa8428e9464 was builds on top of
2a12d06fc13f7c3bbcf8d204d6f760ab222d75d9, and hence, needs to be reverted too.
Canonical link: https://commits.webkit.org/251064@main
- 3:10 PM Changeset in webkit [294959] by
-
- 2 edits2 adds in trunk
[Modern Media Controls] REGRESSION(r293684) cannot pause
<video>ifcontrolsare added after"play"
https://bugs.webkit.org/show_bug.cgi?id=240985
<rdar://problem/93822316>
Reviewed by Eric Carlson.
- Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController):
Actually check if themediais playing and/or has played instead of always assumingfalse.
- Source/WebCore/Modules/modern-media-controls/media/start-support.js:
(StartSupport.prototype._shouldShowStartButton):
Drive-by: It's no longer necessary to checkmedia.played.lengthhere it's part ofmediaController.hasPlayed.
- LayoutTests/media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-added-after-play.html: Added.
- LayoutTests/media/modern-media-controls/ios-inline-media-controls/touch/ios-inline-media-controls-added-after-play-expected.txt: Added.
Canonical link: https://commits.webkit.org/251062@main
- 3:10 PM Changeset in webkit [294958] by
-
- 2 edits in trunk/Source
Crash under RemoteDisplayListRecorder::restore()
https://bugs.webkit.org/show_bug.cgi?id=240545
Reviewed by Simon Fraser.
- Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h:
(WebKit::RemoteImageBuffer::~RemoteImageBuffer):
Avoid restoring the GraphicsContext stack for volatile
ImageBuffers. The buffers do not have a graphics context.
- Source/WebCore/platform/graphics/ConcreteImageBuffer.h:
Add an assertion to check that volatile image buffers
do not try to access their context.
Canonical link: https://commits.webkit.org/251061@main
- 3:05 PM Changeset in webkit [294957] by
-
- 1 copy in tags/WebKit-7614.1.14.10.9
Tag WebKit-7614.1.14.10.9.
- 3:02 PM Changeset in webkit [294956] by
-
- 9 edits in branches/safari-7614.1.14.10-branch/Source
Versioning.
WebKit-7614.1.14.10.9
- 2:50 PM Changeset in webkit [294955] by
-
- 6 edits4 adds in trunk
CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions
https://bugs.webkit.org/show_bug.cgi?id=239909
<rdar://problem/87885717>
Reviewed by Wenson Hsieh.
This exception happens when trying to add attributes for text that contains collapsed whitespace and
has also been wrapped due to the size of its parent container. The exception specifically is about
trying to add attributes beyond the current length of aNSAttributedString.
- Source/WebCore/editing/TextIteratorBehavior.h:
- Source/WebCore/editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextRun):
In the case thatm_lastTextNodeEndedWithCollapsedSpace, we only want to add the remaining text if
we're still within the desired portion of them_textRun. Otherwise, we'll iterate over too much of
the text and result in a string that's longer than what would be the case if one manually calculated
it from the givenoffsetandoffsetEnd. Add a newTextIteratorBehavior::IgnoresWhiteSpaceAtEndOfRun
to not include the trailing whitespace.
- Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:
(WebKit::TextCheckingControllerProxy::annotatedSubstringBetweenPositions):
Use the newWebCore::TextIteratorBehavior::IgnoresWhiteSpaceAtEndOfRunto not include the trailing
whitespace.
Also add some defensive checks just in case.
- Source/WebCore/testing/Internals.idl:
- Source/WebCore/testing/Internals.h:
- Source/WebCore/testing/Internals.cpp:
(WebCore::toTextIteratorBehaviors): Added.
(WebCore::Internals::locationFromRange):
(WebCore::Internals::lengthFromRange):
(WebCore::Internals::statesOfTextIterator): Added.
Add a way to provideTextIteratorBehaviorsto methods that useTextIterator.
Add a method that gets thetextandrangeof aTextIteratorafter everyadvance.
- LayoutTests/editing/text-iterator/sequential-collapsed-ranges.html: Added.
- LayoutTests/editing/text-iterator/sequential-collapsed-ranges-expected.txt: Added.
- LayoutTests/editing/text-iterator/subrange-with-trailing-collapsed-whitespace.html: Added.
- LayoutTests/editing/text-iterator/subrange-with-trailing-collapsed-whitespace-expected.txt: Added.
Canonical link: https://commits.webkit.org/251061@main
- 2:37 PM Changeset in webkit [294954] by
-
- 1 copy in tags/WebKit-7614.1.14.1.14
Tag WebKit-7614.1.14.1.14.
- 2:35 PM Changeset in webkit [294953] by
-
- 1 copy in tags/WebKit-7614.1.14.0.13
Tag WebKit-7614.1.14.0.13.
- 2:10 PM Changeset in webkit [294952] by
-
- 6 edits1 add in trunk/Source
[Xcode] Compute PGO profdata paths instead of searching for them at build time
https://bugs.webkit.org/show_bug.cgi?id=239681
Reviewed by Wenson Hsieh and Alexey Proskuryakov.
Production builds should always use profdata from the SDK, internal
release builds should use profdata from the local WebKitAdditions when
available, and open source builds should use the stub profdata. Add a
PROFILE_DATA_PATH build setting which implements these rules and replace
the script phases that checked those paths dynamically.
This fixes XCBuild validation issues in the open-source build, and
should prevent production builders from using stale profdata in
BUILT_PRODUCTS_DIR. Additionally, engineers can now build with custom
profile data by overriding PROFILE_DATA_PATH.
- Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
- Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
- Source/JavaScriptCore/Scripts/copy-profiling-data.sh: Added. This file is part of JavaScriptCore's private headers and replaces the "Copy Profiling Data" script phase logic all projects.
- Source/WebKit/Configurations/BaseTarget.xcconfig:
- Source/WebKit/WebKit.xcodeproj/project.pbxproj:
- Source/WebCore/Configurations/WebCore.xcconfig:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/251060@main
- 1:52 PM Changeset in webkit [294951] by
-
- 2 edits in trunk/Source
Start allocating shared memory with MAP_MEM_VM_SHARE again on newer OSes
https://bugs.webkit.org/show_bug.cgi?id=241014
<rdar://94032696>
Reviewed by Simon Fraser.
When we started doing memory attribution in the GPUProcess, we stopped using
the MAP_MEM_VM_SHARE flag when creating SharedMemory, because it was
incompatible with attribution. However, creating shared memory would fail
without the MAP_MEM_VM_SHARE flag under certain circumstances (due to size
restriction iirc), in which case we would fall back to using MAP_MEM_VM_SHARE
and fail memory attribution.
As of <rdar://73715428>, MAP_MEM_VM_SHARE is now compatible with memory
attribution so this patch starts using the flag again and unconditionally on
newer OSes.
- Source/WTF/wtf/PlatformHave.h:
- Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp:
(WebKit::makeMemoryEntry):
Canonical link: https://commits.webkit.org/251059@main
- 1:14 PM Changeset in webkit [294950] by
-
- 3 edits in trunk/Source
[WebAuthn] Forward declare ASC SPI for internal needs.
https://bugs.webkit.org/show_bug.cgi?id=240928
rdar://problem/93930713
Reviewed by Brent Fulgham.
This fixes the build after an internal change for older macOS.
- Source/WebKit/Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
- Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:
Remove unused import that isn't present in older macOS sdk.
Canonical link: https://commits.webkit.org/251058@main
- 12:54 PM Changeset in webkit [294949] by
-
- 3 edits in trunk/Source/WebCore
Stop exposing ApplicationCache API if it is not enabled
https://bugs.webkit.org/show_bug.cgi?id=241000
Reviewed by Chris Dumez.
- Source/WebCore/bindings/js/WebCoreBuiltinNames.h:
- Source/WebCore/loader/appcache/DOMApplicationCache.idl:
- Source/WebCore/page/DOMWindow.idl:
Canonical link: https://commits.webkit.org/251057@main
- 12:29 PM Changeset in webkit [294948] by
-
- 7 edits2 deletes in trunk
Revert "REGRESSION(r289580): Canvas: putImageData sometimes draws nothing"
Unreviewed revert of commit 749c20ef7e6693fc1e69be46db08eedabc4d8a1b.
This caused Mac EWS testing to exit early with 30+ failures.
Canonical link: https://commits.webkit.org/251056@main
- 12:20 PM Changeset in webkit [294947] by
-
- 27 edits in trunk/Source
Move disk operations when deleting cookies off from the main thread
https://bugs.webkit.org/show_bug.cgi?id=240981
<rdar://92415240>
Reviewed by Geoff Garen.
This should reduce hangs and increase responsiveness.
- Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:
- Source/WebCore/inspector/agents/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::deleteCookie):
- Source/WebCore/loader/CookieJar.cpp:
(WebCore::CookieJar::deleteCookie):
- Source/WebCore/loader/CookieJar.h:
- Source/WebCore/platform/network/NetworkStorageSession.h:
- Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::NetworkStorageSession::deleteCookie):
(WebCore::NetworkStorageSession::setAllCookiesToSameSiteStrict):
(WebCore::NetworkStorageSession::deleteHTTPCookie const):
(WebCore::NetworkStorageSession::deleteCookie const):
(WebCore::NetworkStorageSession::deleteAllCookies):
(WebCore::NetworkStorageSession::deleteCookiesForHostnames):
(WebCore::NetworkStorageSession::deleteAllCookiesModifiedSince):
(WebCore::NetworkStorageSession::flushCookieStore): Deleted.
(WebCore::deleteAllHTTPCookies): Deleted.
- Source/WebKit/NetworkProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::deleteCookiesForHostnames):
(WebKit::WebCookieManager::deleteAllCookies):
(WebKit::WebCookieManager::deleteCookie):
(WebKit::WebCookieManager::deleteAllCookiesModifiedSince):
- Source/WebKit/NetworkProcess/Cookies/WebCookieManager.h:
- Source/WebKit/NetworkProcess/Cookies/WebCookieManager.messages.in:
- Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::deleteCookie):
- Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
- Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
- Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp:
(API::HTTPCookieStore::deleteAllCookies):
- Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::deleteAllCookies):
- Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::deleteCookiesForHostnames):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
- Source/WebKit/UIProcess/WebCookieManagerProxy.h:
- Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::deleteCookie):
- Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp:
(WebKit::WebCookieCache::cookiesDeleted):
(WebKit::WebCookieCache::clearForHost):
- Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:
(WebKit::WebCookieJar::deleteCookie):
- Source/WebKit/WebProcess/WebPage/WebCookieJar.h:
- Source/WebKitLegacy/mac/WebView/WebPreferences.mm:
(+[WebPreferences _clearNetworkLoaderSession]):
Canonical link: https://commits.webkit.org/251055@main
- 11:58 AM Changeset in webkit [294946] by
-
- 13 edits3 adds in trunk
Add EXT_texture_norm16 WebGL extension support
https://bugs.webkit.org/show_bug.cgi?id=220343
Patch by Alexey Knyazev <3479527+lexaknyazev@users.noreply.github.com> on 2022-05-27
Reviewed by Kenneth Russell.
- LayoutTests/TestExpectations:
- Source/WebCore/CMakeLists.txt:
- Source/WebCore/DerivedSources-input.xcfilelist:
- Source/WebCore/DerivedSources-output.xcfilelist:
- Source/WebCore/DerivedSources.make:
- Source/WebCore/Sources.txt:
- Source/WebCore/WebCore.xcodeproj/project.pbxproj:
- Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp:
(WebCore::convertToJSValue):
- Source/WebCore/html/canvas/EXTTextureNorm16.cpp: Added.
(WebCore::EXTTextureNorm16::EXTTextureNorm16):
(WebCore::EXTTextureNorm16::getName const):
(WebCore::EXTTextureNorm16::supported):
- Source/WebCore/html/canvas/EXTTextureNorm16.h: Added.
- Source/WebCore/html/canvas/EXTTextureNorm16.idl: Added.
- Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
(WebCore::WebGL2RenderingContext::renderbufferStorageImpl):
- Source/WebCore/html/canvas/WebGLExtension.h:
- Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::addExtensionSupportedFormatsAndTypesWebGL2):
(WebCore::WebGLRenderingContextBase::loseExtensions):
- Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
- Source/WebCore/platform/graphics/GraphicsContextGL.h:
Canonical link: https://commits.webkit.org/251054@main
- 11:41 AM Changeset in webkit [294945] by
-
- 9 edits in branches/safari-7614.1.14.1-branch/Source
Versioning.
WebKit-7614.1.14.1.14
- 11:38 AM Changeset in webkit [294944] by
-
- 9 edits in branches/safari-7614.1.14.0-branch/Source
Versioning.
WebKit-7614.1.14.0.13
- 10:59 AM Changeset in webkit [294943] by
-
- 1 edit in trunk/Source/cmake/WebKitFeatures.cmake
[CMake] Support string values in cmakeconfig.h
https://bugs.webkit.org/show_bug.cgi?id=241013
Reviewed by Adrian Perez de Castro and Michael Catanzaro.
Add
EXPOSE_STRING_VARIABLE_TO_BUILDwhich adds a string variable to the config. Modify
CREATE_CONFIGURATION_HEADERto output the values tocmakeconfig.h.
- Source/cmake/WebKitFeatures.cmake:
Canonical link: https://commits.webkit.org/251053@main
- 10:58 AM Changeset in webkit [294942] by
-
- 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp
[GTK] Deprecate WebKitSettings:enable-java
https://bugs.webkit.org/show_bug.cgi?id=239538
Reviewed by Adrian Perez de Castro.
- Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings): Move test of deprecated function to section
disabling deprecation warnings.
Canonical link: https://commits.webkit.org/251052@main
- 10:22 AM Changeset in webkit [294941] by
-
- 9 edits in trunk/Source
Versioning.
WebKit-7614.1.16
- 10:12 AM Changeset in webkit [294940] by
-
- 1 copy in tags/WebKit-7614.1.14.11.4
Tag WebKit-7614.1.14.11.4.
- 9:54 AM Changeset in webkit [294939] by
-
- 2 edits in trunk/Source
Non unified build fixes, lateish May 2022 edition
https://bugs.webkit.org/show_bug.cgi?id=241019
Unreviewed build fixes.
- Source/JavaScriptCore/wasm/js/WasmToJS.cpp: Add missing JSCJSValueInlines.h header inclusion.
- Source/WebCore/platform/audio/MultiChannelResampler.cpp: Add missing <functional> header inclusion, needed for std::bind().
Canonical link: https://commits.webkit.org/251050@main
- 8:49 AM Changeset in webkit [294938] by
-
- 8 edits1 add in trunk
AX: Update the isolated tree in response to dynamic aria-haspopup and aria-describedby changes
https://bugs.webkit.org/show_bug.cgi?id=240968
Reviewed by Chris Fleizach.
Testcases added to aria-describedby-on-input.html
and element-haspopup.html to cover this change.
- LayoutTests/accessibility/aria-describedby-on-input-expected.txt:
- LayoutTests/accessibility/aria-describedby-on-input.html:
- LayoutTests/accessibility/element-haspopup-expected.txt:
- LayoutTests/accessibility/element-haspopup.html:
- LayoutTests/platform/ios/accessibility/aria-describedby-on-input-expected.txt: Added.
- LayoutTests/platform/ios/TestExpectations:
- Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
- Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):
- Source/WebCore/accessibility/AXObjectCache.h:
Canonical link: https://commits.webkit.org/251049@main
- 7:47 AM Changeset in webkit [294937] by
-
- 6 edits in trunk/Source/WebKit
Simplify MediaPlayerPrivateRemote::RequestResource API
https://bugs.webkit.org/show_bug.cgi?id=240999
<rdar://94012261>
Reviewed by Eric Carlson.
When the GPU Process' MediaPlayerProxy needs to allocate a new MediaResource it sends
a message to the content process via the MediaPlayerPrivateRemote::RequestResource
IPC call with a RemoteMediaResourceIdentifier which will then respond to indicate that
the MediaResource is now "ready".
There's two scenarios possible here:
Either the creation of the media resource in the content process is successful or it's not.
If it's successful the content process will start sending data starting by a call to the
GPU's RemoteMediaResourceManager responseReceived
Or it will fail and call RemoteMediaResourceManager::LoadFailed.
The RemoteMediaResourceManager will only accept incoming data once the MediaResource's
ready status is true, and if you're only working on the main thread, it will always be,
as the Content Process' RequestResource response will always be received before either
a LoadFailed or ResponseReceived call.
Under these conditions, the ready status is totally redundant. Testing that the
RemoteMediaResource exists in the MediaResourceManager's map is sufficient.
However, if we want to parallelise networking operations so that ResponseReceived and
LoadFailed will be called on a secondary thread as introduced in bug 235353;
the "ready" flag becomes problematic as the response from a RequestResource is handled
on the main thread.
The multi-threaded nature of the work means that the RequestResource response could be
received only after LoadFailed or ResponseReceived message; and if that's the case
those two messages will be dropped.
This can be seen with the intermittent failures occurring with media/video-src-blob-replay.html test.
So we remove this concept of RemoteMediaResource::ready as at best it serves no purpose.
- Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::requestResource):
- Source/WebKit/GPUProcess/media/RemoteMediaResource.h:
(WebKit::RemoteMediaResource::ready const): Deleted.
(WebKit::RemoteMediaResource::setReady): Deleted.
- Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.cpp:
(WebKit::RemoteMediaResourceManager::responseReceived):
(WebKit::RemoteMediaResourceManager::redirectReceived):
(WebKit::RemoteMediaResourceManager::dataSent):
(WebKit::RemoteMediaResourceManager::dataReceived):
(WebKit::RemoteMediaResourceManager::accessControlCheckFailed):
(WebKit::RemoteMediaResourceManager::loadFailed):
(WebKit::RemoteMediaResourceManager::loadFinished):
- Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::requestResource):
- Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
- Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:
Canonical link: https://commits.webkit.org/251048@main
- 6:17 AM Changeset in webkit [294936] by
-
- 1 edit in trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in
Unreviewed, reverting r294898.
https://bugs.webkit.org/show_bug.cgi?id=241008
Introduced crash
Reverted changeset:
"[macOS][GPUP] Block unused system calls"
https://bugs.webkit.org/show_bug.cgi?id=240966
https://commits.webkit.org/r294898
Canonical link: https://commits.webkit.org/251047@main
- 4:03 AM Changeset in webkit [294935] by
-
- 7 edits in trunk/Source/WebCore/platform/graphics
[TextureMapper] Generalize YUV-to-RGB matrices
https://bugs.webkit.org/show_bug.cgi?id=240952
Patch by Žan Doberšek <zdobersek@igalia.com> on 2022-05-27
Reviewed by Miguel Gomez.
Right now, TextureMapper supports converting YUV data to RGB when using either
the BT.601 or BT.709 colorspaces. The caller provides the basic 3x3 conversion
matrix for the given colorspace, and the offsets agains the initial YUV values
are hard-coded in the shader since they are the same for both colorspaces.
To support additional colorspaces (which don't share the same offset values) the
matrix handling has to be generalized. This means every conversion matrix is now
4x4 in size, with the adjusted offset values residing in the last column.
- Source/WebCore/platform/graphics/gstreamer/GStreamerVideoFrameHolder.cpp:
(WebCore::GstVideoFrameHolder::platformLayerBuffer):
- Source/WebCore/platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:
(WebCore::VideoTextureCopierGStreamer::copyVideoTextureToPlatformTexture):
- Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexturePlanarYUV):
(WebCore::TextureMapperGL::drawTextureSemiPlanarYUV):
(WebCore::TextureMapperGL::drawTexturePackedYUV):
- Source/WebCore/platform/graphics/texmap/TextureMapperGL.h:
- Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:
- Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp:
(WebCore::TextureMapperPlatformLayerProxyDMABuf::DMABufLayer::paintToTextureMapper):
- Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:
Canonical link: https://commits.webkit.org/251046@main
- 1:47 AM Changeset in webkit [294934] by
-
- 57 edits2 adds in trunk
Enable WasmLLInt on ARMv7
Patch by Geza Lore <Geza Lore> on 2022-05-27
https://bugs.webkit.org/show_bug.cgi?id=221260
Reviewed by Saam Barati.
Patch by Geza Lore and Xan López.
Implement the LLInt tier of WebAssembly for ARMv7. A lot of the
work will be shared by any 32bit port, but the offlineassembler
has only been updated for ARMv7 so far.
Main highlights:
We have split the WebAssembly.asm file into three chunks,
following what LowLevelInterpreter.asm does. The common code
remains in WebAssembly.asm, and 32 and 64bit specific code (mostly
opcode implementations) goes into WebAssembly32_64.asm and
WebAssembly64.asm.
We have decided to use consecutive even/odd pairs of GPRs for every
type of wasm values, even if they are 32bit (i32/f32), with the odd
(higher) numbered GPR holding the more significant half. 32bit values
are held in the even (lower) numbered register. This makes the code
much simpler and allows us to share more code with the 64bit variant.
This is mostly relevant for argument passing, and given that every
value ends up in the stack anyway we do not think it is significant
from a performance POV.
We are reusing JSValueRegs to hold Wasm values too. Obviously they
are not really JSValues, so it might make sense to create a base
class that can be used for both JS and Wasm values.
We do not have enough registers to keep things like the memory
base pointer and size in pinned registers, so we are forced to
load them on each use.
We disable the 'Signaling' memory mode, since the current
implementation relies on being able to mprotect a 232 + redzone
region of memory. This can be changed in the future but it's not a
priority at the moment.
- stress/sampling-profiler-wasm-name-section.js:
- stress/sampling-profiler-wasm.js:
- wasm/regress/llint-callee-saves-with-fast-memory.js:
- CMakeLists.txt:
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::vcvt_signedToFloatingPoint):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::convertInt32ToFloat):
(JSC::MacroAssemblerARMv7::threadSafePatchableNearCall):
(JSC::MacroAssemblerARMv7::callOperation):
- b3/B3ValueRep.h:
(JSC::B3::ValueRep::ValueRep):
- bytecode/BytecodeDumper.cpp:
(JSC::Wasm::BytecodeDumper::formatConstant const):
- interpreter/CallFrame.h: adapt to new callee tagging format.
(JSC::CallFrame::callee const):
(JSC::CallFrame::unsafeCallee const):
- interpreter/CalleeBits.h: add wasm tagging of callee values for
32bit.
(JSC::CalleeBits::CalleeBits):
(JSC::CalleeBits::operator=):
(JSC::CalleeBits::boxWasm):
(JSC::CalleeBits::isWasm const):
(JSC::CalleeBits::asWasmCallee const):
- interpreter/Register.h:
(JSC::Register::unboxedFloat const):
(JSC::Register::asanUnsafeUnboxedFloat const):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::unboxDouble):
- jit/RegisterAtOffsetList.cpp:
(JSC::RegisterAtOffsetList::RegisterAtOffsetList):
- jit/RegisterAtOffsetList.h:
(JSC::RegisterAtOffsetList::sizeOfAreaInBytes const):
- jit/RegisterSet.cpp:
(JSC::RegisterSet::macroScratchRegisters):
- llint/LLIntOfflineAsmConfig.h:
- llint/LowLevelInterpreter32_64.asm:
- llint/WebAssembly.asm:
- llint/WebAssembly32_64.asm: Added.
- llint/WebAssembly64.asm: Added.
- offlineasm/arm.rb:
- offlineasm/instructions.rb:
- offlineasm/registers.rb:
- offlineasm/risc.rb:
- runtime/JSCJSValue.h:
(JSC::wasmUnboxedFloat):
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::JSValue):
- wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::useSignalingMemory const):
(JSC::Wasm::AirIRGenerator::AirIRGenerator):
(JSC::Wasm::AirIRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::AirIRGenerator::addCall):
- wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::useSignalingMemory const):
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::addArguments):
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::B3IRGenerator::memoryKind):
(JSC::Wasm::B3IRGenerator::addCall):
- wasm/WasmBinding.cpp:
(JSC::Wasm::wasmToWasm):
- wasm/WasmCallee.cpp:
(JSC::Wasm::LLIntCallee::calleeSaveRegisters):
- wasm/WasmCalleeGroup.cpp:
(JSC::Wasm::CalleeGroup::isSafeToRun):
- wasm/WasmCallingConvention.cpp:
(JSC::Wasm::jsCallingConvention):
(JSC::Wasm::wasmCallingConvention):
- wasm/WasmCallingConvention.h:
(JSC::Wasm::CallInformation::computeResultsOffsetList):
(JSC::Wasm::WasmCallingConvention::WasmCallingConvention):
(JSC::Wasm::WasmCallingConvention::marshallLocationImpl const):
(JSC::Wasm::WasmCallingConvention::marshallLocation const):
(JSC::Wasm::JSCallingConvention::JSCallingConvention):
(JSC::Wasm::JSCallingConvention::marshallLocationImpl const):
(JSC::Wasm::JSCallingConvention::marshallLocation const):
(JSC::Wasm::JSCallingConvention::callInformationFor const):
- wasm/WasmFormat.h:
- wasm/WasmIndexOrName.cpp:
(JSC::Wasm::IndexOrName::IndexOrName):
(JSC::Wasm::makeString):
- wasm/WasmIndexOrName.h:
(JSC::Wasm::IndexOrName::IndexOrName):
(JSC::Wasm::IndexOrName::isEmpty const):
(JSC::Wasm::IndexOrName::isIndex const):
(JSC::Wasm::IndexOrName::isName const):
(JSC::Wasm::IndexOrName::index const):
(JSC::Wasm::IndexOrName::name const):
(JSC::Wasm::IndexOrName::nameSection const):
- wasm/WasmInstance.h:
(JSC::Wasm::Instance::updateCachedMemory):
- wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::virtualRegisterForWasmLocal):
(JSC::Wasm::LLIntGenerator::callInformationForCaller):
(JSC::Wasm::LLIntGenerator::callInformationForCallee):
(JSC::Wasm::LLIntGenerator::addArguments):
(JSC::Wasm::LLIntGenerator::addLoop):
- wasm/WasmLLIntPlan.cpp:
(JSC::Wasm::LLIntPlan::didCompleteCompilation):
- wasm/WasmMemory.cpp:
(JSC::Wasm::MemoryHandle::~MemoryHandle):
(JSC::Wasm::Memory::tryCreate):
(JSC::Wasm::Memory::growShared):
(JSC::Wasm::Memory::grow):
(JSC::Wasm::Memory::copy):
- wasm/WasmMemory.h:
- wasm/WasmMemoryInformation.cpp:
(JSC::Wasm::PinnedRegisterInfo::get):
- wasm/WasmMemoryInformation.h:
(JSC::Wasm::PinnedRegisterInfo::toSave const):
- wasm/WasmMemoryMode.cpp:
(JSC::Wasm::makeString):
- wasm/WasmMemoryMode.h:
- wasm/WasmOpcodeOrigin.cpp:
- wasm/WasmOpcodeOrigin.h:
- wasm/WasmOperations.cpp:
(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):
- wasm/WasmOperations.h:
- wasm/WasmPageCount.h:
- wasm/WasmParser.h:
(JSC::Wasm::Parser<SuccessType>::parseUInt32):
(JSC::Wasm::Parser<SuccessType>::parseUInt64):
- wasm/WasmSlowPaths.cpp:
(JSC::LLInt::WASM_SLOW_PATH_DECL):
(JSC::LLInt::slow_path_wasm_popcount):
(JSC::LLInt::slow_path_wasm_popcountll):
(JSC::LLInt::slow_path_wasm_i32_div_s):
(JSC::LLInt::slow_path_wasm_i32_div_u):
(JSC::LLInt::slow_path_wasm_i32_rem_s):
(JSC::LLInt::slow_path_wasm_i32_rem_u):
(JSC::LLInt::slow_path_wasm_i64_div_s):
(JSC::LLInt::slow_path_wasm_i64_div_u):
(JSC::LLInt::slow_path_wasm_i64_rem_s):
(JSC::LLInt::slow_path_wasm_i64_rem_u):
- wasm/WasmSlowPaths.h:
- wasm/WasmValueLocation.cpp:
(JSC::Wasm::ValueLocation::dump const):
(WTF::printInternal):
- wasm/WasmValueLocation.h:
(JSC::Wasm::ValueLocation::ValueLocation):
(JSC::Wasm::ValueLocation::isGPR const):
(JSC::Wasm::ValueLocation::isFPR const):
(JSC::Wasm::ValueLocation::isStack const):
(JSC::Wasm::ValueLocation::isStackArgument const):
(JSC::Wasm::ValueLocation::jsr const):
(JSC::Wasm::ValueLocation::fpr const):
(JSC::Wasm::ValueLocation::reg): Deleted.
(JSC::Wasm::ValueLocation::isReg const): Deleted.
(JSC::Wasm::ValueLocation::reg const): Deleted.
(JSC::Wasm::ValueLocation::gpr const): Deleted.
- wasm/js/JSToWasm.cpp:
(JSC::Wasm::marshallJSResult):
(JSC::Wasm::createJSToWasmWrapper):
- wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJS):
- wasm/js/WebAssemblyFunction.cpp:
(JSC::WebAssemblyFunction::previousInstanceOffset const):
(JSC::WebAssemblyFunction::jsCallEntrypointSlow):
- wasm/js/WebAssemblyGlobalConstructor.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
- wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::initializeExports):
- wtf/PlatformEnable.h: enable WebAssembly on ARMv7.
- Scripts/run-jsc-stress-tests: allow to run the wasm tests on
armv7 even without jit support (for now).
Canonical link: https://commits.webkit.org/251045@main
