Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Jun 7, 2022:

10:20 PM Changeset in webkit [295376] by Megan Gardner

• 1 edit in trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm

Upstream iOS grammar checking.
​https://bugs.webkit.org/show_bug.cgi?id=241388

Reviewed by Wenson Hsieh and Tim Horton.

Upstream work for grammar checking colors for iOS.

• Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::grammarColor):

Canonical link: ​https://commits.webkit.org/251384@main

9:45 PM Changeset in webkit [295375] by Ryan Haddad

• 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp

REGRESSION (250986@main): [iOS/macOS] ASSERTION FAILED: isASCII(characters[I]) in WTF::ASCIILiteral WTF::StringLiterals::operator""_s(const char *, size_t)
​https://bugs.webkit.org/show_bug.cgi?id=241380

Reviewed by Chris Dumez.

One of the subtests in this API test uses a non-ASCII character.
Use StringView::fromLatin1() since that worked on another test in
251205@main.

• Tools/TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:

(TestWebKitAPI::TEST):

Canonical link: ​https://commits.webkit.org/251383@main

9:34 PM Changeset in webkit [295374] by Patrick Angle

• 5 edits in trunk/Source/WebKit/UIProcess/Inspector

Web Inspector: Non-reproducible crash at WebKit::WebInspectorUIProxy::platformDetach
​https://bugs.webkit.org/show_bug.cgi?id=240284
rdar://91720039

Reviewed by Devin Rousso.

Speculative fix for non-reproducible crash. When WebInspectorUIProxy::platformDetach is called from
WebInspectorUIProxy::closeFrontendPageAndWindow`, it appears to be possible for the inspected page to have
already been discarded (via WebInspectorUIProxy::reset). This is reinforced by the fact that
WebInspectorUIProxy::closeFrontendPageAndWindow already guards use of inspectedPage(). We should do the same
here, and should also guard other places we use inspectedPage() to help future folks (including me)
understand that the existance of an inspectedPage() is not guaranteed.

• UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:

(WebKit::WebInspectorUIProxy::platformCreateFrontendWindow):

• If we don't have an inspected page when creating a window for the frontend, use the default window size by

passing an empty NSRect to WebInspectorUIProxy::createFrontendWindow.

(WebKit::WebInspectorUIProxy::platformResetState):
(WebKit::WebInspectorUIProxy::platformBringToFront):
(WebKit::WebInspectorUIProxy::platformBringInspectedPageToFront):
(WebKit::WebInspectorUIProxy::windowFrameDidChange):

• If the inspected page no longer exists, don't try to use it.

(WebKit::WebInspectorUIProxy::platformCanAttach):
(WebKit::WebInspectorUIProxy::platformAttach):

• Update platformCanAttach to return false if we no longer have an inspected page, and assert that we have an

inspected page in platformAttach since any call to it should be guarded on platformCanAttach

(WebKit::WebInspectorUIProxy::platformDetach):

• We should attempt to clean up as much of the attachment as we can, but work around the possibility that the inspected

page is no longer available.

• Clean up newlines while we are here.

(WebKit::WebInspectorUIProxy::platformInspectedWindowHeight): Deleted.
(WebKit::WebInspectorUIProxy::platformInspectedWindowWidth): Deleted.

• These methods were unused on Mac.

• UIProcess/Inspector/WebInspectorUIProxy.cpp:

(WebKit::WebInspectorUIProxy::open):

• Add a check that we can actually attach in our current state when opening, otherwise fall back to creating a window instead.

(WebKit::WebInspectorUIProxy::platformInspectedWindowHeight): Deleted.
(WebKit::WebInspectorUIProxy::platformInspectedWindowWidth): Deleted.

• UIProcess/Inspector/WebInspectorUIProxy.h:
• UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp:

(WebKit::WebInspectorUIProxy::platformAttach):
(WebKit::WebInspectorUIProxy::platformInspectedWindowHeight): Deleted.
(WebKit::WebInspectorUIProxy::platformInspectedWindowWidth): Deleted.

• UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp:

(WebKit::WebInspectorUIProxy::platformAttach):
(WebKit::WebInspectorUIProxy::platformInspectedWindowHeight): Deleted.
(WebKit::WebInspectorUIProxy::platformInspectedWindowWidth): Deleted.

• Inline Windows/GTK usage of platformInspectedWindow*, since they are only used once, not used by the

superclass any more, and also not used on all platforms.

Canonical link: ​https://commits.webkit.org/251382@main

9:23 PM Changeset in webkit [295373] by Cameron McCormack

• 63 edits
  1 copy
  15 adds in trunk

Add a new DrawDecomposedGlyphs display list item to avoid repeatedly sending glyphs when using the GlyphDisplayListCache
​https://bugs.webkit.org/show_bug.cgi?id=240497
<rdar://93387615>

Reviewed by Simon Fraser.

The GlyphDisplayListCache is used to record a display list for
frequently painting text content. With GPU Process DOM rendering, there
is significant overhead in sending the contents of these display lists
over IPC. The contents of these display lists don't change if the text
content in the document doesn't change, so we could greatly reduce the
overhead by treating the data inside a display list item for glyph
drawing as a remote resource.

This commit adds:

• a new display list item, DrawDecomposedGlyphs, to represent drawing a glyph list resource
• a new class, DecomposedGlyphs, which is the resource type
• a new struct, PositionedGlyphs, to provide a common place for the glyph drawing fields (the vector of glyph IDs, the anchor position, etc.) to live, so that we don't have duplication between DisplayList::DrawGlyphs and DecomposedGlyphs

So that a DrawDecomposedGlyphs command can be replayed from a
GlyphDisplayListCache's in-memory display list and recorded to a
RemoteDisplayListRecorder, the GraphicsContext API gains a new
drawDecomposedGlyphs function.

A new argument to the DisplayList::RecordImpl constructor (and the
DrawGlyphsRecorder) is added to represent how to record drawText
commands:

• DrawGlyphsMode::Normal, which records each GraphicsContext::drawText call with a single DrawText command
• DrawGlyphsMode::DeconstructToDrawGlyphsCommands, which ensures different text layers get deconstructed into separate DrawText commands
• DrawGlyphsMode::DeconstructToDrawDecomposedGlyphsCommands, which ensures different text layers get desconstructed into separate DrawDecomposedGlyphs commands

FontCascade::displayListForTextRun is updated to use that last value.

Additionally, GlyphDisplayListCache is extended to cache display lists
keyed off TextRun/FontCascade/etc. values. This allows sharing of the same
cached display list between different elements on the page that have the same
text content.

This sharing would not be valid if the two elements have different
values for the color property, and the text contains COLRv0 glyphs that
alternate painting of specific colors and the color fill color, since
the recording would incorrectly record a setFillBrush command
corresponding to the first element's fill color. Rather than extend the
glyph recorder to parameterize the current fill (and stroke) colors, we
detect when outlines are drawn with colors other than the context's
initial colors, and prevent sharing. This is done by checking whether
the recorded display list contains items that aren't known to be safe
for sharing.

Similarly, if the sharing would not be valid if the contains bitmap
images (like those from emoji fonts) or SVG glyphs, both of which are
captured as DrawNativeImage commands, if the text is drawn at different
scales. This is because the size of the images is dependent on the
scale. We detect and prevent reuse across different text runs if the
scale is different, by checking the recorded display list for
DrawNativeImage commands and by storing the context scale on the
GlyphDisplayListCache::Entry.

• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-color-expected.txt:
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-colr-unshared-expected.txt: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-colr-unshared.html: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-scaled-unshared-expected.txt: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-scaled-unshared.html: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-shadow-unshared-expected.txt: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-shadow-unshared.html: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-shared-expected.txt: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-shared.html: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-svg-unshared-expected.txt: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-svg-unshared.html: Added.
• Source/WTF/wtf/PlatformHave.h:
• Source/WebCore/Headers.cmake:
• Source/WebCore/Sources.txt:
• Source/WebCore/WebCore.xcodeproj/project.pbxproj:
• Source/WebCore/page/MemoryRelease.cpp:

(WebCore::releaseNoncriticalMemory):

• Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp:

(WebCore::BifurcatedGraphicsContext::drawDecomposedGlyphs):

• Source/WebCore/platform/graphics/BifurcatedGraphicsContext.h:
• Source/WebCore/platform/graphics/DecomposedGlyphs.cpp: Added.

(WebCore::DecomposedGlyphs::create):
(WebCore::DecomposedGlyphs::DecomposedGlyphs):
(WebCore::m_renderingResourceIdentifier):

• Source/WebCore/platform/graphics/DecomposedGlyphs.h: Added.

(WebCore::DecomposedGlyphs::positionedGlyphs const):
(WebCore::DecomposedGlyphs::bounds const):
(WebCore::DecomposedGlyphs::addObserver):
(WebCore::DecomposedGlyphs::removeObserver):
(WebCore::DecomposedGlyphs::renderingResourceIdentifier const):

• Source/WebCore/platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::displayListForTextRun const):

• Source/WebCore/platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawDecomposedGlyphs):

• Source/WebCore/platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::drawGlyphsAndCacheResources):
(WebCore::GraphicsContext::drawGlyphsAndCacheFont): Deleted.

• Source/WebCore/platform/graphics/NullGraphicsContext.h:
• Source/WebCore/platform/graphics/PositionedGlyphs.cpp: Copied from Source/WebCore/platform/graphics/win/DrawGlyphsRecorderWin.cpp.

(WebCore::PositionedGlyphs::computeBounds const):

• Source/WebCore/platform/graphics/PositionedGlyphs.h: Added.

(WebCore::PositionedGlyphs::PositionedGlyphs):
(WebCore::PositionedGlyphs::encode const):
(WebCore::PositionedGlyphs::decode):

• Source/WebCore/platform/graphics/TextRun.cpp:

(WebCore::operator<<):

• Source/WebCore/platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::isHashTableEmptyValue const):
(WebCore::TextRun::isHashTableDeletedValue const):
(WebCore::TextRun::isolatedCopy const):

• Source/WebCore/platform/graphics/TextRunHash.h: Added.

(WebCore::add):
(WebCore::TextRun::operator== const):
(WebCore::TextRunHash::hash):
(WebCore::TextRunHash::equal):
(WTF::HashTraits<WebCore::TextRun>::isDeletedValue):
(WTF::HashTraits<WebCore::TextRun>::isEmptyValue):
(WTF::HashTraits<WebCore::TextRun>::constructDeletedValue):
(WTF::HashTraits<WebCore::TextRun>::emptyValue):

• Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContextCairo::drawDecomposedGlyphs):

• Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.h:
• Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:

(WebCore::DrawGlyphsRecorder::createInternalContext):
(WebCore::DrawGlyphsRecorder::updateCTM):
(WebCore::DrawGlyphsRecorder::recordDrawGlyphs):

• Source/WebCore/platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::description const):
(WebCore::DisplayList::DisplayList::append):

• Source/WebCore/platform/graphics/displaylists/DisplayList.h:

(WebCore::DisplayList::DisplayList::cacheDecomposedGlyphs):

• Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp:

(WebCore::DisplayList::ItemHandle::apply):
(WebCore::DisplayList::ItemHandle::destroy):
(WebCore::DisplayList::ItemHandle::safeCopy const):

• Source/WebCore/platform/graphics/displaylists/DisplayListItemType.cpp:

(WebCore::DisplayList::sizeOfItemInBytes):
(WebCore::DisplayList::isDrawingItem):
(WebCore::DisplayList::isInlineItem):

• Source/WebCore/platform/graphics/displaylists/DisplayListItemType.h:
• Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawGlyphs::DrawGlyphs):
(WebCore::DisplayList::m_bounds):
(WebCore::DisplayList::DrawGlyphs::apply const):
(WebCore::DisplayList::DrawDecomposedGlyphs::apply const):
(WebCore::DisplayList::operator<<):
(WebCore::DisplayList::dumpItem):
(WebCore::DisplayList::dumpItemHandle):
(WebCore::DisplayList::DrawGlyphs::computeBounds): Deleted.

• Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawGlyphs::localAnchor const):
(WebCore::DisplayList::DrawGlyphs::anchorPoint const):
(WebCore::DisplayList::DrawGlyphs::glyphs const):
(WebCore::DisplayList::DrawGlyphs::encode const):
(WebCore::DisplayList::DrawGlyphs::decode):
(WebCore::DisplayList::DrawDecomposedGlyphs::DrawDecomposedGlyphs):
(WebCore::DisplayList::DrawDecomposedGlyphs::fontIdentifier const):
(WebCore::DisplayList::DrawDecomposedGlyphs::decomposedGlyphsIdentifier const):
(WebCore::DisplayList::DrawDecomposedGlyphs::globalBounds const):
(WebCore::DisplayList::DrawDecomposedGlyphs::localBounds const):

• Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::Recorder):
(WebCore::DisplayList::Recorder::shouldDeconstructDrawGlyphs const):
(WebCore::DisplayList::Recorder::drawGlyphs):
(WebCore::DisplayList::Recorder::drawDecomposedGlyphs):
(WebCore::DisplayList::Recorder::drawGlyphsAndCacheResources):
(WebCore::DisplayList::Recorder::drawGlyphsAndCacheFont): Deleted.

• Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:
• Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp:

(WebCore::DisplayList::RecorderImpl::RecorderImpl):
(WebCore::DisplayList::RecorderImpl::recordDrawDecomposedGlyphs):
(WebCore::DisplayList::RecorderImpl::recordResourceUse):

• Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h:
• Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::applyDrawDecomposedGlyphs):
(WebCore::DisplayList::Replayer::applyItem):
(WebCore::DisplayList::Replayer::replay):

• Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.h:
• Source/WebCore/platform/graphics/displaylists/DisplayListResourceHeap.h:

(WebCore::DisplayList::LocalResourceHeap::add):

• Source/WebCore/platform/graphics/harfbuzz/DrawGlyphsRecorderHarfBuzz.cpp:

(WebCore::DrawGlyphsRecorder::drawGlyphs):

• Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:

(Nicosia::CairoOperationRecorder::drawDecomposedGlyphs):

• Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
• Source/WebCore/platform/graphics/win/DrawGlyphsRecorderWin.cpp:

(WebCore::DrawGlyphsRecorder::drawGlyphs):

• Source/WebCore/platform/text/TextDirection.h:

(WebCore::operator<<):

• Source/WebCore/platform/text/TextFlags.cpp:

(WebCore::operator<<):

• Source/WebCore/platform/text/TextFlags.h:

(WebCore::ExpansionBehavior::operator== const):

• Source/WebCore/rendering/GlyphDisplayListCache.cpp: Added.

(WebCore::canShareDisplayListWithItem):
(WebCore::add):
(WebCore::GlyphDisplayListCacheKeyTranslator::hash):
(WebCore::GlyphDisplayListCacheKeyTranslator::equal):
(WebCore::GlyphDisplayListCache::singleton):
(WebCore::GlyphDisplayListCache::clear):
(WebCore::GlyphDisplayListCache::size const):
(WebCore::GlyphDisplayListCache::sizeInBytes const):
(WebCore::GlyphDisplayListCache::get):
(WebCore::GlyphDisplayListCache::getIfExists):
(WebCore::GlyphDisplayListCache::remove):
(WebCore::GlyphDisplayListCache::canShareDisplayList):
(WebCore::GlyphDisplayListCacheEntry::~GlyphDisplayListCacheEntry):

• Source/WebCore/rendering/GlyphDisplayListCache.h:

(WebCore::GlyphDisplayListCacheEntry::create):
(WebCore::GlyphDisplayListCacheEntry::operator== const):
(WebCore::GlyphDisplayListCacheEntry::displayList):
(WebCore::GlyphDisplayListCacheEntry::GlyphDisplayListCacheEntry):
(WebCore::add):
(WebCore::GlyphDisplayListCacheEntryHash::hash):
(WebCore::GlyphDisplayListCacheEntryHash::equal):
(WebCore::GlyphDisplayListCache::get):
(WebCore::GlyphDisplayListCache::getIfExists):
(WebCore::GlyphDisplayListCache::remove):
(WebCore::GlyphDisplayListCache::singleton): Deleted.
(WebCore::GlyphDisplayListCache::clear): Deleted.
(WebCore::GlyphDisplayListCache::size const): Deleted.
(WebCore::GlyphDisplayListCache::sizeInBytes const): Deleted.

• Source/WebCore/rendering/RenderLayerCompositor.cpp:
• Source/WebCore/rendering/TextPainter.cpp:

(WebCore::TextPainter::clearGlyphDisplayLists): Deleted.

• Source/WebCore/rendering/TextPainter.h:

(WebCore::TextPainter::setGlyphDisplayListIfNeeded):
(WebCore::TextPainter::removeGlyphDisplayList):
(WebCore::TextPainter::glyphDisplayListIfExists):

• Source/WebCore/testing/Internals.cpp:

(WebCore::toDisplayListFlags):
(WebCore::Internals::displayListForElement):
(WebCore::Internals::replayDisplayListForElement):
(WebCore::Internals::cachedGlyphDisplayListsForTextNode):

• Source/WebCore/testing/Internals.h:
• Source/WebCore/testing/Internals.idl:
• Source/WebKit/GPUProcess/graphics/QualifiedResourceHeap.h:

(WebKit::QualifiedResourceHeap::add):
(WebKit::QualifiedResourceHeap::getDecomposedGlyphs const):
(WebKit::QualifiedResourceHeap::removeDecomposedGlyphs):
(WebKit::QualifiedResourceHeap::checkInvariants const):

• Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:

(WebKit::RemoteDisplayListRecorder::drawDecomposedGlyphs):
(WebKit::RemoteDisplayListRecorder::drawDecomposedGlyphsWithQualifiedIdentifiers):

• Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h:
• Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in:
• Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::cacheFontWithQualifiedIdentifier):
(WebKit::RemoteRenderingBackend::cacheDecomposedGlyphs):
(WebKit::RemoteRenderingBackend::cacheDecomposedGlyphsWithQualifiedIdentifier):

• Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
• Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in:
• Source/WebKit/GPUProcess/graphics/RemoteResourceCache.cpp:

(WebKit::RemoteResourceCache::cacheDecomposedGlyphs):
(WebKit::RemoteResourceCache::cachedDecomposedGlyphs const):
(WebKit::RemoteResourceCache::releaseRemoteResource):

• Source/WebKit/GPUProcess/graphics/RemoteResourceCache.h:
• Source/WebKit/Scripts/webkit/messages.py:
• Source/WebKit/Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<DecomposedGlyphs>::encode):
(IPC::ArgumentCoder<DecomposedGlyphs>::decode):

• Source/WebKit/Shared/WebCoreArgumentCoders.h:
• Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:

(WebKit::RemoteDisplayListRecorderProxy::RemoteDisplayListRecorderProxy):
(WebKit::RemoteDisplayListRecorderProxy::recordDrawDecomposedGlyphs):
(WebKit::RemoteDisplayListRecorderProxy::recordResourceUse):

• Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
• Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::cacheDecomposedGlyphs):

• Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
• Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:

(WebKit::RemoteResourceCacheProxy::~RemoteResourceCacheProxy):
(WebKit::RemoteResourceCacheProxy::recordDecomposedGlyphsUse):
(WebKit::RemoteResourceCacheProxy::releaseDecomposedGlyphs):
(WebKit::RemoteResourceCacheProxy::clearDecomposedGlyphsMap):
(WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed):

• Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:

Canonical link: ​https://commits.webkit.org/251381@main

8:48 PM Changeset in webkit [295372] by Said Abou-Hallawa

• 7 edits
  1 copy
  1 add in trunk/Source

[GPU Process] [Filters] Make FilterImage allocate shared memory if it is created in GPUProcess
​https://bugs.webkit.org/show_bug.cgi?id=240810
<rdar://problem/94118129>

Reviewed by Kimmo Kinnunen.

PixelBuffer will be sub-classed to a new class named 'ShareablePixelBuffer'. This
class will be backed by SharedMemory for the pixels.

ImageBufferShareableAllocator will call ShareablePixelBuffer::tryCreate() to
allocate PixelBuffe for software filters when they are applied in GPUProcess.

The plan is to attribute the handle of the underlying SharedMemory to WebProcess.

• Source/WebKit/GPUProcess/graphics/ImageBufferShareableAllocator.cpp:

(WebKit::ImageBufferShareableAllocator::createPixelBuffer const):

• Source/WebKit/GPUProcess/graphics/ShareablePixelBuffer.cpp: Copied from Source/WebKit/GPUProcess/graphics/ImageBufferShareableAllocator.cpp.

(WebKit::ShareablePixelBuffer::tryCreate):
(WebKit::ShareablePixelBuffer::ShareablePixelBuffer):
(WebKit::ShareablePixelBuffer::createScratchPixelBuffer const):

• Source/WebKit/GPUProcess/graphics/ShareablePixelBuffer.h: Added.

(WebKit::ShareablePixelBuffer::data const):
(WebKit::ShareablePixelBuffer::takeData):

• Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
• Source/WebKit/Sources.txt:
• Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: ​https://commits.webkit.org/251380@main

5:38 PM Changeset in webkit [295371] by Tyler Wilcock

• 14 edits in trunk

AX: Update the isolated tree in response to dynamic aria-level and aria-setsize changes
​https://bugs.webkit.org/show_bug.cgi?id=241361

Reviewed by Chris Fleizach.

New testcases added to aria-setsize-posinset.html, heading-level.html,
and mac/aria-tree.html to cover these changes.

• LayoutTests/accessibility/aria-setsize-posinset-expected.txt:
• LayoutTests/accessibility/aria-setsize-posinset.html:

Add test case that dynamically changes aria-setsize.

• LayoutTests/accessibility/heading-level-expected.txt:
• LayoutTests/accessibility/heading-level.html:

Add test case that dynamically changes aria-level on an ARIA heading.

• LayoutTests/accessibility/mac/aria-tree-expected.txt:
• LayoutTests/accessibility/mac/aria-tree.html:

Add test case that dynamically changes aria-level on a treeitem.

• LayoutTests/platform/ios/TestExpectations:

Enable heading-level.html on iOS.

• Source/WebCore/accessibility/AXLogger.cpp:

(WebCore::operator<<):

• Source/WebCore/accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):

• Source/WebCore/accessibility/AXObjectCache.h:
• Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

• Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::updateNodeProperty):

• Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
• Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm

Implement AccessibilityUIElement::intValue() so heading-level.html can pass.

Canonical link: ​https://commits.webkit.org/251379@main

5:33 PM Changeset in webkit [295370] by Kate Cheney

• 3 edits in trunk/Source

Upstream support for new share sheet behaviors in macOS Ventura
​https://bugs.webkit.org/show_bug.cgi?id=241384
rdar://94558182

Reviewed by Wenson Hsieh.

Upstream new share sheet changes. Remove staging code now that
changes have been in the build for a significant amount of time.

• Source/WTF/wtf/PlatformHave.h:
• Source/WebKit/UIProcess/Cocoa/WKShareSheet.h:
• Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm:

(-[WKShareSheet presentWithShareDataArray:inRect:]):
(-[WKShareSheet canShowPickerAsync:]): Deleted.
(-[WKShareSheet showPickerAsync:showRelativeToRect:ofView:completion:]): Deleted.

Canonical link: ​https://commits.webkit.org/251378@main

5:26 PM Changeset in webkit [295369] by commit-queue@webkit.org

• 1 edit in trunk/Source/WebKit/UIProcess/mac/WebDateTimePickerMac.mm

Datetime-local Field Picker Shows Incorrect Date when seconds is zero
​https://bugs.webkit.org/show_bug.cgi?id=239778

Patch by Mike Wyrzykowski <​mwyrzykowski@apple.com> on 2022-06-07
Reviewed by Aditya Keerthi.

In r286869, a change was made to WebCore::DateComponents::toStringForTime as
noted in the changelog:

The output will use the shortest possible string, omitting seconds or milliseconds when 0, as per

​https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#valid-normalised-local-date-and-time-string

however that broke WebDateTimePicker when seconds or milliseconds is specified yet they are zero.

Since the change to WebCore::DateComponents is to spec, change WebDateTimePicker to handle this behavior
change instead.

• Source/WebKit/UIProcess/mac/WebDateTimePickerMac.mm:

(-[WKDateTimePicker updatePicker:]):
-[NSDataFormatter dateFromString:] will return nil if the format
requires seconds but the seconds is omitted, so try fallback formats
without milliseconds or seconds.

(-[WKDateTimePicker dateFormatFallbackForFormat:]):
Fallback from milliseconds -> seconds -> time without seconds.

Canonical link: ​https://commits.webkit.org/251377@main

4:57 PM Changeset in webkit [295368] by commit-queue@webkit.org

• 5 edits
  2 adds in trunk/Source/WebCore

Isolate TrackBuffer from SourceBufferPrivate
​https://bugs.webkit.org/show_bug.cgi?id=241290

Patch by Youssef Soliman <​youssefdevelops@gmail.com> on 2022-06-07
Reviewed by Eric Carlson.

Currently TrackBuffer is just a struct within SourceBufferPrivate,
it makes sense to extract TrackBuffer as its own platform agnostic
class for use in future media players.

• Source/WebCore/Headers.cmake:
• Source/WebCore/Sources.txt:
• Source/WebCore/WebCore.xcodeproj/project.pbxproj:
• Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:

(WebCore::SourceBufferPrivate::resetTimestampOffsetInTrackBuffers):
(WebCore::SourceBufferPrivate::resetTrackBuffers):
(WebCore::SourceBufferPrivate::updateHighestPresentationTimestamp):
(WebCore::SourceBufferPrivate::updateBufferedFromTrackBuffers):
(WebCore::SourceBufferPrivate::reenqueSamples):
(WebCore::SourceBufferPrivate::seekToTime):
(WebCore::SourceBufferPrivate::clearTrackBuffers):
(WebCore::SourceBufferPrivate::bufferedSamplesForTrackId):
(WebCore::SourceBufferPrivate::fastSeekTimeForMediaTime):
(WebCore::SourceBufferPrivate::updateMinimumUpcomingPresentationTime):
(WebCore::SourceBufferPrivate::trySignalAllSamplesInTrackEnqueued):
(WebCore::SourceBufferPrivate::provideMediaData):
(WebCore::SourceBufferPrivate::reenqueueMediaForTime):
(WebCore::SourceBufferPrivate::reenqueueMediaIfNeeded):
(WebCore::removeSamplesFromTrackBuffer):
(WebCore::SourceBufferPrivate::removeCodedFrames):
(WebCore::SourceBufferPrivate::evictCodedFrames):
(WebCore::SourceBufferPrivate::totalTrackBufferSizeInBytes const):
(WebCore::SourceBufferPrivate::addTrackBuffer):
(WebCore::SourceBufferPrivate::setAllTrackBuffersNeedRandomAccess):
(WebCore::SourceBufferPrivate::didReceiveSample):
(WebCore::roundTowardsTimeScaleWithRoundingMargin): Deleted.
(WebCore::SourceBufferPrivate::TrackBuffer::TrackBuffer): Deleted.
(WebCore::enqueueDiscontinuityBoundary): Deleted.
(WebCore::decodeTimeComparator): Deleted.

• Source/WebCore/platform/graphics/SourceBufferPrivate.h:
• Source/WebCore/platform/graphics/TrackBuffer.cpp: Added.

(WebCore::roundTowardsTimeScaleWithRoundingMargin):
(WebCore::TrackBuffer::create):
(WebCore::TrackBuffer::TrackBuffer):
(WebCore::TrackBuffer::maximumBufferedTime const):
(WebCore::TrackBuffer::addBufferedRange):
(WebCore::TrackBuffer::addSample):
(WebCore::TrackBuffer::updateMinimumUpcomingPresentationTime):
(WebCore::TrackBuffer::reenqueueMediaForTime):
(WebCore::TrackBuffer::findSeekTimeForTargetTime):
(WebCore::TrackBuffer::removeSamples):
(WebCore::decodeTimeComparator):

• Source/WebCore/platform/graphics/TrackBuffer.h: Added.

Canonical link: ​https://commits.webkit.org/251376@main

3:46 PM Changeset in webkit [295367] by Wenson Hsieh

• 19 edits
  1 move in trunk

[Live Text in Video] Rename "video extraction" code to refer to text recognition instead
​https://bugs.webkit.org/show_bug.cgi?id=241381
rdar://94446831

Reviewed by Tim Horton.

Replace all references to "fullscreen video extraction" with "text recognition in fullscreen video"
instead, to reflect the real purpose of this code. No change in behavior.

• Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::didChangePlaybackRate):
(WebKit::WebPageProxy::didChangeCurrentTime):
(WebKit::WebPageProxy::updateFullscreenVideoTextRecognition):
(WebKit::WebPageProxy::fullscreenVideoTextRecognitionTimerFired):
(WebKit::WebPageProxy::updateFullscreenVideoExtraction): Deleted.
(WebKit::WebPageProxy::fullscreenVideoExtractionTimerFired): Deleted.

• Source/WebKit/UIProcess/Cocoa/WebViewImpl.h:
• Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::beginTextRecognitionForVideoInElementFullscreen):
(WebKit::WebViewImpl::cancelTextRecognitionForVideoInElementFullscreen):
(WebKit::WebViewImpl::beginElementFullscreenVideoExtraction): Deleted.
(WebKit::WebViewImpl::cancelElementFullscreenVideoExtraction): Deleted.

• Source/WebKit/UIProcess/PageClient.h:

(WebKit::PageClient::isTextRecognitionInFullscreenVideoEnabled const):
(WebKit::PageClient::beginTextRecognitionForVideoInElementFullscreen):
(WebKit::PageClient::cancelTextRecognitionForVideoInElementFullscreen):
(WebKit::PageClient::isFullscreenVideoExtractionEnabled const): Deleted.
(WebKit::PageClient::beginElementFullscreenVideoExtraction): Deleted.
(WebKit::PageClient::cancelElementFullscreenVideoExtraction): Deleted.

• Source/WebKit/UIProcess/WebPageProxy.cpp:

(WebKit::m_fullscreenVideoTextRecognitionTimer):
(WebKit::WebPageProxy::didEnterFullscreen):
(WebKit::WebPageProxy::didExitFullscreen):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
(WebKit::WebPageProxy::beginTextRecognitionForVideoInElementFullScreen):
(WebKit::WebPageProxy::cancelTextRecognitionForVideoInElementFullScreen):
(WebKit::m_fullscreenVideoExtractionTimer): Deleted.
(WebKit::WebPageProxy::extractVideoInElementFullScreen): Deleted.
(WebKit::WebPageProxy::cancelVideoExtractionInElementFullScreen): Deleted.

• Source/WebKit/UIProcess/WebPageProxy.h:
• Source/WebKit/UIProcess/WebPageProxy.messages.in:
• Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
• Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::beginTextRecognitionForFullscreenVideo):
(WebKit::PageClientImpl::cancelTextRecognitionForFullscreenVideo):
(WebKit::PageClientImpl::isTextRecognitionInFullscreenVideoEnabled const):
(WebKit::PageClientImpl::beginTextRecognitionForVideoInElementFullscreen):
(WebKit::PageClientImpl::cancelTextRecognitionForVideoInElementFullscreen):
(WebKit::PageClientImpl::beginFullscreenVideoExtraction): Deleted.
(WebKit::PageClientImpl::cancelFullscreenVideoExtraction): Deleted.
(WebKit::PageClientImpl::isFullscreenVideoExtractionEnabled const): Deleted.
(WebKit::PageClientImpl::beginElementFullscreenVideoExtraction): Deleted.
(WebKit::PageClientImpl::cancelElementFullscreenVideoExtraction): Deleted.

• Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView beginTextRecognitionForFullscreenVideo:playerViewController:]):
(-[WKContentView cancelTextRecognitionForFullscreenVideo:]):
(-[WKContentView isTextRecognitionInFullscreenVideoEnabled]):
(-[WKContentView beginTextRecognitionForVideoInElementFullscreen:bounds:]):
(-[WKContentView cancelTextRecognitionForVideoInElementFullscreen]):
(-[WKContentView beginFullscreenVideoExtraction:playerViewController:]): Deleted.
(-[WKContentView cancelFullscreenVideoExtraction:]): Deleted.
(-[WKContentView isFullscreenVideoExtractionEnabled]): Deleted.
(-[WKContentView beginElementFullscreenVideoExtraction:bounds:]): Deleted.
(-[WKContentView cancelElementFullscreenVideoExtraction]): Deleted.

• Source/WebKit/UIProcess/mac/PageClientImplMac.h:
• Source/WebKit/UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::beginTextRecognitionForVideoInElementFullscreen):
(WebKit::PageClientImpl::cancelTextRecognitionForVideoInElementFullscreen):
(WebKit::PageClientImpl::beginElementFullscreenVideoExtraction): Deleted.
(WebKit::PageClientImpl::cancelElementFullscreenVideoExtraction): Deleted.

• Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::WebFullScreenManager):
(WebKit::WebFullScreenManager::handleEvent):
(WebKit::WebFullScreenManager::mainVideoElementTextRecognitionTimerFired):
(WebKit::WebFullScreenManager::scheduleTextRecognitionForMainVideo):
(WebKit::WebFullScreenManager::endTextRecognitionForMainVideoIfNeeded):
(WebKit::WebFullScreenManager::setMainVideoElement):
(WebKit::WebFullScreenManager::mainVideoElementExtractionTimerFired): Deleted.
(WebKit::WebFullScreenManager::scheduleMainVideoElementExtraction): Deleted.
(WebKit::WebFullScreenManager::endMainVideoElementExtractionIfNeeded): Deleted.

• Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h:
• Source/WebKit/WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::beginTextRecognitionForVideoInElementFullScreen):
(WebKit::WebPage::cancelTextRecognitionForVideoInElementFullScreen):
(WebKit::WebPage::extractVideoInElementFullScreen): Deleted.
(WebKit::WebPage::cancelVideoExtractionInElementFullScreen): Deleted.

• Source/WebKit/WebProcess/WebPage/WebPage.h:
• Tools/TestWebKitAPI/SourcesCocoa.txt:
• Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenVideoTextRecognition.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenVideoExtraction.mm.

(swizzledPresentViewController):
(swizzledProcessRequest):
(swizzledSetAnalysis):
(+[FullscreenVideoTextRecognitionWebView create]):
(-[FullscreenVideoTextRecognitionWebView initWithFrame:configuration:]):
(-[FullscreenVideoTextRecognitionWebView loadVideoSource:]):
(-[FullscreenVideoTextRecognitionWebView enterFullscreen]):
(-[FullscreenVideoTextRecognitionWebView exitFullscreen]):
(-[FullscreenVideoTextRecognitionWebView didChangeValueForKey:]):
(-[FullscreenVideoTextRecognitionWebView pause]):
(-[FullscreenVideoTextRecognitionWebView play]):
(-[FullscreenVideoTextRecognitionWebView waitForVideoFrame]):
(-[FullscreenVideoTextRecognitionWebView hasActiveImageAnalysis]):
(-[FullscreenVideoTextRecognitionWebView waitForImageAnalysisToBegin]):
(-[FullscreenVideoTextRecognitionWebView waitForImageAnalysisToEnd]):
(TestWebKitAPI::TEST):

Canonical link: ​https://commits.webkit.org/251375@main

2:45 PM Changeset in webkit [295366] by Tyler Wilcock

• 4 edits
  2 adds in trunk

AX: WebKit does not trap user focus inside modals that have been DOM moved
​https://bugs.webkit.org/show_bug.cgi?id=240978

Reviewed by Andres Gonzalez.

In this patch, we now properly trap user focus inside non-empty modals
that have been DOM moved. This pattern is used in the WAI-ARIA aria-modal
usage example:

​https://w3c.github.io/aria-practices/examples/dialog-modal/dialog.html

We do this by re-computing the live and isolated trees when the active
modal changes, since the presence of a modal effects every element on
the page.

This patch also includes several other modal improvements:

• We no longer sometimes overwrite author manual focus (e.g. via JS) with our modal autofocus behavior.

• We now properly re-compute the active modal when focus changes. This is relevant in cases where there are multiple modals, and an author changes focus from one to another, making the latter the new active modal.

This patch removes m_focusModalNodeTimer in favor of a new function
called focusCurrentModal(), which allows precise and synchronous control
over when modal autofocus happens. The asynchronous nature of the timer
made it hard to prevent overwriting manual author focus (e.g. via JS).

This patch fixes existing tests in ITM:

• accessibility/aria-modal-multiple-dialogs.html
• accessibility/ignore-modals-without-any-content.html
• accessibility/mac/aria-modal-auto-focus.html

And adds a new test:
accessibility/recompute-current-modal-after-aria-modal-element-appears.html

• LayoutTests/accessibility/aria-modal-multiple-dialogs-expected.txt:
• LayoutTests/accessibility/aria-modal-multiple-dialogs.html:
• LayoutTests/accessibility/recompute-current-modal-after-aria-modal-element-appears-expected.txt: Added.
• LayoutTests/accessibility/recompute-current-modal-after-aria-modal-element-appears.html: Added.
• Source/WebCore/accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::updateCurrentModalNode):
(WebCore::AXObjectCache::updateCurrentModalNodeInternal):
(WebCore::AXObjectCache::modalNode):
(WebCore::AXObjectCache::deferNodeAddedOrRemoved):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::focusCurrentModal):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::currentModalNode): Deleted.
(WebCore::AXObjectCache::focusModalNode): Deleted.
(WebCore::AXObjectCache::focusModalNodeTimerFired): Deleted.
(WebCore::AXObjectCache::handleModalChange): Deleted.

• Source/WebCore/accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::focusCurrentModal):
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::focusModalNodeTimerFired): Deleted.
(WebCore::AXObjectCache::handleModalChange): Deleted.

Canonical link: ​https://commits.webkit.org/251374@main

2:31 PM Changeset in webkit [295365] by achristensen@apple.com

• 23 edits
  1 move
  1 add
  3 deletes in trunk/Source/WebKit

Remove WebCookieManagerProxy, replaced by API::HTTPCookieStore
​https://bugs.webkit.org/show_bug.cgi?id=240931

Reviewed by Brady Eidson.

• Source/WebKit/CMakeLists.txt:
• Source/WebKit/DerivedSources-input.xcfilelist:
• Source/WebKit/DerivedSources-output.xcfilelist:
• Source/WebKit/DerivedSources.make:
• Source/WebKit/NetworkProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::notifyCookiesDidChange):

• Source/WebKit/Sources.txt:
• Source/WebKit/SourcesGTK.txt:
• Source/WebKit/SourcesWPE.txt:
• Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp:

(API::HTTPCookieStore::HTTPCookieStore):
(API::HTTPCookieStore::~HTTPCookieStore):
(API::HTTPCookieStore::cookies):
(API::HTTPCookieStore::cookiesForURL):
(API::HTTPCookieStore::setCookies):
(API::HTTPCookieStore::deleteCookie):
(API::HTTPCookieStore::deleteAllCookies):
(API::HTTPCookieStore::deleteCookiesForHostnames):
(API::HTTPCookieStore::setHTTPCookieAcceptPolicy):
(API::HTTPCookieStore::getHTTPCookieAcceptPolicy):
(API::HTTPCookieStore::flushCookies):
(API::HTTPCookieStore::registerObserver):
(API::HTTPCookieStore::unregisterObserver):
(API::HTTPCookieStore::networkProcessIfExists):
(API::HTTPCookieStore::networkProcessLaunchingIfNecessary):
(API::APIWebCookieManagerProxyObserver::APIWebCookieManagerProxyObserver): Deleted.
(): Deleted.

• Source/WebKit/UIProcess/API/APIHTTPCookieStore.h:
• Source/WebKit/UIProcess/API/C/WKAPICast.h:
• Source/WebKit/UIProcess/API/C/WKContext.cpp:
• Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm:
• Source/WebKit/UIProcess/API/glib/WebKitCookieManager.cpp:

(CookieStoreObserver::CookieStoreObserver):
(_WebKitCookieManagerPrivate::cookieStore const):
(_WebKitCookieManagerPrivate::~_WebKitCookieManagerPrivate):
(webkitCookieManagerCreate):
(webkit_cookie_manager_get_accept_policy):
(webkit_cookie_manager_add_cookie):
(webkit_cookie_manager_get_cookies):
(webkit_cookie_manager_delete_cookie):
(WebCookieManagerProxyObserver::WebCookieManagerProxyObserver): Deleted.
(_WebKitCookieManagerPrivate::cookieManager const): Deleted.

• Source/WebKit/UIProcess/API/soup/HTTPCookieStoreSoup.cpp: Renamed from Source/WebKit/UIProcess/soup/WebCookieManagerProxySoup.cpp.

(API::HTTPCookieStore::setCookiePersistentStorage):

• Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::deleteAllCookies):

• Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::cookiesDidChange):
(WebKit::NetworkProcessProxy::flushCookies): Deleted.

• Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
• Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in:
• Source/WebKit/UIProcess/WebCookieManagerProxy.cpp: Removed.
• Source/WebKit/UIProcess/WebCookieManagerProxy.h: Removed.
• Source/WebKit/UIProcess/WebCookieManagerProxy.messages.in: Removed.
• Source/WebKit/UIProcess/WebProcessPool.cpp:
• Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::flushCookies): Deleted.

• Source/WebKit/UIProcess/WebsiteData/soup/WebsiteDataStoreSoup.cpp:

(WebKit::WebsiteDataStore::setCookiePersistentStorage):
(WebKit::WebsiteDataStore::setHTTPCookieAcceptPolicy):

• Source/WebKit/UIProcess/soup/WebProcessPoolSoup.cpp:
• Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: ​https://commits.webkit.org/251373@main

1:33 PM Changeset in webkit [295364] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/win/TestExpectations

[Gardening]: [ Windows EWS ] html5lib/generated/run-tests19-data.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=241382
<rdar://94559821>

Unreviewed test gardening.

• LayoutTests/platform/win/TestExpectations:

Canonical link: ​https://commits.webkit.org/251372@main

1:24 PM Changeset in webkit [295363] by Alan Bujtas

• 1 edit in trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

LineBuilder::rebuildLineForTrailingSoftHyphen may end up with no wrapping opportunities
​https://bugs.webkit.org/show_bug.cgi?id=241375
<rdar://94516475>

Reviewed by Antti Koivisto.

This is a speculative fix to address the overflow issue in rebuildLineForTrailingSoftHyphen, where we assume a non-empty m_wrapOpportunityList vector.

• Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::handleInlineContent):
(WebCore::Layout::LineBuilder::rebuildLineForTrailingSoftHyphen):

Canonical link: ​https://commits.webkit.org/251371@main

1:15 PM Changeset in webkit [295362] by commit-queue@webkit.org

• 1 edit in trunk/Tools/Scripts/hooks/prepare-commit-msg

[git-webkit] git-webkit revert won't trigger pre-commit hook properly
​https://bugs..webkit.org/show_bug.cgi?id=241202
rdar://problem/94251413

Patch by Zhifei Fang <​facetothefate@gmail.com> on 2022-06-07
Reviewed by Jonathan Bedard.

• Tools/Scripts/hooks/prepare-commit-msg:

Canonical link: ​https://commits.webkit.org/251370@main

1:14 PM Changeset in webkit [295361] by Alan Coon

• 10 edits
  1 delete in branches/safari-613-branch

Revert "Calls to print can result in unresponsive print modal"

This reverts commit 8a2d5954643fd470ce6846432c4e31397f21e829.

12:52 PM Changeset in webkit [295360] by Wenson Hsieh

• 19 edits in trunk/Source

Upstream WebKit support for Stage Manager on iPadOS
​https://bugs.webkit.org/show_bug.cgi?id=241372
rdar://94540740

Reviewed by Tim Horton.

Upstream support for viewport and snapshotting behaviors that are specific to window resizing on
iPad, when Stage Manager is enabled. In particular, this merges the existing MULTITASKING_MODE
and MAC_CATALYST_LIVE_RESIZE feature flags into a single UIKIT_RESIZABLE_WINDOWS flag, which is
used to guard both snapshotting and viewport code.

• Source/WTF/wtf/PlatformHave.h:
• Source/WebKit/Platform/spi/ios/UIKitSPI.h:
• Source/WebKit/Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

• Source/WebKit/Shared/WebPageCreationParameters.h:
• Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView dealloc]):

• Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
• Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:
• Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView setFrame:]):
(-[WKWebView setBounds:]):
(-[WKWebView _registerForNotifications]):
(-[WKWebView _processWillSwapOrDidExit]):
(-[WKWebView didMoveToWindow]):
(-[WKWebView _isWindowResizingEnabled]):
(-[WKWebView _enhancedWindowingToggled:]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _multitaskingModeDidChange:]): Deleted.

• Source/WebKit/UIProcess/API/ios/WKWebViewTestingIOS.mm:

(-[WKWebView _hasResizeAssertion]):

• Source/WebKit/UIProcess/PageClient.h:

(WebKit::PageClient::hasResizableWindows const):
(WebKit::PageClient::isInMultitaskingMode const): Deleted.

• Source/WebKit/UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setIsWindowResizingEnabled):
(WebKit::WebPageProxy::setIsInMultitaskingMode): Deleted.

• Source/WebKit/UIProcess/WebPageProxy.h:
• Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
• Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::hasResizableWindows const):
(WebKit::PageClientImpl::isInMultitaskingMode const): Deleted.

• Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::isDesktopClassBrowsingRecommended const):

• Source/WebKit/WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):
(WebKit::WebPage::setIsWindowResizingEnabled):
(WebKit::WebPage::setIsInMultitaskingMode): Deleted.

• Source/WebKit/WebProcess/WebPage/WebPage.h:
• Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
• Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::shouldEnableViewportBehaviorsForResizableWindows const):
(WebKit::WebPage::usesMultitaskingModeViewportBehaviors const): Deleted.

Canonical link: ​https://commits.webkit.org/251369@main

11:38 AM Changeset in webkit [295359] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/win/TestExpectations

[Gardening]: [ Windows ] fast/css3-text/css3-text-decoration/repaint/underline-outside-of-layout-rect-altered.html is a flaky image failure
​https://bugs.webkit.org/show_bug.cgi?id=241377
<rdar://94550320>

Unreviewed test gardening.

• LayoutTests/platform/win/TestExpectations:

Canonical link: ​https://commits.webkit.org/251368@main

11:21 AM Changeset in webkit [295358] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/mac-wk1/TestExpectations

[Gardening]: [ macOS wk1 ] imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/replaced-element-035.html is a flaky image failure
​https://bugs.webkit.org/show_bug.cgi?id=241376
<rdar://94548274>

Unreviewed test gardening.

• LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: ​https://commits.webkit.org/251367@main

10:48 AM Changeset in webkit [295357] by Ben Nham

• 11 edits in trunk/Source

Some trustd network requests are not attributed to the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=241352

Reviewed by Kate Cheney.

Some of the calls to SecTrustEvaluate (in particular the one in ResourceResponseCocoa) are not made
with a corresponding call to SecTrustSetClientAuditToken. As a result, if trustd ends up making a
network request to fulfill that API request (e.g. for OCSP verification), the corresponding network
request is attributed to NetworkProcess rather than the UIProcess. This causes us to receive spurious
network usage regression bugs from the power team claiming that NetworkProcess (rather than UIProcess)
is making extra network requests if we happen to make a request that triggers OCSP verification.

To fix this, we added a call SecTrustSetClientAuditToken in ResourceResponse::platformCertificateInfo.

• Source/WTF/wtf/PlatformHave.h:
• Source/WTF/wtf/spi/cocoa/SecuritySPI.h:
• Source/WebCore/platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::includeCertificateInfo const):

• Source/WebCore/platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::includeCertificateInfo):
(WebCore::ResourceResponseBase::platformCertificateInfo const):

• Source/WebCore/platform/network/cf/ResourceResponse.h:
• Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::platformCertificateInfo const):

• Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm:

(WebCore::ResourceResponse::platformCertificateInfo const):

• Source/WebCore/platform/network/soup/ResourceResponse.h:
• Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::platformCertificateInfo const):

• Source/WebKit/NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::notifyDidReceiveResponse):

• Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(NetworkSessionCocoa::setClientAuditToken):

Canonical link: ​https://commits.webkit.org/251366@main

10:22 AM Changeset in webkit [295356] by Alan Coon

• 1 copy in tags/WebKit-7614.1.14.10.13

Tag WebKit-7614.1.14.10.13.

10:05 AM Changeset in webkit [295355] by Alan Coon

• 9 edits in branches/safari-7614.1.14.10-branch/Source

Versioning.

WebKit-7614.1.14.10.13

10:01 AM Changeset in webkit [295354] by Russell Epstein

• 1 copy in tags/WebKit-7614.1.15.4

Tag WebKit-7614.1.15.4.

9:56 AM Changeset in webkit [295353] by Russell Epstein

• 9 edits in branches/safari-7614.1.15-branch/Source

Versioning.

WebKit-7614.1.15.4

9:41 AM Changeset in webkit [295352] by Russell Epstein

• 1 copy in tags/WebKit-7614.1.15.3

Tag WebKit-7614.1.15.3.

9:33 AM Changeset in webkit [295351] by mmaxfield@apple.com

• 16 edits
  1 add in trunk

[Cocoa] Move contentSizeCategory to platform/
​https://bugs.webkit.org/show_bug.cgi?id=241360

Reviewed by Cameron McCormack.

There are 2 reasons for moving it:

1. There are already layering violations where existing code in platform/ is calling into RenderTheme

to get the contentSizeCategory.

2. For ​https://bugs.webkit.org/show_bug.cgi?id=237817, I'm going to be adding a new system font cache,

and the most natural place to put it is in SystemFontDatabase in platform/. This new cache needs
access to the contentSizeCategory, so contentSizeCategory needs to be in platform/.

This patch adds FontCacheCocoa.mm because the contentSizeCategory stuff is exposed via Objective-C, and
FontCacheCoreText.cpp is a C++ source.

• Source/WebCore/SourcesCocoa.txt:
• Source/WebCore/WebCore.xcodeproj/project.pbxproj:
• Source/WebCore/platform/graphics/cocoa/FontCacheCocoa.mm: Copied from Source/WebCore/rendering/RenderThemeCocoa.h.

(WebCore::getUIContentSizeCategoryDidChangeNotificationName):
(WebCore::_contentSizeCategory):
(WebCore::contentSizeCategory):
(WebCore::setContentSizeCategory):

• Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::platformInit):
(WebCore::fontWithFamilySpecialCase):

• Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.h:
• Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:

(WebCore::SystemFontDatabaseCoreText::createTextStyleFont):

• Source/WebCore/rendering/RenderThemeCocoa.h:
• Source/WebCore/rendering/RenderThemeIOS.h:
• Source/WebCore/rendering/RenderThemeIOS.mm:

(WebCore::attachmentActionFont):
(WebCore::attachmentTitleFont):
(WebCore::attachmentDynamicTypeScaleFactor):
(WebCore::contentSizeCategoryDidChange): Deleted.
(WebCore::RenderThemeIOS::RenderThemeIOS): Deleted.
(WebCore::_contentSizeCategory): Deleted.
(WebCore::RenderThemeIOS::contentSizeCategory const): Deleted.
(WebCore::RenderThemeIOS::setContentSizeCategory): Deleted.

• Source/WebCore/rendering/RenderThemeMac.h:
• Source/WebCore/rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::contentSizeCategory const): Deleted.

• Source/WebCore/testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setContentSizeCategory):

• Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::contentSizeCategoryDidChange):

• Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

• Tools/TestWebKitAPI/Tests/ios/TextStyleFontSize.mm:

(TEST):

Canonical link: ​https://commits.webkit.org/251365@main

9:29 AM Changeset in webkit [295350] by Russell Epstein

• 9 edits in branches/safari-7614.1.15-branch/Source

Versioning.

WebKit-7614.1.15.3

9:13 AM Changeset in webkit [295349] by commit-queue@webkit.org

• 1 edit in trunk/Tools/flatpak/flatpakutils.py

[WPE][GTK] xdg-dbus-proxy process sometimes go zombie
​https://bugs.webkit.org/show_bug.cgi?id=241317

Patch by Philippe Normand <​philn@igalia.com> on 2022-06-07
Reviewed by Adrian Perez de Castro and Xabier Rodriguez-Calvar.

The atexit hook seems problematic for subprocesses, so try to kill the xdg-dbus-proxy process from
the WebKitFlatpak destructor instead.

• Tools/flatpak/flatpakutils.py:

(WebkitFlatpak.init):
(WebkitFlatpak):
(WebkitFlatpak.del):
(WebkitFlatpak.setup_a11y_proxy):

Canonical link: ​https://commits.webkit.org/251364@main

8:40 AM Changeset in webkit [295348] by Jonathan Bedard

• 1 add in trunk/.github/CODEOWNERS

Add CODEOWNERS file
​https://bugs.webkit.org/show_bug.cgi?id=241354
<rdar://94470932>

Reviewed by Yusuke Suzuki.

Note that we're using the CODEOWNERS file to recommend reviewers. Individual
contributors in WebKit do not "own" components.

• .github/CODEOWNERS: Added.

Canonical link: ​https://commits.webkit.org/251363@main

8:37 AM Changeset in webkit [295347] by Wenson Hsieh

• 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm

Unreviewed, fix several failing API tests on iOS 15 after r295346
​https://bugs.webkit.org/show_bug.cgi?id=241341
rdar://94446831

Rename a couple of strings that I missed in the original upstreaming patch. These tests ran normally
for me on iOS 16 simulator, since these system feature flags were enabled by default; however, iOS
15 relies on these feature flags being enabled for the web view through preferences.

• Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:

(-[TestWKWebView waitForImageAnalysisRequests:]):

Also, drive-by-fix a minor grammar error in a logging string.

(TestWebKitAPI::createWebViewWithTextRecognitionEnhancements):

Canonical link: ​https://commits.webkit.org/251362@main

8:19 AM Changeset in webkit [295346] by Wenson Hsieh

• 65 edits in trunk

Upstream new Live Text and visual intelligence features introduced in iOS 16 and macOS Ventura
​https://bugs.webkit.org/show_bug.cgi?id=241341
rdar://94446831

Reviewed by Eric Carlson.

Upstream several Live Text and visual intelligence-related features introduced in iOS 16 and macOS
Ventura. These features include:

• Visual translation for images on the page, during webpage translation
• Live Text on paused video elements
• Object lifting support (Copy Subject and Remove Background)
• List and rich text detection using Live Text

• Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:
• Source/WTF/wtf/PlatformEnable.h:
• Source/WTF/wtf/PlatformHave.h:
• Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.h:
• Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.mm:
• Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h:
• Source/WebCore/dom/TextEvent.h:
• Source/WebCore/dom/TextEventInputType.h:
• Source/WebCore/editing/EditAction.cpp:

(WebCore::undoRedoLabel):

• Source/WebCore/editing/EditAction.h:
• Source/WebCore/editing/Editor.cpp:

(WebCore::Editor::handleTextEvent):
(WebCore::Editor::pasteAsFragment):
(WebCore::Editor::replaceSelectionWithFragment):

• Source/WebCore/en.lproj/Localizable.strings:
• Source/WebCore/loader/EmptyClients.cpp:
• Source/WebCore/page/ContextMenuClient.h:
• Source/WebCore/page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):

• Source/WebCore/page/EventHandler.cpp:

(WebCore::EventHandler::textRecognitionCandidateElement const):

• Source/WebCore/page/ImageAnalysisQueue.cpp:

(WebCore::ImageAnalysisQueue::enqueueAllImages):
(WebCore::ImageAnalysisQueue::resumeProcessing):
(WebCore::ImageAnalysisQueue::clear):

• Source/WebCore/page/ImageAnalysisQueue.h:
• Source/WebCore/platform/ContextMenuItem.cpp:

(WebCore::isValidContextMenuAction):

• Source/WebCore/platform/ContextMenuItem.h:
• Source/WebCore/platform/LocalizedStrings.h:
• Source/WebCore/platform/TextRecognitionOptions.h:
• Source/WebCore/platform/TextRecognitionResult.h:
• Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm:

(WebCore::contextMenuItemTagCopySubject):
(WebCore::contextMenuItemTitleRemoveBackground):
(WebCore::contextMenuItemTagCopyCroppedImage): Deleted.
(WebCore::contextMenuItemTitleMarkupImage): Deleted.

• Source/WebCore/platform/cocoa/TextRecognitionResultCocoa.mm:

(WebCore::stringForRange):

• Source/WebCore/testing/Internals.h:
• Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.h:
• Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm:

(WebKit::languageCodeForLocale):
(WebKit::supportsLiveText):
(WebKit::makeTextRecognitionResult):
(WebKit::shouldLogFullImageTranslationResults):
(WebKit::requestVisualTranslation):
(WebKit::requestBackgroundRemoval):
(WebKit::setUpAdditionalImageAnalysisBehaviors):
(WebKit::imageDataForRemoveBackground):
(WebKit::canStartImageAnalysis): Deleted.
(WebKit::textRecognitionEnhancementsSystemFeatureEnabled): Deleted.
(WebKit::imageAnalysisQueueSystemFeatureEnabled): Deleted.
(WebKit::isImageAnalysisMarkupSystemFeatureEnabled): Deleted.
(WebKit::imageDataForCroppedImageResult): Deleted.

• Source/WebKit/Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

• Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm:

(WebKit::defaultTextRecognitionInVideosEnabled):
(WebKit::defaultVisualTranslationEnabled):
(WebKit::defaultRemoveBackgroundEnabled):
(WebKit::defaultTextRecognitionEnhancementsEnabled): Deleted.
(WebKit::defaultImageAnalysisQueueEnabled): Deleted.
(WebKit::defaultImageAnalysisMarkupEnabled): Deleted.

• Source/WebKit/Shared/WebPreferencesDefaultValues.h:
• Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm:
• Source/WebKit/UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h:
• Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _startImageAnalysis:target:]):

• Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm:

(+[_WKElementAction _elementActionWithType:customTitle:assistant:]):
(elementActionTypeToUIActionIdentifier):
(uiActionIdentifierToElementActionType):

• Source/WebKit/UIProcess/Cocoa/WebViewImpl.h:
• Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::requestTextRecognition):
(WebKit::WebViewImpl::beginElementFullscreenVideoExtraction):
(WebKit::WebViewImpl::cancelElementFullscreenVideoExtraction):
(WebKit::WebViewImpl::installImageAnalysisOverlayView):
(WebKit::WebViewImpl::uninstallImageAnalysisOverlayView):

• Source/WebKit/UIProcess/PageClient.h:

(WebKit::PageClient::requestTextRecognition):

• Source/WebKit/UIProcess/WebContextMenuProxy.h:

(WebKit::WebContextMenuProxy::copySubjectResult const):
(WebKit::WebContextMenuProxy::croppedImageResult const): Deleted.

• Source/WebKit/UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::contextMenuItemSelected):
(WebKit::WebPageProxy::requestTextRecognition):
(WebKit::WebPageProxy::startVisualTranslation):
(WebKit::WebPageProxy::shouldAllowRemoveBackground):
(WebKit::WebPageProxy::startImageAnalysis): Deleted.
(WebKit::WebPageProxy::shouldAllowImageMarkup): Deleted.

• Source/WebKit/UIProcess/WebPageProxy.h:
• Source/WebKit/UIProcess/ios/PageClientImplIOS.h:
• Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::requestTextRecognition):

• Source/WebKit/UIProcess/ios/WKActionSheetAssistant.h:
• Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant defaultActionsForLinkSheet:]):
(-[WKActionSheetAssistant defaultActionsForImageSheet:]):
(-[WKActionSheetAssistant handleElementActionWithType:element:needsInteraction:]):

• Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

(canAttemptTextRecognitionForNonImageElements):
(-[WKContentView requestRectsToEvadeForSelectionCommandsWithCompletionHandler:]):
(-[WKContentView removeBackgroundMenu]):
(-[WKContentView doAfterComputingImageAnalysisResultsForBackgroundRemoval:]):
(-[WKContentView prepareSelectionForContextMenuWithLocationInView:completionHandler:]):
(-[WKContentView buildMenuForWebViewWithBuilder:]):
(-[WKContentView _setUpImageAnalysis]):
(-[WKContentView _tearDownImageAnalysis]):
(-[WKContentView requestTextRecognition:imageData:sourceLanguageIdentifier:targetLanguageIdentifier:completionHandler:]):
(-[WKContentView imageAnalysisGestureDidBegin:]):
(-[WKContentView _completeImageAnalysisRequestForContextMenu:requestIdentifier:hasTextResults:]):
(-[WKContentView imageAnalysisGestureDidTimeOut:]):
(-[WKContentView actionSheetAssistantShouldIncludeCopySubjectAction:]):
(-[WKContentView actionSheetAssistant:copySubject:sourceMIMEType:]):
(-[WKContentView beginFullscreenVideoExtraction:playerViewController:]):
(-[WKContentView cancelFullscreenVideoExtraction:]):
(-[WKContentView isFullscreenVideoExtractionEnabled]):
(-[WKContentView beginElementFullscreenVideoExtraction:bounds:]):
(-[WKContentView cancelElementFullscreenVideoExtraction]):
(-[WKContentView installImageAnalysisInteraction:]):
(-[WKContentView uninstallImageAnalysisInteraction]):
(-[WKContentView _shouldAvoidSecurityHeuristicScoreUpdates]):
(-[WKContentView imageAnalysisMarkupMenu]): Deleted.
(-[WKContentView doAfterComputingImageAnalysisResultsForMarkup:]): Deleted.
(-[WKContentView requestTextRecognition:imageData:source:target:completionHandler:]): Deleted.
(-[WKContentView actionSheetAssistantShouldIncludeCopyCroppedImageAction:]): Deleted.
(-[WKContentView actionSheetAssistant:copyCroppedImage:sourceMIMEType:]): Deleted.

• Source/WebKit/UIProcess/mac/PageClientImplMac.h:
• Source/WebKit/UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::requestTextRecognition):

• Source/WebKit/UIProcess/mac/WKSharingServicePickerDelegate.h:
• Source/WebKit/UIProcess/mac/WKSharingServicePickerDelegate.mm:

(-[WKSharingServicePickerDelegate removeBackground]):
(-[WKSharingServicePickerDelegate markupImage]): Deleted.

• Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.h:
• Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::appendMarkupItemToControlledImageMenuIfNeeded):
(WebKit::WebContextMenuProxyMac::applyMarkupToControlledImage):
(WebKit::menuItemIdentifier):
(WebKit::WebContextMenuProxyMac::getContextMenuFromItems):

• Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::handleContextMenuCopySubject):
(WebKit::WebPageProxy::handleContextMenuCopyCroppedImage): Deleted.

• Source/WebKit/WebProcess/WebCoreSupport/WebContextMenuClient.h:
• Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::replaceImageWithMarkupResults):

• Source/WebKit/WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::requestTextRecognition):
(WebKit::WebPage::startVisualTranslation):
(WebKit::WebPage::shouldAllowRemoveBackground const):
(WebKit::WebPage::startImageAnalysis): Deleted.
(WebKit::WebPage::shouldAllowImageMarkup const): Deleted.

• Source/WebKit/WebProcess/WebPage/WebPage.h:
• Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
• Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h:
• Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:

(toTag):

• Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenVideoExtraction.mm:

(swizzledPresentViewController):
(swizzledProcessRequest):
(swizzledSetAnalysis):
(+[FullscreenVideoExtractionWebView create]):
(-[FullscreenVideoExtractionWebView initWithFrame:configuration:]):
(-[FullscreenVideoExtractionWebView loadVideoSource:]):
(-[FullscreenVideoExtractionWebView enterFullscreen]):
(-[FullscreenVideoExtractionWebView exitFullscreen]):
(-[FullscreenVideoExtractionWebView didChangeValueForKey:]):
(-[FullscreenVideoExtractionWebView pause]):
(-[FullscreenVideoExtractionWebView play]):
(-[FullscreenVideoExtractionWebView waitForVideoFrame]):
(-[FullscreenVideoExtractionWebView hasActiveImageAnalysis]):
(-[FullscreenVideoExtractionWebView waitForImageAnalysisToBegin]):
(-[FullscreenVideoExtractionWebView waitForImageAnalysisToEnd]):
(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WebKitCocoa/ImageAnalysisTests.mm:

(TestWebKitAPI::createWebViewWithTextRecognitionEnhancements):
(TestWebKitAPI::invokeRemoveBackgroundAction):
(TestWebKitAPI::TEST):
(TestWebKitAPI::invokeImageMarkupAction): Deleted.

• Tools/TestWebKitAPI/cocoa/ImageAnalysisTestingUtilities.h:
• Tools/TestWebKitAPI/cocoa/ImageAnalysisTestingUtilities.mm:

(-[FakeRemoveBackgroundResult initWithImage:cropRect:]):
(-[FakeRemoveBackgroundResult createCGImage]):
(-[FakeRemoveBackgroundResult cropRect]):
(TestWebKitAPI::makeRequestHandler):
(TestWebKitAPI::RemoveBackgroundSwizzler::RemoveBackgroundSwizzler):

Canonical link: ​https://commits.webkit.org/251361@main

8:19 AM Changeset in webkit [295345] by Adrian Perez de Castro

• 1 edit in releases/WebKitGTK/webkit-2.36/Source/WebKit/WebProcess/WebCoreSupport/WebPermissionController.cpp

Merge r295336 - WebPermissionController::tryProcessingRequests should check for m_page
​https://bugs.webkit.org/show_bug.cgi?id=241344
rdar://94276618

Patch by Youenn Fablet <​youennf@gmail.com> on 2022-06-07
Reviewed by Eric Carlson.

• Source/WebKit/WebProcess/WebCoreSupport/WebPermissionController.cpp:

(WebKit::WebPermissionController::tryProcessingRequests):
Add a null check since async reply destructor might trigger completion handler execution.

Canonical link: ​https://commits.webkit.org/251355@main

7:09 AM Changeset in webkit [295344] by Andres Gonzalez

• 4 edits in trunk/LayoutTests

AX ITM: Fix for accessibility/aria-toggle-button-with-title.html in isolated tree mode.
​https://bugs.webkit.org/show_bug.cgi?id=241240

Reviewed by Chris Fleizach and Tyler Wilcock.

This test was flaky in isolated tree mode.

• LayoutTests/accessibility/aria-toggle-button-with-title-expected.txt:
• LayoutTests/accessibility/aria-toggle-button-with-title.html:
• LayoutTests/platform/glib/accessibility/aria-toggle-button-with-title-expected.txt:

Canonical link: ​https://commits.webkit.org/251360@main

6:43 AM Changeset in webkit [295343] by commit-queue@webkit.org

• 14 edits in trunk/Source

ImageBuffer::copyImage consumes GPUP memory and is redundant
​https://bugs.webkit.org/show_bug.cgi?id=241127

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-06-07
ImageBuffer::copyImage overrides:

• Always ends up returning BitmapImage
• Always ends up constructing BitmapImage from copyNativeImage
• Is implemented erroneously in many backends, ignoring the preserve resolution scale flag
• Is implemented correctly in ImageBufferCGBackend, but will allocate the destination buffer when trying to honor the PreserveResolution::No. This will cause a large unattributed allocation in GPUP.

Instead, implement ImageBuffer::copyImage for all the backends and overrides
with ImageBuffer::copyNativeImage().

Implement the scaling conversion, PreserveResolution::No, as a normal WebCore GraphicsContext
operation.

Reviewed by Said Abou-Hallawa.

• Source/WebCore/platform/graphics/ConcreteImageBuffer.h:
• Source/WebCore/platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::copyImage const):
(WebCore::ImageBuffer::sinkIntoImage):

• Source/WebCore/platform/graphics/ImageBuffer.h:
• Source/WebCore/platform/graphics/ImageBufferBackend.cpp:

(WebCore::ImageBufferBackend::sinkIntoImage): Deleted.

• Source/WebCore/platform/graphics/ImageBufferBackend.h:
• Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp:

(WebCore::ImageBufferCairoBackend::copyImage const): Deleted.

• Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.h:
• Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp:

(WebCore::createBitmapImageAfterScalingIfNeeded): Deleted.
(WebCore::ImageBufferCGBackend::copyImage const): Deleted.
(WebCore::ImageBufferCGBackend::sinkIntoImage): Deleted.

• Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.h:
• Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.cpp:

(WebKit::ImageBufferShareableBitmapBackend::copyImage const): Deleted.

• Source/WebKit/WebProcess/GPU/graphics/ImageBufferShareableBitmapBackend.h:
• Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
• Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.cpp:

(WebKit::ImageBufferRemoteIOSurfaceBackend::copyImage const): Deleted.

• Source/WebKit/WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.h:

Canonical link: ​https://commits.webkit.org/251359@main

6:08 AM Changeset in webkit [295342] by commit-queue@webkit.org

• 3 edits in trunk

Do not enable promoted extensions in WebGL 2.0
​https://bugs.webkit.org/show_bug.cgi?id=223348

Patch by Alexey Knyazev <​3479527+lexaknyazev@users.noreply.github.com> on 2022-06-07
Reviewed by Kimmo Kinnunen.

• LayoutTests/TestExpectations:
• Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::initializeNewContext):
(WebCore::WebGL2RenderingContext::initializeShaderExtensions): Deleted.

• Source/WebCore/html/canvas/WebGL2RenderingContext.h:

Canonical link: ​https://commits.webkit.org/251358@main

4:43 AM WebKitGTK/2.36.x edited by Adrian Perez de Castro

(diff)

4:42 AM Changeset in webkit [295341] by Adrian Perez de Castro

• 1 edit in releases/WebKitGTK/webkit-2.36/Tools/WebKitTestRunner/CMakeLists.txt

Merge r295310 - [CMake] Cleanup use of frameworks in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=241349

Reviewed by Fujii Hironori.

Remove includes that are implicit from using a framework.

• Tools/WebKitTestRunner/CMakeLists.txt:

Canonical link: ​https://commits.webkit.org/251348@main

4:42 AM Changeset in webkit [295340] by Adrian Perez de Castro

• 4 edits in releases/WebKitGTK/webkit-2.36

Merge r295034 - WebKitTestRunner shouldn't link object files of JavaScriptCore and WebCore
​https://bugs.webkit.org/show_bug.cgi?id=241002

Reviewed by Don Olmstead.

243269@main removed WebKit from WebKitTestRunner_FRAMEWORKS for
WPE. But, it should be there not to link object files of
JavaScriptCore and WebCore to WebKitTestRunner. In WPE builds,
JavaScriptCore and WebCore API are exported from WebKit shared
library. WebKit consumers shouldn't link with object files of
JavaScriptCore and WebCore.

However, adding WebKit to WebKitTestRunner_FRAMEWORKS introduced a
new problem that the object file of LowLevelInterpreter.cpp was linked
into WebKitTestRunner. This problem was fixed by changing
LowLevelInterpreterLib to a STATIC library.

• Source/JavaScriptCore/CMakeLists.txt:
• Tools/WebKitTestRunner/CMakeLists.txt:
• Tools/WebKitTestRunner/PlatformGTK.cmake:
• Tools/WebKitTestRunner/PlatformWin.cmake:

Canonical link: ​https://commits.webkit.org/251129@main

4:42 AM Changeset in webkit [295339] by Adrian Perez de Castro

• 1 edit in releases/WebKitGTK/webkit-2.36/Source/WebCore/bindings/js/JSDOMMapLike.cpp

Merge r295045 - Build failure when cross-building for 64-bit ARM ​https://bugs.webkit.org/show_bug.cgi?id=241109

Unreviewed build fix.

• Source/WebCore/bindings/js/JSDOMMapLike.cpp: Add missing JavaScriptCore/HashMapImplInlines.h header inclusion.

4:33 AM Changeset in webkit [295338] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore/platform

[GStreamer][WebRTC] Misc pipeline improvements
​https://bugs.webkit.org/show_bug.cgi?id=241332

Patch by Philippe Normand <​philn@igalia.com> on 2022-06-07
Reviewed by Xabier Rodriguez-Calvar.

The player is now able to tune RTP depayloaders in the pipeline, which is useful for incoming RTC
stream handling. The x264 encoder is also now capped at 4 threads, matching other encoders behavior
in our custom video encoder bin.

• Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
(WebCore::MediaPlayerPrivateGStreamer::configureDepayloader):
(WebCore::MediaPlayerPrivateGStreamer::configureVideoDecoder):

• Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
• Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp:

(webkit_webrtc_video_encoder_class_init):

Canonical link: ​https://commits.webkit.org/251357@main

4:00 AM Changeset in webkit [295337] by Jean-Yves Avenard

• 19 edits in trunk/Source/WebKit

SharedBuffer should be copied when moved over IPC
​https://bugs.webkit.org/show_bug.cgi?id=240902
<rdar://93881913>

Reviewed by Jer Noble.

Have SharedBuffer and FragmentedSharedBuffer IPC serializers always perform a copy
Make DrawToPDF use SharedBuffer directly rather than SharedBufferReference.
Replace use of IPCHandle with SharedBuffer in clipboard IPC methods.

The SharedBuffer serializer ultimately does the same thing and it allows for simpler code.

• Source/WebKit/Shared/WebCoreArgumentCoders.cpp:

(IPC::decodeSharedBuffer):

• Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView createPDFWithConfiguration:completionHandler:]):

• Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::getPasteboardBufferForType):
(WebKit::WebPasteboardProxy::setPasteboardBufferForType):
(WebKit::WebPasteboardProxy::readBufferFromPasteboard):

• Source/WebKit/UIProcess/WebPageProxy.cpp:

(WebKit::CompletionHandler<void):
(WebKit::WebPageProxy::drawPagesToPDF):
(WebKit::WebPageProxy::drawToPDF):

• Source/WebKit/UIProcess/WebPageProxy.h:
• Source/WebKit/UIProcess/WebPasteboardProxy.cpp:

(WebKit::WebPasteboardProxy::readBufferFromPasteboard):

• Source/WebKit/UIProcess/WebPasteboardProxy.h:
• Source/WebKit/UIProcess/WebPasteboardProxy.messages.in:
• Source/WebKit/UIProcess/gtk/WebPasteboardProxyGtk.cpp:

(WebKit::WebPasteboardProxy::readBuffer):

• Source/WebKit/UIProcess/ios/WKContentView.mm:

(-[WKContentView _wk_pageCountForPrintFormatter:]):

• Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::drawToPDFiOS):

• Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::dataSelectionForPasteboard):

• Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::writeItemsToPasteboard):

• Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::readBufferFromClipboard):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):

• Source/WebKit/WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawToPDF):
(WebKit::WebPage::drawPagesToPDF):

• Source/WebKit/WebProcess/WebPage/WebPage.h:
• Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
• Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getDataSelectionForPasteboard):
(WebKit::WebPage::drawToPDFiOS):

• Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::getDataSelectionForPasteboard):

Canonical link: ​https://commits.webkit.org/251356@main

2:36 AM Changeset in webkit [295336] by commit-queue@webkit.org

• 1 edit in trunk/Source/WebKit/WebProcess/WebCoreSupport/WebPermissionController.cpp

WebPermissionController::tryProcessingRequests should check for m_page
​https://bugs.webkit.org/show_bug.cgi?id=241344
rdar://94276618

Patch by Youenn Fablet <​youennf@gmail.com> on 2022-06-07
Reviewed by Eric Carlson.

• Source/WebKit/WebProcess/WebCoreSupport/WebPermissionController.cpp:

(WebKit::WebPermissionController::tryProcessingRequests):
Add a null check since async reply destructor might trigger completion handler execution.

Canonical link: ​https://commits.webkit.org/251355@main

2:23 AM Changeset in webkit [295335] by commit-queue@webkit.org

• 2 edits in trunk

Validate top origin in ServiceWorkerRegistrationKey::fromDatabaseKey
​https://bugs.webkit.org/show_bug.cgi?id=241221
rdar://problem/94280334

Patch by Youenn Fablet <​youennf@gmail.com> on 2022-06-07
Reviewed by Chris Dumez.

When reading the top origin from file disk, let's validate it like we do with scope URL.
Covered by API tests.

• Source/WebCore/workers/service/ServiceWorkerRegistrationKey.cpp:

(WebCore::ServiceWorkerRegistrationKey::fromDatabaseKey):

• Tools/TestWebKitAPI/Tests/WebCore/ServiceWorkerRoutines.cpp:

(TEST):

Canonical link: ​https://commits.webkit.org/251354@main

12:16 AM Changeset in webkit [295334] by Diego Pino Garcia

• 1 edit in trunk/Source/WebKit/Shared/IPCTester.messages.in

REGRESSION(250081@main): Parsing error in generate-message-receiver.py
​https://bugs.webkit.org/show_bug.cgi?id=241356

Reviewed by Kimmo Kinnunen.

• Source/WebKit/Shared/IPCTester.messages.in: Remove redundant non-ascii character.

Canonical link: ​https://commits.webkit.org/251353@main

Jun 6, 2022:

11:57 PM Changeset in webkit [295333] by achristensen@apple.com

• 3 edits in trunk/Tools/TestWebKitAPI

Make _WKDataTask.Basic API test more permissive of different number of TCP connections
​https://bugs.webkit.org/show_bug.cgi?id=241358
rdar://94322457

Reviewed by Tim Horton.

Since r294757 we call _setPrivacyProxyFailClosedForUnreachableNonMainHosts on most loads
from WKWebView, but _WKDataTask uses NetworkSessionCocoa::dataTaskWithRequest which does not.
On platforms that support the SPI, we now make a different TCP connection because the stream
properties are different so we can't use the same cached connection. This is fine. The test
verifies that the session cookie is sent. An alternative could be to call
_setPrivacyProxyFailClosedForUnreachableNonMainHosts for all _WKDataTask loads, but that would
strangely and unnecessarily block some loads. The mitigation for rdar://problem/92697007 is not
needed in contexts where _WKDataTask is used because those loads can't run JS that then triggers
other loads, and there's also no main document so the algorithm we use in r294757 can't work.

• Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:

(TEST):

• Tools/TestWebKitAPI/cocoa/HTTPServer.h:
• Tools/TestWebKitAPI/cocoa/HTTPServer.mm:

(TestWebKitAPI::Connection::awaitableSend):

Canonical link: ​https://commits.webkit.org/251352@main

11:52 PM WebKitGTK/2.36.x edited by Adrian Perez de Castro

(diff)

11:03 PM Changeset in webkit [295332] by Alan Coon

• 1 copy in tags/WebKit-7614.1.14.10.12

Tag WebKit-7614.1.14.10.12.

10:47 PM Changeset in webkit [295331] by Alan Coon

• 1 edit in branches/safari-7614.1.14.10-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm

Cherry-pick r294877. rdar://problem/93834054

Uniform buffer reuse causes flush, creates invalid state
​https://bugs.webkit.org/show_bug.cgi?id=240896

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-05-26
Patch by Kyle Piddington.

Reviewed by Kimmo Kinnunen.

A flush during draw setup would leave the render command encoder
not started and render pipeline unset. This would assert in debug
and leak memory with corrupted draws in release.

This would happen for example when uniform buffer pool would run
out of uniform memory. If the pool is maxed out, we flush the
existing rendering to obtain free buffers. After the flush,
we need to re-run the setup.

Test is tracked in bug 240948.

• Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm: (rx::ContextMtl::setupDraw): (rx::ContextMtl::setupDrawImpl):

Canonical link: ​https://commits.webkit.org/251007@main

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@294877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:47 PM Changeset in webkit [295330] by Alan Coon

• 5 edits in branches/safari-7614.1.14.10-branch/Source/WebKit/UIProcess

Cherry-pick r294831. rdar://problem/93656000

Prevent NSAttributedString crashes when AppSSO URLs are provided
​https://bugs.webkit.org/show_bug.cgi?id=240739
<rdar://93656000>

Reviewed by Chris Dumez.

When NSAttributedString is used in a sandboxed app, it is prevented from checking in with the
AppSSO plugin manager, causing a Sandbox Violation and crash. We don't want NSAttributedString
to ever hand-off to AppSSO, so we should configure it's internal WKWebView to do the right thing.
Reviewed by Chris Dumez.

• Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm: (+[_WKAttributedStringWebViewCache configuration]): Turn off AppSSO for string uses.
• Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::trySOAuthorization): Use new lazy loading approach.
• Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::trySOAuthorization): Ditto.
• Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::WebsiteDataStore): (WebKit::WebsiteDataStore::soAuthorizationCoordinator): Lazily initialize, and RELEASE_ASSERT if we somehow reach this code without enabling AppSSO.
• Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h: (WebKit::WebsiteDataStore::soAuthorizationCoordinator): Deleted.

Canonical link: ​https://commits.webkit.org/250981@main

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@294831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:47 PM Changeset in webkit [295329] by Alan Coon

• 8 edits
  2 adds in branches/safari-7614.1.14.10-branch

Cherry-pick r294186. rdar://problem/93805727

Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence
​https://bugs.webkit.org/show_bug.cgi?id=240365

Reviewed by Chris Fleizach.

Source/WebCore:

We can get infinite recursion when accessibilityIsIgnored is called as
part of computing AccessibilityObject::ignoredFromModalPresence. One
example of such a cycle:

AXObjectCache::currentModalNode() ->
AccessibilityRenderObject::computeAccessibilityIsIgnored() ->
AccessibilityRenderObject::parentObjectUnignored() ->
AccessibilityObject::accessibilityIsIgnored() ->
AccessibilityObject::ignoredFromModalPresence() ->
AXObjectCache::currentModalNode() ->
...repeat...

This patch fixes this by tracking when we start computing the current
modal node in the AXObjectCache. Then, in AccessibilityObject::accessibilityIsIgnored(),
we don't call AccessibilityObject::ignoredFromModalPresence() if this new state is true,
since in this context we only need to know if the object is inherently
ignored (i.e. ignored disregarding modal presence).

Test: accessibility/aria-modal-with-text-crash.html

• accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::currentModalNode):
• accessibility/AXObjectCache.h: Add m_isRetrievingCurrentModalNode. (WebCore::AXObjectCache::isRetrievingCurrentModalNode): Added.
• accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessibilityIsIgnored const): Don't call ignoredFromModalPresence if we're in the midst of computing the current modal.

LayoutTests:

• accessibility/aria-modal-with-text-crash-expected.txt: Added.
• accessibility/aria-modal-with-text-crash.html: Added.
• platform/glib/TestExpectations: Skip new test.
• platform/ios/TestExpectations: Enable new test.
• platform/win/TestExpectations: Skip new test.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@294186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:37 PM Changeset in webkit [295328] by Alan Coon

• 9 edits in branches/safari-7614.1.14.10-branch/Source

Versioning.

WebKit-7614.1.14.10.12

8:58 PM Changeset in webkit [295327] by don.olmstead@sony.com

• 1 edit in trunk/Source/cmake/OptionsPlayStation.cmake

Fix PlayStation build after r295294
​https://bugs.webkit.org/show_bug.cgi?id=241359

Reviewed by Ross Kirsling.

The ICU::uc target was added twice to a list of modules causing it to be multiply defined.

• Source/cmake/OptionsPlayStation.cmake:

Canonical link: ​https://commits.webkit.org/251351@main

8:44 PM Changeset in webkit [295326] by mmaxfield@apple.com

• 14 edits in trunk/Source/WebCore

Delete RenderTheme::cachedSystemFontDescription() because it does nothing
​https://bugs.webkit.org/show_bug.cgi?id=241329

Reviewed by Cameron McCormack.

RenderTheme::cachedSystemFontDescription() is supposed to maintain storage for cached font descriptors.
However, every time this storage is referenced, it is immediately copied from, leaving the storage
in its default uninitialized state. There's no point in keeping default initialized objects around
for no reason.

This is the second piece in a sequence of patches to fix the accessibility bold setting in web content.

• Source/WebCore/css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeSystemFont):

• Source/WebCore/rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry const):

• Source/WebCore/rendering/RenderTheme.cpp:

(WebCore::RenderTheme::cachedSystemFontDescription const): Deleted.
(WebCore::RenderTheme::systemFont const): Deleted.

• Source/WebCore/rendering/RenderTheme.h:

(WebCore::RenderTheme::canPaint const):

• Source/WebCore/rendering/RenderThemeAdwaita.h:
• Source/WebCore/rendering/RenderThemeCocoa.h:
• Source/WebCore/rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::systemFont const):
(WebCore::RenderThemeCocoa::cachedSystemFontDescription const): Deleted.
(WebCore::RenderThemeCocoa::updateCachedSystemFontDescription const): Deleted.

• Source/WebCore/rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::systemFont const):
(WebCore::RenderThemeGtk::updateCachedSystemFontDescription const): Deleted.

• Source/WebCore/rendering/RenderThemeGtk.h:
• Source/WebCore/rendering/RenderThemePlayStation.cpp:

(WebCore::RenderThemePlayStation::systemFont const):
(WebCore::RenderThemePlayStation::updateCachedSystemFontDescription const): Deleted.

• Source/WebCore/rendering/RenderThemePlayStation.h:
• Source/WebCore/rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::systemFont const):
(WebCore::fillFontDescription): Deleted.
(WebCore::RenderThemeWin::updateCachedSystemFontDescription const): Deleted.

• Source/WebCore/rendering/RenderThemeWin.h:

Canonical link: ​https://commits.webkit.org/251350@main

8:43 PM Changeset in webkit [295325] by Alan Coon

• 6 edits in trunk/Tools/Scripts/libraries

Add proxy support to webkitscmpy's GitHub client
​https://bugs.webkit.org/show_bug.cgi?id=241031
rdar://93129765

Reviewed by Jonathan Bedard.

Allow for the passing of proxy settings to the GitHub client. Use
requests.Session to pass the proxy settings to all requests made.

Additionally pass this session to the Tracker data member, for
github.com networking requests made at the Tracker level.

Version bumps webkitbugspy and webkitscmpy.

• Tools/Scripts/libraries/webkitbugspy/setup.py: version bump to 0.6.3
• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py: version bump to 0.6.3
• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:

Add a requests.Session member to the class that can be passed into the constructor.
Call all networking requests through the session.
(Tracker.init):
(Tracker):
(Tracker.credentials.validater):

• Tools/Scripts/libraries/webkitscmpy/setup.py: version bump to 4.15.4
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: version bump to 4.15.4
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:

Add a proxies argument to the constructor. Will pass proxies to a request.Session member
that is used to perform networking requests to github.com from this class.
This session is passed to the Tracker member in its constructor (see webkitbugspy.github changes).
(GitHub.PRGenerator.create):
(GitHub.PRGenerator.update):
(GitHub.init):
(GitHub.request):
(GitHub._count_for_ref):
(GitHub._branches_for):

Canonical link: ​https://commits.webkit.org/251349@main

7:30 PM Changeset in webkit [295324] by Alan Coon

• 2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick c88d60bba878. rdar://problem/91643534

<link rel=preconnect> always sends credentials to different-origin, ignoring crossorigin=anonymous
​https://bugs.webkit.org/show_bug.cgi?id=239119
<rdar://problem/91643534>

Reviewed by John Wilander.

Update the check as per spec, step 5 of
​https://html.spec.whatwg.org/multipage/links.html#link-type-preconnect

This is difficult to test as preconnect can only expose TLS credentials.

• loader/LinkLoader.cpp: (WebCore::LinkLoader::preconnectIfNeeded):

Canonical link: ​https://commits.webkit.org/250034@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:30 PM Changeset in webkit [295323] by Alan Coon

• 18 edits
  20 moves
  24 adds in branches/safari-613-branch

Cherry-pick c7f59d768c0a. rdar://problem/94467852

Incorrect CORP/COEP check in 304 responses
​https://bugs.webkit.org/show_bug.cgi?id=238238
<rdar://problem/90706510>

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2022-04-08
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Sync cross-origin-embedder-policy tests to include the new test require-corp-revalidated-images.https.html.

• web-platform-tests/html/cross-origin-embedder-policy/block-local-documents-inheriting-none.https.html:
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/cache-storage.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/cache-storage.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/cache-storage.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/cache.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/cache.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/cache.tentative.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/dedicated-worker.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/dedicated-worker.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/dedicated-worker.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/fetch.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/fetch.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/fetch.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/iframe-coep-credentialless.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/iframe-coep-credentialless.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/iframe-coep-credentialless.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/iframe-coep-none.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/iframe-coep-none.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/iframe-coep-none.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/iframe-coep-require-corp.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/iframe-coep-require-corp.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/iframe-coep-require-corp.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/iframe.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/iframe.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/iframe.tentative.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/image.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/image.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/image.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/link.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/link.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/link.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/redirect.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/redirect.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/redirect.tentative.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/reporting-navigation.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/reporting-navigation.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/reporting-navigation.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/reporting-subresource-corp.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/reporting-subresource-corp.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/reporting-subresource-corp.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/script.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/script.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/script.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/service-worker-coep-credentialless-proxy.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/service-worker-coep-credentialless-proxy.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/service-worker-coep-credentialless-proxy.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/service-worker-coep-none-proxy.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/service-worker-coep-none-proxy.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/service-worker-coep-none-proxy.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/service-worker.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/service-worker.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/service-worker.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/shared-worker.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/shared-worker.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/shared-worker.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/video.https.window.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/video.https.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/video.tentative.https.window.js.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/video.https.window.js.headers: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/credentialless/video.tentative.https.window.js.headers.
• web-platform-tests/html/cross-origin-embedder-policy/credentialless/w3c-import.log:
• web-platform-tests/html/cross-origin-embedder-policy/dedicated-worker.https-expected.txt:
• web-platform-tests/html/cross-origin-embedder-policy/dedicated-worker.https.html:
• web-platform-tests/html/cross-origin-embedder-policy/reporting-to-endpoint.https.html:
• web-platform-tests/html/cross-origin-embedder-policy/reporting-to-endpoint.https.html.headers:
• web-platform-tests/html/cross-origin-embedder-policy/require-corp-cached-images.https-expected.txt:
• web-platform-tests/html/cross-origin-embedder-policy/require-corp-cached-images.https.html:
• web-platform-tests/html/cross-origin-embedder-policy/require-corp-revalidated-images.https-expected.txt: Added.
• web-platform-tests/html/cross-origin-embedder-policy/require-corp-revalidated-images.https.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/resources/corp-image.py: (main):
• web-platform-tests/html/cross-origin-embedder-policy/resources/fetch-and-create-url.html: Added.
• web-platform-tests/html/cross-origin-embedder-policy/resources/load-corp-images.html:
• web-platform-tests/html/cross-origin-embedder-policy/resources/w3c-import.log:
• web-platform-tests/html/cross-origin-embedder-policy/resources/worker-support.js: Added. (setCoep): (resolveUrl): (async withIframe): (waitForMessage): (async createLocalUrl):
• web-platform-tests/html/cross-origin-embedder-policy/shared-workers.https-expected.txt:
• web-platform-tests/html/cross-origin-embedder-policy/shared-workers.https.html:
• web-platform-tests/html/cross-origin-embedder-policy/w3c-import.log:

Source/WebKit:

Add CORP header to the 304 response if previously set to avoid being blocked by load checker due to COEP.

Test: imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/require-corp-revalidated-images.https.html

• NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::didReceiveResponse):

LayoutTests:

Mark some tests with DumpJSConsoleLogInStdErr modifier.

• TestExpectations:

Canonical link: ​https://commits.webkit.org/249428@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:30 PM Changeset in webkit [295322] by Alan Coon

• 3 edits
  2 adds in branches/safari-613-branch

Cherry-pick e40c1e30bd61. rdar://problem/94467808

CSP: Fix script-src-elem policies in workers
​https://bugs.webkit.org/show_bug.cgi?id=239840

Reviewed by Kate Cheney.

Source/WebCore:

Test: http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-and-script-src-elem.html

• page/csp/ContentSecurityPolicyDirectiveList.cpp: (WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForScript const):

LayoutTests:

CSP: Fix script-src-elem policies in workers

• http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-and-script-src-elem-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-and-script-src-elem.html: Added.

Canonical link: ​https://commits.webkit.org/250386@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:30 PM Changeset in webkit [295321] by Alan Coon

• 15 edits
  3 adds in branches/safari-613-branch

Cherry-pick bf09fd4a06a7. rdar://problem/92033309

Add testRunner API to clear memory cache
​https://bugs.webkit.org/show_bug.cgi?id=239804
rdar://92033309

Reviewed by Chris Dumez.

Source/WebCore:

• testing/Internals.cpp: (WebCore::Internals::clearMemoryCache): Beef up clearMemoryCache to be on par with testRunner counterpart.

Source/WebKit:

Add necessary WebKit API to implement the testRunner API.
Make use of new testRunner API in added test.

Test: http/wpt/fetch/clear-memory-cache.html

• NetworkProcess/NetworkProcess.cpp:
• UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
• UIProcess/API/C/WKWebsiteDataStoreRef.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

Tools:

Implement the clear memory cache testRunner API and related plumbery.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:
• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:
• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

LayoutTests:

• http/wpt/fetch/clear-memory-cache-expected.txt: Added.
• http/wpt/fetch/clear-memory-cache.html: Added.
• http/wpt/fetch/resources/clear-memory-cache.py: Added.

Canonical link: ​https://commits.webkit.org/250033@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:30 PM Changeset in webkit [295320] by Alan Coon

• 2 edits in branches/safari-613-branch/Source/WebCore/platform/graphics/avfoundation/objc

Cherry-pick b3360dfccef2. rdar://problem/89387951

[Cocoa][MSE] Frames are displayed "fast forward" during seek operations
​https://bugs.webkit.org/show_bug.cgi?id=241234
<rdar://89387951>

Reviewed by Eric Carlson.

When MSE was moved into the GPU process, certain operations that used to be synchronous became
async. This includes seek operations, where the seek request is initiated by the HTMLMediaElement,
async dispatched to the MediaPlayer in the GPU process, and then async dispatched back to the
WebContent process and MediaSource. Immediately prior to this last dispatch, the
SourceBufferPrivateAVFObjC flushes its sample buffer renderers, and during the subsequent async
portion there is an opportunity for the sample buffers to request new data. When that request
occurs before the response to the async dispatch, incorrect samples (future samples from the
previous playback location) are enqueued. These are then flushed again during the async response,
and replaced by correct samples.

Add a new ivar to SourceBufferPrivateAVFObjC that tracks this state, blocking enqueing new samples
while there is a pending seek operation.

• Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
• Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm: (WebCore::SourceBufferPrivateAVFObjC::willSeek): (WebCore::SourceBufferPrivateAVFObjC::seekToTime): (WebCore::SourceBufferPrivateAVFObjC::isSeeking const):

Canonical link: ​https://commits.webkit.org/251301@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@295253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:30 PM Changeset in webkit [295319] by Alan Coon

• 1 edit
  2 adds in branches/safari-613-branch

Cherry-pick 97487f0eee71. rdar://problem/90755619

[iOS 15] Unable to type in Google Docs with a hardware keyboard without refocusing editor
​https://bugs.webkit.org/show_bug.cgi?id=241308
rdar://90755619

Reviewed by Tim Horton.

After the changes in r277265, we no longer call into -reloadInputViews when starting an input
session after programmatically focusing an editable container with inputmode="none", with a
hardware keyboard attached. This is because -_shouldShowKeyboardForElement: returns NO (due to
inputmode none), so we bail early at this check:

`

if (!shouldShowInputView

information.elementType == WebKit::InputType::None) {

_page->setIsShowingInputViewForFocusedElement(false);
return;

}
`

As a result, UIKit never resets UIKeyboardImpl's input delegate, which should now be the
WKContentView, and thus never consults whether we require key events (-requiresKeyEvents), which
in turn means that -handleKeyWebEvent:withCompletionHandler: is never invoked on the content view,
so we never dispatch key events to the page.

In the normal, non-editable key event case, we lazily call -reloadInputViews in
-_handleKeyUIEvent: (which is called just before keyboard WebEvents start getting dispatched by
UIKit). However, since we're still focusing an editable element in this case, we don't end up going
down this codepath.

When the hardware keyboard is not connected, avoiding the call to -reloadInputViews is expected,
since we aren't showing a keyboard anyways due to the fact that the element was programmatically
focused (so the user has no way of typing or dispatching key events, in the first place).

And finally, when the inputmode is not none, _isFocusingElementWithKeyboard is set to YES, so
we begin the input session and call -reloadInputViews as normal.

It's only in this inputmode=none case with both the hardware keyboard attached and the editable
container being programmatically focused, where we end up in a state where the user can type with a
hardware keyboard, but we haven't informed UIKit that we should receive key events.

We can fix this by consulting a separate -_shouldShowKeyboardForElementIgnoringInputMode: instead
which allows us to follow the normal routine for focusing an editable element with inputmode="none"
which includes zooming to reveal the focused element if it's on-screen and not hidden, as well as
calling the related delegate methods; the only difference is that we avoid showing the UCB or
software keyboard, by returning YES from -_disableAutomaticKeyboardUI in this case.

• LayoutTests/fast/forms/ios/keydown-in-hidden-contenteditable-with-inputmode-none-expected.txt: Added.
• LayoutTests/fast/forms/ios/keydown-in-hidden-contenteditable-with-inputmode-none.html: Added.

Add a new layout test to simulate typing in Google Docs with a hardware keyboard (i.e., focus a
hidden contenteditable container with inputmode="none"), and verify that we dispatch key events to
the focused editable element.

• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _elementTypeRequiresAccessoryView:]): (-[WKContentView _shouldShowKeyboardForElement:]): (-[WKContentView _shouldShowKeyboardForElementIgnoringInputMode:]):

Split this helper method into two versions (one of which ignores inputmode=none). See above for
more details.

(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):

Canonical link: ​https://commits.webkit.org/251335@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@295289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:30 PM Changeset in webkit [295318] by Alan Coon

• 10 edits
  1 add in branches/safari-613-branch

Cherry-pick 8a2d5954643f. rdar://problem/94467773

Calls to print can result in unresponsive print modal
​https://bugs.webkit.org/show_bug.cgi?id=237940
<rdar://problem/88257828>

Reviewed by Chris Dumez.

Source/WebKit:

Calls to print were hanging in the case of the client asynchronously
handling the completion handler passed to the delegate. To fix this
we can adjust all printing IPC to have the option
DispatchMessageEvenWhenWaitingForUnboundedSyncReply which allows IPC
messages when waiting for a sync reply in the case where the receiver
of the message is not guranteed to call the completion handler at the
end of the runloop.

• UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
• UIProcess/API/Cocoa/WKWebViewTesting.mm: (-[WKWebView _computePagesForPrinting:completionHandler:]):
• UIProcess/WebPageProxy.cpp: (WebKit::printingSendOptions):
• WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::print):

Tools:

Add API test. Adjust delegate naming in the PDF case to be more
specific so we can use the generic PrintUIDelegate name in the general
case.

• TestWebKitAPI/SourcesCocoa.txt:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm: (TEST): (-[PrintUIDelegate _webView:printFrame:pdfFirstPageSize:completionHandler:]): Deleted. (-[PrintUIDelegate waitForPageSize]): Deleted. (-[PrintUIDelegate lastPrintedFrame]): Deleted.
• TestWebKitAPI/Tests/WebKitCocoa/WKPrinting.mm: Added. (-[PrintUIDelegate callBlockAsync:]): (-[PrintUIDelegate _webView:printFrame:pdfFirstPageSize:completionHandler:]): (-[PrintUIDelegate waitForPagination]): (TEST):

Canonical link: ​https://commits.webkit.org/248540@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:30 PM Changeset in webkit [295317] by Alan Coon

• 2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick 753398de3962. rdar://problem/92081823

Use more smart pointers in Element.cpp
​https://bugs.webkit.org/show_bug.cgi?id=239836

Patch by Alex Christensen <​achristensen@webkit.org> on 2022-04-28
Reviewed by Chris Dumez.

• dom/Element.cpp: (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop):

Canonical link: ​https://commits.webkit.org/250083@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:30 PM Changeset in webkit [295316] by Alan Coon

• 2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick 694fbb13c1b6. rdar://problem/92081556

afterprint event should be scheduled on event loop
​https://bugs.webkit.org/show_bug.cgi?id=239883

Patch by Alex Christensen <​achristensen@webkit.org> on 2022-04-28
Reviewed by Chris Dumez.

• page/Page.cpp: (WebCore::dispatchPrintEvent): (WebCore::Page::dispatchBeforePrintEvent): (WebCore::Page::dispatchAfterPrintEvent):

Canonical link: ​https://commits.webkit.org/250112@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:30 PM Changeset in webkit [295315] by Alan Coon

• 9 edits
  2 adds in branches/safari-613-branch

Cherry-pick 2c80da108c11. rdar://problem/84667910

[iOS] Keyboard obscures file upload context menu when trying to attach a file in gmail.com
​https://bugs.webkit.org/show_bug.cgi?id=241320
rdar://84667910

Reviewed by Tim Horton.

When composing a message on gmail.com, if a user taps the "Attach file" button in the bottom
toolbar, Gmail's script programmatically clicks a hidden file input and then immediately focuses the
editable body field. The context menu presents at the interaction location near the bottom of the
viewport; however, if no hardware keyboard is attached, the software keyboard appears right
afterwards, obscuring the context menu completely.

To address this, teach WKFileUploadPanel to reposition its context menu when the keyboard is
shown, if it might overlap with the bounds of the input view.

• LayoutTests/fast/forms/ios/show-file-upload-context-menu-above-keyboard-expected.txt: Added.
• LayoutTests/fast/forms/ios/show-file-upload-context-menu-above-keyboard.html: Added.

Add a layout test to verify that focusing a text field with the software keyboard while presenting a
file picker doesn't result in the file picker's context menu being obscured behind the keyboard.

• LayoutTests/resources/ui-helper.js: (window.UIHelper.dismissMenu): (window.UIHelper.contextMenuRect):

Add a couple of new UIHelper methods.

• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _keyboardDidShow]):

If the keyboard appears while the file upload panel is active, reposition the context menu if it
overlaps with the new keyboard bounds.

(-[WKContentView _zoomToFocusRectAfterShowingKeyboardIfNeeded]):

Factor this existing logic out into a helper method.

• Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.h:
• Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm: (-[WKFileUploadPanel contextMenuInteraction:willEndForConfiguration:animator:]):

If the _isRepositioningContextMenu flag is set, avoid removing and destroying the context menu
interaction.

(-[WKFileUploadPanel ensureContextMenuInteraction]):

Drive-by fix: adjust -ensureContextMenuInteraction so that it returns the either the existing or
newly created context menu interaction.

(-[WKFileUploadPanel repositionContextMenuIfNeeded]):

Add a helper method to reposition the context menu by removing and re-presenting the context menu
interaction without animation, only if it overlaps the input view bounds. While removing and
presenting the context menu again, set a _isRepositioningContextMenu flag, such that

(-[WKFileUploadPanel showDocumentPickerMenu]):

• Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• Tools/TestRunnerShared/UIScriptContext/UIScriptController.h: (WTR::UIScriptController::contextMenuRect const):
• Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: (-[TestRunnerWKWebView _dismissAllContextMenuInteractions]):

Adjust this helper to immediately cancel all context menu interactions without animation, so that
context menu removal delegate methods don't bleed into subsequent tests.

• Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h:
• Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptControllerIOS::menuRect const):

Use the new toObject helper method.

(WTR::UIScriptControllerIOS::contextMenuRect const):

Add support for a new script controller method to return the context menu container view's bounds
in window coordinates. Note that I'm using window coordinates here as opposed to root view
coordinates, since the new test that uses this method needs to compare the context menu's position
against the input view bounds in window coordinates.

(WTR::UIScriptControllerIOS::toObject const):

Add a helper method to convert the given CGRect into a JavaScript object reference.

Canonical link: ​https://commits.webkit.org/251344@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@295299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7:30 PM Changeset in webkit [295314] by Alan Coon

• 3 edits
  2 adds in branches/safari-613-branch

Cherry-pick 0fe83157c4d9. rdar://problem/94467906

CSP: Fix mixing strict-dynamic and unsafe-inline policies
​https://bugs.webkit.org/show_bug.cgi?id=239862

Reviewed by Kate Cheney.

Source/WebCore:

Test: http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-and-unsafe-inline-policies.html

• page/csp/ContentSecurityPolicyDirectiveList.cpp: (WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForNonParserInsertedScripts const):

LayoutTests:

If you had multiple policies, one including strict-dynamic and another with unsafe-inline, the unsafe-inline
policy was incorrectly handled.

• http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-and-unsafe-inline-policies-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-and-unsafe-inline-policies.html: Added.

Canonical link: ​https://commits.webkit.org/250109@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:32 PM Changeset in webkit [295313] by Alan Coon

• 1 edit in branches/safari-7614.1.16-branch/Source/WebCore/accessibility/AXObjectCache.h

Cherry-pick r295165.

Unreviewed !ENABLE(ACCESSIBILITY) build fix for r295139.

• Source/WebCore/accessibility/AXObjectCache.h: (WebCore::AXObjectCache::relatedObjectIDsFor): (WebCore::AXObjectCache::relatedObjectsFor): Deleted.

Canonical link: ​https://commits.webkit.org/251249@main

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@295165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:27 PM Changeset in webkit [295312] by Alan Coon

• 1 copy in branches/safari-7614.1.16-branch

New branch.

6:19 PM Changeset in webkit [295311] by Alan Coon

• 1 copy in tags/WebKit-7614.1.15.2

Tag WebKit-7614.1.15.2.

5:58 PM Changeset in webkit [295310] by don.olmstead@sony.com

• 1 edit in trunk/Tools/WebKitTestRunner/CMakeLists.txt

[CMake] Cleanup use of frameworks in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=241349

Reviewed by Fujii Hironori.

Remove includes that are implicit from using a framework.

• Tools/WebKitTestRunner/CMakeLists.txt:

Canonical link: ​https://commits.webkit.org/251348@main

5:35 PM Changeset in webkit [295309] by Alan Coon

• 11 edits in branches/safari-613-branch

Cherry-pick b8c770451902. rdar://problem/84570717

[Modern Media Controls] macCatalyst should not use touch events
​https://bugs.webkit.org/show_bug.cgi?id=240704
<rdar://problem/84570717>

Reviewed by Eric Carlson.

• Source/WebCore/Modules/modern-media-controls/controls/layout-traits.js: (LayoutTraits.prototype.supportsTouches): Added.
• Source/WebCore/Modules/modern-media-controls/controls/macos-layout-traits.js: (MacOSLayoutTraits.prototype.supportsTouches): Added. Allow LayoutTraits to indicate whether touches are supported.

• Source/WebCore/Modules/modern-media-controls/controls/auto-hide-controller.js: (AutoHideController):
• Source/WebCore/Modules/modern-media-controls/controls/button.js: (Button):
• Source/WebCore/Modules/modern-media-controls/controls/range-button.js: (RangeButton):
• Source/WebCore/Modules/modern-media-controls/controls/slider.js: (Slider.prototype._interactionEndTarget):
• Source/WebCore/Modules/modern-media-controls/media/media-document-controller.js: (MediaDocumentController): Use LayoutTraits.prototype.supportsTouches instead of GestureRecognizer.SupportsTouches so that macOS (including macCatalyst) can always act as though touches are not supported (which is fine since mouse events are fully functional on macOS).

• LayoutTests/media/modern-media-controls/button/button-icon-name.html:
• LayoutTests/media/modern-media-controls/button/button.html:
• LayoutTests/media/modern-media-controls/buttons-container/buttons-container-buttons-property.html:
• LayoutTests/media/modern-media-controls/buttons-container/buttons-container-constructor.html:
• LayoutTests/media/modern-media-controls/buttons-container/buttons-container-layout.html: Add layoutDelegate/layoutTraits where needed.

Canonical link: ​https://commits.webkit.org/250814@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@294573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:35 PM Changeset in webkit [295308] by Alan Coon

• 6 edits
  2 adds in branches/safari-613-branch

Cherry-pick 348b1a10ee87. rdar://problem/92449950

[CSS Cascade Layers] Endless recursion with revert-layer in other tree context
​https://bugs.webkit.org/show_bug.cgi?id=239967
<rdar://92449950>

Reviewed by Alan Bujtas.

Source/WebCore:

We should only revert within a tree context (scope).

Adding more comprehensive WPTs separately.

Test: fast/css/revert-layer-tree-context-stack-overflow.html

• style/PropertyCascade.cpp: (WebCore::Style::PropertyCascade::PropertyCascade):

Pass the property tree scope to the rollback cascade.

(WebCore::Style::PropertyCascade::addMatch):

Don't include properties from lower priority tree scopes to rollback cascade.
Reverse the logic for clarity.

• style/PropertyCascade.h: (WebCore::Style::PropertyCascade::PropertyCascade):
• style/StyleBuilder.cpp: (WebCore::Style::Builder::ensureRollbackCascadeForRevert): (WebCore::Style::Builder::ensureRollbackCascadeForRevertLayer): (WebCore::Style::Builder::makeRollbackCascadeKey):

Include tree scope to the key.

• style/StyleBuilder.h:

LayoutTests:

• fast/css/revert-layer-tree-context-stack-overflow-expected.html: Added.
• fast/css/revert-layer-tree-context-stack-overflow.html: Added.

Canonical link: ​https://commits.webkit.org/250213@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@293725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:35 PM Changeset in webkit [295307] by Alan Coon

• 5 edits
  2 adds in branches/safari-613-branch

Cherry-pick 077f4d227924. rdar://problem/94034984

AX: inert attribute doesn't cause display:contents element to be ignored
​https://bugs.webkit.org/show_bug.cgi?id=241022

Reviewed by Chris Fleizach.

Prior to this patch, the inert attribute didn't cause node-only objects
(like those with display:contents) to be ignored. This was because
AccessibilityObject::defaultObjectInclusion only checked effectiveInert
for elements with renderers, even though you only need an element to
have style (not a renderer).

This patch fixes this by adding a new AccessibilityObject::style()
method which uses AccessibilityObject::element() to get
Element::computedStyle() and checking effectiveInert on that, which
works for both renderer and renderer-less objects.

• LayoutTests/accessibility/node-only-inert-object-expected.txt: Added.
• LayoutTests/accessibility/node-only-inert-object.html: Added.
• LayoutTests/platform/ios/TestExpectations: Enable new test.
• LayoutTests/platform/mac-wk1/TestExpectations: Skip new test.
• Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::style const): Added. (WebCore::AccessibilityObject::defaultObjectInclusion const):
• Source/WebCore/accessibility/AccessibilityObject.h:

Canonical link: ​https://commits.webkit.org/251185@main
git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@295090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:35 PM Changeset in webkit [295306] by Alan Coon

• 9 edits in branches/safari-613-branch/Source

Versioning.

WebKit-7613.3.4

5:15 PM Changeset in webkit [295305] by commit-queue@webkit.org

• 1 edit in trunk/Source/WebCore/platform/ios/UserAgentIOS.mm

Make Mobile Safari desktop mode report the same macOS version in the user agent as Safari on Mac
​https://bugs.webkit.org/show_bug.cgi?id=241322

Patch by nitinseshadri <​61258126+nitinseshadri@users.noreply.github.com> on 2022-06-06
Reviewed by Alexey Proskuryakov.

• Source/WebCore/platform/ios/UserAgentIOS.mm:

(WebCore::standardUserAgentWithApplicationName):
Change reported macOS version in user agent to 10.15.7.

Canonical link: ​https://commits.webkit.org/251347@main

4:47 PM Changeset in webkit [295304] by Brent Fulgham

• 1 edit in trunk/Source/WebKit/Configurations/BaseXPCService.xcconfig

Framework Mismatch Crash when loading any page if CaptivePortal mode enabled
rdar://89925654

Reviewed by Tim Horton.

Code signing flags were improperly set for the CaptivePortal process. This patch instructs the build
system to treat CaptivePortal code signing the same as Normal WebContent process builds.

• Source/WebKit/Configurations/BaseXPCService.xcconfig:

Canonical link: ​https://commits.webkit.org/251346@main

4:23 PM Changeset in webkit [295303] by Russell Epstein

• 12 edits in branches/safari-7614.1.15-branch/Source

Cherry-pick r295134. rdar://problem/93068926

Fix build failures introduced in "[Xcode] Prevent STP and other self-contained builds from overwriting content in the macOS SDK"
​https://bugs.webkit.org/show_bug.cgi?id=240408

Reviewed by Alexey Proskuryakov.

Revert "Revert "[Xcode] Prevent STP and other self-contained builds from overwriting content in the macOS SDK""
This reverts commit 680fe6580f261df69a607a33b6252f3e19704169.

Apply small fixups across xcconfig files to address regressions:

• Fix SYSTEM_HEADER_SEARCH_PATHS not referring to Catlyst's include directory.
• Replace /usr/local/include literal in PROFILE_DATA_PATH with WK_ALTERNATE_WEBKIT_SDK_PATH and WK_LIBRARY_HEADERS_FOLDER_PATH to select the correct profdata for Catalyst or self-contained builds.

• Source/JavaScriptCore/Configurations/Base.xcconfig: Clean up an old WK_STATICLIB_INSTALL_PREFIX, replacing it with WK_LIBRARY_HEADERS_FOLDER_PATH.
• Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
• Source/WebCore/Configurations/WebCore.xcconfig:
• Source/WebCore/PAL/Configurations/PAL.xcconfig:
• Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: PAL's SDKVariant.xcconfig was not included in the project for some reason. This is fine for building (as it's still includable) but prevents Xcode from indexing it. Add it.
• Source/WebGPU/Configurations/WGSL.xcconfig:
• Source/WebGPU/Configurations/WebGPU.xcconfig:
• Source/WebKit/Configurations/BaseTarget.xcconfig:
• Source/WebKit/Configurations/SandboxProfiles.xcconfig: Clean up an old WK_STATICLIB_INSTALL_PREFIX setting. We don't need to redirect sandbox profiles to a separate directory, like we do headers and static libraries, so leave these paths hard coded to /usr/local/include.
• Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:

Canonical link: ​https://commits.webkit.org/251225@main

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@295134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:23 PM Changeset in webkit [295302] by Russell Epstein

• 45 edits in branches/safari-7614.1.15-branch/Source

Cherry-pick r295073. rdar://problem/93068926

[Xcode] Prevent STP and other self-contained builds from overwriting content in the macOS SDK
​https://bugs.webkit.org/show_bug.cgi?id=240408

Reviewed by Alexey Proskuryakov.

When building with WK_OVERRIDE_FRAMEWORKS_DIR, we assume that WebKit is
being built as part of a self-contained application, e.g. Safari
Technology Preview. This means that most content is installed to the
override directory, instead of the normal /System/Library/Frameworks
directory.

However, static library content (e.g. headers and archives
for bmalloc, webrtc, WTF) is _not_ installed to the override directory,
as it is not needed at runtime. It was being installed to the default
/usr/local prefix, where it would merge with and overwrite whatever
WebKit content was already present.

To prevent overwrites and other sorts of conflict with the
system-provided WebKit, introduce WK_LIBRARY_HEADERS_FOLDER_PATH and
WK_LIBRARY_INSTALL_PATH, which expand to /usr/local/include/safari-sdk
and /usr/local/lib/safari-sdk respectively when building in this mode.
Static library headers and archives are built to these locations, where
they're still in the expected SDK location, but won't clobber system
WebKit.

• Source/bmalloc/Configurations/Base.xcconfig:
• Source/bmalloc/Configurations/bmalloc.xcconfig:
• Source/bmalloc/Configurations/mbmalloc.xcconfig:
• Source/JavaScriptCore/Configurations/Base.xcconfig:
• Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:
• Source/JavaScriptCore/DerivedSources.make:
• Source/JavaScriptCore/Scripts/generate-unified-sources.sh:
• Source/JavaScriptCore/offlineasm/config.rb:
• Source/JavaScriptCore/offlineasm/parser.rb:
• Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:
• Source/ThirdParty/ANGLE/Configurations/AngleMetalLib.xcconfig:
• Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/boringssl.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/libabsl.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/libsrtp.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/libwebm.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/libyuv.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/opus.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/usrsctp.xcconfig:
• Source/ThirdParty/libwebrtc/Configurations/yasm.xcconfig:
• Source/WebCore/PAL/Configurations/Base.xcconfig:
• Source/WebCore/PAL/Configurations/PAL.xcconfig:
• Source/WebGPU/Configurations/Base.xcconfig:
• Source/WebGPU/Configurations/WGSL.xcconfig:
• Source/WebGPU/Configurations/WGSLUnitTests.xcconfig:
• Source/WebGPU/Configurations/WebGPU.xcconfig:
• Source/WebKit/Configurations/Base.xcconfig:
• Source/WebKit/Configurations/BaseTarget.xcconfig:
• Source/WebKit/Configurations/SandboxProfiles.xcconfig:
• Source/WebKit/WebKit.xcodeproj/project.pbxproj:
• Source/WebKitLegacy/scripts/generate-unified-sources.sh:
• Source/WebKitLegacy/mac/Configurations/Base.xcconfig:
• Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:
• Source/WTF/Configurations/Base.xcconfig:
• Source/WTF/Configurations/WTF.xcconfig:
• Source/WTF/Configurations/icu.xcconfig:
• Source/WebCore/Configurations/Base.xcconfig:
• Source/WebCore/Configurations/WebCore.xcconfig:
• Source/WebCore/Configurations/WebCoreTestSupport.xcconfig:
• Source/WebCore/DerivedSources.make:
• Source/WebCore/Scripts/generate-unified-sources.sh:
• Source/WebCore/WebCore.xcodeproj/project.pbxproj:

Canonical link: ​https://commits.webkit.org/251168@main

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@295073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:23 PM Changeset in webkit [295301] by Russell Epstein

• 6 edits
  1 add in branches/safari-7614.1.15-branch/Source

Cherry-pick r295065. rdar://problem/93068926

Refer to correct profiling data in WebCore and WebKit
​https://bugs.webkit.org/show_bug.cgi?id=239681

Reviewed by Alexey Proskuryakov.

Revert "Unreviewed, revert "[Xcode] Compute PGO profdata paths instead of searching for them at build time""
This reverts commit 2ee0d9d171e2ff7daa94d1a15727033a994e6414.

A bad copy-paste led to WebCore and WebKit's production builds using PGO
data from JavaScriptCore. Fix it, and add back a check that ensures
production builds fail instead of falling back to stub profiling data.

• Source/WebCore/Configurations/WebCore.xcconfig:
• Source/WebKit/Configurations/BaseTarget.xcconfig:

Canonical link: ​https://commits.webkit.org/251160@main

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@295065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:12 PM Changeset in webkit [295300] by Ryan Haddad

• 1 edit in trunk/LayoutTests/platform/ios/TestExpectations

[iOS] Skip tests that cause crashes due to unfired UI script callbacks
​https://bugs.webkit.org/show_bug.cgi?id=241350

Unreviewed test gardening.

These tests were identified in webkit.org/b/236794. Skip them to reduce flakes and
false positives on iOS test bots. Remove flaky expectations for tests that were caught
in the fallout from these bad tests.

• LayoutTests/platform/ios/TestExpectations:

Canonical link: ​https://commits.webkit.org/251345@main

3:08 PM Changeset in webkit [295299] by Wenson Hsieh

• 9 edits
  2 adds in trunk

[iOS] Keyboard obscures file upload context menu when trying to attach a file in gmail.com
​https://bugs.webkit.org/show_bug.cgi?id=241320
rdar://84667910

Reviewed by Tim Horton.

When composing a message on gmail.com, if a user taps the "Attach file" button in the bottom
toolbar, Gmail's script programmatically clicks a hidden file input and then immediately focuses the
editable body field. The context menu presents at the interaction location near the bottom of the
viewport; however, if no hardware keyboard is attached, the software keyboard appears right
afterwards, obscuring the context menu completely.

To address this, teach WKFileUploadPanel to reposition its context menu when the keyboard is
shown, if it might overlap with the bounds of the input view.

• LayoutTests/fast/forms/ios/show-file-upload-context-menu-above-keyboard-expected.txt: Added.
• LayoutTests/fast/forms/ios/show-file-upload-context-menu-above-keyboard.html: Added.

Add a layout test to verify that focusing a text field with the software keyboard while presenting a
file picker doesn't result in the file picker's context menu being obscured behind the keyboard.

• LayoutTests/resources/ui-helper.js:

(window.UIHelper.dismissMenu):
(window.UIHelper.contextMenuRect):

Add a couple of new UIHelper methods.

• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _keyboardDidShow]):

If the keyboard appears while the file upload panel is active, reposition the context menu if it
overlaps with the new keyboard bounds.

(-[WKContentView _zoomToFocusRectAfterShowingKeyboardIfNeeded]):

Factor this existing logic out into a helper method.

• Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.h:
• Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel contextMenuInteraction:willEndForConfiguration:animator:]):

If the _isRepositioningContextMenu flag is set, avoid removing and destroying the context menu
interaction.

(-[WKFileUploadPanel ensureContextMenuInteraction]):

Drive-by fix: adjust -ensureContextMenuInteraction so that it returns the either the existing or
newly created context menu interaction.

(-[WKFileUploadPanel repositionContextMenuIfNeeded]):

Add a helper method to reposition the context menu by removing and re-presenting the context menu
interaction without animation, only if it overlaps the input view bounds. While removing and
presenting the context menu again, set a _isRepositioningContextMenu flag, such that

(-[WKFileUploadPanel showDocumentPickerMenu]):

• Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• Tools/TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::contextMenuRect const):

• Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView _dismissAllContextMenuInteractions]):

Adjust this helper to immediately cancel all context menu interactions without animation, so that
context menu removal delegate methods don't bleed into subsequent tests.

• Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h:
• Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::menuRect const):

Use the new toObject helper method.

(WTR::UIScriptControllerIOS::contextMenuRect const):

Add support for a new script controller method to return the context menu container view's bounds
in window coordinates. Note that I'm using window coordinates here as opposed to root view
coordinates, since the new test that uses this method needs to compare the context menu's position
against the input view bounds in window coordinates.

(WTR::UIScriptControllerIOS::toObject const):

Add a helper method to convert the given CGRect into a JavaScript object reference.

Canonical link: ​https://commits.webkit.org/251344@main

3:04 PM Changeset in webkit [295298] by Ryan Haddad

• 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm

REGRESSION: [ iOS ] Six TestWebKitAPI.AppPrivacyReport API tests are a consistent timeout
​https://bugs.webkit.org/show_bug.cgi?id=241233
<rdar://94298162>

Reviewed by Kate Cheney.

Two tests requiring a fix were missed in 251292@main.

• Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:

Canonical link: ​https://commits.webkit.org/251343@main

2:46 PM Changeset in webkit [295297] by timothy_horton@apple.com

• 2 edits
  2 copies in trunk/LayoutTests/compositing

REGRESSION (r295269): compositing/hidpi-compositing-layer-with-zero-sized-container.html times out
​https://bugs.webkit.org/show_bug.cgi?id=241346

Reviewed by Alan Bujtas.

• LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html:
• LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container.html:
• LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one-expected.html:
• LayoutTests/compositing/hidpi-compositing-layer-with-zero-sized-container-offsets-above-one.html:

This test was slow before, but r295269 made it even slower due to WKTR's force repaint
now causing the compositing layers to repaint as well (a progression).

Reduce the number of layers per test from 1600 to 400, and split the test
in half; one test for offsets below 1, one for offsets between 1 and 2;
Alan says that rounding behavior is different between these two cases.

Canonical link: ​https://commits.webkit.org/251342@main

2:35 PM Changeset in webkit [295296] by don.olmstead@sony.com

• 2 edits in trunk/Tools/Scripts/hooks

Invoke perl in git hooks
​https://bugs.webkit.org/show_bug.cgi?id=241345

Reviewed by Jonathan Bedard.

A windows command prompt doesn't understand shebangs and needs the interpreter to be specified in
order to run successfully.

• Tools/Scripts/hooks/pre-commit:
• Tools/Scripts/hooks/prepare-commit-msg:

Canonical link: ​https://commits.webkit.org/251341@main

1:41 PM Changeset in webkit [295295] by Alan Coon

• 9 edits in branches/safari-7614.1.15-branch/Source

Versioning.

WebKit-7614.1.15.2

1:24 PM Changeset in webkit [295294] by don.olmstead@sony.com

• 10 edits in trunk

[CMake] Use playstation_module for shared libs
​https://bugs.webkit.org/show_bug.cgi?id=241049

Reviewed by Ross Kirsling.

The playstation_module function determines how to properly load a shared library. It figures out
if a shared library is being used and if so will create a target to copy it to the directory it
will load from. Additionally it exposes a ${target}_LOAD_AT variable that can be used with
dlopen.

• Source/JavaScriptCore/shell/playstation/Initializer.cpp:
• Source/WTF/wtf/PlatformPlayStation.cmake:
• Source/WebCore/PlatformPlayStation.cmake:
• Source/WebKit/NetworkProcess/EntryPoint/playstation/NetworkProcessMain.cpp:
• Source/WebKit/WebProcess/EntryPoint/playstation/WebProcessMain.cpp:
• Source/cmake/OptionsPlayStation.cmake:
• Tools/MiniBrowser/playstation/CMakeLists.txt:
• Tools/MiniBrowser/playstation/main.cpp:
• Tools/TestWebKitAPI/PlatformPlayStation.cmake:
• Tools/TestWebKitAPI/playstation/main.cpp:

Canonical link: ​https://commits.webkit.org/251340@main

1:13 PM Changeset in webkit [295293] by don.olmstead@sony.com

• 2 edits in trunk/Tools/Scripts/hooks

Use raw string for LOCATION in git hooks
​https://bugs.webkit.org/show_bug.cgi?id=241343

Reviewed by Jonathan Bedard.

• Tools/Scripts/hooks/pre-commit:
• Tools/Scripts/hooks/prepare-commit-msg:

Canonical link: ​https://commits.webkit.org/251339@main

12:22 PM Changeset in webkit [295292] by Russell Epstein

• 9 edits in trunk/Source

Versioning.

WebKit-7614.1.17

10:50 AM Changeset in webkit [295291] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebCore

InteractionRegionOverlay should use RenderLayer-cached regions instead of computing them itself
​https://bugs.webkit.org/show_bug.cgi?id=241338

Reviewed by Simon Fraser.

• Source/WebCore/page/DebugPageOverlays.cpp:

(WebCore::RegionOverlay::shouldPaintOverlayIntoLayer):
(WebCore::InteractionRegionOverlay::updateRegion):
Stop computing InteractionRegions ourselves.

(WebCore::InteractionRegionOverlay::activeLayer):
Determine the layer from which to retrieve InteractionRegions. For now, we just
use the root layer, because that's where we stash all regions. Later, we'll
do a hit-test here to find the region under the mouse.

(WebCore::InteractionRegionOverlay::activeRegion):
Look up InteractionRegions cached on the aforementioned active layer, instead of
computing them ourselves.

(WebCore::InteractionRegionOverlay::drawRect):
Stop painting region-indicating borders into the overlay (see RenderLayerBacking changes).

(WebCore::InteractionRegionOverlay::mouseEvent):
Correctly map into layer coordinates. For now this is a no-op because we're using
the root layer, but it will be important in a future patch where we use regions
on a per-layer basis.

(WebCore::DebugPageOverlays::shouldPaintOverlayIntoLayer):

• Source/WebCore/page/DebugPageOverlays.h:

(WebCore::DebugPageOverlays::shouldPaintOverlayIntoLayerForRegionType):

• Source/WebCore/rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintDebugOverlays):
(WebCore::RenderLayerBacking::paintContents):
Paint region-indicating borders into the layer, instead of into the page overlay.
This will make them correctly scroll along with the content, and layer correctly.

Canonical link: ​https://commits.webkit.org/251337@main

10:36 AM Changeset in webkit [295290] by Wenson Hsieh

• 15 edits
  1 copy in trunk

REGRESSION (r291302): editing/secure-input tests fail when run while a password input is focused on the system
​https://bugs.webkit.org/show_bug.cgi?id=241324
rdar://94184618

Reviewed by Alexey Proskuryakov.

The tests in editing/secure-input fail after the removal of WebCoreTestShim in r291302, if a
secure text field is focused anywhere on the system while the tests are running. This is because we
now call into the real system IsSecureEventInputEnabled() API during these tests, instead of the
shimmed version for testing.

Since interposing these API functions apparently doesn't work on M1 Macs, we can't use this
technique to ensure that these tests are robust moving forward; instead, introduce and use testing-
only SPI (and IPI) to consult whether or not we're currently editing a secure input.

See below for more details.

• Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h:
• Source/WebKit/UIProcess/API/mac/WKWebViewTestingMac.mm:

(-[WKWebView _secureEventInputEnabledForTesting]):

Add testing-only SPI on WKWebView to return whether or not we're in a secure input, as an
alternative to calling into the actual IsSecureEventInputEnabled() API.

• Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:
• Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:

(-[WebHTMLView _secureEventInputEnabledForTesting]):

• Source/WebKitLegacy/mac/WebView/WebHTMLViewForTestingMac.h: Copied from Source/WebKit/UIProcess/API/mac/WKWebViewPrivateForTestingMac.h.

Add a testing-only header file that's internal (i.e. non-exported), but imported in DumpRenderTree
through a Source-relative header include path. At the moment, this only contains a method to check
whether or not we're currently editing a secure text input, as an alternative to calling into
IsSecureEventInputEnabled().

• Tools/DumpRenderTree/TestRunner.cpp:

(getSecureEventInputIsEnabledCallback):
(TestRunner::isSecureEventInputEnabled const):

Adjust DumpRenderTree to consult -[WebHTMLView _secureEventInputEnabledForTesting].

• Tools/DumpRenderTree/TestRunner.h:
• Tools/DumpRenderTree/mac/Configurations/Base.xcconfig:

Add a relative include path on DumpRenderTree, so that we can use WebHTMLViewForTestingMac.h in
DumpRenderTree without having to introduce new WebKitLegacy SPI.

• Tools/DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::isSecureEventInputEnabled const):

• Tools/WebKitTestRunner/PlatformWebView.h:

(WTR::PlatformWebView::platformView const):
(WTR::PlatformWebView::platformWindow const):
(WTR::PlatformWebView::platformView): Deleted.
(WTR::PlatformWebView::platformWindow): Deleted.

Mark platformView const so that it can be invoked from isSecureEventInputEnabled, and also mark
platformWindow const for consistency.

• Tools/WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

• Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::isSecureEventInputEnabled const):

• Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::isSecureEventInputEnabled const):

• Tools/WebKitTestRunner/libwpe/PlatformWebViewLibWPE.cpp:

(WTR::PlatformWebView::isSecureEventInputEnabled const):

• Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::isSecureEventInputEnabled const):

Add a new isSecureEventInputEnabled method on the PlatformWebView, and adjust WebKitTestRunner
to consult -[WKWebView _secureEventInputEnabledForTesting].

• Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp:

(WTR::PlatformWebView::isSecureEventInputEnabled const):

Canonical link: ​https://commits.webkit.org/251336@main

8:57 AM Changeset in webkit [295289] by Wenson Hsieh

• 1 edit
  2 adds in trunk

[iOS 15] Unable to type in Google Docs with a hardware keyboard without refocusing editor
​https://bugs.webkit.org/show_bug.cgi?id=241308
rdar://90755619

Reviewed by Tim Horton.

After the changes in r277265, we no longer call into -reloadInputViews when starting an input
session after programmatically focusing an editable container with inputmode="none", with a
hardware keyboard attached. This is because -_shouldShowKeyboardForElement: returns NO (due to
inputmode none), so we bail early at this check:

`

if (!shouldShowInputView

information.elementType == WebKit::InputType::None) {

_page->setIsShowingInputViewForFocusedElement(false);
return;

}
`

As a result, UIKit never resets UIKeyboardImpl's input delegate, which should now be the
WKContentView, and thus never consults whether we require key events (-requiresKeyEvents), which
in turn means that -handleKeyWebEvent:withCompletionHandler: is never invoked on the content view,
so we never dispatch key events to the page.

In the normal, non-editable key event case, we lazily call -reloadInputViews in
-_handleKeyUIEvent: (which is called just before keyboard WebEvents start getting dispatched by
UIKit). However, since we're still focusing an editable element in this case, we don't end up going
down this codepath.

When the hardware keyboard is not connected, avoiding the call to -reloadInputViews is expected,
since we aren't showing a keyboard anyways due to the fact that the element was programmatically
focused (so the user has no way of typing or dispatching key events, in the first place).

And finally, when the inputmode is not none, _isFocusingElementWithKeyboard is set to YES, so
we begin the input session and call -reloadInputViews as normal.

It's only in this inputmode=none case with both the hardware keyboard attached and the editable
container being programmatically focused, where we end up in a state where the user can type with a
hardware keyboard, but we haven't informed UIKit that we should receive key events.

We can fix this by consulting a separate -_shouldShowKeyboardForElementIgnoringInputMode: instead
which allows us to follow the normal routine for focusing an editable element with inputmode="none"
which includes zooming to reveal the focused element if it's on-screen and not hidden, as well as
calling the related delegate methods; the only difference is that we avoid showing the UCB or
software keyboard, by returning YES from -_disableAutomaticKeyboardUI in this case.

• LayoutTests/fast/forms/ios/keydown-in-hidden-contenteditable-with-inputmode-none-expected.txt: Added.
• LayoutTests/fast/forms/ios/keydown-in-hidden-contenteditable-with-inputmode-none.html: Added.

Add a new layout test to simulate typing in Google Docs with a hardware keyboard (i.e., focus a
hidden contenteditable container with inputmode="none"), and verify that we dispatch key events to
the focused editable element.

• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _elementTypeRequiresAccessoryView:]):
(-[WKContentView _shouldShowKeyboardForElement:]):
(-[WKContentView _shouldShowKeyboardForElementIgnoringInputMode:]):

Split this helper method into two versions (one of which ignores inputmode=none). See above for
more details.

(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):

Canonical link: ​https://commits.webkit.org/251335@main

8:53 AM Changeset in webkit [295288] by Jonathan Bedard

• 6 edits in trunk/Tools/Scripts

git webkit setup hard codes the path to Xcode in .git/hooks/pre-commit
​https://bugs.webkit.org/show_bug.cgi?id=241284
<rdar://problem/94435371>

Reviewed by Tim Horton.

• Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/hooks/prepare-commit-msg:
• Tools/Scripts/hooks/pre-commit: Use git instead of git path.
• Tools/Scripts/hooks/prepare-commit-msg: Ditto.
• Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:

(Setup.git): Remove git executable path.

Canonical link: ​https://commits.webkit.org/251334@main

8:22 AM Changeset in webkit [295287] by pvollan@apple.com

• 3 edits in trunk/Source

Eagerly soft link Data Detection frameworks
​https://bugs.webkit.org/show_bug.cgi?id=241267

Reviewed by Geoffrey Garen.

Eagerly soft link Data Detection frameworks in the WebContent process. There are two motivations behind this change.
First, soft linking frameworks may lead to communication with launchd. Doing the soft linking before the WebContent
process has finished launching, will help our effort in blocking launchd post launch. Second, the data detection
frameworks are normally used in every WebContent process, and eagerly soft linking them should be a performance
improvement. Ideally, these frameworks should be hard linked or weak linked. However, that would most likely create
cycles in the build dependencies.

• Source/WebCore/PAL/pal/cocoa/DataDetectorsCoreSoftLink.h:
• Source/WebCore/PAL/pal/cocoa/DataDetectorsCoreSoftLink.mm:
• Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::softlinkDataDetectorsFrameworks):
(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: ​https://commits.webkit.org/251333@main

7:34 AM Changeset in webkit [295286] by eocanha@igalia.com

• 6 edits in trunk

Revert of revert of [MSE][GStreamer] Honor MP4 edit lists, bis
​https://bugs.webkit.org/show_bug.cgi?id=231019

Reviewed by Xabier Rodriguez-Calvar.

This patch reintroduces ​https://commits.webkit.org/243426@main with
some corrections that avoid the problems detected in
​https://bugs.webkit.org/show_bug.cgi?id=233861, which motivated the
original patch revert.

Original author: Alicia Boya Garcia <​aboya@igalia.com>

Source/WebCore:

This patch takes into consideration the GstSegment attached to a
sample to offset the PTS and DTS. This ensures accurate timestamps are
obtained for MP4 files containing edit lists (commonly necessary for
files containing video with B frames to have PTS starting at zero).

Before this was implemented, a workaround was in place based on a
heuristic (DTS = 0 && PTS > 0 && PTS < 0.1). The workaround is
preserved for the sake of content without proper edit lists, but
any edit list takes preference.

The time fudge factor has been modified from 0.083 seconds up to
0.100 seconds to accomodate the size of the empty edit in test.mp4
used by Web Platform Tests.

This test fixes improves expectation results and fixes two subtests in
imported/w3c/web-platform-tests/media-source/mediasource-remove.html.

This is a reworked version that avoids using gst_sample_set_buffer()
which is not available on GStreamer 1.14, and fixes an issue where
frames that would get a negative DTS were not being enqueued properly.

LayoutTests:

Update expectations for mediasource-remove.html in the GStreamer
ports, as a couple subtests get fixed.

• LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-source/mediasource-remove-expected.txt:
• Source/WebCore/Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::currentTimeFudgeFactor):

• Source/WebCore/platform/graphics/SourceBufferPrivate.h:

(WebCore::SourceBufferPrivate::timeFudgeFactor const):

• Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:

(WebCore::toGstClockTime):

• Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp:

(WebCore::MediaSampleGStreamer::MediaSampleGStreamer):

• Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::bufferTimeToStreamTime):
(WebCore::AppendPipeline::appsinkNewSample):
(WebCore::matroskademuxForceSegmentStartToEqualZero): Now we reset segment.time in addition to segment.start. This avoids the regressions.

Canonical link: ​https://commits.webkit.org/251332@main

7:18 AM Changeset in webkit [295285] by commit-queue@webkit.org

• 68 edits
  16 deletes in trunk

Unreviewed, reverting r295278.
​https://bugs.webkit.org/show_bug.cgi?id=241336

Causes crashes

Reverted changeset:

"Add a new DrawDecomposedGlyphs display list item to avoid repeatedly sending glyphs when using the GlyphDisplayListCache"
​https://bugs.webkit.org/show_bug.cgi?id=240497
​https://commits.webkit.org/r295278

Canonical link: ​https://commits.webkit.org/251331@main

6:42 AM Changeset in webkit [295284] by commit-queue@webkit.org

• 8 edits in trunk

RemoteGraphicsContextGL autogeneration broken after 249754@main, 251204@main, 251325@main
​https://bugs.webkit.org/show_bug.cgi?id=241328

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-06-06
Unreviewed, build fix.

Verifieable by running Tools/Scripts/generate-gpup-webgl and
observing no change.

Make generate-gpup-webgl add NOLINT for getIntegeri_v() to skip
warning about underscores in methods.

• Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:

(WebKit::RemoteGraphicsContextGL::paintRenderingResultsToPixelBuffer):

• Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.h:
• Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
• Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:

(getInternalformativ):
(paintRenderingResultsToPixelBuffer): Deleted.

• Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:
• Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
• Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:

(WebKit::RemoteGraphicsContextGLProxy::paintRenderingResultsToPixelBuffer): Deleted.

• Tools/Scripts/generate-gpup-webgl:

Canonical link: ​https://commits.webkit.org/251330@main

6:11 AM Changeset in webkit [295283] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

Implement FlexFormattingContext::usedContentHeight
​https://bugs.webkit.org/show_bug.cgi?id=241325

Reviewed by Antti Koivisto.

Update the RenderFlexibleBox's content height.

• Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::usedContentHeight const):

• Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:

(WebCore::LayoutIntegration::FlexLayout::contentLogicalHeight const):

• Source/WebCore/rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutUsingFlexFormattingContext):

Canonical link: ​https://commits.webkit.org/251329@main

6:08 AM Changeset in webkit [295282] by Alan Bujtas

• 1 edit in trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

Populate canUseForFlexLayout with unsupported styles and content
​https://bugs.webkit.org/show_bug.cgi?id=241323

Reviewed by Tim Nguyen.

This is in preparation for being able to run WPT tests (filter out unsupported content).

• Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForFlexLayout):

Canonical link: ​https://commits.webkit.org/251328@main

5:10 AM Changeset in webkit [295281] by ntim@apple.com

• 2 edits
  3 moves
  57 adds in trunk/LayoutTests/imported/w3c

Re-import css/css-text/text-align/ WPT
​https://bugs.webkit.org/show_bug.cgi?id=241305

Reviewed by Cameron McCormack.

Upstream revision: ​https://github.com/web-platform-tests/wpt/commit/a6101f13a28eb78dbef77e276ddee75052a8a2d4

• LayoutTests/imported/w3c/resources/resource-files.json:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-center-last-center-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-center-last-center.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-center-last-default-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-center-last-default.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-center-last-end-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-center-last-end.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-center-last-justify-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-center-last-justify.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-center-last-start-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-center-last-start.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-default-last-default-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-default-last-default.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-last-center-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-last-center.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-last-default-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-last-default.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-last-end-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-last-end.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-last-justify-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-last-justify.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-last-start-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-end-last-start.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-last-center-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-last-center.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-last-default-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-last-default.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-last-end-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-last-end.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-last-justify-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-last-justify.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-last-start-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-justify-last-start.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-center-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-center-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-center.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-end-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-end-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-end.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-justify-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-justify-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-justify-rtl-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-justify-rtl-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-justify-rtl.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-justify.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-simple-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-expected.html.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-simple-ref.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-ref.html.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-simple.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last.html.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-start-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-start-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-start.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-start-last-center-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-start-last-center.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-start-last-default-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-start-last-default.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-start-last-end-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-start-last-end.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-start-last-justify-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-start-last-justify.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-start-last-start-expected-mismatch.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-start-last-start.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/w3c-import.log:

Canonical link: ​https://commits.webkit.org/251327@main

4:35 AM Changeset in webkit [295280] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore/platform/graphics

[Linux] Fix and improve format handling in DMABufFormat, TextureMapperPlatformLayerProxyDMABuf
​https://bugs.webkit.org/show_bug.cgi?id=241326

Patch by Žan Doberšek <​zdobersek@igalia.com> on 2022-06-06
Reviewed by Miguel Gomez.

In the DMABufFormat header, VYUY and AYUV format definitions are fixed to use
the correct FourCC values. In DMABufFormat::create(), a macro is used to map
FourCC values to corresponding DMABufFormat definitions.

In TextureMapperPlatformLayerProxyDMABuf, missing packed-YUV formats are
added to the switch statement, and properly ordered.

• Source/WebCore/platform/graphics/gbm/DMABufFormat.h:

(WebCore::DMABufFormat::create<DMABufFormat::FourCC::VYUY>):
(WebCore::DMABufFormat::create<DMABufFormat::FourCC::AYUV>):
(WebCore::DMABufFormat::create):

• Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyDMABuf.cpp:

(WebCore::TextureMapperPlatformLayerProxyDMABuf::DMABufLayer::paintToTextureMapper):

Canonical link: ​https://commits.webkit.org/251326@main

1:43 AM Changeset in webkit [295279] by commit-queue@webkit.org

• 22 edits
  3 adds in trunk

Add OES_draw_buffers_indexed WebGL extension support
​https://bugs.webkit.org/show_bug.cgi?id=222430

Patch by Alexey Knyazev <​3479527+lexaknyazev@users.noreply.github.com> on 2022-06-06
Reviewed by Kimmo Kinnunen.

• Added the entrypoints defined by the extension
• Added getIntegeri_v and getIntegeri context functions

• LayoutTests/TestExpectations:
• Source/WebCore/CMakeLists.txt:
• Source/WebCore/DerivedSources-input.xcfilelist:
• Source/WebCore/DerivedSources-output.xcfilelist:
• Source/WebCore/DerivedSources.make:
• Source/WebCore/Sources.txt:
• Source/WebCore/WebCore.xcodeproj/project.pbxproj:
• Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

• Source/WebCore/html/canvas/OESDrawBuffersIndexed.cpp: Added.

(WebCore::OESDrawBuffersIndexed::OESDrawBuffersIndexed):
(WebCore::OESDrawBuffersIndexed::getName const):
(WebCore::OESDrawBuffersIndexed::supported):
(WebCore::OESDrawBuffersIndexed::enableiOES):
(WebCore::OESDrawBuffersIndexed::disableiOES):
(WebCore::OESDrawBuffersIndexed::blendEquationiOES):
(WebCore::OESDrawBuffersIndexed::blendEquationSeparateiOES):
(WebCore::OESDrawBuffersIndexed::blendFunciOES):
(WebCore::OESDrawBuffersIndexed::blendFuncSeparateiOES):
(WebCore::OESDrawBuffersIndexed::colorMaskiOES):

• Source/WebCore/html/canvas/OESDrawBuffersIndexed.h: Added.
• Source/WebCore/html/canvas/OESDrawBuffersIndexed.idl: Added.
• Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getIndexedParameter):
(WebCore::WebGL2RenderingContext::getIndexedBooleanArrayParameter):
(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

• Source/WebCore/html/canvas/WebGL2RenderingContext.h:
• Source/WebCore/html/canvas/WebGLExtension.h:
• Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::extensionIsEnabled):
(WebCore::WebGLRenderingContextBase::loseExtensions):

• Source/WebCore/html/canvas/WebGLRenderingContextBase.h:
• Source/WebCore/platform/graphics/GraphicsContextGL.h:

(WebCore::GraphicsContextGL::getIntegeri):

• Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::getIntegeri_v):
(WebCore::GraphicsContextGLANGLE::enableiOES):
(WebCore::GraphicsContextGLANGLE::disableiOES):
(WebCore::GraphicsContextGLANGLE::blendEquationiOES):
(WebCore::GraphicsContextGLANGLE::blendEquationSeparateiOES):
(WebCore::GraphicsContextGLANGLE::blendFunciOES):
(WebCore::GraphicsContextGLANGLE::blendFuncSeparateiOES):
(WebCore::GraphicsContextGLANGLE::colorMaskiOES):

• Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:
• Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::getIntegeri_v):
(WebCore::GraphicsContextGLOpenGL::enableiOES):
(WebCore::GraphicsContextGLOpenGL::disableiOES):
(WebCore::GraphicsContextGLOpenGL::blendEquationiOES):
(WebCore::GraphicsContextGLOpenGL::blendEquationSeparateiOES):
(WebCore::GraphicsContextGLOpenGL::blendFunciOES):
(WebCore::GraphicsContextGLOpenGL::blendFuncSeparateiOES):
(WebCore::GraphicsContextGLOpenGL::colorMaskiOES):

• Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:
• Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:
• Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLFunctionsGenerated.h:

(getIntegeri_v):
(enableiOES):
(disableiOES):
(blendEquationiOES):
(blendEquationSeparateiOES):
(blendFunciOES):
(blendFuncSeparateiOES):
(colorMaskiOES):

• Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:
• Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxyFunctionsGenerated.cpp:

(WebKit::RemoteGraphicsContextGLProxy::getIntegeri_v):
(WebKit::RemoteGraphicsContextGLProxy::enableiOES):
(WebKit::RemoteGraphicsContextGLProxy::disableiOES):
(WebKit::RemoteGraphicsContextGLProxy::blendEquationiOES):
(WebKit::RemoteGraphicsContextGLProxy::blendEquationSeparateiOES):
(WebKit::RemoteGraphicsContextGLProxy::blendFunciOES):
(WebKit::RemoteGraphicsContextGLProxy::blendFuncSeparateiOES):
(WebKit::RemoteGraphicsContextGLProxy::colorMaskiOES):

Canonical link: ​https://commits.webkit.org/251325@main

Jun 5, 2022:

11:19 PM Changeset in webkit [295278] by Cameron McCormack

• 68 edits
  1 copy
  15 adds in trunk

Add a new DrawDecomposedGlyphs display list item to avoid repeatedly sending glyphs when using the GlyphDisplayListCache
​https://bugs.webkit.org/show_bug.cgi?id=240497
<rdar://93387615>

Reviewed by Simon Fraser.

The GlyphDisplayListCache is used to record a display list for
frequently painting text content. With GPU Process DOM rendering, there
is significant overhead in sending the contents of these display lists
over IPC. The contents of these display lists don't change if the text
content in the document doesn't change, so we could greatly reduce the
overhead by treating the data inside a display list item for glyph
drawing as a remote resource.

This commit adds:

• a new display list item, DrawDecomposedGlyphs, to represent drawing a glyph list resource
• a new class, DecomposedGlyphs, which is the resource type
• a new struct, PositionedGlyphs, to provide a common place for the glyph drawing fields (the vector of glyph IDs, the anchor position, etc.) to live, so that we don't have duplication between DisplayList::DrawGlyphs and DecomposedGlyphs

So that a DrawDecomposedGlyphs command can be replayed from a
GlyphDisplayListCache's in-memory display list and recorded to a
RemoteDisplayListRecorder, the GraphicsContext API gains a new
drawDecomposedGlyphs function.

A new argument to the DisplayList::RecordImpl constructor (and the
DrawGlyphsRecorder) is added to represent how to record drawText
commands:

• DrawGlyphsMode::Normal, which records each GraphicsContext::drawText call with a single DrawText command
• DrawGlyphsMode::DeconstructToDrawGlyphsCommands, which ensures different text layers get deconstructed into separate DrawText commands
• DrawGlyphsMode::DeconstructToDrawDecomposedGlyphsCommands, which ensures different text layers get desconstructed into separate DrawDecomposedGlyphs commands

FontCascade::displayListForTextRun is updated to use that last value.

Additionally, GlyphDisplayListCache is extended to cache display lists
keyed off TextRun values. This allows sharing of the same cached display
list between different elements on the page that have the same text
content.

This sharing would not be valid if the two elements have different
values for the color property, and the text contains COLRv0 glyphs that
alternate painting of specific colors and the color fill color, since
the recording would incorrectly record a setFillBrush command
corresponding to the first element's fill color. Rather than extend the
glyph recorder to parameterize the current fill (and stroke) colors, we
detect when outlines are drawn with colors other than the context's
initial colors, and prevent sharing. This is done by checking whether
the recorded display list contains items that aren't known to be safe
for sharing.

Similarly, if the sharing would not be valid if the contains bitmap
images (like those from emoji fonts) or SVG glyphs, both of which are
captured as DrawNativeImage commands, if the text is drawn at different
scales. This is because the size of the images is dependent on the
scale. We detect and prevent reuse across different text runs if the
scale is different, by checking the recorded display list for
DrawNativeImage commands and by storing the context scale on the
GlyphDisplayListCache::Entry.

• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-colr-unshared-expected.txt: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-colr-unshared.html: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-scaled-unshared-expected.txt: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-scaled-unshared.html: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-shadow-unshared-expected.txt: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-shadow-unshared.html: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-shared-expected.txt: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-shared.html: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-svg-unshared-expected.txt: Added.
• LayoutTests/fast/text/glyph-display-lists/glyph-display-list-svg-unshared.html: Added.
• Source/WebCore/Headers.cmake:
• Source/WebCore/Sources.txt:
• Source/WebCore/WebCore.xcodeproj/project.pbxproj:
• Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp:

(WebCore::BifurcatedGraphicsContext::drawDecomposedGlyphs):

• Source/WebCore/platform/graphics/BifurcatedGraphicsContext.h:
• Source/WebCore/platform/graphics/DecomposedGlyphs.cpp: Added.

(WebCore::DecomposedGlyphs::create):
(WebCore::DecomposedGlyphs::DecomposedGlyphs):
(WebCore::m_renderingResourceIdentifier):

• Source/WebCore/platform/graphics/DecomposedGlyphs.h: Added.

(WebCore::DecomposedGlyphs::positionedGlyphs const):
(WebCore::DecomposedGlyphs::bounds const):
(WebCore::DecomposedGlyphs::addObserver):
(WebCore::DecomposedGlyphs::removeObserver):
(WebCore::DecomposedGlyphs::renderingResourceIdentifier const):

• Source/WebCore/platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::displayListForTextRun const):

• Source/WebCore/platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawDecomposedGlyphs):

• Source/WebCore/platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::drawGlyphsAndCacheResources):
(WebCore::GraphicsContext::drawGlyphsAndCacheFont): Deleted.

• Source/WebCore/platform/graphics/NullGraphicsContext.h:
• Source/WebCore/platform/graphics/PositionedGlyphs.cpp: Copied from Source/WebCore/platform/graphics/win/DrawGlyphsRecorderWin.cpp.

(WebCore::PositionedGlyphs::computeBounds const):

• Source/WebCore/platform/graphics/PositionedGlyphs.h: Added.

(WebCore::PositionedGlyphs::PositionedGlyphs):
(WebCore::PositionedGlyphs::encode const):
(WebCore::PositionedGlyphs::decode):

• Source/WebCore/platform/graphics/TextRun.cpp:

(WebCore::operator<<):

• Source/WebCore/platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::isHashTableEmptyValue const):
(WebCore::TextRun::isHashTableDeletedValue const):
(WebCore::TextRun::cloneForStorage const):

• Source/WebCore/platform/graphics/TextRunHash.h: Added.

(WebCore::add):
(WebCore::TextRun::operator== const):
(WebCore::TextRunHash::hash):
(WebCore::TextRunHash::equal):
(WTF::HashTraits<WebCore::TextRun>::isDeletedValue):
(WTF::HashTraits<WebCore::TextRun>::isEmptyValue):
(WTF::HashTraits<WebCore::TextRun>::constructDeletedValue):
(WTF::HashTraits<WebCore::TextRun>::emptyValue):

• Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContextCairo::drawDecomposedGlyphs):

• Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.h:
• Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp:

(WebCore::DrawGlyphsRecorder::createInternalContext):
(WebCore::DrawGlyphsRecorder::updateCTM):
(WebCore::DrawGlyphsRecorder::recordDrawGlyphs):

• Source/WebCore/platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::description const):
(WebCore::DisplayList::DisplayList::append):

• Source/WebCore/platform/graphics/displaylists/DisplayList.h:

(WebCore::DisplayList::DisplayList::cacheDecomposedGlyphs):

• Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp:

(WebCore::DisplayList::ItemHandle::apply):
(WebCore::DisplayList::ItemHandle::destroy):
(WebCore::DisplayList::ItemHandle::safeCopy const):

• Source/WebCore/platform/graphics/displaylists/DisplayListItemType.cpp:

(WebCore::DisplayList::sizeOfItemInBytes):
(WebCore::DisplayList::isDrawingItem):
(WebCore::DisplayList::isInlineItem):

• Source/WebCore/platform/graphics/displaylists/DisplayListItemType.h:
• Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawGlyphs::DrawGlyphs):
(WebCore::DisplayList::m_bounds):
(WebCore::DisplayList::DrawGlyphs::apply const):
(WebCore::DisplayList::DrawDecomposedGlyphs::apply const):
(WebCore::DisplayList::operator<<):
(WebCore::DisplayList::dumpItem):
(WebCore::DisplayList::dumpItemHandle):
(WebCore::DisplayList::DrawGlyphs::computeBounds): Deleted.

• Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawGlyphs::localAnchor const):
(WebCore::DisplayList::DrawGlyphs::anchorPoint const):
(WebCore::DisplayList::DrawGlyphs::glyphs const):
(WebCore::DisplayList::DrawGlyphs::encode const):
(WebCore::DisplayList::DrawGlyphs::decode):
(WebCore::DisplayList::DrawDecomposedGlyphs::DrawDecomposedGlyphs):
(WebCore::DisplayList::DrawDecomposedGlyphs::fontIdentifier const):
(WebCore::DisplayList::DrawDecomposedGlyphs::decomposedGlyphsIdentifier const):
(WebCore::DisplayList::DrawDecomposedGlyphs::globalBounds const):
(WebCore::DisplayList::DrawDecomposedGlyphs::localBounds const):

• Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::Recorder):
(WebCore::DisplayList::Recorder::shouldDeconstructDrawGlyphs const):
(WebCore::DisplayList::Recorder::drawGlyphs):
(WebCore::DisplayList::Recorder::drawDecomposedGlyphs):
(WebCore::DisplayList::Recorder::drawGlyphsAndCacheResources):
(WebCore::DisplayList::Recorder::drawGlyphsAndCacheFont): Deleted.

• Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:
• Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp:

(WebCore::DisplayList::RecorderImpl::RecorderImpl):
(WebCore::DisplayList::RecorderImpl::recordDrawDecomposedGlyphs):
(WebCore::DisplayList::RecorderImpl::recordResourceUse):

• Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h:
• Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::applyDrawDecomposedGlyphs):
(WebCore::DisplayList::Replayer::applyItem):
(WebCore::DisplayList::Replayer::replay):

• Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.h:
• Source/WebCore/platform/graphics/displaylists/DisplayListResourceHeap.h:

(WebCore::DisplayList::LocalResourceHeap::add):

• Source/WebCore/platform/graphics/harfbuzz/DrawGlyphsRecorderHarfBuzz.cpp:

(WebCore::DrawGlyphsRecorder::drawGlyphs):

• Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:

(Nicosia::CairoOperationRecorder::drawDecomposedGlyphs):

• Source/WebCore/platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
• Source/WebCore/platform/graphics/win/DrawGlyphsRecorderWin.cpp:

(WebCore::DrawGlyphsRecorder::drawGlyphs):

• Source/WebCore/platform/text/TextDirection.h:

(WebCore::operator<<):

• Source/WebCore/platform/text/TextFlags.cpp:

(WebCore::operator<<):

• Source/WebCore/platform/text/TextFlags.h:

(WebCore::ExpansionBehavior::operator== const):

• Source/WebCore/rendering/GlyphDisplayListCache.cpp: Added.

(WebCore::GlyphDisplayListCacheBase::displayListSharing):

• Source/WebCore/rendering/GlyphDisplayListCache.h:

(WebCore::GlyphDisplayListCacheBase::size const):
(WebCore::GlyphDisplayListCacheBase::sizeInBytes const):
(WebCore::GlyphDisplayListCacheBase::Entry::create):
(WebCore::GlyphDisplayListCacheBase::Entry::displayList):
(WebCore::GlyphDisplayListCacheBase::Entry::relevantScaleFactor const):
(WebCore::GlyphDisplayListCacheBase::Entry::Entry):
(WebCore::GlyphDisplayListCache::get):
(WebCore::GlyphDisplayListCache::getIfExists):
(WebCore::GlyphDisplayListCache::remove):
(WebCore::GlyphDisplayListCache::clear):
(WebCore::GlyphDisplayListCache::size const): Deleted.
(WebCore::GlyphDisplayListCache::sizeInBytes const): Deleted.

• Source/WebCore/rendering/RenderLayerCompositor.cpp:
• Source/WebCore/rendering/TextPainter.cpp:
• Source/WebCore/testing/Internals.cpp:

(WebCore::toDisplayListFlags):
(WebCore::Internals::displayListForElement):
(WebCore::Internals::replayDisplayListForElement):
(WebCore::Internals::cachedGlyphDisplayListsForTextNode):

• Source/WebCore/testing/Internals.h:
• Source/WebCore/testing/Internals.idl:
• Source/WebKit/GPUProcess/graphics/QualifiedResourceHeap.h:

(WebKit::QualifiedResourceHeap::add):
(WebKit::QualifiedResourceHeap::getDecomposedGlyphs const):
(WebKit::QualifiedResourceHeap::removeDecomposedGlyphs):
(WebKit::QualifiedResourceHeap::checkInvariants const):

• Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp:

(WebKit::RemoteDisplayListRecorder::drawDecomposedGlyphs):
(WebKit::RemoteDisplayListRecorder::drawDecomposedGlyphsWithQualifiedIdentifiers):

• Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h:
• Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in:
• Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::cacheFontWithQualifiedIdentifier):
(WebKit::RemoteRenderingBackend::cacheDecomposedGlyphs):
(WebKit::RemoteRenderingBackend::cacheDecomposedGlyphsWithQualifiedIdentifier):

• Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h:
• Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in:
• Source/WebKit/GPUProcess/graphics/RemoteResourceCache.cpp:

(WebKit::RemoteResourceCache::cacheDecomposedGlyphs):
(WebKit::RemoteResourceCache::cachedDecomposedGlyphs const):
(WebKit::RemoteResourceCache::releaseRemoteResource):

• Source/WebKit/GPUProcess/graphics/RemoteResourceCache.h:
• Source/WebKit/Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<DecomposedGlyphs>::encode):
(IPC::ArgumentCoder<DecomposedGlyphs>::decode):

• Source/WebKit/Shared/WebCoreArgumentCoders.h:
• Source/WebKit/WebKit.xcodeproj/project.pbxproj:
• Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:

(WebKit::RemoteDisplayListRecorderProxy::RemoteDisplayListRecorderProxy):
(WebKit::RemoteDisplayListRecorderProxy::recordDrawDecomposedGlyphs):
(WebKit::RemoteDisplayListRecorderProxy::recordResourceUse):

• Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
• Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::cacheDecomposedGlyphs):

• Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
• Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp:

(WebKit::RemoteResourceCacheProxy::~RemoteResourceCacheProxy):
(WebKit::RemoteResourceCacheProxy::recordDecomposedGlyphsUse):
(WebKit::RemoteResourceCacheProxy::releaseDecomposedGlyphs):
(WebKit::RemoteResourceCacheProxy::clearDecomposedGlyphsMap):
(WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed):

• Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:

Canonical link: ​https://commits.webkit.org/251324@main

10:20 PM Changeset in webkit [295277] by Alan Bujtas

• 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp

Take align-self into account when computing flex item's logical height.
​https://bugs.webkit.org/show_bug.cgi?id=241314

Reviewed by Antti Koivisto.

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):

Canonical link: ​https://commits.webkit.org/251323@main

8:51 PM Changeset in webkit [295276] by Alan Bujtas

• 4 edits in trunk/Source/WebCore/layout/formattingContexts/flex

FlexLayout should only take logical values
​https://bugs.webkit.org/show_bug.cgi?id=241310

Reviewed by Antti Koivisto.

Turn ConstraintsForFlexContent into LogicalConstraints.

• Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):

• Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.h:
• Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::computeAvailableLogicalVerticalSpace const):
(WebCore::Layout::FlexLayout::computeAvailableLogicalHorizontalSpace const):
(WebCore::Layout::FlexLayout::layout):

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:

Canonical link: ​https://commits.webkit.org/251322@main

6:24 PM Changeset in webkit [295275] by Alan Bujtas

• 1 edit in trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp

Reset the flex item renderers before flex layout
​https://bugs.webkit.org/show_bug.cgi?id=241311

Reviewed by Antti Koivisto.

Each layout frame should start with a clean state.

• Source/WebCore/rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutUsingFlexFormattingContext):

Canonical link: ​https://commits.webkit.org/251321@main

6:06 PM Changeset in webkit [295274] by Alan Bujtas

• 2 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Distribute extra logical vertical space across lines
​https://bugs.webkit.org/show_bug.cgi?id=241307

Reviewed by Antti Koivisto.

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::computeAvailableLogicalVerticalSpace const):
(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexLayout::layout):

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:

Canonical link: ​https://commits.webkit.org/251320@main

5:04 PM Changeset in webkit [295273] by Alan Bujtas

• 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp

column-reverse content should take resolved flex box height into account when computing visual position
​https://bugs.webkit.org/show_bug.cgi?id=241313

Reviewed by Antti Koivisto.

When the flex box has resolvable height, use it as the anchor point to compute the column-reverse content's visual vertical position.

• Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):

Canonical link: ​https://commits.webkit.org/251319@main

2:53 PM Changeset in webkit [295272] by Chris Dumez

• 1 edit in trunk/Source/WebKit/Shared/Cocoa/XPCEndpoint.mm

Unreviewed iOS build fix after 251316@main
​https://bugs.webkit.org/show_bug.cgi?id=241321

• Source/WebKit/Shared/Cocoa/XPCEndpoint.mm:

Canonical link: ​https://commits.webkit.org/251318@main

2:06 AM Changeset in webkit [295271] by commit-queue@webkit.org

• 1 edit
  2 adds in trunk

REGRESSION(STP146): wpt/quirks/table-cell-width-calculation.html
​https://bugs.webkit.org/show_bug.cgi?id=241005
rdar://problem/94025359

Patch by Youenn Fablet <​youennf@gmail.com> on 2022-06-05
Reviewed by Brent Fulgham and Chris Dumez.

We should be able to use memory cache when images are either loaded using ServiceWorkerMode::All or None.
Make the reload check stricter by mandating reload in case service worker mode is none for requests that might trigger registration matching in network process.

• LayoutTests/imported/w3c/web-platform-tests/quirks/table-cell-width-calculation-expected.txt: Added.
• LayoutTests/imported/w3c/web-platform-tests/quirks/table-cell-width-calculation.html: Added.
• Source/WebCore/loader/cache/CachedResourceLoader.cpp:

(WebCore::mustReloadFromServiceWorkerOptions):
(WebCore::CachedResourceLoader::determineRevalidationPolicy const):

Canonical link: ​https://commits.webkit.org/251317@main

Jun 4, 2022:

11:59 PM Changeset in webkit [295270] by Chris Dumez

• 380 edits in trunk

Drop operator==() overload for comparing a String to a const char*
​https://bugs.webkit.org/show_bug.cgi?id=241285

Reviewed by Darin Adler.

Drop operator==() overload for comparing a String to a const char*. This
encourages people to use ""_s for string literals.

• Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEqualityOpImpl):

• Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:

(JSC::ApplyFunctionCallDotNode::emitBytecode):

• Source/JavaScriptCore/inspector/ScriptCallFrame.cpp:

(Inspector::ScriptCallFrame::isNative const):

• Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorXPCConnection.mm:

(Inspector::RemoteInspectorXPCConnection::handleEvent):

• Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:

(CppProtocolTypesImplementationGenerator):

• Source/JavaScriptCore/jit/ExecutableAllocator.cpp:

(JSC::isJITEnabled):
(JSC::ExecutableAllocator::setJITEnabled):

• Source/JavaScriptCore/jsc.cpp:

(dumpException):

• Source/JavaScriptCore/runtime/IntlCollator.cpp:

(JSC::IntlCollator::initializeCollator):

• Source/JavaScriptCore/runtime/IntlObject.cpp:

(JSC::removeUnicodeLocaleExtension):

• Source/JavaScriptCore/runtime/JSObject.cpp:

(JSC::JSObject::calculatedClassName):

• Source/JavaScriptCore/runtime/Options.cpp:

(JSC::canUseJITCage):

• Source/JavaScriptCore/runtime/StringPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

• Source/JavaScriptCore/runtime/TypeSet.cpp:

(JSC::StructureShape::leastCommonAncestor):

• Source/JavaScriptCore/tools/JSDollarVM.cpp:
• Source/JavaScriptCore/yarr/YarrUnicodeProperties.cpp:

(JSC::Yarr::unicodeMatchPropertyValue):

• Source/WTF/wtf/URL.cpp:

(WTF::URL::setProtocol):

• Source/WTF/wtf/cocoa/Entitlements.h:
• Source/WTF/wtf/cocoa/Entitlements.mm:

(WTF::hasEntitlement):
(WTF::processHasEntitlement):
(WTF::hasEntitlementValue):

• Source/WTF/wtf/text/WTFString.h:
• Source/WebCore/Modules/applepay/PaymentRequestValidator.mm:

(WebCore::validateCountryCode):
(WebCore::validateCurrencyCode):

• Source/WebCore/Modules/async-clipboard/ios/ClipboardImageReaderIOS.mm:

(WebCore::ClipboardImageReader::readBuffer):

• Source/WebCore/Modules/async-clipboard/mac/ClipboardImageReaderMac.mm:

(WebCore::ClipboardImageReader::readBuffer):

• Source/WebCore/Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::requestFromInfo):

• Source/WebCore/Modules/cache/DOMCacheEngine.cpp:

(WebCore::DOMCacheEngine::matchURLs):

• Source/WebCore/Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):

• Source/WebCore/Modules/fetch/FetchRequest.cpp:

(WebCore::methodCanHaveBody):
(WebCore::FetchRequest::initializeOptions):
(WebCore::FetchRequest::referrer const):

• Source/WebCore/Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::contentTypeShouldGenerateTimestamps):

• Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::setContentHint):

• Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp:

(WebCore::RTCRtpSFrameTransform::setEncryptionKey):

• Source/WebCore/Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::dtmf):

• Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:

(WebCore::GStreamerMediaEndpoint::createTransceiverBackends):

• Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:

(WebCore::iceCandidateType):

• Source/WebCore/Modules/mediastream/gstreamer/GStreamerWebRTCUtils.cpp:

(WebCore::toRTCIceProtocol):
(WebCore::toRTCIceTcpCandidateType):
(WebCore::toRTCIceCandidateType):
(WebCore::parseIceCandidateSDP):

• Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::addTransceiver):

• Source/WebCore/Modules/webauthn/cbor/CBORValue.cpp:

(cbor::CBORValue::CBORValue):

• Source/WebCore/Modules/webauthn/cbor/CBORValue.h:
• Source/WebCore/Modules/webauthn/fido/AuthenticatorGetInfoResponse.cpp:

(fido::encodeAsCBOR):

• Source/WebCore/Modules/webauthn/fido/FidoConstants.h:
• Source/WebCore/Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::setBinaryType):

• Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp:

(PAL::WebGPU::AdapterImpl::requestDevice):

• Source/WebCore/accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canSetValueAttribute const):

• Source/WebCore/accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::currentState const):
(WebCore::AccessibilityObject::attributeValue const):

• Source/WebCore/accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::isColumnHeaderCell const):
(WebCore::AccessibilityTableCell::isRowHeaderCell const):
(WebCore::AccessibilityTableCell::columnHeaders):
(WebCore::AccessibilityTableCell::rowHeaders):
(WebCore::AccessibilityTableCell::axRowSpan const):

• Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

• Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::state const):

• Source/WebCore/accessibility/atspi/AccessibilityObjectTextAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::textAttributes const):

• Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::attributeValue const):

• Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp:

(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue):

• Source/WebCore/animation/KeyframeEffect.cpp:

(WebCore::IDLAttributeNameToAnimationPropertyName):

• Source/WebCore/bindings/js/IDBBindingUtilities.cpp:

(WebCore::get):

• Source/WebCore/bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSC_DEFINE_HOST_FUNCTION):

• Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowInstanceFunction_openDatabaseBody):

• Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:

(GenerateIsLegacyUnforgeablePropertyName):

• Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeableProperties.cpp:

(WebCore::JSTestNamedSetterWithLegacyUnforgeableProperties::defineOwnProperty):

• Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns.cpp:

(WebCore::JSTestNamedSetterWithLegacyUnforgeablePropertiesAndLegacyOverrideBuiltIns::defineOwnProperty):

• Source/WebCore/contentextensions/ContentExtensionActions.cpp:

(WebCore::ContentExtensions::ModifyHeadersAction::ModifyHeaderInfo::parse):
(WebCore::ContentExtensions::RedirectAction::URLTransformAction::parse):

• Source/WebCore/contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::loadAction):

• Source/WebCore/crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::importKey):

• Source/WebCore/crypto/algorithms/CryptoAlgorithmECDSA.cpp:

(WebCore::CryptoAlgorithmECDSA::importKey):

• Source/WebCore/crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::importKey):

• Source/WebCore/crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):

• Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::importKey):

• Source/WebCore/crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:

(WebCore::CryptoAlgorithmRSA_PSS::importKey):

• Source/WebCore/crypto/keys/CryptoKeyAES.cpp:

(WebCore::CryptoKeyAES::importJwk):

• Source/WebCore/crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::importJwk):

• Source/WebCore/crypto/keys/CryptoKeyHMAC.cpp:

(WebCore::CryptoKeyHMAC::importJwk):

• Source/WebCore/crypto/keys/CryptoKeyRSA.cpp:

(WebCore::CryptoKeyRSA::importJwk):

• Source/WebCore/css/CSSBasicShapes.cpp:

(WebCore::buildInsetRadii):

• Source/WebCore/css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const):

• Source/WebCore/css/CSSPropertySourceData.cpp:

(WebCore::CSSPropertySourceData::toString const):

• Source/WebCore/css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const):

• Source/WebCore/css/MediaQuery.cpp:

(WebCore::MediaQuery::serialize const):

• Source/WebCore/css/SelectorCheckerTestFunctions.h:

(WebCore::matchesLangPseudoClass):

• Source/WebCore/css/StyleProperties.cpp:

(WebCore::StyleProperties::borderPropertyValue const):
(WebCore::StyleProperties::asTextInternal const):

• Source/WebCore/css/parser/CSSPropertyParser.cpp:

(WebCore::parseGridTemplateAreasRow):
(WebCore::CSSPropertyParser::canParseTypedCustomPropertyValue):
(WebCore::CSSPropertyParser::collectParsedCustomPropertyValueDependencies):
(WebCore::CSSPropertyParser::parseTypedCustomPropertyValue):

• Source/WebCore/dom/DataTransfer.cpp:

(WebCore::DataTransfer::getDataForItem const):
(WebCore::DataTransfer::readStringFromPasteboard const):
(WebCore::DataTransfer::setDataFromItemList):
(WebCore::dragOpFromIEOp):
(WebCore::DataTransfer::dropEffect const):
(WebCore::DataTransfer::setDropEffect):

• Source/WebCore/dom/DataTransfer.h:

(WebCore::DataTransfer::dropEffectIsUninitialized const):

• Source/WebCore/dom/Document.cpp:

(WebCore::Document::originIdentifierForPasteboard const):

• Source/WebCore/dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

• Source/WebCore/dom/Range.cpp:

(WebCore::Range::expand):

• Source/WebCore/dom/UIEventWithKeyState.cpp:

(WebCore::UIEventWithKeyState::getModifierState const):

• Source/WebCore/editing/Editing.cpp:

(WebCore::isMailBlockquote):

• Source/WebCore/editing/Editor.cpp:

(WebCore::Editor::handleTextEvent):
(WebCore::Editor::insertTextWithoutSendingTextEvent):

• Source/WebCore/editing/HTMLInterchange.h:
• Source/WebCore/editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::doApply):

• Source/WebCore/editing/ReplaceSelectionCommand.cpp:

(WebCore::isInterchangeNewlineNode):
(WebCore::isInterchangeConvertedSpaceSpan):
(WebCore::isInlineNodeWithStyle):

• Source/WebCore/editing/cocoa/HTMLConverter.mm:

(HTMLConverter::computedAttributesForElement):
(HTMLConverter::_addAttachmentForElement):
(HTMLConverter::_enterElement):
(HTMLConverter::_addTableForElement):
(HTMLConverter::_addTableCellForElement):
(HTMLConverter::_processElement):
(HTMLConverter::_exitElement):
(HTMLConverter::_processText):

• Source/WebCore/editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendNodeToPreserveMSOList):
(WebCore::createFragmentFromText):
(WebCore::createFragmentForTransformToFragment):

• Source/WebCore/html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::handleKeydownEvent):

• Source/WebCore/html/BaseClickableWithKeyInputType.cpp:

(WebCore::BaseClickableWithKeyInputType::handleKeydownEvent):
(WebCore::BaseClickableWithKeyInputType::handleKeyupEvent):

• Source/WebCore/html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::handleKeyupEvent):

• Source/WebCore/html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine):

• Source/WebCore/html/FormController.cpp:

(WebCore::FormController::SavedFormState::appendReferencedFilePaths const):

• Source/WebCore/html/HTMLAnchorElement.cpp:

(WebCore::isEnterKeyKeydownEvent):

• Source/WebCore/html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::parseAttribute):

• Source/WebCore/html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::defaultEventHandler):

• Source/WebCore/html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::is2dType):
(WebCore::HTMLCanvasElement::isWebGLType):
(WebCore::HTMLCanvasElement::toWebGLVersion):
(WebCore::HTMLCanvasElement::isBitmapRendererType):

• Source/WebCore/html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::parseAttribute):

• Source/WebCore/html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValueFromRenderer):

• Source/WebCore/html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::collectPresentationalHintsForAttribute):

• Source/WebCore/html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::collectPresentationalHintsForAttribute):

• Source/WebCore/html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::collectPresentationalHintsForAttribute):

• Source/WebCore/html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

• Source/WebCore/html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

• Source/WebCore/html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::defaultEventHandler):

• Source/WebCore/html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setSelectionRange):

• Source/WebCore/html/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler):

• Source/WebCore/html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseTimeFragment):

• Source/WebCore/html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::handleKeyupEvent):

• Source/WebCore/html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

• Source/WebCore/html/SearchInputType.cpp:

(WebCore::SearchInputType::handleKeydownEvent):

• Source/WebCore/html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleKeydownEvent):
(WebCore::TextFieldInputType::handleKeydownEventForSpinButton):
(WebCore::TextFieldInputType::shouldSubmitImplicitly):

• Source/WebCore/html/canvas/CanvasPattern.cpp:

(WebCore::CanvasPattern::parseRepetitionType):

• Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::setLineCap):
(WebCore::CanvasRenderingContext2DBase::setLineJoin):

• Source/WebCore/html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype):

• Source/WebCore/html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):

• Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp:

(WebCore::InspectorAuditAccessibilityObject::getComputedProperties):

• Source/WebCore/inspector/InspectorCanvas.cpp:

(WebCore::shouldSnapshotBitmapRendererAction):
(WebCore::shouldSnapshotWebGLAction):
(WebCore::shouldSnapshotWebGL2Action):

• Source/WebCore/inspector/InspectorFrontendHost.cpp:

(WebCore::dockSideFromString):
(WebCore::populateContextMenu):

• Source/WebCore/inspector/InspectorStyleSheet.cpp:

(WebCore::buildArrayForGroupings):
(WebCore::InspectorStyle::shorthandValue const):

• Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

• Source/WebCore/loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlSimpleRequestMethodAllowlist):
(WebCore::passesAccessControlCheck):

• Source/WebCore/loader/DocumentLoader.cpp:

(WebCore::isRedirectToGetAfterPost):
(WebCore::DocumentLoader::isPostOrRedirectAfterPost):
(WebCore::DocumentLoader::responseReceived):

• Source/WebCore/loader/FormSubmission.cpp:

(WebCore::FormSubmission::Attributes::updateEncodingType):

• Source/WebCore/loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::addHTTPOriginIfNeeded):
(WebCore::createWindow):

• Source/WebCore/loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::isMixedContent):

• Source/WebCore/loader/PrivateClickMeasurement.cpp:

(WebCore::PrivateClickMeasurement::parseAttributionRequestQuery):

• Source/WebCore/loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::loadDataURL):

• Source/WebCore/loader/SubframeLoader.cpp:

(WebCore::FrameLoader::SubframeLoader::requestFrame):

• Source/WebCore/loader/archive/mhtml/MHTMLParser.cpp:

(WebCore::MHTMLParser::parseArchiveWithHeader):

• Source/WebCore/loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::add):

• Source/WebCore/loader/mac/LoaderNSURLExtras.mm:

(suggestedFilenameWithMIMEType):

• Source/WebCore/mathml/MathMLElement.cpp:

(WebCore::convertMathSizeIfNeeded):

• Source/WebCore/mathml/MathMLOperatorElement.cpp:

(WebCore::MathMLOperatorElement::computeDictionaryProperty):

• Source/WebCore/mathml/MathMLPresentationElement.cpp:

(WebCore::MathMLPresentationElement::parseMathVariantAttribute):

• Source/WebCore/mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::isMathMLEncoding):
(WebCore::MathMLSelectElement::isSVGEncoding):
(WebCore::MathMLSelectElement::isHTMLEncoding):
(WebCore::MathMLSelectElement::getSelectedActionChild):
(WebCore::MathMLSelectElement::defaultEventHandler):
(WebCore::MathMLSelectElement::willRespondToMouseClickEventsWithEditability const):

• Source/WebCore/page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

• Source/WebCore/page/EventHandler.cpp:

(WebCore::convertDropZoneOperationToDragOperation):
(WebCore::EventHandler::accessibilityPreventsEventPropagation):
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::isKeyboardOptionTab):

• Source/WebCore/page/Performance.cpp:

(WebCore::Performance::getEntriesByType const):
(WebCore::Performance::getEntriesByName const):
(WebCore::Performance::appendBufferedEntriesByType const):

• Source/WebCore/page/PerformanceEntry.cpp:

(WebCore::PerformanceEntry::parseEntryTypeString):

• Source/WebCore/page/Quirks.cpp:

(WebCore::isTwitterDocument):
(WebCore::isYouTubeDocument):
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
(WebCore::Quirks::shouldDispatchedSimulatedMouseEventsAssumeDefaultPrevented const):
(WebCore::Quirks::shouldMakeTouchEventNonCancelableForTarget const):
(WebCore::Quirks::shouldEnableLegacyGetUserMediaQuirk const):
(WebCore::Quirks::shouldDisableElementFullscreenQuirk const):
(WebCore::Quirks::needsCanPlayAfterSeekedQuirk const):
(WebCore::Quirks::shouldAllowNavigationToCustomProtocolWithoutUserGesture):

• Source/WebCore/page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canDisplay const):
(WebCore::SecurityOrigin::toString const):
(WebCore::areOriginsMatching):

• Source/WebCore/page/SecurityOrigin.h:

(WebCore::SecurityOrigin::isHTTPFamily const):

• Source/WebCore/page/SecurityOriginData.cpp:

(WebCore::SecurityOriginData::toString const):

• Source/WebCore/page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::referrerToOriginString):

• Source/WebCore/page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::matches const):

• Source/WebCore/page/WindowFeatures.cpp:

(WebCore::boolFeature):

• Source/WebCore/page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::ResourceUsageThread::platformCollectCPUData):

• Source/WebCore/page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation const):

• Source/WebCore/page/csp/ContentSecurityPolicySource.cpp:

(WebCore::ContentSecurityPolicySource::schemeMatches const):

• Source/WebCore/page/linux/ResourceUsageThreadLinux.cpp:

(WebCore::ResourceUsageThread::platformCollectCPUData):

• Source/WebCore/platform/KeyboardScrollingAnimator.cpp:

(WebCore::keyboardScrollingKeyFromEvent):

• Source/WebCore/platform/KeypressCommand.h:

(WebCore::KeypressCommand::KeypressCommand):

• Source/WebCore/platform/LocalizedStrings.cpp:

(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):

• Source/WebCore/platform/Pasteboard.cpp:

(WebCore::Pasteboard::isSafeTypeForDOMToReadAndWrite):

• Source/WebCore/platform/RegistrableDomain.h:

(WebCore::RegistrableDomain::operator== const):

• Source/WebCore/platform/Theme.cpp:

(WebCore::Theme::drawNamedImage const):

• Source/WebCore/platform/UserAgentQuirks.cpp:

(WebCore::urlRequiresChromeBrowser):
(WebCore::urlRequiresFirefoxBrowser):
(WebCore::urlRequiresMacintoshPlatform):
(WebCore::urlRequiresUnbrandedUserAgent):

• Source/WebCore/platform/cocoa/ThemeCocoa.mm:

(WebCore::ThemeCocoa::drawNamedImage const):

• Source/WebCore/platform/graphics/GLContext.cpp:

(WebCore::GLContext::version):

• Source/WebCore/platform/graphics/Image.cpp:

(WebCore::Image::create):

• Source/WebCore/platform/graphics/MIMETypeCache.cpp:

(WebCore::MIMETypeCache::shouldOverrideExtendedType):

• Source/WebCore/platform/graphics/VP9Utilities.cpp:

(WebCore::parseVPCodecParameters):

• Source/WebCore/platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:

(WebCore::CDMPrivateMediaSourceAVFObjC::supportsMIMEType):

• Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::shouldWaitForLoadingOfResource):

• Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):

• Source/WebCore/platform/graphics/cairo/ImageBufferUtilitiesCairo.cpp:

(WebCore::encodeImage):

• Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoderCG::frameHasAlphaAtIndex const):
(WebCore::ImageDecoderCG::createFrameImageAtIndex):

• Source/WebCore/platform/graphics/cg/ImageSourceCGWin.cpp:

(WebCore::MIMETypeForImageType):

• Source/WebCore/platform/graphics/cocoa/VP9UtilitiesCocoa.mm:

(WebCore::isVPCodecConfigurationRecordSupported):
(WebCore::createVideoInfoFromVPCodecConfigurationRecord):

• Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::getFamilyNameStringFromFamily):

• Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::isMediaDiskCacheDisabled):

• Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::platformMaximumBufferSize const):

• Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGL.cpp:

(WebCore::ExtensionsGLOpenGL::platformSupportsExtension):

• Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:

(WebCore::ExtensionsGLOpenGLCommon::supports):
(WebCore::ExtensionsGLOpenGLCommon::ensureEnabled):
(WebCore::ExtensionsGLOpenGLCommon::isEnabled):

• Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLES.cpp:

(WebCore::ExtensionsGLOpenGLES::isEnabled):
(WebCore::ExtensionsGLOpenGLES::platformSupportsExtension):

• Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::checkVaryingsPacking const):

• Source/WebCore/platform/gtk/PasteboardGtk.cpp:

(WebCore::selectionDataTypeFromHTMLClipboardType):

• Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):

• Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::platformPasteboardTypeForSafeTypeForDOMToReadAndWrite):

• Source/WebCore/platform/ios/PreviewConverterIOS.mm:

(WebCore::PreviewConverter::isPlatformPasswordError const):

• Source/WebCore/platform/mac/PasteboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):

• Source/WebCore/platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::platformPasteboardTypeForSafeTypeForDOMToReadAndWrite):

• Source/WebCore/platform/mac/PublicSuffixMac.mm:

(WebCore::topPrivatelyControlledDomain):

• Source/WebCore/platform/mediastream/RealtimeMediaSourceSettings.cpp:

(WebCore::RealtimeMediaSourceSettings::videoFacingModeEnum):

• Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoEncoderFactory.cpp:

(WebCore::GStreamerH264Encoder::GStreamerH264Encoder):

• Source/WebCore/platform/mock/MediaEngineConfigurationFactoryMock.cpp:

(WebCore::canDecodeMedia):
(WebCore::canSmoothlyDecodeMedia):
(WebCore::canPowerEfficientlyDecodeMedia):
(WebCore::canEncodeMedia):
(WebCore::canSmoothlyEncodeMedia):
(WebCore::canPowerEfficientlyEncodeMedia):

• Source/WebCore/platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::supportsType):

• Source/WebCore/platform/network/CacheValidation.cpp:

(WebCore::verifyVaryingRequestHeadersInternal):

• Source/WebCore/platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::isMultipart const):

• Source/WebCore/platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::cfStreamError const):

• Source/WebCore/platform/network/curl/CookieJarDB.cpp:

(WebCore::CookieJarDB::checkDatabaseValidity):

• Source/WebCore/platform/network/curl/CookieJarDB.h:

(WebCore::CookieJarDB::isOnMemory const):

• Source/WebCore/platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::shouldRedirectAsGET):

• Source/WebCore/platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::setupTransfer):

• Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp:

(WebCore::topPrivatelyControlledDomain):

• Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::shouldRedirectAsGET):

• Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.h:

(WebCore::shouldUseQuickLookForMIMEType):

• Source/WebCore/platform/soup/PublicSuffixSoup.cpp:

(WebCore::topPrivatelyControlledDomain):

• Source/WebCore/platform/win/SearchPopupMenuDB.cpp:

(WebCore::SearchPopupMenuDB::checkDatabaseValidity):

• Source/WebCore/rendering/RenderBlockFlow.cpp:

(WebCore::needsAppleMailPaginationQuirk):

• Source/WebCore/rendering/RenderCounter.cpp:

(WebCore::planCounter):

• Source/WebCore/rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::getAverageCharWidth):

• Source/WebCore/rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::getAverageCharWidth):
(WebCore::RenderTextControlSingleLine::preferredContentLogicalWidth const):

• Source/WebCore/rendering/RenderTreeAsText.cpp:

(WebCore::isEmptyOrUnstyledAppleStyleSpan):

• Source/WebCore/svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

• Source/WebCore/svg/SVGComponentTransferFunctionElement.h:

(WebCore::SVGPropertyTraits<ComponentTransferType>::fromString):

• Source/WebCore/svg/SVGFEColorMatrixElement.h:

(WebCore::SVGPropertyTraits<ColorMatrixType>::fromString):

• Source/WebCore/svg/SVGFECompositeElement.h:

(WebCore::SVGPropertyTraits<CompositeOperationType>::fromString):

• Source/WebCore/svg/SVGFEConvolveMatrixElement.h:

(WebCore::SVGPropertyTraits<EdgeModeType>::fromString):

• Source/WebCore/svg/SVGFEDisplacementMapElement.h:

(WebCore::SVGPropertyTraits<ChannelSelectorType>::fromString):

• Source/WebCore/svg/SVGFEMorphologyElement.h:

(WebCore::SVGPropertyTraits<MorphologyOperatorType>::fromString):

• Source/WebCore/svg/SVGFETurbulenceElement.h:

(WebCore::SVGPropertyTraits<SVGStitchOptions>::fromString):
(WebCore::SVGPropertyTraits<TurbulenceType>::fromString):

• Source/WebCore/svg/SVGGradientElement.h:

(WebCore::SVGPropertyTraits<SVGSpreadMethodType>::fromString):

• Source/WebCore/svg/SVGMarkerTypes.h:

(WebCore::SVGPropertyTraits<SVGMarkerUnitsType>::fromString):

• Source/WebCore/svg/SVGTests.cpp:

(WebCore::SVGTests::hasFeatureForLegacyBindings):

• Source/WebCore/svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::collectPresentationalHintsForAttribute):

• Source/WebCore/svg/SVGTextContentElement.h:

(WebCore::SVGPropertyTraits<SVGLengthAdjustType>::fromString):

• Source/WebCore/svg/SVGTextPathElement.h:

(WebCore::SVGPropertyTraits<SVGTextPathMethodType>::fromString):
(WebCore::SVGPropertyTraits<SVGTextPathSpacingType>::fromString):

• Source/WebCore/svg/SVGUnitTypes.h:

(WebCore::SVGPropertyTraits<SVGUnitTypes::SVGUnitType>::fromString):

• Source/WebCore/svg/SVGZoomAndPanType.h:

(WebCore::SVGPropertyTraits<SVGZoomAndPanType>::fromString):

• Source/WebCore/svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):

• Source/WebCore/svg/properties/SVGPropertyTraits.h:

(WebCore::SVGPropertyTraits<bool>::fromString):

• Source/WebCore/testing/Internals.cpp:

(WebCore::Internals::pseudoElement):
(WebCore::Internals::setViewBaseBackgroundColor):
(WebCore::Internals::setPagination):
(WebCore::parseFindOptions):
(WebCore::Internals::countMatchesForText):
(WebCore::Internals::setOverridePreferredDynamicRangeMode):
(WebCore::taskSourceFromString):
(WebCore::Internals::hasSandboxMachLookupAccessToGlobalName):
(WebCore::Internals::hasSandboxMachLookupAccessToXPCServiceName):

• Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::createConnection):

• Source/WebCore/workers/WorkerFontLoadRequest.cpp:

(WebCore::WorkerFontLoadRequest::load):

• Source/WebCore/workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadAsynchronously):

• Source/WebCore/workers/service/server/RegistrationDatabase.cpp:

(WebCore::stringToUpdateViaCache):
(WebCore::stringToWorkerType):

• Source/WebCore/xml/DOMParser.cpp:

(WebCore::DOMParser::parseFromString):

• Source/WebCore/xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::sendBytesData):
(WebCore::XMLHttpRequest::createRequest):

• Source/WebCore/xml/XPathFunctions.cpp:

(WebCore::XPath::Function::setArguments):

• Source/WebCore/xml/XPathParser.cpp:

(WebCore::XPath::Parser::nextTokenInternal):

• Source/WebCore/xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

• Source/WebCore/xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::transformToString):

• Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::shouldAllowExternalLoad):
(WebCore::XMLDocumentParser::supportsXMLVersion):
(WebCore::externalSubsetHandler):

• Source/WebDriver/CommandResult.cpp:

(WebDriver::CommandResult::CommandResult):

• Source/WebDriver/Session.cpp:

(WebDriver::Session::newWindow):
(WebDriver::Session::isElementSelected):
(WebDriver::Session::elementClick):

• Source/WebDriver/WebDriverService.cpp:

(WebDriver::deserializeTimeouts):
(WebDriver::deserializeProxy):
(WebDriver::deserializePageLoadStrategy):
(WebDriver::deserializeUnhandledPromptBehavior):
(WebDriver::WebDriverService::validatedCapabilities const):
(WebDriver::WebDriverService::matchCapabilities const):
(WebDriver::WebDriverService::newWindow):
(WebDriver::isValidStrategy):
(WebDriver::findStrategyAndSelectorOrCompleteWithError):
(WebDriver::processNullAction):
(WebDriver::processKeyAction):
(WebDriver::processPointerMoveAction):
(WebDriver::processPointerAction):
(WebDriver::processWheelAction):
(WebDriver::processPointerParameters):
(WebDriver::processInputActionSequence):

• Source/WebDriver/glib/WebDriverServiceGLib.cpp:

(WebDriver::WebDriverService::platformSupportProxyType const):

• Source/WebDriver/gtk/WebDriverServiceGtk.cpp:

(WebDriver::WebDriverService::platformValidateCapability const):

• Source/WebDriver/socket/HTTPParser.cpp:

(WebDriver::HTTPParser::expectedBodyLength const):

• Source/WebDriver/socket/SessionHostSocket.cpp:

(WebDriver::SessionHost::parseTargetList):

• Source/WebDriver/soup/HTTPServerSoup.cpp:

(WebDriver::soupServerListen):

• Source/WebDriver/wpe/WebDriverServiceWPE.cpp:

(WebDriver::WebDriverService::platformValidateCapability const):

• Source/WebGPU/WGSLUnitTests/WGSLParserTests.mm:

(-[WGSLParserTests testParsingStruct]):
(-[WGSLParserTests testParsingGlobalVariable]):
(-[WGSLParserTests testParsingFunctionDecl]):
(-[WGSLParserTests testTrivialGraphicsShader]):

• Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:

(WebKit::ResourceLoadStatisticsStore::shouldSkip const):

• Source/WebKit/NetworkProcess/DatabaseUtilities.cpp:

(WebKit::insertDistinctValuesInTableStatement):

• Source/WebKit/NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::allowsPrivateClickMeasurementTestFunctionality const):

• Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::isCrossOriginPrefetch const):

• Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:

(WebKit::ServiceWorkerFetchTask::ServiceWorkerFetchTask):

• Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::getDirectorySize):

• Source/WebKit/NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::queryCache):
(WebKit::CacheStorage::Cache::retrieveRecords):

• Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeRetrieveDecision):
(WebKit::NetworkCache::makeStoreDecision):

• Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::Entry):

• Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::SpeculativeLoadManager::shouldRegisterLoad):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieveSubresourcesEntry):

• Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp:

(WebKit::NetworkCache::SubresourcesEntry::SubresourcesEntry):

• Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::isActingOnBehalfOfAFullWebBrowser):

• Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::shouldRedirectAsGET):

• Source/WebKit/NetworkProcess/ios/NetworkProcessIOS.mm:

(WebKit::NetworkProcess::parentProcessHasServiceWorkerEntitlement const):

• Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.cpp:

(WebKit::isValidFileName):

• Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:

(WebKit::OriginStorageManager::StorageBucket::isEmpty):

• Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb:
• Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesInternalDebugFeatures.cpp.erb:
• Source/WebKit/Shared/AuxiliaryProcess.h:
• Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:

(WebKit::AuxiliaryProcess::parentProcessHasEntitlement):
(WebKit::AuxiliaryProcess::setPreferenceValue):

• Source/WebKit/Shared/Cocoa/DefaultWebBrowserChecks.mm:

(WebKit::appBoundDomainsForTesting):
(WebKit::isParentProcessAFullWebBrowser):
(WebKit::isFullWebBrowser):

• Source/WebKit/Shared/Cocoa/XPCEndpoint.mm:

(WebKit::XPCEndpoint::XPCEndpoint):

• Source/WebKit/Shared/Cocoa/XPCEndpointClient.mm:

(WebKit::XPCEndpointClient::setEndpoint):

• Source/WebKit/Shared/Daemon/DaemonUtilities.h:
• Source/WebKit/Shared/Daemon/DaemonUtilities.mm:

(WebKit::startListeningForMachServiceConnections):

• Source/WebKit/Shared/Databases/IndexedDB/IDBUtilities.cpp:

(WebKit::uniqueDatabaseIdentifier):

• Source/WebKit/Shared/EntryPointUtilities/Cocoa/Daemon/PCMDaemonEntryPoint.mm:

(WebKit::PCMDaemonMain):

• Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
• Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::checkEntitlements):
(WebKit::XPCServiceInitializerDelegate::hasEntitlement):

• Source/WebKit/Shared/IPCTester.cpp:

(WebKit::messageTestDriver):

• Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultMediaSessionCoordinatorEnabled):

• Source/WebKit/Shared/glib/InputMethodState.cpp:

(WebKit::inputElementHasDigitsPattern):

• Source/WebKit/Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::createWebKeyboardEvent):

• Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::tryApplyCachedSandbox):
(WebKit::AuxiliaryProcess::initializeSandbox):

• Source/WebKit/UIProcess/API/C/WKMockMediaDevice.cpp:

(WKAddMockMediaDevice):

• Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setupPageConfiguration:]):

• Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm:

(-[WKWebpagePreferences _setCaptivePortalModeEnabled:]):

• Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferences.mm:

(+[_WKSystemPreferences isCaptivePortalModeEnabled]):
(+[_WKSystemPreferences setCaptivePortalModeEnabled:]):

• Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferencesInternal.h:
• Source/WebKit/UIProcess/API/glib/WebKitAutomationSession.cpp:

(parseProxyCapabilities):

• Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:

(addOriginToMap):

• Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp:

(WebKit::DropTarget::accept):

• Source/WebKit/UIProcess/ApplicationStateTracker.mm:

(WebKit::applicationType):

• Source/WebKit/UIProcess/Cocoa/MediaPermissionUtilities.mm:

(WebKit::applicationVisibleNameFromOrigin):

• Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::collectKeyboardLayoutCommandsForEvent):

• Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::DownloadProxyMap):

• Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorClient.cpp:

(WebKit::debuggableType):

• Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess):

• Source/WebKit/UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::isDisplayingMarkupDocument const):

• Source/WebKit/UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestAttachmentIcon):

• Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::networkProcessHasEntitlementForTesting):

• Source/WebKit/UIProcess/WebsiteData/WebsiteDataRecord.cpp:

(WebKit::WebsiteDataRecord::displayNameForCookieHostName):
(WebKit::WebsiteDataRecord::displayNameForOrigin):

• Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:

(WebKit::isEGLImageAvailable):

• Source/WebKit/UIProcess/gtk/Clipboard.cpp:

(WebKit::Clipboard::get):

• Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:

(WebKit::WebDataListSuggestionsDropdownGtk::handleKeydownWithIdentifier):

• Source/WebKit/UIProcess/gtk/WebDateTimePickerGtk.cpp:

(WebKit::WebDateTimePickerGtk::update):

• Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:

(applicationHasAppLinkEntitlements):

• Source/WebKit/UIProcess/ios/WKPDFView.mm:

(+[WKPDFView web_requiresCustomSnapshotting]):

• Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):

• Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:

(WebKit::WebDataListSuggestionsDropdownMac::handleKeydownWithIdentifier):
(-[WKDataListSuggestionsController moveSelectionByDirection:]):

• Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::evaluateJavaScriptCallback):

• Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:

(webkitWebPageDidReceiveMessage):

• Source/WebKit/WebProcess/Plugins/PDF/PDFPluginPasswordField.mm:

(WebKit::PDFPluginPasswordField::handleEvent):

• Source/WebKit/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::handleEvent):

• Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::getActionTypeForKeyEvent):

• Source/WebKit/WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:

(WebKit::TextCheckingControllerProxy::removeAnnotationRelativeToSelection):

• Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:

(WebKit::IPCTestingAPI::encodeArgument):

• Source/WebKit/WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::setTextDirection):

• Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::parentProcessHasServiceWorkerEntitlement const):
(WebKit::WebPage::focusedElementInformation):
(WebKit::WebPage::platformUserAgent const):

• Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::executeKeypressCommandsInternal):
(WebKit::WebPage::handleEditingKeyboardEvent):
(WebKit::WebPage::performNonEditingBehaviorForSelector):

• Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeProcess):
(WebKit::WebProcess::handlePreferenceChange):

• Source/WebKit/webpushd/PushClientConnection.h:
• Source/WebKit/webpushd/PushClientConnection.mm:

(WebPushD::ClientConnection::hostHasEntitlement):

• Source/WebKitLegacy/cf/WebCoreSupport/WebInspectorClientCF.cpp:

(WebInspectorClient::inspectorAttachDisabled):
(WebInspectorClient::inspectorStartsAttached):

• Source/WebKitLegacy/mac/Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage isQuickTimePlugIn]):

• Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm:

(selectorForKeyEvent):

• Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::transitionToCommittedForNewPage):

• Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:

(-[WebHTMLView _executeSavedKeypressCommands]):

• Source/WebKitLegacy/win/WebFrame.cpp:

(WebFrame::setTextDirection):
(WebFrame::canProvideDocumentSource):

• Tools/DumpRenderTree/win/DumpRenderTree.cpp:

(runTest):

• Tools/TestWebKitAPI/Tests/WTF/AtomString.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WTF/JSONValue.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.cpp:

(TEST):

• Tools/TestWebKitAPI/Tests/WTF/cocoa/TextStreamCocoa.mm:

(TEST):

• Tools/TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WebCore/FontShadowTests.cpp:

(TestWebKitAPI::TEST_F):

• Tools/TestWebKitAPI/Tests/WebCore/LineBreaking.mm:

(breakingLocationsFromICU):

• Tools/TestWebKitAPI/Tests/WebCore/NowPlayingInfoTests.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:

(TestWebKitAPI::TEST_F):

• Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:

(TestWebKitAPI::TEST_F):

• Tools/TestWebKitAPI/Tests/WebCore/StringWithDirection.cpp:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WebKit/MediaSessionCoordinatorTest.mm:

(TestWebKitAPI::TEST_F):

• Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:

(TEST_F):

• Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:

(TEST):

• Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:

(TestWebKitAPI::TEST):

• Tools/TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(TEST):

• Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:

(-[SyncScheme webView:startURLSchemeTask:]):

• Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::dumpErrorDescriptionSuitableForTestResult):

• Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:

(WTR::attributesOfElement):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::isPressActionSupported):

• Tools/WebKitTestRunner/TestController.cpp:

(WTR::TestController::setPluginSupportedMode):

• Tools/WebKitTestRunner/cocoa/CrashReporterInfo.mm:

(WTR::testPathFromURL):

• Tools/WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:

(WTR::UIScriptControllerCocoa::overridePreference):

• Tools/WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:

(WTR::UIScriptControllerGtk::overridePreference):

Canonical link: ​https://commits.webkit.org/251316@main

8:30 PM Changeset in webkit [295269] by timothy_horton@apple.com

• 10 edits
  1 copy in trunk

Force Repaint menu item does not repaint compositing layers, only tiles
​https://bugs.webkit.org/show_bug.cgi?id=241292

Reviewed by Simon Fraser.

• Source/WebCore/page/Page.h:
• Source/WebCore/page/Page.cpp:

(WebCore::Page::forceRepaintAllFrames):
Move forceRepaint to Page, and use repaintViewAndCompositedLayers instead of
TiledBacking::forceRepaint, so we hit all the compositing layers, not just the tiles.

• Source/WebCore/platform/graphics/TiledBacking.h:
• Source/WebCore/platform/graphics/ca/TileController.cpp:

(WebCore::TileController::forceRepaint): Deleted.

• Source/WebCore/platform/graphics/ca/TileController.h:
• Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp:

Get rid of this unused method.

• Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::forceRepaint):

• Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::forceRepaint):
Adopt forceRepaintAllFrames.

• LayoutTests/fast/images/async-image-multiple-clients-repaint-expected.txt:
• LayoutTests/platform/ios/fast/images/async-image-multiple-clients-repaint-expected.txt
• LayoutTests/platform/win/fast/images/async-image-multiple-clients-repaint-expected.txt

Rebaseline this test, except on Windows.

Canonical link: ​https://commits.webkit.org/251315@main

1:59 PM Changeset in webkit [295268] by Chris Dumez

• 11 edits in trunk/Source

Tweak HTMLToken / AtomHTMLToken data members for better packing
​https://bugs.webkit.org/show_bug.cgi?id=241293

Reviewed by Darin Adler.

Tweak HTMLToken / AtomHTMLToken data members for better packing. Also use
Span<> more.

• Source/WTF/wtf/text/StringView.h:
• Source/WTF/wtf/text/WTFString.h:
• Source/WebCore/html/parser/AtomHTMLToken.h:

(WebCore::AtomHTMLToken::hasDuplicateAttribute const):
(WebCore::AtomHTMLToken::name const):
(WebCore::AtomHTMLToken::setName):
(WebCore::AtomHTMLToken::selfClosing const):
(WebCore::AtomHTMLToken::attributes):
(WebCore::AtomHTMLToken::attributes const):
(WebCore::AtomHTMLToken::characters const):
(WebCore::AtomHTMLToken::charactersIsAll8BitData const):
(WebCore::AtomHTMLToken::comment const):
(WebCore::AtomHTMLToken::comment):
(WebCore::AtomHTMLToken::forceQuirks const):
(WebCore::AtomHTMLToken::publicIdentifier const):
(WebCore::AtomHTMLToken::initializeAttributes):
(WebCore::AtomHTMLToken::AtomHTMLToken):
(WebCore::AtomHTMLToken::charactersLength const): Deleted.

• Source/WebCore/html/parser/HTMLConstructionSite.cpp:

(WebCore::setAttributes):
(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::createElementFromSavedToken):

• Source/WebCore/html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):

• Source/WebCore/html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):

• Source/WebCore/html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):

• Source/WebCore/html/parser/HTMLToken.h:

(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::makeEndOfFile):
(WebCore::HTMLToken::name const):
(WebCore::HTMLToken::appendToName):
(WebCore::HTMLToken::setForceQuirks):
(WebCore::HTMLToken::beginDOCTYPE):
(WebCore::HTMLToken::setPublicIdentifierToEmptyString):
(WebCore::HTMLToken::setSystemIdentifierToEmptyString):
(WebCore::HTMLToken::appendToPublicIdentifier):
(WebCore::HTMLToken::appendToSystemIdentifier):
(WebCore::HTMLToken::selfClosing const):
(WebCore::HTMLToken::setSelfClosing):
(WebCore::HTMLToken::beginStartTag):
(WebCore::HTMLToken::beginEndTag):
(WebCore::HTMLToken::beginAttribute):
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::HTMLToken::appendToAttributeValue):
(WebCore::HTMLToken::attributes const):
(WebCore::HTMLToken::characters const):
(WebCore::HTMLToken::charactersIsAll8BitData const):
(WebCore::HTMLToken::appendToCharacter):
(WebCore::HTMLToken::comment const):
(WebCore::HTMLToken::commentIsAll8BitData const):
(WebCore::HTMLToken::beginComment):
(WebCore::HTMLToken::appendToComment):
(WebCore::HTMLToken::HTMLToken): Deleted.

• Source/WebCore/html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::saveEndTagNameIfNeeded):
(WebCore::HTMLTokenizer::haveBufferedCharacterToken const):

• Source/WebCore/html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
(WebCore::HTMLTreeBuilder::processToken):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndOfFileForInTemplateContents):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::insertPhoneNumberLink):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):

• Source/WebCore/html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

Canonical link: ​https://commits.webkit.org/251314@main

11:32 AM Changeset in webkit [295267] by Ryan Haddad

• 2 edits in trunk/Tools/CISupport/build-webkit-org

Temporarily disable lldb-webkit-test on Monterey
​https://bugs.webkit.org/show_bug.cgi?id=241294

Reviewed by Aakash Jain.

Temporarily disable lldb-webkit-test on Monterey until webkit.org/b/239463
can be resolved or worked around.

• Tools/CISupport/build-webkit-org/factories.py:

(TestFactory.init):

• Tools/CISupport/build-webkit-org/factories_unittest.py:

(TestExpectedBuildSteps):

Canonical link: ​https://commits.webkit.org/251313@main

7:26 AM Changeset in webkit [295266] by Alan Bujtas

• 2 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Add basic 'flex-wrap: wrap' support
​https://bugs.webkit.org/show_bug.cgi?id=241300

Reviewed by Antti Koivisto.

1. compute wrap positions by simply checking for overflow as walking the flex item list.
2. let each function operate on the range instead of the entire list.

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::computeWrappingPositions const):
(WebCore::Layout::FlexLayout::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexLayout::alignFlexItems):
(WebCore::Layout::FlexLayout::justifyFlexItems):
(WebCore::Layout::FlexLayout::layout):

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:

Canonical link: ​https://commits.webkit.org/251312@main

7:01 AM Changeset in webkit [295265] by ntim@apple.com

• 5 edits
  3 adds
  1 delete in trunk

[IFC] Support text-align-last: justify
​https://bugs.webkit.org/show_bug.cgi?id=241301
<rdar://94384891>

Reviewed by Alan Bujtas.

text-align: justify already worked for the legacy line layout, but not in IFC. Add support for it and a corresponding WPT.

Also removed text-justify: none handling from legacy line layout, since IFC doesn't handle it, and legacy line layout also doesn't handle it correctly either. Thankfully text-justify is disabled by default.

• LayoutTests/TestExpectations:
• LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify-expected.html: Removed.
• LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html: Removed.

Removed tests that were wrong, compared with other browsers to verify.

• LayoutTests/imported/w3c/resources/resource-files.json:
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-expected.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-ref.html: Added.
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last.html: Added.

WPT is from Blink: ​https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/fast/css3-text/css3-text-align-last/text-align-last.html;drc=77578ccb4082ae20a9326d9e673225f1189ebb63

Upstream WPT PR: ​https://github.com/web-platform-tests/wpt/pull/34308

• Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:

(WebCore::Layout::Line::applyRunExpansion):

• Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::close):

• Source/WebCore/rendering/LegacyLineLayout.cpp:

(WebCore::LegacyLineLayout::textAlignmentForLine const):

Canonical link: ​https://commits.webkit.org/251311@main

6:23 AM Changeset in webkit [295264] by Antti Koivisto

• 3 edits in trunk

Update query container layout unconditionally when ancestor style changes
​https://bugs.webkit.org/show_bug.cgi?id=241302

Reviewed by Alan Bujtas.

In some cases we incorrectly optimize away the layout.

• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/display-none-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-004-expected.txt:
• Source/WebCore/style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveComposedTree):

Do the query container update even when shouldIterateChildren is false. While there is no reason to iterate children
now there may be after the query container layout has been updated.

Canonical link: ​https://commits.webkit.org/251310@main

5:48 AM Changeset in webkit [295263] by Alan Bujtas

• 3 edits in trunk/Source/WebCore/layout/formattingContexts/flex

Introduce LineRange to be able to layout just a subset
​https://bugs.webkit.org/show_bug.cgi?id=241299

Reviewed by Antti Koivisto.

This is in preparation for supporting flex-wrap: wrap.
LineRange keeps track of the flex items associated with the current line. In case of no-wrap, the range is [0, number of flex items].

• Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace): This is already coming in as logical.

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::computeAvailableLogicalVerticalSpace const):
(WebCore::Layout::FlexLayout::computeAvailableLogicalHorizontalSpace const):
(WebCore::Layout::FlexLayout::computeWrappingPositions const):
(WebCore::Layout::FlexLayout::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexLayout::alignFlexItems):
(WebCore::Layout::FlexLayout::justifyFlexItems):
(WebCore::Layout::FlexLayout::layout):

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:

Canonical link: ​https://commits.webkit.org/251309@main

5:45 AM Changeset in webkit [295262] by Darin Adler

• 9 edits in trunk/Source/WebCore/html/parser

Try moving HTMLStackItem in the HTML parser instead of using reference counting
​https://bugs.webkit.org/show_bug.cgi?id=240700

Reviewed by Chris Dumez.

A/B testing indicates that this is performance neutral on Speedometer
on an Apple Silicon Mac, and a 0.23% speedup on an Intel Mac. On that basis,
this simplfication seems worth doing.

• Source/WebCore/html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML): Use constructor
instead of create function.
(WebCore::HTMLConstructionSite::insertHTMLHeadElement): Ditto.
(WebCore::HTMLConstructionSite::insertHTMLBodyElement): Ditto.
(WebCore::HTMLConstructionSite::insertHTMLFormElement): Ditto.
(WebCore::HTMLConstructionSite::insertHTMLElement): Ditto.
(WebCore::HTMLConstructionSite::insertHTMLElementOrFindCustomElementInterface): Ditto.
(WebCore::HTMLConstructionSite::insertCustomElement): Ditto.
(WebCore::HTMLConstructionSite::insertFormattingElement): Ditto.
(WebCore::HTMLConstructionSite::insertScriptElement): Ditto.
(WebCore::HTMLConstructionSite::insertForeignElement): Ditto.
(WebCore::HTMLConstructionSite::insertAlreadyParsedChild): Ditto.
(WebCore::HTMLConstructionSite::takeAllChildrenAndReparent): Ditto.
(WebCore::HTMLConstructionSite::createElementFromSavedToken): Ditto.
(WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements): Ditto.

• Source/WebCore/html/parser/HTMLConstructionSite.h: Changed return value

to be HTMLStackItem instead of Ref<HTMLStackItem> and changed headStackItem
to return HTMLStackItem&. Since HTMLStackItem now has a null value it does
not need to be a pointer.

• Source/WebCore/html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::ElementRecord::ElementRecord): Take an HTMLStackItem&&
instead of a Ref<HTMLStackItem>&&.
(WebCore::HTMLElementStack::ElementRecord::replaceElement): Ditto.
(WebCore::HTMLElementStack::pushRootNode): Ditto.
(WebCore::HTMLElementStack::pushHTMLHtmlElement): Ditto.
(WebCore::HTMLElementStack::pushRootNodeCommon): Ditto.
(WebCore::HTMLElementStack::pushHTMLHeadElement): Ditto.
(WebCore::HTMLElementStack::pushHTMLBodyElement): Ditto.
(WebCore::HTMLElementStack::push): Ditto.
(WebCore::HTMLElementStack::insertAbove): Ditto.
(WebCore::HTMLElementStack::pushCommon): Ditto.

• Source/WebCore/html/parser/HTMLElementStack.h: Updated for the above changes,

and changed the ElementRecord class to use HTMLStackItem. Maybe eventually we
could figure out how to optimize further by using a data structure other than
a singly linked list, to avoid having to allocate a memory block each time we
create one of these. Or at least find a way to recycle as we push and pop.

• Source/WebCore/html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::closestElementInScopeWithName): Update
to use the reference instead of pointer.
(WebCore::HTMLFormattingElementList::swapTo): Take an HTMLStackItem&&
instead of a Ref<HTMLStackItem>&&. Also added a missing WTFMove in one case.
(WebCore::HTMLFormattingElementList::append): Ditto.
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
Changed to use a return value instead of an out argument.
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition): Updated
for the above and tweaked formatting a bit.

• Source/WebCore/html/parser/HTMLFormattingElementList.h: Changed Entry

to store a HTMLStackItem instead of a RefPtr<HTMLStackItem>. Also
updated for the above.

• Source/WebCore/html/parser/HTMLStackItem.h: Changed HTMLStackItem to

no longer derive from RefCounted. Got rid of the create functions and
replaced them with use of the constructor. Added a default constructor
and a null value. Added an elementOrNull function that is handy for Entry.
Removed the slightly peculiar double-const-ness of this class. We can
probably use const HTMLStackItem more; every member function is const.

• Source/WebCore/html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Use HTMLStackItem constructor
instead of the create function.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): Ditto.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement): Removed const.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElementStackItem): Ditto.
(WebCore::HTMLTreeBuilder::processStartTag): Updated since headStackItem is a reference.
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): Ditto.
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency): Ditto.
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): Ditto.
(WebCore::HTMLTreeBuilder::adjustedCurrentStackItem): Ditto.

• Source/WebCore/html/parser/HTMLTreeBuilder.h: Updated for the above.

Canonical link: ​https://commits.webkit.org/251308@main

3:12 AM Changeset in webkit [295261] by jh718.park@samsung.com

• 1 edit in trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp

Unreviewed. Fix the build warning below since r295039.

warning: variable ‘accumulatedWidth’ set but not used [-Wunused-but-set-variable]

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):

1:30 AM Changeset in webkit [295260] by Nikos Mouchtaris

• 1 edit in trunk/Source/WebCore/platform/graphics/filters/FilterImage.cpp

Add checks for overflow in FilterImage::copyImageBytes
​https://bugs.webkit.org/show_bug.cgi?id=241296
<rdar://89744102>

Reviewed by Said Abou-Hallawa.

Add overflow checks to copyImageBytes functions in FilterImage class.

• Source/WebCore/platform/graphics/filters/FilterImage.cpp:

(WebCore::copyImageBytes):

Canonical link: ​https://commits.webkit.org/251306@main

Jun 3, 2022:

7:17 PM Changeset in webkit [295259] by Elliott Williams

• 1 edit in trunk/Source/WebKit/Configurations/BaseTarget.xcconfig

Fix WebKit's PROFILE_DATA_PATH in internal release builds
​https://bugs.webkit.org/show_bug.cgi?id=241297

Reviewed by Wenson Hsieh.

WebKit's PROFILE_DATA_PATH_INTERNAL_YES was missing WebKitAdditions/
in its path name. Just a typo here, WebCore and JavaScriptCore have
correct paths.

• Source/WebKit/Configurations/BaseTarget.xcconfig:

Canonical link: ​https://commits.webkit.org/251305@main

7:09 PM Changeset in webkit [295258] by ysuzuki@apple.com

• 2 edits
  1 add in trunk

[WTF] Handle "at" in Date parse heuristics to make Date picker work in CNBC.com
​https://bugs.webkit.org/show_bug.cgi?id=241258
rdar://93920424

Reviewed by Darin Adler.

AppleICU changes Intl.DateTimeFormat's formatting result to align it to Apple HI. But we
observed regression in CNBC.com since it reparses Intl.DateTimeFormat's string with Date
constructor.

Strictly speaking, there is no guarantee that code works. Date constructor's parsing
is implementation-dependent, and the spec does not require that Intl.DateTimeFormat's output
should be accepted by Date constructor. And this works only for English case anyway even before
this AppleICU change: if date is formatted via ja-JP, then Date constructor does not accept it.
But previously, this English case was working by chance, but now, new ICU format inserts "at"
in the string, and it makes that string unaccepted in Date constructor.

To workaround this web-compatibility issue, we extend our Date parsing heuristics to
accept "at". This is OK since the goal of this heuristics is accepting wider range of date
strings. Also it is OK that accepting English word "at" since this heuristics already handle
weekday and month names in English.

• JSTests/complex.yaml:
• JSTests/complex/intl-date-time-format-date-parse.js: Added.

(shouldBe):

• Source/WTF/wtf/DateMath.cpp:

(WTF::parseDateFromNullTerminatedCharacters):

Canonical link: ​https://commits.webkit.org/251304@main

6:10 PM Changeset in webkit [295257] by Alan Coon

• 1 copy in tags/WebKit-7614.1.14.10.11

Tag WebKit-7614.1.14.10.11.

6:06 PM Changeset in webkit [295256] by Alan Coon

• 9 edits in branches/safari-7614.1.14.10-branch/Source

Versioning.

WebKit-7614.1.14.10.11

5:30 PM Changeset in webkit [295255] by Devin Rousso

• 27 edits in trunk/Source

Web Inspector: remove unused InspectorFrontendHost attributes and methods
​https://bugs.webkit.org/show_bug.cgi?id=241291

Reviewed by Patrick Angle.

• Source/WebCore/inspector/InspectorFrontendHost.idl:
• Source/WebCore/inspector/InspectorFrontendHost.h:
• Source/WebCore/inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::port const): Deleted.
(WebCore::InspectorFrontendHost::append): Deleted.
(WebCore::InspectorFrontendHost::close): Deleted.

• Source/WebCore/inspector/InspectorFrontendClient.h:

• Source/WebCore/inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::append): Deleted.

• Source/WebKit/WebProcess/Inspector/WebInspectorUI.messages.in:
• Source/WebKit/WebProcess/Inspector/WebInspectorUI.h:
• Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::didSave): Deleted.
(WebKit::WebInspectorUI::append): Deleted.
(WebKit::WebInspectorUI::didAppend): Deleted.

• Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in:
• Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h:
• Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp:

(WebKit::WebInspectorUIProxy::append): Deleted.
(WebKit::WebInspectorUIProxy::platformAppend): Deleted.

• Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp:

(WebKit::fileReplaceContentsCallback):
(WebKit::WebInspectorUIProxy::platformAppend): Deleted.

• Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:

(WebKit::WebInspectorUIProxy::platformSave):
(WebKit::WebInspectorUIProxy::platformAppend): Deleted.

• Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp:

(WebKit::WebInspectorUIProxy::platformAppend): Deleted.

• Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.messages.in:
• Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h:
• Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::didSave): Deleted.
(WebKit::RemoteWebInspectorUI::didAppend): Deleted.
(WebKit::RemoteWebInspectorUI::append): Deleted.

• Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.messages.in:
• Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.h:
• Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.cpp:

(WebKit::RemoteWebInspectorUIProxy::append): Deleted.
(WebKit::RemoteWebInspectorUIProxy::platformAppend): Deleted.

• Source/WebKit/UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp:

(WebKit::remoteFileReplaceContentsCallback):
(WebKit::RemoteWebInspectorUIProxy::platformAppend): Deleted.

• Source/WebKit/UIProcess/Inspector/mac/RemoteWebInspectorUIProxyMac.mm:

(WebKit::RemoteWebInspectorUIProxy::platformSave):
(WebKit::RemoteWebInspectorUIProxy::platformAppend): Deleted.

• Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp:

(WebKit::RemoteWebInspectorUIProxy::platformAppend): Deleted.

• Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h:
• Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append): Deleted.

• Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorFrontendClient::append): Deleted.

• Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.savedURL): Deleted.
(InspectorFrontendAPI.appendedToURL): Deleted.

Canonical link: ​https://commits.webkit.org/251303@main

4:59 PM Changeset in webkit [295254] by sihui_liu@apple.com

• 1 edit in trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm

Regression (r294405): missing tiles during scrolling after foregrounding app
​https://bugs.webkit.org/show_bug.cgi?id=241280

Reviewed by Chris Dumez.

Partially revert r294405 to disable ProcessStateMonitor that can make UI process fail to take foreground assertion after
app is foregrounded.

• Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKProcessAssertionBackgroundTaskManager init]):
(-[WKProcessAssertionBackgroundTaskManager _releaseBackgroundTask]):

Canonical link: ​https://commits.webkit.org/251302@main

4:55 PM Changeset in webkit [295253] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore/platform/graphics/avfoundation/objc

[Cocoa][MSE] Frames are displayed "fast forward" during seek operations
​https://bugs.webkit.org/show_bug.cgi?id=241234
<rdar://89387951>

Reviewed by Eric Carlson.

When MSE was moved into the GPU process, certain operations that used to be synchronous became
async. This includes seek operations, where the seek request is initiated by the HTMLMediaElement,
async dispatched to the MediaPlayer in the GPU process, and then async dispatched back to the
WebContent process and MediaSource. Immediately prior to this last dispatch, the
SourceBufferPrivateAVFObjC flushes its sample buffer renderers, and during the subsequent async
portion there is an opportunity for the sample buffers to request new data. When that request
occurs before the response to the async dispatch, incorrect samples (future samples from the
previous playback location) are enqueued. These are then flushed again during the async response,
and replaced by correct samples.

Add a new ivar to SourceBufferPrivateAVFObjC that tracks this state, blocking enqueing new samples
while there is a pending seek operation.

• Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
• Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::willSeek):
(WebCore::SourceBufferPrivateAVFObjC::seekToTime):
(WebCore::SourceBufferPrivateAVFObjC::isSeeking const):

Canonical link: ​https://commits.webkit.org/251300@main

4:54 PM Changeset in webkit [295252] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations

[Gardening]: [ Monterey wk2 release ] imported/w3c/web-platform-tests/content-security-policy/inheritance/blob-url-inherits-from-initiator.sub.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=239307
<rdar://91719197>

Unreviewed test gardening.

• LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/251300@main

4:49 PM Changeset in webkit [295251] by Devin Rousso

• 1 edit in trunk/LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html

[ Mac ] http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html is a flaky text failure
​https://bugs.webkit.org/show_bug.cgi?id=239091
<rdar://problem/91594397>

Unreviewed test fix.

• LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html:

Only listen for "webkitfullscreenchange" once in case the <video> exiting fullscreen somehow
happens before the test fully finishes.

Canonical link: ​https://commits.webkit.org/251299@main

4:45 PM Changeset in webkit [295250] by mmaxfield@apple.com

• 4 edits
  2 adds in trunk

[Cocoa] Mail compose doesn't use Bulgarian letter forms when the system language is set to Bulgarian
​https://bugs.webkit.org/show_bug.cgi?id=241253
<rdar://problem/94295531>

Reviewed by Cameron McCormack.

Mail compose doesn't set lang, which causes us to have a null locale string.
String::createCFString() transforms a null string to CFSTR(""), which indicates to Core Text
that it shouldn't use the shaping from the system language. Instead, if the locale string
is null, we should give Core Text a null locale string, so they use the correct shaping.

• LayoutTests/TestExpectations:
• LayoutTests/fast/text/bulgarian-system-language-shaping-expected-mismatch.html: Added.
• LayoutTests/fast/text/bulgarian-system-language-shaping.html: Added.
• LayoutTests/platform/ios/TestExpectations:
• LayoutTests/platform/mac/TestExpectations:
• Source/WebCore/platform/graphics/coretext/FontCoreText.cpp:

(WebCore::Font::applyTransforms const):

Canonical link: ​https://commits.webkit.org/251298@main

4:39 PM Changeset in webkit [295249] by Alan Coon

• 1 copy in tags/WebKit-7613.3.3

Tag WebKit-7613.3.3.

4:38 PM Changeset in webkit [295248] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations

[Gardening]: [ macOS Debug wk2 EWS ] fast/animation/request-animation-frame-throttling-lowPowerMode.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=241289
<rdar://94371800>

Unreviewed test gardening.

• LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/251297@main

4:24 PM Changeset in webkit [295247] by Chris Dumez

• 2 edits in trunk/Source/WebCore/html/parser

Optimize HTMLToken::appendToAttributeValue()
​https://bugs.webkit.org/show_bug.cgi?id=241274

Reviewed by Darin Adler.

Optimize HTMLToken::appendToAttributeValue() by appending all characters at
once instead of one by one.

• Source/WebCore/html/parser/HTMLToken.h:

(WebCore::HTMLToken::appendToAttributeValue):

• Source/WebCore/html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::processToken):

Canonical link: ​https://commits.webkit.org/251296@main

4:22 PM Changeset in webkit [295246] by Russell Epstein

• 18 edits in branches/safari-613-branch

Revert 57e001f8c81440562b765975b7ae2b633c8bc66d. rdar://problem/88904160

This reverts commit 57e001f8c81440562b765975b7ae2b633c8bc66d.

4:21 PM Changeset in webkit [295245] by Russell Epstein

• 5 edits in branches/safari-613-branch/Source/WebKit

Revert 637d98e55c078fde1b8a5f7cff22da2cfda99187. rdar://problem/88904160

This reverts commit 637d98e55c078fde1b8a5f7cff22da2cfda99187.

4:21 PM Changeset in webkit [295244] by Russell Epstein

• 4 edits in branches/safari-613-branch

Revert afffb32a8971addf23e6b2cea93a52cbb6199e54. rdar://problem/92015599

This reverts commit afffb32a8971addf23e6b2cea93a52cbb6199e54.

4:21 PM Changeset in webkit [295243] by Russell Epstein

• 5 edits in branches/safari-613-branch

Revert 704644f751c332c5b1001936cf2cd0446f4bea18. rdar://problem/92380002

This reverts commit 704644f751c332c5b1001936cf2cd0446f4bea18.

4:21 PM Changeset in webkit [295242] by Russell Epstein

• 4 edits in branches/safari-613-branch/Source/WebKit

Revert a56ea95c510fc523f36e6f179f2e6a9763418f4e. rdar://problem/88904160

This reverts commit a56ea95c510fc523f36e6f179f2e6a9763418f4e.

4:21 PM Changeset in webkit [295241] by Russell Epstein

• 1 edit in branches/safari-613-branch/Source/WebCore/editing/BreakBlockquoteCommand.cpp

Unreviewed build fix. rdar://14839536

./editing/BreakBlockquoteCommand.cpp:29:10: fatal error: 'CommonAtomStrings.h' file not found

4:09 PM Changeset in webkit [295240] by Devin Rousso

• 58 edits
  3 copies in trunk

Web Inspector: replace the two "Export Audit" and "Export Result" buttons with a single button that has a picker in the NSSavePanel
​https://bugs.webkit.org/show_bug.cgi?id=241214
<rdar://problem/76775840>

Reviewed by Patrick Angle.

It's odd to have only one "Import" button but two "Export *" buttons in the Audits Tab, Graphics Tab,
etc. Ideally, there'd be just one "Export" button that lets the developer choose what kind of data
to save (i.e. all formats are provided up front, and the developer picks what's actually used).

• Source/WebInspectorUI/UserInterface/Base/FileUtilities.js:

(WI.FileUtilities.canSave): Added.
(WI.FileUtilities.async save): Added.
(WI.FileUtilities.save): Deleted.

• Source/WebCore/inspector/InspectorFrontendHost.idl:
• Source/WebCore/inspector/InspectorFrontendHost.h:
• Source/WebCore/inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canSave):
(WebCore::InspectorFrontendHost::save):
Introduce a new SaveMode that's used to both check for multi-format saving support and indicate
that a particular save operation has multiple formats. Always require an array of SaveData to be
provided when saving, but only expect a single item when the save operation is not multi-format.

• Source/WebInspectorUI/UserInterface/Base/Main.js:

(WI._contextMenuRequested):
(WI._updateDownloadTabBarButton):
(WI._save):
(WI._saveAs):
(WI.archiveMainFrame):
(WI.canArchiveMainFrame):

• Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js:

(WI.AuditManager.prototype.export):
(WI.AuditManager.prototype.export.dataForObject): Added.

• Source/WebInspectorUI/UserInterface/Debug/ProtocolTrace.js:

(WI.ProtocolTrace.prototype.get saveMode): Added.

• Source/WebInspectorUI/UserInterface/Models/TimelineRecording.js:

(WI.TimelineRecording.prototype.get exportMode): Added.
(WI.TimelineRecording.prototype.canExport):

• Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js:

(WI.AuditTestContentView):
(WI.AuditTestContentView.prototype.get navigationItems):
(WI.AuditTestContentView.prototype.get supportsSave):
(WI.AuditTestContentView.prototype.get saveMode): Added.
(WI.AuditTestContentView.prototype.get saveData):
(WI.AuditTestContentView.prototype._export): Added.
(WI.AuditTestContentView.prototype._updateExportNavigationItems):
(WI.AuditTestContentView.prototype._handleExportTestButtonNavigationItemClicked):
(WI.AuditTestContentView.prototype._handleExportResultButtonNavigationItemClicked):
(WI.AuditTestContentView.prototype._handleExportButtonNavigationItemClicked): Added.
(WI.AuditTestContentView.prototype._exportResult): Deleted.

• Source/WebInspectorUI/UserInterface/Views/AuditTreeElement.js:

(WI.AuditTreeElement.prototype.populateContextMenu):

• Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js:

(WI.ClusterContentView.prototype.get supportsSave):
(WI.ClusterContentView.prototype.get saveMode): Added.
(WI.ClusterContentView.prototype.get saveData):

• Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:

(WI.ConsoleMessageView.prototype._handleContextMenu):

• Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForSourceCode):

• Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView.prototype.get saveMode): Added.

• Source/WebInspectorUI/UserInterface/Views/HeapSnapshotContentView.js:

(WI.HeapSnapshotContentView):
(WI.HeapSnapshotContentView.prototype._exportSnapshot):

• Source/WebInspectorUI/UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.get saveMode): Added.
(WI.LogContentView.prototype._handleContextMenuEvent):

• Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.get saveMode): Added.
(WI.NetworkTableContentView.prototype._canExportHAR):
(WI.NetworkTableContentView.prototype._exportHAR):

• Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView):
(WI.RecordingContentView.prototype.get supportsSave):
(WI.RecordingContentView.prototype.get saveMode): Added.
(WI.RecordingContentView.prototype.get saveData):
(WI.RecordingContentView.prototype._export): Added.
(WI.RecordingContentView.prototype._exportRecording):
(WI.RecordingContentView.prototype._exportReduction):
(WI.RecordingContentView.prototype._updateExportButton):
(WI.RecordingContentView.prototype._handleExportNavigationItemClicked):

• Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView.prototype.get saveMode): Added.

• Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js:

(WI.ScriptContentView.prototype.get saveMode): Added.

• Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:

(WI.ShaderProgramContentView):
(WI.ShaderProgramContentView.prototype.get supportsSave):
(WI.ShaderProgramContentView.prototype.get saveMode): Added.
(WI.ShaderProgramContentView.prototype.get saveData):

• Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._save):

• Source/WebInspectorUI/UserInterface/Views/TextContentView.js:

(WI.TextContentView.prototype.get saveMode):

• Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView.prototype.get saveData):

• Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView.prototype.get saveMode):
(WI.TimelineRecordingContentView.prototype._exportTimelineRecording):
Indicate the kind of SaveMode that's used. When multi-format is supported, use it to unify the
export buttons (if applicable). Also make sure to only enable the export button(s) if the desired
SaveMode is supported.

• Source/WebKit/WebProcess/Inspector/WebInspectorUI.h:
• Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::save):
(WebKit::WebInspectorUI::canSave):

• Source/WebKit/WebProcess/Inspector/gtk/WebInspectorUIGtk.cpp:

(WebKit::WebInspectorUI::canSave):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const): Deleted.

• Source/WebKit/WebProcess/Inspector/mac/WebInspectorUIMac.mm:

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL const):
(WebKit::webInspectorUILocalizedStringsURL): Deleted.
(WebKit::RemoteWebInspectorUI::localizedStringsURL const): Deleted.

• Source/WebKit/WebProcess/Inspector/win/WebInspectorUIWin.cpp:

(WebKit::WebInspectorUI::canSave):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const): Deleted.

• Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h:
• Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::save):
(WebKit::RemoteWebInspectorUI::canSave): Added.
(WebKit::RemoteWebInspectorUI::canLoad): Added.

• Source/WebKit/WebProcess/Inspector/gtk/RemoteWebInspectorUIGtk.cpp: Added.

(WebKit::RemoteWebInspectorUI::canSave):
(WebKit::RemoteWebInspectorUI::canLoad):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const):

• Source/WebKit/WebProcess/Inspector/mac/RemoteWebInspectorUIMac.mm: Added.

(WebKit::RemoteWebInspectorUI::canSave):
(WebKit::RemoteWebInspectorUI::canLoad):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const):

• Source/WebKit/WebProcess/Inspector/win/RemoteWebInspectorUIWin.cpp: Added.

(WebKit::RemoteWebInspectorUI::canSave):
(WebKit::RemoteWebInspectorUI::canLoad):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const):
Currently, macOS supports both single and multi-format saving, GTK supports single format saving,
and windows supports neither.
Drive-by: Add RemoteWebInspectorProxy* files for each platform instead of shoving the code into

the related WebInspectorProxy* (of the same platform).

• Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.messages.in:
• Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.h:
• Source/WebKit/UIProcess/Inspector/WebInspectorUIProxy.cpp:

(WebKit::WebInspectorUIProxy::save):
(WebKit::WebInspectorUIProxy::platformSave):

• Source/WebKit/UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp:

(WebKit::WebInspectorUIProxy::platformSave):

• Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:

(-[WKWebInspectorUISaveController initWithSaveDatas:savePanel:]): Added.
(-[WKWebInspectorUISaveController content]): Added.
(-[WKWebInspectorUISaveController base64Encoded]): Added.
(-[WKWebInspectorUISaveController _updateSavePanel]): Added.
(-[WKWebInspectorUISaveController _popUpButtonAction:]): Added.
(WebKit::WebInspectorUIProxy::showSavePanel):
(WebKit::WebInspectorUIProxy::platformSave): Added.

• Source/WebKit/UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp:

(WebKit::WebInspectorUIProxy::platformSave):

• Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.messages.in:
• Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.h:
• Source/WebKit/UIProcess/Inspector/RemoteWebInspectorUIProxy.cpp:

(WebKit::RemoteWebInspectorUIProxy::save):
(WebKit::RemoteWebInspectorUIProxy::platformSave):

• Source/WebKit/UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp:

(WebKit::RemoteWebInspectorUIProxy::platformSave):

• Source/WebKit/UIProcess/Inspector/mac/RemoteWebInspectorUIProxyMac.mm:

(WebKit::RemoteWebInspectorUIProxy::platformSave):

• Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp:

(WebKit::RemoteWebInspectorUIProxy::platformSave):
On macOS, create a shared function to show a NSSavePanel with an accessoryView that lets the
developer choose which format to save with. On GTK, there should only ever be a single SaveData
provided (since GTK only supports single format saving), so use that.

• Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h:
• Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::canSave):
(WebInspectorFrontendClient::save):

• Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorFrontendClient::save):
WK1 only supports single format saving, meaning that there should only ever be a single SaveData
provided, so use that.

• Source/WebCore/inspector/InspectorFrontendClient.h:

(WebCore::InspectorFrontendClient::SaveData::encode const):
(WebCore::InspectorFrontendClient::SaveData::decode):
IPC stuff.

• Source/WebCore/inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::canSave):
(WebCore::InspectorFrontendClientLocal::save):
Testing code doesn't (need to) know how to save things.

• Source/WebInspectorUI/UserInterface/Base/URLUtilities.js:

(WI.urlWithoutExtension): Added.

• LayoutTests/inspector/unit-tests/url-utilities.html:
• LayoutTests/inspector/unit-tests/url-utilities-expected.txt:

Drive-by: Added a utility method to help in a console.assert.

• Source/WebCore/en.lproj/Localizable.strings:
• Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
• Source/WebKit/PlatformWin.cmake:
• Source/WebKit/SourcesCocoa.txt:
• Source/WebKit/SourcesGTK.txt:
• Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: ​https://commits.webkit.org/251295@main

3:29 PM Changeset in webkit [295239] by commit-queue@webkit.org

• 3 edits
  2 deletes in trunk

Properly implement text-align-last in legacy layout engine and IFC
​https://bugs.webkit.org/show_bug.cgi?id=241050

Patch by Kiet Ho <Kiet Ho> on 2022-06-03
Reviewed by Alan Bujtas.

The alignment of the last line in a block always follows the alignment specified
by text-align-last. However, the legacy layout engine currently follows the old
spec, where text-align-last only takes effect when text-align was 'justify' (see [1]
where this was changed), and IFC does not honor text-align-last at all. Fix both the
legacy layout engine and IFC to align the last line according to text-align-last.

Manually tested by running run-webkit-tests with IFC enabled and disabled.

[1]: ​https://github.com/w3c/csswg-drafts/commit/c1f7023611f2c44d24d5a0647965817902651f58

• LayoutTests/TestExpectations:
• LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify-expected.html: Removed.
• LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html:

Remove obsolete test that tests the old behavior of text-align-line.

• Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:

(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::LineBoxBuilder::build):

• Source/WebCore/rendering/LegacyLineLayout.cpp:

(WebCore::LegacyLineLayout::textAlignmentForLine const):

Canonical link: ​https://commits.webkit.org/251294@main

3:21 PM Changeset in webkit [295238] by Fujii Hironori

• 2 edits in trunk/Tools

webkit-patch: git am strips []-enclosed prefixes (e.g. [CMake][WPE]) in a subject
​https://bugs.webkit.org/show_bug.cgi?id=241114

Reviewed by Jonathan Bedard.

git-am removes all []-enclosed prefixes from a subject by default.
git-am has --keep-non-patch option that removes only "[PATCH]" prefix.

• Tools/CISupport/ews-build/steps.py:

(run):

• Tools/Scripts/webkitpy/common/checkout/checkout.py:

(apply_patch):
Use --keep-non-patch option for git am.

Canonical link: ​https://commits.webkit.org/251293@main

3:08 PM Changeset in webkit [295237] by Kate Cheney

• 1 edit in trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm

REGRESSION: [ iOS ] Six TestWebKitAPI.AppPrivacyRep ort API tests are a consistent timeout (241233)
​https://bugs.webkit.org/show_bug.cgi?id=241233
rdar://94298162

Reviewed by Ryan Haddad.

Avoid connecting to the internet in API tests.

• Tools/TestWebKitAPI/Tests/WebKitCocoa/AppPrivacyReport.mm:

(TEST):

Canonical link: ​https://commits.webkit.org/251292@main

3:02 PM Changeset in webkit [295236] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/win/TestExpectations

[Gardening]: [Win] Update expectations for layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=172437

Unreviewed test gardening.

• LayoutTests/platform/win/TestExpectations:

Canonical link: ​https://commits.webkit.org/251291@main

2:44 PM Changeset in webkit [295235] by pvollan@apple.com

• 1 edit in trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in

[iOS][GPUP] Add read access to Mobile asset font directory
​https://bugs.webkit.org/show_bug.cgi?id=241276
<rdar://89592483>

Reviewed by Geoffrey Garen.

• Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in:

Canonical link: ​https://commits.webkit.org/251290@main

2:21 PM Changeset in webkit [295234] by pvollan@apple.com

• 1 edit in trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

Enable HEIC decoding for all non-browser apps on macOS
​https://bugs.webkit.org/show_bug.cgi?id=241271
<rdar://92983791>

Reviewed by Geoffrey Garen.

Enable HEIC decoding for all non-browser apps on macOS, since this capability is also needed for other apps besides Mail.
We do not want to enable it for Web browsers yet, since this currently requries an unconditional sandbox extension for
trustd.

• Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

Canonical link: ​https://commits.webkit.org/251289@main

2:12 PM Changeset in webkit [295233] by Fujii Hironori

• 3 edits in trunk/Source/WebCore/platform/graphics/texmap

Remove TextureMapperLayer::setChildren(const Vector<GraphicsLayer*>&) to make TextureMapperLayer independent to GraphicsLayer and GraphicsLayerTextureMapper
​https://bugs.webkit.org/show_bug.cgi?id=241248

Reviewed by Don Olmstead.

setChildren(const Vector<GraphicsLayer*>&) was taking GraphicsLayer
objects as an argument, and assuming the GraphicsLayer objects were
GraphicsLayerTextureMapper objects. This was a layer violation.
TextureMapperLayer doen't need to know about GraphicsLayer and
GraphicsLayerTextureMapper.

• Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):

• Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:
• Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h:

Canonical link: ​https://commits.webkit.org/251288@main

2:08 PM Changeset in webkit [295232] by Devin Rousso

• 28 edits
  11 adds
  8 deletes in trunk

Web Inspector: drop InspectorAdditionsEnabled in favor of new methods on InspectorFrontendhost
​https://bugs.webkit.org/show_bug.cgi?id=241192

Reviewed by Patrick Angle.

This removes custom things from standardized IDLs and allows custom functionality necessary for Web
Inspector to be kept inside inspector objects (as well as the fact that InspectorFrontendHost is
guaranteed to exist, so there's no concern about this functionality not being available).

• Source/WTF/Scripts/Preferences/WebPreferences.yaml:
• Source/WebCore/page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setInspectorAdditionsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::inspectorAdditionsEnabled const): Deleted.

• Source/WebKit/UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetInspectorAdditionsEnabled): Deleted.
(WKPreferencesGetInspectorAdditionsEnabled): Deleted.

• Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:
• Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::enableFrontendFeatures):

• Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h:
• Source/WebKitLegacy/mac/WebView/WebPreferences.mm:

(-[WebPreferences inspectorAdditionsEnabled]): Deleted.
(-[WebPreferences setInspectorAdditionsEnabled:]): Deleted.

• Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:
• Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl:
• Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h:
• Source/WebKitLegacy/win/WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::inspectorAdditionsEnabled): Deleted.
(WebPreferences::setInspectorAdditionsEnabled): Deleted.

• Source/WebKitLegacy/win/WebPreferences.h:
• Source/WebKitLegacy/win/WebView.cpp:

(WebView::notifyPreferencesChanged):

• Tools/DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):
Remove all things related to InspectorAdditionsEnabled.

• Source/WebCore/html/canvas/CanvasPath.idl:
• Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:
• Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.idl:

Remove nonstandard functionality gated by InspectorAdditionsEnabled in standardized IDLs.

• Source/WebCore/inspector/InspectorFrontendHost.h:
• Source/WebCore/inspector/InspectorFrontendHost.idl:
• Source/WebCore/inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::getPath const): Added.
(WebCore::InspectorFrontendHost::getCurrentX const): Added.
(WebCore::InspectorFrontendHost::getCurrentY const): Added.
(WebCore::InspectorFrontendHost::setPath const): Added.

• Source/WebInspectorUI/UserInterface/Base/IDLExtensions.js: Added.

(File.prototype.getPath): Added.
(CanvasRenderingContext2D.prototype.currentX): Added.
(CanvasRenderingContext2D.prototype.currentY): Added.
(CanvasRenderingContext2D.prototype.getPath): Added.
(CanvasRenderingContext2D.prototype.setPath): Added.
Centralize all custom IDL extensions in a new file with the same name so it's very easy to find.

• Source/WebInspectorUI/UserInterface/Base/ImageUtilities.js:

(WI.ImageUtilities.supportsCanvasPathDebugging): Deleted.

• Source/WebInspectorUI/UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.prototype.process):

• Source/WebInspectorUI/UserInterface/Models/RecordingState.js:

(WI.RecordingState.prototype.fromContext):

• Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView):
(WI.RecordingContentView.prototype.get navigationItems):
(WI.RecordingContentView.prototype.attached):
(WI.RecordingContentView.prototype._generateContentCanvas2D):

• Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView.prototype.async _handleMapLocalResourceOverrideToFile):
Remove checks based on InspectorAdditionsEnabled (technically they check for the existence of the
custom functionality on the builtin prototype, but that's added based on InspectorAdditionsEnabled).

• Source/WebInspectorUI/UserInterface/Main.html:
• Source/WebInspectorUI/UserInterface/Test.html:

• LayoutTests/fast/canvas/2d.currentPoint.html: Removed.
• LayoutTests/fast/canvas/2d.currentPoint-expected.txt: Removed.
• LayoutTests/fast/canvas/2d.getPath.modification.html: Removed.
• LayoutTests/fast/canvas/2d.getPath.modification-expected.txt: Removed.
• LayoutTests/fast/canvas/2d.getPath.newobject.html: Removed.
• LayoutTests/fast/canvas/2d.getPath.newobject-expected.txt: Removed.
• LayoutTests/fast/canvas/2d.setPath.html: Removed.
• LayoutTests/fast/canvas/2d.setPath-expected.txt: Removed.
• LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/getPath.html: Added.
• LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/getPath-expected.txt: Added.
• LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/get_currentX.html: Added.
• LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/get_currentX-expected.txt: Added.
• LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/get_currentY.html: Added.
• LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/get_currentY-expected.txt: Added.
• LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/setPath.html: Added.
• LayoutTests/inspector/idl-extensions/CanvasRenderingContext2D/setPath-expected.txt: Added.

Canonical link: ​https://commits.webkit.org/251287@main

2:06 PM Changeset in webkit [295231] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit/Shared/RemoteLayerTree

Unreviewed build fix after r295149

• Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.cpp:

(WebKit::CGDisplayListImageBufferBackend::getPixelBuffer const):

• Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.h:

Fix the build.

Canonical link: ​https://commits.webkit.org/251286@main

2:03 PM Changeset in webkit [295230] by achristensen@apple.com

• 2 edits in trunk

HSTS synthesized redirect responses should not be blocked by CORS
​https://bugs.webkit.org/show_bug.cgi?id=241003

Reviewed by Youenn Fablet.

If a cross-origin request is made to an http URL that would be upgraded to an https URL
because of HSTS, we synthesize a "response" to call willPerformHTTPRedirection with.
Unfortunately, this response can fail CORS checks causing the request to be unnecessarily blocked.
To prevent this, just add CORS headers to the synthesized responses for HSTS.

• Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):

• Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:

(TestWebKitAPI::TEST):

Canonical link: ​https://commits.webkit.org/251284@main

2:03 PM Changeset in webkit [295229] by Ryan Haddad

• 3 edits in trunk/Tools/CISupport/build-webkit-org

Repurpose arm64 iOS simulator GPUP bot as a general arm64 iOS simulator tester
​https://bugs.webkit.org/show_bug.cgi?id=241278

Reviewed by Aakash Jain.

• Tools/CISupport/build-webkit-org/config.json:
• Tools/CISupport/build-webkit-org/factories_unittest.py:

(TestExpectedBuildSteps):

• Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

Canonical link: ​https://commits.webkit.org/251284@main

2:00 PM Changeset in webkit [295228] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations

[Gardening]: [ macOS Debug wk2 EWS ] fast/animation/request-animation-frame-throttling-detached-iframe.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=241283
<rdar://94364006>

Unreviewed test gardening.

• LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/251283@main

1:52 PM Changeset in webkit [295227] by Said Abou-Hallawa

• 31 edits
  2 adds in trunk

[GPU Process] [Filters] Make PixelBuffer an abstract class
​https://bugs.webkit.org/show_bug.cgi?id=240809
<rdar://problem/94117981>

Reviewed by Simon Fraser.

Hide the current underlying memory of PixelBuffer which is 'Uint8ClampedArray'
and move it to a new subclass named ByteArrayPixelBuffer.

All clients should use the virtual methods 'bytes()' and 'sizeInBytes()' to have
access to the pixel bytes. All calls to 'PixelBuffer::tryCreate()' should be
replaced with 'ByteArrayPixelBuffer::tryCreate()'.

In future patches and when GPUProcess applies software filters, we are going to
create new subclass of PixelBuffer for the result FilterImages. This new sub-
class will use SharedMemory as its underlying pixel data and it will attribute
this SharedMemory to WebProcess.

• Source/WebCore/Headers.cmake:
• Source/WebCore/Sources.txt:
• Source/WebCore/WebCore.xcodeproj/project.pbxproj:
• Source/WebCore/bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpImageBitmap):
(WebCore::CloneDeserializer::readImageBitmap):

• Source/WebCore/html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getImageData):

• Source/WebCore/html/ImageData.cpp:

(WebCore::ImageData::create):
(WebCore::ImageData::pixelBuffer const):

• Source/WebCore/html/ImageData.h:
• Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::getImageData const):

• Source/WebCore/page/PageColorSampler.cpp:

(WebCore::sampleColor):

• Source/WebCore/platform/graphics/GraphicsContextGL.cpp:

(WebCore::GraphicsContextGL::extractPixelBuffer):

• Source/WebCore/platform/graphics/ImageBufferAllocator.cpp:

(WebCore::ImageBufferAllocator::createPixelBuffer const):

• Source/WebCore/platform/graphics/ImageBufferBackend.cpp:

(WebCore::ImageBufferBackend::convertToLuminanceMask):
(WebCore::ImageBufferBackend::getPixelBuffer const):
(WebCore::ImageBufferBackend::putPixelBuffer):

• Source/WebCore/platform/graphics/PixelBuffer.cpp:

(WebCore::PixelBuffer::supportedPixelFormat):
(WebCore::PixelBuffer::PixelBuffer):
(WebCore::PixelBuffer::tryCreateForDecoding): Deleted.
(WebCore::PixelBuffer::tryCreate): Deleted.
(WebCore::PixelBuffer::create): Deleted.
(WebCore::PixelBuffer::bytes const): Deleted.
(WebCore::PixelBuffer::sizeInBytes const): Deleted.
(WebCore::PixelBuffer::createScratchPixelBuffer const): Deleted.
(WebCore::operator<<): Deleted.

• Source/WebCore/platform/graphics/PixelBuffer.h:

(WebCore::PixelBuffer::size const):
(WebCore::PixelBuffer::isByteArrayPixelBuffer const):
(WebCore::PixelBuffer::data const): Deleted.
(WebCore::PixelBuffer::takeData): Deleted.
(WebCore::PixelBuffer::encode const): Deleted.
(WebCore::PixelBuffer::decode): Deleted.

• Source/WebCore/platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::blurShadowBuffer):

• Source/WebCore/platform/graphics/ByteArrayPixelBuffer.cpp: Added.

(WebCore::ByteArrayPixelBuffer::create):
(WebCore::ByteArrayPixelBuffer::tryCreate):
(WebCore::ByteArrayPixelBuffer::tryCreateForDecoding):
(WebCore::ByteArrayPixelBuffer::ByteArrayPixelBuffer):
(WebCore::ByteArrayPixelBuffer::bytes const):
(WebCore::ByteArrayPixelBuffer::sizeInBytes const):
(WebCore::ByteArrayPixelBuffer::createScratchPixelBuffer const):

• Source/WebCore/platform/graphics/ByteArrayPixelBuffer.h: Added.

(WebCore::ByteArrayPixelBuffer::data const):
(WebCore::ByteArrayPixelBuffer::takeData):
(WebCore::ByteArrayPixelBuffer::encode const):
(WebCore::ByteArrayPixelBuffer::decode):
(isType):

• Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::readPixelsForPaintResults):
(WebCore::GraphicsContextGLANGLE::paintRenderingResultsToPixelBuffer):

• Source/WebCore/platform/graphics/cg/GraphicsContextGLCG.cpp:

(WebCore::GraphicsContextGL::paintToCanvas):

• Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp:

(WebCore::ImageBufferCGBackend::copyCGImageForEncoding const):

• Source/WebCore/platform/graphics/cg/ImageBufferUtilitiesCG.cpp:

(WebCore::encode):

• Source/WebCore/platform/graphics/cv/VideoFrameCV.mm:

(WebCore::VideoFrameCV::createFromPixelBuffer):

• Source/WebCore/platform/graphics/filters/FilterImage.cpp:

(WebCore::copyImageBytes):

• Source/WebCore/rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

• Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:

(WebKit::RemoteGraphicsContextGL::paintPixelBufferToImageBuffer):

• Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::getPixelBufferForImageBuffer):

• Source/WebKit/Platform/IPC/PixelBufferReference.h:

(IPC::PixelBufferReference::encode const):
(IPC::PixelBufferReference::decode):

• Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
• Tools/TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp:

(TestWebKitAPI::imageBufferPixelIs):

Canonical link: ​https://commits.webkit.org/251282@main

1:39 PM Changeset in webkit [295226] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/win/TestExpectations

[Gardening]: [ Windows EWS ] webanimations/accelerated-animations-and-motion-path.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=241282
<rdar://94362852>

Unreviewed test gardening.

• LayoutTests/platform/win/TestExpectations:

Canonical link: ​https://commits.webkit.org/251281@main

1:31 PM Changeset in webkit [295225] by Devin Rousso

• 1 edit in trunk/LayoutTests/http/tests/inspector/network/copy-as-fetch.html

New test: http/tests/inspector/network/copy-as-fetch.html is a frequent / flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=241279
<rdar://problem/94361782>

Unreviewed text fix.

• LayoutTests/http/tests/inspector/network/copy-as-fetch.html:

Canonical link: ​https://commits.webkit.org/251280@main

1:29 PM Changeset in webkit [295224] by Devin Rousso

• 14 edits in trunk/Source/WebInspectorUI/UserInterface

Web Inspector: Sources: creating a local override when viewing a resource should automatically place the cursor where it was before
​https://bugs.webkit.org/show_bug.cgi?id=218301
<rdar://problem/70773143>

Reviewed by Patrick Angle.

• Source/WebInspectorUI/UserInterface/Base/Main.js:

(WI.showLocalResourceOverride):
If the overridden WI.Resource is also provided, grab the selected text and scroll position from
the WI.ContentView created for it (if it exists) and pass it along when showing the WI.ContentView
for the given WI.LocalResourceOverride.

• Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForSourceCode):

• Source/WebInspectorUI/UserInterface/Views/FontResourceContentView.js:

(WI.FontResourceContentView.prototype.dropZoneHandleDrop):

• Source/WebInspectorUI/UserInterface/Views/ImageResourceContentView.js:

(WI.ImageResourceContentView.prototype.dropZoneHandleDrop):

• Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideTreeElement.js:

(WI.LocalResourceOverrideTreeElement.prototype.willDismissPopover):

• Source/WebInspectorUI/UserInterface/Views/LocalResourceOverrideWarningView.js:

(WI.LocalResourceOverrideWarningView.prototype.initialLayout):

• Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView.prototype.async _createAndShowLocalResourceOverride):
(WI.ResourceContentView.prototype._handleImportLocalResourceOverride):
Pass along the overridden WI.Resource.

• Source/WebInspectorUI/UserInterface/Views/TextEditor.js:

(WI.TextEditor.prototype.get scrollOffset): Added.
(WI.TextEditor.prototype.set scrollOffset): Added.
(WI.TextEditor.prototype.revealPosition):
(WI.TextEditor.prototype.revealPosition.revealAndHighlightLine):
(WI.TextEditor.prototype._updateAfterFormatting):
(WI.TextEditor.prototype._revealPendingPositionIfPossible):
Add a way for callers to get/set the scroll position.
Allow callers of revealPosition to also focus for instant editability.
Drive-by: Rework the structure of the parameters to make it easier to add new one.

• Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:

(WI.ResourceClusterContentView.prototype.restoreFromCookie):
(WI.ResourceClusterContentView.prototype.showResponse):
(WI.ResourceClusterContentView.prototype._resourceLoadingDidFinish):
Teach restoreFromCookie how to pull out more things (e.g. WI.TextRange, WI.Point, etc.).
Drive-by: Remove parameters from showResponse as they're not used anywhere.

• Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js:

(WI.ScriptContentView.prototype.revealPosition):
(WI.ScriptContentView.prototype.restoreFromCookie):

• Source/WebInspectorUI/UserInterface/Views/ShaderProgramContentView.js:

(WI.ShaderProgramContentView.prototype.revealPosition):

• Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.dialogWasDismissedWithRepresentedObject):

• Source/WebInspectorUI/UserInterface/Views/TextContentView.js:

(WI.TextContentView.prototype.revealPosition):

• Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView.prototype.revealPosition):
Adjust revealPosition to simply pass along parameters instead of trying to do things with them.

Canonical link: ​https://commits.webkit.org/251279@main

1:24 PM Changeset in webkit [295223] by Wenson Hsieh

• 5 edits in trunk/Source/WebKit/UIProcess

Allow the element fullscreen security heuristic to ignore certain touches
​https://bugs.webkit.org/show_bug.cgi?id=241068

Reviewed by Eric Carlson.

• Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:
• Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _shouldAvoidSecurityHeuristicScoreUpdates]):

• Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _shouldAvoidSecurityHeuristicScoreUpdates]):

• Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController _touchDetected:]):

Canonical link: ​https://commits.webkit.org/251278@main

1:24 PM Changeset in webkit [295222] by Alan Coon

• 1 edit in branches/safari-613-branch/Source/WebCore/Modules/cache/WorkerCacheStorageConnection.cpp

Unreviewed build fix. rdar://problem/92853663

FAILURE ./Modules/cache/WorkerCacheStorageConnection.cpp:125:107: error: non-virtual member function marked 'final' hides virtual member function
FAILURE ./Modules/cache/WorkerCacheStorageConnection.cpp:119:72: error: allocating an object of abstract class type 'WebCore::StoppedCacheStorageConnection'

1:24 PM Changeset in webkit [295221] by Alan Coon

• 1 edit in branches/safari-613-branch/Source/WebCore/animation/KeyframeEffect.cpp

Revert 41769648c46b. rdar://problem/93513759

This reverts commit dc0c4463e249c835881c42cc7446662a85914ae1.

1:19 PM Changeset in webkit [295220] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/win/TestExpectations

[Gardening]: [ Windows ] two tests imported/blink and fast/layers are a consistent failure
​https://bugs.webkit.org/show_bug.cgi?id=241281
<rdar://94362021>
Unreviewed test gardening.

• LayoutTests/platform/win/TestExpectations:

Canonical link: ​https://commits.webkit.org/251277@main

12:59 PM Changeset in webkit [295219] by achristensen@apple.com

• 26 edits in trunk

Implement CSSNumericValue.to
​https://bugs.webkit.org/show_bug.cgi?id=241167

Reviewed by Chris Dumez.

• LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/cssRotate.tentative-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssMathValue.tentative-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/to.tentative-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-subclasses/numeric-objects/toSum.tentative-expected.txt:
• Source/WebCore/css/CSSUnits.cpp:

(WebCore::canonicalUnitType): Deleted.

• Source/WebCore/css/CSSUnits.h:
• Source/WebCore/css/typedom/CSSNumericValue.cpp:

(WebCore::operationOnValuesOfSameUnit):
(WebCore::CSSNumericValue::multiplyInternal):
(WebCore::CSSNumericValue::min):
(WebCore::CSSNumericValue::max):
(WebCore::CSSNumericValue::to):

• Source/WebCore/css/typedom/CSSNumericValue.h:
• Source/WebCore/css/typedom/CSSUnitValue.cpp:

(WebCore::CSSUnitValue::parseUnit):
(WebCore::CSSUnitValue::create):
(WebCore::CSSUnitValue::CSSUnitValue):
(WebCore::conversionToCanonicalUnitsScaleFactor):
(WebCore::CSSUnitValue::convertTo const):
(WebCore::CSSUnitValue::toSumValue const):
(WebCore::numericType): Deleted.
(WebCore::parseUnit): Deleted.

• Source/WebCore/css/typedom/CSSUnitValue.h:
• Source/WebCore/css/typedom/numeric/CSSMathInvert.cpp:

(WebCore::CSSMathInvert::toSumValue const):

• Source/WebCore/css/typedom/numeric/CSSMathInvert.h:
• Source/WebCore/css/typedom/numeric/CSSMathMax.cpp:

(WebCore::CSSMathMax::create):
(WebCore::CSSMathMax::CSSMathMax):
(WebCore::CSSMathMax::toSumValue const):

• Source/WebCore/css/typedom/numeric/CSSMathMax.h:
• Source/WebCore/css/typedom/numeric/CSSMathMin.cpp:

(WebCore::CSSMathMin::create):
(WebCore::CSSMathMin::CSSMathMin):
(WebCore::CSSMathMin::toSumValue const):

• Source/WebCore/css/typedom/numeric/CSSMathMin.h:
• Source/WebCore/css/typedom/numeric/CSSMathNegate.cpp:

(WebCore::CSSMathNegate::toSumValue const):

• Source/WebCore/css/typedom/numeric/CSSMathNegate.h:
• Source/WebCore/css/typedom/numeric/CSSMathProduct.cpp:

(WebCore::CSSMathProduct::toSumValue const):

• Source/WebCore/css/typedom/numeric/CSSMathProduct.h:
• Source/WebCore/css/typedom/numeric/CSSMathSum.cpp:

(WebCore::CSSMathSum::toSumValue const):

• Source/WebCore/css/typedom/numeric/CSSMathSum.h:
• Source/WebCore/css/typedom/numeric/CSSNumericArray.cpp:

(WebCore::CSSNumericArray::forEach):

• Source/WebCore/css/typedom/numeric/CSSNumericType.cpp:

(WebCore::CSSNumericType::create):
(WebCore::typeFromVector):

• Source/WebCore/css/typedom/numeric/CSSNumericType.h:

(WebCore::CSSNumericType::operator!= const):

• Source/WebCore/css/typedom/transform/CSSTransformValue.cpp:

(WebCore::CSSTransformValue::serialize const):

Canonical link: ​https://commits.webkit.org/251276@main

12:57 PM Changeset in webkit [295218] by commit-queue@webkit.org

• 18 edits in trunk/Source/WebCore/html/canvas

WebGL extensions enable code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=241264

Patch by Alexey Knyazev <​3479527+lexaknyazev@users.noreply.github.com> on 2022-06-03
Reviewed by Kenneth Russell.

• Use extension ctors to enable them in ANGLE. It is safe to

call ensureExtensionEnabled even when ANGLE is not used

• Do not request ARB-prefixed extensions from ANGLE
• Fixed duplicated extension enable requests for
  • ANGLE_instanced_arrays
  • OES_fbo_render_mipmap
  • WEBGL_draw_buffers
• Directly check for enabled extensions in

WebGL2RenderingContext::renderbufferStorageImpl and
WebGLRenderingContextBase::addExtensionSupportedFormatsAndTypes
instead of scanning through the list of strings

• Source/WebCore/html/canvas/ANGLEInstancedArrays.cpp:

(WebCore::ANGLEInstancedArrays::ANGLEInstancedArrays):

• Source/WebCore/html/canvas/EXTBlendMinMax.cpp:

(WebCore::EXTBlendMinMax::EXTBlendMinMax):

• Source/WebCore/html/canvas/EXTFragDepth.cpp:

(WebCore::EXTFragDepth::EXTFragDepth):

• Source/WebCore/html/canvas/EXTShaderTextureLOD.cpp:

(WebCore::EXTShaderTextureLOD::EXTShaderTextureLOD):

• Source/WebCore/html/canvas/EXTTextureCompressionBPTC.cpp:

(WebCore::EXTTextureCompressionBPTC::EXTTextureCompressionBPTC):

• Source/WebCore/html/canvas/EXTTextureCompressionRGTC.cpp:

(WebCore::EXTTextureCompressionRGTC::EXTTextureCompressionRGTC):

• Source/WebCore/html/canvas/EXTTextureFilterAnisotropic.cpp:

(WebCore::EXTTextureFilterAnisotropic::EXTTextureFilterAnisotropic):

• Source/WebCore/html/canvas/EXTTextureNorm16.cpp:

(WebCore::EXTTextureNorm16::EXTTextureNorm16):

• Source/WebCore/html/canvas/EXTsRGB.cpp:

(WebCore::EXTsRGB::EXTsRGB):

• Source/WebCore/html/canvas/OESElementIndexUint.cpp:

(WebCore::OESElementIndexUint::OESElementIndexUint):

• Source/WebCore/html/canvas/OESStandardDerivatives.cpp:

(WebCore::OESStandardDerivatives::OESStandardDerivatives):

• Source/WebCore/html/canvas/OESTextureFloatLinear.cpp:

(WebCore::OESTextureFloatLinear::OESTextureFloatLinear):

• Source/WebCore/html/canvas/OESTextureHalfFloatLinear.cpp:

(WebCore::OESTextureHalfFloatLinear::OESTextureHalfFloatLinear):

• Source/WebCore/html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::OESVertexArrayObject):

• Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::renderbufferStorageImpl):

• Source/WebCore/html/canvas/WebGLDepthTexture.cpp:

(WebCore::WebGLDepthTexture::WebGLDepthTexture):

• Source/WebCore/html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):

• Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::addExtensionSupportedFormatsAndTypes):

Canonical link: ​https://commits.webkit.org/251275@main

12:30 PM Changeset in webkit [295217] by Wenson Hsieh

• 2 edits
  1 delete in trunk/LayoutTests

[iOS] editing/selection/ios/do-not-hide-selection-in-visible-container.html fails on iPhone 12 simulator
​https://bugs.webkit.org/show_bug.cgi?id=241270
rdar://86025461

Reviewed by Tim Horton.

This test currently fails when run on iPhone 12 simulator. Due to the slightly wider screen size, the row of buttons at
the top of the page no longer wraps to the next line, which in turn causes the output text to have one less space
character when compared to the output on iPhone SE.

To fix this, make the test robust against this difference by removing each button before the end of the test. This also
causes the text ouput on iPad to now match the expected output on iPhone, so we no longer require test expectations that
are specific to iPad vs. iPhone.

• LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt:
• LayoutTests/editing/selection/ios/do-not-hide-selection-in-visible-container.html:
• LayoutTests/platform/ipad/editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt: Removed.

Canonical link: ​https://commits.webkit.org/251274@main

10:11 AM Changeset in webkit [295216] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[GTK] Fix a couple clang warnings related with DESTINATION_COLOR_SPACE_LINEAR_SRGB and atspi
​https://bugs.webkit.org/show_bug.cgi?id=241269

Patch by Philippe Normand <​philn@igalia.com> on 2022-06-03
Reviewed by Michael Catanzaro.

• Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::postPlatformNotification): Add switch case for AXHasPopupChanged, stubbed for now.

• Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp:

(WebCore::ImageBufferCairoBackend::transformToColorSpace): makr newColorSpace as unused when
DESTINATION_COLOR_SPACE_LINEAR_SRGB is disabled.

• Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource): Move svgStyle declaration to
DESTINATION_COLOR_SPACE_LINEAR_SRGB code path.

Canonical link: ​https://commits.webkit.org/251273@main

9:30 AM Changeset in webkit [295215] by commit-queue@webkit.org

• 18 edits in trunk/Source/WebCore

Remove last remnants of old Media Controls related sliders
​https://bugs.webkit.org/show_bug.cgi?id=241226

Patch by Philippe Normand <​philn@igalia.com> on 2022-06-03
Reviewed by Tim Nguyen.

The media-*-slider-*part theme parts are no longer used, so should be removed.

• Source/WebCore/WebCore.order:
• Source/WebCore/accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::orientation const):

• Source/WebCore/css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

• Source/WebCore/css/CSSValueKeywords.in:
• Source/WebCore/css/mediaControls.css:

(:is(audio, video)::-webkit-media-controls-timeline):

• Source/WebCore/css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

• Source/WebCore/html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

• Source/WebCore/html/shadow/ShadowPseudoIds.cpp:

(WebCore::ShadowPseudoIds::webkitMediaSliderThumb): Deleted.
(WebCore::ShadowPseudoIds::webkitMediaSliderContainer): Deleted.

• Source/WebCore/html/shadow/ShadowPseudoIds.h:
• Source/WebCore/html/shadow/SliderThumbElement.cpp:

(WebCore::hasVerticalAppearance):
(WebCore::SliderThumbElement::create):
(WebCore::SliderThumbElement::resolveCustomStyle):
(WebCore::SliderContainerElement::create):
(WebCore::SliderThumbElement::shadowPseudoId const): Deleted.
(WebCore::SliderContainerElement::resolveCustomStyle): Deleted.
(WebCore::SliderContainerElement::shadowPseudoId const): Deleted.

• Source/WebCore/html/shadow/SliderThumbElement.h:

(WebCore::SliderThumbElement::create): Deleted.

• Source/WebCore/platform/ThemeTypes.cpp:

(WebCore::operator<<):

• Source/WebCore/platform/ThemeTypes.h:
• Source/WebCore/rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::autoAppearanceForElement const):
(WebCore::RenderTheme::paint):

• Source/WebCore/rendering/RenderTheme.h:

(WebCore::RenderTheme::paintMediaSliderTrack): Deleted.
(WebCore::RenderTheme::paintMediaSliderThumb): Deleted.
(WebCore::RenderTheme::paintMediaVolumeSliderTrack): Deleted.
(WebCore::RenderTheme::paintMediaVolumeSliderThumb): Deleted.
(WebCore::RenderTheme::paintMediaFullScreenVolumeSliderTrack): Deleted.
(WebCore::RenderTheme::paintMediaFullScreenVolumeSliderThumb): Deleted.

• Source/WebCore/rendering/RenderThemeAdwaita.cpp:

(WebCore::parentMediaElement): Deleted.
(WebCore::RenderThemeAdwaita::paintMediaSliderTrack): Deleted.
(WebCore::RenderThemeAdwaita::paintMediaVolumeSliderTrack): Deleted.

• Source/WebCore/rendering/RenderThemeAdwaita.h:
• Source/WebCore/rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSliderTrack):

Canonical link: ​https://commits.webkit.org/251272@main

9:13 AM Changeset in webkit [295214] by Chris Dumez

• 9 edits in trunk/Source

Drop unnecessary operator==() overloads for String
​https://bugs.webkit.org/show_bug.cgi?id=241235

Reviewed by Alex Christensen.

• Source/WTF/wtf/text/WTFString.h:

(WTF::operator==):
(WTF::operator!=):

Canonical link: ​https://commits.webkit.org/251271@main

8:55 AM Changeset in webkit [295213] by pvollan@apple.com

• 6 edits in trunk/Source

Call function to restrict image decoders for all clients
​https://bugs.webkit.org/show_bug.cgi?id=240958
<rdar://93794556>

Reviewed by Geoffrey Garen.

Call function to enable HEIC decoding for all clients on iOS. The main motivation behind this patch
is to avoid using IOKit when decoding HEIC or JPEGs with aux HEIC. Calling enableDecodingHEIC() will
make sure IOKit is not being used, as well as enabling HEIC decoding. We previously only did this for
Mail, but decoding of HEIC images should be possible for all clients. We are not enabling this for
all clients on macOS, since macOS is not blocking IOKit in the WebContent process. This patch also
renames the function, since the former name was not accurate.

• Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::createImageSourceOptions):
(WebCore::ImageDecoderCG::enableDecodeHEIC):
(WebCore::ImageDecoderCG::decodeHEICEnabled):
(WebCore::ImageDecoderCG::enableRestrictedDecoding): Deleted.
(WebCore::ImageDecoderCG::restrictedDecodingEnabled): Deleted.

• Source/WebCore/platform/graphics/cg/ImageDecoderCG.h:
• Source/WebKit/Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Source/WebKit/Shared/WebProcessCreationParameters.h:
• Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: ​https://commits.webkit.org/251270@main

8:47 AM Changeset in webkit [295212] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/win/TestExpectations

[Gardening]: [ Windows EWS ] webanimations/accelerated-transform-animation-from-scale-zero-and-implicit-to-kefyrame.html is a flaky image failure
​https://bugs.webkit.org/show_bug.cgi?id=241268
<rdar://94347232>

Unreviewed test gardening.

• LayoutTests/platform/win/TestExpectations:

Canonical link: ​https://commits.webkit.org/251269@main

8:29 AM Changeset in webkit [295211] by Antti Koivisto

• 10 edits in trunk

Disallow styles using container units from matched declarations cache
​https://bugs.webkit.org/show_bug.cgi?id=241261

Reviewed by Alan Bujtas.

We may fail to invalidate styles using container units correctly on container size change
because they are getting cached.

• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-invalidation-expected.txt:
• Source/WebCore/css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):

Mark styles that use container units.

• Source/WebCore/css/CSSToLengthConversionData.cpp:

(WebCore::CSSToLengthConversionData::defaultViewportFactor const):
(WebCore::CSSToLengthConversionData::smallViewportFactor const):
(WebCore::CSSToLengthConversionData::largeViewportFactor const):
(WebCore::CSSToLengthConversionData::dynamicViewportFactor const):
(WebCore::CSSToLengthConversionData::setUsesContainerUnits const):

• Source/WebCore/css/CSSToLengthConversionData.h:
• Source/WebCore/dom/Document.cpp:

(WebCore::Document::updateViewportUnitsOnResize):

• Source/WebCore/rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::isFullScreenIFrame const):

• Source/WebCore/rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

• Source/WebCore/rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setUsesViewportUnits):
(WebCore::RenderStyle::usesViewportUnits const):

Also rename hasViewportUnits -> usesViewportUnits for clarity.

(WebCore::RenderStyle::setUsesContainerUnits):
(WebCore::RenderStyle::usesContainerUnits const):
(WebCore::RenderStyle::NonInheritedFlags::operator== const):
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
(WebCore::RenderStyle::setHasViewportUnits): Deleted.
(WebCore::RenderStyle::hasViewportUnits const): Deleted.

• Source/WebCore/style/MatchedDeclarationsCache.cpp:

(WebCore::Style::MatchedDeclarationsCache::isCacheable):

Disallow caching.

(WebCore::Style::MatchedDeclarationsCache::clearEntriesAffectedByViewportUnits):

• Source/WebCore/style/StyleResolver.cpp:

(WebCore::Style::Resolver::styleForElement):
(WebCore::Style::Resolver::pseudoStyleForElement):

Canonical link: ​https://commits.webkit.org/251268@main

8:24 AM Changeset in webkit [295210] by commit-queue@webkit.org

• 1 edit in trunk/Source/WebCore/html/HTMLMapElement.cpp

Allow image map adding/removing when in tree scope
​https://bugs.webkit.org/show_bug.cgi?id=241263

Patch by Rob Buis <​rbuis@igalia.com> on 2022-06-03
Reviewed by Ryosuke Niwa.

Allow image map adding/removing when in tree scope, even
when disconnected, to avoid insert/remove mismatches.

• Source/WebCore/html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::parseAttribute):

Canonical link: ​https://commits.webkit.org/251267@main

8:13 AM Changeset in webkit [295209] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/mac-wk1/TestExpectations

[Gardening]: [ macOS wk1 ] compositing/video/video-border-radius.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=241266

Unreviewed test gardening.

• LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: ​https://commits.webkit.org/251266@main

8:03 AM Changeset in webkit [295208] by Alan Bujtas

• 4 edits in trunk/Source/WebCore/layout

FlexLayout should not use non-logical intrinsic widths
​https://bugs.webkit.org/show_bug.cgi?id=241256

Reviewed by Antti Koivisto.

This is in preparation for using logical-intrinsic widths in flex layout.

• Source/WebCore/layout/FormattingState.h:
• Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
(WebCore::Layout::FlexFormattingContext::layoutInFlowContentForIntegration):

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::FlexLayout):
(WebCore::Layout::FlexLayout::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:

(WebCore::Layout::FlexLayout::LogicalFlexItem::minimumContentWidth const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::LogicalFlexItem):
(WebCore::Layout::FlexLayout::formattingState const): Deleted.

Canonical link: ​https://commits.webkit.org/251265@main

7:41 AM Changeset in webkit [295207] by Chris Dumez

• 2 edits in trunk/Source/WebCore/html/parser

Optimize HTMLToken::appendToComment()
​https://bugs.webkit.org/show_bug.cgi?id=241250

Reviewed by Yusuke Suzuki.

Append several characters at once whenever possible instead of going one
character at a time. Also avoid updating the m_data8BitCheck data member
when the input characters are not UChars.

• Source/WebCore/html/parser/HTMLToken.h:

(WebCore::HTMLToken::appendToComment):

• Source/WebCore/html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::processToken):

Canonical link: ​https://commits.webkit.org/251264@main

7:16 AM Changeset in webkit [295206] by Karl Rackler

• 1 edit in trunk/LayoutTests/platform/mac-wk2/TestExpectations

[Gardening]: [ macOS Debug wk2 EWS ] WebCore::RenderView::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
​https://bugs.webkit.org/show_bug.cgi?id=241265
<rdar://94344274>

Unreviewed test gardening.

• LayoutTests/platform/mac-wk2/TestExpectations:

Canonical link: ​https://commits.webkit.org/251263@main

7:00 AM Changeset in webkit [295205] by commit-queue@webkit.org

• 114 edits
  2 adds in trunk/Source/ThirdParty/ANGLE

Update ANGLE to 2022-05-31 (b6a93d753bdd819ddc0dacb8cea554c86bc4c04e))
​https://bugs.webkit.org/show_bug.cgi?id=241140

Patch by Kenneth Russell <​kbr@chromium.org> on 2022-06-03
Reviewed by Kimmo Kinnunen.

Contains upstream commits:
git log --oneline 8291f2d3e72eca3a25826b689a013c292ef4ba94..b6a93d753bdd819ddc0dacb8cea554c86bc4c04e --pretty=%h %s
b6a93d753 GL: Temporarily enable validation for all GL calls.
d96cee668 Fix to invalidate cache when binding Transform Feedback.
86fce7a77 Roll SwiftShader from d070309f7d15 to 51c43dc015b7 (1 revision)
31c13df5d Revert "Initialize buffer contents separately from BufferImpl::setData"
213f669d3 Roll Chromium from 312583ebe76f to 85bb5555c93e (843 revisions)
0b533e64c Make GLProgram non-copyable.
9f4b9c650 Vulkan: Refactor command buffer retain calls.
ae74bdb3d Roll vulkan-deps from 528f7d8e618c to 59aa5963cf64 (8 revisions)
33b254fe8 Fix ValidateFragmentShaderColorBufferMaskMatch for indexed masks
e02848080 Roll SwiftShader from 5ca5b0ae5a7d to d070309f7d15 (5 revisions)
23f213d13 Vulkan: Make drawable size uniform
73019edeb Vulkan: SPIR-V Gen: No RelaxedPrecision on bitCount() and findLSB()
a2fe4445d Vulkan: Sync pipeline cache only when truly changed
9ea3967d3 Bug fix in GL_EXT_YUV_target
34cff1a14 Initialize buffer contents separately from BufferImpl::setData
2df17a127 Vulkan: Pack driver uniforms
98c2e169c Vulkan: Reduce pre-rotation spec const to bool
b267c009d Add support for comparison operator in FlatUnorderedSet
ee023e6af D3D11: fix constant buffer cache lookup.
cd42f669a Roll vulkan-deps from 6885957e17e7 to 528f7d8e618c (11 revisions)
5b74b1218 Roll SwiftShader from b5cb037f0292 to 5ca5b0ae5a7d (4 revisions)
aa2201725 Roll Chromium from f86f5d40df44 to 312583ebe76f (401 revisions)
c8989675e FramebufferTest: Add FramebufferConditionalFeedbackLoop test.
ae3de1a8c Add test for primitive state change
cd80b511e Metal: Upstream uniform limits from WebKit
54e08a5af Trace Tests: Remove Pixel 2 expectations.
757b84973 Vulkan: Fix reserve varying for xfb (take 2)
7495509b3 Roll vulkan-deps from c8893896acff to 6885957e17e7 (7 revisions)
7076ae5d0 Roll Chromium from 1f342b327faa to f86f5d40df44 (495 revisions)
891dd5b3d Vulkan: Fix mid-RP draw clear w.r.t growing scissor
7ad48b846 Revert "Add Vulkan backend support for texture labels"
fea195678 Vulkan: Remove removeEarlyFragmentTestsOpt flag
7b880204d Vulkan: Remove invalid ASSERT in DescriptorSetDesc.
4aa0975e6 Vulkan: Support Wayland EGL_DEFAULT_DISPLAY
4a20c9143 D3D: Fix race condition with parallel shader compile.
17750ab06 Roll vulkan-deps from 82a65519c521 to c8893896acff (10 revisions)
ccca0c25b libANGLE: Fix evaluating the sample count
2edb216bf Roll Chromium from d624307d6d25 to 1f342b327faa (484 revisions)
a81524477 Capture/Replay: Override eglCreateImage and eglDestroyImage
c608df696 Code Cleanup
802321922 Add ​ffz@google.com to OWNERS
615b2c685 D3D: implement whole-struct assignment in SSBOs.

Canonical link: ​https://commits.webkit.org/251261@main

6:59 AM Changeset in webkit [295204] by commit-queue@webkit.org

• 1 edit in trunk/Source/WebCore/rendering/RenderTable.cpp

Layout table captions in simplified layout
​https://bugs.webkit.org/show_bug.cgi?id=241262

Patch by Rob Buis <​rbuis@igalia.com> on 2022-06-03
Reviewed by Alan Bujtas.

Layout table captions in simplified layout.

• Source/WebCore/rendering/RenderTable.cpp:

(WebCore::RenderTable::simplifiedNormalFlowLayout):

Canonical link: ​https://commits.webkit.org/251261@main

6:31 AM Changeset in webkit [295203] by Alan Bujtas

• 3 edits in trunk/Source/WebCore/layout/formattingContexts/flex

FlexLayout::computeLogicalHeightForFlexItems should check if the logical height value is auto
​https://bugs.webkit.org/show_bug.cgi?id=241255

Reviewed by Antti Koivisto.

FlexLayout should always operate on logical values even if just checking whether height/width is auto.

• Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:

(WebCore::Layout::FlexLayout::LogicalFlexItem::setTop):
(WebCore::Layout::FlexLayout::LogicalFlexItem::setLeft):
(WebCore::Layout::FlexLayout::LogicalFlexItem::setWidth):
(WebCore::Layout::FlexLayout::LogicalFlexItem::setHeight):
(WebCore::Layout::FlexLayout::LogicalFlexItem::rect const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::topLeft const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::top const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::bottom const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::left const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::right const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::width const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::height const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::isHeightAuto const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::LogicalFlexItem):

Canonical link: ​https://commits.webkit.org/251260@main

6:27 AM Changeset in webkit [295202] by commit-queue@webkit.org

• 52 edits in trunk/Source/WebCore/html/canvas

WebGL extensions support code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=241229

Patch by Alexey Knyazev <​3479527+lexaknyazev@users.noreply.github.com> on 2022-06-03
Reviewed by Kenneth Russell.

• Add missing static functions, do not call supportsExtension directly
• Use the same template for all WebGL extension classes
• Remove redundant ENABLE(WEBGL) guards from various WebGL extension headers,

since those are already guarded elsewhere

• Aligned includes in OESVertexArrayObject and WebGLCompressedTextureASTC

• Source/WebCore/html/canvas/ANGLEInstancedArrays.h:
• Source/WebCore/html/canvas/EXTBlendMinMax.cpp:

(WebCore::EXTBlendMinMax::supported):

• Source/WebCore/html/canvas/EXTBlendMinMax.h:
• Source/WebCore/html/canvas/EXTFragDepth.cpp:

(WebCore::EXTFragDepth::supported):

• Source/WebCore/html/canvas/EXTFragDepth.h:
• Source/WebCore/html/canvas/EXTShaderTextureLOD.cpp:

(WebCore::EXTShaderTextureLOD::supported):

• Source/WebCore/html/canvas/EXTShaderTextureLOD.h:
• Source/WebCore/html/canvas/EXTTextureFilterAnisotropic.cpp:

(WebCore::EXTTextureFilterAnisotropic::supported):

• Source/WebCore/html/canvas/EXTTextureFilterAnisotropic.h:
• Source/WebCore/html/canvas/EXTsRGB.cpp:

(WebCore::EXTsRGB::supported):

• Source/WebCore/html/canvas/EXTsRGB.h:
• Source/WebCore/html/canvas/KHRParallelShaderCompile.h:
• Source/WebCore/html/canvas/OESElementIndexUint.cpp:

(WebCore::OESElementIndexUint::supported):

• Source/WebCore/html/canvas/OESElementIndexUint.h:
• Source/WebCore/html/canvas/OESFBORenderMipmap.h:
• Source/WebCore/html/canvas/OESStandardDerivatives.cpp:

(WebCore::OESStandardDerivatives::supported):

• Source/WebCore/html/canvas/OESStandardDerivatives.h:
• Source/WebCore/html/canvas/OESTextureFloat.h:
• Source/WebCore/html/canvas/OESTextureFloatLinear.cpp:

(WebCore::OESTextureFloatLinear::supported):

• Source/WebCore/html/canvas/OESTextureFloatLinear.h:
• Source/WebCore/html/canvas/OESTextureHalfFloat.cpp:
• Source/WebCore/html/canvas/OESTextureHalfFloat.h:
• Source/WebCore/html/canvas/OESTextureHalfFloatLinear.cpp:

(WebCore::OESTextureHalfFloatLinear::supported):

• Source/WebCore/html/canvas/OESTextureHalfFloatLinear.h:
• Source/WebCore/html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::supported):

• Source/WebCore/html/canvas/OESVertexArrayObject.h:
• Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

• Source/WebCore/html/canvas/WebGLColorBufferFloat.h:
• Source/WebCore/html/canvas/WebGLCompressedTextureASTC.cpp:
• Source/WebCore/html/canvas/WebGLCompressedTextureASTC.h:
• Source/WebCore/html/canvas/WebGLCompressedTextureATC.cpp:
• Source/WebCore/html/canvas/WebGLCompressedTextureATC.h:
• Source/WebCore/html/canvas/WebGLCompressedTextureETC.cpp:
• Source/WebCore/html/canvas/WebGLCompressedTextureETC.h:
• Source/WebCore/html/canvas/WebGLCompressedTextureETC1.cpp:
• Source/WebCore/html/canvas/WebGLCompressedTextureETC1.h:
• Source/WebCore/html/canvas/WebGLCompressedTexturePVRTC.cpp:
• Source/WebCore/html/canvas/WebGLCompressedTexturePVRTC.h:
• Source/WebCore/html/canvas/WebGLCompressedTextureS3TC.cpp:
• Source/WebCore/html/canvas/WebGLCompressedTextureS3TC.h:
• Source/WebCore/html/canvas/WebGLCompressedTextureS3TCsRGB.cpp:
• Source/WebCore/html/canvas/WebGLCompressedTextureS3TCsRGB.h:
• Source/WebCore/html/canvas/WebGLDebugRendererInfo.cpp:
• Source/WebCore/html/canvas/WebGLDebugRendererInfo.h:
• Source/WebCore/html/canvas/WebGLDebugShaders.cpp:

(WebCore::WebGLDebugShaders::supported):

• Source/WebCore/html/canvas/WebGLDebugShaders.h:
• Source/WebCore/html/canvas/WebGLDepthTexture.cpp:
• Source/WebCore/html/canvas/WebGLDepthTexture.h:
• Source/WebCore/html/canvas/WebGLDrawBuffers.h:
• Source/WebCore/html/canvas/WebGLLoseContext.cpp:
• Source/WebCore/html/canvas/WebGLLoseContext.h:
• Source/WebCore/html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

Canonical link: ​https://commits.webkit.org/251259@main

5:43 AM Changeset in webkit [295201] by Alan Bujtas

• 3 edits in trunk/Source/WebCore/layout/formattingContexts/flex

FlexLayout::LogicalFlexItem should provide setters and getters
​https://bugs.webkit.org/show_bug.cgi?id=241254

Reviewed by Antti Koivisto.

This is in preparation for adding more members to struct LogicalFlexItem.

• Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:

(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:

(WebCore::Layout::FlexLayout::computeAvailableLogicalVerticalSpace const):
(WebCore::Layout::FlexLayout::computeAvailableLogicalHorizontalSpace const):
(WebCore::Layout::FlexLayout::computeLogicalWidthForShrinkingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalWidthForFlexItems):
(WebCore::Layout::FlexLayout::computeLogicalHeightForFlexItems):
(WebCore::Layout::FlexLayout::alignFlexItems):
(WebCore::Layout::FlexLayout::justifyFlexItems):

• Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:

(WebCore::Layout::FlexLayout::LogicalFlexItem::setTop):
(WebCore::Layout::FlexLayout::LogicalFlexItem::setLeft):
(WebCore::Layout::FlexLayout::LogicalFlexItem::setWidth):
(WebCore::Layout::FlexLayout::LogicalFlexItem::setHeight):
(WebCore::Layout::FlexLayout::LogicalFlexItem::rect const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::topLeft const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::top const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::bottom const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::left const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::right const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::width const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::height const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::style const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::layoutBox const):
(WebCore::Layout::FlexLayout::LogicalFlexItem::LogicalFlexItem):

Canonical link: ​https://commits.webkit.org/251258@main

2:54 AM Changeset in webkit [295200] by Antti Koivisto

• 10 edits in trunk

Re-evaluate queries after subframe size changes
​https://bugs.webkit.org/show_bug.cgi?id=241225

Reviewed by Alan Bujtas.

Container queries in frames don't react to frame size changes.

• LayoutTests/TestExpectations:

Mark imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-size-bfc-floats.html as failure, it has ever
been passing by fluke (there are some containment issues with floats).

• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-in-container-invalidation-expected.txt:
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/iframe-invalidation-expected.txt:
• Source/WebCore/css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

Ensure we update layout when there are container queries in a subframe, similar to media queries.

• Source/WebCore/dom/Document.cpp:

(WebCore::Document::resolveStyle):
(WebCore::Document::updateLayout):

• Source/WebCore/page/FrameView.cpp:

(WebCore::FrameView::updateContentsSize):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

• Source/WebCore/page/FrameViewLayoutContext.cpp:

(WebCore::FrameViewLayoutContext::layout):

Move the container query invalidation loop to the main layout function so all paths are covered.

(WebCore::FrameViewLayoutContext::performLayout):

• Source/WebCore/page/FrameViewLayoutContext.h:
• Source/WebCore/style/StyleScopeRuleSets.cpp:

(WebCore::Style::ScopeRuleSets::hasContainerQueries const):

• Source/WebCore/style/StyleScopeRuleSets.h:

Canonical link: ​https://commits.webkit.org/251257@main

1:29 AM Changeset in webkit [295199] by Diego Pino Garcia

• 1 edit in trunk/Tools/jhbuild/jhbuild-minimal.modules

[JHBuild] Disable gnutls backend in glib-networking and enable openssl backend
​https://bugs.webkit.org/show_bug.cgi?id=239324

Reviewed by Carlos Alberto Lopez Perez.

glib-networking uses gnutls backend by default. Ubuntu 18.04's gnutls
doesn't meet the minimal version required by glib-networking. Use
openssl instead.

• jhbuild/jhbuild-minimal.modules: Use openssl backend in glib-networking.

Canonical link: ​https://commits.webkit.org/251256@main