Changes between Version 6 and Version 7 of Abandoned documents
- Timestamp:
- Aug 30, 2018 2:26:47 PM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Abandoned documents
v6 v7 5 5 All documents are referenced by Document::allDocumentsMap(), so they are not leaked in the sense that the 'leaks' tool doesn't show them. 6 6 7 = Why are layout test results showing me a list of abandoned documents? =7 = Why are layout test results showing me a list of leaked documents? = 8 8 9 9 Leaked documents usually entrain a lot of other objects, which can use lots of memory (e.g. via entries in the memory cache). Leaking documents is bad because it will cause ever-increasing memory use as the user browses. See [https://bugs.webkit.org/show_bug.cgi?id=186214] … … 15 15 = How do I debug document abandonment? = 16 16 17 Let's take an example [https://bugs.webkit.org/show_bug.cgi?id=188722]. We run tests, checking for abandonment:17 Let's take an example [https://bugs.webkit.org/show_bug.cgi?id=188722]. We run tests, checking for world leaks: 18 18 19 19 {{{ 20 run-webkit-tests fast/forms/ -- check-for-abandoned-documents20 run-webkit-tests fast/forms/ --world-leaks 21 21 }}} 22 22 23 The results say that {{{fast/forms/textarea-paste-newline.html}}} was abandoned. Now you have to figure out why this Document object is not going away.23 The results say that {{{fast/forms/textarea-paste-newline.html}}} was leaked. Now you have to figure out why this Document object is not going away. 24 24 25 25 A bit of testing in MiniBrowser can be useful, and if you're lucky, the abandonment will reproduce there. To test this, do these steps: