wiki:AddingFeatures

Version 6 (modified by dominik.rottsches@intel.com, 9 years ago) (diff)

--

Introduction

The policy for adding new (major) features to WebKit is:

  • Send an email to webkit-dev describing the feature and linking to the tracking bug
  • If necessary, add an ENABLE flag for the feature.

How to add an ENABLE flag

By adding a build definition for ENABLE_FEATURE it allows code/preprocessor to test using ENABLE(FEATURE). You'll need to edit at least the following files:

  • Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
  • Source/WebCore/Configurations/FeatureDefines.xcconfig
  • Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
  • Source/WebKit2/Configurations/FeatureDefines.xcconfig
  • Source/cmake/WebKitFeatures.cmake
  • Source/cmakeconfig.h.cmake
  • Tools/Scripts/webkitperl/FeatureList.pm
  • Tools/qmake/mkspecs/features/features.pri
  • WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
  • WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops

Note that's only permitting the feature. To actually turn it on you'll need to edit the build configurations for each port. (TODO: page describing where each configuration is?)

After adding a feature, please add it to the list in the wiki

Activating a feature for CMAKE based ports

  • Edit Source/cmake/Options<Port>.cmake, e.g. OptionsEfl.cmake and set a default value for this feature.
  • Edit Tools/Scripts/webkitperl/FeatureList.pm to default enable this for the same port, e.g add a isPort() statement to the default setting assignment.