Changes between Version 4 and Version 5 of AnalyzingBuildPerformance

Timestamp:

Oct 13, 2021, 11:28:33 AM (3 years ago)

Author:

jer.noble@apple.com

Comment:

--

AnalyzingBuildPerformance

@@ -207 +207 @@
 void MyClass::doFoo() { m_yourClass->doFoo(); }
 }}}
+
+==== Avoid Private Inlines ====
+
+Private functions, by definition, can only be called from class methods and declared friends, so defining private functions in the class header file is of limited value. If those private functions are called by friends or other inlined functions, consider moving the private function definition into an Inline.h header. Otherwise, consider moving the definition into the implementation file.
+
+Bad:
+{{{
+#!c++
+// MyClass.h
+class MyClass {
+private:
+    void doFoo() { foo(); }
+};
+}}}
+
+Good:
+{{{
+#!c++
+// MyClass.h
+class MyClass {
+private:
+    void doFoo();
+};
+
+// MyClass.cpp
+#include "MyClass.h"
+void MyClass::doFoo() { foo(); }
+}}}