| | 1 | Some answers to common commit-queue questions. |
| | 2 | |
| | 3 | === Q: What do the commit-queue states mean? === |
| | 4 | |
| | 5 | commit-queue+ // Patch is 100% ready for commit, queue should land it. (Moral equivalent of committing yourself.) |
| | 6 | commit-queue- // Patch needs manual landing (set this when you don't want any chance of auto-commit) |
| | 7 | commit-queue? // Set by non-committers to ask someone to approve their patch for auto-commit. |
| | 8 | |
| | 9 | |
| | 10 | === Q: Who can set commit-queue+ or review+? === |
| | 11 | |
| | 12 | bugzilla-tool validates that the flag setters are committers/reviewers using: |
| | 13 | http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py |
| | 14 | |
| | 15 | |
| | 16 | === Q: How long until a patch lands after I set commit-queue+? === |
| | 17 | |
| | 18 | Generally about 15 minutes. Depends on if commit-queue is running or not. |
| | 19 | |
| | 20 | |
| | 21 | === Q: What checks does commit-queue do before landing? === |
| | 22 | |
| | 23 | Everything "bugzilla-tool land-patches" does. Which is build (on Mac) and then run-webkit-tests. If you would like it to do more, please file bugs and post patches to bugzilla-tool! :) |
| | 24 | |
| | 25 | |
| | 26 | === Q: When I review a patch, should I set commit-queue+? === |
| | 27 | |
| | 28 | Yes. Unless the patch-poster is a committer or you want to commit it yourself. |
| | 29 | |
| | 30 | |
| | 31 | === Q: When I don't want my patch to be auto-landed, what should I do? === |
| | 32 | |
| | 33 | You don't need to do anything. Only commit-queue+ patches are auto-landed. Setting commit-queue- will make extra-sure. |
| | 34 | |
| | 35 | |
| | 36 | === Q: If I want my patch landed, and I'm not a committer, what do I do? === |
| | 37 | |
| | 38 | Set "commit-queue=?". A committer can set it to commit-queue+ |
