Changes between Initial Version and Version 1 of CommitQueue


Ignore:
Timestamp:
Aug 13, 2009 3:59:41 PM (13 years ago)
Author:
eric@webkit.org
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • CommitQueue

    v1 v1  
     1Some answers to common commit-queue questions.
     2
     3=== Q: What do the commit-queue states mean? ===
     4
     5commit-queue+ // Patch is 100% ready for commit, queue should land it.  (Moral equivalent of committing yourself.)
     6commit-queue- // Patch needs manual landing (set this when you don't want any chance of auto-commit)
     7commit-queue? // Set by non-committers to ask someone to approve their patch for auto-commit.
     8
     9
     10=== Q: Who can set commit-queue+ or review+? ===
     11
     12bugzilla-tool validates that the flag setters are committers/reviewers using:
     13http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py
     14
     15
     16=== Q: How long until a patch lands after I set commit-queue+? ===
     17
     18Generally about 15 minutes.  Depends on if commit-queue is running or not.
     19
     20
     21=== Q:  What checks does commit-queue do before landing? ===
     22
     23Everything "bugzilla-tool land-patches" does.  Which is build (on Mac) and then run-webkit-tests.  If you would like it to do more, please file bugs and post patches to bugzilla-tool! :)
     24
     25
     26=== Q: When I review a patch, should I set commit-queue+? ===
     27
     28Yes.  Unless the patch-poster is a committer or you want to commit it yourself.
     29
     30
     31=== Q:  When I don't want my patch to be auto-landed, what should I do? ===
     32
     33You don't need to do anything.  Only commit-queue+ patches are auto-landed.  Setting commit-queue- will make extra-sure.
     34
     35
     36=== Q: If I want my patch landed, and I'm not a committer, what do I do? ===
     37
     38Set "commit-queue=?".  A committer can set it to commit-queue+