Changes between Version 10 and Version 11 of CommitQueue


Ignore:
Timestamp:
Sep 14, 2009, 2:07:57 PM (16 years ago)
Author:
eric@webkit.org
Comment:

--

Legend:

Unmodified
Added
Removed
Modified

  • CommitQueue

    v10 v11  
     1
     2WebKit's commit-queue [wiki:"BugzillaTool" bugzilla-tool] command which is run on the commit server (maintained by Eric Seidel) and is the primary way for contributers without commit privileges to get their changes into WebKit.
     3
     4== Commit Queue Process ==
     5 1. Contributers will set "commit-queue=?" on their patches.
     6 1. A committer will set "commit-queue=+" in response.
     7 1. The commit-queue polls bugzilla for the list of cq+'d patches. When it finds one it will run `bugzilla-tool land-patches` on the bug in question.
     8
     9
    110== Commit Queue FAQ ==
    2 
    3 WebKit's commit-queue is a small shell-script wrapper around [wiki:"BugzillaTool" bugzilla-tool].  It wakes up every 10 minutes and tries to land all patches in the commit-queue using `bugzilla-tool land-patches`.
    4 
    511
    612=== Q: What do the commit-queue states mean? ===
    … …  
    212710-15 minutes.  Depends on if the tree is currently red or not (http://build.webkit.org).  The commit-queue will not commit when the buildbots are red.
    2228
    23 `commit-queue` bugs: https://bugs.webkit.org/buglist.cgi?quicksearch=commit-queue
    24 
    25 `bugzilla-tool` bugs: https://bugs.webkit.org/buglist.cgi?quicksearch=bugzilla-tool
    26 
    2729
    2830=== Q: My patch was rejected by the commit queue, what should I do!? ===
    … …  
    3335
    3436The commit-queue is still buggy.  Sometimes it rejects patches it shouldn't.  Don't worry, whoever is running the commit queue should add your patch back to the queue if it was wrongly rejected.
     37
     38`commit-queue` bugs: https://bugs.webkit.org/buglist.cgi?quicksearch=commit-queue
     39
     40`bugzilla-tool` bugs: https://bugs.webkit.org/buglist.cgi?quicksearch=bugzilla-tool
    3541
    3642
    … …  
    6975=== Q: Can I run the commit-queue myself? ===
    7076
    71 Yes.  Any committer could run the commit queue.  The wrapper process which Adam Barth and Eric Seidel have been using will soon be in SVN: https://bugs.webkit.org/show_bug.cgi?id=28040.
     77Yes.  Any committer could run the commit queue.  `bugzilla-tool commit-queue`  The commit queue is not designed to have more than one copy run at a time though.
    7278
    7379=== Q: Does the commit-queue fix the "Reviewed by NOBODY" in any ChangeLogs in the patch? ===