Changes between Version 11 and Version 12 of CommitQueue


Ignore:
Timestamp:
Sep 15, 2009 1:25:15 PM (13 years ago)
Author:
eric@webkit.org
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • CommitQueue

    v11 v12  
    11
    2 WebKit's commit-queue [wiki:"BugzillaTool" bugzilla-tool] command which is run on the commit server (maintained by Eric Seidel) and is the primary way for contributers without commit privileges to get their changes into WebKit.
     2WebKit's commit-queue [wiki:"BugzillaTool" bugzilla-tool] command which is run on the commit server (maintained by Eric Seidel) and is an easy way for contributers without commit privileges to get their changes into WebKit.
    33
    44== Commit Queue Process ==
    5  1. Contributers will set "commit-queue=?" on their patches.
    6  1. A committer will set "commit-queue=+" in response.
    7  1. The commit-queue polls bugzilla for the list of cq+'d patches. When it finds one it will run `bugzilla-tool land-patches` on the bug in question.
     5 1. Contributer set "commit-queue=?" on their patch.
     6 1. Committer sets "commit-queue=+" in response.
     7 1. commit-queue polls bugzilla for the list of cq+'d patches, finding one it runs `bugzilla-tool land-patches` on the bug in question.
    88
    99
     
    1212=== Q: What do the commit-queue states mean? ===
    1313
    14  * commit-queue=+ // Patch is 100% ready for commit, queue should land it.
     14 * commit-queue=+ // Patch is 100% ready for commit, the commit bot should land it.
    1515 * commit-queue=- // Patch needs manual landing (set this when you don't want any chance of auto-commit).
    1616 * commit-queue=? // Set by non-committers to ask someone to approve their patch for auto-commit.
     
    2525=== Q: How long until a patch lands after I set commit-queue+? ===
    2626
    27 10-15 minutes.  Depends on if the tree is currently red or not (http://build.webkit.org).  The commit-queue will not commit when the buildbots are red.
     2710-15 minutes.  Depends on if the [http://build.webkit.org/waterfall tree is red or not].  The commit-queue will not commit when buildbots for the [http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/buildbot.py#L48 core platforms] are red.
    2828
    2929
    3030=== Q: My patch was rejected by the commit queue, what should I do!? ===
    3131
    32 First, read the comment the commit queue added to the bug.
     32First, read the comment the commit queue added to the bug.  If the message is not clear, feel free to email the WebKit Commit Bot address in the bug.  There are [https://bugs.webkit.org/show_bug.cgi?id=28686 outstanding bugs] about making the commit bot's messages more clear.
    3333
    34 Eventually the commit-queue will know how to attach its failure logs to the bug: https://bugs.webkit.org/show_bug.cgi?id=28286
     34Sometimes the commit-queue rejects patches due to flakey tests.  Don't worry, whoever is running the commit queue should add your patch back to the queue if it was wrongly rejected.
    3535
    36 The commit-queue is still buggy.  Sometimes it rejects patches it shouldn't.  Don't worry, whoever is running the commit queue should add your patch back to the queue if it was wrongly rejected.
     36Outstanding bugs:
    3737
    3838`commit-queue` bugs: https://bugs.webkit.org/buglist.cgi?quicksearch=commit-queue
     
    5555=== Q: When I review a patch, should I set commit-queue+? ===
    5656
    57 Yes.  Unless the patch-poster is a committer or you want to commit it yourself.
     57If you would like the commit bot to land the patch, yes.
    5858
    5959
     
    7777Yes.  Any committer could run the commit queue.  `bugzilla-tool commit-queue`  The commit queue is not designed to have more than one copy run at a time though.
    7878
     79
    7980=== Q: Does the commit-queue fix the "Reviewed by NOBODY" in any ChangeLogs in the patch? ===
    8081
    81 Yes, it sets this based on who marked the patch as r+. It also updates the date for the changelog entry as well.
     82Yes `bugzilla-tool` calls `svn-apply` which does.  It sets the reviewer based on who marked the patch as r+. It also updates the date for the changelog entry.