Changes between Version 15 and Version 16 of CommitQueue


Ignore:
Timestamp:
Feb 18, 2010, 11:10:19 AM (15 years ago)
Author:
eric@webkit.org
Comment:

--

Legend:

Unmodified
Added
Removed
Modified

  • CommitQueue

    v15 v16  
    11
    2 WebKit's commit-queue [wiki:"BugzillaTool" bugzilla-tool] command which is run on the commit server (maintained by Eric Seidel) and is an easy way for contributers without commit privileges to get their changes into WebKit.
     2WebKit's commit-queue [wiki:"WebKitPatch" webkit-patch] command which is run on the commit server (maintained by Eric Seidel) and is an easy way for contributers without commit privileges to get their changes into WebKit.
    33
    44== Commit Queue Process ==
    55 1. Contributer set "commit-queue=?" on their patch.
    66 1. Committer sets "commit-queue=+" in response.
    7  1. commit-queue polls bugzilla for the list of cq+'d patches, finding one it runs `bugzilla-tool land-patches` on the bug in question.
     7 1. commit-queue polls bugzilla for the list of cq+'d patches, finding one it runs `webkit-patch land-from-bug` on the bug in question.
    88
    99
    … …  
    1919=== Q: Who can set commit-queue+ or review+? ===
    2020
    21 `bugzilla-tool` validates that the flag setters are committers/reviewers using:
     21`webkit-patch` validates that the flag setters are committers/reviewers using:
    2222http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py
    2323
    … …  
    3838`commit-queue` bugs: https://bugs.webkit.org/buglist.cgi?quicksearch=commit-queue
    3939
    40 `bugzilla-tool` bugs: https://bugs.webkit.org/buglist.cgi?quicksearch=bugzilla-tool
     40`webkit-patch` bugs: https://bugs.webkit.org/buglist.cgi?quicksearch=webkit-patch
    4141
    4242
    … …  
    4545[http://webkit-commit-queue.appspot.com/ commit queue status]
    4646
    47 `bugzilla-tool bugs-to-commit` is how the commit-queue checks.  That will print out any pending bugs.
     47`webkit-patch bugs-to-commit` is how the commit-queue checks.  That will print out any pending bugs.
    4848
    4949
    5050=== Q:  What checks does commit-queue do before landing? ===
    5151
    52 Everything `bugzilla-tool land-patches` does.  Which is `build-webkit` (on Mac) and then `run-webkit-tests`.  The commit-queue also checks http://build.webkit.org/ to make sure that all of the Leopard and Windows builders are green.  If you would like it to do more, please file bugs and post patches to `bugzilla-too`l! :)
     52Everything `webkit-patch land-from-bug` does.  Which is `build-webkit` (on Mac) and then `run-webkit-tests`.  The commit-queue also checks http://build.webkit.org/ to make sure that all of the Leopard and Windows builders are green.  If you would like it to do more, please file bugs and post patches to `bugzilla-too`l! :)
    5353
    5454
    … …  
    7878=== Q: Can I run the commit-queue myself? ===
    7979
    80 Yes.  Any committer could run the commit queue.  `bugzilla-tool commit-queue`  The commit queue is not designed to have more than one copy run at a time though.
     80Yes.  Any committer could run the commit queue.  `webkit-patch commit-queue`  The commit queue is not designed to have more than one copy run at a time though.
    8181
    8282
    8383=== Q: Does the commit-queue fix the "Reviewed by NOBODY" in any ChangeLogs in the patch? ===
    8484
    85 Yes `bugzilla-tool` calls `svn-apply` which does.  It sets the reviewer based on who marked the patch as r+. It also updates the date for the changelog entry.
     85Yes `webkit-patch` calls `svn-apply` which does.  It sets the reviewer based on who marked the patch as r+. It also updates the date for the changelog entry.