Changes between Version 22 and Version 23 of CommitQueue

Timestamp:

Sep 20, 2010, 7:28:52 AM (15 years ago)

Author:

Patrick Gansterer

Comment:

--

CommitQueue

@@ -48 +48 @@
 
 
-=== Q:  What checks does commit-queue do before landing? ===
+=== Q: What checks does commit-queue do before landing? ===
 
 Everything `webkit-patch land-from-bug` does.  Which is `build-webkit` (on Mac) and then `run-webkit-tests`.  The commit-queue also checks http://build.webkit.org/ to make sure builders such as the Leopard and Windows are green.  If you would like the commit-queue to block on your builder being green, please file a bug and post a patch to change the [http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/buildbot.py#L50 core_builders regexp].
@@ -57 +57 @@
 If you would like the commit bot to land the patch, yes.
 
+
 === Q: Help!  The commit queue broke the tree!  Who do I blame? ===
 
 Setting commit-queue+ on a patch is the moral equivalent of typing "svn commit" on the command line.  That means whoever set the flag to + is responsible for watching the tree and cleaning up if disaster strikes.  The proper response is normally to just roll out the change which broke the tree -- `webkit-patch rollout` can assist with this.
 
-=== Q:  When I don't want my patch to be auto-landed, what should I do? ===
+
+=== Q: When does the commit queue fix up the svn author? ===
+
+If you are a committer, and you use the commit queue, the server should fix up the author of the commit automatically, when you use your svn username in the ChangeLog. If you are not a committer, or the server can not find a vaild svn username in the commit message, commit-queue@webkit.org will be used as author.
+
+
+=== Q: When I don't want my patch to be auto-landed, what should I do? ===
 
 You don't need to do anything.  Only commit-queue+ patches are auto-landed.  Setting commit-queue- will make extra-sure.