Changes between Version 19 and Version 20 of CommitterTips
- Timestamp:
- Dec 20, 2010, 9:54:54 AM (14 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
CommitterTips
v19 v20 20 20 * [http://lists.webkit.org/mailman/listinfo.cgi/webkit-committers webkit-committers@lists.webkit.org] 21 21 * [http://lists.webkit.org/mailman/listinfo.cgi/webkit-reviewers webkit-reviewers@lists.webkit.org] (reviewers only) 22 * [http://trac.webkit.org/browser/trunk/ WebKitTools/Scripts/webkitpy/common/config/committers.py WebKitTools/Scripts/webkitpy/common/config/committers.py] (the list our scripts use to know you're a committer/reviewer)22 * [http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py Tools/Scripts/webkitpy/common/config/committers.py] (the list our scripts use to know you're a committer/reviewer) 23 23 * Your [https://bugs.webkit.org/userprefs.cgi?tab=permissions bugzilla account] needs `editbugs` set if it does not have it already (so you can change the components of bugs, etc.) Ask on webkit-committers if your account is missing this flag. 24 24 25 25 == Tools you should know to use == 26 * [http://trac.webkit.org/browser/trunk/ WebKitTools/Scripts/webkit-patch webkit-patch] see `--help` for more information. Most useful are the `land` and `upload` subcommands.26 * [http://trac.webkit.org/browser/trunk/Tools/Scripts/webkit-patch webkit-patch] see `--help` for more information. Most useful are the `land` and `upload` subcommands. 27 27 * `svn-apply` is how we apply patches from bugzilla. (`webkit-patch apply` and `webkit-patch apply-from-bug` use svn-apply under the covers.) 28 28 * `svn-apply` has various helpful flags including `--reviewer`. … … 33 33 Below are some "manual" steps for doing your first commit from an SVN checkout. In some cases, alternative commands are listed. 34 34 35 WebKit maintains several tools that simplify the commit process in many scenarios. All of these tools are scripts in the WebKitTools/Scripts directory. Nevertheless, understanding more manual forms of the process is still a good thing. Because the tools can't do everything, it helps to have the manual process to fall back on in case the tools can't do what you need.35 WebKit maintains several tools that simplify the commit process in many scenarios. All of these tools are scripts in the Tools/Scripts directory. Nevertheless, understanding more manual forms of the process is still a good thing. Because the tools can't do everything, it helps to have the manual process to fall back on in case the tools can't do what you need. 36 36 37 37 1. '''Create an account.''' … … 41 41 2. '''Configure commit-log-editor.''' 42 42 43 When using "svn commit" to submit a patch, the commit message should be the ChangeLog message(s) for the patch. WebKit maintains a script called "commit-log-editor" that populates the commit message for you. To configure the editor that commit-log-editor opens, you can set the SVN_LOG_EDITOR environment variable to the editor of your choice (e.g. nano). See the commit-log-editor source code [http://trac.webkit.org/browser/trunk/ WebKitTools/Scripts/commit-log-editor] for alternative options and to see how commit-log-editor decides what editor to use.43 When using "svn commit" to submit a patch, the commit message should be the ChangeLog message(s) for the patch. WebKit maintains a script called "commit-log-editor" that populates the commit message for you. To configure the editor that commit-log-editor opens, you can set the SVN_LOG_EDITOR environment variable to the editor of your choice (e.g. nano). See the commit-log-editor source code [http://trac.webkit.org/browser/trunk/Tools/Scripts/commit-log-editor] for alternative options and to see how commit-log-editor decides what editor to use. 44 44 45 45 3. '''Apply the patch to your local checkout.'''