Changes between Version 26 and Version 27 of CommitterTips


Ignore:
Timestamp:
Mar 9, 2012 3:52:24 AM (9 years ago)
Author:
Csaba Osztrogonác
Comment:

Add some more tips for unreviewed buildfixes

Legend:

Unmodified
Added
Removed
Modified
  • CommitterTips

    v26 v27  
    107107
    108108== Guidelines for committers ==
    109  * Build fixes do not need review.
     109 * Build fixes do not need review, but please mention in the changelog and in the original bug report '''what''' you fixed and '''which revision''' caused the fail.
     110   * examples for good comments: Buildfix after r100000 for !ENABLE(FOO) platforms. ; Typo fix after r100000. ; Revert accidentally committed lines after r100000.
     111   * examples for bad comments: Trivial GTK buildfix. ; Qt minimal buildfix. ; Revert accidentally committed lines.
    110112 * Committers are the gate-keepers of the project.  That's why you signed the agreement.  Only commit patches which have been reviewed.
    111113 * [wiki:"CodeReview" Getting your patch reviewed]