Changes between Version 2 and Version 3 of EFLWebKitCodingStyle

Timestamp:

Jan 4, 2012, 12:53:14 AM (14 years ago)

Author:

t.morawski@samsung.com

Comment:

--

EFLWebKitCodingStyle

@@ -6 +6 @@
  * Place '*' operator to data type
  * Use '''static_cast<...>''' for type casting
-
+ * Use smart pointers
+ * Use c++ new/delete operators
 
 = Example =
@@ -94 +95 @@
  Ewk_View_Smart_Data* smartData = (Ewk_View_Smart_Data*)data;
 }}}
+
+== Use smart pointers ==
+=== Right ===
+{{{
+ RefPtr<cairo_region_t> dirtyRegion = adoptRef(cairo_region_create_rectangle(&rect));
+
+ or 
+
+ OwnPtr<WebCore::Page> page = adoptPtr(new WebCore::Page(pageClients));
+}}}
+=== Wrong ===
+{{{
+ cairo_region_t* dirtyRegion = cairo_region_create_rectangle(&rect);
+ ...
+ cairo_region_destroy(dirtyRegion);
+
+ or
+
+ WebCore::Page* page = new WebCore::Page(pageClients);
+ ...
+ delete page;
+}}}
+== Use c++ new/delete operators ==
+=== Right ===
+Where it is not possible to use smart pointers. Use new/delete operators.
+{{{
+ unusedCacheEntry = new Ewk_Tile_Unused_Cache_Entry;
+ ...
+ delete unusedCacheEntry;
+}}}
+=== Wrong ===
+{{{
+ unusedCacheEntry = static_cast<Ewk_Tile_Unused_Cache_Entry*>(malloc(sizeof(Ewk_Tile_Unused_Cache_Entry)));
+ ...
+ free(unusedCacheEntry);
+}}}