Changes between Version 5 and Version 6 of EfficientStrings

Timestamp:

Aug 29, 2012 1:56:25 AM (12 years ago)

Author:

kenneth@webkit.org

Comment:

Some more hints

EfficientStrings

@@ -11 +11 @@
 The safest option is ''ASCIILiteral("Foo")''. It produces the same code size as String("Foo") while being faster.
 
-The difference between the version is if the length of the string is included or not. Having the size given in the constructor makes the constructor faster. Having the size also makes the code bigger, which is a problem when the code is executed infrequently.[[BR]]
+The difference between the version is if the length of the string is included or not. Having the size given in the constructor makes the constructor faster. Having the size also makes the code bigger, which is a problem when the code is executed infrequently.[[BR]][[BR]]
 In general, use ASCIILiteral unless you can show improvement on a benchmark by using ConstructFromLiteral.
 
@@ -21 +21 @@
  * foo.startsWith(ASCIILiteral("bar"))
  * foo.startsWith(String("bar"))
+
 The first version is the fastest.
 
@@ -32 +33 @@
 {{{
 str = text;
-str.append("a"); // == str.append(String("a");
+str.append("a"); // == str.append(String("a"));
 str.append(foo);
 str += bar;
 }}}
+
 Should be (StringOperators):
+
 {{{
 str = text + 'a' + foo + bar;
 }}}
 
+Note the use of {{{ 'a' }}} here instead of {{{ "a" }}} as it is more efficient.
 ----
 
@@ -50 +54 @@
    str += "bar";
 }}}
+
 should be:
 
@@ -59 +64 @@
 str = builder.toString();
 }}}
+
+Note: If you need to append a literal char, {{{ builder.append('c'); }}} is more efficient than {{{ builder.appendLiteral("c"); }}}