Changes between Version 7 and Version 8 of EfficientStrings

Timestamp:

Aug 29, 2012 6:18:53 PM (12 years ago)

Author:

benjamin@webkit.org

Comment:

--

EfficientStrings

@@ -7 +7 @@
  * '''String foo = ASCIILiteral("bar")''';
  * String foo("bar", String::ConstructFromLiteral);
- * AtomicString foo("bar", AtomicString::ConstructFromLiteral);
 
 The safest option is ''ASCIILiteral("Foo")''. It produces the same code size as String("Foo") while being faster.
@@ -13 +12 @@
 The difference between the version is if the length of the string is included or not. Having the size given in the constructor makes the constructor faster. Having the size also makes the code bigger, which is a problem when the code is executed infrequently.[[BR]][[BR]]
 In general, use ASCIILiteral unless you can show improvement on a benchmark by using ConstructFromLiteral.
+
+==== AtomicString from literal ====
+AtomicString should always use the full template version:
+ * AtomicString foo("bar", AtomicString::ConstructFromLiteral);
+
+The reason is that version gives the possibility to compute the hash at compile time in the future.
 
 ==== Not creating a string ====
@@ -23 +28 @@
 
 The first version is the fastest.
-
 
 === Concatenation ===