Changes between Version 19 and Version 20 of HackingWebInspector

Timestamp:

Jun 24, 2022, 1:04:28 PM (3 years ago)

Author:

Sam Sneddon

Comment:

Update for git, recommend minibrowser instead of Safari given SafariForWebDevelopment often not working

HackingWebInspector

@@ -36 +36 @@
 == Now Do Your Hacking ==
 
- 1.  [https://trac.webkit.org/wiki/UsingGitWithWebKit Using Git with WebKit]
+ 1.  [https://webkit.org/getting-the-code/ Get the Code]
 {{{
-git clone git://git.webkit.org/WebKit.git
+git clone https://github.com/WebKit/WebKit.git WebKit
 cd WebKit
 git checkout -b purple_css_values
@@ -51 +51 @@
  3. [http://webkit.org/building/run.html Run it]
 {{{
-Tools/Scripts/run-safari --release
+Tools/Scripts/run-minibrowser --release
 }}}
 
- 4. Edit `Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css` within a git repository.
+ 4. Edit `Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css` within the repo.
 
  5. Run `make -C Source/WebInspectorUI release` to copy files from `Source/WebInspectorUI/UserInterface` to the build directory. Do it after every time you modify Inspector's files.
 
- 7. Look at your changes
+ 6. Look at your changes
  {{{
 git status
@@ -64 +64 @@
  }}}
 
- 8.  [http://webkit.org/coding/contributing.html#changelogs ChangeLogs]
+ 7. [hhttps://webkit.org/contributing-code/#overview Submit a PR] and wait for a review!
  {{{
-Tools/Scripts/check-webkit-style
-Tools/Scripts/prepare-ChangeLog --bug xxxxx
-# edit Source/WebInspectorUI/ChangeLog
- }}}
-
- Instead of xxxxx you should put bug number, like [https://bugs.webkit.org/show_bug.cgi?id=32926 32926].
-
- 9. [http://webkit.org/coding/contributing.html#submit Upload a patch] and wait for a review!
- {{{
-Tools/Scripts/webkit-patch upload xxxxx -m "patch"
+git add -u
+git commit
+Tools/Scripts/git-webkit pull-request
  }}}