Changes between Version 18 and Version 19 of Rebaseline


Ignore:
Timestamp:
Jun 3, 2012 9:18:08 PM (10 years ago)
Author:
rniwa@webkit.org
Comment:

Update per TestExpectations rename

Legend:

Unmodified
Added
Removed
Modified
  • Rebaseline

    v18 v19  
    1111  * Extract baselines from the archive file for all identified files.
    1212  * Add new baselines to SVN or Git repository.
    13   * For each test that has been rebaselined, remove this platform option from the test in _test_expectation.txt_. If no other platform options remaining after removal, delete the test from the file.
     13  * For each test that has been rebaselined, remove this platform option from the test in [wiki:TestExpectations TestExpectations files]. If no other platform options remaining after removal, delete the test from the file.
    1414
    1515After new baselines are generated, the tool launches a html page to compare the old and new baselines. (EDIT: No it doesn't. See https://lists.webkit.org/pipermail/webkit-dev/2011-November/018527.html ) The html can be disabled with `--no_html_results` option.
     
    1717== How to use it? ==
    1818  * Make sure the test files exist in repository and the build bots have cycled at least once after they were committed. If you are not sure, check the Release version of [http://build.chromium.org/buildbot/layout_test_results/ buildbot layout archive] to see whether your test results are available. By default, the rebaselining tool retrieves new baselines from the release version of buildbot layout test archive.
    19   * Update `test_expectations.txt`: add flag `REBASELINE` to the tests that need to be rebaselined.
     19  * Update `TestExpectations`: add flag `REBASELINE` to the tests that need to be rebaselined.
    2020  * Run rebaselining script: `Tools/Scripts/webkit-patch rebaseline-expectations`
    21   * If the script runs successfully, new baselines (expected files) are added to SVN repository and the rebaselined tests are removed from `test_expectations.txt`.
     21  * If the script runs successfully, new baselines (expected files) are added to SVN repository and the rebaselined tests are removed from `TestExpectations`.
    2222  * The tool launches a html page to compare the old and new baselines. (EDIT: No it doesn't. See https://lists.webkit.org/pipermail/webkit-dev/2011-November/018527.html ) Check the new baseline changes are expected.
    23   * Prepare a patch with the new baselines and `test_expectations.txt`, review the changes and then commit the patch.
     23  * Prepare a patch with the new baselines and `TestExpectations`, review the changes and then commit the patch.
    2424
    2525== Examples ==
     
    2727
    2828  * If these are tests just added, make sure the layout tests ran at buildbot and the test results have been archived.
    29   * Update `test_expectations.txt` to include the following lines:
     29  * Update `TestExpectations` to include the following lines:
    3030{{{
    3131BUG1234 REBASELINE : foo1.html = FAIL
     
    3434
    3535  * Run `Tools/Scripts/webkit-patch rebaseline-expectations`.
    36   * Check that tests `foo1` and `foo2` were removed from test_expectations.txt.
     36  * Check that tests `foo1` and `foo2` were removed from TestExpectations.
    3737
    3838  * Create a patch, review the changes and commit.