Changes between Version 19 and Version 20 of UsingGitHub
- Timestamp:
- Mar 18, 2012, 5:31:43 PM (13 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
UsingGitHub
v19 v20 44 44 1. Push your lastest commits to your feature branch (e.g., `$ git push origin awesomefeature`) 45 45 1. Create a pull request by going to https://github.com/yourname/webkit/pull/new/awesomefeature 46 1. Click the "Change Commits" button to select that reviewer's WebKit repo as the "base branch". ''TODO: Investigate whether we can make reviewers members of the "WebKit" organization so we can just use WebKit/webkit@master as the base branch.''46 1. ''TODO: I'm not entirely sure how this process works if your reviewer isn't a member of the WebKit organization on GitHub.'' 47 47 1. Write a helpful description of your pull request and click "Send pull request". 48 48 1. Iterate with the reviewer as usual using GitHub's review tools.