| 38 | | == Getting your code reviewed == |
| 39 | | |
| 40 | | 1. Find a reviewer who is interested in reviewing your awesome feature. |
| 41 | | 1. Push your lastest commits to your feature branch (e.g., `$ git push origin awesomefeature`) |
| 42 | | 1. Create a pull request by going to https://github.com/yourname/webkit/pull/new/awesomefeature |
| 43 | | 1. ''TODO: I'm not entirely sure how this process works if your reviewer isn't a member of the WebKit organization on GitHub.'' |
| 44 | | 1. Write a helpful description of your pull request and click "Send pull request". |
| 45 | | 1. Iterate with the reviewer as usual using GitHub's review tools. |
| 46 | | |
| 47 | | == Landing your code == |
| 48 | | |
| 49 | | ''TODO: If we're going to use this process, we'll probably want to teach webkit-patch how to automatically fill in the ChangeLog description and "Reviewed by" lines from the pull request.'' |
| 50 | | |
| 51 | | 1. If you're landing a patch for someone else, first download and apply the patch: `$ curl https://github.com/yourname/webkit/pull/7.patch | git am` |
| 52 | | 1. `$ ./Tools/Scripts/webkit-patch upload --no-review` (Note: This will upload the current branch as one patch to a newly created bugs on https://bugs.webkit.org/.) |
| 53 | | 1. Fill in the ChangeLog description and the "Reviewed by" line from the pull request. Please also include a link to the pull request so folks can read the full discussion. |
| 54 | | 1. Go to the https://bugs.webkit.org/ bug for your patch and set the commit-queue+ flag. (If you're not a committer, you'll need to ask a committer to set that flag for you.) |
| 55 | | |
