Changes between Version 4 and Version 5 of UsingGitHub


Ignore:
Timestamp:
Mar 15, 2012 4:42:23 PM (10 years ago)
Author:
abarth@webkit.org
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • UsingGitHub

    v4 v5  
    2626== Getting your code reviewed ==
    2727
     28 1. Push your changes to a new feature branch.
    2829 1. Find a reviewer who is interested in reviewing your awesome feature.
    2930 1. Create a pull request by going to https://github.com/yourname/webkit/pull/new/awesomefeature
    30  1. Click the "Change Commits" button to select that reviewer's base branch of WebKit.
     31 1. Click the "Change Commits" button to select that reviewer's WebKit repo as the "base branch". ''TODO: Investigate whether we can make reviewers members of the "WebKit" organization so you can just use WebKit/webkit@master as the base branch.''
    3132 1. Write a helpful description of your pull request and click "Send pull request".
    3233 1. Iterate with the reviewer as usual using GitHub's review tools.
    33 
    34 ''TODO: Investigate whether we can make reviewers members of the "WebKit" organization so you can just use WebKit/webkit@master as the base branch.''
    3534
    3635== Landing a patch ==