Changes between Version 4 and Version 5 of UsingGitHub

Timestamp:

Mar 15, 2012 4:42:23 PM (12 years ago)

Author:

abarth@webkit.org

Comment:

--

UsingGitHub

@@ -26 +26 @@
 == Getting your code reviewed ==
 
+ 1. Push your changes to a new feature branch.
  1. Find a reviewer who is interested in reviewing your awesome feature.
  1. Create a pull request by going to https://github.com/yourname/webkit/pull/new/awesomefeature
- 1. Click the "Change Commits" button to select that reviewer's base branch of WebKit.
+ 1. Click the "Change Commits" button to select that reviewer's WebKit repo as the "base branch". ''TODO: Investigate whether we can make reviewers members of the "WebKit" organization so you can just use WebKit/webkit@master as the base branch.''
  1. Write a helpful description of your pull request and click "Send pull request".
  1. Iterate with the reviewer as usual using GitHub's review tools.
-
-''TODO: Investigate whether we can make reviewers members of the "WebKit" organization so you can just use WebKit/webkit@master as the base branch.''
 
 == Landing a patch ==