| | 1 | [[PageOutline]] |
| | 2 | |
| | 3 | = Export changes from WebKit to WPT = |
| | 4 | |
| | 5 | If you are working on a WebKit patch that modifies the tests located in the directory `LayoutTests/imported/w3c/web-platform-tests` you should export this changes to WPT. |
| | 6 | |
| | 7 | Any change done in this directory will be lost (if not exported to WPT) the next time those tests are re-imported from upstream WPT. |
| | 8 | |
| | 9 | The guide below describes how the process for exporting changes from WebKit to WPT works. |
| | 10 | |
| | 11 | == Process for exporting changes from WebKit to WPT == |
| | 12 | |
| | 13 | 1. Upload your original patch to the WebKit bugzilla and ask for review. |
| | 14 | 2. Create a pull-request in the [https://github.com/web-platform-tests/wpt WPT repository] with the relevant changes for WPT with the following title: |
| | 15 | {{{ |
| | 16 | WebKit export of http://bugs.webkit.org/show_bug.cgi?id=${bugidfromabove} |
| | 17 | }}} |
| | 18 | * You can use the script `Tools/Scripts/export-w3c-test-changes` to help exporting this changes to WPT. |
| | 19 | |
| | 20 | 3. Ensure that in bug from point 1. (above), you add the link to the PR from point 2. in the '''See Also''' field. |
| | 21 | * This is important, as the bot that automatically approves pull-requests from WebKit (see below) checks this. |
| | 22 | |
| | 23 | 4. Get a review (''r+'') for the WebKit patch uploaded to the bug from above (point 1.) |
| | 24 | 5. A bot will automatically approve your WPT PR linked to this WebKit bug: |
| | 25 | * There is a bot watching all PRs on WPT with the title "WebKit export of.." |
| | 26 | * So, once you get review (''r+'') for your patch on WebKit, this bot will automatically approve the PR on WPT. |
| | 27 | * In order for this process to work you should take into account this two things: |
| | 28 | * The title of the PR in WPT has to be this: `WebKit export of http://bugs.webkit.org/show_bug.cgi?id=${bugidfromabove}` |
| | 29 | * The bug in WebKit from above (point 1.) has to have a link to the WPT PR in the '''See Also''' field. |
| | 30 | * You need to get reviewed (''r+'') the patch in the WebKit bug |
| | 31 | 6. Land the PR in WPT |
| | 32 | 7. Finally land the patch in WebKit |
| | 33 | |
| | 34 | |
| | 35 | |
