Version 3 (modified by 5 years ago) ( diff ) | ,
---|
Export changes from WebKit to WPT
If you are working on a WebKit patch that modifies the tests located in the directory LayoutTests/imported/w3c/web-platform-tests
you should export this changes to WPT.
Any change done in this directory will be lost (if not exported to WPT) the next time those tests are re-imported from upstream WPT.
The guide below describes how the process for exporting changes from WebKit to WPT works.
Process for exporting changes from WebKit to WPT
- Upload your original patch to the WebKit bugzilla and ask for review.
- Create a pull-request in the WPT repository with the relevant changes for WPT with the following title:
WebKit export of http://bugs.webkit.org/show_bug.cgi?id=${bugidfromabove}
- You can use the script
Tools/Scripts/export-w3c-test-changes
to help exporting this changes to WPT.- This script will try to automatically create a WPT PR from your WebKit patch, but sometimes it fails. So you may need to export the changes and create the WPT PR manually.
- You can use the script
- Ensure that in bug from point 1. (above), you add the link to the PR from point 2. in the See Also field.
- This is important, as the bot that automatically approves pull-requests from WebKit (see below) checks this.
- Get a review (r+) for the WebKit patch uploaded to the bug from above (point 1.)
- A bot will automatically approve your WPT PR linked to this WebKit bug:
- There is a bot watching all PRs on WPT with the title "WebKit export of.."
- So, once you get review (r+) for your patch on WebKit, this bot will automatically approve the PR on WPT.
- In order for this process to work you should take into account this two things:
- The title of the PR in WPT has to contain the URL to the WebKit bug. Its recommended to use the format:
WebKit export of http://bugs.webkit.org/show_bug.cgi?id=${bugidfromabove}
- The bug in WebKit from above (point 1.) has to have a link to the WPT PR in the See Also field.
- You need to get reviewed (r+) the patch in the WebKit bug
- The title of the PR in WPT has to contain the URL to the WebKit bug. Its recommended to use the format:
- Land the PR in WPT
- Finally land the patch in WebKit
Note:
See TracWiki
for help on using the wiki.