Preparing for 2.20.0

WebkitGTK+ 2.20.0 will be the next release in the stable series (following 2.18.x). We should merge not overly intrusive patches that improve stability or performance, fix build issues, etc. We branched at r228090(05/02/18).

When filing bugs (​http://bugs.webkit.org) against stable release, please prefix them with "[GTK] [Stable]" to ensure they are addressed with high priority. Also, running a debug build and including stack traces is highly encouraged. (Don't use "[Stable]" if the bug also applies to master, though.)

To get the stable branch code, simply check out ​http://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.20

Over the next few weeks we'll be merging important fixes into the branch, so be sure to stay up to date. Thanks for your help!

Proposed merges for 2.20.5

• ​https://trac.webkit.org/changeset/233792 Web Inspector: Type token positioning should use line/column locations from Esprima instead of offsets
• ​https://trac.webkit.org/changeset/233817 Web Inspector: Execution highlighting in the frontend should be line/column-based
• ​https://trac.webkit.org/changeset/233820 Web Inspector: Basic blocks highlighting should use line/column locations instead of offsets
• ​https://trac.webkit.org/changeset/233824 Web Inspector: REGRESSION (r195723): Improve support for resources with '\r' and '\r\n' line endings

Proposed merges for 2.20.4

• ​https://trac.webkit.org/changeset/232832 [WPE] Trying to access the remote inspector hits an assertion in the UIProcess
• ​https://trac.webkit.org/changeset/230662 Function.prototype.caller shouldn't return generator bodies
• ​https://trac.webkit.org/changeset/232816 [LLInt] use loadp consistently for get_from_scope/put_to_scope
• ​https://trac.webkit.org/changeset/232883 Unreviewed, rolling out r232816.
• ​https://trac.webkit.org/changeset/233080 Unreviewed manual rollout of r230950

• ​https://trac.webkit.org/changeset/233193 [GTK] Many webpages can crash the browser in WebCore::CoordinatedGraphicsLayer::transformedVisibleRect
• ​https://trac.webkit.org/changeset/233353 [WPE] Some frames are dropped when using rAF to animate an element
• ​https://trac.webkit.org/changeset/233404 Fix off-by-one error in xdg_mime_get_simple_globs

Proposed merges for 2.20.3

• ​https://trac.webkit.org/changeset/231631 [GTK] gtk-doc installation subdir duplicated
• ​https://trac.webkit.org/changeset/232059 Define GIGACAGE_ALLOCATION_CAN_FAIL on Linux
• ​https://trac.webkit.org/changeset/232062 Unreviewed, rolling out r231843.
• ​https://trac.webkit.org/changeset/232067 [CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64-bit atomic operations
• ​https://trac.webkit.org/changeset/232397 [GTK] Crash in WebKitFaviconDatabase when pageURL is unset
• ​https://trac.webkit.org/changeset/232618 [GTK][WPE] Wrong result when calling ImageBufferCairo's getImageData()
• ​https://trac.webkit.org/changeset/232667 [WPE][GTK] paypal.com requires user agent quirk

• ​https://bugs.webkit.org/show_bug.cgi?id=182622#c30 [CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64-bit atomic operations
• ​https://trac.webkit.org/changeset/230254 [WTF] Remove Atomics.cpp
• ​https://trac.webkit.org/changeset/231801 [WPE] Build failure with RPi userland drivers and gstreamer-gl
• ​https://trac.webkit.org/changeset/231804 Add missing header to fix build.
• ​https://trac.webkit.org/changeset/231917 [WPE] Implement and enable FULLSCREEN_API

Proposed merges for 2.20.2

• ​https://trac.webkit.org/changeset/229505 Turn off offset*/scroll* optimization for input elements with shadow content
• ​https://trac.webkit.org/changeset/230954 REGRESSION(r230950): Faulty commit sequencing in CoordinatedGraphicsScene''
  • (Depends on previous r230950 backport below, but it won't apply directly, a backport for ​2.20 branch has already been done and is available here )
• ​https://trac.webkit.org/changeset/230950 [CoordGraphics] Avoid painting backing stores for zero-opacity layers
• ​https://trac.webkit.org/changeset/230380 Use alignas instead of compiler-specific attributes
• ​https://trac.webkit.org/changeset/230627 [GTK] [gstreamer] video won't unpause when built with -DUSE_GSTREAMER_GL=OFF
• ​https://trac.webkit.org/changeset/230629 REGRESSION(r230627): [GTK][WPE] Possible deadlock when destroying the player in non AC mode

Proposed merges for 2.20.1

• ​https://trac.webkit.org/changeset/229499 AX: AOM: More accessibility events support - this change is a follow-up to the change adding more accessibility events support. It's a sanity check to prevent a crash resulting from calling updateBackingStore when the AXObjectCache object is gone and is a check which makes sense independent of AOM.
• ​https://trac.webkit.org/changeset/229282 [CMake] Split JSC header copying into public and private targets - broke builds with -j1 - requested by j_v on #webkitgtk+
• ​https://trac.webkit.org/changeset/229669 Improve error message when Gigacage cannot allocate virtual memory
• ​https://trac.webkit.org/changeset/229721 REGRESSION(r225340): WPE port should not be getting EGL X11 types on ANGLE
• ​https://trac.webkit.org/changeset/229848 [WPE][GTK] Build failure when ENABLE_VIDEO, ENABLE_WEB_AUDIO and ENABLE_XSLT are disabled
• ​https://trac.webkit.org/changeset/229866 [WPE] Enable WOFF2 support
• ​https://trac.webkit.org/changeset/229894 WebProcess memory monitor thresholds should be better tuned for embedded systems.
• ​https://trac.webkit.org/changeset/229965 WebProcess memory monitor: use %zu format specifier for size_t
• ​https://trac.webkit.org/changeset/229971 [GTK] WebKitWebProcessEnumTypes.h missing from webkit-web-extension.h
• ​https://trac.webkit.org/changeset/230205 Make SecurityOrigin safe to create and use from any thread

Proposed merges for 2.19.92

• ​https://trac.webkit.org/changeset/228336 Web Inspector: Object.shallowEqual always fails when comparing array property values
• ​https://trac.webkit.org/changeset/228349 ImageBitmapRenderingContext should be Runtime guarded
• ​https://trac.webkit.org/changeset/228522 [WPE] Unify build of platform-specific files in WebKit layer
• ​https://trac.webkit.org/changeset/228594 Remove UTF-32 BOM parsing code
• ​https://trac.webkit.org/changeset/228720 Don't mark an array profile out of bounds for the cases where the DFG will convert the access to SaneChain
• ​https://trac.webkit.org/changeset/228724 null m_lastNodeInserted dereference at ReplaceSelectionCommand::InsertedNodes::lastLeafInserted
• ​https://trac.webkit.org/changeset/228725 Don't use JSFunction's allocation profile when getting the prototype can be effectful
• ​https://trac.webkit.org/changeset/228796 [GTK] whatsapp web blurry in some parts, sharp on others
• ​https://trac.webkit.org/changeset/228826 [GTK][CMake] Support building with Enchant 2.x
• ​https://trac.webkit.org/changeset/228851 Crash under JSC::JSCell::toNumber(JSC::ExecState*)
• ​https://trac.webkit.org/changeset/228860 DFG::VarargsForwardingPhase should eliminate getting argument length
• ​https://trac.webkit.org/changeset/228888 [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower
• ​https://trac.webkit.org/changeset/228934 ResourceRequestBase::isolatedCopy() fails to isolate copy the cachePartition
• ​https://trac.webkit.org/changeset/228937 Web Inspector: REGRESSION (r228349): ImageBitmap builtin is now runtime guarded
• ​https://trac.webkit.org/changeset/228944 [GStreamer] media/video-src-blob-using-open-panel.html crashes in Debug
• ​https://trac.webkit.org/changeset/228945 [GStreamer] HTTP totalBytes query returns 0 after seeking (sometimes)
• ​https://trac.webkit.org/changeset/229061 Potential privacy issue: DNS prefetching can be re-enabled
• ​https://trac.webkit.org/changeset/229155 [CMake] configure failure for aarch64
• ​https://trac.webkit.org/changeset/229203 [l10n] Updated Indonesian translation for WebKitGTK+

Proposed merges for 2.19.91

• ​https://trac.webkit.org/changeset/228091 Unreviewed, rolling out r228085.
• ​http://trac.webkit.org/changeset/228096 Crash on sfgate.com because mismatching link preload types
• ​http://trac.webkit.org/changeset/228152 Avoid unnecessarily constructing RunLoops for GC AutomaticThreads in Connection::sendMessage() after r228001
• ​http://trac.webkit.org/changeset/228193 put_to_scope/get_from_scope should not cache lexical scopes when expecting a global object
• ​http://trac.webkit.org/changeset/228257 REGRESSION(r227758): Webpage fails to load due to crash in com.apple.WebKit: WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse + 267
• ​http://trac.webkit.org/changeset/228258 ASSERTION FAILED: vm->currentThreadIsHoldingAPILock() seen with http/tests/paymentrequest/payment-request-show-method.https.html
• ​https://trac.webkit.org/changeset/228265 [GStreamer][WebAudio] No need for version check in each loop iteration
• ​https://trac.webkit.org/changeset/228271 [GStreamer] LayoutTest webaudio/silent-audio-interrupted-in-background.html makes its subsequent test flaky crash
• ​https://trac.webkit.org/changeset/228272 [GTK] WaylandCompositor misusing eglGetProcAddress
• ​https://trac.webkit.org/changeset/228279 AX: Defer attribute computation until needed.
• ​https://trac.webkit.org/changeset/228281 [GStreamer] WebKit improperly handles missing GStreamer elements
• ​http://trac.webkit.org/changeset/228299 Form submission after navigation fails when decidePolicyForNavigationAction is async
• ​https://trac.webkit.org/changeset/228321 [GStreamer][WebAudio] Winamp2-js woes
• ​http://trac.webkit.org/changeset/228368 [GTK] Scrolling sometimes jumps around
• ​http://trac.webkit.org/changeset/228373 [GTK] Unify builds for platform-specific files in WebKit layer
• ​http://trac.webkit.org/changeset/228378 [l10n] Updated Polish translation of WebKitGTK+ for 2.20
• ​http://trac.webkit.org/changeset/228401 DFG::emitCodeToGetArgumentsArrayLength needs to handle NewArrayBuffer/PhantomNewArrayBuffer
• ​http://trac.webkit.org/changeset/228430 REGRESSION (r228299): Broke reader mode in Safari
• ​http://trac.webkit.org/changeset/228435 Crash when breakpoint hit in unload handler
• ​http://trac.webkit.org/changeset/228436 [YarrJIT][ARM] We need to save r8 as it is the initial start register
• ​http://trac.webkit.org/changeset/228454 putDirectIndexSlowOrBeyondVectorLength needs to convert to dictionary indexing mode always if attributes are present
• ​http://trac.webkit.org/changeset/228476 CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot + 618
• ​http://trac.webkit.org/changeset/228481 REGRESSION(225695) : com.apple.WebKit.WebContent at com.apple.JavaScriptCore: JSC::RegExp::match + 630 :: stack overflow
• ​http://trac.webkit.org/changeset/228488 Setting a VMTrap shouldn't look at topCallFrame since that may imply we're in C code and holding the malloc lock
• ​https://trac.webkit.org/changeset/228560 IndexedDB: Several test crash in when destroying a IDBKeyData
• ​https://trac.webkit.org/changeset/228561 fast/frames/sandboxed-iframe-navigation-top-denied.html is crashing in Inspector::createScriptCallStackForConsole::Exec for GTK
• ​https://trac.webkit.org/changeset/228608 [GTK][WPE] Fullscreen video is broken
• ​https://trac.webkit.org/changeset/228609 REGRESSION(r219298): RELEASE_ASSERT(!m_owningPointerForClose) fails in WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose
• ​https://trac.webkit.org/changeset/228639 [GStreamer] Crash in WebCore::MediaPlayerRequestInstallMissingPluginsCallback::complete
• ​https://trac.webkit.org/changeset/228641 [GTK][GStreamer] Replaying a webm video twice causes the video to stop getting rendered

Changes on track

Previous versions

For changes in older stable branches see: 2.18.x

Useful commands

To get a wiki-formated list of commits that just got merged:

 $ git log --pretty=oneline <commit>.. | cut -d ' ' -f 5- | sed "s,\(.\+\)\(https://bugs.*\),  * ~~[\2] ''\1''~~,"

How to add a webkit-2.20 branch to existing git-svn clone

If you have already cloned ​git://git.webkit.org/WebKit.git, it only contains a git-svn clone of the svn trunk. To add webkit-2.20 branch to there, add a new remote to .git/config:

[svn-remote "webkit-2.20"]
    url = http://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.20
    fetch = :refs/remotes/git-svn-webkit-2.20

and run the following commands:

git svn fetch webkit-2.20 -r 228090
git branch webkit-2.20 git-svn-webkit-2.20
git checkout webkit-2.20
git svn rebase