Preparing for 2.24.0

WebKitGTK and WPE 2.24.0 will be the next release in the stable series (following 2.22.x). We should merge not overly intrusive patches that improve stability or performance, fix build issues, etc. We branched at r241292 (12/02/19).

When filing bugs (​http://bugs.webkit.org) against stable release, please prefix them with "[GTK] [Stable]" (or "[WPE] [Stable]") to ensure they are addressed with high priority. Also, running a debug build and including stack traces is highly encouraged. (Don't use "[Stable]" if the bug also applies to master, though.)

To get the stable branch code, simply check out ​http://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.24 Over the next few weeks we'll be merging important fixes into the branch, so be sure to stay up to date. Thanks for your help!

Proposed merges for 2.24.3

• ​https://trac.webkit.org/changeset/245848 [MSE][GStreamer] update the readyState correctly in MediaPlayerPrivateGStreamerMSE
• ​https://trac.webkit.org/changeset/243690 Build failure after r243644 in GTK Linux 64-bit stable builds
• ​https://trac.webkit.org/changeset/245514 [GLIB] Crash when instantiating a js object registered with jsc_context_register_class on window object cleared
• ​https://trac.webkit.org/changeset/245676 [WPE] Build fails with ENABLE_VIDEO=OFF and ENABLE_WEB_AUDIO=OFF
• ​https://trac.webkit.org/changeset/245681 Fix a few missing header inclusions often masked by by unified sources

• ​https://trac.webkit.org/changeset/246151 aarch64: ‘JSC::ARM64Assembler::LinkRecord::<unnamed union>::RealTypes::m_compareRegister’ is too small to hold all values of ‘JSC::ARM64Assembler::RegisterID’ {aka ‘enum JSC::ARM64Registers::RegisterID’}
• ​https://trac.webkit.org/changeset/246353 [WPE][GTK] Deprecate WebSQL APIs
• ​https://trac.webkit.org/changeset/246399 [GStreamer] HLS stream slow start

Proposed merges for 2.24.2

• ​https://trac.webkit.org/changeset/244108 [WPE] Avoid async IO starving timers
• ​https://trac.webkit.org/changeset/244109 [GStreamer] Adaptive streaming playback broken with GStreamer < 1.12
• ​https://trac.webkit.org/changeset/244111 there is no vp8 support in youtube.com/html5 page with libwebkit2gtk 2.24 (MSE enabled)
• ​https://trac.webkit.org/changeset/244584 [GStreamer] Crash in AudioTrackPrivate with playbin3 enabled
• ​https://trac.webkit.org/changeset/244587 [GTK][GStreamer] Flaky ASSERTION FAILED: m_lock.isHeld() in TextureMapperPlatformLayerProxy
• ​https://trac.webkit.org/changeset/244640 [REGRESSION(r243197)][GStreamer] http/tests/media/clearkey/collect-webkit-media-session.html hits an ASSERT
• ​https://trac.webkit.org/changeset/244641 [GStreamer] gst_element_get_state: assertion 'GST_IS_ELEMENT (element)' failed in WebCore::MediaPlayerPrivateGStreamer::paused
• ​https://trac.webkit.org/changeset/244649 [GTK] Back/Forward gesture interferes with scrolling
• ​https://trac.webkit.org/changeset/244138 Unreviewed, rolling out r243989.
• ​https://trac.webkit.org/changeset/245054 REGRESSION(r243197): [GStreamer] Error playing redirected streams
• ​https://trac.webkit.org/changeset/245055 [GTK] Pinch Zooming has no maximum

• ​https://trac.webkit.org/changeset/242749 [macOS] Dispatching reentrant "contextmenu" events may cause crashes
• ​https://trac.webkit.org/changeset/242838 REGRESSION (iOS 12.2): Webpage using CoffeeScript crashes
• ​https://trac.webkit.org/changeset/243605 [SimpleLineLayout] Disable SLL when text-underline-position is not auto.
• ​http://trac.webkit.org/changeset/243660 [Simple line layout] Turn off inline boxtree generation for multiline content
• ​http://trac.webkit.org/changeset/243786 REGRESSION (r238266): Exchange 2013 Outlook Web Access displays partially blank page when creating new e-mail
• ​https://trac.webkit.org/changeset/243819 Remove support for -apple-trailing-word
  • ​https://trac.webkit.org/changeset/243841 -apple-trailing-word is needed for browser detection
• ​https://trac.webkit.org/changeset/241918 Same Site Lax cookies are not sent with cross-site redirect from client-initiated load
  • ​http://trac.webkit.org/changeset/241931 Fix the test failure following r241918
• ​https://trac.webkit.org/changeset/244079 Clean up Int52 code and some bugs in it
  • ​https://trac.webkit.org/changeset/244238 r244079 logically broke shouldSpeculateInt52
  • ​https://trac.webkit.org/changeset/244287 mergeOSREntryValue is wrong when the incoming value does not match up with the flush format
• ​https://trac.webkit.org/changeset/244314 SafeToExecute for GetByOffset/GetGetterByOffset/PutByOffset is using the wrong child for the base
• ​http://trac.webkit.org/changeset/244358 REGRESSION(r238168) Web Inspector: <iframe src=...> request does not show up in Network Tab
• ​https://trac.webkit.org/changeset/244884 Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
• ​https://trac.webkit.org/changeset/244892 Setting a frame's src to a javascript URL should not run it synchronously
• ​https://trac.webkit.org/changeset/244950 TypedArrays should not store properties that are canonical numeric indices
• ​https://trac.webkit.org/changeset/244996 [JSC] We should check OOM for description string of Symbol
• ​https://trac.webkit.org/changeset/245047 JSC: A bug in BytecodeGenerator::emitEqualityOpImpl
• ​https://trac.webkit.org/changeset/245051 [JSC] DFG_ASSERT failed in lowInt52
• ​https://trac.webkit.org/changeset/245056 Correct delayed load event handling
  • ​https://trac.webkit.org/changeset/245142 Correct delayed load event handling
• ​https://trac.webkit.org/changeset/245071 Invalid DFG JIT genereation in high CPU usage state
• ​https://trac.webkit.org/changeset/245158 Do not mix inline and block level boxes.
• ​https://trac.webkit.org/changeset/245182 [WPE] Forward libepoxy cflags
• ​https://trac.webkit.org/changeset/245196 Streamline test-and-clear operation for ContextMenu
• ​https://trac.webkit.org/changeset/245284 Protect current WebFrame during form submission
• ​https://trac.webkit.org/changeset/245300 Do not try to issue repaint while the render tree is being destroyed.
• ​https://trac.webkit.org/changeset/245361 Do not create a shape object outside of the layout context

Proposed merges for 2.24.1

• ​https://trac.webkit.org/changeset/242788 [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
• ​https://trac.webkit.org/changeset/242917 Fix an edge case where HTMLFormElement::removeFormElement is invoked twice with the same element
• ​https://trac.webkit.org/changeset/242919 Use RenderBox::previousSiblingBox/nextSiblingBox in RenderMultiColumnFlow
• ​https://trac.webkit.org/changeset/242921 [WeakPtr] RenderListMarker::m_listItem should be a WeakPtr
• ​https://trac.webkit.org/changeset/242943 Cleanup inline boxes when list marker gets blockified
• ​https://trac.webkit.org/changeset/242964 Storing a Node in Ref/RefPtr inside its destructor results in double delete
• ​https://trac.webkit.org/changeset/243058 [GStreamer] Rewrite HTTP source element using pushsrc base class
  • ​https://trac.webkit.org/changeset/243140 REGRESSION(r243058): [GStreamer] 3 tests now timing out
  • ​https://trac.webkit.org/changeset/243197 [GStreamer] Switch back to webkitwebsrc for adaptive streaming fragments downloading
• ​https://trac.webkit.org/changeset/243069 Structure::flattenDictionary() should clear unused property slots.
• ​https://trac.webkit.org/changeset/243175 Reparenting during a mutation event inside appendChild could result in a circular DOM tree
  • ​https://trac.webkit.org/changeset/243182 Rebaseline the test after r243175. It got somehow landed with failing expectations.
• ​https://trac.webkit.org/changeset/243280 Cap length of an array with spread to MIN_ARRAY_STORAGE_CONSTRUCTION_LENGTH.
• ​https://trac.webkit.org/changeset/243291 Fix possible memory leak when dismissing a color picker
• ​https://trac.webkit.org/changeset/243233 appendChild should throw when inserting an ancestor of a template into its content adopted to another document
• ​https://trac.webkit.org/changeset/243331 Do not insert the first-letter anonymous container until after we've constructed the first-letter renderer.
• ​https://trac.webkit.org/changeset/243341 Inband Text Track cues interspersed with Data cues can display out of order.
• ​https://trac.webkit.org/changeset/243434 [GTK][WPE] Do not allow changes in active URI before provisional load starts for non-API requests
• ​https://trac.webkit.org/changeset/243505 Assertion failure !isInAcceleratedCompositingMode() in DrawingAreaProxyCoordinatedGraphics::incorporateUpdate when forceCompositingMode is turned on
• ​https://trac.webkit.org/changeset/243506 vertexAttribPointer must restrict offset parameter
• ​https://trac.webkit.org/changeset/243602 [FreeType] Incorrect application of glyph positioning in the Y direction
• ​https://trac.webkit.org/changeset/243608 [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
• ​https://trac.webkit.org/changeset/243639 BackwardsGraph needs to consider back edges as the backward's root successor
• ​https://trac.webkit.org/changeset/243804 Get rid of HTMLInputElement::setEditingValue
• ​https://trac.webkit.org/changeset/243820 Crash in HTMLCanvasElement::createContext2d after the element got adopted to a new document
• ​https://trac.webkit.org/changeset/243828 Documents can be destroyed before their CSSFontFaceSet is destroyed
• ​https://trac.webkit.org/changeset/243860 [ATK] Don't touch accessibility tree in WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld

• ​https://trac.webkit.org/changeset/243538 Build failure with gstreamer 1.12.5 if USE_GSTREAMER_GL is enabled
• ​https://trac.webkit.org/changeset/243492 [WPE][Qt] Uninitialized racy ViewBackend
• ​https://trac.webkit.org/changeset/243489 [GStreamer] Sound loop with Google Hangouts and WhatsApp notifications
• ​https://trac.webkit.org/changeset/243372 [MSE][GStreamer] Don't construct segments on PlaybackPipeline::flush
• ​https://trac.webkit.org/changeset/243199 [MSE][GStreamer] Fix handling of resolution changes in AppendPipeline
• ​https://trac.webkit.org/changeset/243138 [MSE] Use tolerance in eraseBeginTime
• ​https://trac.webkit.org/changeset/243104 REGRESSION(r236862): early frame decoupling leaves JSC ArrayBuffer objects lingering

Proposed merges for 2.24.0

• ​https://trac.webkit.org/changeset/242637 [GTK] Make Tools/gtkdoc/ python3 compatible
• ​https://trac.webkit.org/changeset/242793 [GStreamer][v4l2] Synchronous video texture flushing support

Proposed merges for 2.23.92

• ​https://trac.webkit.org/changeset/242349 [GLib] Returning G_TYPE_OBJECT from a constructor does not work
• ​https://trac.webkit.org/changeset/242033 [WPE] Add support for holepunch using an external video player
• ​https://trac.webkit.org/changeset/241952 [GTK] Navigation gesture improvements
• ​https://trac.webkit.org/changeset/242082 [WPE] Add API for webview background color configuration
• ​https://trac.webkit.org/changeset/242084 [EGL] Runtime support for RGB565 pixel layout

Changes on track

Previous versions

For changes in older stable branches see: 2.22.x

Useful commands

To get a wiki-formated list of commits that just got merged:

 $ git log --pretty=oneline <commit>.. | cut -d ' ' -f 5- | sed "s,\(.\+\)\(https://bugs.*\),  * ~~[\2] ''\1''~~,"

How to add a webkit-2.24 branch to existing git-svn clone

If you have already cloned ​git://git.webkit.org/WebKit.git, it only contains a git-svn clone of the svn trunk. To add webkit-2.24 branch to there, add a new remote to .git/config:

[svn-remote "webkit-2.24"]
    url = http://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.24
    fetch = :refs/remotes/git-svn-webkit-2.24

and run the following commands:

git svn fetch webkit-2.24 -r 241292
git branch webkit-2.24 git-svn-webkit-2.24
git checkout webkit-2.24
git svn rebase