(courtesy of Martin Robinson, who introduced the notion of Garderner in WebKit world of fame)
- Keep the tree green: the gardener on a given day will diagnose all bot redness and try to form a hypothesis for each failure. In my experience there are several types of failures:
- The GTK+ port is lacking some feature or has a bug: In this case the gardener will figure out exactly what the problem is, open a bug with as much information as possible including test diffs and links to relevant bugs. The gardener will CC any people involved in WebKitGTK+ who would might know how to fix the problem.
- A test is exposing a general WebKit bug that only GTK+ triggers (often the case with JavaScriptCore and inspector tests): In this case the gardener will leave a comment on the original bug with the test diff or stack trace (for something like an assertion failure) and offer to gather more information for the original patch author (even resorting to debugging directly on the bots if it cannot be reproduced locally).
- A test is missing expectations or needs new expectations: The gardener will generate new expectations after verifying that the tests seem to work when run manually or by looking at the expected results.
- A DRT feature is missing: The gardener will open a bug. The idea is that we will completely avoid skipped tests with no information about the failure.
- If the tree isn't red, the gardener should be able to choose how to spend the day:
- Generating results for tests that do not have results (soon this will include pixel results as well).
- Diagnosing and opening bugs for failures that do not have open bugs (there's a huge list). This also includes unskipping tests that are passing.
- Implementing missing DRT features. There are a ton of these and we need to kill them. Using DRTSupportGtk we can do it without making API decisions.
- At the end of the day the gardener should keep a very simple log for tomorrow's gardener, so he/she can follow up with any pending investigations. This will also help us keep track of newly skipped tests. See the Gardening log entry at the bottom of this wiki page.
Check also chrome gardening instructions: http://dev.chromium.org/developers/how-tos/webkit-gardening
Gardening schedule
| Day | Gardener
|
|---|
| Mon 07 Apr | clopez
|
| Tue 08 Apr | clopez
|
| Wed 09 Apr | aperez
|
| Thu 10 Apr | dpino
|
| Fri 11 Apr | eocanha
|
| Sat 12 Apr |
|
| Sun 13 Apr |
|
| Mon 14 Apr | elima
|
| Tue 15 Apr | ltilve
|
| Wed 16 Apr |
|
| Thu 17 Apr | tanty
|
| Fri 18 Apr |
|
| Sat 19 Apr |
|
| Sun 20 Apr |
|
| Mon 21 Apr |
|
| Tue 22 Apr | ltilve
|
| Wed 23 Apr |
|
| Thu 24 Apr | tanty
|
| Fri 25 Apr |
|
| Sat 26 Apr |
|
| Sun 27 Apr |
|
| Mon 28 Apr |
|
| Tue 29 Apr | ltilve
|
| Wed 30 Apr |
|
| Thu 01 May | tanty
|
| Fri 02 May |
|
| Sat 03 May |
|
| Sun 04 May |
|
| Mon 05 May |
|
| Tue 06 May |
|
| Wed 07 May |
|
Gardening log
- Please put new log entries at the top.
Done:
- Opened the following bugs:
- Updated the following test expectations:
Pending:
- Check the remaining failures.
-- eocanha@igalia.com - Fri Apr 11 2014
|
Done:
- Checked both text-only and image-only failures on r167072
- Opened the following bugs:
- Updated the following test expectations:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Thu Apr 10 2014
|
Done:
- Checked the status of
garden-o-matic:
- Works fine for WebKitGTK+ port when using a Git clone.
- Usage instructions in the Rebaseline page.
aperez@igalia.com - Wed 9 Apr 2014
|
Done:
- Started checking the reported Unexpected text-only failures on r166926
- Opened the following bugs:
- Updated test expectations accordingly and rebaselined one test:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Tue Apr 8 2014
|
|
