(courtesy of Martin Robinson, who introduced the notion of Garderner in WebKit world of fame)
- Keep the tree green: the gardener on a given day will diagnose all bot redness and try to form a hypothesis for each failure. In my experience there are several types of failures:
- The GTK+ port is lacking some feature or has a bug: In this case the gardener will figure out exactly what the problem is, open a bug with as much information as possible including test diffs and links to relevant bugs. The gardener will CC any people involved in WebKitGTK+ who would might know how to fix the problem.
- A test is exposing a general WebKit bug that only GTK+ triggers (often the case with JavaScriptCore and inspector tests): In this case the gardener will leave a comment on the original bug with the test diff or stack trace (for something like an assertion failure) and offer to gather more information for the original patch author (even resorting to debugging directly on the bots if it cannot be reproduced locally).
- A test is missing expectations or needs new expectations: The gardener will generate new expectations after verifying that the tests seem to work when run manually or by looking at the expected results.
- A DRT feature is missing: The gardener will open a bug. The idea is that we will completely avoid skipped tests with no information about the failure.
- If the tree isn't red, the gardener should be able to choose how to spend the day:
- Generating results for tests that do not have results (soon this will include pixel results as well).
- Diagnosing and opening bugs for failures that do not have open bugs (there's a huge list). This also includes unskipping tests that are passing.
- Implementing missing DRT features. There are a ton of these and we need to kill them. Using DRTSupportGtk we can do it without making API decisions.
- At the end of the day the gardener should keep a very simple log for tomorrow's gardener, so he/she can follow up with any pending investigations. This will also help us keep track of newly skipped tests. See the Gardening log entry at the bottom of this wiki page.
Check also chrome gardening instructions: http://dev.chromium.org/developers/how-tos/webkit-gardening
Gardening schedule
| Day | Gardener
|
|---|
| Fri 01 Aug | clopez
|
| Sat 02 Aug |
|
| Sun 03 Aug |
|
| Mon 04 Aug | clopez
|
| Tue 05 Aug |
|
| Wed 06 Aug |
|
| Thu 07 Aug |
|
| Fri 08 Aug |
|
| Sat 09 Aug |
|
| Sun 10 Aug |
|
| Mon 11 Aug |
|
| Tue 12 Aug |
|
| Wed 13 Aug |
|
| Thu 14 Aug |
|
| Fri 15 Aug |
|
| Sat 16 Aug |
|
| Sun 17 Aug |
|
| Mon 18 Aug |
|
| Tue 19 Aug |
|
| Wed 20 Aug |
|
| Thu 21 Aug |
|
| Fri 22 Aug |
|
| Sat 23 Aug |
|
| Sun 24 Aug |
|
| Mon 25 Aug |
|
| Tue 26 Aug |
|
| Wed 27 Aug |
|
| Thu 28 Aug |
|
| Fri 29 Aug |
|
| Sat 30 Aug |
|
| Sun 31 Aug |
|
Gardening log
- Please put new log entries at the top.
Done:
- Opened the following bugs:
- Committed the following changes:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Mon Aug 04 2014
|
Done:
- Opened the following bugs:
- Rebaselined the tests affected by r171567, r171609 and r171341.
- Committed the following changes:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Sat Aug 02 2014
|
Done:
- Opened the following bugs:
- Updated the bugs
- Committed the following changes:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Sat Jul 19 2014
|
Done:
- Opened the following bugs:
- Updated the bugs
- Committed the following changes:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Wed Jul 16 2014
|
Done:
- Opened the following bugs:
- Updated the bugs
- Committed the following changes:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Wed Jul 09 2014
|
Done:
- Updated the bugs:
- Committed the following changes:
Pending:
- Check the remaining failures.
-- ltilve@igalia.com - Mon Jul 07 2014
|
Done:
- Opened the following bugs:
- Updated the bug
- Committed the following changes:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Wed Jul 02 2014
|
Done:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Fri Jun 27 2014
|
Done:
- Opened the following bugs for flaky and failing tests:
- Committed the following changes:
Pending:
- Check the remaining failures.
-- eocanha@igalia.com - Fri Jun 13 2014
|
Done:
- Opened the following bugs:
- Rebaselined fast/forms/placeholder-position.html
- Updated the highdpi list for bug http://webkit.org/b/131347
- Committed the following changes:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Thu Jun 12 2014
|
Done:
- Committed the following changes:
Pending:
- Check the remaining failures.
-- ltilve@igalia.com - Wed Jun 11 2014
|
Done:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Wed Jun 04 2014
|
Done:
- Checked Layout test failures on r169097
- Opened the following bugs:
- Committed the following changes:
-- ltilve@igalia.com - Thu May 21 2014
|
Done:
Pending:
- Check the remaining failures.
-- eocanha@igalia.com - Fri May 16 2014
|
Done:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Thu May 15 2014
|
Done:
- Checked Layout test failures on r168676
- Updated the following bugs:
- Committed the following changes:
-- ltilve@igalia.com - Thu May 13 2014
|
Done:
- Checked Layout test failures on r168358
- Updated the following bugs:
- Opened the following bugs:
- Committed the following changes:
-- ltilve@igalia.com - Thu May 7 2014
|
Done:
-- clopez@igalia.com - Thu May 01 2014
|
Done:
- Rebaselined all the (128) tests affected by the new multi-column mode enabled on r168046.
- Opened the following bugs:
- Updated the following bugs:
- Committed the following changes:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Thu May 01 2014
|
Done:
- Checked Layout test failures on r167923
- Opened the following bugs:
-- ltilve@igalia.com - Thu Apr 29 2014
|
Done:
- Done:
- Flagged tons of tests and created tons of bugs in three entries:
-- calvaris@igalia.com - Thu Apr 28 2014
|
Done:
- Opened the following bugs (flaky tests):
- Updated the following test expectations for the previous bugs:
Pending:
- Check the remaining failures.
-- eocanha@igalia.com - Fri Apr 25
|
Done:
- Changed on the release bot (http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release) the following:
- Removed the environment variable XVFB_SCREEN_DEPTH=8
- Removed deprecated environment variable WEBKIT_TESTFONTS
- Did an upgrade of the system (Debian testing)
- Opened the following bugs:
- Updated the following bugs:
- Committed the following changes:
Notes:
- If you notice that a test started failing on r167754 it could be because
of the removal of the XVFB_SCREEN_DEPTH=8 variable. Let me know that
or update http://webkit.org/b/132126
-- clopez@igalia.com - Thu Apr 24 2014
|
Done:
- Checked Layout test failures on r167649
- Opened the following bugs:
- Committed the following changes:
Pending:
- Check the remaining failures.
-- elima@igalia.com - Thu Apr 24 2014
|
Done:
- Checked Layout test failures on r167649
- Opened the following bugs:
- Committed the following changes:
Pending:
- Check the remaining failures.
-- ltilve@igalia.com - Mon Apr 22 2014
|
Done:
- Checked Layout test failures on r167589
- Opened the following bugs:
- Updated the following bugs:
- Committed the following changes:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Mon Apr 21 2014
|
Done:
- Checked API tests failures on r167424
- Updated the following bugs:
- Opened the following bugs:
- Committed the following changes:
-- elima@igalia.com - Thu Apr 17 2014
|
Done:
- Opened the following bugs:
Pending:
- Check the remaining failures.
-- aperez@igalia.com - Wed Apr 16 2014
|
Done:
- Checked API tests failures on r167347
- Opened the following bugs:
- Updated the following bugs:
- Committed the following changes:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Wed Apr 16 2014
|
Done:
- Checked failures on r167304
- Committed the following changes:
Pending:
- Check the remaining failures.
-- ltilve@igalia.com - Tue Apr 15 2014
|
Done:
- Checked failures on r167246
- Opened the following bugs:
- Committed the following changes:
Pending:
- Check the remaining failures.
-- elima@igalia.com - Fri Apr 14 2014
|
Done:
- Checked failures on r167125
- Opened the following bugs:
- Updated the following bugs:
- Committed the following changes:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Fri Apr 11 2014
|
Done:
- Opened the following bugs:
- Updated the following test expectations:
Pending:
- Check the remaining failures.
-- eocanha@igalia.com - Fri Apr 11 2014
|
Done:
- Checked both text-only and image-only failures on r167072
- Opened the following bugs:
- Updated the following test expectations:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Thu Apr 10 2014
|
Done:
- Checked the status of
garden-o-matic:
- Works fine for WebKitGTK+ port when using a Git clone.
- Usage instructions in the Rebaseline page.
aperez@igalia.com - Wed 9 Apr 2014
|
Done:
- Started checking the reported Unexpected text-only failures on r166926
- Opened the following bugs:
- Updated test expectations accordingly and rebaselined one test:
Pending:
- Check the remaining failures.
-- clopez@igalia.com - Tue Apr 8 2014
|
|
