Changes between Version 58 and Version 59 of WebKitIDL


Ignore:
Timestamp:
Feb 21, 2012 5:11:31 PM (9 years ago)
Author:
haraken@chromium.org
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • WebKitIDL

    v58 v59  
    154154If you change the behavior of code generators or add a new IDL attribute,
    155155please add test cases to WebCore/bindings/scripts/test/*.idl.
    156 You can reset the results of run-bindings-tests using the --reset-results option:
     156You can reset the run-bindings-tests results using the --reset-results option:
    157157{{{
    158158    $ ./Tools/Scripts/run-bindings-tests --reset-results
    159159}}}
    160160
    161 '''The objective of run-bindings-tests is to show you and reviewers how the code generation is changed by your patch.
    162 If you change the behavior of code generators, please update the results of run-bindings-tests'''.
    163 
    164 That being said, people
    165 
     161The objective of run-bindings-tests is to show you and reviewers how the code generation is changed by your patch.
     162'''If you change the behavior of code generators, please update the results of run-bindings-tests'''.
     163
     164That being said, run-bindings-tests is just for showing the change to you and reviewers,
     165and the test failure is not critical for the WebKit build.
     166People have been likely to forget to update the run-bindings-tests results in fact.
     167Therefore, build bots do not treat the test failure as a failure.
     168In this way, the run-bindings-tests results in the WebKit repository are sometimes wrong.
     169If you find it, please rebaseline the run-bindings-tests before making your patch.
     170If you make your patch without rebaselining the test results,
     171the run-bindings-tests results will include the changes that had been caused by previous patches,
     172which would be unreadable for you and reviewers.
     173
     174Anyway, ideally all people should update the run-bindings-tests results if their patch changes the behavior of code generators.
    166175
    167176= Where is the bindings code generated? = #BindingsCode