Timeline



Jan 31, 2011:

11:54 PM Changeset in webkit [77223] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-533.20-branch

Merge r71724.

11:44 PM Changeset in webkit [77222] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r71686.

11:41 PM Changeset in webkit [77221] by mrowe@apple.com
  • 11 edits in branches/safari-533.20-branch/WebCore

Merge r71641.

9:53 PM Changeset in webkit [77220] by ap@apple.com
  • 4 edits in trunk/Source

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=53466
Move WebKit2 to printing via API methods

Also fixes <rdar://problem/8933724> REGRESSION: Wrong pages are printed when not printing from page 1

Also fixes horizontal tiling (no bug filed).

The main idea here is that we don't force AppKit to use a different scaling factor when
a Web view can't be resized to exact page size, and scale when drawing instead.

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _firstPrintedPageNumber]): Factored out into a separate method. (-[WKPrintingView _lastPrintedPageNumber]): Ditto. (pageDidDrawToPDF): Avoid crashing if data is null. (-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]): Use -_firstPrintedPageNumber and -_lastPrintedPageNumber. (pageDidComputePageRects): Set frame size to what it would have been for a normal NSView that's been asked to resize. (-[WKPrintingView _pageForRect:]): Check x(), because several pages can be at the same y() when tiling horizontally. (-[WKPrintingView _drawPDFDocument:page:atPoint:]): Point to draw at and frame size are now using different units, translate as appropriate. (-[WKPrintingView _drawPreview:]): Scale the rect to WebCore units. (-[WKPrintingView drawRect:]): Correctly calculate page number when the first page to print isn't page 1. (-[WKPrintingView rectForPage:]): Scale the rect to AppKit units.
9:51 PM Changeset in webkit [77219] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation updates.

Removed media/controls-strict.html and svg/custom/clip-path-referencing-use2.svg (Mac)
since it has been passing since r77171 and r77172-r77173 respectively.

Also removed http/tests/media/reload-after-dialog.html because it has been passing for a while.

  • platform/chromium/test_expectations.txt:
9:50 PM Changeset in webkit [77218] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Versioning.

9:50 PM Changeset in webkit [77217] by mrowe@apple.com
  • 1 copy in tags/Safari-533.20.20

New tag.

9:40 PM Changeset in webkit [77216] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Patrick Gansterer <paroga@webkit.org>

Reviewed by Adam Barth.

Remove obsolete comment after r41871
https://bugs.webkit.org/show_bug.cgi?id=53406

  • dom/Document.h:
9:33 PM Changeset in webkit [77215] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-31 Simon Fraser <simon.fraser@apple.com>

Fix according to reviewer comments: can just use Color::black now.

  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::drawInsetShadow): (WebCore::ShadowBlur::drawRectShadowWithoutTiling):
9:31 PM Changeset in webkit [77214] by mrowe@apple.com
  • 3 edits in branches/safari-533.20-branch/WebCore

Build fix.

9:19 PM Changeset in webkit [77213] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

2011-01-31 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Clean up ShadowBlur
https://bugs.webkit.org/show_bug.cgi?id=53472

Some minor ShadowBlur cleanup.

  • platform/graphics/ShadowBlur.h:
  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::ShadowBlur): Use m_blurRadius rather than the radius paramter. (WebCore::ShadowBlur::adjustBlurRadius): Renamed from adjustBlurDistance. (WebCore::ShadowBlur::calculateLayerBoundingRect): Rename layerFloatRect to layerRect. Make frameSize a float. (WebCore::ShadowBlur::beginShadowLayer): This now takes a precomputed layerRect rather than calling calculateLayerBoundingRect() to compute it itself, since we were calling calculateLayerBoundingRect() twice. (WebCore::ShadowBlur::drawRectShadow): Optimize to call calculateLayerBoundingRect() only once. The shadowRect variable was unused, so two return paths could be collapsed into one. (WebCore::ShadowBlur::drawInsetShadow): Call calculateLayerBoundingRect() before beginShadowLayer() now. (WebCore::ShadowBlur::drawRectShadowWithoutTiling): The layerRect gets passed in. We always used alpha=1, so no need to pass that in. (WebCore::ShadowBlur::drawRectShadowWithTiling): We always used alpha=1, so no need to pass that in. Move shadowRect down to first use. ShadowBlur::clipBounds() was unused.
8:34 PM Changeset in webkit [77212] by noam.rosenthal@nokia.com
  • 4 edits in trunk/Source

2011-01-31 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebElements example from QtWebKit Bridge documentation does not work at all
https://bugs.webkit.org/show_bug.cgi?id=46748

This problem disappears when we register QWebElement using qRegisterMetaType, which we now do in QtInstance.
Added a regression test to tst_QWebFrame.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::QtInstance):

2011-01-31 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebElements example from QtWebKit Bridge documentation does not work at all
https://bugs.webkit.org/show_bug.cgi?id=46748

Problem was that we need to register QWebElement's variant-type to Qt's meta type system at some point.
This wasn't caught by previous tests inside tst_QWebFrame because it only appears when there's also a QWebElement property.
Added a regression test to tst_QWebFrame.

  • tests/qwebframe/tst_qwebframe.cpp: (MyWebElementSlotOnlyObject::doSomethingWithWebElement): (MyWebElementSlotOnlyObject::tagName):
8:05 PM Changeset in webkit [77211] by morrita@google.com
  • 8 edits in trunk/Source/WebCore

2011-01-27 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Convert <progress> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50660

  • Removed RenderProgress::m_valuePart, moved the shadow node to the shadow root of HTMLProgressElement.
  • Removed hard-coded pseudo ID for -webkit-progress-bar-value. ProgressBarValueElement is defined only for overriding shadowPseudoId().

No new tests. No behavioral change.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::ProgressBarValueElement::ProgressBarValueElement): (WebCore::ProgressBarValueElement::shadowPseudoId): (WebCore::ProgressBarValueElement::create): (WebCore::ProgressBarValueElement::detach): (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach): (WebCore::HTMLProgressElement::valuePart): (WebCore::HTMLProgressElement::didElementStateChange): (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts): (WebCore::RenderProgress::valuePart):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
8:04 PM Changeset in webkit [77210] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

Add sanity check to help diagnose bug 52819
https://bugs.webkit.org/show_bug.cgi?id=53402

Crash early if the children of fromItem look invalid.

  • loader/HistoryController.cpp:
7:56 PM Changeset in webkit [77209] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix the change log entry order.

7:54 PM Changeset in webkit [77208] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-01-31 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Setting "selected" attribute to false should have no effect in single line <select>
https://bugs.webkit.org/show_bug.cgi?id=52436

Add test for changing the selection in a one-line select element using\
the option.selected property.

  • fast/dom/HTMLSelectElement/selected-false-expected.txt: Added.
  • fast/dom/HTMLSelectElement/selected-false.html: Added.
7:46 PM Changeset in webkit [77207] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-31 Kalle Vahlman <kalle.vahlman@movial.com>

Reviewed by Andreas Kling.

[Qt] canvas.drawImage(HTMLVideoElement) doesn't work with Qt Multimedia backend
https://bugs.webkit.org/show_bug.cgi?id=53325

Reimplement paintCurrentFrameInContext() rather than delegate the
rendering to paint() to make sure we really do get the video frame
content into the GraphicsContext, regardless of accelerated
compositing and the video scene state.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp: (WebCore::MediaPlayerPrivateQt::paintCurrentFrameInContext):
  • platform/graphics/qt/MediaPlayerPrivateQt.h:
7:45 PM Changeset in webkit [77206] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-31 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Setting "selected" attribute to false should have no effect in single line <select>
https://bugs.webkit.org/show_bug.cgi?id=52436

Add test for changing the selection in a one-line select element using\
the option.selected property.

  • fast/dom/HTMLSelectElement/selected-false-expected.txt: Added.
  • fast/dom/HTMLSelectElement/selected-false.html: Added.

2011-01-31 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

Setting "selected" attribute to false should have no effect in single line <select>
https://bugs.webkit.org/show_bug.cgi?id=52436

Change SelectElement::setSelectedIndex to select the first selectable
option when the select state of all options is set to false as required
by the HTML5 specification.

Test: fast/dom/HTMLSelectElement/selected-false.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::setSelectedIndex):
7:27 PM Changeset in webkit [77205] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Console source references need a left-margin
https://bugs.webkit.org/show_bug.cgi?id=53308

  • inspector/front-end/inspector.css: (.console-message-url): Added a 4px margin on the left.
7:19 PM Changeset in webkit [77204] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r73937.

7:19 PM Changeset in webkit [77203] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.20-branch

Merge r73927.

7:08 PM Changeset in webkit [77202] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r59357.

6:54 PM Changeset in webkit [77201] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r72833.

6:54 PM Changeset in webkit [77200] by mrowe@apple.com
  • 11 edits
    9 adds in branches/safari-533.20-branch

Merge r72590.

6:54 PM Changeset in webkit [77199] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/LayoutTests

Merge r72353.

6:54 PM Changeset in webkit [77198] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r72348.

6:54 PM Changeset in webkit [77197] by mrowe@apple.com
  • 9 edits
    8 adds in branches/safari-533.20-branch

Merge r72344.

6:53 PM Changeset in webkit [77196] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r72301.

6:53 PM Changeset in webkit [77195] by mrowe@apple.com
  • 4 edits in branches/safari-533.20-branch/WebCore

Merge r71947.

6:53 PM Changeset in webkit [77194] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r71684.

6:53 PM Changeset in webkit [77193] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-533.20-branch

Merge r72924.

6:53 PM Changeset in webkit [77192] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-533.20-branch

Merge r72819.

6:36 PM Changeset in webkit [77191] by carol.szabo@nokia.com
  • 4 edits in trunk/Source/WebCore

2011-01-31 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

Code Changes only.

It is needlessly expensive to find the generating node from an anonymous renderer of a pseudoelement.
https://bugs.webkit.org/show_bug.cgi?id=53024

No new tests. No change in functionality

  • rendering/RenderObject.h: (WebCore::RenderObject::before): (WebCore::RenderObject::after): (WebCore::RenderObject::generatingNode): Added new accessors for the use of the CSS 2.1 counters code (mainlyly)
  • rendering/RenderObjectChildList.cpp: (WebCore::beforeAfterContainer): (WebCore::RenderObjectChildList::invalidateCounters): (WebCore::RenderObjectChildList::before): (WebCore::RenderObjectChildList::after): Refactored the code to take advantage of the new accessors. (WebCore::RenderObjectChildList::updateBeforeAfterContent): Changed to store the generating node in the :before and :after renderers.
  • rendering/RenderObjectChildList.h:
6:09 PM Changeset in webkit [77190] by rniwa@webkit.org
  • 7 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines for r77173.

  • platform/chromium-mac/fast/text/justify-ideograph-complex-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-complex-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.checksum:
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
6:00 PM Changeset in webkit [77189] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r75548.

5:49 PM Changeset in webkit [77188] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r67634.

5:46 PM Changeset in webkit [77187] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.20-branch

Merge r70594.

5:45 PM Changeset in webkit [77186] by commit-queue@webkit.org
  • 7 edits in trunk

2011-01-31 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by David Hyatt.

Add background-clip to background shorthand
https://bugs.webkit.org/show_bug.cgi?id=52080

Added test cases to check whether webkitMaskClip is correctly set when
declared as a shorthand.

  • fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
  • fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js:

Added test cases to check whether background-clip is set correctly when
declared as a shorthand.

  • fast/css/background-clip-text-expected.txt:
  • fast/css/script-tests/background-clip-text.js: (test):

2011-01-31 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>

Reviewed by David Hyatt.

Add background-clip to background shorthand
https://bugs.webkit.org/show_bug.cgi?id=52080

Added background-clip to background-shorthand. Also made changes to
include webkitMaskClip to the mask shorthand to keep both in sync.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFillShorthand):
5:43 PM Changeset in webkit [77185] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r74045.

5:40 PM Changeset in webkit [77184] by mrowe@apple.com
  • 7 edits
    3 adds in branches/safari-533.20-branch

Merge r67568.

5:27 PM Changeset in webkit [77183] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-01-31 Srikumar Bonda <srikumar.b@gmail.com>

Reviewed by Andreas Kling.

[Qt] ContextMenuClientQt.cpp has coding-style errors
"RefCounted.h" header inclusion style changed to <wtf/RefCounted.h>
https://bugs.webkit.org/show_bug.cgi?id=40243

  • WebCoreSupport/ContextMenuClientQt.cpp:
5:20 PM Changeset in webkit [77182] by Darin Adler
  • 4 edits in trunk/Source

2011-01-31 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

WKView should support scrollPageDown:, scrollPageUp:, scrollToBeg and other similar selectors
https://bugs.webkit.org/show_bug.cgi?id=53460

  • editing/EditorCommand.cpp: (WebCore::executeScrollPageBackward): Added. (WebCore::executeScrollPageForward): Added. (WebCore::executeScrollToBeginningOfDocument): Added. (WebCore::executeScrollToEndOfDocument): Added. (WebCore::createCommandMap): Added the four commands above to the map.

2011-01-31 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

WKView should support scrollPageDown:, scrollPageUp:, scrollToBeg and other similar selectors
https://bugs.webkit.org/show_bug.cgi?id=53460

  • UIProcess/API/mac/WKView.mm: Added WEBCORE_COMMAND macro for lots of editor commands that are implemented in WebCore so they will get forwarded. Many of these will probably work without any further changes required. Added comments about the methods that we do not yet forward. (createSelectorExceptionMap): Map scrollPageDown: to ScrollPageForward and scrollPageUp: to ScrollPageBackward because we want the page up and page down keys to follow the document logical order, not physical order. This is equivalent to what we do in WebPage::performDefaultBehaviorForKeyEvent.
5:19 PM Changeset in webkit [77181] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r59477.

5:14 PM Changeset in webkit [77180] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r72639.

5:10 PM Changeset in webkit [77179] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r72685.

5:02 PM Changeset in webkit [77178] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533.20-branch

Merge r69051.

5:00 PM Changeset in webkit [77177] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533.20-branch

Merge r74155.

4:57 PM Changeset in webkit [77176] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-01-28 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

4:50 PM Changeset in webkit [77175] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch/LayoutTests

Merge r72166.

4:50 PM Changeset in webkit [77174] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r72163.

4:44 PM BuildingQtOnOSX edited by andreas.kling@nokia.com
(diff)
4:30 PM Changeset in webkit [77173] by mitz@apple.com
  • 11 edits in trunk

Inter-ideograph justification should apply to hiragana and katakana as well
https://bugs.webkit.org/show_bug.cgi?id=53464

Reviewed by Adele Peterson.

Source/WebCore:

Changed the test for expansion opportunities from isCJKIdeograph() to isCJKIdeographOrSymbol().

  • platform/graphics/Font.cpp:

(WebCore::Font::expansionOpportunityCount):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advance):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

LayoutTests:

  • platform/mac/fast/text/justify-ideograph-complex-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-complex-expected.png:
  • platform/mac/fast/text/justify-ideograph-simple-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-simple-expected.png:
  • platform/mac/fast/text/justify-ideograph-vertical-expected.checksum:
  • platform/mac/fast/text/justify-ideograph-vertical-expected.png:
4:20 PM Changeset in webkit [77172] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-01-31 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

[Chromium] Switch chromium-mac to use ChromiumDriver
https://bugs.webkit.org/show_bug.cgi?id=53461

For the sake of consistency with the other Chromium platforms (and so
that chromium-mac picks up special flags like --enable-hardware-gpu),
switch chromium-mac from the WebKitDriver to ChromiumDriver.

  • Scripts/webkitpy/layout_tests/port/chromium.py:
3:54 PM Changeset in webkit [77171] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-01-31 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by James Robinson.

REGRESSION(r76951): Appearance of media controls changed slightly on Qt/Chromium ports
https://bugs.webkit.org/show_bug.cgi?id=53314

Fixes media/controls-strict.html on Chromium.

  • css/mediaControlsChromium.css: (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

Added proper box-sizing to avoid differences between strict/quirks mode.

3:50 PM Changeset in webkit [77170] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Validation message bubble shouldn't inherit text-security style
https://bugs.webkit.org/show_bug.cgi?id=53457

No new tests because the validation message feature depends on timers
and is enabled only in Chromium port.

  • css/html.css: (::-webkit-validation-bubble): Reset -webkit-text-security.
3:44 PM Changeset in webkit [77169] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch/WebCore

Merge r74759.

3:44 PM Changeset in webkit [77168] by mrowe@apple.com
  • 5 edits
    5 adds in branches/safari-533.20-branch

Merge r74716.

3:44 PM Changeset in webkit [77167] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch/WebCore

Merge r62016.

3:42 PM Changeset in webkit [77166] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
3:11 PM Changeset in webkit [77165] by oliver@apple.com
  • 3 edits
    3 adds in trunk

2011-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Bogus callframe during stack unwinding
https://bugs.webkit.org/show_bug.cgi?id=53454

Add test

  • fast/js/invalid-callframe-during-unwind-expected.txt: Added.
  • fast/js/invalid-callframe-during-unwind.html: Added.
  • fast/js/script-tests/invalid-callframe-during-unwind.js: Added. (testUnwind):

2011-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Sam Weinig.

Bogus callframe during stack unwinding
https://bugs.webkit.org/show_bug.cgi?id=53454

Trying to access a callframe's globalData after destroying its
ScopeChain is not a good thing. While we could access the
globalData directly through the (known valid) scopechain we're
holding on to, it feels fragile. Instead we push the valid
ScopeChain onto the callframe again to ensure that the callframe
itself remains valid.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame):
2:59 PM BuildingQtOnOSX edited by Dimitri Glazkov
(diff)
2:59 PM Changeset in webkit [77164] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit/win

Fix the clean Windows build.

Reviewed by Adam Roben.

  • WebKitGraphics.cpp:

(WebDrawText):

2:59 PM Changeset in webkit [77163] by dpranke@chromium.org
  • 16 edits in trunk/Tools

2011-01-31 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

The current modifier parsing code in test_expectations is
fragile and hard-coded, so it's not easy to understand the logic
or easily add new types of modifiers (like GPU vs. CPU testing
for graphics tests, or 32-bit vs. 64-bit differences).

This is the first of two patches that will add in more generic
support and then eliminate the GPU-specific test expectations
files for Chromium.

This patch adds two standalone objects for handling modifiers. The
rules for interpreting modifiers, precedence, and conflicts are
given in the docstring to the ModifierMatcher class, which
returns ModifierMatchResult objects.

This patch also adds routines to the Port interface and a
default set of values in the base object, in order to obtain the
values needed on a given test run. These values are then passed
to the expectation parser. This also allows us to clean up the
logic used to lint all of the different configurations in a
single test_expectations.txt file.

The next patch will merge in the separate GPU expectations file.

https://bugs.webkit.org/show_bug.cgi?id=51222

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
  • Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2:56 PM Changeset in webkit [77162] by crogers@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-31 Chris Rogers <crogers@google.com>

Reviewed by Jeremy Orlow.

Improve audio latency on Mac OS X for chromium port
https://bugs.webkit.org/show_bug.cgi?id=53452

  • src/AudioDestinationChromium.cpp:
2:32 PM Changeset in webkit [77161] by dbates@webkit.org
  • 4 edits
    1 add in trunk

2011-01-31 Scott Cameron <sccameron@rim.com>

Reviewed by Daniel Bates.

update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
https://bugs.webkit.org/show_bug.cgi?id=50036

This will add an Apache2.2 configuration file and modifies scripts to allow
running an httpd server in an MSYS environment.

The default Apache2.2 installation path has been preserved and PHP5 modules disabled
in order to allow for simple installation/execution. Simply install the latest
Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
be able to execute run-webkit-httpd.


  • http/conf/apache2-msys-httpd.conf: Added.

2011-01-31 Scott Cameron <sccameron@rim.com>

Reviewed by Daniel Bates.

update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
https://bugs.webkit.org/show_bug.cgi?id=50036

This will add an Apache2.2 configuration file and modifies scripts to allow
running an httpd server in an MSYS environment.

The default Apache2.2 installation path has been preserved and PHP5 modules disabled
in order to allow for simple installation/execution. Simply install the latest
Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
be able to execute run-webkit-httpd.


  • Scripts/run-webkit-httpd:
  • Scripts/webkitperl/httpd.pm:
2:27 PM Changeset in webkit [77160] by rniwa@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium Mac rebaselines for r77153; also rebaseline Kusa-Makura-background-canvas.html

  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/chromium/test_expectations.txt:
2:24 PM Changeset in webkit [77159] by msaboff@apple.com
  • 5 edits in trunk/Source

Rolling back in the changes for https://bugs.webkit.org/show_bug.cgi?id=53271.

1:39 PM Changeset in webkit [77158] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/rendering/RenderCombineText.cpp

Fix 32-bit build bustage.

1:29 PM Changeset in webkit [77157] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
1:05 PM Changeset in webkit [77156] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-01-31 Andreas Kling <kling@webkit.org>

Unbreak Qt build after r77151.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate):
12:51 PM Changeset in webkit [77155] by alex
  • 1 edit
    6 adds in trunk/LayoutTests

2011-01-31 Alejandro G. Castro <alex@igalia.com>

Unreviewed added new expected results for GTK+.

  • platform/gtk/fast/box-shadow/box-shadow-radius-expected.txt: Added.
  • platform/gtk/fast/box-shadow/box-shadow-transformed-expected.txt: Added.
  • platform/gtk/fast/box-shadow/inset-box-shadow-radius-expected.txt: Added.
  • platform/gtk/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Added.
  • platform/gtk/fast/repaint/gradients-em-stops-repaint-expected.txt: Added.
  • platform/gtk/fast/repaint/select-option-background-color-expected.txt: Added.
12:48 PM Changeset in webkit [77154] by chang.shu@nokia.com
  • 2 edits
    1 add
    13 deletes in trunk/LayoutTests

2011-01-31 Chang Shu <chang.shu@nokia.com>

Reviewed by Ryosuke Niwa.

Convert the test case to dumpAsText test so the expected result is cross-platform.
https://bugs.webkit.org/show_bug.cgi?id=53437

  • editing/deleting/5168598-expected.txt: Added.
  • editing/deleting/5168598.html:
  • platform/chromium-linux/editing/deleting/5168598-expected.checksum: Removed.
  • platform/chromium-linux/editing/deleting/5168598-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5168598-expected.checksum: Removed.
  • platform/chromium-win/editing/deleting/5168598-expected.png: Removed.
  • platform/chromium-win/editing/deleting/5168598-expected.txt: Removed.
  • platform/mac-leopard/editing/deleting/5168598-expected.checksum: Removed.
  • platform/mac-leopard/editing/deleting/5168598-expected.png: Removed.
  • platform/mac/editing/deleting/5168598-expected.checksum: Removed.
  • platform/mac/editing/deleting/5168598-expected.png: Removed.
  • platform/mac/editing/deleting/5168598-expected.txt: Removed.
  • platform/qt/editing/deleting/5168598-expected.checksum: Removed.
  • platform/qt/editing/deleting/5168598-expected.png: Removed.
  • platform/qt/editing/deleting/5168598-expected.txt: Removed.
12:39 PM Changeset in webkit [77153] by hyatt@apple.com
  • 47 edits
    7 adds in trunk

Implement text-combine rendering code
https://bugs.webkit.org/show_bug.cgi?id=50621

Patch by takano takumi <takano@apple.com> on 2011-01-31
Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/text/international/text-combine-image-test.html

  • Android.mk: Added RenderCombineText.cpp/h
  • CMakeLists.txt: Added RenderCombineText.cpp/h
  • GNUmakefile.am: Added RenderCombineText.cpp/h
  • WebCore.exp.in:
  • WebCore.gypi: Added RenderCombineText.cpp/h
  • WebCore.pro: Added RenderCombineText.cpp/h
  • WebCore.vcproj/WebCore.vcproj: Added RenderCombineText.cpp/h
  • WebCore.xcodeproj/project.pbxproj: Added RenderCombineText.cpp/h
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • Added fontDescription.widthVariant to SimpleFontData creation.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • Changed to set "Unique" flag to RenderStyle in case of TextCombine.
  • dom/Text.cpp:

(WebCore::Text::createRenderer):

  • Changed to create RenderCombineText in case of TextCombine.
  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::platformDataFromCustomData):

  • Added FontWidthVariant as an argument for FontPlatformData creation.
  • loader/cache/CachedFont.h:
  • Ditto.
  • platform/graphics/Font.h:

(WebCore::Font::widthVariant):

  • The accessor to FontWidthVariant member variable.
  • platform/graphics/FontCache.cpp:
  • Made cache to incorporate FontWidthVariant value.

(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::computeHash):
(WebCore::FontCache::getCachedFontPlatformData):

  • platform/graphics/FontDescription.h:
  • Add a member variable that holds a width variant - none, half-width, third-width, and quarter-width.

(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::widthVariant):
(WebCore::FontDescription::setWidthVariant):
(WebCore::FontDescription::operator==):

  • platform/graphics/FontWidthVariant.h: Added.
  • platform/graphics/cairo/FontCustomPlatformData.h:
  • Changed to carry FontWidthVariant value.
  • platform/graphics/cocoa/FontPlatformData.h:
  • Changed to carry FontWidthVariant value.

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::widthVariant):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):

  • Changed to carry FontWidthVariant value.

(WebCore::FontPlatformData::operator=):

  • Ditto.

(WebCore::mapFontWidthVariantToCTFeatureSelector):

  • A function to map a FontWidthVariant value to a CoreText's text spacing feature selector.

(WebCore::FontPlatformData::ctFont):

  • Changed to create CTFont with text spacing variant based on FontWidthVariant.
  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/haiku/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/haiku/FontCustomPlatformData.h:
  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Changed to carry FontWidthVariant value.
  • platform/graphics/mac/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::shouldUseCoreText):

  • Changed to skip CT path when width variant is specified.
  • platform/graphics/pango/FontCustomPlatformDataPango.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/qt/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/qt/FontCustomPlatformDataQt.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/skia/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/skia/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/win/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:
  • Ditto.

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/win/FontCustomPlatformDataCairo.h:
  • Ditto.
  • platform/graphics/wince/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/wince/FontCustomPlatformData.h:
  • Ditto.
  • platform/graphics/wx/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • Ditto.
  • platform/graphics/wx/FontCustomPlatformData.h:
  • Ditto.
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

  • In case of RenderCombineText, we don't rotate text even in vertical writing. Also, we render original text

instead of text returned from text().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

  • Made to call RenderCombinedText's prepareTextCombine() here.
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::textWidth):

  • Made to always use the render object's width() in case of TextCombine.

(WebCore::RenderBlock::findNextLineBreak):

  • Made to call RenderCombinedText's prepareTextCombine() here.
  • rendering/RenderCombineText.cpp: Added. A subclass of RenderText.

(WebCore::RenderCombineText::RenderCombineText):
(WebCore::RenderCombineText::styleDidChange):

  • Clear the flag that indicated the font has been prepared for combining. The font will be reinitialized in

the next call of RenderBlock::findNextLineBreak().
(WebCore::RenderCombineText::setTextInternal):

  • Ditto.

(WebCore::RenderCombineText::width):

  • Returns 1-em width in case of font combine.

(WebCore::RenderCombineText::adjustTextOrigin):

  • Adjust drawing origin point in case of font combine.

(WebCore::RenderCombineText::charactersToRender):

  • Return original text instead of current text in case of font combine.

(WebCore::RenderCombineText::combineText):

  • This function tries to pack passed text with; 1) the current font as is, 2) the font created

from the descriptor with half-width variant specified, 3) the font with third-width variant, 4) the font
with quarter-width variant.

  • If a suitable font successfully found, replace the current font with the new font. If no appropriate font found,

we give up text-combine as the CSS spec describes.

  • If a new font found, we replace the text with 0xFFFC. This is needed for a combined text block to be able to

behave like a single character against text decorations.

  • rendering/RenderCombineText.h: Added.

(WebCore::RenderCombineText::isCombined):
(WebCore::RenderCombineText::combinedTextWidth):

  • Returns 1-em width in case of font combine.

(WebCore::RenderCombineText::renderName):
(WebCore::toRenderCombineText):

  • rendering/RenderText.cpp:

(WebCore::RenderText::widthFromCache):

  • Made to call RenderCombineText's combinedTextWidth when the text is combined.
  • rendering/RenderingAllInOne.cpp: Added RenderCombineText.cpp
  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hasTextCombine):

  • Added for a quick test of TextCombine.

LayoutTests:

  • fast/text/international/text-combine-image-test.html: Added.
  • platform/mac/fast/text/international/text-combine-image-test-expected.checksum: Added.
  • platform/mac/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/mac/fast/text/international/text-combine-image-test-expected.txt: Added.
12:15 PM Changeset in webkit [77152] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Windows 7 Release Tests] fast/forms/select-writing-direction-natural.html failing since r77046
https://bugs.webkit.org/show_bug.cgi?id=53443

Checking in failing expected results for Windows to get the bots green. Ureviewed.

  • platform/win/fast/forms/select-writing-direction-natural-expected.txt: Added.
12:07 PM Changeset in webkit [77151] by oliver@apple.com
  • 126 edits
    2 adds in trunk/Source

2011-01-31 Oliver Hunt <oliver@apple.com>

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

rolling r77098, r77099, r77100, r77109, and
r77111 back in, along with a few more Qt fix attempts.

12:04 PM Changeset in webkit [77150] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Another unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
11:57 AM Changeset in webkit [77149] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
11:37 AM Changeset in webkit [77148] by kov@webkit.org
  • 5 edits in trunk/Source

2011-01-31 Dan Winship <danw@gnome.org>

Reviewed by Gustavo Noronha Silva.

wss (websockets ssl) support for gtk via new gio TLS support
https://bugs.webkit.org/show_bug.cgi?id=50344

Add a GPollableOutputStream typedef for TLS WebSockets support

  • wtf/gobject/GTypedefs.h:

2011-01-31 Dan Winship <danw@gnome.org>

Reviewed by Gustavo Noronha Silva.

wss (websockets ssl) support for gtk via new gio TLS support
https://bugs.webkit.org/show_bug.cgi?id=50344

Update to use GPollableOutputStream and GTlsConnection to
implement wss URLs

  • platform/network/soup/SocketStreamHandle.h:
  • platform/network/soup/SocketStreamHandleSoup.cpp: (WebCore::SocketStreamHandle::SocketStreamHandle): (WebCore::SocketStreamHandle::connected): (WebCore::SocketStreamHandle::platformSend): (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): (WebCore::writeReadyCallback):
11:25 AM Changeset in webkit [77147] by jberlin@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebKit2

WebKit2: the cookies used by the WebKit2 Web Process should not go in a top-level
directory.
https://bugs.webkit.org/show_bug.cgi?id=53278

Reviewed by Steve Falkenburg.

Use the name WebKit2WebProcess since the default location for the cookies is determined
based on the process name (which is WebKit2WebProcess.exe on Windows).

  • win/WebKit2.make:

Copy the WebKit2WebProcess.resources directory into the AppleInternal bin.

  • win/WebKit2WebProcess.resources: Added.
  • win/WebKit2WebProcess.resources/Info.plist: Added.

Copied from the WebKit version of Info.plist.

  • win/WebKit2WebProcessPostBuild.cmd:

Copy the WebKit2WebProcess.resources directory into the WebKitOutPutDir's bin.

11:08 AM Changeset in webkit [77146] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Tony Chang <tony@chromium.org>

Unreviewed, update chromium mac layout test results after r77138.
fast/blockflow/Kusa-Makura-background-canvas.html and fast/multicol/vertical-rl/float-paginate-complex.html
match upstream text results now.

  • platform/chromium/test_expectations.txt:
11:02 AM Changeset in webkit [77145] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=53352
Heavy external fragmentation in FixedVMPoolAllocator can lead to a CRASH().

Reviewed by Geoff Garen.

The FixedVMPoolAllocator currently uses a best fix policy -
switch to first fit, this is less prone to external fragmentation.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::AllocationTableSizeClass::AllocationTableSizeClass):
(JSC::AllocationTableSizeClass::blockSize):
(JSC::AllocationTableSizeClass::blockCount):
(JSC::AllocationTableSizeClass::blockAlignment):
(JSC::AllocationTableSizeClass::size):
(JSC::AllocationTableLeaf::AllocationTableLeaf):
(JSC::AllocationTableLeaf::~AllocationTableLeaf):
(JSC::AllocationTableLeaf::allocate):
(JSC::AllocationTableLeaf::free):
(JSC::AllocationTableLeaf::isEmpty):
(JSC::AllocationTableLeaf::isFull):
(JSC::AllocationTableLeaf::size):
(JSC::AllocationTableLeaf::classForSize):
(JSC::AllocationTableLeaf::dump):
(JSC::LazyAllocationTable::LazyAllocationTable):
(JSC::LazyAllocationTable::~LazyAllocationTable):
(JSC::LazyAllocationTable::allocate):
(JSC::LazyAllocationTable::free):
(JSC::LazyAllocationTable::isEmpty):
(JSC::LazyAllocationTable::isFull):
(JSC::LazyAllocationTable::size):
(JSC::LazyAllocationTable::dump):
(JSC::LazyAllocationTable::classForSize):
(JSC::AllocationTableDirectory::AllocationTableDirectory):
(JSC::AllocationTableDirectory::~AllocationTableDirectory):
(JSC::AllocationTableDirectory::allocate):
(JSC::AllocationTableDirectory::free):
(JSC::AllocationTableDirectory::isEmpty):
(JSC::AllocationTableDirectory::isFull):
(JSC::AllocationTableDirectory::size):
(JSC::AllocationTableDirectory::classForSize):
(JSC::AllocationTableDirectory::dump):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::allocated):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::classForSize):
(JSC::FixedVMPoolAllocator::offsetToPointer):
(JSC::FixedVMPoolAllocator::pointerToOffset):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::isValid):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • wtf/PageReservation.h:

(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::committed):

11:00 AM Changeset in webkit [77144] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Check the textarea node still exists in document before casting
it to HTMLTextAreaElement.
https://bugs.webkit.org/show_bug.cgi?id=53429

Test: fast/forms/textarea-node-removed-from-document-crash.html

  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):

2011-01-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that we do not crash when destructing textarea renderer when its
node is already removed from document.
https://bugs.webkit.org/show_bug.cgi?id=53429

  • fast/forms/textarea-node-removed-from-document-crash-expected.txt: Added.
  • fast/forms/textarea-node-removed-from-document-crash.html: Added.
10:56 AM Changeset in webkit [77143] by mitz@apple.com
  • 1 edit
    6 deletes in trunk/LayoutTests

Remove expected results in mac-wk2 and win that are equal to the mac results after r77138.

  • platform/mac-wk2/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: Removed.
  • platform/mac-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
  • platform/mac-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Removed.
  • platform/win/fast/block/basic/truncation-rtl-expected.txt: Removed.
  • platform/win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Removed.
  • platform/win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Removed.
10:28 AM Changeset in webkit [77142] by inferno@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-01-31 Cris Neckar <cdn@chromium.org>

Reviewed by Eric Seidel.

Tests for crash when cloning elements that reference counter nodes.
https://bugs.webkit.org/show_bug.cgi?id=53344

  • http/tests/css/counter-crash-expected.txt: Added.
  • http/tests/css/counter-crash.html: Added.
  • http/tests/css/resources/counter-crash-frame-src.html: Added.
10:23 AM Changeset in webkit [77141] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when adding a child in a table
where the before child is not a table section.
https://bugs.webkit.org/show_bug.cgi?id=53276

  • fast/table/before-child-non-table-section-add-table-crash-expected.txt: Added.
  • fast/table/before-child-non-table-section-add-table-crash.html: Added.

2011-01-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

If beforeChild is wrapped in an anonymous table section, we need to
go the parent to find it and use it before adding childs to table.
https://bugs.webkit.org/show_bug.cgi?id=53276

We need to make sure that beforeChild's parent is "this" before calling
RenderBox::addChild. The previous condition in while is too restrictive
and fails to calculate the right beforeChild value when its display
style is table caption.
Test: fast/table/before-child-non-table-section-add-table-crash.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild):
10:11 AM Changeset in webkit [77140] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-01-31 Shane Stephens <shanestephens@google.com>

Reviewed by Simon Fraser.

AffineTransform::translateRight incorrectly computes a translateLeft.
https://bugs.webkit.org/show_bug.cgi?id=52551

Removed translateRight and converted all uses to perform standard
matrix multiplication.

No new tests because patch doesn't modify functionality.

  • platform/graphics/transforms/AffineTransform.cpp:
  • platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::translation):
  • rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::localToParentTransform):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform):
  • rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::localToParentTransform):
  • rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices):
10:08 AM Changeset in webkit [77139] by andersca@apple.com
  • 7 edits
    1 add in trunk/Source/WebKit2

2011-01-31 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Make LayerTreeHost an abstract base class and make LayerTreeHostMac inherit from it
https://bugs.webkit.org/show_bug.cgi?id=53432

  • WebKit2.xcodeproj/project.pbxproj: Add LayerTreeHostMac.h.
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.h: Make m_layerTreeHost an OwnPtr and initialize/destroy it appropriately.
  • WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create): On Mac, create a LayerTreeHostMac instance.

(WebKit::LayerTreeHost::~LayerTreeHost):
No need to call platformInvalidate anymore.

  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h: Added.
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::~LayerTreeHostMac): Invalidate the run loop observer here instead of in platformInvalidate.

(WebKit::LayerTreeHostMac::scheduleLayerFlush):
(WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback):
These are now members of LayerTreeHostMac.

10:06 AM Changeset in webkit [77138] by tony@chromium.org
  • 7 edits in trunk

2011-01-31 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

mac DRT should report RTL scroll offset relative to top right corner
https://bugs.webkit.org/show_bug.cgi?id=53324

Remove scroll offsets since these are at the origin.

  • platform/mac/fast/block/basic/truncation-rtl-expected.txt:
  • platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:

2011-01-31 Tony Chang <tony@chromium.org>

Reviewed by Eric Seidel.

mac DRT should report RTL scroll offset relative to top right corner
https://bugs.webkit.org/show_bug.cgi?id=53324

  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpFrameScrollPosition):
9:57 AM Changeset in webkit [77137] by mario@webkit.org
  • 4 edits in trunk/Source

2011-01-31 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful
https://bugs.webkit.org/show_bug.cgi?id=53389

Return FALSE when not able to set the caret at the specified offset.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_set_caret_offset): Return FALSE when the range created is NULL and adjust offset to account for list markers.

2011-01-31 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful
https://bugs.webkit.org/show_bug.cgi?id=53389

New unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkCaretOffsets): New. (main): Add new test.
9:37 AM Changeset in webkit [77136] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Mark some tests as having wrong image results on Mac.

  • platform/chromium/test_expectations.txt:
9:18 AM Changeset in webkit [77135] by ager@chromium.org
  • 11 edits in trunk/LayoutTests

2011-01-31 Mads Ager <ager@chromium.org>

Reviewed by Pavel Feldman.

[V8] Update V8 specific layout test expectations
https://bugs.webkit.org/show_bug.cgi?id=53423

Error formatting has changed in V8. Updating chromium specific
layout test expectations accordingly.

  • platform/chromium-mac/fast/js/array-every-expected.txt:
  • platform/chromium-mac/fast/js/instance-of-immediates-expected.txt:
  • platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt:
  • platform/chromium-mac/storage/transaction-error-callback-expected.txt:
  • platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
  • platform/chromium-win/fast/js/array-every-expected.txt:
  • platform/chromium-win/fast/js/instance-of-immediates-expected.txt:
  • platform/chromium-win/fast/js/property-getters-and-setters-expected.txt:
  • platform/chromium-win/storage/transaction-error-callback-expected.txt:
  • platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
9:14 AM Changeset in webkit [77134] by alex
  • 2 edits in trunk/LayoutTests

2011-01-31 Alejandro G. Castro <alex@igalia.com>

Unreviewed skipped favicon-as-image.html test, it is flaky and it
was unskipped after r76555.

  • platform/gtk/Skipped:
9:05 AM Changeset in webkit [77133] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/NetworkPanel.js

Merge 77128 - 2011-01-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: copy HAR to clipboard instead of saving blob on export.
https://bugs.webkit.org/show_bug.cgi?id=53328

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._exportAll): (WebInspector.NetworkPanel.prototype._exportResource):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6312032

8:35 AM Changeset in webkit [77132] by simon.fraser@apple.com
  • 3 edits in trunk/LayoutTests

2011-01-31 Simon Fraser <simon.fraser@apple.com>

Update a pixel resuls after r77101.

  • platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum:
  • platform/mac/fast/css/color-correction-on-box-shadow-expected.png:
8:03 AM Changeset in webkit [77131] by yurys@chromium.org
  • 3 edits
    2 adds in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.checksum: Added.
  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png: Added.
  • platform/chromium-mac/fast/transforms/shadows-expected.checksum:
  • platform/chromium-mac/fast/transforms/shadows-expected.png:
7:39 AM Changeset in webkit [77130] by zoltan@webkit.org
  • 3 edits in trunk/Tools

[Qt] Add Take Screen Shot action to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53422

Reviewed by Andreas Kling.

Add Take Screen Shot action to MiniBrowser's view menu.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::screenshot):

  • MiniBrowser/qt/BrowserWindow.h:
7:29 AM Changeset in webkit [77129] by kbr@google.com
  • 3 edits
    3 deletes in trunk/LayoutTests

2011-01-31 Kenneth Russell <kbr@google.com>

Unreviewed, test and expectations update. Stop reporting the precise
pixel value for tests that are supposed to be within a certain range.
Remove now-unneeded Chromium expectations.

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html:
  • platform/chromium-linux/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
  • platform/chromium-mac/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
  • platform/chromium-win/fast/canvas/webgl/gl-teximage-expected.txt: Removed.
7:18 AM Changeset in webkit [77128] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: copy HAR to clipboard instead of saving blob on export.
https://bugs.webkit.org/show_bug.cgi?id=53328

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._exportAll): (WebInspector.NetworkPanel.prototype._exportResource):
6:43 AM Changeset in webkit [77127] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-01-30 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: speed up network panel rendering.
https://bugs.webkit.org/show_bug.cgi?id=53397

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.get scrollContainer):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._exportResource): (WebInspector.NetworkPanel.prototype._onScroll):
  • inspector/front-end/networkPanel.css: (.network-sidebar .data-grid.small tr.offscreen): (.network-sidebar .data-grid tr.offscreen): (.network-sidebar .data-grid tr.offscreen td):
6:34 AM Changeset in webkit [77126] by pvarga@webkit.org
  • 4 edits
    1 delete in trunk/Source/WebCore

2011-01-31 Peter Varga <pvarga@webkit.org>

Reviewed by Andreas Kling.

Remove wrec from WebCore
https://bugs.webkit.org/show_bug.cgi?id=53298

No new tests needed.

  • Android.jscbindings.mk:
  • ForwardingHeaders/wrec/WREC.h: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
6:26 AM Changeset in webkit [77125] by commit-queue@webkit.org
  • 5 edits in trunk/Source

2011-01-31 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76969.
http://trac.webkit.org/changeset/76969
https://bugs.webkit.org/show_bug.cgi?id=53418

"It is causing crashes in GTK+ and Leopard bots" (Requested by
alexg on #webkit).

  • runtime/WeakGCMap.h:

2011-01-31 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76969.
http://trac.webkit.org/changeset/76969
https://bugs.webkit.org/show_bug.cgi?id=53418

"It is causing crashes in GTK+ and Leopard bots" (Requested by
alexg on #webkit).

  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::addRuntimeObject): (JSC::Bindings::RootObject::removeRuntimeObject):
  • bridge/runtime_root.h:
6:23 AM Changeset in webkit [77124] by yurys@chromium.org
  • 3 edits
    17 adds
    4 deletes in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum: Added.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.checksum:
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-mac/fast/repaint/box-shadow-v-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-v-expected.png: Added.
  • platform/chromium-mac/fast/repaint/gradients-em-stops-repaint-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/gradients-em-stops-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Removed.
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
  • platform/chromium-mac/fast/transforms/shadows-expected.checksum: Added.
  • platform/chromium-mac/fast/transforms/shadows-expected.png: Added.
5:59 AM Changeset in webkit [77123] by kov@webkit.org
  • 7 edits in trunk

2011-01-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
https://bugs.webkit.org/show_bug.cgi?id=53379

Remove left over mentions of HAVE_SOUP_2_29_90, and apply the
dependency on newer soup to efl as well.

  • Source/cmake/OptionsEfl.cmake:

2011-01-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
https://bugs.webkit.org/show_bug.cgi?id=53379

Unskip tests that pass again.

  • platform/gtk/Skipped:

2011-01-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
https://bugs.webkit.org/show_bug.cgi?id=53379

Remove left over #ifdef's. I thought all of the conditional code
had been freed from the condition, but I forgot to check DRT.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies):
5:36 AM Changeset in webkit [77122] by mnaganov@chromium.org
  • 3 edits
    5 copies in branches/chromium/648

Merge 76429 - 2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903

In case of an exception in a script from different domain only generic message
will be passed to window.onerror hander.

Tests: http/tests/security/cross-origin-script-window-onerror-redirected.html

http/tests/security/cross-origin-script-window-onerror.html

  • bindings/js/CachedScriptSourceProvider.h: use URL from the resource response to make sure we do all cross origin checks agains real script URL, not the original URL which may have resulted in a sequence of redirects to different domains. (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
  • bindings/v8/ScriptSourceCode.h: same for v8. (WebCore::ScriptSourceCode::url):
  • dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::dispatchErrorEvent): in case the error occurred in a script we cannot access provide concise "Script error." message without any information about the error source. This is what Firefox does in this case.

2011-01-21 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Adam Barth.

Regression: new window.onerror() implementation leaks cross-origin Javascript errors
https://bugs.webkit.org/show_bug.cgi?id=52903

A couple of tests to check that window.onerror won't reveal any content of the resource
from a different domain if the latter is referenced via <script src=...>

  • http/tests/security/cross-origin-script-window-onerror-expected.txt: Added.
  • http/tests/security/cross-origin-script-window-onerror-redirected-expected.txt: Added.
  • http/tests/security/cross-origin-script-window-onerror-redirected.html: Added.
  • http/tests/security/cross-origin-script-window-onerror.html: Added.
  • http/tests/security/resources/cross-origin-script.txt: Added.

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/6409009

3:56 AM Changeset in webkit [77121] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Not reviewed.

Spelling.

  • css/CSSSelectorList.h:

(WebCore::CSSSelectorList::next):

3:45 AM Changeset in webkit [77120] by yurys@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations after r77108

  • platform/chromium-linux/fast/canvas/webgl/gl-teximage-expected.txt: Added.
  • platform/chromium-mac/fast/canvas/webgl/gl-teximage-expected.txt: Added.
  • platform/chromium-win/fast/canvas/webgl/gl-teximage-expected.txt: Added.
3:10 AM Changeset in webkit [77119] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium compilation on Linux.

  • platform/graphics/ShadowBlur.cpp: added PLATFORM(CHROMIUM) guard
  • platform/graphics/ShadowBlur.h: added missing ColorSpace.h header include
2:55 AM Changeset in webkit [77118] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Fix Chromium compilation on Mac broken by r77101.

  • WebCore.gypi: add ShadowBlur.{h,cpp} to the gypi file.
2:51 AM Changeset in webkit [77117] by yurys@chromium.org
  • 1 edit
    16 adds in trunk/LayoutTests

2011-01-31 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Update Chromium test expectations after r77101

  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.txt: Added.
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-win/fast/repaint/gradients-em-stops-repaint-expected.txt: Added.
2:44 AM Changeset in webkit [77116] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-31 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Change button title from "Clear CPU profiles" to "Clear all profiles".

https://bugs.webkit.org/show_bug.cgi?id=53309

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel):
2:35 AM Changeset in webkit [77115] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

2011-01-31 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed, fix the build with current GTK+ 3.x.

  • plugins/gtk/gtk2xtbin.c:
  • plugins/gtk/gtk2xtbin.h:

Jan 30, 2011:

11:18 PM Changeset in webkit [77114] by tkent@chromium.org
  • 7 edits
    2 adds in trunk

2011-01-30 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223

Adds insertedIntoDocument() and remvoedFromDocument() to
FormAssociatedElement class to register the element on the document
if and only if it actually inserted into (removed from) the document.

Test: fast/forms/dangling-form-element-crash.html

  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document.
  • html/FormAssociatedElement.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto.
  • html/HTMLFormControlElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument().

2011-01-30 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

Dangling form associated elements should not be registered on the document
https://bugs.webkit.org/show_bug.cgi?id=53223

Adds a test that ensures dangling form associated elements are not
registered on the document.

  • fast/forms/dangling-form-element-crash-expected.txt: Added.
  • fast/forms/dangling-form-element-crash.html: Added.
10:56 PM Changeset in webkit [77113] by Csaba Osztrogonác
  • 127 edits
    2 deletes in trunk/Source

2011-01-30 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
http://trac.webkit.org/changeset/77098
http://trac.webkit.org/changeset/77099
http://trac.webkit.org/changeset/77100
http://trac.webkit.org/changeset/77109
http://trac.webkit.org/changeset/77111
https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • API/JSCallbackObject.h: (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::setPrivateProperty):
  • API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): (JSObjectSetPrivateProperty):
  • API/JSWeakObjectMapRefInternal.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::globalObject):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply): (JSC::BytecodeGenerator::findScopedProperty):
  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation): (JSC::DebuggerActivation::markChildren):
  • debugger/DebuggerActivation.h:
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/CallFrame.h: (JSC::ExecState::exception):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::unwindCallFrame): (JSC::appendSourceToError): (JSC::Interpreter::execute): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::GlobalObject):
  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists):
  • runtime/Arguments.cpp: (JSC::Arguments::markChildren): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put):
  • runtime/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice):
  • runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
  • runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor): (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow):
  • runtime/ConservativeSet.h: (JSC::ConservativeSet::~ConservativeSet): (JSC::ConservativeSet::mark):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DatePrototype.cpp: (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear):
  • runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::markChildren):
  • runtime/GetterSetter.h: (JSC::GetterSetter::GetterSetter): (JSC::GetterSetter::getter): (JSC::GetterSetter::setGetter): (JSC::GetterSetter::setter): (JSC::GetterSetter::setSetter):
  • runtime/GlobalEvalFunction.cpp: (JSC::GlobalEvalFunction::GlobalEvalFunction): (JSC::GlobalEvalFunction::markChildren):
  • runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::cachedGlobalObject):
  • runtime/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::value): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): (JSC::JSActivation::put):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::unshiftCount): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToRegisters): (JSC::JSArray::compactForSorting):
  • runtime/JSArray.h: (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::uncheckedSetIndex): (JSC::JSArray::markChildrenDirect):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.h: (JSC::JSCell::JSValue::toThisObject): (JSC::JSCell::MarkStack::append):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype): (JSC::JSGlobalObject::markChildren):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::regExpConstructor): (JSC::JSGlobalObject::errorConstructor): (JSC::JSGlobalObject::evalErrorConstructor): (JSC::JSGlobalObject::rangeErrorConstructor): (JSC::JSGlobalObject::referenceErrorConstructor): (JSC::JSGlobalObject::syntaxErrorConstructor): (JSC::JSGlobalObject::typeErrorConstructor): (JSC::JSGlobalObject::URIErrorConstructor): (JSC::JSGlobalObject::evalFunction): (JSC::JSGlobalObject::objectPrototype): (JSC::JSGlobalObject::functionPrototype): (JSC::JSGlobalObject::arrayPrototype): (JSC::JSGlobalObject::booleanPrototype): (JSC::JSGlobalObject::stringPrototype): (JSC::JSGlobalObject::numberPrototype): (JSC::JSGlobalObject::datePrototype): (JSC::JSGlobalObject::regExpPrototype): (JSC::JSGlobalObject::methodCallDummy): (JSC::Structure::prototypeForLookup): (JSC::constructArray):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object): (JSC::Stringifier::markAggregate): (JSC::Stringifier::stringify): (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::callReviver): (JSC::Walker::walk):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::removeDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::putDescriptor): (JSC::JSObject::defineOwnProperty):
  • runtime/JSObject.h: (JSC::JSObject::getDirectOffset): (JSC::JSObject::putDirectOffset): (JSC::JSObject::flattenDictionaryObject): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::JSValue::putDirect): (JSC::JSObject::allocatePropertyStorageInline): (JSC::JSObject::markChildrenDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): (JSC::JSPropertyNameIterator::get):
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
  • runtime/JSString.cpp: (JSC::StringObject::create):
  • runtime/JSValue.h:
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::markChildren):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue):
  • runtime/LiteralParser.cpp: (JSC::LiteralParser::parse):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::lookupPut):
  • runtime/MarkStack.h: (JSC::MarkStack::appendValues):
  • runtime/MathObject.cpp: (JSC::MathObject::MathObject):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor): (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyDescriptor):
  • runtime/Operations.h: (JSC::normalizePrototypeChain): (JSC::resolveBase):
  • runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::print):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::~ScopeChainNode): (JSC::ScopeChainIterator::operator*): (JSC::ScopeChainIterator::operator->): (JSC::ScopeChain::top):
  • runtime/ScopeChainMark.h: (JSC::ScopeChain::markAggregate):
  • runtime/SmallStrings.cpp: (JSC::isMarked): (JSC::SmallStrings::markChildren):
  • runtime/SmallStrings.h: (JSC::SmallStrings::emptyString): (JSC::SmallStrings::singleCharacterString): (JSC::SmallStrings::singleCharacterStrings):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure):
  • runtime/Structure.h: (JSC::Structure::storedPrototype):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::uncheckedGet): (JSC::WeakGCMap::isValid): (JSC::::get): (JSC::::take): (JSC::::set): (JSC::::uncheckedRemove):
  • runtime/WriteBarrier.h: Removed.

2011-01-30 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
http://trac.webkit.org/changeset/77098
http://trac.webkit.org/changeset/77099
http://trac.webkit.org/changeset/77100
http://trac.webkit.org/changeset/77109
http://trac.webkit.org/changeset/77111
https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):

2011-01-30 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
http://trac.webkit.org/changeset/77098
http://trac.webkit.org/changeset/77099
http://trac.webkit.org/changeset/77100
http://trac.webkit.org/changeset/77109
http://trac.webkit.org/changeset/77111
https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • ForwardingHeaders/runtime/WriteBarrier.h: Removed.
  • WebCore.exp.in:
  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSDOMBinding.cpp: (WebCore::markDOMNodesForDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData): (WebCore::getDOMConstructor):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::DialogHandler::dialogCreated):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow): (WebCore::JSDOMWindowShell::markChildren): (WebCore::JSDOMWindowShell::unwrappedObject):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::window): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::createAccelerationObject): (WebCore::createRotationRateObject):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::markJSFunction):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setAll):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain): (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::markAggregate): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::restore):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::putProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::QtInstance): (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate):
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod): (JSC::Bindings::QtRuntimeMetaMethod::markChildren): (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
  • bridge/qt/qt_runtime.h:
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate):
  • bridge/runtime_root.h:
  • dom/Document.h:

2011-01-30 Csaba Osztrogonác <Csaba Osztrogonác>

Unreviewed, rolling out r77098, r77099, r77100, r77109, and
r77111.
http://trac.webkit.org/changeset/77098
http://trac.webkit.org/changeset/77099
http://trac.webkit.org/changeset/77100
http://trac.webkit.org/changeset/77109
http://trac.webkit.org/changeset/77111
https://bugs.webkit.org/show_bug.cgi?id=53219

Qt build is broken

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):
10:18 PM Changeset in webkit [77112] by simon.fraser@apple.com
  • 8 edits in trunk/Source/WebCore

2011-01-30 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77107.
http://trac.webkit.org/changeset/77107
https://bugs.webkit.org/show_bug.cgi?id=53412

Caused 5 new form-related test crashes (Requested by smfr on
#webkit).

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
10:05 PM Changeset in webkit [77111] by simon.fraser@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Build fix the build fix. I assume Oliver meant m_cell, not m_value.

  • runtime/WriteBarrier.h: (JSC::WriteBarrierBase::clear):
10:02 PM Changeset in webkit [77110] by simon.fraser@apple.com
  • 10 edits
    4 adds in trunk

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Enhance ShadowBlur to render inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=51567

Use ShadowBlur for inset box-shadows with CG. It
currently lacks a tiled version, but is still much
faster than CG shadows.

Test: fast/box-shadow/inset-box-shadow-radius.html

  • platform/graphics/ShadowBlur.cpp:
  • platform/graphics/ShadowBlur.h: New method for inset shadows. (WebCore::ShadowBlur::drawInsetShadow):
  • platform/graphics/GraphicsContext.cpp: #ifdef out fillRectWithRoundedHole() for CG.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRectWithRoundedHole): If there's a shadow with a radius > 0, use ShadowBlur.
9:54 PM Changeset in webkit [77109] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

More Qt build fixes

9:11 PM Changeset in webkit [77108] by kbr@google.com
  • 5 edits
    1 add in trunk

2011-01-28 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

WebGL shows PNG Textures with indexed colors too dark
https://bugs.webkit.org/show_bug.cgi?id=47477

Added test case for upload of indexed PNG images to
gl-teximage.html in the Khronos WebGL conformance tests.
Synchronized this test with the Khronos repository.

  • fast/canvas/webgl/gl-teximage-expected.txt:
  • fast/canvas/webgl/gl-teximage.html:
  • fast/canvas/webgl/resources/red-indexed.png: Added.

2011-01-28 Kenneth Russell <kbr@google.com>

Reviewed by Chris Marrin.

WebGL shows PNG Textures with indexed colors too dark
https://bugs.webkit.org/show_bug.cgi?id=47477

Properly handle indexed PNG images by re-rendering them as RGBA
images before upload. Verified with this layout test and the test
cases from bugs 47477 and 53269.

  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
8:39 PM Changeset in webkit [77107] by morrita@google.com
  • 8 edits in trunk/Source/WebCore

2011-01-27 MORITA Hajime <morrita@google.com>

Reviewed by Dimitri Glazkov.

Convert <progress> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50660

  • Removed RenderProgress::m_valuePart, moved the shadow node to the shadow root of HTMLProgressElement.
  • Removed hard-coded pseudo ID for -webkit-progress-bar-value. ProgressBarValueElement is defined only for overriding shadowPseudoId().

No new tests. No behavioral change.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h:
  • html/HTMLProgressElement.cpp: (WebCore::ProgressBarValueElement::ProgressBarValueElement): (WebCore::ProgressBarValueElement::shadowPseudoId): (WebCore::ProgressBarValueElement::create): (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach): (WebCore::HTMLProgressElement::valuePart): (WebCore::HTMLProgressElement::didElementStateChange): (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
  • html/HTMLProgressElement.h:
  • rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts): (WebCore::RenderProgress::valuePart):
  • rendering/RenderProgress.h:
  • rendering/style/RenderStyleConstants.h:
8:26 PM Changeset in webkit [77106] by simon.fraser@apple.com
  • 4 edits in trunk/Source/WebCore

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Ariya Hidayat.

Enhance ShadowBlur to render inset box shadows; Part 1.
https://bugs.webkit.org/show_bug.cgi?id=51567

Add a new method to GraphicsContext to render a rect with a rounded hole,
for use by inset box-shadow code. Knowledge that we're rendering a rounded
hole will enable ShadowBlur to be used here in future.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::fillRectWithRoundedHole):
  • platform/graphics/GraphicsContext.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
8:23 PM Changeset in webkit [77105] by morrita@google.com
  • 3 edits
    4 adds in trunk

2011-01-23 MORITA Hajime <morrita@google.com>

Reviewed by Eric Seidel.

REGRESSION: Inset shadow with too large border radius misses rounded corner.
https://bugs.webkit.org/show_bug.cgi?id=52800

  • fast/box-shadow/inset-with-extraordinary-radii-and-border.html: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Added.

2011-01-23 MORITA Hajime <morrita@google.com>

Reviewed by Eric Seidel.

REGRESSION: Inset shadow with too large border radius misses rounded corner.
https://bugs.webkit.org/show_bug.cgi?id=52800

The refactoring on r76083 broke the invariant between border
IntRect and its radii because RoundedIntRect::setRect() is called
after getRoundedInnerBorderWithBorderWidths(), which enforces the
invariant. Th rounded-rect clipping code verifies the invariant,
and discard the invalid radii, that results broken paintings.

This change moved setRect() before
getRoundedInnerBorderWithBorderWidths() not to modify the valid
RoundedIntRect value.

Test: fast/box-shadow/inset-with-extraordinary-radii-and-border.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow):
8:06 PM Changeset in webkit [77104] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

[Take 2!]
Fixed crash on window close (maybe crash on launch?) due to missing frame null checks
https://bugs.webkit.org/show_bug.cgi?id=53408

  • UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle): Use MESSAGE_CHECK because we don't think we should be able to reach this state under normal conditions.
8:05 PM Changeset in webkit [77103] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Attempt to fix Windows build by adding ShadowBlur.cpp/h to the
vcproj.

  • WebCore.vcproj/WebCore.vcproj:
7:36 PM Changeset in webkit [77102] by ggaren@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Fixed crash on window close (maybe crash on launch?) due to missing
frame null checks
https://bugs.webkit.org/show_bug.cgi?id=53408

  • UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle): Check for NULL, since we're calling a function that can return it.
7:36 PM Changeset in webkit [77101] by simon.fraser@apple.com
  • 32 edits
    1 move
    7 adds
    6 deletes in trunk

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

-webkit-box-shadow causes awful scroll/resize/redraw performance
https://bugs.webkit.org/show_bug.cgi?id=22102

Use ShadowBlur for CG, whe rendering shadows on rects and
rounded rects outside of canvas.

CG shadows with a radius of more than 8px do not render
correctly. We preserve this incorrect rendering by compensating
for it when rending -webkit-box-shadow. Calls that should use
this deprecated radius behavior now use setLegacyShadow().

Test: fast/box-shadow/box-shadow-transformed.html

  • html/canvas/CanvasRenderingContext2D.cpp: Use setLegacyShadow() for canvas, to indicate that it should use the deprecated radius behavior. (WebCore::CanvasRenderingContext2D::setAllAttributesToDefault): Ditto. (WebCore::CanvasRenderingContext2D::setShadow): Ditto. (WebCore::CanvasRenderingContext2D::applyShadow): Ditto.
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setLegacyShadow): Set the m_state.shadowsUseLegacyRadius bit.
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState): Add a shadowsUseLegacyRadius bit to the state.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::radiusToLegacyRadius): Map from the actual radius to one that approximates CG behavior. (WebCore::hasBlurredShadow): Helper that returns true if we have a shadow with a non-zero blur radius. (WebCore::GraphicsContext::fillRect): Use ShadowBlur if not canvas. (WebCore::GraphicsContext::fillRoundedRect): Ditto. (WebCore::GraphicsContext::setPlatformShadow): Comment.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Call setLegacyShadow() for -webkit-box-shadow.
  • platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::calculateLayerBoundingRect): Fix some pixel crack issues by rounding up the blur radius. (WebCore::ShadowBlur::drawRectShadow): Ditto (WebCore::ShadowBlur::drawRectShadowWithTiling): Ditto.
7:11 PM Changeset in webkit [77100] by oliver@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix Qt build (again).

5:35 PM Changeset in webkit [77099] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Try to fix Qt build.

5:13 PM Changeset in webkit [77098] by oliver@apple.com
  • 125 edits
    2 adds in trunk/Source

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

rolling r77006 and r77020 back in.

4:44 PM Changeset in webkit [77097] by simon.fraser@apple.com
  • 6 edits
    2 adds in trunk/Source/WebCore

2011-01-30 Simon Fraser <simon.fraser@apple.com>

Reviewed by Sam Weinig.

Make ContextShadow code cross-platform
https://bugs.webkit.org/show_bug.cgi?id=51312

Add a new class, ShadowBlur, that contains most of the
code from ContextShadow, but is fully cross-platform.
It depends on one new method, GraphicsContext::clipBounds(),
which platforms will have to implement.

Add ShadowBlur to the Mac Xcode project, but don't use it
anywhere yet.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::clipBounds):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ShadowBlur.cpp: Added. (WebCore::roundUpToMultipleOf32): (WebCore::ScratchBuffer::ScratchBuffer): (WebCore::ScratchBuffer::getScratchBuffer): (WebCore::ScratchBuffer::scheduleScratchBufferPurge): (WebCore::ScratchBuffer::timerFired): (WebCore::ScratchBuffer::clearScratchBuffer): (WebCore::ScratchBuffer::shared): (WebCore::ShadowBlur::ShadowBlur): (WebCore::ShadowBlur::blurLayerImage): (WebCore::ShadowBlur::adjustBlurDistance): (WebCore::ShadowBlur::calculateLayerBoundingRect): (WebCore::ShadowBlur::beginShadowLayer): (WebCore::ShadowBlur::endShadowLayer): (WebCore::ShadowBlur::drawRectShadow): (WebCore::ShadowBlur::drawRectShadowWithoutTiling): (WebCore::ShadowBlur::drawRectShadowWithTiling): (WebCore::ShadowBlur::clipBounds):
  • platform/graphics/ShadowBlur.h: Added. (WebCore::ShadowBlur::setShadowsIgnoreTransforms): (WebCore::ShadowBlur::shadowsIgnoreTransforms):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::clipBounds):
3:32 PM Changeset in webkit [77096] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-30 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Fix regression introduced in r77093 - path.rsplit() doesn't
take keyword arguments.

https://bugs.webkit.org/show_bug.cgi?id=53326

  • Scripts/webkitpy/common/system/filesystem_mock.py:
3:16 PM Changeset in webkit [77095] by dpranke@chromium.org
  • 5 edits
    3 copies in trunk/Tools

2011-01-30 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

Add more unit tests for rebaseline-chromium-webkit-tests. This
change involves restructuring a bunch of r-c-w-t code to make it
more testable as well. We also add wrapper classes for handling
testing zip files and fetching URLs.

https://bugs.webkit.org/show_bug.cgi?id=53040

  • Scripts/webkitpy/common/system/urlfetcher.py:
  • Scripts/webkitpy/common/system/urlfetcher_mock.py:
  • Scripts/webkitpy/common/system/zipfileset_mock.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
3:07 PM Changeset in webkit [77094] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Filter all Heap collection through a common reset function, in
preparation for adding features triggered by collection.
https://bugs.webkit.org/show_bug.cgi?id=53396


SunSpider reports no change.

  • runtime/Heap.cpp: (JSC::Heap::reportExtraMemoryCostSlowCase): When we're over the extraCost limit, just call collectAllGarbage() instead of rolling our own special way of resetting the heap. In theory, this may be slower in some cases, but it also fixes cases of pathological heap growth that we've seen, where the only objects being allocated are temporary and huge (<rdar://problem/8885843>).

(JSC::Heap::allocate):
(JSC::Heap::collectAllGarbage): Use the shared reset function.

(JSC::Heap::reset):

  • runtime/Heap.h: Carved a new shared reset function out of the old collectAllGarbage.
3:07 PM Changeset in webkit [77093] by dpranke@chromium.org
  • 9 edits in trunk/Tools

2011-01-30 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Clean up of the filesystem-related modules used in webkitpy.
I've added relpath() to the filesystem interface, modified
ospath.relpath() so that it could work with the filesystem
interface, and modified the fileset* routines to use the
filesystem interface consistently.

This patch also adds a close() routine to the fileset routines
to indicate that the caller is done with the fileset. This
allows zipfileset to clean up after itself when it creates
tempfiles to store downloads.

https://bugs.webkit.org/show_bug.cgi?id=53326

  • Scripts/webkitpy/common/system/directoryfileset.py:
  • Scripts/webkitpy/common/system/fileset.py:
  • Scripts/webkitpy/common/system/filesystem.py:
  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/common/system/filesystem_unittest.py:
  • Scripts/webkitpy/common/system/ospath.py:
  • Scripts/webkitpy/common/system/zipfileset.py:
  • Scripts/webkitpy/common/system/zipfileset_unittest.py:
12:25 PM Changeset in webkit [77092] by kbalazs@webkit.org
  • 6 edits in trunk

2011-01-30 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2]REGRESSION (r76991): Fix build errors
https://bugs.webkit.org/show_bug.cgi?id=53400

Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
and remove WebKit2Prefix.h from the build.

  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkpage.h:
  • WebKit2.pro:

2011-01-30 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2]REGRESSION (r76991): Fix build errors
https://bugs.webkit.org/show_bug.cgi?id=53400

Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
and remove WebKit2Prefix.h from the build.

  • MiniBrowser/qt/MiniBrowser.pro:
12:04 PM Changeset in webkit [77091] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-01-30 Jeff Miller <jeffm@apple.com>

Reviewed by Dan Bernstein.

FindController::updateFindIndicator() crashes if selection isn't visible
https://bugs.webkit.org/show_bug.cgi?id=53399

  • WebProcess/WebPage/FindController.cpp: (WebKit::FindController::updateFindIndicator): Return false if ShareableBitmap::createShareable() returns null (typically because the selection rect is empty).
11:54 AM Changeset in webkit [77090] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r77025.
http://trac.webkit.org/changeset/77025
https://bugs.webkit.org/show_bug.cgi?id=53401

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-30
It made js1_5/Regress/regress-159334.js fail on 64 bit Linux
(Requested by Ossy on #webkit).

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FreeListEntry::FreeListEntry):
(JSC::AVLTreeAbstractorForFreeList::get_less):
(JSC::AVLTreeAbstractorForFreeList::set_less):
(JSC::AVLTreeAbstractorForFreeList::get_greater):
(JSC::AVLTreeAbstractorForFreeList::set_greater):
(JSC::AVLTreeAbstractorForFreeList::get_balance_factor):
(JSC::AVLTreeAbstractorForFreeList::set_balance_factor):
(JSC::AVLTreeAbstractorForFreeList::null):
(JSC::AVLTreeAbstractorForFreeList::compare_key_key):
(JSC::AVLTreeAbstractorForFreeList::compare_key_node):
(JSC::AVLTreeAbstractorForFreeList::compare_node_node):
(JSC::reverseSortFreeListEntriesByPointer):
(JSC::reverseSortCommonSizedAllocations):
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::addToFreeList):
(JSC::FixedVMPoolAllocator::coalesceFreeSpace):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::allocInternal):
(JSC::FixedVMPoolAllocator::isWithinVMPool):
(JSC::FixedVMPoolAllocator::addToCommittedByteCount):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::maybeModifyVMPoolSize):
(JSC::ExecutableAllocator::isValid):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • wtf/PageReservation.h:

(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):

10:19 AM Changeset in webkit [77089] by simon.fraser@apple.com
  • 4 edits
    4 adds in trunk

2011-01-29 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

CSS3 gradients with em-based stops fail to repaint when font size changes
https://bugs.webkit.org/show_bug.cgi?id=51845

Mark as uncacheable gradidients whose color stops depend on font size,
and don't attempt to put these into CSSImageGeneratorValue's image cache.
This means we return a new gradient each time, which is fairly cheap, and
fixes repaint issues under changing font size.

Test: fast/repaint/gradients-em-stops-repaint.html

  • css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::image): (WebCore::CSSGradientValue::isCacheable):
  • css/CSSGradientValue.h:
5:21 AM Changeset in webkit [77088] by Csaba Osztrogonác
  • 5 edits in trunk

Unreviewed.

[Qt][WK2] Buildfix.

Source/WebKit2:

  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkpage.h:

Tools:

  • MiniBrowser/qt/MiniBrowser.pro:
3:54 AM Changeset in webkit [77087] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-30 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Daniel Bates.

Code style issue in JavaScriptCore/wtf/CurrentTime.h
https://bugs.webkit.org/show_bug.cgi?id=53394

According to rule #3 at http://webkit.org/coding/coding-style.html,
This patch fix style issue in CurrentTime.h.

No functionality change, no new tests.

  • wtf/CurrentTime.h: (WTF::currentTimeMS): (WTF::getLocalTime):
2:40 AM Changeset in webkit [77086] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-01-30 Benjamin Poulain <ikipou@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] JavaScriptCore does not link on Mac if building WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=53377

The option "-whole-archive" is not availabe with the libtool of Mac OS X,
instead, we can use "-all_load" on Mac.

12:30 AM Changeset in webkit [77085] by mjs@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-01-29 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoffrey Garen.

Add WKPageCopyPendingAPIRequestURL API
https://bugs.webkit.org/show_bug.cgi?id=53383

This API returns the last URL requested for load via API, if neither that load nor any
other load subsequently reaches the provisional state.


This is useful to be able to track loads initiated via the API


  • UIProcess/API/C/WKPage.cpp: (WKPageCopyPendingAPIRequestURL): Retrieve the pending URL.
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadURL): Set pending URL. (WebKit::WebPageProxy::loadURLRequest): ditto (WebKit::WebPageProxy::reload): ditto (WebKit::WebPageProxy::goForward): ditto (WebKit::WebPageProxy::goBack): ditto (WebKit::WebPageProxy::estimatedProgress): Assume the initial progress value when there is a pending URL. (WebKit::WebPageProxy::didStartProvisionalLoadForFrame): Clear pending URL; clients should look at the provisional URL now. (WebKit::WebPageProxy::decidePolicyForNavigationAction): Clear pending URL if it doesn't match the policy URL; this means we were interrupted by another load.
  • UIProcess/WebPageProxy.h: (WebKit::WebPageProxy::pendingAPIRequestURL): Helper function. (WebKit::WebPageProxy::clearPendingAPIRequestURL): ditto (WebKit::WebPageProxy::setPendingAPIRequestURL): ditto

Jan 29, 2011:

10:48 PM Changeset in webkit [77084] by mitz@apple.com
  • 2312 edits in trunk/LayoutTests/platform

Set the svn:mime-type property of some PNG files to image/png

10:43 PM Changeset in webkit [77083] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Sorry Leopard bot -- I committed a change by accident.

10:23 PM Changeset in webkit [77082] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Simplified Heap iteration
https://bugs.webkit.org/show_bug.cgi?id=53393

  • runtime/CollectorHeapIterator.h: (JSC::CollectorHeapIterator::isValid): (JSC::CollectorHeapIterator::isLive): (JSC::CollectorHeapIterator::advance): Removed "max" argument to advance because it's a constant. (JSC::LiveObjectIterator::LiveObjectIterator): (JSC::LiveObjectIterator::operator++): (JSC::DeadObjectIterator::DeadObjectIterator): (JSC::DeadObjectIterator::operator++): (JSC::ObjectIterator::ObjectIterator): (JSC::ObjectIterator::operator++): Factored out common checks into two helper functions -- isValid() for "Am I past the end?" and isLive() for "Is the cell I'm pointing to live?".
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::freeBlock): (JSC::MarkedSpace::sweep): Always sweep from the beginning of the heap to the end, to avoid making sweep subtly reliant on internal Heap state. (JSC::MarkedSpace::primaryHeapBegin): (JSC::MarkedSpace::primaryHeapEnd): Always be explicit about where iteration begins.
10:11 PM Changeset in webkit [77081] by ggaren@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-01-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Cameron Zwarich.

Simplified heap destruction
https://bugs.webkit.org/show_bug.cgi?id=53392

  • JavaScriptCore.exp:
  • runtime/Heap.cpp: (JSC::Heap::destroy):
  • runtime/Heap.h:
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::destroy):
  • runtime/MarkedSpace.h: Don't go out of our way to destroy GC-protected cells last -- the difficult contortions required to do so just don't seem justified. We make no guarantees about GC protection after the client throws away JSGlobalData, and it doesn't seem like any meaningful guarantee is even possible.
9:58 PM Changeset in webkit [77080] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-01-29 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Switched heap to use the Bitmap class and removed CollectorBitmap
https://bugs.webkit.org/show_bug.cgi?id=53391


SunSpider says 1.005x as fast. Seems like a fluke.

  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::allocate): Updated for rename and returning a value rather than taking a value by reference.
  • runtime/MarkedSpace.h: Code reuse is good.
  • wtf/Bitmap.h: (WTF::::testAndSet): Added, since this is the one thing Bitmap was missing which CollectorBitmap had. (Renamed from the less conventional "getset".)

(WTF::::nextPossiblyUnset): Renamed and changed to return a value for
clarity. It's all the same with inlining.

8:17 PM Changeset in webkit [77079] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Undo try to fix the Qt build.

My guess didn't work.

  • WebCore.pro:
8:04 PM Changeset in webkit [77078] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Qt build.

  • WebCore.pro: Added platform/text/CharacterNames.h.
7:32 PM Changeset in webkit [77077] by ggaren@apple.com
  • 14 edits in trunk/Source

2011-01-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some more Heap cleanup.
https://bugs.webkit.org/show_bug.cgi?id=53357


  • runtime/Heap.cpp: (JSC::Heap::reportExtraMemoryCostSlowCase): Renamed recordExtraCost to reportExtraMemoryCostSlowCase to match our naming conventions.

(JSC::Heap::capacity): Renamed size to capacity because this function
returns the capacity of the heap, including unused portions.

  • runtime/Heap.h: (JSC::Heap::globalData): (JSC::Heap::markedSpace): (JSC::Heap::machineStackMarker): (JSC::Heap::reportExtraMemoryCost): Moved statics to the top of the file. Moved ctor and dtor to the beginning of the class definition. Grouped functions by purpose.
  • runtime/MarkedSpace.cpp: (JSC::MarkedSpace::capacity): Renamed size to capacity because this function returns the capacity of the heap, including unused portions.
  • runtime/MarkedSpace.h: Removed statistics and the Statistics class because the same information can be gotten just by calling size() and capacity().
  • runtime/MemoryStatistics.cpp:
  • runtime/MemoryStatistics.h: Ditto.

2011-01-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some more Heap cleanup.
https://bugs.webkit.org/show_bug.cgi?id=53357

Updated for JavaScriptCore changes.

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics memoryStatistics]):

2011-01-28 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Some more Heap cleanup.
https://bugs.webkit.org/show_bug.cgi?id=53357


Updated for JavaScriptCore changes.

  • bindings/js/ScriptGCEvent.cpp: (WebCore::ScriptGCEvent::getHeapSize):
6:39 PM Changeset in webkit [77076] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Fix XSSFilter crash when extracting the source for a token twice
https://bugs.webkit.org/show_bug.cgi?id=53368

Previously, it was unsafe to extract the source for the same token
twice because the HTMLSourceTracker would advance its internal
representation of the SegmentedString. This patch introduces a cache
to make calling HTMLSourceTracker::sourceForToken multiple times safe.

  • html/parser/HTMLSourceTracker.cpp: (WebCore::HTMLSourceTracker::end): (WebCore::HTMLSourceTracker::sourceForToken):
  • html/parser/HTMLSourceTracker.h:
4:22 PM Changeset in webkit [77075] by mjs@apple.com
  • 2 edits in trunk/Source/WebCore

2011-01-29 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Fix fat build for both 32-bit and 64-bit under llvm-gcc 4.2
https://bugs.webkit.org/show_bug.cgi?id=53386

  • platform/mac/ScrollAnimatorMac.mm: (WebCore::elasticDeltaForReboundDelta): (WebCore::scrollWheelMultiplier): (WebCore::ScrollAnimatorMac::smoothScrollWithEvent): (WebCore::ScrollAnimatorMac::beginScrollGesture): (WebCore::roundTowardZero): (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
3:21 PM Changeset in webkit [77074] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed fix for last commit.

Remove stray slash in previous commit.

  • platform/mac-wk2/Skipped:
3:14 PM Changeset in webkit [77073] by dbates@webkit.org
  • 4 edits in trunk

2011-01-29 Daniel Bates <dbates@rim.com>

Reviewed by Maciej Stachowiak.

Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files
https://bugs.webkit.org/show_bug.cgi?id=53382

Our file system hierarchy ensures that CMAKE_SOURCE_DIR is defined to be /Source.
So, ${CMAKE_SOURCE_DIR}/Source evaluates to the non-existent directory /Source/Source.
Therefore, we should remove such references.

  • Source/cmake/OptionsCommon.cmake:

2011-01-29 Daniel Bates <dbates@rim.com>

Reviewed by Maciej Stachowiak.

Remove reference to ${CMAKE_SOURCE_DIR}/Source in CMake files
https://bugs.webkit.org/show_bug.cgi?id=53382

Our file system hierarchy ensures that CMAKE_SOURCE_DIR is defined to be /Source.
So, ${CMAKE_SOURCE_DIR}/Source evaluates to the non-existent directory /Source/Source.
Therefore, we should remove such references.

  • CMakeLists.txt:
3:10 PM Changeset in webkit [77072] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-29 Maciej Stachowiak <mjs@apple.com>

Reviewed by Daniel Bates.

Skip a test that uses unimplemented DRT API
https://bugs.webkit.org/show_bug.cgi?id=53381

  • platform/mac-wk2/Skipped:
2:19 PM Changeset in webkit [77071] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix 32-bit build on the Mac.

Reviewed by Jon Honeycutt.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
Use floats instead of doubles to avoid double-to-float conversion
issues.

2:17 PM Changeset in webkit [77070] by dbates@webkit.org
  • 6 edits
    1 add
    1 delete in trunk

2011-01-29 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

Move wince/mt19937ar.c to ThirdParty and make it a policy choice
https://bugs.webkit.org/show_bug.cgi?id=53253

Move implementation of Mersenne Twister pseudorandom number generator to
ThirdParty since it is a third party library.

  • Source/ThirdParty/mt19937ar.c: Copied from Source/JavaScriptCore/wtf/wince/mt19937ar.c.

2011-01-29 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

Move wince/mt19937ar.c to ThirdParty and make it a policy choice
https://bugs.webkit.org/show_bug.cgi?id=53253

Make inclusion of MT19937 a policy decision.

Currently, we hardcoded to use MT19937 when building for
Windows CE. Instead, we should make this a policy decision
with the Windows CE port using this by default.

  • JavaScriptCore.pri: Append Source/ThirdParty to the end of the list include directories.
  • wtf/CMakeLists.txt: Ditto.
  • wtf/Platform.h: Defined WTF_USE_MERSENNE_TWISTER_19937 when building for Windows CE.
  • wtf/RandomNumber.cpp: (WTF::randomNumber): Substituted USE(MERSENNE_TWISTER_19937) for OS(WINCE).
2:00 PM Changeset in webkit [77069] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-29 Gustavo Noronha Silva <gns@gnome.org>

[GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing
https://bugs.webkit.org/show_bug.cgi?id=53379

Skip tests failing likely by the usage of a newer version of soup.

  • platform/gtk/Skipped:
12:47 PM Changeset in webkit [77068] by rniwa@webkit.org
  • 3 edits
    10 adds in trunk/LayoutTests

2011-01-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines.

  • platform/chromium-linux/fast/block/positioning/001-expected.checksum: Added.
  • platform/chromium-linux/fast/block/positioning/001-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum: Added.
  • platform/chromium-linux/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-objectBoundingBox-expected.checksum: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.checksum: Added.
  • platform/chromium-win/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Added.
  • platform/chromium-win/svg/custom/missing-xlink-expected.txt:
  • platform/chromium/test_expectations.txt:
12:31 PM Changeset in webkit [77067] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Bug 53374 - Remove uses of unsafe string functions in debugging code
https://bugs.webkit.org/show_bug.cgi?id=53374

Reviewed by David Kilzer.

  • runtime/RegExp.cpp:

(JSC::RegExp::printTraceData):

12:27 PM Changeset in webkit [77066] by cwzwarich@webkit.org
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix ChangeLog date.

12:18 PM Changeset in webkit [77065] by cwzwarich@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JavaScriptCoreUseJIT environment variable broken
https://bugs.webkit.org/show_bug.cgi?id=53372

Reviewed by Oliver Hunt.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData): Check the actual value in the string returned
by getenv() rather than just doing a NULL check on the return value.

11:43 AM Changeset in webkit [77064] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

2011-01-28 Simon Fraser <simon.fraser@apple.com>

Reviewed by Adam Barth.

Use clampToInteger() functions in a few places
https://bugs.webkit.org/show_bug.cgi?id=53363

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use clampToInteger() for z-index. (WebCore::CSSStyleSelector::createTransformOperations): Use clampToPositiveInteger().
  • platform/graphics/transforms/PerspectiveTransformOperation.cpp: Ditto. (WebCore::PerspectiveTransformOperation::blend): Ditto.
10:50 AM Changeset in webkit [77063] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update; removed http/tests/appcache/online-whitelist.html
from the test expectation, because it has been passing on Chromium Windows.

  • platform/chromium/test_expectations.txt:
9:04 AM Changeset in webkit [77062] by paroga@webkit.org
  • 56 edits
    2 adds
    1 delete in trunk/Source

2011-01-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Move CharacterNames.h into WTF directory
https://bugs.webkit.org/show_bug.cgi?id=49618

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/unicode/CharacterNames.h: Renamed from WebCore/platform/text/CharacterNames.h.
  • wtf/unicode/UTF8.cpp:

2011-01-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Move CharacterNames.h into WTF directory
https://bugs.webkit.org/show_bug.cgi?id=49618

  • ForwardingHeaders/wtf/unicode/CharacterNames.h: Added.
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityRenderObject.cpp:
  • bindings/cpp/WebDOMHTMLDocumentCustom.cpp:
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • dom/Position.cpp:
  • dom/SelectElement.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/Editor.cpp:
  • editing/HTMLInterchange.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/MarkupAccumulator.cpp:
  • editing/TextIterator.cpp:
  • editing/VisibleSelection.cpp:
  • editing/htmlediting.cpp:
  • editing/htmlediting.h:
  • editing/markup.cpp:
  • html/FTPDirectoryDocument.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/parser/HTMLTreeBuilder.cpp:
  • loader/appcache/ManifestParser.cpp:
  • platform/chromium/PopupMenuChromium.cpp:
  • platform/graphics/Font.h:
  • platform/graphics/FontFastPath.cpp:
  • platform/graphics/GlyphPageTreeNode.cpp:
  • platform/graphics/StringTruncator.cpp:
  • platform/graphics/mac/ComplexTextController.cpp:
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:
  • platform/graphics/wince/GraphicsContextWinCE.cpp:
  • platform/mac/PasteboardMac.mm:
  • platform/text/TextCodecICU.cpp:
  • platform/text/mac/TextCodecMac.cpp:
  • platform/text/transcoder/FontTranscoder.cpp:
  • rendering/RenderBlockLineLayout.cpp:
  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderText.cpp:
  • rendering/RenderTextControl.cpp:
  • rendering/RenderTreeAsText.cpp:
  • rendering/break_lines.cpp:
  • rendering/mathml/RenderMathMLOperator.h:
  • websockets/WebSocketHandshake.cpp:
  • wml/WMLTableElement.cpp:

2011-01-29 Patrick Gansterer <paroga@webkit.org>

Reviewed by David Kilzer.

Move CharacterNames.h into WTF directory
https://bugs.webkit.org/show_bug.cgi?id=49618

  • src/ChromeClientImpl.cpp:
3:39 AM Changeset in webkit [77061] by commit-queue@webkit.org
  • 11 edits in trunk

2011-01-29 Dan Winship <danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Require the latest glib and libsoup, and remove conditional
support for older versions
https://bugs.webkit.org/show_bug.cgi?id=50675

  • autotools/webkit.m4: use AM_PATH_GLIB_2_0 rather than doing basically the same work by hand
  • configure.ac:

2011-01-29 Dan Winship <danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Remove HAVE_LIBSOUP_2_29_90 conditionals; we depend on
libsoup 2.33.1 now.
https://bugs.webkit.org/show_bug.cgi?id=50675

  • platform/network/soup/CookieJarSoup.cpp: (WebCore::defaultCookieJar): (WebCore::setCookies):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::prepareForURL): (WebCore::restartedCallback): (WebCore::startHttp):
  • platform/network/soup/ResourceRequestSoup.cpp: (WebCore::ResourceRequest::updateSoupMessage): (WebCore::ResourceRequest::toSoupMessage): (WebCore::ResourceRequest::updateFromSoupMessage):

2011-01-29 Dan Winship <danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Remove HAVE_LIBSOUP_2_29_90 conditionals; we depend on
libsoup 2.33.1 now.
https://bugs.webkit.org/show_bug.cgi?id=50675

  • ewk/ewk_cookies.cpp: (ewk_cookies_file_set): (ewk_cookies_policy_set): (ewk_cookies_policy_get):

2011-01-29 Dan Winship <danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Remove HAVE_LIBSOUP_2_29_90 and HAVE_GSETTINGS conditionals;
we depend on glib 2.27.4 and libsoup 2.33.1 now.
https://bugs.webkit.org/show_bug.cgi?id=50675

  • GNUmakefile.am:
  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::storeSetting):
  • webkit/webkitprivate.cpp: (inspectorGSettings):
  • webkit/webkitprivate.h:
1:22 AM Changeset in webkit [77060] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should replace URLs with about:blank instead of the empty string
https://bugs.webkit.org/show_bug.cgi?id=53370

Using the empty string will make the URL complete to the current
document's URL, which isn't really what we want. Instead, we want to
use about:blank, which is safe.

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterObjectToken): (WebCore::XSSFilter::filterEmbedToken):
1:20 AM Changeset in webkit [77059] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should pass xssAuditor/script-tag-addslashes*
https://bugs.webkit.org/show_bug.cgi?id=53365

We need to canonicalize strings to avoid being tricked by addslashes.

  • html/parser/XSSFilter.cpp: (WebCore::HTMLNames::isNonCanonicalCharacter):
    • This function is copied from the XSSAuditor (with some tweaks). We'll eventually remove the XSSAuditor once we've got XSSFilter working properly.

(WebCore::HTMLNames::canonicalize):
(WebCore::HTMLNames::decodeURL):
(WebCore::XSSFilter::isContainedInRequest):

1:19 AM Changeset in webkit [77058] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should pass xssAuditor/script-tag-with-source-same-host.html
and xssAuditor/script-tag-post-*
https://bugs.webkit.org/show_bug.cgi?id=53364

We're supposed to allow loading same-origin resources even if they
appear as part of the request.

Also, we're supposed to look at the POST data too. :)

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::eraseAttributeIfInjected): (WebCore::XSSFilter::isSameOriginResource):
    • Copy/paste from XSSAuditor::isSameOriginResource. We'll eventually remove the XSSAuditor version when XSSFilter is done.
  • html/parser/XSSFilter.h:
1:17 AM Changeset in webkit [77057] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-01-29 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

XSSFilter should pass 16 of the xssAuditor/script-tag* tests
https://bugs.webkit.org/show_bug.cgi?id=53362

Turns out we need to replace the src attribute of script tags with
about:blank to avoid loading the main document URL as a script. Also,
move misplaced return statement that was triggering the console message
too often.

  • html/parser/HTMLToken.h: (WebCore::HTMLToken::appendToAttributeValue):
  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterScriptToken): (WebCore::XSSFilter::eraseAttributeIfInjected):
  • html/parser/XSSFilter.h:
1:11 AM Changeset in webkit [77056] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
12:34 AM Changeset in webkit [77055] by jhoneycutt@apple.com
  • 13 edits
    2 adds in trunk/Source

Downloads in WK2 on Windows should write resume data to bundle
https://bugs.webkit.org/show_bug.cgi?id=53282
<rdar://problem/8753077>

Reviewed by Alice Liu.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj:

Added new files to project.

  • platform/network/cf/DownloadBundle.h: Added.
  • platform/network/win/DownloadBundleWin.cpp: Added.

(WebCore::DownloadBundle::magicNumber):
Moved from WebKit's WebDownload so that WebKit and WebKit2 can share
it.
(WebCore::DownloadBundle::fileExtension):
Ditto.
(WebCore::DownloadBundle::appendResumeData):
Ditto - but modified to return bool rather than HRESULT and to clean up
whitespace.
(WebCore::DownloadBundle::extractResumeData):
Ditto - modified to clean up whitespace.

Source/WebKit/win:

  • WebDownload.cpp:

(WebDownload::bundlePathForTargetPath):
Use the new WebCore::DownloadBundle function.
(WebDownload::request):

  • WebDownload.h:

Removed declarations for functions that were moved to a new location.

  • WebDownloadCFNet.cpp:

(WebDownload::initToResumeWithBundle):
Use the new WebCore::DownloadBundle function.
(WebDownload::cancelForResume):
Fix a leak of the resume data CFDataRef by using adoptCF(). Use the new
WebCore::DownloadBundle function.

Source/WebKit2:

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::decideDestinationWithSuggestedFilename):
Call didDecideDestination(), now that the destination is decided.

  • WebProcess/Downloads/Download.h:

Declare didDecideDestination(). Added member variables to hold the
destination file path and the download bundle path.
(WebKit::Download::destination):
Return the path to the final destination for this download.

  • WebProcess/Downloads/cf/DownloadCFNet.cpp:

(WebKit::Download::start):
Remove the name of an unused param.
(WebKit::Download::startWithHandle):
Ditto.
(WebKit::Download::cancel):
Tell CFNetwork not to delete the file upon failure, and tell it to
cancel the download. Copy the resume data for the download, and append
it to the download bundle. Call didCancel() with an empty
DataReference, since we have written our own resume data.
(WebKit::decideDestinationWithSuggestedObjectNameCallback):
Remove some unused param names. Removed the call to
CFURLDownloadSetDestination() - this is now handled in
Download::didDecideDestination().
(WebKit::didCreateDestinationCallback):
Report that the final destination was created, rather than the download
bundle, matching old WebKit.
(WebKit::Download::didDecideDestination):
Store the final destination and the download bundle paths, and call
CFURLDownloadSetDestination(), passing the path to the download bundle.

  • WebProcess/Downloads/curl/DownloadCurl.cpp:

(WebKit::Download::didDecideDestination):
Stubbed.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::didDecideDestination):
Stubbed - unneeded on the Mac.

  • WebProcess/Downloads/qt/DownloadQt.cpp:

(WebKit::Download::didDecideDestination):
Stubbed.

12:27 AM Changeset in webkit [77054] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit2

2011-01-29 Jeff Miller <jeffm@apple.com>

Reviewed by Anders Carlsson.

Support find bouncy in WebKit2 on Windows
https://bugs.webkit.org/show_bug.cgi?id=53329
<rdar://problem/8565843>
The Mac implements the find bouncy inside of WebKit in the UI process for WebKit2, but we need to do this inside Safari for WebKit2 on Windows.
Add infrastructure to call back into the app when the find indicator changes.

  • UIProcess/API/C/win/WKView.cpp: Cleanup some code style violations. (WKViewSetFindIndicatorCallback): Added. (WKViewGetFindIndicatorCallback): Added.
  • UIProcess/API/C/win/WKView.h: Cleanup some code style violations.
  • UIProcess/FindIndicator.cpp: (WebKit::FindIndicator::create): (WebKit::FindIndicator::FindIndicator): (WebKit::FindIndicator::frameRect): (WebKit::FindIndicator::draw): Rename m_selectionRect to m_selectionRectInWindowCoordinates and m_textRects to m_textRectsInSelectionRectCoordinates (along with similarly named local variables) to be more explict about the coordinate system.
  • UIProcess/FindIndicator.h: (WebKit::FindIndicator::selectionRectInWindowCoordinates): Added. (WebKit::FindIndicator::textRects): Rename m_textRects to m_textRectsInSelectionRectCoordinates.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setFindIndicator): Rename selectionRect to selectionRectInWindowCoordinates and textRects to textRectsInSelectionRectCoordinates to be more explict about the coordinate system.
  • UIProcess/WebPageProxy.h: Ditto.
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::setFindIndicator): Added. (WebKit::WebView::setFindIndicatorCallback): Added. (WebKit::WebView::getFindIndicatorCallback): Added.
  • UIProcess/win/WebView.h:
12:23 AM Changeset in webkit [77053] by rniwa@webkit.org
  • 4 edits
    2 deletes in trunk

2011-01-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77050.
http://trac.webkit.org/changeset/77050
https://bugs.webkit.org/show_bug.cgi?id=53371

Caused a crash in Chromium's test_shell_tests (Requested by
rniwa on #webkit).

  • resources/performance-test.js: Removed.
  • tiny-innerHTML.html: Removed.

2011-01-29 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77050.
http://trac.webkit.org/changeset/77050
https://bugs.webkit.org/show_bug.cgi?id=53371

Caused a crash in Chromium's test_shell_tests (Requested by
rniwa on #webkit).

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): (WebCore::HTMLTreeBuilder::FragmentParsingContext::document): (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
  • html/parser/HTMLTreeBuilder.h:
12:13 AM Changeset in webkit [77052] by rniwa@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-01-29 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed rebaselines and test expectation updates for Chromium Linux.

  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.checksum: Added.
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.png: Added.
  • platform/chromium-linux/fast/forms/select-dirty-parent-pref-widths-expected.txt: Added.
  • platform/chromium/test_expectations.txt:

Jan 28, 2011:

11:56 PM Changeset in webkit [77051] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-28 Alexey Proskuryakov <ap@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=53367
<rdar://problem/8926460> Remove dysfunctional code from -[WKPrintingView _isPrintingPreview].

  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _isPrintingPreview]): The common branch works fine for now, no need to make platforms different.
11:37 PM Changeset in webkit [77050] by eric@webkit.org
  • 4 edits
    2 adds in trunk

2011-01-28 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719

It's unclear exactly what the Peacekeeper benchmark is testing,
because I haven't found a way to run it myself.

However, I constructed a benchmark which shows at least one possible slow point.
The HTML5 spec talks about creating a new document for every time we use
the fragment parsing algorithm. Document() it turns out, it a huge bloated
mess, and the constructor and destructor do a huge amount of work.
To avoid constructing (or destructing) documents for each innerHTML call,
this patch adds a shared dummy document used by all innerHTML calls.

  • benchmarks/parser/tiny-innerHTML.html: Added.

2011-01-28 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

HTML5 TreeBuilder regressed a Peacekeeper DOM test by 40%
https://bugs.webkit.org/show_bug.cgi?id=48719

It's unclear exactly what the Peacekeeper benchmark is testing,
because I haven't found a way to run it myself.

However, I constructed a benchmark which shows at least one possible slow point.
The HTML5 spec talks about creating a new document for every time we use
the fragment parsing algorithm. Document() it turns out, it a huge bloated
mess, and the constructor and destructor do a huge amount of work.
To avoid constructing (or destructing) documents for each innerHTML call,
this patch adds a shared dummy document used by all innerHTML calls.

This patch brings us from 7x slower than Safari 5 on tiny-innerHTML
to only 1.5x slower than Safari 5. I'm sure there is more work to do here.

Saving a shared Document like this is error prone. Currently
DummyDocumentFactory::releaseDocument() calls removeAllChildren()
in an attempt to clear the Document's state. However it's possible
that that call is not sufficient and we'll have future bugs here.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::DummyDocumentFactory::createDummyDocument): (WebCore::DummyDocumentFactory::releaseDocument): (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): (WebCore::HTMLTreeBuilder::FragmentParsingContext::document): (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
  • html/parser/HTMLTreeBuilder.h:
11:06 PM Changeset in webkit [77049] by jnd@chromium.org
  • 3 edits
    2 adds in trunk

2011-01-28 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Gesture API, disallow popup bypass with using iframe src.
https://bugs.webkit.org/show_bug.cgi?id=53244

  • fast/events/popup-blocked-from-iframe-src-expected.txt: Added.
  • fast/events/popup-blocked-from-iframe-src.html: Added.

2011-01-28 Johnny Ding <jnd@chromium.org>

Reviewed by Adam Barth.

Gesture API: Don't use current gesture status to set "forceUserGesture" parameter when calling ScriptController::executeScript.
The "forceUserGesture" parameter should be only set when you are definitely sure that the running script is from a hyper-link.
https://bugs.webkit.org/show_bug.cgi?id=53244

Test: fast/events/popup-blocked-from-iframe-src.html

  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeIfJavaScriptURL):
11:00 PM Changeset in webkit [77048] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; removed Chromium test expectations for tests that have been steadily passing.

In particular, many ietestcenter tests have been passing since V8 is updated to
version 3.0.12 in Chromium r72940.

  • platform/chromium/test_expectations.txt:
10:25 PM Changeset in webkit [77047] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-28 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; roll WebKit Chromium revision from 72894 to 73048.

  • DEPS:
9:56 PM Changeset in webkit [77046] by mitz@apple.com
  • 7 edits
    2 copies in trunk/LayoutTests

Updated test results after r76983.

Rubber-stamped by Maciej Stachowiak.

  • platform/mac-leopard/fast/forms/select-writing-direction-natural-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-writing-direction-natural-expected.txt.
  • platform/mac-leopard/fast/text/international/bidi-menulist-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-menulist-expected.txt.
  • platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.png:
  • platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/mac/fast/text/international/bidi-menulist-expected.checksum:
  • platform/mac/fast/text/international/bidi-menulist-expected.png:
  • platform/mac/fast/text/international/bidi-menulist-expected.txt:
9:02 PM Changeset in webkit [77045] by simon.fraser@apple.com
  • 6 edits in trunk

2011-01-28 Simon Fraser <simon.fraser@apple.com>

Reviewed by Gavin Barraclough.

Add various clampToInt() methods to MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=52910

Use clampToInteger() from MathExtras.h

  • css/CSSParser.cpp: (WebCore::CSSParser::parseCounter):
8:06 PM Changeset in webkit [77044] by rniwa@webkit.org
  • 125 edits
    2 deletes in trunk/Source

2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77006 and r77020.
http://trac.webkit.org/changeset/77006
http://trac.webkit.org/changeset/77020
https://bugs.webkit.org/show_bug.cgi?id=53360

"Broke Windows tests" (Requested by rniwa on #webkit).

  • API/JSCallbackObject.h: (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::setPrivateProperty):
  • API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): (JSObjectSetPrivateProperty):
  • API/JSWeakObjectMapRefInternal.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::globalObject):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply): (JSC::BytecodeGenerator::findScopedProperty):
  • debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame):
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation): (JSC::DebuggerActivation::markChildren):
  • debugger/DebuggerActivation.h:
  • debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate):
  • interpreter/CallFrame.h: (JSC::ExecState::exception):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::unwindCallFrame): (JSC::appendSourceToError): (JSC::Interpreter::execute): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::GlobalObject):
  • runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists):
  • runtime/Arguments.cpp: (JSC::Arguments::markChildren): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put):
  • runtime/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice):
  • runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
  • runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor): (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow):
  • runtime/ConservativeSet.h: (JSC::ConservativeSet::~ConservativeSet): (JSC::ConservativeSet::mark):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DatePrototype.cpp: (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear):
  • runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::markChildren):
  • runtime/GetterSetter.h: (JSC::GetterSetter::GetterSetter): (JSC::GetterSetter::getter): (JSC::GetterSetter::setGetter): (JSC::GetterSetter::setter): (JSC::GetterSetter::setSetter):
  • runtime/GlobalEvalFunction.cpp: (JSC::GlobalEvalFunction::GlobalEvalFunction): (JSC::GlobalEvalFunction::markChildren):
  • runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::cachedGlobalObject):
  • runtime/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::value): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): (JSC::JSActivation::put):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::unshiftCount): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToRegisters): (JSC::JSArray::compactForSorting):
  • runtime/JSArray.h: (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::uncheckedSetIndex): (JSC::JSArray::markChildrenDirect):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.h: (JSC::JSCell::JSValue::toThisObject): (JSC::JSCell::MarkStack::append):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype): (JSC::JSGlobalObject::markChildren):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::regExpConstructor): (JSC::JSGlobalObject::errorConstructor): (JSC::JSGlobalObject::evalErrorConstructor): (JSC::JSGlobalObject::rangeErrorConstructor): (JSC::JSGlobalObject::referenceErrorConstructor): (JSC::JSGlobalObject::syntaxErrorConstructor): (JSC::JSGlobalObject::typeErrorConstructor): (JSC::JSGlobalObject::URIErrorConstructor): (JSC::JSGlobalObject::evalFunction): (JSC::JSGlobalObject::objectPrototype): (JSC::JSGlobalObject::functionPrototype): (JSC::JSGlobalObject::arrayPrototype): (JSC::JSGlobalObject::booleanPrototype): (JSC::JSGlobalObject::stringPrototype): (JSC::JSGlobalObject::numberPrototype): (JSC::JSGlobalObject::datePrototype): (JSC::JSGlobalObject::regExpPrototype): (JSC::JSGlobalObject::methodCallDummy): (JSC::Structure::prototypeForLookup): (JSC::constructArray):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object): (JSC::Stringifier::markAggregate): (JSC::Stringifier::stringify): (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::callReviver): (JSC::Walker::walk):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::removeDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::putDescriptor): (JSC::JSObject::defineOwnProperty):
  • runtime/JSObject.h: (JSC::JSObject::getDirectOffset): (JSC::JSObject::putDirectOffset): (JSC::JSObject::flattenDictionaryObject): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::JSValue::putDirect): (JSC::JSObject::allocatePropertyStorageInline): (JSC::JSObject::markChildrenDirect):
  • runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): (JSC::JSPropertyNameIterator::get):
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
  • runtime/JSString.cpp: (JSC::StringObject::create):
  • runtime/JSValue.h:
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::markChildren):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue):
  • runtime/LiteralParser.cpp: (JSC::LiteralParser::parse):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::lookupPut):
  • runtime/MarkStack.h: (JSC::MarkStack::appendValues):
  • runtime/MathObject.cpp: (JSC::MathObject::MathObject):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor): (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyDescriptor):
  • runtime/Operations.h: (JSC::normalizePrototypeChain): (JSC::resolveBase):
  • runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::print):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::~ScopeChainNode): (JSC::ScopeChainIterator::operator*): (JSC::ScopeChainIterator::operator->): (JSC::ScopeChain::top):
  • runtime/ScopeChainMark.h: (JSC::ScopeChain::markAggregate):
  • runtime/SmallStrings.cpp: (JSC::isMarked): (JSC::SmallStrings::markChildren):
  • runtime/SmallStrings.h: (JSC::SmallStrings::emptyString): (JSC::SmallStrings::singleCharacterString): (JSC::SmallStrings::singleCharacterStrings):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure):
  • runtime/Structure.h: (JSC::Structure::storedPrototype):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::uncheckedGet): (JSC::WeakGCMap::isValid): (JSC::::get): (JSC::::take): (JSC::::set): (JSC::::uncheckedRemove):
  • runtime/WriteBarrier.h: Removed.

2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77006 and r77020.
http://trac.webkit.org/changeset/77006
http://trac.webkit.org/changeset/77020
https://bugs.webkit.org/show_bug.cgi?id=53360

"Broke Windows tests" (Requested by rniwa on #webkit).

  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):

2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77006 and r77020.
http://trac.webkit.org/changeset/77006
http://trac.webkit.org/changeset/77020
https://bugs.webkit.org/show_bug.cgi?id=53360

"Broke Windows tests" (Requested by rniwa on #webkit).

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):

2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r77006 and r77020.
http://trac.webkit.org/changeset/77006
http://trac.webkit.org/changeset/77020
https://bugs.webkit.org/show_bug.cgi?id=53360

"Broke Windows tests" (Requested by rniwa on #webkit).

  • ForwardingHeaders/runtime/WriteBarrier.h: Removed.
  • WebCore.exp.in:
  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSDOMBinding.cpp: (WebCore::markDOMNodesForDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData): (WebCore::getDOMConstructor):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::DialogHandler::dialogCreated):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow): (WebCore::JSDOMWindowShell::markChildren): (WebCore::JSDOMWindowShell::unwrappedObject):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::window): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::createAccelerationObject): (WebCore::createRotationRateObject):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::markJSFunction):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setAll):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain): (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::markAggregate): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::restore):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::putProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod): (JSC::Bindings::QtRuntimeMetaMethod::markChildren): (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
  • bridge/qt/qt_runtime.h:
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate):
  • bridge/runtime_root.h:
  • dom/Document.h:
7:45 PM Changeset in webkit [77043] by mjs@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WKPageGetEstimatedProgress returns wrong value after a mainframe provisional load has started
https://bugs.webkit.org/show_bug.cgi?id=53358

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didStartProgress): Start progress at the magic initial value, not 0.
6:25 PM Changeset in webkit [77042] by mjs@apple.com
  • 8 edits in trunk

2011-01-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setPOSIXLocale
https://bugs.webkit.org/show_bug.cgi?id=42682

  • platform/mac-wk2/Skipped:

2011-01-28 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

WebKitTestRunner needs layoutTestController.setPOSIXLocale
https://bugs.webkit.org/show_bug.cgi?id=42682

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::resetLocalSettings): (WTR::InjectedBundle::didReceiveMessage):
  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setPOSIXLocale):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
6:08 PM Changeset in webkit [77041] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

XSSFilter should log to the console when it blocks something
https://bugs.webkit.org/show_bug.cgi?id=53354

This patch refactors a bunch of methods in XSSFilter to return a bool
indicating whether they blocked anything. Using this bool, we decide
whether to log to the console. We're using the same log message as the
XSSAuditor, but it seems likely we can improve this message in the
future (especially by piping in the correct line number, which is now
accessible via the parser).

  • html/parser/XSSFilter.cpp: (WebCore::HTMLNames::isNameOfInlineEventHandler): (WebCore::XSSFilter::filterToken): (WebCore::XSSFilter::filterTokenInitial): (WebCore::XSSFilter::filterTokenAfterScriptStartTag): (WebCore::XSSFilter::filterScriptToken): (WebCore::XSSFilter::filterObjectToken): (WebCore::XSSFilter::filterEmbedToken): (WebCore::XSSFilter::filterAppletToken): (WebCore::XSSFilter::filterMetaToken): (WebCore::XSSFilter::filterBaseToken): (WebCore::XSSFilter::eraseInlineEventHandlersIfInjected):
  • html/parser/XSSFilter.h:
6:08 PM Changeset in webkit [77040] by mrowe@apple.com
  • 5 edits in branches/safari-533.20-branch

Merge r72046.

6:08 PM Changeset in webkit [77039] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-28 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths

This patch re-enables this test and changes it to
handle all of the mac platform versions, not just the one
it is running on.

https://bugs.webkit.org/show_bug.cgi?id=53356

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
5:41 PM Changeset in webkit [77038] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-28 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Take two. The fix in 77023 didn't work, because we were
still calling path.abspath_to_uri, which calls _cygpath under
the covers, and it appears the cygpath on the bots does
something different than it does on my machine. This patch
removes the calls to path.abspath_to_uri, so it should be safe.
If it doesn't work, I'll roll it out along with r76982 and 77023.

https://bugs.webkit.org/show_bug.cgi?id=53126

  • Scripts/webkitpy/layout_tests/port/test.py:
5:25 PM Changeset in webkit [77037] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.20-branch

Merge r76828.

5:12 PM Changeset in webkit [77036] by mrowe@apple.com
  • 3 edits
    6 adds in branches/safari-533.20-branch

Merge r71182.

5:07 PM Changeset in webkit [77035] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.20-branch

Merge r74574.

4:58 PM Changeset in webkit [77034] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Wire up settings->xssAuditorEnabled to XSSFilter
https://bugs.webkit.org/show_bug.cgi?id=53345

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::XSSFilter): (WebCore::XSSFilter::filterToken):
  • html/parser/XSSFilter.h:
4:57 PM Changeset in webkit [77033] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter about <meta> and <base> tags
https://bugs.webkit.org/show_bug.cgi?id=53339

I'm not 100% sure we need to block <meta http-equiv>, but it seems
prudent given how powerful that attribute is. We definitely need to
block injection of <base href> because that can redirect script tags
that use relative URLs.

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterToken): (WebCore::XSSFilter::filterMetaToken): (WebCore::XSSFilter::filterBaseToken):
  • html/parser/XSSFilter.h:
4:55 PM Changeset in webkit [77032] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter about <applet>
https://bugs.webkit.org/show_bug.cgi?id=53338

HTML5 is pretty light on information about how the <applet> tag works.
According to this site:

http://download.oracle.com/javase/1.4.2/docs/guide/misc/applet.html

The "code" and "object" attributes are the essential attributes for
determining which piece of Java to run. We might need to expand to the
codebase and archive attributes at some point, but hopefully code and
object will be sufficient.

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterToken): (WebCore::XSSFilter::filterAppletToken):
  • html/parser/XSSFilter.h:
4:53 PM Changeset in webkit [77031] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach the XSSFilter about object and embed tags
https://bugs.webkit.org/show_bug.cgi?id=53336

For <object> and <embed>, we filter out attribute values that either
indicate which piece of media to load or which plugin to load. In a
perfect world, we'd only need to filter out the URLs of the media, but
some plug-ins (like Flash) have lots of fun places you can hide the
URL (e.g., the "movie" <param>).

  • html/parser/XSSFilter.cpp: (WebCore::XSSFilter::filterToken): (WebCore::XSSFilter::filterScriptToken): (WebCore::XSSFilter::filterObjectToken): (WebCore::XSSFilter::filterEmbedToken): (WebCore::XSSFilter::eraseAttributeIfInjected):
  • html/parser/XSSFilter.h:
4:53 PM Changeset in webkit [77030] by ddkilzer@apple.com
  • 1 edit in trunk/Tools/ChangeLog

Added link to bug in ChangeLog.

4:50 PM Changeset in webkit [77029] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Yet another build fix (What was I thinking?)

  • WebProcess/Downloads/Download.h:
  • WebProcess/Plugins/PluginProxy.h:
4:46 PM Changeset in webkit [77028] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

<rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode

Reviewed by Mark Rowe.

  • Scripts/webkitdirs.pm:

(checkRequiredSystemConfig): Check the Xcode marketing version
in addition to the DevCoreTools build version before complaining
about an old version of Xcode. Also make the Mac OS X version
check use Perl's built-in version string comparitor.

4:39 PM Changeset in webkit [77027] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed; Fixed Chromium test expectation.

  • platform/chromium/test_expectations.txt:
4:35 PM Changeset in webkit [77026] by andersca@apple.com
  • 4 edits in trunk/WebKitLibraries

Build fix.

Update WKSI.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
4:35 PM Changeset in webkit [77025] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=53352
Heavy external fragmentation in FixedVMPoolAllocator can lead to a CRASH().

Reviewed by Geoff Garen.

The FixedVMPoolAllocator currently uses a best fix policy -
switch to first fit, this is less prone to external fragmentation.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::AllocationTableSizeClass::AllocationTableSizeClass):
(JSC::AllocationTableSizeClass::blockSize):
(JSC::AllocationTableSizeClass::blockCount):
(JSC::AllocationTableSizeClass::blockAlignment):
(JSC::AllocationTableSizeClass::size):
(JSC::AllocationTableLeaf::AllocationTableLeaf):
(JSC::AllocationTableLeaf::~AllocationTableLeaf):
(JSC::AllocationTableLeaf::allocate):
(JSC::AllocationTableLeaf::free):
(JSC::AllocationTableLeaf::isEmpty):
(JSC::AllocationTableLeaf::isFull):
(JSC::AllocationTableLeaf::size):
(JSC::AllocationTableLeaf::classForSize):
(JSC::AllocationTableLeaf::dump):
(JSC::LazyAllocationTable::LazyAllocationTable):
(JSC::LazyAllocationTable::~LazyAllocationTable):
(JSC::LazyAllocationTable::allocate):
(JSC::LazyAllocationTable::free):
(JSC::LazyAllocationTable::isEmpty):
(JSC::LazyAllocationTable::isFull):
(JSC::LazyAllocationTable::size):
(JSC::LazyAllocationTable::dump):
(JSC::LazyAllocationTable::classForSize):
(JSC::AllocationTableDirectory::AllocationTableDirectory):
(JSC::AllocationTableDirectory::~AllocationTableDirectory):
(JSC::AllocationTableDirectory::allocate):
(JSC::AllocationTableDirectory::free):
(JSC::AllocationTableDirectory::isEmpty):
(JSC::AllocationTableDirectory::isFull):
(JSC::AllocationTableDirectory::size):
(JSC::AllocationTableDirectory::classForSize):
(JSC::AllocationTableDirectory::dump):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::allocated):
(JSC::FixedVMPoolAllocator::isValid):
(JSC::FixedVMPoolAllocator::classForSize):
(JSC::FixedVMPoolAllocator::offsetToPointer):
(JSC::FixedVMPoolAllocator::pointerToOffset):
(JSC::ExecutableAllocator::committedByteCount):
(JSC::ExecutableAllocator::isValid):
(JSC::ExecutableAllocator::underMemoryPressure):
(JSC::ExecutablePool::systemAlloc):
(JSC::ExecutablePool::systemRelease):

  • wtf/PageReservation.h:

(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::committed):

4:33 PM Changeset in webkit [77024] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix Windows build.

  • Shared/PrintInfo.h:
4:32 PM Changeset in webkit [77023] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-28 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Work around breakage on Win 7 Release bot caused by r76982
and the fact that windows ports use "file:////" instead of
"file:///". Ideally the test code should be isolated from
this, but it isn't yet. Will fix properly in a bit.

  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4:30 PM Changeset in webkit [77022] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r71642.

4:30 PM Changeset in webkit [77021] by jberlin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Windows 7 Release Tests] fast/repaint/select-option-background-color.html failing since
introduction in r76826.
https://bugs.webkit.org/show_bug.cgi?id=53327

Add the pixel-test results missing from http://trac.webkit.org/changeset/76976. Unreviewed.

  • platform/win/fast/repaint/select-option-background-color-expected.checksum: Added.
  • platform/win/fast/repaint/select-option-background-color-expected.png: Added.
4:29 PM Changeset in webkit [77020] by oliver@apple.com
  • 3 edits in trunk/Source/WebCore

Fixed Qt build.

4:23 PM Changeset in webkit [77019] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

CSS styles are shared based on uninitialized property values
https://bugs.webkit.org/show_bug.cgi?id=53285

Reviewed by Simon Fraser.

Null test.

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::mappedMapsEquivalent):

4:22 PM Changeset in webkit [77018] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r68860.

4:20 PM Changeset in webkit [77017] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.20-branch

Merge r70681.

4:15 PM Changeset in webkit [77016] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.20-branch

Merge r69345.

4:12 PM Changeset in webkit [77015] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r69735.

4:12 PM Changeset in webkit [77014] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
4:08 PM Changeset in webkit [77013] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix tyop.

  • Shared/mac/CoreAnimationRenderer.mm:
4:06 PM Changeset in webkit [77012] by andersca@apple.com
  • 2 edits
    2 adds in trunk/Source/WebKit2

2011-01-28 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add CoreAnimationRenderer class
https://bugs.webkit.org/show_bug.cgi?id=53343

  • Shared/mac/CoreAnimationRenderer.h: Added.
  • Shared/mac/CoreAnimationRenderer.mm: Added.

(WebKit::CoreAnimationRenderer::CoreAnimationRenderer):
Initialize the underlying CARenderer object and hook up a notification observer.

(WebKit::CoreAnimationRenderer::~CoreAnimationRenderer):
Assert that the client is null. It has been set to null by the call to invalidate().

(WebKit::CoreAnimationRenderer::setBounds):
Update the bounds on the CARenderer and the root layer.

(WebKit::CoreAnimationRenderer::render):
Ask the renderer to render and return the next frame time.

(WebKit::CoreAnimationRenderer::invalidate):
Remove the change observer and reset the client.

(WebKit::CoreAnimationRenderer::rendererDidChange):
Call the client member function.

  • WebKit2.xcodeproj/project.pbxproj: Add new files.
4:02 PM Changeset in webkit [77011] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533.20-branch

Merge r69476.

3:59 PM Changeset in webkit [77010] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.20-branch

Merge r68819.

3:52 PM Changeset in webkit [77009] by mrowe@apple.com
  • 8 edits
    4 adds in branches/safari-533.20-branch

Merge r70797.

3:44 PM Changeset in webkit [77008] by mrowe@apple.com
  • 7 edits
    2 adds in branches/safari-533.20-branch

Merge r73432.

3:42 PM Changeset in webkit [77007] by andersca@apple.com
  • 13 edits in trunk/Source/WebKit2

2011-01-28 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add an OBJC_CLASS macro for forward declaring an Objective-C class
https://bugs.webkit.org/show_bug.cgi?id=53337

  • Shared/NativeWebKeyboardEvent.h:
  • Shared/PrintInfo.h:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.h:
  • UIProcess/LayerBackedDrawingAreaProxy.h:
  • UIProcess/WebInspectorProxy.h:
  • UIProcess/mac/WebContextMenuProxyMac.h:
  • UIProcess/mac/WebPopupMenuProxyMac.h:
  • WebProcess/Downloads/Download.h:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/WebPage/LayerBackedDrawingArea.h:
  • WebProcess/WebPage/WebPage.h:
  • config.h:
3:39 PM Changeset in webkit [77006] by oliver@apple.com
  • 123 edits
    2 adds in trunk/Source

2011-01-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

Move the MarkStack over to a slot based marking API.

In order to avoiding aliasing concerns there are two new types
that need to be used when holding on to JSValues and JSCell that
need to be marked: WriteBarrier and DeprecatedPtr. WriteBarrier
is expected to be used for any JSValue or Cell that's lifetime and
marking is controlled by another GC object. DeprecatedPtr is used
for any value that we need to rework ownership for.

The change over to this model has produced a large amount of
code changes, but they are mostly mechanical (forwarding JSGlobalData,
etc).

  • API/JSCallbackObject.h: (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::setPrivateProperty):
  • API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor): (JSObjectSetPrivateProperty):
  • API/JSWeakObjectMapRefInternal.h:
  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::globalObject):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply): (JSC::BytecodeGenerator::findScopedProperty):
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation): (JSC::DebuggerActivation::markChildren):
  • debugger/DebuggerActivation.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::unwindCallFrame): (JSC::appendSourceToError): (JSC::Interpreter::execute): (JSC::Interpreter::privateExecute):
  • interpreter/Register.h: (JSC::Register::jsValueSlot):
  • jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::GlobalObject):
  • runtime/Arguments.cpp: (JSC::Arguments::markChildren): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put):
  • runtime/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice):
  • runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
  • runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor): (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean):
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/ConservativeSet.h: (JSC::ConservativeSet::mark):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance):
  • runtime/DatePrototype.cpp: (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear):
  • runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::markChildren):
  • runtime/GetterSetter.h: (JSC::GetterSetter::GetterSetter): (JSC::GetterSetter::getter): (JSC::GetterSetter::setGetter): (JSC::GetterSetter::setter): (JSC::GetterSetter::setSetter):
  • runtime/GlobalEvalFunction.cpp: (JSC::GlobalEvalFunction::GlobalEvalFunction): (JSC::GlobalEvalFunction::markChildren):
  • runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::cachedGlobalObject):
  • runtime/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots):
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::value): (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
  • runtime/JSActivation.cpp: (JSC::JSActivation::put):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::unshiftCount): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToRegisters): (JSC::JSArray::compactForSorting):
  • runtime/JSArray.h: (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::uncheckedSetIndex): (JSC::JSArray::markChildrenDirect):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
  • runtime/JSCell.h: (JSC::JSCell::MarkStack::append): (JSC::JSCell::MarkStack::appendCell):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype): (JSC::JSGlobalObject::markChildren):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::regExpConstructor): (JSC::JSGlobalObject::errorConstructor): (JSC::JSGlobalObject::evalErrorConstructor): (JSC::JSGlobalObject::rangeErrorConstructor): (JSC::JSGlobalObject::referenceErrorConstructor): (JSC::JSGlobalObject::syntaxErrorConstructor): (JSC::JSGlobalObject::typeErrorConstructor): (JSC::JSGlobalObject::URIErrorConstructor): (JSC::JSGlobalObject::evalFunction): (JSC::JSGlobalObject::objectPrototype): (JSC::JSGlobalObject::functionPrototype): (JSC::JSGlobalObject::arrayPrototype): (JSC::JSGlobalObject::booleanPrototype): (JSC::JSGlobalObject::stringPrototype): (JSC::JSGlobalObject::numberPrototype): (JSC::JSGlobalObject::datePrototype): (JSC::JSGlobalObject::regExpPrototype): (JSC::JSGlobalObject::methodCallDummy): (JSC::constructArray):
  • runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object): (JSC::Stringifier::Holder::objectSlot): (JSC::Stringifier::markAggregate): (JSC::Stringifier::stringify): (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::callReviver): (JSC::Walker::walk):
  • runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::removeDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::putDescriptor): (JSC::JSObject::defineOwnProperty):
  • runtime/JSObject.h: (JSC::JSObject::putDirectOffset): (JSC::JSObject::putUndefinedAtDirectOffset): (JSC::JSObject::flattenDictionaryObject): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::JSValue::putDirect): (JSC::JSObject::allocatePropertyStorageInline): (JSC::JSObject::markChildrenDirect):
  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
  • runtime/JSString.cpp: (JSC::StringObject::create):
  • runtime/JSValue.h:
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::markChildren):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue):
  • runtime/LiteralParser.cpp: (JSC::LiteralParser::parse):
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h: (JSC::lookupPut):
  • runtime/MarkStack.h:
  • runtime/MathObject.cpp: (JSC::MathObject::MathObject):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor): (JSC::constructWithNumberConstructor):
  • runtime/NumberObject.cpp: (JSC::constructNumber):
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyDescriptor):
  • runtime/Operations.h: (JSC::normalizePrototypeChain): (JSC::resolveBase):
  • runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base):
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
  • runtime/ScopeChain.cpp: (JSC::ScopeChainNode::print):
  • runtime/ScopeChain.h: (JSC::ScopeChainNode::~ScopeChainNode): (JSC::ScopeChainIterator::operator*): (JSC::ScopeChainIterator::operator->): (JSC::ScopeChain::top):
  • runtime/ScopeChainMark.h: (JSC::ScopeChain::markAggregate):
  • runtime/SmallStrings.cpp: (JSC::isMarked): (JSC::SmallStrings::markChildren):
  • runtime/SmallStrings.h: (JSC::SmallStrings::emptyString): (JSC::SmallStrings::singleCharacterString): (JSC::SmallStrings::singleCharacterStrings):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringObject.cpp: (JSC::StringObject::StringObject):
  • runtime/StringObject.h:
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/Structure.cpp: (JSC::Structure::flattenDictionaryStructure):
  • runtime/Structure.h: (JSC::Structure::storedPrototypeSlot):
  • runtime/WeakGCMap.h: (JSC::WeakGCMap::uncheckedGet): (JSC::WeakGCMap::uncheckedGetSlot): (JSC::::get): (JSC::::take): (JSC::::set): (JSC::::uncheckedRemove):
  • runtime/WriteBarrier.h: Added. (JSC::DeprecatedPtr::DeprecatedPtr): (JSC::DeprecatedPtr::get): (JSC::DeprecatedPtr::operator*): (JSC::DeprecatedPtr::operator->): (JSC::DeprecatedPtr::slot): (JSC::DeprecatedPtr::operator UnspecifiedBoolType*): (JSC::DeprecatedPtr::operator!): (JSC::WriteBarrierBase::set): (JSC::WriteBarrierBase::get): (JSC::WriteBarrierBase::operator*): (JSC::WriteBarrierBase::operator->): (JSC::WriteBarrierBase::slot): (JSC::WriteBarrierBase::operator UnspecifiedBoolType*): (JSC::WriteBarrierBase::operator!): (JSC::WriteBarrier::WriteBarrier): (JSC::operator==):

2011-01-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

There's no reason to recurse here, the value we
were marking was protected.

  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):

2011-01-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

Update WebCore to the new marking apis, correct bindings
codegen.

  • ForwardingHeaders/runtime/WriteBarrier.h: Added.
  • WebCore.exp.in:
  • bindings/js/DOMWrapperWorld.h: (WebCore::DOMWrapperWorld::globalData):
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSDOMBinding.cpp: (WebCore::markDOMNodesForDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript):
  • bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData): (WebCore::getDOMConstructor):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::DialogHandler::dialogCreated):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow): (WebCore::JSDOMWindowShell::markChildren): (WebCore::JSDOMWindowShell::unwrappedObject):
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::window): (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::markJSFunction):
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setAll):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageDataCustom.cpp: (WebCore::toJS):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain): (WebCore::JSJavaScriptCallFrame::scopeType):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::markAggregate): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::restore):
  • bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set):
  • bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::putProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.h:

2011-01-27 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Convert markstack to a slot visitor API
https://bugs.webkit.org/show_bug.cgi?id=53219

Update to new marking api

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):
3:38 PM Changeset in webkit [77005] by mrowe@apple.com
  • 6 edits
    2 adds in branches/safari-533.20-branch

Merge r74636.

3:33 PM Changeset in webkit [77004] by dpranke@chromium.org
  • 6 edits in trunk/Tools

2011-01-28 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: change worker model values to
"old-inline", "old-threads" in preparation for test_runner2 /
multiprocessing changes.

https://bugs.webkit.org/show_bug.cgi?id=53156

  • Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3:21 PM Changeset in webkit [77003] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Keyboard scrolling doesn’t work in WebKit2
<rdar://problem/8909672>

Reviewed by Anders Carlsson.

  • platform/mac/ScrollAnimatorMac.mm:

(-[ScrollAnimationHelperDelegate convertSizeToBacking:]):
(-[ScrollAnimationHelperDelegate convertSizeFromBacking:]):
Add additional necessary delegate methods.

3:18 PM Changeset in webkit [77002] by mrowe@apple.com
  • 5 edits
    35 adds in branches/safari-533.20-branch

Merge r72802.

3:18 PM Changeset in webkit [77001] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r68321.

3:12 PM Changeset in webkit [77000] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Don't put config.h in the message headers.

Reviewed by Sam Weinig.

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
3:12 PM Changeset in webkit [76999] by Darin Adler
  • 4 edits in trunk/Source/WebCore

Re-land this patch with the missing null check that caused crashes in layout tests.

Reviewed by Dan Bernstein.

Changing cursor style has no effect until the mouse moves
https://bugs.webkit.org/show_bug.cgi?id=14344
rdar://problem/7563712

No tests added because we don't have infrastructure for testing actual cursor
changes (as opposed to cursor style computation) at this time. We might add it later.

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon): Added.

  • page/EventHandler.h: Ditto.
  • rendering/RenderObject.cpp:

(WebCore::areNonIdenticalCursorListsEqual): Added.
(WebCore::areCursorsEqual): Added.
(WebCore::RenderObject::styleDidChange): Call dispatchFakeMouseMoveEventSoon if
cursor styles changed.

3:12 PM Changeset in webkit [76998] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-01-28 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

committers.py - add an IRC nickname for dpranke
https://bugs.webkit.org/show_bug.cgi?id=53335

  • Scripts/webkitpy/common/config/committers.py:
3:05 PM Changeset in webkit [76997] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533.20-branch

Merge r70740.

3:03 PM Changeset in webkit [76996] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • Shared/mac/ShareableSurface.cpp:
2:55 PM Changeset in webkit [76995] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to unbreak the Windows build.

  • UIProcess/cf/WebPageProxyCF.cpp:
2:51 PM Changeset in webkit [76994] by tony@chromium.org
  • 7 edits in trunk/LayoutTests

2011-01-28 Tony Chang <tony@chromium.org>

Unreviewed, a chromium win/linux rebaseline. The mac result was
rebaselined in r76735.

  • platform/chromium-linux/fast/overflow/overflow-rtl-vertical-expected.checksum:
  • platform/chromium-linux/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.checksum:
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png:
  • platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.txt:
  • platform/chromium/test_expectations.txt:
2:48 PM Changeset in webkit [76993] by beidson@apple.com
  • 9 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=53330
Need InjectedBundle API to get the response MIMEType for a URL

Reviewed by John Sullivan.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyMIMETypeForResourceWithURL):

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

Get the MIMEType from the in-memory cache, or cachedResponseMIMETypeForURL() if not available:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::mimeTypeForResourceWithURL):

  • WebProcess/WebPage/WebFrame.h:

Get the MIMEType from the platform's disk cache if available:

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::cachedResponseMIMETypeForURL):

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::cachedResponseMIMETypeForURL):

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::cachedResponseMIMETypeForURL):

2:41 PM Changeset in webkit [76992] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r74779.

2:31 PM Changeset in webkit [76991] by andersca@apple.com
  • 62 edits in trunk/Source/WebKit2

Clean up the mess introduced when config.h was added to the project:

Reviewed by Sam Weinig.

  • Remove the contents of WebKit2Prefix.h that is now in config.h, to avoid including everything twice in each file, probably slowing down compile time.
  • Add config.h to all the files that were forgotten in order to keep the build from breaking.
  • Added trap to ensure that config.h is included at the top of every implementation file. If this had been added it would have caught the previous issue.
2:26 PM Changeset in webkit [76990] by jschuh@chromium.org
  • 6 edits
    2 adds in trunk

2011-01-28 Justin Schuh <jschuh@chromium.org>

Reviewed by Eric Seidel.

We should hold RefPtrs to SVG font faces
https://bugs.webkit.org/show_bug.cgi?id=53270

  • svg/custom/use-multiple-on-nested-disallowed-font-expected.txt: Added.
  • svg/custom/use-multiple-on-nested-disallowed-font.html: Added.

2011-01-28 Justin Schuh <jschuh@chromium.org>

Reviewed by Eric Seidel.

We should hold RefPtrs to SVG font faces
https://bugs.webkit.org/show_bug.cgi?id=53270

Test: svg/custom/use-multiple-on-nested-disallowed-font.html

  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
  • css/CSSFontFaceSource.h:
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::associatedFontElement):
  • svg/SVGFontFaceElement.h:
2:26 PM Changeset in webkit [76989] by slewis@apple.com
  • 5 edits in trunk/Source/WebKit2

<rdar://problem/8857651> Implement unregisterWorld for WebKit2
Rename unregisterWorld to clearWrappers. Clearing the wrappers reduces the
memory use of isolated worlds.

Reviewed by Geoff Garen.

  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:

(WKBundleScriptWorldClearWrappers):

  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h:
  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:

(WebKit::InjectedBundleScriptWorld::clearWrappers):

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
2:20 PM Changeset in webkit [76988] by zmo@google.com
  • 7 edits in trunk

2011-01-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

uniformN*v should generate INVALID_VALUE of the array size is not a multiple of N
https://bugs.webkit.org/show_bug.cgi?id=53306

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateUniformMatrixParameters):

2011-01-28 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

uniformN*v should generate INVALID_VALUE of the array size is not a multiple of N
https://bugs.webkit.org/show_bug.cgi?id=53306

  • fast/canvas/webgl/gl-uniform-arrays-expected.txt:
  • fast/canvas/webgl/gl-uniform-arrays.html:
  • fast/canvas/webgl/gl-uniformmatrix4fv-expected.txt:
  • fast/canvas/webgl/gl-uniformmatrix4fv.html:
2:17 PM Changeset in webkit [76987] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-28 Tom Sepez <tsepez@chromium.org>

Reviewed by Eric Seidel.

NULL pointer crash in TextIterator::handleTextBox()
https://bugs.webkit.org/show_bug.cgi?id=53267

  • fast/css/rtl-nth-child-first-letter-crash-expected.txt: Added.
  • fast/css/rtl-nth-child-first-letter-crash.html: Added.

2011-01-28 Tom Sepez <tsepez@chromium.org>

Reviewed by Eric Seidel.

NULL pointer crash in TextIterator::handleTextBox()
https://bugs.webkit.org/show_bug.cgi?id=53267

Test: fast/css/rtl-nth-child-first-letter-crash.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextBox):
2:08 PM Changeset in webkit [76986] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-01-28 Dimitri Glazkov <Dimitri Glazkov>

Skip webkitAudioPannerNode from the test. It's not yet implemented across
all ports/platforms.

  • fast/dom/script-tests/prototype-inheritance.js: Skipped webkitAudioPannerNode.
1:58 PM Changeset in webkit [76985] by mnaganov@chromium.org
  • 8 edits in branches/chromium/648

Merge 76683 - 2011-01-26 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: inspector tests fix.

  • http/tests/inspector/inspector-test2.js: (initialize_InspectorTest.InspectorTest.evaluateInPage):
  • inspector/console-format.html:

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6282016

1:55 PM Changeset in webkit [76984] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-28 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Remove a spurious diagnostic CRASH check.
https://bugs.webkit.org/show_bug.cgi?id=52379

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::invalidateRect):
1:34 PM Changeset in webkit [76983] by mitz@apple.com
  • 55 edits
    1 add in trunk/Source

Source/WebCore: <rdar://problem/4761512> <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

Changed <select> pop-up menus on Mac OS X Snow Leopard and later to have their items aligned in the
direction corresponding to the writing direction of the <select> element, with the checkmarks
on the "start" side, and use the <option>'s writing direction rather than "natural". Made the
pop-up button match the menu by adding a Chrome boolean function, selectItemAlignmentFollowsMenuWritingDirection(),
which returns true for this pop-up behavior.

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • manual-tests/pop-up-alignment-and-direction.html: Added.
  • page/Chrome.cpp:

(WebCore::Chrome::selectItemAlignmentFollowsMenuWritingDirection): Added. Calls through to the
client.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/PopupMenuStyle.h:

(WebCore::PopupMenuStyle::PopupMenuStyle): Added hasTextDirectionOverride parameter and member
variable initialization.
(WebCore::PopupMenuStyle::hasTextDirectionOverride): Added this accessor.

  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenuMac::populate): Set the pop-up's layout direction and items' text alignment
to match the menu's writing direction. Set items' writing direction and direction override
according to their styles.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList): Removed unncesaary initialization of a smart pointer.
(WebCore::RenderMenuList::adjustInnerStyle): If the alignment of items in the menu follows the
menu's writing direction, use that alignment for the button as well. Also in this mode, use the
item's writing direction and override setting.
(WebCore::RenderMenuList::setTextFromOption): Store the option element's style.
(WebCore::RenderMenuList::itemStyle): Pass the text direction override value.
(WebCore::RenderMenuList::menuStyle): Ditto. Also use the button's direction, not the inner text's.

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::menuStyle): Pass the text direction override value.

Source/WebKit/chromium: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • src/AutoFillPopupMenuClient.cpp:

(WebKit::AutoFillPopupMenuClient::initialize): Pass hasTextDirectionOverride to the PopupMenuStyle
constructor.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • src/ChromeClientImpl.h:
  • tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::itemStyle): Pass hasTextDirectionOverride to the PopupMenuStyle
constructor.

Source/WebKit/efl: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/haiku: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/ChromeClientHaiku.cpp:

(WebCore::ChromeClientHaiku::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebCoreSupport/ChromeClientHaiku.h:

Source/WebKit/mac: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.

Source/WebKit/qt: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit/wx: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebKitSupport/ChromeClientWx.h:

Source/WebKit2: <select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785

Reviewed by Sam Weinig.

  • Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::WebPopupItem): Added initializers for m_textDirection and m_hasTextDirectionOverride.
(WebKit::WebPopupItem::encode): Encode the item's writing direction and direction override values.
(WebKit::WebPopupItem::decode): Decode the item's writing direction and direction override values.

  • Shared/WebPopupItem.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu): Added a parameter for the menu's text direction.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • UIProcess/WebPopupMenuProxy.h:
  • UIProcess/mac/WebPopupMenuProxyMac.h:
  • UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::populate): Added a parameter for the menu's text direction.
Set items' text alignment to match the menu's writing direction. Set items' writing direction
and direction override according to their styles.
(WebKit::WebPopupMenuProxyMac::showPopupMenu): Set the pop-up's layout direction.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
(WebKit::WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::populateItems): Initialize items' writing direction and direction override
values.
(WebKit::WebPopupMenu::show): Pass the menu's writing direction.

1:34 PM Changeset in webkit [76982] by dpranke@chromium.org
  • 5 edits
    2 adds in trunk/Tools

2011-01-28 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: add a "mock DRT" port implementation
and a separate class that emulates what we expect the
DumpRenderTree behavior to be.

This will eventually replace port/dryrun.py and allow us to get
better test coverage of the new-run-webkit-tests code as well as
a reference for what new-run-webkit-tests expects from DRT.

This is the first attempt at this, and it is pretty bare-boned. It
really only has been tested on the 'mac' port (and a little on
the 'chromium-mac' port.

https://bugs.webkit.org/show_bug.cgi?id=53126

  • Scripts/webkitpy/common/system/filesystem_mock.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
  • Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
  • Scripts/webkitpy/layout_tests/port/test.py:
1:31 PM Changeset in webkit [76981] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Teach XSSFilter how to filter <script> elements
https://bugs.webkit.org/show_bug.cgi?id=53279

This patch adds the ability for the XSSFilter to block injected
<script> elements. Handling script elements is slightly subtle because
these elements act very differently depending on whether they have a
src attribute.


In the "src case", which check whether the src attribute was present in
the request. In the "non-src case", we check whether the start tag and
the body of the script element was included in the request. Checking
for the whole start tag means we miss out on some attribute splitting
attacks inside of script tags, but that doesn't seem like that big a
deal.

This patch also introduces some amount of state into the XSSFilter
because inline script elements span multiple tokens. There's a lot of
tuning and optimization left in these cases, some of which I've noted
with FIXMEs.

To test this patch, I played around with some of the existing
XSSAuditor tests. Hopefully I'll be able to run the test suite more
systematically in the future.

  • html/parser/HTMLToken.h: (WebCore::HTMLToken::eraseCharacters): (WebCore::HTMLToken::eraseValueOfAttribute):
  • html/parser/XSSFilter.cpp: (WebCore::HTMLNames::hasName): (WebCore::HTMLNames::findAttributeWithName): (WebCore::HTMLNames::isNameOfScriptCarryingAttribute): (WebCore::XSSFilter::XSSFilter): (WebCore::XSSFilter::filterToken): (WebCore::XSSFilter::filterTokenAfterScriptStartTag): (WebCore::XSSFilter::filterScriptToken): (WebCore::XSSFilter::snippetForRange): (WebCore::XSSFilter::snippetForAttribute):
  • html/parser/XSSFilter.h:
1:29 PM Changeset in webkit [76980] by abarth@webkit.org
  • 10 edits
    2 adds in trunk/Source/WebCore

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Daniel Bates.

Sketch out new XSS filter design (disabled by default)
https://bugs.webkit.org/show_bug.cgi?id=53205

This patch adds a basic sketch of the new XSS filter design. Rather
than watching scripts as they execute, in this design, we watch tokens
emitted by the tokenizer. We then map the tokens directly back into
input characters, which lets us skip all the complicated logic related
to HTML entities and double-decoding of JavaScript URLs.

This patch contains only the bare essentially machinery. I'll add more
in future patches and eventually remove the previous code once this
code is up and running correctly.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::sourceForToken):
  • html/parser/HTMLDocumentParser.h:
  • html/parser/XSSFilter.cpp: Added.
  • html/parser/XSSFilter.h: Added.
1:29 PM Changeset in webkit [76979] by mrobinson@webkit.org
  • 2 edits in trunk

2011-01-28 Martin Robinson <mrobinson@igalia.com>

[GTK] Build failure with --enable-indexed-database
https://bugs.webkit.org/show_bug.cgi?id=50954

Build fix for IndexedDB support.

  • configure.ac: Change the autogen.sh option --enable-indexeddb to --enable-indexed-database to match the build-webkit option.
1:27 PM Changeset in webkit [76978] by Dimitri Glazkov
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

2011-01-28 Dimitri Glazkov <Dimitri Glazkov>

[Chromium] Added expectations for a passing test.

  • platform/chromium-mac/fast/dom/isindex-002-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/isindex-002-expected.png: Added.
  • platform/chromium-mac/fast/dom/isindex-002-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
1:22 PM Changeset in webkit [76977] by Dimitri Glazkov
  • 6 edits
    2 adds in trunk/LayoutTests

2011-01-28 Dimitri Glazkov <Dimitri Glazkov>

Updated Chromium baselines for a bug that was fixed.
https://bugs.webkit.org/show_bug.cgi?id=45527

  • platform/chromium-linux/fast/dom/replaceChild-expected.checksum:
  • platform/chromium-linux/fast/dom/replaceChild-expected.png:
  • platform/chromium-mac/fast/dom/replaceChild-expected.checksum: Added.
  • platform/chromium-mac/fast/dom/replaceChild-expected.png: Added.
  • platform/chromium-win/fast/dom/replaceChild-expected.checksum:
  • platform/chromium-win/fast/dom/replaceChild-expected.png:
  • platform/chromium/test_expectations.txt: Removed expectation of failure.
1:04 PM Changeset in webkit [76976] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Windows 7 Release Tests] fast/repaint/select-option-background-color.html failing since introduction in r76826
https://bugs.webkit.org/show_bug.cgi?id=53327

Unreviewed, adding Windows-specific results to get the Windows 7 Release Test bot green.

  • platform/win/fast/repaint/select-option-background-color-expected.txt: Added.
12:51 PM Changeset in webkit [76975] by Adam Roben
  • 2 edits in trunk/Source/JavaScriptCore

Chromium build fix after r76967

  • wtf/ThreadingPrimitives.h: Use OS(WINDOWS) instead of PLATFORM(WIN), to match other

similar macros in this file.

12:39 PM Changeset in webkit [76974] by andersca@apple.com
  • 2 edits
    2 adds in trunk/Source/WebKit2

2011-01-28 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Add ShareableSurface class
https://bugs.webkit.org/show_bug.cgi?id=53313

  • Shared/mac/ShareableSurface.cpp: Added. (WebKit::ShareableSurface::Handle::Handle): Initialize the mach port.

(WebKit::ShareableSurface::Handle::~Handle):
Deallocate our send right if needed.

(WebKit::ShareableSurface::Handle::encode):
Encode the send right, and then null it out.

(WebKit::ShareableSurface::Handle::decode):
Decode the send right.


(WebKit::createIOSurface):
Create an IOSurface with the given size.

(WebKit::ShareableSurface::create):
Create an IOSurface, either from a size or from a handle.

(WebKit::ShareableSurface::~ShareableSurface):
Delete the texture and framebuffer.

(WebKit::ShareableSurface::createHandle):
Create a mach port from the surface.

(WebKit::ShareableSurface::attach):
Create an FBO if needed and bind it.

(WebKit::ShareableSurface::detach):
Unbind the FBO.

(WebKit::ShareableSurface::textureID):
Generate a new texture and bind it to the IOSurface.

  • Shared/mac/ShareableSurface.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Add new files.
12:35 PM Changeset in webkit [76973] by psolanki@apple.com
  • 1 edit
    1 delete in trunk/Tools

Unreviewed. Removing .swp file checked in by mistake.

  • Scripts/.webkitdirs.pm.swp: Removed.
12:33 PM Changeset in webkit [76972] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-28 Adam Klein <adamk@chromium.org>

Reviewed by Kent Tamura.

[Chromium] Remove deprecated openFileSystem method signature
https://bugs.webkit.org/show_bug.cgi?id=53262

Chromium still builds after this patch.

  • public/WebFrameClient.h:
12:27 PM Changeset in webkit [76971] by psolanki@apple.com
  • 2 edits
    1 add in trunk/Tools

2011-01-28 Pratik Solanki <psolanki@apple.com>

Reviewed by David Kilzer.

Space not necessary for undefined feature
https://bugs.webkit.org/show_bug.cgi?id=53317

  • Scripts/build-webkit:
12:26 PM Changeset in webkit [76970] by rniwa@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-28 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines.

Check in the same result as fast/dom/window-domurl-crash-expected.txt because Windows port
intentionally added a failing result in http://trac.webkit.org/changeset/76953.

The Windows port's bug is tracked by https://bugs.webkit.org/show_bug.cgi?id=53310.

  • platform/chromium-win/fast/dom/window-domurl-crash-expected.txt: Added.
12:21 PM Changeset in webkit [76969] by msaboff@apple.com
  • 5 edits in trunk/Source

2011-01-28 Michael Saboff <msaboff@apple.com>

Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
https://bugs.webkit.org/show_bug.cgi?id=53271

Reapplying this this change. No change from prior patch in
JavaScriptCore.

Added new isValid() methods to check if a contained object in
a WeakGCMap is valid when using an unchecked iterator.

  • runtime/WeakGCMap.h: (JSC::WeakGCMap::isValid):

2011-01-28 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
https://bugs.webkit.org/show_bug.cgi?id=53271

Reapplying this patch with the change that the second ASSERT in
RootObject::removeRuntimeObject was changed to use
.uncheckedGet() instead of the failing .get(). The object in question
could be in the process of being GC'ed. The get() call will not return
such an object while the uncheckedGet() call will return the (unsafe)
object. This is the behavior we want.

Precautionary change.
Changed RootObject to use WeakGCMap instead of HashSet.
Found will looking for another issue, but can't produce a test case
that is problematic. THerefore there aren't any new tests.

  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::addRuntimeObject): (JSC::Bindings::RootObject::removeRuntimeObject):
  • bridge/runtime_root.h:
12:16 PM Changeset in webkit [76968] by Adam Roben
  • 4 edits in trunk

Notify CACFLayerTreeHost when the context is flushed

LegacyCACFLayerTreeHost was keeping this a secret, which meant that WebCore's animation
timers were never starting.

Fixes <http://webkit.org/b/53302> [Windows 7 Release Tests] changesets 76853, 76856, and
76858 broke ~36 animations, compositing, and transitions tests

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:

(WebCore::LegacyCACFLayerTreeHost::contextDidChange): Call up to the base class after we
start our render timer.

LayoutTests:

Unskip compositing-related tests that are now fixed

  • platform/win/Skipped:
12:16 PM Changeset in webkit [76967] by Adam Roben
  • 8 edits
    1 copy in trunk/Source

Change BinarySemaphore to wrap an auto-reset Win32 event on Windows

Fixes <http://webkit.org/b/53208> <rdar://problem/8922490>.

Reviewed by Dave Hyatt.

Source/WebKit2:

  • Platform/CoreIPC/BinarySemaphore.cpp: Wrap this implementation in #if !PLATFORM(WIN).
  • Platform/CoreIPC/BinarySemaphore.h: Make the Windows implementation have a single HANDLE

member that holds the event.

  • Platform/CoreIPC/win/BinarySemaphoreWin.cpp: Copied from Source/WebKit2/Platform/CoreIPC/BinarySemaphore.cpp.

(CoreIPC::BinarySemaphore::BinarySemaphore): Create our event.
(CoreIPC::BinarySemaphore::~BinarySemaphore): Destory our event.
(CoreIPC::BinarySemaphore::signal): Signal the event.
(CoreIPC::BinarySemaphore::wait): Convert the absolute time to a wait interval, then wait
for the event to be signaled or for the interval to elapse.

  • win/WebKit2.vcproj: Added BinarySemaphoreWin.cpp. Also let VS have its way with the file.

Source/JavaScriptCore:

Extract code to convert a WTF absolute time to a Win32 wait interval into a separate
function

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export the new function.
  • wtf/ThreadingPrimitives.h: Declare the new function.
  • wtf/ThreadingWin.cpp:

(WTF::ThreadCondition::timedWait): Moved code to convert the absolute time to a wait
interval from here...
(WTF::absoluteTimeToWaitTimeoutInterval): ...to here.

12:15 PM Changeset in webkit [76966] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

Remove dead code that tried to map from CSS values to parser values
https://bugs.webkit.org/show_bug.cgi?id=53318

Reviewed by Dan Bernstein.

  • css/CSSFunctionValue.cpp:
  • css/CSSFunctionValue.h:
  • css/CSSPrimitiveValue.cpp:
  • css/CSSPrimitiveValue.h:
  • css/CSSValue.h:
  • css/CSSValueList.cpp:
  • css/CSSValueList.h:
12:14 PM Changeset in webkit [76965] by jberlin@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Windows 7 Release Tests] fast/text/justify-ideograph-complex/simple/vertical.html failing since introduction in r76743.
https://bugs.webkit.org/show_bug.cgi?id=53321

Unreviewed, checking in failing expected results to get the Windows 7 Release Tests bots green.

  • platform/win/fast/text/justify-ideograph-complex-expected.txt: Added.
  • platform/win/fast/text/justify-ideograph-simple-expected.txt: Added.
  • platform/win/fast/text/justify-ideograph-vertical-expected.txt: Added.
12:11 PM Changeset in webkit [76964] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-01-28 Dimitri Glazkov <Dimitri Glazkov>

Remove now-passing test from expectations.

  • platform/chromium/test_expectations.txt: Expectation of failure removed.
12:08 PM Changeset in webkit [76963] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-01-28 Dimitri Glazkov <Dimitri Glazkov>

Update expectations for prototype-inheritance to match platform/mac.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt: Updated.
11:48 AM Changeset in webkit [76962] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-27 Chris Marrin <cmarrin@apple.com>

Reviewed by Anders Carlsson.

WebKit2: Page flashes just before accelerated compositing animation
https://bugs.webkit.org/show_bug.cgi?id=53274

When switching out of compositing mode, the new ChunkedUpdateDrawingAreaProxy
is getting created with the current page size. When the setSize() call is
subsequently made, the sizeDidChange() call is not made (which does the initial
render of the page) because the old size and new size are the same. The solution
is to skip the setting of the size in the ctor and let it go through a size
change sequence.

  • UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy):
11:46 AM Changeset in webkit [76961] by enrica@apple.com
  • 3 edits
    4 deletes in trunk

Some drag and drop tests fail since r76824
https://bugs.webkit.org/show_bug.cgi?id=53304

Reviewed by Adam Roben.

Source/WebCore:

There were '
' instead of '&&' in the checks for valid

clipboard content.

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):

LayoutTests:

Removing platform-specific tests after fixing the cause of the failure.

  • platform/win/editing/pasteboard/get-data-text-plain-paste-expected.txt: Removed.
  • platform/win/editing/pasteboard/onpaste-text-html-expected.txt: Removed.
  • platform/win/fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Removed.
  • platform/win/fast/events/ondrop-text-html-expected.txt: Removed.
11:29 AM Changeset in webkit [76960] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-28 Martin Robinson <mrobinson@igalia.com>

[GTK] AudioProcessingEvent.h and JSJavaScriptAudioNode.h: No such file or directory
https://bugs.webkit.org/show_bug.cgi?id=52889

Build fix for WebAudio. Include WebAudio source files on the source
list when WebAudio is enabled.

  • GNUmakefile.am: Include missing source files.
11:18 AM Changeset in webkit [76959] by jberlin@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove the Windows-specific failing results for media/audio-data-url.html, since it appears
to be passing on the bots now. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=51518

  • platform/win/media/audio-data-url-expected.txt: Removed.
11:16 AM Changeset in webkit [76958] by chang.shu@nokia.com
  • 5 edits in trunk

2011-01-28 Chang Shu <chang.shu@nokia.com>

Reviewed by Andreas Kling.

Unskipp auth.html after fix.
https://bugs.webkit.org/show_bug.cgi?id=36688

  • platform/qt/Skipped:

2011-01-28 Chang Shu <chang.shu@nokia.com>

Reviewed by Andreas Kling.

Reset NetworkAccessManager to clean up credentials from previous tests.
This change causes no performance overhead either.
https://bugs.webkit.org/show_bug.cgi?id=36688

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::open):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
11:11 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
fix typos, yuck (diff)
11:06 AM Changeset in webkit [76957] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-01-28 Dimitri Glazkov <Dimitri Glazkov>

Added newly-failing tests to expectations, will be fixing them shortly.
https://bugs.webkit.org/show_bug.cgi?id=53314

  • platform/chromium/test_expectations.txt: Added.
11:05 AM Changeset in webkit [76956] by weinig@apple.com
  • 12 edits in trunk/Source

Add basic rubber banding support
<rdar://problem/8219429>
https://bugs.webkit.org/show_bug.cgi?id=53277

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

  • wtf/Platform.h: Add ENABLE for rubber banding.

Source/WebCore:

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
Pass gesture events to the FrameView.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleGestureEvent):

  • platform/ScrollAnimator.h:

Add stubbed out implementation.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::wheelEvent):

  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::ScrollableArea):
(WebCore::ScrollableArea::handleGestureEvent):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::constrainsScrollingToContentEdge):
(WebCore::ScrollableArea::setConstrainsScrollingToContentEdge):
Move constrains scrolling bit to ScrollableArea from ScrollView.

(WebCore::ScrollableArea::contentsSize):
(WebCore::ScrollableArea::overhangAmount):
Add additional virtual functions for information needed by the animator.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):
(WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):
(WebCore::elasticDeltaForTimeDelta):
(WebCore::elasticDeltaForReboundDelta):
(WebCore::reboundDeltaForElasticDelta):
(WebCore::scrollWheelMultiplier):
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::handleGestureEvent):
(WebCore::ScrollAnimatorMac::pinnedInDirection):
(WebCore::ScrollAnimatorMac::allowsVerticalStretching):
(WebCore::ScrollAnimatorMac::allowsHorizontalStretching):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
(WebCore::ScrollAnimatorMac::beginScrollGesture):
(WebCore::ScrollAnimatorMac::endScrollGesture):
(WebCore::ScrollAnimatorMac::snapRubberBand):
(WebCore::roundTowardZero):
(WebCore::roundToDevicePixelTowardZero):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
Implement basic rubber banding.

11:05 AM Changeset in webkit [76955] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Adding tests broken on Windows 7 Release in 76853,76856,76858 to the Skipped list to get the
Windows 7 Release Bot green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53302

  • platform/win/Skipped:
11:00 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
use --minimal only if you have to (test what you ship) (diff)
10:46 AM Changeset in webkit [76954] by mitz@apple.com
  • 3 edits
    4 adds in trunk

Changing unicode-bidi doesn’t force layout
https://bugs.webkit.org/show_bug.cgi?id=53311

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/dynamic/unicode-bidi.html

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Return a layout difference if unicode-bidi values differ.

LayoutTests:

  • fast/dynamic/unicode-bidi-expected.checksum: Added.
  • fast/dynamic/unicode-bidi-expected.png: Added.
  • fast/dynamic/unicode-bidi-expected.txt: Added.
  • fast/dynamic/unicode-bidi.html: Added.
10:44 AM Changeset in webkit [76953] by jberlin@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add Windows expected (failing) results to get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53310

  • platform/win/fast/dom/window-domurl-crash-expected.txt: Added.
10:16 AM Changeset in webkit [76952] by jberlin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Check in Windows-specific expected results to get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53307

  • platform/win/fast/multicol: Added.
  • platform/win/fast/multicol/vertical-rl: Added.
  • platform/win/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
  • platform/win/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
9:52 AM Changeset in webkit [76951] by Dimitri Glazkov
  • 9 edits in trunk/Source/WebCore

2011-01-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Change HTMLInputElement-derived parts of media element shadow DOM to use shadowPseudoId.
https://bugs.webkit.org/show_bug.cgi?id=53122

This is the first step in converting HTMLMediaElement to the new shadow DOM.

Should not regress any existing tests. No observable change in behavior.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed now-unnecessary hard-coded pseudo-element selectors. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h: Ditto.
  • css/mediaControls.css: Added proper initial values, now that elements use the proper selector pipeline.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::MediaControlInputElement): Removed the switch statement,

which is now replaced with virtual shadowPseudoId on each corresponding class.

(WebCore::MediaControlInputElement::styleForElement): Changed to use element pipeline.
(WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Changed to set

display type in constructor.

(WebCore::MediaControlMuteButtonElement::create): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlMuteButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement): Added

to disambiguate from the MediaControlMuteButtonElement.

(WebCore::MediaControlVolumeSliderMuteButtonElement::create): Added.
(WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlPlayButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement): Added.
(WebCore::MediaControlSeekForwardButtonElement::create): Added.
(WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement): Added.
(WebCore::MediaControlSeekBackButtonElement::create): Added.
(WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Added.
(WebCore::MediaControlRewindButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Added.
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlTimelineElement::shadowPseudoId): Added.
(WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlVolumeSliderElement::shadowPseudoId): Added.
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement): Changed to not take PseudoId as

constructor argument.

(WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Added.

  • rendering/MediaControlElements.h: (WebCore::MediaControlSeekForwardButtonElement::isForwardButton): Added. (WebCore::MediaControlSeekBackButtonElement::isForwardButton): Added.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createMuteButton): Changed to use new constructor. (WebCore::RenderMedia::createSeekBackButton): Ditto. (WebCore::RenderMedia::createSeekForwardButton): Ditto. (WebCore::RenderMedia::createVolumeSliderMuteButton): Ditto.
  • rendering/style/RenderStyleConstants.h: Removed constants that are no longer used.
9:11 AM Changeset in webkit [76950] by Dimitri Glazkov
  • 13 edits
    2 copies in trunk/Source/WebCore

2011-01-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

Split MediaControls out of RenderMedia.
https://bugs.webkit.org/show_bug.cgi?id=53252

Near-mechanical moving of stuff, no change in behavior, thus no new tests.

  • Android.mk: Added MediaControls to build system.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::defaultEventHandler): Changed to forward events to MediaControls.
  • html/shadow/MediaControls.cpp: Copied all controls-related methods from

Source/WebCore/rendering/RenderMedia.cpp, pulled them into their own class called MediaControls.

  • html/shadow/MediaControls.h: Ditto from Source/WebCore/rendering/RenderMedia.h.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler): Changed to use MediaControls.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::RenderMedia): Moved relevant constructor initializers out to MediaControls. (WebCore::RenderMedia::destroy): Changed to use MediaControls. (WebCore::RenderMedia::styleDidChange): Ditto. (WebCore::RenderMedia::layout): Ditto. (WebCore::RenderMedia::updateFromElement): Ditto.
  • rendering/RenderMedia.h: Updated defs accordingly and removed player() accessor, which

is only used by sub-class RenderVideo.

(WebCore::RenderMedia::controls): Added.

  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::~RenderVideo): Changed to access MediaPlayer* directly from mediaElement(). (WebCore::RenderVideo::calculateIntrinsicSize): Ditto. (WebCore::RenderVideo::paintReplaced): Ditto. (WebCore::RenderVideo::updatePlayer): Ditto. (WebCore::RenderVideo::supportsAcceleratedRendering): Ditto. (WebCore::RenderVideo::acceleratedRenderingStateChanged): Ditto.
9:05 AM Changeset in webkit [76949] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76942.
http://trac.webkit.org/changeset/76942
https://bugs.webkit.org/show_bug.cgi?id=53301

Unskipped tests keep failing on GTK release bots (Requested by
svillar on #webkit).

  • platform/gtk/Skipped:
9:01 AM Changeset in webkit [76948] by jberlin@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add Windows expected (failing) results to get the bots green. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=53304

  • platform/win/editing/pasteboard/get-data-text-plain-paste-expected.txt: Added.
  • platform/win/editing/pasteboard/onpaste-text-html-expected.txt: Added.
  • platform/win/fast/events/drag-and-drop-dataTransfer-types-nocrash-expected.txt: Added.
  • platform/win/fast/events/ondrop-text-html-expected.txt: Added.
8:56 AM Changeset in webkit [76947] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-28 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: allow remote debugging with front-end
served from the cloud.
https://bugs.webkit.org/show_bug.cgi?id=53303

  • inspector/front-end/inspector.js:
8:33 AM Changeset in webkit [76946] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-28 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

Setting value of m_PressedPos to make scrolling smooth

Page scroll popup menu "Scroll here" option not working when cliking above scroll slider/handler.
https://bugs.webkit.org/show_bug.cgi?id=51349

The value of m_PressedPos was getting set before moveThumb() call
in all other scenarios except when "Scroll Here" option is used.
Hence scrolling with this option was not as expected even in cases
where scrolling was happening. The thumb would move in unexpected
direction. m_PressedPos is now set to pressed position so delta is
calculated.
Unable to write a test case as the test needs to click on "Scroll
Here" option of context sensitive menu and QTest is unable to do it.
Besides no new functionality introduced.

  • platform/qt/ScrollbarQt.cpp: (WebCore::Scrollbar::contextMenu):
8:28 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
8:27 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
(diff)
8:24 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
--minimal now works on Symbian , added 64-bit linker notes for … (diff)
8:06 AM Changeset in webkit [76945] by caseq@chromium.org
  • 1 edit
    1 add in trunk/Source/WebCore

2011-01-28 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Extensions API] add JSON schema for extensions API
https://bugs.webkit.org/show_bug.cgi?id=53236

  • inspector/front-end/ExtensionAPISchema.json: Added.
7:56 AM WebKit Team edited by joone.hur@collabora.co.uk
Add myself to committer list (diff)
7:51 AM Changeset in webkit [76944] by zmo@google.com
  • 9 edits in trunk

2011-01-27 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Remove _LENGTH enumerants
https://bugs.webkit.org/show_bug.cgi?id=53259

  • html/canvas/WebGLRenderingContext.cpp: Remove queries for *LENGTH. (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getShaderParameter):
  • html/canvas/WebGLRenderingContext.idl: Remove *LENGTH.

2011-01-27 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Remove _LENGTH enumerants
https://bugs.webkit.org/show_bug.cgi?id=53259

  • fast/canvas/webgl/constants.html:
  • fast/canvas/webgl/gl-getshadersource-expected.txt:
  • fast/canvas/webgl/gl-getshadersource.html:
  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/gl-object-get-calls.html:
7:48 AM Changeset in webkit [76943] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: syntax highlight inline JS and CSS in HTML resources
https://bugs.webkit.org/show_bug.cgi?id=30831

  • inspector/front-end/SourceHTMLTokenizer.js: (WebInspector.SourceHTMLTokenizer): (WebInspector.SourceHTMLTokenizer.prototype.set line): (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
  • inspector/front-end/SourceHTMLTokenizer.re2js:
7:12 AM Changeset in webkit [76942] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Unskipped some tests. They're not failing anymore.

  • platform/gtk/Skipped:
7:07 AM Changeset in webkit [76941] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-28 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [STYLES] Up/Down-suggestion breaks an existing keyword
https://bugs.webkit.org/show_bug.cgi?id=53295

Select the current word suffix before switching to the next suggestion.

  • inspector/front-end/StylesSidebarPane.js: ():
6:34 AM Changeset in webkit [76940] by alex
  • 2 edits in trunk/Source/WebKit/gtk

2011-01-28 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix compilation warning
https://bugs.webkit.org/show_bug.cgi?id=53292

  • webkit/webkitwebframe.cpp: (draw_page_callback): Cast the pageCount from size_t to int, it should be safe considering page_nr is the number of pages, 0-based.
6:27 AM Changeset in webkit [76939] by mnaganov@chromium.org
  • 3 edits in branches/chromium/648

Merge 76795 - 2011-01-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234

  • inspector/debugger-expand-scope.html:
  • inspector/debugger-proto-property.html:

2011-01-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234

  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane): (WebInspector.ScopeChainSidebarPane.prototype.update):

TBR=podivilov@chromium.org
Review URL: http://codereview.chromium.org/6397012

6:24 AM Changeset in webkit [76938] by mnaganov@chromium.org
  • 3 edits in branches/chromium/648

Merge 76788 - 2011-01-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Elements panel] Tooltip for relative links incorrectly identifies current URL
https://bugs.webkit.org/show_bug.cgi?id=53171

WebCore:

  • inspector/front-end/inspector.js: (WebInspector.completeURL): Taught to understand partial href's that start with "?" (contain GET parameters only)

LayoutTests:

  • inspector/styles-url-linkify-expected.txt:
  • inspector/styles-url-linkify.html:

TBR=apavlov@chromium.org
Review URL: http://codereview.chromium.org/6327025

6:19 AM Changeset in webkit [76937] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/bindings/v8/V8Proxy.cpp

Merge 76786 - 2011-01-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Crash in WebCore::addMessageToConsole
https://bugs.webkit.org/show_bug.cgi?id=53227

  • bindings/v8/V8Proxy.cpp: check that the Frame where the error occured still has a page before getting a console object from it. (WebCore::V8Proxy::reportUnsafeAccessTo):

TBR=yurys@chromium.org
Review URL: http://codereview.chromium.org/6324018

6:19 AM Changeset in webkit [76936] by alex
  • 4 edits in trunk/Source

2011-01-28 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix dist compilation for the release
https://bugs.webkit.org/show_bug.cgi?id=53290

  • GNUmakefile.am: Added inspector files to the extra dist.

2011-01-28 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Fix dist compilation for the release
https://bugs.webkit.org/show_bug.cgi?id=53290

  • GNUmakefile.am: Remove a file that is not in the repository anymore.
6:16 AM Changeset in webkit [76935] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js

Merge 76692 - 2011-01-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: visualize \n in strings as unicode cr
symbol in stack variables sidebar.
https://bugs.webkit.org/show_bug.cgi?id=53162

  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.update):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6390007

6:07 AM Changeset in webkit [76934] by mnaganov@chromium.org
  • 12 edits in branches/chromium/648/Source/WebCore/inspector

Merge 76680 - 2011-01-26 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Incorrect on-hover evaluation of a variable named 'profile'.
https://bugs.webkit.org/show_bug.cgi?id=53018

  • inspector/InjectedScript.cpp: (WebCore::InjectedScript::evaluate): (WebCore::InjectedScript::evaluateOnCallFrame): (WebCore::InjectedScript::getCompletions): (WebCore::InjectedScript::getCompletionsOnCallFrame):
  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js: (.):
  • inspector/Inspector.idl:
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame): (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorRuntimeAgent.cpp: (WebCore::InspectorRuntimeAgent::evaluate): (WebCore::InspectorRuntimeAgent::getCompletions):
  • inspector/InspectorRuntimeAgent.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype.evalInInspectedWindow): (WebInspector.ConsoleView.prototype._enterKeyPressed):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper): (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._showPopup):
  • inspector/front-end/WatchExpressionsSidebarPane.js: (WebInspector.WatchExpressionsSection.prototype.update):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6320021

6:02 AM Changeset in webkit [76933] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/HeapSnapshotView.js

Merge 76514 - 2011-01-21 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Chromium] Fix heap snapshot table sorting.

Fix table sorting to avoid qsort instability artefacts.

https://bugs.webkit.org/show_bug.cgi?id=52914

  • inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype._sortData): (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator): (WebInspector.HeapSnapshotDataGridList.propertyComparator):

TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/6405002

5:54 AM Changeset in webkit [76932] by mnaganov@chromium.org
  • 1 edit in branches/chromium/648/Source/WebCore/inspector/front-end/NetworkPanel.js

Merge 76483 - 2011-01-23 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: summary bar is not resized properly with the rest of net
https://bugs.webkit.org/show_bug.cgi?id=52881

  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.updateSidebarWidth): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._toggleGridMode):

TBR=caseq@chromium.org
Review URL: http://codereview.chromium.org/6366026

5:16 AM Changeset in webkit [76931] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-01-28 Andreas Kling <kling@webkit.org>

Rubber-stamped by Simon Hausmann.

[Qt][WK2] Combine QWKPage::engine{Connected,Disconnected} into one signal.

Having two signals for this is redundant, combine them into
QWKPage::engineConnectionChanged(bool connected).

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::didRelaunchProcess): (QWKPagePrivate::processDidCrash):
  • UIProcess/API/qt/qwkpage.h:
5:06 AM Changeset in webkit [76930] by zoltan@webkit.org
  • 3 edits in trunk/Tools

[Qt] Add Zoom Text Only action to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53297

Reviewed by Andreas Kling.

Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::zoomIn):
(BrowserWindow::zoomOut):
(BrowserWindow::resetZoom):
(BrowserWindow::toggleZoomTextOnly):
(BrowserWindow::applyZoom):

  • MiniBrowser/qt/BrowserWindow.h:
4:46 AM Changeset in webkit [76929] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-01-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Andreas Kling.

Const-correct HTMLSelectElement and WebSelectElement
https://bugs.webkit.org/show_bug.cgi?id=53293

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::value): const.
  • html/HTMLSelectElement.h:

2011-01-28 Ilya Sherman <isherman@chromium.org>

Reviewed by Andreas Kling.

Const-correct HTMLSelectElement and WebSelectElement
https://bugs.webkit.org/show_bug.cgi?id=53293

  • public/WebSelectElement.h:
  • src/WebSelectElement.cpp: (WebKit::WebSelectElement::value): const. (WebKit::WebSelectElement::listItems): const.
4:45 AM Changeset in webkit [76928] by podivilov@chromium.org
  • 4 edits in trunk/LayoutTests

2011-01-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: fix debugger-scripts.html (broken by r76587).
https://bugs.webkit.org/show_bug.cgi?id=53112

  • inspector/debugger-scripts-expected.txt:
  • inspector/debugger-scripts.html:
  • platform/chromium/test_expectations.txt:
3:25 AM Changeset in webkit [76927] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-28 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

Adding media/video-controls-rendering.html to the Skipped list of tests.

  • platform/gtk/Skipped:
2:14 AM Changeset in webkit [76926] by abarth@webkit.org
  • 14 edits
    6 adds in trunk/Tools

2011-01-28 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add webkit-patch roll-chromium-deps
https://bugs.webkit.org/show_bug.cgi?id=53288

This command updates the Source/WebKit/chromium/DEPS file with the
last-known good revision of Chromium (or a revision specified on the
command line). I'd eventually like to turn this into a SheriffBot
command, but this is the first step.

This patch somewhat sprawled because I needed to move a bunch of code
out of ChangeLog that should never have been there in the first place.
Also, I had to fix a bug in MockUser in order to test the new command.

  • Scripts/webkitpy/common/checkout/api.py:
  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/deps.py: Added.
  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/roll.py: Added.
  • Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  • Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
  • Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
  • Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1:10 AM Changeset in webkit [76925] by Csaba Osztrogonác
  • 5 edits in trunk/Source

Unreviewed, rolling out r76893.
http://trac.webkit.org/changeset/76893
https://bugs.webkit.org/show_bug.cgi?id=53287

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-01-28
It made some tests crash on GTK and Qt debug bots (Requested
by Ossy on #webkit).

Source/JavaScriptCore:

  • runtime/WeakGCMap.h:

Source/WebCore:

  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::invalidate):
(JSC::Bindings::RootObject::addRuntimeObject):
(JSC::Bindings::RootObject::removeRuntimeObject):

  • bridge/runtime_root.h:
12:33 AM Changeset in webkit [76924] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-01-28 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

12:05 AM Changeset in webkit [76923] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-01-28 Commit Queue <commit-queue@webkit.org>

Unreviewed. Test commit for commit-queue@webkit.org.

Jan 27, 2011:

11:49 PM Changeset in webkit [76922] by Laszlo Gombos
  • 2 edits in trunk/Source/WebKit2

2011-01-27 Laszlo Gombos <Laszlo Gombos>

Reviewed by Maciej Stachowiak.

Build fix for Mac Intel Debug after r76916
https://bugs.webkit.org/show_bug.cgi?id=53284

Fix macro redefinition by guarding the redefined macros.

  • config.h:
11:25 PM Changeset in webkit [76921] by Laszlo Gombos
  • 2 edits in trunk/Source/WebKit2

2011-01-27 Laszlo Gombos <Laszlo Gombos>

Unreviewed build fix for Mac Intel Debug after r76916.

Fix macro redefinition by guarding the redefined macros.

Check if the macro is already defined before defininig it.
c++config.h has the same macros with the same values.

  • config.h:
11:14 PM Changeset in webkit [76920] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt: More media test crashes due to crbug.com/71087.
10:42 PM Changeset in webkit [76919] by Laszlo Gombos
  • 2 edits in trunk/Source/WebKit2

2011-01-27 Laszlo Gombos <Laszlo Gombos>

Reviewed by Adam Barth.

Update the expected results for test-webkitpy after r76916.

Include "config.h" in the expected results as well.

  • Scripts/webkit2/messages_unittest.py:
10:34 PM Changeset in webkit [76918] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

2011-01-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Adam Barth.

Skip some tests that fail due to missing DRT API
https://bugs.webkit.org/show_bug.cgi?id=53283

  • platform/mac-wk2/Skipped:
10:09 PM Changeset in webkit [76917] by Laszlo Gombos
  • 2 edits in trunk/Source/WebKit2

2011-01-27 Laszlo Gombos <Laszlo Gombos>

Unreviewed buildfix for SnowLeopard Intel Debug.

Fix macro redefinition by not including config.h.

Revert previous change in WebPageProxyCF.cpp.

  • UIProcess/cf/WebPageProxyCF.cpp:
9:37 PM Changeset in webkit [76916] by Laszlo Gombos
  • 360 edits
    1 copy in trunk

2011-01-27 Greg Coletta <greg.coletta@nokia.com>

Reviewed by Laszlo Gombos.

Get rid of prefix header dependency for WebKit2 build system
https://bugs.webkit.org/show_bug.cgi?id=50174

Change the style checker so that it enforces config.h include for
WebKit2.

  • Scripts/webkitpy/style/checker.py:

2011-01-27 Greg Coletta <greg.coletta@nokia.com>

Reviewed by Laszlo Gombos.

Get rid of prefix header dependency for WebKit2 build system
https://bugs.webkit.org/show_bug.cgi?id=50174

Guard EmptyProtocalDefinitions.h to make sure it's not included twice.

  • platform/mac/EmptyProtocolDefinitions.h:

2011-01-27 Greg Coletta <greg.coletta@nokia.com>

Reviewed by Laszlo Gombos.

Get rid of prefix header dependency for WebKit2 build system.
https://bugs.webkit.org/show_bug.cgi?id=50174

Add config.h include explicitelly.

  • Platform/CoreIPC/ArgumentDecoder.cpp:
  • Platform/CoreIPC/ArgumentEncoder.cpp:
  • Platform/CoreIPC/Attachment.cpp:
  • Platform/CoreIPC/BinarySemaphore.cpp:
  • Platform/CoreIPC/Connection.cpp:
  • Platform/CoreIPC/DataReference.cpp:
  • Platform/CoreIPC/gtk/ConnectionGtk.cpp:
  • Platform/CoreIPC/mac/ConnectionMac.cpp:
  • Platform/CoreIPC/qt/ConnectionQt.cpp:
  • Platform/CoreIPC/win/ConnectionWin.cpp:
  • Platform/Logging.cpp:
  • Platform/Module.cpp:
  • Platform/Region.cpp:
  • Platform/RunLoop.cpp:
  • Platform/WorkQueue.cpp:
  • Platform/cg/CGUtilities.cpp:
  • Platform/gtk/RunLoopGtk.cpp:
  • Platform/gtk/SharedMemoryGtk.cpp:
  • Platform/gtk/WorkQueueGtk.cpp:
  • Platform/mac/MachUtilities.cpp:
  • Platform/mac/SharedMemoryMac.cpp:
  • Platform/mac/WorkQueueMac.cpp:
  • Platform/qt/MappedMemoryPool.cpp:
  • Platform/qt/ModuleQt.cpp:
  • Platform/qt/RunLoopQt.cpp:
  • Platform/qt/WorkQueueQt.cpp:
  • Platform/win/ModuleWin.cpp:
  • Platform/win/RunLoopWin.cpp:
  • Platform/win/SharedMemoryWin.cpp:
  • Platform/win/WorkQueueWin.cpp:
  • PluginProcess/PluginControllerProxy.cpp:
  • PluginProcess/PluginProcess.cpp:
  • PluginProcess/WebProcessConnection.cpp:
  • Scripts/webkit2/messages.py:
  • Shared/API/c/WKArray.cpp:
  • Shared/API/c/WKCertificateInfo.cpp:
  • Shared/API/c/WKContextMenuItem.cpp:
  • Shared/API/c/WKData.cpp:
  • Shared/API/c/WKDictionary.cpp:
  • Shared/API/c/WKError.cpp:
  • Shared/API/c/WKImage.cpp:
  • Shared/API/c/WKMutableArray.cpp:
  • Shared/API/c/WKMutableDictionary.cpp:
  • Shared/API/c/WKNumber.cpp:
  • Shared/API/c/WKSecurityOrigin.cpp:
  • Shared/API/c/WKSerializedScriptValue.cpp:
  • Shared/API/c/WKString.cpp:
  • Shared/API/c/WKType.cpp:
  • Shared/API/c/WKURL.cpp:
  • Shared/API/c/WKURLRequest.cpp:
  • Shared/API/c/WKURLResponse.cpp:
  • Shared/API/c/WKUserContentURLPattern.cpp:
  • Shared/API/c/cf/WKStringCF.cpp:
  • Shared/API/c/cf/WKURLCF.cpp:
  • Shared/API/c/cf/WKURLRequestCF.cpp:
  • Shared/API/c/cf/WKURLResponseCF.cpp:
  • Shared/API/c/cg/WKImageCG.cpp:
  • Shared/API/c/win/WKCertificateInfoWin.cpp:
  • Shared/ChildProcess.cpp:
  • Shared/ImmutableArray.cpp:
  • Shared/ImmutableDictionary.cpp:
  • Shared/MutableArray.cpp:
  • Shared/MutableDictionary.cpp:
  • Shared/OriginAndDatabases.cpp:
  • Shared/PlatformPopupMenuData.cpp:
  • Shared/Plugins/NPIdentifierData.cpp:
  • Shared/Plugins/NPObjectMessageReceiver.cpp:
  • Shared/Plugins/NPObjectProxy.cpp:
  • Shared/Plugins/NPRemoteObjectMap.cpp:
  • Shared/Plugins/NPVariantData.cpp:
  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:
  • Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
  • Shared/Plugins/PluginProcessCreationParameters.cpp:
  • Shared/PrintInfo.cpp:
  • Shared/SessionState.cpp:
  • Shared/ShareableBitmap.cpp:
  • Shared/UpdateInfo.cpp:
  • Shared/VisitedLinkTable.cpp:
  • Shared/WebBackForwardListItem.cpp:
  • Shared/WebContextMenuItem.cpp:
  • Shared/WebContextMenuItemData.cpp:
  • Shared/WebError.cpp:
  • Shared/WebEvent.cpp:
  • Shared/WebEventConversion.cpp:
  • Shared/WebGeolocationPosition.cpp:
  • Shared/WebImage.cpp:
  • Shared/WebKeyboardEvent.cpp:
  • Shared/WebMemorySampler.cpp:
  • Shared/WebMouseEvent.cpp:
  • Shared/WebOpenPanelParameters.cpp:
  • Shared/WebPageCreationParameters.cpp:
  • Shared/WebPageGroupData.cpp:
  • Shared/WebPlatformTouchPoint.cpp:
  • Shared/WebPopupItem.cpp:
  • Shared/WebPreferencesStore.cpp:
  • Shared/WebProcessCreationParameters.cpp:
  • Shared/WebTouchEvent.cpp:
  • Shared/WebURLRequest.cpp:
  • Shared/WebURLResponse.cpp:
  • Shared/WebWheelEvent.cpp:
  • Shared/cairo/ShareableBitmapCairo.cpp:
  • Shared/cf/ArgumentCodersCF.cpp:
  • Shared/cg/ShareableBitmapCG.cpp:
  • Shared/gtk/ShareableBitmapGtk.cpp:
  • Shared/gtk/WebCoreArgumentCodersGtk.cpp:
  • Shared/mac/CommandLineMac.cpp:
  • Shared/mac/UpdateChunk.cpp:
  • Shared/qt/CleanupHandler.cpp:
  • Shared/qt/NativeWebKeyboardEventQt.cpp:
  • Shared/qt/ShareableBitmapQt.cpp:
  • Shared/qt/UpdateChunk.cpp:
  • Shared/qt/WebCoreArgumentCodersQt.cpp:
  • Shared/qt/WebEventFactoryQt.cpp:
  • Shared/qt/WebURLRequestQt.cpp:
  • Shared/qt/WebURLResponseQt.cpp:
  • Shared/win/CommandLineWin.cpp:
  • Shared/win/NativeWebKeyboardEventWin.cpp:
  • Shared/win/PlatformCertificateInfo.cpp:
  • Shared/win/UpdateChunk.cpp:
  • Shared/win/WebCoreArgumentCodersWin.cpp:
  • Shared/win/WebEventFactory.cpp:
  • Shared/win/WebURLRequestWin.cpp:
  • Shared/win/WebURLResponseWin.cpp:
  • UIProcess/API/C/WKAuthenticationChallenge.cpp:
  • UIProcess/API/C/WKAuthenticationDecisionListener.cpp:
  • UIProcess/API/C/WKBackForwardList.cpp:
  • UIProcess/API/C/WKBackForwardListItem.cpp:
  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKCredential.cpp:
  • UIProcess/API/C/WKDatabaseManager.cpp:
  • UIProcess/API/C/WKDownload.cpp:
  • UIProcess/API/C/WKFormSubmissionListener.cpp:
  • UIProcess/API/C/WKFrame.cpp:
  • UIProcess/API/C/WKFramePolicyListener.cpp:
  • UIProcess/API/C/WKGeolocationManager.cpp:
  • UIProcess/API/C/WKGeolocationPermissionRequest.cpp:
  • UIProcess/API/C/WKGeolocationPosition.cpp:
  • UIProcess/API/C/WKInspector.cpp:
  • UIProcess/API/C/WKNavigationData.cpp:
  • UIProcess/API/C/WKOpenPanelParameters.cpp:
  • UIProcess/API/C/WKOpenPanelResultListener.cpp:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPageGroup.cpp:
  • UIProcess/API/C/WKPreferences.cpp:
  • UIProcess/API/C/WKProtectionSpace.cpp:
  • UIProcess/API/C/win/WKContextWin.cpp:
  • UIProcess/API/C/win/WKView.cpp:
  • UIProcess/API/C/win/WKViewPrivate.cpp:
  • UIProcess/API/cpp/qt/WKStringQt.cpp:
  • UIProcess/API/cpp/qt/WKURLQt.cpp:
  • UIProcess/API/qt/ClientImpl.cpp:
  • UIProcess/API/qt/qgraphicswkview.cpp:
  • UIProcess/API/qt/qwkcontext.cpp:
  • UIProcess/API/qt/qwkpage.cpp:
  • UIProcess/API/qt/qwkpreferences.cpp:
  • UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
  • UIProcess/Authentication/AuthenticationDecisionListener.cpp:
  • UIProcess/Authentication/WebCredential.cpp:
  • UIProcess/Authentication/WebProtectionSpace.cpp:
  • UIProcess/BackingStore.cpp:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
  • UIProcess/Downloads/DownloadProxy.cpp:
  • UIProcess/DrawingAreaProxy.cpp:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/FindIndicator.cpp:
  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
  • UIProcess/GeolocationPermissionRequestProxy.cpp:
  • UIProcess/Launcher/ProcessLauncher.cpp:
  • UIProcess/Launcher/ThreadLauncher.cpp:
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
  • UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
  • UIProcess/Launcher/win/ProcessLauncherWin.cpp:
  • UIProcess/Launcher/win/ThreadLauncherWin.cpp:
  • UIProcess/LayerBackedDrawingAreaProxy.cpp:
  • UIProcess/Plugins/PluginInfoStore.cpp:
  • UIProcess/Plugins/PluginProcessManager.cpp:
  • UIProcess/Plugins/PluginProcessProxy.cpp:
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:
  • UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:
  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
  • UIProcess/ResponsivenessTimer.cpp:
  • UIProcess/TiledDrawingAreaProxy.cpp:
  • UIProcess/VisitedLinkProvider.cpp:
  • UIProcess/WebBackForwardList.cpp:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebContextInjectedBundleClient.cpp:
  • UIProcess/WebContextMenuProxy.cpp:
  • UIProcess/WebDatabaseManagerProxy.cpp:
  • UIProcess/WebDatabaseManagerProxyClient.cpp:
  • UIProcess/WebDownloadClient.cpp:
  • UIProcess/WebEditCommandProxy.cpp:
  • UIProcess/WebFindClient.cpp:
  • UIProcess/WebFormClient.cpp:
  • UIProcess/WebFormSubmissionListenerProxy.cpp:
  • UIProcess/WebFrameListenerProxy.cpp:
  • UIProcess/WebFramePolicyListenerProxy.cpp:
  • UIProcess/WebFrameProxy.cpp:
  • UIProcess/WebGeolocationManagerProxy.cpp:
  • UIProcess/WebGeolocationProvider.cpp:
  • UIProcess/WebHistoryClient.cpp:
  • UIProcess/WebInspectorProxy.cpp:
  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/WebNavigationData.cpp:
  • UIProcess/WebOpenPanelResultListenerProxy.cpp:
  • UIProcess/WebPageContextMenuClient.cpp:
  • UIProcess/WebPageGroup.cpp:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPolicyClient.cpp:
  • UIProcess/WebPreferences.cpp:
  • UIProcess/WebProcessManager.cpp:
  • UIProcess/WebProcessProxy.cpp:
  • UIProcess/WebResourceLoadClient.cpp:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/cf/WebBackForwardListCF.cpp:
  • UIProcess/cf/WebPageProxyCF.cpp:
  • UIProcess/cf/WebPreferencesCF.cpp:
  • UIProcess/gtk/TextCheckerGtk.cpp:
  • UIProcess/gtk/WebInspectorGtk.cpp:
  • UIProcess/gtk/WebPageProxyGtk.cpp:
  • UIProcess/gtk/WebPreferencesGtk.cpp:
  • UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:
  • UIProcess/qt/TextCheckerQt.cpp:
  • UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
  • UIProcess/qt/TiledDrawingAreaTileQt.cpp:
  • UIProcess/qt/WebContextMenuProxyQt.cpp:
  • UIProcess/qt/WebContextQt.cpp:
  • UIProcess/qt/WebInspectorProxyQt.cpp:
  • UIProcess/qt/WebPageProxyQt.cpp:
  • UIProcess/qt/WebPopupMenuProxyQt.cpp:
  • UIProcess/qt/WebPreferencesQt.cpp:
  • UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp:
  • UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp:
  • UIProcess/win/TextCheckerWin.cpp:
  • UIProcess/win/WebContextMenuProxyWin.cpp:
  • UIProcess/win/WebContextWin.cpp:
  • UIProcess/win/WebInspectorProxyWin.cpp:
  • UIProcess/win/WebPageProxyWin.cpp:
  • UIProcess/win/WebPopupMenuProxyWin.cpp:
  • UIProcess/win/WebView.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Authentication/AuthenticationManager.cpp:
  • WebProcess/Downloads/Download.cpp:
  • WebProcess/Downloads/DownloadManager.cpp:
  • WebProcess/Downloads/cf/DownloadCFNet.cpp:
  • WebProcess/Downloads/curl/DownloadCurl.cpp:
  • WebProcess/Downloads/qt/DownloadQt.cpp:
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
  • WebProcess/Geolocation/WebGeolocationManager.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardList.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePageGroup.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:
  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:
  • WebProcess/InjectedBundle/InjectedBundleClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
  • WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
  • WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp:
  • WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
  • WebProcess/Plugins/Plugin.cpp:
  • WebProcess/Plugins/PluginProcessConnection.cpp:
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:
  • WebProcess/Plugins/PluginProxy.cpp:
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPopupMenu.cpp:
  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
  • WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:
  • WebProcess/WebCoreSupport/gtk/WebPopupMenuGtk.cpp:
  • WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp:
  • WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
  • WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
  • WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp:
  • WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp:
  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
  • WebProcess/WebKitMain.cpp:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
  • WebProcess/WebPage/DecoderAdapter.cpp:
  • WebProcess/WebPage/DrawingArea.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/EncoderAdapter.cpp:
  • WebProcess/WebPage/FindController.cpp:
  • WebProcess/WebPage/LayerBackedDrawingArea.cpp:
  • WebProcess/WebPage/PageOverlay.cpp:
  • WebProcess/WebPage/TiledDrawingArea.cpp:
  • WebProcess/WebPage/WebBackForwardListProxy.cpp:
  • WebProcess/WebPage/WebContextMenu.cpp:
  • WebProcess/WebPage/WebEditCommand.cpp:
  • WebProcess/WebPage/WebFrame.cpp:
  • WebProcess/WebPage/WebInspector.cpp:
  • WebProcess/WebPage/WebOpenPanelResultListener.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPageGroupProxy.cpp:
  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
  • WebProcess/WebPage/mac/ChunkedUpdateDrawingAreaMac.cpp:
  • WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp:
  • WebProcess/WebPage/qt/TiledDrawingAreaQt.cpp:
  • WebProcess/WebPage/qt/WebInspectorQt.cpp:
  • WebProcess/WebPage/qt/WebPageQt.cpp:
  • WebProcess/WebPage/win/ChunkedUpdateDrawingAreaWin.cpp:
  • WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp:
  • WebProcess/WebPage/win/WebInspectorWin.cpp:
  • WebProcess/WebPage/win/WebPageWin.cpp:
  • WebProcess/WebProcess.cpp:
  • WebProcess/gtk/WebProcessGtk.cpp:
  • WebProcess/gtk/WebProcessMainGtk.cpp:
  • WebProcess/qt/WebProcessMainQt.cpp:
  • WebProcess/qt/WebProcessQt.cpp:
  • WebProcess/win/WebProcessMainWin.cpp:
  • WebProcess/win/WebProcessWin.cpp:
  • config.h: Copied from Source/WebKit2/WebKit2Prefix.h.
  • win/WebKit2Common.vsprops:
9:30 PM Changeset in webkit [76915] by inferno@chromium.org
  • 3 edits
    3 adds in trunk

2011-01-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Recalc table sections if needed before calculating the first line
box baseline.
https://bugs.webkit.org/show_bug.cgi?id=53265

When we try to calculate the baseline position of a table cell,
we recurse through all the child sibling boxes (when children are
non inline) and add their first linebox baseline values. If one of
the children is a table with pending section recalc, we will access
wrong table section values. We recalc table sections if it is needed.

Test: fast/table/recalc-section-first-body-crash-main.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::firstLineBoxBaseline):

2011-01-27 Abhishek Arya <inferno@chromium.org>

Reviewed by Dan Bernstein.

Tests that we do not crash when calculating the first line box
baseline for the table.
https://bugs.webkit.org/show_bug.cgi?id=53265

  • fast/table/recalc-section-first-body-crash-main-expected.txt: Added.
  • fast/table/recalc-section-first-body-crash-main.html: Added.
  • fast/table/resources/recalc-section-first-body-crash.html: Added.
8:26 PM Changeset in webkit [76914] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-01-27 Adrienne Walker <enne@google.com>

Reviewed by Kenneth Russell.

[chromium] Add CRASH calls to further debug tiled compositor memcpy crash.
https://bugs.webkit.org/show_bug.cgi?id=52379

Test: LayoutTests/compositing (to verify these weren't triggered)

  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::invalidateRect): (WebCore::LayerTilerChromium::update):
8:14 PM Changeset in webkit [76913] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [STYLES] Cancelled suggestion of a property name results in a visual artifact
https://bugs.webkit.org/show_bug.cgi?id=53242

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
7:42 PM Changeset in webkit [76912] by commit-queue@webkit.org
  • 6 edits in trunk/Source

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76891.
http://trac.webkit.org/changeset/76891
https://bugs.webkit.org/show_bug.cgi?id=53280

Makes every layout test crash (Requested by othermaciej on
#webkit).

  • page/EventHandler.cpp:
  • page/EventHandler.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleDidChange):

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76891.
http://trac.webkit.org/changeset/76891
https://bugs.webkit.org/show_bug.cgi?id=53280

Makes every layout test crash (Requested by othermaciej on
#webkit).

  • Misc/WebIconDatabase.mm: (-[ThreadEnabler threadEnablingSelector:]): (importToWebCoreFormat):
7:30 PM Changeset in webkit [76911] by rniwa@webkit.org
  • 4 edits
    8 deletes in trunk

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed, rolling out r76839.
http://trac.webkit.org/changeset/76839
https://bugs.webkit.org/show_bug.cgi?id=49744

broke pixel tests

  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect):

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed, rolling out r76839.
http://trac.webkit.org/changeset/76839
https://bugs.webkit.org/show_bug.cgi?id=49744

broke pixel tests

  • editing/selection/caret-painting-after-paste-undo-rtl.html: Removed.
  • editing/selection/caret-painting-after-paste-undo.html: Removed.
  • platform/mac/editing/deleting/5408255-expected.png:
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Removed.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Removed.
7:18 PM Changeset in webkit [76910] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-533.20-branch/LayoutTests

Merge r64815.

7:18 PM Changeset in webkit [76909] by mrowe@apple.com
  • 6 edits
    1 copy
    1 move
    3 adds
    2 deletes in branches/safari-533.20-branch

Merge r64379.

7:09 PM Changeset in webkit [76908] by mjs@apple.com
  • 9 edits in trunk

2011-01-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

execCommand("Paste") doesn't work in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=52785


Unskip paste tests, except the ones that still fail.

  • platform/mac-wk2/Skipped:

2011-01-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

execCommand("Paste") doesn't work in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=52785


Thread through the new JavaScriptCanAccessClipboard setting.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetJavaScriptCanAccessClipboard): (WKPreferencesGetJavaScriptCanAccessClipboard):
  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):

2011-01-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin Adler.

execCommand("Paste") doesn't work in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=52785

Enable both of the settings needed to allow paste.


  • WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
7:08 PM Changeset in webkit [76907] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-533.20-branch

Merge r75168.

7:01 PM Changeset in webkit [76906] by mrowe@apple.com
  • 5 edits
    16 adds in branches/safari-533.20-branch

Merge r74954.

6:56 PM Changeset in webkit [76905] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r74787.

6:46 PM Changeset in webkit [76904] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r75519.

6:41 PM Changeset in webkit [76903] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-27 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

contentEditable formatBlock crashes on divs with contenteditable="false"
https://bugs.webkit.org/show_bug.cgi?id=53263

Add test for executing a formatBlock command on a selection containing an
element with contenteditable=false.

  • editing/execCommand/format-block-contenteditable-false-expected.txt: Added.
  • editing/execCommand/format-block-contenteditable-false.html: Added.

2011-01-27 Emil A Eklund <eae@chromium.org>

Reviewed by Darin Adler.

contentEditable formatBlock crashes on divs with contenteditable="false"
https://bugs.webkit.org/show_bug.cgi?id=53263

Check if editableRootForPosition returns null for position.

Test: editing/execCommand/format-block-contenteditable-false.html

  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::formatRange):
6:39 PM Changeset in webkit [76902] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r69936.

6:35 PM Changeset in webkit [76901] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533.20-branch

Merge r72625.

6:32 PM Changeset in webkit [76900] by mrowe@apple.com
  • 3 edits
    8 adds in branches/safari-533.20-branch

Merge r71256.

6:29 PM Changeset in webkit [76899] by mrowe@apple.com
  • 6 edits
    4 adds in branches/safari-533.20-branch

Merge r74084.

6:26 PM Changeset in webkit [76898] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-01-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Remove RenderMedia members that aren't used.
https://bugs.webkit.org/show_bug.cgi?id=53245

Refactoring, no change in behavior, so no new tests.

  • rendering/RenderMedia.h: Removed unused member variables.
6:24 PM Changeset in webkit [76897] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r70517.

6:22 PM Changeset in webkit [76896] by mrowe@apple.com
  • 3 edits in branches/safari-533.20-branch/LayoutTests

Merge r72830.

6:21 PM Changeset in webkit [76895] by mrowe@apple.com
  • 3 edits
    2 moves
    6 adds in branches/safari-533.20-branch

Merge r72817.

6:20 PM Changeset in webkit [76894] by abarth@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-01-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add WTFString method to compare equality with Vector<UChar>
https://bugs.webkit.org/show_bug.cgi?id=53266

I'm planning to use this method in the new XSS filter implementation,
but it seems generally useful.

  • wtf/text/StringImpl.h: (WTF::equalIgnoringNullity):
  • wtf/text/WTFString.h: (WTF::equalIgnoringNullity):
6:18 PM Changeset in webkit [76893] by msaboff@apple.com
  • 5 edits in trunk/Source

2011-01-27 Michael Saboff <msaboff@apple.com>

Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
https://bugs.webkit.org/show_bug.cgi?id=53271

Added new isValid() methods to check if a contained object in
a WeakGCMap is valid when using an unchecked iterator.

  • runtime/WeakGCMap.h: (JSC::WeakGCMap::isValid):

2011-01-27 Michael Saboff <msaboff@apple.com>

Reviewed by Darin Adler.

Potentially Unsafe HashSet of RuntimeObject* in RootObject definition
https://bugs.webkit.org/show_bug.cgi?id=53271

Precautionary change.
Changed RootObject to use WeakGCMap instead of HashSet.
Found will looking for another issue, but can't produce a test case
that is problematic. THerefore there aren't any new tests.

  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::addRuntimeObject): (JSC::Bindings::RootObject::removeRuntimeObject):
  • bridge/runtime_root.h:
6:15 PM Changeset in webkit [76892] by kbr@google.com
  • 33 edits in trunk

2011-01-27 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Rename Typed Array slice() to subset()
https://bugs.webkit.org/show_bug.cgi?id=53273

  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::constructArrayBufferView):
  • bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArray):
  • html/canvas/Float32Array.cpp: (WebCore::Float32Array::subset):
  • html/canvas/Float32Array.h:
  • html/canvas/Float32Array.idl:
  • html/canvas/Int16Array.cpp: (WebCore::Int16Array::subset):
  • html/canvas/Int16Array.h:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.cpp: (WebCore::Int32Array::subset):
  • html/canvas/Int32Array.h:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.cpp: (WebCore::Int8Array::subset):
  • html/canvas/Int8Array.h:
  • html/canvas/Int8Array.idl:
  • html/canvas/TypedArrayBase.h: (WebCore::TypedArrayBase::subsetImpl):
  • html/canvas/Uint16Array.cpp: (WebCore::Uint16Array::subset):
  • html/canvas/Uint16Array.h:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.cpp: (WebCore::Uint32Array::subset):
  • html/canvas/Uint32Array.h:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.cpp: (WebCore::Uint8Array::subset):
  • html/canvas/Uint8Array.h:
  • html/canvas/Uint8Array.idl:

2011-01-27 Kenneth Russell <kbr@google.com>

Reviewed by James Robinson.

Rename Typed Array slice() to subset()
https://bugs.webkit.org/show_bug.cgi?id=53273

  • fast/canvas/webgl/array-setters.html:
  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:
  • fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt:
  • fast/canvas/webgl/draw-elements-out-of-bounds.html:
  • fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
  • fast/canvas/webgl/webgl-array-invalid-ranges.html:
6:12 PM Changeset in webkit [76891] by Darin Adler
  • 5 edits in trunk/Source

2011-01-27 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Changing cursor style has no effect until the mouse moves
https://bugs.webkit.org/show_bug.cgi?id=14344
rdar://problem/7563712

No tests added because we don't have infrastructure for testing actual cursor
changes (as opposed to cursor style computation) at this time. We might add it later.

  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchFakeMouseMoveEventSoon): Added.
  • page/EventHandler.h: Ditto.
  • rendering/RenderObject.cpp: (WebCore::areNonIdenticalCursorListsEqual): Added. (WebCore::areCursorsEqual): Added. (WebCore::RenderObject::styleDidChange): Call dispatchFakeMouseMoveEventSoon if cursor styles changed.
6:10 PM Changeset in webkit [76890] by mrowe@apple.com
  • 6 edits in branches/safari-533.20-branch/WebKit/mac

Merge r76191.

6:03 PM Changeset in webkit [76889] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-27 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by Ojan Vafai.

This addresses a regression introduced by r75784, as described in:
https://bugs.webkit.org/show_bug.cgi?id=53176

The problem is that originalEndContainer and originalEndOffset was
meant to capture the end of the document, but was being assigned after
a call to searchRange->setStart() (when scoping is restarted), which can
result in the Range being collapsed to start (thereby assigning the
wrong value to the Container/Offset pair).

This code is never triggered by layout tests, but I'm adding a regressiono
test on the Chromium side for this.

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::scopeStringMatches):
6:03 PM Changeset in webkit [76888] by mrowe@apple.com
  • 5 edits
    2 adds in branches/safari-533.20-branch

Merge r72969.

5:57 PM Changeset in webkit [76887] by mrowe@apple.com
  • 4 edits
    4 adds in branches/safari-533.20-branch

Merge r60992.

5:55 PM Changeset in webkit [76886] by mrowe@apple.com
  • 7 edits in branches/safari-533.20-branch

Merge r68923.

5:52 PM Changeset in webkit [76885] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533.20-branch

Merge r74287.

5:52 PM Changeset in webkit [76884] by mrowe@apple.com
  • 3 edits in branches/safari-533.20-branch/WebCore

Merge r74286.

5:51 PM Changeset in webkit [76883] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-01-27 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

SVG Use Cycle is not detected
https://bugs.webkit.org/show_bug.cgi?id=52544

Test for indirect <use> recursion. This test passes if
no crash occurs.

  • svg/custom/recursive-use2-expected.txt: Added.
  • svg/custom/recursive-use2.svg: Added.

2011-01-27 Leo Yang <leo.yang@torchmobile.com.cn>

Reviewed by Dirk Schulze.

SVG Use Cycle is not detected
https://bugs.webkit.org/show_bug.cgi?id=52544

We should check if SVGUseElement::buildInstanceTree finds problem
for every child node. If it finds problem for any children we must
return immediately because otherwise the foundProblem variable may
be rewritten to false.

Test: svg/custom/recursive-use2.svg

  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildInstanceTree):
5:48 PM Changeset in webkit [76882] by mrowe@apple.com
  • 3 edits
    3 adds in branches/safari-533.20-branch

Merge r72644.

5:48 PM Changeset in webkit [76881] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-533.20-branch

Merge r71925.

5:41 PM Changeset in webkit [76880] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r72013.

5:38 PM Changeset in webkit [76879] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533.20-branch

Merge r70473.

5:36 PM Changeset in webkit [76878] by mrowe@apple.com
  • 3 edits in branches/safari-533.20-branch/WebCore

Merge r70550.

5:33 PM Changeset in webkit [76877] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r72304.

5:29 PM Changeset in webkit [76876] by zmo@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-27 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Define GC3D types to match GL types and use them in WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=51947

  • public/WebGraphicsContext3D.h:
5:27 PM Changeset in webkit [76875] by mrowe@apple.com
  • 9 edits
    1 delete in branches/safari-533.20-branch/WebCore

<rdar://problem/8796252> Use WTF's StringBuffer.h.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2010-10-19.
Reviewed by Aaron Golden.

  • css/CSSParser.cpp:
  • dom/Document.cpp:
  • platform/Length.cpp:
  • platform/text/StringBuffer.h: Removed.
  • platform/text/StringBuilder.cpp:
  • platform/text/TextCodecLatin1.cpp:
  • platform/text/TextCodecUTF16.cpp:
  • platform/text/TextCodecUserDefined.cpp:
  • rendering/RenderText.cpp:
5:26 PM Changeset in webkit [76874] by zmo@google.com
  • 3 edits
    2 adds in trunk

2011-01-27 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

texSubImage2D's format/type needs to match the internalformat/type from the previous texImage2D call
https://bugs.webkit.org/show_bug.cgi?id=53054

  • fast/canvas/webgl/tex-sub-image-2d-bad-args-expected.txt: Added.
  • fast/canvas/webgl/tex-sub-image-2d-bad-args.html: Added.

2011-01-27 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

texSubImage2D's format/type needs to match the internalformat/type from the previous texImage2D call
https://bugs.webkit.org/show_bug.cgi?id=53054

Test: fast/canvas/webgl/tex-sub-image-2d-bad-args.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texSubImage2DBase): Check format/type match.
5:23 PM Changeset in webkit [76873] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-01-27 Yi Shen <yi.4.shen@nokia.com>, Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Reviewed by Andreas Kling.

[Qt] Add fullscreen media control button for html video
https://bugs.webkit.org/show_bug.cgi?id=51543

Implement media control fullscreen button for QtWebKit html5 video.

  • css/mediaControlsQt.css: (video::-webkit-media-controls-fullscreen-button):
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintMediaFullscreenButton):
5:22 PM Changeset in webkit [76872] by Nate Chapin
  • 35 edits in trunk/Source

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Remove FrameLoader::url() and update callers to use
Document::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

Refactor, no new tests.

  • WebCore.exp.in:
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::removePendingSheet):
  • history/CachedFrame.cpp: (WebCore::CachedFrameBase::CachedFrameBase):
  • history/PageCache.cpp: (WebCore::logCanCacheFrameDecision): (WebCore::PageCache::canCachePageContainingThisFrame):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):
  • html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::allowedToLoadFrameURL):
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::inspectedURL):
  • inspector/InspectorResourceAgent.cpp: (WebCore::buildObjectForFrame):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocument): (WebCore::DocumentWriter::deprecatedFrameEncoding):
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/HistoryController.cpp: (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): (WebCore::HistoryController::updateForSameDocumentNavigation):
  • loader/NavigationScheduler.cpp: (WebCore::ScheduledHistoryNavigation::fire): (WebCore::NavigationScheduler::scheduleLocationChange): (WebCore::NavigationScheduler::scheduleRefresh):
  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints):
  • page/Location.cpp: (WebCore::Location::url): (WebCore::Location::setProtocol): (WebCore::Location::setHost): (WebCore::Location::setHostname): (WebCore::Location::setPort): (WebCore::Location::setPathname): (WebCore::Location::setSearch): (WebCore::Location::setHash): (WebCore::Location::reload):
  • page/Page.cpp: (WebCore::Page::goToItem):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

  • ewk/ewk_frame.cpp: (ewk_frame_uri_changed):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

  • webkit/webkitwebview.cpp: (webkit_web_view_get_icon_uri):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::dispatchDidFinishDocumentLoad):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

  • WebView/WebView.mm: (-[WebView _dispatchDidReceiveIconFromWebFrame:]):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

  • Api/qwebframe.cpp: (QWebFrame::url):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

  • WebFrame.cpp: (WebFrame::url):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDidFinishDocumentLoad):

2011-01-27 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage): (WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage): (WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage):
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::url):
5:19 PM Changeset in webkit [76871] by Adam Roben
  • 3 edits in trunk/Source/WebKit/win

Fix scrollbars in Safari's Downloads window and Bookmarks view by implementing two needed functions from ScrollableArea.

Patch by Sam Weinig <sam@webkit.org> on 2011-01-27
Reviewed by Adam Roben.

  • WebScrollBar.cpp:

(WebScrollBar::horizontalScrollbar): Return the WebCore::Scrollbar if
we are a horizontal scrollbar.
(WebScrollBar::verticalScrollbar): Return the WebCore::Scrollbar if we
are a vertical scrollbar.

  • WebScrollBar.h:
5:18 PM Changeset in webkit [76870] by mrowe@apple.com
  • 3 edits in branches/safari-533.20-branch/WebCore

Merge r68715.

5:10 PM Changeset in webkit [76869] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/WebCore

Merge r61181.

5:07 PM Changeset in webkit [76868] by rniwa@webkit.org
  • 2 edits
    5 adds in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed rebaselines for Chromium Mac and Windows.

[chromium] fast/repaint/select-option-background-color.html fails on Windows and Mac
https://bugs.webkit.org/show_bug.cgi?id=53260

  • platform/chromium-mac/fast/repaint/select-option-background-color-expected.checksum: Added.
  • platform/chromium-mac/fast/repaint/select-option-background-color-expected.png: Added.
  • platform/chromium-win/fast/repaint/select-option-background-color-expected.checksum: Added.
  • platform/chromium-win/fast/repaint/select-option-background-color-expected.png: Added.
  • platform/chromium-win/fast/repaint/select-option-background-color-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
5:02 PM Changeset in webkit [76867] by mrowe@apple.com
  • 5 edits
    1 add in branches/safari-533.20-branch

Merge r75851.

4:58 PM Changeset in webkit [76866] by senorblanco@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-01-27 Stephen White <senorblanco@chromium.org>

Reviewed by Darin Adler.

Fix performance regression in ImageQualityController::objectDestroyed().
https://bugs.webkit.org/show_bug.cgi?id=52645

In r72282, I inadvertently introduced this regression by using a
linear search through the hash map on object destruction. This was
because the hash key consisted of both object pointer and layer id,
but on object destruction we only know the object pointer, requiring
a search to find all the layers.
By replacing the hash map with two nested hash maps, where the outer key
is the object and the inner key is the layer, we can find all the
relevant data for an object in one hash lookup.

  • rendering/RenderBoxModelObject.cpp: Replace the (object,layer)->size HashMap with object->layer and layer->size HashMaps. (WebCore::ImageQualityController::isEmpty): Implement isEmpty() for the outer HashMap. (WebCore::ImageQualityController::removeLayer): When a layer is removed, remove it from the inner hash map. (WebCore::ImageQualityController::set): Implement set(): if the inner map exists, set the layer->size tuple directly. If not, create a new inner map, set the tuple, and insert it in the outer map. (WebCore::ImageQualityController::objectDestroyed): Look up the object in the outer map only. (WebCore::ImageQualityController::highQualityRepaintTimerFired): Cosmetic changes for the renamed now-outer hash map. (WebCore::ImageQualityController::shouldPaintAtLowQuality): Do both outer and inner hash map lookups. Call set() to add/update entries to the hash maps. keyDestroyed() is now removeLayer(). (WebCore::imageQualityController): Make the ImageQualityController a file-static global, so it can be created and destroyed on the fly. (WebCore::RenderBoxModelObject::~RenderBoxModelObject): If there is no ImageQualityController, don't call objectDestroyed(). If it's empty, delete it.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintIntoRect): Also pass the Image* as the (void*) layer, since 0 is not a valid HashMap key.
4:55 PM Changeset in webkit [76865] by mrowe@apple.com
  • 8 edits in branches/safari-533.20-branch

Merge r71426.

4:50 PM Changeset in webkit [76864] by enne@google.com
  • 3 edits in trunk/Source/WebCore

2011-01-27 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Tiled compositor crashes if compositing turned off mid-paint
https://bugs.webkit.org/show_bug.cgi?id=53198

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayers):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::update): (WebCore::LayerTilerChromium::draw):
4:49 PM Changeset in webkit [76863] by zmo@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-27 Zhenyao Mo <zmo@google.com>

Unreviewed, roll webkit chromium rev from 72673 to 72894.
Also, added gmock section in DEPS to pull down gmock.

  • DEPS:
4:36 PM Changeset in webkit [76862] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-27 Alexey Marinichev <amarinichev@chromium.org>

Reviewed by Kenneth Russell.

Add a callback to WebGraphicsContext3D that is called when a context is lost
https://bugs.webkit.org/show_bug.cgi?id=53153

  • public/WebGraphicsContext3D.h: (WebKit::WebGraphicsContext3D::setContextLostCallback):
4:25 PM Changeset in webkit [76861] by mrowe@apple.com
  • 6 edits
    3 adds in branches/safari-533.20-branch

Merge r73623.

4:21 PM Changeset in webkit [76860] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

2011-01-27 Jacob Dinu <dinu.jacob@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
https://bugs.webkit.org/show_bug.cgi?id=48440

Preserve user input when toggling use of QGraphicsView

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::initializeView): (LauncherWindow::loadFinished):
  • QtTestBrowser/launcherwindow.h:
  • QtTestBrowser/mainwindow.cpp: (MainWindow::addressUrl):
  • QtTestBrowser/mainwindow.h:
4:14 PM Changeset in webkit [76859] by carol.szabo@nokia.com
  • 5 edits in trunk/Source/WebCore

2011-01-27 Carol Szabo <carol.szabo@nokia.com>

Reviewed by David Hyatt.

A corrupted counter tree is created when renderers are added to the
tree bypassing RenderObject::addChild
https://bugs.webkit.org/show_bug.cgi?id=51270

No new tests. This patch reimplements the fix for bugs 43812 and
51637 and hence all tests are already there as part of the original
fixes for those bugs.

  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Removed old workaround as this patch hopefully fixes the real problem.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addChild): Removed call to counter updater as it was moved to a lower level. (WebCore::RenderObject::destroy): Moved attached counter nodes destruction to after the node is removed from the tree.
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode): (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode): Added notifications to the Counter system such that the CounterForest reflects the changes to the RendererTree.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): Applied the same changes as for RenderObject::destroy() since RenderObject::destroy() is not called from here.
3:40 PM Changeset in webkit [76858] by Adam Roben
  • 6 edits
    1 copy
    1 add in trunk/Source/WebCore

Add WKCACFViewLayerTreeHost

This is a class that derives from CACFLayerTreeHost and uses a WKCACFView to render.

Fixes <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost should use
WKCACFView for rendering

  • WebCore.vcproj/WebCore.vcproj: Added WKCACFViewLayerTreeHost.{cpp,h}.
  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Make the test window have a
non-zero size. WKCACFView will always say it can't render if you pass it a 0-sized window,
so we need a non-empty window to perform a valid test.
(WebCore::CACFLayerTreeHost::create): First try to create a WKCACFViewLayerTreeHost, then
fall back to a LegacyCACFLayerTreeHost.
(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Moved code to react to the
context flush from here...
(WebCore::CACFLayerTreeHost::contextDidChange): ...to here. Derived classes are required to
call this function whenever changes are flushed to the context.

  • platform/graphics/ca/win/CACFLayerTreeHost.h: Added contextDidChange.
  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp:

(WebCore::LegacyCACFLayerTreeHost::createRenderer):
(WebCore::LegacyCACFLayerTreeHost::resize):
Changed to use flushContext instead of flushing the context manually so that we will always
notify the base class when the context gets flushed.

(WebCore::LegacyCACFLayerTreeHost::flushContext): Added a call to contextDidChange so the
base class will know what happened. Moved code to schedule a render from here...
(WebCore::LegacyCACFLayerTreeHost::contextDidChange): ...to here.

  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Added contextDidChange.
  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Added.

(WebCore::WKCACFViewLayerTreeHost::create): If WebKitQuartzCoreAdditions, which provides
WKCACFView, isn't present, bail. Otherwise allocate and return a new host.
(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost): Initialize members.
(WebCore::WKCACFViewLayerTreeHost::updateViewIfNeeded): Update the view if we previously
marked that we needed to do so, and flush the context if our layer's bounds have changed.
(WebCore::WKCACFViewLayerTreeHost::contextDidChangeCallback): Call through to
contextDidChange.
(WebCore::WKCACFViewLayerTreeHost::contextDidChange): Tell the WKCACFView to start rendering
(if we didn't already), then call up to the base class.
(WebCore::WKCACFViewLayerTreeHost::initializeContext): Set the context's user data, the
view's layer, and hook up our "context did change" callback.
(WebCore::WKCACFViewLayerTreeHost::resize): Mark that the view needs to be updated the next
time we paint.
(WebCore::WKCACFViewLayerTreeHost::createRenderer): Update our view and return whether it is
able to render or not.
(WebCore::WKCACFViewLayerTreeHost::destroyRenderer): Clear out all the info we passed down
to the view.
(WebCore::WKCACFViewLayerTreeHost::lastCommitTime): Call through to the view.
(WebCore::WKCACFViewLayerTreeHost::flushContext): Ditto.
(WebCore::WKCACFViewLayerTreeHost::paint): Update the view so it will draw at the right
size, then call up to the base class.
(WebCore::WKCACFViewLayerTreeHost::render): Invalidate the view using the passed-in dirty
rects, then ask it to draw.

  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/ca/win/LegacyCACFLayerTreeHost.h.
3:40 PM Changeset in webkit [76857] by tony@chromium.org
  • 2 edits in branches/chromium/648/LayoutTests

Merge 76816 - 2011-01-27 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

back-during-onload-hung-page.php causes Chromium WebKit bot to fail
https://bugs.webkit.org/show_bug.cgi?id=53220

Reduces the timeout on a script that shouldn't finish during a test.
This avoids problems in one of the Chromium WebKit builders.

  • http/tests/history/resources/back-during-onload-hung-page.php: Reduce timeout.

TBR=rniwa@webkit.org
Review URL: http://codereview.chromium.org/6280020

3:39 PM Changeset in webkit [76856] by Adam Roben
  • 3 edits
    2 adds in trunk/Source/WebCore

Move LegacyCACFLayerTreeHost into its own files

More preparation for <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost

Reviewed by Simon Fraser.

  • WebCore.vcproj/WebCore.vcproj: Added LegacyCACFLayerTreeHost.{cpp,h}.
  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: Moved code from here to new files.
  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp: Added.
  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Added.
3:33 PM Changeset in webkit [76855] by mihaip@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-27 Mihai Parparita <mihaip@chromium.org>

Unreviewed, fixed upstream Chromium build

r76844 should have rolled back Chromium DEPS to 72673, not 72637.

  • DEPS:
3:29 PM Changeset in webkit [76854] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-27 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r76824.

  • platform/wince/DragDataWinCE.cpp: (WebCore::DragData::dragDataMap):
3:26 PM Changeset in webkit [76853] by Adam Roben
  • 3 edits in trunk/Source/WebCore

Split CACFLayerTreeHost into base and derived classes

The derived class, LegacyCACFLayerTreeHost, contains all the D3D-related code. A later patch
will add a new derived class that replaces the D3D code with a different rendering API.

For now, LegacyCACFLayerTreeHost lives in CACFLayerTreeHost.cpp. This keeps the diff a
little smaller. A later patch will move it to its own source files.

Preparation for <http://webkit.org/b/53251> <rdar://problem/8925496> CACFLayerTreeHost
should use WKCACFView for rendering

Reviewed by Simon Fraser.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable): Clear the window before
destroying the host, as that is now the API contract that clients must fulfill.
(WebCore::LegacyCACFLayerTreeHost::create): Added. Simple creator.
(WebCore::CACFLayerTreeHost::create): Now instantiates a LegacyCACFLayerTreeHost. Calls the
new initialize function to perform initialization that has to happen after the vtable has
been set up.

(WebCore::LegacyCACFLayerTreeHost::LegacyCACFLayerTreeHost):
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost):
(WebCore::LegacyCACFLayerTreeHost::initializeContext):
(WebCore::CACFLayerTreeHost::initialize):
Moved some initialization code from the CACFLayerTreeHost constructor into these new
functions.

(WebCore::LegacyCACFLayerTreeHost::~LegacyCACFLayerTreeHost): Added. Moved code here from
~CACFLayerTreeHost.
(WebCore::CACFLayerTreeHost::~CACFLayerTreeHost): Rather than clearing the window at this
point (which would be too late, since we won't be able to call into the derived class's
virtual functions), just assert that it has already been cleared (or was never set in the
first place).
(WebCore::LegacyCACFLayerTreeHost::createRenderer): Renamed from
CACFLayerTreeHost::createRenderer, and changed to use getters instead of accessing
CACFLayerTreeHost's data members directly.

(WebCore::LegacyCACFLayerTreeHost::destroyRenderer):
(WebCore::CACFLayerTreeHost::destroyRenderer):
Moved some code to the new LegacyCACFLayerTreeHost function.

(WebCore::LegacyCACFLayerTreeHost::resize):
(WebCore::LegacyCACFLayerTreeHost::renderTimerFired):
Moved these functions to LegacyCACFLayerTreeHost.

(WebCore::LegacyCACFLayerTreeHost::paint):
(WebCore::CACFLayerTreeHost::paint):
Moved some code to the new LegacyCACFLayerTreeHost function.

(WebCore::LegacyCACFLayerTreeHost::render):
(WebCore::LegacyCACFLayerTreeHost::renderSoon):
Moved these functions to LegacyCACFLayerTreeHost.

(WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Moved code to flush the context
from here...
(WebCore::LegacyCACFLayerTreeHost::flushContext): ...to this new function.

(WebCore::LegacyCACFLayerTreeHost::lastCommitTime): Moved code to get the last commit time
to this new function...
(WebCore::CACFLayerTreeHost::notifyAnimationsStarted): ...from here.

(WebCore::LegacyCACFLayerTreeHost::initD3DGeometry):
(WebCore::LegacyCACFLayerTreeHost::resetDevice):
Moved these functions to LegacyCACFLayerTreeHost.

  • platform/graphics/ca/win/CACFLayerTreeHost.h: Made some functions virtual, removed some

members that have moved to LegacyCACFLayerTreeHost, added some getters used by
LegacyCACFLayerTreeHost.

3:25 PM Changeset in webkit [76852] by Adam Roben
  • 9 edits
    1 add in trunk/Source

Move CACFLayerTreeHostClient to its own header file

Rubber-stamped by Steve Falkenburg.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj: Added CACFLayerTreeHostClient.h. Also let VS have its way

with the file.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include.
  • platform/graphics/ca/win/CACFLayerTreeHost.h: Removed CACFLayerTreeHostClient.
  • platform/graphics/ca/win/CACFLayerTreeHostClient.h: Added.
  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: Moved some #includes here

from the header file.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h: Replaced broader #includes

with more specific ones, plus a forward-declaration.

Source/WebKit/win:

Trim down #includes in WebView.h

  • WebView.cpp: Moved some #includes here from the header file.
  • WebView.h: Replaced some broader #includes with more specific ones, plus a

forward-declaration.

3:23 PM Changeset in webkit [76851] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/JavaScriptCore

Merge r72209.

3:23 PM Changeset in webkit [76850] by mrowe@apple.com
  • 3 edits in branches/safari-533.20-branch/JavaScriptCore

Merge r69414.

3:23 PM Changeset in webkit [76849] by mrowe@apple.com
  • 7 edits in branches/safari-533.20-branch

Merge r72114.

3:23 PM Changeset in webkit [76848] by mrowe@apple.com
  • 4 edits in branches/safari-533.20-branch

Merge r71867.

3:23 PM Changeset in webkit [76847] by mrowe@apple.com
  • 2 edits in branches/safari-533.20-branch/JavaScriptCore

Merge r65920.

3:20 PM Changeset in webkit [76846] by krit@webkit.org
  • 4 edits in trunk/LayoutTests

2011-01-27 Dirk Schulze <krit@webkit.org>

Unreviewed rebaseline.

SVG animation of Paths with segments of different coordinate modes on begin and end
https://bugs.webkit.org/show_bug.cgi?id=52984

Rebaseline for SL. HTML were created by make-script-test-wrappers now.
Skip added tests on WebKit2 because of missing eventSender.

  • platform/mac-wk2/Skipped:
  • svg/animations/animate-path-nested-transforms-expected.txt:
  • svg/animations/animate-text-nested-transforms-expected.txt:
3:03 PM Changeset in webkit [76845] by simonjam@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-27 James Simonsen <simonjam@chromium.org>

Reviewed by Tony Chang.

[Chromium] Simplify small caps logic in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=53207

Test: fast/text/atsui-multiple-renderers.html

fast/text/atsui-small-caps-punctuation-size.html

  • platform/graphics/chromium/ComplexTextControllerLinux.cpp: (WebCore::ComplexTextController::nextScriptRun): Remove redundant logic. Case changes in a text run imply FontData changes. (WebCore::ComplexTextController::setupFontForScriptRun): Update comment to reflect above.
2:59 PM Changeset in webkit [76844] by zmo@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-27 Zhenyao Mo <zmo@google.com>

Unreviewed, roll back webkit chromium rev to 72637.

  • DEPS:
2:50 PM Changeset in webkit [76843] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-27 Adam Barth <abarth@webkit.org>

In which I attempt to fix the EFL build.

  • CMakeLists.txt:
2:43 PM Changeset in webkit [76842] by mihaip@chromium.org
  • 3 edits in trunk/LayoutTests

2011-01-27 Mihai Parparita <mihaip@chromium.org>

Unreviewed Chromium rebaseline for fast/text/text-letter-spacing.html
with changes matching the mac ones done by r76739.

  • platform/chromium-win/fast/text/text-letter-spacing-expected.txt:
  • platform/chromium/test_expectations.txt:
2:39 PM Changeset in webkit [76841] by mrowe@apple.com
  • 13 edits in branches/safari-533.20-branch

Merge r74887.

2:38 PM Changeset in webkit [76840] by zmo@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-01-27 Zhenyao Mo <zmo@google.com>

Unreviewed.

Roll Webkit Chromium rev from 72637 to 72868.

  • DEPS:
2:38 PM Changeset in webkit [76839] by leviw@chromium.org
  • 4 edits
    8 adds in trunk

2011-01-25 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Updating the expected result for 5408255 and adding tests for caret positioning at the
beginning and end of RenderBoxes.

Undo moves caret to invalid position
https://bugs.webkit.org/show_bug.cgi?id=49744

  • editing/selection/caret-painting-after-paste-undo-rtl.html: Added.
  • editing/selection/caret-painting-after-paste-undo.html: Added.
  • platform/mac/editing/deleting/5408255-expected.png:
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.checksum: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.png: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-expected.txt: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.checksum: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.png: Added.
  • platform/mac/editing/selection/caret-painting-after-paste-undo-rtl-expected.txt: Added.

2011-01-25 Levi Weintraub <leviw@chromium.org>

Reviewed by Darin Adler.

Adding border and padding to the calculation of the local caret rect for RenderBoxes.
Corrected for mistake in r76625

Undo moves caret to invalid position
https://bugs.webkit.org/show_bug.cgi?id=49744

Tests: editing/selection/caret-painting-after-paste-undo-rtl.html

editing/selection/caret-painting-after-paste-undo.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect):
2:30 PM Changeset in webkit [76838] by rniwa@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaseline and text expectation update.

  • platform/chromium-linux/fast/repaint/select-option-background-color-expected.checksum: Added.
  • platform/chromium-linux/fast/repaint/select-option-background-color-expected.png: Added.
  • platform/chromium-linux/fast/repaint/select-option-background-color-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
2:13 PM Changeset in webkit [76837] by mihaip@chromium.org
  • 4 edits in trunk/LayoutTests

2011-01-27 Mihai Parparita <mihaip@chromium.org>

Unreviewed rebaseline of fast/inline/continuation-outlines-with-layers.html
afte r76726.

  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
  • platform/chromium-win/fast/inline/continuation-outlines-with-layers-expected.txt:
  • platform/chromium/test_expectations.txt:
2:02 PM Changeset in webkit [76836] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76825.
http://trac.webkit.org/changeset/76825
https://bugs.webkit.org/show_bug.cgi?id=53256

"caused crashes on GTK and chromium" (Requested by rniwa on
#webkit).

  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::keyDestroyed): (WebCore::ImageQualityController::objectDestroyed): (WebCore::ImageQualityController::highQualityRepaintTimerFired): (WebCore::ImageQualityController::shouldPaintAtLowQuality): (WebCore::imageQualityController): (WebCore::RenderBoxModelObject::~RenderBoxModelObject):
1:52 PM Changeset in webkit [76835] by abarth@webkit.org
  • 14 edits
    2 adds in trunk/Source/WebCore

2011-01-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Generalize the mechanism view-source uses to remember the source for an HTMLToken
https://bugs.webkit.org/show_bug.cgi?id=53200

Currently view-source tracks the source associated with each HTMLToken.
We want to re-use this mechanism for the new XSS auditor. This patch
moves this code into its own class so it can be shared between the
view-source parser and the general HTML parser. This patch also add
support for tracking the source of tokens that span document.write
boundaries.

No functional change. This code change is somewhat tested by our
view-source layout tests.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
    • Fun with updating build files.
  • html/parser/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
    • Teach HTMLDocumentParser to track the source for HTMLTokens. Currently, this information isn't used, but it will be shortly. I ran the HTML parser benchmark and this change didn't have a measurable effect.
  • html/parser/HTMLDocumentParser.h:
    • Composite in the HTMLSourceTracker.
  • html/parser/HTMLSourceTracker.cpp: Added. (WebCore::HTMLSourceTracker::HTMLSourceTracker): (WebCore::HTMLSourceTracker::start): (WebCore::HTMLSourceTracker::end):
    • This function should eventualy be folded into HTMLTokenizer.

(WebCore::HTMLSourceTracker::sourceForToken):

  • html/parser/HTMLSourceTracker.h: Added.
  • html/parser/HTMLToken.h:
    • Now HTMLTokens always have a start index of zero. To do the job of the old start index, this patch introduces the notion of a baseOffset. Unlike the start index (which was used as the base offset for all the other indicies), the baseOffset can change over the lifetime of the token. We need the flexibility to change the offset for tokens that span document.write boundaries. Values are now normalized to zero-offset when stored.

(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::setBaseOffset):
(WebCore::HTMLToken::end):
(WebCore::HTMLToken::beginAttributeName):
(WebCore::HTMLToken::endAttributeName):
(WebCore::HTMLToken::beginAttributeValue):
(WebCore::HTMLToken::endAttributeValue):

  • html/parser/HTMLViewSourceParser.cpp:
    • Updates the HTMLViewSourceParser to use the new HTMLSourceTracker.

(WebCore::HTMLViewSourceParser::pumpTokenizer):
(WebCore::HTMLViewSourceParser::append):
(WebCore::HTMLViewSourceParser::sourceForToken):

  • This function now just calls through to HTMLSourceTracker.
  • html/parser/HTMLViewSourceParser.h:
  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::currentColumn): (WebCore::SegmentedString::setCurrentPosition):
  • platform/text/SegmentedString.h: (WebCore::SegmentedString::numberOfCharactersConsumed):
    • We need to handle the general case now. The "slow" version doesn't turn out to be any slower in practice anyway.
1:45 PM Changeset in webkit [76834] by robert@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-01-27 Robert Hogan <robert@webkit.org>

Rubber-stamped by Andreas Kling.

[Qt] Style Fix: correct indentation in FrameLoadeClientQt:createPlugin

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin):
1:35 PM Changeset in webkit [76833] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-01-27 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Encode/Decode hasPreciseScrollingDeltas bit in WebWheelEvent
https://bugs.webkit.org/show_bug.cgi?id=53254

  • Shared/WebWheelEvent.cpp: (WebKit::WebWheelEvent::WebWheelEvent): Initialize m_phase and m_hasPreciseScrollingDeltas.

(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
Add missing coding for m_hasPreciseScrollingDeltas.

1:32 PM Changeset in webkit [76832] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix all the builds.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paintOverhangAreas): Add parameters.

1:23 PM Changeset in webkit [76831] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Add ability to do an unconstrained scroll on a ScrollView
https://bugs.webkit.org/show_bug.cgi?id=53249

Reviewed by Dave Hyatt.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::ScrollView):
Initialize m_constrainsScrollingToContentEdge to true.

(WebCore::ScrollView::setScrollOffset):
Only constrain the offset if the m_constrainsScrollingToContentEdge is set.

(WebCore::ScrollView::updateScrollbars):
Simplify expression converting an IntSize to an IntPoint.

(WebCore::ScrollView::paint):
Paint the overhang if there is any.

(WebCore::ScrollView::calculateOverhangAreasForPainting):
Calculate the overhang in viewport coordinates for painting.

  • platform/ScrollView.h:

(WebCore::ScrollView::constrainsScrollingToContentEdge):
(WebCore::ScrollView::setConstrainsScrollingToContentEdge):
Add bit to control whether the scroll position should be constrained
to the content edge when set.

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::usedTotalSize):
(WebCore::ScrollbarThemeComposite::thumbPosition):
(WebCore::ScrollbarThemeComposite::thumbLength):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):
Improve calculations of thumb size and position to take overhang into account.

1:11 PM QtWebKitSecurity created by Ademar Reis
1:03 PM Changeset in webkit [76830] by krit@webkit.org
  • 7 edits
    18 adds in trunk

2011-01-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation of Paths with segments of different coordinate modes on begin and end
https://bugs.webkit.org/show_bug.cgi?id=52984

Added tests to check the correct behavior on path animations, where the coordinate modes
of the start path differs from the one on the end path.

  • svg/animations/animate-path-animation-Cc-Ss-expected.txt: Added.
  • svg/animations/animate-path-animation-Cc-Ss.html: Added.
  • svg/animations/animate-path-animation-Ll-Vv-Hh-expected.txt: Added.
  • svg/animations/animate-path-animation-Ll-Vv-Hh.html: Added.
  • svg/animations/animate-path-animation-Qq-Tt-expected.txt: Added.
  • svg/animations/animate-path-animation-Qq-Tt.html: Added.
  • svg/animations/animate-path-animation-cC-sS-inverse-expected.txt: Added.
  • svg/animations/animate-path-animation-cC-sS-inverse.html: Added.
  • svg/animations/animate-path-animation-lL-vV-hH-inverse-expected.txt: Added.
  • svg/animations/animate-path-animation-lL-vV-hH-inverse.html: Added.
  • svg/animations/animate-path-animation-qQ-tT-inverse-expected.txt: Added.
  • svg/animations/animate-path-animation-qQ-tT-inverse.html: Added.
  • svg/animations/animate-path-nested-transforms.html: Cleanup.
  • svg/animations/animate-text-nested-transforms.html: Cleanup.
  • svg/animations/resources/SVGAnimationTestCase.js: (shouldBeCloseEnough): For debug output of values with tolerance level. (startTest): (sampleAnimation):
  • svg/animations/script-tests/animate-path-animation-Cc-Ss.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):
  • svg/animations/script-tests/animate-path-animation-Ll-Vv-Hh.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):
  • svg/animations/script-tests/animate-path-animation-Qq-Tt.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):
  • svg/animations/script-tests/animate-path-animation-cC-sS-inverse.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):
  • svg/animations/script-tests/animate-path-animation-lL-vV-hH-inverse.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):
  • svg/animations/script-tests/animate-path-animation-qQ-tT-inverse.js: Added. (sample1): (sample2): (sample3): (sample4): (executeTest):

2011-01-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation of Paths with segments of different coordinate modes on begin and end
https://bugs.webkit.org/show_bug.cgi?id=52984

At the moment we just support SVG path animations, if the number of segments on the given start path
is the same as the number of segments on the given end path. But a segment on a given position must be identical
on both paths as well. Not only the segment type, also the coordinate mode of the segments must be identical.
If MoveToRel is on the second position on the start path a MoveToRel must be on the second position
of the end path too. According to the SVG spec, at least the coordinate mode can differ. Means, if we have MoveToRel
in the start path, we can use MoveToAbs on the same position in the end path.

This patch fixes the blending code to follow the spec here. It was necessary to track the current position of
both paths, transform coordinates to the same coordinate mode and transform the resulting animation coordinate back
to the coordinate mode of either the start or the end path. Which mode is taken depends on the progress of the
animation.

Tests: svg/animations/animate-path-animation-Cc-Ss.html

svg/animations/animate-path-animation-Ll-Vv-Hh.html
svg/animations/animate-path-animation-Qq-Tt.html
svg/animations/animate-path-animation-cC-sS-inverse.html
svg/animations/animate-path-animation-lL-vV-hH-inverse.html
svg/animations/animate-path-animation-qQ-tT-inverse.html

  • svg/SVGPathBlender.cpp: (WebCore::blendFloatPoint): (WebCore::blendAnimatedFloat): (WebCore::SVGPathBlender::blendAnimatedDimensionalFloat): (WebCore::SVGPathBlender::blendAnimatedFloatPoint): (WebCore::SVGPathBlender::blendMoveToSegment): (WebCore::SVGPathBlender::blendLineToSegment): (WebCore::SVGPathBlender::blendLineToHorizontalSegment): (WebCore::SVGPathBlender::blendLineToVerticalSegment): (WebCore::SVGPathBlender::blendCurveToCubicSegment): (WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment): (WebCore::SVGPathBlender::blendCurveToQuadraticSegment): (WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment): (WebCore::SVGPathBlender::blendArcToSegment): (WebCore::coordinateModeOfCommand): (WebCore::isSegmentEqual): (WebCore::SVGPathBlender::blendAnimatedPath): (WebCore::SVGPathBlender::cleanup):
  • svg/SVGPathBlender.h:
12:53 PM Changeset in webkit [76829] by dpranke@chromium.org
  • 4 edits in trunk/Tools

2011-01-27 Dirk Pranke <dpranke@chromium.org>

Reviewed by Mihai Parparita.

new-run-webkit-tests: turn off pixel tests correctly by default
for webkit-based ports. r70013 (bug 47510) used
port.set_option_default() to attempt to set default values, but
that didn't work correctly. I have removed set_option_default
for now since it was only being used in two places and in three
useless unit tests. There is a separate bug open to fix the
option parsing (48095), so this workaround is fine for now.

https://bugs.webkit.org/show_bug.cgi?id=53217

  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
12:47 PM Changeset in webkit [76828] by jschuh@chromium.org
  • 4 edits
    2 adds in trunk

2011-01-27 Cris Neckar <cdn@chromium.org>

Reviewed by Dimitri Glazkov.

Clear the parent on a css keyframe's m_style when removing it from the stylesheet.
https://bugs.webkit.org/show_bug.cgi?id=52320

Test: fast/css/css-keyframe-style-crash.html

  • css/CSSRuleList.cpp: (WebCore::CSSRuleList::deleteRule):
  • css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):

2011-01-27 Cris Neckar <cdn@chromium.org>

Reviewed by Dimitri Glazkov.

Test for crash when accessing a keyframe's style rule.
https://bugs.webkit.org/show_bug.cgi?id=52320

  • fast/css/css-keyframe-style-crash-expected.txt: Added.
  • fast/css/css-keyframe-style-crash.html: Added.
12:28 PM Changeset in webkit [76827] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium text expectation update.

  • platform/chromium/test_expectations.txt: Apparently, video-size.html crashes on Linux due to crbug.com/71087.
12:02 PM Changeset in webkit [76826] by rwlbuis@webkit.org
  • 3 edits
    4 adds in trunk

2011-01-27 Rob Buis <rwlbuis@gmail.com>

Reviewed by Kent Tamura.

Color changes to option elements in a select multiple aren't drawn immediately
https://bugs.webkit.org/show_bug.cgi?id=49790

Redirect style changes on <option> element to the owner <select> element.

Test: fast/repaint/select-option-background-color.html

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setRenderStyle):
11:58 AM Changeset in webkit [76825] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-19 Stephen White <senorblanco@chromium.org>

Reviewed by Darin Adler.

Fix performance regression in ImageQualityController::objectDestroyed().
https://bugs.webkit.org/show_bug.cgi?id=52645

In r72282, I inadvertently introduced this regression by using a
linear search through the hash map on object destruction. This was
because the hash key consisted of both object pointer and layer id,
but on object destruction we only know the object pointer, requiring
a search to find all the layers.
By replacing the hash map with two nested hash maps, where the outer key
is the object and the inner key is the layer, we can find all the
relevant data for an object in one hash lookup.

  • rendering/RenderBoxModelObject.cpp: Replace the (object,layer)->size HashMap with object->layer and layer->size HashMaps. (WebCore::ImageQualityController::isEmpty): Implement isEmpty() for the outer HashMap. (WebCore::ImageQualityController::removeLayer): When a layer is removed, remove it from the inner hash map. (WebCore::ImageQualityController::set): Implement set(): if the inner map exists, set the layer->size tuple directly. If not, create a new inner map, set the tuple, and insert it in the outer map. (WebCore::ImageQualityController::objectDestroyed): Look up the object in the outer map only. (WebCore::ImageQualityController::highQualityRepaintTimerFired): Cosmetic changes for the renamed now-outer hash map. (WebCore::ImageQualityController::shouldPaintAtLowQuality): Do both outer and inner hash map lookups. Call set() to add/update entries to the hash maps. keyDestroyed() is now removeLayer(). (WebCore::imageQualityController): Make the ImageQualityController a file-static global, so it can be created and destroyed on the fly. (WebCore::RenderBoxModelObject::~RenderBoxModelObject): If there is no ImageQualityController, don't call objectDestroyed(). If it's empty, delete it.
11:51 AM Changeset in webkit [76824] by enrica@apple.com
  • 15 edits in trunk/Source

Source/WebCore: WebKit2: add support for drag and drop on Windows
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>

Reviewed by Darin Adler and Adam Roben.

On Windows the access to the content being dragged is
provided via the IDataObject interface that is made available
to the window that registers itself as drop target.
Since this interface cannot be accessed from the WebProcess,
in every call to one of the methods of the IDropTarget interface
we serialize the content of the drag clipboard and send it over to
the WebProcess.
The bulk of this patch consists in the refactoring needed in DragData
and ClipboardWin classes to extract the data from the serialized object.

  • platform/DragData.cpp:
  • platform/DragData.h:
  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::getWebLocData):
(WebCore::getURL):
(WebCore::getPlainText):
(WebCore::getTextHTML):
(WebCore::getCFHTML):
(WebCore::fragmentFromFilenames):
(WebCore::containsFilenames):
(WebCore::fragmentFromHTML):
(WebCore::containsHTML):
(WebCore::getClipboardData):

  • platform/win/ClipboardUtilitiesWin.h:
  • platform/win/ClipboardWin.cpp:

(WebCore::Clipboard::create):
(WebCore::ClipboardWin::ClipboardWin):
(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):
(WebCore::ClipboardWin::hasData):

  • platform/win/ClipboardWin.h:

(WebCore::ClipboardWin::create):

  • platform/win/DragDataWin.cpp:

(WebCore::DragData::DragData):
(WebCore::DragData::containsURL):
(WebCore::DragData::dragDataMap):
(WebCore::DragData::asURL):
(WebCore::DragData::containsFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asFragment):

Source/WebKit2: WebKit2: add support for drag and drop on Windows
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>

Reviewed by Darin Adler and Adam Roben.

On Windows the access to the content being dragged is
provided via the IDataObject interface that is made available
to the window that registers itself as drop target.
Since this interface cannot be accessed from the WebProcess,
in every call to one of the methods of the IDropTarget interface
we serialize the content of the drag clipboard and send it over to
the WebProcess. The implementation uses the same messages as the
Mac one, with slightly different parameters to pass the serialized
clipboard.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::performDragControllerAction): Added Windows
specific implementation.

  • UIProcess/WebPageProxy.h:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView): Added dropTargetHelper object creation.
(WebKit::WebView::initialize): Added to register for drag/drop with out
refcount issues.
(WebKit::WebView::close):
(WebKit::WebView::windowReceivedMessage):
(WebKit::WebView::QueryInterface):
(WebKit::WebView::AddRef):
(WebKit::WebView::Release):
(WebKit::dragOperationToDragCursor):
(WebKit::WebView::keyStateToDragOperation):
(WebKit::WebView::DragEnter):
(WebKit::WebView::DragOver):
(WebKit::WebView::DragLeave):
(WebKit::WebView::Drop):

  • UIProcess/win/WebView.h:

(WebKit::WebView::create):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
11:44 AM Changeset in webkit [76823] by estade@chromium.org
  • 2 edits in branches/chromium/648/Source/WebCore

Merge 76637 - 2011-01-25 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Empty URLs are never display isolated
https://bugs.webkit.org/show_bug.cgi?id=53053

This check mirrors the check in the local case. There isn't a good way
to test this with a LayoutTest, but it is tested in Chromium (where
this registry is used).

  • platform/SchemeRegistry.cpp: (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):

TBR=abarth@webkit.org
Review URL: http://codereview.chromium.org/6312016

11:38 AM Changeset in webkit [76822] by mario@webkit.org
  • 4 edits in trunk/Source

2011-01-27 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Space characters in source document interfere with reported caret offset
https://bugs.webkit.org/show_bug.cgi?id=53033

Calculate caret offset from rendered text instead of from node contents.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (objectAndOffsetUnignored): Calculate the caret offset based only on positions and ranges, instead of using the computed offset in the container node.

2011-01-27 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Space characters in source document interfere with reported caret offset
https://bugs.webkit.org/show_bug.cgi?id=53033

New unit test to check the fix for this bug.

  • tests/testatk.c: (testWebkitAtkCaretOffsetsAndExtranousWhiteSpaces): New. (main): Add new unit test.
11:36 AM Changeset in webkit [76821] by ap@apple.com
  • 14 edits in trunk/Source

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=53197
<rdar://problem/8895682> Make WebKit2 printing asynchronous

<rdar://problem/8899988> REGRESSION(WebKit2): Attempting to print WHATWG HTML spec shows
1-page blank preview

<rdar://problem/8900078> WebKit2 printing has a separate message exchange per page when
printing instead of printing all at once

  • UIProcess/API/mac/WKPrintingView.h: Store a lot more cached information.
  • UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]): Use PrintOperation stored in class. We generally want that now, because current operation will not be set up on other threads. (-[WKPrintingView _isPrintingPreview]): Added. Preview is different, because it can draw a placeholder - but actual printing need to wait until UI process has data. (-[WKPrintingView _updatePreview]): Force AppKit to update print preview when we have real data to replace placeholder with. (-[WKPrintingView _hasPageRects]): Return if page rects have already been computed. (-[WKPrintingView _expectedPreviewCallbackForRect:]): Find an existing request for this rect, if any. (pageDidDrawToPDF): Update preview - or if actually printing, release control to printing thread. (-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]): Ask for a PDF document with pages the user asked to print. (pageDidComputePageRects): When web process returns page geometry data, we update preview to display a page count (which indirectly triggers a request for a preview). When actually printing, request a PDF right away, we'll need it later. (-[WKPrintingView _askPageToComputePageRects]): Ask web process for page geometry. (prepareDataForPrintingOnSecondaryThread): This function starts preparing all data necessary for actual printing on main thread. (-[WKPrintingView knowsPageRange:]): Changed to be async for preview, and to call main thread for actual printing. (-[WKPrintingView _pageForRect:]): Find page number for a given range, assuming that AppKit always asks for full pages. (-[WKPrintingView _drawPDFDocument:page:atPoint:]): A helper function to draw a PDF document. (-[WKPrintingView _drawPreview:]): Draw the whole page for preview. (-[WKPrintingView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Draw the whole page for actual printing. (-[WKPrintingView _drawPageBorderWithSizeOnMainThread:]): Call drawPageBorderWithSize: with correct graphics context and print operation. (-[WKPrintingView drawPageBorderWithSize:]): Delegate work to main thread when called from a secondary one. (-[WKPrintingView _provideTotalScaleFactorForPrintOperation:]): Added an assertion that our stored NSPrintOperation isn't out of sync with reality. (-[WKPrintingView rectForPage:]): Handle the case where we don't have the data yet, drawing a placeholder. (-[WKPrintingView endDocument]): When page setup changes, we must reset all state.
  • UIProcess/API/mac/WKView.mm: (-[WKView printOperationWithPrintInfo:forFrame:]): Tell NSPrintingView which operation it's serving, so that it knows it even when current operation isn't set.
  • UIProcess/GenericCallback.h: (WebKit::ComputedPagesCallback::create): (WebKit::ComputedPagesCallback::~ComputedPagesCallback): (WebKit::ComputedPagesCallback::performCallbackWithReturnValue): (WebKit::ComputedPagesCallback::invalidate): (WebKit::ComputedPagesCallback::callbackID): (WebKit::ComputedPagesCallback::generateCallbackID): (WebKit::ComputedPagesCallback::ComputedPagesCallback): Added ComputedPagesCallback, which returns a vector of IntRects and a double. Hopefully, it will become a specialization of GenericCallback one day.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): Added m_voidCallbacks - it looks like they were omitted by accident. (WebKit::WebPageProxy::computedPagesCallback): Added. (WebKit::WebPageProxy::processDidCrash): Added m_computedPagesCallbacks. (WebKit::WebPageProxy::computePagesForPrinting): Async now! (WebKit::WebPageProxy::drawRectToPDF): Ditto. (WebKit::WebPageProxy::drawPagesToPDF): Added.
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Added ComputedPagesCallback.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::beginPriting): Compute page rects right away - we'll need them in drawPagesToPDF(), which doesn't have a PrintInfo. (WebKit::WebPage::computePagesForPrinting): Send async response. (WebKit::WebPage::drawRectToPDF): This function used to draw into original location at frame coordinates, and now it draws at (0, 0). (WebKit::WebPage::drawPagesToPDF): Added - make a multi-page PDF.
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Added DrawPagesToPDF.
11:24 AM Changeset in webkit [76820] by jorlow@chromium.org
  • 5 edits
    2 adds in trunk

2011-01-27 David Grogan <dgrogan@google.com>

Reviewed by Jeremy Orlow.

initial support for close() in indexeddb backend
https://bugs.webkit.org/show_bug.cgi?id=53150

  • storage/indexeddb/transaction-after-close-expected.txt: Added.
  • storage/indexeddb/transaction-after-close.html: Added.

2011-01-27 David Grogan <dgrogan@google.com>

Reviewed by Jeremy Orlow.

initial support for close() in indexeddb backend
https://bugs.webkit.org/show_bug.cgi?id=53150

Test: storage/indexeddb/transaction-after-close.html

  • storage/IDBDatabase.cpp: (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::transaction): (WebCore::IDBDatabase::close):
  • storage/IDBDatabase.h:
  • storage/IDBDatabase.idl:
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::transaction): (WebCore::IDBDatabaseBackendImpl::close):
11:23 AM Changeset in webkit [76819] by krit@webkit.org
  • 3 edits
    6 adds in trunk

2011-01-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation doesn't support calcMode discrete for number and color values.
https://bugs.webkit.org/show_bug.cgi?id=53189

Add support for calcMode discrete on number and color animation.

Tests: svg/animations/animate-color-calcMode-discrete.html

svg/animations/animate-number-calcMode-discrete.html

  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue):

2011-01-27 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG animation doesn't support calcMode discrete for number and color values.
https://bugs.webkit.org/show_bug.cgi?id=53189

Test for correct behavior on animating numbers and colors with calcMode discrete.

  • svg/animations/animate-color-calcMode-discrete-expected.txt: Added.
  • svg/animations/animate-color-calcMode-discrete.html: Added.
  • svg/animations/animate-number-calcMode-discrete-expected.txt: Added.
  • svg/animations/animate-number-calcMode-discrete.html: Added.
  • svg/animations/script-tests/animate-color-calcMode-discrete.js: Added. (sample1): (sample2): (executeTest):
  • svg/animations/script-tests/animate-number-calcMode-discrete.js: Added. (sample1): (sample2): (executeTest):
11:18 AM Changeset in webkit [76818] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update for video tests.

  • platform/chromium/test_expectations.txt:
11:16 AM Changeset in webkit [76817] by alex
  • 2 edits in trunk/Source/WebKit2

2011-01-27 Alejandro G. Castro <alex@igalia.com>

Unreviewed GTK build fix after r76797.

  • Shared/WebPreferencesStore.h: Use Qt fonts preference for the moment.
11:11 AM Changeset in webkit [76816] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-27 Charlie Reis <creis@chromium.org>

Reviewed by Mihai Parparita.

back-during-onload-hung-page.php causes Chromium WebKit bot to fail
https://bugs.webkit.org/show_bug.cgi?id=53220

Reduces the timeout on a script that shouldn't finish during a test.
This avoids problems in one of the Chromium WebKit builders.

  • http/tests/history/resources/back-during-onload-hung-page.php: Reduce timeout.
11:05 AM Changeset in webkit [76815] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Allow pop-up menus to contain multiple items that have the same title.

Reviewed by Anders Carlsson.

  • UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::populate): Set the item’s title after adding it rather than
when adding it, so that it will not replace any existing item with the same title.

10:58 AM Changeset in webkit [76814] by zmo@google.com
  • 5 edits
    2 adds in trunk

2011-01-26 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

shaderSource needs to preserve original source
https://bugs.webkit.org/show_bug.cgi?id=52833

  • fast/canvas/webgl/gl-getshadersource-expected.txt: Added.
  • fast/canvas/webgl/gl-getshadersource.html: Added.

2011-01-26 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

shaderSource needs to preserve original source
https://bugs.webkit.org/show_bug.cgi?id=52833

Test: fast/canvas/webgl/gl-getshadersource.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getShaderParameter): Intercept SHADER_SOURCE_LENGTH. (WebCore::WebGLRenderingContext::getShaderSource): Intercept the call. (WebCore::WebGLRenderingContext::shaderSource): Cache the source.
  • html/canvas/WebGLShader.cpp: Cache shader source. (WebCore::WebGLShader::WebGLShader):
  • html/canvas/WebGLShader.h: Ditto. (WebCore::WebGLShader::getSource): (WebCore::WebGLShader::setSource):
10:52 AM Changeset in webkit [76813] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Reverted an accidental change in r76561.

Rubber-stamped by Anders Carlsson.

  • WebView/WebHTMLView.mm:
10:24 AM Changeset in webkit [76812] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky test, needs further investigation on the failure.

[GTK] media/audio-delete-while-slider-thumb-clicked.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53247

  • platform/gtk/Skipped:
10:09 AM Changeset in webkit [76811] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

Trivial crash fix in WTR.

Rubber-stamped by Ariya Hidayat.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize): Increase the size
of the vector by one to be able to store the null character.

10:06 AM CSS3 3D Transforms.zip attached to QtWebKitContrib by kcomkar@gmail.com
Testcases checking for CSS3 3D Transforms functionality.
10:04 AM CSS3 2D Transforms.zip attached to QtWebKitContrib by kcomkar@gmail.com
Testcases checking for CSS3 2D Transforms functionality.
9:58 AM Browser Performance Tests.zip attached to QtWebKitContrib by kcomkar@gmail.com
Analyses browser's performance at various stress-conditions. An …
9:32 AM Changeset in webkit [76810] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

fast/text/international/bidi-mirror-he-ar.html now passed on Windows in WebKit2.
Unreviewed.

  • platform/win-wk2/Skipped:
9:26 AM Changeset in webkit [76809] by mjs@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed.

Fix mistake in my previous commit; I accidentally copied the old mac results instead
of the new mac results for this test.

  • platform/mac-wk2/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
9:05 AM Changeset in webkit [76808] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed; Fixed change log entries because Chromium rebaselines are unreviewed but claimed to be reviewed.

8:58 AM Changeset in webkit [76807] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, rebaseline of the favicon-as-image test from the build
bot.

  • platform/gtk/http/tests/misc/favicon-as-image-expected.txt:
8:55 AM Changeset in webkit [76806] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Another Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
8:50 AM Changeset in webkit [76805] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium test expectation update.

  • platform/chromium/test_expectations.txt:
8:31 AM Changeset in webkit [76804] by rniwa@webkit.org
  • 4 edits
    10 adds in trunk/LayoutTests

2011-01-27 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines.

  • platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Added.
  • platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.checksum:
  • platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-complex-expected.checksum: Added.
  • platform/chromium-mac/fast/text/justify-ideograph-complex-expected.png: Added.
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.checksum: Added.
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png: Added.
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.checksum: Added.
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Added.
  • platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.png: Added.
  • platform/chromium/test_expectations.txt:
8:29 AM Changeset in webkit [76803] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

2011-01-27 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt][WK2] WTR should be initialized in the same way as DRT
https://bugs.webkit.org/show_bug.cgi?id=53240

  • WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: (WTR::activateFonts): Added missing initialization steps.
7:55 AM Changeset in webkit [76802] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-01-27 Patrick Gansterer <paroga@webkit.org>

Unreviewed WinCE build fix for r76743.

  • platform/graphics/wince/FontWinCE.cpp: (WebCore::TextRunComponent::TextRunComponent):
7:38 AM Changeset in webkit [76801] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for
svg/custom/pattern-referencing-preserve-aspect-ratio.svg added in r76274.

  • platform/gtk/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.
7:25 AM Changeset in webkit [76800] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for
http/tests/misc/favicon-as-image.html which was unskipped in r76555.

  • platform/gtk/http/tests/misc/favicon-as-image-expected.txt: Added.
7:11 AM Changeset in webkit [76799] by Philippe Normand
  • 1 edit
    1 add in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for fast/dom/52776.html, follow-up of r76319.

  • platform/gtk/fast/dom/52776-expected.txt: Added.
7:07 AM Changeset in webkit [76798] by andreas.kling@nokia.com
  • 4 edits in trunk/Source/WebKit2

2011-01-27 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt][WK2] Add QWKPage APIs regarding engine process availability
https://bugs.webkit.org/show_bug.cgi?id=53237

QWKPage will now emit engineConnected() and engineDisconnected()
when the web process crashes and is relaunched respectively.

Also added QWKPage::isConnectedToEngine() for convenience.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPagePrivate::didRelaunchProcess): (QWKPagePrivate::processDidCrash): (QWKPage::isConnectedToEngine):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
6:56 AM Changeset in webkit [76797] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-01-27 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Lots of layout test failures due to wrong font type
https://bugs.webkit.org/show_bug.cgi?id=53233

  • Shared/WebPreferencesStore.h: Specialize default font families for Qt.
6:25 AM Changeset in webkit [76796] by Philippe Normand
  • 1 edit
    3 adds in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, new GTK baselines for fast/text/justify* tests
introduced in r76743.

  • platform/gtk/fast/text/justify-ideograph-complex-expected.txt: Added.
  • platform/gtk/fast/text/justify-ideograph-simple-expected.txt: Added.
  • platform/gtk/fast/text/justify-ideograph-vertical-expected.txt: Added.
6:22 AM Changeset in webkit [76795] by podivilov@chromium.org
  • 5 edits in trunk

2011-01-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234

  • inspector/debugger-expand-scope.html:
  • inspector/debugger-proto-property.html:

2011-01-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234

  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane): (WebInspector.ScopeChainSidebarPane.prototype.update):
6:14 AM Changeset in webkit [76794] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76789.
http://trac.webkit.org/changeset/76789
https://bugs.webkit.org/show_bug.cgi?id=53238

Broke GTK layout tests (Requested by podivilov on #webkit).

  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane): (WebInspector.ScopeChainSidebarPane.prototype.update):
6:07 AM Changeset in webkit [76793] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, fix typo introduced in r76783.

  • platform/gtk/Skipped:
6:03 AM Changeset in webkit [76792] by yurys@chromium.org
  • 34 edits
    2 deletes in trunk

2011-01-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: store all settings related to the agents on the frontend side
https://bugs.webkit.org/show_bug.cgi?id=53174

  • http/tests/inspector/console-xhr-logging.html: since the setting doesn't change on the front-end side there is no need to check it after modifying backend's value.
  • inspector/report-protocol-errors.html: use the new signature of disableDebugger method.

2011-01-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: store all settings related to the agents on the frontend side
https://bugs.webkit.org/show_bug.cgi?id=53174

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptDebugServer.cpp:
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptProfiler.cpp:
  • bindings/js/ScriptProfiler.h:
  • bindings/v8/ScriptDebugServer.cpp:
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/ScriptProfiler.cpp:
  • bindings/v8/ScriptProfiler.h:
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: profiler and debugger enablement state is now stored on the front-end side and will be pushed to the backend when the frontend is loaded. (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::restoreDebugger): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::enableProfiler): (WebCore::InspectorAgent::disableProfiler): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::disableDebugger):
  • inspector/InspectorAgent.h:
  • inspector/InspectorConsoleAgent.cpp: XHR failures will be logged to the console only if the front-end was opened during current browser session and XHR logging is turned on there. (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
  • inspector/InspectorSettings.cpp: Removed.
  • inspector/InspectorSettings.h: Removed.
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction): (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._toggleProfiling):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._toggleDebugging):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js:
5:56 AM Changeset in webkit [76791] by Philippe Normand
  • 1 edit
    22 adds in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, new GTK baselines for fast/multicol tests as follow-up
of r76726.

  • platform/gtk/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-lr/column-count-with-rules-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-rl/column-count-with-rules-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
  • platform/gtk/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.
5:43 AM Changeset in webkit [76790] by joone.hur@collabora.co.uk
  • 2 edits in trunk/Tools

2011-01-27 Joone Hur <joone.hur@collabora.co.uk>

Unreviewed.

Adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
5:41 AM WebKitGTK edited by Philippe Normand
(diff)
5:40 AM WebKitGTK/KeepingTheTreeGreen created by Philippe Normand
5:01 AM Changeset in webkit [76789] by podivilov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-27 Pavel Podivilov <podivilov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Closure and Global variable details automatically collapsing on each step through JavaScript code.
https://bugs.webkit.org/show_bug.cgi?id=53234

  • inspector/front-end/ScopeChainSidebarPane.js: (WebInspector.ScopeChainSidebarPane): (WebInspector.ScopeChainSidebarPane.prototype.update):
4:54 AM Changeset in webkit [76788] by apavlov@chromium.org
  • 5 edits in trunk

2011-01-27 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: [Elements panel] Tooltip for relative links incorrectly identifies current URL
https://bugs.webkit.org/show_bug.cgi?id=53171

WebCore:

  • inspector/front-end/inspector.js: (WebInspector.completeURL): Taught to understand partial href's that start with "?" (contain GET parameters only)

LayoutTests:

  • inspector/styles-url-linkify-expected.txt:
  • inspector/styles-url-linkify.html:
4:44 AM Changeset in webkit [76787] by sergio@webkit.org
  • 2 edits
    4 adds in trunk/LayoutTests

2011-01-27 Sergio Villar Senin <svillar@igalia.com>

Unreviewed.

New test expectations for http/tests/navigation/error404* in GTK.

  • platform/gtk/Skipped:
  • platform/gtk/http/tests/navigation/error404-basic-expected.txt: Added.
  • platform/gtk/http/tests/navigation/error404-goback-expected.txt: Added.
  • platform/gtk/http/tests/navigation/error404-subframeload-expected.txt: Added.
4:38 AM Changeset in webkit [76786] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-01-27 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

[V8] Crash in WebCore::addMessageToConsole
https://bugs.webkit.org/show_bug.cgi?id=53227

  • bindings/v8/V8Proxy.cpp: check that the Frame where the error occured still has a page before getting a console object from it. (WebCore::V8Proxy::reportUnsafeAccessTo):
4:30 AM Changeset in webkit [76785] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] [Symbian] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891

Patch by Laszlo Gombos <Laszlo Gombos> on 2011-01-27
Reviewed by Csaba Osztrogonác.

Fix the Symbian build after the project files
are moved to Source directory. On Symbian qmake
needs to run in the same directory where the main
pro files (WebKit.pro, Tools.pro) are located.

  • Scripts/webkitdirs.pm: Change to the directory where the pro file

is located before running qmake for Symbian. Qmake on Symbian
does not properly honor the "-o" option, work it around by setting
the name of the Makefile to bld.inf.

3:57 AM Changeset in webkit [76784] by hans@chromium.org
  • 13 edits in trunk/Source

2011-01-27 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Remove IDBCallbacks::onSuccess() used for null values.
https://bugs.webkit.org/show_bug.cgi?id=53178

Remove the IDBCallbacks::onSuccess() function that was used for
null values, and replace such calls with calls to
IDBCallBacks::onSuccess(SerializedScriptValue::nullValue())
instead.

No new functionality, so no new tests.

  • storage/IDBCallbacks.h:
  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::updateInternal): (WebCore::IDBCursorBackendImpl::continueFunctionInternal):
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::openCursorInternal):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::deleteInternal): (WebCore::IDBObjectStoreBackendImpl::openCursorInternal):
  • storage/IDBRequest.cpp:
  • storage/IDBRequest.h:

2011-01-27 Hans Wennborg <hans@chromium.org>

Reviewed by Jeremy Orlow.

IndexedDB: Remove IDBCallbacks::onSuccess() used for null values.
https://bugs.webkit.org/show_bug.cgi?id=53178

Remove the IDBCallbacks::onSuccess() function that was used for
null values, and replace such calls with calls to
IDBCallBacks::onSuccess(SerializedScriptValue::nullValue())
instead.

  • public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onSuccess):
  • src/IDBCallbacksProxy.cpp:
  • src/IDBCallbacksProxy.h:
  • src/WebIDBCallbacksImpl.cpp:
  • src/WebIDBCallbacksImpl.h:
3:54 AM Changeset in webkit [76783] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping 2 more media tests.

[GStreamer] wrong media duration report in media/controls-after-reload.html
https://bugs.webkit.org/show_bug.cgi?id=51602

  • platform/gtk/Skipped:
3:38 AM Changeset in webkit [76782] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium/test_expectations.txt:
3:27 AM Changeset in webkit [76781] by yuzo@google.com
  • 1 edit
    30 deletes in trunk/LayoutTests

2011-01-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum: Removed.
  • platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/blockflow/vertical-baseline-alignment-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.checksum: Removed.
  • platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/text/complex-text-opacity-expected.txt: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.checksum: Removed.
  • platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Removed.
3:13 AM Changeset in webkit [76780] by mjs@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed.

Fix mistake in my previous commit; I accidentally copied the old mac results instead
of the new mac results for this test.

  • platform/mac-wk2/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
2:51 AM Changeset in webkit [76779] by Csaba Osztrogonác
  • 1 edit
    56 adds in trunk/LayoutTests

Unreviewed.

Add Qt specific expected results for new passing tests introduced in r76726.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/multicol/vertical-lr/border-padding-pagination-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-lr/border-padding-pagination-expected.png: Added.
  • platform/qt/fast/multicol/vertical-lr/border-padding-pagination-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-lr/column-rules-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-lr/column-rules-expected.png: Added.
  • platform/qt/fast/multicol/vertical-lr/column-rules-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png: Added.
  • platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-lr/float-multicol-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-lr/float-multicol-expected.png: Added.
  • platform/qt/fast/multicol/vertical-lr/float-multicol-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/qt/fast/multicol/vertical-lr/float-paginate-complex-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-lr/float-paginate-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/qt/fast/multicol/vertical-lr/float-paginate-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-lr/nested-columns-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/qt/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-rl/border-padding-pagination-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-rl/border-padding-pagination-expected.png: Added.
  • platform/qt/fast/multicol/vertical-rl/border-padding-pagination-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-rl/column-rules-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-rl/column-rules-expected.png: Added.
  • platform/qt/fast/multicol/vertical-rl/column-rules-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png: Added.
  • platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-rl/float-multicol-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/qt/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/qt/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-rl/float-paginate-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/qt/fast/multicol/vertical-rl/float-paginate-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-rl/nested-columns-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/qt/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
  • platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.checksum: Added.
  • platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt: Added.
2:25 AM Changeset in webkit [76778] by zoltan@webkit.org
  • 3 edits in trunk/Tools

[Qt] Add simple zooming features to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=53231

Reviewed by Andreas Kling.

Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::zoomIn):
(BrowserWindow::zoomOut):
(BrowserWindow::resetZoom):
(BrowserWindow::updateUserAgentList):
(BrowserWindow::applyZoom):

  • MiniBrowser/qt/BrowserWindow.h:
2:00 AM Changeset in webkit [76777] by Philippe Normand
  • 4 edits in trunk

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76773.
http://trac.webkit.org/changeset/76773
https://bugs.webkit.org/show_bug.cgi?id=53230

breaks multiple GTK media tests (Requested by philn-tp on
#webkit).

  • platform/gtk/Skipped:

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76773.
http://trac.webkit.org/changeset/76773
https://bugs.webkit.org/show_bug.cgi?id=53230

breaks multiple GTK media tests (Requested by philn-tp on
#webkit).

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
1:41 AM Changeset in webkit [76776] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectaion change.

  • platform/chromium/test_expectations.txt:
1:34 AM Changeset in webkit [76775] by yurys@chromium.org
  • 31 edits
    1 copy
    1 add in trunk/Source/WebCore

2011-01-27 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r76770.
http://trac.webkit.org/changeset/76770
https://bugs.webkit.org/show_bug.cgi?id=53229

Some inspector tests fail (Requested by yurys on #webkit).

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptProfiler.cpp: (WebCore::ScriptProfiler::isProfilerAlwaysEnabled):
  • bindings/js/ScriptProfiler.h:
  • bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::isDebuggerAlwaysEnabled):
  • bindings/v8/ScriptDebugServer.h:
  • bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::isProfilerAlwaysEnabled):
  • bindings/v8/ScriptProfiler.h:
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::restoreDebugger): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::ensureSettingsLoaded): (WebCore::InspectorAgent::enableProfiler): (WebCore::InspectorAgent::disableProfiler): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::disableDebugger):
  • inspector/InspectorAgent.h: (WebCore::InspectorAgent::settings):
  • inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  • inspector/InspectorDebuggerAgent.cpp: (WebCore::InspectorDebuggerAgent::isDebuggerAlwaysEnabled):
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::InspectorProfilerAgent): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
  • inspector/InspectorSettings.cpp: Added. (WebCore::InspectorSettings::InspectorSettings): (WebCore::InspectorSettings::getBoolean): (WebCore::InspectorSettings::setBoolean): (WebCore::InspectorSettings::getLong): (WebCore::InspectorSettings::setLong): (WebCore::InspectorSettings::registerBoolean): (WebCore::InspectorSettings::registerLong):
  • inspector/InspectorSettings.h: Copied from Source/WebCore/bindings/v8/ScriptProfiler.h.
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.monitoringXHRStateChanged): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher): (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._toggleProfiling):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._toggleDebugging):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js:
1:08 AM Changeset in webkit [76774] by mjs@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

2011-01-27 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Add or update WebKit2-specific results to account for different reporting of scroll position
https://bugs.webkit.org/show_bug.cgi?id=53226

  • platform/mac-wk2/fast/multicol: Added.
  • platform/mac-wk2/fast/multicol/vertical-rl: Added.
  • platform/mac-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
  • platform/mac-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: Added.
12:55 AM Changeset in webkit [76773] by Philippe Normand
  • 4 edits in trunk

2011-01-26 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] LayoutTests/media/audio-mpeg4-supported.html fails
https://bugs.webkit.org/show_bug.cgi?id=53125

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache): Add audio/x-m4a mimetype in the cache.

2011-01-26 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] LayoutTests/media/audio-mpeg4-supported.html fails
https://bugs.webkit.org/show_bug.cgi?id=53125

  • platform/gtk/Skipped: Unskip fixed test.
12:43 AM Changeset in webkit [76772] by Philippe Normand
  • 9 edits in trunk/LayoutTests

2011-01-27 Philippe Normand <pnormand@igalia.com>

Unreviewed, updated GTK baselines after r76726.

  • platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
  • platform/gtk/fast/blockflow/vertical-baseline-alignment-expected.txt:
  • platform/gtk/fast/lists/002-vertical-expected.txt:
  • platform/gtk/fast/lists/003-vertical-expected.txt:
  • platform/gtk/fast/overflow/overflow-rtl-vertical-expected.txt:
  • platform/gtk/fast/table/028-vertical-expected.txt:
  • platform/gtk/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/gtk/fast/table/height-percent-test-vertical-expected.txt:
12:38 AM Changeset in webkit [76771] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Update expectation for r76760.

  • platform/chromium/test_expectations.txt:
12:36 AM Changeset in webkit [76770] by yurys@chromium.org
  • 31 edits
    2 deletes in trunk/Source/WebCore

2011-01-26 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: store all settings related to the agents on the frontend side
https://bugs.webkit.org/show_bug.cgi?id=53174

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.idl:
  • inspector/InspectorAgent.cpp: profiler and debugger enablement state is now stored on the front-end side and will be pushed to the backend when the frontend is loaded. (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::disconnectFrontend): (WebCore::InspectorAgent::restoreDebugger): (WebCore::InspectorAgent::restoreProfiler): (WebCore::InspectorAgent::enableProfiler): (WebCore::InspectorAgent::disableProfiler): (WebCore::InspectorAgent::showAndEnableDebugger): (WebCore::InspectorAgent::enableDebugger): (WebCore::InspectorAgent::disableDebugger):
  • inspector/InspectorAgent.h:
  • inspector/InspectorConsoleAgent.cpp: XHR failures will be logged to the console only if the front-end was opened during current browser session and XHR logging is turned on there. (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled): (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): (WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::enable): (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorSettings.cpp: Removed.
  • inspector/InspectorSettings.h: Removed.
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher): (WebInspector.ConsoleView.prototype._handleContextMenuEvent.itemAction): (WebInspector.ConsoleView.prototype._handleContextMenuEvent):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._toggleProfiling):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._toggleDebugging):
  • inspector/front-end/Settings.js: (WebInspector.Settings):
  • inspector/front-end/inspector.js:
12:32 AM Changeset in webkit [76769] by mjs@apple.com
  • 23 edits
    2 adds in trunk

2011-01-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
https://bugs.webkit.org/show_bug.cgi?id=42319


Unskip inspector tests (except the few that mysteriously fail).

  • platform/mac-wk2/Skipped:

2011-01-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
https://bugs.webkit.org/show_bug.cgi?id=42319


Add evaluateInWebInspector and other APIs needed for inspector tests to run.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::showWebInspector): (WTR::LayoutTestController::closeWebInspector): (WTR::LayoutTestController::evaluateInWebInspector): (WTR::LayoutTestController::setTimelineProfilingEnabled):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/TestInvocation.cpp: (WTR::shouldOpenWebInspector): (WTR::TestInvocation::invoke):
  • WebKitTestRunner/WebKitTestRunnerPrefix.h:

2011-01-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
https://bugs.webkit.org/show_bug.cgi?id=42319

Add WKBundleInspector and APIs needed to implement WebKitTestRunner APIs.


  • GNUmakefile.am:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
  • WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp: Added. (WKBundleInspectorGetTypeID): (WKBundleInspectorShow): (WKBundleInspectorClose): (WKBundleInspectorEvaluateScriptForTest): (WKBundleInspectorSetPageProfilingEnabled):
  • WebProcess/InjectedBundle/API/c/WKBundleInspector.h: Added.
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageGetInspector):
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::create): (WebKit::WebInspector::evaluateScriptForTest):
  • WebProcess/WebPage/WebInspector.h: (WebKit::WebInspector::type):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::inspector):
  • WebProcess/WebPage/WebPage.h:
  • win/WebKit2.vcproj:
  • win/WebKit2Generated.make:
12:23 AM Changeset in webkit [76768] by mitz@apple.com
  • 6 edits in trunk/Source/WebCore

REGRESSION (r76743): Uneven spacing in right-to-left justified text
https://bugs.webkit.org/show_bug.cgi?id=53225

Reviewed by Sam Weinig.

Fixes failure in fast/text/atsui-spacing-features.html

There was an inconsistency between rendering code and font code in the interpretation of
'after expansion' and 'trailing expansion'. Changed all code to interpret these in terms of
visual order rather than logical.

  • platform/graphics/Font.cpp:

(WebCore::Font::expansionOpportunityCount): Added a text direction parameter and changed to
iterate in visual order accordingly.

  • platform/graphics/Font.h:
  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator): Pass the run direction to expansionOpportunityCount().
(WebCore::WidthIterator::advance): For right-to-left runs, evaluate the trailing expansion
condition with respect to the first character, which is the trailing character in visual order.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController): Pass the run direction to
expansionOpportunityCount().

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.

12:15 AM Changeset in webkit [76767] by yuzo@google.com
  • 2 edits in trunk/LayoutTests

2011-01-27 Yuzo Fujishima <yuzo@google.com>

Unreviewed Chromium test expectation change.

Another test expectation update for r76743.

  • platform/chromium/test_expectations.txt:
Note: See TracTimeline for information about the timeline view.