Timeline



Jun 4, 2011:

10:28 PM Changeset in webkit [88132] by kevino@webkit.org
  • 3 edits in trunk/Tools

[wx] Unreviewed build fix. Update git branch build dir handling to match what other WebKit scripts expect, so other scripts work properly with wx.

10:07 PM Changeset in webkit [88131] by kevino@webkit.org
  • 7 edits in trunk

[wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures to build on Mac.

9:38 PM Changeset in webkit [88130] by kevino@webkit.org
  • 3 edits in trunk/Tools

[wx] Unreviewed build fixes for recent trunk changes.

9:33 PM Changeset in webkit [88129] by cevans@google.com
  • 4 edits in branches/chromium/782/Source/WebCore/accessibility

Merge 87856
BUG=84950
Review URL: http://codereview.chromium.org/7058064

8:21 PM Changeset in webkit [88128] by mrowe@apple.com
  • 3 edits
    3 copies in trunk

Roll over some ChangeLogs.

7:08 PM Changeset in webkit [88127] by weinig@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-06-04 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Disable WebProcess side display throttling when in a user scroll
<rdar://problem/9517175>
https://bugs.webkit.org/show_bug.cgi?id=62095

Add the ability to disable WebProcess side display throttling that
takes place in DrawingAreaImpl::displayTimerFired. Disable the throttling
when in a user or animated scroll.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didStartRubberBandForFrame): (WebKit::WebChromeClient::didCompleteRubberBandForFrame): (WebKit::WebChromeClient::didStartAnimatedScroll): (WebKit::WebChromeClient::didCompleteAnimatedScroll):
  • WebProcess/WebPage/DrawingArea.h: (WebKit::DrawingArea::enableDisplayThrottling): (WebKit::DrawingArea::disableDisplayThrottling):
  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::enableDisplayThrottling): (WebKit::DrawingAreaImpl::disableDisplayThrottling): (WebKit::DrawingAreaImpl::displayTimerFired):
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::wheelEvent):
5:46 PM Changeset in webkit [88126] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/JavaScriptCore

2011-06-04 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed, MIPS build fix.

WebKitGTK+ tarball fails to build on MIPS.
https://buildd.debian.org/status/fetch.php?pkg=webkitgtk%2B&arch=mips&ver=1.4.0-1&stamp=1304786691

  • GNUmakefile.am: Add missing MIPS-related file to the list of files that are added to the tarball on make dist, and fix sorting.
5:37 PM Changeset in webkit [88125] by mrobinson@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

2011-06-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez

Update the news file for the 1.4.1 release.

  • NEWS: Update news.
5:09 PM Changeset in webkit [88124] by kov@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-04 Gustavo Noronha Silva <gns@gnome.org>

Unreviewed, MIPS build fix.

WebKitGTK+ tarball fails to build on MIPS.
https://buildd.debian.org/status/fetch.php?pkg=webkitgtk%2B&arch=mips&ver=1.4.0-1&stamp=1304786691

  • GNUmakefile.list.am: Add missing MIPS-related file to the list of files that are added to the tarball on make dist, and fix sorting.
2:03 PM Changeset in webkit [88123] by darin@apple.com
  • 9 edits
    2 adds in trunk/Source

2011-06-04 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

[Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
https://bugs.webkit.org/show_bug.cgi?id=62094
rdar://problem/9539204

  • WebCore.exp.in: Export ResourceHandle::synchronousLoadRunLoopMode.
  • platform/network/ResourceHandle.h: Add synchronousLoadRunLoopMode.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added. (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::synchronousLoadRunLoopMode): Added. (WebCore::ResourceHandle::loadResourceSynchronously): Call synchronousLoadRunLoopMode.

2011-06-04 Darin Adler <darin@apple.com>

Reviewed by Anders Carlsson.

[Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
https://bugs.webkit.org/show_bug.cgi?id=62094
rdar://problem/9539204

  • WebKit2.xcodeproj/project.pbxproj: Added new source files.
  • WebProcess/mac/CoreIPCClientRunLoop.h: Added.
  • WebProcess/mac/CoreIPCClientRunLoop.mm: Added. (-[WKFunctionAdapter perform]): Added. (WebKit::createCoreIPCRunLoopModesArray): Added. (WebKit::coreIPCRunLoopModesArray): Added. (WebKit::callOnCoreIPCClientRunLoopAndWait): Added.
  • WebProcess/mac/KeychainItemShimMethods.mm: (WebKit::webFreeAttributeListContent): Use callOnCoreIPCClientRunLoopAndWait. (WebKit::webFreeKeychainItemContent): Ditto. (WebKit::webSecKeychainItemCopyContent): Ditto. (WebKit::webSecKeychainItemCreateFromContent): Ditto. (WebKit::webSecKeychainItemModifyContent): Ditto.
  • WebProcess/mac/SecItemShimMethods.mm: (WebKit::webSecItemCopyMatching): Ditto. (WebKit::webSecItemAdd): Ditto. (WebKit::webSecItemUpdate): Ditto. (WebKit::webSecItemDelete): Ditto.
12:34 PM Changeset in webkit [88122] by eric@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add InlineWalker class to hold state for repeated calls to bidiNext
https://bugs.webkit.org/show_bug.cgi?id=60724

This is one more little step towards removing (naked) bidiNext usage.
More refactoring is required before all callers of bidiNext can move
onto using an InlineWalker instead of bidiNext directly.

No change in behavior, thus no tests.

  • rendering/InlineIterator.h: (WebCore::InlineWalker::InlineWalker): (WebCore::InlineWalker::root): (WebCore::InlineWalker::current): (WebCore::InlineWalker::atEndOfInline): (WebCore::InlineWalker::atEnd): (WebCore::InlineWalker::advance):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::simplifiedNormalFlowLayout):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutInlineChildren):
12:20 PM Changeset in webkit [88121] by weinig@apple.com
  • 10 edits in trunk/Source

2011-06-04 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
https://bugs.webkit.org/show_bug.cgi?id=62093

Add additional ChromeClient functions to indicate the beginning and end of
the various ScrollAnimator animations. Change existing notification that a
rubber-band has completed for the main frame to be triggered for all frames.

  • page/ChromeClient.h: (WebCore::ChromeClient::didStartRubberBandForFrame): (WebCore::ChromeClient::didCompleteRubberBandForFrame): (WebCore::ChromeClient::didStartAnimatedScroll): (WebCore::ChromeClient::didCompleteAnimatedScroll):
  • page/FrameView.cpp: (WebCore::FrameView::didStartRubberBand): (WebCore::FrameView::didCompleteRubberBand): (WebCore::FrameView::didStartAnimatedScroll): (WebCore::FrameView::didCompleteAnimatedScroll):
  • page/FrameView.h:
  • platform/ScrollableArea.h: (WebCore::ScrollableArea::didStartRubberBand): (WebCore::ScrollableArea::didStartAnimatedScroll): (WebCore::ScrollableArea::didCompleteAnimatedScroll):
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm: (-[ScrollAnimationHelperDelegate _immediateScrollToPoint:]): (WebCore::ScrollAnimatorMac::scroll): (WebCore::ScrollAnimatorMac::immediateScrollToPointForScrollAnimation): (WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):

2011-06-04 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 needs to know when a scroll is happening due to the ScrollAnimator
https://bugs.webkit.org/show_bug.cgi?id=62093

Stub out new ChromeClient functions regarding the start and end of ScrollAnimator
animated scrolls, and update logic for rubber-band ending to check for main frame
now that it is called for all frames.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didStartRubberBandForFrame): (WebKit::WebChromeClient::didCompleteRubberBandForFrame): (WebKit::WebChromeClient::didStartAnimatedScroll): (WebKit::WebChromeClient::didCompleteAnimatedScroll):
  • WebProcess/WebCoreSupport/WebChromeClient.h:
11:59 AM Changeset in webkit [88120] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-04 Martin Robinson <mrobinson@igalia.com>

Touch a file to try to fix the GTK+ build on the 32-bit bot.

  • testing/Internals.idl: Touch this IDL file in an effort to fix the build.
11:55 AM Changeset in webkit [88119] by weinig@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-04 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Fix formatting of the output generated by KeywordLookupGenerator.py
https://bugs.webkit.org/show_bug.cgi?id=62083

  • Uses correct year for copyright.
  • Puts ending brace on same line as "else if"
  • Puts starting brace of function on its own line.
  • Adds some tasteful whitespace.
  • Adds comments to make clear that scopes are ending
  • Make macros actually split on two lines.
  • KeywordLookupGenerator.py:
11:18 AM Changeset in webkit [88118] by mrobinson@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.4

Merging r87696

10:45 AM Changeset in webkit [88117] by dcheng@chromium.org
  • 8 edits
    2 copies in branches/chromium/782

Merge 87848 - 2011-06-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887

  • fast/events/drag-image-filename-expected.txt: Added.
  • fast/events/drag-image-filename.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-06-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887

We try to guess an appropriate filename when dragging out images. In order, we try to use:

  • The filename suggested in the HTTP header.
  • The last path component of the source URL.
  • The alt text. This matches the behavior of the other WebKit ports.

Test: fast/events/drag-image-filename.html

  • platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject):
  • platform/chromium/ClipboardChromiumMac.cpp: (WebCore::isInvalidFileCharacter): (WebCore::ClipboardChromium::validateFileName):

2011-06-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::dumpFilenameBeingDragged):
  • DumpRenderTree/chromium/EventSender.h:

TBR=dcheng@chromium.org
Review URL: http://codereview.chromium.org/7054067

10:23 AM Changeset in webkit [88116] by mrobinson@webkit.org
  • 4 edits in trunk

2011-06-04 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build.

  • bindings/gobject/GNUmakefile.am: Make the GObject build less noisy.

2011-06-04 Martin Robinson <mrobinson@igalia.com>

Fix the GTK+ build.

  • GNUmakefile.am: Add some missing newline escape.
10:14 AM Changeset in webkit [88115] by Dimitri Glazkov
  • 10 edits in trunk/Source/WebCore

2011-06-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Convert file <input> to use the new shadow DOM model
https://bugs.webkit.org/show_bug.cgi?id=59005

Refactoring, covered by existing tests.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Removed FILE_UPLOAD_BUTTON pseudoId and all references to it. (WebCore::nameToPseudoTypeMap): Ditto. (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h: Ditto.
  • css/html.css: (input[type="button"], input[type="submit"], input[type="reset"]): Moved -webkit-file-upload-button to its own rule. (input[type="file"]::-webkit-file-upload-button): Added and moved all previously hard-coded properties there.
  • html/FileInputType.cpp: (WebCore::UploadButtonElement::create): Added. (WebCore::UploadButtonElement::UploadButtonElement): Added. (WebCore::UploadButtonElement::shadowPseudoId): Added. (WebCore::FileInputType::createShadowSubtree): Added.
  • html/FileInputType.h: Added createShadowSubtree decl.
  • page/DragController.cpp: (WebCore::asFileInput): Changed the logic to use new shadow DOM.
  • rendering/RenderFileUploadControl.cpp: Removed UploadButton class. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed initializer for m_button. (WebCore::RenderFileUploadControl::updateFromElement): Removed attachment logic that's no longer necessary. (WebCore::nodeWidth): Added a helper. (WebCore::RenderFileUploadControl::maxFilenameWidth): Changed to use uploadButton and nodeWidth. (WebCore::RenderFileUploadControl::paintObject): Ditto. (WebCore::RenderFileUploadControl::uploadButton): Added a helper to retrieve the button. (WebCore::RenderFileUploadControl::buttonValue): Changed to use uploadButton.
  • rendering/RenderFileUploadControl.h: Changed decls.
  • rendering/style/RenderStyleConstants.h: Removed FILE_UPLOAD_BUTTON decls.
9:15 AM Changeset in webkit [88114] by kov@webkit.org
  • 7 edits
    3 adds in releases/WebKitGTK/webkit-1.4

Merging http://trac.webkit.org/changeset/87523

5:56 AM Changeset in webkit [88113] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

KeywordLookupGenerator.py spams stdout in Chromium Linux build
https://bugs.webkit.org/show_bug.cgi?id=62087

This action does not appear to be needed.

5:06 AM Changeset in webkit [88112] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make ResourceHandleInternal's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62073

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
4:35 AM Changeset in webkit [88111] by Laszlo Gombos
  • 2 edits in trunk/LayoutTests

2011-06-04 Laszlo Gombos <Laszlo Gombos>

Reviewed by Andreas Kling.

[Qt] Enable passing File API tests
https://bugs.webkit.org/show_bug.cgi?id=62020

File API has been enabled for QtWebKit in r74115,
let's also enable the passing related tests.

  • platform/qt/Skipped:
4:23 AM Changeset in webkit [88110] by ap@apple.com
  • 6 edits
    1 delete in trunk

2011-06-04 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

Input value sanitization for text fields is incorrect
https://bugs.webkit.org/show_bug.cgi?id=62061
<rdar://problem/9553273>

  • fast/forms/input-value-sanitization-expected.txt:
  • fast/forms/input-value-sanitization.html:
  • fast/forms/paste-multiline-text-input.html:
  • fast/forms/script-tests/input-value-sanitization.js: Removed.

2011-06-04 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

Input value sanitization for text fields is incorrect
https://bugs.webkit.org/show_bug.cgi?id=62061
<rdar://problem/9553273>

Newline characters should be removed according to HTML5, not replaced with spaces.
This also matches Safari 5 behavior.

  • html/TextFieldInputType.cpp: (WebCore::isASCIILineBreak): A functor for removeCharacters(). (WebCore::limitLength): Do one thing at once. (WebCore::TextFieldInputType::sanitizeValue): Sanitization removes newlines. (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent): Moved (somewhat surprising) code that replaces newlines with spaces here.
4:14 AM Changeset in webkit [88109] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make ChromePrintContext's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62076

Since WebFrameImpl's m_printContext is a OnwPtr<ChromePrintContext>
that is dynamically set to either a ChromePrintContext or a
ChromePluginPrintContext, this fixes an actual bug.

  • src/WebFrameImpl.cpp: (WebKit::ChromePrintContext::~ChromePrintContext): (WebKit::ChromePluginPrintContext::~ChromePluginPrintContext):
4:06 AM Changeset in webkit [88108] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebTextCheckingCompletionImpl's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62074

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/WebTextCheckingCompletionImpl.h: (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
3:58 AM Changeset in webkit [88107] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make PlatformMessagePortChannel's destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62072

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/PlatformMessagePortChannel.h:
3:50 AM Changeset in webkit [88106] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Give VoidCallbackClient a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=62067

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/NotificationPresenterImpl.cpp: (WebKit::VoidCallbackClient::~VoidCallbackClient):
3:42 AM Changeset in webkit [88105] by thakis@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebFrameImpl destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62065

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/WebFrameImpl.h:
3:32 AM Changeset in webkit [88104] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-04 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Beth Dakin.

Crash in WebCore::RenderMathMLSubSup::baselinePosition()
https://bugs.webkit.org/show_bug.cgi?id=57897

Added simple test that hits the relevant code.

  • mathml/msubsup-remove-children-expected.txt: Added.
  • mathml/msubsup-remove-children.xhtml: Added.

2011-06-04 Jeffrey Pfau <jpfau@apple.com>

Reviewed by Beth Dakin.

Crash in WebCore::RenderMathMLSubSup::baselinePosition()
https://bugs.webkit.org/show_bug.cgi?id=57897

Simple patch adding NULL checks in each function.
Test: mathml/msubsup-remove-children.xhtml

  • rendering/mathml/RenderMathMLSubSup.cpp: (WebCore::RenderMathMLSubSup::stretchToHeight): (WebCore::RenderMathMLSubSup::baselinePosition):
3:24 AM Changeset in webkit [88103] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

Give IDBBackingStore::Transaction a virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=62063

IDBLevelDBBackingStore::createTransaction() hands out a
PassRefPtr<IDBBackingStore::Transaction>, which means the missing
virtual destructor is a real bug.

  • storage/IDBBackingStore.h: (WebCore::IDBBackingStore::Transaction::~Transaction):
2:53 AM Changeset in webkit [88102] by eae@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-06-04 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Convert RenderBox::overflowClipRect to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62032

Covered by existing tests.

  • editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
  • platform/graphics/IntRect.h: (WebCore::IntRect::contract):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip): (WebCore::RenderBox::overflowClipRect):
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::repaintBlockSelectionGaps):
  • rendering/RenderLayerBacking.cpp: (WebCore::clipBox):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::overflowClipRect): (WebCore::RenderTable::nodeAtPoint):
  • rendering/RenderTable.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
2:24 AM Changeset in webkit [88101] by abarth@webkit.org
  • 2 edits in trunk/Source/ThirdParty
  • glu: Added property svn:ignore.
    • For glu.xcodeproj, which is generated from glu.gyp.
2:22 AM Changeset in webkit [88100] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

V8Proxy::disconnectFrame doesn't do anything
https://bugs.webkit.org/show_bug.cgi?id=62051

Dead code should die.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::~ScriptController):
  • bindings/v8/V8Proxy.cpp:
  • bindings/v8/V8Proxy.h:
2:05 AM Changeset in webkit [88099] by thakis@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

Make the destructors of DataTransferItem and DataTransferItems virtual
https://bugs.webkit.org/show_bug.cgi?id=62052

Clang has grown a new warning that warns on |delete ptr| if ptr's
class is non-final, has virtual methods, but no virtual destructor.
This warning finds real bugs, so we want to keep it enabled. However,
it also warns about DataTransferItem[s]. Since these are subclassed,
they can't be made final, so make their destructors virtual. (Maybe
clang's warning even points out an actual bug here.)

  • dom/DataTransferItem.h: (WebCore::DataTransferItem::~DataTransferItem):
  • dom/DataTransferItems.h: (WebCore::DataTransferItems::~DataTransferItems):
2:02 AM Changeset in webkit [88098] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-04 Nico Weber <thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make LayerPainterChromium destructor virtual
https://bugs.webkit.org/show_bug.cgi?id=62056

LayerTextureUpdaterCanvas has an OwnPtr<LayerPainterChromium>, which
means that without this patch, the destructor of classes implementing
LayerPainterChromium wasn't called correctly in that case.

  • platform/graphics/chromium/LayerPainterChromium.h: (WebCore::LayerPainterChromium::~LayerPainterChromium):
1:08 AM Changeset in webkit [88097] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

Configure new commit-queue instance. (Please ignore.)

12:02 AM Changeset in webkit [88096] by eae@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-04 Emil A Eklund <eae@chromium.org>

Reviewed by Andreas Kling.

Fix IntRect::expand(const IntSize& size)
https://bugs.webkit.org/show_bug.cgi?id=62042

No new tests.

  • platform/graphics/IntRect.h: (WebCore::IntRect::expand): Fix IntRect::expand to expand the size rather than move the location. Currently unused.

Jun 3, 2011:

11:45 PM Changeset in webkit [88095] by vangelis@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Vangelis Kokkevis <vangelis@chromium.org>

Unreviewed. Fixes test expectatations.

[chromium] Fixing redefinitions of test_expectations entries
for chrome gpu tests.

  • platform/chromium/test_expectations.txt:
11:15 PM Changeset in webkit [88094] by oliver@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

2011-06-03 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej Stachowiak.

Lexer needs to provide Identifier for reserved words
https://bugs.webkit.org/show_bug.cgi?id=62086

Alas it is necessary to provide an Identifier reference for keywords
so that we can do the right thing when they're used in object literals.
We now keep Identifiers for all reserved words in the CommonIdentifiers
structure so that we can access them without a hash lookup.

  • KeywordLookupGenerator.py:
  • parser/Lexer.cpp: (JSC::Lexer::parseIdentifier):
  • parser/Lexer.h:
  • runtime/CommonIdentifiers.cpp: (JSC::CommonIdentifiers::CommonIdentifiers):
  • runtime/CommonIdentifiers.h:
10:25 PM Changeset in webkit [88093] by barraclough@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add debug code to break on speculation failures.

Reviewed by Sam Weinig.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGNode.h:
10:13 PM Changeset in webkit [88092] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=62082
DFG JIT - bug passing arguments that need swap

Reviewed by Sam Weinig.

This is really just a typo.
When setting up the arguments for a call out to a C operation, we'll
fail to swap arguments where this is necessary. For example, in the
case of 2 arg calls, where the first argument is in %rdx & the second
is in %rsi we should swap (exec will be passed in %rdi), but we don't.

This can also affect function calls passing three arguments.

  • dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::setupTwoStubArgs):

  • Call swap with the correct arguments.
9:59 PM Changeset in webkit [88091] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-03 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

ResourceHandleMac should always respond to an authentication challenge
https://bugs.webkit.org/show_bug.cgi?id=61667

I don't know if this can actually happen in practice, so no new tests.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Cancel authentication challenge if we don't have a client. We must always respond to the challenge to release the connection, and there is nothing else to do in this state anyway.
9:35 PM Changeset in webkit [88090] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

Try to fix the Apple LLVM Compiler build after r88087.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintMask):

  • rendering/RenderTableCell.h:
8:06 PM Changeset in webkit [88089] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Fix clang build - take 2

7:57 PM Changeset in webkit [88088] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Fix clang build

7:25 PM Changeset in webkit [88087] by leviw@chromium.org
  • 21 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintMask and paintObject to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62077

Switching paintMask and paintObject to use IntPoint for their paint offset instead of
a pair of ints. paintObject is still on tx/ty, but paintMask was converted to IntSize
passed by value -- bringing it in-line with the agreed-upon convention of a const IntPoint&.

No new tests since this is simple refactoring.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintObject):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMask): (WebCore::RenderBox::pushContentsClip): (WebCore::RenderBox::popContentsClip):
  • rendering/RenderBox.h: (WebCore::RenderBox::paintObject):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintMask):
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
  • rendering/RenderListBox.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintMask):
  • rendering/RenderTable.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::paintObject):
  • rendering/RenderTableSection.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder): (WebCore::RenderTextControl::paintObject):
  • rendering/RenderTextControl.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::paint):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
6:58 PM Changeset in webkit [88086] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/782

Merge 88071
BUG=83743
Review URL: http://codereview.chromium.org/7058060

6:55 PM Changeset in webkit [88085] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/742

Merge 88071
BUG=83743
Review URL: http://codereview.chromium.org/7112025

6:34 PM Changeset in webkit [88084] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-03 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Force inlining of some hot lexer functions
https://bugs.webkit.org/show_bug.cgi?id=62079

Fix more GCC stupidity

  • parser/Lexer.h: (JSC::Lexer::isWhiteSpace): (JSC::Lexer::isLineTerminator):
5:43 PM Changeset in webkit [88083] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

2011-06-03 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

GCC not inlining some functions that it really should be
https://bugs.webkit.org/show_bug.cgi?id=62075

Add ALWAYS_INLINE to a number of parsing and lexing functions
that should always be inlined. This gets us ~1.4% on my ad hoc
parser test.

  • KeywordLookupGenerator.py:
  • parser/JSParser.cpp: (JSC::JSParser::next): (JSC::JSParser::nextTokenIsColon): (JSC::JSParser::consume): (JSC::JSParser::match): (JSC::JSParser::tokenStart): (JSC::JSParser::tokenLine): (JSC::JSParser::tokenEnd):
  • parser/Lexer.cpp: (JSC::isIdentPart):
5:39 PM Changeset in webkit [88082] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Whoops, fix last minute bug.

5:22 PM Changeset in webkit [88081] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-03 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Support FontCustomPlatformData on Skia-Mac-Chrome variant
https://bugs.webkit.org/show_bug.cgi?id=62040

Canvas text is only recognized by Skia if it is registered
by creating a new SkTypeface. Skia uses CGFont to measure
and render the glyphs, then takes care of managing the glyph
cache.

Skia on Mac Chrome is not yet enabled, so this change
does not affect existing code, and requires no new tests.

  • platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::RemoteFontStream::RemoteFontStream): (WebCore::RemoteFontStream::~RemoteFontStream): (WebCore::RemoteFontStream::rewind): (WebCore::RemoteFontStream::read): Turn the buffer into a stream. This is identical to the implementation in skia/FontCustomPlatformData.cpp. While that file could be modified instead of this one, it was simpler to add SkTypeface streaming to this instead of adding all CGFont support to the skia platform file.

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
Release the SkTypeface reference.

(WebCore::createFontCustomPlatformData):
Associate the buffer stream with a SkTypeface so Skia
can find the custom font data.

  • platform/graphics/mac/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData): Add a slot to hold the SkTypeface.
5:16 PM Changeset in webkit [88080] by sfalken@apple.com
  • 2 edits in trunk/Source/WebCore

2011-06-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Brian Weinstein.

HistoryItem children persist across page loads
https://bugs.webkit.org/show_bug.cgi?id=62071
<rdar://problem/9552129>


Not testable since there's no way to check for the presence/absence
of children for a HistoryItem.

  • history/HistoryItem.cpp: (WebCore::HistoryItem::reset): Call clearChildren when we're reusing a HistoryItem.
5:09 PM Changeset in webkit [88079] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-06-03 James Robinson <jamesr@chromium.org>

[chromium] Mark GPU-only expectations as GPU.

  • platform/chromium/test_expectations.txt:
4:57 PM Changeset in webkit [88078] by mrobinson@webkit.org
  • 5 edits in trunk

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Try to fix the GTK+ build.

  • GNUmakefile.am: Clean up some spaces that should be tabs.
  • GNUmakefile.list.am: Add KeywordLookup.h to the source list and clean up some spaces that should be tabs.

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Try to fix the GTK+ bulid.

  • GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals source list.
4:53 PM Changeset in webkit [88077] by scherkus@chromium.org
  • 36 edits in trunk/LayoutTests

2011-06-03 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, rebaselining Chromium GPU media pixel results after Chromium commit 87830.

  • platform/chromium-gpu-linux/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-linux/media/controls-strict-expected.png:
  • platform/chromium-gpu-linux/media/controls-styling-expected.png:
  • platform/chromium-gpu-linux/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-linux/media/video-aspect-ratio-expected.png:
  • platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-linux/media/video-transformed-expected.png:
  • platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-mac/media/controls-strict-expected.png:
  • platform/chromium-gpu-mac/media/controls-styling-expected.png:
  • platform/chromium-gpu-mac/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-mac/media/video-aspect-ratio-expected.png:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-transformed-expected.png:
  • platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/controls-after-reload-expected.png:
  • platform/chromium-gpu-win/media/controls-strict-expected.png:
  • platform/chromium-gpu-win/media/controls-styling-expected.png:
  • platform/chromium-gpu-win/media/controls-without-preload-expected.png:
  • platform/chromium-gpu-win/media/video-aspect-ratio-expected.png:
  • platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-layer-crash-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-transformed-expected.png:
  • platform/chromium-gpu-win/media/video-volume-slider-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
4:30 PM Changeset in webkit [88076] by oliver@apple.com
  • 10 edits
    1 add in trunk/Source/JavaScriptCore

2011-06-03 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Improve keyword lookup
https://bugs.webkit.org/show_bug.cgi?id=61913

Rather than doing multiple hash lookups as we currently
do when trying to identify keywords we now use an
automatically generated decision tree (essentially it's
a hard coded patricia trie). We still use the regular
lookup table for the last few characters of an input as
this allows us to completely skip all bounds checks.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • JavaScriptCore.gyp/JavaScriptCore.gyp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • KeywordLookupGenerator.py: Added.
  • make-generated-sources.sh:
  • parser/Lexer.cpp: (JSC::Lexer::internalShift): (JSC::Lexer::shift): (JSC::Lexer::parseIdentifier):
  • parser/Lexer.h:
4:29 PM Changeset in webkit [88075] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9553645> and https://bugs.webkit.org/show_bug.cgi?id=62064
WebBackForwardListItem::setBackForwardData actually appends data

Reviewed by Steve Falkenburg.

  • Shared/WebBackForwardListItem.cpp:

(WebKit::WebBackForwardListItem::setBackForwardData): Clear the Vector out before appending

the replacement data.

4:03 PM Changeset in webkit [88074] by crogers@google.com
  • 8 edits in trunk/Source/WebCore

2011-06-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Allow existing AudioParams to use scheduled parameter changes
https://bugs.webkit.org/show_bug.cgi?id=62046

No new tests since audio API is not yet implemented.

  • platform/audio/AudioBus.cpp: (WebCore::AudioBus::processWithGainFrom): (WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom):
  • platform/audio/AudioBus.h:
  • webaudio/AudioBufferSourceNode.cpp: (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
  • webaudio/AudioGainNode.cpp: (WebCore::AudioGainNode::AudioGainNode): (WebCore::AudioGainNode::process):
  • webaudio/AudioGainNode.h:
  • webaudio/HighPass2FilterNode.cpp: (WebCore::HighPass2FilterNode::HighPass2FilterNode):
  • webaudio/LowPass2FilterNode.cpp: (WebCore::LowPass2FilterNode::LowPass2FilterNode):
4:02 PM Changeset in webkit [88073] by dpranke@chromium.org
  • 5 edits in trunk

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, merge in downstream lines from Chromium as part of
landing the fix for bug 61888.

  • platform/chromium/test_expectations.txt:

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

nrwt: should skip chromium test expectation overrides on upstream bots
https://bugs.webkit.org/show_bug.cgi?id=61888

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3:52 PM Changeset in webkit [88072] by crogers@google.com
  • 3 edits in trunk/Source/WebCore

2011-06-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Biquad filter coefficient naming is incorrect
https://bugs.webkit.org/show_bug.cgi?id=62053

No new tests since audio API is not yet implemented.

  • platform/audio/Biquad.cpp: (WebCore::Biquad::Biquad): (WebCore::Biquad::process): (WebCore::Biquad::processFast): (WebCore::Biquad::setLowpassParams): (WebCore::Biquad::setHighpassParams): (WebCore::Biquad::setLowShelfParams): (WebCore::Biquad::setZeroPolePairs):
  • platform/audio/Biquad.h:
3:42 PM Changeset in webkit [88071] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

DOMWindow::setLocation doesn't understand that DOMWindow can be inactive
https://bugs.webkit.org/show_bug.cgi?id=62057

Test that some esoteric combination of eval, load, and Location don't
do something goofy.

  • http/tests/security/xss-DENIED-contentWindow-eval-expected.txt: Added.
  • http/tests/security/xss-DENIED-contentWindow-eval.html: Added.

2011-06-03 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

DOMWindow::setLocation doesn't understand that DOMWindow can be inactive
https://bugs.webkit.org/show_bug.cgi?id=62057

This code gets confused when dealing with inactive DOMWindows. We
should just block inactive DOMWindows because there's no compatibility
reason to support them in this code path.

Test: http/tests/security/xss-DENIED-contentWindow-eval.html

  • page/DOMWindow.cpp: (WebCore::DOMWindow::isInsecureScriptAccess):
3:38 PM QtWebKitFeatures22 edited by Laszlo Gombos
(diff)
3:34 PM Changeset in webkit [88070] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: minor logging, code cleanup
https://bugs.webkit.org/show_bug.cgi?id=62055

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
3:22 PM Changeset in webkit [88069] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Try to fix the build failure on the GTK+ 32-bit Release bot.

  • GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
3:14 PM Changeset in webkit [88068] by simonjam@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-06-03 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, baseline for full-screen-placeholder. More flakiness for svg/zoom and navigator.

  • platform/chromium-win/fullscreen/full-screen-placeholder-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:03 PM Changeset in webkit [88067] by enne@google.com
  • 2 edits in branches/chromium/782/Source

Merge 87868 - 2011-06-01 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix syncing of removed mask and replica layers
https://bugs.webkit.org/show_bug.cgi?id=61895

  • platform/graphics/chromium/TreeSynchronizer.cpp: (WebCore::TreeSynchronizer::synchronizeTreeRecursive):

2011-06-01 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix syncing of removed mask and replica layers
https://bugs.webkit.org/show_bug.cgi?id=61895

  • tests/TreeSynchronizerTest.cpp: (WebCore::TEST):

TBR=enne@google.com

2:55 PM Changeset in webkit [88066] by mrobinson@webkit.org
  • 22 edits in trunk

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734

Unskip tests which are now passing and update results for other tests
which vary depending on smart replace support.

  • platform/gtk/Skipped: Unskip tests which are now passing.
  • platform/gtk/editing/deleting/smart-delete-003-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-004-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-2-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-007-expected.txt:
  • platform/gtk/editing/pasteboard/smart-paste-008-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/fast/lists/drag-into-marker-expected.txt:

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734

Add smart replace support to WebCore and add hooks for it in WebKit
via DumpRenderTreeSupportGtk. When a platform supports smart replace,
WebCore will remove extra spaces that appear when pasting text. Eventually
WebKitGTK+ may want to expose this in the public API.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeSelection): Now pass whether or not to use smart replace when calling writeSelection. (WebCore::Pasteboard::canSmartReplace): Added an implementation that checks the clipboard for whether or not it supports smart paste.
  • platform/gtk/PasteboardHelper.cpp: (WebCore::initGdkAtoms): Added initialization for smart replace atom. (WebCore::PasteboardHelper::fillSelectionData): Added no-op handler for smart replace atom. (WebCore::PasteboardHelper::targetListForDataObject): Properly handle new smart replace parameter. (WebCore::PasteboardHelper::writeClipboardContents): Properly handle new smart replace parameter. (WebCore::PasteboardHelper::clipboardContentSupportsSmartReplace): Added helper for Pasteboard.
  • platform/gtk/PasteboardHelper.h: Add new method definition.

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734

Add the EditorClient and DumpRenderTreeSupportGtk hooks for enabling
smart replace in the tests.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): targeListForDataObject now takes another parameter determining whether or not to add smart paste support. Add it here.
  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: (DumpRenderTreeSupportGtk::setSmartInsertDeleteEnabled): Added.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h: Add new method definition.
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::toggleSmartInsertDelete): Added implementation. (WebKit::EditorClient::smartInsertDeleteEnabled): Added. (WebKit::EditorClient::EditorClient):
  • WebCoreSupport/EditorClientGtk.h: Add new method definition.

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ryosuke Niwa.

[GTK] Support smart replace for the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=61734

Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
This is required to produce consistent test results.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this methods which calls into DumpRenderTreeSupportGtk.
2:53 PM Changeset in webkit [88065] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-03 Rafael Brandao <rafael.lobo@openbossa.org>

Reviewed by Andreas Kling.

[Qt] It made two Qt API tests fail
https://bugs.webkit.org/show_bug.cgi?id=58847

Modified failing test's base url so it could get a valid origin
and make use of local storage. Also added another test that checks
local storage visibility in both scenarios.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::testOptionalJSObjects): (checkLocalStorageVisibility): (tst_QWebPage::testLocalStorageVisibility):
2:49 PM Changeset in webkit [88064] by scherkus@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, updating media/video-display-aspect-ratio.html expectations for Chromium.

  • platform/chromium/test_expectations.txt:
2:45 PM Changeset in webkit [88063] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintCell to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62033

Switching paintCell to take an IntPoint representing the paint offset
instead of a pair of ints.

No new tests since this is simple refactoring.

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintCell): (WebCore::RenderTableSection::paintObject):
  • rendering/RenderTableSection.h:
2:39 PM Changeset in webkit [88062] by mrobinson@webkit.org
  • 9 edits in trunk

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dimitri Glazkov.

Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071

  • Source/autotools/symbols.filter: Added some symbols necessary for window.internals to function to the global symbol list.

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dimitri Glazkov.

Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071

  • platform/gtk/Skipped: Unskip the one new window.internals test.

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dimitri Glazkov.

Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071

  • GNUmakefile.am: Add new internals directories to the VPATH (for idl processing) and the include list.

2011-06-03 Martin Robinson <mrobinson@igalia.com>

Reviewed by Dimitri Glazkov.

Teach Gtk build about window.internals
https://bugs.webkit.org/show_bug.cgi?id=61071

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): Inject the new internals object when the window object clears.
  • GNUmakefile.am: Add new source files and includes necessary for window.internals. Also do a little bit of cleanup.
2:37 PM Changeset in webkit [88061] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source

Versioning.

2:34 PM Changeset in webkit [88060] by Lucas Forschler
  • 1 copy in tags/Safari-534.43

New tag.

2:33 PM Changeset in webkit [88059] by Lucas Forschler
  • 1 delete in tags/Safari-534.43

remove tag.

2:33 PM Changeset in webkit [88058] by Lucas Forschler
  • 1 delete in tags/Safari-534.43/safari-534-branch

remove tag.

2:31 PM Changeset in webkit [88057] by Lucas Forschler
  • 1 copy in tags/Safari-534.43/safari-534-branch

New tag.

2:31 PM Changeset in webkit [88056] by Lucas Forschler
  • 8 edits in branches/safari-534-branch/Source/WebKit2

Merge r87839.

2:26 PM Changeset in webkit [88055] by Lucas Forschler
  • 1 copy in tags/Safari-534.43

New tag.

2:26 PM Changeset in webkit [88054] by Laszlo Gombos
  • 2 edits in trunk/LayoutTests

2011-06-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Antonio Gomes.

[Qt] Enable ArrayBuffer passing tests as ArrayBuffer is enabled by default
https://bugs.webkit.org/show_bug.cgi?id=62025

  • platform/qt/Skipped:
2:24 PM Changeset in webkit [88053] by scherkus@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-03 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, adding Ogg Theora version of media/content/test-par-16-9.mp4.

  • media/content/test-par-16-9.ogv: Added.
2:02 PM Changeset in webkit [88052] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Warning fixes on comparisons between a signed and an unsigned.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo): (DumpRenderTreeSupportQt::nodesFromRect):
1:59 PM Changeset in webkit [88051] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintBackgroundsBehindCell to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62031

Switching paintBackgroundsBehindCell to take an IntPoint representing
the paint offset instead of a pair of ints.

No new tests as this is simple refactoring.

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintCell):
1:57 PM Changeset in webkit [88050] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintCaret and paintDragCaret to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62037

Switching paintCaret and paintDragCaret to use an IntPoint representing
the paint offset instead of a pair of ints.

No new tests since this is simple refactoring.

  • editing/FrameSelection.cpp: (WebCore::FrameSelection::paintCaret): (WebCore::CaretBase::paintCaret): (WebCore::DragCaretController::paintDragCaret):
  • editing/FrameSelection.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::positionForPoint): (WebCore::RenderBlock::offsetForContents):
  • rendering/RenderBlock.h:
1:55 PM Changeset in webkit [88049] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintItemForeground and paintItemForeground to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62035

Switching paintItemFore/Background to use IntPoint instead of a pair of ints.

No new tests since this is simple refactoring.

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground):
  • rendering/RenderListBox.h:
1:53 PM Changeset in webkit [88048] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-06-03 Anders Carlsson <andersca@apple.com>

Reviewed by Brady Eidson.

Disable the sync message timeout for the Microsoft SharePoint plug-in
https://bugs.webkit.org/show_bug.cgi?id=62043
<rdar://problem/9536303>

  • WebProcess/Plugins/PluginProcessConnection.cpp: (WebKit::defaultSyncMessageTimeout):
1:49 PM Changeset in webkit [88047] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change. Fix conflict in expectations.

  • platform/chromium/test_expectations.txt:
1:35 PM Changeset in webkit [88046] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit2

2011-06-03 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

[Qt] TiledDrawingArea: Initialize tiles to transparent.

  • UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::incorporateUpdate): When constructing new back buffers, fill them with transparent pixels.
1:32 PM Changeset in webkit [88045] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.

  • WebCoreSupport/FrameLoaderClientQt.h:

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.

  • platform/network/qt/QtMIMETypeSniffer.h:
1:29 PM Changeset in webkit [88044] by mnaganov@chromium.org
  • 1 edit in trunk/LayoutTests/platform/chromium/test_expectations.txt

[Chromium] Unreviewed test expectations update for inspector/profiler/cpu-profiler-profiling* on Linux. https://bugs.webkit.org/show_bug.cgi?id=61533

1:28 PM Changeset in webkit [88043] by kov@webkit.org
  • 6 edits in releases/WebKitGTK/webkit-1.4

Merging http://trac.webkit.org/changeset/85207

1:22 PM Changeset in webkit [88042] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4

http://trac.webkit.org/changeset/86084

1:07 PM Changeset in webkit [88041] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed build fix after r87902.

To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE but
only on classes inside Qt.


  • WebCoreSupport/DumpRenderTreeSupportQt.h:
12:43 PM Changeset in webkit [88040] by dpranke@chromium.org
  • 3 edits in trunk/Tools

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

Worker may not be stopped after LT.
https://bugs.webkit.org/show_bug.cgi?id=61847

Re-submit a variant of the first fix for this bug. It's possible
that actually calling cleanup() in the worker threads was taking
too long and we triggered the assertions in the manager thread.

I've bumped up the timeout in the manager and added better
diagnostics. I also cleaned up the cleanup() code a bit because
there was some unnecessary if-checks.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
12:35 PM Changeset in webkit [88039] by rwlbuis@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-06-03 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Cleanup member variable usage in svg/animation classes
https://bugs.webkit.org/show_bug.cgi?id=62029

Cleanup member variables.

  • svg/animation/SMILTimeContainer.cpp: (WebCore::SMILTimeContainer::SMILTimeContainer): (WebCore::SMILTimeContainer::sampleAnimationAtTime): (WebCore::SMILTimeContainer::updateAnimations):
  • svg/animation/SMILTimeContainer.h:
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::SVGSMILElement):
  • svg/animation/SVGSMILElement.h:
12:18 PM Changeset in webkit [88038] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

Some warning fixes. Values in switch not handled, and
a comparison between a signed and an unsigned.

  • Api/qwebpage.cpp: (QWebPagePrivate::inputMethodEvent): (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPage::action):
12:17 PM Changeset in webkit [88037] by crogers@google.com
  • 6 edits
    2 adds in trunk/Source/WebCore

2011-06-03 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Add AudioParam parameter scheduling implementation
https://bugs.webkit.org/show_bug.cgi?id=61830

No new tests since audio API is not yet implemented.

  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • webaudio/AudioParam.cpp: (WebCore::AudioParam::value): (WebCore::AudioParam::smoothedValue): (WebCore::AudioParam::smooth): (WebCore::AudioParam::calculateSampleAccurateValues):
  • webaudio/AudioParam.h: (WebCore::AudioParam::setContext): (WebCore::AudioParam::context): (WebCore::AudioParam::setValueAtTime): (WebCore::AudioParam::linearRampToValueAtTime): (WebCore::AudioParam::exponentialRampToValueAtTime): (WebCore::AudioParam::setTargetValueAtTime): (WebCore::AudioParam::setValueCurveAtTime): (WebCore::AudioParam::cancelScheduledValues): (WebCore::AudioParam::hasTimelineValues):
  • webaudio/AudioParam.idl:
  • webaudio/AudioParamTimeline.cpp: Added. (WebCore::AudioParamTimeline::setValueAtTime): (WebCore::AudioParamTimeline::linearRampToValueAtTime): (WebCore::AudioParamTimeline::exponentialRampToValueAtTime): (WebCore::AudioParamTimeline::setTargetValueAtTime): (WebCore::AudioParamTimeline::setValueCurveAtTime): (WebCore::isValidNumber): (WebCore::AudioParamTimeline::insertEvent): (WebCore::AudioParamTimeline::cancelScheduledValues): (WebCore::AudioParamTimeline::valueForContextTime): (WebCore::AudioParamTimeline::valuesForTimeRange): (WebCore::timeToSampleFrame): (WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
  • webaudio/AudioParamTimeline.h: Added. (WebCore::AudioParamTimeline::AudioParamTimeline): (WebCore::AudioParamTimeline::hasValues): (WebCore::AudioParamTimeline::ParamEvent::ParamEvent): (WebCore::AudioParamTimeline::ParamEvent::type): (WebCore::AudioParamTimeline::ParamEvent::value): (WebCore::AudioParamTimeline::ParamEvent::time): (WebCore::AudioParamTimeline::ParamEvent::timeConstant): (WebCore::AudioParamTimeline::ParamEvent::duration): (WebCore::AudioParamTimeline::ParamEvent::curve):
12:05 PM QtWebKitFeatures22 edited by Ademar Reis
(diff)
12:03 PM QtWebKitFeatures22 edited by Ademar Reis
(diff)
12:02 PM QtWebKitFeatures22 edited by Ademar Reis
(diff)
12:02 PM Changeset in webkit [88036] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.4/Source/WebCore

Merging http://trac.webkit.org/changeset/87366

12:00 PM Changeset in webkit [88035] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: fix duplicate logging regression
https://bugs.webkit.org/show_bug.cgi?id=61981

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
11:57 AM QtWebKitFeatures22 edited by Ademar Reis
(diff)
11:51 AM QtWebKitFeatures22 edited by Ademar Reis
(diff)
11:48 AM Changeset in webkit [88034] by jer.noble@apple.com
  • 7 edits
    2 adds in trunk

2011-06-01 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Flash of broken page when exiting full screen at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61897
<rdar://problem/9522985>

  • fullscreen/full-screen-placeholder-expected.txt: Added.
  • fullscreen/full-screen-placeholder.html: Added.

2011-06-01 Jer Noble <jer.noble@apple.com>

Reviewed by Simon Fraser.

Flash of broken page when exiting full screen at jerryseinfeld.com
https://bugs.webkit.org/show_bug.cgi?id=61897
<rdar://problem/9522985>

Test: fullscreen/full-screen-placeholder.html

Entering full-screen mode is causing the page layout to change because the full-screen
element is taken out of the normal flow. To counteract this effect, insert a placeholder
block as a parent of the full-screen renderer with the same size and style as the full-screen
element pre-full-screen.

Only create a placeholder for block-level elements; the technique required for inline elements
would be vastly more complicated.

  • dom/Document.cpp: (WebCore::Document::webkitWillEnterFullScreenForElement): Create a placeholder

based on the size and style of the full-screen element.

(WebCore::Document::setFullScreenRenderer): Persist the placeholder size and

style across new renderers.

  • rendering/RenderFullScreen.cpp: (RenderFullScreen::RenderFullScreen): Added ivar. (RenderFullScreen::destroy): Make sure to safely destroy our placeholder. (RenderFullScreen::createPlaceholder): Added.
  • rendering/RenderFullScreen.h: (WebCore::RenderFullScreen::placeholder): Ivar accessor.
11:43 AM Changeset in webkit [88033] by leviw@chromium.org
  • 17 edits in trunk/Source/WebCore

2011-06-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintBoxDecorations to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61968

Switching paintBoxDecorations to take an IntPoint representing
the paint offset instead of a pair of ints. Also cleaning up
some duplicated code in InlineFlowBox related to constraining
the paint rect to the linetop and linebottom.

No new tests since this is just refactoring.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded): Added to remove duplicate code in paintBoxDecorations and paintMask. (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations):
  • rendering/RenderBox.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderFieldset.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paintObject): (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTableCell.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint):
11:37 AM QtWebKitFeatures22 edited by Ademar Reis
(diff)
11:33 AM Changeset in webkit [88032] by commit-queue@webkit.org
  • 4 edits in trunk

2011-06-03 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Adam Barth.

Removed test_expectations failure entry for BUGCR36415 as is fixed
with patch in https://bugs.webkit.org/show_bug.cgi?id=62016

  • platform/chromium/test_expectations.txt:

2011-06-03 Robert Kroeger <rjkroege@chromium.org>

Reviewed by Adam Barth.

Modified addTouchPoint to correctly re-use touchPoint id values starting
from the lowest not-un-use touchPoint id as is done by the embedder
APIs. (Fixes BUGCR36415)

https://bugs.webkit.org/show_bug.cgi?id=62016

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::addTouchPoint):
11:22 AM Changeset in webkit [88031] by simonjam@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-06-03 James Simonsen <simonjam@chromium.org>

[Chromium] Unreviewed, pixel baselines for selectlist-minsize.html.

  • platform/chromium-linux/fast/forms/selectlist-minsize-expected.png: Added.
  • platform/chromium-linux/fast/forms/selectlist-minsize-expected.txt: Added.
  • platform/chromium-mac/fast/forms/selectlist-minsize-expected.png: Added.
  • platform/chromium-win/fast/forms/selectlist-minsize-expected.png: Added.
  • platform/chromium-win/fast/forms/selectlist-minsize-expected.txt: Added.
10:39 AM Changeset in webkit [88030] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

2011-06-03 Philippe Beauchamp <philippe.beauchamp@gmail.com>

Reviewed by Dimitri Glazkov.

Add the feature "Add as search engine..." in a search text field context menu for chromium
https://bugs.webkit.org/show_bug.cgi?id=47980

  • public/WebContextMenuData.h:
  • public/WebSearchableFormData.h:
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/WebSearchableFormData.cpp: (WebKit::WebSearchableFormData::WebSearchableFormData):
10:03 AM Changeset in webkit [88029] by commit-queue@webkit.org
  • 28 edits
    3 adds in trunk

2011-06-03 Doreen Jiang <doreen.jiang@nokia.com>

Reviewed by Benjamin Poulain.

[Qt]The minimum size of the select menu list is incorrect for qtwebkit
https://bugs.webkit.org/show_bug.cgi?id=56752

The test is to get the render tree of select menu lists with varying widths based on content.
Some select list based tests are rebaselined because minimum width of RenderMenuList changes
based on the content with this fix.

  • fast/forms/selectlist-minsize.html: Added.
  • platform/mac/fast/forms/selectlist-minsize-expected.txt: Added.
  • platform/qt/editing/pasteboard/4641033-expected.txt:
  • platform/qt/editing/pasteboard/4944770-1-expected.txt:
  • platform/qt/editing/pasteboard/4944770-2-expected.txt:
  • platform/qt/editing/selection/caret-before-select-expected.txt:
  • platform/qt/fast/forms/003-expected.txt:
  • platform/qt/fast/forms/004-expected.txt:
  • platform/qt/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/qt/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/qt/fast/forms/basic-selects-expected.txt:
  • platform/qt/fast/forms/menulist-deselect-update-expected.txt:
  • platform/qt/fast/forms/menulist-separator-painting-expected.txt:
  • platform/qt/fast/forms/menulist-style-color-expected.txt:
  • platform/qt/fast/forms/option-script-expected.txt:
  • platform/qt/fast/forms/select-background-none-expected.txt:
  • platform/qt/fast/forms/select-baseline-expected.txt:
  • platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/qt/fast/forms/select-empty-option-height-expected.txt:
  • platform/qt/fast/forms/select-size-expected.txt:
  • platform/qt/fast/forms/select-style-expected.txt:
  • platform/qt/fast/forms/selectlist-minsize-expected.txt: Added.
  • platform/qt/fast/invalid/014-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-expected.txt:
  • platform/qt/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/qt/fast/replaced/three-selects-break-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/qt/tables/mozilla/core/margins-expected.txt:

2011-06-03 Doreen Jiang <doreen.jiang@nokia.com>

Reviewed by Benjamin Poulain.

[Qt]The minimum size of the select menu list is incorrect for qtwebkit
https://bugs.webkit.org/show_bug.cgi?id=56752

The minimum width of the select-box is calculated to be as small as possible
instead of hardcoded value (width of 7 characters) in minimumMenuListSize() function
This will avoid overapping the select lists in popular websites.

Test: fast/forms/selectlist-minsize.html

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::minimumMenuListSize):
10:00 AM Changeset in webkit [88028] by bulach@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Marcus Bulach <bulach@chromium.org>

Reviewed by Unreviewed rebaseline.

[chromium] Rebaseline following r88020
https://bugs.webkit.org/show_bug.cgi?id=62028

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
9:54 AM Changeset in webkit [88027] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebKit2

2011-06-03 No'am Rosenthal <noam.rosenthal@nokia.com>

Reviewed by Andreas Kling.

[Qt][WK2] Make tiling on WebKit2 more responsive.
https://bugs.webkit.org/show_bug.cgi?id=50064

Instead of creating and destroying pixmaps, and copying them using QPixmap::copy()
or relying on the implicit sharing functionality, we keep the QPixmaps alive
and just make sure their content is synchronized.

This seems to improve responsiveness noticably, as now the UI process doesn't deal
with allocating/deallocating pixmaps, and the copies are done with the optimized
path (QPainter) vs the unoptimized ones (QPixmap::copy().)

  • UIProcess/TiledDrawingAreaTile.h:
  • UIProcess/qt/TiledDrawingAreaTileQt.cpp: (WebKit::TiledDrawingAreaTile::TiledDrawingAreaTile): (WebKit::TiledDrawingAreaTile::isReadyToPaint): (WebKit::TiledDrawingAreaTile::hasReadyBackBuffer): (WebKit::TiledDrawingAreaTile::swapBackBufferToFront): (WebKit::TiledDrawingAreaTile::incorporateUpdate):
9:26 AM Changeset in webkit [88026] by Dimitri Glazkov
  • 6 edits in trunk

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Prevent event dispatch for events with related target when host is the target.
https://bugs.webkit.org/show_bug.cgi?id=61979

  • fast/events/shadow-boundary-crossing-expected.txt: Added test.
  • fast/events/shadow-boundary-crossing.html: Added expectations.

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Prevent event dispatch for events with related target when host is the target.
https://bugs.webkit.org/show_bug.cgi?id=61979

Turns out, even if we trim the ancestor chain to 0, the event is still dispatched during AT_TARGET.
So might as well be explicit about what we are trying to do and add a flag to prevent dispatch in these cases.

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::adjustToShadowBoundaries): Added preventing dispatch when the ancestor chain is trimmed to nothing. (WebCore::EventDispatcher::EventDispatcher): Added initializer. (WebCore::EventDispatcher::dispatchEvent): Added a check to prevent dispatch.
  • dom/EventDispatcher.h: Added a def.
9:24 AM Changeset in webkit [88025] by mario@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, new baselines for GTK after r88007 and r8009.

  • platform/gtk/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/gtk/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
  • platform/gtk/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/gtk/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
9:14 AM Changeset in webkit [88024] by mario@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, new baselines for GTK after r88011.

  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
9:08 AM Changeset in webkit [88023] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Mac build fix.

  • WebCore.xcodeproj/project.pbxproj:
9:07 AM Changeset in webkit [88022] by mario@webkit.org
  • 6 edits
    5 adds in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, tests rebaselines for GTK after r88011.

  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
9:00 AM Changeset in webkit [88021] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/Source

2011-06-03 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Eric Seidel.

[Chromium] Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.
https://bugs.webkit.org/show_bug.cgi?id=61260
http://code.google.com/p/chromium/issues/detail?id=12721

Manual test: select-popup-tooltip-test.html

  • manual-tests/select-popup-tooltip-test.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::getSelectedItemToolTip): Get selected item tooltip string according to hovering mouse position.
  • platform/chromium/PopupMenuChromium.h: Add getSelectedItemToolTip() declaration.

2011-06-03 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Eric Seidel.

[Chromium] Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.
https://bugs.webkit.org/show_bug.cgi?id=61260
http://code.google.com/p/chromium/issues/detail?id=12721

  • public/WebMenuItemInfo.h: Add toolTip.
  • public/WebViewClient.h: Remove setToolTipText().
  • public/WebWidgetClient.h: Add setTooTipText(). (WebKit::WebWidgetClient::setToolTipText):
  • src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::getPopupMenuInfo): Add popupItem.toolTip set.
  • src/WebPopupMenuImpl.cpp: (WebKit::WebPopupMenuImpl::MouseMove): Call setToolTipText().
8:45 AM Changeset in webkit [88020] by rwlbuis@webkit.org
  • 15 edits in trunk

2011-06-03 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Creating <animateMotion> elements via javascript do not execute
https://bugs.webkit.org/show_bug.cgi?id=34301

Update test results.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • svg/custom/global-constructors-expected.txt:

2011-06-03 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

Creating <animateMotion> elements via javascript do not execute
https://bugs.webkit.org/show_bug.cgi?id=34301

Enable constructors for SVGMPathElement and SVGAnimateMotionElement.

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.idl:
8:37 AM BuildingQtOnLinux edited by siddharth.mathur@nokia.com
added note on ICU (diff)
8:02 AM Changeset in webkit [88019] by hans@chromium.org
  • 6 edits in trunk/Source

2011-06-03 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
https://bugs.webkit.org/show_bug.cgi?id=62009

This constant should only be needed inside IDBLevelDBCoding.cpp.

No new functionality, no new tests.

  • storage/IDBLevelDBBackingStore.cpp: (WebCore::getNewDatabaseId): (WebCore::IDBLevelDBBackingStore::getObjectStores): (WebCore::getNewObjectStoreId): (WebCore::IDBLevelDBBackingStore::deleteObjectStore): (WebCore::getNewIndexId):
  • storage/IDBLevelDBCoding.cpp: (WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encodeMaxKey): (WebCore::IDBLevelDBCoding::IndexFreeListKey::encodeMaxKey):
  • storage/IDBLevelDBCoding.h:

2011-06-03 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
https://bugs.webkit.org/show_bug.cgi?id=62009

Don't use INT64_MAX, use the various encodeMaxKey() functions instead.

  • tests/IDBLevelDBCodingTest.cpp: (IDBLevelDBCoding::TEST):
7:58 AM Changeset in webkit [88018] by bulach@chromium.org
  • 2 edits
    11 adds in trunk/LayoutTests

2011-06-03 Marcus Bulach <bulach@chromium.org>

Reviewed by Unreviewed rebaseline.

[chromium] Rebaseline following r88007-88008
https://bugs.webkit.org/show_bug.cgi?id=62018

  • platform/chromium-linux-x86/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/chromium-linux-x86/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/chromium-linux/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
  • platform/chromium-win/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/chromium-win/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
7:53 AM Changeset in webkit [88017] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88014.
http://trac.webkit.org/changeset/88014
https://bugs.webkit.org/show_bug.cgi?id=62017

Broken EFL build (Requested by tonikitoo on #webkit).

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload):
7:47 AM Changeset in webkit [88016] by commit-queue@webkit.org
  • 11 edits
    1 add in trunk/Source

2011-06-03 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] Build flag for experimental ICU library support
https://bugs.webkit.org/show_bug.cgi?id=60786

Adds a build-time flag (CONFIG+=use_system_icu) that enables experimental
ICU powered Unicode support.

  • JavaScriptCore.pri: Support for use_system_icu CONFIG flag.
  • wtf/unicode/qt4/UnicodeQt4.h: Guard an include file with USE(ICU_UNICODE).

2011-06-03 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Benjamin Poulain.

[Qt] Build flag for experimental ICU library support
https://bugs.webkit.org/show_bug.cgi?id=60786

Adds a build-time flag (CONFIG+=use_system_icu) that enables experimental
ICU powered Unicode support.

No new tests as no new features added.

  • WebCore.pri: Removed text_breaking_with_icu CONFIG flag.
  • WebCore.pro: Added TextCodecICU.cpp and qt/TextBreakIteratorInternalICUQt.cpp.
  • editing/qt/SmartReplaceQt.cpp:
  • features.pri: Support for use_system_icu CONFIG flag.
  • platform/text/TextCodecICU.cpp: Guard with USE(ICU_UNICODE).
  • platform/text/qt/TextBreakIteratorInternalICUQt.cpp: Added. (WebCore::Q_GLOBAL_STATIC_WITH_INITIALIZER): (WebCore::currentSearchLocaleID): (WebCore::currentTextBreakLocaleID):
  • platform/text/qt/TextBreakIteratorQt.cpp: Moved out currentTextBreakLocaleID(). (WebCore::isTextBreak):
  • platform/text/qt/TextCodecQt.cpp: Guard with USE(QT4_UNICODE). (WebCore::TextCodecQt::registerEncodingNames): (WebCore::TextCodecQt::registerCodecs):
7:39 AM Changeset in webkit [88015] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-03 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Draw DRT scroll bar thumb with CG when WebKit renders with Skia
https://bugs.webkit.org/show_bug.cgi?id=61534

Skia on Mac uses Skia to render WebKit, and CG
to render UI elements. The CG elements need a
transcribed graphics context that preserves the
canvas matrix, and the canvas clip.

The SkiaBitLocker utility class sets up a CGContext
from the SkCanvas, locks the bitmap's bits, and
releases the lock when the class goes out of scope.

The SkiaBitLocker implementation is described by
this patch:
http://codereview.chromium.org/7031006/

When WebKit uses Skia for rendering, the WebCanvas
is an SkCanvas. Create an equivalent CGContext to
draw the scrollbar thumb.

As the Chrome Mac port does not yet use Skia, this
patch has no effect and requires no tests.

  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
7:17 AM Changeset in webkit [88014] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Antonio Gomes.

[EFL] Implement startDownload() in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=61998

Implement startDownload() with download().

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::startDownload):
7:12 AM Changeset in webkit [88013] by abecsi@webkit.org
  • 2 edits in trunk/Tools

2011-06-03 Andras Becsi <abecsi@webkit.org>

Unreviewed build fix.

Fix typo.

  • Scripts/old-run-webkit-tests:
6:56 AM Changeset in webkit [88012] by abecsi@webkit.org
  • 3 edits in trunk/Tools

2011-06-03 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

Print error message when there is no httpd present on the system
https://bugs.webkit.org/show_bug.cgi?id=61939

  • Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
  • Scripts/webkitperl/httpd.pm:
6:47 AM Changeset in webkit [88011] by yael.aharon@nokia.com
  • 3 edits
    9 adds in trunk

2011-06-03 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491

  • fast/frames/flattening/iframe-flattening-out-of-view.html: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
  • fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
  • fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.

2011-06-03 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491

Do not flatten offscreen iframes during frame flattening, as flattening might make them visible.

Test: fast/frames/flattening/iframe-flattening-out-of-view.html

fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html
fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html

  • rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::flattenFrame):
6:29 AM Changeset in webkit [88010] by mnaganov@chromium.org
  • 19 edits
    2 adds in trunk

2011-06-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533

Skip cpu-profiler-profiling in debug, implement a fast headless alternative.

  • inspector/profiler/cpu-profiler-profiling-without-inspector-expected.txt: Added.
  • inspector/profiler/cpu-profiler-profiling-without-inspector.html: Added.
  • platform/chromium/test_expectations.txt:

2011-06-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533

Skip cpu-profiler-profiling in debug, implement a fast headless alternative.

  • public/WebDevToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::setJavaScriptProfilingEnabled):
  • src/WebDevToolsAgentImpl.h:

2011-06-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533

Skip cpu-profiler-profiling in debug, implement a fast headless alternative.

  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
  • DumpRenderTree/chromium/DRTDevToolsAgent.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setJavaScriptProfilingEnabled):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setJavaScriptProfilingEnabled):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

2011-06-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
https://bugs.webkit.org/show_bug.cgi?id=61533

Skip cpu-profiler-profiling in debug, implement a fast headless alternative.

  • WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp: (WKBundleInspectorSetJavaScriptProfilingEnabled):
  • WebProcess/InjectedBundle/API/c/WKBundleInspector.h:
  • WebProcess/WebPage/WebInspector.cpp: (WebKit::WebInspector::setJavaScriptProfilingEnabled):
  • WebProcess/WebPage/WebInspector.h:
5:43 AM Changeset in webkit [88009] by zimmermann@webkit.org
  • 3 edits
    9 adds in trunk

2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Incorrect embedded document replaced size calculation for box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=62007

When using <object style="box-sizing: border-box" data="foo.svg"/> to embed foo.svg
which has an intrinsic width/height, the embedded document intrinsic size is incorrect.

  • platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.png: Added.
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.txt: Added.
  • platform/mac/svg/as-object: Added.
  • platform/mac/svg/as-object/object-box-sizing-no-width-height-expected.png: Added.
  • platform/mac/svg/as-object/object-box-sizing-no-width-height-expected.txt: Added.
  • svg/as-image/img-preserveAspectRatio-support-2.html: Added.
  • svg/as-image/resources/circle-default-default.svg: Added.
  • svg/as-object: Added.
  • svg/as-object/object-box-sizing-no-width-height.html: Added.

2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Incorrect embedded document replaced size calculation for box-sizing: border-box
https://bugs.webkit.org/show_bug.cgi?id=62007

When using <object style="box-sizing: border-box" data="foo.svg"/> to embed foo.svg
which has an intrinsic width/height, the embedded document intrinsic size is incorrect.

RenderPart::computeEmbeddedDocumentReplacedWidth/Height has to ask the content renderer for the replaced width/height not ourselves.

Tests: svg/as-image/img-preserveAspectRatio-support-2.html

svg/as-object/object-box-sizing-no-width-height.html

  • rendering/RenderPart.cpp: (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth): (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight):
5:36 AM Changeset in webkit [88008] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

2011-06-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88004.
http://trac.webkit.org/changeset/88004
https://bugs.webkit.org/show_bug.cgi?id=62008

This patch broke 4 tests in the GTK bots (Requested by
msanchez on #webkit).

  • platform/gtk/accessibility/caret-browsing-anchor-followed-expected.txt: Removed.
  • platform/gtk/accessibility/caret-browsing-anchor-followed.html: Removed.

2011-06-03 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r88004.
http://trac.webkit.org/changeset/88004
https://bugs.webkit.org/show_bug.cgi?id=62008

This patch broke 4 tests in the GTK bots (Requested by
msanchez on #webkit).

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleScrolledToAnchor):
5:11 AM Changeset in webkit [88007] by zimmermann@webkit.org
  • 9 edits
    4 adds in trunk

2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Zooming <object style="width/height: auto" data="foo.svg"/> doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=62005

Zooming an object with auto size, that references a svg with fixed size was broken. The svg size stayed the same.
Added new tests covering this zooming.

  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
  • svg/zoom/page/resources/circle.svg: Added.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size.html: Added.

2011-06-03 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Zooming <object style="width/height: auto" data="foo.svg"/> doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=62005

Zooming an object with auto size, that references a svg with fixed size was broken. The svg size stayed the same.
Get rid of the dependency between RenderSVGRoot and SVGSVGElement::currentScale(), always ask for the effective
zoom in the RenderStyle instead of asking SVGSVGElement.

The SVGSVGElement::currentScale()/setCurrentScale() methods are now only used when called from the bindings (eg. JS).
They only take effect on the outermost <svg> element in standalone documents, otherwhise they are no-ops.

Test: svg/zoom/page/zoom-svg-through-object-with-auto-size.html

  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computeIntrinsicWidth): (WebCore::RenderSVGRoot::computeIntrinsicHeight): (WebCore::RenderSVGRoot::localToBorderBoxTransform):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale):
  • svg/SVGSVGElement.h:
5:04 AM Changeset in webkit [88006] by alexis.menard@openbossa.org
  • 4 edits in trunk

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957

When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks. We need to append in both case because qmake behave differently
when called with -spec or via SUBDIR+=.

  • Source/WebKit.pri:

2011-06-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957

When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks. We need to append in both case because qmake behave differently
when called with -spec or via SUBDIR+=. This patch unbreak r87950 on Mac for Qt port.

4:20 AM Changeset in webkit [88005] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt][WK2] Update platform specific expected file after r87873.

  • platform/qt-wk2/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
4:10 AM Changeset in webkit [88004] by mario@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

Focus and caret position should be updated when same-page links are followed
https://bugs.webkit.org/show_bug.cgi?id=59737

Update the caret position to the anchor's position after scrolling.

This behavior is specific to the Gtk port and requested because of
accessibility needs, that's why it's implemented in AXObjectCache.

Test: platform/gtk/accessibility/caret-browsing-anchor-followed.html

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleScrolledToAnchor): Make sure the caret is updated to be in the anchor's position after scrolling.

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Martin Robinson.

Focus and caret position should be updated when same-page links are followed
https://bugs.webkit.org/show_bug.cgi?id=59737

New layout test for testing this GTK-specific feature.

  • platform/gtk/accessibility/caret-browsing-anchor-followed-expected.txt: Added.
  • platform/gtk/accessibility/caret-browsing-anchor-followed.html: Added.
3:44 AM Changeset in webkit [88003] by tonyg@chromium.org
  • 13 edits in branches/chromium/782

Merge 87802 - 2011-06-01 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Renaming the Page Visibility attributes as per the modified spec draft.
https://bugs.webkit.org/show_bug.cgi?id=61825

Spec draft:
http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html

  • Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
  • The attribute webkitIsVisible needs to change to webkitHidden
  • fast/events/page-visibility-iframe-delete-test.html:
  • fast/events/page-visibility-iframe-move-test-expected.txt:
  • fast/events/page-visibility-iframe-move-test.html:
  • fast/events/page-visibility-iframe-propagation-test-expected.txt:
  • fast/events/page-visibility-iframe-propagation-test.html:
  • fast/events/page-visibility-transition-test-expected.txt:
  • fast/events/page-visibility-transition-test.html:

2011-06-01 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Renaming the Page Visibility attributes as per the modified spec draft.
https://bugs.webkit.org/show_bug.cgi?id=61825

Spec draft:
http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html

  • Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
  • The attribute webkitIsVisible needs to change to webkitHidden
  • dom/Document.cpp: (WebCore::Document::webkitHidden): (WebCore::Document::dispatchVisibilityStateChangeEvent):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/EventNames.h:

BUG=84840
TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/7065057

3:35 AM Changeset in webkit [88002] by dominicc@chromium.org
  • 4 edits
    2 adds in trunk

2011-06-03 Dominic Cooney <dominicc@chromium.org>

Reviewed by Kent Tamura.

Adds a test that keygen clones have the right shadow pseudoclass.
https://bugs.webkit.org/show_bug.cgi?id=61984

  • fast/html/clone-keygen-expected.txt: Added.
  • fast/html/clone-keygen.html: Added.
  • platform/win/Skipped: Test needs DRT functionality not in this port.

2011-06-03 Dominic Cooney <dominicc@chromium.org>

Reviewed by Kent Tamura.

Cloned keygen shadows should have -webkit-keygen-select pseudoclass.
https://bugs.webkit.org/show_bug.cgi?id=61984

When cloneNode's tag name-based cloning algorithm clones the
KeygenSelectElements of a keygen shadow as select elements. These
lack the -webkit-keygen-select pseudoclass.

Test: fast/html/clone-keygen.html

  • html/HTMLKeygenElement.cpp: (WebCore::KeygenSelectElement::cloneElementWithoutAttributesAndChildren): Create a KeygenSelectElement when being cloned.
3:31 AM Changeset in webkit [88001] by morrita@google.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

2011-06-02 MORITA Hajime <morrita@google.com>

Unreviewed ChangeLog fix.

3:08 AM Changeset in webkit [88000] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping test with different results in 32-bit and 64-bit.

  • platform/gtk/Skipped: Skipped test.
3:05 AM Changeset in webkit [87999] by sergio@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-06-03 Sergio Villar Senin <svillar@igalia.com>

Reviewed by Martin Robinson.

[GTK] Unref the SoupSession used by WebKitGtk+ at exit
https://bugs.webkit.org/show_bug.cgi?id=60165

WebKitGtk+ creates a SoupSession instance to handle network stuff
that is never freed. We should unref that object at exit time.

  • webkit/webkitglobals.cpp: (webkitExit): (webkitInit):
2:53 AM Changeset in webkit [87998] by Csaba Osztrogonác
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Update platform specific expected files after r87873.

  • platform/qt/fast/events/overflow-viewport-renderer-deleted-expected.txt: Added.
  • platform/qt/plugins/document-open-expected.txt: Added.
1:57 AM Changeset in webkit [87997] by pvarga@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt][V8] build fix.

1:36 AM Changeset in webkit [87996] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed. Test rebaseline for GTK after revision 87936.

  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
1:36 AM Changeset in webkit [87995] by dominicc@chromium.org
  • 4 edits
    2 adds in trunk

2011-06-03 Dominic Cooney <dominicc@chromium.org>

Reviewed by Kent Tamura.

Adds a test that range input clones have the right kind of slider.
https://bugs.webkit.org/show_bug.cgi?id=61982

  • fast/html/clone-range-expected.txt: Added.
  • fast/html/clone-range.html: Added.
  • platform/win/Skipped: Test needs DRT functionality not in this port.

2011-06-03 Dominic Cooney <dominicc@chromium.org>

Reviewed by Kent Tamura.

Cloned range input sliders should be SliderThumbElements, not divs.
https://bugs.webkit.org/show_bug.cgi?id=61982

Test: fast/html/clone-range.html

  • html/shadow/SliderThumbElement.h: (WebCore::SliderThumbElement::cloneElementWithoutAttributesAndChildren): Create a SliderThumbElement when being cloned.
1:22 AM Changeset in webkit [87994] by Laszlo Gombos
  • 2 edits in trunk/LayoutTests

2011-06-03 Laszlo Gombos <Laszlo Gombos>

Reviewed by Csaba Osztrogonác.

[Qt] Organize the disabled features section in the Skipped list
https://bugs.webkit.org/show_bug.cgi?id=61994

Move all the tests for disabled features under the "Disabled
features" section in the Skipped list. Use the name of the build flags to
identify the features for better tracking.

  • platform/qt/Skipped:
12:47 AM Changeset in webkit [87993] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, unskipping tests, now passing after reverting r87901.

  • platform/gtk/Skipped: Unskipped 3 tests.
12:23 AM Changeset in webkit [87992] by yurys@chromium.org
  • 12 edits in trunk/Source

2011-06-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add an option for automatically attaching to new workers
https://bugs.webkit.org/show_bug.cgi?id=61930

Worker list is extended with a checkbox that makes inspector attach to each
new worker. Whenever a new worker context starts a new inspector window will
be opened for it.

Also worker agent and worker list will be updated when worker context is terminated.

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController):
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::workerContextTerminatedImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::workerContextTerminated):
  • inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::create): (WebCore::InspectorWorkerAgent::InspectorWorkerAgent): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::setAutoconnectToWorkers): (WebCore::InspectorWorkerAgent::didStartWorkerContext): (WebCore::InspectorWorkerAgent::workerContextTerminated):
  • inspector/InspectorWorkerAgent.h:
  • inspector/front-end/WorkerManager.js: (WebInspector.WorkerManager.prototype._workerCreated): (WebInspector.WorkerManager.prototype._workerTerminated): (WebInspector.WorkerManager.prototype.openWorkerInspector): (WebInspector.WorkerManager.prototype._openInspectorWindow): (WebInspector.WorkerManager.prototype.reset): (WebInspector.WorkerMessageForwarder.prototype.workerCreated): (WebInspector.WorkerMessageForwarder.prototype.workerTerminated):
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkerListSidebarPane): (WebInspector.WorkerListSidebarPane.prototype._workerAdded): (WebInspector.WorkerListSidebarPane.prototype._workerRemoved): (WebInspector.WorkerListSidebarPane.prototype._workersCleared): (WebInspector.WorkerListSidebarPane.prototype._addWorker): (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked): (WebInspector.WorkerListSidebarPane.prototype._autoattachToWorkersClicked):
  • inspector/front-end/inspector.js: (WebInspector.reset):

2011-06-02 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: add an option for automatically attaching to new workers
https://bugs.webkit.org/show_bug.cgi?id=61930

Notification about worker context termination are now sent to the inspector.

  • src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::terminateWorkerContext): (WebKit::WebWorkerClientImpl::disconnectFromInspector): (WebKit::WebWorkerClientImpl::workerContextDestroyed):

Jun 2, 2011:

10:17 PM Changeset in webkit [87991] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-02 Hayato Ito <hayato@chromium.org>

Reviewed by Ryosuke Niwa.

Show a shadow root node itself in Node::traverseNextNodeAcrossFrame.
https://bugs.webkit.org/show_bug.cgi?id=61992

It's better to show a shadow root node itself for debugging.
Skipping it didn't add any values.

No new tests since the function is only available in debug builds.

  • dom/Node.cpp: (WebCore::traverseNextNodeAcrossFrame):
8:12 PM Changeset in webkit [87990] by jamesr@google.com
  • 4 edits in trunk/Source/WebCore

2011-06-02 James Robinson <jamesr@chromium.org>

Unreviewed, rolling out r87901.
http://trac.webkit.org/changeset/87901
https://bugs.webkit.org/show_bug.cgi?id=61894

Might be responsible for performance regression on Chromium page cyclers, reverting to see...

  • loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad): (WebCore::DocumentLoader::haveToldClientAboutLoad):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache):
  • loader/ResourceLoadNotifier.cpp: (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
7:41 PM Changeset in webkit [87989] by leviw@chromium.org
  • 32 edits in trunk/Source/WebCore

2011-06-02 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintReplaced to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61891

Switching paintReplaced to use IntPoint to represent the paint offset instead
of a pair of ints.

Also renaming the IntPoint flavor of IntRect::move to moveBy to clear up the
fact that the IntPoint is added as an offset as opposed to being relocated
to that point.

No tests because this is just a refactoring.

  • page/FrameView.cpp: (WebCore::FrameView::invalidateScrollbarRect): (WebCore::FrameView::convertFromRenderer): (WebCore::FrameView::convertToRenderer):
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::invalidatePart):
  • platform/graphics/gpu/Texture.cpp (WebCore::Texture::updateSubRect)
  • platform/graphics/IntRect.h: (WebCore::IntRect::moveBy):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::logicalRectToPhysicalRect): (WebCore::RenderBlock::selectionGaps):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::localCaretRect):
  • rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::paint):
  • rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paintReplaced):
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced):
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
  • rendering/RenderImage.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
  • rendering/RenderLayer.cpp: (WebCore::expandClipRectForDescendantsAndReflection): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::paintChildLayerIntoColumns): (WebCore::RenderLayer::hitTestChildLayerColumns): (WebCore::RenderLayer::boundingBox): (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::paintScrollbar): (WebCore::RenderLayerBacking::paintContents):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::layerWillBeRemoved): (WebCore::paintScrollbar): (WebCore::RenderLayerCompositor::paintContents):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::controlClipRect):
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderReplaced.h: (WebCore::RenderReplaced::paintReplaced):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::computeRectForRepaint):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::controlClipRect):
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::paintReplaced):
  • rendering/RenderVideo.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle):
7:34 PM Changeset in webkit [87988] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-02 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

[chromium][V8] Add trace events for timer fires and event listener dispatches
https://bugs.webkit.org/show_bug.cgi?id=61977

Adds TRACE_EVENT macro around timer and event listener dispatches. When tracing (a chromium feature) is
enabled, this allows correlating these events with painting, compositing, and everything else in chromium that
is traced. When tracing is disabled, this macro does nothing useful. Trace points are very cheap when tracing
is disabled so this should have no performance impact for non-developers.

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/v8/V8EventListener.cpp: (WebCore::V8EventListener::callListenerFunction):
7:10 PM Changeset in webkit [87987] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-02 John Bates <jbates@google.com>

Reviewed by James Robinson.

DrawingBufferChromium cleanup:

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::DrawingBuffer): (WebCore::DrawingBuffer::~DrawingBuffer): (WebCore::DrawingBuffer::publishToPlatformLayer): (WebCore::DrawingBuffer::didReset): (WebCore::DrawingBuffer::platformLayer):
  • platform/graphics/gpu/DrawingBuffer.h:
6:50 PM Changeset in webkit [87986] by Lucas Forschler
  • 7 edits in branches/safari-534-branch/Source/WebKit2

Merge r87945.

6:48 PM Changeset in webkit [87985] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87857.

6:46 PM Changeset in webkit [87984] by Lucas Forschler
  • 5 edits in branches/safari-534-branch/Source/WebCore

Merge r87856.

6:44 PM Changeset in webkit [87983] by caio.oliveira@openbossa.org
  • 3 edits in trunk/Source/WebKit/qt

2011-06-02 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix enum order in qwebpage.h public API header
https://bugs.webkit.org/show_bug.cgi?id=61959

Since qwebpage.h is a public header, we can't change the values of
the enumerations. This patch moves the new enumeration to the end
of the list. As a bonus, adds a missing entry in
editorCommandWebActions table.

  • Api/qwebpage.cpp:
  • Api/qwebpage.h:
6:44 PM Changeset in webkit [87982] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-534-branch

Merge r87844.

6:21 PM Changeset in webkit [87981] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-02 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: ResourceCookiesView.resize() is missing
https://bugs.webkit.org/show_bug.cgi?id=61868

  • inspector/front-end/ResourceCookiesView.js: (WebInspector.ResourceCookiesView.prototype.resize):
6:15 PM Changeset in webkit [87980] by tkent@chromium.org
  • 8 edits
    2 adds in trunk

2011-06-02 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r87014): Cloned text <input> doesn't work well.
https://bugs.webkit.org/show_bug.cgi?id=61909

  • fast/forms/textfield-clone-expected.txt: Added.
  • fast/forms/textfield-clone.html: Added.

2011-06-02 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

REGRESSION(r87014): Cloned text <input> doesn't work well.
https://bugs.webkit.org/show_bug.cgi?id=61909

The default implementation of Element::cloneNode() creates a clone
node by Document::createElement(). So, if a customized class is used for
shadow nodes, cloneNode() doesn't create a node of the correct class.

Such custom classes need to override Element
cloneElementWithoutAttributesAndChildren().

TextFieldInputType and SearchInputType had references to shadow nodes
initialized in createShadowSubtree(). However createShadowSubtree() is
not called if the host node is cloned. The accessors for shadow nodes
should search a shadow tree.

Test: fast/forms/textfield-clone.html

  • html/SearchInputType.cpp: Remove data members for shadow nodes, and the accessors search the shadow tree for the requested node by TreeScope::getElementById(). (WebCore::SearchInputType::SearchInputType): (WebCore::innerBlockId): (WebCore::resultButtonId): (WebCore::cancelButtonId): (WebCore::SearchInputType::createShadowSubtree): (WebCore::SearchInputType::innerBlockElement): (WebCore::SearchInputType::resultsButtonElement): (WebCore::SearchInputType::cancelButtonElement):
  • html/SearchInputType.h:
  • html/TextFieldInputType.cpp: ditto. (WebCore::TextFieldInputType::TextFieldInputType): (WebCore::TextFieldInputType::innerTextId): (WebCore::spinButtonId): (WebCore::TextFieldInputType::speechButtonId): (WebCore::TextFieldInputType::appendChildAndSetId): (WebCore::TextFieldInputType::createShadowSubtree): (WebCore::TextFieldInputType::getShadowElementById): (WebCore::TextFieldInputType::innerTextElement): (WebCore::TextFieldInputType::innerSpinButtonElement): (WebCore::TextFieldInputType::speechButtonElement):
  • html/TextFieldInputType.h:
  • html/shadow/TextControlInnerElements.cpp: Overrides cloneElementWithoutAttributesAndChildren() in order that cloneNode() produces an instance of the correct class. (WebCore::TextControlInnerElement::cloneElementWithoutAttributesAndChildren): (WebCore::TextControlInnerTextElement::cloneElementWithoutAttributesAndChildren): (WebCore::SearchFieldResultsButtonElement::cloneElementWithoutAttributesAndChildren): (WebCore::SearchFieldCancelButtonElement::cloneElementWithoutAttributesAndChildren): (WebCore::SpinButtonElement::cloneElementWithoutAttributesAndChildren): (WebCore::InputFieldSpeechButtonElement::cloneElementWithoutAttributesAndChildren):
  • html/shadow/TextControlInnerElements.h:
6:13 PM Changeset in webkit [87979] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Adam Barth <abarth@webkit.org>

Tweaks to which kind of failure we expect.

  • platform/chromium/test_expectations.txt:
6:05 PM Changeset in webkit [87978] by mrobinson@webkit.org
  • 16 edits
    1 delete in trunk/Source

2011-05-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Remove PasteboardHelperGtk
https://bugs.webkit.org/show_bug.cgi?id=61690

Remove the virtual methods from PasteboardHelper, so that PasteboardHelperGtk
can be removed. Since the GtkClipboard IDs are verified to be the same between
WebKit and WebCore we no longer need to communicate from WebCore to WebKit to
get them.

No new tests. This is just a code refactor.

  • platform/Pasteboard.h: Remove GTK+ specific methods. They are no longer needed.
  • platform/gtk/ClipboardGtk.cpp: Remove the m_helper member and access the PasteboardHelper singleton directly.
  • platform/gtk/ClipboardGtk.h: Ditto.
  • platform/gtk/PasteboardGtk.cpp: Ditto.
  • platform/gtk/PasteboardHelper.cpp: (WebCore::removeMarkupPrefix): Remove an extra line. (WebCore::PasteboardHelper::defaultPasteboardHelper): Added this static getter for the singleton. (WebCore::PasteboardHelper::PasteboardHelper): Moved the contents of initTargetList here. (WebCore::PasteboardHelper::getCurrentClipboard): Instead of talking with WebKit to determine whether or not to use the primary selection clipboard, just use our new member. (WebCore::PasteboardHelper::fillSelectionData): Use our local enum to get the ID. (WebCore::PasteboardHelper::targetListForDataObject): Ditto. (WebCore::PasteboardHelper::dropAtomsForContext): Ditto. (WebCore::getClipboardContentsCallback): Ditto.
  • platform/gtk/PasteboardHelper.h: PasteboardHelper now keeps track of whether or not to use the primary selection clipboard internally. (WebCore::PasteboardHelper::setUsePrimarySelectionClipboard): Added. (WebCore::PasteboardHelper::usePrimarySelectionClipboard): Added.

2011-05-28 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Remove PastboardHelperGtk
https://bugs.webkit.org/show_bug.cgi?id=61690

Remove PasteboardHelperGtk and talk directly to WebCore for pasteboard
activity. This change moves the PasteboardHelper singleton from WebKit
to WebCore.

  • GNUmakefile.am: Remove PasteboardHelperGtk from the source list.
  • WebCoreSupport/AssertMatchingEnums.cpp: Added assertions verifying that the WebCore versions of the GtkClipboard enums match those in the WebKit API.
  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Access the pasteboard helper via a static method.
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::setSelectionPrimaryClipboardIfNeeded): Ditto. Call into the helper to specify that the current clipboard is selection primary now.
  • WebCoreSupport/PasteboardHelperGtk.cpp: Removed.
  • webkit/webkitglobals.cpp: Remove function to set and get the pasteboard helper.
  • webkit/webkitglobalsprivate.h: Ditto.
  • webkit/webkitwebview.cpp: (webkit_web_view_button_press_event): Access the pasteboard helper via a static method. (webkit_web_view_drag_data_get): Ditto. (webkit_web_view_drag_motion): Ditto. (webkit_web_view_drag_data_received): Ditto. (webkit_web_view_init): Ditto. (webkit_web_view_get_copy_target_list): Ditto. (webkit_web_view_get_paste_target_list): Ditto.
  • webkit/webkitwebviewprivate.h: Ditto.
5:57 PM Changeset in webkit [87977] by Lucas Forschler
  • 10 edits in branches/safari-534-branch

Merge r87826.

5:52 PM Changeset in webkit [87976] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-02 Adam Barth <abarth@webkit.org>

This process is converging (hopefully).

  • platform/chromium-mac/fast/backgrounds/svg-as-mask-expected.png: Added.
5:50 PM Changeset in webkit [87975] by Lucas Forschler
  • 4 edits in branches/safari-534-branch/Source

Merge r87768.

5:48 PM Changeset in webkit [87974] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebKit2

Merge r87804.

5:46 PM Changeset in webkit [87973] by Lucas Forschler
  • 12 edits in branches/safari-534-branch/Source/WebKit2

Merge r87755.

5:44 PM Changeset in webkit [87972] by abarth@webkit.org
  • 3 edits
    1 delete in trunk/LayoutTests

2011-06-02 Adam Barth <abarth@webkit.org>

Some more fallout from http://trac.webkit.org/changeset/87955, this time on Windows.

  • platform/chromium-win-vista/fast/forms/validation-message-appearance-expected.png: Removed.
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
5:44 PM Changeset in webkit [87971] by Lucas Forschler
  • 3 edits in branches/safari-534-branch/Source/WebCore

Merge r87704.

5:42 PM Changeset in webkit [87970] by Lucas Forschler
  • 2 edits in branches/safari-534-branch/Source/WebCore

Merge r87703.

5:30 PM Changeset in webkit [87969] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Adam Barth <abarth@webkit.org>

This test is flaky on Linux.

  • platform/chromium/test_expectations.txt:
5:28 PM Changeset in webkit [87968] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-06-02 Anders Carlsson <andersca@apple.com>

Reviewed by Mark Rowe.

Assert when trying to unload a module that failed to load
https://bugs.webkit.org/show_bug.cgi?id=61980

Remove an invalid ASSERT; it's OK for m_bundle to be null if the bundle failed to load.

  • Platform/mac/ModuleMac.mm: (WebKit::Module::unload):
5:21 PM Changeset in webkit [87967] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-06-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

NRWT needs a way to log to a file without including backspaces without needing --verbose
https://bugs.webkit.org/show_bug.cgi?id=60328

This change modifies NRWT so that if it can tell if it is
writing to a terminal, it will overwrite any messages printed
in the 'one-line-progress' and 'updates' print options, and if
not (or if --verbose was specified) the messages will be printed
without backspaces.

If the overwriting updates are disabled, one-line-progress will
only print every 10 seconds instead of on every update. This
ensures that we still get updates once in a while while the
tests are running, even if we're not in --verbose mode. Note
that one-line-progress will now still be printed in --verbose,
since it's useful as long as you're not flooded with the
updates.

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
5:16 PM Changeset in webkit [87966] by abarth@webkit.org
  • 15 edits
    49 adds
    1 delete in trunk/LayoutTests

2011-06-02 Adam Barth <abarth@webkit.org>

The next round of updated baselines after
http://trac.webkit.org/changeset/87955. Again, these all look fine to
visual inspection.

  • platform/chromium-mac-leopard/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/background-leakage-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/svg-as-background-1-expected.png:
  • platform/chromium-mac/fast/backgrounds/svg-as-mask-expected.png: Removed.
  • platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-mac/fast/blockflow/border-styles-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/border-styles-vertical-rl-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-circle-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-different-width-001-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-groove-01-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-groove-02-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-groove-03-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-inset-outset-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-02-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-03-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-wide-border-04-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-styles-split-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusDashed05-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDashed06-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDotted02-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDotted03-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDotted04-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDotted05-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusDouble04-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDouble05-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDouble06-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDouble07-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDouble08-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDouble09-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.png: Added.
  • platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png: Added.
  • platform/chromium-mac/fast/borders/mixed-border-styles-radius2-expected.png: Added.
  • platform/chromium-mac/fast/borders/webkit-border-radius-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac/fast/box-shadow/shadow-tiling-artifact-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/spread-expected.png:
  • platform/chromium-mac/fast/css/border-radius-non-negative-expected.png: Added.
  • platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png: Added.
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png: Added.
  • platform/chromium-mac/fast/forms/basic-selects-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-separator-painting-expected.png: Added.
  • platform/chromium-mac/fast/forms/menulist-style-color-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-background-none-expected.png:
  • platform/chromium-mac/fast/forms/select-baseline-expected.png: Added.
  • platform/chromium-mac/fast/forms/select-empty-option-height-expected.png: Added.
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png: Added.
  • platform/chromium-mac/svg/carto.net/button-expected.png: Added.
5:01 PM Changeset in webkit [87965] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

2011-06-02 Aaron Colwell <acolwell@chromium.org>

Reviewed by David Levin.

Add mediaTimeForTimeValue() implementation.
https://bugs.webkit.org/show_bug.cgi?id=61555

  • public/WebMediaPlayer.h:
  • src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::mediaTimeForTimeValue):
  • src/WebMediaPlayerClientImpl.h:
4:49 PM Changeset in webkit [87964] by leviw@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-06-02 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Teach InlineBox about FloatPoint
https://bugs.webkit.org/show_bug.cgi?id=44412

Original patch by Eric Seidel. Updated by me.

This is another step towards more point/size
usage throughout the rendering tree.

Added left(), right(), top(), and bottom() methods
to InlineBox. Removed m_x, and m_y and replaced them
with a single m_topLeft member.

No new tests since this is just a refactoring.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint): (WebCore::EllipsisBox::selectionRect): (WebCore::EllipsisBox::paintSelection): (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox):
  • rendering/InlineBox.cpp: (WebCore::InlineBox::adjustPosition): (WebCore::InlineBox::canAccommodateEllipsis):
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::setX): (WebCore::InlineBox::x): (WebCore::InlineBox::left): (WebCore::InlineBox::setY): (WebCore::InlineBox::y): (WebCore::InlineBox::top): (WebCore::InlineBox::topLeft): (WebCore::InlineBox::right): (WebCore::InlineBox::bottom): (WebCore::InlineBox::logicalLeft): (WebCore::InlineBox::setLogicalLeft): (WebCore::InlineBox::logicalTop): (WebCore::InlineBox::setLogicalTop): (WebCore::InlineBox::logicalFrameRect):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::frameRectIncludingLineHeight):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::computeRectForReplacementMarker):
  • rendering/RenderText.cpp: (WebCore::RenderText::firstRunX): (WebCore::RenderText::firstRunY):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeTextRun):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::placeEllipsis):
  • rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::positionForPoint):
  • rendering/svg/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::selectionTop):
  • rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::closestLeafChildForPosition):
4:45 PM Changeset in webkit [87963] by abarth@webkit.org
  • 130 edits
    68 adds
    3 deletes in trunk/LayoutTests

2011-06-02 Adam Barth <abarth@webkit.org>

First round of baseline updates after
http://trac.webkit.org/changeset/87955 changed some floating point
calculations for borders. Visually, these appear to all be fine.

  • platform/chromium-gpu-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-gpu-win/media/video-zoom-controls-expected.png:
  • platform/chromium-linux-x86/fast/backgrounds: Added.
  • platform/chromium-linux-x86/fast/backgrounds/border-radius-split-background-expected.png: Added.
  • platform/chromium-linux-x86/fast/backgrounds/border-radius-split-background-image-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-radius-constraints-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-linux-x86/fast/borders/borderRadiusSolid04-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/different-color-borders-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/fieldsetBorderRadius-expected.png: Added.
  • platform/chromium-linux-x86/fast/box-shadow/inset-box-shadows-expected.png: Added.
  • platform/chromium-linux-x86/fast/box-shadow/inset-expected.png: Added.
  • platform/chromium-linux-x86/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-linux-x86/fast/box-shadow/spread-multiple-inset-expected.png: Added.
  • platform/chromium-linux-x86/fast/clip: Added.
  • platform/chromium-linux-x86/fast/clip/overflow-border-radius-clip-expected.png: Added.
  • platform/chromium-linux-x86/fast/css/nested-rounded-corners-expected.png: Added.
  • platform/chromium-linux-x86/fast/repaint/border-radius-repaint-expected.png:
  • platform/chromium-linux-x86/fast/transforms: Added.
  • platform/chromium-linux-x86/fast/transforms/shadows-expected.png: Added.
  • platform/chromium-linux-x86/media: Added.
  • platform/chromium-linux-x86/media/video-zoom-controls-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/dasharrayOrigin-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/fractional-rects-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/gradient-rotated-bbox-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/rounded-rects-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/svg-fonts-in-html-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/perf/001-expected.png:
  • platform/chromium-linux-x86/svg/hixie/perf/002-expected.png:
  • platform/chromium-linux-x86/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-linux/fast/backgrounds/border-radius-split-background-expected.png:
  • platform/chromium-linux/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid04-expected.png:
  • platform/chromium-linux/fast/borders/different-color-borders-expected.png:
  • platform/chromium-linux/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-linux/fast/clip/overflow-border-radius-clip-expected.png:
  • platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
  • platform/chromium-linux/svg/custom/dasharrayOrigin-expected.png:
  • platform/chromium-linux/svg/custom/fractional-rects-expected.png:
  • platform/chromium-linux/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/chromium-linux/svg/custom/rounded-rects-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-linux/svg/hixie/perf/001-expected.png:
  • platform/chromium-linux/svg/hixie/perf/002-expected.png:
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/chromium-mac-leopard/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-mac-leopard/fast/repaint/border-radius-repaint-expected.png: Added.
  • platform/chromium-mac-leopard/fast/transforms/shadows-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/perf: Added.
  • platform/chromium-mac-leopard/svg/hixie/perf/001-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-mac/fast/backgrounds/border-radius-split-background-expected.png:
  • platform/chromium-mac/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-constraints-expected.png: Added.
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDashed02-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDashed03-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDotted01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDouble01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.png: Added.
  • platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.png: Added.
  • platform/chromium-mac/fast/borders/different-color-borders-expected.png: Added.
  • platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-mac/fast/box-shadow/inset-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-mac/fast/clip: Added.
  • platform/chromium-mac/fast/clip/overflow-border-radius-clip-expected.png: Added.
  • platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-mac/fast/repaint/border-radius-repaint-expected.png: Added.
  • platform/chromium-mac/fast/transforms/shadows-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
  • platform/chromium-mac/svg/custom/dasharrayOrigin-expected.png:
  • platform/chromium-mac/svg/custom/fractional-rects-expected.png: Added.
  • platform/chromium-mac/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/chromium-mac/svg/custom/rounded-rects-expected.png: Added.
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac/svg/hixie/perf/001-expected.png:
  • platform/chromium-mac/svg/hixie/perf/002-expected.png:
  • platform/chromium-mac/svg/wicd: Added.
  • platform/chromium-mac/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
  • platform/chromium-win-vista/svg/wicd/rightsizing-grid-expected.png: Removed.
  • platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.png: Removed.
  • platform/chromium-win-xp/fast/transforms/shadows-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/border-radius-split-background-expected.png:
  • platform/chromium-win/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium-win/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid04-expected.png:
  • platform/chromium-win/fast/borders/different-color-borders-expected.png:
  • platform/chromium-win/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
  • platform/chromium-win/fast/clip/overflow-border-radius-clip-expected.png:
  • platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
  • platform/chromium-win/svg/custom/dasharrayOrigin-expected.png:
  • platform/chromium-win/svg/custom/fractional-rects-expected.png:
  • platform/chromium-win/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/chromium-win/svg/custom/rounded-rects-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/svg/hixie/perf/001-expected.png:
  • platform/chromium-win/svg/hixie/perf/002-expected.png:
  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.txt: Added.
4:02 PM Changeset in webkit [87962] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit/mac

2011-06-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Need a way to install the memory pressure handler without initializing WebKit1
https://bugs.webkit.org/show_bug.cgi?id=61975

Add a WebInstallMemoryPressureHandler function which will install the memory pressure handler.
-[WebView WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:] will do this,
but we'd like to be able to install a memory pressure handler without creating a WebView or even
calling any WebView method since that will call +[WebView initialize].

  • WebKit.exp:
  • WebView/WebView.mm: (WebInstallMemoryPressureHandler):
  • WebView/WebViewPrivate.h:
3:26 PM Changeset in webkit [87961] by jianli@chromium.org
  • 20 edits
    2 copies in trunk

Update the behavior of multiple reads for FileReader
https://bugs.webkit.org/show_bug.cgi?id=61793

Reviewed by David Levin.

Source/WebCore:

Changed to throw an OperationNotAllowedException with the NOT_ALLOWED_ERR
status code on any of the read methods that occur when readyState = LOADING.
Otherwise, calling any of the read methods should work.

Test: fast/files/read-file-async.html

  • CodeGenerators.pri:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • dom/ExceptionCode.cpp:

(WebCore::getExceptionCodeDescription):

  • dom/ExceptionCode.h:
  • fileapi/FileReader.cpp:

(WebCore::FileReader::FileReader):
(WebCore::FileReader::hasPendingActivity):
(WebCore::FileReader::readAsArrayBuffer):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::abort):
(WebCore::FileReader::doAbort):
(WebCore::FileReader::terminate):
(WebCore::FileReader::start):
(WebCore::FileReader::didStartLoading):
(WebCore::FileReader::didFinishLoading):
(WebCore::FileReader::didFail):

  • fileapi/FileReader.h:

(WebCore::FileReader::readyState):

  • fileapi/FileReader.idl:
  • fileapi/OperationNotAllowedException.h: Added.

(WebCore::OperationNotAllowedException::create):
(WebCore::OperationNotAllowedException::OperationNotAllowedException):

  • fileapi/OperationNotAllowedException.idl: Added.

LayoutTests:

Added test cases to cover calling read methods multiple times.

  • fast/files/read-file-async-expected.txt:
  • fast/files/resources/read-file-test-cases.js:

(ensureInitialized):
(runNextTest):
(testMultipleReads):
(testReuseReaderStep1):
(testReuseReaderStep2):

  • fast/files/workers/worker-read-file-async-expected.txt:
3:14 PM Changeset in webkit [87960] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-02 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
https://bugs.webkit.org/show_bug.cgi?id=61954

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp: (WebCore::CCHeadsUpDisplay::draw):
3:03 PM Changeset in webkit [87959] by beidson@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/9539920> and https://bugs.webkit.org/show_bug.cgi?id=61950
Repro crash loading certain webarchives after r87566.

Reviewed by Oliver Hunt.

Source/WebCore:

Test: webarchive/loading/javascript-url-iframe-crash.html

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL): DocumentWriter::replaceDocument can

cause the DocumentLoader to be destroyed, so protect it with a Ref here.

LayoutTests:

  • webarchive/loading/javascript-url-iframe-crash-expected.txt: Added.
  • webarchive/loading/javascript-url-iframe-crash.html: Added.
  • webarchive/loading/resources/javascript-url-iframe-crash.webarchive: Added.
2:59 PM Changeset in webkit [87958] by jcivelli@chromium.org
  • 12 edits in trunk/Source

2011-06-02 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Added a method to generate RFC 2822 compliant date strings.
https://bugs.webkit.org/show_bug.cgi?id=7169

  • wtf/DateMath.cpp: (WTF::twoDigitStringFromNumber): (WTF::makeRFC2822DateString):
  • wtf/DateMath.h:

2011-06-02 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML generation support to MHTMLArchive.
https://bugs.webkit.org/show_bug.cgi?id=7169

  • loader/archive/mhtml/MHTMLArchive.cpp: (WebCore::generateRandomBoundary): (WebCore::replaceNonPrintableCharacters): (WebCore::MHTMLArchive::generateMHTMLData):
  • loader/archive/mhtml/MHTMLArchive.h:
  • page/PageSerializer.cpp: (WebCore::PageSerializer::serializeFrame): (WebCore::PageSerializer::serializeCSSStyleSheet):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::append):
  • platform/SharedBuffer.h:

2011-06-02 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML generation support to MHTMLArchive.
https://bugs.webkit.org/show_bug.cgi?id=7169

  • public/WebPageSerializer.h:
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serializeToMHTML):
2:50 PM Changeset in webkit [87957] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

2011-06-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] autogen.sh is run twice for each buld on the bots
https://bugs.webkit.org/show_bug.cgi?id=61951

  • Scripts/webkitdirs.pm: Only check the previous autotools arguments for the WebKit project. This prevents build-jsc runs from forcing subsequent build-webkit runs to re-rerun autogen.sh.
2:45 PM Changeset in webkit [87956] by tony@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-06-02 Tony Chang <tony@chromium.org>

[chromium] mark media/audio-delete-while-slider-thumb-clicked.html as passing
https://bugs.webkit.org/show_bug.cgi?id=61967

This test is passing now that we get proper click events on the
slider and we no longer use absolute positions on the slider. The
test was updated in r78562 while it was disabled, so the chromium
results were stale (thus I'm deleting them).

  • platform/chromium-win/media/audio-delete-while-slider-thumb-clicked-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
2:43 PM Changeset in webkit [87955] by simon.fraser@apple.com
  • 3 edits in trunk/Source/WebCore

2011-06-02 Simon Fraser <simon.fraser@apple.com>

Reviewed by Andreas Kling.

Share Path code that uses beziers to construct a rounded rect
https://bugs.webkit.org/show_bug.cgi?id=61960

Have two methods in Path that construct beziers for rounded
rects to share the same code.

Make gCircleControlPoint a little more precise, and add
a comment describing its derivation.

Make use of FloatRect::maxX() and maxY().

  • platform/graphics/Path.cpp: (WebCore::Path::addRoundedRect): (WebCore::Path::addBeziersForRoundedRect):
  • platform/graphics/Path.h:
2:41 PM Changeset in webkit [87954] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Stephen White <senorblanco@chromium.org>

Reviewed by Andreas Kling.

Fix layout test compositing/images/direct-svg-image.html.
https://bugs.webkit.org/show_bug.cgi?id=61966


Change this test to get SVG resources from their new, post-r87782
location (svg/as-image).

  • compositing/images/direct-svg-image.html:
2:36 PM Changeset in webkit [87953] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87946.
http://trac.webkit.org/changeset/87946
https://bugs.webkit.org/show_bug.cgi?id=61965

Cause NRWT to break (Requested by abarth|gardener on #webkit).

  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
2:35 PM Changeset in webkit [87952] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-02 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Enrica Casucci.

ApplyStyleCommand shouldn't call collapseTextDecorationProperties
https://bugs.webkit.org/show_bug.cgi?id=61887

Removed the call to collapseTextDecorationProperties in ApplyStyleCommand::applyInlineStyle.

No new tests because this is a code refactoring.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): No loner calls collapseTextDecorationProperties. (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Updated comment.
  • editing/EditingStyle.cpp: (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Added to check both text-decoration and -webkit-text-decorations-in-effect. (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Added a comment. (WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle): Checks both text-decoration and -webkit-text-decorations-in-effect. (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Checks if a text decoration is present in -webkit-text-decorations-in-effect or text-decoration preferring the former. (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Merged loops for when conflictingProperties is false and true. Added a support for -webkit-text-decorations-in-effect.
2:29 PM Changeset in webkit [87951] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-02 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Make more functions static local in EventHandlers.cpp
https://bugs.webkit.org/show_bug.cgi?id=58503

Removed canHandleDragAndDropForTarget and made focusDirectionForKey local to EventHandler.cpp.

  • page/EventHandler.cpp: (WebCore::targetIsFrame): Extracted from canHandleDragAndDropForTarget. (WebCore::EventHandler::updateDragAndDrop): Calls contentFrameForTarget instead of canHandleDragAndDropForTarget. (WebCore::EventHandler::cancelDragAndDrop): Ditto. (WebCore::EventHandler::performDragAndDrop): Ditto. (WebCore::focusDirectionForKey): No longer a member function of EventHandler class. (WebCore::handleKeyboardSelectionMovement): No longer a member function of EventHandler class; also calls focusDirectionForKey instead of manually comparing.
  • page/EventHandler.h:
1:37 PM Changeset in webkit [87950] by alexis.menard@openbossa.org
  • 4 edits in trunk

2011-06-02 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957

When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks.

  • Source/WebKit.pri:

2011-06-02 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Build fix of QtWebKit 2.2 when inside Qt tree with GCC 4.6.
https://bugs.webkit.org/show_bug.cgi?id=61957

When building inside the Qt source tree, qmake always append the mkspecs
defines after ours. We have to workaround and make sure that we append
our flags after the qmake variable used inside Qt. This workaround was provided
by our qmake folks.

1:20 PM Changeset in webkit [87949] by alokp@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-02 Alok Priyadarshi <alokp@chromium.org>

Reviewed by James Robinson.

[chromium] Things jump around when selecting anything on the page
https://bugs.webkit.org/show_bug.cgi?id=61639

WebCore::LayerTextureUpdaterSkPicture::updateTextureRect was not updating a tile sub-region properly.
It did not consider dest-rect when selecting the clip and translation required to draw the content-rect into dest-rect.
Also removed clearing of framebuffer because it used to clear the whole tile not just dest-rect.
An appropriate viewport could be set to just clear the dest-rect, but it was debug only code and I did not want to mess
with the viewport set by skia.

No new tests. This case should be covered by most of the layout tests (pixel) targeting selection or hovering when chromium is run in compositing mode.
Here is a non-exhaustive list of existing tests covering this case.
Test: editing/selection/14971.html (existing)

editing/selection/3690703-2.html (existing)
editing/selection/4402375.html (existing)
editing/selection/4818145.html (existing)

  • platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp: (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect): (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
  • platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
1:15 PM Changeset in webkit [87948] by Dimitri Glazkov
  • 24 edits
    12 adds in trunk

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

  • fast/dom/Window/script-tests/window-property-descriptors.js: Added internals object to list of properties to skip.
  • fast/dom/Window/window-properties.html: Ditto.
  • fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
  • fast/dom/script-tests/prototype-inheritance.js: Ditto.
  • fast/harness/internals-object-expected.txt: Added.
  • fast/harness/internals-object.html: Added.
  • platform/gtk/Skipped: Skipped the newly added test until platform supports window.internals.
  • platform/mac-wk2/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

Test: fast/harness/internals-object.html

  • Configurations/WebCoreTestSupport.xcconfig: Added.
  • DerivedSources.make: Added support for generating from Internals.idl.
  • WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
  • testing/Internals.cpp: Added.
  • testing/Internals.h: Added.
  • testing/Internals.idl: Added.
  • testing/js/WebCoreTestSupport.cpp: Added.
  • testing/js/WebCoreTestSupport.h: Added.
  • testing/v8/WebCoreTestSupport.cpp: Added.
  • testing/v8/WebCoreTestSupport.h: Added.

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

  • WebKit.gyp: Added linking new webkit_test_support library.
  • public/WebTestingSupport.h: Added.
  • src/WebTestingSupport.cpp: Added.

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow): Added injection code.
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
1:01 PM Changeset in webkit [87947] by abarth@webkit.org
  • 5 edits
    1 add
    1 delete in trunk/LayoutTests

2011-06-02 Adam Barth <abarth@webkit.org>

More housekeep w.r.t. border-radius-clip.html. These new image results
look correct. The "replaced" version is the one with the failure.

  • platform/chromium-linux-x86/fast/overflow/border-radius-clipping-expected.png: Added.
  • platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png:
  • platform/chromium-mac-leopard/fast/overflow/border-radius-clipping-expected.png:
  • platform/chromium-mac/fast/overflow/border-radius-clipping-expected.png: Removed.
  • platform/chromium-win/fast/overflow/border-radius-clipping-expected.png:
  • platform/chromium/test_expectations.txt:
1:01 PM Changeset in webkit [87946] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-06-02 Hao Zheng <zhenghao@chromium.org>

Reviewed by Dirk Pranke.

Call cleanup() explicitly at the end of worker.run().
https://bugs.webkit.org/show_bug.cgi?id=61847

  • Scripts/webkitpy/layout_tests/layout_package/worker.py:
12:59 PM Changeset in webkit [87945] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-06-02 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

Add quirk for plug-ins that return a retained CALayer
https://bugs.webkit.org/show_bug.cgi?id=61948
<rdar://problem/9530390>

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks): Set the ReturnsRetainedCoreAnimationLayer quirk for Flash.
  • Shared/Plugins/PluginQuirks.h: Add ReturnsRetainedCoreAnimationLayer quirk.
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Handle WKNVExpectsNonretainedLayer by always returning true, and also call NetscapePlugin::setPluginReturnsNonretainedLayer(true) to add a way for plug-ins to opt into returning non-retained layers even if they have the quirk specified.
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp: (WebKit::NetscapePlugin::NetscapePlugin): Initialize m_pluginReturnsNonretainedLayer to true.
  • WebProcess/Plugins/Netscape/NetscapePlugin.h: (WebKit::NetscapePlugin::setPluginReturnsNonretainedLayer): Add setter.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: (WebKit::NetscapePlugin::platformPostInitialize): If m_pluginReturnsNonretainedLayer is false, adopt the layer.
12:58 PM Changeset in webkit [87944] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-02 Aaron Colwell <acolwell@chromium.org>

Reviewed by David Levin.

Update chromium version
https://bugs.webkit.org/show_bug.cgi?id=61555

  • DEPS:
12:54 PM Changeset in webkit [87943] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed WinCairo build correction.

  • UIProcess/win/WebView.cpp: Don't include CG file header

when building without CoreGraphics support.

12:45 PM Changeset in webkit [87942] by enne@google.com
  • 2 edits in trunk/Source/WebCore

2011-06-01 Adrienne Walker <enne@google.com>

Reviewed by Eric Seidel.

[chromium] LayerChromium should use a RefPtr for replica layer
https://bugs.webkit.org/show_bug.cgi?id=61898

Having this member variable be a raw pointer is brittle and assumes
that the GraphicsLayer tree keeps this in sync. There aren't any
known bugs caused by this, but it seems like good sense to do this.

  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::replicaLayer):
12:38 PM Changeset in webkit [87941] by abarth@webkit.org
  • 1 edit in trunk/Source/WebKit/chromium

Actually make the property change.

12:38 PM Changeset in webkit [87940] by abarth@webkit.org
  • 1 edit in trunk/Source/WebKit/ChangeLog

2011-06-02 Adam Barth <abarth@webkit.org>

Reviewed by Ryosuke Niwa.

Update svn:ignore property on Source/WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=61952

Add some more generated files and directories mapped in using DEPS to svn:ignore.

  • chromium: Modified property svn:ignore.
12:27 PM Changeset in webkit [87939] by abarth@webkit.org
  • 4 edits
    5 adds
    3 deletes in trunk/LayoutTests

2011-06-02 Adam Barth <abarth@webkit.org>

First cut at updating test expectations for Win 7.

  • platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt: Removed.
  • platform/chromium-win/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-win/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Removed.
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/chromium-win/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png: Added.
  • platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/chromium/test_expectations.txt:
12:10 PM Changeset in webkit [87938] by abarth@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2011-06-02 Adam Barth <abarth@webkit.org>

These differ only by the scroll bar.

  • platform/chromium-linux-x86/fast/css: Added.
  • platform/chromium-linux-x86/fast/css/last-of-type-pseudo-class-expected.png: Added.
  • platform/chromium-linux/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/chromium/test_expectations.txt:
12:07 PM Changeset in webkit [87937] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-02 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: inline style is lost when deleting line break between paragraphs with same style
https://bugs.webkit.org/show_bug.cgi?id=61899

Added a regression test to ensure WebKit preserves font family for a paragraph being merged
to the previous paragraph when deleting a line break between two paragraphs with the same style.

  • editing/deleting/delete-line-break-between-paragraphs-with-same-style-expected.txt: Added.
  • editing/deleting/delete-line-break-between-paragraphs-with-same-style.html: Added.

2011-06-02 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: inline style is lost when deleting line break between paragraphs with same style
https://bugs.webkit.org/show_bug.cgi?id=61899

The bug was caused by ReplaceSelectionCommand::doApply's calling handleStyleSpansBeforeInsertion
before insertionPos is adjusted by positionAvoidingPrecedingNodes and positionOutsideTabSpan.

Fixed the bug by calling handleStyleSpansBeforeInsertion after the calls to these two functions.

Test: editing/deleting/delete-line-break-between-paragraphs-with-same-style.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
12:05 PM Changeset in webkit [87936] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

2011-06-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Simon Fraser.

REGRESSION: Text selection broken for text with line-height applied
https://bugs.webkit.org/show_bug.cgi?id=54929

The bug was caused by RenderText::positionForPoint's not considering the case where a point is
above selectionTop and below lineTop of the first root inline box. Fixed the bug by considering
any point between selectionTop and lineTop to be inside a root inline box. This condition is
consistent with the condition we use to determine the bottom of a line.

Test: editing/selection/hit-test-on-text-with-line-height.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPointWithInlineChildren): Fixed a condition to determine whether or not a point is above the first root line box. We need to check both selectionTop and logicalTop for the same reason explained above.
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint): See above.

2011-06-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Simon Fraser.

REGRESSION: Text selection broken for text with line-height applied
https://bugs.webkit.org/show_bug.cgi?id=54929

Added a test to ensure WebKit can place caret in text with a line-height smaller than
the height of the text.

  • editing/selection/hit-test-on-text-with-line-height-expected.txt: Added.
  • editing/selection/hit-test-on-text-with-line-height.html: Added.
11:57 AM Changeset in webkit [87935] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Adam Barth <abarth@webkit.org>

This test actually fails as IMAGE not as IMAGE+TEXT.

  • platform/chromium/test_expectations.txt:
11:39 AM Changeset in webkit [87934] by abarth@webkit.org
  • 45 edits
    23 adds
    1 delete in trunk/LayoutTests

2011-06-02 Adam Barth <abarth@webkit.org>

New baselines for these tests. These only differ from the existing baselines by a handful of pixels.

  • platform/chromium-linux-x86/fast/borders/border-radius-huge-assert-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusAllStylesAllCorners-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusArcs01-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusDashed02-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusDashed03-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusDotted01-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusDouble01-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusDouble02-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusDouble03-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusGroove01-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusGroove02-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusInset01-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusInvalidColor-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusOutset01-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusRidge01-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusSolid01-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusSolid02-expected.png: Added.
  • platform/chromium-linux-x86/fast/borders/borderRadiusSolid03-expected.png: Added.
  • platform/chromium-linux-x86/fast/box-shadow: Added.
  • platform/chromium-linux-x86/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
  • platform/chromium-linux-x86/fast/overflow: Added.
  • platform/chromium-linux-x86/fast/repaint/border-radius-repaint-expected.png: Added.
  • platform/chromium-linux-x86/fast/replaced: Added.
  • platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
  • platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-mac-leopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac-leopard/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Removed.
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
  • platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
  • platform/chromium/test_expectations.txt:
11:27 AM Changeset in webkit [87933] by andreas.kling@nokia.com
  • 4 edits in trunk

2011-06-02 Andreas Kling <kling@webkit.org>

Reviewed by James Robinson.

Canvas/V8: Fix setting strokeStyle or fillStyle to a CSS system color.
https://bugs.webkit.org/show_bug.cgi?id=61944

  • platform/chromium/test_expectations.txt: Unskip canvas/philip/tests/2d.fillStyle.parse.system.html.

2011-06-02 Andreas Kling <kling@webkit.org>

Reviewed by James Robinson.

Canvas/V8: Fix setting strokeStyle or fillStyle to a CSS system color.
https://bugs.webkit.org/show_bug.cgi?id=61944

Call setFillColor/setStrokeColor (instead of setFillStyle/setStrokeStyle)
for string styles. This ensures that system color resolution is performed,
and matches what the JSC bindings do.

Test: canvas/philip/tests/2d.fillStyle.parse.system.html

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: (WebCore::toCanvasStyle): (WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter): (WebCore::V8CanvasRenderingContext2D::fillStyleAccessorSetter):
11:08 AM Changeset in webkit [87932] by abarth@webkit.org
  • 4 edits
    1 delete in trunk/Source

2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87920.
http://trac.webkit.org/changeset/87920
https://bugs.webkit.org/show_bug.cgi?id=61943

This patch does not build in Win Builder (dbg)(shared)
downstream (Requested by abarth|gardener on #webkit).

  • tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::TestPopupMenuClient): (WebKit::TestPopupMenuClient::valueChanged): (WebKit::TestPopupMenuClient::itemIsEnabled): (WebKit::SelectPopupMenuTest::TearDown):
  • tests/data/popup/select_event.html: Removed.
  • tests/data/popup/select_event_remove_on_change.html: Removed.
  • tests/data/popup/select_event_remove_on_click.html: Removed.

2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87920.
http://trac.webkit.org/changeset/87920
https://bugs.webkit.org/show_bug.cgi?id=61943

This patch does not build in Win Builder (dbg)(shared)
downstream (Requested by abarth|gardener on #webkit).

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup): (WebCore::PopupListBox::handleMouseReleaseEvent): (WebCore::PopupListBox::acceptIndex):
11:05 AM Changeset in webkit [87931] by Dimitri Glazkov
  • 24 edits
    12 deletes in trunk

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r87926.
http://trac.webkit.org/changeset/87926
https://bugs.webkit.org/show_bug.cgi?id=60313

Fails to find WebCoreTestSupport.dylib on bots.

  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance-2.js:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/harness/internals-object-expected.txt: Removed.
  • fast/harness/internals-object.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r87926.
http://trac.webkit.org/changeset/87926
https://bugs.webkit.org/show_bug.cgi?id=60313

Fails to find WebCoreTestSupport.dylib on bots.

  • Configurations/WebCore.xcconfig:
  • Configurations/WebCoreTestSupport.xcconfig: Removed.
  • DerivedSources.make:
  • WebCore.exp.in:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWrapper.cpp: (WebCore::JSDOMWrapper::~JSDOMWrapper):
  • bindings/js/JSDOMWrapper.h:
  • testing/Internals.cpp: Removed.
  • testing/Internals.h: Removed.
  • testing/Internals.idl: Removed.
  • testing/js/WebCoreTestSupport.cpp: Removed.
  • testing/js/WebCoreTestSupport.h: Removed.
  • testing/v8/WebCoreTestSupport.cpp: Removed.
  • testing/v8/WebCoreTestSupport.h: Removed.

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r87926.
http://trac.webkit.org/changeset/87926
https://bugs.webkit.org/show_bug.cgi?id=60313

Fails to find WebCoreTestSupport.dylib on bots.

  • WebKit.gyp:
  • public/WebTestingSupport.h: Removed.
  • src/WebTestingSupport.cpp: Removed.

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r87926.
http://trac.webkit.org/changeset/87926
https://bugs.webkit.org/show_bug.cgi?id=60313

Fails to find WebCoreTestSupport.dylib on bots.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow):
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
11:01 AM Changeset in webkit [87930] by Carlos Garcia Campos
  • 7 edits
    2 copies
    2 adds in trunk/Source

2011-06-02 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement popup menus in Webkit2
https://bugs.webkit.org/show_bug.cgi?id=61854

Move common code into a new class to be used by both WebKit1 and
WebKit2.

  • GNUmakefile.list.am: Add new files to compilation.
  • platform/gtk/GtkPopupMenu.cpp: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.cpp. (WebCore::GtkPopupMenu::GtkPopupMenu): (WebCore::GtkPopupMenu::~GtkPopupMenu): (WebCore::GtkPopupMenu::clear): Remove all menu items. (WebCore::GtkPopupMenu::appendSeparator): Add a new separator item to the menu. (WebCore::GtkPopupMenu::appendItem): Add a new item to the menu for the given action. (WebCore::GtkPopupMenu::popUp): Show the menu. (WebCore::GtkPopupMenu::popDown): Hide the menu. (WebCore::GtkPopupMenu::menuRemoveItem): (WebCore::GtkPopupMenu::menuPositionFunction): (WebCore::GtkPopupMenu::resetTypeAheadFindState): (WebCore::GtkPopupMenu::typeAheadFind): (WebCore::GtkPopupMenu::selectItemCallback): (WebCore::GtkPopupMenu::keyPressEventCallback):
  • platform/gtk/GtkPopupMenu.h: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.h. (WebCore::GtkPopupMenu::create): (WebCore::GtkPopupMenu::platformMenu):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenuGtk::PopupMenuGtk): (WebCore::PopupMenuGtk::~PopupMenuGtk): (WebCore::PopupMenuGtk::show): Use GtkPopupMenu. (WebCore::PopupMenuGtk::hide): Ditto. (WebCore::PopupMenuGtk::menuItemActivated): (WebCore::PopupMenuGtk::menuUnmapped):
  • platform/gtk/PopupMenuGtk.h:

2011-06-02 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement popup menus in Webkit2
https://bugs.webkit.org/show_bug.cgi?id=61854

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::createPopupMenuProxy): Create a new WebPopupMenuProxy.
  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp: Added. (WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk): (WebKit::WebPopupMenuProxyGtk::~WebPopupMenuProxyGtk): (WebKit::WebPopupMenuProxyGtk::showPopupMenu): (WebKit::WebPopupMenuProxyGtk::hidePopupMenu): (WebKit::WebPopupMenuProxyGtk::shutdownRunLoop): (WebKit::WebPopupMenuProxyGtk::menuItemActivated): (WebKit::WebPopupMenuProxyGtk::menuUnmapped):
  • UIProcess/gtk/WebPopupMenuProxyGtk.h: Added. (WebKit::WebPopupMenuProxyGtk::create): (WebKit::WebPopupMenuProxyGtk::setActiveItem):
10:50 AM Changeset in webkit [87929] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Adam Barth <abarth@webkit.org>

More examples of SVG tests timing out in debug with Skia.

  • platform/chromium/test_expectations.txt:
10:42 AM Changeset in webkit [87928] by enne@google.com
  • 3 edits in trunk/LayoutTests

2011-06-02 Adrienne Walker <enne@google.com>

[chromium] Unreviewed, rebaseline tests after r87822
https://bugs.webkit.org/show_bug.cgi?id=60821

  • platform/chromium-gpu-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-gpu-win/platform/chromium/compositing/layout-width-change-expected.png:
10:40 AM Changeset in webkit [87927] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-06-02 Aaron Colwell <acolwell@chromium.org>

Reviewed by Dimitri Glazkov.

Bring gyp_webkit up to date with changes made to
gyp_chromium so chromium_rev can be advanced past
revision 87140.
https://bugs.webkit.org/show_bug.cgi?id=61881

  • gyp_webkit:
10:30 AM Changeset in webkit [87926] by Dimitri Glazkov
  • 24 edits
    12 adds in trunk

2011-05-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

  • fast/dom/Window/script-tests/window-property-descriptors.js: Added internals object to list of properties to skip.
  • fast/dom/Window/window-properties.html: Ditto.
  • fast/dom/script-tests/prototype-inheritance-2.js: Ditto.
  • fast/dom/script-tests/prototype-inheritance.js: Ditto.
  • fast/harness/internals-object-expected.txt: Added.
  • fast/harness/internals-object.html: Added.
  • platform/gtk/Skipped: Skipped the newly added test until platform supports window.internals.
  • platform/mac-wk2/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
  • platform/win/Skipped: Ditto.

2011-05-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

Test: fast/harness/internals-object.html

  • Configurations/WebCoreTestSupport.xcconfig: Added.
  • DerivedSources.make: Added support for generating from Internals.idl.
  • WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
  • testing/Internals.cpp: Added.
  • testing/Internals.h: Added.
  • testing/Internals.idl: Added.
  • testing/js/WebCoreTestSupport.cpp: Added.
  • testing/js/WebCoreTestSupport.h: Added.
  • testing/v8/WebCoreTestSupport.cpp: Added.
  • testing/v8/WebCoreTestSupport.h: Added.

2011-05-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

  • WebKit.gyp: Added linking new webkit_test_support library.
  • public/WebTestingSupport.h: Added.
  • src/WebTestingSupport.cpp: Added.

2011-05-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add build logistics and plumbing for window.internals object.
https://bugs.webkit.org/show_bug.cgi?id=60313

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::bindJSObjectsToWindow): Added injection code.
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
10:16 AM Changeset in webkit [87925] by joone.hur@collabora.co.uk
  • 2 edits in trunk/Source/WebKit/gtk

2011-06-02 Joone Hur <joone.hur@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Only load dictionaries if spell check is enabled
https://bugs.webkit.org/show_bug.cgi?id=32879

We don't need to call enchant if enable-spell-checking is false.

  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): Skip loading dictionaries when enable-spell-checking is false. (webkit_web_view_settings_notify): Ditto.
10:04 AM Changeset in webkit [87924] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

[Win] Start skipping a test that's now using shadowRoot machinery.

  • platform/win/Skipped: Skip fast/events/shadow-boundary-crossing.html, since it now uses shadowRoot accessors.
10:00 AM Changeset in webkit [87923] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-02 John Knottenbelt <jknotten@chromium.org>

Unreviewed.

[Chromium] Adjust test expectations.
https://bugs.webkit.org/show_bug.cgi?id=61938

  • platform/chromium/test_expectations.txt:
9:50 AM Changeset in webkit [87922] by enne@google.com
  • 14 edits in trunk/LayoutTests

2011-06-02 Adrienne Walker <enne@google.com>

[chromium] Unreviewed, rebaseline tests after r87822
https://bugs.webkit.org/show_bug.cgi?id=60821

  • platform/chromium-gpu-linux/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/fixed-position-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-gpu-win/compositing/overflow/fixed-position-ancestor-clip-expected.png:
  • platform/chromium/test_expectations.txt:
9:48 AM Changeset in webkit [87921] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping another failing test in GTK after r87901.

  • platform/gtk/Skipped: Skipped test.
9:45 AM Changeset in webkit [87920] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk/Source

2011-06-02 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Dimitri Glazkov.

[Chromium] Click event is not fired for a menulist <select>
https://bugs.webkit.org/show_bug.cgi?id=60563

Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView. (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup. (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.

2011-06-02 Naoki Takano <takano.naoki@gmail.com>

Reviewed by Dimitri Glazkov.

[Chromium] Click event is not fired for a menulist <select>
https://bugs.webkit.org/show_bug.cgi?id=60563

  • tests/PopupMenuTest.cpp: (WebKit::TestPopupMenuClient::TestPopupMenuClient): Initialize m_node. (WebKit::TestPopupMenuClient::valueChanged): To fire 'change' event, forward the event like RenderMenuList. (WebKit::TestPopupMenuClient::itemIsEnabled): Change to return true or false according to disabled item or not. (WebKit::TestPopupMenuClient::setDisabledIndex): Set disabled index to simulate disabled item. (WebKit::TestPopupMenuClient::setFocusedNode): Set focused node to dispatch the event. (WebKit::SelectPopupMenuTest::SelectPopupMenuTest): Add baseURL. (WebKit::SelectPopupMenuTest::TearDown): Add UnregisterAllMockedURLs() call. (WebKit::SelectPopupMenuTest::registerMockedURLLoad): To simulate html load, call RegisterMockedURL(). (WebKit::SelectPopupMenuTest::serveRequests): Call ServeAsynchronousMockedRequests(). (WebKit::SelectPopupMenuTest::loadFrame): Simulate load frame with url string. (WebKit::TEST_F): Implement SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange.
  • tests/data/select_event.html: Added for SelectItemEventFire and SelectItemKeyEvent.
  • tests/data/select_event_remove_on_change.html: Added SelectItemRemoveSelectOnChange.
  • tests/data/select_event_remove_on_click.html: Added SelectItemRemoveSelectOnChange.
9:36 AM Changeset in webkit [87919] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs an implementation of eventSender.
https://bugs.webkit.org/show_bug.cgi?id=42194

Add editing/pasteboard/copy-standalone-image-crash.html to the mac-wk2 skipped list to get
the bots green, as it uses eventSender.contextClick().

  • platform/mac-wk2/Skipped:
9:31 AM Changeset in webkit [87918] by jknotten@chromium.org
  • 3 edits
    4 adds in trunk/LayoutTests

2011-06-02 John Knottenbelt <jknotten@chromium.org>

Unreviewed.

[Chromium] Rebaseline scaling-font-with-geometric-precision and navigator-detached-no-crash.
https://bugs.webkit.org/show_bug.cgi?id=61934

  • platform/chromium-linux-x86/svg/text/scaling-font-with-geometric-precision-expected.png:
  • platform/chromium-mac-leopard/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/chromium-mac/fast/dom/navigator-detached-no-crash-expected.txt: Added.
  • platform/chromium-win/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/chromium-win/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
9:24 AM Changeset in webkit [87917] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WebKitTestRunner needs an implementation of setTextDirection.
https://bugs.webkit.org/show_bug.cgi?id=61931

Add fast/html/set-text-direction.html to the mac-wk2 skipped list to get the bots green.

  • platform/mac-wk2/Skipped:
9:10 AM Changeset in webkit [87916] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skiping flaky test on GTK 32-bit Debug bot.

  • platform/gtk/Skipped: Skipped test.
9:05 AM Changeset in webkit [87915] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-02 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Eric Seidel.

[Qt] Rebaseline tables/mozilla/bugs/bug196870.html test after r73385
https://bugs.webkit.org/show_bug.cgi?id=61781

Rebaseline tables/mozilla/bugs/bug196870.html test after r73385.
See bug #49220

  • platform/qt/Skipped:
  • platform/qt/tables/mozilla/bugs/bug196870-expected.txt:
8:59 AM Changeset in webkit [87914] by Dimitri Glazkov
  • 5 edits in trunk

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Stop event propagation for cases where relatedTarget is both ancestor of the target and at shadow boundary.
https://bugs.webkit.org/show_bug.cgi?id=61892

  • fast/events/shadow-boundary-crossing.html: Added a test that uses new shadow DOM testing machinery.
  • fast/events/shadow-boundary-crossing-expected.txt: Updated expectations.

2011-06-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Stop event propagation for cases where relatedTarget is both ancestor of the target and at shadow boundary.
https://bugs.webkit.org/show_bug.cgi?id=61892

In the cases where the relatedTarget of an event is an ancestor of the target, and the relatedTarget is
a shadow host, we should not allow events to escape out of the hosted shadow DOM subtree.

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::adjustToShadowBoundaries): Added a check that is valid for both new and old shadow DOM.
8:48 AM Changeset in webkit [87913] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping failing tests in GTK after r87901.

  • platform/gtk/Skipped: Skipped 2 tests.
8:46 AM Changeset in webkit [87912] by jknotten@chromium.org
  • 2 edits
    5 adds in trunk/LayoutTests

2011-06-02 John Knottenbelt <jknotten@chromium.org>

Unreviewed.

Adjust test expectations, rebaseline windows SVG wicd tests.
https://bugs.webkit.org/show_bug.cgi?id=61929

  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/chromium-win/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/chromium-win/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
8:32 AM Changeset in webkit [87911] by hans@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-02 Hans Wennborg <hans@chromium.org>

Reviewed by Tony Gentilcore.

Fix LevelDBTransaction::clearTree()
https://bugs.webkit.org/show_bug.cgi?id=61917

This was broken in the code I copied it from; we can't delete and walk
the tree at the same time.

No new functionality, no new tests.

  • platform/leveldb/LevelDBTransaction.cpp: (WebCore::LevelDBTransaction::clearTree):
7:53 AM Changeset in webkit [87910] by jknotten@chromium.org
  • 6 edits
    12 adds in trunk/LayoutTests

2011-06-02 John Knottenbelt <jknotten@chromium.org>

Unreviewed.

Rebaseline SVG tests.
https://bugs.webkit.org/show_bug.cgi?id=61927

  • platform/chromium-mac-leopard/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/chromium-mac-leopard/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/chromium-win/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/chromium-win/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/chromium-win/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/chromium-win/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/chromium-win/svg/hixie/intrinsic/002-expected.txt: Added.
  • platform/chromium-win/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/chromium-win/svg/hixie/intrinsic/003-expected.txt: Added.
  • platform/chromium-win/svg/in-html/by-reference-expected.txt:
  • platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
7:44 AM Changeset in webkit [87909] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

2011-06-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

Adjust efl coding style to more efl directories
https://bugs.webkit.org/show_bug.cgi?id=61903

  • Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
7:40 AM Changeset in webkit [87908] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipped tests crashing on GTK debug bots.

  • platform/gtk/Skipped: Skipped 2 more tests crashing on GTK debug bots because of the same reason than before (see WK bug 61924).
7:20 AM Changeset in webkit [87907] by rwlbuis@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-02 Rob Buis <rbuis@rim.com>

Reviewed by Nikolas Zimmermann.

LayoutTests/svg/animations/animate-path-nested-transforms.html causes assertion in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=49045

Fix mistake in id part of expected values.

  • svg/animations/script-tests/animate-mpath-insert.js: (executeTest):
  • svg/animations/script-tests/animate-path-nested-transforms.js: (executeTest):
7:12 AM Changeset in webkit [87906] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Kent Tamura <tkent@chromium.org>

[Chromium] Update spinbutton expectations.

  • platform/chromium/test_expectations.txt:
7:00 AM Changeset in webkit [87905] by andreas.kling@nokia.com
  • 3 edits
    1 delete in trunk/Source

2011-06-02 Andreas Kling <kling@webkit.org>

Rubber-stamped by Simon Hausmann.

Remove Qt's precompiled header hack as it was broken, and was not even
used unless building WebKit inside a Qt tree.

  • WebKit_pch.h: Removed.

2011-06-02 Andreas Kling <kling@webkit.org>

Rubber-stamped by Simon Hausmann.

Remove Qt's precompiled header hack as it was broken, and was not even
used unless building WebKit inside a Qt tree.

  • WebCore.pri:
6:58 AM Changeset in webkit [87904] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipped tests crashing on GTK debug bots.

  • platform/gtk/Skipped: Skipped 9 more tests crashing on GTK debug bots because of the same reason than before (see WK bug 61924).
6:42 AM Changeset in webkit [87903] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipped tests crashing on GTK debug bots.

  • platform/gtk/Skipped: Skipped 7 tests crashing, apparently all of them crash because of the same reason (see WK bug 61924).
5:55 AM Changeset in webkit [87902] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebKit/qt

2011-06-02 Andreas Kling <kling@webkit.org>

Unreviewed build fix.

To support building namespaced Qt, we require that forward-declarations
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.

  • WebCoreSupport/DumpRenderTreeSupportQt.h:
5:52 AM Changeset in webkit [87901] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-02 James Robinson <jamesr@chromium.org>

Reviewed by Brady Eidson.

DocumentLoader keeps a reference to all URL strings ever loaded leading to lots of memory waste
https://bugs.webkit.org/show_bug.cgi?id=61894

DocumentLoader::m_resourcesClientKnowsAbout is a set of all the URLs that have passed through
FrameLoader::dispatchWillSendRequest() and is used by FrameLoader::loadedResourceFromMemoryCached to decide
whether to inform the FrameLoader's m_client about this load. Unfortunately, this set holds a reference to the
URL string for every resource loaded, so on pages that use data URLs to "load" large amounts of data this leaks
lots of memory.

This set only has an effect on the Mac port, as the only two ports that implement
FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache() are Chromium and Mac and the Chromium implementation
can correctly handle receiving multiple callbacks. This patch limits the set to only PLATFORM(MAC) so other
ports do not have to pay this memory cost. It's possible that a better fix exists specifically for the Mac port
implementation, but that would have to determined by someone who works on that port specifically.

  • loader/DocumentLoader.h: (WebCore::DocumentLoader::didTellClientAboutLoad): (WebCore::DocumentLoader::haveToldClientAboutLoad):
5:52 AM Changeset in webkit [87900] by jknotten@chromium.org
  • 2 edits in trunk/LayoutTests

2011-06-02 John Knottenbelt <jknotten@chromium.org>

Unreviewed.

[Chromium] Adjust test expectations.
https://bugs.webkit.org/show_bug.cgi?id=61922

  • platform/chromium/test_expectations.txt:
5:48 AM Changeset in webkit [87899] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement hasWebView() in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=61905

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::hasWebView): Implement hasWebView() function.
5:24 AM Changeset in webkit [87898] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-06-02 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] No need to invalidate empty areas in ChromeClientEfl::invalidateContentsAndWindow
https://bugs.webkit.org/show_bug.cgi?id=61902

Just return to reduce unnecessary calls when invalidateContentsAndWindow
received empty area.

  • WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::invalidateContentsAndWindow):
5:10 AM Changeset in webkit [87897] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-02 Aparna Nandyal <aparna.nand@wipro.com>

Reviewed by Andreas Kling.

[Qt] Multiple drop events when doing DnD of images.
https://bugs.webkit.org/show_bug.cgi?id=61504

Duplicate entries of the url were getting added into drag data
which is removed. The duplicate entries were causing the same image
url to be copied twice. The code changes now match other webkit ports.

  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage):
5:00 AM Changeset in webkit [87896] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

2011-06-02 Naiem Shaik <naiem.shaik@gmail.com>

Reviewed by Kent Tamura.

Fixing invalid value being returned for default checkbox and radio state
https://bugs.webkit.org/show_bug.cgi?id=61674

As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and
http://www.w3.org/TR/html5/number-state.html#radio-button-state:
The value IDL attribute is in mode default/on:
If the element has a value attribute, it must return that attribute's
value; otherwise, it must return the string "on".
Currently default value is empty string;Default value of Radio button
and checkbox should be "on"
This works as per spec in IE9,Firefox and Opera

  • fast/forms/checkbox-default-value-expected.txt: Added.
  • fast/forms/checkbox-default-value.html: Added.
  • fast/forms/radio-default-value-expected.txt: Added.
  • fast/forms/radio-default-value.html: Added.

2011-06-02 Naiem Shaik <naiem.shaik@gmail.com>

Reviewed by Kent Tamura.

Fixing invalid value being returned for default checkbox and radio state
https://bugs.webkit.org/show_bug.cgi?id=61674

As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and
http://www.w3.org/TR/html5/number-state.html#radio-button-state:
The value IDL attribute is in mode default/on:
If the element has a value attribute, it must return that attribute's
value; otherwise, it must return the string "on".
Currently default value is empty string;Default value of Radio button
and checkbox should be "on".Changed fallbackValue function to return the same
This works as per spec in IE9,Firefox and Opera

Tests: fast/forms/checkbox-default-value.html

fast/forms/radio-default-value.html

  • html/BaseCheckableInputType.cpp: (WebCore::BaseCheckableInputType::fallbackValue):
4:57 AM Changeset in webkit [87895] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipped test timing out for GTK since r87605.

  • platform/gtk/Skipped: Skipped test.
4:52 AM Changeset in webkit [87894] by mnaganov@chromium.org
  • 5 edits in trunk/Source/WebCore/inspector/front-end

Unreviewed: Web Inspector: remove accidental eXecutable flag from certain script files

4:35 AM Changeset in webkit [87893] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, added missing new baselines for GTK after r87779.

  • platform/gtk/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/gtk/svg/hixie/intrinsic/002-expected.txt: Added.
4:11 AM Changeset in webkit [87892] by mario@webkit.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, new GTK baselines after r87807, r87829, r87840 and r87846.

  • platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/gtk/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
  • platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.png: Added.
  • platform/gtk/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
  • platform/gtk/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/gtk/svg/custom/embedding-external-svgs-expected.txt: Added.
  • platform/gtk/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/gtk/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
3:56 AM Changeset in webkit [87891] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium/Mac] Fix a wrong merge for r87881
https://bugs.webkit.org/show_bug.cgi?id=61845

  • platform/chromium/ThemeChromiumMac.mm:

(WebCore::paintStepper):

3:49 AM Changeset in webkit [87890] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipped SVG tests randomly failing with 16px diff.

  • platform/gtk/Skipped: Skipped tests.
3:20 AM Changeset in webkit [87889] by mario@webkit.org
  • 4 edits in trunk/LayoutTests

2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>

Update GTK expectations because the position of steppers are moved.

  • platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
3:12 AM Changeset in webkit [87888] by jknotten@chromium.org
  • 23 edits
    48 adds in trunk/LayoutTests

2011-06-02 John Knottenbelt <jknotten@chromium.org>

Unreviewed.

[Chromium] Update baselines for Windows 7 platform.
https://bugs.webkit.org/show_bug.cgi?id=61916

  • platform/chromium-win/fast/borders/border-antialiasing-expected.png: Added.
  • platform/chromium-win/fast/borders/border-antialiasing-expected.txt: Added.
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/gradients/css3-linear-right-angle-gradients-expected.png: Added.
  • platform/chromium-win/fast/gradients/css3-repeating-linear-gradients2-expected.png: Added.
  • platform/chromium-win/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
  • platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-win/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
  • platform/chromium-win/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/chromium-win/svg/custom/embedding-external-svgs-expected.txt: Added.
  • platform/chromium-win/svg/custom/invalid-fill-expected.png:
  • platform/chromium-win/svg/custom/invalid-fill-expected.txt:
  • platform/chromium-win/svg/custom/invalid-fill-hex-expected.png:
  • platform/chromium-win/svg/custom/invalid-fill-hex-expected.txt:
  • platform/chromium-win/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/chromium-win/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/chromium-win/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/chromium-win/svg/custom/invalid-uri-stroke-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win/svg/custom/small-rect-scale-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/chromium-win/svg/filters/feBlend-invalid-mode-expected.txt: Added.
  • platform/chromium-win/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
3:04 AM Changeset in webkit [87887] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-02 Ian Henderson <ianh@apple.com>

Reviewed by Simon Fraser.

[CG] GraphicsContext::fillRoundedRect() ignores the gradient fill the CGContextFillEllipseInRect() code path
https://bugs.webkit.org/show_bug.cgi?id=61882

If we have a gradient or pattern fill set, take the slow path, which
handles these cases properly.

No new tests, since we never try to fill a rounded rect with a
gradient or pattern.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect):
2:48 AM Changeset in webkit [87886] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-02 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipped test with 1px different results in GTK bots.

  • platform/gtk/Skipped: Skipped test.
2:14 AM Changeset in webkit [87885] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

2011-06-02 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Refactoring] Node::nextRenderer() and previousRenderer() should be part of NodeRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=61912

Inlined Node::nextRenderer() and previousRenderer() into NodeRenderingContext and
removed original definitions.

No test, no behavioral change.

  • dom/Node.cpp:
  • dom/Node.h:
  • dom/NodeRenderingContext.cpp: (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::previousRenderer):
1:48 AM Changeset in webkit [87884] by loki@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-02 Piroska András <Piroska.Andras@stud.u-szeged.hu>

Rubber-stamped by Gabor Loki.

Trivial buildfix for the ParallelJobs part of FEConvolveMatrix.

  • platform/graphics/filters/FEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::apply): Rename variable i to job
1:12 AM Changeset in webkit [87883] by yutak@chromium.org
  • 6 edits in trunk

2011-06-02 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Call WebSocketChannel::fail() when WebSocketHandshake has failed
https://bugs.webkit.org/show_bug.cgi?id=61841

  • http/tests/websocket/tests/bad-handshake-crash-expected.txt: Now the error message starts with a capital letter.

2011-06-02 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Call WebSocketChannel::fail() when WebSocketHandshake has failed
https://bugs.webkit.org/show_bug.cgi?id=61841

There is no change in behavior except that capitalization of a few error messages
has been changed. No new tests are added.

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::processBuffer): Pass m_handshake.failureReason() to fail() if the handshake has failed.
  • websockets/WebSocketHandshake.cpp: Replace occurrences of m_handle->addMessage() with assignments to m_failureReason. Change capitalization of a few messages so that all messages start with a capital letter. (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::failureReason): (WebCore::WebSocketHandshake::readStatusLine): (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::checkResponseHeaders):
  • websockets/WebSocketHandshake.h: Add failureReason(), which returns a string that describes why WebSocket handshake has failed.
12:21 AM Changeset in webkit [87882] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Incorrect UA style when printing a simple document
https://bugs.webkit.org/show_bug.cgi?id=61900

Reviewed by Anders Carlsson.

This is not testable in run-webkit-tests because unless the test is the first to run in an instance
of DumpRenderTree, it is not guaranteed that the full default style sheet has not been initialized.

  • css/CSSStyleSelector.cpp:

(WebCore::loadFullDefaultStyle): Replace the simple default print style, which is now equal to the
simple default style, with a new RuleSet before adding the style rules from the full default sheet.
(WebCore::loadSimpleDefaultStyle): Set defaultPrintStyle to point to the default style. They are
equal in the simple case.

12:04 AM Changeset in webkit [87881] by tkent@chromium.org
  • 33 edits in trunk

2011-06-01 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Remove outer-spin-button
https://bugs.webkit.org/show_bug.cgi?id=61845

Update Mac expectations because the position of steppers are moved.

  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.png:
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png:
  • platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png:
  • platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:

2011-06-01 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Remove outer-spin-button
https://bugs.webkit.org/show_bug.cgi?id=61845

Remove outer-spin-button, and render steppers as inner-spin-button.
Outer-spin-button have never worked well with padding and border of
<input>, and the layout code is very tricky and very hard to maintain it.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSValueKeywords.in:
  • css/html.css:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::innerSpinButtonElement):
  • html/HTMLInputElement.h:
  • html/InputType.h:
  • html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::TextFieldInputType): (WebCore::TextFieldInputType::createShadowSubtree): (WebCore::TextFieldInputType::destroyShadowSubtree):
  • html/TextFieldInputType.h:
  • html/shadow/TextControlInnerElements.cpp: (WebCore::SpinButtonElement::SpinButtonElement): (WebCore::SpinButtonElement::create): (WebCore::SpinButtonElement::shadowPseudoId):
  • html/shadow/TextControlInnerElements.h:
  • platform/ThemeTypes.h:
  • platform/chromium/ThemeChromiumMac.mm: (WebCore::paintStepper): Center the stepper drawing area because the specified area can be larger than the NSStepper sizes. (WebCore::ThemeChromiumMac::controlSize): (WebCore::ThemeChromiumMac::minimumControlSize): (WebCore::ThemeChromiumMac::inflateControlPaintRect): (WebCore::ThemeChromiumMac::paint):
  • platform/mac/ThemeMac.mm: (WebCore::paintStepper): Center the stepper drawing area because the specified area can be larger than the NSStepper sizes. (WebCore::ThemeMac::controlSize): (WebCore::ThemeMac::minimumControlSize): (WebCore::ThemeMac::inflateControlPaintRect): (WebCore::ThemeMac::paint):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations):
  • rendering/RenderBox.h:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::textBlockWidth):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::adjustInnerSpinButtonStyle):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustRepaintRect):

Jun 1, 2011:

11:41 PM Changeset in webkit [87880] by eae@chromium.org
  • 6 edits in trunk/Source/WebCore

2011-06-01 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Switch RenderLayer::convertToLayerCoords to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61818

Covered by existing tests.

  • platform/graphics/FloatPoint.h: (WebCore::flooredIntSize):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::expandClipRectForDescendantsAndReflection): (WebCore::transparencyClipBox): (WebCore::RenderLayer::convertToLayerCoords): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::paintChildLayerIntoColumns): (WebCore::RenderLayer::createLocalTransformState): (WebCore::RenderLayer::hitTestChildLayerColumns): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::boundingBox): (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateCompositedBounds): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::layerWillBeRemoved): (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
11:30 PM Changeset in webkit [87879] by rolandsteiner@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-01 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Kent Tamura.

Remove superfluous renderer() test
https://bugs.webkit.org/show_bug.cgi?id=61907

No new tests. (trivial)

  • dom/Document.cpp: (WebCore::Document::recalcStyle):
9:51 PM Changeset in webkit [87878] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Hajime Morita.

Add IntPoint + IntPoint operator
https://bugs.webkit.org/show_bug.cgi?id=61876

Adding an operator+ convenience method to IntPoint that sums two points
and returns the result as an IntPoint. Changing doImageDrag to use it
as a proof of concept.

No new tests since there is no change in behavior.

  • page/DragController.cpp: (WebCore::DragController::doImageDrag):
  • platform/graphics/IntPoint.h: (WebCore::operator+):
9:21 PM Changeset in webkit [87877] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-06-01 Jaehun Lim <ljaehun.lim@samsung.com>

Reviewed by Eric Seidel.

[EFL] Add adjustMenuListButtonStyle and paintMenuListButton functions
https://bugs.webkit.org/show_bug.cgi?id=61836

Add functions for rendering drop-down list when style attributes are applied.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::adjustMenuListButtonStyle): (WebCore::RenderThemeEfl::paintMenuListButton):
  • platform/efl/RenderThemeEfl.h:
7:53 PM Changeset in webkit [87876] by yutak@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-01 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: WebSocketChannel::fail() should close the connection immediately
https://bugs.webkit.org/show_bug.cgi?id=61851

The effect of this change is almost unobservable. The difference between m_handle->close() and
m_handle->disconnect() is that the former does not close the connection if the handle has
unsent data while the latter immediately closes the connection regardless of unsent data.
Usually a socket stream handle does not have unsent data, and even if it has any, it is hard
for user scripts to observe the difference between close() and disconnect() (it should take some time
for onclose() to be called if there are any unsent data, but there ought to be no other difference
in user scripts' perspective).

No new tests are added, because writing a test for this issue is not feasible due to the above reason.

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::fail): Use m_handle->disconnect() instead of m_handle->close().
7:49 PM Changeset in webkit [87875] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-01 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Coding style nit. Move ec=0 initialization, change
recommended by Alexey in bug.
https://bugs.webkit.org/show_bug.cgi?id=60831

  • dom/Document.cpp: (WebCore::Document::setBody):
7:23 PM Changeset in webkit [87874] by hayato@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-01 Hayato Ito <hayato@chromium.org>

Reviewed by Kent Tamura.

Move {Next,Previous}FocusableNode functions from Document to FocusController.
https://bugs.webkit.org/show_bug.cgi?id=61839

There are some member functions in Document which use 'this'
pointer, but we should use TreeScope instead of Document in some
places to handle focus issues nicely. We have to move these
functions out of Document class so that we can give the TreeScope
as a parameter.

No new tests since no functionality was changed.

  • dom/Document.cpp:
  • dom/Document.h:
  • page/FocusController.cpp: (WebCore::FocusController::deepFocusableNode): (WebCore::FocusController::advanceFocusInDocumentOrder): (WebCore::nextNodeWithExactTabIndex): (WebCore::previousNodeWithExactTabIndex): (WebCore::nextNodeWithGreaterTabIndex): (WebCore::previousNodeWithLowerTabIndex): (WebCore::FocusController::nextFocusableNode): (WebCore::FocusController::previousFocusableNode):
  • page/FocusController.h:
7:09 PM Changeset in webkit [87873] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-06-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

old-run-webkit-tests: add support for audio files
https://bugs.webkit.org/show_bug.cgi?id=57992

  • Scripts/old-run-webkit-tests:
6:36 PM Changeset in webkit [87872] by abarth@webkit.org
  • 2 edits
    1 move in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

There seems to be something odd about registerProtocolHandler on Mac.
The "no-crash" seems to "pass" because the test does not crash, where
as the "register-protocol-handler" test fails, apparently due to the
API being disabled.

  • platform/chromium/test_expectations.txt:
  • platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
  • platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt.
    • This expectation file is misplaced.
6:11 PM Changeset in webkit [87871] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

Now that this test doesn't time out, we can see that it fails. That's
progress, of a sort.

  • platform/chromium/test_expectations.txt:
6:05 PM Changeset in webkit [87870] by abarth@webkit.org
  • 1 edit
    1 move
    1 delete in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

Move expected result to the correct location. The script put it in the
wrong location.

  • platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt: Removed.
  • platform/chromium-win/fast/js/property-getters-and-setters-expected.txt: Removed.
  • platform/chromium/fast/js/property-getters-and-setters-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt.
6:00 PM Changeset in webkit [87869] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

These test time out on debug, probably because drop shadows are slow in debug skia.

  • platform/chromium/test_expectations.txt:
5:53 PM Changeset in webkit [87868] by enne@google.com
  • 4 edits in trunk/Source

2011-06-01 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix syncing of removed mask and replica layers
https://bugs.webkit.org/show_bug.cgi?id=61895

  • platform/graphics/chromium/TreeSynchronizer.cpp: (WebCore::TreeSynchronizer::synchronizeTreeRecursive):

2011-06-01 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix syncing of removed mask and replica layers
https://bugs.webkit.org/show_bug.cgi?id=61895

  • tests/TreeSynchronizerTest.cpp: (WebCore::TEST):
5:53 PM Changeset in webkit [87867] by jchaffraix@webkit.org
  • 12 edits
    4 adds in trunk

2011-06-01 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Simon Fraser.

CSSStyleSheet#insertRule doesn't work well with imported stylesheets
https://bugs.webkit.org/show_bug.cgi?id=56981

Test that a combination of insertRule and @import works properly.

  • fast/css/import-and-insert-rule-no-update-expected.txt: Added.
  • fast/css/import-and-insert-rule-no-update.html: Added.
  • fast/css/resources/red.css: Added. (div):
  • fast/css/resources/redimport.css: Added.

2011-06-01 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Simon Fraser.

CSSStyleSheet#insertRule doesn't work well with imported stylesheets
https://bugs.webkit.org/show_bug.cgi?id=56981

Test: fast/css/import-and-insert-rule-no-update.html

The bug arises from the fact that <link> element did not know about a programmatically
loading sheet (using insertRule and @import) and would thus never call removePendingSheet.
This is needed to make sure our style selector contains an up-to-date list of stylesheets.

The gist of the patch adds a way for style sheet owner element to know if we are
programmatically loading a style sheet. This is needed as <link> keeps the information
about that last loaded stylesheet.

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent): Call startLoadingDynamicSheet on our parent style sheet instead of directly adding a pending style sheet.
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::startLoadingDynamicSheet): Call startLoadingDynamicSheet on our owner element if we have one.
  • css/CSSStyleSheet.h:
  • dom/Node.h: (WebCore::Node::startLoadingDynamicSheet): Added common implementation of startLoadingDynamicSheet, which should never be called.
  • dom/StyleElement.cpp: (WebCore::StyleElement::startLoadingDynamicSheet):
  • dom/StyleElement.h: Common implementation of startLoadingDynamicSheet for style elements.
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::startLoadingDynamicSheet):
  • html/HTMLLinkElement.h: Use the HTMLLinkElement plumbing to make sure we call addRemovePendingSheet.
  • html/HTMLStyleElement.h: (WebCore::HTMLStyleElement::startLoadingDynamicSheet):
  • svg/SVGStyleElement.h: (WebCore::SVGStyleElement::startLoadingDynamicSheet): Forward the call to StyleElement.
5:46 PM Changeset in webkit [87866] by leviw@chromium.org
  • 10 edits in trunk/Source/WebCore

2011-06-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintCustomHighlight to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61562

Switching paintCustomHighlight to use an IntPoint for
its paint offset instead of a pair of ints.

No new tests since this is refactoring.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/InlineTextBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RenderBox.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint):
  • rendering/RootInlineBox.h:
4:19 PM Changeset in webkit [87865] by eae@chromium.org
  • 8 edits in trunk/Source/WebCore

2011-06-01 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

Switch MouseRelatedEvent to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61574

Covered by existing tests.

  • dom/MouseEvent.cpp: (WebCore::MouseEvent::MouseEvent): (WebCore::MouseEvent::initMouseEvent): (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::contentsScrollOffset): (WebCore::MouseRelatedEvent::initCoordinates): (WebCore::MouseRelatedEvent::computeRelativePosition): (WebCore::MouseRelatedEvent::layerX): (WebCore::MouseRelatedEvent::layerY): (WebCore::MouseRelatedEvent::offsetX): (WebCore::MouseRelatedEvent::offsetY): (WebCore::MouseRelatedEvent::pageX): (WebCore::MouseRelatedEvent::pageY): (WebCore::MouseRelatedEvent::pageLocation): (WebCore::MouseRelatedEvent::x): (WebCore::MouseRelatedEvent::y):
  • dom/MouseRelatedEvent.h: (WebCore::MouseRelatedEvent::screenX): (WebCore::MouseRelatedEvent::screenY): (WebCore::MouseRelatedEvent::screenLocation): (WebCore::MouseRelatedEvent::clientX): (WebCore::MouseRelatedEvent::clientY): (WebCore::MouseRelatedEvent::clientLocation): (WebCore::MouseRelatedEvent::absoluteLocation):
  • dom/TouchEvent.cpp: (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::initTouchEvent):
  • dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): (WebCore::WheelEvent::initWheelEvent): (WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
  • dom/WheelEvent.h: (WebCore::WheelEvent::create): (WebCore::WheelEvent::wheelDelta): (WebCore::WheelEvent::wheelDeltaX): (WebCore::WheelEvent::wheelDeltaY): (WebCore::WheelEvent::rawDeltaX): (WebCore::WheelEvent::rawDeltaY): (WebCore::WheelEvent::isHorizontal):
  • platform/graphics/IntPoint.h: (WebCore::IntPoint::scale):
4:15 PM Changeset in webkit [87864] by leviw@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-06-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintOverflowControls to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61884

Switching paintOverflowControls to use an IntPoint instead of a pair of ints.

No new tests since this is simple refactoring.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintLayer):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer):
4:13 PM Changeset in webkit [87863] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-06-01 Abhishek Arya <inferno@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix setting of document.body
https://bugs.webkit.org/show_bug.cgi?id=60831

  1. Only allowing setting to an element if it has a body tag.
  2. If element is from another document, import it.

Test: fast/dom/document-set-body.html

  • dom/Document.cpp: (WebCore::Document::setBody):

2011-06-01 Abhishek Arya <inferno@chromium.org>

Reviewed by Alexey Proskuryakov.

Tests setting document.body to non body elements, elements in other
documents.
https://bugs.webkit.org/show_bug.cgi?id=60831

  • fast/dom/document-set-body-expected.txt: Added.
  • fast/dom/document-set-body.html: Added.
4:03 PM Changeset in webkit [87862] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

Add Windows baseline for this new test.

  • platform/chromium-win-vista/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/chromium-win-vista/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
3:59 PM Changeset in webkit [87861] by abarth@webkit.org
  • 22 edits
    5 adds in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

Update image baselines for these drop shadows. They differ from each
other only by minor rendering differences in the shadow.

  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
  • platform/chromium-linux-x86/svg/filters/feDropShadow-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/chromium-linux/svg/filters/feDropShadow-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/chromium-mac-leopard/svg/filters/feDropShadow-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/chromium-mac/svg/filters/feDropShadow-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png:
  • platform/chromium-win/svg/filters/feDropShadow-expected.png:
  • platform/chromium/test_expectations.txt:
3:57 PM Changeset in webkit [87860] by jochen@chromium.org
  • 6 edits
    1 copy
    5 adds in trunk

2011-06-01 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Add a test for FrameLoaderClient::allowImages
https://bugs.webkit.org/show_bug.cgi?id=34314

  • platform/chromium/permissionclient/image-permissions-expected.txt: Added.
  • platform/chromium/permissionclient/image-permissions.html: Added.
  • platform/chromium/permissionclient/resources/boston.gif: Added.
  • platform/chromium/permissionclient/resources/image.html: Added.

2011-06-01 Jochen Eisinger <jochen@chromium.org>

Reviewed by Adam Barth.

Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
https://bugs.webkit.org/show_bug.cgi?id=34314

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setImagesAllowed): (LayoutTestController::setStorageAllowed):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h. (WebPermissions::WebPermissions): (WebPermissions::~WebPermissions): (WebPermissions::allowImages): (WebPermissions::allowStorage): (WebPermissions::setImagesAllowed): (WebPermissions::setStorageAllowed): (WebPermissions::reset):
  • DumpRenderTree/chromium/WebPermissions.h:
3:54 PM Changeset in webkit [87859] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

These tests no longer time out. Yay!

  • platform/chromium/test_expectations.txt:
3:51 PM Changeset in webkit [87858] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

Update expected results to match V8 rather than JSC.

  • platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt:
3:48 PM Changeset in webkit [87857] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Non-users need access to the mds caches for SSL support.
<rdar://problem/9471799>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb:
3:37 PM Changeset in webkit [87856] by Chris Fleizach
  • 5 edits in trunk/Source/WebCore

Safari always crashes on http://bbc.co.uk when VoiceOver enabled
https://bugs.webkit.org/show_bug.cgi?id=61886

Reviewed by Darin Adler.

This crash can happen on webpages that remove an element from the DOM when the element receives focus.
When AppKit goes to post a notification to inform VoiceOver the focus has changed, it asks for the AXFocusedUIElement.
However by posting that notification, a render tree update is performed. This causes the element to disappear, but
AppKit still has a handle to it and continues to try to reference it. When the autorelease pool pops, the reference goes bad.

To fix, the root element, the AccessibilityScrollView, needs to implement updateBackingStore(), otherwise this method
will not be called in time.

No test could be created because to cause it depends on an internal AppKit mechanism
that is only triggered remotely through the accessibility runtime.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateBackingStore):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/AccessibilityRenderObject.h:
2:57 PM Changeset in webkit [87855] by commit-queue@webkit.org
  • 7 edits in trunk

2011-06-01 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Tony Chang.

Test plugin should support event logging on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=61721

  • platform/chromium-win/plugins/keyboard-events-expected.txt: New windows result.
  • platform/chromium/test_expectations.txt: New expectations.
  • plugins/keyboard-events.html: Add attribute windowPlugin="false" to force the Chromium windows port to load the test plugin in windowless mode. The plugin will then receive events and can log them to the console as required by this test.
  • plugins/mouse-events.html: Ditto.

2011-06-01 Noel Gordon <noel.gordon@gmail.com>

Reviewed by Tony Chang.

Test plugin should support event logging on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=61721

  • DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventWin): Well, handle them.
2:55 PM Changeset in webkit [87854] by abarth@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

... and finally Windows.

  • platform/chromium-win-vista/fullscreen/full-screen-zIndex-after-expected.png: Added.
2:42 PM Changeset in webkit [87853] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-06-01 David Carson <dacarson@apple.com>

Reviewed by Antti Koivisto.

Don't flatten frames that have a zero size.
https://bugs.webkit.org/show_bug.cgi?id=61831

This tests creates an iframe that has a width and height of zero
and ensures that the iframe is not flattened to the size of the
containing content.

  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html: Added.
  • fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size-expected.txt: Added.

2011-06-01 David Carson <dacarson@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=61831
If width and height of an iframe is fixed and should not be visible, then
it shouldn't be flattened.

Test: fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html

  • rendering/RenderIFrame.cpp: (WebCore::RenderIFrame::flattenFrame): add a check for a zero width or height
2:32 PM Changeset in webkit [87852] by abarth@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

Linux image baselines for this new test. Leviw confirms that this results are correct.

  • platform/chromium-linux-x86/svg/text: Added.
  • platform/chromium-linux-x86/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/chromium-linux-x86/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
  • platform/chromium-linux/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/chromium-linux/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
2:28 PM Changeset in webkit [87851] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

Image baselines for this new test.

  • platform/chromium-linux-x86/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-linux/fullscreen/full-screen-zIndex-after-expected.png: Added.
  • platform/chromium-mac/fullscreen/full-screen-zIndex-after-expected.png: Added.
2:25 PM Changeset in webkit [87850] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

... and now Windows results.

  • platform/chromium-win-vista/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/embedding-external-svgs-expected.txt: Added.
2:17 PM Changeset in webkit [87849] by kerz@chromium.org
  • 1 add in branches/chromium/782/codereview.settings

Adding codereview settings file so drover will work correctly on this branch

2:13 PM Changeset in webkit [87848] by dcheng@chromium.org
  • 11 edits
    2 adds in trunk

2011-06-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887

  • fast/events/drag-image-filename-expected.txt: Added.
  • fast/events/drag-image-filename.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-06-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887

We try to guess an appropriate filename when dragging out images. In order, we try to use:

  • The filename suggested in the HTTP header.
  • The last path component of the source URL.
  • The alt text. This matches the behavior of the other WebKit ports.

Test: fast/events/drag-image-filename.html

  • platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject):
  • platform/chromium/ClipboardChromiumMac.cpp: (WebCore::isInvalidFileCharacter): (WebCore::ClipboardChromium::validateFileName):

2011-06-01 Daniel Cheng <dcheng@chromium.org>

Reviewed by Tony Chang.

[chromium] Use correct file name for dragging out images.
https://bugs.webkit.org/show_bug.cgi?id=24887

  • DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::dumpFilenameBeingDragged):
  • DumpRenderTree/chromium/EventSender.h:
2:09 PM Changeset in webkit [87847] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-06-01 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

nrwt: make webaudio work w/o content-length header
https://bugs.webkit.org/show_bug.cgi?id=61819

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/port/mock_drt.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
2:00 PM Changeset in webkit [87846] by leviw@chromium.org
  • 3 edits
    3 adds in trunk

2011-06-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Text is scaled in a stair-step pattern
https://bugs.webkit.org/show_bug.cgi?id=60317

Stop scaling the specified font to the actual on-screen value when font-rendering:
geometricPrecision is specified, but instead scale the graphics context. This allows
us to scale text up and down smoothly.

Test: svg/text/scaling-font-with-geometric-precision.html

  • rendering/svg/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):

2011-06-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Text is scaled in a stair-step pattern
https://bugs.webkit.org/show_bug.cgi?id=60317

Stop scaling the specified font to the actual on-screen value when font-rendering:
geometricPrecision is specified, but instead scale the graphics context. This allows
us to scale text up and down smoothly.

  • platform/mac/svg/text/scaling-font-with-geometric-precision-expected.png: Added.
  • platform/mac/svg/text/scaling-font-with-geometric-precision-expected.txt: Added.
  • svg/text/scaling-font-with-geometric-precision.html: Added.
1:58 PM Changeset in webkit [87845] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintResizer to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61883

Switch paintResizer to take an IntPoint instead of a pair of ints.

No new tests as this is simple refactoring.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintResizer):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintContents):
1:57 PM Changeset in webkit [87844] by jer.noble@apple.com
  • 3 edits
    3 adds in trunk

2011-06-01 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Page layout messed up after exiting full screen at Apple trailers page
https://bugs.webkit.org/show_bug.cgi?id=61755

  • fullscreen/full-screen-zIndex-after-expected.txt: Added.
  • fullscreen/full-screen-zIndex-after.html: Added.
  • platform/mac/fullscreen/full-screen-zIndex-after-expected.png: Added.

2011-06-01 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Page layout messed up after exiting full screen at Apple trailers page
https://bugs.webkit.org/show_bug.cgi?id=61755
<rdar://problem/9525277>

Test: fullscreen/full-screen-zIndex-after.html

Fix the incomplete implementation of r87660. Make parameters to
setContainsFullScreenElementRecursively() in webkitWillExitFullScreenForElement() match those
in webkitWillEnterFullScreenForElement(), so the ancestors' flags do not become
inconsistent..

  • dom/Document.cpp: (WebCore::Document::webkitWillExitFullScreenForElement):
1:52 PM Changeset in webkit [87843] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

Image baselines for this test. More to follow once the bots catch up.

  • platform/chromium-linux-x86/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/embedding-external-svgs-expected.txt: Added.
  • platform/chromium-linux/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/chromium-linux/svg/custom/embedding-external-svgs-expected.txt: Added.
1:42 PM Changeset in webkit [87842] by abarth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

Image baselines for these platforms.

  • platform/chromium-linux-x86/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-linux-x86/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
  • platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-linux/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
  • platform/chromium-win-vista/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/chromium-win-vista/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
1:38 PM Changeset in webkit [87841] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-06-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintScrollCorner to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61874

Changing paintScrollCorner to take an IntPoint representing the paint
offset instead of a pair of ints.

No new tests as this is simple refactoring.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner):
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintContents):
1:24 PM Changeset in webkit [87840] by zimmermann@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

SVG graphics do not actually work in IMG tags or as background-image properties
https://bugs.webkit.org/show_bug.cgi?id=18228

Adding the nice testcase from the bug 18228, all issues are fully resolved now.

  • platform/mac/svg/custom/embedding-external-svgs-expected.png: Added.
  • platform/mac/svg/custom/embedding-external-svgs-expected.txt: Added.
  • svg/custom/embedding-external-svgs.xhtml: Added.
  • svg/custom/resources/spinner.svg: Added.
1:14 PM Changeset in webkit [87839] by jer.noble@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-06-01 Jer Noble <jer.noble@apple.com>

Reviewed by Maciej Stachowiak.

Flash of old video frame at the end of full screen transition
https://bugs.webkit.org/show_bug.cgi?id=61752

Add a new method and message, DisposeOfLayerClient, which will invalidate and release
the WKRemoteLayerClient used during the full-screen animation. This ensures that
the root layer used for the full-screen animation will be in a clean state at the start
of the next transition.

  • UIProcess/WebFullScreenManagerProxy.cpp: (WebKit::WebFullScreenManagerProxy::disposeOfLayerClient): Added.
  • UIProcess/WebFullScreenManagerProxy.h:
  • UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]): Call disposeOfLayerClient.
  • WebProcess/FullScreen/WebFullScreenManager.h: (WebKit::WebFullScreenManager::disposeOfLayerClient): Added.
  • WebProcess/FullScreen/WebFullScreenManager.messages.in: Added DisposeOfLayerClient.
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.h:
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::disposeOfLayerClient): Added, invalidates and clears m_rootLayerClient.
1:09 PM Changeset in webkit [87838] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-06-01 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Add single character lookup cache to IdentifierArena
https://bugs.webkit.org/show_bug.cgi?id=61879

Add a simple lookup cache for single ascii character
identifiers. Produces around a 2% improvement in parse
time for my adhoc parser test.

  • parser/ParserArena.h: (JSC::IdentifierArena::IdentifierArena): (JSC::IdentifierArena::clear): (JSC::IdentifierArena::makeIdentifier):
12:52 PM Changeset in webkit [87837] by kbr@google.com
  • 5 edits in trunk/Source/WebCore

2011-06-01 Kenneth Russell <kbr@google.com>

Reviewed by Nate Chapin.

[V8] Optimize fetches of indexed properties in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=61821

Avoid allocating garbage in affected custom bindings. This speeds
up one test case by at least a factor of two. No new tests;
covered by existing layout tests (typed array and otherwise).

  • bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArray): (WebCore::setWebGLArrayHelper):
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getMessagePortArray):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::jsArrayToFloatArray): (WebCore::jsArrayToIntArray):
12:20 PM Changeset in webkit [87836] by abarth@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

Add new results for this new test. Our results are different by one
pixel. Mac results likely to follow once those bots catch up.

  • platform/chromium-linux-x86/svg/as-image: Added.
  • platform/chromium-linux-x86/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
  • platform/chromium-linux/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
  • platform/chromium-win-vista/svg/as-image: Added.
  • platform/chromium-win-vista/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
11:58 AM Changeset in webkit [87835] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Ryosuke Niwa <rniwa@webkit.org>

Skip editing/pasteboard/drag-drop-list.html on GTK after r87778
since smart paste isn't supported by GTK (tracked by the bug 61661).

  • platform/gtk/Skipped:
11:54 AM Changeset in webkit [87834] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Build fix after r87831

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
Added some HAVE(WKQCA) guards.

11:44 AM Changeset in webkit [87833] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

2011-06-01 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

LayoutTests/editing/pasteboard/drag-drop-list fails on webkit2
https://bugs.webkit.org/show_bug.cgi?id=61871

Renames editing/pasteboard/4861080.html to drag-drop-list.html, since it was renamed in r87778.

  • platform/mac-wk2/Skipped:
  • platform/qt-wk2/Skipped:
11:41 AM Changeset in webkit [87832] by Adam Roben
  • 4 edits in trunk/Source/WebKit2

Delete a bunch of dead code in DrawingAreaImpl

LayerTreeHost::participatesInDisplay always returns false now, which means a bunch of code
in DrawingAreaImpl no longer runs.

Cleanup after fixing <http://webkit.org/b/58054>
<rdar://problem/9249839> REGRESSION (WebKit2): Accelerated CSS animations have a lower
framerate than in WebKit1

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaImpl::didUpdate):
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::scheduleDisplay):
(WebKit::DrawingAreaImpl::displayTimerFired):
(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.h:

Reverted r82959.

11:39 AM Changeset in webkit [87831] by Adam Roben
  • 12 edits
    1 copy
    1 add in trunk/Source/WebKit2

Render accelerated content into a web process-owned child HWND

This allows us to use WKCACFView's far more efficient kWKCACFViewDrawingDestinationWindow
mode, which gives us asynchronous rendering on a background thread and doesn't require us to
read bits off the GPU back into system memory.

A new class, WKCACFViewWindow, represents the child HWND. The child HWND is placed at the
bottom of the z-order so it won't obscure any other child HWNDs (i.e., windowed plugins).
The child HWND is made transparent to mouse events so that WKView will continue to receive
mouse events even though it is obscured by the child HWND.

There is now a bunch of dead code in DrawingAreaImpl to handle our old rendering model. I'll
remove that in a future patch.

Fixes <http://webkit.org/b/58054> <rdar://problem/9249839> REGRESSION (WebKit2): Accelerated
CSS animations have a lower framerate than in WebKit1

Reviewed by Anders Carlsson.

  • Shared/LayerTreeContext.h: Added HWND member on Windows.
  • Shared/win/CoalescedWindowGeometriesUpdater.cpp:

(WebKit::CoalescedWindowGeometriesUpdater::updateGeometries):

  • Shared/win/CoalescedWindowGeometriesUpdater.h:

Added new BringToTopOrNot argument. Allows the caller to specify that all windows being
updated should also be brought to the top of the z-order.

  • Shared/win/LayerTreeContextWin.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):
Implemented based on new window member.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView): Initialize new member.
(WebKit::WebView::onSizeEvent): Resize the layer host window to cover our entire view, if we
have one.
(WebKit::WebView::enterAcceleratedCompositingMode): Store, position, and show the layer host
window.
(WebKit::WebView::exitAcceleratedCompositingMode): Destroy the layer host window.
(WebKit::WebView::updateChildWindowGeometries): Updated for change to
CoalescedWindowGeometriesUpdater.

  • UIProcess/win/WebView.h: Added m_layerHostWindow member.
  • WebProcess/WebPage/LayerTreeHost.h: Added scheduleChildWindowGeometryUpdate.
  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::supportsAcceleratedCompositing): Simplified by using
WKCACFViewWindow.

(WebKit::LayerTreeHostCAWin::LayerTreeHostCAWin): Removed initialization of a removed
member.
(WebKit::LayerTreeHostCAWin::platformInitialize): Changed to use WKCACFViewWindow,
kWKCACFViewDrawingDestinationWindow, and to initialize the LayerTreeContext.
(WebKit::LayerTreeHostCAWin::invalidate): Leak our window and tell it to clean up after
itself. The UI process will take care of destroying the window when it finishes switching
out of accelerated compositing mode. Removed a WKCACFViewUpdate call that is now handled by
WKCACFViewWindow.
(WebKit::LayerTreeHostCAWin::scheduleChildWindowGeometryUpdate): Added. Calls through to
m_geometriesUpdater.
(WebKit::LayerTreeHostCAWin::sizeDidChange): Updated to use WKCACFViewWindow.
(WebKit::LayerTreeHostCAWin::contextDidChange): Update child window geometries now to keep
them (almost) in sync with the accelerated content. <http://webkit.org/b/61867> covers the
slight asynchrony that still exists.
(WebKit::LayerTreeHostCAWin::setRootCompositingLayer): Don't flush any changes when we don't
have a root layer. This prevents a flash of white when switching out of compositing mode.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added m_window and m_geometriesUpdater.

Removed code related to the old, synchronous display model.

  • WebProcess/WebPage/ca/win/WKCACFViewWindow.cpp: Added.

(WebKit::WKCACFViewWindow::WKCACFViewWindow): Initialize members and create our window.
(WebKit::WKCACFViewWindow::~WKCACFViewWindow): Destroy our window if needed.
(WebKit::WKCACFViewWindow::onCustomDestroy): Just call ::DestroyWindow.
(WebKit::WKCACFViewWindow::onDestroy): Tell our view not to render into our window anymore.
(WebKit::WKCACFViewWindow::onEraseBackground): Tell Windows not to erase us.
(WebKit::WKCACFViewWindow::onNCDestroy): Clear out m_window since it's now pointing to a
destroy window, and destroy ourselves if requested.
(WebKit::WKCACFViewWindow::onPaint): Tell the view to draw, then clear our invalid region.
(WebKit::WKCACFViewWindow::onPrintClient): Tell our view to draw into the given HDC.
(WebKit::WKCACFViewWindow::registerClass): Register our class (duh).
(WebKit::WKCACFViewWindow::staticWndProc): Get the WKCACFViewWindow pointer, or store the
pointer if needed, then call through to wndProc.
(WebKit::WKCACFViewWindow::wndProc): Call out to the appropriate handler function.

  • WebProcess/WebPage/ca/win/WKCACFViewWindow.h: Added.

(WebKit::WKCACFViewWindow::setDeletesSelfWhenWindowDestroyed): Simple setter.
(WebKit::WKCACFViewWindow::window): Simple getter.

  • WebProcess/WebPage/win/DrawingAreaImplWin.cpp:

(WebKit::DrawingAreaImpl::scheduleChildWindowGeometryUpdate): Let the LayerTreeHost handle
the geometry update, if we have one.

  • win/WebKit2.vcproj: Added WKCACFViewWindow files.
11:38 AM Changeset in webkit [87830] by xan@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-06-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Explictly request the size of a pointer in malloc. Otherwise this
explodes in 64bit architectures, at least.

  • webkit/webkitwebplugin.cpp: (webkit_web_plugin_get_mimetypes): ditto.
11:36 AM Changeset in webkit [87829] by zimmermann@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

Permanent red background when SVG is used as a background image (DEBUG ONLY)
https://bugs.webkit.org/show_bug.cgi?id=16518

The problem seems gone, I can't reproduce it anymore, add Beths test to svg/as-image.

  • platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.png: Added.
  • platform/mac/svg/as-image/svg-as-background-with-relative-size-expected.txt: Added.
  • svg/as-image/resources/svg-as-background-with-relative-size.svg: Added.
  • svg/as-image/svg-as-background-with-relative-size.html: Added.
11:16 AM Changeset in webkit [87828] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-06-01 Andras Becsi <abecsi@webkit.org>

Reviewed by Csaba Osztrogonác.

[Qt] Fix the Phonon build when logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=61869

No new tests needed.

  • platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Add missing guards. (WebCore::MediaPlayerPrivatePhonon::networkState): (WebCore::MediaPlayerPrivatePhonon::readyState): (WebCore::MediaPlayerPrivatePhonon::updateStates): (WebCore::MediaPlayerPrivatePhonon::stateChanged):
11:12 AM Changeset in webkit [87827] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-06-01 Abhishek Arya <inferno@chromium.org>

Reviewed by Antti Koivisto.

Do not use the pushed style selector if it is not equal to the
parent document's style selector. It usually means that it is
in a bad state, e.g. already cleared.
https://bugs.webkit.org/show_bug.cgi?id=61737

  • dom/Element.cpp: (WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
11:08 AM Changeset in webkit [87826] by oliver@apple.com
  • 10 edits in trunk

2011-05-31 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Freezing a function and its prototype causes browser to crash.
https://bugs.webkit.org/show_bug.cgi?id=61758

Add test to ensure correct behaviour

  • fast/js/preventExtensions-expected.txt:
  • fast/js/script-tests/preventExtensions.js: (f):

2011-05-31 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Freezing a function and its prototype causes browser to crash.
https://bugs.webkit.org/show_bug.cgi?id=61758

Make JSObject::preventExtensions virtual so that we can override it
and instantiate all lazy

  • JavaScriptCore.exp:
  • runtime/JSFunction.cpp: (JSC::createPrototypeProperty): (JSC::JSFunction::preventExtensions): (JSC::JSFunction::getOwnPropertySlot):
  • runtime/JSFunction.h:
  • runtime/JSObject.h:
  • runtime/JSObject.cpp: (JSC::JSObject::seal): (JSC::JSObject::seal):
10:59 AM Changeset in webkit [87825] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-06-01 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch RenderLineBoxList intersection functions to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61794

Switching rangeIntersectsRect, anyLineIntersectsRect, and lineIntersectsDirtyRect
to take IntPoint instead of a tx/ty to represent the offset to be applied match
the rect and lines' coordinates.

No new tests since this is merely refactoring.

  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::rangeIntersectsRect): (WebCore::RenderLineBoxList::anyLineIntersectsRect): (WebCore::RenderLineBoxList::lineIntersectsDirtyRect): (WebCore::RenderLineBoxList::paint): (WebCore::RenderLineBoxList::hitTest):
  • rendering/RenderLineBoxList.h:
10:55 AM Changeset in webkit [87824] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

2011-06-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

Reviewed by Andreas Kling.

[Qt][WK2] Add QGLWidget viewport support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=61802

Add command line parameter and menu item to MiniBrowser application
enabling use of QGLWidget for browser viewport.

  • MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::toggleGLViewport):
  • MiniBrowser/qt/BrowserWindow.h:
  • MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::handleUserOptions):
  • MiniBrowser/qt/MiniBrowserApplication.h: (WindowOptions::WindowOptions):
10:41 AM Changeset in webkit [87823] by xan@webkit.org
  • 3 edits in trunk/Source/WebKit/gtk

2011-06-01 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Utility methods for UA spellchecking
https://bugs.webkit.org/show_bug.cgi?id=61788

Adds a couple of utility methods needed to implement some aspects
of spell checking support in a browser.

  • webkit/webkitwebframe.cpp: (webkit_web_frame_replace_selection): method to replace the current selection with a string of text. (webkit_web_frame_get_range_for_word_around_caret): returns the DOM range for the word where the caret/selection currently is.
  • webkit/webkitwebframe.h: declare new methods.
10:36 AM Changeset in webkit [87822] by enne@google.com
  • 5 edits in trunk

2011-05-19 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Don't split long, narrow layers into multiple tiles.
https://bugs.webkit.org/show_bug.cgi?id=60821

These tests have imperceptible pixel changes on horizontal scrollbars
as a result of this patch. Marking them as failing temporarily so
that they can be rebaselined.

  • platform/chromium/test_expectations.txt:

2011-05-19 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Don't split long, narrow layers into multiple tiles.
https://bugs.webkit.org/show_bug.cgi?id=60821

This changes the heuristic for when we tile layers to be less bad
about wasting texture space. Long, narrow layers that are tiled with
a large tile size waste texture space. Now layers are only tiled if
they are above 512px in one dimension and extend into a second tile in
the other. If they are not tiled, their layer texture will exactly
fit their layer bounds. In particular, this will help scrollbars.

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerChromium::updateLayerSize):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::maxTextureSize):
10:27 AM BuildingGtk edited by mrobinson@webkit.org
(diff)
10:19 AM Changeset in webkit [87821] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-06-01 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Ready Chromium port for Skia on Mac
https://bugs.webkit.org/show_bug.cgi?id=61800

Skia on Mac is not enabled. The executing
code is unchanged, so there are no new tests.

  • platform/chromium/DragImageRef.h: Use Skia for DragImageRef instead of CG.
  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint): Get the total matrix from Skia for the scrollbar. Convert the SkCanvas into a CGContext to draw.
  • platform/chromium/ThemeChromiumMac.mm: (WebCore::paintStepper): Ditto.
10:08 AM Changeset in webkit [87820] by kerz@chromium.org
  • 1 copy in branches/chromium/782

Branch for Chrome 13

10:03 AM Changeset in webkit [87819] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

2011-06-01 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

Print out autogen arguments when they differ from the last set, to help
with debugging build issues.

  • Scripts/webkitdirs.pm: Print out previous and current build arguments when they differ.
9:58 AM Changeset in webkit [87818] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
https://bugs.webkit.org/show_bug.cgi?id=59345

KURL and QUrl disagree whether certain URLs are valid or not. The regression here
was caused by the fact that now KURL accepts "http:/example.com" (note only one
slash) and our test case used a strange edge case that's transformed into a
"one-slash" URL that now KURL can handle.

QtWebKit approach in this case is to do a best effort and accept the QUrl if KURL
can understand it. So I've updated the test to use a more meaningful example and
show that an invalid URL gets converted to a valid URL if possible.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::setUrlToInvalid):
9:27 AM Changeset in webkit [87817] by sjl@chromium.org
  • 5 edits
    4 deletes in trunk/LayoutTests

2011-06-01 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Remove layout test http/tests/media/video-seekable-stall

http/tests/media/video-seekable-stall.html fails on the Leopard Commit Queue Machine
https://bugs.webkit.org/show_bug.cgi?id=35271

  • http/tests/media/video-seekable-stall-expected.txt: Removed.
  • http/tests/media/video-seekable-stall.html: Removed.
  • platform/chromium-linux/http/tests/media/video-seekable-stall-expected.png: Removed.
  • platform/chromium-win/http/tests/media/video-seekable-stall-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/win/Skipped:
9:22 AM Changeset in webkit [87816] by mario@webkit.org
  • 1 edit
    25 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, added new baselines for GTK after r87779.

  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/gtk/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/gtk/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/gtk/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/gtk/svg/hixie/intrinsic/003-expected.txt: Added.
9:15 AM Changeset in webkit [87815] by abarth@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

2011-06-01 Adam Barth <abarth@webkit.org>

Add baselines for these tests.

  • platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
9:14 AM Changeset in webkit [87814] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, added new baseline for GTK after r87726.

  • platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt: Added.
  • platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.png: Added.
9:14 AM Changeset in webkit [87813] by mario@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, added new baselines for GTK after r87721.

  • platform/gtk/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/gtk/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/gtk/svg/custom/invalid-uri-stroke-expected.txt: Added.
  • platform/gtk/svg/custom/invalid-uri-stroke-expected.png: Added.
9:13 AM Changeset in webkit [87812] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, added new baseline for GTK after r87680.

  • platform/gtk/svg/filters/feConvolveFilter-y-bounds-expected.txt: Added.
  • platform/gtk/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
9:12 AM Changeset in webkit [87811] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, added new baseline for GTK after r87605.

  • platform/gtk/svg/wicd/test-scalable-background-image2-expected.txt: Added.
  • platform/gtk/svg/wicd/test-scalable-background-image2-expected.png: Added.
9:11 AM Changeset in webkit [87810] by mario@webkit.org
  • 1 edit
    35 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, added new baselines for GTK after r87526.

  • platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Added.
  • platform/gtk/svg/custom/object-no-size-attributes-expected.png: Added.
  • platform/gtk/svg/custom/object-no-size-attributes-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-explicit-height-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-explicit-height-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-explicit-width-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-explicit-width-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-explicit-width-height-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-explicit-width-height-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-no-width-height-change-content-box-size-expected.txt: Added.
  • platform/gtk/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/gtk/svg/custom/object-sizing-no-width-height-expected.txt: Added.
  • platform/gtk/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/gtk/svg/wicd/rightsizing-grid-expected.txt: Added.
  • platform/gtk/svg/wicd/test-rightsizing-a-expected.png: Added.
  • platform/gtk/svg/wicd/test-rightsizing-a-expected.txt: Added.
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.png: Added.
  • platform/gtk/svg/wicd/test-rightsizing-b-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-text-expected.png: Added.
  • platform/gtk/svg/zoom/page/zoom-svg-through-object-with-text-expected.txt: Added.
9:10 AM Changeset in webkit [87809] by mario@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, added new baseline for GTK after r87387.

  • platform/gtk/fast/borders/border-antialiasing-expected.txt: Added.
  • platform/gtk/fast/borders/border-antialiasing-expected.png: Added.
9:08 AM Changeset in webkit [87808] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

2011-06-01 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] run-launcher should run MiniBrowser in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=61858

  • Scripts/run-launcher: Check whether -2 command line option has been passed and run MiniBrowser instead of GtkLauncher.
9:01 AM Changeset in webkit [87807] by zimmermann@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

SVGs with a viewbox specified do not seem to work as SVGImages
https://bugs.webkit.org/show_bug.cgi?id=16517

SVGs with a viewBox work as background image nowadays, add a testcase covering it, originally from Beth Dakin.

  • platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.png: Added.
  • platform/mac/svg/as-image/svg-as-background-with-viewBox-expected.txt: Added.
  • svg/as-image/resources/green-relative-size-rect-with-viewBox.svg: Added.
  • svg/as-image/svg-as-background-with-viewBox.html: Added.
8:28 AM Changeset in webkit [87806] by Adam Roben
  • 7 edits
    1 add in trunk/Source/WebKit2

Route plugin window geometry updates through the DrawingArea

This will allow the geometry updates to be handled by the LayerTreeHost in compositing mode
in the future.

More rep work for <http://webkit.org/b/58054> <rdar://problem/9249839> REGRESSION (WebKit2):
Accelerated CSS animations have a lower framerate than in WebKit1

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate): Tell the DrawingArea, not the
WebPage, about the geometry update.

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/win/DrawingAreaImplWin.cpp: Added.

(WebKit::DrawingAreaImpl::scheduleChildWindowGeometryUpdate):
Moved code here...

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/win/WebPageWin.cpp:

...from here.

  • win/WebKit2.vcproj: Added DrawingAreaImplWin.cpp.
8:12 AM Changeset in webkit [87805] by Adam Roben
  • 4 edits
    2 adds in trunk/Source/WebKit2

Move WebView's window geometry updating code to a new class

This will allow us to share this code with LayerTreeHostCAWin.

Prep work for <http://webkit.org/b/58054> <rdar://problem/9249839> REGRESSION (WebKit2):
Accelerated CSS animations have a lower framerate than in WebKit1

Reviewed by Anders Carlsson.

  • Shared/win/CoalescedWindowGeometriesUpdater.cpp: Added.

(WebKit::CoalescedWindowGeometriesUpdater::CoalescedWindowGeometriesUpdater):
(WebKit::CoalescedWindowGeometriesUpdater::~CoalescedWindowGeometriesUpdater):
Simple constructor/destructor.

(WebKit::CoalescedWindowGeometriesUpdater::addPendingUpdate):
(WebKit::setWindowRegion):
(WebKit::CoalescedWindowGeometriesUpdater::updateGeometries):

  • Shared/win/CoalescedWindowGeometriesUpdater.h: Added.

Moved code here...

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::scheduleChildWindowGeometryUpdate):
(WebKit::WebView::updateChildWindowGeometries):

  • UIProcess/win/WebView.h:

...from here.

  • win/WebKit2.vcproj: Added new files.
7:51 AM Changeset in webkit [87804] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Windows build fix after r87755

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled): Fixed
typo.

7:34 AM Changeset in webkit [87803] by yurys@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-06-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: allow opening inspector for existing workers
https://bugs.webkit.org/show_bug.cgi?id=61853

Added sidebar pane with a list of all workers. Each worker has a check box
that allows opening inspector for the worker.

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
  • inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::didStartWorkerContext):
  • inspector/InspectorWorkerAgent.cpp: (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::connectToWorkerContext): (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::disconnectFromWorkerContext): (WebCore::InspectorWorkerAgent::clearFrontend): (WebCore::InspectorWorkerAgent::connectToWorker): (WebCore::InspectorWorkerAgent::disconnectFromWorker): (WebCore::InspectorWorkerAgent::didStartWorkerContext):
  • inspector/InspectorWorkerAgent.h:
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
  • inspector/front-end/Settings.js:
  • inspector/front-end/WorkerManager.js: (WebInspector.WorkerManager): (WebInspector.WorkerManager.prototype._workerCreated): (WebInspector.WorkerManager.prototype._sendMessageToWorkerInspector): (WebInspector.WorkerManager.prototype.openWorkerInspector): (WebInspector.WorkerManager.prototype.closeWorkerInspector): (WebInspector.WorkerManager.prototype._workerInspectorClosing): (WebInspector.WorkerMessageForwarder): (WebInspector.WorkerMessageForwarder.prototype.workerCreated): (WebInspector.WorkerMessageForwarder.prototype.dispatchMessageFromWorker):
  • inspector/front-end/WorkersSidebarPane.js: (WebInspector.WorkersSidebarPane): (WebInspector.WorkersSidebarPane.prototype.addWorker): (WebInspector.WorkerListSidebarPane): (WebInspector.WorkerListSidebarPane.prototype._workerAdded): (WebInspector.WorkerListSidebarPane.prototype._workerRemoved): (WebInspector.WorkerListSidebarPane.prototype._workerInspectorClosed): (WebInspector.WorkerListSidebarPane.prototype._addWorker): (WebInspector.WorkerListSidebarPane.prototype._createCheckbox): (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
  • workers/Worker.cpp: (WebCore::Worker::notifyFinished):
7:32 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
Adding note on Fshell (diff)
7:29 AM BuildingQtOnSymbian edited by siddharth.mathur@nokia.com
added note on GCC 4.4 with Qt SDK 1.1. (diff)
7:15 AM QtWebKitGardening edited by andreas.kling@nokia.com
(diff)
7:11 AM Changeset in webkit [87802] by commit-queue@webkit.org
  • 13 edits in trunk

2011-06-01 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Renaming the Page Visibility attributes as per the modified spec draft.
https://bugs.webkit.org/show_bug.cgi?id=61825

Spec draft:
http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html

  • Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
  • The attribute webkitIsVisible needs to change to webkitHidden
  • fast/events/page-visibility-iframe-delete-test.html:
  • fast/events/page-visibility-iframe-move-test-expected.txt:
  • fast/events/page-visibility-iframe-move-test.html:
  • fast/events/page-visibility-iframe-propagation-test-expected.txt:
  • fast/events/page-visibility-iframe-propagation-test.html:
  • fast/events/page-visibility-transition-test-expected.txt:
  • fast/events/page-visibility-transition-test.html:

2011-06-01 Shishir Agrawal <shishir@chromium.org>

Reviewed by Tony Gentilcore.

Renaming the Page Visibility attributes as per the modified spec draft.
https://bugs.webkit.org/show_bug.cgi?id=61825

Spec draft:
http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PageVisibility/Overview.html

  • Event needs to be webkitVisibilityChange from webkitVisibilityStateChange
  • The attribute webkitIsVisible needs to change to webkitHidden
  • dom/Document.cpp: (WebCore::Document::webkitHidden): (WebCore::Document::dispatchVisibilityStateChangeEvent):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/EventNames.h:
7:10 AM Changeset in webkit [87801] by zimmermann@webkit.org
  • 8 edits in trunk/Source/WebCore

2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

Remove duplicated code in various computeReplacedLogical*() functions
https://bugs.webkit.org/show_bug.cgi?id=61860

Centralize this calculation in RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth:
int minLogicalWidth = computeReplacedLogicalWidthUsing(style()->logicalMinWidth());

int maxLogicalWidth = !includeMaxWidth
style()->logicalMaxWidth().isUndefined() ? logicalWidth : computeReplacedLogicalWidthUsing(style()->logicalMaxWidth());

return max(minLogicalWidth, min(logicalWidth, maxLogicalWidth));

Centralize this calculation in RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight:
int minLogicalHeight = computeReplacedLogicalHeightUsing(style()->logicalMinHeight());
int maxLogicalHeight = style()->logicalMaxHeight().isUndefined() ? logicalHeight : computeReplacedLogicalHeightUsing(style()->logicalMaxHeight());
return max(minLogicalHeight, min(logicalHeight, maxLogicalHeight));

Use the new helper methods where possible, deduplicating lots of code.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::computeReplacedLogicalWidth): (WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth): (WebCore::RenderBox::computeReplacedLogicalHeight): (WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
  • rendering/RenderBox.h:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::computeReplacedLogicalWidth): (WebCore::RenderImage::computeReplacedLogicalHeight):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::computeEmbeddedDocumentReplacedWidth): (WebCore::RenderPart::computeEmbeddedDocumentReplacedHeight): (WebCore::RenderPart::computeReplacedLogicalWidth): (WebCore::RenderPart::computeReplacedLogicalHeight):
  • rendering/RenderPart.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeReplacedLogicalWidth): (WebCore::RenderReplaced::computeReplacedLogicalHeight):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): (WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
6:51 AM QtWebKitGardening edited by andreas.kling@nokia.com
(diff)
6:48 AM Changeset in webkit [87800] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Gabor Loki <loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

Skip a flakey test on ARM.

  • platform/qt-arm/Skipped:
6:31 AM QtWebKitGardening edited by andreas.kling@nokia.com
(diff)
6:21 AM QtWebKitGardening edited by andreas.kling@nokia.com
(diff)
6:04 AM Changeset in webkit [87799] by commit-queue@webkit.org
  • 12 edits in trunk/Source

2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87788.
http://trac.webkit.org/changeset/87788
https://bugs.webkit.org/show_bug.cgi?id=61856

breaks windows chromium canary (Requested by jknotten on
#webkit).

  • wtf/DateMath.cpp: (WTF::timeClip):
  • wtf/DateMath.h:

2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87788.
http://trac.webkit.org/changeset/87788
https://bugs.webkit.org/show_bug.cgi?id=61856

breaks windows chromium canary (Requested by jknotten on
#webkit).

  • loader/archive/mhtml/MHTMLArchive.cpp:
  • loader/archive/mhtml/MHTMLArchive.h:
  • page/PageSerializer.cpp: (WebCore::PageSerializer::serializeFrame): (WebCore::PageSerializer::serializeCSSStyleSheet):
  • platform/SharedBuffer.cpp:
  • platform/SharedBuffer.h:

2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87788.
http://trac.webkit.org/changeset/87788
https://bugs.webkit.org/show_bug.cgi?id=61856

breaks windows chromium canary (Requested by jknotten on
#webkit).

  • public/WebPageSerializer.h:
  • src/WebPageSerializer.cpp:
5:44 AM Changeset in webkit [87798] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[WK2] Skip new failing test because of missing SVG animation pause API.

  • platform/mac-wk2/Skipped:
5:42 AM QtWebKitGardening created by andreas.kling@nokia.com
5:39 AM Changeset in webkit [87797] by andreas.kling@nokia.com
  • 3 edits in trunk/Source/WebKit/qt

2011-06-01 Andreas Kling <kling@webkit.org>

Reviewed by Benjamin Poulain.

REGRESSION: [Qt] QNetworkReply delivered by the unsupportedContent() signal does not contain downloaded data
https://bugs.webkit.org/show_bug.cgi?id=49650

Defer emission of QWebPage::unsupportedContent() until we're back in the event loop.
This lets the QNAM backend finish with the reply without handing over ownership to the user code.

No new tests since this doesn't fail for qrc:// or file:// URLs and our tests can't depend on http:// URLs.

To correctly solve this issue, we need changes to Qt, tracked here:
http://bugreports.qt.nokia.com/browse/QTBUG-18718

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setFrame): (WebCore::FrameLoaderClientQt::download):
  • WebCoreSupport/FrameLoaderClientQt.h:
5:16 AM Changeset in webkit [87796] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebKit/qt

2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Tor Arne Vestbø.

[Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals
https://bugs.webkit.org/show_bug.cgi?id=61739

The skipped test was imported from Qt source repository, and used private headers
to peek in the QML Grid element. This patch changes the QML used to expose the
information we want to test: number of pages opened and the first page opened.

  • tests/qdeclarativewebview/resources/newwindows.html: Added <body> tags. We have no reason to not use them in the test.
  • tests/qdeclarativewebview/resources/newwindows.qml: Moved the timer out of the page component, used anchors for setting webview size, changed the way we count pages opened. Also changed coding style a bit.
  • tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: (tst_QDeclarativeWebView::multipleWindows): We now look for properties with the information we want in the rootItem: pagesOpened and firstPageOpened.
5:01 AM Changeset in webkit [87795] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping flaky test on GTK 64-bit bot.

  • platform/gtk/Skipped: Skipped test.
4:52 AM QtWebKitForQt5 edited by jocelyn.turcotte@nokia.com
(diff)
4:40 AM Changeset in webkit [87794] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-06-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kent Tamura.

[EFL] Add null checking condition to EditorClientEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=61846

Add null checking condition for using settings() of frame.

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::handleEditingKeyboardEvent):
4:17 AM Changeset in webkit [87793] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

2011-06-01 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: [JSC] JSLock ASSERTs Seen Under eventListenerHandlerBody
https://bugs.webkit.org/show_bug.cgi?id=61835

Add a JSLock call before possible allocations in jsFunction and toString.

  • bindings/js/ScriptEventListener.cpp: (WebCore::eventListenerHandlerBody):
4:03 AM Changeset in webkit [87792] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed trivial fix after r87778.

  • platform/qt/Skipped: Rename editing/pasteboard/4861080.html to editing/pasteboard/drag-drop-list.html.
2:53 AM Changeset in webkit [87791] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-06-01 Gabor Loki <loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Skip flakey tests on ARM

  • platform/qt-arm/Skipped:
2:40 AM Changeset in webkit [87790] by jknotten@chromium.org
  • 1 edit
    76 adds in trunk/LayoutTests

2011-06-01 John Knottenbelt <jknotten@chromium.org>

Unreviewed.

[Chromium] Add in baselines for new SVG tests following https://bugs.webkit.org/show_bug.cgi?id=15473
https://bugs.webkit.org/show_bug.cgi?id=61849

  • platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/002-expected.txt: Added.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/chromium-linux-x86/svg/hixie/intrinsic/003-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-linux/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/chromium-linux/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/chromium-linux/svg/hixie/intrinsic/002-expected.txt: Added.
  • platform/chromium-linux/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/chromium-linux/svg/hixie/intrinsic/003-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/chromium-win-vista/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/chromium-win-vista/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/chromium-win-vista/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/chromium-win-vista/svg/hixie/intrinsic/002-expected.txt: Added.
  • platform/chromium-win-vista/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/chromium-win-vista/svg/hixie/intrinsic/003-expected.txt: Added.
2:23 AM Changeset in webkit [87789] by mario@webkit.org
  • 5 edits in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed. Test rebaselines for GTK after revision 87526.

  • platform/gtk/svg/hixie/text/003-expected.png:
  • platform/gtk/svg/hixie/text/003-expected.txt:
  • platform/gtk/svg/in-html/by-reference-expected.txt:
  • platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
2:17 AM Changeset in webkit [87788] by jcivelli@chromium.org
  • 12 edits in trunk/Source

2011-06-01 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Added a method to generate RFC 2822 compliant date strings.
https://bugs.webkit.org/show_bug.cgi?id=7169

  • wtf/DateMath.cpp: (WTF::twoDigitStringFromNumber): (WTF::makeRFC2822DateString):
  • wtf/DateMath.h:

2011-06-01 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML generation support to MHTMLArchive.
https://bugs.webkit.org/show_bug.cgi?id=7169

  • loader/archive/mhtml/MHTMLArchive.cpp: (WebCore::generateRandomBoundary): (WebCore::replaceNonPrintableCharacters): (WebCore::MHTMLArchive::generateMHTMLData):
  • loader/archive/mhtml/MHTMLArchive.h:
  • page/PageSerializer.cpp: (WebCore::PageSerializer::serializeFrame): (WebCore::PageSerializer::serializeCSSStyleSheet):
  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::append):
  • platform/SharedBuffer.h:

2011-06-01 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding MHTML generation support to MHTMLArchive.
https://bugs.webkit.org/show_bug.cgi?id=7169

  • public/WebPageSerializer.h:
  • src/WebPageSerializer.cpp: (WebKit::WebPageSerializer::serializeToMHTML):
2:10 AM Changeset in webkit [87787] by zimmermann@webkit.org
  • 1 edit
    2 moves
    1 delete in trunk/LayoutTests

2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

REGRESSION: fast/images/svg-background-crash-on-refresh.html hangs
https://bugs.webkit.org/show_bug.cgi?id=15483

The regression seems gone, I can't reproduce it anymore, reenable svg-background-crash-on-refresh.html.
Convert the test to use dumpAsText() and actually execute the refreshing twice, including forced gc
to see whether we crash on referesh or not, before it didn't actually reload. If a crash happened,
it happened somewhen after executing this test, which is probably why it was flakey.

  • platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.png: Removed.
  • platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt: Removed.
  • svg/as-image/svg-background-crash-on-refresh-expected.txt: Copied from platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt.
  • svg/as-image/svg-background-crash-on-refresh.html: Copied from svg/as-image/svg-background-crash-on-refresh.html-disabled.
  • svg/as-image/svg-background-crash-on-refresh.html-disabled: Removed.
1:47 AM Changeset in webkit [87786] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-31 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
https://bugs.webkit.org/show_bug.cgi?id=61803

  • WebKit.gyp:
  • scripts/generate_devtools_zip.py:
1:29 AM Changeset in webkit [87785] by mario@webkit.org
  • 5 edits in trunk/LayoutTests

2011-06-01 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed. Test rebaselines for GTK after revision 87721.

  • platform/gtk/svg/custom/invalid-fill-expected.png:
  • platform/gtk/svg/custom/invalid-fill-expected.txt:
  • platform/gtk/svg/custom/invalid-fill-hex-expected.png:
  • platform/gtk/svg/custom/invalid-fill-hex-expected.txt:
1:07 AM Changeset in webkit [87784] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-06-01 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r87781.
http://trac.webkit.org/changeset/87781
https://bugs.webkit.org/show_bug.cgi?id=61842

breaks chromium linux release (Requested by mnaganov on
#webkit).

  • WebKit.gyp:
  • scripts/generate_devtools_zip.py:
1:04 AM Changeset in webkit [87783] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-06-01 Oleg Romashin <romaxa@gmail.com>

Reviewed by Kenneth Rohde Christiansen.

platformGeometryDidChange function definition was changed everywhere except Qt.
This is fix for Qt WK2 plugins compilation
https://bugs.webkit.org/show_bug.cgi?id=61832

  • PluginProcess/qt/PluginControllerProxyQt.cpp: (WebKit::PluginControllerProxy::platformGeometryDidChange):
1:02 AM Changeset in webkit [87782] by zimmermann@webkit.org
  • 5 edits
    72 moves
    10 adds in trunk/LayoutTests

2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Adam Barth.

Move fast/images/*svg* to svg/as-image/
https://bugs.webkit.org/show_bug.cgi?id=61840

The SVG crowd regulary runs pixel tests, and we'd like to also include the SVG-as-image tests in our daily runs.
Also it makes more sense to have these tests in a single place, just like eg. svg/in-html (html5+svg).

  • fast/images/animated-svg-as-image.html: Removed.
  • fast/images/drag-svg-as-image-expected.txt: Removed.
  • fast/images/drag-svg-as-image.html: Removed.
  • fast/images/resources/animated-rect-fixed-size.svg: Removed.
  • fast/images/resources/animated-rect-relative-size.svg: Removed.
  • fast/images/resources/butterfly.svg: Removed.
  • fast/images/resources/circle.svg: Removed.
  • fast/images/resources/green-fixed-size-rect.svg: Removed.
  • fast/images/resources/green-relative-size-rect.svg: Removed.
  • fast/images/resources/load-script.html: Removed.
  • fast/images/resources/width-100-percent.svg: Removed.
  • fast/images/svg-as-background.html: Removed.
  • fast/images/svg-as-image.html: Removed.
  • fast/images/svg-as-relative-image.html: Removed.
  • fast/images/svg-as-tiled-background.html: Removed.
  • fast/images/svg-background-crash-on-refresh.html-disabled: Removed.
  • fast/images/svg-background-partial-redraw.html: Removed.
  • fast/images/svg-image-leak-loader-expected.txt: Removed.
  • fast/images/svg-image-leak-loader.html: Removed.
  • fast/images/svg-nested-expected.txt: Removed.
  • fast/images/svg-nested.html: Removed.
  • fast/images/svg-width-100p-as-background.html: Removed.
  • platform/chromium-linux/fast/images/animated-svg-as-image-expected.png: Removed.
  • platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-linux/svg/as-image: Added.
  • platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/chromium-linux/fast/images/animated-svg-as-image-expected.png.
  • platform/chromium-linux/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png.
  • platform/chromium-mac-leopard/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-mac-leopard/svg/as-image: Added.
  • platform/chromium-mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac-leopard/fast/images/svg-background-partial-redraw-expected.png.
  • platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-mac/svg/as-image: Added.
  • platform/chromium-mac/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png.
  • platform/chromium-win/fast/images/animated-svg-as-image-expected.png: Removed.
  • platform/chromium-win/fast/images/animated-svg-as-image-expected.txt: Removed.
  • platform/chromium-win/fast/images/svg-as-background-expected.txt: Removed.
  • platform/chromium-win/fast/images/svg-as-tiled-background-expected.txt: Removed.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Removed.
  • platform/chromium-win/fast/images/svg-width-100p-as-background-expected.txt: Removed.
  • platform/chromium-win/svg/as-image: Added.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/chromium-win/fast/images/animated-svg-as-image-expected.png.
  • platform/chromium-win/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/chromium-win/fast/images/animated-svg-as-image-expected.txt.
  • platform/chromium-win/svg/as-image/svg-as-background-expected.txt: Copied from platform/chromium-win/fast/images/svg-as-background-expected.txt.
  • platform/chromium-win/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/chromium-win/fast/images/svg-as-tiled-background-expected.txt.
  • platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png.
  • platform/chromium-win/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt.
  • platform/chromium-win/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/chromium-win/fast/images/svg-width-100p-as-background-expected.txt.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/fast/images/animated-svg-as-image-expected.png: Removed.
  • platform/gtk/fast/images/animated-svg-as-image-expected.txt: Removed.
  • platform/gtk/fast/images/svg-as-background-expected.png: Removed.
  • platform/gtk/fast/images/svg-as-background-expected.txt: Removed.
  • platform/gtk/fast/images/svg-as-image-expected.png: Removed.
  • platform/gtk/fast/images/svg-as-image-expected.txt: Removed.
  • platform/gtk/fast/images/svg-as-relative-image-expected.png: Removed.
  • platform/gtk/fast/images/svg-as-relative-image-expected.txt: Removed.
  • platform/gtk/fast/images/svg-as-tiled-background-expected.png: Removed.
  • platform/gtk/fast/images/svg-as-tiled-background-expected.txt: Removed.
  • platform/gtk/fast/images/svg-background-partial-redraw-expected.txt: Removed.
  • platform/gtk/fast/images/svg-width-100p-as-background-expected.png: Removed.
  • platform/gtk/fast/images/svg-width-100p-as-background-expected.txt: Removed.
  • platform/gtk/svg/as-image: Added.
  • platform/gtk/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/gtk/fast/images/animated-svg-as-image-expected.png.
  • platform/gtk/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/gtk/fast/images/animated-svg-as-image-expected.txt.
  • platform/gtk/svg/as-image/svg-as-background-expected.png: Copied from platform/gtk/fast/images/svg-as-background-expected.png.
  • platform/gtk/svg/as-image/svg-as-background-expected.txt: Copied from platform/gtk/fast/images/svg-as-background-expected.txt.
  • platform/gtk/svg/as-image/svg-as-image-expected.png: Copied from platform/gtk/fast/images/svg-as-image-expected.png.
  • platform/gtk/svg/as-image/svg-as-image-expected.txt: Copied from platform/gtk/fast/images/svg-as-image-expected.txt.
  • platform/gtk/svg/as-image/svg-as-relative-image-expected.png: Copied from platform/gtk/fast/images/svg-as-relative-image-expected.png.
  • platform/gtk/svg/as-image/svg-as-relative-image-expected.txt: Copied from platform/gtk/fast/images/svg-as-relative-image-expected.txt.
  • platform/gtk/svg/as-image/svg-as-tiled-background-expected.png: Copied from platform/gtk/fast/images/svg-as-tiled-background-expected.png.
  • platform/gtk/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/gtk/fast/images/svg-as-tiled-background-expected.txt.
  • platform/gtk/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/gtk/fast/images/svg-background-partial-redraw-expected.txt.
  • platform/gtk/svg/as-image/svg-width-100p-as-background-expected.png: Copied from platform/gtk/fast/images/svg-width-100p-as-background-expected.png.
  • platform/gtk/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/gtk/fast/images/svg-width-100p-as-background-expected.txt.
  • platform/mac-leopard/fast/images/animated-svg-as-image-expected.png: Removed.
  • platform/mac-leopard/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/mac-leopard/svg/as-image: Added.
  • platform/mac-leopard/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/mac-leopard/fast/images/animated-svg-as-image-expected.png.
  • platform/mac-leopard/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/mac-leopard/fast/images/svg-background-partial-redraw-expected.png.
  • platform/mac/fast/images/animated-svg-as-image-expected.png: Removed.
  • platform/mac/fast/images/animated-svg-as-image-expected.txt: Removed.
  • platform/mac/fast/images/svg-as-background-expected.png: Removed.
  • platform/mac/fast/images/svg-as-background-expected.txt: Removed.
  • platform/mac/fast/images/svg-as-image-expected.png: Removed.
  • platform/mac/fast/images/svg-as-image-expected.txt: Removed.
  • platform/mac/fast/images/svg-as-relative-image-expected.png: Removed.
  • platform/mac/fast/images/svg-as-relative-image-expected.txt: Removed.
  • platform/mac/fast/images/svg-as-tiled-background-expected.png: Removed.
  • platform/mac/fast/images/svg-as-tiled-background-expected.txt: Removed.
  • platform/mac/fast/images/svg-background-crash-on-refresh-expected.png: Removed.
  • platform/mac/fast/images/svg-background-crash-on-refresh-expected.txt: Removed.
  • platform/mac/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/mac/fast/images/svg-background-partial-redraw-expected.txt: Removed.
  • platform/mac/fast/images/svg-width-100p-as-background-expected.png: Removed.
  • platform/mac/fast/images/svg-width-100p-as-background-expected.txt: Removed.
  • platform/mac/svg/as-image: Added.
  • platform/mac/svg/as-image/animated-svg-as-image-expected.png: Copied from platform/mac/fast/images/animated-svg-as-image-expected.png.
  • platform/mac/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/mac/fast/images/animated-svg-as-image-expected.txt.
  • platform/mac/svg/as-image/svg-as-background-expected.png: Copied from platform/mac/fast/images/svg-as-background-expected.png.
  • platform/mac/svg/as-image/svg-as-background-expected.txt: Copied from platform/mac/fast/images/svg-as-background-expected.txt.
  • platform/mac/svg/as-image/svg-as-image-expected.png: Copied from platform/mac/fast/images/svg-as-image-expected.png.
  • platform/mac/svg/as-image/svg-as-image-expected.txt: Copied from platform/mac/fast/images/svg-as-image-expected.txt.
  • platform/mac/svg/as-image/svg-as-relative-image-expected.png: Copied from platform/mac/fast/images/svg-as-relative-image-expected.png.
  • platform/mac/svg/as-image/svg-as-relative-image-expected.txt: Copied from platform/mac/fast/images/svg-as-relative-image-expected.txt.
  • platform/mac/svg/as-image/svg-as-tiled-background-expected.png: Copied from platform/mac/fast/images/svg-as-tiled-background-expected.png.
  • platform/mac/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/mac/fast/images/svg-as-tiled-background-expected.txt.
  • platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.png: Copied from platform/mac/fast/images/svg-background-crash-on-refresh-expected.png.
  • platform/mac/svg/as-image/svg-background-crash-on-refresh-expected.txt: Copied from platform/mac/fast/images/svg-background-crash-on-refresh-expected.txt.
  • platform/mac/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/mac/fast/images/svg-background-partial-redraw-expected.png.
  • platform/mac/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/mac/fast/images/svg-background-partial-redraw-expected.txt.
  • platform/mac/svg/as-image/svg-width-100p-as-background-expected.png: Copied from platform/mac/fast/images/svg-width-100p-as-background-expected.png.
  • platform/mac/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/mac/fast/images/svg-width-100p-as-background-expected.txt.
  • platform/qt-mac/Skipped:
  • platform/qt-wk2/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/images/animated-svg-as-image-expected.txt: Removed.
  • platform/qt/fast/images/svg-as-background-expected.txt: Removed.
  • platform/qt/fast/images/svg-as-image-expected.txt: Removed.
  • platform/qt/fast/images/svg-as-relative-image-expected.txt: Removed.
  • platform/qt/fast/images/svg-as-tiled-background-expected.txt: Removed.
  • platform/qt/fast/images/svg-background-partial-redraw-expected.png: Removed.
  • platform/qt/fast/images/svg-background-partial-redraw-expected.txt: Removed.
  • platform/qt/fast/images/svg-width-100p-as-background-expected.txt: Removed.
  • platform/qt/svg/as-image: Added.
  • platform/qt/svg/as-image/animated-svg-as-image-expected.txt: Copied from platform/qt/fast/images/animated-svg-as-image-expected.txt.
  • platform/qt/svg/as-image/svg-as-background-expected.txt: Copied from platform/qt/fast/images/svg-as-background-expected.txt.
  • platform/qt/svg/as-image/svg-as-image-expected.txt: Copied from platform/qt/fast/images/svg-as-image-expected.txt.
  • platform/qt/svg/as-image/svg-as-relative-image-expected.txt: Copied from platform/qt/fast/images/svg-as-relative-image-expected.txt.
  • platform/qt/svg/as-image/svg-as-tiled-background-expected.txt: Copied from platform/qt/fast/images/svg-as-tiled-background-expected.txt.
  • platform/qt/svg/as-image/svg-background-partial-redraw-expected.png: Copied from platform/qt/fast/images/svg-background-partial-redraw-expected.png.
  • platform/qt/svg/as-image/svg-background-partial-redraw-expected.txt: Copied from platform/qt/fast/images/svg-background-partial-redraw-expected.txt.
  • platform/qt/svg/as-image/svg-width-100p-as-background-expected.txt: Copied from platform/qt/fast/images/svg-width-100p-as-background-expected.txt.
  • svg/as-image: Added.
  • svg/as-image/animated-svg-as-image.html: Copied from fast/images/animated-svg-as-image.html.
  • svg/as-image/drag-svg-as-image-expected.txt: Copied from fast/images/drag-svg-as-image-expected.txt.
  • svg/as-image/drag-svg-as-image.html: Copied from fast/images/drag-svg-as-image.html.
  • svg/as-image/resources: Added.
  • svg/as-image/resources/animated-rect-fixed-size.svg: Copied from fast/images/resources/animated-rect-fixed-size.svg.
  • svg/as-image/resources/animated-rect-relative-size.svg: Copied from fast/images/resources/animated-rect-relative-size.svg.
  • svg/as-image/resources/butterfly.svg: Copied from fast/images/resources/butterfly.svg.
  • svg/as-image/resources/circle.svg: Copied from fast/images/resources/circle.svg.
  • svg/as-image/resources/green-fixed-size-rect.svg: Copied from fast/images/resources/green-fixed-size-rect.svg.
  • svg/as-image/resources/green-relative-size-rect.svg: Copied from fast/images/resources/green-relative-size-rect.svg.
  • svg/as-image/resources/load-script.html: Copied from fast/images/resources/load-script.html.
  • svg/as-image/resources/width-100-percent.svg: Copied from fast/images/resources/width-100-percent.svg.
  • svg/as-image/svg-as-background.html: Copied from fast/images/svg-as-background.html.
  • svg/as-image/svg-as-image.html: Copied from fast/images/svg-as-image.html.
  • svg/as-image/svg-as-relative-image.html: Copied from fast/images/svg-as-relative-image.html.
  • svg/as-image/svg-as-tiled-background.html: Copied from fast/images/svg-as-tiled-background.html.
  • svg/as-image/svg-background-crash-on-refresh.html-disabled: Copied from fast/images/svg-background-crash-on-refresh.html-disabled.
  • svg/as-image/svg-background-partial-redraw.html: Copied from fast/images/svg-background-partial-redraw.html.
  • svg/as-image/svg-image-leak-loader-expected.txt: Copied from fast/images/svg-image-leak-loader-expected.txt.
  • svg/as-image/svg-image-leak-loader.html: Copied from fast/images/svg-image-leak-loader.html.
  • svg/as-image/svg-nested-expected.txt: Copied from fast/images/svg-nested-expected.txt.
  • svg/as-image/svg-nested.html: Copied from fast/images/svg-nested.html.
  • svg/as-image/svg-width-100p-as-background.html: Copied from fast/images/svg-width-100p-as-background.html.
12:46 AM Changeset in webkit [87781] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-31 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
https://bugs.webkit.org/show_bug.cgi?id=61803

  • WebKit.gyp:
  • scripts/generate_devtools_zip.py:
12:40 AM Changeset in webkit [87780] by Dimitri Glazkov
  • 11 edits
    2 deletes in trunk/Source/WebCore

2011-06-01 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Kent Tamura.

Remove ShadowElement and compact remaining used bits into RenderFileUploadControl.
https://bugs.webkit.org/show_bug.cgi?id=61816

This is a near-mechanical move-and-rename of ShadowElement, which is now only
used by input[type=file]. Next step -- switch it over to new shadow DOM.

Refactoring, no change in behavior.

  • CMakeLists.txt: Removed ShadowElement.cpp and ShadowElement.h.
  • GNUmakefile.list.am: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore/WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCore/rendering/RenderingAllInOne.cpp: Ditto.
  • rendering/RenderFileUploadControl.cpp: (WebCore::UploadButton::create): Moved from ShadowElement, renamed as UploadButton. (WebCore::UploadButton::detach): Ditto. (WebCore::UploadButton::UploadButton): Ditto. (WebCore::RenderFileUploadControl::updateFromElement): Changed to use UploadButton.
  • rendering/RenderMeter.cpp: Removed ShadowElement.h include, which is no longer used.
  • rendering/RenderProgress.cpp: Ditto.
  • rendering/ShadowElement.cpp: Removed.
  • rendering/ShadowElement.h: Removed.
12:30 AM Changeset in webkit [87779] by zimmermann@webkit.org
  • 5 edits
    54 adds in trunk

2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

SVG fails all 3 of Hixie's CSS intrinsic sizing tests
https://bugs.webkit.org/show_bug.cgi?id=15473

Hixies CSS intrinsic sizing tests cover percentage sizes specified on the target SVG document as width/height attributes
and using width: auto / height: auto on the <object> that hosts the SVG document. Take percentage sizes of the outermost
SVGs width/height attributes into account when determining the intrinsic size of the <object>.

Added several other testcases demonstrating several scenarios. All tests work exactly the same in WebKit and Firefox now.
The *on-target-svg-absolute.xhtml tests look equal to WebKit/FF but Opera fails them, likely a relict of the different
interpretation of the intrinsic size of a SVG document in SVG Tiny 1.2.

  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
  • platform/mac/svg/hixie/intrinsic: Added.
  • platform/mac/svg/hixie/intrinsic/001-expected.png: Added.
  • platform/mac/svg/hixie/intrinsic/001-expected.txt: Added.
  • platform/mac/svg/hixie/intrinsic/002-expected.png: Added.
  • platform/mac/svg/hixie/intrinsic/002-expected.txt: Added.
  • platform/mac/svg/hixie/intrinsic/003-expected.png: Added.
  • platform/mac/svg/hixie/intrinsic/003-expected.txt: Added.
  • svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml: Added.
  • svg/custom/object-sizing-height-50p-on-target-svg.xhtml: Added.
  • svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml: Added.
  • svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml: Added.
  • svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml: Added.
  • svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml: Added.
  • svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml: Added.
  • svg/custom/object-sizing-width-50p-on-target-svg.xhtml: Added.
  • svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml: Added.
  • svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml: Added.
  • svg/custom/resources/object-sizing-height-50p.svg: Added.
  • svg/custom/resources/object-sizing-width-50p-height-50p.svg: Added.
  • svg/custom/resources/object-sizing-width-50p-height-75p.svg: Added.
  • svg/custom/resources/object-sizing-width-50p.svg: Added.
  • svg/custom/resources/object-sizing-width-75p-height-50p.svg: Added.
  • svg/hixie/intrinsic: Added.
  • svg/hixie/intrinsic/001.html: Added.
  • svg/hixie/intrinsic/002.html: Added.
  • svg/hixie/intrinsic/003.html: Added.
  • svg/hixie/intrinsic/resources: Added.
  • svg/hixie/intrinsic/resources/001.svg: Added.
  • svg/hixie/intrinsic/resources/002.svg: Added.
  • svg/hixie/intrinsic/resources/003.svg: Added.
  • svg/hixie/intrinsic/resources/test-bl: Added.
  • svg/hixie/intrinsic/resources/test-br: Added.
  • svg/hixie/intrinsic/resources/test-tl: Added.
  • svg/hixie/intrinsic/resources/test-tr: Added.

2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Rob Buis.

SVG fails all 3 of Hixie's CSS intrinsic sizing tests
https://bugs.webkit.org/show_bug.cgi?id=15473

Hixies CSS intrinsic sizing tests cover percentage sizes specified on the target SVG document as width/height attributes
and using width: auto / height: auto on the <object> that hosts the SVG document. Take percentage sizes of the outermost
SVGs width/height attributes into account when determining the intrinsic size of the <object>.

Added several other testcases demonstrating several scenarios. All tests work exactly the same in WebKit and Firefox now.
The *on-target-svg-absolute.xhtml tests look equal to WebKit/FF but Opera fails them, likely a relict of the different
interpretation of the intrinsic size of a SVG document in SVG Tiny 1.2.

Tests: svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml

svg/custom/object-sizing-height-50p-on-target-svg.xhtml
svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml
svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml
svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml
svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml
svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml
svg/custom/object-sizing-width-50p-on-target-svg.xhtml
svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml
svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml
svg/hixie/intrinsic/001.html
svg/hixie/intrinsic/002.html
svg/hixie/intrinsic/003.html

  • rendering/RenderPart.cpp: (WebCore::RenderPart::computeReplacedLogicalWidth): (WebCore::RenderPart::computeReplacedLogicalHeight):
  • rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::computeIntrinsicRatio):
  • rendering/svg/RenderSVGRoot.h:
12:16 AM Changeset in webkit [87778] by commit-queue@webkit.org
  • 1 edit
    1 move
    1 add
    8 deletes in trunk/LayoutTests

2011-06-01 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Convert editing/pasteboard/4861010 to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61683

Renamed test to drag-drop-list.html, cleaned up html, and updated description.

  • editing/pasteboard/4861080.html: Removed.
  • editing/pasteboard/drag-drop-list.html: Copied from LayoutTests/editing/pasteboard/4861080.html.
  • platform/chromium-linux/editing/pasteboard/4861080-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/4861080-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/4861080-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/4861080-expected.png: Removed.
  • platform/gtk/editing/pasteboard/4861080-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/4861080-expected.png: Removed.
  • platform/mac/editing/pasteboard/4861080-expected.png: Removed.
  • platform/mac/editing/pasteboard/4861080-expected.txt: Removed.

May 31, 2011:

11:57 PM Changeset in webkit [87777] by tkent@chromium.org
  • 2 edits
    1 add
    9 deletes in trunk/LayoutTests

2011-05-31 Kent Tamura <tkent@chromium.org>

Reviewed by Hajime Morita.

Convert fast/forms/date-input-visible-strings.html to dumpAsText().
https://bugs.webkit.org/show_bug.cgi?id=61777

  • fast/forms/date-input-visible-strings.html:
  • fast/forms/date-input-visible-strings-expected.txt: Added.
  • platform/chromium-linux/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/chromium-mac-leopard/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/chromium-win/fast/forms/date-input-visible-strings-expected.txt: Removed.
  • platform/gtk/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/gtk/fast/forms/date-input-visible-strings-expected.txt: Removed.
  • platform/mac/fast/forms/date-input-visible-strings-expected.png: Removed.
  • platform/mac/fast/forms/date-input-visible-strings-expected.txt: Removed.
  • platform/win/fast/forms/date-input-visible-strings-expected.txt: Removed.
11:25 PM Changeset in webkit [87776] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-31 Tonis Tiigi <tonistiigi@gmail.com>

Reviewed by Pavel Feldman.

Web Inspector: Timeline panel improvements for managing current selection
https://bugs.webkit.org/show_bug.cgi?id=61468

Enables X-axis dragging of the selected area.
Double click zoom-out.
Fixes slightly wrong selection area position.

  • inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane): (WebInspector.TimelineOverviewPane.prototype._dragWindow): (WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging): (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight): (WebInspector.TimelineOverviewPane.prototype._resizeWindowMaximum): (WebInspector.TimelineOverviewPane.prototype.scrollWindow): (WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):
  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel):
11:18 PM Changeset in webkit [87775] by commit-queue@webkit.org
  • 2 edits
    1 add
    8 deletes in trunk/LayoutTests

2011-05-31 Annie Sullivan <sullivan@chromium.org>

Reviewed by Ryosuke Niwa.

Convert editing/pasteboard/paste-blockquote-into-blockquote-2.html to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=61682

Convert test to dump-as-markup and clean up HTML. Also update test description.

  • editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
  • editing/pasteboard/paste-blockquote-into-blockquote-2.html:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
  • platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
  • platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
10:54 PM Changeset in webkit [87774] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-31 Hao Zheng <zhenghao@chromium.org>

Reviewed by Dirk Pranke.

Fix exception in verbose printing mode.
https://bugs.webkit.org/show_bug.cgi?id=61723

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
10:46 PM Changeset in webkit [87773] by keishi@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

2011-05-31 Keishi Hattori <keishi@webkit.org>

Reviewed by Kent Tamura.

Fix to enable page scroll of select element
https://bugs.webkit.org/show_bug.cgi?id=53628

Manual test: select-page-scroll.html

  • manual-tests/select-page-scroll.html: Added.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::computeLogicalHeight): Fix min to max.
10:09 PM Changeset in webkit [87772] by kinuko@chromium.org
  • 8 edits
    3 adds in trunk

2011-05-31 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Kent Tamura.

[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823

Added a new test for the fix marked the new test 'skipped' on unsupported platforms.

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • storage/storageinfo-no-callbacks-expected.txt: Added.
  • storage/storageinfo-no-callbacks.html: Added.

2011-05-31 Kinuko Yasuda <kinuko@chromium.org>

Reviewed by Kent Tamura.

[Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
https://bugs.webkit.org/show_bug.cgi?id=61823

Fixed assertion on errorCallback parameter.

Test: storage/quotainfo-no-callbacks.html

  • src/StorageInfoChromium.cpp: (WebCore::StorageInfo::queryUsageAndQuota): (WebCore::StorageInfo::requestQuota):
7:40 PM Changeset in webkit [87771] by commit-queue@webkit.org
  • 10 edits in trunk

2011-05-31 Yong Li <yoli@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=54807
We have been assuming plain bitfields (like "int a : 31") are always signed integers.
However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
rule we should have in order to make our code independent from compilers and compiler flags.

No new test added because this change is not known to fix any issue.

  • bytecode/StructureStubInfo.h:

2011-05-31 Yong Li <yoli@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=54807
We have been assuming plain bitfields (like "int a : 31") are always signed integers.
However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
rule we should have in order to make our code independent from compilers and compiler flags.

No new test added because this change is not known to fix any issue.

  • css/CSSPrimitiveValue.h:
  • css/CSSProperty.h:
  • rendering/InlineBox.h:
  • rendering/RenderBlock.h:

2011-05-31 Yong Li <yoli@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=54807
We have been assuming plain bitfields (like "int a : 31") are always signed integers.
However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
rule we should have in order to make our code independent from compilers and compiler flags.

  • Scripts/webkitpy/style/checkers/cpp.py:
7:39 PM QtWebKitForQt5 edited by noam.rosenthal@nokia.com
(diff)
7:25 PM Changeset in webkit [87770] by morrita@google.com
  • 15 edits
    2 adds in trunk

2011-05-31 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

Send an input event when we change the text direction.
https://bugs.webkit.org/show_bug.cgi?id=50952

This adds a new layout test to verify that we can receive input events
when we change the text direction of a <textarea> element and an <input>
element.

  • fast/html/set-text-direction-expected.txt: Added.
  • fast/html/set-text-direction.html: Added.
  • platform/gtk/Skipped:
  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:

2011-05-31 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

Send an input event when we change the text direction.
https://bugs.webkit.org/show_bug.cgi?id=50952

Both Safari and Chrome call Editor::setBaseWritingDirection() to change
the text direction of an editable element with their UIs. This change
calls dispatchInputEvent() to send an input event when the function
actually changes the "dir" attribute so we can send an input event as
written in the HTML5 spec.

Test: fast/html/set-text-direction.html

  • editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection):

2011-05-31 Hironori Bono <hbono@chromium.org>

Reviewed by Eric Seidel.

Add a JavaScript function layoutTestController.setTextDirection().
https://bugs.webkit.org/show_bug.cgi?id=50952

This change adds a new JavaScript function setTextDirection() to the
LayoutTestController class of Safari and Chrome to write layout tests
that changes the text direction of an editable element.

  • DumpRenderTree/LayoutTestController.cpp: (setTextDirectionCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setTextDirection):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setTextDirection):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setTextDirection):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setTextDirection):
7:22 PM Changeset in webkit [87769] by cevans@google.com
  • 2 edits in trunk/Websites/webkit.org

2011-05-31 Chris Evans <cevans@chromium.org>

Reviewed by Drew Yao.

Add "Collaboration" to WebKit Security Group Privileges and Responsibilities section.

  • security/index.html: Add "Collaboration" section with text discussed on webkit-security.
6:48 PM Changeset in webkit [87768] by jer.noble@apple.com
  • 4 edits in trunk/Source

2011-05-31 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Flash of black at the end of full screen transition at apple.com product videos
https://bugs.webkit.org/show_bug.cgi?id=61756

Added two new entries to the WebCore exports list.

  • WebCore.exp.in:

2011-05-31 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Flash of black at the end of full screen transition at apple.com product videos
https://bugs.webkit.org/show_bug.cgi?id=61756

The @"WebKitLayerHostChanged" notification is causing the QTMovie to tear down its layer
(which is good) at the wrong time (which is bad). Send this notification only after
the dragImage snapshot is taken. This exposed another problem, that the snapshot has
a white background. Set the default background color and transparency for the view (making
sure to reset them afterwards) to transparent.

  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
6:47 PM Changeset in webkit [87767] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-05-31 Rafael Brandao <rafael.lobo@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::render() failing
https://bugs.webkit.org/show_bug.cgi?id=60893

Due a problem on QPicture (http://bugreports.qt.nokia.com/browse/QTBUG-19496),
this test was calculating the final geometry incorrectly. As the order between
a translate and a draw operation could be relevant for it, but not for the
final rendered result, they were changed on ScrollbarThemeQt::paint.

  • platform/qt/ScrollbarThemeQt.cpp: (WebCore::ScrollbarThemeQt::paint):

2011-05-31 Rafael Brandao <rafael.lobo@openbossa.org>

Reviewed by Andreas Kling.

[Qt] tst_QWebFrame::render() failing
https://bugs.webkit.org/show_bug.cgi?id=60893

The test was expecting the frame contents to be already loaded
before rendering it into a QPicture. Renamed the test to fit
its real purpose more accordingly.

  • tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::renderGeometry):
6:42 PM Rebaseline edited by dpranke@chromium.org
(diff)
6:26 PM Changeset in webkit [87766] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

2011-05-31 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] gtkdoc run produces many warnings about missing declarations
https://bugs.webkit.org/show_bug.cgi?id=61797

  • docs/webkitgtk-sections.txt: Remove inexistent symbols from this file to reduce the number of gtkdoc warnings.
6:05 PM Changeset in webkit [87765] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

2011-05-31 Raphael Kubo da Costa <kubo@profusion.mobi>

Reviewed by Adam Barth.

[efl] Add ewk API to enable/disable developer extras.
https://bugs.webkit.org/show_bug.cgi?id=61746

Add ewk_view_setting_enable_developer_extras_{get,set}, which is used
to enable or disable developer extras (currently, the Web Inspector)
in a given view.

  • ewk/ewk_view.cpp: (_ewk_view_priv_new): (ewk_view_setting_enable_developer_extras_get): (ewk_view_setting_enable_developer_extras_set):
  • ewk/ewk_view.h:
5:43 PM Changeset in webkit [87764] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-31 Daniel Erat <derat@chromium.org>

Reviewed by Tony Chang.

Make WebScreenInfoFactory return fresh screen dimensions.
https://bugs.webkit.org/show_bug.cgi?id=61679

  • public/x11/WebScreenInfoFactory.h:
  • src/x11/WebScreenInfoFactory.cpp: (WebKit::WebScreenInfoFactory::screenInfo):
5:14 PM Changeset in webkit [87763] by Ademar Reis
  • 3 edits in trunk/Tools

2011-05-31 Ademar de Souza Reis Jr <Ademar Reis>

Reviewed by Simon Hausmann.

[Qt] User-agent list of Qt test browsers is very outdated
https://bugs.webkit.org/show_bug.cgi?id=61531

The user can edit the user-agent manually, so there's no need to have
a super complete and up to date list, but it's nice to have it
minimally updated.

  • MiniBrowser/qt/useragentlist.txt:
  • QtTestBrowser/useragentlist.txt:
4:49 PM Changeset in webkit [87762] by enne@google.com
  • 4 edits
    2 adds in trunk

2011-05-27 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix crash from empty reflections with masks
https://bugs.webkit.org/show_bug.cgi?id=61654

  • compositing/reflections/empty-reflection-with-mask-expected.txt: Added.
  • compositing/reflections/empty-reflection-with-mask.html: Added.

2011-05-27 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Fix crash from empty reflections with masks
https://bugs.webkit.org/show_bug.cgi?id=61654

Change the iteration for updateCompositorResources to match that being
done in the paint and draw steps. This mismatch of iteration style
was causing layers with replica masks to correctly get skipped while
painting but not get skipped during texture upload.

Test: compositing/reflections/empty-reflection-with-mask.html

  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updateLayers): (WebCore::LayerRendererChromium::updateCompositorResources):
  • platform/graphics/chromium/LayerRendererChromium.h:
4:37 PM Changeset in webkit [87761] by inferno@chromium.org
  • 3 edits
    2 copies in branches/chromium/742

Merge 87743

BUG=84452
Review URL: http://codereview.chromium.org/7057049

4:35 PM Changeset in webkit [87760] by mrobinson@webkit.org
  • 11 edits
    4 copies
    6 adds in trunk

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Roben.

[GTK] [WebKit2] Implement a basic WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=57068

  • GNUmakefile.am: Added reference to WebKitTestRunner GNUmakefile.

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Roben.

[GTK] [WebKit2] Implement a basic WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=57068

Added InjectedBundle support for GTK+.

  • WebProcess/InjectedBundle/InjectedBundle.h: Added typedef for GTK+.
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: Added implementation. (WebKit::InjectedBundle::load): (WebKit::InjectedBundle::activateMacFontAscentHack):
  • WebProcess/WebPage/gtk/WebPageGtk.cpp: Remove unnecessary method definition.

2011-03-30 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Roben.

[GTK] [WebKit2] Implement a basic WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=57068

Add an implementation of WebKitTestRunner for GTK+.

  • Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
  • Scripts/old-run-webkit-tests: Ditto.
  • Scripts/run-launcher: Ditto.
  • Scripts/webkitdirs.pm: Ditto.
  • WebKitTestRunner/GNUmakefile.am: Added.
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
  • WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
  • WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
  • WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
  • WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  • WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp. (main): Added.
4:35 PM Changeset in webkit [87759] by inferno@chromium.org
  • 1 edit
    2 copies in branches/chromium/742

Merge 87737

BUG=84333
Review URL: http://codereview.chromium.org/7057048

3:40 PM Changeset in webkit [87758] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-31 Berend-Jan Wever <skylined@chromium.org>

Reviewed by Adam Barth.

Add test to make sure an error in requestFileSystem or resolveLocalFileSystemURI
when no error callback is supplied does not cause a NULL ptr.
https://bugs.webkit.org/show_bug.cgi?id=49539

  • fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Added.
  • fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Added.

2011-05-31 B.J. Wever <skylined@chromium.org>

Reviewed by Adam Barth.

requestFileSystem and resolveLocalFileSystemURI are not checking if
errorCallback is NULL before scheduling a callback on error.
https://bugs.webkit.org/show_bug.cgi?id=49539

Test: fast/filesystem/filesystem-no-callback-null-ptr-crash.html

  • fileapi/DOMFileSystem.cpp: (WebCore::DOMFileSystem::scheduleCallback): Only call callback if one is supplied.
3:26 PM Changeset in webkit [87757] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-05-31 Dirk Pranke <dpranke@chromium.org>

Reviewed by Tony Chang.

new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
https://bugs.webkit.org/show_bug.cgi?id=60241

  • Scripts/new-run-webkit-tests:
3:13 PM Changeset in webkit [87756] by beidson@apple.com
  • 8 edits in trunk/Source/WebCore

Another swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494

Reviewed by Darin Adler.

Re-land http://trac.webkit.org/changeset/87566 with invalid ASSERTs removed.

No new tests. No change in behavior.

Instead of storing the DocumentLoader at construction and never changing it,
always calculate it based on the FrameLoader's current DocumentLoader:

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::suggestedMIMEType):
(WebCore::Document::lastModified):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::loader):

  • dom/Document.h:

Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::replaceMediaElementTimerFired):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • platform/mac/HTMLConverter.mm:

(fileWrapperForElement):

  • WebCore.exp.in:
3:11 PM Changeset in webkit [87755] by mitz@apple.com
  • 12 edits in trunk/Source/WebKit2

<rdar://problem/9523192> REGRESSION (5.0.5-ToT, WebKit2): Flash to white when navigating between pages on wsj.com, other sites (when navigating away from composited page)
https://bugs.webkit.org/show_bug.cgi?id=61808

Reviewed by Simon Fraser.

WebKit1 has a mechanism to prevent the stale bits from the outgoing page from being erased
until the incoming page has layout. Adapt this in WebKit2 to prevent the composited layer tree
of the outgoing page from being torn down or updated until the incoming page has layout.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout): Unfreeze the layer tree state.
(WebKit::WebFrameLoaderClient::frameLoadCompleted): Ditto.
(WebKit::WebFrameLoaderClient::provisionalLoadStarted): Freeze the layer tree state.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::setLayerTreeStateIsFrozen): Added.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize new member variables.
(WebKit::DrawingAreaImpl::setLayerTreeStateIsFrozen): Added. When freezing, sets the flag and
disables layer flush scheduling and exiting accelerated compositing mode. When unfreezing,
clears the flag and exits compositing mode if needed.
(WebKit::DrawingAreaImpl::setRootCompositingLayer): Reset m_wantsToExitAcceleratedCompositingMode.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): Ditto.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Ditto.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon): If the layer tree state is frozen,
bail out but set m_wantsToExitAcceleratedCompositingMode.

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp:

(WebKit::LayerTreeHostCA::LayerTreeHostCA): Initialize m_layerFlushSchedulingEnabled.

  • WebProcess/WebPage/ca/LayerTreeHostCA.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:
  • WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:

(WebKit::LayerTreeHostCAMac::scheduleLayerFlush): Bail out if scheduling is not enabled.
(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled): Added. Sets the flag. If disabling
flushing, cancels the pending flush.
(WebKit::LayerTreeHostCAMac::flushPendingLayerChangesRunLoopObserverCallback): Added an assertion.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:

(WebKit::LayerTreeHostCAWin::scheduleLayerFlush): Bail out if scheduling is not enabled.
(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled): Added. Sets the flag. If disabling
flushing, cancels the pending flush.

  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:
3:03 PM Changeset in webkit [87754] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

2011-05-31 Hao Zheng <zhenghao@chromium.org>

Reviewed by Tony Chang.

Flush output buffer of php.
https://bugs.webkit.org/show_bug.cgi?id=56060

On Lucid, the output buffer is enabled by default, but it's not
enabled on Hardy. Fix test http/tests/loading/preload-slow-loading.php
http://www.php.net/manual/en/function.ob-flush.php

  • http/tests/loading/preload-slow-loading.php:
  • platform/chromium/test_expectations.txt:
2:55 PM Changeset in webkit [87753] by leviw@chromium.org
  • 20 edits in trunk/Source/WebCore

2011-05-31 Levi Weintraub <leviw@chromium.org>

Reviewed by Simon Fraser.

Change InlineBox::paint and its overloaded variants to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61804

Changing InlineBox::paint, its 7 overloaded variants, and RootInlineBox::paintEllipsisBox
to use IntPoint for their paint offset instead of a pair of ints.

No new tests since this is just a refactoring.

  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::paint):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintEllipsisBoxes):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintEllipsisBox): (WebCore::RootInlineBox::paint):
  • rendering/RootInlineBox.h:
  • rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint):
  • rendering/svg/SVGInlineFlowBox.h:
  • rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paint):
  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint):
  • rendering/svg/SVGRootInlineBox.h:
2:50 PM Changeset in webkit [87752] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-31 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Clear out LayerChromium's m_ccLayerImpl ptr on CCLayerImpl destruction
https://bugs.webkit.org/show_bug.cgi?id=61593

Whenever a CCLayerImpl is being destroyed, clear out its owner's m_ccLayerImpl pointer.
This is extremely defensive and not strictly necessary, but not harmful either.

  • platform/graphics/chromium/LayerChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.cpp: (WebCore::CCLayerImpl::~CCLayerImpl):
2:15 PM Changeset in webkit [87751] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-05-31 Eric Seidel <eric@webkit.org>

Reviewed by David Kilzer.

webkitpy should create zips with zip -9
https://bugs.webkit.org/show_bug.cgi?id=61789

Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.

  • Scripts/webkitpy/common/system/workspace.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
2:02 PM Changeset in webkit [87750] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-31 Stephen White <senorblanco@chromium.org>

Unreviewed; build fix.

Silence some warnings on the Safari/Mac release build.

  • platform/graphics/gpu/TilingData.h: (WebCore::TilingData::assertTile):
1:53 PM Changeset in webkit [87749] by abarth@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-05-31 Adam Barth <abarth@webkit.org>

Add chromium-mac-leopard image results for these SVG tests.

  • platform/chromium-mac-leopard/svg/custom/invalid-fill-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/invalid-fill-hex-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/invalid-uri-stroke-expected.png: Added.
1:21 PM Changeset in webkit [87748] by senorblanco@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-31 Justin Novosad <junov@chromium.org>

Reviewed by Stephen White.

[Chromium] Build fails when ACCELERATED_2D_CANVAS is disabled
https://bugs.webkit.org/show_bug.cgi?id=61790
Changing the build guards in these two files that are required
by the accelerated compositing feature.

  • platform/graphics/gpu/LoopBlinnMathUtils.cpp:
  • platform/graphics/gpu/TilingData.cpp:
12:56 PM WebKit Team edited by tonikitoo@webkit.org
(diff)
12:51 PM Changeset in webkit [87747] by rwlbuis@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-31 Rob Buis <rbuis@rim.com>

RS=Dirk Schulze.

run-webkit-tests on animate-path-nested-transform.html crashes
https://bugs.webkit.org/show_bug.cgi?id=61798

"Fix" the crashing test by choosing safer values.

  • svg/animations/script-tests/animate-path-nested-transforms.js: (executeTest):
12:38 PM Changeset in webkit [87746] by rwlbuis@webkit.org
  • 6 edits
    5 adds in trunk

2011-05-31 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

https://bugs.webkit.org/show_bug.cgi?id=34301
Creating <animateMotion> elements via javascript do not execute

https://bugs.webkit.org/show_bug.cgi?id=17043
SVG missing some .idl files

Add missing idl files.

Test: svg/animations/animate-mpath-insert.html

  • CMakeLists.txt:
  • CodeGenerators.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/SVGAnimateMotionElement.idl: Added.
  • svg/SVGMPathElement.idl: Added.

2011-05-31 Rob Buis <rbuis@rim.com>

Reviewed by Dirk Schulze.

https://bugs.webkit.org/show_bug.cgi?id=34301
Creating <animateMotion> elements via javascript do not execute

https://bugs.webkit.org/show_bug.cgi?id=17043
SVG missing some .idl files

Verify that adding mpath via javascript works.

  • svg/animations/animate-mpath-insert-expected.txt: Added.
  • svg/animations/animate-mpath-insert.html: Added.
  • svg/animations/script-tests/animate-mpath-insert.js: Added. (mpath.setAttributeNS.animateMotion.appendChild.g.appendChild.rootSVGElement.appendChild.passIfCloseEnough): (startSample): (endSample): (executeTest):
12:21 PM Changeset in webkit [87745] by kevino@webkit.org
  • 10 edits in trunk/Source

Reviewed by Kevin Ollivier.

[wx] Implement printing support for wxWidgets 2.9.x and above.

https://bugs.webkit.org/show_bug.cgi?id=61796

11:53 AM Changeset in webkit [87744] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

2011-05-31 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Pavel Feldman.

Web Inspector: Missing InspectorFrontendHost.saveSessionSetting function
https://bugs.webkit.org/show_bug.cgi?id=61751

Add missing stub function causing an error on load.

  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.saveSessionSetting):
11:16 AM Changeset in webkit [87743] by inferno@chromium.org
  • 5 edits
    2 adds in trunk

2011-05-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Improve hasMediaControls logic to check that node has
media controls. This can be false when cloning nodes.
https://bugs.webkit.org/show_bug.cgi?id=61765

Test: media/media-controls-clone-crash.html

  • dom/Node.h: (WebCore::Node::isMediaControls):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaControls): (WebCore::HTMLMediaElement::hasMediaControls):
  • html/shadow/MediaControls.h: (WebCore::MediaControls::isMediaControls): (WebCore::toMediaControls):

2011-05-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Tests that cloning an audio element with media controls does
not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=61765

  • media/media-controls-clone-crash-expected.txt: Added.
  • media/media-controls-clone-crash.html: Added.
11:14 AM Changeset in webkit [87742] by xan@webkit.org
  • 2 edits in trunk

2011-05-31 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Bump version to 1.5.1.

  • configure.ac:
11:10 AM Changeset in webkit [87741] by xan@webkit.org
  • 4 edits
    2 adds in trunk/Source

2011-05-31 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
https://bugs.webkit.org/show_bug.cgi?id=61791

  • bindings/gobject/GNUmakefile.am: add new files.
  • bindings/gobject/WebKitDOMCustom.cpp: Added. (webkit_dom_html_text_area_element_is_edited): (webkit_dom_html_input_element_is_edited):
  • bindings/gobject/WebKitDOMCustom.h: Added.

2011-05-31 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
https://bugs.webkit.org/show_bug.cgi?id=61791

  • GNUmakefile.am: add new files.
10:55 AM Changeset in webkit [87740] by andreas.kling@nokia.com
  • 2 edits in trunk/LayoutTests

2011-05-31 Andreas Kling <kling@webkit.org>

Unreviewed. Rebaseline Mac after JSC/Canvas bindings changes.

  • platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
10:22 AM Changeset in webkit [87739] by noam.rosenthal@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-31 Noam Rosenthal <noam.rosenthal@nokia.com>

Unreviewed build fix for Symbian.
Opt-out Symbian for TextureMapper.

No new tests: build fix.

  • WebCore.pri:
10:12 AM Changeset in webkit [87738] by leviw@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-31 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Switch paintFocusRing to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=61580

Switching paintFocusRing to take an IntPoint representing the paint offset
instead of a pair of ints.

No new tests as this is just refactoring.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintFocusRing): (WebCore::RenderObject::paintOutline):
  • rendering/RenderObject.h:
9:51 AM Changeset in webkit [87737] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Convert raw ptr to RefPtr for documentElement.
https://bugs.webkit.org/show_bug.cgi?id=61688

Test: fast/dom/xml-parser-error-message-crash.svg

  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::insertErrorMessageBlock):

2011-05-31 Abhishek Arya <inferno@chromium.org>

Reviewed by Dimitri Glazkov.

Test that we do not crash when a DOMNodeInsertedIntoDocument event
is fired while generating a error message block in xml parsing.
https://bugs.webkit.org/show_bug.cgi?id=61688

  • fast/dom/xml-parser-error-message-crash-expected.txt: Added.
  • fast/dom/xml-parser-error-message-crash.svg: Added.
9:28 AM Changeset in webkit [87736] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setShadow()
https://bugs.webkit.org/show_bug.cgi?id=61786

Move CanvasRenderingContext2D.setShadow() to auto-generated JSC bindings.

There is a subtle difference to the previous behavior: invalid numbers of
arguments now raise TypeError instead of SyntaxError. This is in accordance
with Web IDL, and matches the existing V8 bindings.

Test: fast/canvas/canvas-overloads-setShadow.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setShadow()
https://bugs.webkit.org/show_bug.cgi?id=61786

Add a test to verify the behavior of setShadow() when called
with different numbers of arguments.

  • fast/canvas/canvas-overloads-setShadow-expected.txt: Added.
  • fast/canvas/canvas-overloads-setShadow.html: Added.
  • fast/canvas/script-tests/canvas-overloads-setShadow.js: Added.
9:25 AM Changeset in webkit [87735] by andreas.kling@nokia.com
  • 5 edits
    3 adds in trunk

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for drawImageFromRect()
https://bugs.webkit.org/show_bug.cgi?id=61709

Add a test to verify the behavior of drawImageFromRect() when called
with different numbers of arguments.

  • fast/canvas/canvas-overloads-drawImageFromRect-expected.txt: Added.
  • fast/canvas/canvas-overloads-drawImageFromRect.html: Added.
  • fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js: Added.

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for drawImageFromRect()
https://bugs.webkit.org/show_bug.cgi?id=61709

Move CanvasRenderingContext2D.drawImageFromRect() to auto-generated JSC bindings.
Make it [RequiresAllArguments=Raise] to match the old behavior.
Side effect: calling drawImageFromRect() with zero arguments will now raise
SyntaxError instead of TypeError.

Test: fast/canvas/canvas-overloads-drawImageFromRect.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:
9:22 AM Changeset in webkit [87734] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for drawImage()
https://bugs.webkit.org/show_bug.cgi?id=61703

Move CanvasRenderingContext2D.drawImage() to auto-generated JSC bindings.

There is a subtle difference to the previous behavior: invalid numbers of
arguments now raise TypeError instead of SyntaxError. This is in accordance
with Web IDL, and matches the existing V8 bindings.

Test: fast/canvas/canvas-overloads-drawImage.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for drawImage()
https://bugs.webkit.org/show_bug.cgi?id=61703

Add a test to verify the behavior of drawImage() when called with
different numbers of arguments.

  • fast/canvas/canvas-overloads-drawImage-expected.txt: Added.
  • fast/canvas/canvas-overloads-drawImage.html: Added.
  • fast/canvas/script-tests/canvas-overloads-drawImage.js: Added.
9:20 AM Changeset in webkit [87733] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for strokeRect()
https://bugs.webkit.org/show_bug.cgi?id=61641

Add a test to verify the behavior of strokeRect() when called with
different numbers of arguments.

  • fast/canvas/canvas-overloads-strokeRect-expected.txt: Added.
  • fast/canvas/canvas-overloads-strokeRect.html: Added.
  • fast/canvas/script-tests/canvas-overloads-strokeRect.js: Added.

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for strokeRect()
https://bugs.webkit.org/show_bug.cgi?id=61641

Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.

No behavioral change.

Test: fast/canvas/canvas-overloads-strokeRect.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:
9:15 AM Changeset in webkit [87732] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setFillColor()
https://bugs.webkit.org/show_bug.cgi?id=61635

Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.

There is a subtle difference to the previous behavior: invalid numbers of
arguments now raise TypeError instead of SyntaxError. This is in accordance
with Web IDL, but doesn't matter much anyway since this method is WebKit-only.

Test: fast/canvas/canvas-overloads-setFillColor.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setFillColor()
https://bugs.webkit.org/show_bug.cgi?id=61635

Add a test to verify the behavior of setFillColor() when called with
different numbers of arguments.

  • fast/canvas/canvas-overloads-setFillColor-expected.txt: Added.
  • fast/canvas/canvas-overloads-setFillColor.html: Added.
  • fast/canvas/script-tests/canvas-overloads-setFillColor.js: Added.
9:12 AM Changeset in webkit [87731] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setStrokeColor()
https://bugs.webkit.org/show_bug.cgi?id=61629

Add a test to verify the behavior of setStrokeColor() when called with
different numbers of arguments.

  • fast/canvas/canvas-overloads-setStrokeColor-expected.txt: Added.
  • fast/canvas/canvas-overloads-setStrokeColor.html: Added.
  • fast/canvas/script-tests/canvas-overloads-setStrokeColor.js: Added.

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for setStrokeColor()
https://bugs.webkit.org/show_bug.cgi?id=61629

Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.

There is a subtle difference to the previous behavior: invalid numbers of
arguments now raise TypeError instead of SyntaxError. This is in accordance
with Web IDL, but doesn't matter much anyway since this method is WebKit-only.

Test: fast/canvas/canvas-overloads-setStrokeColor.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:
9:10 AM Changeset in webkit [87730] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for strokeText()
https://bugs.webkit.org/show_bug.cgi?id=61626

Move CanvasRenderingContext2D.strokeText() to auto-generated JSC bindings.
Make it [RequiresAllArguments=Raise] to match the old behavior.
This has the side-effect of aligning the behaviors of JSC and V8.

Test: fast/canvas/canvas-overloads-strokeText.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for strokeText()
https://bugs.webkit.org/show_bug.cgi?id=61626

Add a test to verify the behavior of strokeText() when called with different
numbers of arguments. There are two differences to the previous behavior:

  • SyntaxError exceptions are now raised with the message "Not enough arguments."
  • Calling strokeText() with superfluous arguments now lets the call through instead of raising a SyntaxError. This matches both Gecko and Presto.
  • fast/canvas/canvas-overloads-strokeText-expected.txt: Added.
  • fast/canvas/canvas-overloads-strokeText.html: Added.
  • fast/canvas/script-tests/canvas-overloads-strokeText.js: Added.
9:08 AM Changeset in webkit [87729] by andreas.kling@nokia.com
  • 4 edits
    3 adds in trunk

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for fillText()
https://bugs.webkit.org/show_bug.cgi?id=61623

Add a test to verify the behavior of fillText() when called with different
numbers of arguments. There are two differences to the previous behavior:

  • SyntaxError exceptions are now raised with the message "Not enough arguments."
  • Calling fillText() with superfluous arguments now lets the call through instead of raising a SyntaxError. This matches both Gecko and Presto.
  • fast/canvas/canvas-overloads-fillText-expected.txt: Added.
  • fast/canvas/canvas-overloads-fillText.html: Added.
  • fast/canvas/script-tests/canvas-overloads-fillText.js: Added.

2011-05-31 Andreas Kling <kling@webkit.org>

Reviewed by Antti Koivisto.

Canvas/JSC: Auto-generate overloads for fillText()
https://bugs.webkit.org/show_bug.cgi?id=61623

Move CanvasRenderingContext2D.fillText() to auto-generated JSC bindings.
Make it [RequiresAllArguments=Raise] to match the old behavior.
This has the side-effect of aligning the behaviors of JSC and V8.

Test: fast/canvas/canvas-overloads-fillText.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • html/canvas/CanvasRenderingContext2D.idl:
9:05 AM Changeset in webkit [87728] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-31 Cary Clark <caryclark@google.com>

Reviewed by Eric Seidel.

Allow Chromium porting layer to use Skia on Mac.
https://bugs.webkit.org/show_bug.cgi?id=61548

  • public/WebCommon.h: Don't allow WebKit to use CG if it is already using Skia.
  • src/PlatformBridge.cpp: (WebCore::PlatformBridge::paintScrollbarThumb): Allow scrollbar thumb draw to take WebCanvas.
8:38 AM Changeset in webkit [87727] by commit-queue@webkit.org
  • 2 edits
    7 adds in trunk/Source/WebKit2

2011-05-31 ChangeLog <james.cooley@nokia.com>

Reviewed by Andreas Kling.

[Qt][WK2] Qt port needs test content for QWKHistory
https://bugs.webkit.org/show_bug.cgi?id=57850

Created data-driven QTestLib tests for existing QWKHistory APIs.

This walks through loading four simple pages, navigating
backwards and forwards.

We check the results at each action by creating expected forward/back
lists and comparing those lists in count and membership to those kept by
WebKit and retrieved via the QWKHistory APIs.

  • UIProcess/API/qt/tests/html/a.htm: Added.
  • UIProcess/API/qt/tests/html/b.htm: Added.
  • UIProcess/API/qt/tests/html/c.htm: Added.
  • UIProcess/API/qt/tests/html/d.htm: Added. Four added simple pages
  • UIProcess/API/qt/tests/qwkhistory: Added.
  • UIProcess/API/qt/tests/qwkhistory/qwkhistory.pro: Added. Created qwkhistory folder and pro
  • UIProcess/API/qt/tests/qwkhistory/tst_qwkhistory.cpp: Added. (TestHistoryItem::title): (TestHistoryItem::url): (TestHistoryItem::TestHistoryItem): Utility class to hold expected url,title for test

(tst_QWKHistory::initTestCase):
(tst_QWKHistory::historyFBTest_data):
(tst_QWKHistory::historyFBTest):
init, data, and data-driven test case

  • UIProcess/API/qt/tests/tests.pro: Included qwkhistory in tests.pro
7:20 AM Changeset in webkit [87726] by simon.fraser@apple.com
  • 3 edits
    5 adds in trunk

2011-05-31 Simon Fraser <simon.fraser@apple.com>

Reviewed by Kenneth Rohde Christiansen.

Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491

  • fast/frames/flattening/iframe-flattening-nested.html: Added.
  • fast/frames/flattening/resources/inner-frame.html: Added.
  • fast/frames/flattening/resources/intermediate-frame.html: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.png: Added.
  • platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.txt: Added.

2011-05-31 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Frame flattening is broken with nested frames
https://bugs.webkit.org/show_bug.cgi?id=61491

After r77988, when frame flattening is enabled, performPostLayoutTasks() is called on a timer for iframes.
This causes layout of nested iframes to sometimes happen asynchronously, but WebCore expects layout to always finish synchronously.
Added a call to updateWidgetPosition() for cases that performPostLayoutTasks() is now happening asynchronously.

Test: fast/frames/flattening/iframe-flattening-nested.html

  • page/FrameView.cpp: (WebCore::FrameView::layout):
6:46 AM Changeset in webkit [87725] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-31 Tommy Widenflycht <tommyw@google.com>

Reviewed by Tony Gentilcore.

Fix getUserMedia callback bindings for JSC.
https://bugs.webkit.org/show_bug.cgi?id=60174

This patch initializes the exception code variable to 0.

Test: fast/dom/MediaStream/argument-types.html

  • bindings/js/JSNavigatorCustom.cpp: (WebCore::JSNavigator::webkitGetUserMedia):
6:32 AM Changeset in webkit [87724] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

[Qt] Implement find feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61425

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-05-31
Reviewed by Csaba Osztrogonác.

Buildfix for --minimal and CONFIG+=qt_minimal build.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::LauncherWindow):
(LauncherWindow::createChrome):

  • QtTestBrowser/launcherwindow.h:
5:43 AM Changeset in webkit [87723] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-31 Oleg Romashin <oleg.romashin@nokia.com>

Reviewed by Benjamin Poulain.

Fix compilation with debug enabled, m_lightSource.type is not valid anymore
https://bugs.webkit.org/show_bug.cgi?id=61719

  • platform/graphics/filters/arm/FELightingNEON.h: (WebCore::FELighting::platformApplyNeon):
5:39 AM QtWebKitForQt5 edited by Simon Hausmann
(diff)
4:49 AM Changeset in webkit [87722] by mnaganov@chromium.org
  • 4 edits
    3 copies
    12 adds in trunk/LayoutTests

2011-05-31 Mikhail Naganov <mnaganov@chromium.org>

[Chromium] Unreviewed tests results rebaseline after r87721.

  • platform/chromium-linux-x86/svg/custom/invalid-fill-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/invalid-fill-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/invalid-fill-expected.txt.
  • platform/chromium-linux-x86/svg/custom/invalid-fill-hex-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/chromium-linux-x86/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/chromium-linux/svg/custom/invalid-fill-expected.png:
  • platform/chromium-linux/svg/custom/invalid-fill-expected.txt:
  • platform/chromium-linux/svg/custom/invalid-fill-hex-expected.png:
  • platform/chromium-linux/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/chromium-linux/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-fill-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-fill-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/invalid-fill-expected.txt.
  • platform/chromium-win-vista/svg/custom/invalid-fill-hex-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-fill-hex-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/invalid-fill-expected.txt.
  • platform/chromium-win-vista/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/chromium-win-vista/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/chromium-win-vista/svg/custom/invalid-uri-stroke-expected.txt: Added.
3:46 AM Changeset in webkit [87721] by commit-queue@webkit.org
  • 13 edits
    10 adds in trunk

2011-05-31 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

Invalid color handling is broken for SVG
https://bugs.webkit.org/show_bug.cgi?id=58531

Fix invalid color fallback handling. If the fill/stroke attributes computed
value leads to a an invalid color, inherit the desired color from the parent
style instead. Matches Opera/FF and SVG 1.1 Second Edition (http://www.w3.org/TR/SVG/).

  • platform/chromium-linux/svg/custom/invalid-fill-expected.txt:
  • platform/chromium-linux/svg/custom/invalid-fill-hex-expected.txt:
  • platform/chromium-linux/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/chromium-linux/svg/custom/invalid-uri-stroke-expected.txt: Added.
  • platform/mac/svg/custom/invalid-fill-expected.png:
  • platform/mac/svg/custom/invalid-fill-expected.txt:
  • platform/mac/svg/custom/invalid-fill-hex-expected.png:
  • platform/mac/svg/custom/invalid-fill-hex-expected.txt:
  • platform/mac/svg/custom/invalid-stroke-hex-expected.png: Added.
  • platform/mac/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/mac/svg/custom/invalid-uri-stroke-expected.png: Added.
  • platform/mac/svg/custom/invalid-uri-stroke-expected.txt: Added.
  • platform/qt/svg/custom/invalid-fill-expected.txt:
  • platform/qt/svg/custom/invalid-fill-hex-expected.txt:
  • platform/qt/svg/custom/invalid-stroke-hex-expected.txt: Added.
  • platform/qt/svg/custom/invalid-uri-stroke-expected.txt: Added.
  • svg/custom/invalid-fill-hex.svg:
  • svg/custom/invalid-fill.svg:
  • svg/custom/invalid-stroke-hex.svg: Added.
  • svg/custom/invalid-uri-stroke.svg: Added.

2011-05-31 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>

Reviewed by Nikolas Zimmermann.

Invalid color handling is broken for SVG
https://bugs.webkit.org/show_bug.cgi?id=58531

Fix invalid color fallback handling. If the fill/stroke attributes computed
value leads to a an invalid color, inherit the desired color from the parent
style instead. Matches Opera/FF and SVG 1.1 Second Edition (http://www.w3.org/TR/SVG/).

Tests: svg/custom/invalid-stroke-hex.svg

svg/custom/invalid-uri-stroke.svg

  • rendering/svg/RenderSVGResource.cpp: (WebCore::inheritColorFromParentStyleIfNeeded): (WebCore::requestPaintingResource):
3:42 AM Changeset in webkit [87720] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-05-31 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[Qt] Implement find feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61425

  • QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::createChrome): (LauncherWindow::showFindBar): (LauncherWindow::find):
  • QtTestBrowser/launcherwindow.h:
3:20 AM Changeset in webkit [87719] by yutak@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-31 Yuta Kitamura <yutak@chromium.org>

Reviewed by Kent Tamura.

WebSocket: Make the output of client-close.html more verbose
https://bugs.webkit.org/show_bug.cgi?id=61770

  • http/tests/websocket/tests/client-close-expected.txt:
  • http/tests/websocket/tests/client-close.html:
  • http/tests/websocket/tests/client-close_wsh.py: Echo back the first two bytes received from the client.
2:58 AM Changeset in webkit [87718] by vangelis@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-31 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kent Tamura.

[chromium] Avoid double deletion of DrawingBuffer's color buffer
texture.
https://bugs.webkit.org/show_bug.cgi?id=61761

Test: Verified that the DCHECK in GraphicsContext3D implementation
doesn't trigger.

  • platform/graphics/chromium/DrawingBufferChromium.cpp: (WebCore::DrawingBuffer::~DrawingBuffer):
2:10 AM Changeset in webkit [87717] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Ossyize editing/pasteboard/copy-standalone-image-crash.html since eventSender is not implemented.

  • platform/qt-wk2/Skipped:
1:50 AM QtWebKitForQt5 edited by Simon Hausmann
More cleanups (diff)
1:49 AM QtWebKitForQt5 edited by Simon Hausmann
AC wording cleanup (diff)
1:45 AM QtWebKitForQt5 edited by Simon Hausmann
Mentioning theming (diff)
12:39 AM Changeset in webkit [87716] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-30 Hayato Ito <hayato@chromium.org>

Reviewed by Ryosuke Niwa.

Add a utility function for dumping a tree for the Node, including a document of a frame.
https://bugs.webkit.org/show_bug.cgi?id=61727

No new tests since added functions are only available in debug builds.

  • dom/Node.cpp: (WebCore::parentOrHostOrFrameOwner): (WebCore::traverseNextNodeAcrossFrame): (WebCore::Node::showTreeForThisAcrossFrame):
  • dom/Node.h:
12:29 AM Changeset in webkit [87715] by yutak@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-31 Yuta Kitamura <yutak@chromium.org>

Unreviewed. Update Chromium test expectation for http/tests/websocket/tests/client-close.html.

  • platform/chromium/test_expectations.txt:
12:01 AM Changeset in webkit [87714] by loki@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-30 Gabor Loki <loki@webkit.org>

Rubber-stamped by Csaba Osztrogonác.

[Qt] Skip crashed test after r87691-r87693 on ARM
https://bugs.webkit.org/show_bug.cgi?id=61764

  • platform/qt-arm/Skipped:
Note: See TracTimeline for information about the timeline view.