Context Navigation

← Previous Period
Next Period →

Timeline

Mar 20, 2007:

10:46 PM Changeset in webkit [20358] by andersca

2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5077252>
In NetNewsWire 2.1.1 and 3.0d62, a crash occurs after triple-clicking a link on the page

loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Move the m_inStopAllLoaders check to the load function that's common for loading a request or substitute data.

10:39 PM Changeset in webkit [20357] by beidson

3 edits in trunk/WebCore

Reviewed by Anders

<rdar://problem/5073391> and http://bugs.webkit.org/show_bug.cgi?id=13137

Crash in IconDatabase when private browsing is enabled.

The problem was caused by http://trac.webkit.org/projects/webkit/changeset/20182
which changed many uses of char[] and Vector<char> to SharedBuffer. The patch
tended to literally replace a Vector<char> with RefPtr<SharedBuffers> but forgot
to enforce the concept that Vector<char>'s always exist, whereas RefPtr<SharedBuffers>
can be null. This led to derefs.

I took the opportunity to rework the iconDB functions to live in a SharedBuffer
world, as that didn't exist when they were originally written - now they just return
SharedBuffers instead of taking a Vector<char>& as a parameter

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::imageDataForIconURL): Return a SharedBuffer (WebCore::IconDatabase::iconForPageURL): Null check the SharedBuffer before asking it if it's empty (WebCore::IconDatabase::imageDataForIconURLQuery): Return a new SharedBuffer

loader/icon/IconDatabase.h: Return SharedBuffer's instead of taking Vector<char>&'s

9:25 PM Changeset in webkit [23150] by aroben

5 edits in branches/WindowsMerge/WebKitTools

Reviewed by Brady.

Always use CCom* smart pointers when possible to avoid memory management issues.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Changed _T() to TEXT(). (dump): (runTest): (initializePreferences): (main):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: (dumpPath): (dump): (EditingDelegate::webViewDidBeginEditing): (EditingDelegate::webViewDidChange): (EditingDelegate::webViewDidEndEditing): (EditingDelegate::webViewDidChangeTypingStyle): (EditingDelegate::webViewDidChangeSelection):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (mouseDownCallback): (doMouseUp): (mouseClickCallback): (doMouseMove): (keyDownCallback):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (setAcceptsEditingCallback): (setTabKeyCyclesThroughElementsCallback):

8:53 PM Changeset in webkit [23149] by sfalken

1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

8:49 PM Changeset in webkit [20356] by sfalken

1 copy in tags/Safari-522.4.1b

New tag.

6:50 PM Changeset in webkit [23148] by mjs

1 edit in branches/WindowsMerge/WebKitTools/ChangeLog

Removed conflict markers.

6:47 PM Changeset in webkit [23147] by mjs

4 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Geoff and Adam.

fixed some bugs in --threaded fond in the course of testing.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runJavaScriptThread): Be smarter about thread dictionary. (startJavaScriptThreads): Ditto. (stopJavaScriptThreads): Ditto. (main): Account for --threaded command-line argument better.

WebKitWin:

Reviewed by Geoff and Adam.

<rdar://problem/4041141> JavaScriptCore is not thread-safe on Windows

WebView.cpp: (WebView::WebView): Tell JavaScriptCore what the main thread is.

6:29 PM Changeset in webkit [23146] by aroben

2 edits in branches/WindowsMerge/LayoutTests

Rubberstamped by Adele.

Roll out r12355 now that OpenSource r20348 has been rolled out.

Skipped: Also removed a crash that was caused by 20348.

6:24 PM Changeset in webkit [20355] by aroben

2 edits in trunk/WebCore

Rubberstamped by Adele.

Roll out r20348 because it was causing crashes.

page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleEvent):

5:54 PM Changeset in webkit [23145] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Hyatt.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Install Helevetica Neue.

5:46 PM Changeset in webkit [20354] by bdash

2 edits in trunk/WebKitSite

2007-03-20 Matt Lilek <pewtermoose@gmail.com>

Reviewed by Darin.

Clear up the steps necessary to get a patch landed.

http://bugs.webkit.org/show_bug.cgi?id=12877 - Bug 12877: "Contributing Code" page could be clearer
http://bugs.webkit.org/show_bug.cgi?id=8690 - Bug 8690: Contributing code doesn't mention what to do with new files

coding/contributing.html:

5:13 PM Changeset in webkit [23144] by aroben

2 edits in branches/WindowsMerge/LayoutTests

Rubberstamped by Beth.

Skipped: Added the real crasher (arrow-navigation.html just fails, doesn't crash).

5:11 PM Changeset in webkit [20353] by thatcher

1 edit in trunk/JavaScriptCore/kjs/collector.cpp

Build fix.

4:57 PM Changeset in webkit [20352] by thatcher

3 edits in trunk/WebCore

Reviewed by Kevin Decker.

Rolling out part of r19828 that caused a scrolling regression in Mail.

<rdar://problem/4820817> Message jumps around when trying to select text

platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::updateContents):

4:57 PM Changeset in webkit [20351] by mjs

10 edits in trunk/JavaScriptCore

Reviewed by Geoff and Adam.

make USE(MULTIPLE_THREADS) support more portable http://bugs.webkit.org/show_bug.cgi?id=13069

fixed a threadsafety bug discovered by testing this

enhanced threadsafety assertions in collector

API/JSCallbackObject.cpp: (KJS::JSCallbackObject::~JSCallbackObject): This destructor can't DropAllLocks around the finalize callback, because it gets called from garbage collection and we can't let other threads collect!

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
kjs/JSLock.cpp: (KJS::JSLock::currentThreadIsHoldingLock): Added new function to allow stronger assertions than just that the lock is held by some thread (you can now assert that the current thread is holding it, given the new JSLock design).
kjs/JSLock.h:
kjs/collector.cpp: Refactored for portability plus added some stronger assertions. (KJS::Collector::allocate): (KJS::currentThreadStackBase): (KJS::Collector::registerAsMainThread): (KJS::onMainThread): (KJS::PlatformThread::PlatformThread): (KJS::getCurrentPlatformThread): (KJS::Collector::Thread::Thread): (KJS::destroyRegisteredThread): (KJS::Collector::registerThread): (KJS::Collector::markCurrentThreadConservatively): (KJS::suspendThread): (KJS::resumeThread): (KJS::getPlatformThreadRegisters): (KJS::otherThreadStackPointer): (KJS::otherThreadStackBase): (KJS::Collector::markOtherThreadConservatively): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collectOnMainThreadOnly): (KJS::Collector::markMainThreadOnlyObjects): (KJS::Collector::collect):
kjs/collector.h:
wtf/FastMalloc.cpp: (WTF::fastMallocSetIsMultiThreaded):
wtf/FastMallocInternal.h:
wtf/Platform.h:

4:25 PM Changeset in webkit [23143] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Release build fix.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed bogus extra linker options.

4:24 PM Changeset in webkit [20350] by beidson

2 edits in trunk/WebCore

Reviewed by John

<rdar://5071341> - Crash in IconLoader::finishLoading()

Though the reproducibility of the crash is still elusive, there's been a crasher likely uncovered
Hyatt's recent caching changings to the IconLoader. This crash tends to hit on sites without favicons,
that serve up complex 404 pages, often when the load is cancelled or redirected. Occasionally, it *seems*
the IconLoader is getting failed/cancelled twice.

This patch adds some assertions and a "fail gracefully in a release build" check that will have to
serve us until we know more about the cause.

loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFail): Add an assertion to catch this case (WebCore::IconLoader::finishLoading): Add an assertion to catch the case, and fail gracefully in debug builds. Also add an efficiency check to not commit to the DB if there is no IconURL

4:15 PM Changeset in webkit [23142] by aroben

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Beth.

Skipped: Added another crasher.

3:06 PM Changeset in webkit [23141] by aroben

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Adele.

Added some tests that fail due to font metric differences.

Skipped:

3:01 PM Changeset in webkit [20349] by antti

8 edits in trunk/WebCore

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=10747 REGRESSION: Using two fingers on a trackpad to scroll inside a text area makes the whole page move <rdar://problem/5045710>

Eat smooth scroll events in WebCore if pointer is over scrollable area. Not
really a good fix, smooth scrolling should be supported properly. It should do for now.

page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
rendering/RenderListBox.cpp: (WebCore::RenderListBox::isScrollable):
rendering/RenderListBox.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::isScrollable):
rendering/RenderObject.h:
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::isScrollable):
rendering/RenderTextControl.h:

2:02 PM Changeset in webkit [23140] by adele

2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adam.

Explicitly pass VK_RETURN when using keyDown for "\n".

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback):

1:47 PM Changeset in webkit [23139] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Release build fix.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Set libpath.

1:29 PM Changeset in webkit [23138] by bdakin

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Adam.

Re-enabling fast/layers/removed-by-scroll-handler.html because
5072678 is fixed.

1:13 PM Changeset in webkit [20348] by bdakin

2 edits in trunk/WebCore

Reviewed by Geoff.

Covered by existing test case.

Fix for <rdar://problem/5072678> Crash in
RenderLayer::scrollRectToVisible with MallocScribble enabled

This removes some code that was added with http://bugs.webkit.org/
show_bug.cgi?id=8360. This code was not needed to fix that bug, but
the idea behind it was that there are times when it is safe for
scheduleEvent() to propagate the event immediately. The
MallocScribble crash revealed that this assumption was a bit too
broad; the cause of the crash was that we were propagating events
immediately when it was not safe. Mitz and I discussed this online
and we agree that the safest solution is to revert to the old
behavior here, and always delay the propagation of the event.

page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleEvent):

12:56 PM Changeset in webkit [20347] by beidson

2 edits in trunk/WebCore

Reviewed by John Sullivan

Add some very helpful logging to the IconLoader's SubresourceLoaderClient impl.

loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFail): (WebCore::IconLoader::didFinishLoading):

12:09 PM Changeset in webkit [20346] by justing

5 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5071074>
REGRESSION: Links are pasted as plain text at certain positions

editing/pasteboard/5071074-2-expected.checksum: Added.
editing/pasteboard/5071074-2-expected.png: Added.
editing/pasteboard/5071074-2-expected.txt: Added.
editing/pasteboard/5071074-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5071074>
REGRESSION: Links are pasted as plain text at certain positions

moveParagraphs calls createMarkup without annotation, which leaves
out anchor elements that aren't fully selected.

editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): We don't want createMarkup to do full annotation here. Doing so could include special ancestor blocks, which would prevent the copied content from appearing in the destination paragraph when it's re-inserted. Annotation would also inline styles from style sheets, which is unnecessary because the content is being moved to the same document it's being moved from. Added a new bool to createMarkup that when true allows markup for special ancestors as long as they are inline when annotation is off.
editing/markup.cpp: (WebCore::createMarkup): Don't set specialCommonAncestor if annotation is off, unless it's inline and we've been told it's ok to include such elements.
editing/markup.h:

11:48 AM Changeset in webkit [23137] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada.

Added null-checks for ResourceHandle::cookieStorage() before passing it
into CFNetwork functions, which are not null-safe.

platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies):

11:20 AM Changeset in webkit [23136] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj: Added XPathNodeSet.(cpp|h).

10:21 AM Changeset in webkit [20345] by ap

30 edits
5 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12497
Implement XPath result ordering.

WebCore:

XPath::NodeVector typedef is replaced with a real XPath::NodeSet class that knows how
to sort itself, and can remember whether it has been already sorted.

CMakeLists.txt:
WebCore.pro:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl: Added XPathNodeSet files.

xml/XPathExpression.cpp: Fixed includes.

xml/XPathFunctions.cpp: (WebCore::XPath::FunId::evaluate): Mark the resulting node-set as unsorted. (WebCore::XPath::FunLocalName::evaluate): Replacing NodeVector with NodeSet. (WebCore::XPath::FunNamespaceURI::evaluate): Ditto. (WebCore::XPath::FunName::evaluate): Ditto. (WebCore::XPath::FunCount::evaluate): Ditto. (WebCore::XPath::FunSum::evaluate): Ditto.

xml/XPathNodeSet.cpp: Added. (WebCore::XPath::parentWithDepth): (WebCore::XPath::sortBlock): (WebCore::XPath::NodeSet::sort): Sort the node-set in document order. (WebCore::XPath::NodeSet::reverse): Reverse the order (useful for making axes such as parent or ancestor sorted). (WebCore::XPath::NodeSet::firstNode): Returns the first node in document order; currently implemented via fully sorting the node-set, but this can obviously be optimized. (WebCore::XPath::NodeSet::anyNode): Added for symmetry with firstNode().

xml/XPathNodeSet.h: Added. (WebCore::XPath::NodeSet::NodeSet): (WebCore::XPath::NodeSet::operator=): (WebCore::XPath::NodeSet::size): (WebCore::XPath::NodeSet::isEmpty): (WebCore::XPath::NodeSet::operator[]): (WebCore::XPath::NodeSet::reserveCapacity): (WebCore::XPath::NodeSet::clear): (WebCore::XPath::NodeSet::swap): (WebCore::XPath::NodeSet::append): (WebCore::XPath::NodeSet::markSorted): (WebCore::XPath::NodeSet::isSorted): Most of these methods just call Vector counterparts.

xml/XPathParser.cpp: Updated the copyright notice.

xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): Replacing NodeVector with NodeSet. (WebCore::XPath::Path::evaluate): Ditto. (WebCore::XPath::LocationPath::evaluate): Replacing NodeVector with NodeSet. This function always marks the result as unsorted, because it is hard to tell whether a step breaks node order. Identifying and implementing special cases when it is not necessary to do so is an important future optimization.

xml/XPathPath.h: Replacing NodeVector with NodeSet.
xml/XPathPredicate.cpp: (WebCore::XPath::EqTestOp::compare): Replacing NodeVector with NodeSet. (WebCore::XPath::Union::evaluate): Replacing NodeVector with NodeSet. Currently, Union just marks the result as unordered; we can consider using merge sort to avoid this.

xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult): Replacing NodeVector with NodeSet. (WebCore::XPathResult::singleNodeValue): Ditto. (WebCore::XPathResult::snapshotLength): Ditto. (WebCore::XPathResult::iterateNext): Ditto. (WebCore::XPathResult::snapshotItem): Ditto. (WebCore::XPathResult::convertTo): Ditto. Sort the result when requested to.

xml/XPathResult.h: Replacing NodeVector with NodeSet.

xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): If the input is not sorted, mark the output as such, too. (WebCore::XPath::Step::nodesInAxis): Fixed a number of bugs when enumerating with an attribute context node. (WebCore::XPath::Step::nodeTestMatches): Replacing NodeVector with NodeSet.
xml/XPathStep.h: Ditto.

xml/XPathUtil.cpp: (WebCore::XPath::isValidContextNode): XPath data model doesn't put attribute data into child nodes, so passing such node as a context could cause problems.

xml/XPathUtil.h: Removed NodeVector typedef.

xml/XPathValue.cpp: (WebCore::XPath::Value::Value): (WebCore::XPath::Value::toNodeSet): (WebCore::XPath::Value::toBoolean): (WebCore::XPath::Value::toNumber): (WebCore::XPath::Value::toString):
xml/XPathValue.h: (WebCore::XPath::Value::): (WebCore::XPath::Value::isNodeSet): Replacing NodeVector with NodeSet.

LayoutTests:

fast/xpath/document-order-expected.txt: Added.
fast/xpath/document-order.html: Added.

fast/xpath/text-nodes-expected.txt:
fast/xpath/text-nodes.html:
fast/xpath/4XPath/Core/test_step-expected.txt: Updated results for tests that now pass.

fast/xpath/xpath-test-pre.js: Added.
fast/xpath/4XPath/Core/test.js: Moved checkSnapshot() to a separate file.

fast/xpath/4XPath/Core/test_core_functions.html:
fast/xpath/4XPath/Core/test_location_path.html:
fast/xpath/4XPath/Core/test_nodeset_expr.html:
fast/xpath/4XPath/Core/test_parser.html:
fast/xpath/4XPath/Core/test_predicate_list.html:
fast/xpath/4XPath/Core/test_step.html: Load xpath-test-pre.js for checkSnapshot().

9:44 AM Open Source Contributors created by ddkilzer@webkit.org

Initial page with fake contributor.

9:37 AM WikiStart edited by ddkilzer@webkit.org

Added link to page for open source contributors. (diff)

8:18 AM Changeset in webkit [20344] by bdash

2 edits in trunk/WebCore

2007-03-21 Mark Rowe <mrowe@apple.com>

Build fix.

bindings/objc/WebScriptObject.mm: (-[WebScriptObject methodForSelector:]): (-[WebScriptObject respondsToSelector:]):

8:11 AM Changeset in webkit [20343] by bdash

3 edits in trunk/WebCore

2007-03-21 Mark Rowe <mrowe@apple.com>

Reviewed by Tim Hatcher.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13129.
Bug 13129: Democracy Player dies in NSException from WebScriptObject on startup.

Some cross-language scripting bridges use the presence of -(int)count to determine
whether to treat objects as sequence-like. All WebScriptObject's exposed this method
which lead to non-collection WebScriptObject's being mishandled by PyObjC. We now
expose -count only when the object we wrap looks like a collection from a JavaScript
point of view (eg, it has a length property).

bindings/objc/WebScriptObject.mm: (-[WebScriptObject _shouldRespondToCount]): (-[WebScriptObject methodForSelector:]): (-[WebScriptObject respondsToSelector:]): (-[WebScriptObject _count]):
bindings/objc/WebScriptObjectPrivate.h:

7:51 AM Changeset in webkit [20342] by darin

2 edits in trunk/WebCore

page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Fix obvious typo in the change from last night -- forgot to assign to the variable.

4:51 AM Changeset in webkit [23135] by andersca

4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

<rdar://problem/5050512>
Need invalid/expired certificate alerts

Add setAllowsAnyHTTPSCertificate method to IWebMutableURLRequest and have it
call down to WebCore.

Interfaces/IWebMutableURLRequest.idl:
WebMutableURLRequest.cpp: (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
WebMutableURLRequest.h:

4:24 AM Changeset in webkit [23134] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Made the metrics of styled selects match those on the Mac to get
fast/forms/001.html passing.

4:22 AM Changeset in webkit [23133] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Rubberstamped by Anders.

Workaround a CFNetwork crash that affects DRT.

WebView.cpp: (WebView::initWithFrame): Commented out cookie storage initialization.

3:27 AM Changeset in webkit [23132] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Build fix.

WebView.cpp: Added missing #include.

3:18 AM Changeset in webkit [23131] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix.

platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest): Fix typo.

3:14 AM Changeset in webkit [23130] by aroben

8 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Oliver.

Implemented layoutTestController.setTabKeyCyclesThroughElements() to
fix fast/events/keypress-insert-tab.html.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback): Removed unnecessary string comparison.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (setTabKeyCyclesThroughElementsCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

Implemented [set]TabKeyCyclesThroughElements.

Interfaces/IWebViewPrivate.idl: Added new declarations.
WebView.cpp: (WebView::setTabKeyCyclesThroughElements): Implemented. (WebView::tabKeyCyclesThroughElements): Implemented.
WebView.h: Updated.

2:45 AM Changeset in webkit [23129] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Oliver.

Implemented layoutTestController.clearBackForwardList() to fix
fast/dom/location-hash.html.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (clearBackForwardListCallback): Implemented.

2:13 AM Changeset in webkit [23128] by hyatt

5 edits
2 adds in branches/WindowsMerge/WebCore

Land advanced text ( turned off )

2:12 AM Changeset in webkit [23127] by hyatt

2 edits in branches/WindowsMerge/WebKitWin

Land advanced text ( turned off )

2:11 AM Changeset in webkit [23126] by andersca

6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

<rdar://problem/4921198>
Cookie acceptance policy not settable

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
(WebCore::willCacheResponse):
Remove FIXMEs.

(WebCore::makeFinalRequest):
New function that makes a final CFURLRequest depending on cookie policy and whether any
invalid SSL certificates should be ignored.

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
Use makeFinalRequest.

(WebCore::ResourceHandle::cookieStorageAcceptPolicy):
(WebCore::ResourceHandle::setCookieStorageAcceptPolicy):
(WebCore::ResourceHandle::cookieStorage):
(WebCore::ResourceHandle::setCookieStorage):
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):
New functions for setting cookie policy, the deafult cookie storage and whether invalid
SSL certificates should result in an error.

platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Set cookie storage, cookie policy and SSL properties.

platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): Use same functions as the mac (sorta).

(WebCore::cookiesEnabled):
Implement this.

WebKitWin:

Reviewed by Adam.

<rdar://problem/4921198>
Cookie acceptance policy not settable

WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences): Update the cookie storage accept policy.

(WebView::initWithFrame):
Initialize the cookie storage.

2:11 AM Changeset in webkit [20341] by hyatt

5 edits in trunk/WebCore

Refactor fonts a bit for portability.

2:06 AM Changeset in webkit [23125] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Oliver.

Remove Arial fonts because of <rdar://problem/5074441>.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Don't install Arial.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Bold Italic.ttf: Removed.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Bold.ttf: Removed.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Italic.ttf: Removed.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial.ttf: Removed.

2:04 AM Changeset in webkit [20340] by aroben

2 edits in trunk/WebCore

Reviewed by Adam.

Stub out a couple of CFNetwork backend functions.

platform/network/ResourceHandle.h:

1:19 AM Changeset in webkit [23124] by oliver

2 edits in branches/WindowsMerge/LayoutTests

2007-03-20 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Removing mouseover-mouseout2.html from skip list

Skipped:

1:10 AM Changeset in webkit [20339] by oliver

2 edits in trunk/WebCore

2007-03-19 Oliver Hunt <oliver@apple.com>

Reviewed by Ada.

Protect against possibility of JS detaching a frame (and losing its view)
midway through a mouse move.

page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):

12:39 AM Changeset in webkit [23123] by aroben

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Ada.

Skipped: Added more international text tests, plus those that use textInputController.

Mar 19, 2007:

11:56 PM Changeset in webkit [23122] by aroben

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Ada.

Skipped: Added tests that relay on DRT's built-in plugin, or on the QuickTime WebKit plugin.

10:58 PM Changeset in webkit [20338] by ap

4 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13107
XPath should raise an exception when trying to parse an unknown function

Test: fast/xpath/invalid-functions.html

xml/XPathFunctions.cpp: (WebCore::XPath::createFunction): Return 0 if the function couldn't be created.
xml/XPathGrammar.y: Handle nulls returned from createFunction().

10:47 PM Changeset in webkit [23121] by aroben

4 edits in branches/WindowsMerge

LayoutTestsWin:

Reviewed by Ada.

Skipped: Added some more international text tests.

WebKitToolsWin:

Reviewed by Ada.

Made DRT output UTF8 strings.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Convert to UTF8 before printing.

9:01 PM Changeset in webkit [23120] by aroben

3 edits in branches/WindowsMerge/WebKitTools

Reviewed by Geoff.

Added support for --threaded.

Note that this always crashes right now due to
<rdar://problem/5051141> JavaScriptCore is not thread-safe,
but that's why we need this feature!

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Changed NULL to 0. (runTest): Ditto. (pthread_equal): Added. (javaScriptThreads): Ported from Mac. (runJavaScriptThread): Ditto. (startJavaScriptThreads): Ditto. (stopJavaScriptThreads): Ditto. (main): Parse --threaded argument and start/stop threads if needed.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Link against pthreadVC2.lib, and added include/pthreads to the include path.

7:45 PM Changeset in webkit [20337] by andersca

4 edits in trunk/WebKit

Reviewed by Dave Hyatt.

<rdar://problem/5067983>
iSale: Crash occurs at WebFrameLoaderClient::dispatchDecidePolicyForMIMEType() when attempting to load a HTML template

Restore old behavior (broke in r14533) where the resource load and download delegates are retained for as long as the
data source is loading.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createDocumentLoader):
WebView/WebDocumentLoaderMac.h:
WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::setDataSource): (WebDocumentLoaderMac::decreaseLoadCount):

6:05 PM Changeset in webkit [20336] by darin

2 edits in trunk/JavaScriptCore

kjs/value.h: Roll ~JSValue change out. It was causing problems. I'll do it right later.

5:50 PM Changeset in webkit [20335] by ggaren

2 edits in trunk/WebKit

Speculative fix for why ASSERT_MAIN_THREAD didn't work for me. (The
documentation says "non-zero," not "1."

Misc/WebKitLogging.m: (WebKitRunningOnMainThread):

5:46 PM Changeset in webkit [20334] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

Fixed <rdar://problem/5073380> REGRESSION: Crash occurs at WTF::fastFree()
when reloading liveconnect page (applet)

Best to use free when you use malloc, especially when malloc and delete
use completely different libraries.

bindings/jni/jni_runtime.cpp: (JavaMethod::~JavaMethod):

5:30 PM Changeset in webkit [20333] by adele

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Beth.

Test for http://bugs.webkit.org/show_bug.cgi?id=13087
<rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)

fast/forms/radio_checked_name-expected.txt: Added.
fast/forms/radio_checked_name.html: Added.

WebCore:

Reviewed by Beth.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13087
<rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)

Test: fast/forms/radio_checked_name.html

We were matching a WinIE quirk that does not allow a user to check and uncheck an unnamed radio button. But they still
allow the checked attribute to be set in html, and changed in javascript. So this change matches that behavior.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): We no longer need a special call to setChecked when parsing the name attribute, since we setChecked will now work with unnamed radio buttons. (WebCore::HTMLInputElement::preDispatchEventHandler): Added comment. (WebCore::HTMLInputElement::setChecked): Don't check for the unnamed radio button case here. (WebCore::HTMLInputElement::postDispatchEventHandler): Don't call setChecked for unnamed radio buttons. (WebCore::HTMLInputElement::defaultEventHandler): ditto.

5:27 PM Changeset in webkit [20332] by aroben

2 edits in trunk/WebCore

Rubberstamped by Oliver.

bridge/JavaScriptStatistics.cpp: Added missing header for correctness.

5:16 PM Changeset in webkit [20331] by andrew

8 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

WebKit.xcodeproj/project.pbxproj:

5:13 PM Changeset in webkit [23119] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Build fix.

WebKit.vcproj/WebKitGUID.vcproj:

4:50 PM Changeset in webkit [20330] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Changed list size threshold to 5 based on testing.

I was testing the i-Bench JavaScript with the list statistics
dumping on, and discovered that there were many 5-element lists.
The fast case for lists was for 4 elements and fewer. By changing
the threshold to 5 elements we get a measurable speedup. I believe
this will help real web pages too, not just the benchmark.

kjs/list.cpp: Change constant from 4 to 5.

4:36 PM Changeset in webkit [23118] by aroben

12 edits
3 copies
2 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders and Darin.

Added JavaScriptStatistics to the project for
<rdar://problems/5071653>.

WebCore.vcproj/WebCore.vcproj: Added include/pthreads to the include path, and added JavaScriptStatistics.(cpp|h).

WebKitToolsWin:

Reviewed by Anders and Darin.

Fix <rdar://problem/5071653> DumpRenderTree needs to be able to
trigger GC on a separate thread

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added GCController.(cpp|h) to the project.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Added. (collectCallback): (collectOnAlternateThreadCallback): (getJSObjectCountCallback): (getClass): (makeGCController):
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Added.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::windowScriptObjectAvailable): Add the GCController to the window object.

WebKitWin:

Reviewed by Anders and Darin.

Added WebJavaScriptCollector for <rdar://problems/5071653>.

Interfaces/IWebJavaScriptCollector.idl: Added.
Interfaces/WebKit.idl:
WebJavaScriptCollector.cpp: Added. (WebJavaScriptCollector::WebJavaScriptCollector): (WebJavaScriptCollector::~WebJavaScriptCollector): (WebJavaScriptCollector::createInstance): (WebJavaScriptCollector::QueryInterface): (WebJavaScriptCollector::AddRef): (WebJavaScriptCollector::Release): (WebJavaScriptCollector::collect): (WebJavaScriptCollector::collectOnAlternateThread): (WebJavaScriptCollector::objectCount):
WebJavaScriptCollector.h: Added.
WebKit.vcproj/Interfaces.vcproj: Added IWebJavaScriptCollector.idl.
WebKit.vcproj/WebKit.vcproj: Added WebJavaScriptCollector.(cpp|h).
WebKit.vcproj/WebKitGUID.vcproj: Added IWebJavaScriptCollector_i.c.
WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Added cases for WebJavaScriptCollector.
WebKitDLL.cpp: (DllGetClassObject): Ditto.

4:28 PM Changeset in webkit [20329] by darin

2 edits in trunk/JavaScriptCore

kjs/value.h: Oops, fix build.

4:12 PM Changeset in webkit [20328] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

remove ~JSValue; tiny low-risk performance boost

kjs/value.h: Remove unneeded empty virtual destructor from JSValue. The only class derived from JSValue is JSCell and it already has a virtual destructor. Declaring an empty constructor in JSValue had one good effect: it marked the destructor private, making it a compile time error to try to destroy a JSValue; but that's not a likely mistake for someone to make. It had two bad effects: (1) it caused gcc, at least, to generate code to fix up the virtual table pointer to point to the JSValue version of the virtual table inside the destructor of all classes derived from JSValue directly or indirectly; (2) it caused JSValue to be a polymorphic class so required a virtual table for it. It's cleaner to not have either of those.

3:54 PM Changeset in webkit [20327] by darin

2 edits in trunk/WebKit

English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

3:39 PM Changeset in webkit [20326] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5071074>
REGRESSION: Links that aren't fully selected copy and paste as only text

editing/pasteboard/5071074-expected.checksum: Added.
editing/pasteboard/5071074-expected.png: Added.
editing/pasteboard/5071074-expected.txt: Added.
editing/pasteboard/5071074.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5071074>
REGRESSION: Links that aren't fully selected copy and paste as only text

We stopped adding markup for all commonAncestorBlocks
and the ancestors of lastClosed up to them because it
was adding a lot of unnecessary markup.

editing/markup.cpp: (WebCore::createMarkup): Also include markup for nodes up to an enclosing anchor. Cleaned up the code for including special common ancestors a bit.

2:39 PM Changeset in webkit [23117] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Release build fix.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Set the include path for release to the same as for debug.

1:22 PM Changeset in webkit [23116] by aroben

2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adele.

Fix eventSender.keyDown() to create WM_CHAR messages as well, since these
are needed by WebCore.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (dispatchMessage): Added. (mouseDownCallback): Call dispatchMessage instead of DispatchMessage. (doMouseUp): Ditto. (mouseClickCallback): Ditto. (doMouseMove): Ditto. (keyDownCallback): Ditto.

12:41 PM Changeset in webkit [20325] by zimmermann

3 edits
1 move
3 adds in trunk

Reviewed by Lars Knoll.

Fix crash when opening a SVG document which contains SVG elements, but no <svg> root element.
Moving the mouse was crashing WebKit. Fixes svg/hixie/dynamic/006.xml.

12:31 PM Changeset in webkit [20324] by adele

4 edits in trunk/WebCore

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13117 REGRESSION (r14658): Flickering text fields when updating via javascript

page/Frame.cpp: (WebCore::Frame::forceLayout): Added a flag to allow partial relayout.
page/Frame.h:
page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]): Allow partial relayout if not adjusting view size. (-[WebCoreFrameBridge needsLayout]): Changed to check for pending subtree layout instead of just whether the root needs layout.

12:28 PM Changeset in webkit [20323] by zimmermann

5 edits in trunk

Reviewed by Maciej.

Make JS function calls on POD-types (ie. SVGLength) take effect.
Calling ie. newValueInSpecifiedUnits on SVGLength works as expected.

This worked fine before we switched to SVGLength POD type, so this
can be considered as P1 regression fix.

Partly fix svg/hixie/dynamic/005-broken.svg. We match Opera now though
it's not yet completly fixed. Setting baseVal attribute on SVGAnimatedString
doesn't work as expected - needs a seperated fix.

12:07 PM Changeset in webkit [23115] by aroben

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by Maciej.

Skip tests with international text due to <rdar://problems/4516194>.

Skipped:

11:21 AM Changeset in webkit [20322] by adele

2 edits in trunk/WebCore

Reviewed by Adam.

Adding comments and a little cleanup from my last checkin.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Removed commented out assert. Added comment about how we use onChange. (WebCore::HTMLSelectElement::selectAll): Added comment about how we use saveLastSelection and onChange. (WebCore::HTMLSelectElement::dispatchFocusEvent): ditto. (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto. (WebCore::HTMLSelectElement::menuListOnChange): Added assert that usesMenuList() is true. (WebCore::HTMLSelectElement::listBoxOnChange): Added assert that usesMenuList() is false. (WebCore::HTMLSelectElement::saveLastSelection): Added early return for menu lists.

11:14 AM JavaScript and DOM Benchmarks edited by timothy@apple.com

(diff)

9:57 AM Changeset in webkit [20321] by zimmermann

1 edit
300 adds in trunk/LayoutTests

Reviewed by Maciej.

Import Hixie's SVG testsuite. It highlights one bug, one regression in JS and one crash.
The crashing file is marked with "-disabled", the broken ones with "-broken".

Landing fixes for the certain bugs/regressions seperated.

6:17 AM Changeset in webkit [20320] by sullivan

2 edits in trunk/WebKit

Reviewed by Justin

fixed <rdar://problem/5071238> REGRESSION: opt-cmd-B to show Bookmarks view does nothing when form field has focus

WebView/WebHTMLView.mm: (-[WebHTMLView _handleStyleKeyEquivalent:]): we were counting any set of modifiers plus 'b' as the standard key equivalent for toggling Bold; now we only accept command+'b'

5:46 AM Changeset in webkit [20319] by bdash

7 edits
2 adds in trunk

2007-03-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Tim Hatcher.

fix http://bugs.webkit.org/show_bug.cgi?id=13091 REGRESSION (r20075): Wrong text style and pixel break in Apple Store Locator HUD

Test: fast/innerHTML/additional-inline-style.html

editing/markup.cpp: (WebCore::startMarkup): Changed to add inline style based on CSS rules only in AnnotateForInterchange mode.

2007-03-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Tim Hatcher.

test and updated result for http://bugs.webkit.org/show_bug.cgi?id=13091 REGRESSION (r20075): Wrong text style and pixel break in Apple Store Locator HUD

editing/pasteboard/paste-table-002-expected.txt:
fast/innerHTML/additional-inline-style-expected.txt: Added.
fast/innerHTML/additional-inline-style.html: Added.
webarchive/test-duplicate-resources-expected.txt:
webarchive/test-frameset-expected.txt:
webarchive/test-link-href-expected.txt:

2:32 AM Changeset in webkit [23114] by aroben

4 edits in branches/WindowsMerge/WebKitTools

Reviewed by Hyatt.

Implemented some more layoutTestController methods:

display
testRepaint
repaintSweepHorizontally

The last two don't have any effect yet because we don't support pixel
tests yet (<rdar://problem/5071708>).

This gets all but one test in fast/repaint passing, and fixes various
other tests that use these methods as well.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runTest): Initialize new globals.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declarations.
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (displayCallback): Implemented. (testRepaintCallback): Implemented. (repaintSweepHorizontallyCallback): Implemented.

1:19 AM Changeset in webkit [20318] by zack

2 edits in trunk/WebCore

compile fix for qt

1:00 AM Changeset in webkit [20317] by aroben

5 edits
2 moves in trunk

WebCore:

Reviewed by Hyatt and Maciej.

Renamed WebCoreJavaScript to JavaScriptStatistics and made it C++ as
part of <rdar://problem/5071653>.

All layout tests pass.

WebCore.exp: Updated.
WebCore.xcodeproj/project.pbxproj: Updated.
bridge/JavaScriptStatistics.cpp: Moved from bridge/mac/WebCoreJavaScript.mm, and converted to C++. (WebCore::collect): (WebCore::JavaScriptStatistics::objectCount): (WebCore::JavaScriptStatistics::interpreterCount): (WebCore::JavaScriptStatistics::protectedObjectCount): (WebCore::JavaScriptStatistics::rootObjectTypeCounts): (WebCore::JavaScriptStatistics::garbageCollect): (WebCore::JavaScriptStatistics::garbageCollectOnAlternateThread): (WebCore::JavaScriptStatistics::shouldPrintExceptions): (WebCore::JavaScriptStatistics::setShouldPrintExceptions):
bridge/JavaScriptStatistics.h: Added.
bridge/mac/WebCoreJavaScript.h: Removed.
bridge/mac/WebCoreJavaScript.mm: Removed.

WebKit:

Reviewed by Hyatt and Maciej.

Updated WebCoreStatistics for the conversion of WebCoreJavaScript to
C++.

Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptObjectsCount]): (+[WebCoreStatistics javaScriptInterpretersCount]): (+[WebCoreStatistics javaScriptProtectedObjectsCount]): (+[WebCoreStatistics javaScriptRootObjectTypeCounts]): Moved conversion to NSCountedSet here from WebCore. (+[WebCoreStatistics garbageCollectJavaScriptObjects]): (+[WebCoreStatistics garbageCollectJavaScriptObjectsOnAlternateThread:]): (+[WebCoreStatistics shouldPrintExceptions]): (+[WebCoreStatistics setShouldPrintExceptions:]): (+[WebCoreStatistics javaScriptReferencedObjectsCount]): (+[WebCoreStatistics javaScriptRootObjectClasses]):

12:49 AM Changeset in webkit [23113] by aroben