Context Navigation

Added JSObject::removeDirect, to support the fix for
<rdar://problem/5522487> REGRESSION: With JavaScript disabled, any
page load causes a crash in PropertyMap::put

kjs/object.cpp: (KJS::JSObject::removeDirect):
kjs/object.h:

WebCore:

Reviewed by Sam Weinig.

New fix for <rdar://problem/5522487> REGRESSION: With JavaScript
disabled, any page load causes a crash in PropertyMap::put

Explicitly remove the "document" property from the window. The old
solution would leave a stale "document" property around after JavaScript
was re-enabled.

The architecture for disabling JavaScript could use some consolidation.
It seems wrong that a script proxy even exists when JavaScript is
disabled. It also seems wrong that so many individual call sites are
responsible for checking whether JavaScript is enabled. I've filed a
bug about this: http://bugs.webkit.org/show_bug.cgi?id=15385.

bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clearDocumentWrapper):
bindings/js/kjs_proxy.h:
page/Frame.cpp: (WebCore::Frame::setDocument):

1:18 PM Changeset in webkit [26084] by bdash

2 edits in tags/Safari-5523.10.3/WebCore

Merge r26071.

Reviewed by Sam Weinig.

Fixed <rdar://problem/5522487> REGRESSION: With JavaScript disabled,
any page load causes a crash in PropertyMap::put

The problem was that we were using JavaScript when JavaScript was
disabled. The architecture for disabling JavaScript could use some
consolidation, but this is the simplest, safest change for now.

Currently passing layout tests still pass.

bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::updateDocumentWrapper):

1:08 PM Changeset in webkit [26083] by bdash

1 copy in tags/Safari-5523.10.3

New tag.

6:30 AM Changeset in webkit [26082] by bdash

3 edits in branches/feature-branch/WebCore

2007-10-06 Mark Rowe <mrowe@apple.com>

Reviewed by Alp Toker.

Gtk+ build fix and minor code cleanup.

WebCore.pro:
platform/gtk/FontCacheGtk.cpp: (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::fontExists):

4:00 AM Changeset in webkit [26081] by ap

3 edits
2 adds in branches/feature-branch

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=15380
XPath: id('foo') doesn't resolve correctly

Test: fast/xpath/id-simple.html

xml/XPathFunctions.cpp: (WebCore::XPath::FunId::evaluate): Fixed a logic error in id() parameter parsing.

3:44 AM Changeset in webkit [26080] by ap

1 edit in branches/feature-branch/WebCore/ChangeLog

Removing a conflict marker.

2:08 AM Changeset in webkit [26079] by ap

2 edits in branches/feature-branch/LayoutTests

fast/dom/xmlhttprequest-get-expected.txt: Updated event properties for changes made in bug 15102.

1:56 AM Changeset in webkit [26078] by ap

36 edits
4 deletes in branches/feature-branch

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13707
REGRESSION: JavaScript exceptions on quotes.burntelectrons.org

http://bugs.webkit.org/show_bug.cgi?id=12628
document.body is not supported in XHTML documents

http://bugs.webkit.org/show_bug.cgi?id=14213
On page with MIME type application/xhtml+xml, cookie don't work

WebCore:

Moved a bunch of methods and properties from HTMLDocument down into Document to make
them available for all documents (xml, svg).
What was kept in HTMLDocument:

some methods and properties that are not in HTML5 (yet?);
open/write/writeln/close, as they will need to be modified to work on XML documents, and aren't of much use for those anyway;
designMode, because its definition in HTML5 is incompatible with our implementation.

Covered by existing tests.

bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::JSDocument::setLocation):
bindings/js/JSHTMLDocumentCustom.cpp:
bindings/objc/PublicDOMInterfaces.h:
dom/Document.cpp: (WebCore::Document::setBody): (WebCore::Document::cookie): (WebCore::Document::setCookie): (WebCore::Document::lastModified):
dom/Document.h: (WebCore::Document::title):
dom/Document.idl:
html/HTMLDocument.cpp:
html/HTMLDocument.h:
html/HTMLDocument.idl:

LayoutTests:

dom/xhtml/level2/html/HTMLBaseElement01-expected.checksum: Removed.
dom/xhtml/level2/html/HTMLBaseElement01-expected.png: Removed.
dom/xhtml/level2/html/HTMLBaseElement01-expected.txt:
dom/xhtml/level2/html/HTMLBaseElement01.xhtml:
dom/xhtml/level2/html/HTMLBaseElement02-expected.checksum: Removed.
dom/xhtml/level2/html/HTMLBaseElement02-expected.png: Removed.
dom/xhtml/level2/html/HTMLBaseElement02-expected.txt:
dom/xhtml/level2/html/HTMLBaseElement02.xhtml:
dom/xhtml/level2/html/HTMLBodyElement07-expected.txt:
dom/xhtml/level2/html/HTMLBodyElement08-expected.txt:
dom/xhtml/level2/html/HTMLBodyElement09-expected.txt:
dom/xhtml/level2/html/HTMLBodyElement10-expected.txt:
dom/xhtml/level2/html/HTMLBodyElement11-expected.txt:
dom/xhtml/level2/html/HTMLBodyElement12-expected.txt:
dom/xhtml/level2/html/HTMLDocument01-expected.txt:
dom/xhtml/level2/html/HTMLDocument02-expected.txt:
dom/xhtml/level2/html/HTMLDocument03-expected.txt:
dom/xhtml/level2/html/HTMLDocument05-expected.txt:
dom/xhtml/level2/html/HTMLDocument07-expected.txt:
dom/xhtml/level2/html/HTMLDocument08-expected.txt:
dom/xhtml/level2/html/HTMLDocument09-expected.txt:
dom/xhtml/level2/html/HTMLDocument10-expected.txt:
dom/xhtml/level2/html/HTMLDocument11-expected.txt:
dom/xhtml/level2/html/HTMLDocument12-expected.txt:
dom/xhtml/level2/html/HTMLDocument13-expected.txt:
dom/xhtml/level2/html/HTMLDocument14-expected.txt:
dom/xhtml/level2/html/doc01-expected.txt: These now pass. Changed HTMLBaseElement* to dump as text.

fast/dom/Window/window-properties-expected.txt: Added Document.prototype.getElementsByName

1:49 AM Changeset in webkit [26077] by eseidel

21 edits in branches/feature-branch/WebCore

2007-10-06 Eric Seidel <eric@webkit.org>

Reviewed by Oliver Hunt.

RenderSVGContainer (<g>) should not repaint when its bounds change (unless it has a filter)
http://bugs.webkit.org/show_bug.cgi?id=15388
This makes the Sun Lively Kernel invalidate only what it should!

No tests possible in DRT.

ksvg2/svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::notifyAttributeChange): replace call to rebuildRenderer
ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::notifyAttributeChange): replace call to rebuildRenderer
ksvg2/svg/SVGImageElement.cpp: (WebCore::SVGImageElement::notifyAttributeChange): replace call to rebuildRenderer (WebCore::SVGImageElement::hasRelativeValues): implemented
ksvg2/svg/SVGImageElement.h:
ksvg2/svg/SVGLineElement.cpp: (WebCore::SVGLineElement::notifyAttributeChange): replace call to rebuildRenderer
ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::notifyAttributeChange): replace call to rebuildRenderer
ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::notifyAttributeChange): replace call to rebuildRenderer
ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::notifyAttributeChange): replace call to rebuildRenderer
ksvg2/svg/SVGStyledElement.cpp:
ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasRelativeValues): default to true instead
ksvg2/svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::updateLocalTransform): don't layout if no change
ksvg2/svg/SVGStyledTransformableElement.h:
ksvg2/svg/SVGTransform.h:
rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
rendering/RenderPath.h:
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::selfWillPaint): return true if have a filter (WebCore::RenderSVGContainer::paint):
rendering/RenderSVGContainer.h:
rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::layout):
rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout):
rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout): (WebCore::RenderSVGViewportContainer::calcViewport): use floats

1:28 AM Changeset in webkit [26076] by rwlbuis

16 edits in branches/feature-branch/WebCore

Reviewed by Eric.

Use document() instead of ownerDocument() and a few other cleanups.

Oct 5, 2007:

5:56 PM Changeset in webkit [26075] by eseidel

6 edits in branches/feature-branch/WebCore

2007-10-05 Eric Seidel <eric@webkit.org>

Reviewed by Oliver Hunt.

SVG invalidates way too much during layout()
http://bugs.webkit.org/show_bug.cgi?id=14003

ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::ownerSVGElement): simplify if (WebCore::SVGElement::viewportElement): simplify if
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): only layout children if parent changed
rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): only layout children when size changes
rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): hack to avoid bad RenderBlock::layout code
rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout): don't use RenderSVGContainer::layout()

5:54 PM Changeset in webkit [26074] by ggaren

8 edits in trunk

JavaScriptCore:

Reviewed by Sam Weinig.

Added JSObject::removeDirect, to support the fix for
<rdar://problem/5522487> REGRESSION: With JavaScript disabled, any
page load causes a crash in PropertyMap::put

kjs/object.cpp: (KJS::JSObject::removeDirect):
kjs/object.h:

WebCore:

Reviewed by Sam Weinig.

New fix for <rdar://problem/5522487> REGRESSION: With JavaScript
disabled, any page load causes a crash in PropertyMap::put

Explicitly remove the "document" property from the window. The old
solution would leave a stale "document" property around after JavaScript
was re-enabled.

The architecture for disabling JavaScript could use some consolidation.
It seems wrong that a script proxy even exists when JavaScript is
disabled. It also seems wrong that so many individual call sites are
responsible for checking whether JavaScript is enabled. I've filed a
bug about this: http://bugs.webkit.org/show_bug.cgi?id=15385.

bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clearDocumentWrapper):
bindings/js/kjs_proxy.h:
page/Frame.cpp: (WebCore::Frame::setDocument):

5:22 PM Changeset in webkit [26073] by oliver

2 edits in branches/feature-branch/WebCore

30%+ performance improvement for svg embedded in xhtml

Reviewed by Eric.

Relayout internal to SVG was incorrectly being propagated to
the containing xhtml element, which subsequently resulted in
a full paint of the SVG, rather than just the dirty regions.

rendering/RenderObject.cpp:

(WebCore::objectIsRelayoutBoundary):
(WebCore::RenderObject::markContainingBlocksForLayout):

2:38 PM Changeset in webkit [26072] by honeycutt

2 edits in trunk/WebCore

2007-10-05 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://5520913> Ticketmaster.com doesn't display correctly (Flash
related?)

The plugin is requesting files that don't exist on the server, and
we are passing the 404 error page to the plugin. This change cancels the
stream if the response code indicates a failure.

This is a port of the safari / mac code.

loader/win/NetscapePlugInStreamLoaderWin.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): If the response code indicates a failure, cancel the stream

1:12 PM Changeset in webkit [26071] by ggaren

2 edits in trunk/WebCore

Reviewed by Sam Weinig.

Fixed <rdar://problem/5522487> REGRESSION: With JavaScript disabled,
any page load causes a crash in PropertyMap::put

The problem was that we were using JavaScript when JavaScript was
disabled. The architecture for disabling JavaScript could use some
consolidation, but this is the simplest, safest change for now.

Currently passing layout tests still pass.

bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::updateDocumentWrapper):

1:04 PM Changeset in webkit [26070] by bdakin

4 edits in trunk

WebCore:

Reviewed by John Sullivan.

Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only):
Vertical scroll bar not redrawn properly when going back in history
(15033)

This fix if-defs r25142 to be Leopard-only since it causes
correctness issues on Tiger and does not seem to have any
performance impact on Tiger either.

loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):

WebKit:

Reviewed by John Sullivan.

Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only):
Vertical scroll bar not redrawn properly when going back in history
(15033)

This fix if-defs r25142 to be Leopard-only since it causes
correctness issues on Tiger and does not seem to have any
performance impact on Tiger either.

WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]):

9:57 AM Changeset in webkit [26069] by adachan

2 edits in trunk/WebKit/win

<rdar://problem/5436617>
Implement WebIconDatabase::delayDatabaseCleanup() and WebIconDatabase::allowDatabaseCleanup().

Reviewed by Brady.

WebIconDatabase.cpp: (WebIconDatabase::delayDatabaseCleanup): (WebIconDatabase::allowDatabaseCleanup):

9:52 AM Changeset in webkit [26068] by adachan

2 edits in trunk/WebCore

<rdar://problem/5436617> Favicons sometimes don't show up even when they are
in the database

A client can try to retain an icon for a page before the database is actually opened. Since isOpened() is not a requirement to retain an icon, remove the check for that. Instead, we'll check to make sure whether this database is enabled before proceeding.

Reviewed by Brady.

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::retainIconForPageURL): (WebCore::IconDatabase::releaseIconForPageURL): only check isOpen() before we schedule for a sync.

3:56 AM Changeset in webkit [26067] by lars

5 edits in trunk/LayoutTests/platform/qt

these tests deliver the same results as on the Mac, which
makes them pass :)

3:25 AM Changeset in webkit [26066] by lars

4 edits in trunk

fix a hang in editing/selection/extend-by-word-002.html

2:10 AM Changeset in webkit [26065] by lars

1 edit
2 adds in trunk/WebKitTools

forgot to add these files in r26061.

2:06 AM Changeset in webkit [26064] by lars

14 deletes in trunk/LayoutTests/platform/qt/traversal

remove platform specific results, after r26045 turned
these tests into being text only.

2:04 AM Changeset in webkit [26063] by lars

1 edit in trunk/LayoutTests/platform/qt/Skipped

remove four more passing tests from the skipped list.

1:57 AM Changeset in webkit [26062] by lars

10 edits in trunk

add proper error messages to the FrameLoaderClient.
Implement ChromeClientQt::closeWindowSoon and
FrameLoaderClientQt::dispatchCreatePage (which should go
away IMO).
Some fixes in DRT to make it work correctly with multiple
windows.

1:57 AM Changeset in webkit [26061] by lars

9 edits in trunk

Add a dummy plugin to DRT to fix fast/dom/Window/Plug-Ins.html.
Add support for layoutTextController.setCanOpenWindows() to DRT
fixing another 2 test cases in fast/dom/Window.

12:45 AM Changeset in webkit [26060] by bdash