⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 7, 2007:

5:41 PM Changeset in webkit [26103] by zimmermann
  • 35 edits in branches/feature-branch

Reviewed by Eric.

Fix some issues with rotation & baseline-shift, when spanning
across <tspan> elements. Highlighted by the existing batik tests.

5:14 PM Changeset in webkit [26102] by aroben
  • 2 edits in trunk/WebCore

Fix Bug 15305: Crash when dragging an image when "load images automatically" preference is off

​http://bugs.webkit.org/show_bug.cgi?id=15305
<rdar://problem/5524774>

Reviewed by Eric Seidel.

No test possible: to reproduce this you have to change a WebKit

preference and reload the page. See
​http://bugs.webkit.org/show_bug.cgi?id=15414

  • platform/win/ClipboardWin.cpp: (WebCore::createGlobalImageFileDescriptor): ASSERT that we have an image and that it has a SharedBuffer. (WebCore::writeImageToDataObject): The fix: null-check imageBuffer.
7:37 AM Changeset in webkit [26101] by bdash
  • 4 edits
    2 adds in branches/feature-branch

2007-10-07 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Bug 5122: Need an equivalent of Mozilla's DOMContentLoaded event
​http://bugs.webkit.org/show_bug.cgi?id=5122

This is based on a patch by Daniel Peebles (​pumpkingod@gmail.com).

Test: http/tests/loading/DOMContentLoaded-event.html

  • dom/Document.cpp: (WebCore::Document::finishedParsing): Dispatch the DOMContentLoaded event when parsing completes.
  • dom/EventNames.h: Add DOMContentLoaded to the list of events.

2007-10-07 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

Test for Bug 5122: Need an equivalent of Mozilla's DOMContentLoaded event
​http://bugs.webkit.org/show_bug.cgi?id=5122

  • http/tests/loading/DOMContentLoaded-event-expected.txt: Added.
  • http/tests/loading/DOMContentLoaded-event.html: Added.
5:17 AM Changeset in webkit [26100] by zimmermann
  • 5 edits in branches/feature-branch/LayoutTests

Reviewed by Mark.
Fix textLength.svg testcase - missed xmlns.

4:21 AM Changeset in webkit [26099] by ap
  • 4 edits in branches/feature-branch/JavaScriptCore

2007-10-07 Ed Schouten <​ed@fxq.nl>

Reviewed and landed by Alexey Proskuryakov.

Add PLATFORM(FREEBSD), so we can fix the build on FreeBSD-like
systems by including <pthread_np.h>. Also fix some (disabled)
regcomp()/regexec() code; it seems some variable names have
changed.

  • kjs/config.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp):
  • wtf/Platform.h:
4:16 AM Changeset in webkit [26098] by ap
  • 1 edit in branches/feature-branch/JavaScriptCore/tests/mozilla/expected.html

Forgot to commit this with r25958.

1:54 AM Changeset in webkit [26097] by ap
  • 3 edits
    4 adds in branches/feature-branch

Reviewed by Eric Seidel.

​http://bugs.webkit.org/show_bug.cgi?id=15368
xsl:import fails when preceded by comment

Test: fast/xsl/import-after-comment.xml

  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::loadChildSheets): It's OK for xsl:import to be preceded by non-element nodes.
1:37 AM Changeset in webkit [26096] by eseidel
  • 5 edits
    6 adds in branches/feature-branch

2007-10-07 Vincent Ricard <​magic@magicninja.org>

Reviewed by Maciej. Landed by eseidel.

​http://bugs.webkit.org/show_bug.cgi?id=15062
Implement document.compatMode

Tests: fast/dom/compatMode-AlmostStrict.html

fast/dom/compatMode-Compat.html
fast/dom/compatMode-Strict.html

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::compatMode):
  • html/HTMLDocument.h:
  • html/HTMLDocument.idl:
1:07 AM Changeset in webkit [26095] by zecke
  • 2 edits in trunk/WebKitTools

2007-10-07 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber stamped by Eric.

Connect to the "hovering-over-link" signal emitted by WebKitPage and
show the current link inside the statusbar.
This shows how to make use of this signal and allows to easily test
​http://bugs.webkit.org/show_bug.cgi?id=15299.

  • GtkLauncher/main.cpp: (hoveringOverLink): (main):
1:06 AM Changeset in webkit [26094] by eseidel
  • 16 edits
    1 add in branches/feature-branch

2007-10-07 Sam Weinig <​sam@webkit.org>

Reviewed by Darin & Nikolas. Landed by eseidel.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=14455
Autogenerate the JS bindings for the StyleSheetList

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSStyleSheetListCustom.cpp: Added. (WebCore::JSStyleSheetList::canGetItemsForName): (WebCore::JSStyleSheetList::nameGetter):
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_css.h:
  • bindings/objc/DOMUtility.mm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/StyleSheetList.cpp: (WebCore::StyleSheetList::StyleSheetList): (WebCore::StyleSheetList::documentDestroyed): (WebCore::StyleSheetList::getNamedItem):
  • css/StyleSheetList.h: Add Document member variable and getNamedItem function to accommodate the odd javascript name getter functionality.
  • css/StyleSheetList.idl:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
  • page/DOMWindow.idl: Add StyleSheetListConstructor
12:40 AM Changeset in webkit [26093] by eseidel
  • 2 edits in branches/feature-branch/WebCore

2007-10-07 Lars Naesbye Christensen <​lars@naesbye.dk>

Reviewed by Eric Seidel.

make CSS cell cursor more mac-like
​http://bugs.webkit.org/show_bug.cgi?id=15325

  • Resources/cellCursor.png:

Oct 6, 2007:

10:08 PM Changeset in webkit [26092] by eseidel
  • 3 edits in branches/feature-branch/WebCore

2007-10-06 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver.


SVG does not correctly handle onfocusin, onfocusout or onactivate
​http://bugs.webkit.org/show_bug.cgi?id=12573

Test: svg/W3C-SVG-1.1/script-handle-02-b.svg

  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::parseMappedAttribute):
  • ksvg2/svg/svgattrs.in: add onfocusin, onfocusout and onactivate
7:00 PM SVG TODO List - Short notes edited by eric@webkit.org
(diff)
5:23 PM SVG TODO List - Short notes edited by zimmermann@kde.org
Fix some typos. (diff)
5:22 PM SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
5:20 PM SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
4:55 PM SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
4:55 PM SVG TODO List - Short notes edited by zimmermann@kde.org
Nicer output. (diff)
4:50 PM SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
3:47 PM Changeset in webkit [26091] by zimmermann
  • 3 edits in branches/feature-branch/WebCore

Reviewed by Oliver.
Never pass null input images to CICrop filter.

3:00 PM Changeset in webkit [26090] by zimmermann
  • 3 edits in branches/feature-branch/LayoutTests

Reviewed by Mark.

Remove useless onload/onunload handlers from js-update-container.svg,
causing a console message saying these handlers don't exist.

2:51 PM Changeset in webkit [26089] by zimmermann
  • 724 edits
    3 deletes in branches/feature-branch/LayoutTests

Rubberstamped by Oliver.
Update SVG baseline with Tiger. No regressions.

1:58 PM Changeset in webkit [26088] by bdash
  • 8 edits in tags/Safari-4523.10.3

Merge r26050.

1:19 PM Changeset in webkit [26087] by bdash
  • 1 copy in tags/Safari-4523.10.3

New tag.

1:19 PM Changeset in webkit [26086] by bdash
  • 4 edits in tags/Safari-5523.10.3

Versioning.

1:18 PM Changeset in webkit [26085] by bdash
  • 8 edits in tags/Safari-5523.10.3

Merge r26074.

JavaScriptCore:

Reviewed by Sam Weinig.

Added JSObject::removeDirect, to support the fix for
<rdar://problem/5522487> REGRESSION: With JavaScript disabled, any
page load causes a crash in PropertyMap::put

  • kjs/object.cpp: (KJS::JSObject::removeDirect):
  • kjs/object.h:

WebCore:

Reviewed by Sam Weinig.

New fix for <rdar://problem/5522487> REGRESSION: With JavaScript
disabled, any page load causes a crash in PropertyMap::put

Explicitly remove the "document" property from the window. The old
solution would leave a stale "document" property around after JavaScript
was re-enabled.

The architecture for disabling JavaScript could use some consolidation.
It seems wrong that a script proxy even exists when JavaScript is
disabled. It also seems wrong that so many individual call sites are
responsible for checking whether JavaScript is enabled. I've filed a
bug about this: ​http://bugs.webkit.org/show_bug.cgi?id=15385.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clearDocumentWrapper):
  • bindings/js/kjs_proxy.h:
  • page/Frame.cpp: (WebCore::Frame::setDocument):
1:18 PM Changeset in webkit [26084] by bdash
  • 2 edits in tags/Safari-5523.10.3/WebCore

Merge r26071.

Reviewed by Sam Weinig.

Fixed <rdar://problem/5522487> REGRESSION: With JavaScript disabled,
any page load causes a crash in PropertyMap::put

The problem was that we were using JavaScript when JavaScript was
disabled. The architecture for disabling JavaScript could use some
consolidation, but this is the simplest, safest change for now.

Currently passing layout tests still pass.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::updateDocumentWrapper):
1:08 PM Changeset in webkit [26083] by bdash
  • 1 copy in tags/Safari-5523.10.3

New tag.

6:30 AM Changeset in webkit [26082] by bdash
  • 3 edits in branches/feature-branch/WebCore

2007-10-06 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp Toker.

Gtk+ build fix and minor code cleanup.

  • WebCore.pro:
  • platform/gtk/FontCacheGtk.cpp: (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::fontExists):
4:00 AM Changeset in webkit [26081] by ap
  • 3 edits
    2 adds in branches/feature-branch

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=15380
XPath: id('foo') doesn't resolve correctly

Test: fast/xpath/id-simple.html

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunId::evaluate): Fixed a logic error in id() parameter parsing.
3:44 AM Changeset in webkit [26080] by ap
  • 1 edit in branches/feature-branch/WebCore/ChangeLog

Removing a conflict marker.

2:08 AM Changeset in webkit [26079] by ap
  • 2 edits in branches/feature-branch/LayoutTests
  • fast/dom/xmlhttprequest-get-expected.txt: Updated event properties for changes made in bug 15102.
1:56 AM Changeset in webkit [26078] by ap
  • 36 edits
    4 deletes in branches/feature-branch

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13707
REGRESSION: JavaScript exceptions on quotes.burntelectrons.org

​http://bugs.webkit.org/show_bug.cgi?id=12628
document.body is not supported in XHTML documents

​http://bugs.webkit.org/show_bug.cgi?id=14213
On page with MIME type application/xhtml+xml, cookie don't work

WebCore:

Moved a bunch of methods and properties from HTMLDocument down into Document to make
them available for all documents (xml, svg).
What was kept in HTMLDocument:

  • some methods and properties that are not in HTML5 (yet?);
  • open/write/writeln/close, as they will need to be modified to work on XML documents, and aren't of much use for those anyway;
  • designMode, because its definition in HTML5 is incompatible with our implementation.

Covered by existing tests.

  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::JSDocument::setLocation):
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/objc/PublicDOMInterfaces.h:
  • dom/Document.cpp: (WebCore::Document::setBody): (WebCore::Document::cookie): (WebCore::Document::setCookie): (WebCore::Document::lastModified):
  • dom/Document.h: (WebCore::Document::title):
  • dom/Document.idl:
  • html/HTMLDocument.cpp:
  • html/HTMLDocument.h:
  • html/HTMLDocument.idl:

LayoutTests:

  • dom/xhtml/level2/html/HTMLBaseElement01-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBaseElement01-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBaseElement01-expected.txt:
  • dom/xhtml/level2/html/HTMLBaseElement01.xhtml:
  • dom/xhtml/level2/html/HTMLBaseElement02-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBaseElement02-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBaseElement02-expected.txt:
  • dom/xhtml/level2/html/HTMLBaseElement02.xhtml:
  • dom/xhtml/level2/html/HTMLBodyElement07-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement08-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement09-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement10-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement11-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement12-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument01-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument02-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument03-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument05-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument07-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument08-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument09-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument10-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument11-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument12-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument13-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument14-expected.txt:
  • dom/xhtml/level2/html/doc01-expected.txt: These now pass. Changed HTMLBaseElement* to dump as text.
  • fast/dom/Window/window-properties-expected.txt: Added Document.prototype.getElementsByName
1:49 AM Changeset in webkit [26077] by eseidel
  • 21 edits in branches/feature-branch/WebCore

2007-10-06 Eric Seidel <​eric@webkit.org>

Reviewed by Oliver Hunt.

RenderSVGContainer (<g>) should not repaint when its bounds change (unless it has a filter)
​http://bugs.webkit.org/show_bug.cgi?id=15388
This makes the Sun Lively Kernel invalidate only what it should!


No tests possible in DRT.

  • ksvg2/svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::notifyAttributeChange): replace call to rebuildRenderer
  • ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::notifyAttributeChange): replace call to rebuildRenderer
  • ksvg2/svg/SVGImageElement.cpp: (WebCore::SVGImageElement::notifyAttributeChange): replace call to rebuildRenderer (WebCore::SVGImageElement::hasRelativeValues): implemented
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLineElement.cpp: (WebCore::SVGLineElement::notifyAttributeChange): replace call to rebuildRenderer
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::notifyAttributeChange): replace call to rebuildRenderer
  • ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::notifyAttributeChange): replace call to rebuildRenderer
  • ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::notifyAttributeChange): replace call to rebuildRenderer
  • ksvg2/svg/SVGStyledElement.cpp:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasRelativeValues): default to true instead
  • ksvg2/svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::updateLocalTransform): don't layout if no change
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGTransform.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::selfWillPaint): return true if have a filter (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::layout):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout):
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout): (WebCore::RenderSVGViewportContainer::calcViewport): use floats
1:28 AM Changeset in webkit [26076] by rwlbuis
  • 16 edits in branches/feature-branch/WebCore

Reviewed by Eric.

Use document() instead of ownerDocument() and a few other cleanups.

Note: See TracTimeline for information about the timeline view.