⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 23, 2007:

10:09 PM Changeset in webkit [27997] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Fix bisect-builds to work with recent WebKit nightly builds.

Reviewed by Dan.

  • Scripts/bisect-builds: Check for the WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use it for the DYLD_FRAMEWORK_PATH environment variable, else fallback to WebKit.app/Contents/Resources.
8:48 PM Changeset in webkit [27996] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Bug 16110: Clicking inside the resource headers in the network timeline collapses them
​http://bugs.webkit.org/show_bug.cgi?id=16110

Toggle the resource headers only if the click happens on the
resource row, not within the headers area.

  • WebCore.xcodeproj/project.pbxproj:
  • page/inspector/NetworkPanel.js:
8:11 PM HackingGtk edited by alp@atoker.com
Add WebCore and WebKit specific hacking guides (diff)
7:14 PM Changeset in webkit [27995] by oliver@apple.com
  • 2 edits in trunk/WebKit/mac

Fixed <rdar://problem/3759190> allow input methods the option of processing mouse events themselves

Reviewed by Mark Rowe.

4:52 PM Changeset in webkit [27994] by kevino@webkit.org
  • 7 edits in trunk

Windows build fixes for USE(CURL) and MSVC compilation for ports.

Reviewed by Adam Roben.

4:11 PM BuildingGtk edited by alp@atoker.com
Fix the link, split out the hacking guide (diff)
4:11 PM HackingGtk created by alp@atoker.com
Add GTK+ hacking information verbatim
4:05 PM BuildingGtk edited by alp@atoker.com
Add link to HackingGtk (diff)
3:22 PM Changeset in webkit [27993] by kevino@webkit.org
  • 2 edits in trunk

Forgot to add JSCore and WebCore ChangeLog during previous commit.

3:17 PM Changeset in webkit [27992] by kevino@webkit.org
  • 11 edits in trunk

Fix the wx buildbot after removal of move-js-headers.sh..

2:03 PM Changeset in webkit [27991] by alp@webkit.org
  • 4 edits in trunk/WebKit/gtk

2007-11-22 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Implement and document several WebKitFrame functions, some of which
are necessary to support DRT.

Correct NULL handling and improve run-time checks.

  • Api/webkitgtkframe.cpp:
  • Api/webkitgtkframe.h:
  • Api/webkitgtkprivate.cpp:
12:07 PM Changeset in webkit [27990] by Antti Koivisto
  • 17 edits in trunk/LayoutTests

Set video src from script, not from the element attribute. This
guarantees load events do not fire before event listeners are registered.
This change does not affect test results.

  • media/progress-event.html:
  • media/video-autoplay.html:
  • media/video-buffered.html:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-dom-autoplay.html:
  • media/video-error-abort.html:
  • media/video-error-does-not-exist.html:
  • media/video-load-networkState.html:
  • media/video-load-readyState.html:
  • media/video-no-autoplay.html:
  • media/video-seekable.html:
  • media/video-seeking.html:
  • media/video-size.html:
  • media/video-src.html:
  • media/video-start.html:
7:56 AM Changeset in webkit [27989] by Simon Hausmann
  • 2 edits in trunk/WebCore

Another build fix specific to trunk (instead of the stable branch) to fix make clean (which the buildbots call).

Signed-off-by: George Staikos <​staikos@kde.org>

7:44 AM Changeset in webkit [27988] by Simon Hausmann
  • 3 edits in trunk/JavaScriptCore

Fix make (dist)clean on Windows.

OBJECTS_DIR_WTR does not exist anymore, use GENERATED_SOURCES_DIR.

Signed-off-by: George Staikos <​staikos@kde.org>

6:37 AM QtWebKitGitInstructions edited by Simon Hausmann
(diff)
5:56 AM QtWebKitGitInstructions edited by Simon Hausmann
(diff)
5:30 AM UsingGitWithWebKit edited by Simon Hausmann
(diff)
5:30 AM QtWebKitGitInstructions created by Simon Hausmann
5:29 AM QtWebKitContrib edited by Simon Hausmann
(diff)
5:29 AM QtWebKitContrib edited by Simon Hausmann
(diff)
5:21 AM UsingGitWithWebKit edited by Simon Hausmann
(diff)
5:19 AM UsingGitWithWebKit edited by Simon Hausmann
(diff)
4:27 AM Changeset in webkit [27987] by ap@webkit.org
  • 2 edits in trunk/WebCore

Not reviewed, trivial leak fix.

Fix xsltUnicodeSortFunction() memory leaks.

  • xml/XSLTUnicodeSort.cpp: (WebCore::xsltUnicodeSortFunction):
2:52 AM ProjectVision created by lars@webkit.org
2:19 AM Changeset in webkit [27986] by ap@webkit.org
  • 6 edits
    8 adds in trunk

Reviewed by Maciej.

<rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
not closed (affects digg.com)

Tests: fast/loader/meta-refresh-vs-open.html

fast/loader/redirect-with-open-subframe-2.html
fast/loader/redirect-with-open-subframe.html
http/tests/loading/onload-vs-immediate-refresh.pl

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleRedirection): Only check whether the load is complete for HTTP redirects - JavaScript-initiated ones are effective immediately.

WebKitTools:

  • DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank one after finishing with a test to avoid having its delayed onload handler fired when starting the next test. This is ugly and still unreliable (see LayoutTests ChangeLog), but it helps somewhat.
1:39 AM WebKit Team edited by Simon Hausmann
(diff)
1:24 AM QtWebKit edited by lars@webkit.org
(diff)
1:21 AM WebKit Team edited by staikos@webkit.org
Remove irc handle (diff)
1:20 AM Changeset in webkit [27985] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Alexey Proskuryakov.

  • apply matrix transforms on the correct side of the transformation matrix (not on the side where the vector is multiplied).

Test: fast/transforms/matrix-02.html

  • rendering/RenderStyle.h: (WebCore::MatrixTransformOperation::apply):

LayoutTests:

Reviewed by Alexey Proskuryakov.

  • test the matrix transforms are applied on the correct side
  • fast/transforms/matrix-02.html: Added.
  • platform/mac/fast/transforms/matrix-02-expected.checksum: Added.
  • platform/mac/fast/transforms/matrix-02-expected.png: Added.
  • platform/mac/fast/transforms/matrix-02-expected.txt: Added.
12:29 AM Changeset in webkit [27984] by ap@webkit.org
  • 7 edits
    7 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=16077
<rdar://problem/5609785> XSLT processor <xsl:sort> algorithm is incompatible with other
browser implementations

Test: fast/xsl/sort-unicode.xml

  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString): Set a custom sort function.
  • xml/XSLTUnicodeSort.cpp: Added. (init_xsltTransformError): (xsltTransformError): (WebCore::xsltUnicodeSortFunction):
  • xml/XSLTUnicodeSort.h: Added. ICU-based implementation of xsl:sort, using an example from libxslt distribution. Only minimal coding style fixes to ease synchronization with upstream in the future.
  • icu/unicode/ucol.h: Added.
  • icu/unicode/uset.h: Added. Taken from ICU 3.2
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Added XSLTUnicodeSort.cpp.

Nov 22, 2007:

10:43 PM Changeset in webkit [27983] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14977
Hixie's DOM Core performance test shows insert >10x slower than append

Each invocation of Element.childNodes[n] was creating and registering a new ChildNodeList,
which persisted and listened to notifications until GC.

A fix is to avoid registering child node lists for notifications - they don't need them, as
they share a common cache in Node.

  • dom/Node.cpp: (WebCore::Node::registerNodeList): (WebCore::Node::unregisterNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged):
  • dom/NodeList.h: (WebCore::NodeList::needsNotifications):
10:04 PM Changeset in webkit [27982] by mitz@apple.com
  • 14 edits in trunk

WebCore:

Reviewed by Antti Koivisto.

Defer plug-in loading until after attach and recalcStyle using the
post-attach callback mechanism. Netscape plug-ins are still loaded only
after layout.

  • dom/ContainerNode.cpp: Made NodeCallbackQueue elements retain the Node because callbacks might delete nodes that are in the callback queue. (WebCore::ContainerNode::suspendPostAttachCallbacks): Added. Needed to prevent post-attach callbacks from being dispatched under recalcStyle(). (WebCore::ContainerNode::resumePostAttachCallbacks): Ditto. (WebCore::ContainerNode::dispatchPostAttachCallbacks): Factored out from attach(). (WebCore::ContainerNode::attach):
  • dom/ContainerNode.h:
  • dom/Document.cpp: (WebCore::Document::recalcStyle): Added calls to suspendPostAttachCallbacks() and resumePostAttachCallbacks().
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::HTMLEmbedElement): (WebCore::HTMLEmbedElement::attach): Changed to queue the widget update for post-attach. (WebCore::HTMLEmbedElement::updateWidget): Added. Called by the post-attach callback.
  • html/HTMLEmbedElement.h: Added an m_needWidgetUpdate member needed to prevent a double update if another plug-in's post-attach updateWidget() triggers a layout which updates the widget before this plug-in's post-attach callback is invoked. (WebCore::HTMLEmbedElement::setNeedWidgetUpdate): Added a setter for m_needWidgetUpdate.
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach): Changed to queue the widget update for post-attach. (WebCore::HTMLObjectElement::updateWidget): Added. Called by the post-attach callback.
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::setNeedWidgetUpdate): Added a setter for m_needWidgetUpdate.
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::updateWidgetCallback): Added.
  • html/HTMLPlugInElement.h: (WebCore::HTMLPlugInElement::updateWidget):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Added calls to setNeedWidgetUpdate(false) so that if this method is called from FrameView::layout() during post-attach dispatch of another plug-in, it will not be called again when this plug-in's post-attach callback is dispatched.
  • rendering/RenderPartObject.h: (WebCore::RenderPartObject::updateWidget) Renamed argument to match the method definition.

WebKit/mac:

Reviewed by Antti Koivisto.

8:45 PM Changeset in webkit [27981] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

Fix the Element.hasStyleClass and Element.removeStyleClass helpers
to not find and replace substrings, but whole class names at the
beginning or end of the string or surrounded by whitespace.

  • page/inspector/utilities.js:
8:23 PM Changeset in webkit [27980] by timothy@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo.

8:20 PM Changeset in webkit [27979] by timothy@apple.com
  • 3 edits in trunk/WebCore

Revert part of my r27935 change that made the Tip balloons
animate with CSS transitions. The balloon was only opacity 0,
so it would cause it's row to highlight when hovering over
another row.

  • page/inspector/NetworkPanel.js:
  • page/inspector/inspector.css:
8:11 PM Changeset in webkit [27978] by mitz@apple.com
  • 6 edits
    4 adds in trunk

WebCore:

Reviewed by Maciej Stachowiak.

Test: fast/transforms/matrix-01.html

Parse all six matrix entries as numbers.

  • css/CSSParser.cpp: (WebCore::TransformOperationInfo::TransformOperationInfo): (WebCore::CSSParser::parseTransform):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/RenderStyle.cpp: (WebCore::MatrixTransformOperation::blend):
  • rendering/RenderStyle.h: (WebCore::MatrixTransformOperation::MatrixTransformOperation): (WebCore::MatrixTransformOperation::apply):

LayoutTests:

Reviewed by Maciej Stachowiak.

  • fast/transforms/matrix-01.html: Added.
  • platform/mac/fast/transforms/matrix-01-expected.checksum: Added.
  • platform/mac/fast/transforms/matrix-01-expected.png: Added.
  • platform/mac/fast/transforms/matrix-01-expected.txt: Added.
6:53 PM Changeset in webkit [27977] by alp@webkit.org
  • 12 edits in trunk/WebKit/gtk

2007-11-22 Alp Toker <​alp@atoker.com>

Whitespace fixes only.

  • Api/webkitgtkframe.cpp:
  • Api/webkitgtkpage.cpp:
  • Api/webkitgtkpage.h:
  • Api/webkitgtkprivate.h:
  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • WebCoreSupport/ContextMenuClientGtk.h:
  • WebCoreSupport/DragClientGtk.h:
  • WebCoreSupport/EditorClientGtk.h:
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification): (WebKit::FrameLoaderClient::createFrame): (WebKit::FrameLoaderClient::createJavaAppletWidget): (WebKit::FrameLoaderClient::registerForIconNotification): (WebKit::FrameLoaderClient::setMainFrameDocumentReady): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::frameLoadCompleted): (WebKit::FrameLoaderClient::saveViewStateToItem): (WebKit::FrameLoaderClient::restoreViewState): (WebKit::FrameLoaderClient::shouldGoToHistoryItem): (WebKit::FrameLoaderClient::setTitle):
  • WebCoreSupport/FrameLoaderClientGtk.h:
5:52 PM Changeset in webkit [27976] by alp@webkit.org
  • 9 edits in trunk/WebKit/gtk

2007-11-22 Michael Natterer <​mitch@imendio.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15984
Implement "navigation-requested" signal for WebKit Gtk

  • Api/webkitgtknetworkrequest.h: fix parent class member.
  • Api/webkitgtknetworkrequest.cpp
  • Api/webkitgtkprivate.h: basic implementation featuring an "url" member and API.
  • Api/webkitgtkdefines.h: added network request typedefs.
  • Api/webkitgtkpage.h: fix enum name: s/WEBKIT_NAVIGATION_REQUEST_RESPONSE/WebKitNavigationRequestResponse/ and sanitized enum values.
  • Api/webkitgtkpage.cpp: made "navigation-requested" a signal.
  • Api/webkitgtk-marshal.list: added INT:OBJECT,OBJECT
  • WebCoreSupport/FrameLoaderClientGtk.cpp: emit the new signal in dispatchDecidePolicyForNavigationAction().
5:48 PM Changeset in webkit [27975] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-11-22 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp Toker.

Fix build-webkit to propagate make's exit status if it fails.

  • Scripts/webkitdirs.pm:
5:03 PM Changeset in webkit [27974] by alp@webkit.org
  • 2 edits in trunk

2007-11-22 Alp Toker <​alp@atoker.com>

GTK+ build fix. Pass a correct LIBDIR value.

  • WebKit.pri:
4:04 PM Changeset in webkit [27973] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-11-22 Laszlo Gombos <​laszlo.gombos@gmail.com>

Reviewed by Alp Toker.

Fix some compilation warnings. Do not reference undefined (platform) specific type (WebCore::CachedFont::m_fontData)

  • loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::allReferencesRemoved):
1:02 PM Changeset in webkit [27972] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-11-22 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

GTK+ drawing fix.

Add a check to avoid crashing when the GraphicsContext is not
associated with a GdkEventExpose. This was noticed when adding
printing support but might be triggered in other situations too.

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::paint):
9:36 AM Changeset in webkit [27971] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

  • fix crash when running pixel tests
  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Parse the command line options before setting up the environment so that we know if we need to set up the pixel dump machinery.
9:02 AM QtWebKitContrib edited by treat@kde.org
(diff)
5:04 AM QtWebKitTodo edited by treat@kde.org
(diff)
5:03 AM QtWebKit edited by treat@kde.org
(diff)
3:35 AM WikiStart edited by treat@kde.org
Reorganize a bit and add page for Git (diff)
3:30 AM UsingGitWithWebKit edited by treat@kde.org
Tips and tricks (diff)
3:03 AM Changeset in webkit [27970] by ap@webkit.org
  • 3 edits
    2 adds in trunk

2007-11-22 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Alexey.

Bug 15530: XMLHttpRequest should not support certain methods

Test: http/tests/xmlhttprequest/xmlhttprequest-forbidden-methods-exception.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open):
2:55 AM Changeset in webkit [27969] by mrowe@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Remove WARNING notes from change logs that committers neglected to remove when landing.

2:42 AM WebKit Team edited by mjs@apple.com
(diff)
2:37 AM WebKit Team edited by mjs@apple.com
(diff)
2:24 AM WebKit Team edited by mjs@apple.com
(diff)
2:20 AM WebKit Team edited by mrowe@apple.com
(diff)
2:18 AM WebKit Team edited by alp@atoker.com
Update (diff)
2:16 AM Changeset in webkit [27968] by Simon Hausmann
  • 1 edit in trunk/WebKit/qt/ChangeLog

Fix changelog

2:13 AM Changeset in webkit [27967] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix compilation (don't define notImplemented twice)

2:12 AM Changeset in webkit [27966] by Simon Hausmann
  • 4 edits in trunk

Use Q_SIGNALS/Q_SLOTS in the public API

2:12 AM Changeset in webkit [27965] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fixed the signature of the QWebPage constructor to follow Qt guidelines.

2:12 AM Changeset in webkit [27964] by Simon Hausmann
  • 11 edits in trunk/WebKit/qt

Use <QtModule/headerfile.h> instead of <Classname> in public HEADER files, to not require the include paths for the other modules to be present

2:11 AM Changeset in webkit [27963] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Removed inline copy of QExplicitlySharedDataPointer. This is not needed anymore since we require Qt >= 4.3.0.

2:11 AM Changeset in webkit [27962] by Simon Hausmann
  • 2 edits in trunk/WebCore

For the build inside Qt include qbase.pri and don't duplicate what qbase.pri otherwise does (install targets, etc.)

2:11 AM Changeset in webkit [27961] by Simon Hausmann
  • 2 edits in trunk/WebCore

Don't set OBJECTS_DIR when building inside Qt

2:10 AM Changeset in webkit [27960] by Simon Hausmann
  • 2 edits in trunk/WebCore

Use ../generated as path for the generated sources for builds inside Qt

2:10 AM Changeset in webkit [27959] by Simon Hausmann
  • 5 edits in trunk

Make the directory of where to put the generated sources configurable through the GENERATED_SOURCE_DIR variable

2:10 AM Changeset in webkit [27958] by Simon Hausmann
  • 5 edits in trunk

Centralize the setup for all the extra compilers in a addExtraCompiler function.

This allows adding a "generated_files" target that builds all generated files
using "make generated_files". For the build inside Qt we do not generate
actual rules for the extra compilers but instead do the variable substitution
of compiler.output manually and add the generated sources to SOURCES.

2:06 AM UsingGitWithWebKit created by treat@kde.org
Start new page for collecting info for using git with webkit
2:03 AM QtWebKitContrib edited by treat@kde.org
Add a link for new page describing tips and tricks for using git with … (diff)
1:58 AM WikiStart edited by treat@kde.org
(diff)
1:40 AM WebKit Team edited by alp@atoker.com
Fix own entry (diff)
1:21 AM QtWebKit edited by treat@kde.org
(diff)
1:19 AM QtWebKitContrib edited by treat@kde.org
More information for new contributors (diff)
1:12 AM Open Source Contributors edited by treat@kde.org
(diff)
1:11 AM WikiStart edited by treat@kde.org
Don't need this anymore as we can add people to the Team page. (diff)
1:10 AM WebKit Team edited by treat@kde.org
Add lots more contributors and add review/commit info. (diff)
1:08 AM Changeset in webkit [27957] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

Fix license headers

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

12:50 AM Changeset in webkit [27956] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix shadowing of "page" variable that is passed as argument as well as a member variable.

This also fixes compilation with gcc 4.3.

Signed-off-by: George Staikos <​staikos@kde.org>

Note: See TracTimeline for information about the timeline view.