Timeline
Nov 24, 2007:
- 11:15 PM Changeset in webkit [28012] by
-
- 3 edits in trunk/LayoutTests
Added tests for select.options.remove(boolean).
Reviewed by Maciej.
- fast/js/resources/select-options-add.js: Added two tests.
- fast/js/select-options-add-expected.txt: Updated results.
- 7:39 PM Changeset in webkit [28011] by
-
- 2 edits in trunk/WebKit/gtk
2007-11-24 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=16125
[GTK] Up key doesn't work properly when content is editable
Add a missing 'break' to avoid falling through to the next case when
handling VK_UP keystrokes. This was noticed when working on editing
support in the GTK+ port.
I've checked the other cases for similar typos and they seem fine.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress):
- 7:13 PM Changeset in webkit [28010] by
-
- 1 edit1 delete in trunk/WebKitTools
2007-11-24 David Kilzer <ddkilzer@webkit.org>
Removed empty directory.
- Scripts/resources: Removed.
- 6:53 PM Changeset in webkit [28009] by
-
- 2 edits in trunk/WebKit/gtk
2007-11-24 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=15745
[GTK] Arrow keys do not Scroll
- Api/webkitgtkpage.cpp:
Support Up/Down/Right/Left keys to scroll. Slight hack, see FIXME for
details.
- 5:23 PM Changeset in webkit [28008] by
-
- 2 edits in trunk/WebKit/gtk
2007-11-24 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=15891
[GTK] Javascript console and dialogs are not implemented
Fix call to gtk_message_dialog_new() which expects a format string.
- Api/webkitgtkpage.cpp:
- 4:23 PM HackingGtk edited by
- Mention the build bots (diff)
- 3:56 PM Changeset in webkit [28007] by
-
- 2 edits in trunk/WebKit/mac
Tiger build fix.
Use WebCFAutorelease in place of NSMakeCollectable then autorelease as this also works on Tiger.
- 3:48 PM Changeset in webkit [28006] by
-
- 7 edits in trunk
Fix <rdar://problem/5432686> 333MB RPRVT seems to leak @ www.43folders.com (1hr plug-in stream).
http://bugs.webkit.org/show_bug.cgi?id=13705
Reviewed by Tim Hatcher.
Have NP_ASFILE and NP_ASFILEONLY streams write the data to disk as they receive it rather than
dumping the data to disk in a single go when the stream has completed loading. On a test case
involving a 150MB Flash movie being streamed from a local web server this reduces memory consumption
on page load from around 400MB to 22MB.
The only plugin I have found that uses NP_ASFILE or NP_ASFILEONLY on the Mac is our NetscapeMoviePlugin
example code so the NP_ASFILE portion of this change has not had any testing with a real-world plugin.
- 3:43 PM Changeset in webkit [28005] by
-
- 8 edits2 deletes in trunk
Get rid of WebCoreSystemInterface on Windows
WebCore:
Get rid of WebCoreSystemInterface on Windows
The one function defined in that file is now in WebKitSystemInterface.
Reviewed by Tim.
- WebCore.vcproj/WebCore.vcproj: Removed WebCoreSystemInterface.{cpp,h}.
- platform/graphics/cg/ImageCG.cpp: Made #include of WebCoreSystemInterface.h Mac-only.
- platform/win/GraphicsContextWin.cpp: Ditto.
- platform/win/WebCoreSystemInterface.cpp: Removed.
- platform/win/WebCoreSystemInterface.h: Removed.
WebKitLibraries:
Add wkSetPatternPhaseInUserSpace to WebKitSystemInterface on Windows
Reviewed by Tim.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h: Added declaration.
- win/lib/WebKitSystemInterface.lib: Updated.
- win/lib/WebKitSystemInterface_debug.lib: Updated.
- 3:33 PM Changeset in webkit [28004] by
-
- 6 edits in trunk/WebCore
Replace uses of %@ with %s in the inspector
Rubberstamped by Tim.
- English.lproj/InspectorLocalizedStrings.js: Changed %@ to %s.
- page/inspector/DatabasePanel.js: Ditto.
- page/inspector/StylesSidebarPane.js: Ditto.
- page/inspector/inspector.js: Ditto.
- page/inspector/utilities.js: (String.vsprintf): Removed @ as a format specifier.
- 3:32 PM Changeset in webkit [28003] by
-
- 3 edits in trunk/WebCore
Windows build fix
Turn off the change made in r27984 on Windows for now.
- xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString):
- xml/XSLTUnicodeSort.cpp:
- 2:35 PM Changeset in webkit [28002] by
-
- 12 edits in trunk/WebCore
Reviewed by Adam Roben.
Bug 16121: Web Inspector needs helper functions that pass a 'this' object to
addEventListener and setTimeout
http://bugs.webkit.org/show_bug.cgi?id=16121
Add Function.prototype.bind. This helper will return a wrapper function
that will call the original function with the supplied arguments
and using the supplied 'this' object.
- page/inspector/Database.js: Remove a use of setTimeout by inheriting some common functions from Resource.
- page/inspector/DatabasePanel.js: Use the new bind function.
- page/inspector/ConsolePanel.js: Ditto.
- page/inspector/DocumentPanel.js: Ditto.
- page/inspector/NetworkPanel.js: Ditto.
- page/inspector/PropertiesSection.js: Ditto.
- page/inspector/Resource.js: Ditto.
- page/inspector/SidebarPane.js: Ditto.
- page/inspector/inspector.html: Moved Database.js after Resource.js, now that Database.js uses it.
- page/inspector/inspector.js: Use the new bind function. Also removed a setTimeout used for the localized strings code. There is now a load event listener added to the localized strings script element that will call WebInspector.loaded.
- page/inspector/utilities.js: Add Function.prototype.bind.
- 2:20 PM Changeset in webkit [28001] by
-
- 1 edit in trunk/WebCore/English.lproj/InspectorLocalizedStrings.js
Add missing strings.
- 1:52 PM Changeset in webkit [28000] by
-
- 2 edits in trunk/WebKit/gtk
2007-11-24 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=15793
[GTK] Webkit doesn't show title attribute tooltip when hovering over an image
Implement tooltip support using the new Tooltip API.
Support for older versions of GTK+ is still lacking.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::setToolTip):
- 11:18 AM Changeset in webkit [27999] by
-
- 4 edits in trunk/WebCore
Reviewed by Adam Roben.
Bug 16112: Some Web Inspector UI elements use offsetWidth and offsetHeight before the stylesheet loads
http://bugs.webkit.org/show_bug.cgi?id=16112
In the places where we use offsetWidth and offsetHeight before
the stylesheet loads there is now a check. If the body's
offsetWidth is not greater than zero, then set a timeout
to do the updates requiring the stylesheet later.
The three places this happened:
- DOM tree selection highlight would show up at the wrong height when using Inspect Element to open the inspector.
- DOM tree breadcrumbs would not collapse when using Inspect Element to open the inspector.
- Network Timeline divider lines would not show when opening directly into the timeline.
- page/inspector/DocumentPanel.js: Check if the stylesheet loaded.
- page/inspector/NetworkPanel.js: Ditto.
- page/inspector/inspector.html: Include the stylesheet before any scripts, this will help get it loaded sooner.
- 10:18 AM Changeset in webkit [27998] by
-
- 2 edits in trunk/WebCore
Add wx implementation for pathGetFilename
Reviewed by David D. Kilzer.
Nov 23, 2007:
- 10:09 PM Changeset in webkit [27997] by
-
- 2 edits in trunk/WebKitTools
Fix bisect-builds to work with recent WebKit nightly builds.
Reviewed by Dan.
- Scripts/bisect-builds: Check for the WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use it for the DYLD_FRAMEWORK_PATH environment variable, else fallback to WebKit.app/Contents/Resources.
- 8:48 PM Changeset in webkit [27996] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Bug 16110: Clicking inside the resource headers in the network timeline collapses them
http://bugs.webkit.org/show_bug.cgi?id=16110
Toggle the resource headers only if the click happens on the
resource row, not within the headers area.
- WebCore.xcodeproj/project.pbxproj:
- page/inspector/NetworkPanel.js:
- 8:11 PM HackingGtk edited by
- Add WebCore and WebKit specific hacking guides (diff)
- 7:14 PM Changeset in webkit [27995] by
-
- 2 edits in trunk/WebKit/mac
Fixed <rdar://problem/3759190> allow input methods the option of processing mouse events themselves
Reviewed by Mark Rowe.
- 4:52 PM Changeset in webkit [27994] by
-
- 7 edits in trunk
Windows build fixes for USE(CURL) and MSVC compilation for ports.
Reviewed by Adam Roben.
- 4:11 PM BuildingGtk edited by
- Fix the link, split out the hacking guide (diff)
- 4:11 PM HackingGtk created by
- Add GTK+ hacking information verbatim
- 4:05 PM BuildingGtk edited by
- Add link to HackingGtk (diff)
- 3:22 PM Changeset in webkit [27993] by
-
- 2 edits in trunk
Forgot to add JSCore and WebCore ChangeLog during previous commit.
- 3:17 PM Changeset in webkit [27992] by
-
- 11 edits in trunk
Fix the wx buildbot after removal of move-js-headers.sh..
- 2:03 PM Changeset in webkit [27991] by
-
- 4 edits in trunk/WebKit/gtk
2007-11-22 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Implement and document several WebKitFrame functions, some of which
are necessary to support DRT.
Correct NULL handling and improve run-time checks.
- Api/webkitgtkframe.cpp:
- Api/webkitgtkframe.h:
- Api/webkitgtkprivate.cpp:
- 12:07 PM Changeset in webkit [27990] by
-
- 17 edits in trunk/LayoutTests
Set video src from script, not from the element attribute. This
guarantees load events do not fire before event listeners are registered.
This change does not affect test results.
- media/progress-event.html:
- media/video-autoplay.html:
- media/video-buffered.html:
- media/video-currentTime-set.html:
- media/video-currentTime-set2.html:
- media/video-currentTime.html:
- media/video-dom-autoplay.html:
- media/video-error-abort.html:
- media/video-error-does-not-exist.html:
- media/video-load-networkState.html:
- media/video-load-readyState.html:
- media/video-no-autoplay.html:
- media/video-seekable.html:
- media/video-seeking.html:
- media/video-size.html:
- media/video-src.html:
- media/video-start.html:
- 7:56 AM Changeset in webkit [27989] by
-
- 2 edits in trunk/WebCore
Another build fix specific to trunk (instead of the stable branch) to fix make clean (which the buildbots call).
Signed-off-by: George Staikos <staikos@kde.org>
- 7:44 AM Changeset in webkit [27988] by
-
- 3 edits in trunk/JavaScriptCore
Fix make (dist)clean on Windows.
OBJECTS_DIR_WTR does not exist anymore, use GENERATED_SOURCES_DIR.
Signed-off-by: George Staikos <staikos@kde.org>
- 6:37 AM QtWebKitGitInstructions edited by
- (diff)
- 5:56 AM QtWebKitGitInstructions edited by
- (diff)
- 5:30 AM UsingGitWithWebKit edited by
- (diff)
- 5:30 AM QtWebKitGitInstructions created by
- 5:29 AM QtWebKitContrib edited by
- (diff)
- 5:29 AM QtWebKitContrib edited by
- (diff)
- 5:21 AM UsingGitWithWebKit edited by
- (diff)
- 5:19 AM UsingGitWithWebKit edited by
- (diff)
- 4:27 AM Changeset in webkit [27987] by
-
- 2 edits in trunk/WebCore
Not reviewed, trivial leak fix.
Fix xsltUnicodeSortFunction() memory leaks.
- xml/XSLTUnicodeSort.cpp: (WebCore::xsltUnicodeSortFunction):
- 2:52 AM ProjectVision created by
- 2:19 AM Changeset in webkit [27986] by
-
- 6 edits8 adds in trunk
Reviewed by Maciej.
<rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
not closed (affects digg.com)
Tests: fast/loader/meta-refresh-vs-open.html
fast/loader/redirect-with-open-subframe-2.html
fast/loader/redirect-with-open-subframe.html
http/tests/loading/onload-vs-immediate-refresh.pl
- loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleRedirection): Only check whether the load is complete for HTTP redirects - JavaScript-initiated ones are effective immediately.
WebKitTools:
- DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank one after finishing with a test to avoid having its delayed onload handler fired when starting the next test. This is ugly and still unreliable (see LayoutTests ChangeLog), but it helps somewhat.
- 1:39 AM WebKit Team edited by
- (diff)
- 1:24 AM QtWebKit edited by
- (diff)
- 1:21 AM WebKit Team edited by
- Remove irc handle (diff)
- 1:20 AM Changeset in webkit [27985] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Alexey Proskuryakov.
- apply matrix transforms on the correct side of the transformation matrix (not on the side where the vector is multiplied).
Test: fast/transforms/matrix-02.html
- rendering/RenderStyle.h: (WebCore::MatrixTransformOperation::apply):
LayoutTests:
Reviewed by Alexey Proskuryakov.
- test the matrix transforms are applied on the correct side
- fast/transforms/matrix-02.html: Added.
- platform/mac/fast/transforms/matrix-02-expected.checksum: Added.
- platform/mac/fast/transforms/matrix-02-expected.png: Added.
- platform/mac/fast/transforms/matrix-02-expected.txt: Added.
- 12:29 AM Changeset in webkit [27984] by
-
- 7 edits7 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=16077
<rdar://problem/5609785> XSLT processor <xsl:sort> algorithm is incompatible with other
browser implementations
Test: fast/xsl/sort-unicode.xml
- xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString): Set a custom sort function.
- xml/XSLTUnicodeSort.cpp: Added. (init_xsltTransformError): (xsltTransformError): (WebCore::xsltUnicodeSortFunction):
- xml/XSLTUnicodeSort.h: Added. ICU-based implementation of xsl:sort, using an example from libxslt distribution. Only minimal coding style fixes to ease synchronization with upstream in the future.
- icu/unicode/ucol.h: Added.
- icu/unicode/uset.h: Added. Taken from ICU 3.2
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl: Added XSLTUnicodeSort.cpp.
