⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 1, 2007:

11:56 PM Changeset in webkit [28314] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Tim

Added a default database quota of 5mb to the default WebPreferences

  • WebView/WebPreferences.m: (+[WebPreferences initialize]):
10:43 PM Changeset in webkit [28313] by alp@webkit.org
  • 4 edits in trunk/WebKit/gtk

2007-12-01 Alp Toker <​alp@atoker.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=15687
[Gtk] Allow API clients to interact with JavaScript in web pages

Include the necessary JavaScriptCore headers directly in the public
API headers.

This is the last of a series of changes needed to allow GTK+
applications to access the JS API.

Until ​http://bugs.webkit.org/show_bug.cgi?id=16029 is resolved,
developers will still have to include the individual JS API headers
individually if they want to use it in their applications.

Patch also removes some old legacy use of GDK that was in
WebKitWebFrame. No ABI change.

  • WebView/webkitdefines.h:
  • WebView/webkitwebframe.h:
  • WebView/webkitwebview.h:
10:14 PM Changeset in webkit [28312] by Antti Koivisto
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Adam.


  • Fix a crash when removing a loading media element from the tree.
  • Follow the spec by invoking pause() when element is removed from the tree instead of unloading.

Tests: http/tests/media/remove-while-loading.html

media/remove-from-document.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::removedFromDocument):

LayoutTests:

Reviewed by Adam.


Test that removing a media element when it is loading does not crash.
Test that media is paused when it is removed from the tree.

  • http/tests/media/remove-while-loading-expected.txt: Added.
  • http/tests/media/remove-while-loading.html: Added.
  • media/remove-from-document-expected.txt: Added.
  • media/remove-from-document.html: Added.
9:24 PM Changeset in webkit [28311] by alp@webkit.org
  • 3 edits in trunk/JavaScriptCore

2007-12-01 Alp Toker <​alp@atoker.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=16228
kJSClassDefinitionEmpty is not exported with JS_EXPORT

Add JS_EXPORT to kJSClassDefinitionEmpty.

Make the gcc compiler check take precedence over the WIN32
_WIN32

check to ensure that symbols are exported on Windows when using gcc.

Add a TODO referencing the bug about JS_EXPORT in the Win build
(​http://bugs.webkit.org/show_bug.cgi?id=16227)

Don't define JS_EXPORT as 'extern' when the compiler is unknown since
it would result in the incorrect expansion:

extern extern const JSClassDefinition kJSClassDefinitionEmpty;

(This was something we inherited from CFBase.h that doesn't make sense
for JSBase.h)

  • API/JSBase.h:
  • API/JSObjectRef.h:
3:59 PM Changeset in webkit [28310] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Beth Dakin.

Restored the test string in this test.

  • manual-tests/window-open-features-parsing.html:
3:56 PM Changeset in webkit [28309] by ggaren@apple.com
  • 25 edits in trunk

JavaScriptCore:

Reviewed by Beth Dakin.


Reversed the ownership relationship between Interpreter and JSGlobalObject.
Now, the JSGlobalObject owns the Interpreter, and top-level objects
that need the two to persist just protect the JSGlobalObject from GC.


Global object bootstrapping looks a little odd right now, but it will
make much more sense soon, after further rounds of refactoring.

  • bindings/runtime_root.h: Made this class inherit from RefCounted, to avoid code duplication.
  • kjs/collector.cpp: (KJS::Collector::collect): No need to give special GC treatment to Interpreters, since we mark their global objects, which mark them.
  • kjs/interpreter.cpp: (KJS::Interpreter::mark): No need to mark our global object, since it marks us.
  • kjs/interpreter.h: Don't inherit from RefCounted -- JSGlobalObject owns us directly.
  • kjs/testkjs.cpp: Modified to follow the new rules. (createGlobalObject): (runWithScripts):

JavaScriptGlue:

Reviewed by Beth Dakin.


Modified to follow new JSGlobalObject/Interpreter ownership rules
in JavaScriptCore.

  • JSRun.cpp: (JSRun::JSRun): (JSRun::GetInterpreter): (JSRun::Evaluate): (JSRun::CheckSyntax):
  • JSRun.h:
  • JSValueWrapper.cpp: (unprotectGlobalObject): (initializeGlobalObjectKey): (getThreadGlobalExecState):

WebCore:

Reviewed by Beth Dakin.


Modified WebCore to follow the new JSGlobalObject/Interpreter ownership
rules in JavaScriptCore.

  • bindings/js/kjs_binding.cpp:
  • bindings/js/kjs_binding.h: Removed stale, unused interpreterForGlobalObject().
  • bindings/js/kjs_proxy.cpp: Changed to store a global object, rather than an interpreter. (WebCore::KJSProxy::finishedWithEvent): Need to NULL check m_globalObject here because we no longer unnecessarily instantiate it.
  • bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
  • bindings/js/kjs_window.h: Removed redundant and less efficient interpreter() function -- global objects have direct access to their interpreters now.

Changed these functions to pass around JSGlobalObjects instead of
Interpreters:

  • page/Frame.cpp: (WebCore::Frame::bindingRootObject): (WebCore::Frame::createRootObject):
  • page/Frame.h:
  • page/mac/WebCoreFrameBridge.mm: (createRootObject):
3:35 PM Changeset in webkit [28308] by treat@webkit.org
  • 2 edits in trunk/WebKitTools
  • Check to see if the directory exists and exit if not.
2:32 PM BuildingGtk edited by alp@atoker.com
Add links to distribution packages (diff)
2:29 PM Changeset in webkit [28307] by weinig@apple.com
  • 4 edits in trunk/WebKit/win

Rename IWebViewPrivate::selectionImageRect to IWebViewPrivate::selectionRect.

Rubber stamped by Adam Roben.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::selectionRect):
  • WebView.h:
2:15 PM Changeset in webkit [28306] by mitz@apple.com
  • 2 edits in trunk/PlanetWebKit

Reviewed by Mark Rowe.

  • config.ini: Correct blog name.
1:08 PM Changeset in webkit [28305] by timothy@apple.com
  • 1 edit in trunk/WebKit/StringsNotToBeLocalized.txt

Update StringsNotToBeLocalized.txt.

11:43 AM UsingGitWithWebKit edited by Adam Roben
(diff)
11:04 AM Changeset in webkit [28304] by Darin Adler
  • 3 edits in trunk/WebCore

Reviewed by Mitz.

  • fix problem tracked by these bugs: ​http://bugs.webkit.org/show_bug.cgi?id=16097 <rdar://problem/5619305> Safari crashes during load of LexisNexis search results <rdar://problem/5510779> CrashTracer: [USER] 25 crashes in Safari at WebCore::DocumentLoader::isLoadingMultipartContent const
  • loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): Create an ImageDocumentElement instead of an HTMLImageElement. (WebCore::ImageDocument::scale): Added a null check for m_imageElement. (WebCore::ImageDocument::resizeImageToFit): Ditto. (WebCore::ImageDocument::restoreImageSize): Ditto. (WebCore::ImageDocument::imageFitsInWindow): Ditto. (WebCore::ImageDocument::windowSizeChanged): Ditto. (WebCore::ImageDocumentElement::~ImageDocumentElement): Call disconnectImageElement so m_imageElement will be set to 0 if we're still connected to the document. (WebCore::ImageDocumentElement::willMoveToNewOwnerDocument): Ditto.
  • loader/ImageDocument.h: Changed image element type to be ImageDocumentElement instead of HTMLImageElement. Also added a disconnectImageElement function that sets m_imageElement to 0.
10:44 AM Changeset in webkit [28303] by Darin Adler
  • 1 edit
    1 delete in trunk/WebCore
  • remove the empty directories
  • ksvg2: Removed.
  • ksvg2/css: Removed.
  • ksvg2/events: Removed.
  • ksvg2/misc: Removed.
  • ksvg2/scripts: Removed.
10:09 AM Changeset in webkit [28302] by Darin Adler
  • 1 edit in trunk/SunSpider/hosted

Ignore another file that's now part of hosted SunSpider.

8:51 AM Changeset in webkit [28301] by mrowe@apple.com
  • 5 edits in trunk

2007-12-01 Julien Chaffraix <​julien.chaffraix@gmail.com>

Bug 16189: XMLHttpRequest::setRequestHeader() should not set certain headers

Reviewed by Darin Adler.

  • xml/XMLHttpRequest.cpp: (WebCore::canSetRequestHeader):

Test: http/tests/xmlhttprequest/set-dangerous-headers.html

2007-12-01 Julien Chaffraix <​julien.chaffraix@gmail.com>

Bug 16189: XMLHttpRequest::setRequestHeader() should not set certain headers

Reviewed by Darin Adler.

  • http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
  • http/tests/xmlhttprequest/set-dangerous-headers.html: Added tests for new headers
8:41 AM Changeset in webkit [28300] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2007-12-01 Rahul Abrol <​ra5ul@comcast.net>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=16128
Ignore resizable=no for window.open().

  • bindings/js/kjs_window.cpp: (KJS::setWindowFeature): (KJS::parseWindowFeatures):
  • manual-tests/window-open-features-parsing.html:
8:33 AM Changeset in webkit [28299] by mitz@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/5619240> REGRESSION (Leopard-r28069): Reproducible crash with a Mootools-based calendar picker (jump to null in FrameView::layout)

Test: fast/dynamic/subtree-common-root.html

  • page/FrameView.cpp: (WebCore::FrameView::layoutRoot): Added a parameter to let this method return the layout root for a pending layout as well. (WebCore::FrameView::scheduleRelayoutOfSubtree): Pass the new root to markContainingBlocksForLayout(). Otherwise, markContainingBlocksForLayout() could mark past the new root, if it had previously been marked as having a normal child needing layout and then was reached via a positioned child.
  • page/FrameView.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::~RenderObject): Fixed the ASSERT so that it would really catch deletion of the layout root. (WebCore::RenderObject::markContainingBlocksForLayout): Added the newRoot parameter, which tells this method where to stop marking.
  • rendering/RenderObject.h:

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/5619240> REGRESSION (Leopard-r28069): Reproducible crash with a Mootools-based calendar picker (jump to null in FrameView::layout)
  • fast/dynamic/subtree-common-root-expected.txt: Added.
  • fast/dynamic/subtree-common-root.html: Added.
8:28 AM Changeset in webkit [28298] by mitz@apple.com
  • 29 edits
    1 delete in trunk/WebCore

Reviewed by Darin Adler.

  • fold FontStyle into TextRun
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Font.cpp: (WebCore::WidthIterator::WidthIterator): (WebCore::WidthIterator::advance): (WebCore::Font::width): (WebCore::Font::drawSimpleText): (WebCore::Font::drawGlyphBuffer): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::selectionRectForText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPosition): (WebCore::Font::offsetForPositionForSimpleText):
  • platform/graphics/Font.h: (WebCore::TextRun::TextRun): (WebCore::TextRun::setText): (WebCore::TextRun::allowTabs): (WebCore::TextRun::xPos): (WebCore::TextRun::padding): (WebCore::TextRun::rtl): (WebCore::TextRun::ltr): (WebCore::TextRun::directionalOverride): (WebCore::TextRun::applyRunRounding): (WebCore::TextRun::applyWordRounding): (WebCore::TextRun::spacingDisabled): (WebCore::TextRun::disableSpacing): (WebCore::TextRun::disableRoundingHacks): (WebCore::TextRun::setRTL): (WebCore::TextRun::setDirectionalOverride):
  • platform/graphics/FontStyle.h: Removed.
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawBidiText): (WebCore::GraphicsContext::drawHighlightForText):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/StringTruncator.cpp: (WebCore::stringWidth):
  • platform/graphics/gtk/FontGtk.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/mac/FontMac.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): (WebCore::addDirectionalOverride): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/graphics/qt/FontQt.cpp: (WebCore::generateComponents): (WebCore::Font::drawText): (WebCore::Font::width): (WebCore::Font::offsetForPosition): (WebCore::cursorToX): (WebCore::Font::selectionRectForText):
  • platform/graphics/win/FontWin.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/graphics/wx/FontWx.cpp: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint):
  • platform/win/UniscribeController.cpp: (WebCore::UniscribeController::UniscribeController): (WebCore::UniscribeController::offsetForPosition): (WebCore::UniscribeController::advance): (WebCore::UniscribeController::itemizeShapeAndPlace): (WebCore::UniscribeController::resetControlAndState): (WebCore::UniscribeController::shapeAndPlaceItem):
  • platform/win/UniscribeController.h:
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::doDrawTextAtPoint):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintCompositionBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::calcPrefWidths):
  • rendering/RenderImage.cpp:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::paintItemForeground):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::calcPrefWidths): (WebCore::RenderText::width):
  • rendering/RenderText.h: (WebCore::RenderText::allowTabs):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::calculateGlyphWidth): (WebCore::SVGInlineTextBox::paintCharacters): (WebCore::SVGInlineTextBox::paintSelection):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback): (WebCore::cummulatedWidthOfInlineBoxCharacterRange): (WebCore::svgTextRunForInlineTextBox):
  • rendering/SVGRootInlineBox.h:
4:58 AM Changeset in webkit [28297] by mrowe@apple.com
  • 3 edits in branches/Safari-3-branch/WebCore

Merge r26782 to Safari-3-branch.

4:34 AM Changeset in webkit [28296] by mrowe@apple.com
  • 2 edits in tags/Safari-5523.10.5

Versioning.

4:33 AM Changeset in webkit [28295] by mrowe@apple.com
  • 5 edits in tags/Safari-5523.10.5/WebCore

Merge r28225.

4:31 AM Changeset in webkit [28294] by mrowe@apple.com
  • 7 edits
    9 adds in tags/Safari-5523.10.5

Merge r28056.

4:29 AM Changeset in webkit [28293] by mrowe@apple.com
  • 4 edits in tags/Safari-5523.10.5/WebCore

Merge r27433.

4:27 AM Changeset in webkit [28292] by mrowe@apple.com
  • 21 edits
    2 adds in tags/Safari-5523.10.5

Merge r26780.

4:22 AM Changeset in webkit [28291] by mrowe@apple.com
  • 2 edits in tags/Safari-4523.12.1

Versioning.

4:21 AM Changeset in webkit [28290] by mrowe@apple.com
  • 5 edits in tags/Safari-4523.12.1/WebCore

Merge r28225.

4:19 AM Changeset in webkit [28289] by mrowe@apple.com
  • 7 edits
    9 adds in tags/Safari-4523.12.1

Merge r28056.

4:17 AM Changeset in webkit [28288] by mrowe@apple.com
  • 4 edits in tags/Safari-4523.12.1/WebCore

Merge r27433.

4:15 AM Changeset in webkit [28287] by mrowe@apple.com
  • 21 edits
    2 adds in tags/Safari-4523.12.1

Merge r26780.

4:07 AM Changeset in webkit [28286] by mrowe@apple.com
  • 5 edits in branches/Safari-3-branch/WebCore

Merge r28225 to Safari-3-branch.

4:04 AM Changeset in webkit [28285] by mrowe@apple.com
  • 7 edits
    9 adds in branches/Safari-3-branch

Merge r28056 to Safari-3-branch.

4:01 AM Changeset in webkit [28284] by mrowe@apple.com
  • 4 edits in branches/Safari-3-branch/WebCore

Merge r27433 to Safari-3-branch.

3:59 AM Changeset in webkit [28283] by mrowe@apple.com
  • 21 edits
    2 adds in branches/Safari-3-branch

Merge r26780 to Safari-3-branch.

3:08 AM Changeset in webkit [28282] by mrowe@apple.com
  • 1 copy in tags/Safari-5523.10.5

New tag.

3:07 AM Changeset in webkit [28281] by mrowe@apple.com
  • 1 delete in tags/Safari-5523.10.4

Remove bogus tag.

3:05 AM Changeset in webkit [28280] by mrowe@apple.com
  • 1 copy in tags/Safari-5523.10.4

New tag.

3:04 AM Changeset in webkit [28279] by mrowe@apple.com
  • 1 copy in tags/Safari-4523.12.1

New tag.

Nov 30, 2007:

10:56 PM Changeset in webkit [28278] by Adam Roben
  • 2 edits in trunk/PlanetWebKit

Add another feed

  • config.ini:
10:48 PM Changeset in webkit [28277] by Adam Roben
  • 1 edit
    1 add in trunk/PlanetWebKit

Add a simple script to update the site

  • update.pl: Added.
10:41 PM HackingGtk edited by alp@atoker.com
More fixes to track the latest WebKit/GTK+ API change (diff)
10:34 PM Changeset in webkit [28276] by Adam Roben
  • 2 edits in trunk/PlanetWebKit

Include all WebKit posts from Trolltech Labs

  • config.ini:
9:46 PM Changeset in webkit [28275] by Simon Hausmann
  • 4 edits in trunk
  • Don't hide symbols when in Debug mode
  • On Linux (glibc) provide a backtrace in the test output for debugging purposes

Signed-off-by: Simon

9:29 PM Changeset in webkit [28274] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-30 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Fix for GTK+ Debug build breakage introduced in r28273.

  • WebView/webkitprivate.cpp: (WebKit::kit):
9:04 PM HackingGtk edited by alp@atoker.com
Update to track API changes (diff)
8:24 PM Changeset in webkit [28273] by alp@webkit.org
  • 13 edits
    16 adds
    1 delete in trunk

2007-11-30 Alp Toker <​alp@atoker.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=15691
[GTK] Public API does not follow GTK+ conventions

Refactor the WebKit/GTK+ public API. Changes:

WebKitPage -> WebKitWebView
WebKitFrame -> WebKitWebFrame

Public API source and header names have been updated to mirror the API
changes.

The API is now kept in WebKit/gtk/WebView to match other ports in the
same class such as Mac and Win.

API/ABI-breaking change.

8:10 PM BuildingOnWindows edited by bfulgham@macports.org
(diff)
6:25 PM Changeset in webkit [28272] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric.

  • ChangeLog:
  • pcre/pcre_compile.cpp: (compile_branch):
5:57 PM Changeset in webkit [28271] by pewtermoose@webkit.org
  • 3 edits in trunk/WebKitSite

Reviewed by Adam.

Link to the commit and review policy.

  • coding/contributing.html:
  • nav.inc:
5:47 PM Changeset in webkit [28270] by Darin Adler
  • 2 edits in trunk/WebKitSite
  • coding/commit-review-policy.html: A couple more typos and very minor grammatical stuff. No substantive change.
5:42 PM Changeset in webkit [28269] by Darin Adler
  • 2 edits in trunk/WebKitSite
  • coding/commit-review-policy.html: Fixed a typo, added a footer.
5:37 PM Changeset in webkit [28268] by Adam Roben
  • 74 adds in trunk/PlanetWebKit

Initial checkin of Planet WebKit

Rubberstamped by Sam.

  • README: Added.
  • config.ini: Added.
  • planet/AUTHORS: Added.
  • planet/INSTALL: Added.
  • planet/LICENCE: Added.
  • planet/NEWS: Added.
  • planet/PKG-INFO: Added.
  • planet/README: Added.
  • planet/THANKS: Added.
  • planet/TODO: Added.
  • planet/examples/atom.xml.tmpl: Added.
  • planet/examples/basic/config.ini: Added.
  • planet/examples/basic/index.html.tmpl: Added.
  • planet/examples/fancy/config.ini: Added.
  • planet/examples/fancy/index.html.tmpl: Added.
  • planet/examples/foafroll.xml.tmpl: Added.
  • planet/examples/opml.xml.tmpl: Added.
  • planet/examples/output/images/edd.png: Added.
  • planet/examples/output/images/evolution.png: Added.
  • planet/examples/output/images/feed-icon-10x10.png: Added.
  • planet/examples/output/images/jdub.png: Added.
  • planet/examples/output/images/keybuk.png: Added.
  • planet/examples/output/images/logo.png: Added.
  • planet/examples/output/images/opml.png: Added.
  • planet/examples/output/images/planet.png: Added.
  • planet/examples/output/images/thom.png: Added.
  • planet/examples/output/planet.css: Added.
  • planet/examples/rss10.xml.tmpl: Added.
  • planet/examples/rss20.xml.tmpl: Added.
  • planet/planet-cache.py: Added.
  • planet/planet.py: Added.
  • planet/planet/init.py: Added.
  • planet/planet/atomstyler.py: Added.
  • planet/planet/cache.py: Added.
  • planet/planet/compat_logging/init.py: Added.
  • planet/planet/compat_logging/config.py: Added.
  • planet/planet/compat_logging/handlers.py: Added.
  • planet/planet/feedparser.py: Added.
  • planet/planet/htmltmpl.py: Added.
  • planet/planet/sanitize.py: Added.
  • planet/planet/tests/init.py: Added.
  • planet/planet/tests/data/simple.tmpl: Added.
  • planet/planet/tests/data/simple2.tmpl: Added.
  • planet/planet/tests/test_channel.py: Added.
  • planet/planet/tests/test_main.py: Added.
  • planet/planet/tests/test_sanitize.py: Added.
  • planet/planet/tests/test_sub.py: Added.
  • planet/planet/timeoutsocket.py: Added.
  • planet/runtests.py: Added.
  • planet/setup.py: Added.
  • templates/atom.xml.tmpl: Added.
  • templates/foafroll.xml.tmpl: Added.
  • templates/index.html.tmpl: Added.
  • templates/opml.xml.tmpl: Added.
  • templates/rss10.xml.tmpl: Added.
  • templates/rss20.xml.tmpl: Added.
  • wwwroot/images/feed-icon-10x10.png: Added.
  • wwwroot/images/planet.png: Added.
  • wwwroot/planet.css: Added.
4:48 PM Changeset in webkit [28267] by pewtermoose@webkit.org
  • 2 edits in trunk/WebKitSite

Reviewed by Maciej.

Clean up a couple of typos from Maciej's last patch.

  • coding/commit-review-policy.html:
4:47 PM Changeset in webkit [28266] by adachan@apple.com
  • 4 edits in trunk/WebKit/win

<rdar://problem/5621373> Added a way for the client to clear undo/redo
operations from a WebView.

Reviewed by Steve.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::clearUndoRedoOperations):
  • WebView.h:
4:27 PM Changeset in webkit [28265] by mjs@apple.com
  • 1 edit
    1 add in trunk/WebKitSite

Reviewed by Bertrand.


New commit and review policy.

  • coding/commit-review-policy.html: Added.
4:18 PM Changeset in webkit [28264] by andersca@apple.com
  • 2 edits in trunk/WebCore

Add platform/text project group.


  • WebCore.vcproj/WebCore.vcproj:
4:05 PM Changeset in webkit [28263] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2007-11-30 Eric Seidel <​eric@webkit.org>

No review, build fix only.

Fix uninitialized var warnings in release build.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • pcre/pcre_compile.cpp: (compile_regex):
3:57 PM Changeset in webkit [28262] by andersca@apple.com
  • 2 edits in trunk/WebCore

Remove extra </Filter> tag which prevented the vcproj from being parsed correctly.


  • WebCore.vcproj/WebCore.vcproj:
3:47 PM Changeset in webkit [28261] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Geoff Garen


Added another symbol for WebDatabaseManager clients

  • WebKit.exp: added .objc_class_name_WebSecurityOrigin
3:43 PM Changeset in webkit [28260] by eric@webkit.org
  • 4 edits
    3 adds in trunk

2007-11-30 Eric Seidel <​eric@webkit.org>

Reviewed by darin.

PCRE crashes under GuardMalloc
​http://bugs.webkit.org/show_bug.cgi?id=16127
check against patternEnd to make sure we don't walk off the end of the string

  • pcre/pcre_compile.cpp: (compile_branch): (calculateCompiledPatternLengthAndFlags):
3:25 PM Changeset in webkit [28259] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Try to fix qt/gtk build.

3:19 PM Changeset in webkit [28258] by Nikolas Zimmermann
  • 5 edits
    27 moves in trunk/WebCore

Rubber stamped by Eric.

Final integration of ksvg2 in WebKit. Moving ksvg2/ to svg/ and killing all it's subdirectories,
by moving the files into approriate locations (css, rendering, ...) - as dicsussed on the
mailing list and on IRC with David/Darin & Eric.

Updated all build files - though I can't guarantee it builds on non-mac. Need buildbot to verify.

2:22 PM Changeset in webkit [28257] by kevino@webkit.org
  • 4 edits in trunk

wx build fix. Add WebCore/platform/graphics/wx to includes.

2:08 PM Changeset in webkit [28256] by beidson@apple.com
  • 7 edits in trunk/WebCore

Reviewed by Geoff

Further hookup of Database API
With this change, any database operation that writes to the database (UPDATE, INSERT, CREATE, etc) will
result in a didModifyDatabase notification when the transaction is successfully committed

  • storage/DatabaseAuthorizer.cpp: Global rename of "m_lastActionIncreasedSize" to "m_lastActionChangedDatabase" (WebCore::DatabaseAuthorizer::reset): (WebCore::DatabaseAuthorizer::createTable): (WebCore::DatabaseAuthorizer::allowAlterTable): (WebCore::DatabaseAuthorizer::createIndex): (WebCore::DatabaseAuthorizer::createTrigger): (WebCore::DatabaseAuthorizer::createVTable): (WebCore::DatabaseAuthorizer::allowInsert): (WebCore::DatabaseAuthorizer::allowUpdate):
  • storage/DatabaseAuthorizer.h: (WebCore::DatabaseAuthorizer::lastActionChangedDatabase):
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::notifyDatabaseChanged): Added. Allow external entities (SQLTransaction) to be able to request a didModifyDatabase notification to the delegate
  • storage/DatabaseTracker.h:
  • storage/SQLTransaction.cpp: Added m_modifiedDatabase flag which tracks if any statement over the course of a transaction resulted in a change to the database. (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::runCurrentStatement): Set m_modifiedDatabase to true if the authorizer reports a mutation statement occurred (WebCore::SQLTransaction::postflightAndCommit): If the transaction successfully commits, call DatabaseTracker::notifyDatabaseChanged (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto
  • storage/SQLTransaction.h:
2:04 PM Changeset in webkit [28255] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Geoff

Add isEqual operator to WebSecurityOrigin

  • Storage/WebSecurityOrigin.mm: (-[WebSecurityOrigin isEqual:]):
1:55 PM Changeset in webkit [28254] by Adam Roben
  • 2 edits in trunk/WebKitTools

Hopefully the final build fix

  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to pull in WTF's assertion/logging functions.
1:44 PM Changeset in webkit [28253] by Adam Roben
  • 2 edits in trunk/WebKitTools

Another build fix

  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for WebKit.lib.
1:27 PM Changeset in webkit [28252] by Adam Roben
  • 4 edits
    1 copy in trunk/WebKitTools

Debug build fix

  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal configuration.
  • Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other projects.
  • Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
  • Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
12:35 PM Changeset in webkit [28251] by Nikolas Zimmermann
  • 6 edits
    60 moves
    6 adds in trunk/WebCore

Rubber stamped by David.

Next round of moves - platform reorganization.
Move text/font/glyph related files from the individual port directories
into platform/text/<port> or platform/graphics/<port>.

12:15 PM Changeset in webkit [28250] by kevino@webkit.org
  • 4 edits in trunk

Other wx port fixes needed to restore the build bot.

12:11 PM Changeset in webkit [28249] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Fix drawSelectionRect to actually draw the selection rect.

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: (drawSelectionRect):
11:33 AM Changeset in webkit [28248] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the build with DATABASE=0.

11:32 AM Changeset in webkit [28247] by Adam Roben
  • 1 edit
    2 adds in trunk/LayoutTests

Copy some cross-platform results into platform/win to avoid picking up the platform/mac versions

  • platform/win/fast/dom/Window/window-resize-expected.txt: Copied from LayoutTests/fast/dom/Window/window-resize-expected.txt.
  • platform/win/fast/dom/wrapper-classes-expected.txt: Copied from LayoutTests/fast/dom/wrapper-classes-expected.txt.
11:21 AM Changeset in webkit [28246] by Nikolas Zimmermann
  • 2 edits
    1 move in trunk/WebCore

Rubber stamped by Darin.

Fix misplaced file. The name "FontStyle" is not correct though - it probably
needs yet another move - but this time inside platform/graphics - as soon
as we agree on a better name.

11:04 AM Changeset in webkit [28245] by sullivan@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Darin


Tweaks to newly-declared NSString * constants to make them usable from clients

  • Storage/WebDatabaseManagerPrivate.h:
  • Storage/WebDatabaseManager.mm: removed "const" from new NSNotification names and userInfo keys; these generate compiler warnings when used


  • WebKit.exp: export new NSNotification names and userInfo keys so clients can use them
11:02 AM QtWebKitTodo edited by Simon Hausmann
(diff)
10:56 AM Changeset in webkit [28244] by Adam Roben
  • 2 edits in branches/Safari-3-branch/WebKitTools

Merge r26734

10:54 AM Changeset in webkit [28243] by Darin Adler
  • 5 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Adam Roben.

SunSpider says this is 5.5% faster on the regexp test, 0.4% faste overall.

Test: fast/js/regexp-non-bmp.html

Renamed ANY_CHAR to NOT_NEWLINE to more-accurately reflect its meaning.

  • pcre/pcre_compile.cpp: (compile_branch): Removed calls to the UTF-16 character accessor functions, replacing them with simple pointer dereferences in some cases, and no code at all in others. (calculateCompiledPatternLengthAndFlags): Ditto.
  • pcre/pcre_exec.cpp: (match): Fixed indentation of some case labels (including all the BEGIN_OPCODE). Removed calls to the UTF-16 character accessor functions, replacing them with simple pointer dereferences in some cases, and no code at all in others. Also removed some explicit UTF-16 support code in a few cases. Removed the unneeded "UTF-8" code path in the ANY_CHAR repeat code, and in another case, eliminated the code to check against end_subject in because it is already done outside the loop. (jsRegExpExecute):
  • pcre/pcre_internal.h: Removed all the UTF-16 helper functions.

LayoutTests:

Reviewed by Adam Roben.

  • fast/js/regexp-non-bmp-expected.txt: Added.
  • fast/js/regexp-non-bmp.html: Added.
  • fast/js/resources/regexp-non-bmp.js: Added.
10:47 AM Changeset in webkit [28242] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
10:44 AM Changeset in webkit [28241] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Build fix after platform/text changes.

10:43 AM Changeset in webkit [28240] by Nikolas Zimmermann
  • 8 edits in trunk/WebCore

Reviewed by Sam.

Rename "FontStyle FontStyle(...)" to "FontStyle fontStyle(...)".
I scripted a bit too much while doing the TextStyle -> FontStyle change.

10:38 AM Changeset in webkit [28239] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-11-30 Alp Toker <​alp@atoker.com>

GTK+ build fix following the recent text reorganization.

  • WebCore.pro:
10:30 AM QtWebKitContrib edited by Simon Hausmann
(diff)
10:08 AM Changeset in webkit [28238] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2007-11-29 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Adam.

Part of <rdar://problem/5506522> Seed: cannot type into text box in
Facebook, don't see plugin content (Adobe Flash)

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent): Focus the plugin's parent frame
10:06 AM Changeset in webkit [28237] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Get ready for some future renaming.
10:03 AM Changeset in webkit [28236] by kmccullough@apple.com
  • 4 edits in trunk/WebKitTools

Reviewed by Adam.

  • Removed some unnecessary functions and changed an unused return type.
  • Drosera/win/DebuggerClient.cpp: (registerConsoleClass):
  • Drosera/win/DebuggerClient.h:
  • Drosera/win/Drosera.cpp: (registerDroseraClass):
9:54 AM Changeset in webkit [28235] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

Not reviewed. Trying to fix gtk/qt/wx build. (I expected problems because of the moves)

9:41 AM Changeset in webkit [28234] by Nikolas Zimmermann
  • 32 edits
    67 moves
    2 adds in trunk/WebCore

Rubber stamped by Brady.

Started platform reorganization (platform/text addition).
Moving string/text/font related classes into new places - as discussed on webkit-dev.

In a follow-up commit I'll move classes out of platform/{mac,win,...} into
platform/text/{mac,win,...}, and also do the ksvg2/ -> svg/ move.

9:02 AM Changeset in webkit [28233] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16072
<rdar://problem/5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button (16072)

Test: fast/events/mousemove-after-drag-over-scrollbar.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): If the mouse is pressed, and we've moved over a new scrollbar, then we can clear m_lastScrollbarUnderMouse. We should only need to show the hover effect when the mouse isn't pressed.

LayoutTests:

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=16072
<rdar://problem/5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button

  • fast/events/mousemove-after-drag-over-scrollbar-expected.txt: Added.
  • fast/events/mousemove-after-drag-over-scrollbar.html: Added.
6:12 AM Changeset in webkit [28232] by ap@webkit.org
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added editing/selection/5241148.html, which crashes for me.
4:40 AM Changeset in webkit [28231] by alp@webkit.org
  • 10 edits in trunk

2007-11-28 Alp Toker <​alp@atoker.com>

Reviewed by Timothy Hatcher.

​http://bugs.webkit.org/show_bug.cgi?id=16174
[GTK] Use "URI" not "URL" in public API

Replace use of the term "URL" with "URI" in public headers,
documentation and some internal code to match GLib/GTK+ convention.

This is now mentioned in the API guidelines:

​http://trac.webkit.org/projects/webkit/wiki/HackingGtk

API/ABI-breaking change.

1:34 AM Changeset in webkit [28230] by zecke@webkit.org
  • 6 edits in trunk/WebKit/qt
  • Self destruct the clients like the ohter ports do

Signed-off-by: Simon

12:49 AM Changeset in webkit [28229] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2007-11-30 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.

Fix layout test regressions caused by r28186
​http://bugs.webkit.org/show_bug.cgi?id=16195
change first_byte and req_byte back to shorts instead of chars
(I think PCRE stuffs information in the high bits)

  • pcre/pcre_internal.h:
12:44 AM QtWebKit edited by Simon Hausmann
(diff)
Note: See TracTimeline for information about the timeline view.