Context Navigation

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
DumpRenderTree/mac/JavaScriptThreading.h: Removed.
DumpRenderTree/pthreads: Added.
DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp. (javaScriptThreads): (runJavaScriptThread): (startJavaScriptThreads): (stopJavaScriptThreads):

8:59 PM Changeset in webkit [28376] by Adam Roben

1 copy in tags/Safari-525.2b

New tag.

8:57 PM Changeset in webkit [28375] by Adam Roben

2 edits in trunk/WebKit/win

Versioning.

5:08 PM Changeset in webkit [28374] by mitz@apple.com

2 edits in trunk/WebKitTools

2007-12-03 Andrew Bonventre <andybons@google.com>

Reviewed by Darin Adler.

Drosera/debugger.js: Fixed javascript error where document property should have been used instead of contentDocument in switchFunction that was breaking the select symbol dropdown menu. This is because window.frames will return a Window object and not a frame object like the author was originally expecting.

4:44 PM Changeset in webkit [28373] by sfalken@apple.com

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/Interfaces.vcproj

Build fix.

4:28 PM Changeset in webkit [28372] by mitz@apple.com

4 edits in trunk

WebCore:

Reviewed by Darin Adler.

fix <rdar://problem/5134044> fast/frames/frame-src-attribute.html fails on Windows

platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleWidth): Do not return negative values. (WebCore::ScrollView::visibleHeight): Ditto.

LayoutTests:

Reviewed by Darin Adler.

remove passing test

platform/win/Skipped:

4:25 PM Changeset in webkit [28371] by mitz@apple.com

13 edits
2 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

Test: fast/events/resize-subframe.html

page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added a timer used when deferring tasks that need to be done after layout. (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::layout): Moved the updating of widget positions, loading plug-ins and sending events queued up during layout into performPostLayoutTasks(). performPostLayoutTasks() is called after layout unless the layout was triggered by a previous layout's post- layout tasks. In the latter case, performPostLayoutTasks() is scheduled to run later. (WebCore::FrameView::performPostLayoutTasks): Performs work that needs to be done after layout but which can result in arbitrary code execution and therefore may re-invalidate the layout. This includes updating widget positions, loading plug-ins, and dispatching layout- related DOM events (scroll, overflow and resize). (WebCore::FrameView::postLayoutTimerFired): (WebCore::FrameView::dispatchScheduledEvents):
page/FrameView.h:
page/mac/WebCoreFrameBridge.h:
page/mac/WebCoreFrameBridge.mm: Removed -sendResizeEvent since this is handled by FrameView now.

WebKit/gtk:

Reviewed by Dave Hyatt.

fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

WebView/webkitwebview.cpp: Remove the call to sendResizeEvent() since FrameView sends it now.

WebKit/mac:

Reviewed by Dave Hyatt.

fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

WebView/WebHTMLView.mm: (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Removed the code that checked if the view had resized and sent the resize event, since FrameView sends resize events now.
WebView/WebHTMLViewInternal.h:

WebKit/win:

Reviewed by Dave Hyatt.

fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

WebView.cpp: (WebViewWndProc): Removed call to sendResizeEvent() since FrameView sends them now.

LayoutTests:

Reviewed by Dave Hyatt.

test for <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame

fast/events/resize-subframe-expected.txt: Added.
fast/events/resize-subframe.html: Added.

2:56 PM Changeset in webkit [28370] by Darin Adler

3 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

fix http://bugs.webkit.org/show_bug.cgi?id=15618 <rdar://problem/5619353> REGRESSION: Stack overflow/crash in KJS::equal (15618)

Test: fast/js/recursion-limit-equal.html

kjs/operations.cpp: (KJS::equal): Check the exception from toPrimitive.

LayoutTests:

Reviewed by Geoff.

test for http://bugs.webkit.org/show_bug.cgi?id=15618 <rdar://problem/5619353> REGRESSION: Stack overflow/crash in KJS::equal (15618)

fast/js/recursion-limit-equal-expected.txt: Added.
fast/js/recursion-limit-equal.html: Added.
fast/js/resources/recursion-limit-equal.js: Added.

2:15 PM Changeset in webkit [28369] by kmccullough@apple.com

12 edits
2 deletes in trunk

WebKit/win:

Reviewed by Adam.

<rdar://5618942> Drosera: Console window does not process everything correctly.
<rdar://5619005> Drosera: could be sped up by moving the WebScriptScope stuff into the WebScriptCallFrame.
Now the console can correctly process objects and does not receive notifications from JavaScriptCore about the JavaScript in Drosera's own process.

Interfaces/IWebScriptCallFrame.idl: Moved the variable lookup functions from WebScriptScope to here.
Interfaces/WebKit.idl: Removed WebScriptScope.
WebKit.vcproj/Interfaces.vcproj: Ditto.
WebKit.vcproj/WebKit.vcproj: Ditto.
WebKit.vcproj/WebKitGUID.vcproj: Ditto.
WebScriptCallFrame.cpp: Moved WebScriptScope functionality into here. (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Now returns a string value for things that are not strings. (WebScriptCallFrame::variableNames): Moved from WebScriptScope. (WebScriptCallFrame::valueForVariable): Moved from WebScriptScope. (WebScriptCallFrame::jsValueToString): Helper functions that converts any JSValue to a String.
WebScriptCallFrame.h: Moved WebScriptScope functionality into here.
WebScriptDebugger.cpp: Added nested guards so that Drosera does not receive notifications about JavaScript that Drosera is running just the JavaScript WebKit is running. (WebScriptDebugger::WebScriptDebugger): (WebScriptDebugger::sourceParsed): (WebScriptDebugger::callEvent): (WebScriptDebugger::atStatement): (WebScriptDebugger::returnEvent): (WebScriptDebugger::exception):
WebScriptDebugger.h: Ditto.
WebScriptScope.cpp: Removed.
WebScriptScope.h: Removed.

WebKitTools:

Reviewed by Adam.

<rdar://5618942> Drosera: Console window does not process everything correctly.
<rdar://5619005> Drosera: could be sped up by moving the WebScriptScope stuff into the WebScriptCallFrame.
Now the console can correctly process objects and does not receive notifications from JavaScriptCore about the JavaScript in Drosera's own process.

Drosera/win/DebuggerDocumentPlatform.cpp: (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):

2:14 PM Changeset in webkit [28368] by mitz@apple.com

2 edits in trunk/JavaScriptCore

fix a copy-and-paste-o

bindings/npruntime.cpp: (_NPN_GetIntIdentifier):

2:12 PM Changeset in webkit [28367] by Stephanie Lewis

2 edits in trunk/WebKitTools

Check to see if we are building a debug root

Scripts/check-for-global-initializers:

2:07 PM Changeset in webkit [28366] by mitz@apple.com

5 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

fix an ASSERT when getIntIdentifier is called with 0 or -1

bindings/npruntime.cpp: (_NPN_GetIntIdentifier): We cannot use the hashmap for 0 and -1 since they are the empty value and the deleted value. Instead, keep the identifiers for those two integers in a static array.

WebKitTools:

Reviewed by Darin Adler.

added a testGetIntIdentifier() method to TestNetscapePlugIn

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke):

LayoutTests:

Reviewed by Darin Adler.

added a test of the behavior of getIntIdentifier with the integers 0 and -1

plugins/getintidentifier-special-values-expected.txt: Added.
plugins/getintidentifier-special-values.html: Added.

1:43 PM Changeset in webkit [28365] by timothy@apple.com

6 edits in trunk/WebKit/mac

Reviewed by Darin.

Change WebViewGetResourceLoadDelegateImplementations and WebViewGetFrameLoadDelegateImplementations
to return a pointer to the implementation struct instead of a copy of the struct. This changes
all of the callers to dereference the pointer to access the struct fields.

Plugins/WebNullPluginView.mm: (-[WebNullPluginView reportFailure]):
WebCoreSupport/WebFrameBridge.mm:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::willCacheResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout):
WebView/WebView.mm: (WebViewGetResourceLoadDelegateImplementations): (WebViewGetFrameLoadDelegateImplementations): (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
WebView/WebViewInternal.h:

1:37 PM Changeset in webkit [28364] by timothy@apple.com

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix the build, move JSDOMWindow.h to the Copy Generated Headers phase.

1:25 PM Changeset in webkit [28363] by rwlbuis@webkit.org

3 edits
4 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15767
Text decorations do not respect "visibility" property

Only paint decorations if visibility is "visible".

12:35 PM Changeset in webkit [28362] by timothy@apple.com

2 edits in trunk/WebKit/mac

Reviewed by Brady Eidson.

<rdar://problem/5539913> 188 crashes in WebViewGetFrameLoadDelegateImplementations
<rdar://problem/5586095> CrashTracer: [USER] 5000+ crashes in Safari and Dashboard in dispatchDidFailLoading
<rdar://problem/5607081> CrashTracer: [USER] 2150 crashes in Safari at com.apple.WebKit:
WebViewGetResourceLoadDelegateImplementations + 28

WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): If the delegate is nil, bzero the implementation cache. This just prevents us from calling getMethod() multiple times just to zero. (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto. (WebViewGetResourceLoadDelegateImplementations): Return a zeroed implementations struct if the WebView is nil. This fixes the crashes. (WebViewGetFrameLoadDelegateImplementations): Ditto.

12:24 PM Changeset in webkit [28361] by alice.liu@apple.com

2 edits in trunk/LayoutTests

Removing passing tests

platform/win/Skipped:

11:55 AM Changeset in webkit [28360] by sfalken@apple.com

2 edits in trunk/WebCore

Fix build.

WebCore.vcproj/WebCore.vcproj:

11:47 AM Changeset in webkit [28359] by kdecker@apple.com

2 edits in trunk/WebKit/mac

i Reviewed by Darin.

Fixed: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang

The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would only call into the NPP_SetWindow()
function when we tell the plug-in to draw. This created havoc with Flash because Flash expects the browser to call NPP_SetWindow()
and provide a valid graphics context regardless of whether or not it actually needs to draw.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned down an ASSERT that was too strict. (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow() function.

11:19 AM Changeset in webkit [28358] by sfalken@apple.com

1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/PRODUCTVERSION

Bump version.

10:57 AM Changeset in webkit [28357] by Nikolas Zimmermann

3 edits
4 adds in trunk

Reviewed by David.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=15645
Don't allow selectors to interfere with the SVG shadow tree (<use> internal non-exposed tree).

10:44 AM Changeset in webkit [28356] by Nikolas Zimmermann

12 edits in trunk/LayoutTests

Rubber stamped by Mark.
Commit missing layout test results from my last commit (fix for bug 15403)

10:09 AM Changeset in webkit [28355] by zecke@webkit.org

2 edits in trunk/WebKit/qt

2007-12-03 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Rubber stamped by Mark.

Always include config.h at the beginning of the file.

Api/qwebsettings.cpp:

10:09 AM Changeset in webkit [28354] by mitz@apple.com

3 edits
3 adds in trunk

WebCore:

Reviewed by Adam Roben.

fix <rdar://problem/5538651> REGRESSSION: domfuzz: null deref in WebCore::Document::canReplaceChild

Test: fast/dom/Document/replaceChild-null-oldChild.html

dom/Document.cpp: (WebCore::Document::canReplaceChild):

LayoutTests:

Reviewed by Adam Roben.

test for <rdar://problem/5538651> REGRESSSION: domfuzz: null deref in WebCore::Document::canReplaceChild

fast/dom/Document/replaceChild-null-oldChild-expected.txt: Added.
fast/dom/Document/replaceChild-null-oldChild.html: Added.
fast/dom/Document/resources/replaceChild-null-oldChild.js: Added.

10:05 AM Changeset in webkit [28353] by zecke@webkit.org

8 edits in trunk

Avoid crashes by making sure everything is layouted before we start painting. This avoids a crash in Widget::invalidateRect because QPainter::begin would fail
The QWebFrame::layout() methods and calls are left untouched because this would be an API decision.

Signed-off-by: Simon

10:02 AM Changeset in webkit [28352] by zecke@webkit.org

2 edits in trunk/WebCore

Implement GraphicsContext::fillRoundedRect similiar to the CoreGraphics implementation only addPath is not called this seems to be only needed for CoreGraphics.

Signed-off-by: Simon

10:01 AM Changeset in webkit [28351] by zecke@webkit.org

2 edits in trunk/WebKit/qt

SubClass QWebPage to handle hide and close events.
Forward these events to the InspectorController
The other options would have been using an eventFilter on the webpage and making InspectorClient a QObject or creating a QObject Observer.
Provide a simple QWebPage* createWindow implementation. This is needed to make FrameLoaderClientQt::dispatchCreatePage stop crashing in the case of the inspector client.

Signed-off-by: Simon

10:01 AM Changeset in webkit [28350] by zecke@webkit.org

2 edits in trunk/WebCore

Coding Style fixes

Signed-off-by: Simon

10:00 AM Changeset in webkit [28349] by zecke@webkit.org

6 edits
1 add in trunk

Implement the InspectorClient for the Qt port
It does not support highlighting of nodes yet
Use QRC to open the internal page. The important thing is the '/' in the URL to make WebCore::Document::completeURL behave the way we want.
To make the InspectorClient work we will have to mark qrc as secure.

Signed-off-by: Simon

9:58 AM Changeset in webkit [28348] by zecke@webkit.org

4 edits in trunk/WebKit/qt

Allow adding the Inspect ContextMenuItem to our Menu
Open the Inspector when Inspect was activated. This requires that we keep the innerNonSharedNode from the HitTest around. This forces us to include <wtf/RefPtr.h> in the private header. It is the first non Qt header but should be okay.

Signed-off-by: Simon

9:57 AM Changeset in webkit [28347] by zecke@webkit.org

4 edits in trunk/WebKit/qt

Add the Developer Extras to the WebAttribute and propagate it to WebCore::Settings. This will enable the Inspect Element menu item
CodingStyle fixes in QWebSettings
Enable the Developer Extras in the QtLauncher

Signed-off-by: Simon

7:46 AM Changeset in webkit [28346] by Darin Adler

3 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=15848 <rdar://problem/5619330> REGRESSION: Assertion failure viewing comments page on digg.com

Test: fast/js/sparse-array.html

kjs/array_instance.cpp: (KJS::ArrayInstance::inlineGetOwnPropertySlot): Check sparse array cutoff before looking in hash map. Can't avoid the branch because we can't look for 0 in the hash. (KJS::ArrayInstance::deleteProperty): Ditto.

LayoutTests:

Reviewed by Mitz.

test for http://bugs.webkit.org/show_bug.cgi?id=15848 <rdar://problem/5619330> REGRESSION: Assertion failure viewing comments page on digg.com

fast/js/resources/sparse-array.js: Added.
fast/js/sparse-array-expected.txt: Added.
fast/js/sparse-array.html: Added.

4:57 AM Changeset in webkit [28345] by alp@webkit.org

4 edits in trunk/WebCore

2007-12-03 Alp Toker <alp@atoker.com>

Reviewed by Mark Rowe.

Don't delete the decoder if it's already been created. The one we have
is fine.

Cairo image cleanups. Nothing substantial.

Notify ImageObservers where appropriate.

platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):
platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::setData):
platform/graphics/gtk/ImageGtk.cpp:

4:04 AM Changeset in webkit [28344] by Simon Hausmann

2 edits in trunk/WebCore

Fixed crash when rendering form elements with Qt 4.4

QPainter::device() is not guaranteed to return a QWidget, so do the safe "cast" with the
help of QPaintDevice::devType().
Also fall back to the QApplication::style() if we don't have a widget.

2:36 AM Changeset in webkit [28343] by zecke@webkit.org

4 edits in trunk/WebCore

2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Reviewed by Sam Weinig.

Add FrameLoader::shouldTreatSchemeAsLocal which is similar to shouldTreatURLAsLocal.
Make use of FrameLoader::shouldTreatSchemeAsLocal in SecurityOrigin and do not hardcode "file". This is needed for the WebKit/qt port to make the Web Inspector work as it using the qrc protocol instead of file.

loader/FrameLoader.cpp: (WebCore::FrameLoader::shouldTreatSchemeAsLocal):
loader/FrameLoader.h:
platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::isSecureTransitionTo):

2:34 AM Changeset in webkit [28342] by zecke@webkit.org

2 edits in trunk/WebCore

2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Rubber stamped by Sam Weinig.

Only add applewebdata to the localSchemes when building for the
mac. This is in preparation of adding qrc for the Qt port there
as well and http://bugs.webkit.org/show_bug.cgi?id=15938.

According to Anders applewebdata is not used on the win port.

loader/FrameLoader.cpp: (WebCore::localSchemes):

2:33 AM Changeset in webkit [28341] by zecke@webkit.org

2 edits in trunk/WebCore

2007-12-02 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Rubber stamped by Sam Weinig.

Fix a typo. It is contains and not containts

loader/FrameLoader.cpp:

1:25 AM Changeset in webkit [28340] by mrowe@apple.com

2 edits in trunk/WebKit/win

2007-12-03 Mark Rowe <mrowe@apple.com>

Speculative Windows build fix.

WebScriptCallFrame.cpp: (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):

1:19 AM Changeset in webkit [28339] by mrowe@apple.com

2 edits in trunk/WebKit/wx

2007-12-03 Mark Rowe <mrowe@apple.com>

wx build fix.

WebView.cpp: (wxWebView::RunScript):

1:10 AM Changeset in webkit [28338] by ap@webkit.org

2 edits in trunk/WebKitTools

Reviewed by Oliver.

Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
in a more fine-grained manner than eventSender.keyDown().

DumpRenderTree/win/EventSender.cpp: (getConstantCallback): (dispatchMessageCallback):

1:05 AM Changeset in webkit [28337] by Adam Roben

2 edits in trunk/WebKit/win

Another speculative Windows build fix

WebScriptCallFrame.cpp: (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):

12:58 AM Changeset in webkit [28336] by alp@webkit.org

4 edits in trunk

2007-12-03 Alp Toker <alp@atoker.com>

Add another missing DEPENDPATH.

Noticed when fixing the build.

WebCore.pro:

12:52 AM Changeset in webkit [28335] by Adam Roben

2 edits in trunk/WebCore

Speculative Windows build fix

plugins/win/PluginViewWin.cpp: (WebCore::getString):

12:43 AM Changeset in webkit [28334] by Adam Roben

3 edits in trunk/WebKit/win

Speculative Windows build fix

WebFrame.cpp: (WebFrame::globalContext): (WebFrame::windowObjectCleared):
WebScriptDebugger.cpp: (WebScriptDebugger::WebScriptDebugger):

12:13 AM Changeset in webkit [28333] by ggaren@apple.com

2 edits in trunk/WebKit/qt

Removed unnecessary and possibly incorrect #include from my last
check-in.

Api/qwebframe.cpp:

12:10 AM Changeset in webkit [28332] by ggaren@apple.com

2 edits in trunk/WebKit/gtk

GTK Build fix: get globalExec from the right place.

WebView/webkitwebframe.cpp:

12:06 AM Changeset in webkit [28331] by ggaren@apple.com

2 edits in trunk/WebKit/qt

Qt build fix: Get globalExec() from the right place.

12:02 AM Changeset in webkit [28330] by ggaren@apple.com

2 edits in trunk/WebCore

Build fix: added symbols to the right .exp file.

WebCore.base.exp:

Dec 2, 2007:

11:53 PM Changeset in webkit [28329] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

Build fix: added an #include.

kjs/collector.cpp:

11:43 PM Changeset in webkit [28328] by ggaren@apple.com

47 edits
1 add in trunk

JavaScriptCore:

Reviewed by Eric Seidel.

Second step in refactoring JSGlobalObject: moved virtual functions from
Interpreter to JSGlobalObject.

Layout and JS tests pass. SunSpider reports a .7% speedup -- don't
believe his lies.

JavaScriptGlue:

Reviewed by Eric Seidel.

Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.

JSRun.cpp:
JSRun.h:
JSValueWrapper.cpp: (getThreadGlobalExecState):
JavaScriptGlue.cpp: (JSRunCopyGlobalObject): (JSRunEvaluate):

WebCore:

Reviewed by Eric Seidel.

Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.

Moved virtual ScriptInterpreter functions to Window.

WebKit/mac:

Reviewed by Eric Seidel.

Updated to match the JavaScriptCore change to move virtual methods from
Interpreter to JSGlobalObject.

WebView/WebFrame.mm: (-[WebFrame globalContext]): Use the toRef function instead of manually casting.

9:52 PM QtWebKitContrib edited by Simon Hausmann

(diff)

8:57 PM Changeset in webkit [28327] by Darin Adler

17 edits
22 adds in trunk

WebCore:

Reviewed by Mitz.

fix <rdar://problem/5601995> Hang/crash on http://ebay-uk.custhelp.com/

There were two problems here:

1) Incorrect HTMLCollection behavior led to us trying to insert a

new row inside an existing row instead of next to it. The fix for
this is to make HTMLCollection work better for table-related
collections.

2) HTMLTableRowElement::insertCell would return a bad pointer if

the insertion failed. The code should have failed, but not crashed,
so it's worth fixing that too.

While fixing the HTMLCollection issues, I did some clean-up of that
class and its derived classes.

Test: fast/dom/HTMLTableElement/rows.html
Test: fast/dom/HTMLTableElement/tBodies.html
Test: fast/dom/HTMLTableRowElement/cells.html
Test: fast/dom/HTMLTableRowElement/insertCell.html
Test: fast/dom/HTMLTableSectionElement/rows.html

bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): Updated because collectionType() was renamed to type().

html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): Updated for data member name changes. Also added a protected constructor for use by derived classes that pass in a CollectionInfo. (WebCore::HTMLCollection::CollectionInfo::copyCacheMap): Moved out of the header. (WebCore::isTableSection): Added. (WebCore::HTMLCollection::itemAfter): Renamed from traverseNextItem, because the old name was grammatically incorrect and thus a bit confusing. Changed to operate on Element* instead of Node*, and use 0 to start rather than passing in the base node (required since the base node can be a document, which is not an element). Generalized the code that made NodeChildren not descend into deeper descendants so it can be used for TRCells, TSectionRows, TableTBodies, and TableRows. Reformatted the switch statement and got rid of the "found" boolean since we can just return when we find something. Got rid of the default case, and instead listed all the enum values. Also changed to use a for loop for clarity. (WebCore::HTMLCollection::calcLength): Updated for itemAfter changes. (WebCore::HTMLCollection::item): Ditto. (WebCore::HTMLCollection::nextItem): Ditto. (WebCore::HTMLCollection::checkForNameMatch): Updated to take an Element instead of a Node pointer. (WebCore::HTMLCollection::namedItem): More of the same. (WebCore::HTMLCollection::updateNameCache): Ditto. (WebCore::HTMLCollection::namedItems): Ditto. (WebCore::HTMLCollection::nextNamedItem): Ditto. (WebCore::HTMLCollection::tags): Ditto.

html/HTMLCollection.h: Added a type FormElements, so that the HTMLFormCollection would not have a type of DocImages, which is what it previously did. Changed the base parameter to be a PassRefPtr to make it clear we take ownership of it. Added a comment explaining why we should change the name CollectionInfo. Made a lot more members private instead of protected. Renamed traverseNextItem to itemAfter. Changed most functions to take Element* instead of Node*.

html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo): Added. (WebCore::HTMLFormCollection::HTMLFormCollection): Updated to pass collection info into the base class. (WebCore::HTMLFormCollection::calcLength): Updated to use base() so we don't need to get at m_base directly. (WebCore::HTMLFormCollection::item): Same, but for info(). (WebCore::HTMLFormCollection::getNamedItem): Removed unused first argument. (WebCore::HTMLFormCollection::getNamedFormItem): Got rid of unneeded checks that the base is still an element and still a form, since that's guaranteed. (WebCore::HTMLFormCollection::nextItem): Use info(). (WebCore::HTMLFormCollection::nextNamedItemInternal): Node instead of Element, some name changes. (WebCore::HTMLFormCollection::namedItem): Update for changes elsewhere. (WebCore::HTMLFormCollection::nextNamedItem): Ditto, also rewrote loop to be much simpler. (WebCore::HTMLFormCollection::updateNameCache): More of the same.

html/HTMLFormCollection.h: Changed constructor to take an HTMLFormElement, using a PassRefPtr to communicate transfer of ownership. Made everything private instead of protected. Removed unneeded override of firstItem. Made getNamedItem and nextNamedItemInternal non-virtual. Removed unused first argument of getNamedItem. Added declaration of formCollectionInfo.

html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::HTMLNameCollection): Updated to pass collection info into the base class. (WebCore::HTMLNameCollection::itemAfter): Reformatted a bit and changed into a for loop.

html/HTMLNameCollection.h: Updated for name changes. Made function private instead of public. Used PassRefPtr in constructor.

html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::HTMLOptionsCollection): Updated to pass collection info into the base class. (WebCore::HTMLOptionsCollection::add): Updated for public/private changes in the base class. (WebCore::HTMLOptionsCollection::selectedIndex): Ditto. (WebCore::HTMLOptionsCollection::setSelectedIndex): Ditto. (WebCore::HTMLOptionsCollection::setLength): Ditto.

html/HTMLOptionsCollection.h: Changed constructor parameter to be a PassRefPtr.

html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::insertCell): Changed code to use RefPtr and PassRefPtr since this creates a new object. This alone fixed the crash. Also cleaned up logic a bit to be more readable.

html/HTMLTableRowElement.h: Changed insertCell to return a PassRefPtr. Also reordered functions a bit to make things a little more logical and removed the unused ncols data member.

html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows): Pass TSectionRows, not TableRows. This mistake was harmless before because TableRows and TSectionRows were handled identically inside HTMLCollection, but that is no longer the case with this fix.

bindings/scripts/CodeGeneratorJS.pm: Add an include to cope with the fact that HTMLOptionsCollection no longer includes HTMLOptionElement. I don't think this really should be a special case -- might be worth returning later to see if this can be optimized.

LayoutTests:

Reviewed by Mitz.

tests for table-related HTMLCollection classes for misnested tables and for <rdar://problem/5601995> Hang/crash on http://ebay-uk.custhelp.com/

fast/dom/HTMLTableElement/resources: Added.
fast/dom/HTMLTableElement/resources/TEMPLATE.html: Added.
fast/dom/HTMLTableElement/resources/rows.js: Added.
fast/dom/HTMLTableElement/resources/tBodies.js: Added.
fast/dom/HTMLTableElement/rows-expected.txt: Added.
fast/dom/HTMLTableElement/rows.html: Added.
fast/dom/HTMLTableElement/tBodies-expected.txt: Added.
fast/dom/HTMLTableElement/tBodies.html: Added.
fast/dom/HTMLTableRowElement: Added.
fast/dom/HTMLTableRowElement/cells-expected.txt: Added.
fast/dom/HTMLTableRowElement/cells.html: Added.
fast/dom/HTMLTableRowElement/insertCell-expected.txt: Added.
fast/dom/HTMLTableRowElement/insertCell.html: Added.
fast/dom/HTMLTableRowElement/resources: Added.
fast/dom/HTMLTableRowElement/resources/TEMPLATE.html: Added.
fast/dom/HTMLTableRowElement/resources/cells.js: Added.
fast/dom/HTMLTableSectionElement: Added.
fast/dom/HTMLTableSectionElement/resources: Added.
fast/dom/HTMLTableSectionElement/resources/TEMPLATE.html: Added.
fast/dom/HTMLTableSectionElement/resources/rows.js: Added.
fast/dom/HTMLTableSectionElement/rows-expected.txt: Added.
fast/dom/HTMLTableSectionElement/rows.html: Added.

8:41 PM Changeset in webkit [28326] by Darin Adler

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: More planned renaming.

5:05 PM Changeset in webkit [28325] by Nikolas Zimmermann

4 edits in trunk/WebCore

Reviewed by Adam.

RenderSVGViewportContainer sets wrong width/height.
Share code with RenderSVGContainer in a central calcBounds() function.

Fixes:

svg/custom/use-css-events.svg (http://bugs.webkit.org/show_bug.cgi?id=15403)
svg/custom/deep-dynamic-updates.svg
svg/custom/use-clipped-hit.svg
svg/custom/image-clipped-hit.svg

3:40 PM Changeset in webkit [28324] by weinig@apple.com

2 edits in trunk/WebKitTools

Rubber stamped by Anders.

Use [NSURL absoluteString] instead of [NSURL description] in order to get
more uniform results cross platform.

DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):

3:32 PM Changeset in webkit [28323] by weinig@apple.com

3 edits
2 moves in trunk/WebKitTools

Rubber stamped by Niko.

Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.

DumpRenderTree/win/DumpRenderTree.cpp:
DumpRenderTree/win/DumpRenderTree.vcproj:
DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
DumpRenderTree/win/FrameLoaderDelegate.h: Removed.

12:20 PM Changeset in webkit [28322] by beidson@apple.com

7 edits in trunk/WebCore

Reviewed by Darin

databaseChanged notifications were being sent out on the database thread - they need to be on the main thread
like all other notifications we send out!

platform/SecurityOriginData.cpp: (WebCore::SecurityOriginData::copy): Add a deep copy method, for when an object thread hops
platform/SecurityOriginData.h:

storage/DatabaseTracker.cpp: (WebCore::notificationMutex): (WebCore::notificationQueue): (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): Add the origin/name pair to a queue (WebCore::DatabaseTracker::scheduleForNotification): Schedule to deliver this queue of notifications on the main thread (WebCore::DatabaseTracker::notifyDatabasesChanged): Deliver all notifications in the queue
storage/DatabaseTracker.h:

storage/SQLTransaction.cpp: (WebCore::SQLTransaction::postflightAndCommit): scheduleNotifyDatabaseChanged() instead of "notify now!" (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback): Ditto

12:18 PM WebKit Team edited by rwlbuis@webkit.org