Context Navigation

← Previous Period
Next Period →

Timeline

Feb 16, 2008:

9:48 PM Changeset in webkit [30344] by oliver@apple.com

2 edits in trunk/WebCore

Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp

Reviewed by Eric S

Use cross-platform code to determine the dirty rects for
fill and stroke operations

7:43 PM Changeset in webkit [30343] by weinig@apple.com

8 edits in trunk/WebCore

Reviewed by Darin Adler.

Take another step in the direction of getting rid of DeprecatedString
by moving all the to{NumericType} off of it.

Create free functions that take a UChar* buffer and length to do the string-to-number conversions. This allows us to avoid two allocations if we don't already have a String and is consistent with the design we would like going forward.
Since the toInt (and family) functions on DeprecatedString were slightly different than the ones on String (they didn't allow trailing garbage), an extra set of 'Strict' toInt functions were added that have this behavior.

platform/graphics/Color.cpp: (WebCore::Color::parseHexColor):
platform/text/PlatformString.h:
platform/text/String.cpp: (WebCore::String::percentage): (WebCore::String::toIntStrict): (WebCore::String::toUIntStrict): (WebCore::String::toInt64Strict): (WebCore::String::toUInt64Strict): (WebCore::String::toUInt): (WebCore::String::toDouble): (WebCore::isCharacterAllowedInBase): (WebCore::toIntegralType): (WebCore::lengthOfCharactersAsInteger): (WebCore::charactersToIntStrict): (WebCore::charactersToUIntStrict): (WebCore::charactersToInt64Strict): (WebCore::charactersToUInt64Strict): (WebCore::charactersToInt): (WebCore::charactersToUInt): (WebCore::charactersToInt64): (WebCore::charactersToUInt64): (WebCore::charactersToDouble): (WebCore::charactersToFloat):
platform/text/StringImpl.cpp: (WebCore::parseLength): (WebCore::StringImpl::toIntStrict): (WebCore::StringImpl::toUIntStrict): (WebCore::StringImpl::toInt64Strict): (WebCore::StringImpl::toUInt64Strict): (WebCore::StringImpl::toInt): (WebCore::StringImpl::toUInt): (WebCore::StringImpl::toInt64): (WebCore::StringImpl::toUInt64): (WebCore::StringImpl::toDouble): (WebCore::StringImpl::toFloat):
platform/text/StringImpl.h:
svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseClockValue):
svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute):

7:08 PM Changeset in webkit [30342] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

fix fixed-pitch font measurement of control characters that render as zero-width space

Test: fast/text/fixed-pitch-control-characters.html

rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache):

LayoutTests:

Reviewed by Sam Weinig.

test fixed-pitch font measurement of control characters that render as zero-width space

fast/text/fixed-pitch-control-characters.html: Added.
platform/mac/fast/text/fixed-pitch-control-characters-expected.checksum: Added.
platform/mac/fast/text/fixed-pitch-control-characters-expected.png: Added.
platform/mac/fast/text/fixed-pitch-control-characters-expected.txt: Added.

2:04 PM Changeset in webkit [30341] by kevino@webkit.org

2 edits in trunk/WebCore

wx build fix.

1:06 PM WebKit Team edited by weinig@apple.com

Add areas of knowledge for Sam Weinig (diff)

1:02 PM WebKit Team edited by weinig@apple.com

Remove Tristan as he is no longer at Apple (diff)

9:41 AM Changeset in webkit [30340] by Darin Adler

1 edit
3 moves in trunk/LayoutTests

disable some failing tests; someone can re-enable after fixing the problems causing them to fail or generating new expected results

http://bugs.webkit.org/show_bug.cgi?id=17391

fast/frames/iframe-scroll-page-up-down.html: Removed.
fast/frames/iframe-scroll-page-up-down.html-disabled: Copied from fast/frames/iframe-scroll-page-up-down.html.

http://bugs.webkit.org/show_bug.cgi?id=17392

svg/batik/text/textBiDi.svg: Removed.
svg/batik/text/textBiDi.svg-disabled: Copied from svg/batik/text/textBiDi.svg.

http://bugs.webkit.org/show_bug.cgi?id=17393

svg/custom/use-on-symbol-inside-pattern.svg: Removed.
svg/custom/use-on-symbol-inside-pattern.svg-disabled: Copied from svg/custom/use-on-symbol-inside-pattern.svg.

9:35 AM Changeset in webkit [30339] by Darin Adler

1 edit in trunk/WebCore/ChangeLog

Clean up some old log entries.

3:09 AM Changeset in webkit [30338] by alp@webkit.org

2 edits in trunk/WebCore

2008-02-16 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

Cross document messaging GTK+/autotools build fix.

GNUmakefile.am:

Feb 15, 2008:

10:44 PM Changeset in webkit [30337] by oliver@apple.com

3 edits in trunk/WebCore

Build fix for Qt and Cairo builds

10:00 PM Changeset in webkit [30336] by oliver@apple.com

8 edits in trunk/WebCore

Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Refactor CanvasRenderingContext2D::drawImage(HTMLCanvasElement) to remove evil ifdefs

Reviewed by Dan B.

Add logic draw(ImageBuffer*) method to GraphicsContext to handle
painting the source canvas content.

9:57 PM Changeset in webkit [30335] by mitz@apple.com

2 edits in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.

skip a test for a Leopard-only NSHTTPURLResponse bug workaround

platform/mac-tiger/Skipped:

7:23 PM Changeset in webkit [30334] by kevino@webkit.org

2 edits in trunk/WebCore

Using GetNativeFontInfoDesc() to generate the hash value was leading to duplicate entries in the HashMap. Use the font object's pointer instead.

http://bugs.webkit.org/show_bug.cgi?id=17371

6:51 PM Changeset in webkit [30333] by adachan@apple.com

2 edits in trunk/WebCore

When parsing url we get from a CFURLRef, we need to null terminate
the string for the case when url ends with a '/'.

Reviewed by Darin.

platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL):

6:02 PM Changeset in webkit [30332] by beidson@apple.com

2 edits in trunk/LayoutTests

Added 2 skipped tests

platform/mac-tiger/Skipped:

4:51 PM Changeset in webkit [30331] by beidson@apple.com

15 edits in trunk

WebCore:

Reviewed by Darin

Fix for <rdar://problem/5727175> and <rdar://problem/5740495> - Database threads and callback scripts can run after
a page has closed or loaded a new document

Deciding to make the Database I/O semantic the same as loaders/XHR when a document is shut down, this patch implements
a policy of shutting down the databases in a document at the same time. This includes removing all pending transactions
in a database, cutting off an queued statements in the current transaction, and preventing further callbacks from being
made.

No new layout tests with this patch as the current layout tests were catching this issue in a plethora of ways already
(crashing, unexpected exceptions and output, etc)

dom/Document.cpp: (WebCore::Document::~Document): Don't actually stop the database thread here - it better have been stopped already. Add an assertion to that effect. (WebCore::Document::addOpenDatabase): Add a new database handle to this Document's open database set (WebCore::Document::removeOpenDatabase): Remove such a handle (WebCore::Document:: stopDatabases): Call "close" on all open Database handles for this document
dom/Document.h:

loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): In addition to canceling all resource loads and XHRs, stop all database I/O

platform/MessageQueue.h: (WebCore::MessageQueue::killed):

platform/sql/SQLiteTransaction.cpp: (WebCore::SQLiteTransaction::stop): Added. Explicit stop to cut off a transaction so it won't try anymore SQL activity
platform/sql/SQLiteTransaction.h:

storage/Database.cpp: (WebCore::Database::Database): (WebCore::Database::~Database): (WebCore::Database::markAsDeletedAndClose): Check if the thread has terminated before committing to waiting on the thread. (WebCore::Database::stop): Stop this database, including all queued transactions and callbacks
storage/Database.h: (WebCore::Database::stopped):

storage/DatabaseThread.cpp: (WebCore::DatabaseThread::terminationRequested):
storage/DatabaseThread.h:

storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL): Throw an exception if a new executeSQL comes in after a database is closed (WebCore::SQLTransaction::checkAndHandleClosedDatabase): Added. Clears queued statements and clear the next step when the database has been closed since the last step/callback was run. Also stops the current SQLite transaction, if any (WebCore::SQLTransaction::performNextStep): (WebCore::SQLTransaction::performPendingCallback):
storage/SQLTransaction.h:

LayoutTests:

Reviewed by Darin

Fix for <rdar://problem/5727175> and <rdar://problem/5740495> - Database threads and callback scripts can run after
a page has closed or loaded a new document

storage/close-during-stress-test-expected.txt: Update results - this test contained output from a javascript callback that never should have taken place

4:44 PM Changeset in webkit [30330] by adele@apple.com

5 edits in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5745072> REGRESSION (r29348): Shift + Tab does not change indent level on Google Docs

The immediate cause of this bug was that we stopped sending keypress events for the tab key when it is used to advance focus.
We had a special case for forward-tab in designMode, where the default behavior was to insert a tab key (or respect the keypress handler behavior).
This change makes the shift-tab behavior match the forward-tab behavior.

If the site had put their event handler (which does the indenting) on the keydown event, then this problem would have been avoided.
This is something we should look into and maybe advise the site on in the future. However, it's a low-risk change to just make tab and shift-tab uniform
in this respect, so I think this is the way to go for right now.

page/EventHandler.cpp: (WebCore::EventHandler::defaultTabEventHandler):

LayoutTests:

Reviewed by Darin.

Updated test for <rdar://problem/5745072> REGRESSION (r29348): Shift + Tab does not change indent level on Google Docs

editing/inserting/typing-tab-designmode-expected.txt:
editing/inserting/typing-tab-designmode.html:

3:47 PM Changeset in webkit [30329] by andersca@apple.com

2 edits in trunk/WebCore

Reviewed by Alice.

<rdar://problem/5738678>
REGRESSION: "Loading" status remains when uploading file to .Mac iDisk via Safari

Use the new CFNetwork functions for setting body parts.

platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody): (WebCore::httpBodyFromRequest):

3:39 PM Changeset in webkit [30328] by ggaren@apple.com

7 edits in trunk

WebCore:

Reviewed by Anders Carlsson.

Fixed <rdar://problem/5725429> REGRESSION (r27898): Greenfield online
surveys no longer work due to XMLHttpRequest exceptions

Reverted some exception throwing code from r12194.

To comply with the W3C draft spec, we used to throw an exception when
trying to access responseText and responseXML at the wrong time, but
that turned out to be a compatibility problem.

Now, matching Firefox and previous versions of WebKit, we never throw
an exception when accessing responseText or responseXML.

See http://www.mail-archive.com/public-webapi@w3.org/msg02756.html.

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML):

LayoutTests:

Reviewed by Anders Carlsson.

Fixed <rdar://problem/5725429> REGRESSION (r27898): Greenfield online
surveys no longer work due to XMLHttpRequest exceptions

Updated layout tests to expect an exception not to be thrown.

http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html:
http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html:
http/tests/xmlhttprequest/zero-length-response-expected.txt:
http/tests/xmlhttprequest/zero-length-response-sync-expected.txt:

3:27 PM Changeset in webkit [30327] by alice.liu@apple.com

1 edit in trunk/WebCore/ChangeLog

minor correction to my last Changlog entry.

3:25 PM Changeset in webkit [30326] by justin.garcia@apple.com

23 edits
3 adds
1 delete in trunk

WebCore:

Reviewed by Dan Bernstein.

<rdar://problem/5738768> REGRESSION (r30062): Crash in InlineTextBox::isLineBreak() when Undoing a replace

Rolled out <http://trac.webkit.org/projects/webkit/changeset/29667>

editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved):

LayoutTests:

Reviewed by Dan Bernstein.

<rdar://problem/5738768> REGRESSION (r30062): Crash in InlineTextBox::isLineBreak() when Undoing a replace

Disabled:

editing/selection/inconsistent-in-removeChildNode.html: Removed.
editing/selection/inconsistent-in-removeChildNode.html-disabled: Added.

Demonstrates fix:

editing/undo/5738768-expected.txt: Added.
editing/undo/5738768.html: Added.

During a shouldChangeSelection call, the old selection is no longer null because
nodeWillBeRemoved doesn't blow it away:

platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
platform/mac/editing/style/remove-underline-in-bold-expected.txt:

During a shouldChangeSelection call, the old selection is now null because
nodeWillBeRemoved blows it away:

platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:

More instances of <rdar://problem/5729315>, where, during a shouldChangeSelection
call content that held the old selection is still around but it wouldn't make sense
to leave the selection there, so we shouldn't call shouldChangeSelection at all:

platform/mac/editing/style/remove-underline-expected.txt:
platform/mac/editing/style/unbold-in-bold-expected.txt:

Similar changes, but ones where I've also updated pixel results for old, unrelated fixes:

platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
platform/mac/editing/deleting/delete-leading-ws-001-expected.checksum:
platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
platform/mac/editing/deleting/delete-line-011-expected.checksum:
platform/mac/editing/deleting/delete-line-011-expected.txt:
platform/mac/editing/execCommand/paste-1-expected.checksum:
platform/mac/editing/execCommand/paste-1-expected.txt:
platform/mac/editing/execCommand/paste-2-expected.checksum:
platform/mac/editing/execCommand/paste-2-expected.txt:
platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.checksum:
platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
platform/mac/editing/pasteboard/paste-text-012-expected.checksum:
platform/mac/editing/selection/4960116-expected.checksum:

3:18 PM Changeset in webkit [30325] by alice.liu@apple.com

23 edits
1 add in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/5741440> REGRESSION (r28496): After deactivating JavaScript, scripts embedded in the HTML page continue to run

Before this patch, Frame::scriptProxy() would only return null in the case that javascript was
disabled and if the script proxy field wasn't set (which would only be the case if the window
hasn't loaded anything yet). Not all callers of scriptProxy() always check for a non-null return
value. Those that did check would effectively be checking if javascript was enabled before proceeding.
This fix consists of 2 elements: first, make sure that scriptProxy() will never return null, regardless
of whether javascript is disabled. This will mean that callers who don't check for null won't crash.
Second, callers who did check for null now instead check for javascript being disabled. This means that
code paths intended for preventing javascript from being run will be making the correct check. Another
minor addition to this patch is that I added a function on Frame to be a shortcut for checking if javascript
is enabled.

bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent):
bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
bindings/js/kjs_html.cpp: (WebCore::runtimeObjectImplementsCall):
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::isEnabled):
bindings/js/kjs_proxy.h:
bindings/js/kjs_window.cpp: (KJS::Window::retrieveWindow): (KJS::Window::retrieve):
dom/Document.cpp: (WebCore::Document::createHTMLEventListener):
dom/EventTarget.cpp: (WebCore::EventTarget::dispatchGenericEvent):
html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::createNPObject):
html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::evaluateScript):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken):
loader/FrameLoader.cpp: (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::userGestureHint): (WebCore::FrameLoader::open): (WebCore::FrameLoader::dispatchWindowObjectAvailable): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
manual-tests/disable-javascript-reload.html: Added.
page/Frame.cpp: (WebCore::Frame::scriptProxy): (WebCore::Frame::bindingRootObject): (WebCore::Frame::windowScriptNPObject):
page/Frame.h:
page/InspectorController.cpp: (WebCore::canPassNodeToJavaScript):
page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):
svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::createSVGEventListener):

2:30 PM Changeset in webkit [30324] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebCore

Merge r30285.

1:30 PM Changeset in webkit [30323] by mitz@apple.com

8 edits
6 adds in trunk

WebCore:

Reviewed by Alexey Proskuryakov.

WebCore part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360 <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html

Test: http/tests/loading/text-content-type-with-binary-extension.html

Refined the workaround for <rdar://problem/5321972> to exclude files
with extensions that are known to be associated with binary MIME types.

WebCore.xcodeproj/project.pbxproj: Added WebCoreURLResponse.{h,mm}.
platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Moved the workaround logic into WebCoreURLResponse.
platform/network/mac/WebCoreURLResponse.h: Added.
platform/network/mac/WebCoreURLResponse.mm: Added. (createBinaryExtensionsSet): Returns a set of extensions known to belong to MIME types of binary data. (-[NSURLResponse _webcore_MIMEType]): (-[NSHTTPURLResponse _webcore_MIMEType]): Forces the MIME type from application/octet-stream to text/plain if that is the specified Content-Type, unless the extension is in the binary extensions set.

WebKit/mac:

Reviewed by Alexey Proskuryakov.

WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360 <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html

WebView/WebDataSource.mm: (+[WebDataSource _representationClassForMIMEType:]): (-[WebDataSource _responseMIMEType]): (-[WebDataSource subresources]): (-[WebDataSource subresourceForURL:]):
WebView/WebResource.mm: (-[WebResource _initWithData:URL:response:]):
WebView/WebResourcePrivate.h:

LayoutTests:

Reviewed by Alexey Proskuryakov.

test for http://bugs.webkit.org/show_bug.cgi?id=17360 <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html

http/tests/loading/resources/.htaccess: Added.
http/tests/loading/resources/binaryData.m4a: Added.
http/tests/loading/text-content-type-with-binary-extension-expected.txt: Added.
http/tests/loading/text-content-type-with-binary-extension.html: Added.

1:28 PM Changeset in webkit [30322] by mrowe@apple.com

6 edits in branches/Safari-3-1-branch

Merge r30276.

1:27 PM Changeset in webkit [30321] by mrowe@apple.com

17 edits in branches/Safari-3-1-branch

Merge r30269.

1:26 PM Changeset in webkit [30320] by weinig@apple.com

1 edit
1 add in trunk/LayoutTests

Reviewed and rubber-stamped by Oliver Hunt.

Add leopard specific results for stroke-width-click.svg to work around
a CG regression.

platform/mac-leopard/svg/custom/stroke-width-click-expected.txt: Added.

1:08 PM Changeset in webkit [30319] by mitz@apple.com

3 edits
1 add in trunk/WebCore

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=17306 <rdar://problem/5737923> Transitions between styles that have different transition-* properties behave inconsistently

manual-tests/transitions.html: Added.
page/AnimationController.cpp: (WebCore::CompositeImplicitAnimation::animate): Changed to use the transition properties of the current style rather than the target style. (WebCore::AnimationControllerPrivate::get): Changed to not create an animation if the style does not have transitions. (WebCore::AnimationController::updateImplicitAnimations): Added code to return the target style if the current style is not animating.
rendering/RenderObject.cpp: (WebCore::RenderObject::setAnimatableStyle): Changed to call updateImplicitAnimations() even if the current style does not have transitions, because we may be animating out of a style that had them.

12:44 PM Changeset in webkit [30318] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebKitTools

Merge r30242.

12:44 PM Changeset in webkit [30317] by mrowe@apple.com

3 edits in branches/Safari-3-1-branch/LayoutTests

Merge r30241.

12:43 PM Changeset in webkit [30316] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebCore

Merge r30240.

12:43 PM Changeset in webkit [30315] by mrowe@apple.com

6 edits in branches/Safari-3-1-branch

Merge r30239.

12:42 PM Changeset in webkit [30314] by mrowe@apple.com

14 edits
2 adds in branches/Safari-3-1-branch

Merge r30238.

12:41 PM Changeset in webkit [30313] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebCore

Merge r30237.

12:41 PM Changeset in webkit [30312] by mrowe@apple.com

3 edits
3 adds in branches/Safari-3-1-branch

Merge r30235.

12:40 PM Changeset in webkit [30311] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebCore

Merge r30233.

12:40 PM Changeset in webkit [30310] by mrowe@apple.com

10 edits in branches/Safari-3-1-branch

Merge r30222.

12:39 PM Changeset in webkit [30309] by mrowe@apple.com

3 edits in branches/Safari-3-1-branch/WebCore

Merge r30218.

12:38 PM Changeset in webkit [30308] by mrowe@apple.com

3 edits
2 adds in branches/Safari-3-1-branch

Merge r30213.

12:37 PM Changeset in webkit [30307] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebKit/win

Merge r30206.

12:06 PM Changeset in webkit [30306] by ap@webkit.org

1 edit
1 delete in trunk/WebCore

Rubber-stamped by Darin.

Remove an obsolete WebCore readme file.

README: Removed.

11:46 AM Changeset in webkit [30305] by mrowe@apple.com

7 edits
4 adds in branches/Safari-3-1-branch

Merge r30195.

11:45 AM Changeset in webkit [30304] by mrowe@apple.com

3 edits
3 adds in branches/Safari-3-1-branch

Merge r30191.

11:45 AM Changeset in webkit [30303] by mrowe@apple.com

1 edit in branches/Safari-3-1-branch/WebCore/platform/sql/SQLiteDatabase.cpp

Merge r30190.

11:44 AM Changeset in webkit [30302] by mrowe@apple.com

7 edits in branches/Safari-3-1-branch/WebCore

Merge r30189.

11:44 AM Changeset in webkit [30301] by mrowe@apple.com

5 edits in branches/Safari-3-1-branch/WebCore

Merge r30184.

11:43 AM Changeset in webkit [30300] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebCore

Merge r30179.

11:43 AM Changeset in webkit [30299] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/JavaScriptCore

Merge r30177.

11:42 AM Changeset in webkit [30298] by mrowe@apple.com

2 edits
2 adds in branches/Safari-3-1-branch/LayoutTests

Merge r30176.

11:42 AM Changeset in webkit [30297] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebCore

Merge r30174.

11:41 AM Changeset in webkit [30296] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebCore

Merge r30173.

11:41 AM Changeset in webkit [30295] by mrowe@apple.com

13 edits
3 adds in branches/Safari-3-1-branch/WebCore

Merge r30172.

11:40 AM Changeset in webkit [30294] by mrowe@apple.com

3 edits
3 adds in branches/Safari-3-1-branch

Merge r30171.

10:29 AM Changeset in webkit [30293] by weinig@apple.com

13 edits in trunk/WebCore

Reviewed by Darin Adler.

Remove more uses of DeprecatedString in preparation of getting rid of it.

bridge/mac/WebCoreScriptDebugger.mm:
css/CSSCursorImageValue.cpp: (WebCore::isSVGCursorIdentifier): (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
css/CSSStyleSelector.h:
dom/Element.cpp: (WebCore::Element::dump): (WebCore::Element::formatForDebugger):
dom/Position.cpp: (WebCore::Position::debugPosition): (WebCore::Position::formatForDebugger):
dom/Range.cpp: (WebCore::Range::formatForDebugger):
dom/Text.cpp: (WebCore::Text::formatForDebugger):
editing/Selection.cpp: (WebCore::Selection::debugPosition): (WebCore::Selection::formatForDebugger):
editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::debugPosition):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::processToken): (WebCore::HTMLTokenizer::notifyFinished):
svg/SVGFontFaceElement.cpp: (WebCore::mapAttributeToCSSProperty):

10:25 AM Changeset in webkit [30292] by mrowe@apple.com

3 edits
4 adds in branches/Safari-3-1-branch

Merge r30162.

10:25 AM Changeset in webkit [30291] by alp@webkit.org

2 edits in trunk

2008-02-15 Alp Toker <alp@atoker.com>

Reviewed by Holger.

GTK+ configure script cleanups

Categorize the configuration summary printout.
Bump GTK+ requirement to 2.8.
Rename 'webkit_target' to just 'target'.
Don't check for pthread on Win32.

configure.ac:

10:24 AM Changeset in webkit [30290] by mrowe@apple.com

4 edits in branches/Safari-3-1-branch/JavaScriptCore

Merge r30158.

10:24 AM Changeset in webkit [30289] by mrowe@apple.com

21 edits
2 copies
15 adds
2 deletes in branches/Safari-3-1-branch

Merge r30157.

10:22 AM Changeset in webkit [30288] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebCore

Merge r30154.

10:22 AM Changeset in webkit [30287] by mrowe@apple.com

2 edits
4 adds in branches/Safari-3-1-branch

Merge r30153.

10:18 AM Changeset in webkit [30286] by mrowe@apple.com

3 edits in branches/Safari-3-1-branch/WebCore

Merge r30146.

10:04 AM Changeset in webkit [30285] by Adam Roben

2 edits in trunk/WebCore

bindings/scripts/CodeGenerator.pm: Touch this to force bindings to regenerate.

9:58 AM Changeset in webkit [30284] by Adam Roben

2 edits in branches/Safari-3-1-branch/LayoutTests

Remove MessageEvent output from window-properties.html since that interface will be disabled as well

Reviewed by Sam.

fast/dom/Window/window-properties-expected.txt:

9:56 AM Changeset in webkit [30283] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebKit/mac

Merge r30120.

9:56 AM Changeset in webkit [30282] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebKit/mac

Merge r30119.

9:55 AM Changeset in webkit [30281] by mrowe@apple.com

3 edits
4 adds in branches/Safari-3-1-branch

Merge r30116.

9:55 AM Changeset in webkit [30280] by mrowe@apple.com

1 edit in branches/Safari-3-1-branch/WebCore/css/CSSStyleSelector.cpp

Merge r30115.

9:54 AM Changeset in webkit [30279] by mrowe@apple.com

4 edits in branches/Safari-3-1-branch/WebCore/rendering

Merge r30114.

9:54 AM Changeset in webkit [30278] by mrowe@apple.com

1 edit in branches/Safari-3-1-branch/WebCore/css/CSSStyleSelector.cpp

Merge r30113.

9:54 AM Changeset in webkit [30277] by mrowe@apple.com

70 edits in branches/Safari-3-1-branch/WebCore

Merge r30112.

9:49 AM Changeset in webkit [30276] by Adam Roben

6 edits in trunk

Mac build fix

JavaScriptCore:

Make JavaScriptCore's FEATURE_DEFINES match WebCore's

Reviewed by Mark.

Configurations/JavaScriptCore.xcconfig:

WebKit/mac:

Make WebKit's FEATURE_DEFINES match WebCore's

Reviewed by Mark.

Configurations/WebKit.xcconfig:

WebKitTools:

Fix a typo that broke the Mac build

Reviewed by Mark.

Scripts/build-webkit:

9:13 AM Changeset in webkit [30275] by mrowe@apple.com

6 edits in branches/Safari-3-1-branch

Merge r30105.

9:12 AM Changeset in webkit [30274] by mrowe@apple.com

8 edits in branches/Safari-3-1-branch/WebCore

Merge r30104.

9:12 AM Changeset in webkit [30273] by mrowe@apple.com

3 edits
2 adds in branches/Safari-3-1-branch

Merge r30101.

9:04 AM Changeset in webkit [30272] by Adam Roben

2 edits in trunk/WebCore

Try to fix Qt/GTK+ builds

WebCore.pro: Remove MessageEvent.{idl,cpp} from the unconditional parts of this file.

8:51 AM Changeset in webkit [30271] by Adam Roben

4 edits in branches/Safari-3-1-branch/LayoutTests

Disable postMessage tests since postMessage is disabled

Reviewed by Mitz.

fast/dom/Window/window-properties-expected.txt: Updated result.
platform/mac/Skipped: Skip tests that depend on postMessage
platform/win/Skipped: Ditto.

8:36 AM Changeset in webkit [30270] by Adam Roben

8 edits in trunk

Turn on cross-document messaging support by default

top level:

Turn on cross-document messaging support by default

Reviewed by Darin.

configure.ac:

WebCore:

Turn on cross-document messaging support by default

Reviewed by Darin.

Configurations/WebCore.xcconfig:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:

WebKitTools:

Turn on cross-document messaging support by default

Reviewed by Darin.

Scripts/build-webkit:

8:36 AM Changeset in webkit [30269] by Adam Roben

17 edits in trunk

Conditionalize cross-document messaging support

top level:

Conditionalize cross-document messaging support

The cross-document messaging parts of HTML 5 are in flux and we want
ports to be able to turn off the support as needed.

Note that the support is turned off by default right now. A subsequent
commit will turn it on by default.

Reviewed by Darin.

configure.ac:

WebCore:

Conditionalize cross-document messaging support

The cross-document messaging parts of HTML 5 are in flux and we want
ports to be able to turn off the support as needed.

Note that the support is turned off by default right now. A subsequent
commit will turn it on by default.

Reviewed by Darin.

GNUmakefile.am:
WebCore.vcproj/build-generated-files.sh:
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
bindings/js/JSEventCustom.cpp: (WebCore::toJS):
dom/Event.cpp: (WebCore::Event::isMessageEvent):
dom/Event.h:
dom/MessageEvent.cpp:
dom/MessageEvent.h:
dom/MessageEvent.idl:
page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage):
page/DOMWindow.h:
page/DOMWindow.idl:

WebKitTools:

Conditionalize cross-document messaging support

The cross-document messaging parts of HTML 5 are in flux and we want
ports to be able to turn off the support as needed.

Note that the support is turned off by default right now. A subsequent
commit will turn it on by default.

Reviewed by Darin.

Scripts/build-webkit:

7:18 AM Changeset in webkit [30268] by Darin Adler

2 edits in trunk/WebKit/win

Reviewed by Adam.

quick fix for a problem causing an assertion on launch

WebFrame.cpp: (WebFrame::loadData): Make an empty KURL even if the BSTR is null. Later we might want to rethink this.

3:41 AM Changeset in webkit [30267] by alp@webkit.org

3 edits in trunk/WebKit/gtk

2008-02-15 Alp Toker <alp@atoker.com>

Fix the GTK+ build following breakage introduced in r30243.

WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::objectContentType):

2:53 AM Changeset in webkit [30266] by mrowe@apple.com