Context Navigation

WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::WebInspectorClient): Removed m_orignalWebViewWndProc member. (WebInspectorClient::attachWindow): Register as a listener with WindowMessageBroadcaster instead of subclassing. (WebInspectorClient::detachWindow): Deregister as a listener with WindowMessageBroadcaster instead of unsubclassing. (WebInspectorClient::windowReceivedMessage): Renamed from SubclassedWebViewWndProc. Also added a missing break statement after the call to onWebViewWindowPosChanging.
WebCoreSupport/WebInspectorClient.h:

4:01 PM Changeset in webkit [30911] by Adam Roben

3 edits in trunk/WebKit/win

Make the node highlight not obscure the tab bar when it first appears

Reviewed by Darin.

WebNodeHighlight.cpp: (WebNodeHighlight::onWebViewWindowPosChanged): Added. Listens for changes to the WebView's size and resizes the highlight window to match. (WebNodeHighlight::onRootWindowPosChanged): Added. Listens for changes to the WebView's root window's position and moves the highlight window to match. (WebNodeHighlight::windowReceivedMessage): Call onWebViewWindowPosChanged/onRootWindowPosChanged as appropriate.
WebNodeHighlight.h:

4:00 PM Changeset in webkit [30910] by Adam Roben

3 edits in trunk/WebKit/win

Fix Bug 14254: Inspector node highlight applied to all tabs

<http://bugs.webkit.org/show_bug.cgi?id=14254>
<rdar://problem/5322306>

WebNodeHighlight now listens for the WM_SHOWWINDOW message being sent
to the inspected WebView so that it can hide/show itself as the
WebView is hidden/shown.

Reviewed by Anders.

WebNodeHighlight.cpp: (WebNodeHighlight::~WebNodeHighlight): Remove ourselves as a listener for our inspected WebView's window's messages. (WebNodeHighlight::show): Add ourselves as a listener for our inspected WebView's window's messages. (WebNodeHighlight::onWebViewShowWindow): Added. Hide ourselves when the WebView hides, show ourselves when the WebView is shown. (WebNodeHighlight::windowReceivedMessage): Added a separate switch statement to handle the inspected WebView's window's messages.
WebNodeHighlight.h:

1:36 PM Changeset in webkit [30909] by Darin Adler

2 edits in trunk/WebCore

Reviewed by Adam.

DerivedSources.make: Put the list of DOM classes into its own variable, and generate the JavaScript bindings and Objective-C bindings dependencies from that. Added some separators to make it a little easier to see the sections of the file. Moved all the Mac-specific rules (except for the SVG conditional part) down to the bottom of the file in a separate section.

11:06 AM ProposedWebInspectorUIRefresh edited by Adam Roben

Added a section about the Scripts view with a new mockup from Tim (diff)

11:05 AM New Inspector - Scripts.png attached to ProposedWebInspectorUIRefresh by Adam Roben

Mockup of the Inspector's Scripts view

10:47 AM Changeset in webkit [30908] by Adam Roben

2 edits in trunk/WebCore

Windows build fix

WebCore.vcproj/WebCore.vcproj: Make sure all Cairo files are excluded from all three CG-based configurations: Debug, Release, and Debug_Internal.

Mar 8, 2008:

11:59 PM Changeset in webkit [30907] by Darin Adler

1 edit in trunk/JavaScriptCore/wtf/OwnPtrWin.cpp

Fix stray executable bit.

11:00 PM Changeset in webkit [30906] by mrowe@apple.com

2 edits in trunk/WebCore

Attempt to fix the Qt build.

10:48 PM Changeset in webkit [30905] by oliver@apple.com

5 edits in trunk

Bug 16516: canvas image patterns stop working with some transformations

Reviewed by Sam W.

Simple fix. We used x/yStep of FLT_MAX to fake a no-repeat-x/y pattern
with CG. However any transforms involving FLT_MAX immediately get
consumed by the introduced floating point error. yStep had already been
clamped to a much smaller arbitrary value, and this patch makes us use
that clamp value for xStep as well.

6:39 PM Changeset in webkit [30904] by oliver@apple.com

3 edits
3 adds in trunk

Bug 17728: Canvas.createPattern with null repeat argument throws an exception

Reviewed by Mitz

Trivial fix, we were calling toString on null which produces the string "null",
we just needed to switch to using valueToStringWithNullCheck rather than
JSValue::toString directly

Test: fast/canvas/canvas-pattern-behaviour.html

5:57 PM Changeset in webkit [30903] by mrowe@apple.com

2 edits in trunk/WebKitTools

2008-03-08 Julien Chaffraix <julien.chaffraix@gmail.com>

Reviewed by Mark Rowe.

DRT build fix for Tiger.

DumpRenderTree/mac/DumpRenderTreeMac.h: Define BUILDING_ON_TIGER.

5:57 PM Changeset in webkit [30902] by mrowe@apple.com

11 edits in trunk

2008-03-08 Mark Rowe <mrowe@apple.com>

Reviewed by Darin Adler.

Fix 64-bit build with GCC 4.2.

bindings/objc/WebScriptObject.mm: Use NSUInteger in place of unsigned where required.
platform/mac/SharedBufferMac.mm: Ditto.

2008-03-08 Mark Rowe <mrowe@apple.com>

Reviewed by Darin Adler.

Fix 64-bit build with GCC 4.2.

DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
History/WebHistoryItem.mm: Ditto.
Misc/WebElementDictionary.mm: Ditto.
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the variable being unused in 64-bit.
WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
WebView/WebHTMLView.mm: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required. (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.

3:10 PM Changeset in webkit [30901] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

fix garbage in transparent areas in canvas.toDataURL results

platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::toDataURL): Clear the bitmap context before painting the canvas image onto it.

6:09 AM Changeset in webkit [30900] by Darin Adler

13 edits in trunk

WebCore:

Reviewed by Adele.

eliminate custom highlight methods from WebCoreFrameBridge

page/Chrome.cpp: (WebCore::ChromeClient::customHighlightRect): Added. (WebCore::ChromeClient::paintCustomHighlight): Added.
page/ChromeClient.h: Added custom highlight functions.
page/Frame.h: Removed custom highlight functions.
page/mac/FrameMac.mm: Ditto.
page/mac/WebCoreFrameBridge.h: Removed custom highlight methods.
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCustomHighlight): Changed code to use the ChromeClient instead of WebCoreFrameBridge to do the custom highlight.
rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight): Ditto.
rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow): Ditto. (WebCore::RootInlineBox::paintCustomHighlight): Ditto.

WebKit/mac:

Reviewed by Adele.

eliminate custom highlight methods from WebCoreFrameBridge

WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
WebCoreSupport/WebChromeClient.mm: (WebChromeClient::customHighlightRect): Moved code here from bridge. (WebChromeClient::paintCustomHighlight): Ditto.
WebCoreSupport/WebFrameBridge.mm: Removed code here.

6:05 AM Changeset in webkit [30899] by Darin Adler

2 edits in trunk/LayoutTests

platform/win/Skipped: Fixed some typos (stray "s" characters).

12:09 AM Changeset in webkit [30898] by Stephanie Lewis

4 edits in trunk

2008-03-07 Stephanie Lewis <Stephanie Lewis>

Reviewed by Oliver.

Fix Windows build.

platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::toDataURL):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed