⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 10, 2008:

11:28 PM Changeset in webkit [30953] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • Windows build fix
  • kjs/function.cpp: (KJS::decode): Initialize variable.
9:42 PM Changeset in webkit [30952] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Sam.

<rdar://problem/5779984> REGRESSION (r30391): GMail: Safari won't display the Edit Link dialog

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): Fixed a typo. The code was only comparing the first character of the prefix to the first character of the property name.

LayoutTests:

Reviewed by Sam.


<rdar://problem/5779984> REGRESSION (r30391): GMail: Safari won't display the Edit Link dialog

  • editing/pasteboard/5780697-2-expected.txt: Added.
  • editing/pasteboard/5780697-2.html: Added.
  • editing/selection/5779984-1-expected.txt: Added.
  • editing/selection/5779984-1.html: Added.
8:40 PM Changeset in webkit [30951] by Beth Dakin
  • 2 edits in trunk/WebCore

Reviewed by Beth.

Hold off on initializing the frame to avoid the RenderView getting
a null FrameView. This could potentially cause problems.

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
5:48 PM Changeset in webkit [30950] by Darin Adler
  • 2 edits in trunk/WebCore
  • try to fix Qt build
  • bridge/qt/qt_runtime.cpp: (KJS::Bindings::convertQVariantToValue): Change KJS::UChar to UChar.
5:45 PM Changeset in webkit [30949] by Darin Adler
  • 15 edits in trunk/WebCore

Reviewed by Antti.

We now mark all links on a page as "changed" at the appropriate times.

  • WebCore.base.exp: Update since I made completeURL be a const member function.
  • css/CSSStyleSelector.cpp: Got rid of some unneeded globals that could be turned into locals. Also changed some static data members to file-scoped globals with internal linkage. Renamed the globals to get rid of the m_ prefix. Changed the prefix on m_styleNotYetAvailable to s_styleNotYetAvailable. (WebCore::CSSStyleSelector::CSSStyleSelector): Updated for name changes. (WebCore::parseUASheet): Tweak the comment. (WebCore::CSSStyleSelector::loadDefaultStyle): Updated for name changes and to use local variables instead of globals where possible. (WebCore::CSSStyleSelector::checkPseudoState): Made this a member function so it can store the link in a hash. Also changed it to have a return value instead of having it modify a global variable. Added code to put the hash into a set so we can tell later if this is one of the links that affects this page. (WebCore::CSSStyleSelector::canShareStyleWithElement): Updated for the change to checkPseudoState. (WebCore::CSSStyleSelector::matchUARules): Updated for name changes. (WebCore::CSSStyleSelector::styleForElement): Ditto. (WebCore::CSSStyleSelector::adjustRenderStyle): Ditto. (WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Changed code to read the SVG style sheet to use a boolean global and put it right here in the function since this is the only code that needs to know about it. (WebCore::CSSStyleSelector::checkOneSelector): Updated for name changes. (WebCore::colorForCSSValue): Moved code inside the function that is not needed anywhere else. (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Updaed for the change to checkPseudoState. (WebCore::CSSStyleSelector::allVisitedStateChanged): Added. Calls setChanged on all links if there were any in the set. (WebCore::CSSStyleSelector::visitedStateChanged): Added. Calls setChanged on all links if the one that changed is in the set.
  • css/CSSStyleSelector.h: Removed unused StyleSelector class and State enum. Made CSSStyleSelector derive from Noncopyable. Made lots of member functions private that didn't need to be public, and removed others that could be made into non-member functions. Changed pseudoStyleRulesForElement to take a const String& instead of a StringImpl*. Added new allVisitedStateChanged and visitedStateChanged functions. Got rid of unneeded friend declarations.
  • dom/Document.cpp: (WebCore::Document::completeURL): Made const. (WebCore::findSlashDotDotSlash): Moved here from PageGroup. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::containsColonSlashSlash): (WebCore::cleanPath): Ditto. (WebCore::matchLetter): Ditto. (WebCore::needsTrailingSlash): Ditto. (WebCore::Document::visitedLinkHash): Moved this here from PageGroup. This is the poor-man's completeURL function. The idea of putting it here is that this way it can be alongside the real completeURL function. Later we should figure out a way to make this function share more code with the real thing and match behavior.
  • dom/Document.h: Marked completeURL function const. Added visitedLinkHash function.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::getMatchedCSSRules): Updated for change to CSSStyleSelector.
  • page/Page.cpp: (WebCore::Page::allVisitedStateChanged): Added. Calls allVisitedStateChanged on all style selectors. (WebCore::Page::visitedStateChanged): Ditto.
  • page/Page.h: Added the above functions.
  • page/PageGroup.cpp: (WebCore::PageGroup::isLinkVisited): Changed to take a visitedLinkHash parameter. The CSSStyleSelector now handles actually computing the hash, and it does so by calling code in Document. (WebCore::PageGroup::addVisitedLink): Refactored so the two overloaded copies share a bit more code. Added code that calls visitedStateChanged if a new link was added. (WebCore::PageGroup::removeVisitedLinks): Added code to call allVisitedStateChanged if any visited links are removed.
  • page/PageGroup.h: Include StringHash.h instead of having the AlreadyHashed struct definition here.
  • platform/text/StringHash.h: (WebCore::CaseFoldingHash::hash): Tweaked to make this a bit more consistent with the StringImpl::computeHash function, using the same technique for avoiding 0. (WebCore::AlreadyHashed::hash): Added. Was formerly in PageGroup.h. (WebCore::AlreadyHashed::avoidDeletedValue): Added. Was formerly in PageGroup.cpp.
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::isStyleAvailable): Changed to use an inline function instead of getting directly at a data member so the data member could be made private.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::scrollToAnchor): Added call to updateHistoryForAnchorScroll. (WebCore::FrameLoader::updateHistoryForAnchorScroll): Added.
  • loader/FrameLoader.h: Added updateHistoryForAnchorScroll.
5:36 PM Changeset in webkit [30948] by eric@webkit.org
  • 2 edits in trunk/WebKit/win

No review, build fix only.

Speculative fix for Windows build, use ::UChar instead of KJS::UChar

  • WebScriptCallFrame.cpp: (WebScriptCallFrame::valueForVariable): (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
5:14 PM Changeset in webkit [30947] by Adam Roben
  • 4 edits in trunk/WebCore

Part of Bug 17224: DOM nodes/attributes should be editable

<​http://bugs.webkit.org/show_bug.cgi?id=17224>
<rdar://problem/5732825>

This patch makes DOM attributes editable via double-click.

Reviewed by Tim.

  • page/inspector/DocumentPanel.js: (WebInspector.DOMNodeTreeElement.onmousedown): Don't do anything if we're being edited, since we want default editing behaviors to work. (WebInspector.DOMNodeTreeElement.ondblclick): Try to start editing before doing anything else. (WebInspector.DOMNodeTreeElement._startEditing): Added. Currently only lets you edit attributes. (WebInspector.DOMNodeTreeElement._attributeEditingCommitted): Added. Uses a scratch element to get the new attribute(s) parsed, then sets the attribute(s) on the node in the inspected document. (WebInspector.DOMNodeTreeElement._attributeEditingCancelled): Added. (WebInspector.DOMNodeTreeElement._updateTitle): Added. Refreshes the representation of the node in the Inspector's DOM tree to reflect the node's current state.
  • page/inspector/inspector.css: Made the .editing class apply everywhere.
  • page/inspector/utilities.js: (nodeTitleInfo): Changed to surround attribute name/value pairs in a webkit-html-attribute span so that we can easily edit the pair as a whole.
4:39 PM Changeset in webkit [30946] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

2008-03-10 Brent Fulgham <​bfulgham@gmail.com>

Windows build fix

Reviewed by Adam.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Set the PATH to include Cygwin before running touch.
4:02 PM Changeset in webkit [30945] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Fix 64-bit builds.

Reviewed by Stephanie.

WebCore.exp only gets generated once for both 32-bit and 64-bit builds,
so we must exclude the _NPN symbols when creating WebCore.LP64.exp.

  • WebCore.xcodeproj/project.pbxproj: Reverted build phase shell code to r30826 to remove _NPN symbols from 64-bit builds in WebCore.LP64.exp.
3:57 PM Changeset in webkit [30944] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

Reviewed by NOBODY.

Build fix for JSC on windows.

  • API/JSStringRefCF.cpp: (JSStringCreateWithCFString):
  • kjs/function.cpp: (KJS::decode):
  • kjs/nodes2string.cpp: (KJS::escapeStringForPrettyPrinting):
3:44 PM Changeset in webkit [30943] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

No review, build fix only.

Attempt to fix the windows build?

  • kjs/ustring.h: change unsigned short to UChar
3:06 PM Changeset in webkit [30942] by eric@webkit.org
  • 28 edits in trunk

Reviewed by Darin.

Remove KJS::UChar, use ::UChar instead
​http://bugs.webkit.org/show_bug.cgi?id=17017

To functional changes, thus no tests.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::hasCSSPropertyNamePrefix): (WebCore::cssPropertyName):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::windowProtoFuncAToB): (WebCore::windowProtoFuncBToA):
  • bindings/js/JSSVGPODTypeWrapper.h:
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
  • bridge/objc/objc_utility.mm: (KJS::Bindings::throwError):
  • dom/Document.cpp: (WebCore::Document::parseQualifiedName):
  • platform/text/AtomicString.cpp: (WebCore::AtomicString::add):
  • platform/text/String.cpp: (WebCore::String::String): (WebCore::String::operator Identifier): (WebCore::String::operator UString):
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decode):
  • svg/SVGAnimatedTemplate.h:
11:58 AM Changeset in webkit [30941] by sfalken@apple.com
  • 3 edits in trunk/WebKit/win

Fix build break caused by r30920.


Serialize remaining dependent builds by adding dependencies.
Visual Studio per-vcproj parallelization doesn't add a lot of value
since so many of our builds are dependent - this just enforces that.
We do our parallelization via pdevenv, which works much better.

  • WebKit.vcproj/WebKit.sln:
  • WebKit.vcproj/WebKit.submit.sln:
11:25 AM Changeset in webkit [30940] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-03-10 Xan Lopez <​xan@gnome.org>

Reviewed by Alp Toker.

Fix "missing braces" compiler warning.

  • webkit/webkitwebview.cpp:
10:37 AM Changeset in webkit [30939] by Darin Adler
  • 12 edits in trunk

WebCore:

Reviewed by Sam.

  • eliminate keyboard UI mode method from WebCoreFrameBridge
  • page/ChromeClient.h: Added keyboardUIMode function. (WebCore::ChromeClient::keyboardUIMode): Ditto.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToAllControls): Call chrome client function instead of bridge function.
  • page/mac/WebCoreFrameBridge.h: Removed keyboardUIMode method, and other unused ones.
  • WebCore.xcodeproj/project.pbxproj: Allowed Xcode to change the project. Do not try to fight the Xcode.

WebKit/mac:

Reviewed by Sam.

  • eliminate keyboard UI mode method from WebCoreFrameBridge
  • WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
  • WebCoreSupport/WebFrameBridge.h: Removed unused things, including the fields for keyboard UI mode.
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini method. (-[WebFrameBridge finalize]): Ditto.
  • WebView/WebView.mm: Moved the keyboard mode code in here. (-[WebView _close]): Remove observer from the distributed notification center as well as the normal one. (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved here from the bridge. (-[WebView _keyboardUIMode]): Ditto.
  • WebView/WebViewInternal.h: Added _keyboardUIMode method.
10:36 AM Changeset in webkit [30938] by weinig@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Beth Dakin.

Add Tiger specific results for toDataURL-supportedTypes.html as the image
encoders have slightly changed between releases.

  • platform/mac-tiger/fast/canvas: Added.
  • platform/mac-tiger/fast/canvas/toDataURL-supportedTypes-expected.txt: Added.
10:29 AM Changeset in webkit [30937] by Darin Adler
  • 2 edits in trunk/WebCore
  • oops, forgot to save last couple changes from the editor
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::markDOMObjectWrapper): Tweaked a tiny bit. (WebCore::JSDOMWindow::mark): Sorted alphabetically.
10:26 AM Changeset in webkit [30936] by Darin Adler
  • 4 edits in trunk/WebCore

Reviewed by Geoff.

  • fix failing regression test (window.navigator is getting garbage collected and thus losing its custom properties)
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::markDOMObject): Added helper function. (WebCore::JSDOMWindow::mark): Added. Marks the wrappers for all the objects that hang off the window object.
  • page/DOMWindow.h: (WebCore::DOMWindow::optionalScreen): Added so we can get the Screen object without creating it if it's already there. (WebCore::DOMWindow::optionalSelection): Ditto. (WebCore::DOMWindow::optionalHistory): Ditto. (WebCore::DOMWindow::optionalLocationbar): Ditto. (WebCore::DOMWindow::optionalMenubar): Ditto. (WebCore::DOMWindow::optionalPersonalbar): Ditto. (WebCore::DOMWindow::optionalScrollbars): Ditto. (WebCore::DOMWindow::optionalStatusbar): Ditto. (WebCore::DOMWindow::optionalToolbar): Ditto. (WebCore::DOMWindow::optionalConsole): Ditto. (WebCore::DOMWindow::optionalNavigator): Ditto.
  • page/DOMWindow.idl: Added the CustomMarkFunction flag. Sorted the flags in alphabetical order since there are a lot of them.
10:01 AM Changeset in webkit [30935] by Darin Adler
  • 9 edits in trunk

WebCore:

Reviewed by Sam.

  • eliminate Java applet methods from WebCoreFrameBridge
  • loader/FrameLoaderClient.h: Added a javaApplet function.
  • page/mac/FrameMac.mm: (WebCore::Frame::createScriptInstanceForWidget): Streamlined the code. Use the loader client instead of the bridge to get the applet.
  • page/mac/WebCoreFrameBridge.h: Removed the getAppletInView and pollForAppletInView methods. Also removed other unused things.

WebKit/mac:

Reviewed by Sam.

  • eliminate Java applet methods from WebCoreFrameBridge
  • WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
  • WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including the ones that load Java applets.
  • WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
  • WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
9:33 AM Changeset in webkit [30934] by Darin Adler
  • 2 edits in trunk/WebKitTools

Reviewed and landed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=17581
Bug 17581: Use of uninitialized value in string ne at WebKitTools/Scripts/run-webkit-tests line 1576.

Remove the previous warning which occurs when the --random option is used.

  • Scripts/run-webkit-tests: verify that $component[0] is defined before checking for its inequality
9:28 AM Changeset in webkit [30933] by Darin Adler
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Eric, landed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=16095
Move GraphicsContextPrivate to its own header file.

Moves GraphicsContextState and GraphicsContextPrivate to its
own header

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContextPrivate.h: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
9:25 AM Changeset in webkit [30932] by Darin Adler
  • 8 edits in trunk

WebCore:

Reviewed and landed by Darin.

bug 12182 : XMLHttpRequest should raise SECURITY_ERR for same-origin policy violations

Removed reference to PERMISSION_DENIED (previous non standard exception) and replaced it
by DOM exception SECURITY_ERR. Updated XMLHttpRequest::open to raise SECURITY_ERR.

  • bindings/js/kjs_binding.cpp: (WebCore::setDOMException): Removed PERMISSION_DENIED code.
  • dom/ExceptionCode.cpp: Added SECURITY_ERR exception.
  • dom/ExceptionCode.h: Ditto.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open): Returns SECURITY_ERR now.
  • xml/XMLHttpRequestException.h: Removed PERMISSION_DENIED.

LayoutTests:

Reviewed and landed by Darin.

bug 12182 : XMLHttpRequest should raise SECURITY_ERR for same-origin policy violations

  • http/tests/xmlhttprequest/exceptions-expected.txt: Updated results
9:17 AM Changeset in webkit [30931] by Adam Roben
  • 3 edits in trunk/WebCore

Refactor CSS editing code so we can share it with DOM editing

Add WebInspector.startEditing, which takes the element to be edited, a
committedCallback, a cancelledCallback, and a context parameter. This
function takes care of setting up the element for editing, and calls
either the cancelledCallback or committedCallback when editing ends.

Reviewed by Tim.

(WebInspector.StylePropertyTreeElement.editingEnded):

  • Renamed from endEditing
  • Removed code now handled by WebInspector.startEditing

(WebInspector.StylePropertyTreeElement.editingCancelled):

  • Renamed from cancelEditing
  • Changed parameters to match WebInspector.startEditing's cancelledCallback

(WebInspector.StylePropertyTreeElement.editingCommitted):

  • Renamed from commitEditing
  • Changed parameters to match WebInspector.startEditing's committedCallback
  • page/inspector/inspector.js: (WebInspector.changeFocus): Changed a call to firstParentWithClassName to firstParentOrSelfWithClassName so that if the focusable element itself is the target it will be recognized. I don't know why this change wasn't needed before this. (WebInspector.isBeingEdited): Added. (WebInspector.startEditing): Added.
9:17 AM Changeset in webkit [30930] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Pick up generated source files out of $(WebKitOutputDir) instead of hard-coding WebKitBuild.
9:15 AM Changeset in webkit [30929] by Darin Adler
  • 2 edits in trunk/WebCore
  • DerivedSources.make: Merge plug-in-related changes with the new way of handling autogenerated DOM classes.
8:38 AM Changeset in webkit [30928] by ap@webkit.org
  • 5 edits
    3 adds in trunk

Reviewed, tweaked and landed by Alexey.

We didn't have a fallback to frame encoding in the case of loading a script via
changing its src attribute.

Test: fast/dom/HTMLScriptElement/script-decoding-error-after-setting-src.html

  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): Use a helper function to get proper charset for correct decoding of script content. (WebCore::HTMLScriptElement::insertedIntoDocument): (WebCore::HTMLScriptElement::scriptCharset): A helper function for getting proper charset for the script (as much as can be determined prior to loading it).
  • html/HTMLScriptElement.h:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Use a helper function to get proper charset for correct decoding of script content.
6:59 AM Changeset in webkit [30927] by Simon Hausmann
  • 7 edits in trunk/WebCore

2008-03-10 Simon Hausmann <Simon Hausmann>

Reviewed by Lars.

Fix reference counting of returned MimeType and Plugin objects
created in the array wrappers.

5:29 AM Changeset in webkit [30926] by Simon Hausmann
  • 2 edits in trunk/WebCore

Wx linking fix.

Added missing stubs for PluginData.

5:20 AM Changeset in webkit [30925] by Simon Hausmann
  • 2 edits in trunk/WebCore

Windows build fix that I forgot to merge earlier ;(

Forward declare Page as class, not struct.

5:09 AM Changeset in webkit [30924] by Simon Hausmann
  • 2 edits in trunk/WebCore

Attempt to fix the Wx build.

4:52 AM Changeset in webkit [30923] by Simon Hausmann
  • 45 edits
    30 adds
    9 deletes in trunk

2008-03-07 Simon Hausmann <Simon Hausmann>

​http://bugs.webkit.org/show_bug.cgi?id=16815

Reviewed by Darin.

Done with Lars.

WebCore:

Ported the manually written JS bindings of window.navigator,
window.navigator.plugins and window.navigator.mimeTypes to
auto-generated bindings.

Moved the globally cached plugin and mimetype information to a
per WebCore::Page shared PluginData structure.

Implemented window.navigator.plugins.refresh() in a
platform-independent way.

LayoutTests:

Added a testcase for ​http://bugs.webkit.org/show_bug.cgi?id=16815

WebKit/qt:

Replaced the QWebObjectPlugin interfaces with QWebPluginFactory.

WebKit/mac:

Simplified WebViewFactory's refreshPlugins method to only refresh the
plugins and not reload the frames anymore since that's now done in a
platform independent manner by WebCore::Page.

Also removed the now unused pluginNameForMIMEType and
pluginSupportsMIMEType methods.

WebKitTools/DumpRenderTree/qt:

Ported the netscape test plugin to QWebPluginFactory.

4:29 AM Changeset in webkit [30922] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-03-10 Simon Hausmann <Simon Hausmann>

Reviewed by Holger.

Replace two printfs() in the Qt port with notImplemented().

4:23 AM Changeset in webkit [30921] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-03-10 Simon Hausmann <Simon Hausmann>

Reviewed by Alp.

Compilation fix with gcc 4.3: Include stdio.h for printf.

Mar 8, 2008:

10:35 PM Changeset in webkit [30920] by sfalken@apple.com
  • 18 edits in trunk

JavaScriptCore:

Stop Windows build if an error occurs in a prior project.

Rubber stamped by Darin.

WebCore:

Stop Windows build if an error occurs in a prior project.

Rubber stamped by Darin.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

WebKit/win:

Stop Windows build if an error occurs in a prior project.

Rubber stamped by Darin.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/InterfacesGenerated.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

WebKitTools:

Stop Windows build if an error occurs in a prior project.

Rubber stamped by Darin.

  • Drosera/win/Drosera.vcproj/Drosera.vcproj:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
8:10 PM Changeset in webkit [30919] by Darin Adler
  • 3 edits in trunk/WebCore
  • DerivedSources.make: Third try at fixing the build.
  • bindings/js/JSRGBColor.cpp: And touching this file.
8:03 PM Changeset in webkit [30918] by Darin Adler
  • 2 edits in trunk/WebCore
  • DerivedSources.make: One *more* try at fixing the build.
7:58 PM Changeset in webkit [30917] by Darin Adler
  • 2 edits in trunk/WebCore
  • DerivedSources.make: One more try at fixing the build.
7:53 PM Changeset in webkit [30916] by Darin Adler
  • 2 edits in trunk/WebCore
  • DerivedSources.make: Re-land the change, fixed, and with an attempt to fix the bots by removing the incorrect file.
7:44 PM Changeset in webkit [30915] by alp@webkit.org
  • 2 edits in trunk

2008-03-09 Alp Toker <​alp@atoker.com>

GTK+ build fix for r30913.

Use UNICODE_CFLAGS for C++ sources as well as C sources.

  • GNUmakefile.am:
5:49 PM Changeset in webkit [30914] by oliver@apple.com
  • 2 edits in trunk/WebCore

Roll out r30909 -- it breaks the build and is a non-trivial fix (according to weinig)

RS=Mark Rowe

5:49 PM Changeset in webkit [30913] by alp@webkit.org
  • 5 edits in trunk

2008-03-09 J?rg Billeter <​j@bitron.ch>

Reviewed by Alp Toker.

Conditionalise ICU for Unicode in the GTK+ port.

4:01 PM Changeset in webkit [30912] by Adam Roben
  • 3 edits in trunk/WebKit/win

Make WebInspectorClient use WindowMessageBroadcaster instead of manual subclassing

Reviewed by Darin.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::WebInspectorClient): Removed m_orignalWebViewWndProc member. (WebInspectorClient::attachWindow): Register as a listener with WindowMessageBroadcaster instead of subclassing. (WebInspectorClient::detachWindow): Deregister as a listener with WindowMessageBroadcaster instead of unsubclassing. (WebInspectorClient::windowReceivedMessage): Renamed from SubclassedWebViewWndProc. Also added a missing break statement after the call to onWebViewWindowPosChanging.
  • WebCoreSupport/WebInspectorClient.h:
4:01 PM Changeset in webkit [30911] by Adam Roben
  • 3 edits in trunk/WebKit/win

Make the node highlight not obscure the tab bar when it first appears

Reviewed by Darin.

  • WebNodeHighlight.cpp: (WebNodeHighlight::onWebViewWindowPosChanged): Added. Listens for changes to the WebView's size and resizes the highlight window to match. (WebNodeHighlight::onRootWindowPosChanged): Added. Listens for changes to the WebView's root window's position and moves the highlight window to match. (WebNodeHighlight::windowReceivedMessage): Call onWebViewWindowPosChanged/onRootWindowPosChanged as appropriate.
  • WebNodeHighlight.h:
4:00 PM Changeset in webkit [30910] by Adam Roben
  • 3 edits in trunk/WebKit/win

Fix Bug 14254: Inspector node highlight applied to all tabs

<​http://bugs.webkit.org/show_bug.cgi?id=14254>
<rdar://problem/5322306>

WebNodeHighlight now listens for the WM_SHOWWINDOW message being sent
to the inspected WebView so that it can hide/show itself as the
WebView is hidden/shown.

Reviewed by Anders.

  • WebNodeHighlight.cpp: (WebNodeHighlight::~WebNodeHighlight): Remove ourselves as a listener for our inspected WebView's window's messages. (WebNodeHighlight::show): Add ourselves as a listener for our inspected WebView's window's messages. (WebNodeHighlight::onWebViewShowWindow): Added. Hide ourselves when the WebView hides, show ourselves when the WebView is shown. (WebNodeHighlight::windowReceivedMessage): Added a separate switch statement to handle the inspected WebView's window's messages.
  • WebNodeHighlight.h:
1:36 PM Changeset in webkit [30909] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Adam.

  • DerivedSources.make: Put the list of DOM classes into its own variable, and generate the JavaScript bindings and Objective-C bindings dependencies from that. Added some separators to make it a little easier to see the sections of the file. Moved all the Mac-specific rules (except for the SVG conditional part) down to the bottom of the file in a separate section.
11:06 AM ProposedWebInspectorUIRefresh edited by Adam Roben
Added a section about the Scripts view with a new mockup from Tim (diff)
11:05 AM New Inspector - Scripts.png attached to ProposedWebInspectorUIRefresh by Adam Roben
Mockup of the Inspector's Scripts view
10:47 AM Changeset in webkit [30908] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Make sure all Cairo files are excluded from all three CG-based configurations: Debug, Release, and Debug_Internal.
Note: See TracTimeline for information about the timeline view.