Context Navigation

← Previous Period
Next Period →

Timeline

Mar 18, 2008:

11:17 PM Changeset in webkit [31148] by oliver@apple.com

5 edits in trunk

Bug 17929: Incorrect decompilation with |const|, comma
http://bugs.webkit.org/show_bug.cgi?id=17929

Reviewed by Mark Rowe

There were actually two bugs here. First we weren't correctly handling const
nodes with multiple declarations. The second issue was caused by us not
giving the correct precedence to the initialisers.

9:23 PM Changeset in webkit [31147] by Darin Adler

17 edits in trunk

JavaScriptCore:

2008-03-18 Darin Adler <Darin Adler>

Reviewed by Maciej.

Speed up JavaScript built-in properties by changing the hash table to take advantage of the identifier objects

5% speedup for Acid3 test 26

JavaScriptCore.exp: Updated.
kjs/create_hash_table: Compute size of hash table large enough so that there are no collisions, but don't generate the hash table.
kjs/identifier.h: Made the add function that returns a PassRefPtr public.
kjs/lexer.cpp: (KJS::Lexer::lex): Updated for change to HashTable interface.
kjs/lookup.cpp: (KJS::HashTable::changeKeysToIdentifiers): Added. Finds the identifier for each property so the equality comparision can be done with pointer comparision.
kjs/lookup.h: Made the key be a union of char* with UString::Rep* so it can hold identifiers. Added a keysAreIdentifiers flag to the HashTable. Changed the Lookup functions to be member functions of HashTable instead.
kjs/object.cpp: (KJS::JSObject::deleteProperty): Update for change to HashTable. (KJS::JSObject::findPropertyHashEntry): Ditto. (KJS::JSObject::getPropertyAttributes): Ditto. (KJS::JSObject::getPropertyNames): Ditto.

WebCore:

2008-03-18 Darin Adler <Darin Adler>

Reviewed by Maciej.

Speed up JavaScript built-in properties by changing the hash table to take advantage of the identifier objects

5% speedup for Acid3 test 26

bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getOwnPropertySlot): Update for change to HashTable. (WebCore::JSDOMWindowBase::put): Ditto.
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Ditto.
bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBase::getOwnPropertySlot): Ditto.
bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::customGetOwnPropertySlot): Ditto.
bindings/js/JSLocation.cpp: (WebCore::JSLocation::customGetOwnPropertySlot): Ditto. (WebCore::JSLocation::put): Ditto.
bindings/js/kjs_binding.cpp: (WebCore::nonCachingStaticFunctionGetter): Ditto.

bindings/scripts/CodeGeneratorJS.pm: Same changes as in the create_hash_table script.

8:50 PM Changeset in webkit [31146] by pewtermoose@webkit.org

2 edits in trunk/WebCore

2008-03-18 Matt Lilek <webkit@mattlilek.com>

Fix the Gtk build for real this time.

platform/network/curl/AuthenticationChallenge.h:

6:50 PM Changeset in webkit [31145] by mrowe@apple.com

3 edits
6 adds in trunk

Fix http://bugs.webkit.org/show_bug.cgi?id=17925 and http://bugs.webkit.org/show_bug.cgi?id=17927.

Bug 17925: Crash in KJS::JSObject::put after setting this.proto
Bug 17927: Hang after attempting to create circular proto

kjs/object.cpp:

(KJS::JSObject::put): Silently ignore attempts to set proto to a non-object, non-null value.
Return after setting the exception when an attempt to set a cyclic proto is detected so that
the cyclic value is not set.

6:42 PM Changeset in webkit [31144] by weinig@apple.com

14 edits
6 adds in trunk

WebCore:

2008-03-18 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for http://bugs.webkit.org/show_bug.cgi?id=17057
REGRESSION: Frequent random crashes in WebCore::JSNodeList::indexGetter
<rdar://problem/5725058>

Tests: fast/dom/NodeList/5725058-crash-scenario-1.html

fast/dom/NodeList/5725058-crash-scenario-2.html
fast/dom/NodeList/5725058-crash-scenario-3.html

dom/ChildNodeList.cpp: (WebCore::ChildNodeList::ChildNodeList):
dom/ChildNodeList.h: Remove rootNodeChildrenChanged() method and fix the constructor to not pass in a needsNotifications argument to DynamicNodeList, as it no longer takes one.

dom/ClassNodeList.cpp: (WebCore::ClassNodeList::ClassNodeList): Don't pass the needsNotifications argument to DynamicNodeList.

dom/ContainerNode.cpp: (WebCore::ContainerNode::childrenChanged): Rename call to hasNodeLists() to hasNodeListCaches().

dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): Zero out the m_document variable to signify to destructors down the destruction chain that this is a Document type node being destructed, and thus, accessing document() is prohibited.
dom/Document.h: (WebCore::Document::addNodeListCache): Renamed from addNodeList. (WebCore::Document::removeNodeListCache): Renamed from removeNodeList, adds assertion. (WebCore::Document::hasNodeListCaches): Renamed from hasNodeListCaches. Rename m_numNodeLists to m_numNodeListCaches.

dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::DynamicNodeList): (WebCore::DynamicNodeList::~DynamicNodeList): (WebCore::DynamicNodeList::invalidateCache): (WebCore::DynamicNodeList::Caches::Caches):
dom/DynamicNodeList.h: (WebCore::DynamicNodeList::hasOwnCaches): Remove the needsNotifications concept from DynamicNodeList, instead, manually invalidate the cache for lists that own their own cache.

dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList):
dom/NameNodeList.h: Remove rootNodeAttributeChanged() method and fix the constructor to not pass in a needsNotifications argument to DynamicNodeList, as it no longer takes one.

dom/Node.cpp: (WebCore::Node::~Node): Decrement the document's nodeListCache count if we had a NodeListsNodeData cache and this is not the Document being destructor, as tagged by a null m_document. (WebCore::Node::childNodes): Increment the document's nodeListCache count if we need create the NodeListsNodeData. (WebCore::Node::registerDynamicNodeList): Increment the document's nodeListCache count if we need create the NodeListsNodeData. Change to invalidate all the caches, instead of just the ChildNodeList, if document has had no NodeListCaches. (WebCore::Node::unregisterDynamicNodeList): Change to remove the cache from the m_listsWithCaches set if it is owned by the NodeList and clear the m_nodeLists if it is empty. (WebCore::Node::notifyLocalNodeListsAttributeChanged): Move logic to NodeListsNodeData::invalidateAttributeCaches and clear the cache pointer if it is empty. (WebCore::Node::notifyLocalNodeListsChildrenChanged): Move logic to NodeListsNodeData::invalidateCaches and clear the cache pointer if it is empty. (WebCore::Node::notifyNodeListsChildrenChanged): Cleanup. (WebCore::Node::getElementsByName): Increment the document's nodeListCache count if we need create the NodeListsNodeData. (WebCore::Node::getElementsByClassName): Increment the document's nodeListCache count if we need create the NodeListsNodeData.

(WebCore::NodeListsNodeData::invalidateCaches): Added.
(WebCore::NodeListsNodeData::invalidateAttributeCaches): Added.
(WebCore::NodeListsNodeData::isEmpty): Added.

dom/TagNodeList.cpp: (WebCore::TagNodeList::TagNodeList): Don't pass the needsNotifications argument to DynamicNodeList.

LayoutTests:

2008-03-18 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Tests for http://bugs.webkit.org/show_bug.cgi?id=17057
REGRESSION: Frequent random crashes in WebCore::JSNodeList::indexGetter
<rdar://problem/5725058>

fast/dom/NodeList/5725058-crash-scenario-1-expected.txt: Added.
fast/dom/NodeList/5725058-crash-scenario-1.html: Added.
fast/dom/NodeList/5725058-crash-scenario-2-expected.txt: Added.
fast/dom/NodeList/5725058-crash-scenario-2.html: Added.
fast/dom/NodeList/5725058-crash-scenario-3-expected.txt: Added.
fast/dom/NodeList/5725058-crash-scenario-3.html: Added.

5:43 PM Changeset in webkit [31143] by pewtermoose@webkit.org

2 edits in trunk/WebCore

2008-03-18 Matt Lilek <webkit@mattlilek.com>

Not reviewed, build fix.

platform/network/curl/AuthenticationChallenge.h:

4:44 PM Changeset in webkit [31142] by weinig@apple.com

3 edits in trunk/LayoutTests

2008-03-18 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Make domListEnumeration.html test not depend on the order of property enumeration
by sorting the result array.

fast/dom/domListEnumeration-expected.txt:
fast/dom/resources/domListEnumeration.js:

4:22 PM Changeset in webkit [31141] by pewtermoose@webkit.org

10 edits in trunk

WebCore:

2008-03-18 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Adam Roben.

Provide some stub implementations for things that WebKit
uses for performing authentication/challenge activities. This
is in support of http://bugs.webkit.org/show_bug.cgi?id=17837

platform/network/ResourceHandle.h:
platform/network/curl/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::sourceHandle):

WebKit/win:

2008-03-18 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Adam Roben.

Provide some stub implementations for things that WebKit
uses for performing authentication/challenge activities. This
is in support of http://bugs.webkit.org/show_bug.cgi?id=17837

WebDataSource.cpp:
WebError.cpp: Conditionalize CFNetwork-specific logic
WebURLAuthenticationChallenge.cpp: Conditionalize constructor for authentication/challenge member. (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
WebURLResponse.cpp: Remove CFNetwork-specific logic.
WebURLResponse.h: Conditionalize CFNetwork-specific member.
WebView.cpp: Conditionalize CFNetwork-specific network protocol test. (WebView::canHandleRequest):

3:31 PM Changeset in webkit [31140] by eric@webkit.org

1 edit in trunk/WebCore/ChangeLog

Add missing changelog

3:30 PM Changeset in webkit [31139] by eric@webkit.org

1 edit in trunk/WebCore/svg/graphics/SVGImage.cpp

Reviewed by Oliver.

Fix SVGImage crash seen once, and obvious via code inspection.

I was not able to find a test case for this.

svg/graphics/SVGImage.cpp: (WebCore::SVGImage::setContainerSize): (WebCore::SVGImage::usesContainerSize): (WebCore::SVGImage::hasRelativeWidth): (WebCore::SVGImage::hasRelativeHeight):

3:03 PM Google Summer of Code 2008 edited by jasper@unix.geek.nz

(diff)

2:52 PM Google Summer of Code 2008 edited by catfish.man@gmail.com

Add calc() to the idea list (diff)

2:43 PM Changeset in webkit [31138] by mrowe@apple.com

2 edits in trunk/WebCore

2008-03-18 Rodney Dawes <dobey@wayofthemonkey.com>

Fix Qt build after r31123.

Add PluginView methods to TemporaryLinkStubs.

platform/qt/TemporaryLinkStubs.cpp:

2:25 PM Changeset in webkit [31137] by weinig@apple.com

2 edits in trunk/WebCore

2008-03-18 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Speed up JavaScript prototype and constructor object creation using a static Identifier in the self() methods to avoid the cost of creating one from a c-string each time.

5% speedup for Acid3 test 26

bindings/scripts/CodeGeneratorJS.pm:

2:10 PM Changeset in webkit [31136] by mjs@apple.com

3 edits in trunk/JavaScriptCore

2008-03-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.

inline ActivationImp::init for 0.8% SunSpider speedup

kjs/Activation.h: (KJS::ActivationImp::init): Moved here from function.cpp
kjs/function.cpp:

1:57 PM Changeset in webkit [31135] by Antti Koivisto

8 edits in trunk/WebCore

2008-03-18 Antti Koivisto <Antti Koivisto>

Reviewed by Mark Rowe.

Enable preloading for other platforms besides Mac.

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCoreSources.bkl:
html/HTMLTokenizer.cpp:
html/HTMLTokenizer.h:
html/PreloadScanner.cpp: (WebCore::PreloadScanner::tokenize):

1:50 PM Changeset in webkit [31134] by hyatt@apple.com

3 edits in trunk/WebKit/mac

2008-03-18 David Hyatt <hyatt@apple.com>

Add support for a preference in WebKit that can be used in nightly builds to test full page
zoom.

Reviewed by Antti

WebView/WebPreferenceKeysPrivate.h:
WebView/WebView.mm: (-[WebView setTextSizeMultiplier:]): (-[WebView canMakeTextSmaller]): (-[WebView makeTextSmaller:]): (-[WebView canMakeTextLarger]): (-[WebView makeTextLarger:]): (-[WebView canMakeTextStandardSize]): (-[WebView makeTextStandardSize:]):

12:58 PM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@apple.com

(diff)

12:21 PM Changeset in webkit [31133] by mrowe@apple.com

4 copies
1 add in releases/Apple/Safari 3.1

Release tag for Safari 3.1.

11:15 AM Changeset in webkit [31132] by mitz@apple.com

3 edits
4 adds in trunk

WebCore:

2008-03-18 Dan Bernstein <mitz@apple.com>

Reviewed by Adele Peterson.

fix <rdar://problem/5805127> REGRESSION (r31116): Assertion failure (floatIndex < floats.size()) in RenderBlock::determineStartPosition() at digg.com

Test: fast/dynamic/floating-to-positioned.html

rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Added code to remove a float from object lists if its position property changes to something other than static, since then it ceases to be a float.

LayoutTests:

2008-03-18 Dan Bernstein <mitz@apple.com>

Reviewed by Adele Peterson.

test for <rdar://problem/5805127> REGRESSION (r31116): Assertion failure (floatIndex < floats.size()) in RenderBlock::determineStartPosition() at digg.com

fast/dynamic/floating-to-positioned.html: Added.
platform/mac/fast/dynamic/floating-to-positioned-expected.checksum: Added.
platform/mac/fast/dynamic/floating-to-positioned-expected.png: Added.
platform/mac/fast/dynamic/floating-to-positioned-expected.txt: Added.

11:04 AM Changeset in webkit [31131] by Adam Roben

2 edits in trunk/WebCore

Windows build fix after r31123

plugins/win/PluginViewWin.cpp: Add back MozillaUserAgent.

10:57 AM Changeset in webkit [31130] by jhoneycutt@apple.com

2 edits in trunk/WebKit/gtk

2008-03-18 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed and landed by jhoneycutt.

Update to check if the MIME type is supported by a plugin.

WebCoreSupport/FrameLoaderClientGtk.cpp: (FrameLoaderClient::objectContentType):

9:42 AM Changeset in webkit [31129] by Adam Roben

3 edits in trunk/WebKit/win

Focus the Inspector's WebView whenever the Inspector window is focused

Reviewed by Mitz.

WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::onSetFocus): Send focus to the WebView. (WebInspectorWndProc): Added a handler for WM_SETFOCUS.
WebCoreSupport/WebInspectorClient.h:

9:40 AM Changeset in webkit [31128] by Adam Roben

4 edits in trunk/WebKit/win

Fix Bug 14276: Element highlight also covers Web inspector

<http://bugs.webkit.org/show_bug.cgi?id=14276>
<rdar://5712796>

Also fixes <rdar://5622837> Browser window comes to front when node
highlight appears, potentially blocking Inspector

Reviewed by Mitz.

WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::highlight): After showing the highlight, reposition it just behind the Inspector's window.
WebNodeHighlight.cpp: (WebNodeHighlight::show):
- Changed flags passed to CreateWindowEx to not specify WS_VISIBLE. This is not needed because we'll show the window later in this function.
- Removed call to SetWindowPos that tried to position the overlay just in front of the WebView. This is now handled by WebInspectorClient.
- Changed call to ShowWindow to use SetWindowPos so that we can pass SWP_NOACTIVATE. This prevents the highlight from jumping in front of the Inspector every time it's shown.
WebNodeHighlight.h: Added a method to get the highlight's HWND.

9:13 AM Changeset in webkit [31127] by mitz@apple.com

5 edits in trunk/WebCore

2008-03-18 Dan Bernstein <mitz@apple.com>

Reviewed by Darin Adler.

eliminate RenderFlow::m_clear

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Removed code to set m_clear. (WebCore::RenderBlock::newLine): Added a 'clear' parameter.
rendering/RenderBlock.h:
rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow): Removed initialization of m_clear.
rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Added a local 'clear' variable, passing a pointer to it to findNextLineBreak() and its value to newLine(). (WebCore::RenderBlock::findNextLineBreak): Added a 'clear' parameter, which this method adjusts when it encounters a <br>.

8:20 AM Changeset in webkit [31126] by Simon Hausmann

4 edits in trunk

Fix the Qt build.

7:50 AM Changeset in webkit [31125] by pewtermoose@webkit.org

3 edits in trunk/WebCore

2008-03-18 Rodney Dawes <dobey@wayofthemonkey.com>

Fix Mac build from commit of r31123.

Add a typedef for NSView* to PlatformWidget, remove duplicate PluginMessageThrottlerWin definition.

platform/Widget.h:
WebCore.vcproj/WebCore.vcproj:

7:46 AM Changeset in webkit [31124] by Simon Hausmann

2 edits in trunk/JavaScriptCore

Fix the Qt build.

Including config.h like in the other .cpp files gets the #ifdeffery
correct for rand_s.

7:21 AM Changeset in webkit [31123] by pewtermoose@webkit.org

12 edits
1 copy in trunk

WebCore:

2008-03-18 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Jon Honeycutt.

Add PluginView.cpp and npapi.cpp to build files.
Copy win/PluginViewWin.cpp to PluginView.cpp for shared code.
Split Windows specific code out of PluginView.cpp.
Add #if USE(NPOBJECT) around dependant code.
Use npruntime_internal.h instead of npapi.h.
Add PlatformWidget typedef to Widget.h.
Update WidgetGtk.cpp for the PlatformWidget usage.
Add needed methods to TemporaryLinkStubs for GTK+ port.

GNUmakefile.am:
WebCore.pro:
WebCoreSources.bkl:
WebCore.vcproj/WebCore.vcproj:
plugins/win/PluginViewWin.cpp:
plugins/PluginView.cpp:
plugins/PluginView.h:
plugins/npapi.cpp:
platform/Widget.h:
platform/gtk/WidgetGtk.cpp:
platform/gtk/TemporaryLinkStubs.cpp:

WebKit/gtk:

2008-03-18 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Jon Honeycutt.

Update setContainingWindow() calls to pass a GtkWidget.

webkit/webkitwebframe.cpp: (webkit_web_frame_new): (webkit_web_frame_init_with_web_view):

6:47 AM Changeset in webkit [31122] by Darin Adler

29 edits in trunk

JavaScriptCore:

2008-03-17 Darin Adler <Darin Adler>

Reviewed by Maciej.

JavaScriptCore changes to support a WebCore speedup.

JavaScriptCore.exp: Export the UString::Rep::computeHash function.
wtf/HashSet.h: Added a find and contains function that take a translator, like the add function.

WebCore:

2008-03-17 Darin Adler <Darin Adler>

Reviewed by Maciej.

speed up document property fetching (eliminate the AtomicString objects made during document property lookup)

3% speedup for Acid3 test 26

bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getOwnPropertySlot): Use AtomicString::find to locate the AtomicString, only if already present. Also call the new faster versions of the hasNamedItem and hasElementWithId functions that don't ref/deref the AtomicStringImpl, get inlined, etc.
bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::canGetItemsForName): Ditto. (WebCore::writeHelper): Use a Vector instead of a String to build up the string to avoid the bad performance of string append.

dom/Document.cpp: Tweaked code and comments a bit. Nothing substantive.
dom/Document.h: Added new hasElementWithId function that's faster than getElementById because it doesn't ref/deref the AtomicStringImpl*, gets inlined, doesn't have to handle the 0 case, and doesn't try to return the element pointer (just a boolean).

html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::parseMappedAttribute): Use AtomicString consistently. Also renamed the data member for clarity. (WebCore::HTMLAppletElement::insertedIntoDocument): Ditto. (WebCore::HTMLAppletElement::removedFromDocument): Ditto.
html/HTMLAppletElement.h: Ditto.

html/HTMLDocument.cpp: (WebCore::addItemToMap): Use AtomicString instead of String. (WebCore::removeItemFromMap): Ditto. (WebCore::HTMLDocument::addNamedItem): Updated for member name change. (WebCore::HTMLDocument::removeNamedItem): Ditto. (WebCore::HTMLDocument::addExtraNamedItem): Ditto. (WebCore::HTMLDocument::removeExtraNamedItem): Ditto. (WebCore::HTMLDocument::clear): Added. Moved code here from the JavaScript bindings. If we're going to have an empty placeholder function, there's no reason to have it in the bindings instead of here.
html/HTMLDocument.h: Added clear. Changed the named item function arguments to AtomicString insted of String. Changed the NameCountMap to use AtomicStringImpl* instead of StringImpl*. Renamed the data members to add a m_ prefix and remove the needless doc prefix. Added hasNamedItem and hasExtraNamedItem functions that are inlined and faster than the old idiom because they doesn't ref/deref the AtomicStringImpl*, get inlined, and don't have to handle the 0 case.
html/HTMLDocument.idl: Removed the [Custom] attribute on clear and took it out of the JavaScript-specific section.

html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): Use AtomicString consistently. Also renamed the data member for clarity. (WebCore::HTMLEmbedElement::insertedIntoDocument): Ditto. (WebCore::HTMLEmbedElement::removedFromDocument): Ditto.
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::insertedIntoDocument): Ditto. (WebCore::HTMLFormElement::removedFromDocument): Ditto. (WebCore::HTMLFormElement::parseMappedAttribute): Ditto.
html/HTMLFormElement.h: Ditto.

html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): Renamed m_name to m_frameName for clarity, since the frame name is not the same as the name attribute. (WebCore::HTMLFrameElementBase::parseMappedAttribute): Ditto. (WebCore::HTMLFrameElementBase::setNameAndOpenURL): Ditto.
html/HTMLFrameElementBase.h: Ditto.

html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::parseMappedAttribute): Use AtomicString consistently. Also renamed the data member for clarity. (WebCore::HTMLIFrameElement::insertedIntoDocument): Ditto. (WebCore::HTMLIFrameElement::removedFromDocument): Ditto.
html/HTMLIFrameElement.h: Ditto.
html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Ditto. (WebCore::HTMLImageElement::insertedIntoDocument): Ditto. (WebCore::HTMLImageElement::removedFromDocument): Ditto.
html/HTMLImageElement.h: Ditto.
html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute): Ditto. (WebCore::HTMLObjectElement::insertedIntoDocument): Ditto. (WebCore::HTMLObjectElement::removedFromDocument): Ditto. (WebCore::HTMLObjectElement::updateDocNamedItem): Ditto.
html/HTMLObjectElement.h: Ditto.

html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::isURLAttribute): Use equalIgnoringCase instead of callling lower().

html/HTMLPlugInElement.h: Changed the type of m_name. The code that uses this is in HTMLAppletElement, HTMLEmbedElement, and HTMLObjectElement.

platform/text/AtomicString.cpp: (WebCore::equal): Moved to an inline so we can share this code between a few different functions. It could move to a header too if we want to use it elsewhere. (WebCore::UCharBufferTranslator::equal): Change to use inline. (WebCore::HashAndCharactersTranslator::hash): Added. (WebCore::HashAndCharactersTranslator::equal): Added. (WebCore::HashAndCharactersTranslator::translate): Added. (WebCore::AtomicString::add): Improved the Identifier and UString overloads to use the already-computed hash code instead of rehashing the string. (WebCore::AtomicString::find): Added.
platform/text/AtomicString.h: Added a find function so we can avoid allocating memory just to look up a string in an atomic string set or map.

platform/text/StringImpl.h: Added declarations needed for the AtomicString changes.

2:42 AM Changeset in webkit [31121] by mjs@apple.com

3 edits in trunk/JavaScriptCore

2008-03-18 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.

a few micro-optimizations for 1.2% SunSpider speedup

kjs/function.cpp: (KJS::FunctionImp::callAsFunction): check for Return completion before Throw, it is more likely.
kjs/object.cpp: (KJS::JSObject::put): When walking prototype chain, instead of checking isObject (a virtual call), compare to jsNull (compare to a constant) since null is the only non-object that can be in a prototype chain.

Mar 17, 2008:

11:12 PM Changeset in webkit [31120] by timothy@apple.com

2 edits in trunk/WebCore

2008-03-17 Timothy Hatcher <timothy@apple.com>

Reviewed by Mark Rowe.

Bug 17908: Various bugs in the Console completion code
http://bugs.webkit.org/show_bug.cgi?id=17908

page/inspector/ConsolePanel.js: (WebInspector.ConsolePanel.complete): Moved the code that checked for the caret being at the end of the prompt into the _caretAtEndOfPrompt helper function. (WebInspector.ConsolePanel.messagesSelectStart): Clear and redo the auto complete when the selection changes. (WebInspector.ConsolePanel._caretInsidePrompt): Fixed a logic error that always caused a false result. (WebInspector.ConsolePanel._caretAtEndOfPrompt): Added. Tests if the selection is a caret at the end of the prompt. (WebInspector.ConsolePanel._moveCaretToEndOfPrompt): Changed the offset to use the childNodes length. This makes sure the caret is at the end when there are multiple text nodes in the prompt.

10:36 PM Changeset in webkit [31119] by oliver@apple.com

3 edits in trunk/JavaScriptCore

Optimise multi-scope function call resolution

Reviewed by Geoff

Refactor multiscope variable resolution and use to add
optimised FunctionCallResolveNode subclasses.

2.6% gain in sunspider performance, *25%* gain in controlflow-recursive

10:03 PM Changeset in webkit [31118] by eric@webkit.org

2 edits in trunk/WebKitTools

Reviewed by Dan Bernstein.

Fix bogus argCount check breaking plugin test.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:

9:36 PM Changeset in webkit [31117] by mitz@apple.com

4 edits in trunk/WebCore

2008-03-17 Dan Bernstein <mitz@apple.com>

Rubber-stamped by Dave Hyatt.

FloatingObject cleanup

Renamed FloatingObject's data members as follows: node -> m_renderer,
startY -> m_top, endY -> m_bottom, left -> m_left, width -> m_width,
and noPaint -> !m_shouldPaint, reversing the meaning of the flag.

Also addressed the FIXME in RenderBlock::containsFloat().

rendering/RenderBlock.cpp: (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::removeFloatingObject): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::nextFloatBottomBelow): (WebCore::RenderBlock::floatBottom): (WebCore::RenderBlock::floatRect): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::leftBottom): (WebCore::RenderBlock::rightBottom): (WebCore::RenderBlock::clearFloats): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::addIntrudingFloats): (WebCore::RenderBlock::containsFloat): Changed to return false if the floats lists exists but is empty, since line layout code no longer relies on the buggy behavior. (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::adjustForBorderFit):
rendering/RenderBlock.h: (WebCore::RenderBlock::containsFloats): (WebCore::RenderBlock::FloatingObject::FloatingObject):
rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::matchedEndLine):

9:04 PM Changeset in webkit [31116] by mitz@apple.com

6 edits
38 adds in trunk

WebCore:

2008-03-17 Dan Bernstein <mitz@apple.com>

Reviewed by Dave Hyatt.

allow incremental relayout of blocks that contain floats

Tests: fast/repaint/line-flow-with-floats-[1-9].html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloatsIfNeeded): Cleaned up by moving most of the function body out of an if statement which was replaced with an early return. (WebCore::RenderBlock::insertFloatingObject): Cleaned up by moving most of the function body out of an if statement and moving the ASSERT, which is a crash in release builds, to the beginning. Made this function set the m_isDescendant flag of floating objects it creates. (WebCore::RenderBlock::removeFloatingObject): Added a call to markLinesDirtyInVerticalRange() when removing a float from a block with inline children. (WebCore::RenderBlock::markLinesDirtyInVerticalRange): Added. Marks the lines in the given range as dirty. (WebCore::RenderBlock::clearFloats): Added code to detect changes to the geometry of floats intruding into this block from other blocks and mark any lines whose available width has changed as a result as dirty.

rendering/RenderBlock.h: (WebCore::RenderBlock::FloatWithRect::FloatWithRect): Added a structure to cache a float with its position and size. (WebCore::RenderBlock::FloatingObject::FloatingObject): Added an m_isDescendant flag, used by clearFloats() to distinguish between floats entering the block from outside and floats internal to the block.

rendering/RootInlineBox.h: (WebCore::RootInlineBox::floats): Added. (WebCore::RootInlineBox::floatsPtr): Added. (WebCore::RootInlineBox::Overflow::Overflow): Added a data member to hold the floats originating on the line.

rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Made the existence of floats not force a full layout. Changed to cache the geometry of floats in the block and detect changes to it. If a float's size or position changes, all lines from that point on are treated as dirty. An exception is a change in the dimensions of a float on an otherwise-clean line, which only dirties lines potentially affected by the change (see determineStartPosition()). Added code to update each RootInlineBox's set of floats as lines are laid out. Added code to shift floats belonging to clean lines in the end along with the lines. (WebCore::RenderBlock::determineStartPosition): Made this function look for changes to floats' dimensions and mark lines as dirty accordingly. Also look for new floats and if found, cause a full layout. Added code to re-add floats belonging to clean lines. (WebCore::RenderBlock::matchedEndLine): Added checking that the clean lines in the end can be shifted vertically as needed, i.e. that the available width along the way is uniform.

LayoutTests:

2008-03-17 Dan Bernstein <mitz@apple.com>

Reviewed by Dave Hyatt.

test incremental relayout of blocks that contain floats

fast/repaint/line-flow-with-floats-1.html: Added.
fast/repaint/line-flow-with-floats-2.html: Added.
fast/repaint/line-flow-with-floats-3.html: Added.
fast/repaint/line-flow-with-floats-4.html: Added.
fast/repaint/line-flow-with-floats-5.html: Added.
fast/repaint/line-flow-with-floats-6.html: Added.
fast/repaint/line-flow-with-floats-7.html: Added.
fast/repaint/line-flow-with-floats-8.html: Added.
fast/repaint/line-flow-with-floats-9.html: Added.
fast/repaint/resources/line-flow-with-floats.html: Added.
fast/repaint/resources/line-flow-with-floats.js: Added.
platform/mac/fast/repaint/line-flow-with-floats-1-expected.checksum: Added.
platform/mac/fast/repaint/line-flow-with-floats-1-expected.png: Added.
platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt: Added.
platform/mac/fast/repaint/line-flow-with-floats-2-expected.checksum: Added.
platform/mac/fast/repaint/line-flow-with-floats-2-expected.png: Added.
platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt: Added.
platform/mac/fast/repaint/line-flow-with-floats-3-expected.checksum: Added.
platform/mac/fast/repaint/line-flow-with-floats-3-expected.png: Added.
platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt: Added.
platform/mac/fast/repaint/line-flow-with-floats-4-expected.checksum: Added.
platform/mac/fast/repaint/line-flow-with-floats-4-expected.png: Added.
platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt: Added.
platform/mac/fast/repaint/line-flow-with-floats-5-expected.checksum: Added.
platform/mac/fast/repaint/line-flow-with-floats-5-expected.png: Added.
platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt: Added.
platform/mac/fast/repaint/line-flow-with-floats-6-expected.checksum: Added.
platform/mac/fast/repaint/line-flow-with-floats-6-expected.png: Added.
platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt: Added.
platform/mac/fast/repaint/line-flow-with-floats-7-expected.checksum: Added.
platform/mac/fast/repaint/line-flow-with-floats-7-expected.png: Added.
platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt: Added.
platform/mac/fast/repaint/line-flow-with-floats-8-expected.checksum: Added.
platform/mac/fast/repaint/line-flow-with-floats-8-expected.png: Added.
platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt: Added.
platform/mac/fast/repaint/line-flow-with-floats-9-expected.checksum: Added.
platform/mac/fast/repaint/line-flow-with-floats-9-expected.png: Added.
platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt: Added.

7:36 PM Google Summer of Code 2008 edited by eric@webkit.org

(diff)

7:34 PM Google Summer of Code 2008 edited by eric@webkit.org

(diff)

7:33 PM Google Summer of Code 2008 edited by eric@webkit.org

(diff)

7:32 PM Google Summer of Code 2008 edited by eric@webkit.org

(diff)

7:32 PM Google Summer of Code 2008 edited by eric@webkit.org

(diff)

7:31 PM Google Summer of Code 2008 edited by eric@webkit.org

(diff)

6:54 PM Changeset in webkit [31115] by ddkilzer@apple.com

2 edits in trunk/JavaScriptCore

Don't define PLATFORM(MIDDLE_ENDIAN) on little endian ARM.

Reviewed by Darin.

See <http://bugs.webkit.org/show_bug.cgi?id=15416#c13>.

wtf/Platform.h: Added check for !defined(ARMEL) when defining PLATFORM(MIDDLE_ENDIAN).

4:33 PM Changeset in webkit [31114] by oliver@apple.com

11 edits in trunk/JavaScriptCore

Add fast multi-level scope lookup

Reviewed by Geoff, Darin and Weinig

Add logic and AST nodes to provide rapid variable resolution across
static scope boundaries. This also adds logic that allows us to skip
any static scopes that do not contain the variable to be resolved.

This results in a ~2.5% speedup in SunSpider, and gives a 25-30% speedup
in some simple and ad hoc closure and global variable access tests.

4:22 PM Google Summer of Code 2008 edited by eric@webkit.org

(diff)

4:08 PM Changeset in webkit [31113] by mitz@apple.com

2 edits in trunk/WebKitSite

2008-03-17 Dan Bernstein <mitz@apple.com>

Reviewed by Sam Weinig.

link "backtrace" to the page that explains how to get one

quality/bugwriting.html:

2:47 PM Changeset in webkit [31112] by eric@webkit.org

8 edits
4 adds in trunk

Reviewed by darin.

Fix _NPN_IntFromIdentifier (and export the symbol for use!)

Test: plugins/netscape-identifier-conversion.html

WebCore.NPAPI.exp:
bridge/npruntime.cpp: (_NPN_IntFromIdentifier):

2:38 PM Changeset in webkit [31111] by weinig@apple.com

4 edits in trunk

WebCore:

2008-03-17 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Add HTMLCollection constructor to the Window object. (Omission noticed by Harri Porten)

page/DOMWindow.idl:

LayoutTests:

2008-03-17 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Add HTMLCollection constructor to the Window object. (Omission noticed by Harri Porten)

fast/dom/Window/window-properties-expected.txt:

2:34 PM Changeset in webkit [31110] by zecke@webkit.org

2 edits in trunk/WebCore

2008-03-17 Holger Hans Peter Freyther <zecke@selfish.org>

Unreviewed Gtk+ build fix.

platform/ScrollView.h: make it public
platform/gtk/ScrollViewGtk.cpp: remove const

2:33 PM Changeset in webkit [31109] by zecke@webkit.org

5 edits in trunk/WebCore

2008-03-17 Julien Chaffraix <julien.chaffraix@gmail.com>

Reviewed by Holger.

<http://bugs.webkit.org/show_bug.cgi?id=17754>

Implement ResourceHandle::loadResourceSynchronously to dispatch synchronous requests.

Implement WebCoreSynchronousLoader, the ResourceHandleClient which holds the network data, response and error for us during the transfert.

platform/network/ResourceHandleInternal.h: Remove trailing white space.
platform/network/curl/ResourceHandleCurl.cpp: Add WebCoreSynchronousLoader (WebCore::WebCoreSynchronousLoader::resourceResponse): (WebCore::WebCoreSynchronousLoader::resourceError): (WebCore::WebCoreSynchronousLoader::data): (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::WebCoreSynchronousLoader::didReceiveResponse): (WebCore::WebCoreSynchronousLoader::didReceiveData): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::ResourceHandle::loadResourceSynchronously): Implement method using WebCoreSynchronousLoader.

platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::dispatchSynchronousJob): (WebCore::ResourceHandleManager::startJob): (WebCore::ResourceHandleManager::initializeHandle): Handle initialization method used both for synchronous and asynchronous job.

platform/network/curl/ResourceHandleManager.h:

2:27 PM Changeset in webkit [31108] by Darin Adler

2 edits in trunk/WebCore

2008-03-17 Darin Adler <Darin Adler>

try to fix GTK build

platform/ScrollView.h: Make setGtkAdjustments adjustment. And non-virtual (why was it virtual?).

1:35 PM Changeset in webkit [31107] by mrowe@apple.com

4 edits in branches/Safari-3-1-branch

Versioning.

1:34 PM Changeset in webkit [31106] by Adam Roben

3 edits
2 adds in trunk/WebCore

2008-03-17 Rodney Dawes <dobey@wayofthemonkey.com>

Fix Bug 17898: Split PluginMessageThrottlerWin into its own files

<http://bugs.webkit.org/show_bug.cgi?id=17898>

Move the PluginMessageThrottlerWin class into its own files, in
preparation for refactoring PluginView code to be shared.

Reviewed and tweaked by Adam Roben.

WebCore.vcproj/WebCore.vcproj:
plugins/PluginView.h:
plugins/win/PluginMessageThrottlerWin.cpp: Added.
plugins/win/PluginMessageThrottlerWin.h: Added.
plugins/win/PluginViewWin.cpp:

1:33 PM Changeset in webkit [31105] by mrowe@apple.com

1 copy in tags/Safari-5525.15

New tag.

1:21 PM Changeset in webkit [31104] by Adam Roben

2 edits in trunk/WebCore

More Windows build fixes after r31098

platform/ScrollView.h: Make some more methods public.

1:18 PM Changeset in webkit [31103] by Adam Roben

2 edits in trunk/WebCore

Windows and Qt build fixes after r31098

platform/ScrollView.h: Mark methods public that still need to be so.

12:28 PM Changeset in webkit [31102] by mrowe@apple.com

2 edits in branches/Safari-3-1-branch/WebCore

Merge r31069.

11:58 AM Changeset in webkit [31101] by timothy@apple.com

2 edits in trunk/WebCore

2008-03-16 Timothy Hatcher <timothy@apple.com>

Reviewed by Darin Adler.

Bug 17883: Console completion should support bracket notation
http://bugs.webkit.org/show_bug.cgi?id=17883

Also fixes a bug where the Inspector's window object was used instead of the
inspected window object.

page/inspector/ConsolePanel.js: (WebInspector.ConsolePanel.complete): Add a comment about the _backwardsRange call. (WebInspector.ConsolePanel.completions): Add a comment about the _backwardsRange call. Check the last character of the expression for a dot or bracket. Fallback to the InspectorController.inspectedWindow() instead of window, this was a bad bug. If the expression caused an exception, just consider the prefix a window property. When bracket notation is used remember what quote was used and compared property names with that quote surrounding it. Also escape the property name for the quote and backslash.

11:01 AM Changeset in webkit [31100] by Darin Adler

12 edits
22 adds
7 deletes in trunk

WebCore:

2008-03-17 Robert Blaut <webkit@blaut.biz>

Reviewed by Darin.

Fix for bug http://bugs.webkit.org/show_bug.cgi?id=17696
Set default margin-bottom for form element in quirk mode
and be compatible with Gecko.

Tests: fast/css/margin-bottom-form-element-quirk.html

fast/css/margin-bottom-form-element-strict.html

css/html4.css:
css/quirks.css:

LayoutTests:

2008-03-17 Robert Blaut <webkit@blaut.biz>

Reviewed by Darin.

Fix for bug http://bugs.webkit.org/show_bug.cgi?id=17696
Set default margin-bottom for form element in quirk mode
and be compatible with Gecko.

fast/css/margin-bottom-form-element-quirk.html: Added.
fast/css/margin-bottom-form-element-strict.html: Added.
fast/frames/viewsource-empty-attribute-value-expected.txt:
platform/mac/fast/block/margin-collapse/103-expected.checksum:
platform/mac/fast/block/margin-collapse/103-expected.png:
platform/mac/fast/block/margin-collapse/103-expected.txt:
platform/mac/fast/css/margin-bottom-form-element-quirk-expected.checksum: Added.
platform/mac/fast/css/margin-bottom-form-element-quirk-expected.png: Added.
platform/mac/fast/css/margin-bottom-form-element-quirk-expected.txt: Added.
platform/mac/fast/css/margin-bottom-form-element-strict-expected.checksum: Added.
platform/mac/fast/css/margin-bottom-form-element-strict-expected.png: Added.
platform/mac/fast/css/margin-bottom-form-element-strict-expected.txt: Added.
platform/mac/tables/mozilla/bugs/bug44505-expected.checksum:
platform/mac/tables/mozilla/bugs/bug44505-expected.png:
platform/mac/tables/mozilla/bugs/bug44505-expected.txt:
platform/mac/tables/mozilla/bugs/bug51727-expected.checksum:
platform/mac/tables/mozilla/bugs/bug51727-expected.png:
platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
platform/mac/tables/mozilla/bugs/bug52505-expected.checksum:
platform/mac/tables/mozilla/bugs/bug52505-expected.png:
platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
platform/mac/tables/mozilla/bugs/bug52506-expected.checksum:
platform/mac/tables/mozilla/bugs/bug52506-expected.png:
platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum:
platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.png:
platform/mac/tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt:
platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.checksum:
platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
platform/mac/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
platform/qt/fast/block/margin-collapse/103-expected.txt: Removed.
platform/qt/tables/mozilla/bugs/bug44505-expected.txt: Removed.
platform/qt/tables/mozilla/bugs/bug51727-expected.txt: Removed.
platform/qt/tables/mozilla/bugs/bug52505-expected.txt: Removed.
platform/qt/tables/mozilla/bugs/bug52506-expected.txt: Removed.
platform/qt/tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt: Removed.
platform/qt/tables/mozilla_expected_failures/bugs/bug56024-expected.txt: Removed.

10:38 AM Changeset in webkit [31099] by Antti Koivisto

2 edits in trunk/WebCore

2008-03-17 Antti Koivisto <Antti Koivisto>

Reviewed by Darin.

Speculative fix for http://bugs.webkit.org/show_bug.cgi?id=17878
Bug 17878: REGRESSION: Acid3 sometimes crashes Webkit under WebCore::Loader::Host::cancelRequests

I can't reproduce the crash or make a test case for this one but I'm pretty sure this
is the problem. Essentially the same bug as http://bugs.webkit.org/show_bug.cgi?id=17862
except in didFail() instead of didFinishLoading().

loader/loader.cpp: (WebCore::Loader::Host::didFail):

9:56 AM Changeset in webkit [31098] by Darin Adler

2 edits in trunk/WebCore

2008-03-17 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed and tweaked by Darin.

http://bugs.webkit.org/show_bug.cgi?id=17172
Refactor platform checks in ScrollView.h

platform/ScrollView.h: Change #ifs around.

9:43 AM Changeset in webkit [31097] by Darin Adler

3 edits
3 adds in trunk

WebCore:

2008-03-17 Yuzhu Shen <yuzhu.shen@gmail.com>

Reviewed by Darin.

Fix the bug: http://bugs.webkit.org/show_bug.cgi?id=17760
It is necessary to load the image even when src="".

Test: fast/images/load-img-with-empty-src.html

html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement): isNull rather than isEmpty.

LayoutTests:

2008-03-17 Yuzhu Shen <yuzhu.shen@gmail.com>

Reviewed by Darin.

Bug: http://bugs.webkit.org/show_bug.cgi?id=17760
Test whether <img> tries to load image with empty src attribute.

fast/images/load-img-with-empty-src-expected.txt: Added.
fast/images/load-img-with-empty-src.html: Added.
fast/images/resources/test-load.jpg: Added.

8:27 AM Changeset in webkit [31096] by Adam Roben

2 edits in trunk/WebCore

2008-03-17 Rodney Dawes <dobey@wayofthemonkey.com>

Fix GTK+ build from r31094.

plugins/gtk/PluginDatabaseGtk.cpp: (PluginDatabase::getPluginsInPaths):

8:25 AM Changeset in webkit [31095] by Adam Roben

3 edits
2 adds in trunk

Fix Bug 17876: REGRESSION (r31060): Attempting to visit Ofcom page causes crash

WebCore:

Fix Bug 17876: REGRESSION (r31060): Attempting to visit Ofcom page causes crash

<http://bugs.webkit.org/show_bug.cgi?id=17876>

Reviewed by John.

Test: fast/dom/remove-named-attribute-crash.html

dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::removeAttribute): Store the Attribute we're going to remove from the m_attributes Vector in a RefPtr so it doesn't get deleted when it is removed from the Vector.

LayoutTests: