Timeline
Apr 20, 2008:
- 11:56 PM Changeset in webkit [32289] by
-
- 7 edits in branches/squirrelfish/JavaScriptCore
Throw exceptions for invalid continue, break, and return statements.
Reviewed by Maciej
Simple refactoring and extension of Cameron's AssignErrorNode, etc patch
- 11:35 PM Changeset in webkit [32288] by
-
- 2 edits in trunk/WebCore
2008-04-20 Sriram Neelakandan <sriram.neelakandan@gmail.com>
Reviewed by Alp Toker.
Implement FileSystemGtk's getFileModificationTime() with GLib.
- platform/gtk/FileSystemGtk.cpp: (WebCore::getFileModificationTime):
- 11:02 PM Changeset in webkit [32287] by
-
- 1 edit2 adds in trunk/WebCore
2008-04-20 Christian Persch <chpe@gnome.org>
Reviewed by Alp Toker.
Bundle GTK+ Xt compatibility code from Mozilla. These files are used
by all currently proposed GTK+ plugin patches and will make the
proposed patches smaller and easier to review.
These files should be kept as close to the upstream versions as
possible so fixes can be shared between projects and to ensure
compatibility with the reference implementation.
- plugins/gtk/gtk2xtbin.c: Added. (xt_event_prepare): (xt_event_check): (xt_event_dispatch): (xt_event_polling_timer_callback): (gtk_xtbin_get_type): (gtk_xtbin_class_init): (gtk_xtbin_init): (gtk_xtbin_realize): (gtk_xtbin_new): (gtk_xtbin_set_position): (gtk_xtbin_resize): (gtk_xtbin_unrealize): (gtk_xtbin_destroy): (xt_client_init): (xt_client_create): (xt_client_unrealize): (xt_client_destroy): (xt_client_set_info): (xt_client_handle_xembed_message): (xt_client_event_handler): (send_xembed_message): (error_handler): (trap_errors): (untrap_error): (xt_client_focus_listener): (xt_add_focus_listener): (xt_remove_focus_listener): (xt_add_focus_listener_tree):
- plugins/gtk/gtk2xtbin.h: Added.
- 10:43 PM SquirrelFishPerfIdeas edited by
- (diff)
- 10:17 PM SquirrelFishPerfIdeas edited by
- (diff)
- 10:16 PM Changeset in webkit [32286] by
-
- 15 edits in branches/squirrelfish/JavaScriptCore
2008-04-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Removed Machine.cpp from AllInOneFile.cpp, and manually inlined a few
things that used to be inlined automatically.
1.9% speedup on SunSpider.
My hope is that we'll face fewer surprises in Machine.cpp codegen, now
that GCC is making fewer decisions. The speedup seems to confirm that.
- 8:22 PM SquirrelFishPerfIdeas edited by
- (diff)
- 7:55 PM Changeset in webkit [32285] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
Bug 18642: Iterator context may get placed into the return register, leading to much badness
<https://bugs.webkit.org/show_bug.cgi?id=18642>
Reviewed by Maciej
To prevent incorrectly reusing what will become the result register for
eval and global code execution, we need to request and ref the destination
in advance of codegen. Unfortunately this may lead to unnecessary copying,
although in future we can probably limit this. Curiously SunSpider shows
a progression in a number of tests, although it comes out as a wash overall.
This also fixes one of the regressions in run-javascriptcore-tests.
- 6:56 PM SquirrelFishPerfIdeas edited by
- (diff)
- 5:34 PM SquirrelFishPerfIdeas edited by
- (diff)
- 5:30 PM SquirrelFishPerfIdeas edited by
- (diff)
- 5:30 PM SquirrelFishPerfIdeas edited by
- (diff)
- 5:29 PM SquirrelFishPerfIdeas created by
- 5:22 PM Changeset in webkit [32284] by
-
- 2 edits in trunk/WebCore
2008-04-20 Dirk Schulze <vbs85@gmx.de>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=15449
[CAIRO] SVG gradients do not work properly
Fixed SVG-gradients in Cairo.
- svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: (WebCore::SVGPaintServerGradient::setup):
- 5:16 PM SquirrelFish edited by
- (diff)
- 5:05 PM ApplicationsGtk edited by
- Add Skipstone and tinymail UI library (diff)
- 4:46 PM SquirrelFish edited by
- (diff)
- 4:29 PM Changeset in webkit [32283] by
-
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-04-20 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Maciej.
Add support for AssignErrorNode, PrefixErrorNode, and PostfixErrorNode.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitCreateError):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::PostfixErrorNode::emitCode): (KJS::PrefixErrorNode::emitCode): (KJS::AssignErrorNode::emitCode):
- kjs/nodes.h:
- 4:09 PM SquirrelFishBlockers edited by
- (diff)
- 4:08 PM SquirrelFishBlockers edited by
- (diff)
- 4:08 PM SquirrelFishBlockers edited by
- (diff)
- 4:03 PM SquirrelFishBlockers edited by
- (diff)
- 4:01 PM SquirrelFishBlockers created by
- 3:59 PM SquirrelFish edited by
- (diff)
- 3:57 PM squirrelfish edited by
- (diff)
- 3:56 PM WikiStart edited by
- (diff)
- 3:55 PM SquirrelFish created by
- 1:48 PM Changeset in webkit [32282] by
-
- 2 edits in trunk/WebKit/mac
2008-04-20 Matt Lilek <webkit@mattlilek.com>
Mysteriously reviewed by mitz|away.
Bug 18111: Closing a tab while dragging crashes Safari
https://bugs.webkit.org/show_bug.cgi?id=18111
Null check the page before handling drag events.
- WebView/WebView.mm: (-[WebView draggingUpdated:]): (-[WebView draggingExited:]):
- 1:47 AM Changeset in webkit [32281] by
-
- 5 edits in branches/squirrelfish/JavaScriptCore
Provide line number information in exceptions
Reviewed by Geoff and Mark
Simple patch, adds line number information metadata to CodeBlock
and a simple method to get the line number responsible for a given
Instruction*.
- 12:28 AM Changeset in webkit [32280] by
-
- 10 edits2 adds in trunk
2008-04-20 Simon Hausmann <Simon Hausmann>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=18578
Share the printing code between the Gtk and the Qt port
- 12:09 AM Changeset in webkit [32279] by
-
- 4 edits in branches/squirrelfish/JavaScriptCore
Provide "sourceURL" in exceptions
Reviewed by Maciej
Apr 19, 2008:
- 11:59 PM Changeset in webkit [32278] by
-
- 3 edits in trunk/WebCore
2008-04-19 Alp Toker <alp@nuanti.com>
Reviewed by Mark Rowe.
Complete the Cairo (CSS) gradient implementation.
- platform/graphics/Gradient.h:
- platform/graphics/cairo/GradientCairo.cpp: (WebCore::Gradient::platformDestroy): (WebCore::Gradient::fill):
- 11:13 PM Changeset in webkit [32277] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
Don't call emitCode directly on subnodes, instead use CodeGenerator::emitNode
Reviewed by Maciej
This patch just a preparation for tracking line numbers.
- 10:34 PM Changeset in webkit [32276] by
-
- 6 edits in trunk/WebCore
2008-04-19 Alp Toker <alp@nuanti.com>
Reviewed by Dave Hyatt.
Restore Cairo canvas support following the recent changes in
BitmapImage and ImageBuffer integrating canvas with CSS. Some
drawing regressions remain unfixed.
- platform/graphics/BitmapImage.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::image):
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::draw):
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::createFrameAtIndex):
- 9:26 PM Changeset in webkit [32275] by
-
- 4 edits1 copy3 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix additional cases of https://bugs.webkit.org/show_bug.cgi?id=17921 namely cases where the trailing white space is already in a separate run but still needs to be re-ordered.
Test: fast/text/trailing-white-space-2.html
- platform/text/BidiResolver.h: (WebCore::::moveRunToEnd): (WebCore::::moveRunToBeginning):
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
LayoutTests:
Reviewed by Dave Hyatt.
- more test cases for https://bugs.webkit.org/show_bug.cgi?id=17921 in which the trailing white space is already in a separate run but still needs to be re-ordered.
- fast/text/trailing-white-space-2.html: Copied from LayoutTests/fast/text/trailing-white-space.html.
- platform/mac/fast/text/trailing-white-space-2-expected.checksum: Added.
- platform/mac/fast/text/trailing-white-space-2-expected.png: Added.
- platform/mac/fast/text/trailing-white-space-2-expected.txt: Added.
- 7:27 PM Changeset in webkit [32274] by
-
- 2 edits in trunk/JavaScriptCore
2008-04-19 Matt Lilek <webkit@mattlilek.com>
Not reviewed, Windows build fix - copy the profiler headers in all
configurations, not just Debug_Internal.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 7:10 PM Changeset in webkit [32273] by
-
- 6 edits4 adds in tags/Safari-6526.1
Merge r31964.
- 7:10 PM Changeset in webkit [32272] by
-
- 2 edits in tags/Safari-6526.1/WebKit/mac
Merge r32023.
- 7:06 PM Changeset in webkit [32271] by
-
- 4 edits in trunk
Versioning.
- 6:58 PM Changeset in webkit [32270] by
-
- 1 copy in tags/Safari-6526.1
New tag.
- 3:34 PM Changeset in webkit [32269] by
-
- 7 edits in branches/squirrelfish/JavaScriptCore
Bug 18619: Support continue, break, and return in try .. finally blocks
<https://bugs.webkit.org/show_bug.cgi?id=18619>
Reviewed by Maciej
This patch replaces the current partial finally support (which uses code
duplication to achieve what it does) with a subroutine based approach.
This has a number of advantages over code duplication:
- Reduced code size
- Simplified exception handling as the finaliser code only exists in one place, so no "magic" is needed to get the correct handler for a finaliser.
- When we support instruction to line number mapping we won't need to worry about the dramatic code movement caused by duplication
On the downside it is necessary to add two new opcodes, op_jsr and op_sret
to enter and exit the finaliser subroutines, happily SunSpider reports
a performance progression (gcc amazes me) and ubench reports a wash.
While jsr and sret provide a mechanism that allows us to enter and exit
any arbitrary finaliser we need to, it was still necessary to increase
the amount of information tracked when entering and exiting both finaliser
scopes and dynamic scopes ("with"). This means "scopeDepth" is now
the combination of "finaliserDepth" and "dynamicScopeDepth". We also
now use a scopeContextStack to ensure that we pop scopes and execute
finalisers in the correct order. This increases the cost of "with" nodes
during codegen, but it should not be significant enough to effect real
world performance and greatly simplifies codegen for return, break and
continue when interacting with finalisers.
- 2:11 PM Changeset in webkit [32268] by
-
- 2 edits in trunk/WebKit/gtk
2008-04-19 Alp Toker <alp@nuanti.com>
Reviewed by Maciej.
Enable visited link tracking by default at startup.
With this patch, the GTK+ port rendering of Acid3 now matches the
reference page.
- webkit/webkitprivate.cpp: (WebKit::core): (webkit_init):
- 1:34 PM Changeset in webkit [32267] by
-
- 2 edits in trunk/WebKit/qt
2008-04-19 Julien Chaffraix <jchaffraix@webkit.org>
Qt build fix (renderer() -> contentRenderer()).
- Api/qwebframe.cpp: (QWebFrame::renderTreeDump): (QWebFrame::render):
- 9:00 AM Changeset in webkit [32266] by
-
- 2 edits in trunk/LayoutTests
2008-04-19 Brady Eidson <beidson@apple.com>
Update window-properties to add the profiler and fix a layout test
- fast/dom/Window/window-properties-expected.txt:
- 9:00 AM Changeset in webkit [32265] by
-
- 2 edits in trunk/WebKit/wx
wx build fix. renderer() -> contentRenderer()
- 2:39 AM Changeset in webkit [32264] by
-
- 2 edits in trunk/WebCore
2008-04-19 Alp Toker <alp@nuanti.com>
Reviewed by Nikolas.
Add text shadow support for simple text in FontCairo.
- platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
- 2:21 AM Changeset in webkit [32263] by
-
- 2 edits in trunk/WebCore
2008-04-19 David Hyatt <hyatt@apple.com>
Fix a minor typo in CSSGradientValue's cssText() method.
Reviewed by olliej
- css/CSSGradientValue.cpp: (WebCore::CSSGradientValue::cssText):
- 12:56 AM Changeset in webkit [32262] by
-
- 4 edits in trunk
2008-04-19 Mike Hommey <glandium@debian.org>
Reviewed by Alp Toker.
Don't build GtkLauncher and DumpRenderTree with rpath.
Don't build testkjs with rpath.
- 12:26 AM Changeset in webkit [32261] by
-
- 9 edits in trunk
WebCore:
2008-04-19 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher
Add LocalStorageDatabasePath to the settings for the location of persistent local storage.
- WebCore.base.exp:
- page/Settings.cpp: (WebCore::Settings::setLocalStorageDatabasePath):
- page/Settings.h: (WebCore::Settings::localStorageDatabasePath):
WebKit/mac:
2008-04-19 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher
Add a WebPreference for the path of the local storage persistent store.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.m: (-[WebPreferences _localStorageDatabasePath]): (-[WebPreferences _setLocalStorageDatabasePath:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
