Context Navigation

← Previous Period
Next Period →

Timeline

Apr 21, 2008:

11:47 PM Changeset in webkit [32373] by jhoneycutt@apple.com

3 edits in trunk/WebCore

2008-04-19 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Darin.

Add a method to get the AccessibilityObject's access key,

page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::accessKey): Added; returns the object's access key attribute.
page/AccessibilityObject.h: Added declaration for accessKey().

11:47 PM Changeset in webkit [32372] by jhoneycutt@apple.com

2 edits in trunk/WebKit/win

2008-04-19 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Darin.

Implement get_accHelp().

AccessibleBase.cpp: (AccessibleBase::get_accHelp): Report the result of calling the object's helpText() method.

11:46 PM Changeset in webkit [32371] by jhoneycutt@apple.com

2 edits in trunk/WebKit/win

2008-04-19 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Darin.

Implement get_accState().

AccessibleBase.cpp: (AccessibleBase::get_accState):

11:46 PM Changeset in webkit [32370] by jhoneycutt@apple.com

3 edits in trunk/WebKit/win

2008-04-18 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Darin.

Implement get_accRole().

AccessibleBase.cpp: (AccessibleBase::get_accRole): Report the result of role(). (MSAARole): Added; returns the MSAA role for a WebCore role. (AccessibleBase::role): Return the MSAA role for the object's roleValue.
AccessibleBase.h: Add declaration for role().

11:45 PM Changeset in webkit [32369] by jhoneycutt@apple.com

3 edits in trunk/WebKit/win

2008-04-18 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Darin.

Implement get_accName(), get_accValue(), get_accDescription(). Added
virtual methods that accessible objects can override to customize the
result.

AccessibleBase.cpp: (AccessibleBase::get_accName): Report result of name(). (AccessibleBase::get_accValue): Report result of value(). (AccessibleBase::get_accDescription): Report result of description(). (AccessibleBase::name): Added; returns AccessibilityObject::title(). (AccessibleBase::value): Added; returns AccessibilityObject::stringValue(). (AccessibleBase::description): Added; returns AccessibilityObject::accessibilityDescription().
AccessibleBase.h: Added declarations for name(), value(), and description().
ChangeLog: Fix my misuse of "definition."

10:47 PM Changeset in webkit [32368] by hyatt@apple.com

1 edit in trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt

Fix layout test results for new props.

10:35 PM Changeset in webkit [32367] by oliver@apple.com

5 edits in branches/squirrelfish/JavaScriptCore

Implement emitCode for ConstDeclNode.

Reviewed by Geoff

This fixes the crash (assertion) in js1_5/Scope/scope-001.js

10:20 PM Changeset in webkit [32366] by mjs@apple.com

3 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Sam.

add some support for the split window object

This fixes many layout tests.

VM/Machine.cpp: (KJS::resolveBaseAndFunc): Use toThisObject() to ensure we get the wrapper global, if one exists, as the "this" object.
kjs/function.cpp: (KJS::globalFuncEval): Use toGlobalObject() to handle the wrapper case properly.

10:17 PM Changeset in webkit [32365] by mjs@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.

restore ScopeChain::operator= to avoid crash on many layout tests

Otherwise, FunctionImp::setScope would cause a reference
underflow. I implemented using the copy construct and swap idiom.

kjs/scope_chain.h: (KJS::ScopeChain::swap): (KJS::ScopeChain::operator=):

9:44 PM Changeset in webkit [32364] by weinig@apple.com

2 edits in trunk/WebCore

2008-04-21 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Fix numerous crashing tests.

html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedIntoDocument): Null check document->frame().

9:06 PM Changeset in webkit [32363] by mrowe@apple.com

1 edit
2 moves
1 delete in trunk/LayoutTests

Fix the case on the file names of test results for svg/custom/altglyph.svg, and remove an extra -expected.txt that was checked in with incorrect
case.

platform/mac/svg/custom/altGlyph-expected.checksum: Removed.
platform/mac/svg/custom/altGlyph-expected.png: Removed.
platform/mac/svg/custom/altGlyph-expected.txt: Removed.
platform/mac/svg/custom/altglyph-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/altGlyph-expected.checksum.
platform/mac/svg/custom/altglyph-expected.png: Copied from LayoutTests/platform/mac/svg/custom/altGlyph-expected.png.

8:33 PM Changeset in webkit [32362] by weinig@apple.com

7 edits
9 adds in trunk

WebCore:

2008-04-21 Dan Bernstein <mitz@apple.com>

Reviewed by Darin Adler.

Tests: fast/media/implicit-media-all.html

fast/media/monochrome.html

allow implicit "all" media in media queries
use a value of 0 for the monochrome media feature on color displays

css/CSSGrammar.y:
css/CSSParser.cpp: (WebCore::CSSParser::createFloatingMediaQuery):
css/CSSParser.h:
css/MediaQueryEvaluator.cpp: (WebCore::monochromeMediaFeatureEval):

LayoutTests:

2008-04-21 Dan Bernstein <mitz@apple.com>

Reviewed by Darin Adler.

update acid3.html to reflect the updated test.
test for implicit "all" media in media queries
test that the value of the monochrome media feature is 0 on color displays

http/tests/misc/acid3.html:
fast/media/implicit-media-all.html: Added.
fast/media/monochrome.html: Added.
platform/mac/fast/media/implicit-media-all-expected.checksum: Added.
platform/mac/fast/media/implicit-media-all-expected.png: Added.
platform/mac/fast/media/implicit-media-all-expected.txt: Added.
platform/mac/fast/media/monochrome-expected.checksum: Added.
platform/mac/fast/media/monochrome-expected.png: Added.
platform/mac/fast/media/monochrome-expected.txt: Added.

5:42 PM Changeset in webkit [32361] by oliver@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

Bug 18649: SQUIRRELFISH: correctly handle exceptions in eval code
<https://bugs.webkit.org/show_bug.cgi?id=18649>

Reviewed by Geoff

Allocate a callframe for eval() and initialise with a null codeBlock to
indicate native code. This prevents the unwinder from clobbering the
register stack.

5:32 PM Changeset in webkit [32360] by ggaren@apple.com

2 edits in branches/squirrelfish/WebKit/mac

2008-04-21 Geoffrey Garen <ggaren@apple.com>

Build fix.

ChangeLog:
WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]):

5:11 PM Changeset in webkit [32359] by ggaren@apple.com

3 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Removed ScopeChain::push(ScopeChain&) because it was unused. Moved
ScopeChain::print to ScopeChainNode.

ScopeChain is now nothing more than a resource-handling wrapper around
ScopeChainNode.

5:08 PM SquirrelFish edited by ggaren@apple.com

(diff)

5:07 PM SquirrelFish edited by ggaren@apple.com

(diff)

5:04 PM Changeset in webkit [32358] by beidson@apple.com

5 edits in trunk/WebCore

2008-04-21 Brady Eidson <beidson@apple.com>

Rockingly reviewed by Adele

Small StorageArea cleanups

storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::copy): Pass "this" instead of the StorageMap belonging to this (WebCore::SessionStorageArea::SessionStorageArea):
storage/SessionStorageArea.h:

storage/StorageArea.cpp: Changed to not expose the StorageMap at all - it's dangerous to expose it since we rely explicitly on its ref-count (WebCore::StorageArea::StorageArea): Take another StorageArea as the c'tor argument and get the StorageMap from that. (WebCore::StorageArea::setItem): The previous comment/code here was bogus. All JS objects passed in to this API are stringified, so there's no such thing as "null" for setItem()
storage/StorageArea.h:

4:53 PM Changeset in webkit [32357] by mjs@apple.com

4 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Bug 18671: SquirrelFish: continue inside switch fails
<https://bugs.webkit.org/show_bug.cgi?id=18671>

VM/CodeGenerator.cpp: (KJS::CodeGenerator::jumpContextForLabel):
VM/CodeGenerator.h:
kjs/nodes.cpp: (KJS::ContinueNode::emitCode):

4:51 PM Changeset in webkit [32356] by dino@apple.com

4 edits
1 add in trunk/WebKitSite

Updated CSS Visual Effects proposals.

CSS Animations

described simplified sandwich model (that animations have no effect outside their duration and last specified animation wins)
diagram showing the above
specified animations to start at style resolution or document load, whichever is later.
animation start events always have elapsedTime == 0

CSS Transforms

removed text saying that elements cannot be drawn as intersecting.
described that preserve-3d trees often need a flattening parent, otherwise elements can be hidden behind their ancestor's background.
describe that preserve-3d is not always possible, such as when overflow is 'hidden'.

CSS Transitions

no change

specs/CSSVisualEffects/CSSAnimation.html:
specs/CSSVisualEffects/CSSTransforms.html:
specs/CSSVisualEffects/CSSTransitions.html:
specs/CSSVisualEffects/sandwich.png: Added.

4:22 PM Changeset in webkit [32355] by hyatt@apple.com

1 edit in trunk/WebCore/css/CSSParser.cpp

Fix Windows bustage.

4:13 PM Changeset in webkit [32354] by kmccullough@apple.com

4 edits in trunk/JavaScriptCore

2008-04-21 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adam.

<rdar://problem/5770054> JavaScript profiler (10928)

When stop profiling is called we need to stop the timers on all the functions that are still running.

profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::didExecute): (KJS::FunctionCallProfile::stopProfiling):
profiler/FunctionCallProfile.h:
profiler/Profiler.cpp: (KJS::Profiler::stopProfiling):

3:48 PM Changeset in webkit [32353] by justin.garcia@apple.com

4 edits
4 adds in trunk

WebCore:

2008-04-21 Justin Garcia <justin.garcia@apple.com>

Reviewed by John Sullivan.

<rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)

If we're doing InsertParagraphSeparator at the end of a header element, do not clone it.
Renamed m_useDefaultParagraphElement to m_mustUseDefaultParagraphElement, since now,
when it is false, that does not necessarily mean that a default paragraph element
will not be used. Callers that passed false for this argument are OK with this.

editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand): (WebCore::InsertParagraphSeparatorCommand::shouldUseDefaultParagraphElement): (WebCore::InsertParagraphSeparatorCommand::doApply):
editing/InsertParagraphSeparatorCommand.h:

LayoutTests:

2008-04-21 Justin Garcia <justin.garcia@apple.com>

Reviewed by John Sullivan.

<rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)

editing/inserting/5803706-1-expected.txt: Added.
editing/inserting/5803706-1.html: Added.
editing/inserting/5803706-2-expected.txt: Added.
editing/inserting/5803706-2.html: Added.

3:22 PM Changeset in webkit [32352] by mrowe@apple.com

5 edits in trunk/LayoutTests

Land updated results for three tests and disable three more on Tiger.

http/tests/xmlhttprequest/infoOnProgressEvent-expected.txt:
platform/mac-tiger/Skipped: Disable three tests using font-face that fail intermittently on Tiger bots.
platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Update Tiger results following r32247.
platform/mac-tiger/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt: Ditto.

3:21 PM Changeset in webkit [32351] by andersca@apple.com

8 edits in trunk/WebCore

2008-04-21 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Perform cache selection. If a main resource has a URL that exists in a cache, load it from there.

html/HTMLAttributeNames.in: Add manifest attribute.

html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedIntoDocument):
html/HTMLHtmlElement.h: Perform cache selection.

loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::load):
loader/appcache/ApplicationCacheGroup.cpp: (WebCore::cacheHostSet): (WebCore::urlHostHash): (WebCore::ApplicationCacheGroup::cacheForRequest): (WebCore::ApplicationCacheGroup::selectCache):
loader/appcache/ApplicationCacheGroup.h:
platform/KURL.h: (WebCore::KURL::hostStart): (WebCore::KURL::hostEnd):

3:14 PM Changeset in webkit [32350] by eric@webkit.org

2 edits in trunk/WebCore

Reviewed by eseidel and darin. Landed by eseidel.

Fix broken optimization in createStrippingNullCharacters.

platform/text/StringImpl.cpp: (WebCore::StringImpl::createStrippingNullCharacters):

3:03 PM Changeset in webkit [32349] by ggaren@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved push(JSObject*) and pop() from ScopeChain to ScopeChainNode,
rearranging scope_chain.h a bit.

SunSpider reports no change.

2:59 PM Changeset in webkit [32348] by hyatt@apple.com

10 edits in trunk

2008-04-21 David Hyatt <hyatt@apple.com>

Make the back end parsing of background properties generic. Rename all the parsing functions from
background -> fill.

Add a new set of properties for doing masks. The code is now refactored so that the mask properties
and the background properties share parsing routines.

Reviewed by Dan

css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::addFillValue): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseFillImage): (WebCore::CSSParser::parseFillPositionXY): (WebCore::CSSParser::parseFillPosition): (WebCore::CSSParser::parseFillSize): (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseTransformOrigin):
css/CSSParser.h:
css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::mapFillAttachment): (WebCore::CSSStyleSelector::mapFillClip): (WebCore::CSSStyleSelector::mapFillComposite): (WebCore::CSSStyleSelector::mapFillOrigin): (WebCore::CSSStyleSelector::mapFillImage): (WebCore::CSSStyleSelector::mapFillRepeat): (WebCore::CSSStyleSelector::mapFillSize): (WebCore::CSSStyleSelector::mapFillXPosition): (WebCore::CSSStyleSelector::mapFillYPosition):
rendering/RenderStyle.cpp: (WebCore::FillLayer::FillLayer): (WebCore::FillLayer::operator=): (WebCore::FillLayer::operator==): (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::diff):
rendering/RenderStyle.h: (WebCore::LengthSize::LengthSize): (WebCore::): (WebCore::FillLayer::type): (WebCore::FillLayer::initialFillAttachment): (WebCore::FillLayer::initialFillClip): (WebCore::FillLayer::initialFillOrigin): (WebCore::FillLayer::initialFillRepeat): (WebCore::FillLayer::initialFillComposite): (WebCore::FillLayer::initialFillSize): (WebCore::FillLayer::initialFillXPosition): (WebCore::FillLayer::initialFillYPosition): (WebCore::FillLayer::initialFillImage): (WebCore::RenderStyle::maskImage): (WebCore::RenderStyle::maskRepeat): (WebCore::RenderStyle::maskComposite): (WebCore::RenderStyle::maskAttachment): (WebCore::RenderStyle::maskClip): (WebCore::RenderStyle::maskOrigin): (WebCore::RenderStyle::maskXPosition): (WebCore::RenderStyle::maskYPosition): (WebCore::RenderStyle::maskSize): (WebCore::RenderStyle::accessMaskLayers): (WebCore::RenderStyle::maskLayers): (WebCore::RenderStyle::clearBackgroundLayers): (WebCore::RenderStyle::clearMaskLayers): (WebCore::RenderStyle::inheritMaskLayers):

1:55 PM Changeset in webkit [32347] by timothy@apple.com

2 edits in trunk/WebCore

Fixes the issue were a Database view could still be visible after navigating to a new page.

Reviewed by Darin Adler.

page/inspector/DatabasesPanel.js:

(WebInspector.DatabasesPanel.prototype.reset): Delete the _tableViews and _queryView properties
from all databases. Remove all the children from databaseViews.

1:54 PM Changeset in webkit [32346] by timothy@apple.com

3 edits in trunk/WebCore

Adds the ability to enter multi-line commands in the console by holding the
alt/option key when pressing enter/return.

https://bugs.webkit.org/show_bug.cgi?id=18454

Reviewed by Darin Adler.

page/inspector/Console.js:

(WebInspector.Console.prototype._enterKeyPressed): Return early if the
alt/option key is held when enter is pressed.

page/inspector/inspector.css:

(.console-message-text): Added. Set white-space: pre-wrap.

1:54 PM Changeset in webkit [32345] by timothy@apple.com

2 edits in trunk/WebCore

Fixes the bug where the Database table names do not update when
running the CREATE TABLE or DROP TABLE queries. Also makes the
table names update every time the database is collapsed and expanded.

https://bugs.webkit.org/show_bug.cgi?id=18453

Reviewed by Darin Adler.

page/inspector/DatabasesPanel.js:

(WebInspector.DatabasesPanel.prototype.updateDatabaseTables):
Set shouldRefreshChildren to true on the Database's tree element.
The refreshChildren property was renamed to shouldRefreshChildren.
(WebInspector.DatabaseSidebarTreeElement.prototype.oncollapse):
Request a refresh after every collapse so the next expand will
have an updated table list.

1:54 PM Changeset in webkit [32344] by timothy@apple.com

2 edits in trunk/WebCore

Adds INDEX to the list of completion words for the Databases query view.

https://bugs.webkit.org/show_bug.cgi?id=18452

Reviewed by Darin Adler.

page/inspector/DatabaseQueryView.js:

(WebInspector.DatabaseQueryView.prototype.completions): Split up "CREATE TABLE "
and "DROP TABLE " into "CREATE ", "DROP ", "TABLE ". And added "INDEX ".

1:53 PM Changeset in webkit [32343] by timothy@apple.com

7 edits
11 adds in trunk/WebCore

Adds the UI portions of the Scripts panel to the Web Inspector.
The Scripts panel has not been added to the toolbar yet.

https://bugs.webkit.org/show_bug.cgi?id=18601

Reviewed by Adam Roben.

English.lproj/InspectorLocalizedStrings.js: Changed "Show inherited properties"

to "Show inherited". Adds new strings for the Scripts' panel tooltips.

page/inspector/BreakpointsSidebarPane.js: Added.
page/inspector/CallStackSidebarPane.js: Added.
page/inspector/Images/back.png: Added.
page/inspector/Images/debuggerContinue.png: Added.
page/inspector/Images/debuggerPause.png: Added.
page/inspector/Images/debuggerStepInto.png: Added.
page/inspector/Images/debuggerStepOut.png: Added.
page/inspector/Images/debuggerStepOver.png: Added.
page/inspector/Images/forward.png: Added.
page/inspector/Images/statusbarResizerHorizontal.png: Added.
page/inspector/PropertiesSection.js:

(WebInspector.PropertiesSection): Flip the order the subtile is appended
so it can float right in the CSS.

page/inspector/ScriptsPanel.js: Added.
page/inspector/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection): Changed "Show inherited properties"
to "Show inherited".

page/inspector/inspector.css: Added new CSS rules for the Scripts panel.

Also changes the look of the section to match the mockup, this affects
Styles and Properties in Elements.

page/inspector/inspector.html: Import new files.
page/inspector/inspector.js:

(Preferences.minScriptsSidebarWidth): Added.

1:25 PM Changeset in webkit [32342] by kmccullough@apple.com

2 edits in trunk/WebCore

2008-04-21 Kevin McCullough <kmccullough@apple.com>

Reviewed by Adam.

<rdar://problem/5770054> JavaScript profiler (10928)
Took out debugging printing since we really want to hook into the
inspector and not to print to the terminal.

page/Console.cpp: (WebCore::Console::profileEnd):

1:23 PM Changeset in webkit [32341] by weinig@apple.com

4 edits in trunk/WebCore

2008-04-21 Sam Weinig <sam@webkit.org>

Reviewed by Alexey Proskuryakov.

Fix up XMLHttpRequestProgressEvent.

bindings/js/JSEventCustom.cpp: (WebCore::toJS):
xml/XMLHttpRequestProgressEvent.cpp:
xml/XMLHttpRequestProgressEvent.h:

1:15 PM Changeset in webkit [32340] by Adam Roben

2 edits in trunk/WebCore

Fix Bug 18615: Crash in PluginPackage::hash

<https://bugs.webkit.org/show_bug.cgi?id=18615>

Reviewed by Anders Carlsson.

plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::refresh): Don't pass a null PluginPackage* to add().

1:00 PM Changeset in webkit [32339] by andersca@apple.com

6 edits in trunk/WebCore

2008-04-21 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add cache group implementation.

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet): (WebCore::ApplicationCache::resourceForRequest):
loader/appcache/ApplicationCache.h:
loader/appcache/ApplicationCacheGroup.cpp: (WebCore::cacheGroupMap): (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): (WebCore::ApplicationCacheGroup::cacheDestroyed): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didReceiveData): (WebCore::ApplicationCacheGroup::didFinishLoading): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): (WebCore::ApplicationCacheGroup::didReceiveManifestData): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::cacheUpdateFailed): (WebCore::ApplicationCacheGroup::didFailToLoadManifest): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::ApplicationCacheGroup::addEntry): (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): (WebCore::ApplicationCacheGroup::callListenersOnAssociatedDocuments): (WebCore::ApplicationCacheGroup::callListeners):
loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::status): (WebCore::ApplicationCacheGroup::newestCache):
platform/KURL.h: (WebCore::KURL::hostStart): (WebCore::KURL::hostEnd):

12:59 PM Changeset in webkit [32338] by ggaren@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Moved bottom() from ScopeChain to ScopeChainNode, simplifying it based
on the knowledge that the ScopeChain is never empty.

SunSpider reports no change.

12:42 PM Changeset in webkit [32337] by ggaren@apple.com

4 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Moved begin() and end() from ScopeChain to ScopeChainNode.

Also marked a few methods "const".

SunSpider reports no change.

12:31 PM Changeset in webkit [32336] by ggaren@apple.com

4 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Turned ScopeChain::depth into a stand-alone function, and simplified it
a bit.

I also moved ScopeChain::depth to Machine.cpp because it doesn't report
the true depth of the ScopeChain -- just the Machine's perspective of
its depth within a given call frame.

SunSpider reports no change.

12:19 PM Changeset in webkit [32335] by ggaren@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Removed indirection in ScopeChain::ref / ScopeChain::deref.

SunSpider reports no change.

kjs/scope_chain.h: (KJS::ScopeChain::ScopeChain): (KJS::ScopeChain::~ScopeChain): (KJS::ScopeChain::clear):

12:14 PM Changeset in webkit [32334] by hyatt@apple.com

22 edits in trunk/WebCore

2008-04-21 David Hyatt <hyatt@apple.com>

Rename BackgroundLayer -> FillLayer in preparation for it being used for other types of fills.

Reviewed by Dan

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EFillBox): (WebCore::CSSPrimitiveValue::operator EFillRepeat):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapFillAttachment): (WebCore::CSSStyleSelector::mapFillClip): (WebCore::CSSStyleSelector::mapFillComposite): (WebCore::CSSStyleSelector::mapFillOrigin): (WebCore::CSSStyleSelector::mapFillImage): (WebCore::CSSStyleSelector::mapFillRepeat): (WebCore::CSSStyleSelector::mapFillSize): (WebCore::CSSStyleSelector::mapFillXPosition): (WebCore::CSSStyleSelector::mapFillYPosition): (WebCore::CSSStyleSelector::mapTransitionDuration): (WebCore::CSSStyleSelector::mapTransitionRepeatCount): (WebCore::CSSStyleSelector::mapTransitionTimingFunction): (WebCore::CSSStyleSelector::mapTransitionProperty):
css/CSSStyleSelector.h:
page/AnimationController.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation): (WebCore::CompositeImplicitAnimation::animate):
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBackgrounds): (WebCore::InlineFlowBox::paintBackground):
rendering/InlineFlowBox.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBackgrounds): (WebCore::RenderBox::paintBackground): (WebCore::RenderBox::calculateBackgroundSize): (WebCore::RenderBox::imageChanged): (WebCore::RenderBox::calculateBackgroundImageGeometry): (WebCore::RenderBox::paintBackgroundExtended):
rendering/RenderBox.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::updateBackgroundImages): (WebCore::RenderObject::arenaDelete):
rendering/RenderObject.h: (WebCore::RenderObject::paintBackgroundExtended):
rendering/RenderStyle.cpp: (WebCore::FillLayer::FillLayer): (WebCore::FillLayer::~FillLayer): (WebCore::FillLayer::operator=): (WebCore::FillLayer::operator==): (WebCore::FillLayer::fillUnsetProperties): (WebCore::FillLayer::cullEmptyLayers): (WebCore::Transition::fillUnsetProperties):
rendering/RenderStyle.h: (WebCore::): (WebCore::FillLayer::image): (WebCore::FillLayer::xPosition): (WebCore::FillLayer::yPosition): (WebCore::FillLayer::attachment): (WebCore::FillLayer::clip): (WebCore::FillLayer::origin): (WebCore::FillLayer::repeat): (WebCore::FillLayer::composite): (WebCore::FillLayer::size): (WebCore::FillLayer::next): (WebCore::FillLayer::isImageSet): (WebCore::FillLayer::isXPositionSet): (WebCore::FillLayer::isYPositionSet): (WebCore::FillLayer::isAttachmentSet): (WebCore::FillLayer::isClipSet): (WebCore::FillLayer::isOriginSet): (WebCore::FillLayer::isRepeatSet): (WebCore::FillLayer::isCompositeSet): (WebCore::FillLayer::isSizeSet): (WebCore::FillLayer::setImage): (WebCore::FillLayer::setXPosition): (WebCore::FillLayer::setYPosition): (WebCore::FillLayer::setAttachment): (WebCore::FillLayer::setClip): (WebCore::FillLayer::setOrigin): (WebCore::FillLayer::setRepeat): (WebCore::FillLayer::setComposite): (WebCore::FillLayer::setSize): (WebCore::FillLayer::clearImage): (WebCore::FillLayer::clearXPosition): (WebCore::FillLayer::clearYPosition): (WebCore::FillLayer::clearAttachment): (WebCore::FillLayer::clearClip): (WebCore::FillLayer::clearOrigin): (WebCore::FillLayer::clearRepeat): (WebCore::FillLayer::clearComposite): (WebCore::FillLayer::clearSize): (WebCore::FillLayer::setNext): (WebCore::FillLayer::operator!=): (WebCore::FillLayer::hasFixedImage): (WebCore::Transition::isDurationSet): (WebCore::Transition::isRepeatCountSet): (WebCore::Transition::isTimingFunctionSet): (WebCore::Transition::isPropertySet): (WebCore::Transition::clearDuration): (WebCore::Transition::clearRepeatCount): (WebCore::Transition::clearTimingFunction): (WebCore::Transition::clearProperty): (WebCore::Transition::duration): (WebCore::Transition::repeatCount): (WebCore::Transition::timingFunction): (WebCore::Transition::property): (WebCore::Transition::setDuration): (WebCore::Transition::setRepeatCount): (WebCore::Transition::setTimingFunction): (WebCore::Transition::setProperty): (WebCore::RenderStyle::NonInheritedFlags::operator==): (WebCore::RenderStyle::setBitDefaults): (WebCore::RenderStyle::backgroundRepeat): (WebCore::RenderStyle::backgroundComposite): (WebCore::RenderStyle::backgroundAttachment): (WebCore::RenderStyle::backgroundClip): (WebCore::RenderStyle::backgroundOrigin): (WebCore::RenderStyle::backgroundSize): (WebCore::RenderStyle::accessBackgroundLayers): (WebCore::RenderStyle::backgroundLayers): (WebCore::RenderStyle::clearBackgroundLayers): (WebCore::RenderStyle::inheritBackgroundLayers): (WebCore::RenderStyle::initialFillAttachment): (WebCore::RenderStyle::initialFillClip): (WebCore::RenderStyle::initialFillOrigin): (WebCore::RenderStyle::initialFillRepeat): (WebCore::RenderStyle::initialFillComposite): (WebCore::RenderStyle::initialFillSize): (WebCore::RenderStyle::initialFillXPosition): (WebCore::RenderStyle::initialFillYPosition): (WebCore::RenderStyle::initialFillImage): (WebCore::RenderStyle::initialWhiteSpace): (WebCore::RenderStyle::initialColor):
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::isControlStyled):
rendering/RenderTheme.h:
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):

12:06 PM Changeset in webkit [32333] by oliver@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

Fix debug build

11:57 AM Changeset in webkit [32332] by oliver@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

Bug 18664: SQUIRRELFISH: correctly throw a SyntaxError when parsing of eval code fails
<https://bugs.webkit.org/show_bug.cgi?id=18664>

Patch from Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver

Correctly throw a SyntaxError when parsing of eval code fails.

11:52 AM Changeset in webkit [32331] by oliver@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

Partial fix for Bug 18649: SQUIRRELFISH: correctly handle exceptions in eval code

Reviewed by Geoff

Make sure we correct the register state before jumping to vm_throw.

11:51 AM Changeset in webkit [32330] by ggaren@apple.com

1 edit in branches/squirrelfish/JavaScriptCore/ChangeLog

Fixed reviewer named in old commit message

11:51 AM Changeset in webkit [32329] by ggaren@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Simplified ScopeChain ref/deref.

SunSpider reports a .4% speedup.

kjs/scope_chain.h: (KJS::ScopeChainNode::ref): Removed this function because it was nonsense. ScopeChainNodes are initialized with a refCount of 1, so the loop was guaranteed to iterate exactly once.

11:39 AM Changeset in webkit [32328] by ggaren@apple.com

4 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Removed support for empty ScopeChains.

SunSpider reports no change.

11:35 AM Changeset in webkit [32327] by jchaffraix@webkit.org

2 edits in trunk/WebCore

2008-04-21 Julien Chaffraix <jchaffraix@webkit.org>

Rubber-stamped by Ap.

Add 2 explicit casts.
Fixes built on 64-bit machines (64-bit to 32-bit conversion warning).

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::dispatchProgressEvent):

11:24 AM Changeset in webkit [32326] by ggaren@apple.com

3 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Removed some completely unused ScopeChain member functions.

SunSpider reports no change.

11:21 AM Changeset in webkit [32325] by Adam Roben

2 edits in trunk/WebKitTools

Flush stdout/stderr after printing every #EOF separator

This fixes a hang when running the pixel tests on Windows

Reviewed by Mitz Pettel.

DumpRenderTree/win/DumpRenderTree.cpp: (dump): (main): We don't have to flush stdout/stderr in the arguments loop anymore, as runTest flushes for us.

11:21 AM Changeset in webkit [32324] by andersca@apple.com

8 edits in trunk/WebCore

2008-04-21 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Make it possible to load resources from the cache.
(Currently no documents are ever associated with a cache though.)

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::mainResourceApplicationCache): (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
loader/DocumentLoader.h:
loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::load):
loader/MainResourceLoader.h: (WebCore::MainResourceLoader::applicationCache):
loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::load):
loader/ResourceLoader.h:
loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::finishedLoadingMainResource):

11:19 AM Changeset in webkit [32323] by Adam Roben

2 edits in trunk/WebKitTools

Fix pixel tests

Scripts/run-webkit-tests: (sub readFromDumpToolWithTimer): Use readline instead of read to ensure that we don't read past the #EOF marker.

11:11 AM Changeset in webkit [32322] by ap@webkit.org

4 edits in trunk

Reviewed by Darin.

Move collector main thread initialization from WebKit/win to KJS::initializeThreading.

11:10 AM Changeset in webkit [32321] by ggaren@apple.com

5 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Avoid creating unnecessary ScopeChain objects, to reduce refcount churn.

SunSpider reports no change.

10:50 AM Changeset in webkit [32320] by eric@webkit.org

5 edits in trunk/WebCore

Reviewed by eseidel. Landed by eseidel.

Add FrameLoader::policyDocumentLoader, and change
provisionalDocumentLoader to have a const signature to be
consistent with documentLoader and activeDocumentLoader.

WebCore.base.exp:
WebCore.order:
loader/FrameLoader.cpp: (WebCore::FrameLoader::policyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader):
loader/FrameLoader.h:

10:46 AM SquirrelFish edited by ggaren@apple.com

(diff)

10:23 AM SquirrelFish edited by ggaren@apple.com

(diff)

9:09 AM Changeset in webkit [32319] by Adam Roben

2 edits in trunk/JavaScriptCore

MSVC build fix

Reviewed by Alexey Proskuryakov.

kjs/ustring.h: (KJS::UString::cost): Disable a warning about assigning a 32-bit size_t into a 31-bit size_t.

8:39 AM Changeset in webkit [32318] by jchaffraix@webkit.org

2 edits
5 adds in trunk

2008-04-21 Julien Chaffraix <jchaffraix@webkit.org>

Not reviewed, add missing files in my previous commit.

8:34 AM Changeset in webkit [32317] by eric@webkit.org

2 edits in trunk/LayoutTests

Stamped by Anders.

Make test work in Opera. Fix bug in results serialization.

fast/js/resources/function-toString-parentheses.js:

7:43 AM Changeset in webkit [32316] by jchaffraix@webkit.org

16 edits in trunk

2008-04-21 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Ap.

Bug 13596: Implement .onprogress handler on XMLHttpRequest objects to support
progressive download content length information.

Add the onprogress attribute to XMLHttpRequest and the necessary bindings.

We use a custom event XMLHttpRequestProgressEvent that is derived from ProgressEvent (as specified by the XHR2 specification) but also implement LSProgressEvent interface (to be compliant with Firefox event).

Test: http/tests/xmlhttprequest/infoOnProgressEvent.html

2008-04-21 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Ap.

Bug 13596: Implement .onprogress handler on XMLHttpRequest objects to support progressive download content length information.

http/tests/xmlhttprequest/infoOnProgressEvent-expected.txt: Added.
http/tests/xmlhttprequest/infoOnProgressEvent.html: Added.

7:29 AM Changeset in webkit [32315] by Simon Hausmann

4 edits in trunk/WebCore

Michael Goddard <michael.goddard@trolltech.com>

Better handle Qt binding object lifetime in JS.
Add explicit marking of JS objects created for Qt
bindings, and remove the gcProtect calls.

7:24 AM Changeset in webkit [32314] by Simon Hausmann

2 edits in trunk/WebCore

Add better support for RuntimeArray type conversions.
It seems that RuntimeArray claims to inherit ArrayInstance
(in the JS sense), but the C++ class doesn't, so properly
access RuntimeArrays. Also, properly support turning
a JS object into a QVariantMap, since we support the
reverse.

6:57 AM Changeset in webkit [32313] by Simon Hausmann

5 edits in trunk

Changed the return type of QWebFrame::evaluateJavaScript from a QString to a QVariant.

6:47 AM Changeset in webkit [32312] by Simon Hausmann

3 edits in trunk/WebCore

Simon Hausmann <Simon Hausmann>

Fix painting of text fields in the CleanLooks style.

The CleanLooks style calls painter->drawRect() and expects a painter
that has no brush set. This is a fairly common assumption and therefore
we now always set the brush to NoBrush before calling a style. This
is done by centralizing the painter setup code into StylePainter
and restore the old brush in the StylePainter destructor.

In addition for textfields it is not necessary anymore to draw
PE_FrameLineEdit as we set the lineWidth in the style option correctly
and it's the style responsibility (QCommonStyle usually) to draw
PE_FrameLineEdit.

6:47 AM Changeset in webkit [32311] by Simon Hausmann

2 edits in trunk/WebCore

Olivier Goffart <ogoffart@trolltech.com>

Fixes copy and paste of international characters.

When exporting HTML to the clipboard we need meta tags for now that confirm the
conversion to utf-8 done inside QClipboard.

6:47 AM Changeset in webkit [32310] by Simon Hausmann

2 edits in trunk/WebCore

Olivier Goffart <ogoffart@trolltech.com>

Fixes: Copying on X11 doesn't always work in webkit

Calling QClipboard::clear right before QClipboard::setData create a race condition with klipper. So don't call QClipboard::clear since it's not required.

6:40 AM Changeset in webkit [32309] by Simon Hausmann

2 edits in trunk/WebKit/qt

Simon Hausmann <Simon Hausmann>

Fixes redundant "Fonts" submenu in default lineedits that has only disabled items.

Don't show sub-menus that have only actions that are disabled.

6:40 AM Changeset in webkit [32308] by Simon Hausmann

8 edits in trunk/WebKit/qt

Kavindra Devi Palaraja <kdpalara@trolltech.com>.

Lots of documentation fixes, fixed all qdoc warnings.

5:24 AM Changeset in webkit [32307] by Simon Hausmann

2 edits in trunk/WebKit/qt

Marius Bugge Monsen <mmonsen@trolltech.com>

Fix compile failure on solaris-cc

5:11 AM Changeset in webkit [32306] by Simon Hausmann

6 edits in trunk

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Build fix for Qt 4.3

When building WebCore/internal make sure the QT_[BEGIN,END]_NAMESPACE is always defined. Do this by adding defines to the compiler line
For users of our API this is not feasible. Every public header file should include qwebkitglobal.h. Define the QT_BEGIN_NAMESPACE and QT_END_NAMESPACE when we are building everything < 4.4.0 and don't have them defined.

4:16 AM Changeset in webkit [32305] by Simon Hausmann

2 edits in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Assume that our lineedit has a frame. This is needed for the motif style

4:15 AM Changeset in webkit [32304] by Simon Hausmann

2 edits in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Follow the windows render theme when determining whether to style

listboxes or not.

4:15 AM Changeset in webkit [32303] by Simon Hausmann

2 edits in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Try to bring the notImplemented implementations closer together. This will print each unimplemted method name only once.

We might want to change wtf/Assertions.cpp to use qDebug

3:46 AM Changeset in webkit [32302] by Simon Hausmann

3 edits in trunk/WebCore

2008-04-21 Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Reviewed by Simon.

Remove the special Qt ctor of BitmapImage as it did not work. The Bitmap returned 0 as width and after intialising drawing would fail. BitmapImage relies on a proper ImageSource.
Instead of adding more special cases to BitmapImage create a new class called StillImage which is getting one QPixmap and is implementing Image::draw and Image::size. This is working well for the images created using Image::loadPlatformResource.

3:38 AM Changeset in webkit [32301] by Simon Hausmann

1 edit in trunk/WebCore/Resources/urlIcon.png

Whoops, fixed file permissions to not be executable.

3:28 AM Changeset in webkit [32300] by Simon Hausmann

2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Initialize the WebGraphics with the one found in WebCore

3:28 AM Changeset in webkit [32299] by Simon Hausmann

2 edits
1 add in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Package the Resources into a qrc

3:28 AM Changeset in webkit [32298] by Simon Hausmann

1 edit
6 adds in trunk/WebCore

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Make sure every resource is available als png as well.

3:27 AM Changeset in webkit [32297] by Simon Hausmann

2 edits in trunk/WebKit/qt

Holger Hans Peter Freyther <holger.freyther@trolltech.com>

Allow TextAreas to be resized.
No QWebSettings for this is introduced.

3:08 AM Changeset in webkit [32296] by Simon Hausmann

5 edits in trunk/WebKit/qt

Simon Hausmann <shausman@trolltech.com>

Fixes: QWebView::url property behaviour strange in designer

Added QWebView/QWebFrame::setUrl, which unlike load() clears the view immediately, schedules a load of the url but also makes sure url() returns the set url. This setter is now also used for the url property.

3:06 AM Changeset in webkit [32295] by mjs@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Alexey.

Add some braces.x

kjs/testkjs.cpp: (runWithScripts):

2:55 AM Changeset in webkit [32294] by Simon Hausmann

3 edits in trunk/WebKit/qt

Andre Poenitz <andre.poenitz@trolltech.com>

Fixe compilation with Qt namespaces

2:36 AM Changeset in webkit [32293] by Simon Hausmann

2 edits in trunk/WebKit/qt

When printing on high resolution printers we need to scale the painter accordingly (for now).

2:35 AM Changeset in webkit [32292] by Simon Hausmann

2 edits in trunk/WebKit/qt

Provide a print preview in the QtLauncher

1:34 AM Changeset in webkit [32291] by mjs@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver.

only print "End:" output when -d flag is passed.

This fixes half of our failing JSC regression tests.

kjs/testkjs.cpp: (runWithScripts):

12:39 AM Changeset in webkit [32290] by mjs@apple.com

9 edits in branches/squirrelfish/JavaScriptCore

2008-04-21 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Add support for variable declarations in eval code.

VM/CodeBlock.h: (KJS::EvalCodeBlock::EvalCodeBlock):
VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator):
VM/CodeGenerator.h:
VM/Machine.cpp: (KJS::Machine::execute):
VM/Machine.h:
kjs/function.cpp: (KJS::globalFuncEval):
kjs/nodes.cpp: (KJS::EvalNode::generateCode):
kjs/nodes.h: (KJS::EvalNode::):

Apr 20, 2008:

11:56 PM Changeset in webkit [32289] by oliver@apple.com

7 edits in branches/squirrelfish/JavaScriptCore

Throw exceptions for invalid continue, break, and return statements.

Reviewed by Maciej

Simple refactoring and extension of Cameron's AssignErrorNode, etc patch

11:35 PM Changeset in webkit [32288] by alp@webkit.org

2 edits in trunk/WebCore

2008-04-20 Sriram Neelakandan <sriram.neelakandan@gmail.com>

Reviewed by Alp Toker.

Implement FileSystemGtk's getFileModificationTime() with GLib.

platform/gtk/FileSystemGtk.cpp: (WebCore::getFileModificationTime):

11:02 PM Changeset in webkit [32287] by alp@webkit.org

1 edit
2 adds in trunk/WebCore

2008-04-20 Christian Persch <chpe@gnome.org>

Reviewed by Alp Toker.

Bundle GTK+ Xt compatibility code from Mozilla. These files are used
by all currently proposed GTK+ plugin patches and will make the
proposed patches smaller and easier to review.

These files should be kept as close to the upstream versions as
possible so fixes can be shared between projects and to ensure
compatibility with the reference implementation.

plugins/gtk/gtk2xtbin.c: Added. (xt_event_prepare): (xt_event_check): (xt_event_dispatch): (xt_event_polling_timer_callback): (gtk_xtbin_get_type): (gtk_xtbin_class_init): (gtk_xtbin_init): (gtk_xtbin_realize): (gtk_xtbin_new): (gtk_xtbin_set_position): (gtk_xtbin_resize): (gtk_xtbin_unrealize): (gtk_xtbin_destroy): (xt_client_init): (xt_client_create): (xt_client_unrealize): (xt_client_destroy): (xt_client_set_info): (xt_client_handle_xembed_message): (xt_client_event_handler): (send_xembed_message): (error_handler): (trap_errors): (untrap_error): (xt_client_focus_listener): (xt_add_focus_listener): (xt_remove_focus_listener): (xt_add_focus_listener_tree):
plugins/gtk/gtk2xtbin.h: Added.

10:43 PM SquirrelFishPerfIdeas edited by mjs@apple.com

(diff)

10:17 PM SquirrelFishPerfIdeas edited by mjs@apple.com

(diff)

10:16 PM Changeset in webkit [32286] by ggaren@apple.com

15 edits in branches/squirrelfish/JavaScriptCore

2008-04-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej Stachowiak.

Removed Machine.cpp from AllInOneFile.cpp, and manually inlined a few
things that used to be inlined automatically.

1.9% speedup on SunSpider.

My hope is that we'll face fewer surprises in Machine.cpp codegen, now
that GCC is making fewer decisions. The speedup seems to confirm that.

8:22 PM SquirrelFishPerfIdeas edited by mjs@apple.com

(diff)

7:55 PM Changeset in webkit [32285] by oliver@apple.com

2 edits in branches/squirrelfish/JavaScriptCore

Bug 18642: Iterator context may get placed into the return register, leading to much badness
<https://bugs.webkit.org/show_bug.cgi?id=18642>

Reviewed by Maciej

To prevent incorrectly reusing what will become the result register for
eval and global code execution, we need to request and ref the destination
in advance of codegen. Unfortunately this may lead to unnecessary copying,
although in future we can probably limit this. Curiously SunSpider shows
a progression in a number of tests, although it comes out as a wash overall.

This also fixes one of the regressions in run-javascriptcore-tests.

6:56 PM SquirrelFishPerfIdeas edited by mjs@apple.com

(diff)

5:34 PM SquirrelFishPerfIdeas edited by mjs@apple.com

(diff)

5:30 PM SquirrelFishPerfIdeas edited by mjs@apple.com

(diff)

5:30 PM SquirrelFishPerfIdeas edited by mjs@apple.com

(diff)

5:29 PM SquirrelFishPerfIdeas created by mjs@apple.com

5:22 PM Changeset in webkit [32284] by alp@webkit.org

2 edits in trunk/WebCore

2008-04-20 Dirk Schulze <vbs85@gmx.de>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=15449
[CAIRO] SVG gradients do not work properly

Fixed SVG-gradients in Cairo.

svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: (WebCore::SVGPaintServerGradient::setup):

5:16 PM SquirrelFish edited by mjs@apple.com

(diff)

5:05 PM ApplicationsGtk edited by alp@atoker.com

Add Skipstone and tinymail UI library (diff)

4:46 PM SquirrelFish edited by mjs@apple.com

(diff)

4:29 PM Changeset in webkit [32283] by mjs@apple.com

8 edits in branches/squirrelfish/JavaScriptCore

2008-04-20 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Maciej.

Add support for AssignErrorNode, PrefixErrorNode, and PostfixErrorNode.

VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitCreateError):
VM/CodeGenerator.h:
VM/Machine.cpp: (KJS::Machine::privateExecute):
VM/Opcode.h:
kjs/nodes.cpp: (KJS::PostfixErrorNode::emitCode): (KJS::PrefixErrorNode::emitCode): (KJS::AssignErrorNode::emitCode):
kjs/nodes.h:

4:09 PM SquirrelFishBlockers edited by mjs@apple.com