⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 29, 2008:

6:31 PM Changeset in webkit [37089] by mjs@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-09-29 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin Adler.



It's pretty common in real-world code (and on some of the v8
benchmarks) to append a number to a string, so I made this one of
the fast cases, and also added support to UString to do it
directly without allocating a temporary UString.


~1% speedup on v8 benchmark.

  • VM/Machine.cpp: (JSC::jsAddSlowCase): Make this NEVER_INLINE because somehow otherwise the change is a regression. (JSC::jsAdd): Handle number + string special case. (JSC::Machine::cti_op_add): Integrate much of the logic of jsAdd to avoid exception check in the str + str, num + num and str + num cases.
  • kjs/ustring.cpp: (JSC::expandedSize): Make this a non-member function, since it needs to be called in non-member functions but not outside this file. (JSC::expandCapacity): Ditto. (JSC::UString::expandCapacity): Call the non-member version. (JSC::createRep): Helper to make a rep from a char*. (JSC::UString::UString): Use above helper. (JSC::concatenate): Guts of concatenating constructor for cases where first item is a UString::Rep, and second is a UChar* and length, or a char*. (JSC::UString::append): Implement for cases where first item is a UString::Rep, and second is an int or double. Sadly duplicates logic of UString::from(int) and UString::from(double).
  • kjs/ustring.h:
6:14 PM Changeset in webkit [37088] by Darin Adler
  • 10 edits in trunk

JavaScriptCore:

2008-09-29 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • JavaScriptCore.exp: Updated since JSGlobalObject::init no longer takes a parameter.
  • VM/Machine.cpp: (JSC::Machine::execute): Removed m_registerFile argument for ExecState constructors.
  • kjs/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): Removed globalThisValue argument for ExecState constructor.
  • kjs/ExecState.cpp: (JSC::ExecState::ExecState): Removed globalThisValue and registerFile arguments to constructors.
  • kjs/ExecState.h: Removed m_globalThisValue and m_registerFile data members.
  • kjs/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): Removed globalThisValue argument for ExecState constructor.
  • kjs/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject): Got rid of parameter for the init function.

WebCore:

2008-09-29 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): Removed globalThisValue argument for base class constructor.
6:03 PM Changeset in webkit [37087] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-09-29 Geoffrey Garen <​ggaren@apple.com>

Rubber-stamped by Cameron Zwarich.


Fixed ​https://bugs.webkit.org/show_bug.cgi?id=21225
Machine::retrieveLastCaller should check for a NULL codeBlock


In order to crash, you would need to call retrieveCaller in a situation
where you had two host call frames in a row in the register file. I
don't know how to make that happen, or if it's even possible, so I don't
have a test case -- but better safe than sorry!

  • VM/Machine.cpp: (JSC::Machine::retrieveLastCaller):
5:46 PM Changeset in webkit [37086] by ggaren@apple.com
  • 13 edits
    2 copies
    6 adds in trunk

JavaScriptCore:

2008-09-29 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.


Store the callee ScopeChain, not the caller ScopeChain, in the call frame
header. Nix the "scopeChain" local variable and ExecState::m_scopeChain, and
access the callee ScopeChain through the call frame header instead.

Profit: call + return are simpler, because they don't have to update the
"scopeChain" local variable, or ExecState::m_scopeChain.


Because CTI keeps "r" in a register, reading the callee ScopeChain relative
to "r" can be very fast, in any cases we care to optimize.

0% speedup on empty function call benchmark. (5.5% speedup in bytecode.)
0% speedup on SunSpider. (7.5% speedup on controlflow-recursive.)
2% speedup on SunSpider --v8.
2% speedup on v8 benchmark.

  • VM/CTI.cpp: Changed scope chain access to read the scope chain from the call frame header. Sped up op_ret by changing it not to fuss with the "scopeChain" local variable or ExecState::m_scopeChain.
  • VM/CTI.h: Updated CTI trampolines not to take a ScopeChainNode* argument, since that's stored in the call frame header now.
  • VM/Machine.cpp: Access "scopeChain" and "codeBlock" through new helper functions that read from the call frame header. Updated functions operating on ExecState::m_callFrame to account for / take advantage of the fact that Exec:m_callFrame is now never NULL.


Fixed a bug in op_construct, where it would use the caller's default
object prototype, rather than the callee's, when constructing a new object.

  • VM/Machine.h: Made some helper functions available. Removed ScopeChainNode* arguments to a lot of functions, since the ScopeChainNode* is now stored in the call frame header.
  • VM/RegisterFile.h: Renamed "CallerScopeChain" to "ScopeChain", since that's what it is now.
  • kjs/DebuggerCallFrame.cpp: Updated for change to ExecState signature.
  • kjs/ExecState.cpp:
  • kjs/ExecState.h: Nixed ExecState::m_callFrame, along with the unused isGlobalObject function.
  • kjs/JSGlobalObject.cpp:
  • kjs/JSGlobalObject.h: Gave the global object a fake call frame in which to store the global scope chain, since our code now assumes that it can always read the scope chain out of the ExecState's call frame.

JavaScriptGlue:

2008-09-29 Geoffrey Garen <​ggaren@apple.com>

Not reviewed.


Forwarding headers to fix the build.

  • ForwardingHeaders/kjs/CTI.h: Copied from ForwardingHeaders/kjs/ExecState.h.
  • ForwardingHeaders/kjs/ustring.h: Copied from ForwardingHeaders/kjs/ExecState.h.
  • ForwardingHeaders/masm: Added.
  • ForwardingHeaders/masm/X86Assembler.h: Added.
  • ForwardingHeaders/profiler: Added.
  • ForwardingHeaders/profiler/Profiler.h: Added.

LayoutTests:

2008-09-29 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.


Test case for which prototype is used when calling "new" across windows.

  • fast/js/construct-global-object-expected.txt: Added.
  • fast/js/construct-global-object.html: Added.
5:42 PM Changeset in webkit [37085] by hyatt@apple.com
  • 4 edits
    1 add in trunk/WebCore

2008-09-29 David Hyatt <​hyatt@apple.com>

Add the new HostWindow base class. A HostWindow hosts a hierarchy of Widgets. The Chrome object on Page
now subclasses from HostWindow. The new class will allow objects in platform/ like Widgets, Scrollbars
and ScrollViews to talk to the HostWindow object in order to do backing store operations and invalidations.
(Right now the platform layering is simply being violated by ScrollViews going directly to the ChromeClient.)

Reviewed by Sam Weinig

  • WebCore.xcodeproj/project.pbxproj:
  • page/Chrome.h:
  • platform/HostWindow.h: Added. (WebCore::HostWindow::HostWindow): (WebCore::HostWindow::~HostWindow):
5:17 PM Changeset in webkit [37084] by kdecker@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • bridge/npapi.h: Tweaked NPNVariable enum. NPNVsupportsCocoaBool, NPNVsupportsCarbonBool are now in the 3000 range instead of
4:42 PM Changeset in webkit [37083] by mitz@apple.com
  • 5 edits in trunk

WebCore:

Reviewed by Adam Roben.

  • WebCore part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::setWebKitIsBeingUnloaded): Added. (WebCore::RenderThemeWin::~RenderThemeWin): Check if WebKit is being unloaded, to avoid calling uxtheme.dll functions after that library has been unloaded.
  • rendering/RenderThemeWin.h:

WebKit/win:

Reviewed by Adam Roben.

  • WebKit/win part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
  • WebKitDLL.cpp: (DllMain): Call RenderThemeWin::setWebKitIsBeingUnloaded() when WebKit is being unloaded.
4:10 PM Changeset in webkit [37082] by Chris Fleizach
  • 2 edits in trunk/WebCore

<rdar://problem/6240743> AXLoadComplete is sent for non-top level web areas and bogus web areas

3:50 PM Changeset in webkit [37081] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

3:49 PM Changeset in webkit [37080] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.4

New tag.

3:34 PM Changeset in webkit [37079] by timothy@apple.com
  • 6 edits in trunk/WebCore

Makes the node highlight always show up when hovering a node in
the Web Inspector now that the highlight does not scroll to reveal
the node. Also adds a hover effect in the inspector when hovering
causes a highlight in the page. This ties the user hovering action
to the highlight so it is clear what causes the highlight to appear.

Also the highlight now temporarily shows up for 2 seconds after
selecting a node in the DOM tree. So arrowing around in the tree
will show the node on the page, providing feedback to the user.

Plus fixes an issue where quickly moving away from hovering
a node would keep showing the page highlight. This was happening
in breadcrumbs and the DOM tree.

​https://bugs.webkit.org/show_bug.cgi?id=21220

Reviewed by Kevin McCullough.

  • page/inspector/Console.js: (WebInspector.Console.prototype._mouseOverNode): Added. Used for hovering DOM nodes in the console. (WebInspector.Console.prototype._mouseOutOfNode): Ditto. (WebInspector.Console.prototype._formatnode): Use the new event listeners and add a class name to the anchor element.
  • page/inspector/ElementsPanel.js: (WebInspector.ElementsPanel): Add new event listeners to the crumbs element to do the node hovering highlight. (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype._mouseMovedInCrumbs): (WebInspector.ElementsPanel.prototype._mouseMovedOutOfCrumbs): (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  • page/inspector/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode): Show the node hishlight for 2 seconds then restore the highlight to the current hovered node. (WebInspector.ElementsTreeOutline.prototype._onmousemove): Set the hovered node and set the hovered state on the tree element. (WebInspector.ElementsTreeOutline.prototype._onmouseout): Set the hovered node to null and removed the hovered state from the previous hovered tree element. (WebInspector.ElementsTreeElement.prototype.set/get hovered): Adds the hovered class to the list item. (WebInspector.ElementsTreeElement.prototype.onattach): Ditto.
  • page/inspector/inspector.css:
  • page/inspector/inspector.js: (WebInspector.set hoveredDOMNode): Pass a delay to _updateHoverHighlightSoon based on the showingDOMNodeHighlight property of 50ms or 500ms. This causes the highlight to change sooner if there is one already showing and appear later if there isn't one showing. This is like tooltips, hovering a node for 500ms will cause highlight then mousing between nodes will keep the highlight and change to the new node. (WebInspector._updateHoverHighlightSoon): Take a delay being passed in and always reset the timeout so continuous mousing does not keep flasshing the highlight on the screen. (WebInspector._updateHoverHighlight): Removed the alt key check and added the showingDOMNodeHighlight property. (WebInspector.documentKeyDown): Removed the alt key check. (WebInspector.documentKeyUp): Ditto. (WebInspector.reset): Clear the hoveredDOMNode.
3:04 PM Changeset in webkit [37078] by Simon Fraser
  • 3 edits in trunk/WebCore

2008-09-29 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson

Fix RenderStyle leak in animation code, and assert that
keyframe resolution in CSSStyleSelector is not going to clobber
m_style.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::~KeyframeAnimation):
2:31 PM Changeset in webkit [37077] by Simon Fraser
  • 14 edits
    2 adds in trunk

2008-09-29 Chris Marrin <​cmarrin@apple.com>

Reviewed by Dave Hyatt

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=20995
Rewrite keyframe resolution to be like styleForElement()

Test: animations/lineheight-animation.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addKeyframeStyle): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::keyframeStylesForAnimation): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::mapAnimationName):
  • css/CSSStyleSelector.h:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateKeyframeAnimations):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::KeyframeAnimation): (WebCore::KeyframeAnimation::animate): (WebCore::KeyframeAnimation::hasAnimationForProperty): (WebCore::KeyframeAnimation::sendAnimationEvent): (WebCore::KeyframeAnimation::overrideAnimations): (WebCore::KeyframeAnimation::resumeOverriddenAnimations): (WebCore::KeyframeAnimation::affectsProperty): (WebCore::KeyframeAnimation::validateTransformFunctionList):
  • page/animation/KeyframeAnimation.h:
  • rendering/style/Animation.cpp: (WebCore::Animation::animationsMatch):
  • rendering/style/Animation.h:
  • rendering/style/KeyframeList.cpp: (WebCore::KeyframeList::~KeyframeList): (WebCore::KeyframeList::clear): (WebCore::KeyframeList::insert):
  • rendering/style/KeyframeList.h: (WebCore::KeyframeValue::KeyframeValue): (WebCore::KeyframeList::KeyframeList): (WebCore::KeyframeList::operator!=): (WebCore::KeyframeList::animationName): (WebCore::KeyframeList::addProperty): (WebCore::KeyframeList::containsProperty): (WebCore::KeyframeList::beginProperties): (WebCore::KeyframeList::endProperties): (WebCore::KeyframeList::isEmpty): (WebCore::KeyframeList::size): (WebCore::KeyframeList::beginKeyframes): (WebCore::KeyframeList::endKeyframes):
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.cpp:
  • rendering/style/StyleRareNonInheritedData.h:
2:24 PM Changeset in webkit [37076] by Simon Fraser
  • 4 edits
    2 adds in trunk

2008-09-29 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel

Clean up fix in PropertyWrapperGetter::equals
​https://bugs.webkit.org/show_bug.cgi?id=21011

Test: transitions/override-transition-crash.html

  • page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperGetter::equals):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
2:21 PM Changeset in webkit [37075] by Simon Fraser
  • 6 edits
    2 adds in trunk

2008-09-29 Chris Marrin <​cmarrin@apple.com>

Reviewed by Eric Seidel

​https://bugs.webkit.org/show_bug.cgi?id=21001
Starting transition after animation, when animation
is finished, transition is wrong.

Test: animations/transition-and-animation-2.html

  • page/animation/AnimationBase.h:
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::resetTransitions): (WebCore::CompositeAnimation::cleanupFinishedAnimations):
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation): (WebCore::ImplicitAnimation::~ImplicitAnimation): (WebCore::ImplicitAnimation::animate): (WebCore::ImplicitAnimation::reset):
  • page/animation/ImplicitAnimation.h:
2:18 PM Changeset in webkit [37074] by Simon Fraser
  • 6 edits
    2 adds in trunk

2008-09-29 Chris Marrin <​cmarrin@apple.com>

Reviewed by Sam Weinig

​https://bugs.webkit.org/show_bug.cgi?id=20921
-webkit-animation-timing-function: inside of keyframes is ignored

Test: animations/keyframe-timing-functions.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::progress):
  • page/animation/AnimationBase.h:
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::animate):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate):
2:09 PM Changeset in webkit [37073] by Simon Fraser
  • 1 edit
    5 adds in trunk/LayoutTests

2008-09-29 Chris Marrin <​cmarrin@apple.com>

Reviewed by Darin Adler

Testcase for crash when parsing keyframes from an @imported
CSS file
​https://bugs.webkit.org/show_bug.cgi?id=20855

  • animations/import-crash-expected.txt: Added.
  • animations/import-crash.html: Added.
  • animations/import-expected.txt: Added.
  • animations/import.html: Added.
  • animations/resources/keyframes.css: Added.
2:04 PM Changeset in webkit [37072] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix, take 3

1:57 PM Changeset in webkit [37071] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix, take 2

1:52 PM Changeset in webkit [37070] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

1:09 PM Changeset in webkit [37069] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-09-29 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21218

Accidentally removed a check to see if the scrollbar modes were equal. This caused a crash on Windows.
It's silly that the code was this fragile, but for now just put the check back in.

Reviewed by Dan Bernstein

  • platform/ScrollView.cpp: (WebCore::ScrollView::setScrollbarModes):
12:49 PM Changeset in webkit [37068] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-09-29 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Sam Weinig.

Remove the isActivationObject() virtual method on JSObject and use
StructureID information instead. This should be slightly faster, but
isActivationObject() is only used in assertions and unwinding the stack
for exceptions.

  • VM/Machine.cpp: (JSC::depth): (JSC::Machine::unwindCallFrame): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_ret_activation):
  • kjs/JSActivation.cpp:
  • kjs/JSActivation.h:
  • kjs/JSObject.h:
12:46 PM Changeset in webkit [37067] by hyatt@apple.com
  • 8 edits in trunk/WebCore

2008-09-29 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21216

Make setScrollPosition and scroll() cross-platform.

Reviewed by Anders

  • platform/ScrollView.cpp: (WebCore::ScrollView::setScrollPosition): (WebCore::ScrollView::scroll):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformSetScrollPosition): (WebCore::ScrollView::platformScroll):
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/ScrollViewWin.cpp:
  • platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::platformSetScrollPosition): (WebCore::ScrollView::platformScroll):
12:09 PM Changeset in webkit [37066] by kmccullough@apple.com
  • 3 edits in trunk/WebCore

2008-09-29 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Oliver.

Bug 21139: Profiler log message is wrong

  • Because _format was called twice the number in the log was incremented too many times, but we were passing it around in the link the whole time
  • page/inspector/ProfilesPanel.js:
  • page/inspector/inspector.js:
12:09 PM Changeset in webkit [37065] by weinig@apple.com
  • 6 edits in trunk/WebCore

2008-09-29 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Autogenerate EventListeners, addEventListener and removeEventListener
for JSDOMWindow.

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::onwebkitanimationstart): (WebCore::JSDOMWindow::setOnwebkitanimationstart): (WebCore::JSDOMWindow::onwebkitanimationiteration): (WebCore::JSDOMWindow::setOnwebkitanimationiteration): (WebCore::JSDOMWindow::onwebkitanimationend): (WebCore::JSDOMWindow::setOnwebkitanimationend): (WebCore::JSDOMWindow::onwebkittransitionend): (WebCore::JSDOMWindow::setOnwebkittransitionend): (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): (WebCore::JSDOMWindow::setListener): (WebCore::JSDOMWindow::getListener):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
9:08 AM Changeset in webkit [37064] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-09-29 Gunnar Sletta <​gunnar@trolltech.com>

Reviewed by Simon

Compile on windows using MSVC 2005

For the PCH We need to define _WIN32_WINNT and include windows.h early on,
otherwise we'll miss several functions.

9:03 AM Changeset in webkit [37063] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-09-29 Peter Gal <​galpeter@inf.u-szeged.hu>

Reviewed and tweaked by Darin Adler.

Fix build for non-all-in-one platforms.

  • kjs/StringPrototype.cpp: Added missing ASCIICType.h include.
7:55 AM Changeset in webkit [37062] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-09-29 Bradley T. Hughes <​bradley.hughes@nokia.com>

Reviewed by Simon.

Fix compilation with icpc

5:47 AM Changeset in webkit [37061] by Simon Hausmann
  • 139 edits in trunk

2008-09-29 Thiago Macieira <​thiago.macieira@nokia.com>

Reviewed by Simon.

Changed copyright from Trolltech ASA to Nokia.

Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.

4:48 AM Changeset in webkit [37060] by jchaffraix@webkit.org
  • 11 edits
    2 adds in trunk

WebCore:

2008-09-26 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 5727: We want to evaluate scripts in viewless documents
​https://bugs.webkit.org/show_bug.cgi?id=5727

Add the posibility to evaluate script or fetch resources on viewless
document using the EmptyClient workaround.

Test: fast/loader/viewless-document.html

  • dom/Document.h: (WebCore::Document::setFrame): Method to set the Document's Frame, added a warning that it should be used under special circumstances.
  • dom/ScriptElement.cpp: (WebCore::ScriptElementData::requestScript): If the frame is empty (viewless document), get a dummy Frame to be able to evalute the script. (WebCore::ScriptElementData::evaluateScript): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Take a bool to toogle empty Document creation.

(WebCore::FrameLoader::fakeLoad): Fake remote resource load.

(WebCore::FrameLoader::createDummyFrame):

  • loader/FrameLoader.h:
  • page/Frame.cpp: (WebCore::Frame::isDummyFrame): (WebCore::Frame::setIsDummyFrame): (WebCore::Frame::setDocument):

(WebCore::FramePrivate::FramePrivate): Added m_isDummyFrame.
(WebCore::FramePrivate::~FramePrivate): We have to free the Page if it is a dummyFrame
(a dummyFrame own its Page).

  • page/Frame.h:
  • page/FramePrivate.h:
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::SVGImage): (WebCore::SVGImage::dataChanged): Use the dummy Frame work-around.
  • svg/graphics/SVGImage.h: Removed unused members.

LayoutTests:

2008-09-26 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric Seidel.


Bug 5727: We want to evaluate scripts in viewless documents
​https://bugs.webkit.org/show_bug.cgi?id=5727


  • fast/loader/viewless-document-expected.txt: Added.
  • fast/loader/viewless-document.html: Added.


4:46 AM QtWebKitContrib edited by ariya.hidayat@trolltech.com
(diff)
4:24 AM QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
4:24 AM QtWebKitJournal created by ariya.hidayat@trolltech.com
4:14 AM QtWebKitTodo edited by ariya.hidayat@trolltech.com
(diff)
2:03 AM Changeset in webkit [37059] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-09-29 Thiago Macieira <​thiago.macieira@trolltech.com>

Reviewed by Simon

Fix compilation with gcc 4.3

gcc 4.3 is stricter and ctype.h isn't getting included

automatically here by dependencies. So do it directly.

2:02 AM Changeset in webkit [37058] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-09-29 Morten Sørvig <​msorvig@trolltech.com>

Reviewed by Simon.

Fix compilation with Qt/Mac without plugins.

2:02 AM Changeset in webkit [37057] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-09-29 Simon Hausmann <Simon Hausmann>

Reviewed by Lars.

Don't accidentially install libJavaScriptCore.a for the build inside
Qt.

1:20 AM Changeset in webkit [37056] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Apply the ASCII fast path optimization from StringImpl::lower to StringImpl::upper.
In the few places that we call .upper() in WebCore the strings represent things like
tag and attribute names, which are nearly always going to be ASCII.

Reviewed by Sam Weinig.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::lower): If we have to resize the buffer, be sure to pass the new length
in to Unicode::toLower the second time.
(WebCore::StringImpl::upper):

1:19 AM Changeset in webkit [37055] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Speed up getPropertyValue('clip') by 25% by using a Vector<UChar> for building a string,
rather than String::operator+=.

Reviewed by Sam Weinig.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText):

1:19 AM Changeset in webkit [37054] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Speed up computedStyle.getPropertyValue('color') by 4.5x.

Using a Vector<UChar> while building up the property's cssText is substantially cheaper than using String::operator+=
as it avoids many memory reallocations.

This also speeds up the jQuery .offset() benchmark at <​http://dev.jquery.com/~john/speed/1.2.6/offset-1.2.6.html>
by 20% due to jQuery's strange need to call getPropertyValue('color') when retrieving the computed styles for
unrelated properties on an element.

Reviewed by Oliver Hunt.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::cssText): Build the result for the color types into a Vector<UChar>
and use appendNumber rather than the String::number in order to cut down on memory allocations.

  • platform/text/PlatformString.h:

(WebCore::appendNumber): A helper function for formatting an unsigned character as a number
into a Vector<UChar>.

Sep 28, 2008:

9:17 PM Changeset in webkit [37053] by weinig@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix spelling

9:16 PM Changeset in webkit [37052] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-09-28 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Remove spurious call to lower().

  • css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator):
8:41 PM Changeset in webkit [37051] by weinig@apple.com
  • 3 edits in trunk/WebCore

2008-09-28 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Use a CaseFoldingHash instead of calling lower on family strings.

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): (WebCore::CSSFontSelector::getFontData):
  • css/CSSFontSelector.h:
8:04 PM Changeset in webkit [37050] by cwzwarich@webkit.org
  • 18 edits in trunk/JavaScriptCore

2008-09-28 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej Stachowiak.

Bug 21200: Allow direct access to 'arguments' without using op_resolve
<​https://bugs.webkit.org/show_bug.cgi?id=21200>

Allow fast access to the 'arguments' object by adding an extra slot to
the callframe to store it.

  • JavaScriptCore.exp:
  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
  • VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::registerFor):
  • VM/CodeGenerator.h: (JSC::CodeGenerator::registerFor):
  • VM/Machine.cpp: (JSC::Machine::initializeCallFrame): (JSC::Machine::dumpRegisters): (JSC::Machine::privateExecute): (JSC::Machine::retrieveArguments): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_construct_JSConstruct):
  • VM/Machine.h:
  • VM/Opcode.h:
  • VM/RegisterFile.h: (JSC::RegisterFile::):
  • kjs/JSActivation.cpp: (JSC::JSActivation::mark): (JSC::JSActivation::argumentsGetter):
  • kjs/JSActivation.h: (JSC::JSActivation::JSActivationData::JSActivationData):
  • kjs/NodeInfo.h:
  • kjs/Parser.cpp: (JSC::Parser::didFinishParsing):
  • kjs/Parser.h: (JSC::Parser::parse):
  • kjs/grammar.y:
  • kjs/nodes.cpp: (JSC::ScopeNode::ScopeNode): (JSC::ProgramNode::ProgramNode): (JSC::ProgramNode::create): (JSC::EvalNode::EvalNode): (JSC::EvalNode::create): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::create):
  • kjs/nodes.h: (JSC::ScopeNode::usesArguments):
7:45 PM Changeset in webkit [37049] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Add an ASCII fast-path to toLowerCase and toUpperCase.

The fast path speeds up the common case of an ASCII-only string by up to 60% while adding a less than 5% penalty
to the less common non-ASCII case.

This also removes stringProtoFuncToLocaleLowerCase and stringProtoFuncToLocaleUpperCase, which were identical
to the non-locale variants of the functions. toLocaleLowerCase and toLocaleUpperCase now use the non-locale
variants of the functions directly.

Reviewed by Sam Weinig.

  • kjs/StringPrototype.cpp:

(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):

7:00 PM Changeset in webkit [37048] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Speed up parseInt and parseFloat.

Repeatedly indexing into a UString is slow, so retrieve a pointer into the underlying buffer once up front
and use that instead. This is a 7% win on a parseInt/parseFloat micro-benchmark.

Reviewed by Cameron Zwarich.

4:57 PM Changeset in webkit [37047] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase

<​https://bugs.webkit.org/show_bug.cgi?id=21185>

Reviewed by Adam.

Scripts/resolve-ChangeLogs: Added new -ffix-merge switch that

will attempt to reapply the last commit to a ChangeLog file such
that the ChangeLog entry appears at the top of the file.
(findChangeLog): Added prototype and moved method below the exit
statement.
(fixMergedChangeLog): Added. Method to fix incorrectly merged
ChangeLog entries.

4:31 PM Changeset in webkit [37046] by timothy@apple.com
  • 9 edits in trunk

Improves the Web Inspector node highlight so it does not scroll to reveal the node in the page.

WebCore:

2008-09-28 Timothy Hatcher <​timothy@apple.com>

Remove the scrollIntoViewIfNeeded() call when drawing the
Inspector node highlight.

<rdar://problem/6115804> Don't scroll when highlighting (21000)
​https://bugs.webkit.org/show_bug.cgi?id=21000

Reviewed by Dan Bernstein.

  • page/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight):

WebKit/mac:

2008-09-28 Timothy Hatcher <​timothy@apple.com>

Improves the Web Inspector node highlight so it does not scroll
to reveal the node in the page. This makes the highlight less
invasive and causes less things to change on screen. Also makes
the highlight redraw when the WebView draws, so it stays current
if the node changes on the page for any reason.

<rdar://problem/6115804> Don't scroll when highlighting (21000)
​https://bugs.webkit.org/show_bug.cgi?id=21000

Reviewed by Dan Bernstein.

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController highlightNode:]): Call setNeedsDisplay:YES if there is an existing highlight. (-[WebInspectorWindowController didAttachWebNodeHighlight:]): Set the current highlight node on the inspected WebView. (-[WebInspectorWindowController willDetachWebNodeHighlight:]): Set the current highlight node on the inspected WebView to nil.
  • WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Disable screen updates until flush for the inspected window. Invalidate the whole highlight view since we don't know the rect that needs updated since the highlight can be larger than the highlighted element due to the margins and other factors.
  • WebInspector/WebNodeHighlightView.m:
  • WebView/WebHTMLView.mm: (-[WebHTMLView drawSingleRect:]): Call setNeedsUpdateInTargetViewRect: on the current highlight node.
  • WebView/WebView.mm: (-[WebViewPrivate dealloc]): Release the current highlight node. (-[WebView setCurrentNodeHighlight:]): Set the current highlight node. (-[WebView currentNodeHighlight]): Return the current highlight node.
  • WebView/WebViewInternal.h:
12:58 PM Changeset in webkit [37045] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-09-28 David Hyatt <​hyatt@apple.com>

Fix crash when WebKit has no instantiated Scrollbars and the appearance prefs for scrollbars are
changed.

Reviewed by Dan Bernstein

  • platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
12:52 PM Changeset in webkit [37044] by timothy@apple.com
  • 2 edits in trunk/WebCore

Clear the current search results in the Inspector when
the search query is less than 3 characters long. Incremental
searches only occur for 3 characters or longer, but deleting
under this limit would not clear the results unless the whole
query was deleted.

​https://bugs.webkit.org/show_bug.cgi?id=21196

Reviewed by Dan Bernstein.

  • page/inspector/inspector.js: (WebInspector.performSearch): Check for short queries in the if statement that triggers the clear.
12:41 PM Changeset in webkit [37043] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo noticed by Hyatt in review, which I forgot to fix before checking in.

12:38 PM Changeset in webkit [37042] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6202962> "Tibetan Machine Uni" font does not work as a web font on Windows because TTLoadEmbeddedFont fails with E_NAMECHANGEFAILED
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): Added overlayDst, overlaySrc and overlayLength parameters. (WebCore::EOTStream::read): Added code to overlay the the m_overlayLength bytes starting at m_overlayDst with the same number of bytes from m_overlaySrc. (WebCore::createFontCustomPlatformData): Changed to get overlay parameters from getEOTHeader.
  • platform/graphics/win/GetEOTHeader.cpp: (WebCore::getEOTHeader): Added code to specify overlaying of the family name with the prefix of the full name if they differ, because that such a difference causes TTLoadEmbeddedFont to fail.
  • platform/graphics/win/GetEOTHeader.h:
12:17 PM QtWebKitTodo edited by Simon Hausmann
(diff)
11:57 AM Changeset in webkit [37041] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-09-28 Simon Hausmann <Simon Hausmann>

Reviewed by David Hyatt.

Ensure the mainThreadIdentifier is set as well as other bits and pieces of
the threading machinery, by calling JSC::initializeThreading().

11:56 AM Changeset in webkit [37040] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-09-28 Simon Hausmann <Simon Hausmann>

Reviewed by David Hyatt.

In Qt's initializeThreading re-use an existing thread identifier for the main
thread if it exists.

currentThread() implicitly creates new identifiers and it could be that
it is called before initializeThreading().

11:48 AM QtWebKitGitInstructions edited by Simon Hausmann
Update to the current branch situation (diff)
11:43 AM QtWebKitTodo edited by Simon Hausmann
Cleanups and start of 4.5 plan (diff)
11:22 AM Changeset in webkit [37039] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

Fix build warning in WebDefaultUIDelegate.m

Reviewed by Dan Bernstein.

This fixes a warning noticed by the clang static analyzer:
.../WebDefaultUIDelegate.m: In function ‘-[WebDefaultUIDelegate webViewFirstResponder:]’:
.../WebDefaultUIDelegate.m:92: warning: initialization from distinct Objective-C type

Note that this doesn't actually cause any change in behavior since
the gcc compiler ignores the semi-colon anyway.

  • DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webViewFirstResponder:]): Removed semi-colon from method signature.
6:23 AM Changeset in webkit [37038] by ap@webkit.org
  • 6 edits in trunk

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=20366
Reproducible test failure for editing/undo/undo-iframe-location-change.html

This does not fix the problem, but makes the test more predictable by using iframe onload.
Also, makes the test runnable in browser. Turns out that the test reliably fails there too,
even without any special steps needed in DRT.

  • editing/undo/undo-iframe-location-change-expected.txt:
  • editing/undo/undo-iframe-location-change.html:
  • ChangeLog-2007-10-14: Added bug URLs for a patch that included this test.

WebCore:

  • ChangeLog-2006-05-10: Added bug URLs for a fix that included this test.
2:35 AM Changeset in webkit [37037] by Darin Adler
  • 28 edits in trunk/WebCore

2008-09-28 Darin Adler <Darin Adler>

Reviewed by Sam Weinig (except for a few comment and header tweaks).

Speeds up Dromaeo a bit less than 1%.

  • bindings/js/JSNamedNodesCollection.cpp: Include Element.h instead of Node.h now that some inlines are in there.
  • dom/Attr.h: Override both the virtual and non-virtual name functions.
  • dom/ChildNodeList.cpp: (WebCore::ChildNodeList::nodeMatches): Updated to take an Element.
  • dom/ChildNodeList.h: Ditto.
  • dom/ClassNodeList.cpp: (WebCore::ClassNodeList::nodeMatches): Ditto.
  • dom/ClassNodeList.h: Ditto.
  • dom/Document.h: Put the Node::isDocumentNode() function's inline definition here where it can see the Document class definition.
  • dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::length): Changed to pass an Element. (WebCore::DynamicNodeList::itemForwardsFromCurrent): Ditto. (WebCore::DynamicNodeList::itemBackwardsFromCurrent): Ditto. (WebCore::DynamicNodeList::itemWithName): Ditto.
  • dom/DynamicNodeList.h: Ditto.
  • dom/Element.cpp: Removed virtualHasTagName.
  • dom/Element.h: Made localName, prefix, namespaceURI, and styleForRenderer non-virtual. Added virtualPrefix, virtualLocalName, virtualNamespaceURI, and removed virtualHasTagName. Put the Node::hasTagName, Node::hasAttributes, and Node::attributes functions' inline definitions here where they can see the Element class definition.
  • dom/NameNodeList.cpp: (WebCore::NameNodeList::nodeMatches): Updated to take an Element.
  • dom/NameNodeList.h: Ditto.
  • dom/Node.cpp: (WebCore::Node::virtualPrefix): Renamed from prefix. (WebCore::Node::virtualLocalName): Renamed from localName. (WebCore::Node::virtualNamespaceURI): Renamed from namespaceURI. (WebCore::Node::styleForRenderer): Handle the Element case here.
  • dom/Node.h: Removed definition of hasTagName that calls virtual, since we now have a non-virtual version. Made hasAttributes, attributes, remove, localName, namespaceURI, prefix, isDocumentNode, and styleForRenderer non-virtual. Added virtualPrefix, virtualLocalName, and virtualNamespaceURI. Removed isMalformed and setMalformed, which are used only on HTMLFormElement objects.
  • dom/TagNodeList.cpp: (WebCore::TagNodeList::nodeMatches): Updated to take an Element.
  • dom/TagNodeList.h: Ditto.
  • html/HTMLAnchorElement.cpp: Added a comment.
  • html/HTMLFormControlElement.cpp: Ditto.
  • html/HTMLAnchorElement.h: Removed unused, unimplemented setTabIndex function. Marked tabIndex function virtual explicitly for clarity.
  • html/HTMLAreaElement.h: Removed unused, unimplemented setTabIndex function. Marked isFocusable function virtual explicitly for clarity.
  • html/HTMLElement.h: Marked tabIndex function virtual explicitly for clarity.
  • html/HTMLFormControlElement.h: Ditto.
  • html/HTMLFormElement.h: Made isMalformed non-virtual.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Use the already-cast-to-HTMLElement pointer to call localName since that one does not need to call a virtual function.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Cast to HTMLFormElement before calling isMalformed. We already did a tag name check so we know it's an HTMLFormELement.
  • xml/XPathUtil.cpp: (WebCore::XPath::isValidContextNode): Rewrote to not make so many calls to nodeType(), since it's a virtual function.
2:33 AM Changeset in webkit [37036] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/wx/MouseWheelEventWx.cpp

Fix wx bustage.

1:52 AM Changeset in webkit [37035] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2008-09-28 David Hyatt <​hyatt@apple.com>

Make frameRectsChanged() cross-platform on ScrollView.

Reviewed by Oliver Hunt

  • platform/ScrollView.cpp: (WebCore::ScrollView::frameRectsChanged):
  • platform/ScrollView.h:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/ScrollViewWin.cpp:
  • platform/wx/ScrollViewWx.cpp:
1:36 AM Changeset in webkit [37034] by oliver@apple.com
  • 2 edits in trunk/WebCore

Bug 21141: REGRESSION: Exception messages for user entered commands are poor
<​https://bugs.webkit.org/show_bug.cgi?id=21141>

Reviewed by Maciej Stachowiak.

The bug repsonsible for this was the the JSInspectedObjectWrapper instances
were not initialising their StructureID's to indicate that the wrapper
overrides hasInstance, etc. The solution is simply to use the createStructureID
helper on JSQuarantinedObjectWrapper to create a correct StructureID.

1:30 AM Changeset in webkit [37033] by hyatt@apple.com
  • 1 edit in trunk/WebKit/gtk/webkit/webkitwebview.cpp

Fix GTK bustage.

1:29 AM Changeset in webkit [37032] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-09-28 David Hyatt <​hyatt@apple.com>

Make sure pixel wheel scrolls (formerly "continuous" wheel events) send deltas to DOM wheel events in
terms of lines.

Reviewed by Oliver Hunt

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchWheelEvent):
1:21 AM Changeset in webkit [37031] by hyatt@apple.com
  • 16 edits in trunk/WebCore

2008-09-28 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=21191

Rework mouse wheeling significantly to make the platform event less messy and to enable wheelEvent
on ScrollView to be cross-platform.

Give the wheel event a concept of granularity (pixel, line or page). What used to be called continuous
events are now pixel wheel events.

Page scrolling as implemented in bug 17589 was completely broken. It had the following problems:
(1) Page scrolling has been corrected to be properly detected (on Windows
page wheeling is only done in the vertical direction and it is keyed off a special return value of -1). The
old code had some bizarre incorrect heuristic for "guessing" that you should page scroll and also thought
you could page scroll horizontally.
(2) Page scrolling a layer used the enclosing ScrollView's width/height instead of the layer's width/height.
This caused the scroll amount for page scrolling to be way too large on layers.

Bug 17589 got the default horizontal scrolling value wrong. It assumed 1, when the Vista default is 3.

Incorporate WebCore's line multiplier right into the deltas of the event. This eliminates the need
for separate multiplier fields (or for the need to ask if you're looking for line sensitivity).

Reviewed by Oliver Hunt

  • editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
  • page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent): (WebCore::EventHandler::handleWheelEvent):
  • platform/PlatformWheelEvent.h: (WebCore::): (WebCore::PlatformWheelEvent::pos): (WebCore::PlatformWheelEvent::globalPos): (WebCore::PlatformWheelEvent::deltaX): (WebCore::PlatformWheelEvent::deltaY): (WebCore::PlatformWheelEvent::granularity): (WebCore::PlatformWheelEvent::x): (WebCore::PlatformWheelEvent::globalX): (WebCore::PlatformWheelEvent::ignore): (WebCore::PlatformWheelEvent::horizontalLineMultiplier): (WebCore::PlatformWheelEvent::verticalLineMultiplier):
  • platform/ScrollView.cpp: (WebCore::ScrollView::wheelEvent):
  • platform/Scrollbar.h:
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::updateScrollbars):
  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/mac/ScrollViewMac.mm:
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateScrollbars):
  • platform/qt/WheelEventQt.cpp:
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars):
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::horizontalLineMultiplier): (WebCore::PlatformWheelEvent::verticalLineMultiplier): (WebCore::PlatformWheelEvent::PlatformWheelEvent):
  • platform/wx/ScrollViewWx.cpp: (WebCore::ScrollView::ScrollViewPrivate::OnScrollWinEvents): (WebCore::ScrollView::wheelEvent):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):
Note: See TracTimeline for information about the timeline view.