Context Navigation

← Previous Period
Next Period →

Timeline

Jan 24, 2009:

4:34 PM Changeset in webkit [40220] by treat@webkit.org

2 edits in trunk/WebKit/qt

Oops, fix the Qt build.

2:41 PM Changeset in webkit [40219] by eric.carlson@apple.com

3 edits in trunk/LayoutTests

2009-01-24 Eric Carlson <eric.carlson@apple.com>

<video> controls visibility test needs to dump render tree as text because
the test does not always end at the same time, so the timeline slider thumb
is not always at the same position.

media/video-controls-visible-audio-only.html:
platform/mac/media/video-controls-visible-audio-only-expected.txt:

2:39 PM Changeset in webkit [40218] by treat@webkit.org

4 edits in trunk/WebKit/qt

Add QWebFrame::renderContents() method which allows arbitary rendering
of any content region within the QWebFrame. It also does not draw any
scrollbars.

12:59 PM Changeset in webkit [40217] by Darin Adler

3 edits in trunk/LayoutTests

2009-01-24 Darin Adler <Darin Adler>

Try to fix expected results for new video element test.

platform/mac/media/video-controls-visible-audio-only-expected.png: Landed new result generated on my machine.
platform/mac/media/video-controls-visible-audio-only-expected.txt: Ditto.

12:40 PM Changeset in webkit [40216] by Darin Adler

2 edits in trunk/WebCore

2009-01-24 Darin Adler <Darin Adler>

Try to fix Qt build.

WebCore.pro: Added JSTextCustom.cpp.

7:10 AM Changeset in webkit [40215] by cmarrin@apple.com

8 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=23467

Change styleAvailable functionality to be a linked list
rather than scanning every CompositeAnimation for
Animations that are waiting for styleAvailable. This has
potential for large performance improvement in cases where
there are many animations firing at once. But it will also
help in my next fix, which is to synchronize software and
accelerated animations.

I also changed slightly when the beginAnimationUpdate and
endAnimationUpdate calls are made. But this has no real
effect on performance or behavior.

1:55 AM Changeset in webkit [40214] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Force inlining of Lexer::matchPunctuator

Reviewed by Maciej Stachowiak.

2.2% win when parsing jQuery, Mootools, Prototype, etc

1:39 AM Changeset in webkit [40213] by ap@webkit.org

5 edits
2 adds in trunk

Reviewed by Darin Adler.

<rdar://problem/6368059> REGRESSION: URL encoding problems on http://www.cineman.ch

Test: http/tests/xmlhttprequest/encode-request-url-2.html

platform/KURL.cpp: (WebCore::appendASCII): Added a helper function. (WebCore::KURL::KURL): Explicitly encode the URL to call two-argument parse() with better specified behavior. (WebCore::KURL::init): Ditto. This avoids trying to round-trip an URL encoded into a byte stream, but not yet transformed to ASCII-only using percent escapes. Since different parts of the byte stream can use different encodings, round-tripping is not possible. (WebCore::KURL::parse): Reverted an earlier change that made the single-argument version of this function convert the string to utf-8. I think that on the remanining code paths, it is correct to assume that the string is all ASCII, but I'm not yet confident enough to drop a FIXME warning.

12:05 AM Changeset in webkit [40212] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2009-01-24 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix after r40170

GNUmakefile.am: Removed editing/RemoveNodeAttributeCommand.cpp and editing/RemoveNodeAttributeCommand.h

Jan 23, 2009:

10:19 PM Changeset in webkit [40211] by treat@webkit.org

2 edits in trunk/WebCore

Fix the Qt build after r40205.

9:47 PM Changeset in webkit [40210] by beidson@apple.com

11 edits
2 adds in trunk/WebCore

2009-01-23 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

In CachedPage, break off per-Frame pieces of data into a CachedFrame object.

GNUmakefile.am:
WebCore.base.exp:
WebCore.pro:
WebCore.scons:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:

history/CachedFrame.cpp: Added. (WebCore::cachedFrameCounter): (WebCore::CachedFrame::CachedFrame): (WebCore::CachedFrame::~CachedFrame): (WebCore::CachedFrame::restore): (WebCore::CachedFrame::clear): (WebCore::CachedFrame::setCachedFramePlatformData): (WebCore::CachedFrame::cachedFramePlatformData):
history/CachedFrame.h: Added. (WebCore::CachedFrame::document): (WebCore::CachedFrame::documentLoader): (WebCore::CachedFrame::view): (WebCore::CachedFrame::mousePressNode): (WebCore::CachedFrame::url): (WebCore::CachedFrame::domWindow):

history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore): (WebCore::CachedPage::clear): (WebCore::CachedPage::setCachedFramePlatformData): (WebCore::CachedPage::cachedFramePlatformData):
history/CachedPage.h: (WebCore::CachedPage::document): (WebCore::CachedPage::documentLoader): (WebCore::CachedPage::view): (WebCore::CachedPage::mousePressNode): (WebCore::CachedPage::url): (WebCore::CachedPage::domWindow):

loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePageForHistoryItem): Setting the DocumentLoader independently of creating a CachedPage was a historical relic. Take the opportunity to clean that up.

7:59 PM Changeset in webkit [40209] by hyatt@apple.com

11 edits in trunk/WebCore

2009-01-23 David Hyatt <hyatt@apple.com>

Add ASSERTs to catch anyone trying to obtain the width/height of an inline flow. Fix up all the places
that triggered the ASSERT (since all of these places are effectively regressions from my landing that
devirtualized width()/height()).

Reviewed by Adele

dom/Position.cpp: (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
rendering/RenderBox.cpp: (WebCore::RenderBox::clientWidth): (WebCore::RenderBox::clientHeight): (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight): (WebCore::RenderBox::absoluteOutlineBounds):
rendering/RenderBox.h: (WebCore::RenderBox::width): (WebCore::RenderBox::height): (WebCore::RenderBox::size): (WebCore::RenderBox::frameRect): (WebCore::RenderBox::borderBoundingBox):
rendering/RenderFlow.h: (WebCore::RenderFlow::borderBoundingBox):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::styleWillChange):
rendering/RenderScrollbarPart.h:
wml/WMLAElement.cpp: (WebCore::WMLAElement::isKeyboardFocusable):

7:03 PM Changeset in webkit [40208] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

2009-01-23 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Fix for <rdar://problem/6126212>
Ensure that callbacks out from the JSC interface are only allowed
to return in reverse-chronological order to that in which they were
made. If we allow earlier callbacks to return first, then this may
result in setions of the RegisterFile in use by another thread
being trampled.

See uber-comment in JSLock.h for details.

runtime/JSLock.cpp: (JSC::JSLock::DropAllLocks::DropAllLocks): (JSC::JSLock::DropAllLocks::~DropAllLocks):

6:39 PM Changeset in webkit [40207] by Darin Adler

4 edits in trunk/WebCore

2009-01-23 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352

Second patch: Slightly less simple cases of various warnings.

bridge/jni/jni_runtime.h: (JSC::Bindings::JavaString::_commonInit): Use reinterpret_cast here and avoid casting away const.

dom/XMLTokenizerLibxml2.cpp: (WebCore::PendingCallbacks::appendStartElementNSCallback): Use static_cast instead of reinterpret_cast; this is casting the result of malloc, and the idiom is to use static_cast, which works because we're casting from void*. (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): Use const_cast instead C-style casts.

xml/XSLTUnicodeSort.cpp: (inlineXSLTTransformError): Tweak soft linking of xsltTransformError to use a macro instead of redefining the function.

6:23 PM Changeset in webkit [40206] by Darin Adler

2 edits in trunk/WebCore

2009-01-23 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Bug 23475: fast/text/find-backwards.html fails with ICU disabled SearchBuffer
https://bugs.webkit.org/show_bug.cgi?id=23475

editing/TextIterator.cpp: (WebCore::SearchBuffer::search): Set the character start flag to false to ensure we won't ever return the same result twice. There are other ways we could accomplish this, mentioned in the comment, but this one was the smallest and cleanest I could think of.

6:22 PM Changeset in webkit [40205] by Darin Adler

7 edits
1 copy in trunk/WebCore

2009-01-23 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Bug 23510: REGRESSION (r40171): CDATASection objects not getting proper JavaScript wrappers
https://bugs.webkit.org/show_bug.cgi?id=23510

That patch fixed the optimization that's supposed to give a faster path for
allocating the wrappers for DOM Text objects. But CDATASection is the one
subclass of Text objects.

GNUmakefile.am: Added JSCDATASectionCustom.cpp.
WebCore.scons: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
WebCoreSources.bkl: Ditto.

bindings/js/JSCDATASectionCustom.cpp: Copied from bindings/js/JSTextCustom.cpp. (WebCore::toJSNewlyCreated): Changed to do CDATASection, not Text.

bindings/scripts/CodeGeneratorJS.pm: Added another toJSNewlyCreated function for CDATASection. We don't want to have to check when creating a wrapper for a Text object whether it's a CDATASection object or not, so we need to do this overload at compile time.

6:00 PM Changeset in webkit [40204] by Nikolas Zimmermann

36 edits
4 adds in trunk/WebCore

Reviewed by Eric Seidel.

Add a base class for WML form control elements: WMLFormControlElement (as it's designed in HTML as well).
WMLFormControlElement inherits from WMLElement and FormControlElement (just like the HTMLFormControlElement equivalent).

WMLInputElement / WMLOptionElement / WMLOptGroupElement are supposed to inherit from the new WMLFormControlElement class.
Now WMLInputElement & WMLOptGroupElement only inherit from WMLElement and FormControlElement, but WMLOptionElement inherits
from WMLEventHandlingElement (which in turn inherits from WMLElement) and FormControlElement. In order to introduce a shared
base class, WMLEventHandlingElement is no longer allowed to inherit from WMLElement directly. Instead it should turn into
another base class, just like FormControlElement.

Add a base class for form control elements 'with state': FormControlElementWithState, serving as base class for
HTMLFormControlElementWithState and WMLFormControlElementWithState. -> Make Document operate on FormControlElementWithState
objects instead of HTMLFormControlElementWithState objects, to support save/restore control state for non HTMLFormControlElements.

Rename isGenericFormElement() to isFormControlElement(), and move it to Element.h
Add new virtual function isFormControlElementWithState() to Element.h.

5:23 PM Changeset in webkit [40203] by bfulgham@webkit.org

3 edits in trunk/WebKit/win

Bug 23492: Separating the WebKitSystemInterface Calls.

5:21 PM Changeset in webkit [40202] by Chris Fleizach

3 edits in trunk/WebCore

Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]

Move null checking into makeRange

4:54 PM Changeset in webkit [40201] by treat@webkit.org

2 edits in trunk/WebCore

Fix the Gtk build too after removal of RenderBox::toConstRenderBox

4:52 PM Changeset in webkit [40200] by treat@webkit.org

2 edits in trunk/WebCore

Fix the Qt build after rename of RenderBox::toConstRenderBox -> toRenderBox

4:47 PM Changeset in webkit [40199] by treat@webkit.org

2 edits in trunk/WebCore

Fix the Qt build after r40168.

4:26 PM Changeset in webkit [40198] by beidson@apple.com

15 edits
3 moves in trunk

WebCore:

2009-01-23 Brady Eidson <beidson@apple.com>

Rubberstamped by Darin Adler

Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.

GNUmakefile.am:
WebCore.base.exp:
WebCore.order:
WebCore.xcodeproj/project.pbxproj:

history/CachedFramePlatformData.h: Copied from WebCore/history/CachedPagePlatformData.h. (WebCore::CachedFramePlatformData::~CachedFramePlatformData):
history/CachedPagePlatformData.h: Removed.

history/CachedPage.cpp: (WebCore::CachedPage::clear): (WebCore::CachedPage::setCachedFramePlatformData): (WebCore::CachedPage::cachedFramePlatformData):
history/CachedPage.h:

WebKit:

2009-01-23 Brady Eidson <beidson@apple.com>

Rubberstamped by Darin Adler

Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-01-23 Brady Eidson <beidson@apple.com>

Rubberstamped by Darin Adler

Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.

WebCoreSupport/WebCachedFramePlatformData.h: Copied from WebKit/mac/WebCoreSupport/WebCachedPagePlatformData.h. (WebCachedFramePlatformData::WebCachedFramePlatformData):
WebCoreSupport/WebCachedPagePlatformData.h: Removed.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::savePlatformDataToCachedPage): (WebFrameLoaderClient::transitionToCommittedFromCachedPage):

WebKit.order:

WebKit/win:

2009-01-23 Brady Eidson <beidson@apple.com>

Rubberstamped by Darin Adler

Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.

WebCachedFramePlatformData.h: Copied from WebKit/win/WebCachedPagePlatformData.h. (WebCachedFramePlatformData::WebCachedFramePlatformData):
WebCachedPagePlatformData.h: Removed.

WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::savePlatformDataToCachedPage):

WebKit.vcproj/WebKit.vcproj:

4:23 PM Changeset in webkit [40197] by kevino@webkit.org

2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Fix drawing in situations where sub-portions of the bitmap are to be drawn to the screen.

4:19 PM Changeset in webkit [40196] by kevino@webkit.org

3 edits in trunk/WebCore

Build fixes for recent changes.

3:33 PM Changeset in webkit [40195] by hyatt@apple.com

1 edit in trunk/WebCore/rendering/RenderThemeWin.cpp

Fix Windows bustage.

3:33 PM Changeset in webkit [40194] by hyatt@apple.com

1 edit in trunk/WebCore/page/EventHandler.cpp

Fix Windows bustage.

3:33 PM Changeset in webkit [40193] by eric.carlson@apple.com

5 edits
4 adds in trunk

2009-01-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson

Fix for https://bugs.webkit.org/show_bug.cgi?id=23407

Implement QTMovieWin::hasVideo so the controller on an audio-only <video> element
is never hidden (as with an <audio> element).

Test: media/video-controls-visible-audio-only.html

platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::hasVideo):
platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::hasVideo):
platform/graphics/win/QTMovieWin.h:

2009-01-23 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson

Test for behavior of <video> element controller when a media file has
only audio.
https://bugs.webkit.org/show_bug.cgi?id=23407

media/video-controls-visible-audio-only.html: Added.
platform/mac/media/video-controls-visible-audio-only-expected.checksum: Added.
platform/mac/media/video-controls-visible-audio-only-expected.png: Added.
platform/mac/media/video-controls-visible-audio-only-expected.txt: Added.

3:25 PM Changeset in webkit [40192] by hyatt@apple.com

33 edits in trunk/WebCore

2009-01-23 David Hyatt <hyatt@apple.com>

Make toRenderBox a non-member function. Rename toConstRenderBox to just also be called toRenderBox.

Reviewed by Oliver Hunt

css/CSSComputedStyleDeclaration.cpp: (WebCore::sizingBox): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner):
dom/Element.cpp: (WebCore::Element::scrollByUnits):
dom/Position.cpp: (WebCore::endsOfNodeAreVisuallyDistinctPositions): (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): (WebCore::Position::isCandidate):
editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
editing/TextIterator.cpp: (WebCore::shouldEmitExtraNewlineForNode):
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isFocusable):
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::width): (WebCore::HTMLFrameElementBase::height):
page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::updateAutoscrollRenderer): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::scrollOverflow):
page/FrameView.cpp: (WebCore::FrameView::layout):
page/animation/AnimationBase.cpp: (WebCore::blendFunc):
rendering/InlineBox.cpp: (WebCore::InlineBox::adjustPosition):
rendering/InlineBox.h: (WebCore::InlineBox::renderBox):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloats):
rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeAbsoluteRepaintRect): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
rendering/RenderBox.h: (WebCore::toRenderBox): (WebCore::RenderBox::previousSiblingBox): (WebCore::RenderBox::nextSiblingBox): (WebCore::RenderBox::parentBox):
rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::resize): (WebCore::RenderLayer::boundingBox):
rendering/RenderObject.cpp: (WebCore::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::findNextLayer): (WebCore::RenderObject::enclosingLayer): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setNeedsPositionedMovementLayout): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline): (WebCore::RenderObject::computeAbsoluteRepaintRect): (WebCore::RenderObject::localToAbsolute): (WebCore::RenderObject::absoluteToLocal): (WebCore::RenderObject::localToAbsoluteQuad): (WebCore::RenderObject::offsetFromContainer): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::destroy): (WebCore::RenderObject::updateHitTestResult): (WebCore::RenderObject::addDashboardRegions):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
rendering/RenderTheme.cpp: (WebCore::RenderTheme::hitTestMediaControlPart): (WebCore::RenderTheme::baselinePosition):
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::hitTestMediaControlPart):
rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation):
rendering/bidi.cpp: (WebCore::inlineWidth): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::requiresLineBox): (WebCore::RenderBlock::findNextLineBreak):
svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
wml/WMLAElement.cpp: (WebCore::WMLAElement::isKeyboardFocusable):
wml/WMLInputElement.cpp: (WebCore::isInputFocusable):

3:03 PM Changeset in webkit [40191] by Chris Fleizach

2 edits in trunk/WebCore

2009-01-23 Chris Fleizach <Chris Fleizach>

Reviewed by Beth Dakin.

Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]
https://bugs.webkit.org/show_bug.cgi?id=23509

Add null checking around next/previous sentence retrieval in AX code

page/AccessibilityObject.cpp: (WebCore::AccessibilityObject::nextSentenceEndPosition): (WebCore::AccessibilityObject::previousSentenceStartPosition):

2:50 PM Changeset in webkit [40190] by adele@apple.com

2 edits in trunk/WebKit/mac

2009-01-23 Adele Peterson <adele@apple.com>

Build fix.

Use new linesBoundingBox method instead of
boundingBoxWidth and boundingBoxHeight for RenderText objects.

WebView/WebRenderNode.mm: (copyRenderNode):

2:41 PM Changeset in webkit [40189] by kevino@webkit.org

2 edits in trunk/WebKit/wx

wx build fix, add missing include dir.

2:39 PM Changeset in webkit [40188] by ddkilzer@apple.com

2 edits in trunk/WebKitTools

2009-01-23 David Kilzer <ddkilzer@apple.com>

Scripts/do-webcore-rename: Removed 10 header guard renames that had already been fixed, and updated 4 renames whose original values had changed.

2:38 PM Changeset in webkit [40187] by ddkilzer@apple.com

1 edit in trunk/JavaScriptCore/DerivedSources.make

Added missing comma to copyright.

2:20 PM Changeset in webkit [40186] by hyatt@apple.com

3 edits in trunk/LayoutTests/platform/mac/svg/batik/text

Land new results now that text runs at negative positions dump their widths correctly.

2:19 PM Changeset in webkit [40185] by hyatt@apple.com

1 edit in trunk/LayoutTests/platform/mac/editing/style/smoosh-styles-003-expected.txt

Land new results now that text runs at negative positions dump their widths correctly.

2:19 PM Changeset in webkit [40184] by hyatt@apple.com

3 edits in trunk/LayoutTests/platform/mac/fast

Update the test results for compacts and run-ins now that they dump accurate positions.

2:18 PM Changeset in webkit [40183] by hyatt@apple.com

4 adds in trunk/LayoutTests

Add new repaint test for hover regression.

2:17 PM Changeset in webkit [40182] by hyatt@apple.com

14 edits in trunk/WebCore

2009-01-23 David Hyatt <hyatt@apple.com>

Fix for <rdar://problem/6518850> REGRESSION: hover feedback not showing on many sites

Inline flow repainting was broken because it relied on width() and height(). Give RenderFlow a linesBoundingBox
method for obtaining a reasonable bounding box to use for repainting. Eliminate the methods from RenderInline
since compacts/run-ins need them too, so putting them on RenderFlow is necessary.

For consistency, change RenderText's version of these methods into the single linesBoundingBox method as
well.

Reviewed by Oliver Hunt

WebCore.base.exp:
dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner):
dom/Position.cpp: (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockHeightForPositioned):
rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect): (WebCore::RenderFlow::linesBoundingBox):
rendering/RenderFlow.h:
rendering/RenderInline.cpp:
rendering/RenderInline.h: (WebCore::RenderInline::offsetWidth): (WebCore::RenderInline::offsetHeight):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
rendering/RenderText.cpp: (WebCore::RenderText::linesBoundingBox):
rendering/RenderText.h:
rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
rendering/SVGRenderTreeAsText.cpp: (WebCore::write):

1:28 PM Changeset in webkit [40181] by hyatt@apple.com

1 edit in trunk/WebCore/rendering/RenderFlow.cpp

Fix RenderFlow. Botched the application of my patch.

1:25 PM Changeset in webkit [40180] by hyatt@apple.com

47 edits in trunk/WebCore

2009-01-23 David Hyatt <hyatt@apple.com>

Move layer() into RenderBox and make it non-virtual. Move all of the scrolling functions from RenderObject
to RenderBox and devirtualize as many as possible. Clean up styleWillChange to factor code specific to
RenderBox and RenderBlock into their appropriate subclasses. Stubbed out an empty styleWillChange on
RenderText, since none of the work done in styleWillChange was relevant to text nodes.

Reviewed by Sam Weinig

dom/Document.cpp: (WebCore::Document::elementFromPoint): (WebCore::Document::renderView): (WebCore::Document::prepareMouseEvent):
dom/Document.h:
dom/Element.cpp: (WebCore::Element::scrollByUnits):
editing/SelectionController.cpp: (WebCore::SelectionController::contains):
html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::start): (WebCore::HTMLMarqueeElement::stop):
page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::topRenderer): (WebCore::AccessibilityRenderObject::visiblePositionForPoint): (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
page/AccessibilityRenderObject.h:
page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::updateAutoscrollRenderer): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::scrollOverflow): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::hoverTimerFired):
page/Frame.cpp: (WebCore::Frame::clearTimers):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange): (WebCore::RenderBox::verticalScrollbarWidth): (WebCore::RenderBox::horizontalScrollbarHeight): (WebCore::RenderBox::scroll): (WebCore::RenderBox::canBeProgramaticallyScrolled): (WebCore::RenderBox::autoscroll): (WebCore::RenderBox::panScroll): (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeAbsoluteRepaintRect):
rendering/RenderBox.h: (WebCore::RenderBox::layer): (WebCore::RenderBox::requiresLayer): (WebCore::RenderBox::stopAutoscroll): (WebCore::RenderBox::hasAutoVerticalScrollbar): (WebCore::RenderBox::hasAutoHorizontalScrollbar): (WebCore::RenderBox::scrollsOverflow): (WebCore::RenderBox::scrollsOverflowX): (WebCore::RenderBox::scrollsOverflowY): (WebCore::RenderBox::includeVerticalScrollbarSize): (WebCore::RenderBox::includeHorizontalScrollbarSize):
rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect): (WebCore::RenderFlow::addFocusRingRects):
rendering/RenderForeignObject.cpp:
rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::requiresLayer):
rendering/RenderInline.cpp:
rendering/RenderInline.h: (WebCore::RenderInline::requiresLayer):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::childrenClipRect): (WebCore::RenderLayer::selfClipRect):
rendering/RenderListBox.cpp:
rendering/RenderListBox.h:
rendering/RenderObject.cpp: (WebCore::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::findNextLayer): (WebCore::RenderObject::enclosingLayer): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setNeedsPositionedMovementLayout): (WebCore::RenderObject::computeAbsoluteRepaintRect): (WebCore::RenderObject::styleWillChange): (WebCore::RenderObject::localToAbsolute): (WebCore::RenderObject::absoluteToLocal): (WebCore::RenderObject::localToAbsoluteQuad): (WebCore::RenderObject::offsetFromContainer): (WebCore::RenderObject::destroy):
rendering/RenderObject.h:
rendering/RenderPath.cpp:
rendering/RenderPath.h: (WebCore::RenderPath::requiresLayer):
rendering/RenderReplica.h: (WebCore::RenderReplica::requiresLayer):
rendering/RenderSVGContainer.cpp:
rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::requiresLayer):
rendering/RenderSVGHiddenContainer.cpp:
rendering/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::requiresLayer):
rendering/RenderSVGImage.cpp:
rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::requiresLayer):
rendering/RenderSVGInline.h: (WebCore::RenderSVGInline::requiresLayer):
rendering/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::requiresLayer):
rendering/RenderSVGText.cpp:
rendering/RenderSVGText.h: (WebCore::RenderSVGText::requiresLayer):
rendering/RenderScrollbarPart.h: (WebCore::RenderScrollbarPart::requiresLayer):
rendering/RenderSlider.cpp: (WebCore::RenderSlider::setCurrentPosition):
rendering/RenderTableCell.cpp:
rendering/RenderTableCell.h: (WebCore::RenderTableCell::requiresLayer):
rendering/RenderTableCol.h: (WebCore::RenderTableCol::requiresLayer):
rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
rendering/RenderText.h: (WebCore::RenderText::styleWillChange):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::autoscroll): (WebCore::RenderTextControl::scroll):
rendering/RenderTextControl.h:
rendering/RenderTreeAsText.cpp: (WebCore::write): (WebCore::externalRepresentation):

1:18 PM Changeset in webkit [40179] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-01-23 Anders Carlsson <andersca@apple.com>

Fix 64-bit build.

Plugins/Hosted/ProxyInstance.mm: (WebKit::proxyClass):

12:56 PM Changeset in webkit [40178] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-01-23 Anders Carlsson <andersca@apple.com>

Fix GCC 4.0 build.

Configurations/Base.xcconfig:

12:53 PM Changeset in webkit [40177] by andersca@apple.com

2 edits in trunk/WebCore

2009-01-23 Anders Carlsson <andersca@apple.com>

Fix tyop.

editing/markup.cpp: (WebCore::joinMarkups):

12:51 PM Changeset in webkit [40176] by Darin Adler

2 edits in trunk/JavaScriptCore

2009-01-23 Darin Adler <Darin Adler>

Try to fix WX build.

runtime/JSGlobalObjectFunctions.h: Include <wtf/unicode/Unicode.h> for the definition of UChar.

12:50 PM Changeset in webkit [40175] by andersca@apple.com

5 edits in trunk/WebCore

2009-01-23 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Configurations/Base.xcconfig: Fix GCC 4.0 build.

editing/markup.cpp: (WebCore::joinMarkups): Pass a const reference to the vector.

html/HTMLElement.cpp:
platform/text/String.cpp: Add comments indicating that these functions are for use in the debugger.

12:37 PM Changeset in webkit [40174] by andersca@apple.com

3 edits in trunk/JavaScriptCore

2009-01-23 Anders Carlsson <andersca@apple.com>

Configurations/Base.xcconfig: GCC 4.0 build fix.

runtime/JSNumberCell.h: 64-bit build fix.

12:35 PM Changeset in webkit [40173] by darin@chromium.org

10 edits
8 adds in trunk/WebCore

2009-01-23 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23506
Upstream Chromium's image decoders for use with PLATFORM(SKIA)

platform/image-decoders/skia/BMPImageDecoder.cpp: Added.
platform/image-decoders/skia/BMPImageDecoder.h: Added.
platform/image-decoders/skia/BMPImageReader.cpp: Added.
platform/image-decoders/skia/BMPImageReader.h: Added.
platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate): (WebCore::GIFImageDecoderPrivate::decode): (WebCore::GIFImageDecoderPrivate::getColorMap): (WebCore::GIFImageDecoder::GIFImageDecoder): (WebCore::GIFImageDecoder::isSizeAvailable): (WebCore::GIFImageDecoder::frameCount): (WebCore::GIFImageDecoder::frameBufferAtIndex): (WebCore::GIFImageDecoder::clearFrameBufferCache): (WebCore::GIFImageDecoder::decode): (WebCore::GIFImageDecoder::sizeNowAvailable): (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow): (WebCore::GIFImageDecoder::frameComplete):
platform/image-decoders/skia/GIFImageDecoder.h: (WebCore::GIFImageDecoder::filenameExtension): (WebCore::GIFImageDecoder::frameDurationAtIndex): (WebCore::GIFImageDecoder::):
platform/image-decoders/skia/GIFImageReader.cpp: (GIFImageReader::do_lzw): (GIFImageReader::read):
platform/image-decoders/skia/GIFImageReader.h:
platform/image-decoders/skia/ICOImageDecoder.cpp: Added.
platform/image-decoders/skia/ICOImageDecoder.h: Added.
platform/image-decoders/skia/ImageDecoder.h: (WebCore::RefCountedNativeImageSkia::create): (WebCore::RefCountedNativeImageSkia::bitmap): (WebCore::RefCountedNativeImageSkia::RefCountedNativeImageSkia): (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::~RGBA32Buffer): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::bitmap): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::rect): (WebCore::RGBA32Buffer::status): (WebCore::RGBA32Buffer::duration): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setRect): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::setDuration): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setRGBA): (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::~ImageDecoder): (WebCore::ImageDecoder::setData): (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::size): (WebCore::ImageDecoder::frameCount): (WebCore::ImageDecoder::repetitionCount): (WebCore::ImageDecoder::supportsAlpha): (WebCore::ImageDecoder::failed): (WebCore::ImageDecoder::setFailed): (WebCore::ImageDecoder::clearFrameBufferCache): (WebCore::ImageDecoder::setSize): (WebCore::ImageDecoder::isOverSize):
platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::JPEGImageReader): (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::isSizeAvailable): (WebCore::JPEGImageDecoder::outputScanlines):
platform/image-decoders/skia/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::filenameExtension): (WebCore::JPEGImageDecoder::supportsAlpha): (WebCore::JPEGImageDecoder::reader):
platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageReader::close): (WebCore::PNGImageDecoder::PNGImageDecoder): (WebCore::PNGImageDecoder::isSizeAvailable): (WebCore::PNGImageDecoder::frameBufferAtIndex): (WebCore::PNGImageDecoder::decode): (WebCore::PNGImageDecoder::decodingFailed): (WebCore::PNGImageDecoder::headerAvailable): (WebCore::rowAvailable): (WebCore::PNGImageDecoder::rowAvailable): (WebCore::PNGImageDecoder::pngComplete):
platform/image-decoders/skia/PNGImageDecoder.h: (WebCore::PNGImageDecoder::filenameExtension): (WebCore::PNGImageDecoder::reader):
platform/image-decoders/skia/XBMImageDecoder.cpp: Added.
platform/image-decoders/skia/XBMImageDecoder.h: Added.

11:58 AM Changeset in webkit [40172] by andersca@apple.com

7 edits in trunk/WebKit/mac

2009-01-23 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Turn on -Wmissing-prototypes and fix the resulting warnings.

Configurations/Base.xcconfig:
History/WebHistory.mm: (timeIntervalForBeginningOfDay):
History/WebHistoryItem.mm: (historyItemWrappers):
Misc/WebNSPasteboardExtras.mm: (imageFromElement):
WebView/WebFrame.mm:
WebView/WebScriptDebugger.mm: (toNSString):

11:52 AM Changeset in webkit [40171] by andersca@apple.com

37 edits in trunk/WebCore

2009-01-23 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Turn on -Wmissing-prototypes and fix the resulting warnings.

Configurations/Base.xcconfig:
bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter): (WebCore::JSLocation::customGetOwnPropertySlot):
bindings/objc/DOMRGBColor.mm: (WebCore::getWrapperForRGB): (WebCore::setWrapperForRGB): (WebCore::removeWrapperForRGB):
bindings/scripts/CodeGeneratorJS.pm:
bridge/c/c_instance.cpp: (JSC::Bindings::globalExceptionString):
bridge/runtime_object.cpp: (JSC::callRuntimeConstructor):
css/CSSParser.cpp: (WebCore::parseGradientColorStop):
css/CSSPrimitiveValue.cpp: (WebCore::scaleFactorForConversion):
css/CSSStyleSelector.cpp: (WebCore::operator >): (WebCore::operator <=): (WebCore::getTransformOperationType):
dom/make_names.pl:
editing/DeleteSelectionCommand.cpp: (WebCore::updatePositionForTextRemoval):
editing/EditorCommand.cpp: (WebCore::valueBackColor): (WebCore::valueFontName): (WebCore::valueFontSize): (WebCore::valueFontSizeDelta): (WebCore::valueForeColor):
editing/VisiblePosition.cpp: (WebCore::canonicalizeCandidate):
editing/htmlediting.cpp:
editing/markup.cpp: (WebCore::joinMarkups):
html/HTMLElement.cpp: (WebCore::inlineTagList): (WebCore::blockTagList):
html/HTMLMediaElement.cpp: (WebCore::serializeTimeOffset): (WebCore::parseTimeOffset):
page/mac/FrameMac.mm: (WebCore::regExpForLabels):
platform/Arena.cpp:
platform/graphics/Color.cpp: (WebCore::colorFloatToRGBAByte):
platform/graphics/cg/ImageSourceCG.cpp: (WebCore::imageSourceOptions):
platform/graphics/cg/PathCG.cpp: (WebCore::CGPathApplierToPathApplier):
platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::initFontData):
platform/mac/PlatformMouseEventMac.mm:
platform/text/String.cpp:
rendering/RenderBlock.cpp: (WebCore::continuationOutlineTable): (WebCore::getHeightForLineCount):
rendering/RenderView.cpp: (WebCore::rendererAfterPosition):
rendering/RootInlineBox.cpp: (WebCore::isEditableLeaf):
rendering/SVGRenderTreeAsText.cpp: (WebCore::hasFractions):
rendering/style/RenderStyle.cpp: (WebCore::positionedObjectMoved):
svg/SVGFont.cpp: (WebCore::floatWidthUsingSVGFontCallback): (WebCore::floatWidthMissingGlyphCallback): (WebCore::drawTextUsingSVGFontCallback): (WebCore::drawTextMissingGlyphCallback):
svg/SVGTransformable.cpp: (WebCore::parseTransformParamList):
svg/graphics/SVGPaintServerGradient.cpp: (WebCore::operator<<):
xml/XPathGrammar.y:
xml/XSLTExtensions.cpp:

11:42 AM Changeset in webkit [40170] by eric@webkit.org

5 edits
2 deletes in trunk/WebCore

No review, removing an empty file.

Remove RemoveNodeAttributeCommand since it was empty.

WebCore.pro:
WebCore.scons:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
editing/RemoveNodeAttributeCommand.cpp: Removed.
editing/RemoveNodeAttributeCommand.h: Removed.

11:40 AM Changeset in webkit [40169] by andersca@apple.com

10 edits in trunk/JavaScriptCore

2009-01-23 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Turn on -Wmissing-prototypes and fix the warnings.

API/JSClassRef.cpp: (clearReferenceToPrototype):
Configurations/Base.xcconfig:
runtime/Collector.cpp: (JSC::getPlatformThreadRegisters):
runtime/ExceptionHelpers.cpp: (JSC::createError):
runtime/JSGlobalObjectFunctions.h:
runtime/JSNumberCell.h:
runtime/UString.cpp: (JSC::initializeStaticBaseString): (JSC::createRep):
wtf/FastMalloc.cpp:
wtf/Threading.cpp:

11:16 AM Changeset in webkit [40168] by beidson@apple.com

7 edits
2 moves in trunk/WebCore

2009-01-23 Brady Eidson <beidson@apple.com>

Rubberstamped by Sam Weinig

Rework ScriptCachedPageData to ScriptCachedFrameData to more accurately reflect its true purpose

GNUmakefile.am:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:

bindings/js/ScriptCachedFrameData.cpp: Copied from bindings/js/ScriptCachedPageData.cpp. (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::domWindow): (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::restore): (WebCore::ScriptCachedFrameData::clear):
bindings/js/ScriptCachedFrameData.h: Copied from bindings/js/ScriptCachedPageData.h.
bindings/js/ScriptCachedPageData.cpp: Removed.
bindings/js/ScriptCachedPageData.h: Removed.

history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore):
history/CachedPage.h:

11:03 AM Changeset in webkit [40167] by sfalken@apple.com

2 edits in trunk/WebCore

Fix build.

rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::baselinePosition):

10:56 AM Changeset in webkit [40166] by darin@chromium.org

1 edit
1 copy in trunk/WebCore

2009-01-23 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23506
Copy existing ImageDecoder.h in preparation for landing Skia changes on top.

platform/image-decoders/skia/ImageDecoder.h: Copied from platform/image-decoders/ImageDecoder.h.

10:53 AM Changeset in webkit [40165] by darin@chromium.org

1 edit
8 copies
1 add in trunk/WebCore

2009-01-23 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23506
Copy existing image-decoders in preparation for landing Skia changes on top.

platform/image-decoders/skia: Added.
platform/image-decoders/skia/GIFImageDecoder.cpp: Copied from platform/image-decoders/gif/GIFImageDecoder.cpp.
platform/image-decoders/skia/GIFImageDecoder.h: Copied from platform/image-decoders/gif/GIFImageDecoder.h.
platform/image-decoders/skia/GIFImageReader.cpp: Copied from platform/image-decoders/gif/GIFImageReader.cpp.
platform/image-decoders/skia/GIFImageReader.h: Copied from platform/image-decoders/gif/GIFImageReader.h.
platform/image-decoders/skia/JPEGImageDecoder.cpp: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.cpp.
platform/image-decoders/skia/JPEGImageDecoder.h: Copied from platform/image-decoders/jpeg/JPEGImageDecoder.h.
platform/image-decoders/skia/PNGImageDecoder.cpp: Copied from platform/image-decoders/png/PNGImageDecoder.cpp.
platform/image-decoders/skia/PNGImageDecoder.h: Copied from platform/image-decoders/png/PNGImageDecoder.h.

9:19 AM BuildingQtOnLinux edited by kojot350@gmail.com

"Installing dependencies on OpenSUSE Linux" (diff)

8:57 AM Changeset in webkit [40164] by ap@webkit.org

1 edit
3 adds in trunk/LayoutTests

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=23478
Add a test for application test resource loading failure

http/tests/appcache/404-resource-expected.txt: Added.
http/tests/appcache/404-resource.html: Added.
http/tests/appcache/resources/404-resource.manifest: Added.

8:18 AM Changeset in webkit [40163] by zecke@webkit.org

2 edits in trunk/WebCore

Build fix in RenderThemeGtk for RenderBox usage.

8:07 AM Changeset in webkit [40162] by ap@webkit.org

9 edits in trunk/WebCore

2009-01-23 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 22720: Make XMLHttpRequest work in Workers
<https://bugs.webkit.org/show_bug.cgi?id=22720>

Add copy/adopt for ResourceResponse(Base)/ResourceRequest(Base) to allow the
data to be passed across threads.

No observable change in behavior, so no test.

platform/network/FormData.cpp: (WebCore::FormData::deepCopy):
platform/network/FormData.h:
platform/network/HTTPHeaderMap.cpp: (WebCore::HTTPHeaderMap::copyData): (WebCore::HTTPHeaderMap::adopt):
platform/network/HTTPHeaderMap.h:
platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData):
platform/network/ResourceRequestBase.h:
platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::adopt): (WebCore::ResourceResponseBase::copyData):
platform/network/ResourceResponseBase.h:

7:53 AM Changeset in webkit [40161] by ap@webkit.org

9 edits
2 adds in trunk/WebCore

2009-01-23 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23374
Add WorkerRunLoop to encapsulate message queue and timer heap.
This is first half (timer heap is added as separate patch).

GNUmakefile.am: Added WorkerRunLoop.cpp to the build.
WebCore.vcproj/WebCore.vcproj: Same as above.
WebCore.xcodeproj/project.pbxproj: Same as above
dom/WorkerContext.cpp: (WebCore::WorkerContext::postTask):
dom/WorkerContext.h:
dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): (WebCore::WorkerMessagingProxy::workerThreadCreated):
dom/WorkerRunLoop.cpp: Added. (WebCore::WorkerRunLoop::run): Runs the loop until terminate() is called. (WebCore::WorkerRunLoop::terminate): Causes the loop to exit. (WebCore::WorkerRunLoop::postTask): Adds a task to the internal queue.
dom/WorkerRunLoop.h: Added. (WebCore::WorkerRunLoop::WorkerRunLoop):
dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): (WebCore::WorkerThread::stop):
dom/WorkerThread.h: (WebCore::WorkerThread::runLoop):

7:02 AM Changeset in webkit [40160] by treat@webkit.org

2 edits in trunk/WebCore

Redo previous patch http://trac.webkit.org/changeset/34260 which fixes a
huge memory leak by ensuring that the timer is fired one last time on
application tear down thus triggering the GCController thereby freeing
JavaScript objects as well as triggering other timer based tear down methods.

6:50 AM Changeset in webkit [40159] by ap@webkit.org