Context Navigation

html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::HTMLMarqueeElement): (WebCore::HTMLMarqueeElement::canSuspend): (WebCore::HTMLMarqueeElement::suspend): (WebCore::HTMLMarqueeElement::resume):
html/HTMLMarqueeElement.h:
page/Frame.cpp: (WebCore::Frame::clearTimers):
rendering/RenderLayer.cpp:
rendering/RenderLayer.h: (WebCore::RenderLayer::marquee):

6:10 PM Changeset in webkit [42160] by dino@apple.com

2 edits in trunk/WebCore

2009-04-01 Dean Jackson <dino@apple.com>

Reviewed by Darin Adler

Make constant values static in previous commit, as suggested
by Darin.

rendering/RenderVideo.cpp:

5:57 PM Changeset in webkit [42159] by dino@apple.com

2 edits in trunk/WebCore

2009-04-01 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser

https://bugs.webkit.org/show_bug.cgi?id=24993

Standalone media should have a smaller instrinsic
height.

rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo):

5:30 PM Changeset in webkit [42158] by Darin Adler

23 edits
1 copy
1 move
6 adds in trunk

WebCore:

2009-04-01 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Bug 22378: Crash submitting a form when parsing an XHTML document
https://bugs.webkit.org/show_bug.cgi?id=22378
rdar://problem/6388377

Tests: fast/loader/submit-form-while-parsing-1.xhtml

fast/loader/submit-form-while-parsing-2.html

WebCore.base.exp: Updated.

history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): Renamed m_subItems to m_children. Used uncheckedAppend because we reserveInitialCapacity. (WebCore::HistoryItem::addChildItem): Renamed m_subItems to m_children. Added an assertion that this is only used to add items that don't have duplicate frame names. (WebCore::HistoryItem::setChildItem): Added. Replaces an existing item if any, preserving the isTargetItem flag. (WebCore::HistoryItem::childItemWithTarget): Renamed from childItemWithName for consistency with the other functions here that all call the frame name the "target". Also updated for rename of m_subItems to m_children. (WebCore::HistoryItem::findTargetItem): Renamed from recurseToFindTargetItem. Removed unneeded size check. (WebCore::HistoryItem::targetItem): Changed to always return the top item if no item has the isTargetItem flag set. The old version would instead return 0 in some cases, but return the top item if it had no children. (WebCore::HistoryItem::children): Renamed m_subItems to m_children. (WebCore::HistoryItem::hasChildren): Ditto. (WebCore::HistoryItem::showTreeWithIndent): Ditto.

history/HistoryItem.h: Name changes.

html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Create and pass a FormState instead of attaching "recorded form values" and "form about to be submitted" to the frame loader. Parameter work fine for this; there's no need to store state on the FrameLoader.

loader/FormState.cpp: (WebCore::FormState::FormState): Adopt a vector instead of copying a hash map. (WebCore::FormState::create): Ditto.
loader/FormState.h: Update to use a vector that we adopt instead of hash map that we copy for auto-fill text field values.

loader/FrameLoader.cpp: (WebCore::ScheduledRedirection::ScheduledRedirection): Added a new case for form submissions and turned the "wasDuringLoad" state into a separate boolean instead of using a special redirection type to track it. (WebCore::FrameLoader::createWindow): Updated for name and argument change of loadFrameRequest. (WebCore::FrameLoader::urlSelected): Ditto. (WebCore::FrameLoader::submitForm): Removed the "deferred form submission" machinery, replacing it with the "scheduled redirection" mechanism, shared with other kinds of redirection and navigation. Moved frame targeting here so we can schedule the redirection on the right frame. Moved the multiple form submission protection here. Moved the code to implement the rule that m_navigationDuringLoad was used for here too. (WebCore::FrameLoader::didOpenURL): Use the new wasDuringLoad flag instead of the locationChangeDuringLoad type to detect location change during a load. (WebCore::FrameLoader::executeScript): Removed call to now-obsolete function, submitFormAgain. (WebCore::FrameLoader::scheduleLocationChange): Moved the code to stop loading out of this function into scheduleRedirection, so it can be shared with the new scheduleFormSubmission function. (WebCore::FrameLoader::scheduleFormSubmission): Added. Almost the same as scheduleLocationChange, but with the arguments for a form submission. (WebCore::FrameLoader::scheduleRefresh): Updated for the change to the duringLoad flag. (WebCore::FrameLoader::isLocationChange): Added case for formSubmission and removed case for locationChangeDuringLoad. (WebCore::FrameLoader::redirectionTimerFired): Ditto. Also removed unneeded completeURL call and just use KURL constructor to match the other cases. (WebCore::FrameLoader::provisionalLoadStarted): Removed the code to set up the m_navigationDuringLoad, which is no longer needed. The new version of this is in the submitForm function and sets the lockHistory boolean. (WebCore::FrameLoader::scheduleRedirection): Moved the code to stop a load in here that used to be in scheduleLocationChange. (WebCore::FrameLoader::startRedirectionTimer): Added case for formSubmission and removed case for locationChangeDuringLoad. (WebCore::FrameLoader::stopRedirectionTimer): Ditto. (WebCore::FrameLoader::completed): Removed call to now-obsolete function, submitFormAgain. (WebCore::FrameLoader::loadFrameRequest): Renamed from loadFrameRequestWithFormAndValues. Replaced form element and form values argument with a single FormState argument. Changed frame targeting code to use the source frame in the case of a form submission to better match the actual target frame. (WebCore::FrameLoader::loadURL): Don't search for existing frames in the form submission case since we already did that in the submitForm function. (WebCore::FrameLoader::clientRedirected): Changed to work with the m_isExecutingJavaScriptFormAction data member directly instead of taking it as a function parameter. (WebCore::FrameLoader::loadPostRequest): Don't search for existing frames in the form submission case since we already did that in the submitForm function. (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): Moved comment in here that was misplaced elsewhere in the file. (WebCore::FrameLoader::findFrameForNavigation): Changed to use the early return idiom. (WebCore::FrameLoader::recursiveGoToItem): Updated for HistoryItem changes. (WebCore::FrameLoader::childFramesMatchItem): Ditto. (WebCore::FrameLoader::updateHistoryForStandardLoad): Removed the m_navigationDuringLoad logic; that's now handled by setting lockHistory to true in the submitForm function. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedBackForwardList): Use the new setChildItem function so we don't get multiple items for the same frame name in the history item tree in the back/forward list.

loader/FrameLoader.h: Renamed loadFrameRequestWithFormAndValues to loadFrameRequest and made it take a form state object instead of the form element and form values. Removed the unused functions loadEmptyDocumentSynchronously, provisionalDocumentLoader, notifyIconChnaged, and updateBaseURLForEmptyDocument. Changed the submitForm function to take a form state argument. Eliminated the clearRecordedFormValues, setFormAboutToBeSubmitted, and recordFormValue functions, which are replaced by the form state arguments to submitForm and loadFrameRequest. Removed the isJavaScriptFormAction argument from the clientRedirected function; instead it looks at a data member directly. Eliminated the submitFormAgain and overload of the submitForm function; these are now subsumed into the remaining submitForm function and the scheduleFormSubmission function. Removed unused and obsolete data members m_navigationDuringLoad, m_deferredFormSubmission, m_formAboutToBeSubmitted and m_formValuesAboutToBeSubmitted.

page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Updated for name and argument change of loadFrameRequest.

page/Frame.cpp: (WebCore::Frame::~Frame): Removed call to the now-unneeded clearRecordedFormValues function.

WebKit/mac:

2009-04-01 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Bug 22378: Crash submitting a form when parsing an XHTML document
https://bugs.webkit.org/show_bug.cgi?id=22378
rdar://problem/6388377

History/WebHistoryItem.mm: (-[WebHistoryItem targetItem]): Call targetItem directly instead of callling isTargetItem, hasChildren, and recurseToFindTargetItem.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm): Updated for the new textFieldValues function in FormState.

WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Updated for name and argument change of loadFrameRequest.

WebKit/win:

2009-04-01 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Bug 22378: Crash submitting a form when parsing an XHTML document
https://bugs.webkit.org/show_bug.cgi?id=22378
rdar://problem/6388377

WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): Updated for the new textFieldValues function in FormState.

LayoutTests:

2009-04-01 Darin Adler <Darin Adler>

Reviewed by Geoff Garen.

Bug 22378: Crash submitting a form when parsing an XHTML document
https://bugs.webkit.org/show_bug.cgi?id=22378
rdar://problem/6388377

fast/loader/onunload-form-submit-crash-2-expected.txt: Updated for change to the test.
fast/loader/onunload-form-submit-crash-2.html: Updated test to expect the form submission during the onunload handler to be ineffective.
fast/loader/onunload-form-submit-crash-expected.txt: Updated for change to the test.
fast/loader/onunload-form-submit-crash.html: Updated test to expect the form submission during the onunload handler to be ineffective.

fast/loader/resources/onunload-form-submit-crash2.html: Removed.
fast/loader/resources/onunload-form-submit-failure.html: Copied from LayoutTests/fast/loader/resources/onunload-form-submit-crash2.html.
fast/loader/resources/onunload-form-submit-success.html: Copied from LayoutTests/fast/loader/resources/onunload-form-submit-crash2.html.

fast/loader/resources/submit-form-while-parsing-subframe.html: Added.
fast/loader/resources/submit-form-while-parsing-success.html: Added.
fast/loader/submit-form-while-parsing-1-expected.txt: Added.
fast/loader/submit-form-while-parsing-1.xhtml: Added.
fast/loader/submit-form-while-parsing-2-expected.txt: Added.
fast/loader/submit-form-while-parsing-2.html: Added.

platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt: Updated to expect proper results, without the duplicate history items for the same frame name that were present before.

4:49 PM Changeset in webkit [42157] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-04-01 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, fixing previous commit.

https://bugs.webkit.org/show_bug.cgi?id=24994
Revert V8DOMMap.cpp change which accidentally snuck into the previous
commit.

bindings/v8/V8DOMMap.cpp: Revert change in previous commit.

4:43 PM Changeset in webkit [42156] by Dimitri Glazkov

5 edits in trunk/WebCore

2009-04-01 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24994
Fix miscellaneous merge/upstreaming divergencies in Chromium port.

bindings/v8/V8Collection.h: Added an include.
platform/KURLGoogle.cpp: (WebCore::KURL::baseAsString): Added to match KURL.cpp.
platform/chromium/ClipboardChromium.cpp: Added an include.

3:47 PM Changeset in webkit [42155] by Dimitri Glazkov

11 edits in trunk/WebCore

2009-04-01 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=24989
Refactor InspectorResource to use ScriptObject/FunctionCall.

bindings/js/JSInspectorControllerCustom.cpp: (WebCore::JSInspectorController::addResourceSourceToFrame): Tweaked to use

a more appropriate type conversion.

(WebCore::JSInspectorController::getResourceDocumentNode): Tweaked to

accommodate for InspectorResource refactoring.

bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::appendArgument): Added long long type to match

existing jsNumber call signature.

bindings/js/ScriptFunctionCall.h: Declaration for above.
bindings/js/ScriptObject.cpp: (WebCore::createEmptyObject): Added. (WebCore::ScriptObject::ScriptObject): (WebCore::ScriptObject::set): Added a bunch of property setters.
bindings/js/ScriptObject.h: Declarations for above.
inspector/InspectorController.cpp: Moved all InspectorResource-managing code

to InspectorResource.cpp

(WebCore::InspectorController::populateScriptObjects): Changed to use

refactored InspectorResource.

(WebCore::InspectorController::resetScriptObjects): Ditto.
(WebCore::InspectorController::pruneResources): Ditto.
(WebCore::InspectorController::didCommitLoad): Ditto.
(WebCore::InspectorController::addResource): Ditto.
(WebCore::InspectorController::removeResource): Ditto.
(WebCore::InspectorController::didLoadResourceFromMemoryCache): Ditto.
(WebCore::InspectorController::identifierForInitialRequest): Ditto.
(WebCore::InspectorController::willSendRequest): Ditto.
(WebCore::InspectorController::didReceiveResponse): Ditto.
(WebCore::InspectorController::didReceiveContentLength): Ditto.
(WebCore::InspectorController::didFinishLoading): Ditto.
(WebCore::InspectorController::didFailLoading): Ditto,
(WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): Ditto.
(WebCore::InspectorController::scriptImported): Ditto.

inspector/InspectorController.h: Removed InspectorResource-managing code decls

and tweaked some signatures to use ScriptString and long long for identifier.

inspector/InspectorController.idl: Changed to use long long for identifier.
inspector/InspectorResource.cpp: Refactored to use ScriptObject/FunctionCall. (WebCore::InspectorResource::InspectorResource): Ditto. (WebCore::InspectorResource::~InspectorResource): Ditto. (WebCore::InspectorResource::createCached): Added. (WebCore::InspectorResource::updateRequest): Added. (WebCore::InspectorResource::updateResponse): Added. (WebCore::createHeadersObject): Added. (WebCore::InspectorResource::createScriptObject): Added. (WebCore::InspectorResource::updateScriptObject): Added. (WebCore::InspectorResource::releaseScriptObject): Added. (WebCore::InspectorResource::type): Tweaked to use ScriptString. (WebCore::InspectorResource::setXMLHttpResponseText): Added. (WebCore::InspectorResource::sourceString): Tweaked to use ScriptString. (WebCore::InspectorResource::startTiming): Added. (WebCore::InspectorResource::markResponseReceivedTime): Added. (WebCore::InspectorResource::endTiming): Added. (WebCore::InspectorResource::markFailed): Added. (WebCore::InspectorResource::addLength): Added.
inspector/InspectorResource.h: Added decls for newly refactored-in methods. (WebCore::InspectorResource::create): Added. (WebCore::InspectorResource::isSameLoader): Added. (WebCore::InspectorResource::markMainResource): Added. (WebCore::InspectorResource::identifier): Added. (WebCore::InspectorResource::requestURL): Added. (WebCore::InspectorResource::frame): Added. (WebCore::InspectorResource::mimeType): Added. (WebCore::InspectorResource::Changes::Changes): Added new class to track

resource changes.

(WebCore::InspectorResource::Changes::hasChange): Added.
(WebCore::InspectorResource::Changes::set): Added.
(WebCore::InspectorResource::Changes::clear): Added.
(WebCore::InspectorResource::Changes::setAll): Added.
(WebCore::InspectorResource::Changes::clearAll): Added.

2:17 PM Changeset in webkit [42154] by darin@chromium.org

3 edits
4 adds in trunk

2009-04-01 Tony Chang <tony@chromium.org>

Reviewed by Darin Fisher.

Ensure the right click doesn't deselect text under it. This was
happening in the Chromium and GTK+ ports because they don't select
the text under the cursor on right click.

This was regressed in r41715, https://bugs.webkit.org/show_bug.cgi?id=19737

https://bugs.webkit.org/show_bug.cgi?id=24946

Test: fast/events/context-no-deselect.html

page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent):

12:48 PM Changeset in webkit [42153] by christian@webkit.org

3 edits
1 add in trunk

2009-04-01 Christian Dywan <christian@twotoasts.de>

Reviewed by Holger Freyther.

Unit test WebKitDownload
http://bugs.webkit.org/show_bug.cgi?id=24844

GNUmakefile.am: Add a unit test for downloading.

2009-04-01 Christian Dywan <christian@twotoasts.de>

Reviewed by Holger Freyther.

tests/testdownload.c: Added. (test_webkit_download_create): (main): Add an initial unit test for downloading.

12:32 PM Changeset in webkit [42152] by bolsinga@apple.com

9 edits in trunk

2009-04-01 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24990
Put SECTORDER_FLAGS into xcconfig files.

12:26 PM Changeset in webkit [42151] by Simon Fraser

2 edits in trunk/WebCore

2009-04-01 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24991

Need to use toRenderBoxModelObject(), not toRenderBox(), to test for layer()
when getting the transform.

rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer):

9:55 AM Changeset in webkit [42150] by kov@webkit.org

3 edits in trunk/WebKit/gtk

2009-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed typo fixes, and naming normalization in the
documentation.

docs/webkitenvironment.xml:
webkit/webkitwebview.cpp:

9:37 AM Changeset in webkit [42149] by kov@webkit.org

2 edits in trunk

2009-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix. Fix make distcheck, after the gtk-doc
integration.

GNUmakefile.am:

8:58 AM QtWebKitTodo edited by Simon Hausmann

(diff)

4:41 AM QtWebKitTodo edited by Simon Hausmann

(diff)

Mar 31, 2009:

11:43 PM Changeset in webkit [42148] by Darin Adler

3 edits in trunk/WebCore

2009-03-31 Darin Adler <Darin Adler>

Rolled out that last change until I can investigate the regression test failures it seems
to have caused.

dom/PositionIterator.cpp: (WebCore::PositionIterator::decrement):
dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator):

9:41 PM Changeset in webkit [42147] by Darin Adler

3 edits in trunk/WebCore

2009-03-31 Darin Adler <Darin Adler>

Reviewed by Eric Seidel.

Bug 24621: PositionIterator doesn't iterate "after last child" positions when going backwards
https://bugs.webkit.org/show_bug.cgi?id=24621

dom/PositionIterator.cpp: (WebCore::PositionIterator::decrement): Make sure that when the parent has no children, we don't ever use Position::uncheckedPreviousOffset. This is consistent with the forward iterator, but also should never arise because of the fix below.
dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator): Fixed so m_offset will always be 0 when the passed-in node has no children. Like the change above, this is consistent with the rest of the class, although in the long run I think it's a bit strange to treat a <p> element with no children differently than a <p> element with children.

5:13 PM Changeset in webkit [42146] by Adam Roben

2 edits in trunk/WebKitTools

Make resolve-ChangeLogs -f work when the working tree has spaces in its path

Reviewed by Mark Rowe and David Kilzer.

Scripts/resolve-ChangeLogs: (sub fixMergedChangeLogs): Quote the path to resolve-ChangeLogs in case it contains spaces.

3:57 PM Changeset in webkit [42145] by andersca@apple.com

5 edits in trunk/WebKit/mac

2009-03-31 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

WebKit side of <rdar://problem/6500266>.

Plugins/Hosted/NetscapePluginInstanceProxy.h:
Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::wheelEvent): Send the event.

Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView scrollWheel:]): Call NetscapePluginInstanceProxy::wheelEvent. If the plug-in processed the event, don't call super.

Plugins/Hosted/WebKitPluginHost.defs: Add definition.

3:13 PM Changeset in webkit [42144] by eric.carlson@apple.com

2 edits in trunk/WebCore

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24965
Bug 24965: HTMLMediaElement: network state changes can be missed

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Always update m_networkState when the state changes, even when no event needs to be fired.

2:55 PM Changeset in webkit [42143] by eric.carlson@apple.com

5 edits in trunk

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24964
Bug 24964: HTMLMediaElement: 'waiting' event may fire twice

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Only fire 'waiting' event once when ready state drops below HAVE_FUTURE_DATA.

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24964
Bug 24964: HTMLMediaElement: 'waiting' event may fire twice

http/tests/media/video-play-stall.html: Fail if 'waiting' fires more than once.
media/video-test.js: Fix a typo. (failTest):

2:39 PM Changeset in webkit [42142] by ap@webkit.org

2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24777
WebKit tools are broken on Tiger

Scripts/webkitdirs.pm: Don't use arch command with options on Tiger.

2:26 PM Changeset in webkit [42141] by eric.carlson@apple.com

9 edits
2 adds in trunk

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24846
Bug 24846: HTMLMediaElement should implement 'autobuffer' attribute

Add 'autobuffer' attrubute to media element. 'autobuffer' is a hint that
the author recommends downloading the entire resource optimistically, so the
attribute is made available to the media engine to use if it is able.

Test: media/video-dom-autobuffer.html

html/HTMLAttributeNames.in: Add autobuffer.

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute): New. (WebCore::HTMLMediaElement::autobuffer): Ditto. (WebCore::HTMLMediaElement::setAutobuffer): Ditto.

html/HTMLMediaElement.h: Declare autobuffer and setAutobuffer.

html/HTMLMediaElement.idl: Add autobuffer.

platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer): Initialize m_autobuffer. (WebCore::MediaPlayer::autobuffer): New. (WebCore::MediaPlayer::setAutobuffer): Ditto.
platform/graphics/MediaPlayer.h: Declare m_autobuffer, autobuffer and setAutobuffer

platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setAutobuffer): Declare setAutobuffer.

2009-03-31 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24846
Bug 24846: HTMLMediaElement should implement 'autobuffer' attribute

media/video-dom-autobuffer-expected.txt: Added.
media/video-dom-autobuffer.html: Added.

1:24 PM Changeset in webkit [42140] by Darin Adler

2 edits in trunk/WebKit/mac

2009-03-31 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

<rdar://problem/6740581> REGRESSION (r41793): Page Down and Page Up don’t work in Leopard Mail

WebView/WebHTMLView.mm: (-[WebResponderChainSink tryToPerform:with:]): Added. Without this we would think we had handled an event when we actually hadn't. Specifically, when -[WebFrameView scrollPageDown:] calls tryToPerform on the next responder.

1:23 PM Changeset in webkit [42139] by dimich@chromium.org

2 edits in trunk/WebCore

2009-03-31 Craig Schlenter <craig.schlenter@gmail.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24550
Check return value of vasprintf. This should keep gcc 4.3.3
happy rather than have it complain about attribute warn_unused_result.

dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):

1:11 PM Changeset in webkit [42138] by dino@apple.com

2 edits in trunk/WebCore

2009-03-31 Dean Jackson <dino@apple.com>

Style guide violation!

loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):

1:05 PM Changeset in webkit [42137] by dino@apple.com

2 edits in trunk/WebCore

2009-03-31 Dean Jackson <dino@apple.com>

Fix Tiger build.

loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):

12:56 PM Changeset in webkit [42136] by dimich@chromium.org

2 adds in trunk/WebCore/bindings/v8

Fixing previous commit - forgot to 'git add' new files.

12:55 PM Changeset in webkit [42135] by dimich@chromium.org

1 edit in trunk/WebCore/ChangeLog

2009-03-31 Jian Li <jianli@chromium.org>

Reviewed by Darin Fisher.

Upstream V8DOMMap for v8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=24951

bindings/v8/V8DOMMap.cpp: Added.
bindings/v8/V8DOMMap.h: Added.

12:50 PM Changeset in webkit [42134] by dino@apple.com

2 edits in trunk/WebCore

2009-03-31 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24955

Spacebar didn't play/pause in standalone MediaDocument

loader/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):

12:10 PM Changeset in webkit [42133] by dimich@chromium.org

2 edits in trunk/WebCore

2009-03-31 Alpha Lam <hclam@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24901
Added the following methods to MediaPlayerPrivate for Chromium port.
void sizeChanged();
void rateChanged();
void durationChanged();

The above changes are to reflect changes in MediaPlayer.cpp.
More details can be found in the original changeset.
http://trac.webkit.org/changeset/41907

platform/graphics/chromium/MediaPlayerPrivateChromium.h:

9:54 AM Changeset in webkit [42132] by Darin Adler

1 edit
1 add in trunk/WebKitTools

2009-03-31 Darin Adler <Darin Adler>

Scripts/add-include: Added.

9:46 AM Changeset in webkit [42131] by darin@chromium.org

4 edits in trunk/WebCore

2009-03-31 Rafael Weinstein <rafaelw@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24947

Special-case drawing text-shadow on win32, to let GDI draw in cases
when both fill & shadow color are opaque and the shadow has no blur.

platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawComplexText):
platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow): (WebCore::windowsCanHandleTextDrawing):
platform/graphics/skia/SkiaFontWin.h:

9:21 AM Changeset in webkit [42130] by darin@chromium.org