⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 23, 2009:

11:38 PM Changeset in webkit [42813] by adele@apple.com
  • 5 edits in trunk/LayoutTests

2009-04-23 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Updating test to make it easier to see the blockquote in the results.

  • editing/pasteboard/paste-blockquote-into-blockquote-3.html:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
  • platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt:
11:03 PM Changeset in webkit [42812] by mrowe@apple.com
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

Move deletionUI-helpers.js in to the correct location so that the
tests that use it can find it.

  • platform/mac/editing/deleting/resources/deletionUI-helpers.js: Renamed from LayoutTests/editing/deleting/resources/deletionUI-helpers.js.
10:12 PM Changeset in webkit [42811] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

With great sadness and a heavy heart I switch us back from YARR to WREC in
order to restore greenness to the world once more.

  • wtf/Platform.h:
10:04 PM Changeset in webkit [42810] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

More Windows build fixage.

9:16 PM Changeset in webkit [42809] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Attempt to fix the Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove a symbol that no longer exists.
8:47 PM Changeset in webkit [42808] by timothy@apple.com
  • 25 edits
    3 adds
    2 deletes in trunk

BUG 24604: WebKit profiler reports incorrect total times

JavaScriptCore:

2009-04-23 Francisco Tolmasky <​francisco@280north.com>

BUG 24604: WebKit profiler reports incorrect total times
<​https://bugs.webkit.org/show_bug.cgi?id=24604>

Reviewed by Timothy Hatcher and Kevin McCullough.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • profiler/CallIdentifier.h: (JSC::CallIdentifier::Hash::hash): (JSC::CallIdentifier::Hash::equal): (JSC::CallIdentifier::hash): (WTF::):
  • profiler/HeavyProfile.cpp: Removed.
  • profiler/HeavyProfile.h: Removed.
  • profiler/Profile.cpp: No more need for TreeProfile/HeavyProfile (JSC::Profile::create):
  • profiler/Profile.h:
  • profiler/ProfileNode.cpp:
  • profiler/ProfileNode.h:
  • profiler/TreeProfile.cpp: Removed.
  • profiler/TreeProfile.h: Removed.

WebCore:

2009-04-23 Francisco Tolmasky <​francisco@280north.com>

BUG 24604: WebKit profiler reports incorrect total times
<​https://bugs.webkit.org/show_bug.cgi?id=24604>

Reviewed by Timothy Hatcher and Kevin McCullough.

Made it so that most of the profiler functions now match the behavior of Shark. Most notably, in the
heavy view, child nodes now represent the statistics of the root node. Each root node of heavy view
displays flattened statistics for a particular function that ran during the profile, and each child
of these root nodes represents a callpath that lead to it. Thus, the statistics for each of these child
nodes should show how much of the root nodes values came from it. For example, if you had the following to
stacks take place during the profile:

A ->calls 1 times-> B ->calls 2 times-> C
D ->calls 4 times-> C

The tree for the C root node would look like this:

C -> B -> A

-> D

The number of calls values would look like this:

C (6) -> B (2) -> A(2)

-> D (4)

What this means is that "2 of the total 6 C calls came from B", "2 of the total C calls came from A", and
"4 of the total C calls came from D". Notice that the "A ->calls 2 time->" is completely ignored. This becomes
particularly tricky during recursive calls, because each child note can represent multiple possible paths. This
is the reason that we would get things like 40000% previously with recursion.

This is also the way gprof works, and as close as we can get to Shark's behavior (Shark is not instrumented so it
can't know exactly how many calls came from where, etc).

  • English.lproj/localizedStrings.js: Added "Average" for average times in the profile.
  • inspector/JavaScriptProfile.cpp: (WebCore::ProfileClass):
  • inspector/JavaScriptProfileNode.cpp: (WebCore::getParent): (WebCore::getHead): (WebCore::getCallUID): (WebCore::ProfileNodeClass):
  • inspector/front-end/BottomUpProfileDataGridTree.js: Added. (WebInspector.BottomUpProfileDataGridTree): (WebInspector.BottomUpProfileDataGridTree.prototype.focus): (WebInspector.BottomUpProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode): (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild): (WebInspector.BottomUpProfileDataGridNode.prototype._exclude): (WebInspector.BottomUpProfileDataGridNode.prototype._merge): (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.insertChild): (WebInspector.DataGrid.prototype.removeChild): (WebInspector.DataGrid.prototype.removeChildren): (WebInspector.DataGridNode.prototype.set hasChildren): (WebInspector.DataGridNode.prototype.get hasChildren):
  • inspector/front-end/ProfileDataGridTree.js: Added. (WebInspector.ProfileDataGridNode): (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds): (WebInspector.ProfileDataGridNode.prototype.get data): (WebInspector.ProfileDataGridNode.prototype.createCell): (WebInspector.ProfileDataGridNode.prototype.select): (WebInspector.ProfileDataGridNode.prototype.deselect): (WebInspector.ProfileDataGridNode.prototype.expand): (WebInspector.ProfileDataGridNode.prototype.insertChild): (WebInspector.ProfileDataGridNode.prototype.removeChild): (WebInspector.ProfileDataGridNode.prototype.removeChildren): (WebInspector.ProfileDataGridNode.prototype.findChild): (WebInspector.ProfileDataGridNode.prototype.get averageTime): (WebInspector.ProfileDataGridNode.prototype.get averagePercent): (WebInspector.ProfileDataGridNode.prototype.get selfPercent): (WebInspector.ProfileDataGridNode.prototype.get totalPercent): (WebInspector.ProfileDataGridNode.prototype._save): (WebInspector.ProfileDataGridNode.prototype._restore): (WebInspector.ProfileDataGridNode.prototype._merge): (WebInspector.ProfileDataGridTree): (WebInspector.ProfileDataGridTree.prototype.get expanded): (WebInspector.ProfileDataGridTree.prototype.appendChild): (WebInspector.ProfileDataGridTree.prototype.insertChild): (WebInspector.ProfileDataGridTree.prototype.removeChildren): (WebInspector.ProfileDataGridTree.prototype.findChild.WebInspector.ProfileDataGridNode.prototype.findChild.sort.WebInspector.ProfileDataGridNode.prototype.sort._save): (WebInspector.ProfileDataGridTree.propertyComparator.comparator): (WebInspector.ProfileDataGridTree.propertyComparator.else.comparator): (WebInspector.ProfileDataGridTree.propertyComparator):
  • inspector/front-end/ProfileView.js: (WebInspector.ProfileView): (WebInspector.ProfileView.prototype.set profile): (WebInspector.ProfileView.prototype.get bottomUpProfileDataGridTree): (WebInspector.ProfileView.prototype.get topDownProfileDataGridTree): (WebInspector.ProfileView.prototype.get currentTree): (WebInspector.ProfileView.prototype.set currentTree): (WebInspector.ProfileView.prototype.get topDownTree): (WebInspector.ProfileView.prototype.get bottomUpTree): (WebInspector.ProfileView.prototype.refresh): (WebInspector.ProfileView.prototype.refreshVisibleData): (WebInspector.ProfileView.prototype.refreshShowAsPercents): (WebInspector.ProfileView.prototype.performSearch.matchesQuery): (WebInspector.ProfileView.prototype.performSearch): (WebInspector.ProfileView.prototype._changeView): (WebInspector.ProfileView.prototype._focusClicked): (WebInspector.ProfileView.prototype._excludeClicked): (WebInspector.ProfileView.prototype._resetClicked): (WebInspector.ProfileView.prototype._sortProfile):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.showProfile): (WebInspector.ProfilesPanel.prototype.showView): (WebInspector.ProfilesPanel.prototype.searchMatchFound):
  • inspector/front-end/TopDownProfileDataGridTree.js: Added. (WebInspector.TopDownProfileDataGridNode): (WebInspector.TopDownProfileDataGridNode.prototype._populate): (WebInspector.TopDownProfileDataGridNode.prototype._exclude): (WebInspector.TopDownProfileDataGridTree): (WebInspector.TopDownProfileDataGridTree.prototype.focus): (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:

LayoutTests:

2009-04-23 Francisco Tolmasky <​francisco@280north.com>

BUG 24604: WebKit profiler reports incorrect total times
<​https://bugs.webkit.org/show_bug.cgi?id=24604>

Reviewed by Timothy Hatcher and Kevin McCullough.

Changed profile.treeProfile to just profile, since these aren't generated in C++ anymore.
Removed heavy-view test since heavy-view isn't an actual tree that is generated in C++ land anymore,
but rather just a different display of the normal treeProfile in the JS data grid.

  • fast/profiler/heavy-view-expected.txt: Removed.
  • fast/profiler/heavy-view.html: Removed.
  • fast/profiler/resources/profiler-test-JS-resources.js: profiles[i].treeProfile -> profiles[i].treeProfile (printProfilesDataWithoutTime):
6:50 PM Changeset in webkit [42807] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

Use static functions (and a couple templates)
to further reduce the amount of copy/paste code in SVGRenderTreeAsText

No test changes, only code cleanup.

  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeNameValuePair): (WebCore::writeNameAndQuotedValue): (WebCore::writeIfNotEmpty): (WebCore::writeIfNotDefault): (WebCore::writeStyle): (WebCore::writePositionAndStyle): (WebCore::operator<<):
6:42 PM Changeset in webkit [42806] by kmccullough@apple.com
  • 1 edit
    3 moves in trunk/LayoutTests

2009-04-23 Kevin McCullough <​kmccullough@apple.com>

  • Windows build fix. Mac only tests go in platform/mac
  • editing/deleting/deletionUI-borders.html: Removed.
  • editing/deleting/deletionUI-differing-background.html: Removed.
  • editing/deleting/deletionUI-minimum-size.html: Removed.
  • platform/mac/editing/deleting/deletionUI-borders.html: Copied from editing/deleting/deletionUI-borders.html.
  • platform/mac/editing/deleting/deletionUI-differing-background.html: Copied from editing/deleting/deletionUI-differing-background.html.
  • platform/mac/editing/deleting/deletionUI-minimum-size.html: Copied from editing/deleting/deletionUI-minimum-size.html.
6:09 PM Changeset in webkit [42805] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-23 Gavin Barraclough <​barraclough@apple.com>

Not Reviewed.

Speculative Windows build fix II.

  • yarr/RegexInterpreter.cpp:
5:53 PM Changeset in webkit [42804] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-04-23 Gavin Barraclough <​barraclough@apple.com>

Not Reviewed.

Speculative Windows build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • runtime/RegExp.cpp:
5:50 PM Changeset in webkit [42803] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Simon Fraser.

SVGRenderTreeAsText cleanup/code sharing.

No test changes, only code cleanup.

  • rendering/RenderText.cpp: (WebCore::RenderText::firstRunOrigin):
  • rendering/RenderText.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStandardPrefix): (WebCore::writeChildren): (WebCore::write): (WebCore::writeRenderResources):
5:39 PM Changeset in webkit [42802] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-23 Gavin Barraclough <​barraclough@apple.com>

Rubber stamped by salty sea dogs Sam & Geoff.

Enable YARR_JIT by default (where supported), replacing WREC.

  • wtf/Platform.h:
5:37 PM Changeset in webkit [42801] by Darin Adler
  • 1 edit
    2 deletes in trunk/LayoutTests

2009-04-23 Darin Adler <Darin Adler>

Removed some stray files that Geoff missed when rolling out changes.

  • svg/custom/resources/svg-fonts-in-text-controls.js: Removed.
  • svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
5:32 PM Changeset in webkit [42800] by barraclough@apple.com
  • 8 edits in trunk

JavaScriptCore:

2009-04-23 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff "Dread Pirate Roberts" Garen.

Various small fixes to YARR JIT, in preparation for enabling it by default.

  • Correctly index into the callframe when storing restart addresses for nested alternatives.
  • Allow backtracking back into matched alternatives of parentheses.
  • Fix callframe offset calculation for parenthetical assertions.
  • When a set of parenthese are quantified with a fixed and variable portion, and the variable portion is quantified once, this should not reset the pattern match on failure to match (the last match from the firxed portion should be preserved).
  • Up the pattern size limit to match PCRE's new limit.
  • Unlclosed parentheses should be reported with the message "missing )".
  • wtf/Platform.h:
  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::quantifyAtom): (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::matchParentheses): (JSC::Yarr::Interpreter::backtrackParentheses): (JSC::Yarr::ByteCompiler::emitDisjunction):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::loadFromFrameAndJump): (JSC::Yarr::RegexGenerator::generateParenthesesDisjunction): (JSC::Yarr::RegexGenerator::generateParentheticalAssertion): (JSC::Yarr::RegexGenerator::generateTerm): (JSC::Yarr::executeRegex):
  • yarr/RegexParser.h: (JSC::Yarr::Parser::): (JSC::Yarr::Parser::parseTokens): (JSC::Yarr::Parser::parse):
  • yarr/RegexPattern.h: (JSC::Yarr::PatternTerm::): (JSC::Yarr::PatternTerm::PatternTerm):

LayoutTests:

2009-04-23 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff "Dread Pirate Roberts" Garen.

This test tries to force itself into PCRE; modify the
test so that as well as dodging WREC it can also avoid
YARR!

  • fast/js/resources/regexp-overflow-too-big.js:
5:25 PM Changeset in webkit [42799] by Beth Dakin
  • 5 edits in trunk

WebCore:

2009-04-23 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

WebCore part of fix for <rdar://problem/6333461> REGRESSION
(r36864-r36869): Dragging stocks widget scrollbar drags the whole
widget

  • platform/Scrollbar.h: (WebCore::Scrollbar::isScrollbar):
  • platform/Widget.h: (WebCore::Widget::isScrollbar):

WebKit/mac:

2009-04-23 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler.

Fix for <rdar://problem/6333461> REGRESSION (r36864-r36869):
Dragging stocks widget scrollbar drags the whole widget

Look for our new WebCore scrollbars in the WebHTMLView and add
proper Dashboard regions for them.

  • WebView/WebView.mm: (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]): (-[WebView _addScrollerDashboardRegions:from:]):
4:59 PM Changeset in webkit [42798] by kmccullough@apple.com
  • 3 edits
    8 adds in trunk

WebCore:

2009-04-23 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adam Roben.

<rdar://problem/6808109> "Deletion UI" is not available for many
portions of HTML content

This patch makes the deletion UI show up in some new situations:
1) If a block's background color is different from its parent's
2) If a block has a background image.
3) If a block has a single visible border.
However the block must now not only be at least a minimum width and
height, but also exceed a minimum area. In practice this has led to
much better element selection.

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):

LayoutTests:

2009-04-23 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adam Roben.

<rdar://problem/6808109> "Deletion UI" is not available for many
portions of HTML content

This patch makes the deletion UI show up in some new situations:
1) If a block's background color is different from its parent's
2) If a block has a background image.
3) If a block has a single visible border.
However the block must now not only be at least a minimum width and
height, but also exceed a minimum area. In practice this has led to
much better element selection.

  • editing/deleting/deletionUI-borders.html: Added.
  • editing/deleting/deletionUI-differing-background.html: Added.
  • editing/deleting/deletionUI-minimum-size.html: Added.
  • editing/deleting/resources: Added.
  • editing/deleting/resources/deletionUI-helpers.js: Added. (debug): (determineDeletionUIExistence):
  • platform/mac/editing/deleting/deletionUI-borders-expected.txt: Added.
  • platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
  • platform/mac/editing/deleting/deletionUI-minimum-size-expected.txt: Added.
4:53 PM Changeset in webkit [42797] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Adding XMLTokenizer.cpp to the build.

4:32 PM Changeset in webkit [42796] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-23 John Sullivan <​sullivan@apple.com>

fixed <rdar://problem/6822479> Assertion failure after Reset Safari in new history-writing code

Reviewed by Oliver Hunt

  • History/WebHistory.mm: (-[WebHistoryPrivate data]): Return nil immediately if there are no entries; this matches a recent Windows-platform fix.
4:14 PM Changeset in webkit [42795] by mrowe@apple.com
  • 2 edits in tags/Safari-6530.7/JavaScriptCore

Temporarily work around <rdar://problem/6812854> by forcing our 2GB allocation up in to high memory.

Rubber-stamped by Geoff Garen.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):

3:46 PM Changeset in webkit [42794] by adele@apple.com
  • 2 edits in trunk/WebCore

2009-04-23 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/6788905> REGRESSION (41928?): hang in Position::upstream
​https://bugs.webkit.org/show_bug.cgi?id=25312

I was unable to reproduce the problem, but I'm pretty sure this will fix it.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition): Since VisiblePosition doesn't ensure the offset is good, we shouldn't pass max int as an offset.
3:38 PM Changeset in webkit [42793] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

3:38 PM Changeset in webkit [42792] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.7

New tag.

3:33 PM Changeset in webkit [42791] by Dimitri Glazkov
  • 5 edits
    2 adds in trunk

WebCore:

2009-04-23 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=25313
Missing scroll bars in GMail.

Test: fast/overflow/overflow-y-scroll.html

  • platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars): Added check for the ScrollbarAlwaysOn scroll mode.

LayoutTests:

2009-04-23 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.
​https://bugs.webkit.org/show_bug.cgi?id=25313
Missing scroll bars in GMail.

  • fast/overflow/overflow-y-scroll-expected.txt: Added.
  • fast/overflow/overflow-y-scroll.html: Added.

WebKit/mac:

2009-04-23 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=25313
Missing scroll bars in GMail.

  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Added check for the ScrollbarAlwaysOn

scroll mode.

3:17 PM Changeset in webkit [42790] by kdecker@apple.com
  • 2 edits in trunk/WebKit/mac

Fix the Tiger build

3:03 PM Changeset in webkit [42789] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-04-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoffrey Garen.

Fix <rdar://problem/6821992>

Add a new m_inDestroy member variable. Set it to true when in destroy, and have all NPRuntime functions return false
when m_inDestroy is true.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): (WebKit::NetscapePluginInstanceProxy::destroy): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::getProperty): (WebKit::NetscapePluginInstanceProxy::setProperty): (WebKit::NetscapePluginInstanceProxy::removeProperty): (WebKit::NetscapePluginInstanceProxy::hasProperty): (WebKit::NetscapePluginInstanceProxy::hasMethod): (WebKit::NetscapePluginInstanceProxy::enumerate):
2:22 PM Changeset in webkit [42788] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Justin Garcia.

  • fix <rdar://problem/6081309> Mail crash when pressing down arrow in some messages in WebCore::canHaveChildrenForEditing

Test: editing/selection/extend-by-line-anonymous-content-crash.html

  • editing/visible_units.cpp: (WebCore::previousLinePosition): Null-check node. If p is not an editable position, then closestLeafChildForXPos() may have returned a non-editable box, and in particular one belonging to anonymous content. If node is 0, fall back on RenderObject::positionForPoint, which finds the closest position in non-anonymous content. (WebCore::nextLinePosition): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition): Fixed a typo.

LayoutTests:

Reviewed by Justin Garcia.

  • test for <rdar://problem/6081309> Mail crash when pressing down arrow in some messages in WebCore::canHaveChildrenForEditing
  • editing/selection/extend-by-line-anonymous-content-crash-expected.txt: Added.
  • editing/selection/extend-by-line-anonymous-content-crash.html: Added.
1:49 PM Changeset in webkit [42787] by hyatt@apple.com
  • 3 edits in trunk/WebKit/mac

2009-04-23 David Hyatt <​hyatt@apple.com>

Reviewed by Maciej.

Fix for <rdar://problem/6789879> REGRESSION (42464): Hitting assertion when loading message in Mail + TOT WebKit


Make the Mac platform the same as all the other platforms. Instead of (incorrectly) marking a FrameView for layout
when its underlying document view changes, just mark the outermost frame view for layout when the WebView's size changes.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView addSuperviewObservers]):
  • WebView/WebView.mm: (-[WebView _boundsChanged]): (-[WebView removeSizeObservers]): (-[WebView addSizeObservers]):
1:08 PM Changeset in webkit [42786] by kdecker@apple.com
  • 6 edits in trunk/WebKit/mac

Reviewed by Tim Hatcher.

Second part of the fix for <rdar://problem/6352982>

  • Plugins/WebBaseNetscapePluginView.h: Make this class conform to WebPluginContainerCheckController
  • Plugins/WebBaseNetscapePluginView.mm: Likewise. (-[WebBaseNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Added skeleton method.
  • Plugins/WebPluginContainerCheck.h: Added protocol for <WebPluginContainerCheckController>
  • Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck initWithRequest:target:resultObject:selector:controller:]):
  • Plugins/WebPluginController.h: Make this class conform to WebPluginContainerCheckController
12:58 PM Changeset in webkit [42785] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Adele Peterson.

<rdar://problem/6791439> REGRESSION: Get an error page instead of login page navigating back in gmail

Test: http/tests/history/back-to-post.php

  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Apply a new cache policy if it changed after the platform request was first created. While at it, also made sure to update timeout.
12:02 PM Changeset in webkit [42784] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk/po

2009-04-23 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

  • pt_BR.po: translation update.
11:45 AM Changeset in webkit [42783] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-04-23 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

When creating a new drawable object, collect system's
information about the best depth it can provide and use it
in a new colormap that the new drawable requires.

  • platform/graphics/gtk/ImageGtk.cpp: (WebCore::BitmapImage::getGdkPixbuf):
11:06 AM Changeset in webkit [42782] by kdecker@apple.com
  • 8 edits
    2 adds in trunk/WebKit

Reviewed by Anders Carlsson.


First part of <rdar://problem/6352982>

  • Plugins/WebBaseNetscapePluginView.h: Imported #WebNetscapeContainerCheckPrivate.h; Added two new method: checkIfAllowedToLoadURL:url:frame:callbackFunc: and cancelCheckIfAllowedToLoadURL:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]): Added skeleton method, does nothing interesting yet. (-[WebBaseNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Likewise.
  • Plugins/WebNetscapeContainerCheckPrivate.h: Added.
  • Plugins/WebNetscapeContainerCheckPrivate.mm: Added. (browserContainerCheckFuncs): Added.
  • Plugins/WebNetscapePluginView.h: Imported #WebNetscapeContainerCheckPrivate.h;
  • Plugins/WebNetscapePluginView.mm: Imported #WebNetscapeContainerCheckPrivate.h; added WKN_CheckIfAllowedToLoadURL and WKN_CancelCheckIfAllowedToLoadURL functions. (-[WebNetscapePluginView getVariable:value:]): Return vtable for container check functions.
  • Plugins/npapi.mm: (WKN_CheckIfAllowedToLoadURL): Added new private function. (WKN_CancelCheckIfAllowedToLoadURL): Ditto.
9:42 AM Changeset in webkit [42781] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip a newly-added test that fails on Windows

See Bug 25344: http/tests/misc/redirect-to-external-url.html fails on
Windows
<​https://bugs.webkit.org/show_bug.cgi?id=25344>

Reviewed by Brady Eidson.

  • platform/win/Skipped: Added http/tests/misc/redirect-to-external-url.html.
8:39 AM Changeset in webkit [42780] by kov@webkit.org
  • 4 edits in trunk/WebCore

2009-04-23 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=15654
GdkPixbuf support for ImageCairo

Add support for converting a Cairo surface to a GdkPixbuf.

  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h: (WebCore::Image::getGdkPixbuf):
  • platform/graphics/gtk/ImageGtk.cpp: (WebCore::BitmapImage::getGdkPixbuf):
8:07 AM Changeset in webkit [42779] by vestbo@webkit.org
  • 1 edit in trunk/WebKit/qt/Api/qwebelement.cpp

Fix Qt build warning

7:55 AM Changeset in webkit [42778] by ariya@webkit.org
  • 3 edits in trunk/WebCore

2009-04-23 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Make windowed plugins (on X11, Qt) behave nicer with wheel scrolling.

Basically, what we want is to send wheel events to the plugin *only*
when it has focus, or else send it to the parent frame.

This is a work around, and basically what we do, is to steal the
wheel events from the plugin, modify the window ID, and put the
event back into the Qt event loop.

  • plugins/qt/PluginContainerQt.cpp: (PluginClientWrapper::PluginClientWrapper): (PluginClientWrapper::~PluginClientWrapper): (PluginClientWrapper::x11Event): (PluginContainerQt::PluginContainerQt): (PluginContainerQt::~PluginContainerQt): (PluginContainerQt::on_clientClosed): (PluginContainerQt::on_clientIsEmbedded): (PluginContainerQt::redirectWheelEventsToParent): (PluginContainerQt::x11Event): (PluginContainerQt::focusInEvent):
  • plugins/qt/PluginContainerQt.h:
6:53 AM Changeset in webkit [42777] by ariya@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-04-23 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Ariya Hidayat.

[Qt] Added QWebElement::computedStyleProperty method.

  • Api/qwebelement.cpp: (QWebElement::computedStyleProperty):
  • Api/qwebelement.h:
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::computedStyle):
5:46 AM QtWebKitTodo edited by vestbo@webkit.org
(diff)
5:36 AM QtWebKitJournal edited by vestbo@webkit.org
(diff)
4:30 AM Changeset in webkit [42776] by vestbo@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-04-23 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Rubber-stamped by Ariya Hidayat.

[Qt] Rename QWebElement arguments from html to markup

12:25 AM Changeset in webkit [42775] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix the Windows DRT build.

  • DumpRenderTree/win/PolicyDelegate.h:
12:10 AM Changeset in webkit [42774] by beidson@apple.com
  • 2 edits in trunk/WebKitTools

2009-04-23 Brady Eidson <​beidson@apple.com>

Fix Windows DRT build.

  • DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::unableToImplementPolicyWithError):
12:09 AM Changeset in webkit [42773] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2009-04-23 Brady Eidson <​beidson@apple.com>

Update my just-landed layout test to agree with Tiger's CFNetwork

  • http/tests/misc/resources/redirect-to-external-url.php:

Apr 22, 2009:

11:42 PM Changeset in webkit [42772] by beidson@apple.com
  • 7 edits
    8 adds in trunk

WebCore:

2009-04-22 Brady Eidson <​beidson@apple.com>

Reviewed by Maciej Stachowiak

<rdar://problem/6786961> - "Are you sure you want to resubmit this form?" nag displays twice.

For most loads, we were consulting the navigation policy delegate twice. Once from FrameLoader before
the load started and once from MainResourceLoader in its willSendRequest callback.

In the past we tried removing MainResourceLoader's call altogether. This caused a regression where urls
that redirect to a url handled by an external application would no longer work in Safari. It probably
also broke other WebKit apps in subtle ways.

Changing MainResourceLoader to make the check only on redirects fixes both bugs. We now only call the
policy delegate once for most standard loads, but we do correctly call it a second time for redirects.

Tests: http/tests/misc/policy-delegate-called-twice.html

http/tests/misc/redirect-to-external-url.html

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Call the navigation policy delegate only for redirects.

WebKitTools:

2009-04-22 Brady Eidson <​beidson@apple.com>

Reviewed by Maciej Stachowiak

Add additional support for test:
<rdar://problem/5689748> - Cannot redirect to protocols handled by external applications.

  • DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]): Dump formatted information when a policy cannot be implemented.
  • DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
  • DumpRenderTree/win/PolicyDelegate.h:

LayoutTests:

2009-04-22 Brady Eidson <​beidson@apple.com>

Reviewed by Maciej Stachowiak

With the fix for:
<rdar://problem/6786961> - "Are you sure you want to resubmit this form?" nag displays twice.
And also to make sure we never rebreak:
<rdar://problem/5689748> - Cannot redirect to protocols handled by external applications.

  • http/tests/misc/redirect-to-external-url-expected.txt: Added.
  • http/tests/misc/redirect-to-external-url.html: Added.
  • http/tests/misc/resources/redirect-to-external-url-iframe.html: Added.
  • http/tests/misc/resources/redirect-to-external-url.php: Added.
  • http/tests/misc/policy-delegate-called-twice-expected.txt: Added.
  • http/tests/misc/policy-delegate-called-twice.html: Added.
  • http/tests/misc/resources/iframe-policy-1.html: Added.
  • http/tests/misc/resources/iframe-policy-2.html: Added.
9:06 PM Changeset in webkit [42771] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Add the m_ prefix on FixedVMPoolAllocator's member variables, and fix typos in a few comments.

Rubber-stamped by Gavin Barraclough.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::addToFreeList):
(JSC::FixedVMPoolAllocator::coalesceFreeSpace):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isWithinVMPool):

9:06 PM Changeset in webkit [42770] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Add some assertions to FixedVMPoolAllocator to guard against cases where we
attempt to free memory that didn't originate from the pool, or we attempt to
hand out a bogus address from alloc.

Rubber-stamped by Gavin Barraclough.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isWithinVMPool):

7:41 PM Changeset in webkit [42769] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-04-22 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Fix for <rdar://problem/6800695>

Add a hack to only allow navigating (via a link from a http page)
to feed: urls (same for feeds: and feedsearch:) that map to http:
or https: via their nested protocol. This includes both feed://example.com
and feed:http://example.com.

  • loader/FrameLoader.cpp: (WebCore::isFeedWithNestedProtocolInHTTPFamily): (WebCore::FrameLoader::loadFrameRequest):
7:34 PM Changeset in webkit [42768] by weinig@apple.com
  • 7 edits in trunk/WebCore

2009-04-22 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Autogenerate the XMLHttpRequest constructor getter/setter for the
WorkerContext and remove the now no longer needed JSWorkerContextBase.lut.h
file.

  • DerivedSources.make: Remove JSWorkerContextBase.lut.h
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSWorkerContextBase.cpp:
  • bindings/js/JSWorkerContextBase.h: Remove code to support hand written code for XMLHttpRequest constructor lookup and shadowing.
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::customGetOwnPropertySlot): Remove JSC prefixes. (WebCore::JSWorkerContext::xmlHttpRequest): Added. Custom implementation of cached constructor lookup.
  • workers/WorkerContext.idl: Make the XMLHttpRequestConstructor accessor not V8 specific.
6:43 PM Changeset in webkit [42767] by adachan@apple.com
  • 6 edits in trunk

WebKitLibraries:

Update WebKitSystemInterface with new method that maps CFNetwork error code to localized description.


Reviewed by Darin Adler.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:

WebKit/win:

<rdar://problem/5115298> Don't get error msg when download is interrupted and cannot resume due to server unavailability
If we fail to get an error description back from CFNetwork, try to get the localized description
based on the error code.

Reviewed by Darin Adler.

  • WebError.cpp: (WebError::localizedDescription):
6:07 PM Changeset in webkit [42766] by Darin Adler
  • 2 edits in trunk/WebCore

2009-04-22 Darin Adler <Darin Adler>

  • page/Navigator.idl: Touch this file to fix build since Geolocation configuration was recently turned off.
6:02 PM Changeset in webkit [42765] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Include updated results

5:59 PM Changeset in webkit [42764] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Modify test to only record the important mouse events

Reviewed by Geoff Garen.

5:54 PM Changeset in webkit [42763] by justin.garcia@apple.com
  • 3 edits
    6 adds in trunk

WebCore:

2009-04-22 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=25322
Can't delete empty paragraph after a block image


Empty paragraph removal would have been handled by mergeParagraphs, but we stopped short
because of some code that avoided problems that would arise from Positions that would go
bad during deletion.


We have several checks that prevent us from using bad Positions, this one in particular
was added to avoid bad Positions that result from text removal. So, I removed the check
and started correctly updating m_downstreamEnd during text removal so that it doesn't go
bad. m_upstreamStart doesn't need to be updated during text removal, since only text
after it will ever be removed.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::deleteTextFromNode): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::mergeParagraphs):

LayoutTests:

2009-04-22 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin Adler.


​https://bugs.webkit.org/show_bug.cgi?id=25322
Can't delete empty paragraph after a block image

  • editing/deleting/25322-1-expected.txt: Added.
  • editing/deleting/25322-1.html: Added.
  • editing/deleting/25322-2-expected.txt: Added.
  • editing/deleting/25322-2.html: Added.
  • editing/deleting/25322-3-expected.txt: Added.
  • editing/deleting/25322-3.html: Added.
5:49 PM Changeset in webkit [42762] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-04-22 Darin Adler <Darin Adler>

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Fixed one case Eric seems to have missed earlier today of RenderImage -> RenderSVGImage.
5:37 PM Changeset in webkit [42761] by oliver@apple.com
  • 7 edits in trunk

<rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves

Reviewed by Darin Adler.

Make mouseUp target the correct frame when the original
mousedown made the drag non-capturing.

5:29 PM Changeset in webkit [42760] by oliver@apple.com
  • 5 edits
    3 adds in trunk

<rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves

Reviewed by Darin Adler.

This is the first step of allowing drag events to match the behaviour
of mouse move events when the default action of the initial mouse down
is prevented. Remaining issue is that the final mouse up event still
targets the original root frame.

Test: fast/events/mouse-drag-from-frame-to-other-frame.html

5:01 PM Changeset in webkit [42759] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-04-22 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson

<rdar://problem/6702882> QT movie's video fails to be displayed after switching between tabs
<rdar://problem/6754957> Resizing Web browser window and hitting play will cause video blocks and artifacting

When in a media document, MediaPlayerPrivateQTKit uses a QTMovieView which may get
layer backing under some circumstances. However, drawing the view via
displayRectIgnoringOpacity:inContext: bypasses any layer setup that AppKit normally performs.
So when in the media document, we draw via displayRectIgnoringOpacity:.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint):
4:56 PM Changeset in webkit [42758] by mrowe@apple.com
  • 3 edits in trunk/LayoutTests

Update test results after Blackbeard's change in r42752 to disable geolocation.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/navigator-detached-no-crash-expected.txt:
3:59 PM Changeset in webkit [42757] by Simon Fraser
  • 2 edits
    2 adds in trunk

2009-04-22 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=24849

Add tests for media 'played' attribute (missed in r42619).

  • media/video-played-expected.txt: Added.
  • media/video-played.html: Added.
3:51 PM Changeset in webkit [42756] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

Fix <rdar://problem/6792694>


When we're trying to instantiate a plug-in and the plug-in host has died, we need to invalidate the
instance so that it doesn't stick around and do bad things.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin):
2:52 PM Changeset in webkit [42755] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-22 Gavin Barraclough <​barraclough@apple.com>

Rubber stamped by Sam "Blackbeard" Weinig.

Although pirates do spell the word 'generate' as 'genertate',
webkit developers do not. Fixerate.

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateAssertionBOL): (JSC::Yarr::RegexGenerator::generateAssertionEOL): (JSC::Yarr::RegexGenerator::generateAssertionWordBoundary): (JSC::Yarr::RegexGenerator::generatePatternCharacterSingle): (JSC::Yarr::RegexGenerator::generatePatternCharacterPair): (JSC::Yarr::RegexGenerator::generatePatternCharacterFixed): (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassSingle): (JSC::Yarr::RegexGenerator::generateCharacterClassFixed): (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy): (JSC::Yarr::RegexGenerator::generateCharacterClassNonGreedy): (JSC::Yarr::RegexGenerator::generateTerm):
2:44 PM Changeset in webkit [42754] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-04-22 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Sam "Blackbeard" Weinig.

Improvements to YARR JIT. This patch expands support in three key areas:

  • Add (temporary) support for falling back to PCRE for expressions not supported.
  • Add support for x86_64 and Windows.
  • Add support for singly quantified parentheses (? and ??), alternatives within parentheses, and parenthetical assertions.
  • runtime/RegExp.cpp: (JSC::RegExp::match):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::storeToFrame): (JSC::Yarr::RegexGenerator::storeToFrameWithPatch): (JSC::Yarr::RegexGenerator::loadFromFrameAndJump): (JSC::Yarr::RegexGenerator::AlternativeBacktrackRecord::AlternativeBacktrackRecord): (JSC::Yarr::RegexGenerator::TermGenerationState::resetAlternative): (JSC::Yarr::RegexGenerator::TermGenerationState::resetTerm): (JSC::Yarr::RegexGenerator::TermGenerationState::jumpToBacktrack): (JSC::Yarr::RegexGenerator::TermGenerationState::plantJumpToBacktrackIfExists): (JSC::Yarr::RegexGenerator::TermGenerationState::addBacktrackJump): (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracks): (JSC::Yarr::RegexGenerator::TermGenerationState::propagateBacktrackingFrom): (JSC::Yarr::RegexGenerator::genertateAssertionBOL): (JSC::Yarr::RegexGenerator::genertateAssertionEOL): (JSC::Yarr::RegexGenerator::matchAssertionWordchar): (JSC::Yarr::RegexGenerator::genertateAssertionWordBoundary): (JSC::Yarr::RegexGenerator::genertatePatternCharacterSingle): (JSC::Yarr::RegexGenerator::genertatePatternCharacterPair): (JSC::Yarr::RegexGenerator::genertatePatternCharacterFixed): (JSC::Yarr::RegexGenerator::genertatePatternCharacterGreedy): (JSC::Yarr::RegexGenerator::genertatePatternCharacterNonGreedy): (JSC::Yarr::RegexGenerator::genertateCharacterClassSingle): (JSC::Yarr::RegexGenerator::genertateCharacterClassFixed): (JSC::Yarr::RegexGenerator::genertateCharacterClassGreedy): (JSC::Yarr::RegexGenerator::genertateCharacterClassNonGreedy): (JSC::Yarr::RegexGenerator::generateParenthesesDisjunction): (JSC::Yarr::RegexGenerator::generateParenthesesSingle): (JSC::Yarr::RegexGenerator::generateParentheticalAssertion): (JSC::Yarr::RegexGenerator::generateTerm): (JSC::Yarr::RegexGenerator::generateDisjunction): (JSC::Yarr::RegexGenerator::generateEnter): (JSC::Yarr::RegexGenerator::generateReturn): (JSC::Yarr::RegexGenerator::RegexGenerator): (JSC::Yarr::RegexGenerator::generate): (JSC::Yarr::RegexGenerator::compile): (JSC::Yarr::RegexGenerator::generationFailed): (JSC::Yarr::jitCompileRegex): (JSC::Yarr::executeRegex):
  • yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::RegexCodeBlock): (JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
2:24 PM Changeset in webkit [42753] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix a crash in Mail when forwarding a specific HTML email.
Caused by the fix for <rdar://problem/6512520> (r42096).
Unable to create a test case that works outside of Mail.

<rdar://problem/6796069>

Reviewed by Ada Chan.

  • editing/markup.cpp: (WebCore::createMarkup): Null check pastEnd before trying to call Range::compareBoundaryPoints.
1:44 PM QtWebKitJournal edited by tonikitoo@gmail.com
(diff)
12:09 PM Changeset in webkit [42752] by weinig@apple.com
  • 8 edits in trunk

JavaScriptCore:

2009-04-22 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Fix for <rdar://problem/6816957>
Turn off Geolocation by default

  • Configurations/FeatureDefines.xcconfig:

WebCore:

2009-04-22 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Fix for <rdar://problem/6816957>
Turn off Geolocation by default

  • Configurations/FeatureDefines.xcconfig:

WebKit/mac:

2009-04-22 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Fix for <rdar://problem/6816957>
Turn off Geolocation by default

  • Configurations/FeatureDefines.xcconfig:

WebKitTools:

2009-04-22 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Fix for <rdar://problem/6816957>
Turn off Geolocation by default

  • Scripts/build-webkit:
11:03 AM Changeset in webkit [42751] by eric@webkit.org
  • 43 edits in trunk

Rubber-stamped by David Hyatt.

Change RenderSVGImage to dump as RenderSVGImage instead of RenderImage

  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::renderName):
8:48 AM Changeset in webkit [42750] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix a crash on Gmail when they remove a "before unload" event listener when
it was never added to the pending map in the first place.

<rdar://problem/6814144>

Reviewed by Darin Adler.

  • page/DOMWindow.cpp: (WebCore::allowsPendingBeforeUnloadListeners): Renamed from shouldAddPendingBeforeUnloadListener. (WebCore::DOMWindow::addEventListener): Call allowsPendingBeforeUnloadListeners now. (WebCore::DOMWindow::removeEventListener): Call allowsPendingBeforeUnloadListeners before removing the before unload listener. (WebCore::DOMWindow::clearAttributeEventListener): Ditto.
6:39 AM Changeset in webkit [42749] by ariya@webkit.org
  • 4 edits in trunk/WebCore

2009-04-22 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Ariya Hidayat.

Made windowed plugins move/resize synchronized with the painting, so
that windowed plugins are not moved before the rest of the parent
frame during scrolling.

  • plugins/qt/PluginContainerQt.cpp: (PluginContainerQt::PluginContainerQt): (PluginContainerQt::requestGeometry): (PluginContainerQt::adjustGeometry):
  • plugins/qt/PluginContainerQt.h:
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::updatePluginWidget): (WebCore::PluginView::paint):
5:34 AM Changeset in webkit [42748] by Simon Hausmann
  • 6 edits
    2 adds in trunk/WebCore

2009-04-22 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Fix various bugs in the X11 Qt plugin focus handling.

Notify the focus controller on activation/deactivation of the plugin and
set focus on the plugin's element when it receives the window system
focus.

5:08 AM Changeset in webkit [42747] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-04-22 Tamas Szirbucz <​szirbucz.tamas@stud.u-szeged.hu>

Reviewed by Ariya Hidayat.

​https://bugs.webkit.org/show_bug.cgi?id=25023
Delete reply in QNetworkReplyHandler::abort() to avoid leak.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::abort):
3:44 AM QtWebKitJournal edited by Simon Hausmann
(diff)
1:52 AM Changeset in webkit [42746] by jhoneycutt@apple.com
  • 12 edits in trunk

2009-04-21 Jon Honeycutt <​jhoneycutt@apple.com>

Allow the UI delegate to control cursor-setting.

Reviewed by Ada Chan.

WebCore/:

  • page/Chrome.cpp: (WebCore::Chrome::setCursor): Pass the call to the client.
  • page/Chrome.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::setCursor): Stubbed; returns false.
  • platform/Cursor.h: Define PlatformCursorHandle for each platform.
  • platform/win/WidgetWin.cpp: Reordered some includes. Added an include of Page.h. (WebCore::Widget::setCursor): Fixed a typo in the comment about ignoreNextSetCursor. Get the Page, and call its Chrome's setCursor() method with the passed cursor. Fall back to SetCursor() if the Page is not available.
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handleMouseEvent): Remove an unused variable. Cleaned up some whitespace.

WebKit/win/:

  • Interfaces/IWebUIDelegatePrivate.idl: Added a function to the IWebUIDelegatePrivate5 interface.
  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::setCursor): Try to call the UI delegate's webViewSetCursor() method. If it fails, fall back to calling SetCursor() with the passed cursor.
  • WebCoreSupport/WebChromeClient.h:
  • WebView.cpp: (WebViewWndProc): Call the Chrome's setCursor() method with the last set cursor.
12:22 AM Changeset in webkit [42745] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

Note: See TracTimeline for information about the timeline view.