⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 30, 2009:

11:54 PM Changeset in webkit [46624] by beidson@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

2009-07-30 Brady Eidson <​beidson@apple.com>

Reviewed by Mark Rowe, but Dan Bernstein also reviewed and asked thoughtful questions.

<rdar://problem/7106968> and ​https://bugs.webkit.org/show_bug.cgi?id=27868
​http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit, works in others.


Test: http/tests/misc/meta-refresh-stray-single-quote.html

  • platform/network/HTTPParsers.cpp: (WebCore::parseHTTPRefresh): Allow for a stray quote character at the start of the URL string.

LayoutTests:

2009-07-30 Brady Eidson <​beidson@apple.com>

Reviewed by Mark Rowe, but Dan Bernstein also reviewed and asked thoughtful questions.

<rdar://problem/7106968> and ​https://bugs.webkit.org/show_bug.cgi?id=27868
​http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit, works in others.

  • http/tests/misc/meta-refresh-stray-single-quote-expected.txt: Added.
  • http/tests/misc/meta-refresh-stray-single-quote.html: Added.
  • http/tests/misc/resources/success-notify-done.html: Added.
11:37 PM Changeset in webkit [46623] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-30 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

Fix compiler warning.

GCC does not like C++-style comments in preprocessor directives.

  • wtf/Platform.h:
11:15 PM Changeset in webkit [46622] by jmalonzo@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-07-30 Martin Robinson <​mrobinson@appcelerator.com>

Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo.

[GTK] new-window-policy-decision-requested provides no information about the target frame
​https://bugs.webkit.org/show_bug.cgi?id=27792

Add frameName property to the WebKitWebNavigation object.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::getNavigationAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_get_property): (webkit_web_navigation_action_set_property): (webkit_web_navigation_action_class_init): (webkit_web_navigation_action_get_target_frame): (webkit_web_navigation_action_set_target_frame):
  • webkit/webkitwebnavigationaction.h:
10:38 PM Changeset in webkit [46621] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

2009-07-30 John McCall <​rjmccall@apple.com>

Reviewed by Gavin Barraclough.

Optimize the X86_64 trampolines: avoid the need for filler arguments
and move the stub-args area closer to the stack pointer.

  • jit/JIT.h: adjust patch offsets because of slight code-size change
  • jit/JITCode.h: (JSC::JITCode::execute): don't pass filler args
  • jit/JITStubs.cpp: (ctiTrampoline): (X86_64): push args onto stack, use args directly (ctiVMThrowTrampoline): (X86_64): adjust %rsp by correct displacement (ctiOpThrowNotCaught): (X86_64): adjust %rsp by correct displacement
  • jit/JITStubs.h: (JITStackFrame): (X86_64): move args area earlier (ctiTrampoline): remove filler args from prototype
7:57 PM Changeset in webkit [46620] by barraclough@apple.com
  • 13 edits in trunk/JavaScriptCore

2009-07-30 Gavin Barraclough <​barraclough@apple.com>

Reviewed by NOBODY (build fix).

Temporarily revert r46618 since this is b0rking on Linux.

7:29 PM Changeset in webkit [46619] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Teach buildbot to detect test cases that are missing results.

Reviewed by Cameron Zwarich.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
7:20 PM Changeset in webkit [46618] by barraclough@apple.com
  • 13 edits in trunk/JavaScriptCore

2009-07-23 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification.
( ​https://bugs.webkit.org/show_bug.cgi?id=27635 )

This improves performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds by 2-2.5%, reducing the overhead to about 2.5%.
(No performance impact with ASSEMBLER_WX_EXCLUSIVE disabled).

  • bytecode/CodeBlock.cpp: (JSC::printStructureStubInfo):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
  • bytecode/CodeBlock.h: (JSC::): (JSC::CallLinkInfo::seenOnce): (JSC::CallLinkInfo::setSeen): (JSC::MethodCallLinkInfo::seenOnce): (JSC::MethodCallLinkInfo::setSeen):
    • Change a pointer in CallLinkInfo/MethodCallLinkInfo to use a PtrAndFlags, use a flag to track when an op has been executed once.
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::StructureStubInfo): (JSC::StructureStubInfo::initGetByIdSelf): (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::initGetByIdSelfList): (JSC::StructureStubInfo::initGetByIdProtoList): (JSC::StructureStubInfo::initPutByIdTransition): (JSC::StructureStubInfo::initPutByIdReplace): (JSC::StructureStubInfo::seenOnce): (JSC::StructureStubInfo::setSeen):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID, add a flag to track when an op has been executed once.
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitGetById): (JSC::BytecodeGenerator::emitPutById):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::unlinkCall):
    • Remove the "don't lazy link" stage of calls.
  • jit/JIT.h: (JSC::JIT::compileCTIMachineTrampolines):
    • Remove the "don't lazy link" stage of calls.
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase):
    • Remove the "don't lazy link" stage of calls.
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::JITStubs::DEFINE_STUB_FUNCTION): (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
    • Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
  • jit/JITStubs.h: (JSC::JITThunks::ctiStringLengthTrampoline): (JSC::JITStubs::):
    • Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
  • wtf/PtrAndFlags.h: (WTF::PtrAndFlags::PtrAndFlags): (WTF::PtrAndFlags::operator!): (WTF::PtrAndFlags::operator->):
    • Add ! and -> operators, add constuctor with pointer argument.
6:28 PM Changeset in webkit [46617] by mrowe@apple.com
  • 6 edits in trunk/WebCore

Bug 27828: Title attribute is not respected on option elements
Fix <​https://bugs.webkit.org/show_bug.cgi?id=27828> for Mac.

Reviewed by Adele Peterson and Jon Honeycutt.

No tests added as it is not clear how to test a tool tip from DumpRenderTree.

  • platform/PopupMenuClient.h: Add a method for retrieving the tool tip of an item.
  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenu::populate): Set the tool tip of the menu item to that of the represented item.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemToolTip): Expose the title attribute of the element as the tool tip.

  • rendering/RenderMenuList.h:
  • rendering/RenderTextControlSingleLine.h:

(WebCore::RenderTextControlSingleLine::itemToolTip): Return an empty string, indicating no tool tip, for
the popup menu in RenderTextControlSingleLine.

5:52 PM Changeset in webkit [46616] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Things work better when you create the correct directories.

  • Scripts/run-webkit-tests:
5:22 PM Changeset in webkit [46615] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Include some information about the error when we die.

  • Scripts/run-webkit-tests:
4:51 PM Changeset in webkit [46614] by treat@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-07-30 Adam Treat <​adam.treat@torchmobile.com>

Add expected results file for new test.

  • platform/gtk/fast/forms/button-style-color-expected.txt: Added.
4:41 PM Changeset in webkit [46613] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Ensure that the path exists before writing results to it.
Hopefully this will make the Windows build bot happy.

  • Scripts/run-webkit-tests:
4:32 PM Changeset in webkit [46612] by treat@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2009-07-30 Adam Treat <​adam.treat@torchmobile.com>

Add expected results file for new test.

  • platform/mac/fast/forms/button-style-color-expected.txt: Added.
4:21 PM Changeset in webkit [46611] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-30 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Remove ChromeClientChromium::setToolTip().
​https://bugs.webkit.org/show_bug.cgi?id=27861

This patch is just to remove a temporarily introduced overloaded empty
virtual function. No test is needed.

  • page/chromium/ChromeClientChromium.h:
4:11 PM Changeset in webkit [46610] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Gavin Barraclough.

Fixed failing tests seen on Windows buildbot.

  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jit/JITStubs.h: (JSC::): Use "int" instead of "bool" to guarantee a 32-bit result, regardless of compiler. gcc on mac uses 32-bit values for bool, but gcc on linux and MSVC on Windows use 8-bit values.
4:08 PM Changeset in webkit [46609] by darin@chromium.org
  • 25 edits
    2 adds in trunk

2009-07-30 Michael Nordman <Michael Nordman>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=27821

ApplicationCacheHost refactoring.


1) Better encapsulate the interfaces between webcore common code
and the appcache system within a new class ApplicationCacheHost.

2) Use that interface throughout the loader system, replacing inline appcache logic.

3) Implement the interface in terms of webcore's appcache system.

4) Add the new files to various makefiles.

5) Implement protocolHostAndPortAreEqual() in KURLGoogle.cpp

No new features, no new tests. The existing layout tests all pass.

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::insertedIntoDocument):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::setPrimaryLoadComplete):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::applicationCacheHost):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::load):
  • loader/MainResourceLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didFail):
  • loader/ResourceLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL): (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): (WebCore::ApplicationCacheGroup::failedLoadingMainResource): (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): (WebCore::ApplicationCacheGroup::update): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::manifestNotFound): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): (WebCore::ApplicationCacheGroup::startLoadingEntry): (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): (WebCore::CallCacheListenerTask::create): (WebCore::CallCacheListenerTask::performTask): (WebCore::CallCacheListenerTask::CallCacheListenerTask): (WebCore::ApplicationCacheGroup::postListenerTask):
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheHost.cpp: Added.
  • loader/appcache/ApplicationCacheHost.h: Added.
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::transferApplicationCache):
  • loader/appcache/ApplicationCacheStorage.h:
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::DOMApplicationCache): (WebCore::DOMApplicationCache::disconnectFrame): (WebCore::DOMApplicationCache::applicationCacheHost): (WebCore::DOMApplicationCache::status): (WebCore::DOMApplicationCache::update): (WebCore::DOMApplicationCache::swapCache): (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::dispatchEvent): (WebCore::DOMApplicationCache::callListener): (WebCore::DOMApplicationCache::toEventName): (WebCore::DOMApplicationCache::toEventType):
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::): (WebCore::DOMApplicationCache::setAttributeEventListener): (WebCore::DOMApplicationCache::getAttributeEventListener): (WebCore::DOMApplicationCache::clearAttributeEventListener): (WebCore::DOMApplicationCache::callEventListener): (WebCore::DOMApplicationCache::setOnchecking): (WebCore::DOMApplicationCache::onchecking): (WebCore::DOMApplicationCache::setOnerror): (WebCore::DOMApplicationCache::onerror): (WebCore::DOMApplicationCache::setOnnoupdate): (WebCore::DOMApplicationCache::onnoupdate): (WebCore::DOMApplicationCache::setOndownloading): (WebCore::DOMApplicationCache::ondownloading): (WebCore::DOMApplicationCache::setOnprogress): (WebCore::DOMApplicationCache::onprogress): (WebCore::DOMApplicationCache::setOnupdateready): (WebCore::DOMApplicationCache::onupdateready): (WebCore::DOMApplicationCache::setOncached): (WebCore::DOMApplicationCache::oncached): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete): (WebCore::DOMApplicationCache::~DOMApplicationCache):
  • platform/KURLGoogle.cpp: (WebCore::protocolHostAndPortAreEqual):
4:05 PM Changeset in webkit [46608] by treat@webkit.org
  • 4 edits in trunk/LayoutTests

2009-07-30 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Mark Rowe.

Revert previous commit to test out new functionality of buildbots and
run-webkit-tests made possible by r46607.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
3:54 PM Changeset in webkit [46607] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Teach run-webkit-tests to always store the actual results in the results directory for new tests.

Reviewed by Adam Treat and Jon Honeycutt.

This allows us to give a working link to the results from the result summary page, even if we're
not generating new results in to the tree.

  • Scripts/run-webkit-tests:
3:44 PM Changeset in webkit [46606] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-07-30 Simon Fraser <Simon Fraser>

Minor change to earlier commit suggested by Darin Adler.
Use the variable rather than dereferencing 'it' again.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation):
3:28 PM Changeset in webkit [46605] by treat@webkit.org
  • 4 edits in trunk/LayoutTests

2009-07-30 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by George Staikos.

Add new test with platform specific results to the Skipped files of ports
that haven't generated them yet. This is to make the buildbot green again.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
2:50 PM Changeset in webkit [46604] by Chris Fleizach
  • 3 edits in trunk/WebCore

Bug 27854 - crash at WebCore::AXObjectCache::notificationPostTimerFired
​https://bugs.webkit.org/show_bug.cgi?id=27854

2:47 PM Changeset in webkit [46603] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-07-30 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Animation with a timing function property in a keyframe eats CPU
​https://bugs.webkit.org/show_bug.cgi?id=27856
<rdar://problem/7104476> Animation demo uses lots of CPU

Don't include animation-timing-function in the list of properties to
animate in a keyframe animation, because this property is not animated;
instead, it describes the timing function to apply to this keyframe.

This prevents the animation code from thinking that there's a property
that it has to software-animate, and thus firing the animation timer frequently.

Not testable because there is no visible impact.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::keyframeStylesForAnimation): Don't add CSSPropertyWebkitAnimationTimingFunction to the list of properties to animate.
  • page/animation/KeyframeAnimation.cpp (WebCore::KeyframeAnimation::getKeyframeAnimationInterval): Add a comment
2:37 PM Changeset in webkit [46602] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Add a Qt Linux build bot.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
2:18 PM Changeset in webkit [46601] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-30 Geoffrey Garen <​ggaren@apple.com>

Windows build fix: added missing symbols on Windows.

2:16 PM Changeset in webkit [46600] by treat@webkit.org
  • 5 edits
    2 adds in trunk

WebCore:
2009-07-30 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Apply colour style to buttons that use Theme settings in Qt.

​https://bugs.webkit.org/show_bug.cgi?id=27814

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustButtonStyle):

LayoutTests:
2009-07-30 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add Button Colour style test and results for Qt based upon fix for bug.
Unskip tables/mozilla/bugs/bug92647-2.html which passes with bug fix.
Update expected results for qt for test fast/dom/HTMLTableColElement/resize-table-using-col-width-expected
which also passes with the the bug fix.

​https://bugs.webkit.org/show_bug.cgi?id=27814

  • fast/forms/button-style-color.html: Added.
  • platform/qt/Skipped:
  • platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/qt/fast/forms/button-style-color-expected.txt: Added.
2:05 PM Changeset in webkit [46599] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-07-30 Geoffrey Garen <​ggaren@apple.com>

Windows build fix: removed stale symbols on Windows.

1:57 PM Changeset in webkit [46598] by ggaren@apple.com
  • 63 edits
    3 adds in trunk

Merged nitro-extreme branch into trunk.

1:57 PM Changeset in webkit [46597] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-30 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Roben.

Add --minimal option to webkit-build.
​https://bugs.webkit.org/show_bug.cgi?id=27852

This option disables all optional build features unless
they are explicitly enabled.

  • Scripts/build-webkit:
12:31 PM Changeset in webkit [46596] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2009-07-30 Dean McNamee <​deanm@chromium.org>

Reviewed by Dimitri Glazkov.

Don't try to hash member function pointers, instead use a precomputed value based on the field.
​https://bugs.webkit.org/show_bug.cgi?id=27843

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/V8SVGPODTypeWrapper.h: (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo): (WebCore::PODTypeWrapperCacheInfo::operator==): (WebCore::PODTypeWrapperCacheInfoHash::hash): (WebCore::V8SVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
12:30 PM Changeset in webkit [46595] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-30 Xan Lopez <​xlopez@igalia.com>

Reviewed by Simon Fraser.

Fix compiler warning.

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
12:20 PM Changeset in webkit [46594] by mpcomplete@chromium.org
  • 7 edits in trunk/WebCore

2009-07-29 Matt Perry <​mpcomplete@chromium.org>

Reviewed by Adam Barth.

Add a way to register V8 extensions for Isolated Worlds only.
​https://bugs.webkit.org/show_bug.cgi?id=27785

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluateInNewWorld): (WebCore::ScriptController::evaluateInNewContext):
  • bindings/v8/ScriptController.h:
  • bindings/v8/V8IsolatedWorld.cpp: (WebCore::V8IsolatedWorld::evaluate):
  • bindings/v8/V8IsolatedWorld.h:
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::evaluateInNewWorld): (WebCore::V8Proxy::evaluateInNewContext): (WebCore::V8Proxy::createNewContext): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::registerExtensionWithV8): (WebCore::V8Proxy::registerExtension):
  • bindings/v8/V8Proxy.h:
12:07 PM Changeset in webkit [46593] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-07-30 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add previously defined out support to PopupMenuQt for marking entries as
disabled and for selecting the desired item.

​https://bugs.webkit.org/show_bug.cgi?id=27772

  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::populate):
11:44 AM Changeset in webkit [46592] by Darin Adler
  • 34 edits in trunk/WebCore

2009-07-30 Darin Adler <Darin Adler>

Reviewed by David Levin.

Use checked casts for render tree
​https://bugs.webkit.org/show_bug.cgi?id=23522

Next step: Add new toRenderWidget cast and use it everywhere.

Use checked casts in all the places that were using static_cast
but there is a checked cast available.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::widget): (WebCore::AccessibilityRenderObject::widgetForAttachmentView): (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getPangoLayoutForAtk):
  • dom/Document.cpp: (WebCore::widgetForNode): (WebCore::Document::setFocusedNode):
  • html/HTMLEmbedElement.cpp: (WebCore::findWidgetRenderer):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::defaultEventHandler):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::renderWidgetForJSBindings):
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadSubframe):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData):
  • page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::subframeForTargetNode): (WebCore::EventHandler::handleWheelEvent):
  • page/Frame.cpp: (WebCore::isFrameElement):
  • page/PrintContext.cpp: (WebCore::PrintContext::computePageRects):
  • page/android/EventHandlerAndroid.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/chromium/FrameChromium.cpp: (WebCore::computePageRectsForFrame):
  • page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/haiku/EventHandlerHaiku.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passSubframeEventToSubframe):
  • page/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
  • page/wx/EventHandlerWx.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • platform/chromium/ClipboardChromium.cpp: (WebCore::getCachedImage):
  • platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage):
  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage):
  • platform/qt/ClipboardQt.cpp: (WebCore::getCachedImage):
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage):
  • platform/win/ClipboardWin.cpp: (WebCore::getCachedImage):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
  • rendering/InlineBox.h: (WebCore::InlineBox::boxModelObject):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::addChildToContinuation):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateImageContents):
  • rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::positionForPoint): Use checked cast instead of static_cast.


  • rendering/RenderWidget.h: Added toRenderWidget.
11:25 AM Changeset in webkit [46591] by staikos@webkit.org
  • 6 edits in trunk/WebCore

2009-07-30 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: some files modified to build for WINCE
​https://bugs.webkit.org/show_bug.cgi?id=27816

11:08 AM Changeset in webkit [46590] by staikos@webkit.org
  • 13 edits in trunk/WebCore

2009-07-30 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: modified graphics files
​https://bugs.webkit.org/show_bug.cgi?id=27779

10:52 AM Changeset in webkit [46589] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-30 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Ariya Hidayat.

Improve efficiency by rewriting code doing three hash table
lookups, which can be replaced by just one as pointed out
by Darin Adler.

Though being slightly less clear, this should be considerable
faster.

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::remove):
10:50 AM Changeset in webkit [46588] by kov@webkit.org
  • 3 edits in trunk/WebCore

2009-07-30 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Gustavo Noronha.

[Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=27651

Removed unneeded includes (gdk.h and gtk.h) and added glib.h and cairo.h instead.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
10:38 AM Changeset in webkit [46587] by kov@webkit.org
  • 5 edits in trunk/WebCore

2009-07-30 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Gustavo Noronha.

[Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=27651

Fixed many code style issues pointed by WebKitTools/Scripts/modules/cpplint.py
No functionality change at all.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gtk/VideoSinkGStreamer.cpp:
  • platform/graphics/gtk/VideoSinkGStreamer.h:
9:43 AM Changeset in webkit [46586] by kenneth@webkit.org
  • 3 edits in trunk/WebCore

Allow to explicitly choose a preferred plugin for a mimetype.

​https://bugs.webkit.org/show_bug.cgi?id=27651

When the preferred plugin is set for a specific MIME type, it will be
always picked up, regardless of its version, quirks etc.

Client applications may want to use that API to resolve mimetype
ambiguity in a custom way, rather than in the default way that is
currently used in WebKit.

9:32 AM Changeset in webkit [46585] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

[Qt] Fix build with GCC 4.4.

9:31 AM Changeset in webkit [46584] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Fix build with Qt 4.4 after r46535.

9:31 AM Changeset in webkit [46583] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-30 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Adam Treat.

Add missing Q_OBJECT to class inheriting from QObject.

  • tests/qwebframe/tst_qwebframe.cpp:
9:31 AM Changeset in webkit [46582] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-30 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Adam Treat.

Fix indentation.

  • tests/qwebframe/tst_qwebframe.cpp:
9:05 AM Changeset in webkit [46581] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

2009-07-30 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Video elements fires another "load" event when attached to DOM
​https://bugs.webkit.org/show_bug.cgi?id=27623

Test: media/media-load-event.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::insertedIntoDocument):

Only schedule load when element's network state is NETWORK_EMPTY.

2009-07-30 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Video elements fires another "load" event when attached to DOM
​https://bugs.webkit.org/show_bug.cgi?id=27623

  • media/media-load-event-expected.txt: Added.
  • media/media-load-event.html: Added.
7:41 AM SpecSupport edited by tony@gonk.net
Added entries for XSLT 2.0 and XPath 2.0. Although each spec's v1.0 … (diff)
7:07 AM Changeset in webkit [46580] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-30 Anton Muhin <​antonm@chromium.org>

Reviewed by David Levin.

Cache v8 strings when converting from WebCore::String to v8 string.
​https://bugs.webkit.org/show_bug.cgi?id=27655

  • bindings/v8/V8Binding.cpp: (WebCore::v8String): now just immediately calls v8ExternalString (WebCore::enableStringImplCache): enables caching of conversions from WebCore::StringImpl to v8::String (WebCore::makeExternalString): utilty function to create external v8::String out of WebCore::String (WebCore::getStringCache): static function to access string cache (WebCore::cachedStringCallback): callback for weak handles of v8::Strings stored in the cache (WebCore::v8ExternalString): if caching enabled, checks if there is already v8::String for the given WebCore::StringImpl. If present, returns it, otherwise creates a new v8 external string.
  • bindings/v8/V8Binding.h:
6:11 AM Changeset in webkit [46579] by ariya@webkit.org
  • 4 edits in trunk/WebKitTools

2009-07-29 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=27813

[Qt] Support pixel tests in DumpRenderTree for the Qt port.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::setDumpPixels): (WebCore::DumpRenderTree::dump):
  • DumpRenderTree/qt/DumpRenderTree.h:
  • DumpRenderTree/qt/main.cpp: (main):
6:01 AM Changeset in webkit [46578] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-07-30 Volker Hilsheimer <​volker.hilsheimer@nokia.com>

Reviewed by Simon Hausmann.

Fix documentation links to examples.

  • Api/qwebview.cpp:
5:59 AM Changeset in webkit [46577] by ariya@webkit.org
  • 3 edits
    2 adds in trunk

ChangeLog:

2009-07-29 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

Adding ImageDiff project file.

​https://bugs.webkit.org/show_bug.cgi?id=27813

  • WebKit.pro: Added ImageDiff.pro.

WebKitTools/ChangeLog:

2009-07-29 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=27813

[Qt] Implement ImageDiff.

  • DumpRenderTree/qt/ImageDiff.cpp: Added.
  • DumpRenderTree/qt/ImageDiff.pro: Added.
5:48 AM Changeset in webkit [46576] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-07-30 Balazs Kelemen <​kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Allocate MainWindow on heap in robotized QtLauncher as well.

  • QtLauncher/main.cpp: (main):
4:24 AM Changeset in webkit [46575] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-30 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Eric Seidel.

build-webkit: Reorder logic for determining the baseProductDir

​https://bugs.webkit.org/show_bug.cgi?id=27699

We now do port-spesific probing for the product dir first, and then
fall back to either the generic WEBKITOUTPUTDIR (which now also works
on Mac), or WebKitBuild.

Then we add the git branch if the git branch build option is enabled.

Finally we massage the product dir based on the port. For example the
Mac port will now always set the SYMROOT and OBJROOT configuration for
XCode.

Note that isAppleWinWebkit() and isCygwin() is not mutually exclusive,
hence the normal if and not elsif in the last two blocks.

  • Scripts/webkitdirs.pm:
12:52 AM Changeset in webkit [46574] by xan@webkit.org
  • 3 edits in trunk/WebCore

2009-07-30 Xan Lopez <​xlopez@igalia.com>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=25535
[GTK] object:state-changed:checked events missing for radio buttons and checkboxes

Implement state-changed:checked for radio buttons and checkboxes.

  • accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::postPlatformNotification):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked):
12:13 AM Changeset in webkit [46573] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-30 Xan Lopez <​xlopez@igalia.com>

Forgot the 'break'.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
12:06 AM Changeset in webkit [46572] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-30 Xan Lopez <​xlopez@igalia.com>

Try to fix Mac build.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
12:00 AM Changeset in webkit [46571] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by Adam Barth.

Add missing enumeration value to switch.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):

Jul 29, 2009:

6:10 PM Changeset in webkit [46570] by jianli@chromium.org
  • 13 edits in trunk

WebCore:

2009-07-29 Jian Li <​jianli@chromium.org>

Reviewed by Darin Adler.

Workers need to throw an exception when presented with invalid URLs.
​https://bugs.webkit.org/show_bug.cgi?id=27770

Tests covered by worker-constructor.html and worker-redirect.html.

  • bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • workers/Worker.cpp: (WebCore::Worker::Worker):
  • workers/Worker.h: (WebCore::Worker::create):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::importScripts):
  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::WorkerScriptLoader::createResourceRequest):
  • workers/WorkerScriptLoader.h:

LayoutTests:

2009-07-29 Jian Li <​jianli@chromium.org>

Reviewed by Darin Adler.

Workers need to throw an exception when presented with invalid URLs.
​https://bugs.webkit.org/show_bug.cgi?id=27770

Update worker-constructor.html and worker-redirect.html per the behavior change.

  • fast/workers/worker-constructor-expected.txt:
  • fast/workers/worker-constructor.html:
  • http/tests/workers/worker-redirect-expected.txt:
  • http/tests/workers/worker-redirect.html:
5:33 PM Changeset in webkit [46569] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-07-29 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler.

(REGRESSION: r46039) Should restore previous connections-per-host limit for non-http(s) hosts
​https://bugs.webkit.org/show_bug.cgi?id=27822 and <rdar://problem/7091659>

  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests): For non-http(s) hosts, restore the previous behavior of only limiting connections while parsing and still trying to figure out stylesheet urls.
5:17 PM Changeset in webkit [46568] by staikos@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-07-29 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.


WINCE PORT: Add WebCore/page/wince/FrameWince.cpp
​https://bugs.webkit.org/show_bug.cgi?id=27729

5:13 PM Changeset in webkit [46567] by rniwa@webkit.org
  • 5 edits
    2 adds
    8 deletes in trunk

WebCore:

2009-07-29 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

REGRESSION(r46370-46426): /editing/style/remove-underline-from-stylesheet.html fails
​https://bugs.webkit.org/show_bug.cgi?id=27809

The patch primarily rebaselines the tests but also fixes the bug in currentlyHasStyle.
To determine that a particular text decoration is present, currentlyHasStyle should refer to
-webkit-text-decorations-in-effect to take care of styles set by u, s, strike tags and ancestors' CSS.
We also need to update layout to accommodate the changes made within ApplyStyleCommand.

  • editing/ApplyStyleCommand.cpp: ditto (WebCore::StyleChange::currentlyHasStyle): ditto

LayoutTests:

2009-07-29 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Justin Garcia.

REGRESSION(r46370-46426): /editing/style/remove-underline-from-stylesheet.html fails
​https://bugs.webkit.org/show_bug.cgi?id=27809

Since new behavior is consistent with Firefox, we rebaseline the test cases.
The patch converts remove-underline-from-stylesheet and remove-underline-in-bold to dumpAsText tests
with markup printed explicitly because pixel tests did not detect the disappearance of underline.

  • editing/style/remove-underline-from-stylesheet-expected.txt: Added.
  • editing/style/remove-underline-from-stylesheet.html:
  • editing/style/remove-underline-in-bold-expected.txt: Added.
  • editing/style/remove-underline-in-bold.html:
  • platform/mac/editing/style/remove-underline-from-stylesheet-expected.checksum: Removed.
  • platform/mac/editing/style/remove-underline-from-stylesheet-expected.png: Removed.
  • platform/mac/editing/style/remove-underline-from-stylesheet-expected.txt: Removed.
  • platform/mac/editing/style/remove-underline-in-bold-expected.checksum: Removed.
  • platform/mac/editing/style/remove-underline-in-bold-expected.png: Removed.
  • platform/mac/editing/style/remove-underline-in-bold-expected.txt: Removed.
  • platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Removed.
  • platform/qt/editing/style/remove-underline-in-bold-expected.txt: Removed.
5:08 PM Changeset in webkit [46566] by staikos@webkit.org
  • 4 edits in trunk/WebCore

2009-07-29 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.

WINCE PORT: changes to platform/text files
​https://bugs.webkit.org/show_bug.cgi?id=27715

5:08 PM Changeset in webkit [46565] by ddkilzer@apple.com
  • 4 edits in trunk/WebKit

<​http://webkit.org/b/27788> Don't export WebPluginController.h as a private header

Reviewed by Mark Rowe.

WebKit:

WebPluginController.h includes WebPluginContainerCheck.h, which
is not a private header. Since WebPluginController.h doesn't
appear to be used anywhere, remove its private header status.

  • WebKit.xcodeproj/project.pbxproj: Remove private header attribute from WebPluginController.h.

WebKit/mac:

  • Plugins/WebPluginController.h: Changed #import of WebPluginContainerCheck.h to use a framework-style include in case other platforms wish to export WebPluginController.h as a private header.
4:48 PM Changeset in webkit [46564] by staikos@webkit.org
  • 2 edits in trunk/WebCore

2009-07-29 Yong Li <​yong.li@torchmobile.com>

Reviewed by Adam Roben.

FIX: HDC leaks in PopupMenuWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=27817

4:48 PM Changeset in webkit [46563] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

<​http://webkit.org/b/27082> bugzilla-tool: Add --no-close switch to land-patches

Reviewed by David Levin.

  • Scripts/bugzilla-tool: (LandPatchesFromBugs.init): Added --no-close switch. (LandPatchesFromBugs.land_patches): Don't close the bug if the --no-close switch was used. Always clear the review+ flag on every landed patch using the commit_text message when cleared. This prevents patches from showing up in the commit queue if reopened and provides consistency with all landed patches.
  • Scripts/modules/bugzilla.py: (Bugzilla.clear_attachment_review_flag): Added.
4:42 PM Changeset in webkit [46562] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-07-29 Darin Adler <Darin Adler>

  • platform/gtk/Skipped: Added ol-start-parsing.html since it has no result yet.
4:29 PM Changeset in webkit [46561] by Darin Adler
  • 3 edits
    4 adds in trunk

2009-07-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Illegal values for <ol start> cause list numbering start at 0 (should start at 1)
​https://bugs.webkit.org/show_bug.cgi?id=27810

Test: fast/lists/ol-start-parsing.html

  • html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::parseMappedAttribute): Check the result of toInt and use the value 1 if it failed to parse. Before we were getting toInt's default behavior, which is to return 0.

2009-07-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Illegal values for <ol start> cause list numbering start at 0 (should start at 1)
​https://bugs.webkit.org/show_bug.cgi?id=27810

Couldn't make a text-only test because list numbers do not show up in
text dumps. This matches the other fast/lists tests.

  • fast/lists/ol-start-parsing.html: Added.
  • platform/mac/fast/lists/ol-start-parsing-expected.checksum: Added.
  • platform/mac/fast/lists/ol-start-parsing-expected.png: Added.
  • platform/mac/fast/lists/ol-start-parsing-expected.txt: Added.
3:49 PM Changeset in webkit [46560] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/win

Was doing the build fix wrong, NotImplemented.h is in WebCore.

3:32 PM Changeset in webkit [46559] by bweinstein@apple.com
  • 2 edits in trunk/WebKit/win

Windows build fix.

3:12 PM Changeset in webkit [46558] by kmccullough@apple.com
  • 21 edits
    1 add in trunk

WebCore:

2009-07-29 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin Adler.

Added foundation work to allow a testing infrastructure for the Web
Inspector.

  • inspector/InspectorClient.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::scriptObjectReady): Tell the testing harness that the window object is ready.
  • loader/EmptyClients.h: Empty class support for SVG. (WebCore::EmptyInspectorClient::inspectorWindowObjectCleared):

WebKit/gtk:

2009-07-29 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin Adler.

Added foundation work to allow a testing infrastructure for the Web
Inspector.


  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::inspectorWindowObjectCleared):
  • WebCoreSupport/InspectorClientGtk.h:

WebKit/mac:

2009-07-29 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin Adler.

Added foundation work to allow a testing infrastructure for the Web
Inspector.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::inspectorWindowObjectCleared): Send the delegate callback.
  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebView.mm: (-[WebView _cacheFrameLoadDelegateImplementations]):
  • WebView/WebViewPrivate.h: The delegate SPI.

WebKit/qt:

2009-07-29 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin Adler.

Added foundation work to allow a testing infrastructure for the Web
Inspector.

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::inspectorWindowObjectCleared):
  • WebCoreSupport/InspectorClientQt.h:

WebKit/win:

2009-07-29 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin Adler.

Added foundation work to allow a testing infrastructure for the Web
Inspector.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::inspectorWindowObjectCleared): Empty definition to let Windows compile but we should implement this at some point so that the tests can be run on Windows too.
  • WebCoreSupport/WebInspectorClient.h:
2:45 PM Changeset in webkit [46557] by Chris Fleizach
  • 2 edits in trunk/WebCore

Fix Windows build breakage.

2:44 PM Changeset in webkit [46556] by bweinstein@apple.com
  • 3 edits in trunk/LayoutTests

2009-07-29 Brian Weinstein <​bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Update getComputedStyle expected results on Windows to match updated Mac results.

  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
2:35 PM Changeset in webkit [46555] by Chris Fleizach
  • 6 edits in trunk/WebCore

Bug 27807 - AX: move re-usable code into more common areas for other platforms
​https://bugs.webkit.org/show_bug.cgi?id=27807

1:53 PM Changeset in webkit [46554] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/27815> bugzilla-tool: add -m/--description to post-commits command

Reviewed by Eric Seidel.

  • Scripts/bugzilla-tool: (PostDiffAsPatchToBug.execute): Changed default patch name from "patch" to "Patch v1". (PostCommitsAsPatchesToBug.init): Added -m/--description switch. (PostCommitsAsPatchesToBug.execute): Use description provided by -m/--description switch first, else fall back to the commit message.
1:35 PM Changeset in webkit [46553] by mitz@apple.com
  • 9 edits in trunk/WebCore

Reviewed by Simon Fraser.

Inset box shadows are incorrectly accounted for in visual overflow
computations
​https://bugs.webkit.org/show_bug.cgi?id=27811

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Use

getBoxShadowHorizontalExtent().

(WebCore::InlineFlowBox::placeBoxesVertically): Use

getBoxShadowVerticalExtent(). Removed duplicate code to get the
text-shadow overflow.

(WebCore::InlineFlowBox::paint): Use getBoxShadowHorizontalExtent().

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): Use

getBoxShadowVerticalExtent().

(WebCore::RenderBlock::overflowWidth): Use

getBoxShadowHorizontalExtent().

(WebCore::RenderBlock::overflowLeft): Ditto.
(WebCore::RenderBlock::overflowTop): Use getBoxShadowVerticalExtent().
(WebCore::RenderBlock::overflowRect): Use getBoxShadowExtent().
(WebCore::RenderBlock::layoutBlock): Ditto.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Exclude inset shadows.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Use

getBoxShadowHorizontalExtent() and getBoxShadowVerticalExtent().

(WebCore::RenderObject::adjustRectForOutlineAndShadow): Exclude inset

shadows.

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Ditto.
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setTextShadow): Also assert that text-shadows are

not inset.

(WebCore::RenderStyle::getBoxShadowExtent): Added. Excludes inset

shadows.

(WebCore::RenderStyle::getBoxShadowHorizontalExtent): Ditto.
(WebCore::RenderStyle::getBoxShadowVerticalExtent): Ditto.

  • rendering/style/RenderStyle.h:
1:26 PM Changeset in webkit [46552] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-29 Brady Eidson <​beidson@apple.com>

Rubber-stamped by Mark Rowe

  • platform/gtk/Skipped: Disable the new test on GTK, as they don't dump resource load callbacks in their DumpRenderTree.
1:13 PM Changeset in webkit [46551] by beidson@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2009-07-29 Brady Eidson <​beidson@apple.com>

Rubber-stamped by Jon Honeycutt

Check in Tiger-specific results for the new test, as it is known they send willCacheResponse
callbacks in a different order.

  • platform/mac-tiger/http/tests/loading: Added.
  • platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt: Added.
1:07 PM Changeset in webkit [46550] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-29 Brady Eidson <​beidson@apple.com>

Adding my new test to the Windows skipped list until I can figure out what's going on.

  • platform/win/Skipped:
12:48 PM Changeset in webkit [46549] by Simon Fraser
  • 4 edits
    2 adds in trunk

2009-07-29 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fix crash when an element with display: table-row is composited (e.g. via a 3d-transform)
​https://bugs.webkit.org/show_bug.cgi?id=27796

Avoid repainting when a layer becomes composited if the renderer is not parented
yet, because it makes no sense to do so.

If the table row is a repaint container, default to the RenderBox implementation
of clippedOverflowRectForRepaint(), because we cannot hand off the repaint rect
computation to something that is above the repaint container.

Test: fast/table/table-row-compositing-repaint-crash.html

  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::repaintOnCompositingChange):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::clippedOverflowRectForRepaint):
11:22 AM Changeset in webkit [46548] by beidson@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

2009-07-29 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=27791
307 redirects of POSTs should use POST, not GET

Test: http/tests/loading/redirect-methods.html

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):

LayoutTests:

2009-07-29 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=27791
307 redirects of POSTs should use POST, not GET

  • http/tests/loading/redirect-methods-expected.txt: Added.
  • http/tests/loading/redirect-methods.html: Added.
  • http/tests/loading/resources/redirect-methods-form.html: Added.
  • http/tests/loading/resources/redirect-methods-result.php: Added.
11:03 AM Changeset in webkit [46547] by cmarrin@apple.com
  • 14 edits
    2 adds in trunk

Adding -webkit-animation-play-state back in
​https://bugs.webkit.org/show_bug.cgi?id=26867

We've decided to keep -webkit-animation-play-state. So this
just adds back in the code from ​https://bugs.webkit.org/show_bug.cgi?id=22907.

10:02 AM Changeset in webkit [46546] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-29 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

Expose the default plugin directories and the current directory set of
the plugin database as public API.

​https://bugs.webkit.org/show_bug.cgi?id=27651

  • plugins/PluginDatabase.h: (WebCore::PluginDatabase::pluginDirectories):
9:30 AM Changeset in webkit [46545] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-29 Alpha Lam <​hclam@chromium.org>

Reviewed by David Levin.

[chromium] Font size for current time display in media controls panel
is affected by body font size.
​https://bugs.webkit.org/show_bug.cgi?id=27799

Fixing the problem of rendering by explicitly setting the font size
for the time displays.

No new tests since this is covered by existing media tests.

  • css/mediaControlsChromium.css:
9:30 AM Changeset in webkit [46544] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-29 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by David Levin.

Update WebCore/page/ContextMenuController.cpp to conform to WebKit
Style Guidelines as identified by cpp_style.py.
​https://bugs.webkit.org/show_bug.cgi?id=27613

  • page/ContextMenuController.cpp: (WebCore::openNewWindow): (WebCore::ContextMenuController::contextMenuItemSelected):
9:17 AM Changeset in webkit [46543] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-07-29 Dean McNamee <​deanm@chromium.org>

Reviewed by Dimitri Glazkov.

Removed unused wrapCPointer/extractCPointer from the v8 bindings.
​https://bugs.webkit.org/show_bug.cgi?id=27805

  • bindings/v8/V8DOMWrapper.h:
8:13 AM Changeset in webkit [46542] by kenneth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-29 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Dave Levin.

Make check-webkit-style support files as arguments.
​https://bugs.webkit.org/show_bug.cgi?id=27549

  • Scripts/check-webkit-style: Support files as argument. Change documentation and use basename on the binary name when used in the documentation. Also do not die when printing something containing non-ASCII characters.
7:54 AM Changeset in webkit [46541] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-29 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Simon Hausmann.

Expose the PluginDatabase::pluginForMIMEType() function as public API.
​https://bugs.webkit.org/show_bug.cgi?id=27651

It can be used to determine the appropriate plugin for a mime type,
without guessing the mimetype from the extension.

  • plugins/PluginDatabase.h:
7:36 AM Changeset in webkit [46540] by kenneth@webkit.org
  • 4 edits in trunk/WebCore

2009-07-29 Jakub Wieczorek <​faw217@gmail.com>

Reviewed by Adam Treat.

Allow to enable/disable particular plugin packages.
​https://bugs.webkit.org/show_bug.cgi?id=27651

Disabled plugins will not be picked up when looking for a plugin
supporting the requested mimetypes.

Client applications may want to use that API to disable specific
plugins.

  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::pluginForMIMEType): (WebCore::PluginDatabase::MIMETypeForExtension):
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::PluginPackage): (WebCore::PluginPackage::setEnabled):
  • plugins/PluginPackage.h: (WebCore::PluginPackage::isEnabled):
6:18 AM Changeset in webkit [46539] by Nikolas Zimmermann
  • 12 edits in trunk

2009-07-29 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by Adam Treat.

[WML] Running WML tests in random order multiple times exposes subtle bugs
​https://bugs.webkit.org/show_bug.cgi?id=27801

Some changes to fix random order WML tests, simplilfy WMLTestCase.js and reset testDocument
properly in enter-first-card-with-events.js. fast/wml/err-multi-access.wml still creates a layout
test difference on consecutive runs, though that's related to bug 27721, which has to be fixed first.

  • wml/resources/WMLTestCase.js:
  • wml/resources/enter-first-card-with-events.js: (setupTestDocument): (prepareTest): (executeTest):

2009-07-29 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by Adam Treat.

[WML] Running WML tests in random order multiple times exposes subtle bugs
​https://bugs.webkit.org/show_bug.cgi?id=27801

Remove superflous assertions regarding the parent node. Under certain circumstances
these can even fire (related to garbage collection while destructing). Fixes random order
WML tests (run-webkit-tests fast/wml wml http/tests/wml fast/wml ... --random)

The wml/enter-first-card-with-events.html test relied on a bug in our implementation of
WMLPageState::reset() - the history stack should still contain the current card afterwards.
Fix that bug by preserving the first item in BackForwardList::clearWMLPageHistory().

  • history/BackForwardList.cpp: Preserve first item in history stack, as demanded by the spec. (WebCore::BackForwardList::clearWMLPageHistory):
  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::insertedIntoDocument): (WebCore::WMLDoElement::removedFromDocument):
  • wml/WMLNoopElement.cpp: (WebCore::WMLNoopElement::insertedIntoDocument):
  • wml/WMLOnEventElement.cpp: (WebCore::eventHandlingParent):
  • wml/WMLPostfieldElement.cpp: (WebCore::WMLPostfieldElement::insertedIntoDocument): (WebCore::WMLPostfieldElement::removedFromDocument):
  • wml/WMLSetvarElement.cpp: (WebCore::WMLSetvarElement::insertedIntoDocument): (WebCore::WMLSetvarElement::removedFromDocument):
  • wml/WMLTaskElement.cpp: (WebCore::WMLTaskElement::insertedIntoDocument): (WebCore::WMLTaskElement::removedFromDocument):
  • wml/WMLTimerElement.cpp: (WebCore::WMLTimerElement::insertedIntoDocument): (WebCore::WMLTimerElement::removedFromDocument):
4:35 AM Changeset in webkit [46538] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

<​http://webkit.org/b/27119> bugzilla-tool: Add create-bug command

Reviewed by David Levin.

Implement "create-bug" command for bugzilla-tool.

  • Scripts/bugzilla-tool: Added CreateBug class. (CreateBug.init): Added. (CreateBug.create_bug_from_commit): Added. (CreateBug.create_bug_from_patch): Added. (CreateBug.prompt_for_bug_title_and_comment): Added. (CreateBug.execute): Added. (BugzillaTool.init): Added create-bug command.
  • Scripts/modules/bugzilla.py: (Bugzilla.prompt_for_component): Added. (Bugzilla.check_create_bug_response_returning_bug_id_on_success): Added. (Bugzilla.create_bug_with_patch): Added.
4:18 AM Changeset in webkit [46537] by jmalonzo@webkit.org
  • 12 edits
    1 add in trunk

2009-07-29 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Eric Seidel and Xan Lopez.

[Gtk] Enable http/tests/appcache tests
​https://bugs.webkit.org/show_bug.cgi?id=27674

  • GNUmakefile.am: Add webkit/webkitapplicationcache.cpp

Enable passing http/tests/appcache tests.

  • platform/gtk/Skipped:

Add 'enable-offline-web-application-cache' WebSetting to enable
or disable the appcache. Also, Add appcache SPI for DRT to use.

  • webkit/webkitapplicationcache.cpp: Added. (webkit_application_cache_set_maximum_size):
  • webkit/webkitprivate.cpp: (webkit_init):
  • webkit/webkitprivate.h:
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
  • webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):

Add support for testing http/tests/appcache tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAppCacheMaximumSize):
3:50 AM Changeset in webkit [46536] by Simon Hausmann
  • 3 edits in trunk/LayoutTests

2009-07-29 Simon Hausmann <​simon.hausmann@nokia.com>

Update Qt-specific results for computed-style tests, like in r46512.

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
3:33 AM Changeset in webkit [46535] by Simon Hausmann
  • 8 edits in trunk/WebCore

2009-07-29 Yongjun Zhang <​yongjun.zhang@nokia.com>

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=26848
[Qt] ResourceHandle::willLoadFromCache needs to be implemented QtWebKit.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::willLoadFromCache):
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::willLoadFromCache):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willLoadFromCache):
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::willLoadFromCache):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::):
2:53 AM Changeset in webkit [46534] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-29 Alpha Lam <​hclam@chromium.org>

Reviewed by David Levin.

Media control panel for <video> in MediaDocument is mis-placed
​https://bugs.webkit.org/show_bug.cgi?id=27798

Fixing a rendering problem: When <video> is displayed in MediaDocument,
the media control panel overlaps with the video by 16 pixels.

No new tests as this is covered by existing media tests.

  • css/mediaControlsChromium.css:
2:48 AM Changeset in webkit [46533] by vestbo@webkit.org
  • 1 edit in trunk/WebKitTools/Scripts/webkitdirs.pm

Revert r46532 (build-webkit: Reorder logic for determining the baseProductDir)

Broke the Windows build.

2:37 AM Changeset in webkit [46532] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-29 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Eric Seidel.

build-webkit: Reorder logic for determining the baseProductDir

​https://bugs.webkit.org/show_bug.cgi?id=27699

We now do port-spesific probing for the product dir first, and then
fall back to either the generic WEBKITOUTPUTDIR (which now also works
on Mac), or WebKitBuild.

Then we add the git branch if the git branch build option is enabled.

Finally we massage the product dir based on the port. For example the
Mac port will now always set the SYMROOT and OBJROOT configuration for
XCode.

  • Scripts/webkitdirs.pm:
1:36 AM Changeset in webkit [46531] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-29 Adam Barth <​abarth@webkit.org>

Unreviewed build fix for Chromium. Those last two patches weren't
independent despite the clean merge.

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener):
1:34 AM Changeset in webkit [46530] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-07-29 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] In debug mode, this fix frees cached resources
and other unreferenced objects (by calling the
garbage collector) to remove the LEAK messages.
​https://bugs.webkit.org/show_bug.cgi?id=27767

  • Api/qwebframe.cpp: (qt_drt_cache_clear):
  • QtLauncher/main.cpp: (main):
1:11 AM Changeset in webkit [46529] by abarth@webkit.org
  • 9 edits
    3 adds in trunk

2009-07-29 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Adler.

ImageSourceCG makes bad data refs (race condition causes blank images)
​https://bugs.webkit.org/show_bug.cgi?id=27777

Make ImageSourceCG guarantee that the lifetime of the SharedBuffer that
backs the CFDataRef will be long enough.

No new tests, as this fixes a bug with a race condition that is
difficult to trigger.

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):

2009-07-29 Kent Tamura <​tkent@chromium.org>

Reviewed by Nikolas Zimmermann.

Fix a bug that HTMLOptionElement::value() returns an incorrect
value in a case that the element has a label attribute and no
value attribute.
​https://bugs.webkit.org/show_bug.cgi?id=27760

  • fast/forms/option-value-and-label-expected.txt: Added.
  • fast/forms/option-value-and-label.html: Added.
1:04 AM Changeset in webkit [46528] by levin@chromium.org
  • 15 edits in trunk/JavaScriptCore

2009-07-29 Laszlo Gombos <Laszlo Gombos>

Reviewed by George Staikos.

Resolve class/struct mixup in forward declarations
​https://bugs.webkit.org/show_bug.cgi?id=27708

  • API/JSClassRef.h:
  • bytecode/SamplingTool.h:
  • interpreter/Interpreter.h:
  • jit/JIT.h:
  • profiler/ProfileGenerator.h:
  • profiler/Profiler.h:
  • runtime/ClassInfo.h:
  • runtime/ExceptionHelpers.h:
  • runtime/JSByteArray.h:
  • runtime/JSCell.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.h:
  • runtime/JSObject.h:
  • runtime/JSString.h:
1:04 AM Changeset in webkit [46527] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-29 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Adler.

ImageSourceCG makes bad data refs (race condition causes blank images)
​https://bugs.webkit.org/show_bug.cgi?id=27777

Make ImageSourceCG guarantee that the lifetime of the SharedBuffer that
backs the CFDataRef will be long enough.

No new tests, as this fixes a bug with a race condition that is
difficult to trigger.

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData):
1:04 AM Changeset in webkit [46526] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-07-29 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Console should show completions for the command line APIs
​https://bugs.webkit.org/show_bug.cgi?id=27696

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._reportCompletions): Adds properties from _inspectorCommandLineAPI to completions when available.
  • inspector/front-end/utilities.js: (Object.properties): Added. (Object.sortedProperties):
1:03 AM Changeset in webkit [46525] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-07-29 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

Refactor the first step of layout in RenderFlexibleBox.cpp
​https://bugs.webkit.org/show_bug.cgi?id=27704

No new tests as this change is just a refactoring.

  • rendering/RenderFlexibleBox.cpp: (WebCore::gatherFlexChildrenInfo): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
1:03 AM Changeset in webkit [46524] by levin@chromium.org
  • 6 edits
    2 adds in trunk

2009-07-29 Kent Tamura <​tkent@chromium.org>

Reviewed by Nikolas Zimmermann.

Fix a bug that HTMLOptionElement::value() returns an incorrect
value in a case that the element has a label attribute and no
value attribute.
​https://bugs.webkit.org/show_bug.cgi?id=27760

WebCore:

Test: fast/forms/option-value-and-label.html

  • dom/OptionElement.cpp: (WebCore::OptionElement::collectOptionLabelOrText): (WebCore::OptionElement::collectOptionInnerText): (WebCore::OptionElement::normalizeText): (WebCore::OptionElement::collectOptionTextRespectingGroupLabel): (WebCore::OptionElement::collectOptionValue):
  • dom/OptionElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::text):
  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::text):

LayoutTests:

  • fast/forms/option-value-and-label-expected.txt: Added.
  • fast/forms/option-value-and-label.html: Added.
12:59 AM Changeset in webkit [46523] by abarth@webkit.org
  • 15 edits
    2 adds in trunk

2009-07-29 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach V8Proxy::context about isolated worlds
​https://bugs.webkit.org/show_bug.cgi?id=27701

Change V8Proxy::context(Frame*) to understand isolated worlds. Audit
all callers of this method to make sure they want isolated worlds. In
cases where we really want the main world, I've changed the call to
V8Proxy::mainWorldContext(Frame*).


The main visible change is to the document.open method when called with
more than two arguments. This design seems more likely to lead to
future correct code.

Test: http/tests/security/isolatedWorld/document-open.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::ScriptController::evaluate): (WebCore::ScriptController::bindToWindowObject): (WebCore::ScriptController::collectGarbage): (WebCore::createScriptObject): (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructor): (WebCore::V8DOMWrapper::setHiddenWindowReference): (WebCore::V8DOMWrapper::convertNodeToV8Object): (WebCore::V8DOMWrapper::convertWindowToV8Object):
  • bindings/v8/V8Helpers.cpp: (WebCore::toV8Context):
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getListenerFunction): (WebCore::V8LazyEventListener::getWrappedListenerFunction):
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::context): (WebCore::V8Proxy::mainWorldContext): (WebCore::V8Proxy::bindJsObjectToWindow):
  • bindings/v8/V8Proxy.h:

2009-07-29 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

[V8] Teach V8Proxy::context about isolated worlds
​https://bugs.webkit.org/show_bug.cgi?id=27701

Test that calling document.open with more than two arguments calls the
window.open method from the correct world.

  • http/tests/security/isolatedWorld/document-open-expected.txt: Added.
  • http/tests/security/isolatedWorld/document-open.html: Added.
12:25 AM Changeset in webkit [46522] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-07-29 Balazs Kelemen <​kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Fix the Qt build, add missing file.

  • WebCore.pro:
12:13 AM Changeset in webkit [46521] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-28 Jon Honeycutt <​jhoneycutt@apple.com>

Speculative fix for <rdar://problem/7005077> WER: Crash in
WebCore::PluginStream::destroyStream+279 (1310510882)

Reviewed by Oliver Hunt.

  • plugins/PluginStream.cpp: (WebCore::PluginStream::destroyStream): Move the "protector" RefPtr out of the block that dispatches notifications and into the function level; if NPN_DestroyStream were called from NPP_NewStream as the comment warns, we would be deleted at the end of the block.
Note: See TracTimeline for information about the timeline view.