⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 1, 2009:

11:05 PM Changeset in webkit [46688] by mitz@apple.com
  • 3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

Make pixel test results more consistent across Mac OS X versions

  • DumpRenderTree/cg/ImageDiffCG.cpp: (createDifferenceImage): Avoid color correction when rendering the

images into graphics contexts, so that the actual color values are
compared, regardless of how the images are tagged.

  • DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Set the window’s color space to the

main screen’s color space, even though the window is off-screen.

10:18 PM Changeset in webkit [46687] by abarth@webkit.org
  • 18 edits
    4 adds in trunk/WebCore

2009-08-01 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Reimplement Elements Panel so that its
interaction with DOM is serialized.

This is a first cut wuth read support for DOM elements
tree as well as some limited editing. No properties, no
styles, no search capabilities are implemented yet.
Set Preferences.useDOMAgent to true in order to try it
out, otherwise disabled by default.

​https://bugs.webkit.org/show_bug.cgi?id=27771

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getChildNodes): (WebCore::InspectorBackend::setAttribute): (WebCore::InspectorBackend::removeAttribute): (WebCore::InspectorBackend::setTextNodeValue):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorController.h: (WebCore::InspectorController::domAgent):
  • inspector/InspectorDOMAgent.cpp: Added.
  • inspector/InspectorDOMAgent.h: Added.
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/Callback.js: Added.
  • inspector/front-end/DOMAgent.js: Added.
  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded):
7:31 PM Changeset in webkit [46686] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Try again to make the Qt build bot happy.

  • BuildSlaveSupport/test-result-archive: Create a placeholder file inside the newly-created

directory to prevent 'zip' from failing due to the directory containing no files.

7:18 PM Changeset in webkit [46685] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Try and make the Qt build bot happy.

  • BuildSlaveSupport/test-result-archive: Handle the case where run-webkit-tests generates

no output files at all and thus does not create the layout-test-results directory.

6:59 PM Changeset in webkit [46684] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Move the include of DumpRenderTreeSupport to after DumpRenderTree has been built.

  • Scripts/run-webkit-tests:
6:41 PM Changeset in webkit [46683] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

wtf/Threading.h: added include of Platform.h

Reviewed by Mark Rowe.

  • wtf/Threading.h: Added #include "Platform.h" since this header uses PLATFORM() and other macros.
6:40 PM Changeset in webkit [46682] by mrowe@apple.com
  • 3 edits
    3 adds in trunk/WebKitTools

Bug 27923: run-webkit-tests should not invoke "ps" repeatedly on Mac OS X
Fix <​https://bugs.webkit.org/show_bug.cgi?id=27923>.

Reviewed by Sam Weinig and David D. Kilzer.

run-webkit-tests invokes "ps" after each test on Mac OS X to determine whether DumpRenderTree is
in the process of crashing. We can do the same test more efficiently with a simple call to sysctl.
I couldn't find any built-in way of doing this directly from perl, so we do it from a simple C module
instead. This speeds up run-webkit-tests by around 8%.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Added.

(processIsCrashing):

  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm: Added. Tiger does not have the SWIG tool

that is used to generate the Perl binding to the C code, so we fall back to the old implementation on Tiger.

  • DumpRenderTree/mac/PerlSupport/Makefile: Added.
  • Scripts/run-webkit-tests:
6:04 PM Changeset in webkit [46681] by rniwa@webkit.org
  • 6 edits in trunk/WebCore

2009-08-01 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Adele Peterson.

isContentEditable function in htmlediting.* must be removed
​https://bugs.webkit.org/show_bug.cgi?id=27870

This patch removes isContentEditable function in htmlediting.cpp and
replaces all usage by calling Node::isContentEditable or its derivatives.

  • editing/AppendNodeCommand.cpp: ditto (WebCore::AppendNodeCommand::AppendNodeCommand): ditto
  • editing/IndentOutdentCommand.cpp: ditto (WebCore::IndentOutdentCommand::outdentParagraph): ditto
  • editing/InsertNodeBeforeCommand.cpp: ditto (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): ditto
  • editing/htmlediting.cpp: ditto (WebCore::enclosingNodeWithTag): ditto (WebCore::enclosingNodeOfType): ditto (WebCore::canMergeLists): ditto
  • editing/htmlediting.h: Updated prototype
5:24 PM Changeset in webkit [46680] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Display the reminder once rather than once per ChangeLog.

Reviewed by David D. Kilzer.

  • Scripts/prepare-ChangeLog:
4:00 PM Changeset in webkit [46679] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Roll out r46668 as it was misinformed. ScopeChain is only used with placement new.

Rubber-stamped by Oliver Hunt.

  • runtime/ScopeChain.h:
3:52 PM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
3:49 PM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
3:48 PM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
3:48 PM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
3:22 PM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
3:08 PM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
3:01 PM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
2:57 PM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
2:57 PM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
2:55 PM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
1:13 PM Changeset in webkit [46678] by mrowe@apple.com
  • 3 edits
    2 deletes in trunk/WebKitTools

Roll out r46676. Tiger is why we can't have nice things :-(

1:09 PM Changeset in webkit [46677] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-01 Brian Weinstein <​bweinstein@apple.com>

Rubber-stamped by Mark Rowe.

Remove a non-existent test from the Windows Skipped List.

  • platform/win/Skipped:
1:05 PM Changeset in webkit [46676] by mrowe@apple.com
  • 3 edits
    3 adds in trunk/WebKitTools

Bug 27923: run-webkit-tests should not invoke "ps" repeatedly on Mac OS X
Fix <​https://bugs.webkit.org/show_bug.cgi?id=27923>.

Reviewed by Sam Weinig.

run-webkit-tests invokes "ps" after each test on Mac OS X to determine whether DumpRenderTree is
in the process of crashing. We can do the same test more efficiently with a simple call to sysctl.
I couldn't find any built-in way of doing this directly from perl, so we do it from a simple C module
instead. This speeds up run-webkit-tests by around 8%.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Added.

(processIsCrashing):

  • DumpRenderTree/mac/PerlSupport/Makefile: Added.
  • Scripts/run-webkit-tests:
11:35 AM Changeset in webkit [46675] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-01 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Allow custom memory allocation control for JavaScriptCore's HashMap class
​http://bugs.webkit.org/show_bug.cgi?id=27871

Inherits HashMap class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/API/JSClassRef.cpp:148.

  • wtf/RefPtrHashMap.h: (WTF::):
11:17 AM Changeset in webkit [46674] by beidson@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

2009-08-01 Brady Eidson <​beidson@apple.com>

For my new test I landed last night, check in Tiger-specific results, and skip on Windows.

  • platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
  • platform/win/Skipped: Add to the skipped list because the failure needs exploration.
10:58 AM Changeset in webkit [46673] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-01 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Eric Seidel.

Update test to work with multi-process message ports.

​https://bugs.webkit.org/show_bug.cgi?id=27819

  • fast/events/message-channel-gc.html:
7:29 AM Changeset in webkit [46672] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

resolve-ChangeLogs: add error checking to git ls-files command on close()

Reviewed by Eric Seidel.

Item 2 of <​https://bugs.webkit.org/show_bug.cgi?id=18599#c0>.

  • Scripts/resolve-ChangeLogs: Added error checking to close() after running git ls-files. Added error checking to all system() calls by checking for a non-zero WEXITSTATUS($?).
Changed "
die;" expressions to "or die $!;".
7:29 AM Changeset in webkit [46671] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

Reviewed by Eric Seidel.

  • Scripts/resolve-ChangeLogs: Used chdirReturningRelativePath() and determineVCSRoot() to change directories to the root of the project before running the command and to provide a path for removeChangeLogArguments() to make sure any ChangeLog arguments on the command line are still found. (canonicalRelativePath): Added. Returns a canonical path (e.g., stripping 'dir/../' from the path) relative to the current directory. (removeChangeLogArguments): Added argument which contains a relative path that must be prepended to any ChangeLog arguments. Used canonicalRelativePath() and File::Spec->catfile() to construct a normalized, relative path to each file.
7:29 AM Changeset in webkit [46670] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

Implement VCSUtils::chdirReturningRelativePath()

Reviewed by Eric Seidel.

Step 2 to fix:
<​http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

  • Scripts/VCSUtils.pm: (VCSUtils::chdirReturningRelativePath): Moved here from chdirAndGetDifference() in svn-create-patch.
  • Scripts/svn-create-patch: Switched to use chdirReturningRelativePath() instead of chdirAndGetDifference(). (chdirAndGetDifference): Removed.
7:23 AM Changeset in webkit [46669] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

Implement VCSUtils::determineVCSRoot()

Reviewed by Eric Seidel.

Step 1 to fix:
<​http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

  • Scripts/VCSUtils.pm: Removed reference to webkitdirs module. (VCSUtils::EXPORT): Added &determineVCSRoot. Realphabetized. (VCSUtils::determineGitRoot): Added. Based on code in commit-log-editor. (VCSUtils::determineVCSRoot): Implemented using determineGitRoot() and determineSVNRoot().
  • Scripts/commit-log-editor: Replaced use of topLevelSourceDirectory() with determineVCSRoot(). Resorted use statements. (topLevelSourceDirectory): Removed.
1:19 AM Changeset in webkit [46668] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-01 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Allow custom memory allocation control for JavaScriptCore's ScopeChain class
​https://bugs.webkit.org/show_bug.cgi?id=27834

Inherits ScopeChain class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSFunction.h:109.

  • runtime/ScopeChain.h:
12:51 AM Changeset in webkit [46667] by abarth@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-01 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's RegExpConstructorPrivate struct
​https://bugs.webkit.org/show_bug.cgi?id=27833

Inherits RegExpConstructorPrivate class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/RegExpConstructor.cpp:152.

  • runtime/RegExpConstructor.cpp:
12:37 AM Changeset in webkit [46666] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-08-01 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Adam Barth.

Fix a message port handle always getting marked as reachable once it gets entangled.

​https://bugs.webkit.org/show_bug.cgi?id=27824

No tests since this only arises with the Chromium multi-process message port implementation
which isn't in this repostiory.

  • bindings/v8/V8GCController.cpp: (WebCore::GCEpilogueVisitor::visitDOMWrapper):
12:23 AM Changeset in webkit [46665] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-08-01 Evan Martin <​evan@chromium.org>

Reviewed by Adam Barth.

Add a regression test for a crash when a page has smart quotes in a
mime type.

  • fast/parser/smart-quotes-in-tag-expected.txt: Added.
  • fast/parser/smart-quotes-in-tag.html: Added.

Jul 31, 2009:

11:56 PM Changeset in webkit [46664] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-31 Daniel Bates <​dbates@intudata.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=27757

Resolves Perl redefinition warnings about functions tmpfile and tmpnam which are
defined in both File::Temp and POSIX.

This stops the warnings by preventing the "import" method of File::Temp from being called,
which would otherwise add these functions into the primary namespace. Note, "use POSIX"
will import these functions into the primary namespace anyway. We only need one instance
of these functions in our namespace (or we get redefinition warnings), so lets use the
one's in the POSIX package.

  • Scripts/update-webkit-auxiliary-libs: Changed "use File::Temp" to "use File::Temp ()".
  • Scripts/update-webkit-support-libs: ditto
11:43 PM Changeset in webkit [46663] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Yong Li <​yong.li@torchmobile.com>

Reviewed by Adam Barth.

Fix Geolocation permission problem
​https://bugs.webkit.org/show_bug.cgi?id=26993

  • page/Geolocation.cpp: (WebCore::Geolocation::requestPermission):
11:29 PM Changeset in webkit [46662] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-31 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Add a top level build option to control datagrid support
​https://bugs.webkit.org/show_bug.cgi?id=27915

  • Scripts/build-webkit:
11:09 PM Changeset in webkit [46661] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Eric Seidel.

Added project properties as needed by symbian platform

  • WebCore.pro:
10:26 PM Changeset in webkit [46660] by abarth@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-07-31 Yong Li <​yong.li@torchmobile.com>

Reviewed by George Staikos.

Resurrect the old GetTickCount implementation of currentTime, controlled by WTF_USE_QUERY_PERFORMANCE_COUNTER
currentSystemTime taken from older WebKit; currentTime written by Yong Li <​yong.li@torchmobile.com>; cleanup by Joe Mason <​joe.mason@torchmobile.com>
​https://bugs.webkit.org/show_bug.cgi?id=27848

  • wtf/CurrentTime.cpp: (WTF::currentSystemTime): get current time with GetCurrentFT (WTF::currentTime): track msec elapsed since first currentSystemTime call using GetTickCount
  • wtf/Platform.h:
9:07 PM Changeset in webkit [46659] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Xan Lopez <​xlopez@igalia.com>

Reviewed by Holger Freyther.

Fix compiler warning.

Initialize member variables in the correct order.

  • plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
9:07 PM Changeset in webkit [46658] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-31 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Holger Hans Peter Freyther.

The reason these four tests fail is a mystery to me right, but placing
them in the Skipped file and the Qt port is... for the first time ever,
finally green!

​https://bugs.webkit.org/show_bug.cgi?id=27914

  • platform/qt/Skipped:
8:43 PM Changeset in webkit [46657] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-31 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

Printing related test needs to go in Skipped for now so we can
get Qt buildbot green for first time.

​https://bugs.webkit.org/show_bug.cgi?id=27913

  • platform/qt/Skipped:
8:43 PM Changeset in webkit [46656] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-31 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

Sometimes they pass, sometimes they fail. In attempt to get Qt buildbot
completely green for first time I'm placing these two in the Skipped file.

​https://bugs.webkit.org/show_bug.cgi?id=27912

  • platform/qt/Skipped:
8:43 PM Changeset in webkit [46655] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-31 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by George Staikos and Eric Seidel.

Place some audio related tests into the Skipped list in
attempt to get Qt buildbot finally green.

​https://bugs.webkit.org/show_bug.cgi?id=27910

  • platform/qt/Skipped:
7:58 PM Changeset in webkit [46654] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2009-07-31 Jon Honeycutt <​jhoneycutt@apple.com>

Windows build fix!

Unreviewed.

  • page/win/PageWin.cpp:
7:38 PM Changeset in webkit [46653] by jhoneycutt@apple.com
  • 3 edits in trunk/WebCore

2009-07-31 Jon Honeycutt <​jhoneycutt@apple.com>

Mac build fix.

Unreviewed.

  • page/Page.cpp: Move setCanStartPlugins() from here...
  • page/win/PageWin.cpp: (WebCore::Page::setCanStartPlugins): ... to here.
7:33 PM Changeset in webkit [46652] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

2009-07-31 David Levin <​levin@chromium.org>

Reviewed by Adam Treat.

check-webkit-style --git-commit has bugs if you select a commit in the past
​https://bugs.webkit.org/show_bug.cgi?id=27908

  • Scripts/check-webkit-style: (main): Made the git-commit command only select the first commit if a range is given (and print a warning).
  • Scripts/modules/scm.py: (SCM::create_patch_from_local_commit): (SCM::create_patch_since_local_commit): (SCM::commit_locally_with_message): (SCM::discard_local_commits): Added an error messages in case these aren't overriden.

(Git::create_patch_since_local_commit):
Added this command to allow doing a diff of everything after a given commit.

6:40 PM Changeset in webkit [46651] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-31 Jan Michael Alonzo <​jmalonzo@webkit.org>

Speculative Qt build fix. Not reviewed.

Add LayoutTestController::disableImageLoading() in jsobjects.h.

  • DumpRenderTree/qt/jsobjects.h:
6:34 PM Changeset in webkit [46650] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-31 Jan Michael Alonzo <​jmalonzo@webkit.org>

Skip http/tests/misc/favicon-loads-with-images-disabled.html as
this requires resource load callbacks in Gtk DRT. I've raised bug
#27905 to track this.

  • platform/gtk/Skipped:
6:13 PM Changeset in webkit [46649] by jhoneycutt@apple.com
  • 16 edits in trunk

WebCore:

2009-07-29 Jon Honeycutt <​jhoneycutt@apple.com>

<rdar://problem/5698113> Safari shouldn't auto-activate plug-ins in
background tabs (make Win consistent with Mac)

​https://bugs.webkit.org/show_bug.cgi?id=27855

Reviewed by Anders Carlsson.

  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::dispatchDidFailToStartPlugin): Declare a new function to dispatch failures to start plug-ins.
  • page/Page.cpp: (WebCore::Page::Page): Initialize new member variable. (WebCore::Page::addUnstartedPlugin): Add the PluginView to the set of unstarted plug-ins. (WebCore::Page::removeUnstartedPlugin): Remove the PluginView from the set of unstarted plug-ins. (WebCore::Page::setCanStartPlugins): If we can now start plug-ins, iterate the set of unstarted plug-ins, starting them. If a plug-in fails to start, dispatch a failed-to-start- plug-in error. Clear the list of unstarted plug-ins.
  • page/Page.h: Added m_canStartPlugins to track whether we can currently start plug-ins. Added m_unstartedPlugins to keep track of plug-ins in the page that are waiting to be started. (WebCore::Page::canStartPlugins):
  • plugins/PluginView.cpp: (WebCore::PluginView::start): m_mimeType is now a WebCore::String, so we call .utf8(). If NPP_New() fails, set m_status to reflect this; this used to be set by init(), but start() will not be called by init() if we are delaying start(). If NPP_New() succeeds, set m_status to reflect this, and call platformStart(). (WebCore::PluginView::startOrAddToUnstartedList): If we cannot start plug-ins, add this view to the Page's list of unstarted plug-ins and return true. Otherwise, call start() and return the result. (WebCore::PluginView::removeFromUnstartedListIfNecessary): If we've been started or we don't have a Page, return early. Remove ourselves from the Page's list of unstarted plug-ins. (WebCore::PluginView::bindingInstance): If we haven't been started yet, return 0. This matches the Mac behavior. (WebCore::PluginView::setParameters): If we find the "plug-ins page" parameter, record it; it may be used if we fail to start the plug-in. (WebCore::PluginView::PluginView): Initialize new members m_haveUpdatedPluginWidget. Initialize m_mimeType with mimeType directly; m_mimeType is now a WebCore::String.
  • plugins/PluginView.h: Made start() public, so Page can call it when we start unstarted plug-ins. Changed m_mimeType from CString to String and added m_pluginsPage; these are needed by dispatchDidFailToStartPlugin(). (WebCore::PluginView::pluginsPage): Added for dispatchDidFailToStartPlugin(). (WebCore::PluginView::mimeType): Ditto. (WebCore::PluginView::url): Ditto.
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::platformStart): Stubbed.
  • plugins/mac/PluginViewMac.cpp: (WebCore::PluginView::platformStart): Stubbed.
  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::platformStart): Stubbed.
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::updatePluginWidget): Use m_haveUpdatedPluginWidget to ensure that we will call MoveWindow() and SetWindowRgn() to position the plug-in and set its clip rect if an earlier call to updatePluginWidget() was made before setPlatformPluginWidget() was called to set the plug-in's HWND. (WebCore::PluginView::~PluginView): Call removeFromUnstartedListIfNecessary() to remove the plug-in from the unstarted list if the plug-in is destroyed before it is started. (WebCore::PluginView::init): Call startOrAddtoUnstartedList to start the plug-in or, if plug-ins cannot be started, to add it to the list of plug-ins waiting to be started. Set m_status to indicate success; this is also set by start(), but that may be delayed, and we don't want the loader to dispatch a failed-to-start-plug-in error when we return from init(). (WebCore::PluginView::platformStart): Added; code moved from init(). This is now called by start() to perform any platform-specific tasks that need to take place after the plug-in has started. Added a call to updatePluginWidget() to ensure we position the plug-in and set its clip rect after the plug-in has started. Removed the setting of m_status; start() does this before calling this function (and we assert this at the head of the function).

WebKit/win:

2009-07-29 Jon Honeycutt <​jhoneycutt@apple.com>

Part of <rdar://problem/5698113> Safari shouldn't auto-activate
plug-ins in background tabs (make Win consistent with Mac)

​https://bugs.webkit.org/show_bug.cgi?id=27855

Reviewed by Adam Roben and Anders Carlsson.

  • Interfaces/IWebViewPrivate.idl: Add setCanStartPlugins().
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidFailToStartPlugin): Added; code moved from createPlugin(). Modified to obtain the plug-in's page URL, the plug-ins "plug-ins page" parameter value, and the plug-in's MIME type by calling getter functions on the passed PluginView. (WebFrameLoaderClient::createPlugin): If the plug-in status is not "success," call dispatchDidFailToStartPlugin().
  • WebCoreSupport/WebFrameLoaderClient.h: Declare an override of dispatchDidFailToStartPlugin().
  • WebView.cpp: (WebViewWndProc): Add a missing ) to a comment. (WebView::setCanStartPlugins): Call the Page's setCanStartPlugins() function.
  • WebView.h:
5:50 PM Changeset in webkit [46648] by adachan@apple.com
  • 3 edits in trunk/JavaScriptCore

Fixes the Windows release-PGO build.

Reviewed by Jon Honeycutt.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj: Suppresses the warning about unreachable code that we get by adding "return 0" to WTF::TCMalloc_PageHeap::runScavengerThread().
  • wtf/FastMalloc.cpp: (WTF::TCMalloc_PageHeap::runScavengerThread): Fixes the error about the method not returning a value in the release-PGO build.
5:40 PM Changeset in webkit [46647] by Darin Adler
  • 42 edits in trunk

WebCore:

2009-07-30 Darin Adler <Darin Adler>

Reviewed by David Levin.

Use checked casts for render tree
​https://bugs.webkit.org/show_bug.cgi?id=23522

Next step: Add casts for all the RenderTable classes and use them everywhere.

Also added a few uses in places that were still using static_cast.
Also made some virtual member functions private.
Also changed RenderTable::m_tableLayout to use OwnPtr.

  • accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility): (WebCore::AccessibilityTable::addChildren): (WebCore::AccessibilityTable::cellForColumnAndRow):
  • accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::parentTable): (WebCore::AccessibilityTableCell::rowIndexRange): (WebCore::AccessibilityTableCell::columnIndexRange): (WebCore::AccessibilityTableCell::titleUIElement):
  • accessibility/AccessibilityTableColumn.cpp: (WebCore::AccessibilityTableColumn::headerObject):
  • accessibility/AccessibilityTableRow.cpp: (WebCore::AccessibilityTableRow::parentTable):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
  • editing/TextIterator.cpp: (WebCore::shouldEmitTabBeforeNode): (WebCore::shouldEmitNewlinesBeforeAndAfterNode):
  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::parseMappedAttribute):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::searchForLabelsAboveCell):
  • page/mac/FrameMac.mm: (WebCore::Frame::searchForNSLabelsAboveCell):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::shouldScaleColumns):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcPrefWidths):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcPercentageHeight):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addChild): (WebCore::RenderObject::containingBlock):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedBottomBorder):
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::table):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): (WebCore::RenderTableRow::layout): (WebCore::RenderTableRow::paint):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition): (WebCore::RenderTableSection::paintObject): (WebCore::RenderTableSection::recalcCells):
  • rendering/RenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeTextRun): Use checked casts.
  • rendering/RenderTable.cpp: (WebCore::RenderTable::styleDidChange): Updated to use OwnPtr. (WebCore::RenderTable::addChild): Use checked cast. (WebCore::RenderTable::layout): Ditto. (WebCore::RenderTable::setCellWidths): Ditto. (WebCore::RenderTable::paintObject): Ditto. (WebCore::RenderTable::splitColumn): Ditto. (WebCore::RenderTable::appendColumn): Ditto. (WebCore::RenderTable::colElement): Ditto. (WebCore::RenderTable::recalcSections): Ditto. (WebCore::RenderTable::outerBorderBottom): Ditto. (WebCore::RenderTable::outerBorderLeft): Ditto. (WebCore::RenderTable::outerBorderRight): Ditto. (WebCore::RenderTable::sectionAbove): Ditto. (WebCore::RenderTable::sectionBelow): Ditto.
  • rendering/RenderTable.h: Added checked cast. Made virtual functions private. Changed m_tableLayout to be a OwnPtr.
  • rendering/RenderTableCell.h: Added checked cast.
  • rendering/RenderTableCol.h: Ditto. Made virtual functions private.
  • rendering/RenderTableRow.h: Ditto.
  • rendering/RenderTableSection.h: Ditto.

WebKit/mac:

2009-07-30 Darin Adler <Darin Adler>

Reviewed by David Levin.

Use checked casts for render tree
​https://bugs.webkit.org/show_bug.cgi?id=23522

  • Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
  • Misc/WebNSPasteboardExtras.mm: (imageFromElement): (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
  • WebView/WebFrame.mm: (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebFrame _accessibilityTree]):
  • WebView/WebRenderNode.mm: (copyRenderNode): Use checked casts.

WebKit/win:

2009-07-30 Darin Adler <Darin Adler>

Reviewed by David Levin.

Use checked casts for render tree
​https://bugs.webkit.org/show_bug.cgi?id=23522

  • DOMHTMLClasses.cpp: (DOMHTMLInputElement::isUserEdited): (DOMHTMLTextAreaElement::isUserEdited): Use checked casts.
4:27 PM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
4:27 PM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
4:22 PM Changeset in webkit [46646] by beidson@apple.com
  • 12 edits
    2 adds in trunk

WebCore:

2009-07-31 Brady Eidson <​beidson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/6973106> and ​https://bugs.webkit.org/show_bug.cgi?id=27896
Favicons are still loaded when automatic image loading is disabled.

People who want to avoid loading images generally want to avoid loading all images.

Test: http/tests/misc/favicon-loads-with-images-disabled.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::startIconLoader): After committing the URL mapping, don't actually perform the load if images shouldn't be loading.

WebKitTools:

2009-07-31 Brady Eidson <​beidson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/6973106> and ​https://bugs.webkit.org/show_bug.cgi?id=27896
Favicons are still loaded when automatic image loading is disabled.

  • DumpRenderTree/LayoutTestController.cpp: (disableImageLoadingCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::disableImageLoading):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::disableImageLoading):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::disableImageLoading): Stubbed for now.
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::disableImageLoading): Ditto.

LayoutTests:

2009-07-31 Brady Eidson <​beidson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/6973106> and ​https://bugs.webkit.org/show_bug.cgi?id=27896
Favicons are still loaded when automatic image loading is disabled.

  • http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
  • http/tests/misc/favicon-loads-with-images-disabled.html: Added.
4:12 PM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
4:03 PM Changeset in webkit [46645] by Simon Fraser
  • 24 edits in trunk

2009-07-31 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Accelerated animations stutter on pages with lots of animations and 3d transforms
​https://bugs.webkit.org/show_bug.cgi?id=27884

This patch changes the strategy for synchronizing painting view the view,
and compositing layer updates. Previously the strategy was to disable screen
updates between the time we updated the layer tree, and painted the view. That
left screen updates disabled for too long (hundreds of milliseconds) in some
cases, causing animation stutter.

The new strategy is to batch up changes to the CA layer tree, and commit them
all at once just before painting happens (referred to as a "sync" in the code).
GraphicsLayerCA now keeps a bitmask of changed properties, and then migrates
the values stored in GraphicsLayer into the CA layer tree at commit time.

Compositing layers are then synced in FrameView::paintContents(). However, not
all style/layout changes will result in painting; to deal with style changes that
touch only compositing properties, we set up a runloop observer that takes care
of comitting layer changes when no painting happens.

  • WebCore.base.exp: Export FrameView::syncCompositingStateRecursive()
  • loader/EmptyClients.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive()
  • page/ChromeClient.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive()
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::syncCompositingStateRecursive): syncCompositingState() on the view and all subviews. Like layoutIfNeededRecursive(). If layout is pending, does not sync and returns false, since we only want to sync when layout is done.

(WebCore::FrameView::paintContents): syncCompositingState() before painting.

  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::endAnimation): Call animationPaused() to notify the graphics layers about animation pausing.
  • platform/graphics/FloatPoint3D.h: (WebCore::operator==): (WebCore::operator!=): Add missing comparison operators.
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setOpacity): (WebCore::GraphicsLayer::setBackgroundColor): Simple setters no longer care about animation info.

(WebCore::GraphicsLayer::paintGraphicsLayerContents): Null-check client.

  • platform/graphics/GraphicsLayer.h: (WebCore::AnimationValue:): (WebCore::TransformAnimationValue:): (WebCore::KeyframeValueList:): (WebCore::KeyframeValueList::insert): Cleaned up versions of FloatValue and TransformValue, used to store information about keyframes values.

(WebCore::GraphicsLayer::contentsRect):
(WebCore::GraphicsLayer::setContentsRect):
ContentsRect is now a simple setter.

(WebCore::GraphicsLayer::addAnimation):
(WebCore::GraphicsLayer::removeAnimationsForProperty):
(WebCore::GraphicsLayer::removeAnimationsForKeyframes):
(WebCore::GraphicsLayer::pauseAnimation):
Simplified animation api.

(WebCore::GraphicsLayer::setGeometryOrientation):
(WebCore::GraphicsLayer::geometryOrientation):
setGeometryOrientation is now just a normal member variable.

(WebCore::GraphicsLayer::contentsOrientation): add a getter.
(WebCore::GraphicsLayer::syncCompositingState): Entry into the layer sync code.

  • platform/graphics/GraphicsLayerClient.h: scheduleViewUpdate() renamed to syncCompositingStateRecursive)
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: Lots of cleanup and refactoring. Main points:
  • Layer changes are all batched, and only committed to the CA layer on syncCompositingState().
  • Bitmask is used to store which properties have changed. More efficient than before.
  • Simpler animation interface; simple setters are no longer confounded with animations.
  • Refactored code that creates CA animations, and stores which animations are running.
  • platform/graphics/transforms/TransformOperations.h: (WebCore::TransformOperations::size): (WebCore::TransformOperations::at): Useful accessors for size and indexed access.
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerBacking.cpp: Renamed 'contentsLayer' to 'foregroundLayer' to avoid confusion with GraphicsLayer's contentsLayer. Adapt to GraphicsLayer's simpler animation API. Pass animation pausing through to the graphics layers. contentsBox() is no longer a callback via GraphicsLayerClient.
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::setCompositingLayersNeedRebuild): (WebCore::RenderLayerCompositor::scheduleSync): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): scheduleViewUpdate() is no longer required. Instead, we plumb through "compositingLayerSync" notifications, which travel up to WebKit and set up a runloop observer.
3:59 PM UpdatingBugzilla created by ddkilzer@apple.com
Initial contents
3:58 PM WikiStart edited by ddkilzer@apple.com
(diff)
3:46 PM Changeset in webkit [46644] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-30 Eric Seidel <​eric@webkit.org>

Reviewed by David Kilzer.

bugzilla-tool post-commits trunk..head errors out
​https://bugs.webkit.org/show_bug.cgi?id=27847

Rename commit_ids_from_range_arguments to commit_ids_from_commitish_arguments
and make it handle the new arguments format proposed in the bug.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
3:29 PM Changeset in webkit [46643] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-07-31 Zoltan Horvath <​hzoltan@inf.u-szeged.hu>

Change malloc to fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp
​https://bugs.webkit.org/show_bug.cgi?id=27874

Use fastMalloc and fastFree instead of malloc and free in RegexInterpreter.cpp's methods.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::allocDisjunctionContext): (JSC::Yarr::Interpreter::freeDisjunctionContext): (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
2:57 PM Changeset in webkit [46642] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-07-31 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Eric Seidel.

Geolocation clean up when no longer updating
​https://bugs.webkit.org/show_bug.cgi?id=27888

When Geolocation::disconnectFrame() is called, need to call
Document::setUsingGeolocation(false) to mirror the true call
when it is set up.

When handling an error, and there are no more listeners, call
GeolocationService::stopUpdating().

  • page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame): (WebCore::Geolocation::handleError):
2:14 PM Changeset in webkit [46641] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-30 Eric Seidel <​eric@webkit.org>

Reviewed by David Levin.

clean up build-webkit to use less copy/paste code and remove unneeded SVG warning
​https://bugs.webkit.org/show_bug.cgi?id=27857

  • Scripts/build-webkit:
2:02 PM Changeset in webkit [46640] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/27894> bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and python-2.5

Reviewed by Eric Seidel.

  • Scripts/modules/bugzilla.py: (Bugzilla.clear_attachment_review_flag): Specify which 'comment' form field to use when setting its value.
1:29 PM Changeset in webkit [46639] by jorlow@chromium.org
  • 1 edit
    6 adds in trunk/LayoutTests

2009-07-31 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Adam Barth.

Add new LocalStorage layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=27778

These test behavior that I don't think was very well verified earlier.

  • storage/domstorage/localstorage/complex-keys-expected.txt: Added.
  • storage/domstorage/localstorage/complex-keys.html: Added.

A bunch of corner cases related to keys.

  • storage/domstorage/localstorage/complex-values-expected.txt: Added.
  • storage/domstorage/localstorage/complex-values.html: Added.

A bunch of corner cases related to values.

  • storage/domstorage/localstorage/remove-item-expected.txt: Added.
  • storage/domstorage/localstorage/remove-item.html: Added.

Test basic removeItem functionality.

1:21 PM Changeset in webkit [46638] by andersca@apple.com
  • 3 edits in trunk/WebKit/win

2009-07-31 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

-Fix <rdar://problem/7104097>

Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count.


  • WebCoreSupport/EmbeddedWidget.cpp: (EmbeddedWidget::create):
  • WebCoreSupport/EmbeddedWidget.h:
1:12 PM Changeset in webkit [46637] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-31 Eric Seidel <​eric@webkit.org>

Reviewed by David Kilzer.

bugzilla-tool post-commits obsoletes its own work :(
​https://bugs.webkit.org/show_bug.cgi?id=27849

Simple fix. Use .add() instead of .update()

  • Scripts/bugzilla-tool:
11:40 AM Changeset in webkit [46636] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2009-07-30 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by David Levin.

Guard needs 's between #endif and ENABLE(DATAGRID)
​https://bugs.webkit.org/show_bug.cgi?id=27862

Compiling this file causes a build break without this change.

  • bindings/v8/custom/V8DataGridColumnListCustom.cpp:
11:16 AM Changeset in webkit [46635] by treat@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-31 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Re-Enable tests from Skipped that are passing correctly.

​https://bugs.webkit.org/show_bug.cgi?id=27890

  • platform/qt/Skipped:
10:07 AM Changeset in webkit [46634] by kenneth@webkit.org
  • 1 edit
    45 adds in trunk/LayoutTests

2009-07-31 Mike Fenton <​mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add LayoutTest results from BuildBot output for tests that currently lack results under Qt.

​https://bugs.webkit.org/show_bug.cgi?id=27882

  • platform/qt/fast/backgrounds/size/backgroundSize20-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt.
  • platform/qt/fast/backgrounds/size/backgroundSize21-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt.
  • platform/qt/fast/backgrounds/size/backgroundSize22-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt.
  • platform/qt/fast/borders/border-radius-constraints-expected.txt: Added.
  • platform/qt/fast/box-shadow/inset-expected.txt: Added.
  • platform/qt/fast/box-shadow/spread-expected.txt: Copied from LayoutTests/platform/mac/fast/box-shadow/spread-expected.txt.
  • platform/qt/fast/canvas/image-pattern-rotate-expected.txt: Added.
  • platform/qt/fast/css/nested-floating-relative-position-percentages-expected.txt: Added.
  • platform/qt/fast/css/pseudo-cache-stale-expected.txt: Added.
  • platform/qt/fast/css/rem-dynamic-scaling-expected.txt: Added.
  • platform/qt/fast/css/rem-units-on-root-expected.txt: Added.
  • platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
  • platform/qt/fast/dynamic/window-scrollbars-test-expected.txt: Added.
  • platform/qt/fast/forms/isindex-placeholder-expected.txt: Added.
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt: Added.
  • platform/qt/fast/frames/content-opacity-1-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/content-opacity-1-expected.txt.
  • platform/qt/fast/frames/content-opacity-2-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/content-opacity-2-expected.txt.
  • platform/qt/fast/frames/frame-navigation-expected.txt: Added.
  • platform/qt/fast/frames/frame-scrolling-attribute-expected.txt: Added.
  • platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt: Added.
  • platform/qt/fast/gradients/crash-on-zero-radius-expected.txt: Added.
  • platform/qt/fast/lists/ol-start-parsing-expected.txt: Added.
  • platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.txt: Added.
  • platform/qt/fast/repaint/float-new-in-block-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/float-new-in-block-expected.txt.
  • platform/qt/fast/text/international/khmer-selection-expected.txt: Added.
  • platform/qt/fast/text/shadow-translucent-fill-expected.txt: Added.
  • platform/qt/fast/text/text-letter-spacing-expected.txt: Added.
  • platform/qt/plugins/netscape-dom-access-expected.txt: Added.
  • platform/qt/svg/batik/filters/feTile-expected.txt: Added.
  • platform/qt/svg/custom/createImageElement-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/createImageElement-expected.txt.
  • platform/qt/svg/custom/createImageElement2-expected.txt: Added.
  • platform/qt/svg/custom/js-update-image-and-display-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display-expected.txt.
  • platform/qt/svg/custom/js-update-image-and-display2-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display2-expected.txt.
  • platform/qt/svg/custom/js-update-image-and-display3-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/js-update-image-and-display3-expected.txt.
  • platform/qt/svg/custom/outer-svg-unknown-feature-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/outer-svg-unknown-feature-expected.txt.
  • platform/qt/svg/filters/feMerge-expected.txt: Added.
  • platform/qt/svg/filters/feOffset-expected.txt: Added.
  • platform/qt/svg/filters/feTile-expected.txt: Added.
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt: Added.
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt: Added.
10:04 AM Changeset in webkit [46633] by bolsinga@apple.com
  • 3 edits in trunk/WebCore

2009-07-30 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by George Staikos.

Consolidate GeoLocation code to send positions and errors
​https://bugs.webkit.org/show_bug.cgi?id=27863

Create helper methods that will send positions and errors to either
one shots or watchers.

  • page/Geolocation.cpp: (WebCore::Geolocation::sendError): (WebCore::Geolocation::sendErrorToOneShots): (WebCore::Geolocation::sendErrorToWatchers): (WebCore::Geolocation::sendPosition): (WebCore::Geolocation::sendPositionToOneShots): (WebCore::Geolocation::sendPositionToWatchers):
  • page/Geolocation.h:
9:52 AM Changeset in webkit [46632] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-31 Jakob Petsovits <​jakob.petsovits@torchmobile.com>

Reviewed by Adam Treat.

Build QtWebKit without benchmark tests for Qt < 4.5.
​https://bugs.webkit.org/show_bug.cgi?id=27886

The QBENCHMARK macro is only available from 4.5 on,
so builds for Qt < 4.5 shouldn't try to build those.

  • tests/tests.pro:
7:56 AM Changeset in webkit [46631] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-31 Tor Arne Vestbø <​tor.arne.vestbo@nokia.com>

Reviewed by Anders Carlsson.

Improve platform-detection in run-webkit-tests

This prevents miss-detection of mac-* over Qt/Mac.

  • Scripts/run-webkit-tests:
7:37 AM Changeset in webkit [46630] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-31 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Adam Treat.

Fix warning by migrating use of QString.sprintf(...) to
QString.arg().arg()...

  • WebCoreSupport/EditorClientQt.cpp: (dumpRange):
6:51 AM Changeset in webkit [46629] by treat@webkit.org
  • 3 edits in trunk/LayoutTests

2009-07-31 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Tor Arne Vestbo.

Adding -webkit-animation-play-state back in following r46547.

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
6:29 AM Changeset in webkit [46628] by kenneth@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-07-31 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Tor Arne Vestbø.

Expose the Offline Web Application Cache in the Qt API.

  • Api/qwebsettings.cpp: (QWebSettings::QWebSettings): (QWebSettings::setOfflineWebApplicationCachePath): (QWebSettings::offlineWebApplicationCachePath): (QWebSettings::setOfflineWebApplicationCacheQuota): (QWebSettings::offlineWebApplicationCacheQuota):
  • Api/qwebsettings.h:
5:43 AM Changeset in webkit [46627] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Xan Lopez <​xlopez@igalia.com>

Roll out previous change as it might be causing some weirdness in
the bots.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::processFileHeader):
5:06 AM Changeset in webkit [46626] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-31 Xan Lopez <​xlopez@igalia.com>

Reviewed by Mark Rowe.

Fix compiler warning.
​https://bugs.webkit.org/show_bug.cgi?id=27851

GCC does not like multi-character character constants, so use the
explicit numerical value of 'BM' in the enum.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::processFileHeader):
12:21 AM Changeset in webkit [46625] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Fix the test case that was landed in r46624.

  • http/tests/misc/meta-refresh-stray-single-quote.html:
Note: See TracTimeline for information about the timeline view.