Timeline
Nov 21, 2009:
- 7:39 PM Changeset in webkit [51291] by
-
- 2 edits in trunk/WebCore
2009-11-20 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Support Ctrl+P and Ctrl+N, Readline keyboard shortcuts in the Console
https://bugs.webkit.org/show_bug.cgi?id=31400
Handle the following when on a Mac:
Ctrl+P = Previous (like Up arrow)
Ctrl+N = Next (like Down arrow)
No longer rerun autocompletion when just pushing a modifier key
like Control, Alt, Shift, or Meta.
Improved arrow key behavior with Multiline code in the Console, with the following behavior:
Up = Previous Command if on First Line (caret moves to the end of the first line)
otherwise default caret movement in text.
Down = Next Command if on Last Line (caret naturally moves to the end)
otherwise default caret movement in text.
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.handleKeyEvent): handle new keyboard shortcuts (WebInspector.TextPrompt.prototype.isCaretOnFirstLine): check if the caret is on the top line (WebInspector.TextPrompt.prototype.isCaretOnLastLine): check if the caret is on the bottom line (WebInspector.TextPrompt.prototype._upKeyPressed): (WebInspector.TextPrompt.prototype._downKeyPressed): (WebInspector.TextPrompt.prototype._moveBackInHistory): (WebInspector.TextPrompt.prototype._moveForwardInHistory):
- 7:04 PM Changeset in webkit [51290] by
-
- 2 edits in trunk/WebCore
Adds a tooltip containing the full url of the resource to each element
in the Resources panel so that it is possible to quickly see the query
parameters.
https://bugs.webkit.org/show_bug.cgi?id=19103
Reviewed by Timothy Hatcher.
- inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourceSidebarTreeElement.prototype.refresh):
Set the tooltip to be the resource's url.
- 4:18 PM Changeset in webkit [51289] by
-
- 5 edits in trunk
2009-11-21 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein.
CSSKeyframesRule::findRule() and deleteRule() should accept 'from' and 'to' as well as percentages
https://bugs.webkit.org/show_bug.cgi?id=31588
In WebKitCSSKeyframesRule::findRuleIndex(), map 'from' to 0% an 'to' to 100%
so that findRule() and deleteRule() work with these keywords.
- css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
- 3:13 PM Changeset in webkit [51288] by
-
- 2 edits in trunk/JavaScriptCore
2009-11-21 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
[Qt][Mac] Turn on multiple JavaScript threads for QtWebkit on Mac
https://bugs.webkit.org/show_bug.cgi?id=31753
- wtf/Platform.h:
- 1:34 PM Changeset in webkit [51287] by
-
- 8 edits in trunk/WebKitTools
2009-11-21 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool --help spews way too much text
https://bugs.webkit.org/show_bug.cgi?id=31771
- Scripts/bugzilla-tool:
- Remove self.cached_scm initialization hack.
- Scripts/modules/buildbot.py:
- Make default_host accessible to callers.
- Scripts/modules/commands/download.py:
- Phrase help for all commands consistently and remove spurious help text punctuation.
- Scripts/modules/commands/queries.py: Ditto.
- Scripts/modules/commands/queues.py: Ditto.
- Scripts/modules/commands/upload.py: Ditto.
- Scripts/modules/multicommandtool.py:
- Add HelpPrintingOptionParser.format_epilog to replace NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
- Make --help only show a list of commands like "svn help" and "git help" do -- previously --help was listing all commands and options.
- Sort list of commands alphabetically.
- 1:32 PM Changeset in webkit [51286] by
-
- 2 edits in trunk/WebKit/win
2009-11-21 Jon Honeycutt <jhoneycutt@apple.com>
Windows build fix. Unreviewed.
- Interfaces/IWebSerializedJSValue.idl:
- 1:26 PM Changeset in webkit [51285] by
-
- 3 edits in trunk/WebCore
2009-11-21 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.
No functionality was changed. So, no new tests.
- dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::~KeyboardEvent):
- dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr. (WebCore::KeyboardEvent::keyEvent):
- 1:12 PM Changeset in webkit [51284] by
-
- 2 edits in trunk/WebKitTools
2009-11-21 Eric Seidel <eric@webkit.org>
No review. Fixing a typo from the previous patch for bug 31767.
AbstractQueue.run_bugzilla_tool throws an exception
https://bugs.webkit.org/show_bug.cgi?id=31769
- Scripts/modules/commands/queues.py:
- 7:50 AM Changeset in webkit [51283] by
-
- 5 edits in trunk/WebKitTools
2009-11-21 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
https://bugs.webkit.org/show_bug.cgi?id=31767
What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
Since we don't have a good way to test BugzillaTool pieces, I've
left out a test for now.
- Scripts/bugzilla-tool:
- Add a path() implementation to expose bugzilla-tool's file path to commit-queue.
- Scripts/modules/commands/queues.py:
- Use tool.path() instead of file.
- Scripts/modules/multicommandtool.py:
- Add a new path() method to MultiComandTool.
- Scripts/modules/multicommandtool_unittest.py:
- Provide a path() method. Little point in testing this mock implementation.
- 7:37 AM Changeset in webkit [51282] by
-
- 2 edits in trunk/WebKitTools
2009-11-21 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix. Turns out I was testing the wrong copy of
WebKitTools.
- Scripts/modules/commands/download.py:
- 7:29 AM Changeset in webkit [51281] by
-
- 2 edits in trunk/WebKitTools
2009-11-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Convert check-style to use LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=31763
Instead of manipulating the working copy by hand, we should use the
LandingSequence in CheckStyle. This will make this code eaiser to
test.
- Scripts/modules/commands/download.py:
- 12:53 AM Web Inspector Update.ja edited by
- (diff)
- 12:52 AM WebKit nightlies support HTML5 noreferrer link relation.ja created by
- 12:50 AM Web Inspector Update.ja edited by
- (diff)
- 12:48 AM Surfin' Safari Translations edited by
- (diff)
Nov 20, 2009:
- 8:50 PM Changeset in webkit [51280] by
-
- 2 edits in trunk/WebKit/win
DOMElement::tagName() is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=31746
Reviewed by Darin Adler.
- DOMCoreClasses.cpp:
(DOMElement::tagName):
Create a BString from the element's tag name, and release its BSTR
into result.
- 8:50 PM Changeset in webkit [51279] by
-
- 2 edits in trunk/WebKit/win
DOMNode::childNodes() is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=31745
Reviewed by Darin Adler.
- DOMCoreClasses.cpp:
(DOMNode::childNodes):
Create a DOMNodeList from the node's child nodes.
- 8:06 PM Changeset in webkit [51278] by
-
- 2 edits2 copies in trunk/WebKitTools
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Unit test query commands
https://bugs.webkit.org/show_bug.cgi?id=31755
These tests are pretty rough, but hopefully they'll grow.
- Scripts/modules/commands/queries_unittest.py: Added.
- Scripts/modules/mock_bugzillatool.py: Added.
- Scripts/run-webkit-unittests:
- 7:53 PM Changeset in webkit [51277] by
-
- 6 edits in trunk/WebKitTools
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
https://bugs.webkit.org/show_bug.cgi?id=31758
- Scripts/modules/multicommandtool.py:
- Allow passing of explicit commands to MultiCommandTool.init
- Scripts/modules/multicommandtool_unittest.py:
- Use new Command.name naming system.
- Test Command auto-discovery.
- Scripts/modules/workqueue.py:
- bug_id no longer exists, use patchbug_id instead.
- Scripts/modules/workqueue_unittest.py:
- WorkQueues require names now.
- should_proceed_with_work_item must return a patch object.
- 7:29 PM Changeset in webkit [51276] by
-
- 13 edits2 adds in trunk
WAI-ARIA: add support for aria-owns
https://bugs.webkit.org/show_bug.cgi?id=31702
Reviewed by Beth Dakin.
WebCore:
Re-organized how accessibilityAttributeNames are returned so
that it's possible for an element to add an attribute based on
a dynamic value. In this case, we only want to add AXOwn if the
element actually supports aria-owns.
Test: platform/mac/accessibility/aria-owns.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::supportsARIAOwns):
(WebCore::AccessibilityObject::ariaOwnsElements):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaOwnsElements):
(WebCore::AccessibilityRenderObject::supportsARIAOwns):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
- html/HTMLAttributeNames.in:
WebKitTools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(ariaOwnsElementAtIndexCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::ariaOwnsElementAtIndex):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::ariaOwnsElementAtIndex):
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::ariaOwnsElementAtIndex):
LayoutTests:
- platform/mac/accessibility/aria-owns-expected.txt: Added.
- platform/mac/accessibility/aria-owns.html: Added.
- 7:14 PM Changeset in webkit [51275] by
-
- 3 edits in trunk/WebKitTools
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix exception thrown when running the commit-queue.
- Scripts/modules/statusbot.py: patch is optional.
- Scripts/modules/workqueue.py: WorkQUeue requires a name.
- 6:54 PM Changeset in webkit [51274] by
-
- 4 edits in trunk/WebKit/win
Change WebSerializedJSValue on Windows to have a zero-argument createInstance call. Move the
serialization into a separate serialize() function that can be called after the object has been
created.
Reviewed by Jon Honeycutt.
Fix a typo in serialize() caused when fixing build bustage (put a ! back in).
- Interfaces/IWebSerializedJSValue.idl:
- WebSerializedJSValue.cpp:
(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::serialize):
(WebSerializedJSValue::deserialize):
- WebSerializedJSValue.h:
- 6:36 PM Changeset in webkit [51273] by
-
- 7 edits in trunk/WebKit/win
Another go at the Windows Build Fix - this is a couple steps of it,
so a little more involved than most build fixes.
Reviewed by Dave Hyatt.
- Interfaces/IWebSerializedJSValue.idl:
- Interfaces/JavaScriptCoreAPITypes.idl:
- WebKit.vcproj/Interfaces.vcproj:
- WebSerializedJSValue.cpp:
(WebSerializedJSValue::deserialize):
- WebSerializedJSValue.h:
- 6:07 PM Changeset in webkit [51272] by
-
- 2 edits in trunk/WebKit/mac
Make sure to export WebSerializedJSValue.
Reviewed by Darin Adler.
- WebKit.exp:
- 5:54 PM Changeset in webkit [51271] by
-
- 5 edits1 add in trunk/WebKit/win
Build fix for Windows - only declare JSContextRef once, instead
of in two different idl files. Create a new file to hold the
definition of JSContextRef.
Reviewed by Dave Hyatt.
- Interfaces/IWebFrameLoadDelegate.idl:
- Interfaces/IWebSerializedJSValue.idl:
- Interfaces/JavaScriptCoreAPITypes.idl: Added.
- Interfaces/WebKit.idl:
- WebKit.vcproj/Interfaces.vcproj:
- 5:44 PM Changeset in webkit [51270] by
-
- 12 edits in trunk
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element
- css/mediaControls.css:
Define closed caption toggle button.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls):
Create closed caption toggle button in display order.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
Don't require MediaControllerThemeQuickTime theme for captions toggle button.
No need to check if the movie has video, a closed captions track is a video
track.
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element
Remove closed captions test from skipped list.
- platform/mac-leopard/Skipped:
- platform/mac-tiger/Skipped:
- 5:34 PM Changeset in webkit [51269] by
-
- 3 edits in trunk/WebKit/chromium
Not reviewed. Fix chromium build.
- public/WebAccessibilityRole.h:
(WebKit::):
- src/AssertMatchingEnums.cpp:
- 5:18 PM Changeset in webkit [51268] by
-
- 2 edits in trunk/WebCore
2009-11-20 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Running code in the Console that ends with a
single line comment no longer produces a parse error.
- inspector/front-end/InjectedScript.js: (InjectedScript._evaluateOn):
- 5:17 PM Changeset in webkit [51267] by
-
- 6 edits5 adds in trunk/WebKit
Add support for WebSerializedJSValue to WebKit. This object wraps the SerializedScriptValue functionality in WebCore
and exposes the ability to do JS value serialization/deserialization to WebKit clients.
Reviewed by Oliver Hunt and Jon Honeycutt.
WebKit:
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
- WebView/WebSerializedJSValue.h: Added.
- WebView/WebSerializedJSValue.mm: Added.
(-[WebSerializedJSValue initWithValue:context:]):
(-[WebSerializedJSValue deserialize:]):
(-[WebSerializedJSValue dealloc]):
WebKit/win:
- Interfaces/IWebSerializedJSValue.idl: Added.
- Interfaces/WebKit.idl:
- WebKit.vcproj/WebKit.vcproj:
- WebSerializedJSValue.cpp: Added.
(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::~WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::AddRef):
(WebSerializedJSValue::Release):
(WebSerializedJSValue::QueryInterface):
(WebSerializedJSValue::deserialize):
- WebSerializedJSValue.h: Added.
- 5:15 PM Changeset in webkit [51266] by
-
- 2 edits in trunk/WebKitTools
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach the StatusBot how to support more than just the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31754
- Scripts/modules/workqueue.py: Another typo.
- 5:09 PM Changeset in webkit [51265] by
-
- 2 edits in trunk/WebKitTools
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach the StatusBot how to support more than just the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31754
- Scripts/modules/commands/queues.py: Fix silly typo.
- 5:02 PM Changeset in webkit [51264] by
-
- 7 edits in trunk/WebKitTools
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach the StatusBot how to support more than just the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31754
- CommitQueueStatus/index.yaml:
- Add indices required for the new queries.
- CommitQueueStatus/queue_status.py:
- Add a patch-status page and move update_status to update-status.
- Only display "commit-queue" status records for the commit-queue.
- Add support for a queue_name property on status records.
- Fix _int_from_request to actually work.
- CommitQueueStatus/update_status.html:
- Add support for a queue_name on status records.
- Remove unused list of bug ids.
- Scripts/modules/commands/queues.py
- Make the queues pass the patch instead of the bug_id to StatusBot.
- Scripts/modules/statusbot.py:
- Support passing the queue_name to the status updates.
- Support fetching patch status with patch_status().
- Scripts/modules/workqueue.py:
- Pass the patch to the StatusBot instead of the bug_id.
- Let WorkQueues have a name.
- 4:15 PM Changeset in webkit [51263] by
-
- 2 edits7 adds in trunk/WebKitTools
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move bugzilla-tool commands into their own file
https://bugs.webkit.org/show_bug.cgi?id=31752
This will let us write unit tests.
- Scripts/bugzilla-tool:
- Scripts/modules/commands/init.py: Added.
- Scripts/modules/commands/download.py: Added.
- Scripts/modules/commands/queries.py: Added.
- Scripts/modules/commands/queues.py: Added.
- Scripts/modules/commands/upload.py: Added.
- Scripts/modules/grammar.py: Added.
- 4:00 PM Changeset in webkit [51262] by
-
- 12 edits in trunk
2009-11-20 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706
- platform/mac/accessibility/aria-grouping-roles-expected.txt:
- platform/mac/accessibility/aria-grouping-roles.html:
2009-11-20 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706
- accessibility/AccessibilityObject.cpp:
- accessibility/AccessibilityObject.h:
- accessibility/mac/AccessibilityObjectWrapper.mm:
2009-11-20 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706
- English.lproj/Localizable.strings:
- StringsNotToBeLocalized.txt:
2009-11-20 Chris Fleizach <Chris Fleizach>
Reviewed by Beth Dakin.
WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory AXARIAContentGroupText:]):
- 2:54 PM Changeset in webkit [51261] by
-
- 1 edit in trunk/WebKitTools/ChangeLog
Fix ChangeLog
- 2:52 PM Changeset in webkit [51260] by
-
- 4 edits in trunk/WebKitTools
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Reviewed by Eric Seidel.
BuildQueue should check if the tree is currently buildable
https://bugs.webkit.org/show_bug.cgi?id=31744
- Scripts/bugzilla-tool:
- Scripts/modules/landingsequence.py:
- Scripts/modules/webkitlandingscripts.py:
- 2:51 PM Changeset in webkit [51259] by
-
- 3 edits in trunk/WebKitTools
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move prepare_clean_working_directory into the LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=31743
- Scripts/bugzilla-tool:
- Scripts/modules/landingsequence.py:
- 2:34 PM Changeset in webkit [51258] by
-
- 3 edits in trunk/LayoutTests
Unreviewed fix.
Fix file names in the skipped list, for files added in http://trac.webkit.org/changeset/51257.
- 1:40 PM Changeset in webkit [51257] by
-
- 7 edits4 adds in trunk
NPN_ReloadPlugins does not reload the page even if reloadPages is true.
https://bugs.webkit.org/show_bug.cgi?id=30460
Reviewed by Kenneth Rohde Christiansen.
WebCore:
Replace call to PluginDatabase::installedPlugins()->refresh() with Page::refreshPlugins().
It already refreshes plugins and reloads pages when necessary.
Tests: plugins/reloadplugins-and-pages.html
plugins/reloadplugins-no-pages.html
- plugins/PluginInfoStore.cpp:
(WebCore::refreshPlugins):
WebKitTools:
Added code for calling NPN_ReloadPlugins with reloadPages true and false.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginInvoke):
LayoutTests:
Added tests for calling NPN_ReloadPlugins with reloadPages being true and false.
- 1:32 PM Changeset in webkit [51256] by
-
- 4 edits in trunk/WebCore
<rdar://7409188> WebKit needs to be able to serialize and deserialize objects.
Reviewed by Dave Hyatt.
Expose WebCore object serialization to WebKit.
- 1:29 PM Changeset in webkit [51255] by
-
- 2 edits in trunk/WebCore
Fixes <http://webkit.org/b/31741>.
Web Inspector: User Entered Data on the console should show up no matter what filters.
Reviewed by Tim Hatcher.
Always show .console-user-command-result, no matter what the filter say
we should do with the other classes.
- inspector/front-end/inspector.css:
- 1:29 PM Changeset in webkit [51254] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25381
Needs test: jQuery animation crashing Safari
Adding a regression test for a bug that doesn't reproduce in ToT.
- fast/dynamic/jQuery-animation-crash-expected.txt: Added.
- fast/dynamic/jQuery-animation-crash.html: Added.
- 1:03 PM Changeset in webkit [51253] by
-
- 5 edits in trunk/WebKitTools
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Pass the port information to the child process
https://bugs.webkit.org/show_bug.cgi?id=31736
We need to do this so the child process knows what to build!
- Scripts/bugzilla-tool:
- Scripts/modules/landingsequence.py:
- Scripts/modules/webkitport.py:
- Scripts/modules/webkitport_unittest.py:
- 12:26 PM Changeset in webkit [51252] by
-
- 2 edits in trunk/LayoutTests
WebSocket tests still don't work on Windows, disabling for futher invesigation.
- platform/win/Skipped:
- 11:55 AM Changeset in webkit [51251] by
-
- 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj
Fix a closing tag issue in the vcproj and remove tabs.
- 11:51 AM Changeset in webkit [51250] by
-
- 7 edits in trunk/WebCore
Fixes <http://webkit.org/b/31700>.
Web Inspector: isMac should be in one central location + Cached.
Reviewed by Tim Hatcher.
We should cache the value of isMac, and make the indexOf call in one
single location, because we are calling it from multiple places, and saving
the result can save us time, and make the call sites simpler.
- inspector/front-end/AbstractTimelinePanel.js:
(WebInspector.AbstractTimelinePanel.prototype._updateFilter):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._updateFilter):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleKeyEvent):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._loaded):
- inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
(WebInspector.isMac):
- 11:31 AM Changeset in webkit [51249] by
-
- 2 edits in trunk/WebKitTools
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Support Qt port in build-queue
https://bugs.webkit.org/show_bug.cgi?id=31733
- Scripts/bugzilla-tool:
- 11:22 AM Changeset in webkit [51248] by
-
- 2 edits in trunk/WebKitTools
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement a build-queue
https://bugs.webkit.org/show_bug.cgi?id=31725
Currently this just builds the first 10 patches in the review queue.
We'll want to do something smarter soon.
- Scripts/bugzilla-tool:
- 11:22 AM Changeset in webkit [51247] by
-
- 2 edits in trunk/LayoutTests
Enabling WebSocket tests on Windows - let's see if they pass after the recent fixes.
- platform/win/Skipped:
- 11:19 AM Changeset in webkit [51246] by
-
- 1 edit1 delete in trunk/WebCore
2009-11-19 Joseph Pecoraro <Joseph Pecoraro>
Removed .DS_Store accidentally added in last (r51245).
- 11:11 AM Changeset in webkit [51245] by
-
- 12 edits3 adds in trunk/WebCore
2009-11-19 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Timothy Hatcher.
Web Inspector: Add Console Only Layout Mode
https://bugs.webkit.org/show_bug.cgi?id=30282
Adds a Console Panel, which allows for a Full size Console. This
extends the Drawer to the size of a Panel. This also fixes previous
resize issues with the Drawer.
- inspector/front-end/ConsolePanel.js: added. (WebInspector.ConsolePanel): (WebInspector.ConsolePanel.prototype.toolbarItemClass.get toolbarItemLabel): (WebInspector.ConsolePanel.prototype.show): (WebInspector.ConsolePanel.prototype.hide):
- inspector/front-end/Drawer.js: (WebInspector.Drawer): (WebInspector.Drawer.prototype.set visibleView): (WebInspector.Drawer.prototype.get savedHeight): access the saved height of the variable console. (WebInspector.Drawer.prototype.show.animationFinished): (WebInspector.Drawer.prototype.show): (WebInspector.Drawer.prototype.hide.animationFinished): (WebInspector.Drawer.prototype.hide): (WebInspector.Drawer.prototype.resize): resize appropriately if full/non-full (WebInspector.Drawer.prototype.enterPanelMode): (WebInspector.Drawer.prototype.exitPanelMode): (WebInspector.Drawer.prototype.immediatelyExitPanelMode): (WebInspector.Drawer.prototype._cancelAnimationIfNeeded): (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished): (WebInspector.Drawer.prototype._animateDrawerHeight): (WebInspector.Drawer.prototype._animationDuration): (WebInspector.Drawer.prototype._startStatusBarDragging): (WebInspector.Drawer.prototype._statusBarDragging): (WebInspector.Drawer.prototype._endStatusBarDragging):
Miscellaneous changes and cleanup.
- English.lproj/localizedStrings.js: "Console" toolbar title.
- inspector/front-end/ConsoleView.js: removed unnecessary element reordering
- inspector/front-end/Images/consoleIcon.png: added.
- inspector/front-end/inspector.css: added icon.
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js: (WebInspector._createPanels): create console panel (WebInspector.windowResize): resize drawer if necessary (WebInspector.documentKeyDown): esc should not toggle the console when in panel mode (WebInspector.animateStyle): start animation interval, returns the interval key (WebInspector.toggleAttach): resize drawer if necessary (WebInspector.showConsolePanel): restore the panel when the inspector restarts (WebInspector.showProfileForURL): style fix
Restore the panel when the inspector restarts.
- inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::specialPanelForJSName):
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::showPanel):
Build files.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/WebKit.qrc:
- 11:06 AM Changeset in webkit [51244] by
-
- 2 edits in trunk/WebKitTools
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make commit-queue and style-queue show up in help
https://bugs.webkit.org/show_bug.cgi?id=31724
We need to store their names on their class to make these commands
properly register themselves with MultiCommandTool.
- Scripts/bugzilla-tool:
- 10:57 AM Changeset in webkit [51243] by
-
- 4 edits in trunk/WebKitTools
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement bugzilla-tool build-attachment
https://bugs.webkit.org/show_bug.cgi?id=31722
This command builds an attachment from bugzilla. It leaves the built
patch in the working copy.
- Scripts/bugzilla-tool:
- Scripts/modules/landingsequence.py:
- Scripts/modules/webkitlandingscripts.py:
- 10:40 AM Changeset in webkit [51242] by
-
- 7 edits in trunk/WebCore
Fixes <http://webkit.org/b/31699>.
Web Inspector: Should Cache Values of InspectorController.platform() and port().
Reviewed by Tim Hatcher.
Refactor the Inspector to cache the value of InspectorController.platform
and InspectorController.port, because those need to call into C++, they are
being called more and more as we add platform specific keyboard shortcuts, and
they shouldn't change in the lifecycle of the Web Inspector.
- inspector/front-end/AbstractTimelinePanel.js:
(WebInspector.AbstractTimelinePanel.prototype._updateFilter):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._updateFilter):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleKeyEvent):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._loaded):
- inspector/front-end/inspector.js:
(WebInspector.get platform):
(WebInspector.get port):
(WebInspector.loaded):
(WebInspector.documentKeyDown):
(WebInspector.toolbarDragStart):
- 9:53 AM Changeset in webkit [51241] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-11-20 Victor Wang <victorw@chromium.org>
Reviewed by Darin Adler.
Add expected pixel result for layout test input-file-re-render
- platform/mac/fast/forms/input-file-re-render-expected.checksum: Added.
- platform/mac/fast/forms/input-file-re-render-expected.png: Added.
- 9:49 AM Changeset in webkit [51240] by
-
- 8 edits in trunk/WebCore
2009-11-20 Dirk Schulze <krit@webkit.org>
Unreviewed build fix for filters enabled builds.
- platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
- platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
- platform/graphics/filters/SourceGraphic.cpp: (WebCore::SourceGraphic::apply):
- svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::applyFilter):
- svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
- svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
- 9:45 AM Changeset in webkit [51239] by
-
- 2 edits in trunk/WebKitTools
2009-11-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT release event does not create the state correctly
https://bugs.webkit.org/show_bug.cgi?id=31717
- WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
- 9:27 AM Changeset in webkit [51238] by
-
- 7 edits in trunk
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7389945> QTKit based media engine should not claim to support
fullscreen on Leopard
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::supportsFullscreen):
Only return true on SnowLeopard for now.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
No need to special case MediaFullscreenButtonPart as the default implementation
asks the media engine if it supports fullscreen.
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/7389945> QTKit based media engine should not claim to support fullscreen on Leopard
Update test results.
- platform/mac/media/audio-controls-rendering-expected.checksum:
- platform/mac/media/audio-controls-rendering-expected.png:
- platform/mac/media/audio-controls-rendering-expected.txt:
- 6:54 AM Changeset in webkit [51237] by
-
- 3 edits in trunk/WebKitTools
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
MultiCommandTool should find Command objects automatically instead of with a manual list
https://bugs.webkit.org/show_bug.cgi?id=31710
- Scripts/bugzilla-tool:
- Scripts/modules/multicommandtool.py:
- Use some wild python-fu to crawl all the known subclasses of Command.
- 6:45 AM Changeset in webkit [51236] by
-
- 2 edits in trunk/WebKitTools
2009-11-20 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix. Added missing import.
- Scripts/bugzilla-tool:
- 6:44 AM Changeset in webkit [51235] by
-
- 2 edits in trunk/WebKitTools
2009-11-20 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix. I failed to update LandingSequence.test
properly.
- Scripts/modules/landingsequence.py:
- 6:21 AM QtWebKitBackportingFixes created by
- 5:47 AM QtWebKitContrib edited by
- (diff)
- 4:29 AM QtWebKitJournal edited by
- (diff)
- 3:18 AM Changeset in webkit [51234] by
-
- 4 edits in trunk/WebCore
[Qt] Implement support for rendering plugins on Qt/Mac when a page is used
without a QWebView or when inside QGraphicsWebView.
Reviewed by Simon Hausmann.
Patch by Yongjun Zhang <yongjun.zhang@nokia.com> and
Girish Ramakrishnan <Girish Ramakrishnan>
Currently, the code provides the cgcontext of the PlatformPluginWidget to
the plugin. This approach does not work when we are printing, or using
QWebFrame::render() to render to a QImage/QPixmap since the plugin ends
up drawing on the QWebView (i.e platformPluginWidget's cgcontext) instead
of the QPaintDevice's context.
To solve all cases and keep the code simple, we render the plugin to an
offscreen pixmap in all cases. This way, the plugin always renders to the
CGContext of the pixmap and we then use QPainter to blit the pixmap into
the QPaintDevice. We also create a fake window and set it's WindowRef in
NPWindow. Only with this WindowRef does Flash paint correctly to the QPixmap.
Now, that's the theory. In practice, ATM, mouse events do not work when using
the fake window. So, setPlatformPluginWidget() is still called when using QWebView
so that there are no regressions after this patch. Once we get mouse events
working, setPlatformPluginWidget will be removed.
- 1:01 AM Changeset in webkit [51233] by
-
- 2 edits2 adds in trunk/WebKitTools
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Create LandingSequence as the all-sing, all-dance landing class
https://bugs.webkit.org/show_bug.cgi?id=31709
Client can inherit from this class to carefully control exactly which
steps they wish to have happen in the landing sequence.
- Scripts/bugzilla-tool:
- Scripts/modules/landingsequence.py: Added.
- Scripts/modules/webkitlandingscripts.py: Added.
